Hans Wennborg [Fri, 15 Nov 2019 08:48:50 +0000 (09:48 +0100)]
Fix GCC -Wcast-qual warnings
Hans Wennborg [Fri, 15 Nov 2019 08:46:44 +0000 (09:46 +0100)]
GCC 5.3 build fix
It was failing with
llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp:56:10:
error: could not convert ‘Obj’ from ‘std::unique_ptr<llvm::MemoryBuffer>’
to ‘llvm::Expected<std::unique_ptr<llvm::MemoryBuffer> >’
return Obj;
^
Matt Arsenault [Mon, 11 Nov 2019 09:16:38 +0000 (14:46 +0530)]
AMDGPU: Change boolean content type to 0 or 1
The usage of target boolean checks is overly inflexible, since sext
and zext of a compare are equally cheap. The choice is arbitrary, but
using 0/1 to some degree is the choice of lower resistance since
that's what most targets use. This enables a few combines that don't
bother to support ZeroOrNegativeOneBooleanContent.
Matt Arsenault [Thu, 14 Nov 2019 08:03:33 +0000 (13:33 +0530)]
AMDGPU: Try to commute sub of boolean ext
Avoids another regression in a future patch.
Matt Arsenault [Fri, 15 Nov 2019 06:29:12 +0000 (11:59 +0530)]
GlobalISel: Lower s1 source G_SITOFP/G_UITOFP
David Zarzycki [Fri, 15 Nov 2019 06:45:20 +0000 (08:45 +0200)]
Unbreak the clang test suite when hexagon-link is not available
All of the other tests are of the form {{hexagon-link|ld}} so this
probably should be too.
LLVM GN Syncbot [Fri, 15 Nov 2019 05:27:58 +0000 (05:27 +0000)]
gn build: Merge
16f38dda292
Lang Hames [Thu, 14 Nov 2019 23:58:21 +0000 (15:58 -0800)]
[ORC] Add a utility to support dumping JIT'd objects to disk for debugging.
Adds a DumpObjects utility that can be used to dump JIT'd objects to disk.
Instances of DebugObjects may be used by ObjectTransformLayer as no-op
transforms.
This patch also adds an ObjectTransformLayer to LLJIT and an example of how
to use this utility to dump JIT'd objects in LLJIT.
Seiya Nuta [Fri, 15 Nov 2019 03:37:55 +0000 (12:37 +0900)]
[llvm-objcopy][MachO] Implement --remove-section
Reviewers: alexshap, rupprecht, jhenderson
Reviewed By: rupprecht, jhenderson
Subscribers: jakehehrlich, abrachet, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D66282
Bruno Cardoso Lopes [Thu, 14 Nov 2019 21:44:18 +0000 (13:44 -0800)]
Add a test to cover structural match for recursive data types
This didn't use to work prior to r370639, now that this is supported
add a testcase to prevent regressions.
rdar://problem/
53602368
Francis Visoiu Mistrih [Fri, 15 Nov 2019 01:45:27 +0000 (17:45 -0800)]
[InstCombine] Don't use getFirstNonPHI in FoldIntegerTypedPHI
getFirstNonPHI iterates over all the instructions in a block until it
finds a non-PHI.
Then, the loop starts from the beginning of the block and goes through
all the instructions until it reaches the instruction found by
getFirstNonPHI.
Instead of doing that, just stop when a non-PHI is found.
This reduces the compile-time of a test case discussed in
https://reviews.llvm.org/D47023 by 13x.
Not entirely sure how to come up with a test case for this since it's a
compile time issue that would significantly slow down running the tests.
Differential Revision: https://reviews.llvm.org/D70016
Wang, Pengfei [Thu, 14 Nov 2019 07:12:07 +0000 (15:12 +0800)]
[WinEH] Fix the wrong alignment orientation during calculating EH frame.
Summary: This is a bug fix for further issues in PR43585.
Reviewers: rnk, RKSimon, craig.topper, andrew.w.kaylor
Subscribers: hiraditya, llvm-commits, annita.zhang
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70224
Davide Italiano [Thu, 14 Nov 2019 23:29:28 +0000 (15:29 -0800)]
[Utility] Remove a dead header [PPC64LE_ehframe_Registers.h]
Reid Kleckner [Thu, 14 Nov 2019 23:15:48 +0000 (15:15 -0800)]
Add missing includes needed to prune LLVMContext.h include, NFC
These are a pre-requisite to removing #include "llvm/Support/Options.h"
from LLVMContext.h: https://reviews.llvm.org/D70280
Marek Kurdej [Thu, 14 Nov 2019 23:12:34 +0000 (00:12 +0100)]
[libc++] [P0920] [P1661] Update status page.
Jonas Devlieghere [Thu, 14 Nov 2019 22:30:11 +0000 (14:30 -0800)]
[LLDB] Fix more -Wdocumentation issues (NFC)
Reid Kleckner [Thu, 14 Nov 2019 22:27:48 +0000 (14:27 -0800)]
[COFF] Avoid CodeView include in header
Most LLD/COFF files don't care about CodeView. Avoid using CodeView
types in InputFiles.h.
Reid Kleckner [Thu, 14 Nov 2019 22:16:21 +0000 (14:16 -0800)]
Forward declare the DWARFCache to avoid including LLVM DWARF details
LLD's DWARF.h header leaks a lot of LLVM DWARF includes that LLD doesn't
need. For Chunks.cpp, I see a compile time decrease of 3.1s to 2.7s.
Jonas Devlieghere [Thu, 14 Nov 2019 19:11:37 +0000 (11:11 -0800)]
[Reproducer] Enable crash reports for reproducer tests
For some reason the reproducer tests seem really proficient at
uncovering structural issues in LLDB related to how we tear down things,
but of course only on the bots.
The pretty stack trace helps a bit, but what I really want is the crash
reports which contain much more information, such as what other threads
we doing.
Crash reports are automatically suppressed by lit. This patch
(temporarily) disables that for the reproducer tests.
Yonghong Song [Thu, 14 Nov 2019 18:34:35 +0000 (10:34 -0800)]
[BPF] Restrict preserve_access_index attribute to C only
This patch is a follow-up for commit
4e2ce228ae79
[BPF] Add preserve_access_index attribute for record definition
to restrict attribute for C only. A new test case is added
to check for this restriction.
Additional code polishing is done based on
Aaron Ballman's suggestion in https://reviews.llvm.org/D69759/new/.
Differential Revision: https://reviews.llvm.org/D70257
Dan Liew [Tue, 29 Oct 2019 00:53:38 +0000 (17:53 -0700)]
[SanitizerCommon] Print the current value of options when printing out help.
Summary:
Previously it wasn't obvious what the default value of various sanitizer
options were. A very close approximation of the "default values" for the
options are the current value of the options at the time of printing the
help output.
In the case that no other options are provided then the current values
are the default values (apart from `help`).
```
ASAN_OPTIONS=help=1 ./program
```
This patch causes the current option values to be printed when the
`help` output is enabled. The original intention for this patch was to append
`(Default: <value>)` to an option's help text. However because this
is technically wrong (and misleading) I've opted to append
`(Current Value: <value>)` instead.
When trying to implement a way of displaying the default value of the
options I tried another solution where the default value used in `*.inc` files
were used to create compile time strings that where used when printing
the help output. This solution was not satisfactory for several reasons:
* Stringifying the default values with the preprocessor did not work very
well in several cases. Some options contain boolean operators which no
amount of macro expansion can get rid of.
* It was much more invasive than this patch. Every sanitizer had to be changed.
* The settings of `__<sanitizer>_default_options()` are ignored.
For those reasons I opted for the solution in this patch.
rdar://problem/
42567204
Reviewers: kubamracek, yln, kcc, dvyukov, vitalybuka, cryptoad, eugenis, samsonov
Subscribers: #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D69546
Reid Kleckner [Thu, 14 Nov 2019 21:46:00 +0000 (13:46 -0800)]
[COFF] Don't include llvm/LTO/LTO.h in a header
LLVM's LTO header includes all of llvm/IR, which most of the COFF linker
doesn't need.
Alexey Bataev [Thu, 14 Nov 2019 19:35:28 +0000 (14:35 -0500)]
Revert "Temporarily Revert:"
This reverts commit
e511c4b0dff1692c267addf17dce3cebe8f97faa:
Temporarily Revert:
"[SLP] Generalization of stores vectorization."
"[SLP] Fix -Wunused-variable. NFC"
"[SLP] Vectorize jumbled stores."
after fixing the problem with compile time.
Matthew Voss [Thu, 14 Nov 2019 20:33:52 +0000 (12:33 -0800)]
[llvm-dis] Fix the disable-output flag
My change in llvmorg-10-init-9872-g141bb5f308f broke this flag.
Thanks to @rsmith for the bug.
Michael Kruse [Thu, 14 Nov 2019 21:17:16 +0000 (15:17 -0600)]
[GPGPU] Fix depricated warning.
setAlignment(unsigned) was deprecated in commit:
0e62011df891d0e7ad904524edf705d07d12d5d4
[Alignment][NFC] Remove dependency on GlobalObject::setAlignment(unsigned)
Craig Topper [Thu, 14 Nov 2019 21:21:35 +0000 (13:21 -0800)]
[X86] Fix the implementation of __readcr3/__writecr3 to work in 64-bit mode
We need to use a 64-bit type in 64-bit mode so a 64-bit register
will get used in the generated assembly. I've also changed the
constraints to just use "r" intead of "q". "q" forces to a only
an a/b/c/d register in 32-bit mode, but I see no reason that
would matter here.
Fixes Nico's note in PR19301 over 4 years ago.
Differential Revision: https://reviews.llvm.org/D70101
Vedant Kumar [Thu, 14 Nov 2019 17:20:58 +0000 (09:20 -0800)]
[DebugInfo] Allow spill slots in call site parameter descriptions
Allow call site paramter descriptions to reference spill slots. Spill
slots are not visible to high-level LLVM IR, so they can safely be
referenced during entry value evaluation (as they cannot be clobbered by
some other function).
This gives a 5% increase in the number of call site parameter DIEs in an
LTO x86_64 build of the xnu kernel.
This reverts commit
eb4c98ca3d2590bad9f6542afbf3a7824d2b53fa (
[DebugInfo] Exclude memory location values as parameter entry values),
effectively reintroducing the portion of D60716 which dealt with memory
locations (authored by Djordje, Nikola, Ananth, and Ivan).
This partially addresses llvm.org/PR43343. However, not all memory
operands forwarded to callees live in spill slots. In the xnu build, it
may be possible to use an escape analysis to increase the number of call
site parameter by another 15% (more details in PR43343).
Differential Revision: https://reviews.llvm.org/D70254
Sergey Dmitriev [Thu, 14 Nov 2019 20:31:13 +0000 (12:31 -0800)]
[yaml2obj][COFF] Add support for extended relocation tables
Summary:
The tool does not correctly handle COFF sections with extended relocation tables (with IMAGE_SCN_LNK_NRELOC_OVFL bit set), this patch fixes this problem.
But I have cheated a bit in the test (to make it smaller) because extended relocation table is supposed to be used when the number of relocations exceeds 65534. Otherwise the test size would be pretty big.
Reviewers: jhenderson, MaskRay, mstorsjo
Reviewed By: mstorsjo
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70251
Michael Kruse [Thu, 14 Nov 2019 20:34:39 +0000 (14:34 -0600)]
[GPGPU] Fix #includes.
Adapt for
05da2fe52162 "Sink all InitializePasses.h includes" which
forgot the GPGPU files (presumably because POLLY_ENABLE_GPGPU_CODEGEN
is OFF by default).
Daniel Sanders [Thu, 14 Nov 2019 20:11:00 +0000 (12:11 -0800)]
[globalisel][irtanslator] The IRTranslator should preserve TBAA information
Jordan Rupprecht [Tue, 12 Nov 2019 19:37:23 +0000 (11:37 -0800)]
[lldb][Editline] Support ctrl+left/right arrow word navigation.
Summary:
This adds several 5C/5D escape codes that allow moving forward/backward words similar to bash command line navigation.
On my terminal, `ctrl+v ctrl+<left arrow>` prints `^[[1;5D`. However, it seems inputrc also maps other escape variants of this to forward/backward word, so I've included those too. Similar for 5C = ctrl+right arrow.
Reviewers: JDevlieghere, labath
Reviewed By: JDevlieghere, labath
Subscribers: merge_guards_bot, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70137
Paul Robinson [Thu, 14 Nov 2019 16:56:32 +0000 (08:56 -0800)]
Fix up lit's tests to run in a multi-config build environment.
Differential Revision: https://reviews.llvm.org/D70239
Sumanth Gundapaneni [Thu, 14 Nov 2019 19:08:06 +0000 (13:08 -0600)]
[Pipeliner] Fix an assertion caused by iterator invalidation.
Sumanth Gundapaneni [Thu, 14 Nov 2019 19:01:16 +0000 (13:01 -0600)]
[Hexagon] Validate the iterators before converting them to mux.
The conditional instructions that are translated to mux instructions
are deleted and the iterators to these deleted instructions are being
used later. This patch fixed this issue.
Sumanth Gundapaneni [Thu, 14 Nov 2019 18:59:15 +0000 (12:59 -0600)]
[Hexagon] Fix clang driver to parse -mcpu/-mvXX and -march properly.
Before this patch if we pass "-mcpu=hexagonv65 -march=hexagon" in this order,
the driver fails to figure out the correct cpu version. This patch fixed this
issue.
Sumanth Gundapaneni [Thu, 14 Nov 2019 18:40:10 +0000 (12:40 -0600)]
Update lit infra to detect "MemoryWithOrigins' sanitizer build.
Differential Revision: https://reviews.llvm.org/D68399
Sam Elliott [Thu, 14 Nov 2019 18:42:33 +0000 (18:42 +0000)]
[RISCV] Use addi rather than add x0
Summary:
The RISC-V backend used to generate `add <reg>, x0, <reg>` in a few
instances. It seems most places no longer generate this sequence.
This is semantically equivalent to `addi <reg>, <reg>, 0`, but the
latter has the advantage of being noted to be the canonical instruction
to be used for moves (which microarchitectures can and should recognise
as such).
The changed testcases use instruction aliases - `mv <reg>, <reg>` is an
alias for `addi <reg>, <reg>, 0`.
Reviewers: luismarques
Reviewed By: luismarques
Subscribers: hiraditya, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, s.egerton, pzheng, sameer.abuasal, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70124
Matthew Voss [Wed, 13 Nov 2019 00:29:37 +0000 (16:29 -0800)]
Add support for multi-module bitcode files to llvm-dis
Summary:
This change allows llvm-dis to disassemble multi-module bitcode
files, including the associated module summary.
Reviewers: tejohnson, pcc, mehdi_amini
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70153
Sergey Dmitriev [Thu, 14 Nov 2019 17:50:36 +0000 (09:50 -0800)]
[llvm-objcopy][COFF] Add support for extended relocation tables
Summary: This patch adds support for COFF objects with extended relocation tables to the llvm-objcopy tool.
Reviewers: jhenderson, MaskRay, mstorsjo, alexshap, rupprecht
Reviewed By: mstorsjo
Subscribers: jakehehrlich, abrachet, seiya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70205
Luís Marques [Thu, 14 Nov 2019 18:27:42 +0000 (18:27 +0000)]
[RISCV] Fix wrong CFI directives
Summary: Removes CFI CFA directives that could incorrectly propagate
beyond the basic block they were inteded for. Specifically it removes
the epilogue CFI directives. See the branch_and_tail_call test for an
example of the issue. Should fix the stack unwinding issues caused by
the incorrect directives.
Reviewers: asb, lenary, shiva0217
Reviewed By: lenary
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69723
Craig Topper [Thu, 14 Nov 2019 18:02:51 +0000 (10:02 -0800)]
[ExpandReductions] Don't push all intrinsics to the worklist. Just push reductions.
We were previously pushing all intrinsics used in a function to the
worklist. This is wasteful for memory in a function with a lot of
intrinsics.
We also ask TTI if we should expand every intrinsic, but we only
have expansion support for the reduction intrinsics. This just
wastes time for the non-reduction intrinsics.
This patch only pushes reduction intrinsics into the worklist and
skips other intrinsics.
Differential Revision: https://reviews.llvm.org/D69470
Mitchell Balan [Thu, 14 Nov 2019 18:18:34 +0000 (13:18 -0500)]
[clang-format] Fixed edge-case with SpacesInSquareBrackets with trailing bare "&" lambda capture.
Summary:
Lambda captures allow for a lone `&` capture, so `&]` needs to be properly handled.
`int foo = [& ]() {}` is fixed to give `int foo = [ & ]() {}`
Reviewers: MyDeveloperDay
Reviewed by: MyDeveloperDay
Subscribers: cfe-commits
Tags: #clang, #clang-format
Differential Revision: https://reviews.llvm.org/D70249
Reid Kleckner [Thu, 14 Nov 2019 18:19:36 +0000 (10:19 -0800)]
Replace wrongly deleted header banner, fix formatting
I reviewed the diff hunks of
05da2fe52162c80dfa that don't contain
'#include' lines, and found two unintended changes. I deleted a header
banner inadvertently while inserting a header, and changed the
indentation of a constructor in an odd way. Add back the banner, and
reformat the constructor.
Tom Stellard [Thu, 14 Nov 2019 17:18:44 +0000 (09:18 -0800)]
[cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows
Summary:
The BUILD_SHARED_LIBS=ON build fails on Windows, so prevent users from
enabling it.
Reviewers: beanz, smeenai, compnerd, phosek
Reviewed By: beanz
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70161
Kevin P. Neal [Thu, 14 Nov 2019 18:11:54 +0000 (13:11 -0500)]
Document more specifically the rounding for "llvm.round".
Differential Revision: https://reviews.llvm.org/D68810
Sanjay Patel [Thu, 14 Nov 2019 17:06:50 +0000 (12:06 -0500)]
[InstCombine] remove duplicate code for simplifying a shuffle; NFCI
The transform is already handled by InstSimplify or earlier
in InstCombine, so trying to do it again is not necessary.
Kevin P. Neal [Thu, 10 Oct 2019 16:24:51 +0000 (12:24 -0400)]
Make the language more consistent since I'm about to commit a content
change next.
Reid Kleckner [Wed, 13 Nov 2019 19:25:42 +0000 (11:25 -0800)]
[clang-include-fixer] Skip .rc files when finding symbols
Summary:
For some reason CMake includes entries for .rc files, but
find-all-symbols handles them improperly.
See PR43993
Reviewers: sammccall, bkramer
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70196
Alexey Bataev [Thu, 14 Nov 2019 17:58:49 +0000 (12:58 -0500)]
[OPENMP]Add assignment operator in UDR test, NFC.
Add assignment operator in the test to check that even if the operator
was declare explicitly, the constructor is called in the user-defined
reduction initializer anyway.
Adrian Prantl [Thu, 14 Nov 2019 17:55:24 +0000 (09:55 -0800)]
Fix incorrect comment.
Adrian Prantl [Thu, 14 Nov 2019 17:38:49 +0000 (09:38 -0800)]
Convert condition to early exit (NFC)
Adrian Prantl [Thu, 14 Nov 2019 17:35:06 +0000 (09:35 -0800)]
Convert UpdateExternalModuleListIfNeeded to use early exits.
Adrian Prantl [Thu, 14 Nov 2019 17:13:04 +0000 (09:13 -0800)]
Rename DWO -> Clang module to avoid confusion. (NFC)
Jonas Devlieghere [Thu, 14 Nov 2019 17:02:35 +0000 (09:02 -0800)]
[LLDB] Make a clear distinction between usage & development docs
This renames the "Goals & Status" section to "Project" and the
"Resources" section to "Development". To better match this layout I've
moved the releases page under "Project".
Adrian Prantl [Thu, 14 Nov 2019 16:57:32 +0000 (08:57 -0800)]
Use ForEachExternalModule in ParseTypeFromClangModule (NFC)
I wanted to further simplify ParseTypeFromClangModule by replacing the
hand-rolled loop with ForEachExternalModule, and then realized that
ForEachExternalModule also had the problem of visiting the same leaf
node an exponential number of times in the worst-case. This adds a set
of searched_symbol_files set to the function as well as the ability to
early-exit from it.
Differential Revision: https://reviews.llvm.org/D70215
Scott Linder [Wed, 13 Nov 2019 17:31:50 +0000 (12:31 -0500)]
[AMDGPU][HIP] Change default DWARF version to 4
Summary:
Tooling around DWARF 5 is still not mature enough for this to be a sane
default, and the AMDGPU and HIP toolchains should agree on a single
default.
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, aprantl, dstuttard, tpr, t-tye, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70191
Adrian McCarthy [Thu, 7 Nov 2019 18:50:33 +0000 (10:50 -0800)]
Improve VFS compatibility on Windows
Keys in a virtual file system can be in Posix or Windows form or even
a combination of the two. Many VFS tests (and a few Clang tests) were
XFAILed on Windows because of false negatives when comparing paths.
First, we default CaseSenstive to false on Windows. This allows
drive letters like "D:" to match "d:". Windows filesystems are, by
default, case insensitive, so this makes sense even beyond the drive
letter.
Second, we allow slashes to match backslashes when they're used as the
root component of a path.
Both of these changes are limited to RedirectingFileSystems, so there's
little chance of affecting other path handling.
These changes allow eleven of the VFS tests to pass on Windows as well
as three other Clang tests, so they have re-enabled.
This solves the majority of PR43272. Additional VFS test failures will
be fixed in separate patches.
Differential Revision: https://reviews.llvm.org/D69958
Sam McCall [Wed, 13 Nov 2019 19:16:23 +0000 (20:16 +0100)]
[clangd] Ignore more implicit nodes in computing selection.
Summary:
The DeclRefExpr for the callee of overloaded `operator()` and `operator[]` are
assigned the range of the paren/bracket lists in the AST.
These are better thought of as implicit (at least `()` - `[] is murkier).
But there's no bit on Expr for implicit, so just ignore them on our side.
While here, deal with the case where an implicit stmt (e.g. implicit-this)
is wrapped in an implicit cast. Previously we ignored the statement but not
the cast, and so the cast ended up being selected.
Fixes https://github.com/clangd/clangd/issues/195
Reviewers: kadircet, lh123
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70194
Sam McCall [Wed, 13 Nov 2019 21:24:17 +0000 (22:24 +0100)]
[clangd] Expose value of enumerators to Hover API. (not UI yet)
Summary: This is part of https://github.com/clangd/clangd/issues/180.
Reviewers: kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70209
Lang Hames [Wed, 13 Nov 2019 17:13:03 +0000 (09:13 -0800)]
[ADT] Move drop_begin from iterator_range.h into STLExtras.
Summary:
drop_begin depends on adl_begin/adl_end, which are defined in STLExtras.h,
but we can't just #include STLExtras.h in iterator_range.h as that would
introduce a circular reference (STLExtras.h already depends on
iterator_range.h). The simplest solution is to move drop_begin into
STLExtras.h, which is a reasonable home for it anyway.
Reviewers: dblaikie
Subscribers: dexonsmith, ributzka, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70189
Adam Balogh [Fri, 8 Nov 2019 11:52:09 +0000 (12:52 +0100)]
[Analyzer][NFC] Separate white-box tests for iterator modelling from iterator checker tests
The recently committed debug.IteratorDebugging checker enables
standalone white-box testing of the modelling of containers and
iterators. For the three checkers based on iterator modelling only
simple tests are needed.
Differential Revision: https://reviews.llvm.org/D70123
Pavel Labath [Thu, 14 Nov 2019 15:16:25 +0000 (16:16 +0100)]
[lldb] Fix dwo variant of TestLibCxxFunction
The test was failing due to a bug in SymbolFileDWARF::FindFunctions --
the function was searching the main dwarf unit for DW_TAG_subprograms,
but the main unit is empty in case of split dwarf. The fix is simple --
search the non-skeleton unit instead.
This bug went unnoticed because this function is expensive, and so one
generally avoids calling it.
Sanjay Patel [Thu, 14 Nov 2019 15:20:48 +0000 (10:20 -0500)]
[InstCombine] regenerate test CHECKs; NFC
There's a discussion about changing a shufflevector
transform in:
https://bugs.llvm.org/show_bug.cgi?id=43958
It would protect against our current undef/poison
behavior, and these are all tests that could be affected.
Benjamin Kramer [Thu, 14 Nov 2019 15:07:13 +0000 (16:07 +0100)]
Revert "[ThinLTO] Add correctness check for RO/WO variable import"
This reverts commit
a2292cc537b561416c21e8d4017715d652c144cc. Breaks
clang selfhost w/ThinLTO.
Ed Maste [Wed, 13 Nov 2019 18:24:23 +0000 (13:24 -0500)]
On FreeBSD use AT_EXECPATH from ELF auxiliary vectors for getExecutablePath
/proc/curproc/file and the KERN_PROC_PATHNAME sysctl may not return the
desired path if there are multiple hardlinks to the file, or if the path has
expired from the namecache.
Reviewed By: theraven
Differential Revision: https://reviews.llvm.org/D70198
Tim Northover [Thu, 14 Nov 2019 13:26:53 +0000 (13:26 +0000)]
ARM: allow rewriting frame indexes for all prefetch variants.
For some reason we could handle PLD but not PLDW or PLI, but all of them can
potentially refer to the stack region (if weirdly for PLI).
Simon Pilgrim [Thu, 14 Nov 2019 13:55:28 +0000 (13:55 +0000)]
GCOVProfiling - fix uninitialized variable warnings + make getFuncChecksum() const. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:54:29 +0000 (13:54 +0000)]
WholeProgramDevirt - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:53:35 +0000 (13:53 +0000)]
Fix uninitialized variable warning. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:52:46 +0000 (13:52 +0000)]
Fix uninitialized variable warning. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:52:02 +0000 (13:52 +0000)]
SROA - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:50:38 +0000 (13:50 +0000)]
Fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:47:22 +0000 (13:47 +0000)]
Hexagon - fix uninitialized variable warnings. NFCI.
Simon Pilgrim [Thu, 14 Nov 2019 13:32:40 +0000 (13:32 +0000)]
MSP430 - fix uninitialized variable warnings. NFCI.
Louis Dionne [Thu, 14 Nov 2019 14:07:05 +0000 (09:07 -0500)]
[libc++][P1872] span should have size_type, not index_type.
Thanks to Marek Kurdej for the patch.
Differential Revision: https://reviews.llvm.org/D70206
Louis Dionne [Thu, 14 Nov 2019 13:54:23 +0000 (08:54 -0500)]
[libc++] [P1612] Add missing feature-test macro __cpp_lib_endian.
Thanks to Marek Kurdej for the patch.
Differential Revision: https://reviews.llvm.org/D70221
Kerry McLaughlin [Thu, 14 Nov 2019 13:29:57 +0000 (13:29 +0000)]
[AArch64][SVE] Implement floating-point comparison & reduction intrinsics
Summary:
Adds intrinsics for the following:
- fadda & faddv
- fminv, fmaxv, fminnmv & fmaxnmv
- facge & facgt
- fcmp[eq|ge|gt|ne|uo]
Reviewers: sdesmalen, huntergr, dancgr, mgudim
Reviewed By: sdesmalen
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, cameron.mcinally, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69858
Ilya Biryukov [Thu, 14 Nov 2019 13:43:07 +0000 (14:43 +0100)]
[clangd] Simplify the code in Index::refs
Summary:
While here, also fix potential UB in MergeIndex.
Thanks Kadir for finding this!
Reviewers: hokein
Reviewed By: hokein
Subscribers: merge_guards_bot, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70225
Sjoerd Meijer [Thu, 14 Nov 2019 13:10:44 +0000 (13:10 +0000)]
[LV] PreferPredicateOverEpilog respecting predicate loop hint
The vectoriser queries TTI->preferPredicateOverEpilogue to determine if
tail-folding is preferred for a loop, but it was not respecting loop hint
'predicate' that can disable this, which has now been added. This showed that
we were incorrectly initialising loop hint 'vectorize.predicate.enable' with 0
(i.e. FK_Disabled) but this should have been FK_Undefined, which has been
fixed.
Differential Revision: https://reviews.llvm.org/D70125
Paweł Bylica [Thu, 14 Nov 2019 12:37:15 +0000 (13:37 +0100)]
[DAGCombiner] Drop redundant DAG method param. NFC
Paweł Bylica [Thu, 14 Nov 2019 11:44:57 +0000 (12:44 +0100)]
[DAGCombiner] Use TLI field already available. NFC
Raphael Isemann [Thu, 14 Nov 2019 12:36:09 +0000 (13:36 +0100)]
Modernize llvm::Error handling in ExternalASTMerger
JonChesterfield [Thu, 14 Nov 2019 12:43:56 +0000 (12:43 +0000)]
[libomptarget][nfc] Use cuda variable wrappers from support.h
Summary:
[libomptarget][nfc] Use cuda variable wrappers from support.h
Reimplementation of D69693, after the revert of D69885
Use the wrappers in support.h for cuda builtin variables at all call sites.
Localises use of cuda and removes WARPSIZE==32 assumption in debug.h.
Reviewers: ABataev, jdoerfert, grokos
Reviewed By: jdoerfert
Subscribers: openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D70186
Miloš Stojanović [Thu, 14 Nov 2019 11:52:56 +0000 (12:52 +0100)]
[mips][NFC] Remove old FIXME comment
This was fixed in rL229595 but this comment was missed.
Differential Revision: https://reviews.llvm.org/D70231
Kerry McLaughlin [Thu, 14 Nov 2019 11:59:00 +0000 (11:59 +0000)]
[AArch64][SVE] Implement remaining floating-point arithmetic intrinsics
Summary:
Adds intrinsics for the following:
- fabs & fneg
- fexpa
- frint[a|i|m|n|p|x|z]
- frecpe, frecps & frecpx
- fsqrt, frsqrte & frsqrts
Reviewers: huntergr, sdesmalen, dancgr, mgudim
Reviewed By: sdesmalen
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, cameron.mcinally, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69800
Kerry McLaughlin [Thu, 14 Nov 2019 11:35:38 +0000 (11:35 +0000)]
[AArch64][SVE] Implement additional floating-point arithmetic intrinsics
Summary:
Adds intrinsics for the following:
- ftssel
- fcadd, fcmla
- fmla, fmls, fnmla, fnmls
- fmad, fmsb, fnmad, fnmsb
Reviewers: sdesmalen, huntergr, dancgr, mgudim
Reviewed By: sdesmalen
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, cameron.mcinally, cfe-commits, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69707
Diana Picus [Thu, 14 Nov 2019 10:53:53 +0000 (11:53 +0100)]
Fix typos in docs. NFC
QingShan Zhang [Thu, 14 Nov 2019 10:55:49 +0000 (10:55 +0000)]
[NFC] Add one test for PowerPC to verify the sext_inreg for vector type.
Kevin Petit [Wed, 13 Nov 2019 09:29:10 +0000 (09:29 +0000)]
Fix use of add_llvm_tool in projects that build no targets
Projects that set LLVM_TARGETS_TO_BUILD to an empty list
can't use add_llvm_tool (and probably other macros).
Here's the error that this change fixes:
list sub-command REMOVE_ITEM requires two or more arguments.
https://reviews.llvm.org/D70167
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Daniil Suchkov [Thu, 14 Nov 2019 10:42:01 +0000 (17:42 +0700)]
Revert "[InstCombine] Fold PHIs with equal incoming pointers"
This reverts commit
a2f6ae9abffcba260c22bb235879f0576bf3b783.
It is reverted due to clang-cmake-armv7-selfhost buildbot failure.
Raphael Isemann [Thu, 14 Nov 2019 10:11:20 +0000 (11:11 +0100)]
[lldb] Fix that trailing backslashes in source lines break the Clang highlighter
Summary:
Clang's raw Lexer doesn't produce any tokens for trailing backslashes in a line. This doesn't work with
LLDB's Clang highlighter which builds the source code to display from the list of tokens the Lexer returns.
This causes that lines with trailing backslashes are lacking the backslash and the following newline when
rendering source code in LLDB.
This patch removes the trailing newline from the current line we are highlighting. This way Clang doesn't
drop the backslash token and we just restore the newline after tokenising.
Fixes rdar://
57091487
Reviewers: JDevlieghere, labath
Reviewed By: JDevlieghere, labath
Subscribers: labath, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70177
Daniil Suchkov [Thu, 14 Nov 2019 08:25:31 +0000 (15:25 +0700)]
[InstCombine] Fold PHIs with equal incoming pointers
This is a resubmission of
bbb29738b58aaf6f6518269abdcf8f64131665a9 that
was reverted due to clang tests failures. It includes the fix and
additional IR tests for the missed case.
Summary:
In case when all incoming values of a PHI are equal pointers, this
transformation inserts a definition of such a pointer right after
definition of the base pointer and replaces with this value both PHI and
all it's incoming pointers. Primary goal of this transformation is
canonicalization of this pattern in order to enable optimizations that
can't handle PHIs. Non-inbounds pointers aren't currently supported.
Reviewers: spatel, RKSimon, lebedev.ri, apilipenko
Reviewed By: apilipenko
Tags: #llvm
Subscribers: hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D68128
Djordje Todorovic [Thu, 14 Nov 2019 07:32:03 +0000 (08:32 +0100)]
[AArch64][DebugInfo] Fix incorrect call site param value produced by MOVZXi
This resolves the problem with the truncation of the immediate operand.
Differential Revision: https://reviews.llvm.org/D70168
Anna Welker [Thu, 14 Nov 2019 09:43:26 +0000 (09:43 +0000)]
[NFC] Fix typo in ARMBaseRegisterInfo
evgeny [Thu, 14 Nov 2019 09:24:05 +0000 (12:24 +0300)]
[ThinLTO] Add correctness check for RO/WO variable import
This patch adds an assertion check for exported read/write-only
variables to be also in import list for module. If they aren't
we may face linker errors, because read/write-only variables are
internalized in their source modules. The patch also changes
export lists to store ValueInfo instead of GUID for performance
considerations.
Differential revision: https://reviews.llvm.org/D70128
Pavel Labath [Tue, 12 Nov 2019 10:36:19 +0000 (11:36 +0100)]
DWARFDebugLoclists: stricter base address handling
Summary:
This removes the use of zero as a base address in section-based dumping.
Although this will often be true for (unlinked) object files with a
single compile unit, it is not true in general. This means that
section-based dumping will not be able to resolve entries referencing
the base address (DW_LLE_offset_pair) -- it wasn't able to do that
correctly before either, but now it will be more explicit about it. One
exception to that is if the location list contains an explicit
DW_LLE_base_address entry -- in this case the dumper will pick it up,
and resolve subsequent entries normally.
The patch also removes the fallback to zero in the "inline" dumping in
case the compile unit does not contain a base address.
Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70115
Raphael Isemann [Thu, 14 Nov 2019 08:47:10 +0000 (09:47 +0100)]
[lldb][NFC] Simplify IOHandler constructor/destructor setup
We only need a default constructor because of DISALLOW_COPY_AND_ASSIGN,
but the non-virtual destructor isn't needed.
Muhammad Omair Javaid [Thu, 14 Nov 2019 08:53:51 +0000 (13:53 +0500)]
[LLDB] Fix whitespace/tabs mismatch in lldbsuite Makefile.rules
This patch fixes whitespace/tabs mismatch in
lldb/packages/Python/lldbsuite/test/make/Makefile.rules
Legacy make files always used tabs though modern make version can
work with white-spaces I have chosen the legacy just to be safe.
Signed-off-by: Muhammad Omair Javaid <omair.javaid@linaro.org>
Differential Revision: https://reviews.llvm.org/D70154
Puyan Lotfi [Thu, 14 Nov 2019 08:39:16 +0000 (03:39 -0500)]
[clang][IFS][test] Reverting driver-test.c to what it was prior to
e782192d5e6
My mistake. Changes I had in this test were for code changes that are
not landed yet. I am reverting driver-test.c back to what it was
originally.
Puyan Lotfi [Thu, 14 Nov 2019 07:41:28 +0000 (02:41 -0500)]
[clang][IFS][test] Removing -shared, fixing triple: driver-test.c/windows.cpp.
Removing -shared as it is not used on a lot of targets in order to green failing
bots with this change. Also, tiding up the windows.cpp test as the
triple compile out can look slightly different that what you specified
on a windows bot.