dEQP-VK.graphicsfuzz.return-float-from-while-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.return-float-from-while-loop

Change-Id: Ic3d8f5f7ec29de0e9af677a13b68f390fe40256d

dEQP-VK.graphicsfuzz.uninitialized-var-decrement-and-add

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.uninitialized-var-decrement-and-add

Change-Id: Iacb6064282253a8107d3d3aee04d133ab36503d7

dEQP-VK.graphicsfuzz.returned-boolean-in-vector

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.returned-boolean-in-vector

Change-Id: I6976dd7e81ee6056cd28ed8cc23846bac2a35ebe

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I2db83dc66e6f9b7bc98171060d27192ea8353e7a

dEQP-VK.graphicsfuzz.always-false-if-in-do-while

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.always-false-if-in-do-while

Change-Id: I31714d74ce659d0c2a78f279d3477aafdfc7c6c1

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I592b6674f5e3a5a1f2a6d050dcc7263b0e5d682c

dEQP-VK.graphicsfuzz.for-loop-with-return

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.for-loop-with-return

Change-Id: I567181e35ed9effa60edb390019cf75a8ec6eb43

dEQP-VK.graphicsfuzz.two-nested-infinite-loops-discard

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.two-nested-infinite-loops-discard

Change-Id: I10f80a5b5640b209c9dfb0b612ab232735cda7e2

Add missing write to PointSize

The primitive topology is POINT_LIST for test cases covering the vertex
stage, but the vertex shader in these cases isn't supplying a value for
PontSize.

Affects:

dEQP-VK.binding_model.buffer_device_address.*.vert

Components: Vulkan

VK-GL-CTS issue: 2080

Change-Id: Ibbbeb143bf957f9494b1df84e69bc4a01c891c6a

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: Ic181ad20201d78dc31564319ab56cbb4323de1c9

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I34ada51e1b9c00280fb9f9d60463989e05f11953

Add timelineSempahore to mandatory ext features

https://gitlab.khronos.org/vulkan/vulkan/merge_requests/3421
clarifies that timelineSemaphore is mandatory for
implementations exposing VK_KHR_timeline_semaphore

This CL updates the test to align with the MR.

Components: Vulkan

Affects: dEQP-VK.api.info.device.mandatory_features

Change-Id: I12f9c9e6b05a77109cb0207b748cc9ccfa872d9b
(cherry picked from commit 33cc61974078e64d66e64ccf67ecc906f7a7f3fb)

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I67e8f8fc2b64060fca9e5a8016cf7d5b53ec5477

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I3fd2e50726e016645834052ba95fa761f84c5686

Fix check in testMandatoryExtensions

Affects:
dEQP-VK.api.info.android.mandatory_extensions

Change-Id: Iec3b405cb168daa7dd7fc2183963778ef7d6eb0b
Components: Vulkan

Remove deprecated std::bind2nd() call

std::bind2nd() was deprecated in C++11 and removed in C++17.

Affects:
dEQP-VK.descriptor_indexing.*

Components: Vulkan

VK-GL-CTS issue: 2074

Change-Id: I408a39ce9f1632515e3ff6bcfb95966e19aa4b22

Test multiple overlapping cube maps

Test cube map images containing multiple overlapping cube maps.

Add tests:
 * dEQP-VK.image.misaligned_cube.*

Components: vulkan

VK-GL-CTS issue: 1889

Change-Id: I24eeba1eea1513e51cc3c4cd0b23d18e3ce8234d

Special-case RenderbufferStorageMultisampleEXT in codegen

Android has additional tests for this ES extension, which we had
observed was shipping broken on various Android devices. Unfortunately,
the ES extension which introduces this function specifies very different
semantics from the same-named function in desktop GL. In desktop GL,
this function is also defined to alias the core
RenderbufferStorageMultisample, and is assigned the same GLX opcode.

We had previously tried to unalias the function in the registry, but
that proved unworkable due to the GLX opcode aliasing.

Instead, add a special case in the CTS code generation.

Change-Id: Id62394cae2b2f01e0a91fdc4d9d357b634a26cf1
Components: Framework

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I21178b89019aad73d0b1862e10d5590361fcdcc8

Add scissor matching renderArea to descriptor indexing tests

This fixes rendering outside of render area, what
is forbidden by spec.

This also fixes regression from 7b7ba4e0, where
looping the RenderPass caused workload execution time
to increase and trigger OS-specific device timeout.

Components: Vulkan

VK-GL-CTS Issue: 2069

Affects: dEQP-VK.descriptor_indexing.*

Change-Id: I40f665ff892d03004860583029eb393e09c1ae95

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I563fc81549024a61aadc779285e8d4686c9c931a

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I365220265de5dd5b239cca76b1ffcd0221404824

Remove 16-bit storage from float16 vector tests

Replace loads and stores of float16s with specialized function to
reinterpret as appropriate uints for vector extract dynamic, vector
insert dynamic and vector shuffle tests.

Component: Vulkan

VK-GL-CTS Issue: 1931

Affects:
dEQP-VK.spirv_assembly.instruction.*.float16.opvectorextractdynamic*
dEQP-VK.spirv_assembly.instruction.*.float16.opvectorinsertdynamic*
dEQP-VK.spirv_assembly.instruction.*.float16.opvectorshuffle*

Change-Id: I1757d2dc3dd8a45098b79ce519d26b351f298a00

dEQP-VK.graphicsfuzz.loop-dead-if-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.loop-dead-if-loop

Change-Id: Ib621527105a57eabea346f7184d210ec8d66c5c1

dEQP-VK.graphicsfuzz.complex-nested-loops-and-call

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.complex-nested-loops-and-call

Change-Id: Idc47ce81d4bc24c8c09b9b9a4b0ebff2f86aabcd

Add tests for formats with mandatory feature bits

Some formats were missing from color attachment and blend tests.

New tests:

dEQP-VK.pipeline.blend.format.a2b10g10r10_unorm_pack32.*
dEQP-VK.pipeline.blend.format.a1r5g5b5_unorm_pack16.*
dEQP-VK.pipeline.image.suballocation.sampling_type.*.format.a2b10g10r10_unorm_pack32.*
dEQP-VK.pipeline.render_to_image.*.a1r5g5b5_unorm_pack16*
dEQP-VK.pipeline.render_to_image.*.r5g6b5_unorm_pack16*
dEQP-VK.pipeline.render_to_image.*.a2b10g10r10_uint_pack32*
dEQP-VK.pipeline.render_to_image.*.a2b10g10r10_unorm_pack32*

Components: Vulkan

VK-GL-CTS issue: 1921

Change-Id: Id300e3946f4e8753d29b405cee36039884ba062b

dEQP-VK.graphicsfuzz.discard-in-array-manipulating-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.discard-in-array-manipulating-loop

Change-Id: I40c19f241955caa3b2168218a400f766bb2d4a82

dEQP-VK.graphicsfuzz.two-for-loops-with-barrier-function

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.two-for-loops-with-barrier-function

Change-Id: Ie5de54846997779caac7db94f9eddf5be77404c0

dEQP-VK.graphicsfuzz.loops-breaks-returns

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.loops-breaks-returns

Change-Id: Ie6f3b52f4466245981e46bf6448959c5e4e2f140

dEQP-VK.graphicsfuzz.do-while-with-always-true-if

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.do-while-with-always-true-if

Change-Id: Ibb8f3aeac2ca2bb328ad406bbe4cea7c67aee065

dEQP-VK.graphicsfuzz.unreachable-discard-statement

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.unreachable-discard-statement

Change-Id: If693c48dbeee308c613c110bab93ed22c8282d8f

dEQP-VK.graphicsfuzz.two-nested-do-whiles

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.two-nested-do-whiles

Change-Id: Ib3c16de65acb79e1764b815edd8d016907635ae8

dEQP-VK.graphicsfuzz.return-before-writing-wrong-color

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.return-before-writing-wrong-color

Change-Id: Id37174663e6573c0c17c9b2141570cacff52bff9

dEQP-VK.graphicsfuzz.wrong-color-in-always-false-if

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.wrong-color-in-always-false-if

Change-Id: I157cca21c7083238826c5bf7837386d657c1f29d

Improve image atomic tests

Image atomic tests were operating only on positive numbers which
potentially could hide issues related to min/max operations
on negative numbers. This change makes half of input data for
min/max negative and properly performs verification depending on
tested format (whether its signed format or unsigned).

Components: Vulkan

VK-GL-CTS issue: 1940

Affects:
dEQP-VK.image.atomic_operations.*

Change-Id: I8c6ad882cab330a1b1d17921fd2fca097e24721c

Add OpFConvert precision tests

This commit adds tests to verify OpFConvert works as expected to convert
to and from 16, 32 and 64-bit wide floats in scalar and vector forms.

It does not use the existing precision tests framework due to the strict
precision requirements of OpFConvert, which require knowing the original
number exactly and are not suited for working with intervals.

New tests:
dEQP-VK.glsl.builtin.precision_fconvert.*

Components: Vulkan, Framework
VK-GL-CTS issue: 1868

Change-Id: I4161dae9d9f2c494cc873d5d11b40286bdfb6466

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Id21fae15bb0fad00a22e2d5798f958e6640804e2

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I58c329c990cacdb992c4c9be0b95cb65aa469a80

Remove magic numbers from subgroupElect tests

Most of these tests use defined constants for the elected and unelected
values for the tess_e version of the tests mysteriously used hardcoded
values. Obviously any attempt to change the constants would have been
broken.

Also, only keep one copy of the loop over stages in the framebuffer
tests. Two was extravagant.

Components: OpenGL, Vulkan
Affects: KHR-Single-*.subgroups.basic.framebuffer.subgroupelect_tess_eval

Change-Id: I6f9c7e02d04c75c5dcfee290a21a85bb97124be6

Fix EGL config incompatibility in negative_partial_update tests

Choosing 2 separate EGL configs, one for a window and a different one for
a pbuffer surface doesn't guarantee that those configs are compatible.
The dummyPbuffer surface may use different bit depths than the window
surface. This causes an unintended failure in eglMakeCurrent().

Choose a single EGL config suitable for both: the window and the pbuffer,
if both are being used.

Components: EGL
VK-GL-CTS issue: 2037
Affects: dEQP-EGL.functional.negative_partial_update.*

Change-Id: I676f760cbe2df3c906c376304efefa3170760438
Signed-off-by: Tomek Bury <tomek.bury@broadcom.com>

Remove use of ANDROID_NDK_HOST_OS

The CMake variable is not needed after removal of the NDK r11 cmake files

Component: Framework

VK-GL-CTS issue: 2056

Change-Id: I6993d48e098dc567c7fc9edcfc13d0f39e6f04ad

Use the new VK_LAYER_KHRONOS_validation layer

In more recent SDKs the VK_LAYER_LUNARG_standard_validation
meta layer has been replaced by the VK_LAYER_KHRONOS_validation
layer.

The latest SDK documentation about this can be found here:
https://vulkan.lunarg.com/doc/sdk/1.1.121.2/windows/validation_layers.html

It also notes that a bunch of the other individual validation layers
have also been deprecated. I've commented this fact in CTS, but
have not removed them because CTS might be used with older SDKs.

Affects all CTS with --deqp-validation=enable:

dEQP-VK.*

Components: Framework, Vulkan

VK-GL-CTS issue: -1

Change-Id: I6925f7dc55f10d7a00d1089effe491b9caebe909

Fix time calibration tests so they use all host time domains

When using std::set_intersection to check which time domains are
available, the input sets are not guaranteed to be sorted. This makes
the code skip some host time domains under Linux-like systems, which may
have more than one host time domain available.

Affected tests:
dEQP-VK.pipeline.timestamp.calibrated.*

Components: Vulkan
VK-GL-CTS issue: 2010

Change-Id: Iea9f0e375d675f9a63671165a78218ca04c6cde9

Check available functionality with context method

This change adds Context::isDeviceFunctionalitySupported and
Context::isInstanceFunctionalitySupported methods that replace
isDeviceExtensionSupported/isInstanceExtensionSupported.

Components: Framework

VK-GL-CTS issue: 2005

Affects:
dEQP-VK.*

Change-Id: If796fc31fe6e769495cdf1ccefa4ae8192caf2b5

Update Amber

Updated Amber to get support for new image comparison features.

Components: Framework
Change-Id: I9b750912dd0324395a5b8c43f6317f341121e9e9

Remove NaNs from double compare tests

Affected tests:
dEQP-VK.spirv_assembly.instruction.*.64bit_compare.double.*

Components: Vulkan
VK-GL-CTS issue: 2066

Change-Id: I8d735bbffe2db5d2c8cfac5a616efd6010057408

Fix incorrect assumption for pipeline cache hit

The test incorrectly assumes that adding a pipeline creation flag bit
VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT to only one pipeline
still should cause a cache hit. Fixed the problem by adding the
VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT flag bit to both pipelines.

Affects:
dEQP-VK.pipeline.creation_feedback.compute_tests.compute_stage

Components: Vulkan
VK-GL-CTS issue: 2068

Change-Id: Idb963219a4e894eee6a0bb3b1fc20797d5b0323e

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: Id91cbdafbce603e6cd681035b8a535e3aaa294dd

Add tests for uploading depth/stencil

Components: Vulkan

Affects:
dEQP-VK.api.copy_and_blit.core.buffer_to_depthstencil.*
dEQP-VK.api.copy_and_blit.dedicated_allocation.buffer_to_depthstencil.*

VK-GL-CTS issue: 1888
Change-Id: Id2153ef90014175f5b52811c80a905164e491735

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Ic9de3ec00dbd38b2106f1c497059e40d4d361297

Fix waitSemaphoreCount value in signal ordering tests

VK-GL-CTS Issue: 2059
Components: Vulkan
Affects: dEQP-VK.synchronization.signal_order.*timeline_semaphore.*

Change-Id: I25b86f1ae2b8e3650e061f9f2e345147c01419c6

Fix external memory import

Fix adds checking for flag
VK_EXTERNAL_MEMORY_FEATURE_DEDICATED_ONLY_BIT
when external memory is being imported.

Affects:
dEQP-VK.synchronization.signal_order.*

Components: Vulkan
VK-GL-CTS issue: 2063

Change-Id: Iebc72ba0ed89ba3ca2b83a5b97d6b24ab7871edb

Fixes VS num instances assumption

Components: Vulkan
VK-GL-CTS Issue: 2022

Affects:
dEQP-VK.spirv_assembly.instruction.*

Change-Id: Ibb0a17d8843c03cd1cf15d2c5af1f547481e8452

Fix LAYOUT_UNDEFINED transitions in descriptor_indexing tests

Commit 7b7ba4e0 caused the UNDEFINED->COLOR layout transition to be applied four
times, corrupting 3/4 of the image. Change the tests to do the layout transition
once, right after the framebuffer is created.

VK-GL-CTS Issue: 2064
Components: Vulkan
Affects: dEQP-VK.descriptor_indexing.*

Change-Id: Ie599ba76ba75af6fee1f4163bd96ea2bd6e4c145

Fix name shadowing warning in SurfaceCountersError

This is a simple warning fix that should not affect any test results,
related to the previous solution to the issue below.

Components: Vulkan
VK-GL-CTS issue: 1683

Change-Id: Ifa702330768f87e25d73f7489a306b4d4a1bbfb3

Fix build issues

Change-Id: I0b0da0af71d3d91e38eddf8e9c60be27b4d6ab11

dEQP-VK.graphicsfuzz.switch-if-discard

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.switch-if-discard

Change-Id: I055c4d205c0a6ce66289a1249dd8a025d4e01aa6

Reduce number of created pipelines in compute subgroups tests

Some drivers are taking too much time to execute compute subgroups
tests, mostly because they need to build N times the same pipeline
where the only difference is the local size values passed via
specialization constants.

As there are drivers that don't take advantage of pipeline derivatives,
reducing the number of pipeline creations helps to reduce execution time.

Affected tests:

   dEQP-VK.subgroups.*compute*

Components: Vulkan
VK-GL-CTS issue: 2019

Change-Id: Ie3ccbc53390bdba691c16d51c173b0a8a16119d9

Added script to list changed tests

Added script which reads git log and lists changed tests since specified
version or date.

Affects: none

Change-Id: I64e6403ed9a3bd9531c01ddb0007139950e4dda0
Components: Framework

Add tests for VK_EXT_blend_operation_advanced

There at three types of tests:

* Ops: they check that all the defined operations work
for a different set of source and destination colors, iterating over
(non)premultiplied colors and uncorrelate/disjoint/conjoint alpha
values.  The tests run on different number of color attachment as well.

* Independent: it checks that color attachments with different depth
operations do not affect the others.

* Coherent: it checks if (non)coherent blend operations work as
expected. It creates two pipelines with 2 different advanced blend ops,
first draw clears the pixel with a specified destination color and do
the blending; the second draw reuses the result of the first one as
destination color and do blending on top. In the case of noncoherent
blending, it adds a memory dependency between both advanced blend
operations.

Added tests:

   dEQP-VK.pipeline.blend_operation_advanced.*

Components: Vulkan
VK-GL-CTS issue: 1673

Change-Id: I4417e6a22e0c2882849f8bf59233c266c60e45c6

Add tests for sparse images using YCbCr formats

Sparse image tests include YCbCr image formats including multiplanar
formats and a group of previously ommited non-YCbCr image formats.

Affects tests:
dEQP-VK.sparse_resources.image_sparse_binding.*
dEQP-VK.sparse_resources.device_group_image_sparse_binding.*
dEQP-VK.sparse_resources.aligned_mip_size.*
dEQP-VK.sparse_resources.image_block_shapes.*
dEQP-VK.sparse_resources.image_sparse_residency.*
dEQP-VK.sparse_resources.mipmap_sparse_residency.*
dEQP-VK.sparse_resources.image_sparse_memory_aliasing.*
dEQP-VK.sparse_resources.shader_intrinsics.*
dEQP-VK.ycbcr.*

New tests:
dEQP-VK.sparse_resources.image_sparse_binding.*
dEQP-VK.sparse_resources.device_group_image_sparse_binding.*
dEQP-VK.sparse_resources.aligned_mip_size.*
dEQP-VK.sparse_resources.image_block_shapes.*
dEQP-VK.sparse_resources.image_sparse_residency.*
dEQP-VK.sparse_resources.mipmap_sparse_residency.*
dEQP-VK.sparse_resources.image_sparse_memory_aliasing.*
dEQP-VK.sparse_resources.shader_intrinsics.*
dEQP-VK.ycbcr.storage_image_write.*

Components: Vulkan Framework

VK-GL-CTS issue: 1419
VK-GL-CTS issue: 1084

Change-Id: I3e335840efbbabc2fc320629f5a165becdbb4f26

Handle LPCWSTR in framework

Components: Framework

VK-GL-CTS issue: 1703

Affects:
dEQP-VK.*

Change-Id: I2061de4eac657aa9453bc3143306d1670eb271aa

Reenable checking for core ballot functions

All the subgroup ballot tests were mistakenly created as extension
tests, so none of them were testing the core functionality.

Components: Vulkan
Affect: dEQP-VK.subgroups.ballot.framebuffer.*

Change-Id: I2876ed3e04c831e90d7d605019cdcfd8ecb8e375

Use buildOptions consistently

Backport the changes to buildOptions. This makes it easier to change the
build options for all the tests at the same time.

Components: Vulkan
Affects: dEQP-VK.subgroups.ballot_broadcast.*

Change-Id: Idf75d3fac002da85e800634078c11f1797ba4812

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: Iae396c7a296389d754c462f1047329a70d619a7a

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Ib3cab2c6bc13dee32caf2403b9dc52492f660082

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I2aa94658d6c8b6543fd9c4899f7da481ba1120a1

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I0954d6799d7b0e4a527cd0fbbdcf61237ca7e9a7

Remove float16 derivatives tests

SPIR-V restricts derivatives to 32-floating point scalars and vectors
only.

Component: Vulkan

VK-GL-CTS Issue: 1931

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.float16.derivative_*.*

Change-Id: Icc5341e697b797045080cc55428dbc2c02d71def
(cherry picked from commit 436d6dd5e7a0c0811bf1b6059542d1cdbccb9566)

Remove float16 derivatives tests

SPIR-V restricts derivatives to 32-floating point scalars and vectors
only.

Component: Vulkan

VK-GL-CTS Issue: 1931

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.float16.derivative_*.*

Change-Id: Icc5341e697b797045080cc55428dbc2c02d71def

Make texture aniso basic self tests less sensitive

The tests cases first check with a fuzzy diff that the images are more
or less the same.

The second diff then checks with a standard image comparison + tolerance
that the images are not identical.

Some of IMG's implementations produce a closer image than the test is
currently expecting - we need to lower the tolerance from 0.05 to 0.02
in order for the diff algorithm to detect that the images are
different 'enough'.

Though there is no actual spec requirement, it is 'generally going to
be the case', for any implementation, that the images will have some
amount of difference. It is potentially useful to still have this test
inplace to check againsty aniso being accidently disabled in the tested
implementation, rather than remove it altogether.

Affects:
dEQP-VK.texture.filtering_anisotropy.basic.*

Components: Vulkan

VK-GL-CTS Issue: 2047

Change-Id: Ia9148e12172ac1c4757f5007e57b3a2b3a3434eb

Relaxes line rasterization tolerances

Components: Framework
VK-GL-CTS Issue: 2033

Affects:
dEQP-VK.rasterization.*

Change-Id: Ib41552b1bb6d9aa2b25d0cbc6f02d51ce997f4e3

Revert "Fixes VS num instances assumption"

This reverts commit bac8df251bb6103d7844bfeacbb29bf14011b7cb.

Change-Id: I60aa83d860b0b11ec7fc58fb97806635a1eebdca

Remove tests that check non-zero values for reservedMustBeZero on all APIs

Although initially it was agreed to keep them for the APIs that still
include that field as reserved, and only remove them when the API
defines the field (baseInstance), in the end it was agreed to remove
it completely, as it is testing an undefined behaviour.

Components: OpenGL, OpenGL ES

VK-GL-CTS issue: 2029

Affects:
KHR-GL40.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GL40.draw_indirect.misc-reservedMustBeZero-elements
KHR-GL41.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GL41.draw_indirect.misc-reservedMustBeZero-elements
KHR-GLES31.core.draw_indirect.misc-reservedMustBeZero-arrays
KHR-GLES31.core.draw_indirect.misc-reservedMustBeZero-elements

Change-Id: Iafe3e711107da818a392ebcdfe50379cf3790d17

Merge "Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master"

Replace imageAtomicExchange with imageAtomicCompSwap in vertex shader

Recently the test was changed in order to replace a imageAtomicAdd for
a imageAtomicExchange, as the test can't assume that the vertex shader
will be executed exactly one per vertex shader (see VK-GL-CTS issue
1910).

But imageAtomicExchange is also problematic because in some
architecture/driver, specially tile-based, the test can't also assume
that all the vertex shader executions would finish before
rasterization starts (so fragment shader execution). So when using
imageAtomicExchange could happend that a vertex shader execution would
override the value that the fragment shader already started to update.

Due this two restrictions, this patch changes the atomic operation on
the vertex shader to imageAtomicCompSwap, that sets the value of the
image at the vertex shader only if it is the initial value (so
zero). That would prevent any possible execution when the
rasterization already started to override the value of such image.

This patch also adds a comment on the code explaining the situation,
to avoid any possible future change to a simpler atomic operation by
mistake.

Components: OpenGL ES

VK-GL-CTS issue: 1997

Affects:
KHR-GLES31.core.shader_image_load_store.advanced-allStages-oneImage

Change-Id: Icbc34662f33839a1ced9f728cee45a1198e4b495

Fix use of invalid HALF_FLOAT enum

GLES 2.0 supports GL_HALF_FLOAT_OES via the OES_texture_half_float
extension. When the enum GL_HALF_FLOAT was added in GLES 3.0,
unfortunately it did not use the same enum value as GL_HALF_FLOAT_OES.
Technically, GL_HALF_FLOAT is not supported on a GLES 2.0 implementation
even with OES_texture_half_float. Fix GLES 2.0 tests to always use
GL_HALF_FLOAT_OES to avoid the issue.

Affects:

KHR-GLES2.core.internalformat.texture2d.*_half_float_*
KHR-GLES3*.core.internalformat.texture2d.*_half_float_*

Components: OpenGL

VK-GL-CTS issue: 1923

Change-Id: I9b43091382341798a0d62b9a4ec09153e915dc5c

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I2df30e7152844ece359dd9d4bfb90eca990a1bd8

Generate a non-zero exit code on test failure

If there are any failed tests, or the test run was not
compelte, the process will now generate EXIT_FAILURE (1)
instead of EXIT_SUCCESS (0).

Affects:

dEQP-VK.*

Components: Framework

VK-GL-CTS issue: 1982

Change-Id: I061d9a3b6703e1f23c48ce8a31e943744f915c92
(cherry picked from commit cfa72a70ef8371eab29da003dbb4d932adba189a)

Generate a non-zero exit code on test failure

If there are any failed tests, or the test run was not
compelte, the process will now generate EXIT_FAILURE (1)
instead of EXIT_SUCCESS (0).

Affects:

dEQP-VK.*

Components: Framework

VK-GL-CTS issue: 1982

Change-Id: I061d9a3b6703e1f23c48ce8a31e943744f915c92

dEQP-VK.graphicsfuzz.always-false-if-with-discard-return

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.always-false-if-with-discard-return

Change-Id: Ib49084f32085d7a620e305637a8e75e062d7ad83

Postpone .amber file parsing

All .amber files were parsed during test indexing, so they were parsed
even if none of the tests were executed. This wasn't a big performance
hit yet, but we're likely to increase the use of amber.

Due to some chicken-and-egg issues part of the capability check was
moved to the start of iterate, but since that throws InternalError if
the check fails this shouldn't be a performance issue.

The tests themselves have not changed, just the order of when to parse
the file.

Affects: None

Components: Vulkan, Framework

VK-GL-CTS issue: 899

Change-Id: Iacdfd9a61d439e3f5dec952b2426386a2eb3451c

Test VkCopyDescriptorSet with inline uniform blocks

Use VkCopyDescriptorSet to copy data between inline uniform blocks
during vkUpdateDescriptorSets if VK_EXT_inline_uniform_block is
supported by the implementation.

New tests:
dEQP-VK.binding_model.descriptor_copy.*.inline_uniform_block_*
dEQP-VK.binding_model.descriptor_copy.*.mix_3
dEQP-VK.binding_model.descriptor_copy.*.mix_array1

Components: Vulkan
VK-GL-CTS issue: 2012

Change-Id: I3898f5c2f236ef62a392409791a870633b572e12

Add tests for VK_EXT_display_surface_counter

This commit adds tests for VK_EXT_display_surface_counter that try to
verify vkGetPhysicalDeviceSurfaceCapabilities2EXT returns the same set
of capabilities as vkGetPhysicalDeviceSurfaceCapabilitiesKHR and the
supportedSurfaceCounters field has coherent values for display surfaces
and non-display surfaces.

Affected tests:
dEQP-VK.wsi.display.create_display_plane_surface

New tests:
dEQP-VK.wsi.*.surface.query_surface_counters
dEQP-VK.wsi.display.surface_counters

Components: Vulkan
VK-GL-CTS issue: 1683

Change-Id: I7754411c7b458201e9a7f5e8a99dfada388124d7

dEQP-VK.graphicsfuzz.switch-with-empty-if-false

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.switch-with-empty-if-false

Change-Id: I42790dbee5975b301126a268c801c6a616aab721

dEQP-VK.graphicsfuzz.unreachable-return-in-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.unreachable-return-in-loop

Change-Id: I339de39006859f5396dc7397b722323f56a2222d

dEQP-VK.graphicsfuzz.disc-and-add-in-func-in-loop

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.disc-and-add-in-func-in-loop

Change-Id: I87cbd5e5f9b0d27f9d875a1ca31d3c7aa12cb433

Disentangle storage and arithmetic from conversions

Remove the requirement for 16-bit storage from float16 conversions
tests. Add f16 -> f32 and f32 -> f16 tests using only 16-bit storage.

Component: Vulkan

VK-GL-CTS Issue: 1931

Affects:
dEQP-VK.spirv_assembly.instruction.*.fconvert.*float16*
dEQP-VK.spirv_assembly.instruction.*.convertftou.*float16*
dEQP-VK.spirv_assembly.instruction.*.convertftos.*float16*
dEQP-VK.spirv_assembly.instruction.*.convertutof.*float16*
dEQP-VK.spirv_assembly.instruction.*.convertstof.*float16*

Change-Id: I993bdb7a6313cf19ce59b5fa43645f5168ea3cbc

Whitelist VK_KHR_shader_subgroup_extended_types

Components: Vulkan

Change-Id: Ie68fd0fd2606aac29ddf1e1a0c6668504a42a91a

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: I7a8febada6ebf7ad2de0f9727a5efbbcc729c3d0

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I3b96cb8cde6cbfc585d717a94f2164739887726f

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Iea7706e036758d8a648ef7938b3d08e21321a087

Use the correct imageType for image support checks.

Components: Vulkan

Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.depth_stencil.{1d,3d}*

VK-GL-CTS issue: 2050

Change-Id: If73d9ff3e026ae4c32fd00fcc546734eebf9990e

Fix wrong wait stage mask

The wait stage mask wasn't accounting for the
stages the readers actually operate in, hence
being effectless.
Track the union of the reader's stage masks
and use that to block execution on the semaphore.

Affects:
dEQP-VK.synchronization.signal_order.*

Components: Vulkan
VK-GL-CTS issue: 2044

Change-Id: Ia4d5c7bcb9dd6eec25e7245dc41754acccd1b995

Fix in shadercacheLoad

There is a slim chance that function shadercacheLoad() can pass a null
pointer into the std::string constructor, causing an exception. This can
happen in the case there is a mismatch between the calculated hash and
the one stored in the cache file.

This commit makes the code more robust, handling this case as a miss.

Components: Vulkan

VK-GL-CTS issue: 2052

Change-Id: I84a382dec51f487314304ec9057cefdff22920c3

Fixed mandatory caselist for parallel CTS run

Duplicate tests listed in deqp-fraction-mandatory-caselist-file
command line option are now skipped during test tree parsing,
when parallel CTS run is configured.

Components: Framework

VK-GL-CTS issue: 2053

Change-Id: I4ce2b6f33fd22c7ddc3aba0adbe9f7e761237e51

Merge vk-gl-cts/vulkan-cts-1.1.6 into vk-gl-cts/master

Change-Id: If68c0cb9516bb0bb1f441c9fde8bfd5456cee76d

Remove superfluous call to createCustomDevice

Components: Vulkan

Change-Id: I7982ff1203b8eaeccfdd4b3a6b9bc3ab0b688721

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Ife971c6779bf35094b5a72a87abaa47a6901530b

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Ibb2b736bbe1c62688044aa21dc75205f6fa32f1c