caryclark@google.com [Tue, 23 Apr 2013 12:04:05 +0000 (12:04 +0000)]
path ops : enable optimizations
this addresses a few FIXME issues
- speed up implicit quad computation
- use ulps instead of epsilon
- assert on bad line results more often
git-svn-id: http://skia.googlecode.com/svn/trunk@8823
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 23 Apr 2013 11:56:44 +0000 (11:56 +0000)]
path ops -- use standard max, min, double-is-nan
fix a comment or two as well
Review URL: https://codereview.chromium.org/
13934009
git-svn-id: http://skia.googlecode.com/svn/trunk@8822
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 23 Apr 2013 11:16:32 +0000 (11:16 +0000)]
Also proxy bumpTestCount.
Example output with -v -x:
...
Finished 127 tests, 0 failures, 0 skipped.
Ran
73094673 Internal tests.
BUG=
R=caryclark@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
13983011
git-svn-id: http://skia.googlecode.com/svn/trunk@8821
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Tue, 23 Apr 2013 11:06:52 +0000 (11:06 +0000)]
Whitespace change to trigger rebuilds after skia-autogen reset
git-svn-id: http://skia.googlecode.com/svn/trunk@8820
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 23 Apr 2013 07:01:29 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8819
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 22 Apr 2013 21:05:48 +0000 (21:05 +0000)]
Add non-separable xfer modes to GPU backend.
Review URL: https://codereview.chromium.org/
14371014
git-svn-id: http://skia.googlecode.com/svn/trunk@8815
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 20:26:44 +0000 (20:26 +0000)]
Fix gyp files to allow ninja to build 64 bit on Mac.
Fix warnings that cropped up building as 64-bit.
BUG=
R=bsalomon@google.com, bungeman@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
13852013
git-svn-id: http://skia.googlecode.com/svn/trunk@8814
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 22 Apr 2013 20:21:56 +0000 (20:21 +0000)]
fix asserts in SkMulDiv255Round, and add test
Review URL: https://codereview.chromium.org/
13934010
git-svn-id: http://skia.googlecode.com/svn/trunk@8813
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 22 Apr 2013 20:12:47 +0000 (20:12 +0000)]
path ops -- crap, I checked in the wrong file
this has the changes Brian suggested
git-svn-id: http://skia.googlecode.com/svn/trunk@8812
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 22 Apr 2013 20:09:23 +0000 (20:09 +0000)]
remove deleted file from gyp
git-svn-id: http://skia.googlecode.com/svn/trunk@8811
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 19:55:19 +0000 (19:55 +0000)]
path ops -- use standard SkTQSort
thanks to bungeman for the contextual sort
R=bungeman@google.com
Author: caryclark@google.com
Review URL: https://chromiumcodereview.appspot.com/
14034014
git-svn-id: http://skia.googlecode.com/svn/trunk@8810
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 19:34:42 +0000 (19:34 +0000)]
Add missing unistd.h include after r8765.
TEST=Build with GCC 4.8.0 and glibc 2.17.
R=reed@google.com, jvanverth@google.com, bsalomon@google.com
Author: raphael.kubo.da.costa@intel.com
Review URL: https://chromiumcodereview.appspot.com/
14401007
git-svn-id: http://skia.googlecode.com/svn/trunk@8809
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 22 Apr 2013 18:48:45 +0000 (18:48 +0000)]
check-point for linux fontmgr impl
Review URL: https://codereview.chromium.org/
14305007
git-svn-id: http://skia.googlecode.com/svn/trunk@8808
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 22 Apr 2013 18:45:12 +0000 (18:45 +0000)]
fix refcnts for singleton fontconfig-direct
git-svn-id: http://skia.googlecode.com/svn/trunk@8807
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 18:05:19 +0000 (18:05 +0000)]
Add new roundrect GM
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
14348022
git-svn-id: http://skia.googlecode.com/svn/trunk@8806
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 22 Apr 2013 18:00:06 +0000 (18:00 +0000)]
start cleanup, in prep for new fontmgr impl
Review URL: https://codereview.chromium.org/
13956032
git-svn-id: http://skia.googlecode.com/svn/trunk@8805
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 17:35:55 +0000 (17:35 +0000)]
Unbreak -z. The LocalReporter shim layer was forcing the pathops options back to defaults.
BUG=
R=caryclark@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
13849013
git-svn-id: http://skia.googlecode.com/svn/trunk@8804
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 16:43:07 +0000 (16:43 +0000)]
Make it clearer what's going on at the end of tests.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
14267022
git-svn-id: http://skia.googlecode.com/svn/trunk@8803
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 15:23:14 +0000 (15:23 +0000)]
Add thread-per-core setting to SkThreadPool.
BUG=
R=scroggo@google.com, caryclark@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
13855009
git-svn-id: http://skia.googlecode.com/svn/trunk@8802
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 22 Apr 2013 15:07:34 +0000 (15:07 +0000)]
Rebaseline performance triggers for new .skp files
git-svn-id: http://skia.googlecode.com/svn/trunk@8801
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 22 Apr 2013 14:56:50 +0000 (14:56 +0000)]
Revert accidentally changed msvs settings in r8764.
git-svn-id: http://skia.googlecode.com/svn/trunk@8800
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 14:39:06 +0000 (14:39 +0000)]
Feed Clang a pragma to ignore -Wc++11-extensions to let it build Skia on Mac.
Tested:
CXX=clang++ ./gyp_skia && ninja -C out/Debug && CXX=G++ ./gyp_skia && ninja -C out/Debug && echo "ok"
Got to ok.
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
14365009
git-svn-id: http://skia.googlecode.com/svn/trunk@8799
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 22 Apr 2013 14:37:05 +0000 (14:37 +0000)]
path ops : add support for inverse fill
add inverse fill, reverse diff, and gm tests
cleaned up some interfaces
Review URL: https://codereview.chromium.org/
14371011
git-svn-id: http://skia.googlecode.com/svn/trunk@8798
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 22 Apr 2013 14:28:01 +0000 (14:28 +0000)]
Adding optimization to avoid image copy in SkSurface copy on write when content is discardable
This patch also adds code to SkDeferredCanvas to trigger the optimization.
TEST=DeferredSurfaceCopy bench, Surface unit test
R=reed@google.com
Author: junov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
14063015
git-svn-id: http://skia.googlecode.com/svn/trunk@8797
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 22 Apr 2013 13:47:40 +0000 (13:47 +0000)]
Catch failures to SkTypeface::Deserialize() and use the default in that case.
This fixes cros bots, who are (for whatever reason) failing to deserialize one
of their fonts during picture-deserialization.
git-svn-id: http://skia.googlecode.com/svn/trunk@8796
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Mon, 22 Apr 2013 12:45:30 +0000 (12:45 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@8795
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Sun, 21 Apr 2013 23:41:00 +0000 (23:41 +0000)]
Copied over new versions of SKP files.
(AddDashboardAnnotation)
git-svn-id: http://skia.googlecode.com/svn/trunk@8794
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 21 Apr 2013 01:44:04 +0000 (01:44 +0000)]
remove printf
git-svn-id: http://skia.googlecode.com/svn/trunk@8792
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 21 Apr 2013 01:43:09 +0000 (01:43 +0000)]
pass 0 instead of NULL for size_t parameter
git-svn-id: http://skia.googlecode.com/svn/trunk@8791
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sun, 21 Apr 2013 01:37:46 +0000 (01:37 +0000)]
specialize SkDataTable for arrays where all elements are the same size.
optimize impl to not require another level of indirection (SkData) for storage.
add unittests for flattening.
optimize builder to not make a deepcopy of its chunkalloc heap.
git-svn-id: http://skia.googlecode.com/svn/trunk@8790
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 20 Apr 2013 21:51:06 +0000 (21:51 +0000)]
Win7 Intel performance rebaseline
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@8789
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 20 Apr 2013 21:44:52 +0000 (21:44 +0000)]
Performance rebaseline on ubuntu
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@8788
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 20 Apr 2013 12:26:07 +0000 (12:26 +0000)]
Vertex Attrib configurations now handled as pointers vs. SkSTArrays
https://codereview.chromium.org/
14328009/
git-svn-id: http://skia.googlecode.com/svn/trunk@8787
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Sat, 20 Apr 2013 12:10:26 +0000 (12:10 +0000)]
Remove GR_STATIC_RECT_VB
https://codereview.chromium.org/
14367030/
git-svn-id: http://skia.googlecode.com/svn/trunk@8786
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 20 Apr 2013 07:01:07 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8785
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 20:52:50 +0000 (20:52 +0000)]
can't return false for a ptr (unless you're in gcc)
git-svn-id: http://skia.googlecode.com/svn/trunk@8782
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 20:45:30 +0000 (20:45 +0000)]
use SkDataTable to return familyNames for fontmgr
git-svn-id: http://skia.googlecode.com/svn/trunk@8781
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 20:22:39 +0000 (20:22 +0000)]
add SkDataTable::NewEmpty()
git-svn-id: http://skia.googlecode.com/svn/trunk@8780
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 20:16:01 +0000 (20:16 +0000)]
add SkDataTable, to efficiently store an immutable array. Includes a builder
helper class.
Review URL: https://codereview.chromium.org/
14188049
git-svn-id: http://skia.googlecode.com/svn/trunk@8779
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 19 Apr 2013 19:01:45 +0000 (19:01 +0000)]
Fix non-uniform scale and stroked ellipses
Strokes were not being scaled properly for ellipses -- the
view matrix was being reset before the scale factors were
being applied. Scaling the stroke has been moved up higher in
the process. Also applies some optimizations suggested by
robertphillips.
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://chromiumcodereview.appspot.com/
14017012
git-svn-id: http://skia.googlecode.com/svn/trunk@8777
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 19 Apr 2013 18:10:50 +0000 (18:10 +0000)]
Final round of .0s
git-svn-id: http://skia.googlecode.com/svn/trunk@8774
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 19 Apr 2013 17:21:49 +0000 (17:21 +0000)]
More .0s
git-svn-id: http://skia.googlecode.com/svn/trunk@8771
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 19 Apr 2013 16:20:20 +0000 (16:20 +0000)]
Add ".0" to 1 constants in xfermodes GLSL code.
git-svn-id: http://skia.googlecode.com/svn/trunk@8770
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 19 Apr 2013 15:03:21 +0000 (15:03 +0000)]
Add all remaining separable xfer modes to GPU backend.
Review URL: https://codereview.chromium.org/
14189024
git-svn-id: http://skia.googlecode.com/svn/trunk@8768
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 14:28:54 +0000 (14:28 +0000)]
return empty fontstyleset instead of null
git-svn-id: http://skia.googlecode.com/svn/trunk@8767
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 19 Apr 2013 13:59:52 +0000 (13:59 +0000)]
Fix for segmentation fault in xfermodes2 GM.
Reviewed offline by bsalomon.
git-svn-id: http://skia.googlecode.com/svn/trunk@8766
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 13:55:00 +0000 (13:55 +0000)]
check-point for new fontmgr on linux
git-svn-id: http://skia.googlecode.com/svn/trunk@8765
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 19 Apr 2013 13:25:28 +0000 (13:25 +0000)]
silence && || parens clang warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@8764
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 19 Apr 2013 13:24:28 +0000 (13:24 +0000)]
Add --threads to tests binary, to run non-GPU tests on multiple cores.
On my quad-core laptop I can get about a 3x speedup:
Debug, --threads 0 40.99s
Debug, --threads 8 14.39s
Release, --threads 0 8.24s
Release, --threads 8 2.80s
I also removed some unused Test.{h,cpp} APIs and refactored a little to make
things thread-safer.
BUG=
R=borenet@google.com, djsollen@google.com, scroggo@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
13855007
git-svn-id: http://skia.googlecode.com/svn/trunk@8763
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 19 Apr 2013 13:14:45 +0000 (13:14 +0000)]
Perform coverage blend with the dst in the shader when using a dst-reading xfermode.
Review URL: https://codereview.chromium.org/
14233006
git-svn-id: http://skia.googlecode.com/svn/trunk@8762
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 19 Apr 2013 12:25:00 +0000 (12:25 +0000)]
ensure that negative zeros are still ignored when computing isIdentity()
crbug.com/162747
git-svn-id: http://skia.googlecode.com/svn/trunk@8761
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 19 Apr 2013 11:45:56 +0000 (11:45 +0000)]
enable path ops in unit tests
git-svn-id: http://skia.googlecode.com/svn/trunk@8760
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 19 Apr 2013 07:01:00 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8759
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 19 Apr 2013 02:37:53 +0000 (02:37 +0000)]
Whitespace change to test the commit queue. (SkipBuildbotRuns)
R=borenet@google.com
Author: rmistry@google.com
Review URL: https://chromiumcodereview.appspot.com/
14079004
git-svn-id: http://skia.googlecode.com/svn/trunk@8758
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 19 Apr 2013 02:36:29 +0000 (02:36 +0000)]
Whitespace change (SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@8757
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 18 Apr 2013 19:50:01 +0000 (19:50 +0000)]
path ops : remove countdown overkill
Review URL: https://codereview.chromium.org/
13958005
git-svn-id: http://skia.googlecode.com/svn/trunk@8756
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 18 Apr 2013 19:36:09 +0000 (19:36 +0000)]
Expand modulate, add, subtract, extract component glsl helpers.
Review URL: https://codereview.chromium.org/
13895006
git-svn-id: http://skia.googlecode.com/svn/trunk@8755
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 18 Apr 2013 19:21:06 +0000 (19:21 +0000)]
disabling path ops
Default single-threaded variant may wait forever.
Review URL: https://codereview.chromium.org/
13874014
git-svn-id: http://skia.googlecode.com/svn/trunk@8754
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 18 Apr 2013 19:18:19 +0000 (19:18 +0000)]
Remove exclude of file which no longer exists.
git-svn-id: http://skia.googlecode.com/svn/trunk@8753
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 18 Apr 2013 19:02:56 +0000 (19:02 +0000)]
Enable path ops
Path ops work (to my knowledge) on all platforms.
Turning it on will use the bots to expose failing
combinations I don't know about.
Review URL: https://codereview.chromium.org/
14057014
git-svn-id: http://skia.googlecode.com/svn/trunk@8751
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 18 Apr 2013 18:47:37 +0000 (18:47 +0000)]
allow tests to optionally use multiple threads
modify threaded path ops tests to check
Background: this CL came out of a conversation with Eric where I learned that 10s of machines host 100s of bots. Since the bot hosting tests may be shared with many other tasks, it seems unwise for path ops to launch multiple test threads.
The change here is to make launching multiple threads "opt-in" and by default, bots can run path ops in a single thread.
Review URL: https://codereview.chromium.org/
14002007
git-svn-id: http://skia.googlecode.com/svn/trunk@8750
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 18 Apr 2013 18:43:26 +0000 (18:43 +0000)]
use SkAutoTDelete instead of SkTScopedPtr
Review URL: https://codereview.chromium.org/
13831011
git-svn-id: http://skia.googlecode.com/svn/trunk@8749
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 18 Apr 2013 17:44:57 +0000 (17:44 +0000)]
Fix compile warning
Review URL: https://codereview.chromium.org/
14227005
git-svn-id: http://skia.googlecode.com/svn/trunk@8748
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 18 Apr 2013 15:58:21 +0000 (15:58 +0000)]
path ops work in progress
fix bugs in tests on 32 bit release
Most changes revolve around pinning computed t values
very close to zero and one.
git-svn-id: http://skia.googlecode.com/svn/trunk@8745
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 18 Apr 2013 15:37:14 +0000 (15:37 +0000)]
augmenting fix in 8700 and 8701, be careful NOT to "sort" the result of mapRect
when we only want to proceed if the matrix is nearly identity. Hence we manually
apply the matrix to the two "points" of the rect.
git-svn-id: http://skia.googlecode.com/svn/trunk@8743
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 18 Apr 2013 15:33:27 +0000 (15:33 +0000)]
revert 8731, restoring 8700 and 8701... further investigation concluded that the
original changes were correct. The failures in DRT will be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@8742
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 18 Apr 2013 14:48:35 +0000 (14:48 +0000)]
Reset shader in ovals GM
Not resetting the shader for the paints produces interesting
results on the following configs...
Review URL: https://codereview.chromium.org/
13947042/
git-svn-id: http://skia.googlecode.com/svn/trunk@8740
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 18 Apr 2013 14:13:10 +0000 (14:13 +0000)]
Adding a bit of rebustness to SkRectShaderImageFilter
Since SkRectShaderImageFilter is an image filter, I added logic so that it can actually use the size of an input image as the rect if an empty rect is provided as an argument. I also added logic to prevent creating an empty device.
Review URL: https://codereview.chromium.org/
14093008
git-svn-id: http://skia.googlecode.com/svn/trunk@8739
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Thu, 18 Apr 2013 14:04:57 +0000 (14:04 +0000)]
Disabling GPU noise on Windows since Angle can't do a proper translation of this shader to HLSL.
git-svn-id: http://skia.googlecode.com/svn/trunk@8738
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 18 Apr 2013 13:59:04 +0000 (13:59 +0000)]
Add a GM to test ovals with a variety of paint settings, matrices and sizes.
Review URL: https://codereview.chromium.org/
14329008/
git-svn-id: http://skia.googlecode.com/svn/trunk@8737
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 18 Apr 2013 13:28:19 +0000 (13:28 +0000)]
Adding SK_API to export SkImage and SkSurface API classes
Review URL: https://codereview.chromium.org/
14328002
git-svn-id: http://skia.googlecode.com/svn/trunk@8736
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 18 Apr 2013 12:32:28 +0000 (12:32 +0000)]
Rebaseline Nexus7 cuteoverload performance trigger
git-svn-id: http://skia.googlecode.com/svn/trunk@8735
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 18 Apr 2013 07:01:48 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8732
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 17 Apr 2013 21:32:03 +0000 (21:32 +0000)]
Revert r8701 and r8700 due to layout test discrepancies
git-svn-id: http://skia.googlecode.com/svn/trunk@8731
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 17 Apr 2013 21:07:55 +0000 (21:07 +0000)]
Updates to images project.
Use the SkImageEncoder_Factory on all platforms. On Windows and Mac,
register the platform's image encoder as an option for
SkImageEncoder::Create. Also add more types that can be decoded.
Update comments for SkImageDecoder to be more accurate.
Add more types to SkImageEncoder::Type, and return the correct type of
encoder, if it exists.
Use a custom version of SkImageDecoder::Factory on Windows and Mac to
check the stream for registered decoders before defaulting to the platform's
version. Share code with the existing SkImageDecoder::Factory method.
Preparation for testing decoders and encoders:
BUG=https://code.google.com/p/skia/issues/detail?id=1241
Review URL: https://codereview.chromium.org/
14298010
git-svn-id: http://skia.googlecode.com/svn/trunk@8730
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 17 Apr 2013 17:37:56 +0000 (17:37 +0000)]
Only use JDCT_IFAST if it's supported.
When encoding to JPEG, do not switch to JDCT_IFAST unless
DCT_IFAST_SUPPORTED is defined.
Review URL: https://codereview.chromium.org/
14031013
git-svn-id: http://skia.googlecode.com/svn/trunk@8728
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 17 Apr 2013 16:19:02 +0000 (16:19 +0000)]
path ops in progress
fix numeric check for cubic-to-quad conversion
to be 80-bit safe
git-svn-id: http://skia.googlecode.com/svn/trunk@8727
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 17 Apr 2013 15:49:16 +0000 (15:49 +0000)]
shape ops work in progress
Try to fix the 32 bit build by making some math
decisions more robust.
Rewrite the cubic intersection special case that
detects if only end points are shared.
Rewrite the angle sort setup that computes whether
a cubic bends to the left or right.
git-svn-id: http://skia.googlecode.com/svn/trunk@8726
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 17 Apr 2013 15:34:09 +0000 (15:34 +0000)]
Reducing the complexity of the noise test for Angle
git-svn-id: http://skia.googlecode.com/svn/trunk@8725
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 17 Apr 2013 14:50:38 +0000 (14:50 +0000)]
Fixing debug bench assert on Android
git-svn-id: http://skia.googlecode.com/svn/trunk@8724
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 17 Apr 2013 14:25:27 +0000 (14:25 +0000)]
Skip copytexsubimage2D code path when src is multisampled.
Review URL: https://codereview.chromium.org/
14048015
git-svn-id: http://skia.googlecode.com/svn/trunk@8722
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 17 Apr 2013 14:19:44 +0000 (14:19 +0000)]
Add xfermodes2 GM. Tests all xfer modes with two gradient bitmaps
Review URL: https://codereview.chromium.org/
13912017
git-svn-id: http://skia.googlecode.com/svn/trunk@8721
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 17 Apr 2013 13:55:45 +0000 (13:55 +0000)]
Build fix
TBR=reed
git-svn-id: http://skia.googlecode.com/svn/trunk@8720
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 17 Apr 2013 13:46:56 +0000 (13:46 +0000)]
Perlin noise adjustments
1 ) Added GPU simplex noise as a comparison to GPU Perlin noise. It can be enabled simply by using a #define (SK_USE_SIMPLEX_NOISE)
2 ) Enabled GPU Perlin noise tests
3 ) Added a small benchmark for noise
4 ) Disabled GPU Perlin noise on Android based on benchmarks
Review URL: https://codereview.chromium.org/
14087002
git-svn-id: http://skia.googlecode.com/svn/trunk@8719
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 17 Apr 2013 13:43:04 +0000 (13:43 +0000)]
Benchmark to measure SkSurface copy on write performance
Review URL: https://codereview.chromium.org/
14297008
git-svn-id: http://skia.googlecode.com/svn/trunk@8718
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 17 Apr 2013 13:36:15 +0000 (13:36 +0000)]
Remove deprecated/obsolete Makefiles.
$ git ls-files | grep .mk
or
$ find . -name *.mk
R=epoger@google.com,reed@google.com
Review URL: https://codereview.chromium.org/
14216002
git-svn-id: http://skia.googlecode.com/svn/trunk@8717
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 17 Apr 2013 07:00:56 +0000 (07:00 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@8714
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 17 Apr 2013 02:25:33 +0000 (02:25 +0000)]
add compute-bounds for conics
git-svn-id: http://skia.googlecode.com/svn/trunk@8713
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Wed, 17 Apr 2013 01:21:01 +0000 (01:21 +0000)]
add extrema for conics
git-svn-id: http://skia.googlecode.com/svn/trunk@8712
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 16 Apr 2013 21:07:27 +0000 (21:07 +0000)]
add comments for computing derivatives
git-svn-id: http://skia.googlecode.com/svn/trunk@8711
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 16 Apr 2013 19:56:45 +0000 (19:56 +0000)]
Build fix: moving more inline functions into header
TBR=reed
git-svn-id: http://skia.googlecode.com/svn/trunk@8710
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 16 Apr 2013 19:50:30 +0000 (19:50 +0000)]
Build fix: moving some inline function definitions into header.
TBR=reed
git-svn-id: http://skia.googlecode.com/svn/trunk@8709
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 16 Apr 2013 19:41:09 +0000 (19:41 +0000)]
Cleanup: Removing unnecessary args/complexity in SkSurface_Base and friends
Review URL: https://codereview.chromium.org/
14263017
git-svn-id: http://skia.googlecode.com/svn/trunk@8708
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 16 Apr 2013 19:11:14 +0000 (19:11 +0000)]
Delete gm after use.
Fixes a memory leak when using the --modulo flag. Instead of deleting
manually in each case we are done with it (which led to missing one
case), use an SkAutoTDelete.
Review URL: https://codereview.chromium.org/
13929019
git-svn-id: http://skia.googlecode.com/svn/trunk@8707
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 16 Apr 2013 17:58:38 +0000 (17:58 +0000)]
change shortName to match filename
git-svn-id: http://skia.googlecode.com/svn/trunk@8705
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 16 Apr 2013 17:18:57 +0000 (17:18 +0000)]
add () around | cluster, to avoid warning.
git-svn-id: http://skia.googlecode.com/svn/trunk@8701
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 16 Apr 2013 17:14:45 +0000 (17:14 +0000)]
use forward matrix to determine if we can ignore scale part of a matrix
Review URL: https://codereview.chromium.org/
14018020
git-svn-id: http://skia.googlecode.com/svn/trunk@8700
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 16 Apr 2013 17:04:43 +0000 (17:04 +0000)]
fix new gm to actually trigger the bug
git-svn-id: http://skia.googlecode.com/svn/trunk@8699
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 16 Apr 2013 16:55:38 +0000 (16:55 +0000)]
add gm to test edge case in drawBitmapRectToRect
git-svn-id: http://skia.googlecode.com/svn/trunk@8698
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 16 Apr 2013 15:24:31 +0000 (15:24 +0000)]
Remove 'friend SkRefCnt' from SkData.
https://codereview.chromium.org/
13925021/
If a non-POD class does not provide a default destructor, one is
provided by teh compiler. GCC will do so, but only at the point where the
vtable is output; since BlockRef has no implementation its destructor is
never output, so there is no complaint. VC++, however, provides the
destructor implementation as soon as it sees the type. If the destructor
of BlockRef is ever defined an error will be reported (since the
destructor of SkData is private).
Declaring (but does not defining) a destructor for BlockRef fixes two
issues. First, it prevents a default destructor from being provided,
removing the VC++ error. Second, BlockRef now blocks access to the
destructor through '->'.
git-svn-id: http://skia.googlecode.com/svn/trunk@8697
2bbb7eff-a529-9590-31e7-
b0007b416f81