José Rivero [Fri, 26 Apr 2019 00:37:59 +0000 (17:37 -0700)]
Undo a change where we ignore the specified EventPipe sessionType.
Andrew Au [Thu, 25 Apr 2019 21:03:01 +0000 (14:03 -0700)]
Refactored the duplicated code into a template method pattern
Gleb Balykov [Fri, 26 Apr 2019 14:04:38 +0000 (17:04 +0300)]
Add config value for jit host slab cache maximum size (#24254)
Brian Sullivan [Fri, 26 Apr 2019 05:51:14 +0000 (22:51 -0700)]
Merge pull request #24229 from briansull/ibc-linux
Fixes for IBC profile data on Linux
Russ Keldorph [Sat, 20 Apr 2019 00:02:16 +0000 (17:02 -0700)]
Helix telemetry fixes
- Enable telemetry unconditionally
- Set the `_BuildConfig` variable in `xplat-job.yml` so it is available to
both product and test builds.
- Set the Helix `Type` parameter explicitly to distinguish product and test builds
- Set the Helix `Source` parameter for builds as well as test jobs
This includes a fix to job.yml from dotnet/arcade#2620.
Filip Navara [Thu, 25 Apr 2019 23:42:30 +0000 (01:42 +0200)]
[System.Globalization.Native] Fix small issues in CloneCollatorWithOptions and GetCollatorFromSortHandle (#24100)
* Fix allocation size calculation when resizing array
Allocate initial array using malloc to avoid needlessly zeroing it
Reinstate optimization for empty array returned from GetCustomRules lost in #22378
* Avoid resizing arrays in GetCustomRules by preallocating the maximum size we can consume (5648 bytes)
* Avoid creating a binary search tree for something that could be easily stored as 32-entry lookup table
* Remove obsolete comment
Omair Majid [Thu, 25 Apr 2019 23:40:19 +0000 (19:40 -0400)]
Null-terminate buffers that strncpy writes to (#24095)
It is possible that the string being copied is so large that strncpy
fills up the destination array and does not write any null characters to
it. That will lead to buffer overflows. Work around that by always
writing a null character at the end of the destination array.
Russ Keldorph [Thu, 25 Apr 2019 23:34:57 +0000 (16:34 -0700)]
Remove redundant tests (#24255)
Tests are technically flaky and have been determined largely redundant with CoreFx.
Fixes #24212
Brian Sullivan [Thu, 25 Apr 2019 22:56:32 +0000 (15:56 -0700)]
Added method ReleaseManagedCommandLine to release memory
Mukul Sabharwal [Thu, 25 Apr 2019 22:34:19 +0000 (15:34 -0700)]
Add IsFrozenObject Profiler API (#24239)
José Rivero [Thu, 25 Apr 2019 22:13:03 +0000 (15:13 -0700)]
Removing EventPipe file polling (EventPipeController+Timer) (#24225)
* Remove file polling only, and leave the COMPlus_* functionality.
* Fix bug/typo introduced with https://github.com/dotnet/coreclr/pull/21718
Brian Sullivan [Tue, 23 Apr 2019 21:52:04 +0000 (14:52 -0700)]
Fix for IBC profile data on Linux - Build the full command line for FEATURE_PAL
Added public static function GetManagedCommandLine() andSaveManagedCommandLine()
Add helper method Append_Next_Item
Moved GetManagedCommandLine and SaveManagedCommandLine to ceeload to link crossgen
Cleanup, codereview feedback
Jan Vorlicek [Thu, 25 Apr 2019 21:49:48 +0000 (23:49 +0200)]
Merge pull request #24242 from janvorli/fix-numa-node-for-disabled-numa
Fix NUMA node for heap when NUMA is not available
Andrew Au [Thu, 25 Apr 2019 17:20:30 +0000 (10:20 -0700)]
Using SList<SListElem<T>> to store the EventPipeProviderCallbackData
Jeremy Koritzinsky [Thu, 25 Apr 2019 20:16:35 +0000 (13:16 -0700)]
Add IBCMerge restore source to the restore command. (#24250)
Anirudh Agnihotry [Thu, 25 Apr 2019 18:47:22 +0000 (11:47 -0700)]
Nullable System.Collections.EmptyReadOnlyDictionaryInternal, System.Collections.ObjectModel.* (#24221)
* annotating collections
* annotated collection.cs and readonlycollection.cs
* adding tkey constraint and comments
Jan Vorlicek [Thu, 25 Apr 2019 18:19:50 +0000 (20:19 +0200)]
Merge pull request #24232 from janvorli/fix-large-version-bubble-2
Fix crossgen with large version bubble enabled
David Wrighton [Thu, 25 Apr 2019 17:57:09 +0000 (10:57 -0700)]
Improve the performance of the type loader (#24177)
Improve the performance of the type loader
- Disable interface ambiguity checks in Corelib
- Improve StackingAllocator perf
- Increase size of allocation blocks
- Cleanup allocation blocks comletely on gc suspension
- Check for presence of generic parameters to methods in a more efficient manner
- Querying the count of GenericParameter records requires a binary search in the GenericParams table
- Checking the generic flag on the method signature is effectively free
- Skip unnecessary checks in EnumerateClassMethods for corelib
- Use Sanity check flag where appropriate
- Use slightly faster hashtable functions in StringLiteralMap
- Remove pointless string literal entry hash table search
- Change stacking allocator to not be allocated for the lifetime of a thread, but instead its allocated/destroyed around the first frame on the thread that needs the allocator.
- Allocate at most 1 stacking allocator per thread
- The allocation is on the stack via _alloca (as managed by the ACQUIRE_STACKING_ALLOCATOR macro
- This will put an 8KB buffer on the stack, and if there is need for a larger buffer it will allocate off of the heap.
- Stacking allocator initial block is always present, so the allocation routine for the allocator can be somewhat simpler
- More logic has been move the the cpp file, to reduce header bloat, and improve iteration when modifying StackingAllocator code
- Avoid use of alloca for StackingAllocator when less than 512KB of stack is available
Levi Broderick [Thu, 25 Apr 2019 15:22:39 +0000 (08:22 -0700)]
Fix verification of 3-byte UTF-8 sequence followed by non-ASCII byte (#24235)
Carol Eidt [Thu, 25 Apr 2019 14:26:21 +0000 (07:26 -0700)]
Return null for unexpected HW intrinsic (#24219)
Fix #17815
Fadi Hanna [Thu, 25 Apr 2019 14:17:19 +0000 (07:17 -0700)]
Fixing 23941 (#24199)
* Fixing 23941
The issue here is that in R2R code, unlike jitted IL code, the pinvoke calls are wrapped by a pair of calls to the JIT_PInvokeBegin and JIT_PInvokeEnd helpers, which link and unlink the InlinedCallFrame to the current thread. We do not initialize and link the ICF in the method prolog, and unlink it in the epilog, like jitted code does. We do this in the JIT helpers, right before/after the pinvoke call.
When an exception is thrown, the JIT_PInvokeEnd helper will be skipped since execution will resume at the nearest valid catch block, and the ICF will remain linked to the thread, which poses a problem if the method attempts another pinvoke operation (it will try to link the ICF which is already the top frame, and we'll end up in an infinite loop). Therefore, for the R2R case, we need to pop the ICF from the chain during exception unwinding.
Stephen Toub [Thu, 25 Apr 2019 14:06:02 +0000 (10:06 -0400)]
Nullable: Contract.cs and more interop (#24193)
* Nullable: Contract.cs and more interop
* Address PR feedback
Jan Vorlicek [Thu, 25 Apr 2019 09:32:31 +0000 (11:32 +0200)]
Fix NUMA node for heap when NUMA is not available
The recent refactoring of the GCToOSInterface::GetProcessorForHeap has
accidentally changed the NUMA node returned in case NUMA is disabled
(either via the COMPlus_GCNumaAware or due to the fact that there is
just a single NUMA node on the system) and the CPU groups are disabled.
Before that refactoring, the code was incorrectly returning 0 as the
NUMA node when CPU groups were disabled no matter whether NUMA was
enabled or disabled. The refactoring fixed that by returning the
current CPU group number for the case when NUMA was enabled, however
it still returned incorrect value, this time GroupProcNo::NoGroup as
the NUMA node number in case NUMA was disabled.
This change fixes it by returning the current group number in this case.
Andrew Au [Fri, 29 Mar 2019 00:07:16 +0000 (17:07 -0700)]
Postponing the managed callback so that they are called after the lock acquistion
Ludovic Henry [Thu, 25 Apr 2019 04:38:57 +0000 (21:38 -0700)]
Switch to workstation GC in case of constrained CPU resources (#24194)
* Switch to workstation GC in case of constrained CPU resources
Right now, if the user sets the configuration so that the server GC is
used, the server GC will be loaded even in conditions where we know the
workstation GC would fare better. An example of such conditions is
constrained environment where there is only 1 or less CPU or with very
low memory.
This can be harmful if users deploy the same projects on different kind
of platforms: deploying to a 20+ cores server and to Azure Functions
will require largely different configurations for the runtime.
There are already multiple ways for the user to specify to use the
server GC or not:
- setting `COMPlus_gcServer` as an environment variable
- setting `gcServer` in the configuration file
- setting `System.GC.Server` passed to `coreclr_initialize`
Fix https://github.com/dotnet/coreclr/issues/23949
* Address review
* Address review
Remove GCToOSInterface::GetCurrentProcessCpuLimit in favor of
GCToOSInterface::GetCurrentProcessCpuCount because the CpuLimit is taken
into account in the CpuCount again.
* Address review
Do the work in src/vm/ceemain.cpp otherwise there will be a disparity
between what the VM and the GC are running. Before, only the GC would be
aware of the switch from server to workstation GC, but not the VM.
Jim [Thu, 25 Apr 2019 02:50:47 +0000 (05:50 +0300)]
Added optional/default parameters for StreamWriter/StreamReader (#24056)
* Added optional/default parameters for StreamWriter/StreamReader
* Disabled outdated test
* Changed default encoding to UTF8NoBOM
* Made encoding parameter nullable
Jan Kotas [Thu, 25 Apr 2019 00:06:30 +0000 (17:06 -0700)]
Unify WIN32_FIND_DATA (dotnet/corefx#37158)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Mukul Sabharwal [Thu, 25 Apr 2019 00:27:06 +0000 (17:27 -0700)]
Add Medium GC Profiling Mode & ICorProfilerInfo::GetObjectReferences (#24156)
David Wrighton [Thu, 25 Apr 2019 00:01:31 +0000 (17:01 -0700)]
More multi-appdomain support removal (#23921)
More multi-appdomain support removal
- Remove DomainLocalBlock
- Remove DomainModule
- Remove FindDomain(File/Module/Assembly)
- Remove GetDomainModule
- Remove variants of GetDomain(File/Assembly) that take AppDomain parameter
- Adjust contracts to be less strict
- GetDomainFile/Assembly no longer need a complex contract as multi-domain support does not exist
- Eliminiate uses of encoded ModuleID
Jan Vorlicek [Wed, 24 Apr 2019 23:07:42 +0000 (01:07 +0200)]
Fix crossgen with large version bubble enabled
This change fixes about 1483 failing Pri-1 tests when they are
crossgen-ed with large version bubble enabled. Only one failing test
remains.
60% of the test cases were failing due to a failure to find generic
interface in an interface map due to the fact that the interface type
was being passed in canonical form.
The remaining 40% were tests using constrained calls. We were missing
the ENCODE_METHOD_SIG_Constrained in the method flags.
Bruce Forstall [Wed, 24 Apr 2019 22:50:59 +0000 (15:50 -0700)]
Merge pull request #24226 from BruceForstall/Disable24224
Disable mandelbrot-7 against #24224
Bruce Forstall [Wed, 24 Apr 2019 22:50:21 +0000 (15:50 -0700)]
Merge pull request #24227 from BruceForstall/Disable24173
Disable _il_dbgu_fld under GCStress against #24173
Sung Yoon Whang [Wed, 24 Apr 2019 21:00:31 +0000 (14:00 -0700)]
Fixing issue where LTTng probe check disables GC events (#24198)
dotnet-maestro [Wed, 24 Apr 2019 12:23:03 +0000 (12:23 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190423.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19223.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19223.2
dotnet-maestro [Tue, 23 Apr 2019 12:22:38 +0000 (12:22 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190422.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19222.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19222.2
dotnet-maestro [Sat, 20 Apr 2019 12:17:37 +0000 (12:17 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190418.7
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19218.7
dotnet-maestro [Fri, 19 Apr 2019 12:20:27 +0000 (12:20 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190418.4
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19218.4
dotnet-maestro [Thu, 18 Apr 2019 12:23:59 +0000 (12:23 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190418.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19218.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19218.1
dotnet-maestro [Wed, 17 Apr 2019 12:25:01 +0000 (12:25 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190417.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19217.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19217.1
Bruce Forstall [Wed, 24 Apr 2019 19:57:32 +0000 (12:57 -0700)]
Disable _il_dbgu_fld under GCStress against #24173
Bruce Forstall [Wed, 24 Apr 2019 19:42:57 +0000 (12:42 -0700)]
Disable mandelbrot-7 against #24224
Michal Strehovský [Wed, 24 Apr 2019 13:24:31 +0000 (15:24 +0200)]
Fix ProjectN build breaks (dotnet/corert#7343)
Porting changes from the non-WinRT files.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Bruce Forstall [Wed, 24 Apr 2019 18:59:52 +0000 (11:59 -0700)]
Merge pull request #24222 from BruceForstall/AddCorefxExclusions
Expand corefx exclusions
Bruce Forstall [Wed, 24 Apr 2019 18:58:38 +0000 (11:58 -0700)]
Expand corefx exclusions
Jeremy Koritzinsky [Wed, 24 Apr 2019 18:50:14 +0000 (11:50 -0700)]
Update IBCMerge and ensure that it runs when in a release build and ibcoptimize is set. (#24205)
* Update IBCMerge and ensure that it runs when in a release build and ibcoptimize is set.
* Add major rollforward for ibcmerge.
William Godbe [Wed, 24 Apr 2019 18:49:32 +0000 (11:49 -0700)]
Merge pull request #24206 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr to preview6-27624-71 (master)
Bruce Forstall [Wed, 24 Apr 2019 17:22:28 +0000 (10:22 -0700)]
Merge pull request #24218 from BruceForstall/FixLinuxX64CorefxTesting
Remove extraneous percent character in Linux/x64 corefx testing command
Bruce Forstall [Wed, 24 Apr 2019 17:21:00 +0000 (10:21 -0700)]
Remove extraneous percent character in Linux/x64 corefx testing command
dotnet-maestro[bot] [Wed, 24 Apr 2019 14:52:26 +0000 (14:52 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190424.1 (#24214)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190424.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190424.1
dotnet-maestro-bot [Wed, 24 Apr 2019 13:05:02 +0000 (06:05 -0700)]
Update CoreClr to preview6-27624-71
Jeremy Koritzinsky [Wed, 24 Apr 2019 05:01:47 +0000 (22:01 -0700)]
Match managed DetermineLibraryNameVariations implementation to native DetermineLibNameVariations implementation. (#24203)
* Match managed DetermineLibraryNameVariations implementation to native DetermineLibNameVariations implementation.
* Update AssemblyDependencyResolver.cs
* Use ordinal comparison instead of culture-specific comparison
Jan Kotas [Wed, 24 Apr 2019 03:21:09 +0000 (20:21 -0700)]
Delete unnecessary static and update GCSample to VS2019 (#24204)
Bruce Forstall [Tue, 23 Apr 2019 23:34:57 +0000 (16:34 -0700)]
Merge pull request #24201 from BruceForstall/AllowFineGrainedCorefxTestExclusions
Enable fine-grained and universal exclusions for CoreFX tests
dotnet-maestro-bot [Tue, 23 Apr 2019 23:28:07 +0000 (16:28 -0700)]
Update CoreClr to preview6-27623-73 (#24200)
Anirudh Agnihotry [Tue, 23 Apr 2019 22:39:32 +0000 (15:39 -0700)]
Revert "Dummy commit" (#24197)
Bruce Forstall [Tue, 23 Apr 2019 21:12:32 +0000 (14:12 -0700)]
Enable fine-grained and universal exclusions for CoreFX tests
One problem we've had in coreclr Jenkins when running corefx
tests (in the coreclr outerloop runs -- the ones using the
run-corefx-tests.py harness) is the inability to exclude
failing tests for x86 or x64, and the inability to have
fine-grained exclusions. This has led to problems like
https://github.com/dotnet/coreclr/issues/22442 where
virtually all Windows x86 and x64 corefx runs fail due to
timeouts. And issues like https://github.com/dotnet/coreclr/issues/24159
where all corefx test legs fail, and we have no control
over exclusions to get them all passing again quickly.
Now that the corefx RunTests.cmd/sh wrapper scripts
parse named arguments, including a response file that
is passed on to xunit, and also that the corefx used
xunit has support for this response file as well as
fine-grained exclusions (per-method/per-class/per-namespace),
we can take advantage of it.
This change adds a single, global, corefx xunit exclusion
response file, that will be used for all platforms. Since this
run-corefx-tests.py mechanism is not expected to live much longer,
this seems sufficient.
Tarek Mahmoud Sayed [Tue, 23 Apr 2019 20:58:54 +0000 (13:58 -0700)]
Fix failures caused by ICU regression (#24190)
Fixes https://github.com/dotnet/corefx/issues/37098
.NET Core depends on ICU when running on Linux/OSX. Recently some people raised some failure on the framework stack. After investigation we found a regression in ICU which is the root cause of this failure. The regression is, when calling ICU to get some date patterns/properties, in some cases ICU return error code U_MISSING_RESOURCE_ERROR. Although the framework code written to fallback to some invariant values at that time, but we had some wrong line of code which assumed we never fail and trying to access the returned value without checking. That cause the framework to throw NullReferenceException.
The fix here is to make the framework resilient against such cases and continue to run nicely. I have contact ICU support members and I learned there is similar issue tracked in ICU repo https://unicode-org.atlassian.net/browse/ICU-20558
Brian Sullivan [Tue, 23 Apr 2019 20:22:16 +0000 (13:22 -0700)]
Merge pull request #23932 from briansull/zero-offset-map
Fixes for tracking struct field sequences
Jan Vorlicek [Tue, 23 Apr 2019 20:14:58 +0000 (22:14 +0200)]
Fix crash after unload with server GC (#24196)
When server GC is on, the DomainAssembly::EnumStaticGCRefs is called to
enumerate GC statics. For collectible assemblies, the GC statics are
stored in managed arrays and so there is no need for a special
enumeration of the GC statics. Attempt to do that was causing a crash
due to the fact that the corresponding DomainLocalModule::m_pGCStatics
is always NULL for collectible assemblies and we were trying to access
it.
Anirudh Agnihotry [Tue, 23 Apr 2019 19:56:09 +0000 (12:56 -0700)]
Nullable : System.Diagnostics.Eventing (Directory) (#24192)
* Eventing directory done
* adding comment and fixing unix build
Michal Strehovský [Tue, 23 Apr 2019 19:18:25 +0000 (21:18 +0200)]
Add test coverage for static members on interfaces (#23928)
This has been supported since v1 but we don't have much test coverage.
C# is going to enable interfaces to have static members and static constructors so we better start testing it.
Anirudh Agnihotry [Tue, 23 Apr 2019 18:21:57 +0000 (11:21 -0700)]
Merge pull request #24195 from Anipik/temp
Dummy commit
Anipik [Tue, 23 Apr 2019 18:20:03 +0000 (11:20 -0700)]
Dummy commit
Brian Sullivan [Tue, 23 Apr 2019 17:00:42 +0000 (10:00 -0700)]
Added additional comment explaining ChnageOper(GT_LCL_FLD) and NotAField
dotnet-maestro[bot] [Tue, 23 Apr 2019 15:17:39 +0000 (08:17 -0700)]
[master] Update dependencies from dotnet/corefx (#24148)
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19222.12
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview6.19222.12
dotnet-maestro[bot] [Tue, 23 Apr 2019 15:16:36 +0000 (08:16 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#24150)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190423.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190423.1
dotnet-maestro-bot [Tue, 23 Apr 2019 15:14:44 +0000 (08:14 -0700)]
Update CoreClr to preview6-27623-71 (#24152)
Stephen Toub [Tue, 23 Apr 2019 14:18:46 +0000 (10:18 -0400)]
Fix handling of negative numbers in ThreadPool.SetMin/MaxThreads (#24163)
* Fix handling of negative numbers in ThreadPool.SetMin/MaxThreads
* Fix disabled test name
Koundinya Veluri [Tue, 23 Apr 2019 06:31:37 +0000 (23:31 -0700)]
Implement APIs for some threading metrics (CoreRT) (dotnet/corert#7066)
* Implement APIs for some threading metrics (CoreRT)
- API review: https://github.com/dotnet/corefx/issues/35500
- May depend on https://github.com/dotnet/coreclr/pull/22754
* Use thread-locals for counting, use finalizer instead of runtime to detect thread exit
* Don't let the count properties throw OOM
* Remove some flushes
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Bruce Forstall [Mon, 22 Apr 2019 23:32:22 +0000 (16:32 -0700)]
Merge pull request #24176 from BruceForstall/Fix24175
Disable 2 GC tests under HeapVerify for arm64
Bruce Forstall [Mon, 22 Apr 2019 23:01:08 +0000 (16:01 -0700)]
Merge pull request #24174 from BruceForstall/Fix24172
Disable _il_relthread-race test under GCStress
Bruce Forstall [Mon, 22 Apr 2019 21:37:08 +0000 (14:37 -0700)]
Disable 2 GC tests under HeapVerify for arm64
They fail due to timeout with `COMPlus_HeapVerify=1` on arm64.
They were already being disabled for HeapVerify for x86 and arm32.
Fixes #24175
Bruce Forstall [Mon, 22 Apr 2019 20:07:14 +0000 (13:07 -0700)]
Disable _il_relthread-race test under GCStress
It takes too long, and times out in CI.
Fixes #24172
William Godbe [Mon, 22 Apr 2019 19:13:55 +0000 (12:13 -0700)]
Merge pull request #24168 from wtgodbe/p6
Update branding in master to preview6
wtgodbe [Mon, 22 Apr 2019 19:01:18 +0000 (12:01 -0700)]
Update branding in master to preview6
Steve MacLean [Mon, 22 Apr 2019 18:23:04 +0000 (14:23 -0400)]
Fix `CORE_LIBRARIES` doc
Sinan Kaya [Mon, 22 Apr 2019 17:09:21 +0000 (13:09 -0400)]
Correct iterator (#24160)
Russ Keldorph [Mon, 22 Apr 2019 12:48:33 +0000 (05:48 -0700)]
Disable failing IJW tests against #23358
Steve MacLean [Mon, 22 Apr 2019 14:07:13 +0000 (10:07 -0400)]
Remove create assembly name (#24154)
* Remove RuntimeAssembly.CreateAssemblyName
Fixes #24135
CreateAssemblyName was not compatible with AssemblyLoadContext isolation.
Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)
* Remove unused AssemblyNameNative::Init arguments
* Temp disable corefx CreateInstanceAssemblyResolve
Carol Eidt [Mon, 22 Apr 2019 11:04:59 +0000 (04:04 -0700)]
Fix Arm64 UpperVector save/restore (#24043)
* Fix Arm64 UpperVector save/restore
Change the general handling of end-of-block restores so that we always have a RefPosition on which to allocate the register needed on Arm64.
Fix #23885
Steve MacLean [Sun, 21 Apr 2019 22:25:04 +0000 (18:25 -0400)]
Fix AssemblyName cache hash and key (#24138)
* Add ContextualReflection LoadWithPartialName case
* Remove unnecessary MethodImplOptions.NoInlining
* Remove m_assembly warning
* Fix AssemblyName hash function
* AssemblyNative::Load fix stackMark usage
Do not use the stackMark if (ptrLoadContextBinder != NULL)
* Temporarily disable DefaultContextOverrideTPA
Test is failing due to a logic error.
Fix is pending in https://github.com/dotnet/corefx/pull/37071
Yoh Deadfall [Sun, 21 Apr 2019 16:59:20 +0000 (19:59 +0300)]
Fixed link to .NET Core SDK (#24147)
dotnet-maestro-bot [Sun, 21 Apr 2019 03:37:21 +0000 (20:37 -0700)]
Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively (master) (#24060)
* Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively
* Fix build errors
* Disable warning with pragma and linked issue
dotnet-maestro[bot] [Sun, 21 Apr 2019 03:31:53 +0000 (20:31 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#24120)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190420.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190420.1
dotnet-maestro[bot] [Sat, 20 Apr 2019 23:31:19 +0000 (19:31 -0400)]
Update dependencies from https://github.com/dotnet/corefx build
20190419.11 (#24141)
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.11
Sung Yoon Whang [Sat, 20 Apr 2019 22:56:19 +0000 (15:56 -0700)]
Eventpipe Crst ordering fix (#24101)
* Adding PendingTypeLoadEntry to Crst order for EventPipeCrst
* update header file
Andrew Au [Sat, 20 Apr 2019 20:18:54 +0000 (13:18 -0700)]
Tighten asserts (#24124)
dotnet-maestro[bot] [Sat, 20 Apr 2019 20:15:49 +0000 (13:15 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190420.01 (#24142)
- Microsoft.NETCore.App - 3.0.0-preview5-27620-01
Sergey Andreenko [Sat, 20 Apr 2019 08:49:30 +0000 (01:49 -0700)]
Merge pull request #24131 from sandreenko/addAReproTest
Add a repro test for #24114.
Steve MacLean [Sat, 20 Apr 2019 06:07:42 +0000 (02:07 -0400)]
Fix Timezone whitespace (#24137)
Aaron Robinson [Sat, 20 Apr 2019 05:11:39 +0000 (22:11 -0700)]
The thread triggering finalizer shutdown events should be in an alertable state. (#24133)
Tanner Gooding [Sat, 20 Apr 2019 03:33:46 +0000 (20:33 -0700)]
Pulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (#24123)
* Update dependencies from https://github.com/dotnet/corefx build
20190419.5
- Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.5
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.5
* Removing the Sse2.StoreLow(long/ulong*, ...) methods that have been replaced
* Moving the Sse2.StoreLow(long/ulong*, ...) tests to be Sse2.StoreScalar tests
* Fixing some existing usages of Sse2.StoreLow(long/ulong*, ...)
Koundinya Veluri [Sat, 20 Apr 2019 02:22:53 +0000 (19:22 -0700)]
Implement APIs for some threading metrics (CoreCLR) (#24113)
Implement APIs for some threading metrics (CoreCLR)
API review: https://github.com/dotnet/corefx/issues/35500
Sergey Andreenko [Fri, 19 Apr 2019 22:42:23 +0000 (15:42 -0700)]
Add a repro test.
Sergey Andreenko [Sat, 20 Apr 2019 01:05:58 +0000 (18:05 -0700)]
Merge pull request #24126 from sandreenko/fixStmtBug
Fix bug in impGetStructAddr.
Sergey Andreenko [Fri, 19 Apr 2019 22:49:39 +0000 (15:49 -0700)]
Fix `impGetStructAddr`.
Brian Sullivan [Sat, 20 Apr 2019 00:32:35 +0000 (17:32 -0700)]
Code review feedback
Sergey Andreenko [Sat, 20 Apr 2019 00:15:02 +0000 (17:15 -0700)]
Merge pull request #24127 from sandreenko/fixArmUbuntuCoreFXTesting
Fix Arm32 Ubuntu CoreFX script.
Brian Sullivan [Tue, 16 Apr 2019 16:52:11 +0000 (09:52 -0700)]
Fixes for Zero Offset field sequence tracking
- A GT_LCL_VAR may have a zeroOffset field
- Add an assert to prevent building field sequences with duplicates
- Fix fgMorphField when we have a zero offset field
Improve fgAddFieldSeqForZeroOffset
- Add JItDump info
- Handle GT_LCL_FLD
Changing the sign of an int constant also remove any field sequence information.
Added method header comment for fgAddFieldSeqForZeroOffset
Changed when we call fgAddFieldSeqForZeroOffset to be before the call to fgMorphSmpOp.
Prefer calling fgAddFieldSeqForZeroOffset() to GetZeroOffsetFieldMap()->Set()
Sergey Andreenko [Fri, 19 Apr 2019 23:15:34 +0000 (16:15 -0700)]
Fix Arm32 Ubuntu CoreFX script.