platform/upstream/dotnet/runtime.git
7 years agoAdding MemoryHandle AddOffset to fix Memory.Retain impl (dotnet/corefx#24323)
Ahson Ahmed Khan [Mon, 2 Oct 2017 21:18:15 +0000 (14:18 -0700)]
Adding MemoryHandle AddOffset to fix Memory.Retain impl (dotnet/corefx#24323)

* Adding MemoryHandle AddOffset to fix Memory.Retain impl

* Adding AddOffset to System.Runtime ref.

* Make the AddOffset API internal.

Commit migrated from https://github.com/dotnet/corefx/commit/b9676be62166e90a07763f070330a9ffc8ef6cc7

7 years agoMake the public class be internal in sgen. (dotnet/corefx#24345)
Huangli Wu [Mon, 2 Oct 2017 20:45:16 +0000 (13:45 -0700)]
Make the public class be internal in sgen. (dotnet/corefx#24345)

* Make the public class be internal in sgen.

* Make Sgen class be internal.

* Make XmlSerializationWriteCallback be internal in SGEN.

Commit migrated from https://github.com/dotnet/corefx/commit/b5626e6a1cbeb56d272f015e06259a4dfb7a40dc

7 years agoMerge pull request dotnet/corefx#24349 from dotnet-maestro-bot/master-UpdateDependencies
Stephen Toub [Mon, 2 Oct 2017 19:33:56 +0000 (15:33 -0400)]
Merge pull request dotnet/corefx#24349 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02102-01, preview1-25730-01, preview1-25802-02, preview1-25802-01, preview1-25802-01, respectively (master)

Commit migrated from https://github.com/dotnet/corefx/commit/63eeffc7a0cddd212f0a98089d7b679d2dd8d6c1

7 years agoFix DebuggerDisplay for XmlNode (dotnet/corefx#24367)
Stephen Toub [Mon, 2 Oct 2017 19:33:00 +0000 (15:33 -0400)]
Fix DebuggerDisplay for XmlNode (dotnet/corefx#24367)

Somewhere along the way XmlNode's debuggerDisplayProxy property was removed.  That doesn't break the build, as it's only used via reflection, but it does break the debugger display tooltip.

This just copy-and-pastes the corresponding implementation from reference source to fix it.  The only other change I made was renaming "node" to "_node" and making it readonly.

Commit migrated from https://github.com/dotnet/corefx/commit/ae2ea6649e7d4e780277e6bcdeb102f7d8fd60d3

7 years agoDisable Tizen leg for PRs
Stephen Toub [Mon, 2 Oct 2017 19:23:19 +0000 (15:23 -0400)]
Disable Tizen leg for PRs

Commit migrated from https://github.com/dotnet/corefx/commit/570a91f9316a9fbab170aa83752ee5ccde7c2341

7 years agoAdding {ReadOnly}Memory<T> debugger view (dotnet/corefx#24203)
Ahson Ahmed Khan [Mon, 2 Oct 2017 19:17:48 +0000 (12:17 -0700)]
Adding {ReadOnly}Memory<T> debugger view (dotnet/corefx#24203)

* Adding {readonly}memory debugger view.

* Addressing PR feedback.

* Removing unnecessary using directives.

* Updating to master. Changing use of AsSpan to Span.

* Using workaround for VSTS bug 286592 and reverting back to Span.ToArray.

* Adding RO span debug view and updating debugger display string.

* Adding link to VSTS bug for clarity.

* Removing redundant info in comments.

Commit migrated from https://github.com/dotnet/corefx/commit/8d212b41126baff94fc025e4438d6f4e8cbff7e9

7 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02102-01, previ...
dotnet-maestro-bot [Mon, 2 Oct 2017 18:13:48 +0000 (11:13 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02102-01, preview1-25730-01, preview1-25802-02, preview1-25802-01, preview1-25802-01, respectively

Commit migrated from https://github.com/dotnet/corefx/commit/a2a0525001dae85578c739ba15b2321199e4fc6f

7 years agoMerge pull request dotnet/corefx#24116 from stephentoub/orderby_perf
Stephen Toub [Mon, 2 Oct 2017 17:33:52 +0000 (13:33 -0400)]
Merge pull request dotnet/corefx#24116 from stephentoub/orderby_perf

Use Array.Sort instead of custom QuickSort implementation in LINQ's OrderBy

Commit migrated from https://github.com/dotnet/corefx/commit/ed0ee133ac49cee86f10ca4692b1d72e337bc012

7 years agoMake GetProcessInfo() for a single PID cheaper on Windows (dotnet/corefx#24198)
dnickless [Mon, 2 Oct 2017 16:47:54 +0000 (18:47 +0200)]
Make GetProcessInfo() for a single PID cheaper on Windows (dotnet/corefx#24198)

* Improved performance of local process information retrieval by not constructing all ProcessInfo instances for all running processes anymore if only one is of interest.

* Removed superfluous space characters only

* Remove superfluous default parameter value

* Added a Debug.Assert()

* Moved a variable from the .Win32 file into the .Windows file in order to fix the UAP build and improved a Debug.Assert() message

* Attempt to make the UAP build happy again

* Removed the optionality of the "int processId" parameter from NtProcessInfoHelper.GetProcessInfos() to try and make the UAP build happy.

* Revert "Removed the optionality of the "int processId" parameter from NtProcessInfoHelper.GetProcessInfos() to try and make the UAP build happy."

This reverts commit dotnet/corefx@78ef4706f412d00d8396a073bd73f9fbd87a5696.

* Revert "Attempt to make the UAP build happy again"

This reverts commit dotnet/corefx@9ca6a02f2d2886ed9acc7e9643307e0ba0ca94b8.

* Fixed UAP builds by creating an NtProcessInfoHelper type with a contained GetProcessInfos(int processId = AllProcessIds) method in the ProcessManager.Uap.cs file which will just throw a NotSupportedException

* Aligned the implementations of GetProcessInfos(string machineName) for both Uap and Win32 into a shared Windows method (possible now because of previous check-in)

* Switched to a Predicate<T> based implementation instead of the "AllProcessIds = -1" magic number based version

Commit migrated from https://github.com/dotnet/corefx/commit/ebf11343ff80295d49607eef5114df917e45f9bb

7 years agoNew tests covering GC.TryStartNoGCRegion (dotnet/corefx#24201)
Sean Gillespie [Mon, 2 Oct 2017 16:29:43 +0000 (09:29 -0700)]
New tests covering GC.TryStartNoGCRegion (dotnet/corefx#24201)

* Add a number of TryStartNoGCRegion tests for corner case parameter validation

* Combine two related tests into a single theory

Commit migrated from https://github.com/dotnet/corefx/commit/82374ba7b930bdb836a6bfd27c794068ba981e10

7 years agoFix RHEL.6 CI build (dotnet/corefx#24331)
Jan Vorlicek [Mon, 2 Oct 2017 15:05:38 +0000 (17:05 +0200)]
Fix RHEL.6 CI build (dotnet/corefx#24331)

I have missed msbuild options separator in the build.sh
invocation when adding the /p:PortableBuild=false option.

Commit migrated from https://github.com/dotnet/corefx/commit/df8e3b568b3115e09df264dd891f218c5d288385

7 years agoAvoid deadlock on NamedPipeTest.Specific on UWP (dotnet/corefx#24348)
Paulo Janotti [Sat, 30 Sep 2017 04:06:02 +0000 (21:06 -0700)]
Avoid deadlock on NamedPipeTest.Specific on UWP (dotnet/corefx#24348)

* Avoid deadlock on NamedPipeTest.Specific on UWP

For now this test is not running in UWP but this change prevents the
test from deadlocking if some of the blocking steps fail.

* Fix typo on method names

Commit migrated from https://github.com/dotnet/corefx/commit/1525832151f05d790d7cd311ec87597e77fbf9fd

7 years agoMerge pull request dotnet/corefx#24306 from ericstj/buildRuntimeJson
Eric StJohn [Fri, 29 Sep 2017 23:49:19 +0000 (16:49 -0700)]
Merge pull request dotnet/corefx#24306 from ericstj/buildRuntimeJson

Don't update runtime.*.json during the build

Commit migrated from https://github.com/dotnet/corefx/commit/4c7b6465d8dcb944d08a3eb355689ea813acea67

7 years agoMerge pull request dotnet/corefx#24315 from mikem8361/llvm3.9a
Mike McLaughlin [Fri, 29 Sep 2017 22:49:30 +0000 (15:49 -0700)]
Merge pull request dotnet/corefx#24315 from mikem8361/llvm3.9a

Update build to clang/llvm 3.9

Commit migrated from https://github.com/dotnet/corefx/commit/28615b146b0ecc0f36f2bd879d13eea4847a8565

7 years agoAdd more parameters support in SGEN. (dotnet/corefx#24322)
Huangli Wu [Fri, 29 Sep 2017 22:00:36 +0000 (15:00 -0700)]
Add more parameters support in SGEN. (dotnet/corefx#24322)

* Add more parameters support in SGEN.

* Add the change in Strings.resx

* rename nolog to noLogo, parsableerrors to parsableErrors.

Commit migrated from https://github.com/dotnet/corefx/commit/024f17e558dcc2666a336d6d60c9da3981d1d3db

7 years agoMerge pull request dotnet/corefx#24313 from shmao/RemoveRdXml
Shin Mao [Fri, 29 Sep 2017 21:12:17 +0000 (14:12 -0700)]
Merge pull request dotnet/corefx#24313 from shmao/RemoveRdXml

Removed Microsoft.XmlSerializer.Generator's rd.xml

Commit migrated from https://github.com/dotnet/corefx/commit/6d3804c5d9edec46c85797701834bbb135c8500f

7 years agoFix handling of empty inputs to TakeLast (dotnet/corefx#24328)
Stephen Toub [Fri, 29 Sep 2017 19:37:25 +0000 (15:37 -0400)]
Fix handling of empty inputs to TakeLast (dotnet/corefx#24328)

It currently ends up trying to remove an element from an empty queue, causing an exception.

Commit migrated from https://github.com/dotnet/corefx/commit/f74844b5b90ca9f3fda8439349071f549df03d43

7 years agoRun GenerateRuntimeGraph during build
Eric St. John [Fri, 29 Sep 2017 19:29:02 +0000 (12:29 -0700)]
Run GenerateRuntimeGraph during build

This turns GenerateRuntimeGraph back on, but it will now only check consistency of the
generated runtime files with what is checked in.

If it detects an inconsistency the build will fail and this project can be rebuilt specifying
/p:UpdateRuntimeFiles=true to commit the updates.

Commit migrated from https://github.com/dotnet/corefx/commit/989a84f355eb6df5612f37bc783510e2d6b4e4c9

7 years agoMerge pull request dotnet/corefx#24208 from qmfrederik/drawing/mono-codec-tests
Eric Mellino [Fri, 29 Sep 2017 16:32:20 +0000 (09:32 -0700)]
Merge pull request dotnet/corefx#24208 from qmfrederik/drawing/mono-codec-tests

Tests Drawing Codecs (based on Mono's test suite)

Commit migrated from https://github.com/dotnet/corefx/commit/25b0a9b6f784216de7f357ba680aa9a835ad3cba

7 years agoFirst DirectoryServcies tests which runs against real server (dotnet/corefx#24316)
Tarek Mahmoud Sayed [Fri, 29 Sep 2017 15:50:11 +0000 (08:50 -0700)]
First DirectoryServcies tests which runs against real server (dotnet/corefx#24316)

* First DirectoryServcies tests which runs against real server

* Fix msbuild failure with None element

* Address the feedback

* Fix some formatting

Commit migrated from https://github.com/dotnet/corefx/commit/f4c2ba68f9e0b0f8735ce4eaecd71a207f520bd1

7 years agoUpdate Standard to preview1-25729-01 (dotnet/corefx#24330)
dotnet-maestro-bot [Fri, 29 Sep 2017 15:37:32 +0000 (10:37 -0500)]
Update Standard to preview1-25729-01 (dotnet/corefx#24330)

Commit migrated from https://github.com/dotnet/corefx/commit/63df758be847ce00422ac2e9bf473282aef94d31

7 years agoMerge pull request dotnet/corefx#24288 from stephentoub/websocket_managedhandler
Stephen Toub [Fri, 29 Sep 2017 11:14:18 +0000 (07:14 -0400)]
Merge pull request dotnet/corefx#24288 from stephentoub/websocket_managedhandler

Use ManagedHandler in managed ClientWebSocket

Commit migrated from https://github.com/dotnet/corefx/commit/ed12fd8ed08a71af95accf545c90fc41eff75a57

7 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-25729-00, beta-25729-00, respectively...
dotnet-maestro-bot [Fri, 29 Sep 2017 06:49:06 +0000 (01:49 -0500)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25729-00, beta-25729-00, respectively (dotnet/corefx#24326)

Commit migrated from https://github.com/dotnet/corefx/commit/9a66ec30c0340f992a4924cbdebad499657aaa8c

7 years agoRevert "Conditionally run namedPipes tests in uap if windows version contains fix...
Paulo Janotti [Fri, 29 Sep 2017 05:25:00 +0000 (22:25 -0700)]
Revert "Conditionally run namedPipes tests in uap if windows version contains fix (dotnet/corefx#24307)" (dotnet/corefx#24324)

This reverts commit dotnet/corefx@161267c8645d4fd4cde51c3783d3c9326ed034f1. Fixes dotnet/corefx#24318

Commit migrated from https://github.com/dotnet/corefx/commit/475bfdd5b0b2bcc21b5fd96f4dabf07b9ac418c8

7 years agoUpdate BuildTools, CoreFx, CoreSetup to prerelease-02029-01, preview1-25729-01, previ...
dotnet-maestro-bot [Fri, 29 Sep 2017 03:20:36 +0000 (22:20 -0500)]
Update BuildTools, CoreFx, CoreSetup to prerelease-02029-01, preview1-25729-01, preview1-25728-02, respectively (dotnet/corefx#24314)

Commit migrated from https://github.com/dotnet/corefx/commit/198205322cde8120c731c48e4c877fb14c467674

7 years agoAddress PR feedback
Stephen Toub [Thu, 28 Sep 2017 15:09:12 +0000 (11:09 -0400)]
Address PR feedback

- Have ClientWebSocket change the scheme from http{s} -> ws{s} instead of having HttpClient accept ws{s} urls.
- Use a duplex response stream only when the status code is 101
- Disable a test that relies on connection opening being cancelable

Commit migrated from https://github.com/dotnet/corefx/commit/518ea1c2f8ad882c9829c8c35d27d92063ac67f7

7 years agoUse ManagedHandler in managed ClientWebSocket
Stephen Toub [Wed, 27 Sep 2017 21:07:26 +0000 (17:07 -0400)]
Use ManagedHandler in managed ClientWebSocket

ClientWebSocket's managed implementation currently has its own basic Socket-based code for establishing a websocket connection.  This change switches it to use ManagedHandler instead, and in doing so benefits from improvements made to ManagedHandler thus far and in the future.  For example, currently ManagedWebSocket doesn't support ClientWebSocketOptions.Proxy or ClientWebSocketOptions.Credentials, but since ManagedHandler does, now ManagedWebSocket does, too.

Commit migrated from https://github.com/dotnet/corefx/commit/db9f342cc43e0096b42d4d6d008c095da2bb8cfa

7 years agoMake several allocations from ClientWebSocketOptions lazy
Stephen Toub [Wed, 27 Sep 2017 20:57:31 +0000 (16:57 -0400)]
Make several allocations from ClientWebSocketOptions lazy

Commit migrated from https://github.com/dotnet/corefx/commit/87ae016da78b9a29be33cc17f076b32c57c2a699

7 years agoSeveral HttpClient/ManagedHandler fixes to better support ClientWebSocket
Stephen Toub [Wed, 27 Sep 2017 20:53:53 +0000 (16:53 -0400)]
Several HttpClient/ManagedHandler fixes to better support ClientWebSocket

- Allow ws:// and wss:// schemes
- Add an HttpContentDuplexStream base class to parallel the existing HttpContentReadStream and HttpContentWriteStream base classes
- Move more shared functionality down to the base HttpContentStream class
- Make ConnectionCloseStream duplex instead of read-only

Commit migrated from https://github.com/dotnet/corefx/commit/9438b0a760b1ef827729662186e107abccb7524d

7 years agoFix several Connect test's dependence on ReceiveAsync returning complete message
Stephen Toub [Wed, 27 Sep 2017 20:12:55 +0000 (16:12 -0400)]
Fix several Connect test's dependence on ReceiveAsync returning complete message

There's no guarantee that WebSocket.ReceiveAsync will return a complete message; in the extreme, a message can contain long.MaxValue bytes but the API only allows you to retrieve ~int.MaxValue at a time, but even way below that, it's common for ReceiveAsync to return the data it has available rather than gathering up all of the data from the message.  However, several of the ConnectTest tests were depending on the full-message behavior.  This commit fixes that.

Commit migrated from https://github.com/dotnet/corefx/commit/ffaf5375c00622b285997bc9626c042b9d64195c

7 years agoStop using ArrayPool<byte> for ManagedWebSocket's receive buffer
Stephen Toub [Wed, 27 Sep 2017 19:25:31 +0000 (15:25 -0400)]
Stop using ArrayPool<byte> for ManagedWebSocket's receive buffer

We end up draining the relevant bucket in the pool very quickly, such that we still end up doing a lot of allocating while also harming other users of the same bucket size.

Commit migrated from https://github.com/dotnet/corefx/commit/7eedd7c8c6bd3729697878afecac6bb9b225b69b

7 years agoReduce spurious completions in ManagedWebSocket
Stephen Toub [Wed, 27 Sep 2017 19:20:38 +0000 (15:20 -0400)]
Reduce spurious completions in ManagedWebSocket

Currently if a web socket message arrives but not all of its data is there, ManagedWebSocket.ReceiveAsync will manufacture a non-EndOfMessage WebSocketReceiveResult with the available data.  This means for larger messages, we end up artificially splitting the messages, which in turns leads to all of the async methods up the stack doing extra allocations due to needing to call back in to get the remainder of the message.  While the approach does allow for the consumer to start processing the data from the message immediately, in most cases the consumer needs the full message anyway.  So we can avoid these costs by being more aggressive about reading the full message size, up to whatever receive buffer we have to work with.

Commit migrated from https://github.com/dotnet/corefx/commit/8bfe84e7e19632894de5ee9be46190a33e518273

7 years agoReduce running time of KeepAlive_LongDelayBetweenSendReceives_Succeeds test
Stephen Toub [Wed, 27 Sep 2017 13:39:40 +0000 (09:39 -0400)]
Reduce running time of KeepAlive_LongDelayBetweenSendReceives_Succeeds test

60 seconds is annoyingly long when trying to iterate.  Reduced to 10.

Commit migrated from https://github.com/dotnet/corefx/commit/941c4c80f0d25b34808d19adc7f8556107a88718

7 years agoAvoid blocking ThreadPool threads in cancelable NamedPipe*Stream.ReadAsync on Unix...
Stephen Toub [Fri, 29 Sep 2017 00:03:16 +0000 (20:03 -0400)]
Avoid blocking ThreadPool threads in cancelable NamedPipe*Stream.ReadAsync on Unix (dotnet/corefx#24302)

Named pipes on Unix are implemented via sockets.  When a ReadAsync is issued, that it turns results in a ReceiveAsync on the socket.  But today we lack a ReceiveAsync overload that takes a CancellationToken, and until such an overload exists, we need a workaround.

Today's workaround involves polling and blocking a thread pool thread doing a synchronous read; that's very expensive, especially when many such calls are made across one or more pipes and we end up blocking many threads.

This PR provides an alternative workaround.  Instead of queueing a blocking poll to the thread pool, we issue a zero-length async receive so that we're notified when data is available, and we concurrently monitor the cancellation token.  This is more efficient when cancellation doesn't occur.  If cancellation does occur, we potentially "leak" the read request until data is available (or the socket closes), but cancellation is relatively rare, and even more rare is reusing the stream after cancellation has occurred, so this shouldn't be much more than a small fixed overhead.

Commit migrated from https://github.com/dotnet/corefx/commit/668b634b6653d5eb0b8f65044e601805ad890957

7 years agoRemoved Microsoft.XmlSerializer.Generator's rd.xml
Xing Mao [Thu, 28 Sep 2017 21:32:29 +0000 (14:32 -0700)]
Removed Microsoft.XmlSerializer.Generator's rd.xml

Commit migrated from https://github.com/dotnet/corefx/commit/377b119c55304c28b71aae6c7f178be6f501da57

7 years agoPR feeback - code cleanup
Frederik Carlier [Thu, 28 Sep 2017 21:04:17 +0000 (23:04 +0200)]
PR feeback - code cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/bde4f33dcf16fa56d078b0d29874ab10708cc04e

7 years agoPR feedback - code cleanup
Frederik Carlier [Thu, 28 Sep 2017 21:02:13 +0000 (23:02 +0200)]
PR feedback - code cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/e7f3c94cfa3ae11fc4916eb7e236c55cd2148745

7 years agoConditionally run namedPipes tests in uap if windows version contains fix (dotnet...
Jose Perez Rodriguez [Thu, 28 Sep 2017 20:11:11 +0000 (13:11 -0700)]
Conditionally run namedPipes tests in uap if windows version contains fix (dotnet/corefx#24307)

* Conditionally run namedPipes tests in uap if windows version contains fix

* PR Feedback

Commit migrated from https://github.com/dotnet/corefx/commit/161267c8645d4fd4cde51c3783d3c9326ed034f1

7 years agoUse PlatformSpecific instead of ActiveIssue
Frederik Carlier [Thu, 28 Sep 2017 19:18:37 +0000 (21:18 +0200)]
Use PlatformSpecific instead of ActiveIssue

Commit migrated from https://github.com/dotnet/corefx/commit/29509cf8132796c46b06854c0242fd3c46e6e1b4

7 years agoMerge pull request dotnet/corefx#24310 from ericstj/disableGeneratingRuntimeJson
Eric StJohn [Thu, 28 Sep 2017 18:35:36 +0000 (11:35 -0700)]
Merge pull request dotnet/corefx#24310 from ericstj/disableGeneratingRuntimeJson

Disable automatic generation of runtime.json during the build

Commit migrated from https://github.com/dotnet/corefx/commit/e4525ebb2fe351814cd7456a1a7e1e4423a514f3

7 years agoDisable automatic generation of runtime.json during the build
Eric St. John [Thu, 28 Sep 2017 18:34:01 +0000 (11:34 -0700)]
Disable automatic generation of runtime.json during the build

Commit migrated from https://github.com/dotnet/corefx/commit/e117c593c407162a20cbefe7444eb01af711af56

7 years agoactive supress coreclr dotnet/corefx#14154 (dotnet/corefx#24305)
Paulo Janotti [Thu, 28 Sep 2017 17:10:01 +0000 (10:10 -0700)]
active supress coreclr dotnet/corefx#14154 (dotnet/corefx#24305)

Commit migrated from https://github.com/dotnet/corefx/commit/9c18f4b74d61fd86dd1f01f5d512474a08adee99

7 years agoMerge pull request dotnet/corefx#24279 from ragmani/skip_xmlserializer_test_armel
Eric Mellino [Thu, 28 Sep 2017 17:06:48 +0000 (10:06 -0700)]
Merge pull request dotnet/corefx#24279 from ragmani/skip_xmlserializer_test_armel

Disable building Microsoft.XmlSerializer.Generator.Tests for armel

Commit migrated from https://github.com/dotnet/corefx/commit/d93b05350d37f494a5bdec595606daf20f948d2b

7 years agoPort Regex.Compiled in-memory compilation of regex patterns from Desktop (dotnet...
Viktor Hofer [Thu, 28 Sep 2017 16:54:16 +0000 (18:54 +0200)]
Port Regex.Compiled in-memory compilation of regex patterns from Desktop (dotnet/corefx#24158)

* Regex.Compiled - Reimplement in-memory compilation of regex patterns

* move opcodesize outside of debug compilation where it belongs

* ArgumentException param names changed, removed internal delegates in favor of Func and Action

* RegexCompilationInfo properties ordered by name and exposed in ref assembly

* Change Name argument name in ArgumentException

* Cleaning up references, enabling many disabled tests for uap/uapaot

* Condition to not support compiled patterns on uap/uapaot

* Add compiled tests

* Update baselines, address PR feedback, stub CompileToAssembly method and expose it, expose RegexCompilationInfo on all targets

Commit migrated from https://github.com/dotnet/corefx/commit/cbcb08b48fb3b1c24231f69665ba5407ef751338

7 years agoUpdate CoreFx, Standard to preview1-25728-02, preview1-25728-01, respectively (dotnet...
dotnet-maestro-bot [Thu, 28 Sep 2017 15:19:27 +0000 (10:19 -0500)]
Update CoreFx, Standard to preview1-25728-02, preview1-25728-01, respectively (dotnet/corefx#24301)

Commit migrated from https://github.com/dotnet/corefx/commit/adb447dbe1407bf329e2446611f9c9f234f9b96a

7 years agoIconCodec: Create dedicated tests for Palette.Entries.Length on Windows and Unix.
Frederik Carlier [Thu, 28 Sep 2017 14:52:51 +0000 (16:52 +0200)]
IconCodec: Create dedicated tests for Palette.Entries.Length on Windows and Unix.

Commit migrated from https://github.com/dotnet/corefx/commit/0c04c212b18240405ee25336fe603e71c9e6d227

7 years ago[WIP] Removing CreateFileW from UWP (dotnet/corefx#24297)
Paulo Janotti [Thu, 28 Sep 2017 13:56:20 +0000 (06:56 -0700)]
[WIP] Removing CreateFileW from UWP (dotnet/corefx#24297)

* [WIP] Removing CreateFileW from UWP

* CR: move conditional to its own ItemGroup

* removed pinvoke exceptions for Runtime.Extensions

* Fixed condition for CreateFile ItemGroup

* exception still needed for netstandard

Commit migrated from https://github.com/dotnet/corefx/commit/a989d4f91cf4208b7a2481d120498a581328eb1d

7 years agoEnable --arch option in run-test.sh (dotnet/corefx#24300)
Hyung-Kyu Choi [Thu, 28 Sep 2017 11:51:44 +0000 (20:51 +0900)]
Enable --arch option in run-test.sh (dotnet/corefx#24300)

There is a help message for --arch option,
but there is no code for the option.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/corefx/commit/c7f67e738cdae5040ef9594f1d190647ed32c67a

7 years agoUpdate CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25728...
dotnet-maestro-bot [Thu, 28 Sep 2017 11:50:15 +0000 (06:50 -0500)]
Update CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25728-01, preview1-25727-05, beta-25728-00, beta-25728-00, preview1-25727-01, respectively (dotnet/corefx#24241)

Commit migrated from https://github.com/dotnet/corefx/commit/4f294114ba126f0482bbc8e9964b460cc26a7929

7 years agoMaking Memory and ReadOnly readonly, fixing issue dotnet/corefx#23809 (dotnet/corefx...
Ahson Ahmed Khan [Thu, 28 Sep 2017 03:54:02 +0000 (20:54 -0700)]
Making Memory and ReadOnly readonly, fixing issue dotnet/corefx#23809 (dotnet/corefx#24245)

Commit migrated from https://github.com/dotnet/corefx/commit/fa27201badbbce3cdb752d52593493a60c2f7d34

7 years agoEnable CI for RHEL.6 (dotnet/corefx#24285)
Jan Vorlicek [Thu, 28 Sep 2017 00:02:42 +0000 (02:02 +0200)]
Enable CI for RHEL.6 (dotnet/corefx#24285)

Commit migrated from https://github.com/dotnet/corefx/commit/8bbe886554664ac464fd7cc45239514aa6d4a2ec

7 years agoUpdate UAP Runner and buildtools to get new uap runner's logging (dotnet/corefx#24132)
Santiago Fernandez Madero [Wed, 27 Sep 2017 23:07:05 +0000 (16:07 -0700)]
Update UAP Runner and buildtools to get new uap runner's logging (dotnet/corefx#24132)

Commit migrated from https://github.com/dotnet/corefx/commit/28d820ab5d6b8a0f01c570a632022e3c5556ee58

7 years agoRe-enable InstalledFontCollection tests on Unix. (dotnet/corefx#24263)
Eric Mellino [Wed, 27 Sep 2017 22:57:20 +0000 (15:57 -0700)]
Re-enable InstalledFontCollection tests on Unix. (dotnet/corefx#24263)

* Re-enable InstalledFontCollection tests on Unix.

* Disable font tests on RHEL 7.3.

Commit migrated from https://github.com/dotnet/corefx/commit/dc15b81c6746ff324a4b93b0d83954b44da9bbac

7 years agoMerge pull request dotnet/corefx#24260 from ericstj/buildRuntimeJson
Eric StJohn [Wed, 27 Sep 2017 22:48:40 +0000 (15:48 -0700)]
Merge pull request dotnet/corefx#24260 from ericstj/buildRuntimeJson

Generate `runtime.json`

Commit migrated from https://github.com/dotnet/corefx/commit/7fa45467cf38215e519994c5337af93f06d2d17a

7 years agoSystem.Drawing - Add tests for Bitmap based on Mono's unit test suite (dotnet/corefx...
Frederik Carlier [Wed, 27 Sep 2017 21:58:47 +0000 (23:58 +0200)]
System.Drawing - Add tests for Bitmap based on Mono's unit test suite (dotnet/corefx#24152)

* Add Bitmap tests based on Mono's unit test suite

* Remove duplicat tests.

* Don't validate BitmapData.Reserved on Unix.

* PR feedback

* Disable certain LockBits tests on Unix

* Disable additional tests on Unix

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/2d5ca4e8efb6a3013ddabc5898b579f554249eb1

7 years agoMerge pull request dotnet/corefx#24286 from shmao/FixNs
Shin Mao [Wed, 27 Sep 2017 21:55:08 +0000 (14:55 -0700)]
Merge pull request dotnet/corefx#24286 from shmao/FixNs

Fix System.SeviceModel.Syndication's Namespace

Commit migrated from https://github.com/dotnet/corefx/commit/61831b82990cdf197d9a384292f1197d1e774345

7 years agoRun GenerateRuntimeJson as part of build
Eric St. John [Wed, 27 Sep 2017 16:21:55 +0000 (09:21 -0700)]
Run GenerateRuntimeJson as part of build

Commit migrated from https://github.com/dotnet/corefx/commit/edd1abbf311708aa3698c8a98f4d77d0acd5c70e

7 years agoGenerate `runtime.json` from RuntimeGroup items and common policy
Eric St. John [Tue, 26 Sep 2017 17:28:13 +0000 (10:28 -0700)]
Generate `runtime.json` from RuntimeGroup items and common policy

This makes our RID graph much less error prone and easier to reason about.

To see how to use the new system see readme.md.

To see the extent of the changes examine the diff of runtime.json and
runtime.compatibility.json.

Commit migrated from https://github.com/dotnet/corefx/commit/ba4f70ac310dfe6a906ceb41ecc0d1a327a62b23

7 years agoReformat runtime.json and add expansion to monitor compatibility changes
Eric St. John [Tue, 19 Sep 2017 18:45:06 +0000 (11:45 -0700)]
Reformat runtime.json and add expansion to monitor compatibility changes

This is simply a roundtrip through JsonRuntimeFormat so that the following changes will have
a clear diff (or no diff)

runtime.compatibility.json is the expansion (`RuntimeGraph.ExpandRuntime`) of each runtime
in the graph.  Differences in this represent potentially breaking changes.

Commit migrated from https://github.com/dotnet/corefx/commit/75a649229b5785aba9145ec3b7e8108a1175160b

7 years agoMerge pull request dotnet/corefx#24284 from joperezr/UpdateBuildTools
Jose Perez Rodriguez [Wed, 27 Sep 2017 21:25:38 +0000 (14:25 -0700)]
Merge pull request dotnet/corefx#24284 from joperezr/UpdateBuildTools

Updating Buildtools to update Roslyn

Commit migrated from https://github.com/dotnet/corefx/commit/eb96cdac247febed3d5d10f93a6472419e1253c1

7 years agoRe-org the files in Syndication source folder.
Xing Mao [Wed, 27 Sep 2017 20:51:44 +0000 (13:51 -0700)]
Re-org the files in Syndication source folder.

Commit migrated from https://github.com/dotnet/corefx/commit/b2216dc5860a55fd89e89bffe48e378cfb379109

7 years agoFixed the Namespace used by S.SM.Syndication.
Xing Mao [Wed, 27 Sep 2017 20:42:59 +0000 (13:42 -0700)]
Fixed the Namespace used by S.SM.Syndication.

Commit migrated from https://github.com/dotnet/corefx/commit/fea1aaaa8eb63f8fdf4db566420685faaed6ff1a

7 years agoTests for Type Having Primitive Types as KnownType (dotnet/corefx#24267)
Shin Mao [Wed, 27 Sep 2017 20:36:40 +0000 (13:36 -0700)]
Tests for Type Having Primitive Types as KnownType (dotnet/corefx#24267)

Fix dotnet/corefx#24264

Commit migrated from https://github.com/dotnet/corefx/commit/9cce463310a7d04d9ed5aab9828ee0af79d5317d

7 years agoFix the Build of Syndication and the Test. (dotnet/corefx#24214)
Shin Mao [Wed, 27 Sep 2017 20:36:15 +0000 (13:36 -0700)]
Fix the Build of Syndication and the Test. (dotnet/corefx#24214)

* Fix the Build of Syndication and the Test.

* Changed Version of Syndication to 4.0.0.0

* Fixed Syndication Test Failures on Unix.

Commit migrated from https://github.com/dotnet/corefx/commit/798f5ebd0960ae8836fb58edaf50e1a32b3c5234

7 years agoDisable failing tests on Windows 7
Frederik Carlier [Wed, 27 Sep 2017 20:03:14 +0000 (22:03 +0200)]
Disable failing tests on Windows 7

Commit migrated from https://github.com/dotnet/corefx/commit/f44f45ee59cdebe02b6c34db22c88ca8c4bc5ff5

7 years agoUpdating Buildtools to update Roslyn
Jose Perez Rodriguez [Wed, 27 Sep 2017 18:09:59 +0000 (11:09 -0700)]
Updating Buildtools to update Roslyn

Commit migrated from https://github.com/dotnet/corefx/commit/c3daae382bcccfda7a9b99899ffa5e4caf4fde45

7 years agoDisable assert which fails on Win7
Frederik Carlier [Wed, 27 Sep 2017 17:05:51 +0000 (19:05 +0200)]
Disable assert which fails on Win7

Commit migrated from https://github.com/dotnet/corefx/commit/9ddaa3473e48dc1c5da3e21b34d3db97dc559cb9

7 years agoUpdate unit tests to work cross-platform
Frederik Carlier [Wed, 27 Sep 2017 16:09:38 +0000 (18:09 +0200)]
Update unit tests to work cross-platform

Commit migrated from https://github.com/dotnet/corefx/commit/20d03613106f5bcf33c2cded3992afbdf4b63ce9

7 years agoFix unit test, account for Windows/Unix differences.
Frederik Carlier [Wed, 27 Sep 2017 14:39:35 +0000 (16:39 +0200)]
Fix unit test, account for Windows/Unix differences.

Commit migrated from https://github.com/dotnet/corefx/commit/02c9cec423d1e50877bcbc1a81b32a846111be7f

7 years agoAddress PR feedback
Frederik Carlier [Wed, 27 Sep 2017 12:27:20 +0000 (14:27 +0200)]
Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5e598a65ad5f57f0ab0382480f7e0d1ed14baadb

7 years agoInclude test files in project file
Frederik Carlier [Wed, 27 Sep 2017 12:22:28 +0000 (14:22 +0200)]
Include test files in project file

Commit migrated from https://github.com/dotnet/corefx/commit/6b26a40c57857067a9465e6f2d5671dd1b80216b

7 years agoDisable building Microsoft.XmlSerializer.Generator.Tests for armel
ragmani [Thu, 21 Sep 2017 12:09:38 +0000 (21:09 +0900)]
Disable building Microsoft.XmlSerializer.Generator.Tests for armel

Commit migrated from https://github.com/dotnet/corefx/commit/d3a8efba6bc1b910bae00254ce49e562356ef11e

7 years agoReturn condition directly instead of `if (condition) return true; else return false...
Amit Dash [Tue, 26 Sep 2017 23:29:06 +0000 (04:59 +0530)]
Return condition directly instead of `if (condition) return true; else return false;` (dotnet/corefx#24252)

Commit migrated from https://github.com/dotnet/corefx/commit/27a43b38f3f599e43d8bf845f6eb0f351da762e2

7 years agoMerge pull request dotnet/corefx#24269 from mellinoe/system.drawing-enable-imageattri...
Eric Mellino [Tue, 26 Sep 2017 23:24:59 +0000 (16:24 -0700)]
Merge pull request dotnet/corefx#24269 from mellinoe/system.drawing-enable-imageattributestests

Enable ImageAttributes tests which pass on Unix System.Drawing.

Commit migrated from https://github.com/dotnet/corefx/commit/675e2b9c2283d79785e489d97009298a9138a596

7 years agoEnable ImageAttributes tests which pass on Unix System.Drawing.
Eric Mellino [Tue, 26 Sep 2017 21:28:32 +0000 (14:28 -0700)]
Enable ImageAttributes tests which pass on Unix System.Drawing.

Commit migrated from https://github.com/dotnet/corefx/commit/9c850843964fc13774e0c6c34ba5a05a166bf2a5

7 years agoUpdating CLI to 2.0.0 version (dotnet/corefx#23751)
Jose Perez Rodriguez [Tue, 26 Sep 2017 21:09:45 +0000 (14:09 -0700)]
Updating CLI to 2.0.0 version (dotnet/corefx#23751)

* Updating CLI to 2.0.0 version

* Fixing Tizen build by disabling warnings that for package downgrades due to missing RID specific packages for Tizen

Commit migrated from https://github.com/dotnet/corefx/commit/c6dbe361680efd21a20fdb8def01936b1031011c

7 years agoMerge pull request dotnet/corefx#24266 from MattGal/Conditional_Plugin_install
Matt Galbraith [Tue, 26 Sep 2017 21:04:31 +0000 (14:04 -0700)]
Merge pull request dotnet/corefx#24266 from MattGal/Conditional_Plugin_install

Disable Inject signed symbol catalogs step for oss-type signing

Commit migrated from https://github.com/dotnet/corefx/commit/ac2e1e3509f637f0b4122d8d2fff1ee96f003e54

7 years agoDisable Inject signed symbol catalogs step for oss-type signing
Matt Galbraith [Tue, 26 Sep 2017 21:02:20 +0000 (14:02 -0700)]
Disable Inject signed symbol catalogs step for oss-type signing

Commit migrated from https://github.com/dotnet/corefx/commit/3c4d66e705fdbedd7d6592eda0f7380572ea47e6

7 years agoUpdate build to clang/llvm 3.9
Mike McLaughlin [Tue, 26 Sep 2017 20:47:40 +0000 (13:47 -0700)]
Update build to clang/llvm 3.9

Update scripts, docs and build pipeline docker images to clang/llvm/lldb 3.9

Commit migrated from https://github.com/dotnet/corefx/commit/1bd2c02ebc269376cfc39d77b9cb5a233cc3b5ac

7 years agoAdd System.ServiceModel.Syndication owners
Karel Zikmund [Tue, 26 Sep 2017 19:28:25 +0000 (12:28 -0700)]
Add System.ServiceModel.Syndication owners

Commit migrated from https://github.com/dotnet/corefx/commit/9588da150eac4f552a8c62a0cf45bda511d997fa

7 years agoAdd System.ServiceModel.Syndication
Karel Zikmund [Tue, 26 Sep 2017 19:25:06 +0000 (12:25 -0700)]
Add System.ServiceModel.Syndication

Commit migrated from https://github.com/dotnet/corefx/commit/afa7ed8e6732b328d80cbf97c3b28efd4173440c

7 years agoMerge pull request dotnet/corefx#24262 from MattGal/Conditional_Plugin_install
Matt Galbraith [Tue, 26 Sep 2017 19:08:57 +0000 (12:08 -0700)]
Merge pull request dotnet/corefx#24262 from MattGal/Conditional_Plugin_install

Temporarily hard-code signType to 'real' to unblock plugin installation step

Commit migrated from https://github.com/dotnet/corefx/commit/771053ef0bb4388ff9074230b23d6ec648c16e4c

7 years agoTemporarily hard-code signType to 'real' to unblock this step since Pipebuild does...
Matt Galbraith [Tue, 26 Sep 2017 19:04:56 +0000 (12:04 -0700)]
Temporarily hard-code signType to 'real' to unblock this step since Pipebuild does not understand conditional build step logic.

Commit migrated from https://github.com/dotnet/corefx/commit/a430af72c029bb8109e4259831847a195a1bb486

7 years agoMerge pull request dotnet/corefx#24261 from MattGal/Conditional_Plugin_install
Matt Galbraith [Tue, 26 Sep 2017 18:13:54 +0000 (11:13 -0700)]
Merge pull request dotnet/corefx#24261 from MattGal/Conditional_Plugin_install

Use conditional execution for signing plugin (does not support OSS).

Commit migrated from https://github.com/dotnet/corefx/commit/39c65a488f1200b36bdb29f17f77296917f4c295

7 years agoUse conditional execution for signing plugin (does not support OSS).
Matt Galbraith [Tue, 26 Sep 2017 18:09:09 +0000 (11:09 -0700)]
Use conditional execution for signing plugin (does not support OSS).

See https://docs.microsoft.com/en-us/vsts/build-release/concepts/process/conditions

Commit migrated from https://github.com/dotnet/corefx/commit/c1cc15b958c17263bde0847957d6b98c105eaa47

7 years agoMerge pull request dotnet/corefx#24258 from MattGal/reenable_publish
Matt Galbraith [Tue, 26 Sep 2017 17:07:51 +0000 (10:07 -0700)]
Merge pull request dotnet/corefx#24258 from MattGal/reenable_publish

Renable some publish scenarios

Commit migrated from https://github.com/dotnet/corefx/commit/bbea46f9ea09c8724e589a99b122bb01916221b1

7 years agoRenable some publish scenarios
Matt Galbraith [Tue, 26 Sep 2017 17:02:02 +0000 (10:02 -0700)]
Renable some publish scenarios

Commit migrated from https://github.com/dotnet/corefx/commit/38f2f234594dc86bbb5cae7de441fe99ea5f9b3e

7 years agoMake ConnectHelper.ConnectAsync return ValueTask<Stream> (dotnet/corefx#24244)
Stephen Toub [Tue, 26 Sep 2017 14:30:44 +0000 (10:30 -0400)]
Make ConnectHelper.ConnectAsync return ValueTask<Stream> (dotnet/corefx#24244)

Minor optimization via playing a bit better perf-wise with changes being made in coreclr.

Commit migrated from https://github.com/dotnet/corefx/commit/c45e6b3d58af63299aea992848370fced532c6e8

7 years agoFix some missing ConfigureAwaits in ManagedHandler (dotnet/corefx#24248)
Stephen Toub [Tue, 26 Sep 2017 14:30:13 +0000 (10:30 -0400)]
Fix some missing ConfigureAwaits in ManagedHandler (dotnet/corefx#24248)

Commit migrated from https://github.com/dotnet/corefx/commit/2f981c6efcd00b4ecee5309697ef07d58605993a

7 years agoDisable RecursiveDelete_DeepNesting (Issue dotnet/corefx#24242). (dotnet/corefx#24243)
Eric Mellino [Tue, 26 Sep 2017 03:12:23 +0000 (20:12 -0700)]
Disable RecursiveDelete_DeepNesting (Issue dotnet/corefx#24242). (dotnet/corefx#24243)

Commit migrated from https://github.com/dotnet/corefx/commit/6cee65c560f1b853f67c7871345c0feacd95a070

7 years agoMerge pull request dotnet/corefx#24238 from hughbe/matrix-same-multiply
Eric Mellino [Tue, 26 Sep 2017 00:01:51 +0000 (17:01 -0700)]
Merge pull request dotnet/corefx#24238 from hughbe/matrix-same-multiply

Fix multiplying a matrix by the same matrix

Commit migrated from https://github.com/dotnet/corefx/commit/634f767771b7c1946d7b10aeb77dbbc0ccb9f622

7 years agoBigInteger based random testing of System.Decimal (dotnet/corefx#24053)
Pent Ploompuu [Mon, 25 Sep 2017 22:36:29 +0000 (01:36 +0300)]
BigInteger based random testing of System.Decimal (dotnet/corefx#24053)

* BigInteger based random testing of Decimal

* Comments for random testing of Decimal

* Parallelize random testing of Decimal

* Simplified BigDecimal.Div for Decimal tests

Commit migrated from https://github.com/dotnet/corefx/commit/d23561261a8c98a9b1f9c46838fae3ecfca31998

7 years agoMerge pull request dotnet/corefx#24218 from MattGal/Support_test_signing
Matt Galbraith [Mon, 25 Sep 2017 20:51:24 +0000 (13:51 -0700)]
Merge pull request dotnet/corefx#24218 from MattGal/Support_test_signing

Changes to propagate PB_SignType variable through the PipeBuild process (was always 'real' before)

Commit migrated from https://github.com/dotnet/corefx/commit/591c28432236eae28f132cd4e07b53f1a55c6ca7

7 years agoFix multiplying a matrix by the same matrix
Hugh Bellamy [Mon, 25 Sep 2017 20:11:52 +0000 (21:11 +0100)]
Fix multiplying a matrix by the same matrix

Commit migrated from https://github.com/dotnet/corefx/commit/cd7559c1e00d60853b542ea6d1737f56ce733b74

7 years agoChanges to actually propate PB_SignType through the PipeBuild process
Matt Galbraith [Fri, 22 Sep 2017 22:59:47 +0000 (15:59 -0700)]
Changes to actually propate PB_SignType through the PipeBuild process

Commit migrated from https://github.com/dotnet/corefx/commit/553c51c985ceaaf0897393ce20d1a8f3b13e2602

7 years agoApplying remaining code review comment from dotnet/corefx#24078 (dotnet/corefx#24237)
Maryam Ariyan [Mon, 25 Sep 2017 19:48:11 +0000 (15:48 -0400)]
Applying remaining code review comment from dotnet/corefx#24078 (dotnet/corefx#24237)

Commit migrated from https://github.com/dotnet/corefx/commit/b625ab61a7b5835ca32b5f2f257cc64eabb8029d

7 years agoUse Docker host's tools version for cleanup (dotnet/corefx#24235)
JC Aguilera [Mon, 25 Sep 2017 19:19:52 +0000 (12:19 -0700)]
Use Docker host's tools version for cleanup (dotnet/corefx#24235)

When doing Cleanup VSTS agent, we should use the tools in Docker host. For CentOS-6 using non-sand boxed tools failed with "Aborted (core dumped)". https://github.com/dotnet/core-eng/issues/1807

Commit migrated from https://github.com/dotnet/corefx/commit/e265052fa2ef0bee145e0a5281d6b18ce3cd966f

7 years agoSkipping ComponentModel failing test on netfx in CI (dotnet/corefx#24236)
Maryam Ariyan [Mon, 25 Sep 2017 19:01:55 +0000 (15:01 -0400)]
Skipping ComponentModel failing test on netfx in CI (dotnet/corefx#24236)

Fixes dotnet/corefx#24233

Commit migrated from https://github.com/dotnet/corefx/commit/18e7272babd6e72b418ae108deb7f2138367e95a

7 years agoMerge pull request dotnet/corefx#24195 from qmfrederik/fixes/metafiletests-x11
Eric Mellino [Mon, 25 Sep 2017 17:19:06 +0000 (10:19 -0700)]
Merge pull request dotnet/corefx#24195 from qmfrederik/fixes/metafiletests-x11

Don't depend on X11 in the MetafileTests

Commit migrated from https://github.com/dotnet/corefx/commit/c2b14b597ad855c159431f12cecf61f5331c9174

7 years agoUpdate Standard to preview1-25725-01 (dotnet/corefx#24231)
dotnet-maestro-bot [Mon, 25 Sep 2017 17:04:04 +0000 (12:04 -0500)]
Update Standard to preview1-25725-01 (dotnet/corefx#24231)

Commit migrated from https://github.com/dotnet/corefx/commit/65e31fc7c96f9aa2720f1cf60a72360c85bb6dd8