review.tizen.org Git - platform/upstream/dotnet/runtime.git/log

Delete duplicate Buffer.Memmove implementations and avoid unnecessary pinning (#44118)

* Delete duplicate Buffer.Memmove implementations and avoid unnecessary pinning

We have several versions of Buffer.Memmove, including one implemented around `byte*` and one implemented around `ref byte`. We can delete the former and just use the latter everywhere. In doing so, we can also remove a few wrapper helpers, and reduce pinning in places where those wrappers were pinning to get pointers only to eventually end up in the ref-based implementation, anyway.

* Use ThrowHelper in more places

Add issues.targets CG2 entries for issue #44054 (#44142)

Enable using the Ninja generator instead of Visual Studio on Windows builds. (#41897)

* Move DacTableGen out of the CMake build and into tools-local.

* Attempt: usenmakefiles means ninja.

* Make changes to Windows build to support non-VS generators like ninja.

* Use CMake 3.16 PCHs.

* Remove explicit process count.

* Build and run DacTableGen via the .NET CLI we pull down for the build instead of via CMake.

* Update configurecompiler.cmake to specify language (needed for Ninja).

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Get Ninja build working again.

* Pass configuration to cmake configure step for Ninja build.

* Rename flag

* Fix configure step for cross-arch native build

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Support building via Ninja for coreclr via an MSBuild property

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Implement support for opening the CoreCLR solution in VS via the -vs flag.

* Fix setting generator to Ninja.

* Merge libraries gen-buildsys-win.bat with runtime gen-buildsys.cmd to share windows cmake configure infra.

* Enable building libraries native build with ninja.

* Centralize setting CMAKE_SYSTEM_VERSION for windows builds.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Update host build to use shared gen-buildsys.cmd

* Fix multi-config generator detection.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Exit with success when we build successfully.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Enable and fix up Ninja build for hosts.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Only link delayimp.lib on Windows

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Remove "overriding /W3 with /W1" warning in Ninja build of hosts by turning on /W3 and disabling any new warnings we hit.

* Reduce command line override warnings by adopting the MSVC_RUNTIME_LIBRARY abstraction feature in CMake 3.14+ (below the minimum requirement on Windows).

* Use the delayed expansion syntax to correctly pass in the config to cmake.

* Move all usages of MSVC runtime library selection to the CMake abstraction to reduce console spew about overridden flags.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Condition the rest of the compiler options correctly so they don't show up as invalid parameter warnings for assembly builds.

* Correctly build DIALib and DacTableGen as AnyCPU

* Fix WRITE_BARRIER_CHECK define

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Fix passing arch for MSBuild build.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Configure ASM compiler command line format in configurecompiler.cmake and use CMake's assembly compilation step to build ASM files for ARM/ARM64 instead of manually building them and adding the generated files as additional sources.

* Cleanup after fixing ARM/ARM64 support.

* Rename variable

* Condition PCH's for C++-only as needed to fix using them on non-Windows (where we compile C as C instead of as C++).

* Fix CoreCLR native test build on windows to point to new gen-buildsys location.

* Add missing compilation options in Ninja build that are implicitly defined in the MSBuild build.

* Disable analyzers for DacTableGen. Remove /MAP linker flag (that's for local testing).

* Upgrade to CMake 3.16.4

* Don't warn on unused variables in CMake (these usually vary on platform/config)

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Manually compile ARM and ARM64 asm files when using the VS generator since it doesn't support emitting MARMASM item types in projects (and as a result cannot compile ARM or ARM64 asm without assistance).

* Enable CMake policy in test build to use CMAKE_MSVC_RUNTIME_LIBRARY variable.

* Update initially disabled warnings in host.

* Add -ninja arg to root scripts to enable using Ninja.

* Enable using Ninja in CoreCLR CI.

* Try to fix passing the -ninja arg in yaml.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Add ninja to the Windows invocation

* Fix 2-phase cross targeting to do one phase at a time and initialize the VC++ environment for the correct build tools each time instead of interleaving them and relying on Visual Studio to handle the differing targets.

* Restore old /Ox optimization setting for Release.

* Fix typos, don't pass exception flags to C files.

* Remove unneeded pragma.

* Fix .pgd file installation.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Add mention of the `-ninja` flag in the Building CoreCLR documentation.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
* Mention installation locations for Ninja and warn while building if CMake is older than 3.16.0.

* Update docs/workflow/requirements/windows-requirements.md

Set GC_SUSPEND based on the target os not the host os. (#44093)

* Set GC_SUSPEND based on the target os not the host os.

* Add ENABLE_LLVM_RUNTIME cmake option.

Fix equality check for unset variables (#44099)

Use slightly smaller code for String.Concat(object, object, ...) (#44133)

C#, IL, and asm are all a bit smaller. We don't need to set the arguments to Empty if they're null, as the called function checks for null.

Delete dead AppendSpanFormattable method from ValueStringBuilder (#44135)

Remove some unused icalls. (#44128)

(MQ cleanup) Remove size_t from managed Brotli code (#44043)

* Remove size_t from managed Brotli code

* Apply suggestions from code review

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>

Remove unsafe code from String.Join (#44126)

* Remove unsafe code from String.Join

- Use a span for the separator to share the same code across a char separator and string separator, rather than using pointers.
- Consolidate argument validation for the value/startIndex/count overloads into one shared helper
- Change indexing to use standard 0 to values.Length for loop to eliminate bounds checking on span accesses

* Update src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs

Remove last remnants of IExpando support. (#44122)

Fix type generator test failures (#44041)

- Fix issue where method token referred to derived type but method was actually defined on base type
  - Previously the methods did not carry enough state to determine when to emit the owner type of the method, and which exact type was the owning type. The new logic computes it from the token in the presence of a proper instantiation context, which allows for correct operation.

- Fix issue where constrained dispatch on a method of a valuetype would not put in the correct owner type
  - Issue fixed by determining if the token resolves to a method on the same type as the eventual target method, or if it needs to have a specific owning type specified

In general these issues where both caused by confusion around exactly the correct owning type, and it turned out that computation could not be computed within the signature emitter code, but instead needed to be computed in the JIT at point of use. Fortunately, we had a structure `MethodWithToken` that is used in these (and only these situations). Finally, I also made a pass through the emitter and related logic to remove various band-aids that had built up over the last few years to make all the tests and applications pass. I believe that the new logic should be correct in the general case.

Bonus tweak...  Use parallelism when compiling the framework composite images with crossgen2, and fix bug in composite image generation where mangled symbol names might conflict.

Fixes #43466 and fixes #43467

Add optimized String.Join for IList<string> (#44032)

* Support IList<string>

* Revert API change

* Feedback

* Use ReadOnlySpan

* Feedback

* Fix comment

* address feedback

* Add test for List<string> optimization

* Remove StartIndex and Count in core

* Update src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

Delete unnecessary seek from SetLengthInternal on Unix (#44097)

Also, improve test coverage for FileStream.SetLength

Avoid linking against libicudata.a, its not needed. (#44105)

Fix the typo (#44075)

[master] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/xharness (#44062)

[master] Update dependencies from dotnet/arcade dotnet/llvm-project dotnet/xharness

Remove WinRT leftovers from mono's CoreLib (#44102)

Minor update to function signatures for RISCV64 architecture (#43862)

I don't believe this fixes any existing issue in the tracker, but I'm trying to build mono with dotnet-core on riscv from git and ran into this problem when compiling. There may end up being other changes but I won't know until my VM is done actually building mono. The changes right now are incredibly minor, just updating some function signatures to match the current rest of the system.



Co-authored-by: simcop2387 <simcop2387@users.noreply.github.com>

Fix IL interpreter build on GCC. (#44049)

Disable PollingEventFires test (#44096)

Optimize String.Replace(string, string) (#44088)

We can significantly improve its throughput for a few scenarios:
- If both oldValue and newValue are single characters in the form of strings, we can just delegate to the Replace(char, char) overload, which is much faster.
- If oldValue is a single character but newValue isn't, we can use IndexOf to find it, rather than an open-coded loop, making search times much faster for reasonably sized strings.
- If oldValue is multiple characters and the string being searched for isn't super frequent (e.g. doesn't repeat every few characters), we can significantly speed up throughput by using IndexOf to search for the whole string. For example, replacing "\r\n" with "\n" in the contents of a typical file.

This does come at a measurable cost when the oldValue is really common and tightly packed, e.g. searching for "aa" in "aaaaaaaaaaaaaaaaaa", so we can decide whether the tradeoff is the right one.

[Interp] Create an intrinsic for Interlocked.Exchange for int64 (#43893)

* Add an instrinsic for Interlocked.Exchange

* Hacks to help with development

* Remove one more layer of function call and revert local hacks

* Revert redundant format change

* make interlocked_mutex a global variable

* Update opcode name

* Resolve reviewer feedbacks

* Add a pair of braces.

Add area owners for System.Formats (#44038)

* Asn1

* Cbor

* Align last pipe, add missing pipes.

* Quic

* Additional owners for Asn1 and Cbor

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>

Clean up debugger debug logging and wasm trace logging (#43960)

* Clean up debugger debug logging and wasm trace logging

* Update src/mono/mono/mini/mini-wasm-debugger.c

Co-authored-by: Ryan Lucia <ryan@luciaonline.net>

EqualityComparer IndexOf to shared (#44065)

Delete area-Tizen

Set default value for value-type ctor params properly (#43831)

* Set default value for value-type ctor params properly

* Address review feedback

Set number handling for properties read after deserializing ctor params (#43829)

* Set number handling for properties read after deserializing ctor params

* Use DeserializeWrapper pattern for tests

Enable unused-result warning for PAL (#43395)

Delete the remaining dead variables and methods from PAL, that were
highlighted by gcc's dead code analysis, and enable `unused-result`
warning for PAL.

Fix gsharedvt constrained calls to Object.GetHashCode () which was broken by #43729. (#44047)

Fixes https://github.com/dotnet/runtime/issues/44000.

Implement the reuse of duplicate constant values (#43899)

* Implement the reuse of duplicate constant value
- Duplicate values will now be reused in the constants area
- Added MIN_DATA_ALIGN and MAX_DATA_ALIGN constants
- Added dsDataType to record the type of the constant
- Print the floating point values in the constants area
- Changed 'alignment' and 'cnsSize' parameters to be unsigned instead of UNATIVE_OFFSET
- Added method emitDataGenFind to search and return a duplicate constant value

* Correctly place declaration of curOffs

* Code review feedback

* Carol's feedback

* Feedback from Tanner Gooding
Allow binary bit pattern matches of constants

* Fix build warning/error

* Jit Format

[cmake] Add -DCHECKED_BUILD=args support, and check getters in Debug (#44024)

* [cmake] Add -DCHECKED_BUILD=args support, and check getters in Debug

Add support for additional compile-time and runtime checks to cmake.

Also for Debug builds, turn on the compile-time "private types" check that
verifies that getters are being used to access the fields of certain structs.

* [interp] Use getters

* remove unused stub

Address JsonElement doc and test feedback (#43832)

Remove unused ifdef logic in ODBC (#44042)

Add Stream argument validation helpers and use throughout dotnet/runtime (#43968)

* Add Stream argument validation helpers and use throughout dotnet/runtime

* Delete unnecessary code in Stream

Stream.Null was using BlockingBegin/EndRead/Write, but the operations are nops (they don't even do argument validation), so the functionality was unnecessary complication. We can just use TaskToApm instead, with already completed tasks, and then also delete the SynchronousAsyncResult that was used by these operations.

Also, the Begin/EndRead/Write methods were checking CanRead/Write and throwing if they return false, but this is a private sealed type with CanRead/Write hardcoded to return true! Delete.

Finally added consistency across Stream.Null to checking for cancellation.

* Clean up some style on Stream

Also consolidate a few resources and use a few existing ThrowHelpers where appropriate.

* Fix a few issues, and remove duplicative tests missed in conformance tests rollout

* Address PR feedback

Enable automated SPMI collection for outerloop tests (#43773)

* wip

* wip

* Parameterized SPMI collection

* move the condition

* change to variables

* Update displayName

* Change the format

* Revert "Change the format"

This reverts commit 292ba21c95026feae7528be449c99a0f20b4b068.

* Use variables.collectionName

* fix displayName

* use variables.collectionName for displayName

* print

* Use name

* fix condition

* Create 2 yml files

* Download test artifacts for tests collection

* Attempt to have multiple jobs

* Back to superpmi.yml

* Add missing parameter

* Use CollectionName at other places

* Use collectionName for artifacts, increase timeout for test

* try to merge whatever mch files we got

* Fixes

- increase the timeout for tests to 8 hours
- ignore file error in superpmi.py
- revert timeout setting from superpmi.proj

* fix the .mch file name

* fix typo

Update dependencies from https://github.com/dotnet/arcade build 20201027.10 (#44020)

[master] Update dependencies from dotnet/arcade

Use BinaryPrimitives where possible (#43474)

Remove some unnecessary List-related allocation from EventSource (#44026)

Use jitstd::sort instead of qsort in jit and gcinfo (#43923)

Current use of qsort interferes with cross compilation.

The qsort algorithm is quite different between Windows and Linux, thus causing cross compilation comparison failures while testing.

This replaces qsort with the use of jitstd::sort which provides a sort which is consistent between all platforms. (Particularly in Windows where CFG has costs for function pointer usage.) With a homegrown sort performance test, there is about 15-30% performance win with this sort over qsort. (However as these tests do not resemble the behavior of these sorts in the JIT I do not believe they are spectacularly relevant.)

There is a size cost of about 4KB-6KB for the templatized routines. I was unable to measure a performance difference for the JIT itself. (Crossgen is very slightly faster in my testing with the change, but I do not believe the difference is statistically meaningful.)

remove unnecessary bound check (#42431)

now that all primitive types are supported (thanks to #29000), we can
remove custom bound checks.

Update coding-style.md

Support loading public-only PEM X.509 certificates

Create an overload of CreateFromFile that accepts just the PEM-encoded
X.509 certificate that does not contain a private key.

Fix loading component when application was started with `dotnet` instead of apphost (#43962)

* Don't parse arguments in hostpolicy until necessary
* Explicit error on invalid startup info in hostfxr
* Update tests

Disable the 'problematic assembly' code on .net core. (#44022)

Fix #44004, disable assertion messages in release mode instead of debug. (#44023)

* Fix #44004, disable assertion messages in release mode instead of debug.

* Remove obsolete 'full_messages' enable-minimal option.

Remove redundant lower function (#44010)

Update ServiceProviderServiceExtensions.cs (#43974)

Use pattern matching, rather than `as` cast and `null` check.

Avoid disabling assert messages in debug configuration on wasm to help debugging. (#44004)

Clarify string.IndexOf rules in code comments (#43999)

Bump xharness (#43996)

Includes a potential fix for https://github.com/dotnet/runtime/issues/43983

Add back passing of --build-id option to Mono runtime build (#43993)

This got lost as part of CMake cleanup in https://github.com/dotnet/runtime/pull/43678 but it is actually important for some publishing infrastructure: https://github.com/dotnet/arcade/issues/6464

[interp] return false for IsLittleEndian on BE (#43946)

To help those who maintain Mono for BE.
Also, it allows interpreter to fold branches since now IsLittleEndian is converted into `LDC.I4.1` always on LE.

Example:
```csharp
static void Validate()
{
    if (!BitConverter.IsLittleEndian)
        throw new PlatformNotSupportedException();
}
```
Current output for `MONO_VERBOSE_METHOD=Validate` on both LE/BE:
```
IR_0000: ldsfld.u1  0
IR_0003: brtrue.i4.s IR_000b
IR_0005: newobj_fast 3
IR_000a: throw
IR_000b: ret.void
```

New output on LE:
```
IR_0000: ret.void
```

Add static libraries for System.Native back to mobile runtime packs (#43987)

We need it for various scenarios there. It was removed in https://github.com/dotnet/runtime/pull/41966.

Fixes https://github.com/dotnet/runtime/issues/43949

[master] Update dependencies from mono/linker dotnet/arcade dotnet/xharness dotnet/llvm-project dotnet/runtime-assets dotnet/icu (#43822)

* Update dependencies from https://github.com/mono/linker build 20201026.1

Microsoft.NET.ILLink.Tasks
From Version 6.0.0-alpha.1.20525.1 -> To Version 6.0.0-alpha.1.20526.1

* Update dependencies from https://github.com/dotnet/arcade build 20201022.2

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.ApiCompat
From Version 6.0.0-beta.20520.8 -> To Version 6.0.0-beta.20522.2

* Update dependencies from https://github.com/dotnet/icu build 20201026.1

Microsoft.NETCore.Runtime.ICU.Transport
From Version 6.0.0-alpha.1.20512.1 -> To Version 6.0.0-alpha.1.20526.1

* Update dependencies from https://github.com/mono/linker build 20201026.2

Microsoft.NET.ILLink.Tasks
From Version 6.0.0-alpha.1.20525.1 -> To Version 6.0.0-alpha.1.20526.2

* Update dependencies from https://github.com/mono/linker build 20201027.1

Microsoft.NET.ILLink.Tasks
From Version 6.0.0-alpha.1.20525.1 -> To Version 6.0.0-alpha.1.20527.1

* Update dependencies from https://github.com/dotnet/arcade build 20201025.1

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.ApiCompat
From Version 6.0.0-beta.20520.8 -> To Version 6.0.0-beta.20525.1

* Update dependencies from https://github.com/dotnet/xharness build 20201027.1

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
From Version 1.0.0-prerelease.20519.2 -> To Version 1.0.0-prerelease.20527.1

* Update dependencies from https://github.com/dotnet/llvm-project build 20201026.1

runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk
From Version 9.0.1-alpha.1.20523.1 -> To Version 9.0.1-alpha.1.20526.1

* Update dependencies from https://github.com/dotnet/runtime-assets build 20201026.1

System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 5.0.0-beta.20522.4 -> To Version 5.0.0-beta.20526.1

* Update dependencies from https://github.com/mono/linker build 20201027.2

Microsoft.NET.ILLink.Tasks
From Version 6.0.0-alpha.1.20525.1 -> To Version 6.0.0-alpha.1.20527.2

* Update dependencies from https://github.com/dotnet/arcade build 20201026.10

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.ApiCompat
From Version 6.0.0-beta.20520.8 -> To Version 6.0.0-beta.20526.10

* Update dependencies from https://github.com/dotnet/runtime-assets build 20201027.1

System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 5.0.0-beta.20522.4 -> To Version 5.0.0-beta.20527.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Fix DI DisposeAsync being called twice (#43803)

* Fix DI DisposeAsync being called twice

Enable the portable thread pool by default in coreclr (#43841)

Replace net6.0 TargetFramework Equality Conditions with msbuild intrinsic functions (#43857)

* using msbuild intrinsic functions to get tfm identifier and tfv version

* Update src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft.Win32.SystemEvents.csproj

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
* Update build-native.proj

* Update build-native.proj

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

Respect reloadOnChange in UserSecrets in DefaultBuilder (#43807)

* Respect reloadOnChange in UserSecrets in DefaultBuilder

[mono] Fix LoadAssemblyRaw to not pin or copy (#43830)

* [mono] Fix LoadAssemblyRaw to not pin or copy

Copying of the assembly and symbols happens later, in `mono_alc_load_raw_bytes`, and the pinning is no longer necessary so long as we have the handle.

* Handle null symbol store

Add interpreter libraries to iOS device runtime pack (#43944)

Fixes https://github.com/dotnet/runtime/issues/43943

Add initial set of conformance tests for Stream (#43834)

* Fix invalid assert in StreamBuffer

This can be hit by calling code and thus shouldn't be an assert.  As an assert it prevents testing.

* Add ConnectedStreams.CreateUnidirectional

* Add initial set of Stream conformance tests

These primarily focus on "connected streams", ones that can be arranged to communicate with each other in a producer/consumer pattern or as a bidirectional communication mechanism, e.g. NetworkStream, PipeStream, SslStream wrapped around a NetworkStream, FileStream created around pipes, etc.  Later we can add more tests focused on standalone streams, e.g. FileStream created for an on-disk file, MemoryStream, etc.

* Add ConnectedStreams tests

These are currently helpers used by many other tests.  At some point they could become public API as well.

* Fix NetworkStream argument names

Technically a breaking change, but the current divergence from the base Stream class is a bug, and bringing them into sync means argument exceptions that emerge from the derived type make sense when used via the base type, as well as then being able to use shared validation logic across all streams (subsequent to these changes).

* Add stream conformance tests for NetworkStream

* Add stream conformance tests for QuicStream

* Fix several CryptoStream behaviors

1. Flushing a stream that wraps another stream for writing should always flush that underlying stream, even if no additional data was written as part of the flush.
2. Argument validation should validate buffers are not null rather than null ref'ing on a null buffer.
3. Checks for the CryptoStream mode should come after argument validation.

* Add stream conformance tests for CryptoStream

* Fix FileStream argument names

Technically a breaking change, but the current divergence from the base Stream class is a bug, and bringing them into sync means argument exceptions that emerge from the derived type make sense when used via the base type, as well as then being able to use shared validation logic across all streams (subsequent to these changes).

* Fix BufferedStream argument names

Technically a breaking change, but the current divergence from the base Stream class is a bug, and bringing them into sync means argument exceptions that emerge from the derived type make sense when used via the base type, as well as then being able to use shared validation logic across all streams (subsequent to these changes).

* Add stream conformance tests for FileStream

Specifically when used in a connected fashion, wrapped around an anonymous or named pipe.

* Add stream conformance tests for BufferedStream

Specifically when used in a connected fashion, wrapped around some other connected stream.

* Add stream conformance tests for SslStream and NegotiateStream

* Fix PipeStream.Flush to not fail on readable streams

Consumers may expect Stream.Flush to be a nop if the stream is readable only, but PipeStream.Flush is throwing in that case.  Stop doing that.

* Add stream conformance tests for PipeStream

* Fix several BrotliStream behaviors

1. When passed a null buffer, it's throwing an exception with the argument name "array", even though the parameter's name is "buffer".
2. Even if there's no data written as part of the Flush{Async} call on a writeable stream, it should be calling flush on the wrapped stream.

* Fix several DeflateStream (and friends) issues

1. DeflateStream.Flush{Async} when writing needs to always flush the underlying stream, even if there's no data written as part of the flush call itself.
2. Several byte[] array arguments should be byte[] buffer. Technically a breaking change, but the current divergence from the base Stream class is a bug, and bringing them into sync means argument exceptions that emerge from the derived type make sense when used via the base type, as well as then being able to use shared validation logic across all streams (subsequent to these changes).
3. DeflateStream.EndRead/Write needs to do additional state validation.
4. Not a bug, but simplify ReadAsync to match the sync Read implementation flow.

* Add stream conformance tests for Deflate/ZLib/GZip/BrotliStream

* Fix PipeReader/WriterStream argument validation

* Add stream conformance tests for PipeReader/WriterStream

* Remove erroneous asserts from Stream.ReadWriteTask

* Address PR feedback

* Fix a few tests in CI

Change Task.FromResult to use same task cache as async methods (#43894)

* Change Task.FromResult to use same task cache as async methods

Task.FromResult today always creates a new task. This leads developers that are aware of this to then create their own caches for common values, typically 0, true, and false, to avoid task allocations for those common values. But we already have such values cached internally, used for async method return values. We can just use the same cache for Task.FromResult.

* Address PR feedback

Disable qcalls on wasm. Treat them as normal pinvokes. (#43798)

* Disable qcalls on wasm. Treat them as normal pinvokes.

This is needed because they are stored in a separate table, so they cannot be linked out the same
way as pinvokes/icalls.

* Update tools-local/tasks/mobile.tasks/WasmAppBuilder/PInvokeTableGenerator.cs

Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
* Update tools-local/tasks/mobile.tasks/WasmAppBuilder/PInvokeTableGenerator.cs

Co-authored-by: Ryan Lucia <ryan@luciaonline.net>
Co-authored-by: Ryan Lucia <ryan@luciaonline.net>

Throw when reader is completed with an exception (#43776)

Add link to Discord server to README.md (#43926)

Some refactoring of thread suspension. (#34666)

* m_dwForbidSuspendThread

* Remove some fibers stuff

* g_TrapReturningThreads

* g_pGCSuspendEvent

* m_pThreadAttemptingSuspendForGC

* refactor SuspendRuntime into just one loop

* Suspend iteration after updating hijacks should "observeOnly" - no point to update hijacks again right away.

* avoid retrying to suspend threads that are already in redirected state.

* PR feedback

* "premptive" - common typo apparently

* missing profiler notification on suspend end and `DisableStressHeap` stuff

* indentation and infinite loop style

* Removed GTF_DONT_CSE flag on `g_TrapReturningThreads` load in GCPoll and added comment explaining why.

* reverted an accidentally removed assert

* removed SWITCHOUT_HANDLE_VALUE entirely - not different from INVALID_HANDLE_VALUE now

* some cleanups and more comments when non-GC suspension yields to GC

* Few tweaks for the concerns discussed in the PR

* On Server GC `pCurThread` is NULL.
Need to fix an ASSERT to account for the possibility of NULL.

[wasm] Add backward compatibility file to timezone data compilation (#43786)

* Add backward file from iana to handle backward compatibility in tz data
* add tests to check for backwards compatibility

Make runtime tests run with Android (#42683)

* Prototype for runtime tests running with Android

* Conditionally collect app dependencies

* Switch android sample from publish to build

* Switch Android sample from publish to build

* Modify AndroidTestRunner

* Only build and test one test

* Clean up some changes

* Update new run test script path and update AndroidTestRunner to use files under CoreRoot

* Add Helix configuration for Android_x64

* Disable test which replies on coreclr System.Private.CoreLib.dll

* Fixed format and removed irrelevant parameters

* Rmoved unused parameters and fixed comment

* Revert my AndroidAppBuilder related changes to prepare for getting Egor's AndroidAppBuilder change

* Fixed rebase and merge error

* Update AndroidTestRunner

* Use the AndroidAppBuilder in the publish folder

* Update runtime test Android App creation command

* Temporarily disable all jobs except for the Android one

* Fix up job running config

* Fixed AndroidTestRunner

* Get Main function return code after running android app

* Fix for skipping building native tests

* Fix helix project path, due to recent coreclr test related files relocation.

* Fix android app running commands

* Add missing helixType

* Update HelixRuntimeRid

* Fix inconsistency

* Create Android app during build preiod.

* Adjust the way to run tests

* Temporary hack before AndroidAppBuilder could accept multiple assemblies

* Use xharness instead of adb to run tests on Androids and disable cmake for Android.

* Cleanup unnecessary changes

* Include xharness Cli

* Use the right xharness command

* Copy runtime assemblies, since the copy logic got removed from AndroidAppBuilder

* Save Android apps in CORE_ROOT dir and adjust BuildAndroidApp target due to rebase from master

* Minor cleanup

* Enable all runtime tests and disable tests caused build failure

* Copy over test helper assemblies and add failing tests to issues.targets

* Remove redundant comment

* Revert previous commit

* Only sending apk files to helix machine

* Delete OutputDir after finishing building the app

* Copy whole Core_Root dir to helix machine.

* Extend timeout threshold

* Extend timeout threshold for each test and each test collection

* Display Android app running logs when tests fail

* Android tests are required to run in sequential

* Check if log file exists before using it.

* Exclude two out-of-memory tests

* Fixed merge error

* Shorten the timeout threshold

* Enable all the lanes

* Fix indentation

* Fixed a few issues from review feedback

* Update src/tests/run.proj

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Only bail out from the bash script when erroring out for andriod

* Extend timeout threshold, since the run could take a long time or a short time on CI.

* Fixed merge error

* Filter out tests using more memory than allowed by helix machine

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

Fix test for 32-bit platforms (#43888)

- Fixed an assertion failure. `WorkerCounter` shouldn't be used in the native thread pool implementation when the portable thread pool is enabled (all the counts will be zero), fixed a missed case in `GetAvailableThreads`.
- The native implementation uses a smaller max default worker thread count by default on 32-bit platforms, allowing configured values to go beyond that. Fixed the portable thread pool implementation to do similar, instead of limiting the max including for configured values.

Add info about how named mutexes work on Unix into code from the orginal PR (#43161)

* Add exception case xml comment for ExecutionContext.Restore

* Add some info about how named mutexes work on Unixes into code from the PR

Remove a volatile access from Task.Id (#43891)

Reimplement Socket.Begin/EndSend/Receive on Send/ReceiveAsync (#43886)

Fix covariant return type validation for canon parents (#43843)

The return type validation was rejecting cases when the method being
overriden had canon type in its generic arguments.
This change fixes the problem by using parent method type instantiation
for constructing the SigTypeContext in such case.
It also adds a regression test.

[RyuJIT] Fold "(X op C1) op C2" to "X op (C1 op C2)" for commutative operators (#43567)

Fold "(X op C1) op C2" to "X op (C1 op C2)"

RyuJIT: Fold Popcnt.PopCount with constant argument (#37836)

Intrinsify BitOperations.PopCount for constant input

add missing CBOR xmldocs (#43882)

Rewrite Socket.ConnectAsync for DNS with async/await (#43661)

* Avoid several WildcardBindForConnectIfNecessary allocations on each connect

* Rewrite Socket.ConnectAsync for DNS with async/await

Rips out all of the APM code that was previously used to implement this and replaces it with {Value}Task-based async/await implementations.

Set TARGET_SIZEOF_VOID_P and SIZEOF_REGISTER correctly when cross compiling. (#43851)

Add IDictionary_Generic_Tests test for multiple values with hash collisions (#43836)

* Add IDictionary_Generic_Tests test for multiple values with hash collisions

* Update src/libraries/System.Collections.Concurrent/tests/ConcurrentDictionary/ConcurrentDictionary.Generic.Tests.cs

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
* Update src/libraries/System.Collections.Concurrent/tests/ConcurrentDictionary/ConcurrentDictionary.Generic.Tests.cs

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>

[Portable thread pool] Don't spin-wait on semaphore when hill climbing stops a thread from processing work (#43840)

[RyuJIT] Propagate gtFlags in Vector.Create (#43578)

Propagate GTF_CALL if needed in GT_LIST. Use gtNewListNode. Ignore test for Mono

Improve annotations for XLinq methods taking params object[] (#43717)

* Improve annotations for XLinq classes taking params object[]

* annotate ref

* address Jozkee's feedback

* Fix XStreamingElement ctor to take nullable content

simplify SslStream_StreamToStream_Alpn_NonMatchingProtocols_Fail test (#43625)

* simplify SslStream_StreamToStream_Alpn_NonMatchingProtocols_Fail test

* feedback from review

Statically linking coreclr and clrjit in single file host (#43556)

* Statically linking coreclr and clrjit in single file host.

* setting g_hmodCoreCLR on Unix

* System.Globalization.Native.lib must build with coreclr to be linkable with it

* Always use system unwind libs on FREEBSD

* no DllMain when coreclr is statically linked

* Handle cases when coreclr configuration is different from libraries

* Adding and using PAL_GetPalHostModule

Revert "Try re-enabling IBC on macOS. (#39801)" (#43839)

This reverts commit 3a4298cf15379678c4d437a6554a1453706cc3b3.

[WIP][interp] Unify execution and valuetype stacks (#43681)

Before this change, an InterpFrame contained 3 regions of data : args + locals, valuetype stack, execution stack. Each entry on the execution stack was a stackval structure. The space for valuetypes, was allocated separately, since they have various sizes. When pushing a valuetype on the stack, we allocated first the space for it on the vtstack and then pushed the address of the region on the execution stack. This change merges the execution stack with the valuetype stack, meaning we push now variable sized data on the execution stack. In order to keep track of the current stack location, whenever we push a type on stack, during transform phase, we also keep track of the offset where this value will reside on stack, as well as the size it occupies. All callsites need to be informed how much they need to pop the stack for the arguments. While called code can access this space normally (the args are special locals belonging to the frame and are accessed directly as such), external code needs a new mechanism to detect each argument for a given frame. This is achieved with the lazily initialized arg_offsets array on an InterpMethod. The method doesn't need to be compiled for this array to be correctly initialized.

Why :
- this simplifies handling of valuetypes, their storage follows the same rules as a normal objref/primitive type
- removes the common use of the vt_sp variable. The compiler no longer needs to reserve it in a register during the switch loop, we no longer need to save it with each call. The sp and ip become now the only variables describing the execution state in a method.
- the flow of the data on the execution stack is well behaved now (with the exception of a few opcodes that update directly based on the stack offset). We were using the vtstack for some magic storage (MINT_VTRESULT for example)
- this makes it such that the stack offset of every value is easily known at compile time, making it possible to completely drop the execution stack approach, and have every opcode have a unique dreg and a list of sregs (which are mapped to a certain stack offset). This will enable more advanced optimizations during compile stage.

Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com>

Merge PAL's _wcslwr into _wcslwr_s (#43265)

In (non-palsuite) product code, `_wcslwr` is only used within PAL
inside `_wcslwr_unsafe()` method, which is exposed as `_wcslwr_s` for
PAL consumers. PR inlines the usage of `_wcslwr` in `_wcslwr_unsafe`
and fixes up PAL tests.

Setting value of enums didn't properly widen the value when setting (#43779)

Use VerifierCorElementType instead of SignatureCorElementType to specify the element type of the target field
- This will send the runtime down the path which can perform primitive widening

Add cancellable and AddressFamily-specific name resolution. (#33420)

Add AddressFamily-specific name resolution and cancellation support for Windows. Resolves #939

Fixed bug in ReadOnlyDictionary's IDictionary.this[object] implementation. This method didn't adhere to IDictionary's contract to return null on a missing key. (#36926)

Bump emscripten to 2.0.6. (#43800)

* Bump emscripten to 2.0.6.

* Define HAVE_SYS_RANDOM_H on wasm, its not detected correctly.

Enhance #43238 so that it covers DefineScope method group with the tests to reflect the behavior added in the PR. (#43790)

ServiceProcess Controller Refactor (#43797)

1. Simplified if checks.
2. Use expression property syntax.
3. Used using declaration.
4. Inlined out declaration.
5. Removed unwated unsafe modifier.
6. Removed redundant casting.

CoreCLR runtime tests + Mono LLVM AOT on arm64 Linux (#41751)

This change:

- Adds new options to mono.proj:

    - MonoAOTEnableLLVM, which enables (or disables) building a Mono AOT
    cross compiler with LLVM;

    - MonoAOTLLVMDir, which specifies the path to a copy of LLVM suitable for
    building a Mono AOT cross compiler, and is optional; and

    - BuildMonoAOTCrossCompilerOnly, which allows building a Mono AOT
    cross compiler without building an associated full Mono runtime.

- Changes offsets-tool.py's user interface slightly; '--include-prefix' is
renamed to '--prefix' and may be specified multiple times. While this latter
feature isn't necessary to build a Mono cross compiler today, because we don't
use distribution-supplied cross-compilation headers on CI, it does make it
easier to experiment with the offsets tool using arbitrary header layouts.  For
example, Debian's arm64 cross-compilation packages scatter useful header files
across `/usr/lib/gcc-cross/aarch64-linux-gnu` and `/usr/aarch64-linux-gnu`.

- Updates the docker image used for arm64 cross-compilation to a newer revision
that includes libclang (see also
https://github.com/dotnet/dotnet-buildtools-prereqs-docker/pull/375).

- Adds some tests that currently fail to compile with Mono LLVM AOT to
issues.targets.

- Adds a Linux_arm64 LLVM AOT job to CI. Nothing particularly fancy is done to
build the Mono LLVM AOT cross compiler; it is built as a step in the same job
that also sends Linux_arm64 tests to Helix.

[docs] Add area-System.Reflection-mono area owners (#43825)

Ensure IBC data is copied to the expected location (#43644)

[w32process-win32] Implement System.Diagnostics.Process::MainWindowHandle. (#43724)

L.A.Noire splash screen calls it to check if the game has opened its window, and stays forever visible if this is not implemented.

Co-authored-by: rbernon <rbernon@users.noreply.github.com>

Fix to set the inner exception for ALC event (#43667)

* Fix to set the inner exception for ALC event

Removes the exception handling at
CLRPrivBinderCoreCLR::BindAssemblyByName so that
the inner exceptioncan be set when the default
AssemblyLoadContext.Resolving handler throws

* Fixing the test for alc.default

* Enhanced the tests by customizing the exception type that
will be thrown by the handlers