github-actions[bot] [Tue, 29 Aug 2023 20:14:33 +0000 (13:14 -0700)]
[release/8.0] [Mono] Fix unsafe accessor related issue for full AOT (#91270)
* Fix unsafe accessor related issue for full aot
* Only skip for WRAPPER_SUBTYPE_UNSAFE_ACCESSOR
---------
Co-authored-by: Fan Yang <yangfan@microsoft.com>
github-actions[bot] [Tue, 29 Aug 2023 17:34:36 +0000 (10:34 -0700)]
[release/8.0] [mono] Extend mono_gsharedvt_constrained_call JIT icall to handle static virtual methods (#91059)
* Extend mono_gsharedvt_constrained_call JIT icall to handle static virtual methods
* Handle static virtual calls in constrained_gsharedvt_call_setup
* Fix lint
* Add runtime test
* Remove runtime test
---------
Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
github-actions[bot] [Tue, 29 Aug 2023 17:27:15 +0000 (10:27 -0700)]
[release/8.0] JIT: Fix various HW intrinsic lowerings for unused values (#91266)
* JIT: Fix LowerHWIntrinsicToScalar with unused values
Fix #91173
* Fix more cases
---------
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
github-actions[bot] [Tue, 29 Aug 2023 17:15:34 +0000 (10:15 -0700)]
[release/8.0] Add Retry and Task.Delay to WinHttpHandler AfterReadResponseServerError_ClientWrite test (#91271)
* Add Task.Delay to give more time for reset frame
* Apply James' solution
---------
Co-authored-by: Ahmet Ibrahim Aksoy (from Dev Box) <aaksoy@microsoft.com>
github-actions[bot] [Tue, 29 Aug 2023 17:14:40 +0000 (10:14 -0700)]
Remove AD0001 NoWarn from Microsoft.Extensions.Logging.Abstractions project (#91236)
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
Jackson Schuster [Mon, 28 Aug 2023 23:01:52 +0000 (16:01 -0700)]
[ComInterfaceGenerator] Recommend [In] and [Out] attributes on array parameters (#91094) (#91231)
Recommend that methods with array parameters use [In] or [Out] attributes if there are none already, and the parameter is not in, ref, or out.
dotnet-maestro[bot] [Mon, 28 Aug 2023 20:54:57 +0000 (14:54 -0600)]
[release/8.0] Update dependencies from dotnet/roslyn-analyzers dotnet/arcade (#91154)
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230825.3
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23424.2 -> To Version 3.11.0-beta1.23425.3
* Update dependencies from https://github.com/dotnet/arcade build
20230825.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23422.1 -> To Version 8.0.0-beta.23425.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23418.1 -> To Version 1.0.0-beta.23423.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update testPackages.proj
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
github-actions[bot] [Mon, 28 Aug 2023 18:06:08 +0000 (12:06 -0600)]
Enable System.IO.Hashing tests on ios and disable tvos (#91195)
Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com>
dotnet-maestro[bot] [Mon, 28 Aug 2023 18:05:35 +0000 (12:05 -0600)]
[release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#91172)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230826.6
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23362.5 -> To Version 1.0.0-prerelease.23426.6
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20230827.2
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
From Version 1.0.0-prerelease.23362.5 -> To Version 1.0.0-prerelease.23427.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet bot [Mon, 28 Aug 2023 16:18:53 +0000 (09:18 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2253168 (#91159)
dotnet-maestro[bot] [Mon, 28 Aug 2023 16:18:04 +0000 (09:18 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91148)
* Update dependencies from https://github.com/dotnet/roslyn build
20230825.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230825.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230825.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23425.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230826.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23424.9 -> To Version 4.8.0-2.23426.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Mon, 28 Aug 2023 16:16:25 +0000 (09:16 -0700)]
[release/8.0] Fix diagnostic creation to ensure including the URI (#91145)
* Fix diagnostic creation to ensure including the URI
* Fix the same issue with the Interop source gen
---------
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
github-actions[bot] [Mon, 28 Aug 2023 16:10:28 +0000 (09:10 -0700)]
[mono] Handle enum return type when inlining CreateInstance (#91061)
Use underlying base type when deciding how to inline a
CreateInstance invocation in mini_emit_inst_for_method.
Fixes https://github.com/dotnet/runtime/issues/90292
(Mono abort causing .NET 8 msbuild regression).
Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
github-actions[bot] [Sat, 26 Aug 2023 22:23:39 +0000 (15:23 -0700)]
Use reader/writer lock instead of mutex for RCW cache (#91149)
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Eric StJohn [Sat, 26 Aug 2023 15:59:34 +0000 (08:59 -0700)]
Merge pull request #91151 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'
Eric StJohn [Sat, 26 Aug 2023 02:43:12 +0000 (19:43 -0700)]
Merge branch 'release/8.0' into merge/release/8.0-rc1-to-release/8.0
dotnet bot [Sat, 26 Aug 2023 02:40:24 +0000 (19:40 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827 (#91144)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2252827
github-actions[bot] [Sat, 26 Aug 2023 00:16:04 +0000 (17:16 -0700)]
[release/8.0] Fix stack_limit handling (#91095)
* Fix stack_limit handling
There is a problem with computing stack_limit in the presence of
inactive InlinedCallFrame. We were trying to call GetCallSiteSP on that
frame to get the call site SP. But when the inlined call frame is not
active (there is no call to native code in progress), that method
returns random junk.
But even if we checked for an active call before reading the value, it
would not get correct stack limit on x86 windows when there was no
active call with the inlined call frame being the topmost one. That
can happen with hardware exception handling on Windows x86. On other
targets, we always have other explicit frame on top of the explicit
frames stack, but on windows x86, we don't use the FaultingExceptionFrame for
hardware exceptions, so the inactive inlined call frame could be the
topmost one when GC starts to scan stack roots.
Since the stack_limit was introduced to fix a Unix specific problem, I
have fixed that by disabling the stack_limit usage for x86 windows.
Close #86265
* Add back the stack_limit field to keep contract unchanged
* Reflect PR feedback - Minimalize the number of ifdefs
* Reflect PR feedback
---------
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
dotnet-maestro[bot] [Sat, 26 Aug 2023 00:15:41 +0000 (17:15 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn-analyzers dotnet/source-build-reference-packages (#91114)
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230824.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23423.2 -> To Version 3.11.0-beta1.23424.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230824.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23421.1 -> To Version 8.0.0-alpha.1.23424.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Fri, 25 Aug 2023 22:27:03 +0000 (15:27 -0700)]
JIT: Fix physical promotion creating overlapping local uses (#91088)
Physical promotion could in some cases create uses overlapping illegally
with defs when faced with seemingly last uses of structs. This is a
result of a mismatch between our model for liveness and the actual model
of local uses in the backend. In the actual model, the uses of LCL_VARs
occur at the user, which means that it is possible for there to be no
place at which to insert IR between to local uses.
The example looks like the following. Physical promotion would be faced
with a tree like
```
▌ CALL void Program:Foo(Program+S,Program+S)
├──▌ LCL_VAR struct<Program+S, 4> V01 loc0
└──▌ LCL_VAR struct<Program+S, 4> V01 loc0
```
When V01 was fully promoted, both of these are logically last uses since
all state of V01 is stored in promoted field locals. Because of that we
would make the following transformation:
```
▌ CALL void Program:Foo(Program+S,Program+S)
├──▌ LCL_VAR struct<Program+S, 4> V01 loc0 (last use)
└──▌ COMMA struct
├──▌ STORE_LCL_FLD int V01 loc0 [+0]
│ └──▌ LCL_VAR int V02 tmp0
└──▌ LCL_VAR struct<Program+S, 4> V01 loc0 (last use)
```
This creates an illegally overlapping use and def; additionally, it is
correct only in a world where the store actually would happen between
the two uses. It is also moderately dangerous to mark both of these as
last uses given the implicit byref transformation.
The fix is to avoid marking a struct use as a last use if we see more
struct uses in the same statement.
Fix #91056
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
github-actions[bot] [Fri, 25 Aug 2023 22:26:42 +0000 (15:26 -0700)]
[release/8.0] [browser] fix MSBuild typo (#91127)
* fix typo
* typo
---------
Co-authored-by: pavelsavara <pavel.savara@gmail.com>
github-actions[bot] [Fri, 25 Aug 2023 22:25:32 +0000 (15:25 -0700)]
[release/8.0] Fix a deadlock in NonGC + Profiler API (#91130)
* Address Jan's feedback
* Fix Debug build
* Clean up
* Fix debug assert
* Update frozenobjectheap.cpp
* Address feedback
* fix build
* Update src/coreclr/vm/frozenobjectheap.cpp
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Address feedback
* Add gc lock for UpdateFrozenSegment
* Address feedback
* Oops, revert unrelated change
* Use preemptive for the whole method
* PublishFrozenObject has to be called in COOP
* Update src/coreclr/vm/frozenobjectheap.cpp
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Address feedback
* Add asserts
* Address feedback
* fix build
* Address feedback
* Update src/coreclr/vm/frozenobjectheap.cpp
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
---------
Co-authored-by: EgorBo <egorbo@gmail.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet-maestro[bot] [Fri, 25 Aug 2023 22:17:09 +0000 (15:17 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91093)
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-1.23424.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230824.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23423.10 -> To Version 4.8.0-2.23424.9
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Fri, 25 Aug 2023 22:11:09 +0000 (15:11 -0700)]
Use RuntimeIdentifierGraphPath if available in runtime copy of Microsoft.NET.CrossGen.targets (#91090)
Co-authored-by: Elinor Fung <elfung@microsoft.com>
github-actions[bot] [Fri, 25 Aug 2023 22:10:54 +0000 (15:10 -0700)]
JIT: Skip Create(ToScalar(Dot(...))) transformation on mismatched types (#91089)
Fix #91062
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
github-actions[bot] [Fri, 25 Aug 2023 22:09:46 +0000 (15:09 -0700)]
[release/8.0] Fix calling existing ctor with MethodInvoker; share tests with invokers (#90968)
* Fix calling existing ctor with MethodInvoker; share tests with invokers
* Remove unnecessary semicolon (non functional)
---------
Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
github-actions[bot] [Thu, 24 Aug 2023 23:24:40 +0000 (16:24 -0700)]
Fix JIT_ByRefWriteBarrier unwinding on macOS x64 (#91076)
Local labels in the JIT_ByRefWriteBarrier were not wrapped in the
LOCAL_LABEL macro. That causes incorrect unwinding in case an
access violation occurs inside of this function. The closest label
before the failure point is considered to be the actual function,
but it obviously doesn't have the right unwind info.
Close #89585
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
github-actions[bot] [Thu, 24 Aug 2023 23:14:26 +0000 (16:14 -0700)]
Suppress credscan warnings in X.509 test files (#91080)
Co-authored-by: Levi Broderick <levib@microsoft.com>
dotnet bot [Thu, 24 Aug 2023 23:13:15 +0000 (16:13 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251942 (#91082)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251732
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251732
github-actions[bot] [Thu, 24 Aug 2023 22:36:51 +0000 (15:36 -0700)]
[release/8.0] `PEImage` should not permit `m_path` field mutation (#91085)
* Remove cases where PEImage::m_path was mutated. Create m_pathHash field and remove function. Remove FEATURE_CASE_SENSITIVE_FILESYSTEM.
* Address contract violations
* Remove try/catch and replace with assert
---------
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
github-actions[bot] [Thu, 24 Aug 2023 16:32:17 +0000 (09:32 -0700)]
Fix manifest MSI version generation (#91023)
Co-authored-by: Jacques Eloff <joeloff@users.noreply.github.com>
dotnet-maestro[bot] [Thu, 24 Aug 2023 15:44:24 +0000 (08:44 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#91033)
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-1.23423.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230823.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23422.14 -> To Version 4.8.0-2.23423.10
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Thu, 24 Aug 2023 15:39:38 +0000 (08:39 -0700)]
Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230823.2 (#91057)
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23421.3 -> To Version 3.11.0-beta1.23423.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet bot [Wed, 23 Aug 2023 23:05:56 +0000 (16:05 -0700)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2251098 (#90996)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2250829
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2250829
github-actions[bot] [Wed, 23 Aug 2023 23:03:49 +0000 (16:03 -0700)]
[release/8.0] [mono][interp] Mask all shift amounts (#90991)
* [tests] Enable tests
* [mono][interp] Mask all shift amounts
---------
Co-authored-by: Vlad Brezae <brezaevlad@gmail.com>
github-actions[bot] [Wed, 23 Aug 2023 23:03:15 +0000 (16:03 -0700)]
Fix --make-repro-path option (#90989)
Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
github-actions[bot] [Wed, 23 Aug 2023 21:53:41 +0000 (14:53 -0700)]
[release/8.0] Support assignment to multiple refs in trim analyzer (#90936)
* Support assignment to multiple refs
* Add support for assigning to arrays
* Fix tests for illink/nativeaot
* Remove ref local test, add issue links
---------
Co-authored-by: Sven Boemer <sbomer@gmail.com>
github-actions[bot] [Wed, 23 Aug 2023 21:44:09 +0000 (14:44 -0700)]
[release/8.0] Fix Type.ContainsGenericParameters for function pointers (#90963)
* Fix Type.ContainsGenericParameters for function pointers
Fixes #84916
* Fix System.Reflection.MetadataLoadContext
* Fix Mono
* Update test
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
github-actions[bot] [Wed, 23 Aug 2023 21:43:00 +0000 (14:43 -0700)]
[release/8.0] Only initialize listeners once (#90932)
* Only initialize listeners once.
* Add test
* Second call
---------
Co-authored-by: Chris R <Tratcher@outlook.com>
github-actions[bot] [Wed, 23 Aug 2023 21:39:22 +0000 (14:39 -0700)]
Remove dbgshim from platform manifest (#90924)
This package has moved out of band and should never conflict.
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
Co-authored-by: Tom McDonald <tommcdon@microsoft.com>
github-actions[bot] [Wed, 23 Aug 2023 21:39:03 +0000 (14:39 -0700)]
Fix runtime knob names for CallCountThreshold and CallCountingDelayMs (#90841)
Co-authored-by: EgorBo <egorbo@gmail.com>
github-actions[bot] [Wed, 23 Aug 2023 21:36:46 +0000 (14:36 -0700)]
Put AO back to AwaitUnsafeOnCompleted (#90980)
Co-authored-by: EgorBo <egorbo@gmail.com>
github-actions[bot] [Wed, 23 Aug 2023 19:54:23 +0000 (12:54 -0700)]
[release/8.0] [mono] Add telemetry for AndroidStripILAfterAOT (#90956)
* Add telemetry for AndroidStripILAfterAOT
* Address review feedback
---------
Co-authored-by: Fan Yang <yangfan@microsoft.com>
Co-authored-by: Fan Yang <52458914+fanyang-mono@users.noreply.github.com>
github-actions[bot] [Wed, 23 Aug 2023 19:51:40 +0000 (12:51 -0700)]
[release/8.0] [mono] Initialize module's image ALC for dynamic objects (#90912)
* Use the image's ALC instead of the default one if exists
* Init module's image ALC
* Add runtime test for dynamic objects
* Fix lint
* Disable test on platforms that don't support dynamic code generation
---------
Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
dotnet-maestro[bot] [Wed, 23 Aug 2023 19:50:25 +0000 (12:50 -0700)]
Update dependencies from https://github.com/dotnet/runtime-assets build
20230821.1 (#90872)
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 8.0.0-beta.23408.1 -> To Version 8.0.0-beta.23421.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
dotnet-maestro[bot] [Wed, 23 Aug 2023 19:49:33 +0000 (12:49 -0700)]
[release/8.0] Update dependencies from dotnet/roslyn (#90816)
* Update dependencies from https://github.com/dotnet/roslyn build
20230818.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230818.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230818.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230818.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230818.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23418.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230819.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23419.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230821.15
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23421.15
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.1
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.1
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.2
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.2
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.3
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.3
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.4
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.5
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.5
* Update dependencies from https://github.com/dotnet/roslyn build
20230821.10
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23421.10
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.6
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.6
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.8
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.8
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.9
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.9
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.7
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.7
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.11
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.11
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.12
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.12
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.13
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-1.23422.13
* Update dependencies from https://github.com/dotnet/roslyn build
20230822.14
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23408.8 -> To Version 4.8.0-2.23422.14
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 23 Aug 2023 15:59:19 +0000 (08:59 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20230822.1 (#90983)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23419.1 -> To Version 8.0.0-beta.23422.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-maestro[bot] [Wed, 23 Aug 2023 05:22:54 +0000 (22:22 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20230817.3 (#90814)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23415.4 -> To Version 8.0.0-beta.23417.3
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23415.1 -> To Version 1.0.0-beta.23416.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Wed, 23 Aug 2023 01:21:57 +0000 (18:21 -0700)]
[release/8.0] [NativeAOT] Missing memory fence before bulk move of objects (#90941)
* Memory fence before bulk move of objects
* deleted GCMemoryHelpers.h
* Introduced a GCHeapMemoryBarrier helper.
---------
Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
github-actions[bot] [Tue, 22 Aug 2023 21:45:25 +0000 (15:45 -0600)]
[release/8.0] Error out when NativeLib has EventPipe enabled (#90934)
* Error out when NativeLib has EventPipe enabled
* Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Co-authored-by: Andy Gocke <andy@commentout.net>
* Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
---------
Co-authored-by: Lakshan Fernando <lakshanf@hotmail.com>
Co-authored-by: Andy Gocke <andy@commentout.net>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet-maestro[bot] [Tue, 22 Aug 2023 19:59:33 +0000 (13:59 -0600)]
[release/8.0] Update dependencies from 7 repositories (#90766)
* Update dependencies from https://github.com/dotnet/icu build
20230814.4
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 9.0.0-alpha.1.23414.4
* Update dependencies from https://github.com/dotnet/msquic build
20230812.1
System.Net.MsQuic.Transport
From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23412.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230816.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23412.1 -> To Version 3.11.0-beta1.23416.1
* Update dependencies from https://github.com/dotnet/cecil build
20230814.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23414.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230817.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23412.1 -> To Version 3.11.0-beta1.23417.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230814.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23414.1
* Revert "Update dependencies from https://github.com/dotnet/icu build
20230814.4"
This reverts commit
6e553e10c4977a6040aa044a608bb1181bb391b6.
* Update dependencies from https://github.com/dotnet/icu build
20230818.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 8.0.0-rc.2.23418.1
* Update dependencies from https://github.com/dotnet/arcade build
20230817.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23415.4 -> To Version 8.0.0-beta.23417.3
* Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23415.1 -> To Version 1.0.0-beta.23416.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/arcade build
20230819.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23415.4 -> To Version 8.0.0-beta.23419.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23415.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230820.2
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23412.1 -> To Version 3.11.0-beta1.23420.2
* Update dependencies from https://github.com/dotnet/cecil build
20230821.1
Microsoft.DotNet.Cecil
From Version 0.11.4-alpha.23407.2 -> To Version 0.11.4-alpha.23421.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build
20230821.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 8.0.0-alpha.0.23407.2 -> To Version 8.0.0-alpha.0.23421.1
* Update dependencies from https://github.com/dotnet/icu build
20230821.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 8.0.0-rc.1.23407.2 -> To Version 8.0.0-rc.2.23421.2
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build
20230821.3
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.11.0-beta1.23412.1 -> To Version 3.11.0-beta1.23421.3
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build
20230821.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23421.1
* [wasm] Fix Wasm.Build.Tests build (#90927)
Prompted by the following getting caught as a warning, and converted to
an error, on windows:
```
EXEC : error : dotnet-install: Failed to check the disk space. Installation will continue, but it may fail if you do not have [D:\a\_work\1\s\src\mono\wasm\Wasm.Build.Tests\Wasm.Build.Tests.csproj]
enough disk space.
dotnet-install: Extracting the archive.
```
(cherry picked from commit
09d7b439fa362c23d6546d1bce9a0a244ff2448f)
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
github-actions[bot] [Tue, 22 Aug 2023 19:40:21 +0000 (13:40 -0600)]
Update Microsoft.Extensions.Http.cs (#90920)
Update ref, add missing `this` to extension method parameter
Co-authored-by: Shreyas Jejurkar <shreyasjejurkar123@live.com>
github-actions[bot] [Tue, 22 Aug 2023 19:38:21 +0000 (13:38 -0600)]
[release/8.0] Update Fedora docker image to Fedora 38 (#90930)
* Update Fedora image to Fedora 38
* (to revert) commit to check Fedora image specifically
* Revert "(to revert) commit to check Fedora image specifically"
This reverts commit
2e2d14e8d9586e5400ce3d7f7afd6ae26e9d9a6c.
---------
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
github-actions[bot] [Tue, 22 Aug 2023 16:19:48 +0000 (09:19 -0700)]
Fix queue count in rate limiters (#90878)
Co-authored-by: Brennan <brecon@microsoft.com>
github-actions[bot] [Mon, 21 Aug 2023 20:52:27 +0000 (13:52 -0700)]
Add missing space in yaml (#90894)
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
github-actions[bot] [Mon, 21 Aug 2023 16:49:58 +0000 (09:49 -0700)]
[release/8.0] Change OneLocBuild mirror branch to release/8.0 (#90813)
* [main] Change OneLocBuild mirror branch to release/8.0 temporarily
* Re-enable OneLocBuild in runtime-official.yml
* Do not modify common, add the parameter in the uncommented lines instead.
* Revert spacing
* Change condition
---------
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
Carlos Sánchez López [Mon, 21 Aug 2023 16:43:31 +0000 (09:43 -0700)]
Merge pull request #90819 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'
github-actions[bot] [Mon, 21 Aug 2023 14:43:57 +0000 (07:43 -0700)]
[release/8.0] Events for IL methods without IL headers (#90844)
* Events for IL methods without IL headers
Dynamically generated methods like UnsafeAccessor
functions are marked as IL, but don't contain an IL
header. The lack of header is an indication the IL must
be generated at runtime.
* Debugger check for no IL header
* Update src/coreclr/debug/daccess/stack.cpp
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
* Review feedback
* Remove redundent calls and another spot to check.
* Move header include
---------
Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
Co-authored-by: Tlakaelel Axayakatl Ceja <tlakaelel.ceja@microsoft.com>
github-actions[bot] [Sat, 19 Aug 2023 16:13:47 +0000 (09:13 -0700)]
[release/8.0-rc1] Use Roslyn interceptors feature in binder gen (#90835)
* Use Roslyn interceptors feature in binder gen
* Fix polymorphic issue and address feedback
* Fix source build issue
* Revert changes to options gen
* Fix
* Work around source build issue
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Larry Ewing [Sat, 19 Aug 2023 02:52:01 +0000 (21:52 -0500)]
Merge branch 'release/8.0' into merge/release/8.0-rc1-to-release/8.0
github-actions[bot] [Sat, 19 Aug 2023 02:33:12 +0000 (19:33 -0700)]
[release/8.0-rc1] [mini] Fix typo in mono_decompose_vtype_opts (#90832)
* Fix typo in mono_decompose_vtype_opts
Without this, if some previous instruction already created a vreg for
ins->dest (for example if we are doing multiple passes over the basic
block because `restart == TRUE`) we will use an incorrect vreg when
decomposing the current VMOVE
Fixes https://github.com/dotnet/runtime/issues/90800
* Only emit an OP_LDTOKEN_FIELD if we loaded a field token
This is used by a CreateSpan optimization that needs access to the
MonoClassField*
For other cases of a bare LDTOKEN (such as hand-written IL that calls
LDTOKEN on a type but doesn't follow it up with a call to
`GetTypeFromHandle` leave the opcode as a VMOVE (from the
`EMIT_NEW_TEMPLOAD` above))
---------
Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
github-actions[bot] [Sat, 19 Aug 2023 01:17:18 +0000 (18:17 -0700)]
Enable telemetry for WasmStripILAfterAOT (#90827)
Co-authored-by: Fan Yang <yangfan@microsoft.com>
github-actions[bot] [Sat, 19 Aug 2023 00:06:10 +0000 (17:06 -0700)]
run nightlies against release/8.0 (#90809)
Co-authored-by: antonfirsov <antonfir@gmail.com>
github-actions[bot] [Fri, 18 Aug 2023 20:04:51 +0000 (13:04 -0700)]
Disable BinderTracingTest.ResolutionFlow test (#90818)
Tracking: #90580
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
github-actions[bot] [Fri, 18 Aug 2023 19:50:30 +0000 (12:50 -0700)]
[release/8.0-rc1] [wasm] Do not build mono libs with `-msimd128` (#90750)
* [wasm] Do not build mono libs with `-msimd128`
Make it optional, build only minimal set of code witch required
`-msimd128` to separate library. Also provide "stub" nosimd
version of this library.
Choose the appropriate library during linking.
* Fix build
* Fix build of non-wasm platforms
* Add simd options for wasi
* Fix wasi build
---------
Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
github-actions[bot] [Fri, 18 Aug 2023 18:11:07 +0000 (11:11 -0700)]
Make DacValidateMD and DacValidateMethodTable more resilient (#90797)
Make both methods more resilient to the case of invalid MethodDesc
and MethodTable with value -1.
Close #90691
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
Carlos Sánchez López [Fri, 18 Aug 2023 14:37:56 +0000 (07:37 -0700)]
Merge pull request #90749 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'
github-actions[bot] [Thu, 17 Aug 2023 23:02:08 +0000 (16:02 -0700)]
[release/8.0] Limit language version on Logger and Options source gens (#90709)
* Limit language version on Logger and Options source gens
* Exclude test in browser
* Address the feedback
* Fix Json test and apply more feedback
* Remove quotes from language versions in source gen diagnostics. (#90720)
---------
Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
mikelle-rogers [Thu, 17 Aug 2023 23:00:36 +0000 (16:00 -0700)]
Revert "Put HasNativeCodeReJITAware into GetFunctionAddress (#90049)" (#90696)
This reverts commit
eacb32e400b3f9d3522bed193bd534d02e8b170a.
Need to investigate changes because they caused a test failure.
github-actions[bot] [Thu, 17 Aug 2023 22:58:58 +0000 (15:58 -0700)]
[release/8.0-rc1] Improve filtering of candidate binding invocations in config binder gen (#90746)
* Improve filtering of candidate binding invocations in config binder gen
* Address feedback
* Address feedback: rename helper; further tighten constraint
* Add follow-up TODO
* Revert TypeSyntax clause to fix failing tests
---------
Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
github-actions[bot] [Thu, 17 Aug 2023 21:49:13 +0000 (14:49 -0700)]
[release/8.0] Switch fx_ver_t::as_str from stringstream to append/to_string (#90760)
* Switch fx_ver_t::as_str from stringstream to append/to_string
* Switch version_t::as_str
* Remove unnecessary include
---------
Co-authored-by: Elinor Fung <elfung@microsoft.com>
github-actions[bot] [Thu, 17 Aug 2023 21:43:10 +0000 (14:43 -0700)]
[release/8.0] [JIT] ARM64 - Temporary fix for ldp/stp optimizations - with test fix (#90758)
* Added regression test 85765
* Mark M4 as NoInlining
* Check current and last ins format to determine whether to proceed with the optimized ldr/str pair
* Additional test
* Feedback
* Fix test
* Fixing test again...
---------
Co-authored-by: TIHan <lol.tihan@gmail.com>
github-actions[bot] [Thu, 17 Aug 2023 21:38:32 +0000 (14:38 -0700)]
[release/8.0] Update Get/SetFieldValue to Account for EnC (#90623)
* update Get/SetFieldValue
* get the address of the instance
* Update src/coreclr/vm/invokeutil.cpp
---------
Co-authored-by: Mikelle <mirogers@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
github-actions[bot] [Thu, 17 Aug 2023 21:35:36 +0000 (14:35 -0700)]
Call SetupNuGetSources for installer jobs (#90759)
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
github-actions[bot] [Thu, 17 Aug 2023 21:33:37 +0000 (14:33 -0700)]
Expose TC_* vars (#90761)
Co-authored-by: EgorBo <egorbo@gmail.com>
github-actions[bot] [Thu, 17 Aug 2023 17:55:24 +0000 (10:55 -0700)]
[wasm] Pin sdk version to 8.0.100-rc.1.23415.5 for workload testing (#90748)
.. because `dotnet-install --channel 8.0` is returning 9.0-alpha sdks right now.
Co-authored-by: Ankit Jain <radical@gmail.com>
github-actions[bot] [Thu, 17 Aug 2023 17:27:20 +0000 (10:27 -0700)]
[release/8.0] JIT: Disallow mismatched GC-ness for physical promotions (#90739)
* JIT: Disallow mismatched GC-ness for physical promotions
Physical promotion was working under the assumption that reinterpreting
GC pointers is undefined behavior, and would happily promote GC pointers
as integers if it saw such accesses. However, physical promotion is
function wide while the UB accesses can be happening in a restricted
(dynamically unreachable) scope. This exact situation happens in
MemoryExtensions.Contains. The issue was uncovered under jit stress
where we did not fold away the guard early enough, meaning that
promotion then saw a `TYP_LONG` access of a `struct { object, int }` and
proceeded to promote it as such.
Fix #90602
* Address feedback
---------
Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Matt Mitchell [Thu, 17 Aug 2023 17:02:09 +0000 (10:02 -0700)]
Call SetupNuGetSources for installer jobs (#90754)
github-actions[bot] [Thu, 17 Aug 2023 16:44:10 +0000 (09:44 -0700)]
Release the stream once the response is sent (#90722)
Co-authored-by: ManickaP <mapichov@microsoft.com>
github-actions[bot] [Thu, 17 Aug 2023 15:25:09 +0000 (09:25 -0600)]
Fix PortableRuntimeIdentifierGraph.json not found during runtime repo source build (#90714)
Co-authored-by: Elinor Fung <elfung@microsoft.com>
Carlos Sánchez López [Thu, 17 Aug 2023 15:24:35 +0000 (08:24 -0700)]
Merge pull request #90668 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'
dotnet-maestro[bot] [Wed, 16 Aug 2023 23:36:32 +0000 (16:36 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20230815.4 (#90665)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23415.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23415.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
github-actions[bot] [Wed, 16 Aug 2023 22:39:04 +0000 (15:39 -0700)]
Do not set fetch depth on source-build (#90704)
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Matt Mitchell [Wed, 16 Aug 2023 22:38:38 +0000 (15:38 -0700)]
Do not set fetch depth on source-build (#90703)
github-actions[bot] [Wed, 16 Aug 2023 20:24:39 +0000 (13:24 -0700)]
[release/8.0] Add doc for the new invoker classes (#90636)
* Add doc new invoker classes
* Fix cref typo
* Misc errors
* Remove arg reference in 0-arg ctor summary
---------
Co-authored-by: Steve Harter <steveharter@users.noreply.github.com>
github-actions[bot] [Wed, 16 Aug 2023 20:22:34 +0000 (13:22 -0700)]
[mono] Add a --path command line argument as an alternative to MONO_PATH. (#90678)
Can be specified multiple times.
Co-authored-by: Zoltan Varga <vargaz@gmail.com>
Steve Pfister [Wed, 16 Aug 2023 20:20:51 +0000 (13:20 -0700)]
[release/8.0-rc1] Bump package version for net7 to 7.0.11 (#90651)
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
github-actions[bot] [Wed, 16 Aug 2023 20:14:48 +0000 (13:14 -0700)]
[release/8.0-rc1] [mono] Fix InlineArray tests on android platforms (#90679)
* Enable inline array tests
* Run android jobs only
* Add verbose logging
* Revert runtime changes
* Remove android-arm64 job
* Rename common assembly and revert CI changes
* Rename assembly name
---------
Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
github-actions[bot] [Wed, 16 Aug 2023 20:12:49 +0000 (13:12 -0700)]
Fix gcroot SOS command on arm/arm64 (#90658)
Faulted in DAC because the HelperMethodFrame's REGDISPLAY CurrentContextPointers were not initialized correctly.
Fixes issue https://github.com/dotnet/diagnostics/issues/3726
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
github-actions[bot] [Wed, 16 Aug 2023 19:42:28 +0000 (21:42 +0200)]
[release/8.0-rc1] Add missing type forwards (#90673)
* Add missing type forwards
Fixes https://github.com/dotnet/runtime/issues/90578
IDispatchImplAttribute, IDispatchImplType and SetWin32ContextInIDispatchAttribute were removed with https://github.com/dotnet/runtime/commit/
9f1dd1aa499a882453b34d4e8810626423fbfed8 and https://github.com/dotnet/runtime/commit/
26a91ad6ac02393c6c7463500c030ec07803c5e6
Those dropped types weren't flagged because APICompat only validates reference assemblies. We have three implementation only shim assemblies: mscorlib, System and System.Data. I verified that no other type forwards were lost between .NET 7 and .NET 8.
* Update mscorlib.cs
---------
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
github-actions[bot] [Wed, 16 Aug 2023 18:44:08 +0000 (12:44 -0600)]
Fix NullableAttribute illink test failures (#90680)
When we started building with preview 7 in
5549f72da3b3cea9e74bb81cfbb0f2d27731fc42, NullableAttribute in
these testcases started to use the attribute definition from the
framework, instead of generating it into the code. This broke the
`--used-attrs-only` optimization because `skip` assemblies (the
default for the framework in these testcases) are treated as if
all types in them are kept, for the purposes of the
`--used-attrs-only` optimization. (The optimization removes
attribute instances unless the attribute type is preserved for
some other reason).
It's not clear what the intended behavior of `--used-attrs-only`
is for `skip` assemblies, and the discussion in
https://github.com/dotnet/linker/issues/952 indicates that it's
considered experimental, so this fixes the failures by using the
`link` action. This represents a more realistic scenario since
`skip` is mainly used in testing to avoid linking the framework
in every testcase.
Co-authored-by: Sven Boemer <sbomer@gmail.com>
github-actions[bot] [Wed, 16 Aug 2023 18:27:32 +0000 (12:27 -0600)]
Fix problems with `Assembler::ReflectionNotation()` (#90655)
Do more parameter validation, correct buffer size calculations
for security-enhanced CRT functions, and avoid memcpy
buffer overrun of locale.
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
Alhad Deshpande [Wed, 16 Aug 2023 18:26:28 +0000 (23:56 +0530)]
[ppc64le] performance improvements while branching (#90656)
github-actions[bot] [Wed, 16 Aug 2023 17:58:54 +0000 (11:58 -0600)]
[release/8.0-rc1] Unify with logging category matching (#90642)
* Unify with logging category matching
* -1 => 0
* Weird overlapping match
---------
Co-authored-by: Chris R <Tratcher@outlook.com>
Carlos Sánchez López [Wed, 16 Aug 2023 15:32:48 +0000 (08:32 -0700)]
Merge pull request #90628 from dotnet-maestro-bot/merge/release/8.0-rc1-to-release/8.0
[automated] Merge branch 'release/8.0-rc1' => 'release/8.0'
github-actions[bot] [Wed, 16 Aug 2023 15:32:09 +0000 (08:32 -0700)]
[release/8.0-rc1] Annotate System.Linq.Expressions with RequiresDynamicCode (#90616)
* Annotate System.Linq.Expressions with RequiresDynamicCode
All this ended up with an RUC on Expression.Compile due to new arrays.
I could potentially silence this warning with a feature flag, but it is a
real risk, and one that users could maybe work around if alterted to the problem.
* Remove suppression that's no longer needed
* Fix tests for new feature switch behavior
* Update src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Expression.cs
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Typo in Throws call
* Fix assert for net framework
* Respond to PR comments
* Add suppression
* Typo
* Update src/libraries/System.Linq.Expressions/src/Resources/Strings.resx
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* PR feedback
---------
Co-authored-by: Andy Gocke <andy@commentout.net>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
github-actions[bot] [Wed, 16 Aug 2023 14:38:41 +0000 (07:38 -0700)]
[release/8.0-rc1] Fix support for non-public default constructors using JsonIncludeAttribute (#90615)
* Fix support for non-public constructors using JsonIncludeAttribute
* Address feedback.
---------
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
github-actions[bot] [Wed, 16 Aug 2023 14:26:12 +0000 (07:26 -0700)]
[release/8.0] Return false from ComWrappers.Try... methods (#90635)
* Return false from ComWrappers.Try... methods
Return false from ComWrappers.TryGetComInstance/TryGetObject instead of
throwing PNSE. It saves callers from needing to protect against PNSE.
Fix #90311
* More efficient IsWindows check
---------
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet-maestro[bot] [Wed, 16 Aug 2023 14:17:22 +0000 (07:17 -0700)]
Update dependencies from https://github.com/dotnet/emsdk build
20230815.5 (#90649)
Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
From Version 8.0.0-rc.1.23411.2 -> To Version 8.0.0-rc.1.23415.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Carlos Sánchez López [Wed, 16 Aug 2023 04:53:03 +0000 (21:53 -0700)]
Merge branch 'release/8.0' into merge/release/8.0-rc1-to-release/8.0