platform/upstream/mesa.git
2 years agoradv/rt: use stage ID as handle for general and closestHit shaders
Daniel Schürmann [Fri, 22 Apr 2022 12:18:36 +0000 (14:18 +0200)]
radv/rt: use stage ID as handle for general and closestHit shaders

This avoids some code duplication and divergence.

Quake II RTX:
Totals from 7 (0.01% of 134913) affected shaders:
CodeSize: 218880 -> 217592 (-0.59%)
Instrs: 39692 -> 39468 (-0.56%)
Latency: 789091 -> 761581 (-3.49%)
InvThroughput: 526061 -> 507721 (-3.49%)
VClause: 1202 -> 1188 (-1.16%)
Copies: 4649 -> 4621 (-0.60%)
Branches: 1605 -> 1598 (-0.44%)

Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17301>

2 years agoradv/rt: use derefs for the traversal stack
Daniel Schürmann [Thu, 21 Apr 2022 22:29:02 +0000 (00:29 +0200)]
radv/rt: use derefs for the traversal stack

Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17301>

2 years agoradv: create RT traversal as separate shader
Daniel Schürmann [Thu, 21 Apr 2022 19:33:10 +0000 (21:33 +0200)]
radv: create RT traversal as separate shader

This will help in future to keep the main shader slim
when we have actual function calls.

Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17301>

2 years agoradv: Only create noop-fs for graphics pipelines
Daniel Schürmann [Fri, 13 May 2022 14:14:34 +0000 (16:14 +0200)]
radv: Only create noop-fs for graphics pipelines

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17301>

2 years agoanv: implement Wa_14015264727 for DG2
Tapani Pälli [Wed, 20 Jul 2022 12:29:22 +0000 (15:29 +0300)]
anv: implement Wa_14015264727 for DG2

On DG2 we need to flush data cache before fast clear operation.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17218>

2 years agoiris: implement Wa_14015264727 for DG2
Tapani Pälli [Wed, 20 Jul 2022 09:30:32 +0000 (12:30 +0300)]
iris: implement Wa_14015264727 for DG2

On DG2 we need to flush data cache before fast clear operation.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17218>

2 years agod3d12: Remove state tracking implementation details from header
Jesse Natalie [Thu, 21 Jul 2022 19:46:23 +0000 (12:46 -0700)]
d3d12: Remove state tracking implementation details from header

Now that the old state tracking code is removed, implementation details
no longer need to be leaked out of this single source file. Remove structs,
function declarations, 'd3d12_' prefixes, and add static when possible.

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Add a transition flag indicating that state accumulation is needed
Jesse Natalie [Thu, 21 Jul 2022 17:15:25 +0000 (10:15 -0700)]
d3d12: Add a transition flag indicating that state accumulation is needed

Most call sites for transitions will only apply transitions to one or two
resources, and don't need to use the bo set, where each call is guaranteed
to insert the bo, only to walk the set immediately afterwards. Instead, they
can just append the barriers to the dynarray directly and skip the bo set.

Draws and dispatches still use the append approach, to accumulate the full
set of state needed for each subresource for the case where a single
[sub]resource is bound to the pipeline in multiple places.

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Optimize transition_subresource_states that covers a whole resource
Jesse Natalie [Thu, 21 Jul 2022 17:00:01 +0000 (10:00 -0700)]
d3d12: Optimize transition_subresource_states that covers a whole resource

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Extract core barrier logic
Jesse Natalie [Thu, 21 Jul 2022 16:21:41 +0000 (09:21 -0700)]
d3d12: Extract core barrier logic

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Rename bind invalidate options to transition flags
Jesse Natalie [Thu, 21 Jul 2022 16:10:13 +0000 (09:10 -0700)]
d3d12: Rename bind invalidate options to transition flags

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Swap the remainder of state tracking to new method
Jesse Natalie [Thu, 21 Jul 2022 03:25:29 +0000 (20:25 -0700)]
d3d12: Swap the remainder of state tracking to new method

Uses a set of d3d12_bo on the context to track which bos are pending
a transition instead of an intrusive linked list, since the bo may
need to be pending on multiple contexts at once.

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Record a state fixup command list when necessary
Jesse Natalie [Wed, 20 Jul 2022 19:03:21 +0000 (12:03 -0700)]
d3d12: Record a state fixup command list when necessary

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Track a global resource state for non-simultaneous-access resources
Jesse Natalie [Wed, 20 Jul 2022 14:45:59 +0000 (07:45 -0700)]
d3d12: Track a global resource state for non-simultaneous-access resources

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Create/free context state entries
Jesse Natalie [Wed, 20 Jul 2022 14:02:38 +0000 (07:02 -0700)]
d3d12: Create/free context state entries

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Treat depth/stencil as planar for plane count helper
Jesse Natalie [Wed, 20 Jul 2022 14:00:36 +0000 (07:00 -0700)]
d3d12: Treat depth/stencil as planar for plane count helper

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Add a context state tracking structure
Jesse Natalie [Wed, 20 Jul 2022 12:31:01 +0000 (05:31 -0700)]
d3d12: Add a context state tracking structure

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Notify contexts about deletion of bos
Jesse Natalie [Tue, 19 Jul 2022 22:42:04 +0000 (15:42 -0700)]
d3d12: Notify contexts about deletion of bos

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Hold lock when removing resources from residency list
Jesse Natalie [Tue, 19 Jul 2022 22:30:07 +0000 (15:30 -0700)]
d3d12: Hold lock when removing resources from residency list

Also, remove them from the list before releasing the ID3D12Resource.

Fixes: 671deb54 ("d3d12: Add residency info to d3d12_bo")
Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Add a list of contexts alive for the current screen
Jesse Natalie [Tue, 19 Jul 2022 22:07:42 +0000 (15:07 -0700)]
d3d12: Add a list of contexts alive for the current screen

When a resource is destroyed, we'll need to let the contexts know.
This is guarded by the submit mutex, because we'll already be holding
that for at least one place where we want to iterate this list, and
it's low-frequency enough that re-using it is simpler than adding more
locks and creating confusing lock ordering.

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Give bos a unique identifier to be used for state tracking
Jesse Natalie [Tue, 19 Jul 2022 21:47:47 +0000 (14:47 -0700)]
d3d12: Give bos a unique identifier to be used for state tracking

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Move current resource state to new files
Jesse Natalie [Mon, 18 Jul 2022 23:11:59 +0000 (16:11 -0700)]
d3d12: Move current resource state to new files

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Move desired resource state to new files
Jesse Natalie [Mon, 18 Jul 2022 21:28:30 +0000 (14:28 -0700)]
d3d12: Move desired resource state to new files

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agod3d12: Add a blank d3d12_resource_state.h/cpp
Jesse Natalie [Mon, 18 Jul 2022 20:20:26 +0000 (13:20 -0700)]
d3d12: Add a blank d3d12_resource_state.h/cpp

This will host some code that's moving and ported to match style
with the rest of the driver, and other code that will be re-written.

Reviewed-by: Bill Kristiansen <billkris@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17688>

2 years agoutil/vbuf: handle multidraws
Mike Blumenkrantz [Thu, 21 Jul 2022 16:48:17 +0000 (12:48 -0400)]
util/vbuf: handle multidraws

this moves the handling from cso_conext to vbuf, which reduces overhead
for draws that aren't rewritten

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17686>

2 years agoglsl: correctly track cross slot component packing
Timothy Arceri [Fri, 22 Jul 2022 01:59:49 +0000 (11:59 +1000)]
glsl: correctly track cross slot component packing

Otherwise we will mix and match mesa's custom cross slot packing
with arb_enhanced_layouts style packing and we won't correctly
handle the size of the vars needed for the mesa custom packing.

The code was working correctly if the shader interface had both
a matching input and output but when we only had one side of
the interface we were only marking a single slot location as
packed.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Fixes: e5122a55435d ("glsl: add a NIR based varying linker")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6853
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17550>

2 years agoetnaviv: remove etna_align_up() function
Lucas Stach [Thu, 21 Jul 2022 19:50:37 +0000 (21:50 +0200)]
etnaviv: remove etna_align_up() function

It does the same thing as align() from u_math.h, no need to
have a etnaviv specific version.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17695>

2 years agozink: drop pointless comment
Erik Faye-Lund [Thu, 21 Jul 2022 10:22:43 +0000 (12:22 +0200)]
zink: drop pointless comment

We're already handling all the meaningful types here. The other types
like samplers, images, structs etc aren't really appropriate here.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17676>

2 years agozink: remove pointless assert
Erik Faye-Lund [Wed, 13 Apr 2022 08:32:26 +0000 (10:32 +0200)]
zink: remove pointless assert

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17676>

2 years agozink: remove pointless test
Erik Faye-Lund [Wed, 13 Apr 2022 08:30:28 +0000 (10:30 +0200)]
zink: remove pointless test

These are already all the bitsizes there are. No need to test for them.

Besides, get_uvec_type already contains an assert for the same
condition anyway.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17676>

2 years agoac/nir/ngg: Remember proper bit sizes of GS output variables.
Timur Kristóf [Sun, 17 Jul 2022 18:36:43 +0000 (20:36 +0200)]
ac/nir/ngg: Remember proper bit sizes of GS output variables.

The LLVM backend keeps track of 16-bit output variables and it will
miscompile shaders when these outputs aren't the correct bitsize.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17706>

2 years agoac/nir/ngg: Copy comment about LDS layout for NGG GS.
Timur Kristóf [Wed, 8 Sep 2021 08:37:09 +0000 (10:37 +0200)]
ac/nir/ngg: Copy comment about LDS layout for NGG GS.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17706>

2 years agoac/llvm: Use gs_prim_id for NGG VS.
Timur Kristóf [Sun, 17 Jul 2022 17:08:11 +0000 (19:08 +0200)]
ac/llvm: Use gs_prim_id for NGG VS.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17706>

2 years agoac/llvm: Add LLVM bug workaround to ac_build_mbcnt_add.
Timur Kristóf [Thu, 19 May 2022 21:13:28 +0000 (23:13 +0200)]
ac/llvm: Add LLVM bug workaround to ac_build_mbcnt_add.

LLVM always believes that this instruction's upper bound is the wave
size, regardless of ac_set_range_metadata and regardless of whether
the add source is used.

As a workaround, emit an extra add instruction.

Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17706>

2 years agoac/llvm: Implement load_num_subgroups for NGG shaders.
Timur Kristóf [Thu, 9 Sep 2021 14:19:37 +0000 (16:19 +0200)]
ac/llvm: Implement load_num_subgroups for NGG shaders.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17706>

2 years agoradv: Simplify the meta init fail path
Konstantin Seurer [Wed, 20 Jul 2022 12:49:38 +0000 (14:49 +0200)]
radv: Simplify the meta init fail path

Move most of the the cleanup into radv_device_init_meta.

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17652>

2 years agoradv: Use RADV_META_SUSPEND_PREDICATING
Konstantin Seurer [Tue, 19 Jul 2022 12:39:06 +0000 (14:39 +0200)]
radv: Use RADV_META_SUSPEND_PREDICATING

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17625>

2 years agoradv: Add meta saving/restoring for predicating
Konstantin Seurer [Tue, 19 Jul 2022 12:11:15 +0000 (14:11 +0200)]
radv: Add meta saving/restoring for predicating

There are a bunch of places, where this is done manually.

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17625>

2 years agollvmpipe: fix aniso cube map arrays.
Dave Airlie [Fri, 22 Jul 2022 03:59:11 +0000 (13:59 +1000)]
llvmpipe: fix aniso cube map arrays.

There was a coordinate missing when you have cube map arrays,
and aniso sampling.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Fixes: ce2b711c0a5d ("gallivm: add support for anisotropic sampling.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17704>

2 years agoRevert "venus: suballocate more for layering"
Yiwei Zhang [Fri, 22 Jul 2022 01:16:34 +0000 (01:16 +0000)]
Revert "venus: suballocate more for layering"

This reverts commit f96e25ae0530be62e8c4b0ca6631643725753190.

It's causing vkbench oom failure on radv.

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17701>

2 years agozink: Mark depth/stencil visual tests as flakes
Jason Ekstrand [Fri, 22 Jul 2022 00:18:09 +0000 (19:18 -0500)]
zink: Mark depth/stencil visual tests as flakes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Don't assert VkGraphicsPipelineLibraryCreateInfoEXT::Flags == 0
Jason Ekstrand [Wed, 20 Jul 2022 23:17:21 +0000 (18:17 -0500)]
vulkan: Don't assert VkGraphicsPipelineLibraryCreateInfoEXT::Flags == 0

There are VUs that imply that this is a requirement but the CTS seems to
ignore it.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Input assembly and depth/stencil can also be fully dynamic
Jason Ekstrand [Thu, 21 Jul 2022 19:41:43 +0000 (14:41 -0500)]
vulkan: Input assembly and depth/stencil can also be fully dynamic

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Fix pipeline libraries with dynamic-only VI or FSR state
Jason Ekstrand [Wed, 20 Jul 2022 18:58:44 +0000 (13:58 -0500)]
vulkan: Fix pipeline libraries with dynamic-only VI or FSR state

When we initialize the graphics pipeline state, we skip VI and FSR state
if they're 100% dynamic.  We need to do this if the current set of
dynamic things contains VI/FSR or if the set of dynamic state already in
the vk_graphics_pipeline_state has them dynamic.  Look state->dynamic
after we've merged instead of just looking at the dynamic set from the
VkGraphicsPipelineCreateInfo we were passed.

Also, when we validate, we need to assume that VI and FSR exist or else
we'll assert if dynamic VI or FSR are set.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Add a fully_dynamic_state_groups() helper
Jason Ekstrand [Thu, 21 Jul 2022 19:35:25 +0000 (14:35 -0500)]
vulkan: Add a fully_dynamic_state_groups() helper

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Depth/stencil isn't fragment output state but multisample is
Jason Ekstrand [Wed, 20 Jul 2022 18:32:28 +0000 (13:32 -0500)]
vulkan: Depth/stencil isn't fragment output state but multisample is

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Multisample state isn't always included in fragment shader state
Jason Ekstrand [Wed, 20 Jul 2022 20:38:28 +0000 (15:38 -0500)]
vulkan: Multisample state isn't always included in fragment shader state

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Record shader stages in vk_graphics_pipeline_state
Jason Ekstrand [Wed, 20 Jul 2022 20:11:57 +0000 (15:11 -0500)]
vulkan: Record shader stages in vk_graphics_pipeline_state

Some of our asserts and other checks depend on the total set of stages,
not just the stages set in the current pCreateInfo.  Recording the stage
mask lets us combine them in vk_graphics_pipeline_state_merge().

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agovulkan: Allow up to 12 pointers in multialloc
Jason Ekstrand [Wed, 20 Jul 2022 02:37:11 +0000 (21:37 -0500)]
vulkan: Allow up to 12 pointers in multialloc

vk_graphics_pipeline_state_init() may allocate up to 12 things so expand
vk_multialloc accordingly.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17696>

2 years agoturnip: fix an assertion with drm-shim
Chia-I Wu [Fri, 15 Jul 2022 18:31:16 +0000 (11:31 -0700)]
turnip: fix an assertion with drm-shim

Fixes

  deqp-vk: ../src/vulkan/runtime/vk_device.c:49:
  get_timeline_mode: Assertion `timeline_type == NULL' failed.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17571>

2 years agofreedreno/drm-shim: add a660
Chia-I Wu [Fri, 15 Jul 2022 18:21:22 +0000 (11:21 -0700)]
freedreno/drm-shim: add a660

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17571>

2 years agoRevert "ci/freedreno: Switch a630 to manual/disabled for lab maintenance."
Emma Anholt [Wed, 20 Jul 2022 19:23:59 +0000 (12:23 -0700)]
Revert "ci/freedreno: Switch a630 to manual/disabled for lab maintenance."

This reverts commit 7e381ba9fcc4b2cba0ab72fdfbe5535561e23f6c.  2 new
boards are in place, bringing us from 7 to 9.  We hoped for 12, but have
ongoing power stability issues.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17662>

2 years agoci/turnip: Add a couple of missing a630 fails.
Emma Anholt [Thu, 21 Jul 2022 21:22:52 +0000 (14:22 -0700)]
ci/turnip: Add a couple of missing a630 fails.

Same as a618.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17662>

2 years agoci/turnip: Bump up the a630 full run timeout.
Emma Anholt [Thu, 21 Jul 2022 21:20:22 +0000 (14:20 -0700)]
ci/turnip: Bump up the a630 full run timeout.

Test runtime has crept up with more CTS tests and more features.  The last
vk_full 1/2 run I tried timed out at:

Pass: 268488, Fail: 2, ExpectedFail: 7, Warn: 1, Skip: 602571, Duration: 1:29:29, Remaining: 45

Rude.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17662>

2 years agoci/freedreno: Add some more known flakes for a630 from our IRC logs.
Emma Anholt [Wed, 20 Jul 2022 19:29:23 +0000 (12:29 -0700)]
ci/freedreno: Add some more known flakes for a630 from our IRC logs.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17662>

2 years agod3d12: Support clip halfz
Jesse Natalie [Mon, 7 Feb 2022 17:49:33 +0000 (09:49 -0800)]
d3d12: Support clip halfz

Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17567>

2 years agod3d12: Enable VPP rotation, flip, alpha blend, crop, scaling via pipe_video_codec...
Sil Vilerino [Fri, 15 Jul 2022 12:04:49 +0000 (08:04 -0400)]
d3d12: Enable VPP rotation, flip, alpha blend, crop, scaling via pipe_video_codec::process_frame

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agod3d12: Add pipe_video_codec::process_frame implementation
Sil Vilerino [Fri, 15 Jul 2022 12:03:56 +0000 (08:03 -0400)]
d3d12: Add pipe_video_codec::process_frame implementation

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agova: Add support for VPP rotation, flip, alpha blend, crop, scaling
Sil Vilerino [Fri, 15 Jul 2022 12:01:41 +0000 (08:01 -0400)]
va: Add support for VPP rotation, flip, alpha blend, crop, scaling

Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agogallium/video: Add video post processing interface
Sil Vilerino [Thu, 21 Jul 2022 16:34:55 +0000 (12:34 -0400)]
gallium/video: Add video post processing interface

Add process_frame to pipe_video codec
Add new structures/caps for video post-processing with rotation,
flip, alpha blending, crop, and scaling, via the video engine.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agova: Replace usage of entrypoint UNKNOWN with PROCESSING for VP
Sil Vilerino [Thu, 21 Jul 2022 16:41:45 +0000 (12:41 -0400)]
va: Replace usage of entrypoint UNKNOWN with PROCESSING for VP

Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agovl: Replace usage of entrypoint UNKNOWN with PROCESSING for VP
Sil Vilerino [Thu, 21 Jul 2022 16:41:32 +0000 (12:41 -0400)]
vl: Replace usage of entrypoint UNKNOWN with PROCESSING for VP

Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agopipe/video: Add PIPE_VIDEO_ENTRYPOINT_PROCESSING
Sil Vilerino [Thu, 21 Jul 2022 16:36:15 +0000 (12:36 -0400)]
pipe/video: Add PIPE_VIDEO_ENTRYPOINT_PROCESSING

Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agod3d12: Video - Remove unused spCopyQueues from enc/dec objects
Sil Vilerino [Fri, 8 Jul 2022 19:01:29 +0000 (15:01 -0400)]
d3d12: Video - Remove unused spCopyQueues from enc/dec objects

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17557>

2 years agoanv: allocate RT scratch in local memory
Lionel Landwerlin [Thu, 21 Jul 2022 09:27:16 +0000 (09:27 +0000)]
anv: allocate RT scratch in local memory

Like a 100x (not joking) improvement.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17674>

2 years agoac/nir/ngg: Create output variable for primitive ID export.
Timur Kristóf [Sun, 17 Jul 2022 19:34:06 +0000 (21:34 +0200)]
ac/nir/ngg: Create output variable for primitive ID export.

This makes the RADV/LLVM backend happy and mitigates a crash.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17581>

2 years agoaco: Remove hack for primitive ID export.
Timur Kristóf [Sun, 17 Jul 2022 19:34:43 +0000 (21:34 +0200)]
aco: Remove hack for primitive ID export.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17581>

2 years agoac/nir/ngg: Move primitive ID workgroup barrier to proper place.
Timur Kristóf [Mon, 18 Jul 2022 13:42:57 +0000 (15:42 +0200)]
ac/nir/ngg: Move primitive ID workgroup barrier to proper place.

Previously, it was in a divergent branch, therefore
it could hang the GPU when a workgroup had a primitive-only wave.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17581>

2 years agoac/nir/ngg: Decouple primitive ID store and primitive export.
Qiang Yu [Thu, 14 Jul 2022 04:45:45 +0000 (12:45 +0800)]
ac/nir/ngg: Decouple primitive ID store and primitive export.

There's no dependency between them.

This can simplify the compiler backend translation by
always storing prim id before vertex export, which also
benefits the LLVM backend in latter changes.

Signed-off-by: Qiang Yu <yuq825@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17581>

2 years agolavapipe: Use more Vulkan NIR heleprs
Jason Ekstrand [Tue, 19 Jul 2022 23:16:18 +0000 (18:16 -0500)]
lavapipe: Use more Vulkan NIR heleprs

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17644>

2 years agovulkan: Call gather_xfb_info in vk_spirv_to_nir
Jason Ekstrand [Wed, 20 Jul 2022 00:20:38 +0000 (19:20 -0500)]
vulkan: Call gather_xfb_info in vk_spirv_to_nir

In particular, we now call it before running dead variables so we get
the XFB info even for things which are never written.  This fixes a 102
Vulkan CTS tests on ANV and probably turnip as well.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17644>

2 years agovulkan/nir: Don't remove dead XFB outputs
Jason Ekstrand [Wed, 20 Jul 2022 18:45:45 +0000 (13:45 -0500)]
vulkan/nir: Don't remove dead XFB outputs

Fixes: 21b405fbbc53 ("vulkan: Add a vk_shader_module_to_nir() helper")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17644>

2 years agovulkan: Call lower_clip_cull_distance_arrays in vk_spirv_to_nir
Jason Ekstrand [Wed, 20 Jul 2022 00:19:42 +0000 (19:19 -0500)]
vulkan: Call lower_clip_cull_distance_arrays in vk_spirv_to_nir

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17644>

2 years agoiris/bufmgr: Add assert and TODO comment for future small BAR uapi
Jordan Justen [Tue, 21 Jun 2022 22:12:18 +0000 (15:12 -0700)]
iris/bufmgr: Add assert and TODO comment for future small BAR uapi

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agoanv/allocator: Add assert and TODO comment for future small BAR uapi
Jordan Justen [Tue, 21 Jun 2022 22:43:32 +0000 (15:43 -0700)]
anv/allocator: Add assert and TODO comment for future small BAR uapi

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agoiris: Set clear_color_unknown if the bo is not mappable
Jordan Justen [Mon, 16 May 2022 17:47:15 +0000 (10:47 -0700)]
iris: Set clear_color_unknown if the bo is not mappable

Rework:
 * Ken: Check bo for IRIS_MMAP_NONE rather than the global
   intel_vram_all_mappable

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agoiris/bufmgr: Set mmap_mode to IRIS_MMAP_NONE for lmem in small-BAR mode
Jordan Justen [Fri, 15 Jul 2022 17:16:19 +0000 (10:16 -0700)]
iris/bufmgr: Set mmap_mode to IRIS_MMAP_NONE for lmem in small-BAR mode

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Suggested-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agoiris/bufmgr: Add all_vram_mappable which is currently always true
Jordan Justen [Mon, 16 May 2022 16:48:23 +0000 (09:48 -0700)]
iris/bufmgr: Add all_vram_mappable which is currently always true

This can be false on systems where the PCI Base Address Register (BAR)
is too small for the amount of VRAM. Eventually the kernel will be
able to tell us that a system can't map all of VRAM, and
`all_vram_mappable` will then be false.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agoiris/resource: Avoid mapping when not needed in iris_resource_init_aux_buf()
Jordan Justen [Mon, 16 May 2022 09:43:03 +0000 (02:43 -0700)]
iris/resource: Avoid mapping when not needed in iris_resource_init_aux_buf()

We might not be able to map all vram buffers in the future, so only
map the buffer when actually required.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agoiris/resource: Assert that DG2 CCS buffers don't also try to set BO_ALLOC_SMEM
Jordan Justen [Mon, 16 May 2022 09:35:11 +0000 (02:35 -0700)]
iris/resource: Assert that DG2 CCS buffers don't also try to set BO_ALLOC_SMEM

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agointel/dev: Add intel_vram_all_mappable()
Jordan Justen [Mon, 16 May 2022 10:02:01 +0000 (03:02 -0700)]
intel/dev: Add intel_vram_all_mappable()

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agointel/tools: Print unmappable region info in intel_dev_info
Jordan Justen [Tue, 14 Jun 2022 06:45:35 +0000 (23:45 -0700)]
intel/tools: Print unmappable region info in intel_dev_info

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agointel/dev: Add vram.unmappable.size region info
Jordan Justen [Sat, 11 Jun 2022 01:10:27 +0000 (18:10 -0700)]
intel/dev: Add vram.unmappable.size region info

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agointel/dev: deal with i915 unallocated_size on smem
Lionel Landwerlin [Wed, 22 Jun 2022 07:51:13 +0000 (10:51 +0300)]
intel/dev: deal with i915 unallocated_size on smem

We cannot rely on unallocated_size on system memory for
VK_EXT_memory_budget.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 4aecfbf0f4ab ("intel/dev: Add devinfo::mem to store i915 regions information")
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17349>

2 years agottn: set dest_type for TXQ
Marek Olšák [Sun, 17 Jul 2022 14:48:12 +0000 (10:48 -0400)]
ttn: set dest_type for TXQ

It was failing an assertion in tgsi_to_nir and NIR validation.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17691>

2 years agoir3: Stop using nir_legalize_16bit_sampler_srcs.
Georg Lehmann [Thu, 21 Jul 2022 13:04:48 +0000 (15:04 +0200)]
ir3: Stop using nir_legalize_16bit_sampler_srcs.

nir_fold_16bit_tex_image's only_fold_all option ensures that there is never
a mix of bit sizes.

Closes https://gitlab.freedesktop.org/mesa/mesa/-/issues/6899

Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16978>

2 years agonir/lower_mediump: Add an option to only fold if all tex sources can be folded.
Georg Lehmann [Wed, 6 Jul 2022 15:00:34 +0000 (17:00 +0200)]
nir/lower_mediump: Add an option to only fold if all tex sources can be folded.

Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16978>

2 years agonir: Rewrite and merge 16bit tex folding pass with 16bit image folding pass.
Georg Lehmann [Sat, 4 Jun 2022 13:56:31 +0000 (15:56 +0200)]
nir: Rewrite and merge 16bit tex folding pass with 16bit image folding pass.

Allow folding constants/undef sources by sharing more code with the image_store
16bit folding pass.

Allow more than one set of sources because RADV wants two, one for
G16 (ddx/ddy) and one for A16 (all other sources).

Allow folding cube sampling destination conversions on radeonsi/radv because
I think the limitation only applies to sources.

Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16978>

2 years agoir3: Lower alu to scalar if nir_legalize_16bit_sampler_srcs made progress.
Georg Lehmann [Tue, 19 Jul 2022 20:44:42 +0000 (22:44 +0200)]
ir3: Lower alu to scalar if nir_legalize_16bit_sampler_srcs made progress.

Fixes: 003327dd95b ("freedreno/ir3: Pass 16-bit sampler coordinates when possible.")
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16978>

2 years agoir3: Only run 16bit tex NIR passes on a5xx+.
Georg Lehmann [Tue, 19 Jul 2022 18:48:42 +0000 (20:48 +0200)]
ir3: Only run 16bit tex NIR passes on a5xx+.

16bit types aren't yet supported on older hardware.

Signed-off-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16978>

2 years agozink: add env var to abort on device-lost if no reset callback is set
Mike Blumenkrantz [Tue, 12 Jul 2022 13:17:25 +0000 (09:17 -0400)]
zink: add env var to abort on device-lost if no reset callback is set

the alternative here is to just spin aimlessly until the process ooms,
which causes problems when trying to detect failures in cts caselists

a separate env var is used so that it can be exported without affecting
ZINK_DEBUG

Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17525>

2 years agogallium/tests: Remove format desc null checks
Konstantin Seurer [Tue, 12 Jul 2022 13:43:44 +0000 (15:43 +0200)]
gallium/tests: Remove format desc null checks

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agoutil/format: Remove format desc null checks
Konstantin Seurer [Tue, 12 Jul 2022 13:42:12 +0000 (15:42 +0200)]
util/format: Remove format desc null checks

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agopvr: Remove format desc null check
Konstantin Seurer [Tue, 12 Jul 2022 13:34:19 +0000 (15:34 +0200)]
pvr: Remove format desc null check

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agovirgl: Remove format desc null checks
Konstantin Seurer [Tue, 12 Jul 2022 13:30:38 +0000 (15:30 +0200)]
virgl: Remove format desc null checks

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agosoftpipe: Remove format desc null check
Konstantin Seurer [Tue, 12 Jul 2022 13:22:38 +0000 (15:22 +0200)]
softpipe: Remove format desc null check

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agoradeonsi: Remove format desc null checks
Konstantin Seurer [Tue, 12 Jul 2022 13:21:24 +0000 (15:21 +0200)]
radeonsi: Remove format desc null checks

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agor600: Remove format desc null checks
Konstantin Seurer [Tue, 12 Jul 2022 13:18:33 +0000 (15:18 +0200)]
r600: Remove format desc null checks

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agor300: Remove format desc null check
Konstantin Seurer [Tue, 12 Jul 2022 13:14:24 +0000 (15:14 +0200)]
r300: Remove format desc null check

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>

2 years agopanfrost: Remove format desc null check
Konstantin Seurer [Tue, 12 Jul 2022 13:12:43 +0000 (15:12 +0200)]
panfrost: Remove format desc null check

Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17490>