platform/upstream/nodejs.git
9 years agodoc: make the abbreviation 1MM clear
Ivan Yan [Thu, 25 Jun 2015 02:21:13 +0000 (10:21 +0800)]
doc: make the abbreviation 1MM clear

Refs: https://github.com/nodejs/io.js/pull/2050
PR-URL: https://github.com/nodejs/io.js/pull/2053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
9 years agobuild: add tar-headers target for headers-only tar
Rod Vagg [Sun, 14 Jun 2015 10:23:43 +0000 (20:23 +1000)]
build: add tar-headers target for headers-only tar

to replace the full src download by node-gyp, using the proper format
instead of the full source format

PR-URL: https://github.com/nodejs/io.js/pull/1975
Reviewed-By: William Blankenship <william.jblankenship@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agodeps: copy all openssl header files to include dir
Shigeki Ohtsu [Fri, 19 Jun 2015 02:48:11 +0000 (11:48 +0900)]
deps: copy all openssl header files to include dir

On upgrading openssl, all symlinks in pulic header files are replaced
with nested include files. The issue was raised that installing them
leads to lost its references to real header files.
To avoid this, all public header files are copied into the
`deps/openssl/openssl/include/openssl/` directory.
As a result, we have duplicated header files under
`deps/openssl/openssl/` but copied files are refereed in build as
specified to include path in openssl.gyp.

Fixes: https://github.com/nodejs/io.js/pull/1975
PR-URL: https://github.com/nodejs/io.js/pull/2016
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agobuild: update build targets for io.js
Rod Vagg [Wed, 10 Jun 2015 07:05:26 +0000 (17:05 +1000)]
build: update build targets for io.js

PR-URL: https://github.com/nodejs/io.js/pull/1938
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
9 years agotest: check for error on Windows
Rich Trott [Tue, 23 Jun 2015 05:17:52 +0000 (22:17 -0700)]
test: check for error on Windows

Instead of not running the dgram-bind-shared-ports
on Windows, check that it gets ENOTSUP.

PR-URL: https://github.com/nodejs/io.js/pull/2035
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agobuild: fix cherry-pick ooops, fix comment wording
Rod Vagg [Tue, 23 Jun 2015 12:13:00 +0000 (22:13 +1000)]
build: fix cherry-pick ooops, fix comment wording

PR-URL: https://github.com/nodejs/io.js/pull/2036
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
9 years agobuild: add MSVS 2015 support
Rod Vagg [Thu, 16 Apr 2015 12:49:49 +0000 (22:49 +1000)]
build: add MSVS 2015 support

PR-URL: https://github.com/nodejs/io.js/pull/2036
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
9 years agobuild,win: set env before generating projects
Alexis Campailla [Thu, 23 Apr 2015 14:26:59 +0000 (07:26 -0700)]
build,win: set env before generating projects

vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
PR-URL: https://github.com/joyent/node/pull/20109

9 years agodoc: Added sample command to test iojs build
Jimmy Hsu [Mon, 16 Feb 2015 02:56:24 +0000 (18:56 -0800)]
doc: Added sample command to test iojs build

PR-URL: https://github.com/nodejs/io.js/pull/850
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
9 years agodoc: add TSC meeting minutes 2015-06-17
Rod Vagg [Wed, 24 Jun 2015 10:53:55 +0000 (20:53 +1000)]
doc: add TSC meeting minutes 2015-06-17

PR-URL: https://github.com/nodejs/io.js/pull/2048
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodoc: clarify prerequisites in benchmark/README.md
Jeremiah Senkpiel [Tue, 23 Jun 2015 03:27:17 +0000 (20:27 -0700)]
doc: clarify prerequisites in benchmark/README.md

PR-URL: https://github.com/nodejs/io.js/pull/2034
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agodoc: add TSC meeting minutes 2015-05-27
Rod Vagg [Wed, 3 Jun 2015 05:38:30 +0000 (15:38 +1000)]
doc: add TSC meeting minutes 2015-05-27

closes: https://github.com/nodejs/node/issues/41
PR-URL: https://github.com/nodejs/io.js/pull/2037
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: archive io.js TC minutes
Rod Vagg [Wed, 3 Jun 2015 05:36:30 +0000 (15:36 +1000)]
doc: archive io.js TC minutes

9 years agodoc: rename tc-meetings to tsc-meetings
Rod Vagg [Wed, 3 Jun 2015 05:36:05 +0000 (15:36 +1000)]
doc: rename tc-meetings to tsc-meetings

9 years agotest: remove obsolete TODO comments
Rich Trott [Mon, 22 Jun 2015 18:53:50 +0000 (11:53 -0700)]
test: remove obsolete TODO comments

The readfile/pipe tests rely on pre-existing pipes in the system.
This arguably tests the OS functionality and not really io.js
functionality. Removing TODOs.

PR-URL: https://github.com/nodejs/io.js/pull/2033
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agotest: remove obsolete TODO comments
Rich Trott [Mon, 22 Jun 2015 20:58:29 +0000 (13:58 -0700)]
test: remove obsolete TODO comments

Not using test_ca.pem in these files anymore.
Using elipses.txt which has multibyte chars.
Not clear what constitutes "large" but that
can be a different ticket if elipses.txt etc.
are insufficiently large.

PR-URL: https://github.com/nodejs/io.js/pull/2032
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agobuild: DTrace is enabled by default on darwin
Evan Lucas [Fri, 19 Jun 2015 15:31:17 +0000 (10:31 -0500)]
build: DTrace is enabled by default on darwin

In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

PR-URL: https://github.com/nodejs/io.js/pull/2019
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agodoc: add TC meeting 2015-05-13 minutes
Rod Vagg [Thu, 14 May 2015 06:42:09 +0000 (23:42 -0700)]
doc: add TC meeting 2015-05-13 minutes

PR-URL: https://github.com/nodejs/io.js/pull/1700
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: add @shigeki and @mscdex to TC
Rod Vagg [Thu, 18 Jun 2015 05:38:09 +0000 (15:38 +1000)]
doc: add @shigeki and @mscdex to TC

voted in to Node.js Foundation TSC in meeting on 2015-06-17

Closes: https://github.com/nodejs/io.js/issues/1500
Closes: https://github.com/nodejs/io.js/issues/1501
PR-URL: https://github.com/nodejs/io.js/pull/2008
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoWorking on v2.3.2
Rod Vagg [Tue, 23 Jun 2015 05:33:08 +0000 (15:33 +1000)]
Working on v2.3.2

9 years ago2015-06-23 io.js v2.3.1 Release v2.3.1
Rod Vagg [Fri, 19 Jun 2015 10:42:59 +0000 (20:42 +1000)]
2015-06-23 io.js v2.3.1 Release

PR-URL: https://github.com/nodejs/io.js/pull/1996

Notable changes

* module: The number of syscalls made during a require() have been
  significantly reduced again (see #1801 from v2.2.0 for previous
  work), which should lead to a performance improvement
  (Pierre Inglebert) #1920.
* npm:
  - Upgrade to v2.11.2 (Rebecca Turner) #1956.
  - Upgrade to v2.11.3 (Forrest L Norvell) #2018.
* zlib: A bug was discovered where the process would abort if the
  final part of a zlib decompression results in a buffer that would
  exceed the maximum length of 0x3fffffff bytes (~1GiB). This was
  likely to only occur during buffered decompression (rather than
  streaming). This is now fixed and will instead result in a thrown
  RangeError (Michaël Zasso) #1811.

9 years agotest: assert tmp and fixture dirs different
Rich Trott [Fri, 19 Jun 2015 05:06:19 +0000 (22:06 -0700)]
test: assert tmp and fixture dirs different

PR-URL: https://github.com/nodejs/io.js/pull/2015
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agomodule: fix stat with long paths on Windows
Michaël Zasso [Thu, 18 Jun 2015 20:18:46 +0000 (22:18 +0200)]
module: fix stat with long paths on Windows

PR-URL: https://github.com/nodejs/io.js/pull/2013
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agotest: confirm symlink
Rich Trott [Fri, 19 Jun 2015 02:39:42 +0000 (19:39 -0700)]
test: confirm symlink

PR-URL: https://github.com/nodejs/io.js/pull/2014
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agotest: check result as early as possible
Rich Trott [Thu, 18 Jun 2015 05:14:22 +0000 (22:14 -0700)]
test: check result as early as possible

PR-URL: https://github.com/nodejs/io.js/pull/2007
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agodoc: add security section to README.md
Rod Vagg [Thu, 11 Jun 2015 10:37:37 +0000 (20:37 +1000)]
doc: add security section to README.md

PR-URL: https://github.com/nodejs/io.js/pull/1948
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agowin,node-gyp: enable delay-load hook by default
Bert Belder [Wed, 15 Apr 2015 20:58:50 +0000 (13:58 -0700)]
win,node-gyp: enable delay-load hook by default

The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: https://github.com/iojs/io.js/pull/1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: make node-gyp work with io.js
cjihrig [Fri, 27 Feb 2015 18:40:58 +0000 (13:40 -0500)]
deps: make node-gyp work with io.js

Every npm version bump requires a few patches to be floated on
node-gyp for io.js compatibility. These patches are found in
03d199276e21c1fa08d8df14eeb654c90cc5aa20,
5de334c23096492014a097ff487f07ad8eaee6d2, and
da730c76e98fb9fd18dac445dafbbec74d79f802. This commit squashes
them into a single commit.

PR-URL: https://github.com/iojs/io.js/pull/990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: upgrade to npm 2.11.3
Forrest L Norvell [Fri, 19 Jun 2015 10:24:06 +0000 (03:24 -0700)]
deps: upgrade to npm 2.11.3

PR-URL: https://github.com/nodejs/io.js/pull/2018
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agobuild: remove lint from test-ci on windows
Johan Bergström [Wed, 17 Jun 2015 22:47:04 +0000 (08:47 +1000)]
build: remove lint from test-ci on windows

PR-URL: https://github.com/nodejs/io.js/pull/2004
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
9 years agodoc: change the info to the same as in gitconfig
Christian Tellnes [Wed, 17 Jun 2015 09:02:36 +0000 (11:02 +0200)]
doc: change the info to the same as in gitconfig

PR-URL: https://github.com/nodejs/io.js/pull/2000
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agodoc: mention CI in Collaborator Guide
Rich Trott [Tue, 16 Jun 2015 22:23:24 +0000 (15:23 -0700)]
doc: mention CI in Collaborator Guide

Add link to Jenkins server in Collaborator Guide.

PR-URL: https://github.com/nodejs/io.js/pull/1995
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agomodule: reduce syscalls during require search
Pierre Inglebert [Mon, 8 Jun 2015 21:44:18 +0000 (23:44 +0200)]
module: reduce syscalls during require search

require() now checks that the path exists before searching
further in it.

PR-URL: https://github.com/nodejs/io.js/pull/1920
Reviewed-By: Isaac Z. Schlueter <i@izs.me>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agonet: Defer reading until listeners could be added
James Hartig [Mon, 8 Jun 2015 22:25:06 +0000 (18:25 -0400)]
net: Defer reading until listeners could be added

Defer reading until user-land has a chance to add listeners. This
allows the TLS wrapper to listen for _tlsError and trigger a
clientError event if the socket already has data that could trigger.

Fixes: https://github.com/nodejs/io.js/issues/1114
PR-URL: https://github.com/nodejs/io.js/pull/1496
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
9 years agodoc: add TOC links to Collaborator Guide
Rich Trott [Tue, 16 Jun 2015 22:01:39 +0000 (15:01 -0700)]
doc: add TOC links to Collaborator Guide

PR-URL: https://github.com/nodejs/io.js/pull/1994
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agodoc: add TSC meeting notes 2015-06-10
Bert Belder [Wed, 17 Jun 2015 19:59:40 +0000 (12:59 -0700)]
doc: add TSC meeting notes 2015-06-10

PR-URL: https://github.com/nodejs/io.js/pull/1943
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agotest: add Buffer slice UTF-8 test
Rich Trott [Tue, 16 Jun 2015 05:02:23 +0000 (22:02 -0700)]
test: add Buffer slice UTF-8 test

PR-URL: https://github.com/nodejs/io.js/pull/1989
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agoasync-wrap: add provider id and object info cb
Trevor Norris [Wed, 3 Jun 2015 21:31:33 +0000 (15:31 -0600)]
async-wrap: add provider id and object info cb

Re-add the wrapper class id to AsyncWrap instances so they can be
tracked directly in a heapdump.

Previously the class id was given without setting the heap dump wrapper
class info provider. Causing a segfault when a heapdump was taken. This
has been added, and the label_ set to the given provider name so each
instance can be identified.

The id will not be set of the passed object has no internal field count.
As the class pointer cannot be retrieved from the object.

In order to properly report the allocated size of each class, the new
pure virtual method self_size() has been introduces.

PR-URL: https://github.com/nodejs/io.js/pull/1896
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agovm: remove unnecessary HandleScopes
Ben Noordhuis [Tue, 16 Jun 2015 14:11:51 +0000 (16:11 +0200)]
vm: remove unnecessary HandleScopes

The accessors run inside an implicit HandleScope, there is no need to
create a new one.

PR-URL: https://github.com/nodejs/io.js/pull/2001
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agotools: make test-npm work without global npm
Jeremiah Senkpiel [Tue, 9 Jun 2015 18:25:19 +0000 (11:25 -0700)]
tools: make test-npm work without global npm

Futher discussion at https://github.com/joyent/node/pull/25294

PR-URL: https://github.com/nodejs/io.js/pull/1926
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
9 years agotest: tmpdir creation failures should fail tests
Rich Trott [Sun, 14 Jun 2015 14:02:29 +0000 (07:02 -0700)]
test: tmpdir creation failures should fail tests

tmpdir creation only happens for tests that need it. So failure to
refresh the temporary directory should result in a failed test.

PR-URL: https://github.com/nodejs/io.js/pull/1976
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodoc: reformat authors section
Johan Bergström [Sat, 13 Jun 2015 03:06:35 +0000 (13:06 +1000)]
doc: reformat authors section

Make the order of name, email and other additions simpler to
copy paste and/or match with git commit messages.

Useful when working with `Reviewed-By`.

PR-URL: https://github.com/nodejs/io.js/pull/1966
Reviewed-By: Christian Tellnes <christian@tellnes.no>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoutil: dont repeat isBuffer
Brendan Ashworth [Tue, 16 Jun 2015 05:01:33 +0000 (22:01 -0700)]
util: dont repeat isBuffer

PR-URL: https://github.com/nodejs/io.js/pull/1988
Reviewed-By: Roman Reiss <me@silverwind.io>
9 years agobuffer: fix cyclic dependency with util
Brendan Ashworth [Tue, 16 Jun 2015 04:52:06 +0000 (21:52 -0700)]
buffer: fix cyclic dependency with util

PR-URL: https://github.com/nodejs/io.js/pull/1988
Fixes: https://github.com/nodejs/io.js/issues/1987
Reviewed-By: Roman Reiss <me@silverwind.io>
9 years agoutil: move deprecate() to internal module
Brendan Ashworth [Tue, 16 Jun 2015 04:51:41 +0000 (21:51 -0700)]
util: move deprecate() to internal module

PR-URL: https://github.com/nodejs/io.js/pull/1988
Reviewed-By: Roman Reiss <me@silverwind.io>
9 years agomodule: allow long paths for require on Windows
Michaël Zasso [Tue, 16 Jun 2015 20:24:08 +0000 (13:24 -0700)]
module: allow long paths for require on Windows

https://github.com/nodejs/io.js/pull/1801 introduced internal fs methods
to speed up require. The methods do not call path._makeLong like their
counterpart from the fs module. This brings back the old behaviour.

Fixes: https://github.com/nodejs/io.js/issues/1990
Fixes: https://github.com/nodejs/io.js/issues/1980
Fixes: https://github.com/nodejs/io.js/issues/1849

PR-URL: https://github.com/nodejs/io.js/pull/1991/files
Reviewed-By: Bert Belder <bertbelder@gmail.com>
9 years agotest: fix test-cluster-worker-disconnect
Santiago Gimeno [Mon, 8 Jun 2015 19:18:48 +0000 (21:18 +0200)]
test: fix test-cluster-worker-disconnect

- Just let the process exit gracefully after the worker is disconnected.

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/nodejs/io.js/pull/1919
Fixes: https://github.com/nodejs/io.js/issues/1757

9 years agocrypto: add cert check to CNNIC Whitelist
Shigeki Ohtsu [Thu, 4 Jun 2015 08:50:33 +0000 (17:50 +0900)]
crypto: add cert check to CNNIC Whitelist

When client connect to the server with certification issued by either
CNNIC Root CA or CNNIC EV Root CA, check hash of server
certification in the list of CNNICHashWhitelist.inc. If it's not,
CERT_REVOKED error returns.

See for details in
https://blog.mozilla.org/security/2015/04/02/distrusting-new-cnnic-certificates/

PR-URL: https://github.com/nodejs/io.js/pull/1895
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: minor clarification in the modules API doc.
Сковорода Никита Андреевич [Mon, 15 Jun 2015 11:45:34 +0000 (14:45 +0300)]
doc: minor clarification in the modules API doc.

PR-URL: https://github.com/nodejs/io.js/pull/1983
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agobuild: fix pkg-config output parsing in configure
Ben Noordhuis [Mon, 15 Jun 2015 20:04:14 +0000 (22:04 +0200)]
build: fix pkg-config output parsing in configure

Fix parsing of `pkg-config --cflags-only-I`.  The configure_library()
step sometimes appended a list in a list instead of list of strings to
include_dirs.

This commit removes the default handling for includes and libpath
options.  They don't have defaults at the moment and I don't see that
changing anytime soon.  Fixing the code is more work and because it's
dead code anyway, I opted to remove it instead.

Fixes: https://github.com/nodejs/io.js/issues/1985
PR-URL: https://github.com/nodejs/io.js/pull/1986
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agozlib: prevent uncaught exception in zlibBuffer
Michaël Zasso [Wed, 27 May 2015 11:21:56 +0000 (13:21 +0200)]
zlib: prevent uncaught exception in zlibBuffer

If the accumulation of data for the final Buffer is greater than
kMaxLength it will throw an un-catchable RangeError. Instead now pass
the generated error to the callback.

PR-URL: https://github.com/nodejs/io.js/pull/1811
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agowin,node-gyp: enable delay-load hook by default
Bert Belder [Wed, 15 Apr 2015 20:58:50 +0000 (13:58 -0700)]
win,node-gyp: enable delay-load hook by default

The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe
for more background.

PR-URL: https://github.com/iojs/io.js/pull/1433
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: make node-gyp work with io.js
cjihrig [Fri, 27 Feb 2015 18:40:58 +0000 (13:40 -0500)]
deps: make node-gyp work with io.js

Every npm version bump requires a few patches to be floated on
node-gyp for io.js compatibility. These patches are found in
03d199276e21c1fa08d8df14eeb654c90cc5aa20,
5de334c23096492014a097ff487f07ad8eaee6d2, and
da730c76e98fb9fd18dac445dafbbec74d79f802. This commit squashes
them into a single commit.

PR-URL: https://github.com/iojs/io.js/pull/990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: upgrade to npm 2.11.2
Rebecca Turner [Fri, 12 Jun 2015 08:04:17 +0000 (04:04 -0400)]
deps: upgrade to npm 2.11.2

PR-URL: https://github.com/nodejs/io.js/pull/1956
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodoc: benchmark/README.md copyedit
Rich Trott [Sat, 13 Jun 2015 16:07:20 +0000 (09:07 -0700)]
doc: benchmark/README.md copyedit

PR-URL: https://github.com/nodejs/io.js/pull/1970
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agotools: enable whitespace related rules in eslint
Roman Reiss [Sat, 13 Jun 2015 19:33:46 +0000 (21:33 +0200)]
tools: enable whitespace related rules in eslint

Enables rules for trailing whitespace, final newline and maximum
consecutive empty lines.

PR-URL: https://github.com/nodejs/io.js/pull/1971
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agolib,test: fix whitespace issues
Roman Reiss [Sat, 13 Jun 2015 17:47:14 +0000 (19:47 +0200)]
lib,test: fix whitespace issues

PR-URL: https://github.com/nodejs/io.js/pull/1971
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agobuild: don't run lint from test-ci
Johan Bergström [Sat, 13 Jun 2015 02:25:35 +0000 (12:25 +1000)]
build: don't run lint from test-ci

Since we will run linting before compiling or testing there's no
need to run it as part of the ci testing.

PR-URL: https://github.com/nodejs/io.js/pull/1965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Revewied-By: Evan Lucas <evanlucas@me.com>
9 years agobuild: simplify execution of built binary
Johan Bergström [Fri, 12 Jun 2015 05:12:20 +0000 (15:12 +1000)]
build: simplify execution of built binary

Since we aleady have a variable with path to the newly built
binary, use that instead of prefixing path. This also allows us
to pass a different path through the environment (NODE=)

PR-URL: https://github.com/nodejs/io.js/pull/1955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agov8: cherry-pick uclibc build patch from upstream
Ben Noordhuis [Tue, 14 Apr 2015 07:54:30 +0000 (00:54 -0700)]
v8: cherry-pick uclibc build patch from upstream

Original commit log follows:

    Restore V8_LIBC_UCLIBC as a libc option.

    As uClibc defines __GLIBC__ in an attempt to look like glibc,
    V8_LIBC_GLIBC was true for uClibc as well. Checking for uClibc
    before glibc fixes this and restores the correct behavior.

    Review URL: https://codereview.chromium.org/1066573005

Fixes: https://github.com/nodejs/io.js/issues/1432
PR-URL: https://github.com/nodejs/io.js/pull/1974
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agodoc: copyedit COLLABORATOR_GUIDE.md
Rich Trott [Sat, 13 Jun 2015 01:59:40 +0000 (18:59 -0700)]
doc: copyedit COLLABORATOR_GUIDE.md

PR-URL: https://github.com/nodejs/io.js/pull/1964
Reviewed-By: Alex Kocharin <alex@kocharin.ru>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agodoc: copyedit GOVERNANCE.md
Rich Trott [Sat, 13 Jun 2015 00:26:04 +0000 (17:26 -0700)]
doc: copyedit GOVERNANCE.md

PR-URL: https://github.com/nodejs/io.js/pull/1963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agotest: only refresh tmpDir for tests that need it
Rich Trott [Tue, 9 Jun 2015 18:40:55 +0000 (11:40 -0700)]
test: only refresh tmpDir for tests that need it

Expose `common.refreshTmpDir()` and only call it
for tests that use common.tmpDir or common.PIPE.

A positive side effect is the removal of a code
smell where child processes were detected by the
presence of `.send()`. Now each process can decide
for itself if it needs to refresh tmpDir.

PR-URL: https://github.com/nodejs/io.js/pull/1954
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
9 years agotest: remove test repetition
Rich Trott [Tue, 2 Jun 2015 20:16:36 +0000 (13:16 -0700)]
test: remove test repetition

Remove loops executing the same tests multiple times.

PR-URL: https://github.com/nodejs/io.js/pull/1874
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agodoc: add ChALkeR as collaborator
Сковорода Никита Андреевич [Tue, 9 Jun 2015 20:50:02 +0000 (23:50 +0300)]
doc: add ChALkeR as collaborator

Using the non-transliterated name as requested.

The transliteration is "Nikita Skovoroda" (first and last name),
if anyone will want to organize non-ASCII names.

PR-URL: https://github.com/nodejs/io.js/pull/1927
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: remove irrelevant SEMVER-MINOR & MAJOR
Rod Vagg [Sat, 13 Jun 2015 05:41:05 +0000 (15:41 +1000)]
doc: remove irrelevant SEMVER-MINOR & MAJOR

9 years agoWorking on v2.3.1
Rod Vagg [Sat, 13 Jun 2015 04:14:45 +0000 (14:14 +1000)]
Working on v2.3.1

9 years ago2015-06-13 io.js v2.3.0 Release v2.3.0
Rod Vagg [Sat, 13 Jun 2015 04:09:33 +0000 (14:09 +1000)]
2015-06-13 io.js v2.3.0 Release

Notable Changes:

* libuv: Upgraded to 1.6.0 and 1.6.1, see full ChangeLog for details.
  (Saúl Ibarra Corretgé) #1905 #1889. Highlights include:
  - Fix TTY becoming blocked on OS X
  - Fix UDP send callbacks to not to be synchronous
  - Add uv_os_homedir() (exposed as os.homedir(), see below)
* npm: See full release notes for details. (Kat Marchán) #1899. Highlight:
  - Use GIT_SSH_COMMAND (available as of Git 2.3)
* openssl:
  - Upgrade to 1.0.2b and 1.0.2c, introduces DHE man-in-the-middle protection
    (Logjam) and fixes malformed ECParameters causing infinite loop
    (CVE-2015-1788). See the security advisory for full details.
    (Shigeki Ohtsu) #1950 #1958
  - Support FIPS mode of OpenSSL, see README for instructions.
    (Fedor Indutny) #1890
* os: Add os.homedir() method. (Colin Ihrig) #1791
* smalloc: Deprecate whole module. (Vladimir Kurchatkin) #1822
* Add new collaborators:
  - Alex Kocharin (@rlidwka)
  - Christopher Monsanto (@monsanto)
  - Ali Ijaz Sheikh (@ofrobots)
  - Oleg Elifantiev (@Olegas)
  - Domenic Denicola (@domenic)
  - Rich Trott (@Trott)

9 years ago2015-06-12 io.js v2.3.0 Release
Rod Vagg [Fri, 12 Jun 2015 05:01:26 +0000 (15:01 +1000)]
2015-06-12 io.js v2.3.0 Release

9 years agotest: add test for failed save in REPL
Rich Trott [Thu, 28 May 2015 02:20:28 +0000 (19:20 -0700)]
test: add test for failed save in REPL

PR-URL: https://github.com/nodejs/io.js/pull/1818
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: add Trott as collaborator
Rich Trott [Fri, 12 Jun 2015 22:49:58 +0000 (15:49 -0700)]
doc: add Trott as collaborator

PR-URL: https://github.com/nodejs/io.js/pull/1962
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agoRevert "readline: allow tabs in input"
Jeremiah Senkpiel [Fri, 12 Jun 2015 21:21:50 +0000 (14:21 -0700)]
Revert "readline: allow tabs in input"

This reverts commit 4b3d493c4b5996d00dc6eac3a7600b124ed4c5b7.

PR-URL: https://github.com/nodejs/io.js/pull/1961
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
9 years agonode: mark promises as handled as soon as possible
Vladimir Kurchatkin [Thu, 11 Jun 2015 20:08:17 +0000 (23:08 +0300)]
node: mark promises as handled as soon as possible

Fixes: https://github.com/nodejs/io.js/issues/1912
PR-URL: https://github.com/nodejs/io.js/pull/1952
Reviewed-By: Domenic Denicola <d@domenic.me>
Reviewed-By: Petka Antonov <petka_antonov@hotmail.com>
9 years agotest: fix cluster-worker-wait-server-close races
Sam Roberts [Thu, 11 Jun 2015 21:43:09 +0000 (14:43 -0700)]
test: fix cluster-worker-wait-server-close races

Wait for data to arrive from worker before doing a disconnect. Without
this, whether the disconnect arrives at the worker before the master
accepts and forwards the connection descriptor to the worker is a race.

Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: https://github.com/nodejs/io.js/pull/1953
Fixes: https://github.com/nodejs/io.js/issues/1933
Fixes: https://github.com/nodejs/io.js/pull/1400

9 years agodeps: update UPGRADING.md doc to openssl-1.0.2c
Shigeki Ohtsu [Thu, 11 Jun 2015 16:04:52 +0000 (01:04 +0900)]
deps: update UPGRADING.md doc to openssl-1.0.2c

PR-URL: https://github.com/nodejs/io.js/pull/1958
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agodeps: replace all headers in openssl
Shigeki Ohtsu [Fri, 12 Jun 2015 16:12:57 +0000 (01:12 +0900)]
deps: replace all headers in openssl

Change all openssl/include/openssl/*.h to include resolved symbolic
links and openssl/crypto/opensslconf.h to refer config/opensslconf.h

PR-URL: https://github.com/nodejs/io.js/pull/1958
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agodeps: add -no_rand_screen to openssl s_client
Shigeki Ohtsu [Wed, 27 May 2015 01:33:38 +0000 (10:33 +0900)]
deps: add -no_rand_screen to openssl s_client

In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: https://github.com/nodejs/io.js/issues/1461
PR-URL: https://github.com/nodejs/io.js/pull/1836
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoopenssl: fix keypress requirement in apps on win32
Shigeki Ohtsu [Tue, 17 Feb 2015 02:30:28 +0000 (11:30 +0900)]
openssl: fix keypress requirement in apps on win32

Reapply b910613792dac946b295855963869933a9089044 .

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: fix asm build error of openssl in x86_win32
Shigeki Ohtsu [Fri, 13 Feb 2015 09:33:59 +0000 (18:33 +0900)]
deps: fix asm build error of openssl in x86_win32

See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: fix openssl assembly error on ia32 win32
Fedor Indutny [Wed, 8 Jan 2014 19:05:01 +0000 (23:05 +0400)]
deps: fix openssl assembly error on ia32 win32

`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
9 years agodeps: upgrade openssl sources to 1.0.2c
Shigeki Ohtsu [Fri, 12 Jun 2015 15:56:07 +0000 (00:56 +0900)]
deps: upgrade openssl sources to 1.0.2c

This just replaces all sources of openssl-1.0.2c.tar.gz
into deps/openssl/openssl

PR-URL: https://github.com/nodejs/io.js/pull/1958
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agodeps: update asm files for openssl-1.0.2b
Shigeki Ohtsu [Thu, 11 Jun 2015 15:09:20 +0000 (00:09 +0900)]
deps: update asm files for openssl-1.0.2b

asm files are generated as
  - In `deps/openssl/asm/`, make with CC=gcc and ASM=nasm
  - In `deps/openssl/asm_obsolute/`, make with no envs for compilers

Fixes: https://github.com/nodejs/io.js/issues/1921
PR-URL: https://github.com/nodejs/io.js/pull/1950
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: replace all headers in openssl
Shigeki Ohtsu [Thu, 11 Jun 2015 15:07:42 +0000 (00:07 +0900)]
deps: replace all headers in openssl

Change all openssl/include/openssl/*.h to include resolved symbolic
links and openssl/crypto/opensslconf.h to refer config/opensslconf.h

Fixes: https://github.com/nodejs/io.js/issues/1921
PR-URL: https://github.com/nodejs/io.js/pull/1950
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: add -no_rand_screen to openssl s_client
Shigeki Ohtsu [Wed, 27 May 2015 01:33:38 +0000 (10:33 +0900)]
deps: add -no_rand_screen to openssl s_client

In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: https://github.com/nodejs/io.js/issues/1461
PR-URL: https://github.com/nodejs/io.js/pull/1836
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoopenssl: fix keypress requirement in apps on win32
Shigeki Ohtsu [Tue, 17 Feb 2015 02:30:28 +0000 (11:30 +0900)]
openssl: fix keypress requirement in apps on win32

Reapply b910613792dac946b295855963869933a9089044 .

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: fix asm build error of openssl in x86_win32
Shigeki Ohtsu [Fri, 13 Feb 2015 09:33:59 +0000 (18:33 +0900)]
deps: fix asm build error of openssl in x86_win32

See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: fix openssl assembly error on ia32 win32
Fedor Indutny [Wed, 8 Jan 2014 19:05:01 +0000 (23:05 +0400)]
deps: fix openssl assembly error on ia32 win32

`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: https://github.com/iojs/io.js/issues/589
PR-URL: https://github.com/iojs/io.js/pull/1389
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
9 years agodeps: upgrade openssl sources to 1.0.2b
Shigeki Ohtsu [Thu, 11 Jun 2015 15:00:05 +0000 (00:00 +0900)]
deps: upgrade openssl sources to 1.0.2b

This just replaces all sources of openssl-1.0.2b.tar.gz
into deps/openssl/openssl

Fixes: https://github.com/nodejs/io.js/issues/1921
PR-URL: https://github.com/nodejs/io.js/pull/1950
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agotest: create temp dir in common.js
Rich Trott [Wed, 3 Jun 2015 03:44:03 +0000 (20:44 -0700)]
test: create temp dir in common.js

Move creation of temporary directories for tests
out of the Python harness and into common.js. This
allows all tests to be run reliably outside of the
Python wrapper.

PR-URL: https://github.com/nodejs/io.js/pull/1877
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agotools: enable/add additional eslint rules
Roman Reiss [Thu, 11 Jun 2015 17:08:25 +0000 (19:08 +0200)]
tools: enable/add additional eslint rules

Enables the following rules:

- no-undef: Valuable rule to error on usage of undefined variables
- require-buffer: Custom rule that forbids usage of the global Buffer
  inside lib/ because of REPL issues.

PR-URL: https://github.com/nodejs/io.js/pull/1794
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agolib: don't use global Buffer
Roman Reiss [Fri, 29 May 2015 17:35:43 +0000 (19:35 +0200)]
lib: don't use global Buffer

Port of https://github.com/joyent/node/pull/8603

The race condition present in the original PR didn't occur, so no
workaround was needed.

PR-URL: https://github.com/nodejs/io.js/pull/1794
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agotest: fix undeclared variable access
Roman Reiss [Fri, 29 May 2015 17:28:01 +0000 (19:28 +0200)]
test: fix undeclared variable access

Fixes all cases of undeclared variable access as uncovered by the
no-undef rule of eslint.

PR-URL: https://github.com/nodejs/io.js/pull/1794
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agotls: fix references to undefined `cb`
Fedor Indutny [Thu, 11 Jun 2015 16:45:57 +0000 (18:45 +0200)]
tls: fix references to undefined `cb`

5795e835a1021abdf803e1460501487adbac8d7c introduced unintentional
copy-paste bug. `cb` is not actually present in those functions and
should not be called, the socket should be destroy instead.

PR-URL: https://github.com/nodejs/io.js/pull/1951
Reviewed-By: Roman Reiss <me@silverwind.io>
9 years agocrypto: support FIPS mode of OpenSSL
Fedor Indutny [Mon, 1 Jun 2015 21:49:43 +0000 (23:49 +0200)]
crypto: support FIPS mode of OpenSSL

Support building and running with FIPS-compliant OpenSSL. The process is
following:

1. Download and verify `openssl-fips-x.x.x.tar.gz` from
   https://www.openssl.org/source/
2. Extract source to `openssl-fips` folder
3. ``cd openssl-fips && ./config fipscanisterbuild --prefix=`pwd`/out``
   (NOTE: On OS X, you may want to run
    ``./Configure darwin64-x86_64-cc --prefix=`pwd`/out`` if you are going to
    build x64-mode io.js)
4. `make -j && make install`
5. Get into io.js checkout folder
6. `./configure --openssl-fips=/path/to/openssl-fips/out`
7. Build io.js with `make -j`
8. Verify with `node -p "process.versions.openssl"` (`1.0.2a-fips`)

Fix: https://github.com/joyent/node/issues/25463
PR-URL: https://github.com/nodejs/io.js/pull/1890
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
9 years agofs: make SyncWriteStream non-enumerable
Sakthipriyan Vairamani [Wed, 3 Jun 2015 14:57:44 +0000 (20:27 +0530)]
fs: make SyncWriteStream non-enumerable

Make SyncWriteStream non-enumerable since it's only for internal use.

PR-URL: https://github.com/nodejs/io.js/pull/1870
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agofs: minor refactoring
Sakthipriyan Vairamani [Tue, 2 Jun 2015 22:11:04 +0000 (03:41 +0530)]
fs: minor refactoring

1. Remove a few unnecessary variables to reduce LoC.

2. Remove redundant `var` definitions of variables in same function.

3. Refactor variables which are defined inside a block and used outside
as well.

4. Refactor effect-less code.

5. In `rethrow` function, instead of assigning to `err` and throwing
`err` directly throw `backtrace` object.

6. Reassign a defined parameter while also mentioning arguments in the
body is one of the optimization killers. So, changing `callback` to
`callback_` and declaring a new variable called `callback` in the body.

PR-URL: https://github.com/nodejs/io.js/pull/1870
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agofs: remove inStatWatchers and use Map for lookup
Sakthipriyan Vairamani [Tue, 2 Jun 2015 17:02:15 +0000 (22:32 +0530)]
fs: remove inStatWatchers and use Map for lookup

Remove `inStatWatchers` function and make `statWatchers` a `Map`.

PR-URL: https://github.com/nodejs/io.js/pull/1870
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agofs: removing unnecessary nullCheckCallNT
Sakthipriyan Vairamani [Tue, 2 Jun 2015 15:15:21 +0000 (20:45 +0530)]
fs: removing unnecessary nullCheckCallNT

`nullCheckCallNT()` function is not necessary, as we can directly pass
`callback` and `er` to `process.nextTick()`.

PR-URL: https://github.com/nodejs/io.js/pull/1870
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agofs: improve error message descriptions
Sakthipriyan Vairamani [Tue, 2 Jun 2015 15:13:46 +0000 (20:43 +0530)]
fs: improve error message descriptions

1. Change "Bad arguments" error messages to a more helpful message
"options should either be an object or a string".

2. Make braces consistent.

3. Return meaningful error message from fs_event_wrap's
FSEvent's Start function.

PR-URL: https://github.com/nodejs/io.js/pull/1870
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agodoc: add domenic as collaborator
Domenic Denicola [Wed, 10 Jun 2015 20:20:17 +0000 (16:20 -0400)]
doc: add domenic as collaborator

PR-URL: https://github.com/nodejs/io.js/pull/1942
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>