Stephen Toub [Fri, 27 Sep 2019 18:19:52 +0000 (14:19 -0400)]
Add some DebuggerDisplay attributes in System.Linq (dotnet/corefx#41386)
Commit migrated from https://github.com/dotnet/corefx/commit/
e667c29636a622eb4f9493f75232b44e0ae90b29
buyaa-n [Fri, 27 Sep 2019 16:41:52 +0000 (09:41 -0700)]
Annotate System.IO.Compression for nullable (dotnet/corefx#41322)
Nullable annotation for System.IO.Compression
Commit migrated from https://github.com/dotnet/corefx/commit/
967eb3c5cb5fd36c8bb56d06f4c840f6a7a5a754
Stephen Toub [Fri, 27 Sep 2019 03:22:52 +0000 (20:22 -0700)]
Remove a few initialization allocations from Cng (dotnet/corefx#41373)
Save four "startup" allocations in System.Security.Cryptography.Cng.
- Appending the '\0' is better done at the call site, because then the concat is done with two constants at compile time.
- There's no benefit to using ToCharArray instead of just passing in the string.
- Once we get rid of those, we can just inline the construction into the declarations.
Commit migrated from https://github.com/dotnet/corefx/commit/
296c0e71ddcc4885d30af18dea829c1923cfdc5c
Steve Harter [Thu, 26 Sep 2019 21:34:50 +0000 (16:34 -0500)]
Add System.Object converter sample to have semantics similar to Newtonsoft Json.NET (dotnet/corefx#41323)
Commit migrated from https://github.com/dotnet/corefx/commit/
946628c1fe463cc058db5a53723ca3867428de01
Stephen Toub [Thu, 26 Sep 2019 21:31:10 +0000 (14:31 -0700)]
Make Delegate.GetMethodInfo extension return non-nullable (dotnet/corefx#41367)
Commit migrated from https://github.com/dotnet/corefx/commit/
e0338a64488dde44c94c843bb15df8dc21138aa9
Stephen Toub [Thu, 26 Sep 2019 21:30:31 +0000 (14:30 -0700)]
Avoid ToCharArray allocation in JsonCamelCaseNamingPolicy (dotnet/corefx#41363)
Commit migrated from https://github.com/dotnet/corefx/commit/
4cfc7ecdf44fee10b86477c67eb9c7d335cf3269
Viktor Hofer [Thu, 26 Sep 2019 21:04:43 +0000 (23:04 +0200)]
Disable S.N.Security tests on arm64 Windows (dotnet/corefx#41370)
Commit migrated from https://github.com/dotnet/corefx/commit/
4fd8e9f3dcbf7484e3cc4b2d77c649a48f1e29ac
Viktor Hofer [Thu, 26 Sep 2019 19:52:36 +0000 (21:52 +0200)]
Add Alpine 3.10 to CI (dotnet/corefx#41355)
Commit migrated from https://github.com/dotnet/corefx/commit/
ea0ff6679926b6d964347c63db7f3598d53e44f2
Adam Sitnik [Thu, 26 Sep 2019 18:51:36 +0000 (20:51 +0200)]
add more IsSuffix test cases (dotnet/corefx#41353)
Commit migrated from https://github.com/dotnet/corefx/commit/
79eb17cf22dc69ac94f900794468d998254e7bd8
Adam Sitnik [Thu, 26 Sep 2019 13:40:44 +0000 (15:40 +0200)]
StartsWith more edge cases (dotnet/corefx#41350)
* add test case for ICU-20832
* add ""o\u0000\u0308".StartsWith("o") test case
Commit migrated from https://github.com/dotnet/corefx/commit/
933f5ddb717307ea75c939058c23c16e3849176e
Viktor Hofer [Thu, 26 Sep 2019 04:53:38 +0000 (06:53 +0200)]
Update windows.yml (dotnet/corefx#41328)
Commit migrated from https://github.com/dotnet/corefx/commit/
84369a81077db9041d9d542f91b642efc4091b7d
Eric StJohn [Wed, 25 Sep 2019 23:19:34 +0000 (16:19 -0700)]
Fix DeflateStream.CopyTo for concatenated payloads (dotnet/corefx#41190)
* Fix DeflateStream.CopyTo for concatenated payloads
Support for concatenated payloads was added in dotnet/corefx@
55f2293ddda3c972fcc2d94915b03bc8556e8c9b.
With this DeflateStream will continue to attempt to read after it
encounters a payload footer if it has more data left and that data
begins with the proper header format.
This caused a bug in CopyTo where it assumed that if the inflater
returned 0 bytes inflated it was done with that buffer.
This can happen in a couple cases:
1. The footer for a payload occurs on a buffer boundary, such that the
first call to Inflate for that buffer reads only the footer and returns
0 data. This was reported by a customer.
2. One of the concatenated payloads is 0 length.
Previously the CopyTo implementation would skip the remainder of the
buffer in this case, then proceed with a new buffer. This new buffer
would start and an arbitrary offset in the compressed data, which likely
isn't a valid header, and an exception would be thrown:
```
System.IO.InvalidDataException : The archive entry was compressed using an unsupported compression method.
```
Fix this by continuing to copy so long as the we haven't run out of
data, regardless of wether or not the inflater happens to read a 0
length chunk.
* Address feedback
* Fix regression introduced in refactoring
* Apply suggestions from code review
Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
b832f6ccdebd18469e4b6d03c1c9b2c9c6c14374
Tomas Weinfurt [Wed, 25 Sep 2019 21:30:10 +0000 (14:30 -0700)]
improve stability of FileSystemWatcher tests (dotnet/corefx#40543)
* improve stability of watcher tests
* feedback from review
* more feedback
* disable parallelization for dangerous tests
* enable FileSystemWatcher_File_Create_ForceLoopRestart again
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
e8fd8931d488d2e06a25a49c0d722b67f35e10fa
Kevin Jones [Wed, 25 Sep 2019 21:09:27 +0000 (17:09 -0400)]
Implement HashAlgorithmName.FromOid and TryFromOid.
Commit migrated from https://github.com/dotnet/corefx/commit/
eda554cfbcceda02db621ab8233d1b53e653681a
Ricardo Arenas [Wed, 25 Sep 2019 20:47:17 +0000 (13:47 -0700)]
Change dependsOn Parameter when calling post-build tempalte to react to Arcade breaking change (dotnet/corefx#41318)
Commit migrated from https://github.com/dotnet/corefx/commit/
78f27e44cd74b1a6eb66401099645c6871251dfc
Jeremy Barton [Wed, 25 Sep 2019 16:32:27 +0000 (09:32 -0700)]
Exploration: Retry STATUS_UNSUCCESSFUL from CNG (dotnet/corefx#41300)
* Exploration: Retry STATUS_UNSUCCESSFUL from CNG
* Restore Array.Resize to separate changes
Commit migrated from https://github.com/dotnet/corefx/commit/
ac99a1b7168bd32046a954c3f06012c0fa909bed
Steve Harter [Wed, 25 Sep 2019 15:46:41 +0000 (10:46 -0500)]
Serializer perf improvements (dotnet/corefx#41238)
Commit migrated from https://github.com/dotnet/corefx/commit/
527595f14c6b3ee307d301ae42d68c29cad545d0
dotnet-maestro[bot] [Tue, 24 Sep 2019 23:09:05 +0000 (01:09 +0200)]
[master] Update dependencies from 4 repositories (dotnet/corefx#41216)
* Update global.json
* Disable DependentUpon convention for resources
* Update dependencies from https://github.com/dotnet/core-setup build
20190920.7
- Microsoft.NETCore.App - 5.0.0-alpha1.19470.7
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19470.7
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19470.7
* Update dependencies from https://github.com/dotnet/corefx build
20190921.2
- runtime.native.System.IO.Ports - 5.0.0-alpha1.19471.2
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19471.2
* Cleanup netcoreapp targeting pack restore
For .NETCore2x the SDK implictily references the targeting pack via
a PackageReference so to binplace the assemblies we just need to reset
the PrivateAssets and IsImplicitlyDefined attributes.
For .NETCore >= 3 we don't need to reset any attributes on the
FrameworkReference.
We default to the version that is bundled within the SDK in the
Microsoft.NETCoreSdk.BundledVersions.props file.
* Update dependencies from https://github.com/dotnet/standard build
20190922.1
- NETStandard.Library - 2.2.0-prerelease.19472.1
* Update SDK to 3.0.100 stable
* Simplify code in netcoreapp.depproj
* Update packageIndex inbox matrix for S.R.Emit
* Manual darc update from build '
20190923.5'
Commit migrated from https://github.com/dotnet/corefx/commit/
90f7cc01418c059f496528beeca77c5f5549e6fc
Levi Broderick [Tue, 24 Sep 2019 22:09:53 +0000 (15:09 -0700)]
Add more Unicode validation tests (dotnet/corefx#41265)
* Add more Unicode validation tests
* PR feedback and add more char tests
Commit migrated from https://github.com/dotnet/corefx/commit/
b59265f6dda8e0462f17b96d85e1356245261de9
Viktor Hofer [Tue, 24 Sep 2019 20:45:20 +0000 (22:45 +0200)]
Update windows-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
4515def03be39fe09f20d47059c9e85438d23825
oleggolovkovuss [Tue, 24 Sep 2019 19:54:36 +0000 (22:54 +0300)]
Fixing outdated method name (dotnet/corefx#41285)
.Net Core release notes lead to this sample for JSON serializing, it's using non-existent static `ToString` method though, this changes updates the docs
Commit migrated from https://github.com/dotnet/corefx/commit/
629eea822f258f8d5771b96286eba8ff8c89d997
Stephen Toub [Tue, 24 Sep 2019 19:53:19 +0000 (12:53 -0700)]
Annotate System.Threading.Tasks.Parallel for nullability (dotnet/corefx#41249)
Commit migrated from https://github.com/dotnet/corefx/commit/
0298da07f3252e645d7d9509cfd4f19615043f7a
buyaa-n [Tue, 24 Sep 2019 17:05:58 +0000 (10:05 -0700)]
Annotate System.ComponentModel.Primitives for nullable (dotnet/corefx#41185)
* Annotate System.ComponentModel.Primitives for nullable
Commit migrated from https://github.com/dotnet/corefx/commit/
da147ece700c2502b91e57d99213feadcfb9c1f0
Viktor Hofer [Tue, 24 Sep 2019 13:49:41 +0000 (15:49 +0200)]
Replace RS4 with Client19H1 in CI (dotnet/corefx#41277)
Commit migrated from https://github.com/dotnet/corefx/commit/
6549a93fb462f581696af11a3be076d36309dc7e
Viktor Hofer [Tue, 24 Sep 2019 10:46:11 +0000 (12:46 +0200)]
Disable UWP pkg publishing to fix official builds (dotnet/corefx#41279)
Commit migrated from https://github.com/dotnet/corefx/commit/
0a51b2d9b191a12768d4d1410d0c200bba558522
Stephen Toub [Tue, 24 Sep 2019 05:22:44 +0000 (22:22 -0700)]
Remove some unnecessary string concatenation from CertificatePal.AppendPrivateKeyInfo (dotnet/corefx#41274)
Commit migrated from https://github.com/dotnet/corefx/commit/
f2292af3a1794378339d6f5c8adcc0f2019a2cf9
Jeremy Barton [Tue, 24 Sep 2019 02:22:35 +0000 (19:22 -0700)]
Fix validity encoding for cert dates after 2049
During the change from the reflection serializer to asn.xslt generation we lost
the metadata that said that X.509 Time GeneralizedTime values need to ignore
fractional seconds.
That means we're generating fractional seconds when the input DateTimeOffset
has them, which means we violate RFC in our generated certificates.
Commit migrated from https://github.com/dotnet/corefx/commit/
8a65f0b14cb3f29272a18b2f6dbe4bebfd4d4177
Carlos Sanchez Lopez [Tue, 24 Sep 2019 00:10:16 +0000 (17:10 -0700)]
Remove person who left the company (dotnet/corefx#41272)
Commit migrated from https://github.com/dotnet/corefx/commit/
5f3673cbcd0bc161c1d3d8cef531e8e57bcfcbed
Jeremy Koritzinsky [Mon, 23 Sep 2019 23:30:46 +0000 (16:30 -0700)]
Error out clearly when trying to use COM objects with the DLR. (dotnet/corefx#40075)
* Throw an exception in the dynamic binder when trying to dynamically resolve a COM object without an enabled COM binder.
* Add test for exception throw on dynamic usage with COM.
* Update test to validate the change in each binder.
* PR Feedback.
* Add missing using.
Commit migrated from https://github.com/dotnet/corefx/commit/
5ed05b311925509d3cd4b6938d4935ca31cdaf92
Anirudh Agnihotry [Mon, 23 Sep 2019 21:01:49 +0000 (14:01 -0700)]
Removing microsoft.private.corefx.uap (dotnet/corefx#41187)
* removing microsoft.private.corefx.uap
* removing uap specific changes in ,.targets
* add uap-windowsNT
Commit migrated from https://github.com/dotnet/corefx/commit/
49ba6ef9cb8120c87eae636fc41b79e07e88e707
Charles Stoner [Mon, 23 Sep 2019 16:24:45 +0000 (09:24 -0700)]
Additional enum tests for System.Linq.Expressions.Interpreter.CallInstruction (dotnet/corefx#41218)
Commit migrated from https://github.com/dotnet/corefx/commit/
f9919e1ce5ca407f55d078af003af642c1b44d92
Krzysztof Wicher [Sat, 21 Sep 2019 16:39:04 +0000 (09:39 -0700)]
Make Add/Remove UnsignedAttribute work with counter signers
Commit migrated from https://github.com/dotnet/corefx/commit/
4c074ae47660448eae66a362076124177709640a
Stephen Toub [Fri, 20 Sep 2019 20:29:39 +0000 (16:29 -0400)]
Enable better trimming of derived XmlReader/Writer-derived types (dotnet/corefx#41235)
Commit migrated from https://github.com/dotnet/corefx/commit/
b893e604ce832ccf4e9cbcbdfe0b0ae2b23195bf
Eirik Tsarpalis [Fri, 20 Sep 2019 15:32:06 +0000 (18:32 +0300)]
HttpClientHandler functional test: replace remote server dependency (dotnet/corefx#41229)
* HttpClientHandler functional test: replace remote server dependency
Replaces remote server dependency for HttpClientHandler_MaxResponseHeadersLength_Test.SetAfterUse_Throws.
Fixes dotnet/corefx#41148
Commit migrated from https://github.com/dotnet/corefx/commit/
b020d0033ffe755f779c564186fc2d98b0af31cc
Stephen Toub [Fri, 20 Sep 2019 14:28:13 +0000 (10:28 -0400)]
Remove unnused StringExtensions.cs from a couple projects (dotnet/corefx#41211)
Commit migrated from https://github.com/dotnet/corefx/commit/
0286bce5fd360207ca707fe7024248be428cf0e9
Günther Foidl [Fri, 20 Sep 2019 13:13:35 +0000 (15:13 +0200)]
Make CryptoNative_EvpDigestUpdate count parameter int32_t instead of size_t
Shim functions should use sized types, which the size type isn't.
Commit migrated from https://github.com/dotnet/corefx/commit/
ca6add5711542ae513dcd2269146eec3c518c4b5
Maryam Ariyan [Fri, 20 Sep 2019 12:28:52 +0000 (05:28 -0700)]
Enable nullable annotations for System.Drawing.Primitives (dotnet/corefx#41188)
Commit migrated from https://github.com/dotnet/corefx/commit/
aa72982dcb20c4e346e08d72dae5abbaf6bba4f9
Adam Sitnik [Fri, 20 Sep 2019 08:18:20 +0000 (10:18 +0200)]
add StartsWith Surrogates test cases (dotnet/corefx#41227)
Commit migrated from https://github.com/dotnet/corefx/commit/
ce5dfbb9ad62f95885748c7e95ebcd3ca453d1bf
Katarzyna Bułat [Fri, 20 Sep 2019 00:47:40 +0000 (17:47 -0700)]
JsonNode options (dotnet/corefx#41030)
* JsonNodeOptions added
* review comments included
* review comments included
Commit migrated from https://github.com/dotnet/corefx/commit/
5bc2806f33090e78b38fafe4d5b46d5a0a4c1f08
buyaa-n [Fri, 20 Sep 2019 00:19:48 +0000 (17:19 -0700)]
Annotate System.Collections.Specialized for nullable (dotnet/corefx#41092)
Annotate System.Collections.NonGeneric for nullable
Commit migrated from https://github.com/dotnet/corefx/commit/
0d6adbc80b1d8262771a4db71931c4383646ff1f
Tomas Weinfurt [Thu, 19 Sep 2019 17:38:41 +0000 (10:38 -0700)]
invalidate state when directory is created (dotnet/corefx#40677)
Commit migrated from https://github.com/dotnet/corefx/commit/
a3bf1eaff8819262e9308a94a59277df95fed6b7
Maryam Ariyan [Thu, 19 Sep 2019 02:50:18 +0000 (19:50 -0700)]
Nullability annotations for System.Console (dotnet/corefx#41161)
Contributes to: dotnet/corefx#40623
Commit migrated from https://github.com/dotnet/corefx/commit/
19b304f7815894b13cb61e87e1c9eac49a474c7e
Stephen Toub [Thu, 19 Sep 2019 02:42:17 +0000 (22:42 -0400)]
Fix trimming of System.Net.NetworkInformation (dotnet/corefx#41191)
Commit migrated from https://github.com/dotnet/corefx/commit/
2f1d199cf19572dc319be344ea0905edbf318ea3
Stephen Toub [Wed, 18 Sep 2019 20:43:25 +0000 (16:43 -0400)]
Remove DEBUG-only TraceSource/Switch usage from corefx (dotnet/corefx#41177)
A lot of TraceSource/Switch usage in corefx exists only to enable some optional DEBUG-only tracing and asserts, which haven't been used in a very long time, but some of it is keeping these types from being trimmed in a default MVC app.
Commit migrated from https://github.com/dotnet/corefx/commit/
80adc8b87163dfe77d5b4262ea7970cc2de87f46
Maryam Ariyan [Wed, 18 Sep 2019 20:35:33 +0000 (13:35 -0700)]
Update unix-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
2c5f652ea6a883bc032db18a8a2401db9f66f523
Maryam Ariyan [Wed, 18 Sep 2019 20:03:01 +0000 (13:03 -0700)]
Update unix-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
a18b1ba2cf6fb9377ccd3d4e263ea84d75c23842
Stephen Toub [Wed, 18 Sep 2019 19:29:16 +0000 (15:29 -0400)]
Fix trimming of System.Net.Ping (dotnet/corefx#41180)
It has an ILLinkTrim.xml file that was keeping a type around for testing, but that's apparently keeping the assembly from being trimmed in a published app.
Commit migrated from https://github.com/dotnet/corefx/commit/
64c7228b941d1402009c57441a5a8c634d0e6843
Jeremy Barton [Wed, 18 Sep 2019 16:37:51 +0000 (09:37 -0700)]
Fix the filename used by the VerifyCrlCache test (dotnet/corefx#41173)
The VerifyCrlCache test, which is a manual test, is looking for the old cache key.
This change updates it to the new cache key, and makes the test pass again.
Commit migrated from https://github.com/dotnet/corefx/commit/
395f42ffa645efd067fd790712b48061c0236523
Adam Sitnik [Wed, 18 Sep 2019 15:47:51 +0000 (17:47 +0200)]
improve span.StartsWith(span) test coverage (dotnet/corefx#41169)
Commit migrated from https://github.com/dotnet/corefx/commit/
b8d1e0620e6ed6355d76d118c6fa609e7f7cc049
Zach Read [Wed, 18 Sep 2019 15:31:26 +0000 (10:31 -0500)]
Allow X509Chain to replace the root trust list when building a chain
This enables users of X509Chain to specify a priori a set of trusted root authorities, which is used in place of the default root authorities.
By explicitly specifying the root authorities the caller enables revocation checking for normally untrusted roots, and simplifies the certificate acceptance by having the chain engine tell them if the root matched, vs doing a post-build check (in the case of cross-certified authorities this even tells the chain engine which path to prefer).
Commit migrated from https://github.com/dotnet/corefx/commit/
e70e76159b3f34e4e35d241daf39d4f57f4bd82c
buyaa-n [Wed, 18 Sep 2019 14:31:39 +0000 (07:31 -0700)]
Annotate System.ComponentModel for nullable (dotnet/corefx#41160)
* Annotate System.ComponentModel for nullable
* Applying feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
90870e3120f4998a70546798b02c4c903df2f4df
Santiago Fernandez Madero [Wed, 18 Sep 2019 14:31:20 +0000 (07:31 -0700)]
Remove some ActiveIssueAttributes (dotnet/corefx#41163)
Commit migrated from https://github.com/dotnet/corefx/commit/
9f4fa8c6d1b581676f24af429bc64867cb623c78
Frank Buckley [Wed, 18 Sep 2019 00:59:41 +0000 (01:59 +0100)]
Add missing tag to XML comments (dotnet/corefx#41162)
Commit migrated from https://github.com/dotnet/corefx/commit/
4ca1feeeb484e8a7089ce8a9d377703ad5b8a53e
Tarek Mahmoud Sayed [Tue, 17 Sep 2019 18:19:40 +0000 (11:19 -0700)]
Add Culture Cloning Test (dotnet/corefx#41124)
* Add Culture Cloning Test
This test to validate the calendar instances inside the culture after colning.
* Address the feedback
* More feedback addressing
* More Feedback Addressing
Commit migrated from https://github.com/dotnet/corefx/commit/
65edbb39dd737e8529a343f385d2600e482b7ff3
Stephen Toub [Tue, 17 Sep 2019 14:43:51 +0000 (10:43 -0400)]
Remove System.Net.Requests dependency from System.Private.Xml (dotnet/corefx#41111)
* Remove System.Net.Requests dependency from System.Private.Xml
Anything that uses System.Xml ends up implicitly referencing this .dll, which in a trimmed default MVC app is 97K. The only thing it's used for is as part of XmlResolver to download the specified url. We can instead remove the usage of WebRequest.Create and replace it with usage of HttpClient, which is already brought in because System.Net.Requests uses it to implement HttpWebRequest.
* Address PR feedback
And other minor cleanup. Also fix uap build.
Commit migrated from https://github.com/dotnet/corefx/commit/
f873a33056ab318c02d295f816065a3d2ad3736b
Stephen Toub [Tue, 17 Sep 2019 14:17:49 +0000 (10:17 -0400)]
Remove unused files from System.Net.Http (dotnet/corefx#41155)
Commit migrated from https://github.com/dotnet/corefx/commit/
e9836aa6bdd40d76d8cf3534e491d90421c4bd9a
Matt Galbraith [Tue, 17 Sep 2019 13:26:21 +0000 (06:26 -0700)]
Fix a typo in DictionaryImportsReceiveMetadataFromNestedAdapters test name (dotnet/corefx#41149)
Commit migrated from https://github.com/dotnet/corefx/commit/
9200a1714863e53be53dc4406f493b2ea810c291
Tomas Weinfurt [Tue, 17 Sep 2019 13:16:25 +0000 (06:16 -0700)]
improve socket timout tests (dotnet/corefx#41078)
* improve socket timout tests
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
938b24dc397e11eab8688deca71ecd13ffc6fa4a
Layomi Akinrinade [Tue, 17 Sep 2019 12:38:41 +0000 (08:38 -0400)]
Support nullable values in dictionaries (dotnet/corefx#40991)
* Support nullable values in dictionaries
* Address review feedback
* Address feedback
* Defer dictionary key escaping to writer
Commit migrated from https://github.com/dotnet/corefx/commit/
a308e93b1f1303be7eab5ce2b8ed11e66cc8e01e
Stephen Toub [Tue, 17 Sep 2019 12:20:14 +0000 (08:20 -0400)]
Remove allocations from Dns.* (dotnet/corefx#41061)
This started as an effort to reduce the size of System.Net.NameResolution.dll when publishing a trimmed app. It's not that big to begin with, but it's carrying around a copy of all of the IAsyncResult helper types, because the Get*Async methods are currently wrappers for the Begin/End* methods.
This PR inverts that, wrapping the Begin/End* methods instead around the Get*Async methods, using the same TaskToApm helper we use in other places in corefx for the same purpose. This makes the Get*Async methods faster and lighterweight, but it does increase the number/amount of allocation in the Begin/End* APIs. Since these are considered legacy, I normally would consider that a good trade, however we still use these Begin/End methods in a few places in System.Net.Sockets, and I didn't want to regress those use cases.
So, this also then trims some additional fat, which helps the Get*Async cases even further, and gets the Begin/End* to be even better than before the change. This includes not allocating an IPHostEntry when we're just going to unwrap it and return its addresses, computing the exact IPAddress[] size we need rather than using a List<> to grow it and ToArray to create the actual array, avoiding creating the HostName if we don't need it, and avoiding an unnecessary SafeHandle allocation.
As part of this, I also noticed that we had some bugs in how some of our interop structures on Windows were defined. In particular, fields that in the native types were size_t were defined as int rather than IntPtr in the managed code. It appears we were saved by padding, but I fixed it regardless.
And as long as I was changing pretty much everything else, where I was touching code I also cleaned up some legacy style stuff.
Commit migrated from https://github.com/dotnet/corefx/commit/
a55e95cbd9fca7ce5b3ad34c583642a35f42cd63
Santiago Fernandez Madero [Tue, 17 Sep 2019 05:10:48 +0000 (22:10 -0700)]
Add missing dummy types to reference assemblies (dotnet/corefx#41147)
Commit migrated from https://github.com/dotnet/corefx/commit/
4aea703673e942756c02b222e6b5babaf8612a25
Stephen Toub [Tue, 17 Sep 2019 01:04:03 +0000 (21:04 -0400)]
Remove use of non-generic Queue/Stack in System.Private.Xml (dotnet/corefx#41142)
This is the only reason these types are brought into a trimmed default MVC app.
Commit migrated from https://github.com/dotnet/corefx/commit/
6347f35dad5fc7a967d5ab1202e8fbaf0ac7d252
Stephen Toub [Tue, 17 Sep 2019 00:38:32 +0000 (20:38 -0400)]
Remove use of RuntimeReflectionExtensions from Microsoft.CSharp (dotnet/corefx#41143)
* Remove use of RuntimeReflectionExtensions from Microsoft.CSharp
The wrappers aren't adding any benefit and are causing us to pull in the extensions type unnecessarily (and doing unnecessary null checks); just call the underlying methods directly.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
4dd07b79be316cf8421a51e0ed6b4a145713080e
Wraith2 [Mon, 16 Sep 2019 19:48:10 +0000 (20:48 +0100)]
Fix SqlParameter with xml schema construction (dotnet/corefx#41008)
Commit migrated from https://github.com/dotnet/corefx/commit/
cd0576dad5fcfe73aeda81a0a81972843734e525
Stephen Toub [Mon, 16 Sep 2019 18:56:59 +0000 (14:56 -0400)]
Remove System.Net.Http dependency on System.Text.RegularExpressions (dotnet/corefx#41110)
* Remove System.Net.Http dependency on System.Text.RegularExpressions
This dependency is the only reason we end up with a 105K System.Text.RegularExpressions.dll as part of a trimmed new MVC app. Regex is used in the case where on Windows a bypass list is provided, in which case each item in the list is changed into a regex, which is then evaluated against each url provided to SocketsHttpHandler. But the patterns usable are simple: the only special character recognized is an asterisk, which can map to zero or more of any character. So, we can instead employ a simple processor for such patterns, which then eliminates the need to reference System.Text.RegularExpressions.dll from System.Net.Http.dll. It also happens to be faster.
* Address PR feedback
* Update src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs
Co-Authored-By: Jan Kotas <jkotas@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
0e65e923689962f9634b5948d15f995140cc7c93
Steve Harter [Mon, 16 Sep 2019 16:20:43 +0000 (11:20 -0500)]
Serialization performance improvements (dotnet/corefx#41098)
Commit migrated from https://github.com/dotnet/corefx/commit/
017a038abaabedcbbc61c85c9f7405f588ca3b46
Ganbarukamo41 [Mon, 16 Sep 2019 16:15:28 +0000 (01:15 +0900)]
Update dogfooding.md to include other blob feeds required for dogfooding (dotnet/corefx#41123)
* Update dogfooding.md to include other feeds
* Add a few more blob feeds that are listed in https://github.com/dotnet/core-sdk#installers-and-binaries, which are required to properly dogfood nightly SDKs
* For example, adding only the core blob may result in build failures due to failures restoring packages that are distributed from ASP.NET feeds
* Replace MyGet with dotnet-blob feeds, since MyGet isn't used anymore
* Remove duplicate feed that's added by mistake
Commit migrated from https://github.com/dotnet/corefx/commit/
115035527ef4179425be7116756cf4e69e9f4a79
Marie Píchová [Mon, 16 Sep 2019 16:12:14 +0000 (18:12 +0200)]
Updated VS code debugging instructions (dotnet/corefx#41138)
* Updated VS code debugging instructions.
* Moved debugging instructions into developer-guide.md (PR comment).
Commit migrated from https://github.com/dotnet/corefx/commit/
a8f4393940c3f01218d115aae7628cf60d8d8fc3
Viktor Hofer [Mon, 16 Sep 2019 16:09:22 +0000 (18:09 +0200)]
Re-enable macOS 10.14 in CI
Commit migrated from https://github.com/dotnet/corefx/commit/
cc0cc906fac8638e78115aa0f7478c654d155b52
marcnet80 [Sat, 14 Sep 2019 19:36:07 +0000 (22:36 +0300)]
Possible overflow in Partitioner dotnet/corefx#40201 (dotnet/corefx#41066)
* Possible overflow in Partitioner dotnet/corefx#40201
https://github.com/dotnet/corefx/issues/40201
* Possible overflow in Partitioner dotnet/corefx#40201
https://github.com/dotnet/corefx/issues/40201
* Possible overflow in Partitioner dotnet/corefx#40201
https://github.com/dotnet/corefx/issues/40201
* Possible overflow in Partitioner dotnet/corefx#40201
https://github.com/dotnet/corefx/issues/40201
* Possible overflow in Partitioner dotnet/corefx#40201
https://github.com/dotnet/corefx/issues/40201
Commit migrated from https://github.com/dotnet/corefx/commit/
36370ae660d385deef9c2dc25f72852bc4b9194e
David Shulman [Sat, 14 Sep 2019 15:50:30 +0000 (08:50 -0700)]
Disable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds (dotnet/corefx#41109)
The remote server "revoked.badssl.com" has a certificate which is not only revoked but also
now untrusted since it has expired.
Disabling test for now
Contributes to dotnet/corefx#41108
Commit migrated from https://github.com/dotnet/corefx/commit/
8350134a21960df364517c9c766937ae47bf76c5
Stephen Toub [Sat, 14 Sep 2019 02:30:37 +0000 (22:30 -0400)]
Remove unnecessary passing of RegexOptions.None to Regex ctor (dotnet/corefx#41101)
Commit migrated from https://github.com/dotnet/corefx/commit/
f07730eedb1f7e2cb5e178d988bc2255f7ce7021
dotnet-maestro[bot] [Fri, 13 Sep 2019 19:53:32 +0000 (19:53 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41089)
* Update dependencies from https://github.com/dotnet/coreclr build
20190912.7
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19462.7
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19462.7
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19462.7
* Fix Environment.WorkingSet tests for coreclr update
Commit migrated from https://github.com/dotnet/corefx/commit/
a3dbe06e55084c12450288db4ea12a1e7fd36144
buyaa-n [Fri, 13 Sep 2019 14:26:27 +0000 (07:26 -0700)]
Annotate System.Collections.NonGeneric for nullable (dotnet/corefx#41036)
* Annotate System.Collections.NonGeneric for nullable
* Removing unnessecarry constant
* Marked CaseInsensitiveHashCodeProvider as Obsolete
* Removing NullableAttributes defintion as it was already added
* Applying feedback
* Revert "Applying feedback"
* Applying feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
001420e80489bf8e456d8bfb9aa22d5a02de0988
Tomas Weinfurt [Fri, 13 Sep 2019 13:40:36 +0000 (06:40 -0700)]
use configuration for invalid host name (dotnet/corefx#41083)
Commit migrated from https://github.com/dotnet/corefx/commit/
19ea63fee517327e1f6fbfa730300ddef5ef8a3b
dotnet-maestro[bot] [Fri, 13 Sep 2019 10:15:01 +0000 (10:15 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41023)
* Update dependencies from https://github.com/dotnet/coreclr build
20190910.9
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19460.9
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19460.9
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19460.9
* Update dependencies from https://github.com/dotnet/coreclr build
20190911.7
- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19461.7
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19461.7
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19461.7
* Update StringComparerTests.netcoreapp.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
fdb13cc7ee134a17fb36a038b57795b7e2225274
Viktor Hofer [Fri, 13 Sep 2019 09:29:49 +0000 (11:29 +0200)]
Disable macOS 10.14 in CI again
One machine is not patched correctly and causes builds to fail.
Commit migrated from https://github.com/dotnet/corefx/commit/
767467e72a372b31be44ee08e161b19e846c191a
Stephen Toub [Fri, 13 Sep 2019 00:21:41 +0000 (20:21 -0400)]
Enable Regex compiler to be trimmed (dotnet/corefx#41075)
Today an app that just does:
```C#
Console.WriteLine(Regex.IsMatch("12345", "0*[1-9][0-9]*"));
```
and is trimmed will end up publishing a 105K System.Text.RegularExpression.dll, including the regex compiler for when the RegexOptions.Compiled is used. We can refactor the constructors such that the compiler only ends up getting rooted when one of the ctors that takes options is used. After this PR, if you don't pass RegexOptions, the 105K drops to 85K.
Commit migrated from https://github.com/dotnet/corefx/commit/
31a5bba0e79a5ae875f691d70ec3b9789691136d
Anirudh Agnihotry [Thu, 12 Sep 2019 21:23:37 +0000 (14:23 -0700)]
making debugging easier (dotnet/corefx#41067)
Commit migrated from https://github.com/dotnet/corefx/commit/
03b2cb81fcd893c38d9b717d5b93ca7eba59fc2e
Steve Harter [Thu, 12 Sep 2019 20:47:56 +0000 (15:47 -0500)]
Improve deserialization perf with changes to property name lookup (dotnet/corefx#40998)
Commit migrated from https://github.com/dotnet/corefx/commit/
d3c6628c2594b496ebc17526576cb164fc5fc0bf
Jeremy Kuhne [Thu, 12 Sep 2019 20:21:59 +0000 (13:21 -0700)]
Fix icon entry selection (dotnet/corefx#41048)
* We weren't checking the color depth properly when choosing an icon entry to extract from an icon file.
Fix, and add a test.
Commit migrated from https://github.com/dotnet/corefx/commit/
3a5b86f21b498067fa920842adaf228e39b6e35a
Tomas Weinfurt [Thu, 12 Sep 2019 18:48:41 +0000 (11:48 -0700)]
make sure BindDuringTcpWait_Succeeds does not run with other tests (dotnet/corefx#40958)
* make sure BindDuringTcpWait_Succeeds does not run with other tests
* add partial to NoParallelTests class
* add empty class to CollectionDefinition
Commit migrated from https://github.com/dotnet/corefx/commit/
b384d34bcd4674bc0df08a333a4973de8e2ac7ae
Omair Majid [Thu, 12 Sep 2019 17:57:14 +0000 (13:57 -0400)]
Add Runtime IDs for Fedora 32
Commit migrated from https://github.com/dotnet/corefx/commit/
86fc9e751c424278a9c4e163e0a71a9d7e30c8e7
Carlos Sanchez Lopez [Wed, 11 Sep 2019 20:38:29 +0000 (13:38 -0700)]
Add example of strong API proposal (dotnet/corefx#41042)
Commit migrated from https://github.com/dotnet/corefx/commit/
452c93e38097b53f19516486fda4f3b1f16334cf
Adam Sitnik [Wed, 11 Sep 2019 20:34:27 +0000 (22:34 +0200)]
add links to the new Profiling docs (dotnet/corefx#41018)
Commit migrated from https://github.com/dotnet/corefx/commit/
dc71f95667cabd5ad0f7a051c974e0d312b243e8
Adam Sitnik [Wed, 11 Sep 2019 19:57:23 +0000 (21:57 +0200)]
add few StartsWith edge case test cases (dotnet/corefx#41016)
* add Hungarian edge case for IsPrefix
* add InvariantCulture.CompareInfo.IsPrefix("o\u0308", "o") edge case
Commit migrated from https://github.com/dotnet/corefx/commit/
e32d9a2664a59eccbcbe5a4044cffbdd96538b5b
Adam Sitnik [Wed, 11 Sep 2019 19:56:55 +0000 (21:56 +0200)]
add IsPrefix test cases for Platforms differences (dotnet/corefx#41017)
Commit migrated from https://github.com/dotnet/corefx/commit/
728aceca7464e964719fc99ef585e63cbb95f44d
Tomas Weinfurt [Wed, 11 Sep 2019 19:16:01 +0000 (12:16 -0700)]
improve two http2 tests (dotnet/corefx#40797)
Commit migrated from https://github.com/dotnet/corefx/commit/
9eed67227c2d0766c1b7fe40fa8a1a97097e3beb
Krzysztof Wicher [Wed, 11 Sep 2019 18:34:57 +0000 (11:34 -0700)]
Fix SerialStream.Flush on Unix (dotnet/corefx#40896)
* Fix SerialStream.Flush
* Only wait for write queue to drain on Flush
* add test case with reproted scenario
Commit migrated from https://github.com/dotnet/corefx/commit/
45dba6ea7a49a9945a5ad497cfc3de2ec1246683
Katarzyna Bułat [Wed, 11 Sep 2019 18:23:17 +0000 (11:23 -0700)]
JsonDocument documenation fix (dotnet/corefx#40994)
* JsonDocument documenation fix
* comma added
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
0354194175bb8d609000b463f402942db7235f0a
Mandar Sahasrabuddhe [Wed, 11 Sep 2019 04:29:44 +0000 (09:59 +0530)]
Given examples and made points explicit (dotnet/corefx#41012)
Made certain points explicit by giving examples or specifying acronyms in brackets where the words they stand for, appear for first time.
Commit migrated from https://github.com/dotnet/corefx/commit/
76f566a281bbe979e80cbbb3a48ddf522cdcb4e1
Ahson Khan [Wed, 11 Sep 2019 00:49:22 +0000 (17:49 -0700)]
Avoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while escaping in Utf8JsonWriter. (dotnet/corefx#40996)
* Avoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while
escaping in Utf8JsonWriter.
* Fix white space typo in the test expected string.
* Guard against empty spans where an implementation of JavascriptEncoder
might not handle null ptrs correctly.
* Cleanup tests to avoid some duplication.
* Some more test clean up.
Commit migrated from https://github.com/dotnet/corefx/commit/
ee9995f31b684a0c6e5488eceb2500bf0057da89
Charles Stoner [Wed, 11 Sep 2019 00:31:41 +0000 (17:31 -0700)]
Use slow path for CallInstruction returning enum value (dotnet/corefx#40976)
* Use slow path for CallInstruction returning enum value
* Fix assert
Commit migrated from https://github.com/dotnet/corefx/commit/
f2daf45473553c19cc7b3dd4bb3f2033080a254c
Jan Kotas [Tue, 10 Sep 2019 22:10:25 +0000 (15:10 -0700)]
Delete unused ItemGroup (dotnet/corefx#40983)
Moved to CoreLib
Commit migrated from https://github.com/dotnet/corefx/commit/
0ebca43a4db8d5ddaf2e9fd0df359a262b61c0ce
Viktor Hofer [Tue, 10 Sep 2019 18:23:02 +0000 (20:23 +0200)]
Re-enable macOS 10.13 (dotnet/corefx#40980)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b0e8cc8d66275de148f7310a7116de00d814cd0
Stephen Toub [Tue, 10 Sep 2019 15:36:35 +0000 (11:36 -0400)]
Fix namespace typo in Tasks test (dotnet/corefx#40974)
Commit migrated from https://github.com/dotnet/corefx/commit/
02bebd69dcac53a7b903d605ce43fd28cd5ee0e9
Santiago Fernandez Madero [Tue, 10 Sep 2019 13:37:09 +0000 (06:37 -0700)]
Add test for IComponent typeconverter register in TypeDescriptor (dotnet/corefx#40959)
Commit migrated from https://github.com/dotnet/corefx/commit/
d1eeba90af85dd203aa27adbb30a28e45b54e23d
Hugh Bellamy [Mon, 9 Sep 2019 23:30:51 +0000 (00:30 +0100)]
Add CodeDom.CodeValidator tests and fix some bugs (dotnet/corefx#39585)
* Add CodeDom.CodeValidator tests and fix some bugs
* Fix netfx tests
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
50e8db3cabbfb6ad0fc0702b3db25491a95c72a5
Steve Harter [Mon, 9 Sep 2019 21:55:47 +0000 (16:55 -0500)]
Minor deserialization perf improvements for collections (dotnet/corefx#40889)
Commit migrated from https://github.com/dotnet/corefx/commit/
27ddbe99ccc32122141b81045ac670c3a0d1a45a
Katarzyna Bułat [Mon, 9 Sep 2019 21:53:38 +0000 (14:53 -0700)]
Writable JSON API changes (dotnet/corefx#40673)
* implicit operators moved to JsonNode
* JsonNull introduced
* JsonObject rewritten to use JsonObjectProperty
* JsonElement.ObjectEnumerator changed to use _current instead of _enumerator
* iterative DeepCopy implemented
* code reorganized
* parse implemented
* JsonDocumentOptions added to JsonNode.Parse
* WriteTo and ToJsonString added
* specification adjusted
* string comparison added
* JsosReadonlyDomWriteTests reused
* code coverage improved
* minor other fixes
* review comments included
Commit migrated from https://github.com/dotnet/corefx/commit/
37b37395481b635c15eaa3454e52b72ab91de4ef