platform/core/ml/nnfw.git
5 years ago[neurun] Remove skip list for TrivialTest.AddThree (#4266)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 18 Jan 2019 06:20:02 +0000 (15:20 +0900)]
[neurun] Remove skip list for TrivialTest.AddThree (#4266)

Related : #4211

This commit removes skip list for `TrivialTest.AddThree`, since #4263 and #4257 are merged.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Support to initialize 2D constant (#4257)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 18 Jan 2019 03:22:06 +0000 (12:22 +0900)]
[neurun] Support to initialize 2D constant (#4257)

* [neurun] Support to initialize 2D constant

Until now, `ConstantInitializer` in `neurun` has supported only for `FullyConnected`.
This commit supports to initialize 2D constant for all other operations.

* Change some comment

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoMove type converter (#4253)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 18 Jan 2019 03:20:24 +0000 (12:20 +0900)]
Move type converter (#4253)

* Move type converter

Move type converter from graph to util
It makes more independent internal code with NNAPI

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix test and remove deprecated include

* Fix comment

* Divide function declaration and definition

5 years agoUse config manager for logging (#4261)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 18 Jan 2019 00:53:06 +0000 (09:53 +0900)]
Use config manager for logging (#4261)

Use config manager for neurun logging enable/disable

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoCorrection in comment in Pad kernel (#4262)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Fri, 18 Jan 2019 00:51:29 +0000 (06:21 +0530)]
Correction in comment in Pad kernel (#4262)

this patch will correct the comment which tells
what the pad kernel does.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRenaming ArgMinMax to ArgOperation (#4238)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Fri, 18 Jan 2019 00:51:16 +0000 (06:21 +0530)]
Renaming ArgMinMax to ArgOperation (#4238)

In order to have genericity so that any arg op
can be added, this patch will rename occurances
of ArgMinMax to ArgOperation.
Also, this patch will correct few of the comments.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Fix when `Graph::lower` is called twice (#4263)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 18 Jan 2019 00:46:44 +0000 (09:46 +0900)]
[neurun] Fix when `Graph::lower` is called twice (#4263)

This commit fixes to handle `Graph::lower` is called multiple times.

Fix #4258

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Remove skip list for TrivialTest.AddTwo (#4260)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 17 Jan 2019 22:24:44 +0000 (07:24 +0900)]
[neurun] Remove skip list for TrivialTest.AddTwo (#4260)

Related : #4211

This commit removes skip lit for `TrivialTest.AddTwo`, since #4249 is merged.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoRemove dependence of data format(NHWC) of PACL from kernels of PAD (#4014)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 17 Jan 2019 09:40:46 +0000 (18:40 +0900)]
Remove dependence of data format(NHWC) of PACL from kernels of PAD (#4014)

This commit removes dependece of data format(NHWC) of PACL runtime from kernels of PAD.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoAdd Broadcast support for PReLU in PACL (#4072)
Prasanna R/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 17 Jan 2019 09:37:52 +0000 (15:07 +0530)]
Add Broadcast support for PReLU in PACL (#4072)

This patch adds broadcast support for PReLU in PACL.

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoOptimisation in Permute kernel (#4202)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 17 Jan 2019 09:32:48 +0000 (15:02 +0530)]
Optimisation in Permute kernel (#4202)

Since many of the assignment operations are present
in kernel which can be easily avoided and hence can
lead to some optmisation.
This patch will remove the unnecessary assignemnt operations.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Support other types in PermuteSource/PermuteSink (#4249)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 17 Jan 2019 08:12:50 +0000 (17:12 +0900)]
[neurun] Support other types in PermuteSource/PermuteSink (#4249)

* [neurun] Support other types in PermuteSource/PermuteSink

This commit supports other types in `PermuteSource`/`PermuteSink`.
These would make some mismatching TCs to match such as `TrivialTest.AddTwo`.

* Remove TODO

* Remove casting value already casted

* Remove unnecessary casting

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoUpdate enabled validation test list (#4256)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 17 Jan 2019 05:45:25 +0000 (14:45 +0900)]
Update enabled validation test list (#4256)

Update enabled validation tests by supporting ADD operation on armv7l acl-cl backend

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoSupport LogcalNot in runtime and nnapi_delegate (#4048)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Thu, 17 Jan 2019 05:44:07 +0000 (08:44 +0300)]
Support LogcalNot in runtime and nnapi_delegate (#4048)

* Support LogcalNot in runtime and nnapi_delegate

Add support of LogcalNot in PACL runtime and nnapi_delegate

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
* Add logical_not to _kernel_program_map and remove from skip list

Add logical_not to _kernel_program_map and remove from skip list

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years ago[PACL] Fix reshape bug. (#4254)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 17 Jan 2019 03:53:19 +0000 (12:53 +0900)]
[PACL] Fix reshape bug. (#4254)

This commit fixes reshape bug that reshape does not support non 4-D input and 4-D output in PACL.
  - Fix GenericReshapeLayer bug
  - Set the apply_dim_correction input shape of GenericFullyConnectedLayer to `false`

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoFix NNAPI validation check for compilation preference (#4255)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 17 Jan 2019 03:36:08 +0000 (12:36 +0900)]
Fix NNAPI validation check for compilation preference (#4255)

Fix NNAPI frontend validation check for compilation preference
- Bad state: try to set after finish is called
- Bad preference value

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[PACL] Support TransposeConv for GPU (#4223)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 17 Jan 2019 01:06:59 +0000 (10:06 +0900)]
[PACL] Support TransposeConv for GPU (#4223)

This commit supports TransposeConv operation for GPU.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoBring CLDeconvolutionLayer from ACL into libARMComputeEx (#4250)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 16 Jan 2019 09:45:35 +0000 (18:45 +0900)]
Bring CLDeconvolutionLayer from ACL into libARMComputeEx (#4250)

This commit brings CLDeconvolutionLayer in order to fix a bug computing wrong the output's dimension value.
  - Bring CLDeconvolutionLayer
  - Bring a function that computes the output's dimension value

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoRemove unused num_elem variable from Arg CL Host file (#4234)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 16 Jan 2019 06:57:39 +0000 (12:27 +0530)]
Remove unused num_elem variable from Arg CL Host file (#4234)

This patch will remove unused num_elem variable from
CLArgMinMaxKernel.cpp

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoTest packaging for x64 build (#4247)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 15 Jan 2019 09:35:54 +0000 (18:35 +0900)]
Test packaging for x64 build (#4247)

Test packaging for x64 build. It's to prepare neurun x64 test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoMore strict acl extention lib debug build option (#4241)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 15 Jan 2019 09:10:43 +0000 (18:10 +0900)]
More strict acl extention lib debug build option (#4241)

More strict acl extention lib debug build option: unused-parameter and unused-function check

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove skip list and add framework test for ADD op (#4216)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 15 Jan 2019 06:58:47 +0000 (15:58 +0900)]
[neurun] Remove skip list and add framework test for ADD op (#4216)

* [neurun] Remove skip list and add framework test for ADD op

This commit removes skip lit and add framework test for ADD op.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* add GeneratedTests.add_broadcast_4D_2D_after_nops_float_nnfw, remove framework tests

5 years ago[neurun] Fix broadcast bug for ADD op and remove skip list (#4243)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 15 Jan 2019 04:38:36 +0000 (13:38 +0900)]
[neurun] Fix broadcast bug for ADD op and remove skip list (#4243)

This commit fixes broadcast bug for ADD op and remove skip list `TrivialTest.BroadcastAddTwo`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoFramework test list for neurun cpu and acl (#4244)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 15 Jan 2019 03:41:35 +0000 (12:41 +0900)]
Framework test list for neurun cpu and acl (#4244)

Add framework test list for neurun armv7l cpu and acl cl
Add framework test list for neurun x86-64 cpu
Workaround test packaging on makefile for CI test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Correct wrong assumptions for Reshape and Concat (#4210)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 15 Jan 2019 03:07:47 +0000 (12:07 +0900)]
[neurun] Correct wrong assumptions for Reshape and Concat (#4210)

* [neurun] Correct wrong assumptions for Reshape and Concat

This commit corrects wrong assumptions for `Reshape` and `Concat` (refer to belows)

- Reshape : https://developer.android.com/ndk/reference/group/neural-networks#group___neural_networks_1ggaabbe492c60331b13038e39d4207940e0a535e7e99383ee49456c8671843b93a59
- Concat : https://developer.android.com/ndk/reference/group/neural-networks#group___neural_networks_1ggaabbe492c60331b13038e39d4207940e0a44cbea825c4b224dd3ea757e9b1f65ed

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Correct concat count check

* Change concat input range

5 years agoFix nnapi delegate (#4240)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 15 Jan 2019 01:05:49 +0000 (10:05 +0900)]
Fix nnapi delegate (#4240)

Fix nnapi delegate bug for gbs build
Fix switch-case indent

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUse more strict compile option for tflite library (#4196)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 15 Jan 2019 00:18:18 +0000 (09:18 +0900)]
Use more strict compile option for tflite library (#4196)

Use more strict compile option for tflite library
Remove use of size_t as possible

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix infering wrong padding in TransposeConv (#4237)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 15 Jan 2019 00:17:45 +0000 (09:17 +0900)]
Fix infering wrong padding in TransposeConv (#4237)

This commit fixes infering wrong padding in TransposeConv.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoRemove deprecated test for transpose convolution (#4235)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 14 Jan 2019 11:07:17 +0000 (20:07 +0900)]
Remove deprecated test for transpose convolution (#4235)

Remove deprecated test: int32 transpose convolution

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoTranspose Convolution fix (#4137)
Vishal Keshav/SNAP /SRI-Bangalore/Engineer/삼성전자 [Mon, 14 Jan 2019 11:04:56 +0000 (16:34 +0530)]
Transpose Convolution fix (#4137)

Fixed the incorrect filter index
Pad change reverted

Signed-off-by: Vishal Keshav <vishal.k1@samsung.com>
5 years agoUpdate NNAPI extend spec not supporting int32 tensor operation (#4229)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 14 Jan 2019 10:56:11 +0000 (19:56 +0900)]
Update NNAPI extend spec not supporting int32 tensor operation (#4229)

Change int32 tensor to quantized int tensor for ANEURALNETWORKS_TRANSPOSE_CONV_EX

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix build error by unused variable on CLLogicalNotKernel.cpp (#4233)
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 14 Jan 2019 10:53:33 +0000 (19:53 +0900)]
Fix build error by unused variable on CLLogicalNotKernel.cpp (#4233)

- Fix build error by unused variable on CLLogicalNotKernel.cpp

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
5 years agoFix permute vaildation check bug (#4226)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 14 Jan 2019 10:39:59 +0000 (19:39 +0900)]
Fix permute vaildation check bug (#4226)

Fix permute validation check to check validate rank only

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoAdd CL Kernel of LogicalNot (#3636)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Mon, 14 Jan 2019 10:11:01 +0000 (13:11 +0300)]
Add CL Kernel of LogicalNot (#3636)

This commit adds implementation of LogicalNot in CL kernel
Related issues: #3596

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoRefactoring of Shape::broadcast (#4132)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Mon, 14 Jan 2019 10:09:41 +0000 (13:09 +0300)]
Refactoring of Shape::broadcast (#4132)

Remove 4 loops and creating two temp vectors and handle all checks in
one loop

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoBug fix for output shape in Permute (#4201)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Mon, 14 Jan 2019 08:16:44 +0000 (13:46 +0530)]
Bug fix for output shape in Permute (#4201)

This patch will fix the bug in calc output shape in Permute

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd more validations in Permute CL host file (#4188)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Mon, 14 Jan 2019 01:23:26 +0000 (06:53 +0530)]
Add more validations in Permute CL host file (#4188)

This patch will add validations to check input
and permutation vector.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoCorrection in variable names in CL Arg op files (#4125)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Sun, 13 Jan 2019 21:50:32 +0000 (03:20 +0530)]
Correction in variable names in CL Arg op files (#4125)

Since somewhere in code variable name is argminmax_axis and
somewhere it is just axis along with comments having name as
axis.So, this patch will corrects the comments and replaces
all argminmax_axis to axis to have a uniformity in variable
name for axis.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Support broadcast for ADD op (#4203)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Sun, 13 Jan 2019 21:48:36 +0000 (06:48 +0900)]
[neurun] Support broadcast for ADD op (#4203)

Related : #4173

This commit supports broadcast for ADD op and enable the gtest.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoSynch tools/nnapi_quickcheck with current changes (#4197)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 11 Jan 2019 03:05:59 +0000 (06:05 +0300)]
Synch tools/nnapi_quickcheck with current changes (#4197)

Since we don't build tools/nnapi_quickcheck, it's far behind from
current state. So, this change updates all files of this dir to be able
to build and run them

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years ago[neurun] Fix CLTensor::setBuffer to work with new acl (#4199)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 11 Jan 2019 01:00:44 +0000 (04:00 +0300)]
[neurun] Fix CLTensor::setBuffer to work with new acl (#4199)

Related issue: 4185
In new versions of acl that we use now, its functions used in this
method were either updated or removed. This change updates
CLTensor::setBuffer to be able to address these new changes

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoRemove unused func from CLArgMinMaxKernel file (#4200)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Fri, 11 Jan 2019 01:00:29 +0000 (06:30 +0530)]
Remove unused func from CLArgMinMaxKernel file (#4200)

This patch will remove unused func from CLArgMinMaxKernel.h

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun] Enable basic ADD op (#4186)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 11 Jan 2019 00:50:18 +0000 (09:50 +0900)]
[neurun] Enable basic ADD op (#4186)

* [neurun] Enable basic ADD op

Related : #4173

This commit migrate basic `ADD` op that is already exist in `PACL` to `neurun`.

- Neon cannot be supported now.
  - TensorBuilder should has not only `arm_compute::CLTensor` but also `arm_compute::Tensor`.
- Remove skip test `GeneratedTests.add`

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Remove neon codes

* Remove unused codes

5 years ago[neurun] Extract Operand LowerInfo from Node (#4184)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 11 Jan 2019 00:45:01 +0000 (09:45 +0900)]
[neurun] Extract Operand LowerInfo from Node (#4184)

* [neurun] Extract Operand LowerInfo from Node

As `model::operand::Node` is pure node info so LowerInfo should not be
Node class. `graph::Graph` holds them instead.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Do not pass Graph object for DotOperandInfo

Pass only `LowerInfo` instead

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[PACL] Extract internal kernels to libs (#4144)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 11 Jan 2019 00:33:27 +0000 (09:33 +0900)]
[PACL] Extract internal kernels to libs (#4144)

* [PACL] draft: Extract internal kernels to libs

Related : #4060

- Introduce `libs/kernels` and `libs/kernels/simple`
- Move `ARMComputeEx` to `libs/kernels`
- Move internal kernels of `PACL` to `libs/kernels/simple`
  - Remove `FeatureLoggingLayer`
- Some utils are copied from `PACL` to `libs/kernels/simple`

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* remove *.clembed

* Revert kernels location

* Fix build failure

* Change directory to misc

5 years agoDefine more skiplist and install (#4195)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 10 Jan 2019 08:14:36 +0000 (17:14 +0900)]
Define more skiplist and install (#4195)

Define more skiplist: neurun x86, neurun armv7l cpu
Install all skiplists for target platform

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove warning from acl on gbs build (#4194)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 10 Jan 2019 04:38:21 +0000 (13:38 +0900)]
Remove warning from acl on gbs build (#4194)

Remove ignored-attributes warning from acl ex header on gbs build

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUse more strict compile option for misc and profiling (#4193)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 10 Jan 2019 03:59:04 +0000 (12:59 +0900)]
Use more strict compile option for misc and profiling (#4193)

Use more strict compile option for misc and profiling
Remove use of size_t as possible

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoCorrecting name to asPadStrideInfo from asPadStringInfo (#4190)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 10 Jan 2019 01:10:38 +0000 (06:40 +0530)]
Correcting name to asPadStrideInfo from asPadStringInfo (#4190)

Since by asPadStringInfo, one cant think if it is having
stride info or not. Hence, this patch wil rename this func
name to asPadStrideInfo.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoStrict build option for acl (#4163)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 10 Jan 2019 01:07:23 +0000 (10:07 +0900)]
Strict build option for acl (#4163)

* Strict build option for acl

- Add build option for more strict
- Except warning unused-parameter and unused-function for validation check
- Add assert, log, debug build option for debug configure
- Fix bug

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix validatoin check & broadcast bug

* Fix update_window_and_padding call using or operation

5 years ago[neurun] Remove `Index::asInt` (#4189)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 10 Jan 2019 00:28:07 +0000 (09:28 +0900)]
[neurun] Remove `Index::asInt` (#4189)

Remove `asInt` method from `Index` since it should return its underlying
type. Calls to `asInt()` has been replaced with `value()`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoEnable neurun x86 build (#4187)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 9 Jan 2019 09:32:29 +0000 (18:32 +0900)]
Enable neurun x86 build (#4187)

Enable neurun x86 build - use cpu kernel only

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Do not use raw int in operand::Context (#4182)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 9 Jan 2019 07:54:45 +0000 (16:54 +0900)]
[neurun] Do not use raw int in operand::Context (#4182)

This commit revises the type of key for `compiler::operand::Context` to
be `Index` class rather than raw int. Since Index does not support
`operator<` the conainer became `unordered_map`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoChange macro `DEBUG` to `ARM_COMPUTE_DEBUG_ENABLED` (#4183)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 9 Jan 2019 07:28:50 +0000 (16:28 +0900)]
Change macro `DEBUG` to `ARM_COMPUTE_DEBUG_ENABLED` (#4183)

This commit changes `DEBUG` option to `ARM_COMPUTE_DEBUG_ENABLED` in ARMComputeEx.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Move Backend info to PermuteNode (#4180)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 9 Jan 2019 04:32:05 +0000 (13:32 +0900)]
[neurun] Move Backend info to PermuteNode (#4180)

In order for StageGenerator to not have dependency on backends.
This commit moves the backend info for input/output from StageGenerator
to creation of PermuteNode.
(which is created only in PermutationInsertionPass)

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoUse -fPIC build flag for tflite only (#4175)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 9 Jan 2019 04:15:33 +0000 (13:15 +0900)]
Use -fPIC build flag for tflite only (#4175)

* Use -fPIC build flag for tflite only

Instead of global setting, use -fPIC build flag for tenroflow lite only

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Specify to build tensorflow lite library static

5 years agoCorrection in validation func in CL Host files (#4139)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 9 Jan 2019 00:51:25 +0000 (06:21 +0530)]
Correction in validation func in CL Host files (#4139)

Since ARM_COMPUTE_RETURN_ERROR_ON_MSG() is an "ERROR_ON" macro,
which means an error will be thrown if the expression evaluates to "true"
Hence, checks need to be inverted.
This patch will correct the checks in th following files:

1. CLBatchToSpaceNDKernel.cpp
2. CLDepthToSpaceKernel.cpp
3. CLPadLayerKernel.cpp
4. CLReduceOperationKernel.cpp
5. CLSpaceToDepthKernel.cpp

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove warning from external acl and tensorflow (#4181)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 9 Jan 2019 00:48:51 +0000 (09:48 +0900)]
Remove warning from external acl and tensorflow (#4181)

Remove warning from external acl and tensorflow by using SYSTEM keyword

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUse acl pre-built binary (#4179)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 8 Jan 2019 10:12:50 +0000 (19:12 +0900)]
Use acl pre-built binary (#4179)

Remove workaround to avoid build fail by acl version update
Use pre-built acl v18.11 binary

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUpdate version of ARMComputeEx to 18.11 (#3877) 0.3
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 8 Jan 2019 07:10:18 +0000 (16:10 +0900)]
Update version of ARMComputeEx to 18.11 (#3877)

* Update version of ARMComputeEx to 18.11

This commit updates the version of ARMComputeEx to 18.11.
  - Change the name of the kernel of StridedSlice and PadLayer to StridedSliceEx and PadLayerEx to prevent duplicated name.
  - Remove the code related to fixed point(QS8, QS16).
  - Update CLKernelLibraryEx to 18.11.
  - Apply using the same context for CLKernelLibraryEx as CLScheduler.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* Change config files to build with acl v18.11

This commit changes config files to build with acl v18.11.
- Change download url of acl from v18.05 to v18.11
- Change acl to always build

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* Enable the build of neurun with v18.11

This commit enables the build of neurun with v18.11.
For detail : https://github.sec.samsung.net/STAR/nnfw/pull/3877#issuecomment-227170

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* acl benchmark patch

* Fix missing cl kernel function

This commit adds missing cl kernel function to map list.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years agoRemove acl link for neurun ineternal (#4174)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 8 Jan 2019 03:42:05 +0000 (12:42 +0900)]
Remove acl link for neurun ineternal (#4174)

Remove acl link for neurun ineternal
Becasue neurun internal is independent with acl, we can remove acl link

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoEnvironment variable to disable compile (#4172)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 8 Jan 2019 03:41:40 +0000 (12:41 +0900)]
Environment variable to disable compile (#4172)

Introduce environment variable to disable compile
Return with bad state in exection phase when compile state is NOT_COMPILED

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Move Permute Type struct to PermuteNode (#4166)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 8 Jan 2019 01:08:19 +0000 (10:08 +0900)]
[neurun] Move Permute Type struct to PermuteNode (#4166)

In order for StageGenerator to not have dependency on backends.
This commit moves Permute Type decision from StageGenerator to creation
of PermuteNode(which is created only in PermutationInsertionPass).

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Remove StageGenerator log prints (#4167)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 8 Jan 2019 01:03:15 +0000 (10:03 +0900)]
[neurun] Remove StageGenerator log prints (#4167)

Remove StageGenerator log prints since it is not useful anymore.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRevert acl cmake build (#4164)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 7 Jan 2019 08:42:11 +0000 (17:42 +0900)]
Revert acl cmake build (#4164)

Revert acl cmake build to update acl v18.11
This reverts commit 5e4e7e27d7b4a20ef300bb4577c4e14369db7e06.
This reverts commit 7d484e5c3acd4b3ad8039226a25f78d26748be0a.

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoAdd pause time between each tests in benchmark-op (#4158)
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Mon, 7 Jan 2019 02:50:12 +0000 (11:50 +0900)]
Add pause time between each tests in benchmark-op (#4158)

To reduce the impact of high temperature due to prior running,
this patch will add pause time  between each run.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years agoCorrecting assertion in transposeConv CPU implementation (#4153)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Mon, 7 Jan 2019 02:16:30 +0000 (07:46 +0530)]
Correcting assertion in transposeConv CPU implementation (#4153)

This patch will correct the position of bracket which has
been wrongly placed.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove unnecessary headers from CLReduce and CLArg ops (#4124)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Fri, 4 Jan 2019 03:09:36 +0000 (08:39 +0530)]
Remove unnecessary headers from CLReduce and CLArg ops (#4124)

This patch will remove unnecessary headers from CLReduce
and CLArg op files. And Replace CLArray to CLScheduler
since only CLScheduler header file is enough.

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRemove unused variables in CLArgMinMaxKernel file (#4127)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Fri, 4 Jan 2019 01:23:29 +0000 (06:53 +0530)]
Remove unused variables in CLArgMinMaxKernel file (#4127)

This patch will remove unused variables from
CLArgMinMaxKernel.cpp

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoBlock gtest install (#4146)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 4 Jan 2019 01:21:42 +0000 (10:21 +0900)]
Block gtest install (#4146)

- Update add_extdirectory macro for EXCLUDE_FROM_ALL setting
- Disable gtest install using add_subdirectory with EXCLUDE_FROM_ALL

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemoving ambiguity from pack gtests (#4074)
Devansh Bansal/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 3 Jan 2019 22:54:00 +0000 (04:24 +0530)]
Removing ambiguity from pack gtests (#4074)

This patch rectifies the name of one of the inputs.

Signed-off-by: b.devansh <b.devansh@samsung.com>
5 years agoUpdate docker builder script (#4141)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 3 Jan 2019 10:16:13 +0000 (19:16 +0900)]
Update docker builder script (#4141)

- Fix to handle multiple docker image build argument
- Set default image name

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUpdate cmake for revised directory structure (#4143)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 3 Jan 2019 08:38:33 +0000 (17:38 +0900)]
Update cmake for revised directory structure (#4143)

Update cmake for android and gbs build for revised directory structure

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoAdding quant8 gtest for split (#4046)
Devansh Bansal/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 3 Jan 2019 08:36:34 +0000 (14:06 +0530)]
Adding quant8 gtest for split (#4046)

This patch adds quant8 gtest for split.

Signed-off-by: b.devansh <b.devansh@samsung.com>
5 years ago[neurun] Extract Operation LowerInfo from Node (#4136)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 3 Jan 2019 06:06:36 +0000 (15:06 +0900)]
[neurun] Extract Operation LowerInfo from Node (#4136)

As `model::operation::Node` is pure node info so LowerInfo should not
be Node class. `graph::Graph` holds them instead.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRemove workaround for test script path change (#4134)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 2 Jan 2019 10:24:18 +0000 (19:24 +0900)]
Remove workaround for test script path change (#4134)

Remove workaround for test script path change because CI scripts are updated

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUpdate validation test skiplist (#4133)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 2 Jan 2019 07:10:46 +0000 (16:10 +0900)]
Update validation test skiplist (#4133)

Remove model vaildation tests in neurun skiplist

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoClean up dependencies of backends (#4112)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Wed, 2 Jan 2019 05:31:21 +0000 (08:31 +0300)]
Clean up dependencies of backends (#4112)

After resolving dependencies and converting backends to plugins, these
dependencies aren't actual anymore

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoRemove nnapi library (#4105)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Wed, 2 Jan 2019 04:13:03 +0000 (07:13 +0300)]
Remove nnapi library (#4105)

Related issue: 4103
Remove nnapi library since just one of its functions is used in
backends: better to move it into neurun/utils

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoChanges in cl kernel files related to #if defined conditions (#4106)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 2 Jan 2019 02:26:50 +0000 (07:56 +0530)]
Changes in cl kernel files related to #if defined conditions (#4106)

1. Add missing #if defined conditions
2. Remove the Vec_size from #if defined check since kernel
   should execute even if it is not passed as an preprocessor
   argument with an assumption VEC_SIZE=1 i.e., processing
   on one element at a time.

Files modified are:
1. embedding_lookup.cl
2. exp.cl
3. hashtable_lookup.cl
4. neg_tensor.cl

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoChanges in Cast op files (#4104)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 2 Jan 2019 02:23:16 +0000 (07:53 +0530)]
Changes in Cast op files (#4104)

1. Add missing comments in Cast kernel
2. Add #if defined to have error handling
3. Renaming of OFFSET_IN/SCALE_IN to offset and scale
   to remove ambiguity if it is for input or output
   due to the variable name

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd missing condition in Batch_to_space kernel for #if defined (#4101)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 2 Jan 2019 02:21:11 +0000 (07:51 +0530)]
Add missing condition in Batch_to_space kernel for #if defined (#4101)

This patch will add one more condition to check if defined(Batch_OUT).

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoCorrections in comments and adding #if defined for PRELU kernel (#4100)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 2 Jan 2019 02:20:28 +0000 (07:50 +0530)]
Corrections in comments and adding #if defined for PRELU kernel (#4100)

This patch will corrects the comments and add  #if defined for PRELU kernel

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoRevise compile state (#4086)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 2 Jan 2019 02:17:54 +0000 (11:17 +0900)]
Revise compile state (#4086)

Move lower, linearize state setting to plan

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoAdd QASYMM8 support for PReLU op (#4079)
Prasanna R/SNAP /SRI-Bangalore/Engineer/삼성전자 [Wed, 2 Jan 2019 02:17:25 +0000 (07:47 +0530)]
Add QASYMM8 support for PReLU op (#4079)

This patch adds QASYMM8 support for PReLU op.
Issue: #3884

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoArrange GTests in linux skip lists in order (#4092)
Prasanna R/SNAP /SRI-Bangalore/Engineer/삼성전자 [Mon, 24 Dec 2018 05:04:36 +0000 (10:34 +0530)]
Arrange GTests in linux skip lists in order (#4092)

Gtest in skiplist were in order before #3878
This patch arranges the same for better organizing and tracking

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoFix build for svace and coverity (#4121)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 24 Dec 2018 05:03:32 +0000 (14:03 +0900)]
Fix build for svace and coverity (#4121)

Fix build for svace and coverity: fix for renamed generated test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix ARMCompute build script bug (#4097)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 24 Dec 2018 05:03:04 +0000 (14:03 +0900)]
Fix ARMCompute build script bug (#4097)

The current version is unable to build ARMCompute from the downloaded
source.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Load backend dynamically as plugin (#3863)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 21 Dec 2018 01:08:40 +0000 (04:08 +0300)]
[neurun] Load backend dynamically as plugin (#3863)

Load backends dynamically as plugins during runtime

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoRemoving unnecessary preprocessor argument in StridedSlice op (#4102)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Fri, 21 Dec 2018 01:07:18 +0000 (06:37 +0530)]
Removing unnecessary preprocessor argument in StridedSlice op (#4102)

Since Element_size is not getting used in the kernel, hence
this patch will remove this unnecessary preprocessor argument
for Element_size

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years ago[neurun]Merge 2 for-loops of PlanBuilder::finalize (#4118)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 21 Dec 2018 01:06:19 +0000 (04:06 +0300)]
[neurun]Merge 2 for-loops of PlanBuilder::finalize (#4118)

Since these two loops are independent and loop over the same
tensor_builders, better to merge them

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years ago[neurun] CamelCase DotDumper::dump_if_needed (#4117)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Fri, 21 Dec 2018 01:01:36 +0000 (04:01 +0300)]
[neurun] CamelCase DotDumper::dump_if_needed (#4117)

Convert style of DotDumper::dump_if_needed to camel case

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoCalculate build depth before script backup (#4107)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Dec 2018 22:19:33 +0000 (07:19 +0900)]
Calculate build depth before script backup (#4107)

Calculate build depth and make depth count text file
Prepare CI update and removing backup

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoCmake for gbs build fix (#4115)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 20 Dec 2018 01:45:14 +0000 (10:45 +0900)]
Cmake for gbs build fix (#4115)

Fix gbs build failure: changed nnapi gtest directory name

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoAdd #ifndef block for VEC_SIZE in comparison op cl kernel (#4109)
Prasanna R/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 20 Dec 2018 00:55:19 +0000 (06:25 +0530)]
Add #ifndef block for VEC_SIZE in comparison op cl kernel (#4109)

This patch adds #ifndef block for VEC_SIZE in comparison op cl kernel

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoChanges req in Binary Logical op files (#4082)
Shubham Gupta/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 20 Dec 2018 00:54:55 +0000 (06:24 +0530)]
Changes req in Binary Logical op files (#4082)

1. Add op_code related comment
2. Initialize op_code variable to have error handling
3. Indentation and correction in already present commnets
   changing #if defined conditions

Signed-off-by: shubham <shub98.gupta@samsung.com>
5 years agoAdd #endif to #ifndef block in comparison_op_quantized cl (#4110)
Prasanna R/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 20 Dec 2018 00:50:50 +0000 (06:20 +0530)]
Add #endif to #ifndef block in comparison_op_quantized cl (#4110)

This patch adds  #endif to #ifndef block in comparison_op_quantized cl
Else it would be a fatal error stating unterminated #ifndef

Signed-off-by: prasannar <prasanna.r@samsung.com>
5 years agoAdding runtime asserts in TransposeConv. (#4099)
Devansh Bansal/SNAP /SRI-Bangalore/Engineer/삼성전자 [Thu, 20 Dec 2018 00:49:14 +0000 (06:19 +0530)]
Adding runtime asserts in TransposeConv. (#4099)

This patch adds shape related asserts for transpose_conv.

Signed-off-by: b.devansh <b.devansh@samsung.com>
5 years ago[neurun] Refactory call of DotDumper in compile() (#4113)
Дилшоджон Умронхонович Пошшоев/AI Tools Lab /SRR/Engineer/삼성전자 [Thu, 20 Dec 2018 00:48:58 +0000 (03:48 +0300)]
[neurun] Refactory call of DotDumper in compile() (#4113)

No need to complicate Compiler::compile with codes, that don't relate to
compilation. So, this change moves env checking DotDumber related
branching into DotDumper

Signed-off-by: Poshshoev Dilshodzhon <d.poshshoev@samsung.com>
5 years agoRename generated test (#4096)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 19 Dec 2018 00:58:29 +0000 (09:58 +0900)]
Rename generated test (#4096)

* Rename generated test

Rename generated test binary: nnapi_gtest
Rename directory including generated test: tests/nnapi
Revise directory structure

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix typo