platform/upstream/coreclr.git
7 years agoMerge pull request #11690 from wtgodbe/IlTestsFix
William Godbe [Thu, 18 May 2017 00:48:15 +0000 (17:48 -0700)]
Merge pull request #11690 from wtgodbe/IlTestsFix

Fix & re-enable failing Loader IL tests

7 years agoThe createdump utility needs RPATH (#11688)
Mike McLaughlin [Wed, 17 May 2017 22:39:25 +0000 (15:39 -0700)]
The createdump utility needs RPATH (#11688)

To find the mscordaccore reference when run as a standalone utility. Works fine when launched from coreclr.

Issue #11687

7 years agoMerge pull request #11660 from CarolEidt/LSRACleanup
Carol Eidt [Wed, 17 May 2017 21:53:50 +0000 (14:53 -0700)]
Merge pull request #11660 from CarolEidt/LSRACleanup

LSRA Cleanup

7 years agomerger takes MC file names as UTF16 names. (#11506)
Sergey Andreenko [Wed, 17 May 2017 20:34:09 +0000 (13:34 -0700)]
merger takes MC file names as UTF16 names. (#11506)

There were problems with:
1. Arabick and Japanese symbols in CLR_SH;
2. Long MC names.

We didn't see these problem before, because we moved all MC files and
renamed them with short numbers names.
Now if we want to:
1. avoid  MC files copying;
2. save information that is encoded in this names for spmi diff between
different collections
we want this fix.

7 years agoFix & re-enable failing Loader IL tests
wtgodbe [Wed, 17 May 2017 20:07:28 +0000 (13:07 -0700)]
Fix & re-enable failing Loader IL tests

7 years agoMove master to 2.1 Preview1 (#11662)
Gaurav Khanna [Wed, 17 May 2017 19:06:49 +0000 (12:06 -0700)]
Move master to 2.1 Preview1 (#11662)

7 years agoMerge pull request #11684 from pgavlin/FixPushdBalance
Pat Gavlin [Wed, 17 May 2017 17:02:31 +0000 (10:02 -0700)]
Merge pull request #11684 from pgavlin/FixPushdBalance

Remove a couple mistaken calls to popd.

7 years agoRemove a couple mistaken calls to popd.
Pat Gavlin [Wed, 17 May 2017 16:29:00 +0000 (09:29 -0700)]
Remove a couple mistaken calls to popd.

These calls were causing individual test runs to fail if other
directories were on the stack.

7 years agoFix CreateDump-related undefined reference on non-AMD64/Linux platforms (#11635)
Jonghyun Park [Wed, 17 May 2017 14:37:01 +0000 (23:37 +0900)]
Fix CreateDump-related undefined reference on non-AMD64/Linux platforms (#11635)

7 years agoMove some local declaration into exceptionhandling.cpp (#11668)
Jonghyun Park [Wed, 17 May 2017 14:20:05 +0000 (23:20 +0900)]
Move some local declaration into exceptionhandling.cpp (#11668)

* Locally declare HandlerFn in exceptionhandling.cpp
* Move ClrUnwindEx forward declaration

7 years agoRemove unused CLRVectoredExceptionHandlerShim forward declarations (#11667)
Jonghyun Park [Wed, 17 May 2017 14:19:00 +0000 (23:19 +0900)]
Remove unused CLRVectoredExceptionHandlerShim forward declarations (#11667)

7 years agoSwitch multicast delegate stub on Windows x64 to use stubs-as-il (#11624)
Jan Kotas [Wed, 17 May 2017 12:49:01 +0000 (05:49 -0700)]
Switch multicast delegate stub on Windows x64 to use stubs-as-il (#11624)

Fixes #11611. The old hand generated assembly path did not work well for structs passed by reference.

7 years agoMerge pull request #11675 from dotnet/revert-11671-PerfTrigger
William Godbe [Wed, 17 May 2017 02:19:27 +0000 (19:19 -0700)]
Merge pull request #11675 from dotnet/revert-11671-PerfTrigger

Revert "Make Perf Tests by Comment only"

7 years agoRevert "Make Perf Tests by Comment only"
William Godbe [Wed, 17 May 2017 02:19:08 +0000 (19:19 -0700)]
Revert "Make Perf Tests by Comment only"

7 years agoMerge pull request #11671 from dotnet/PerfTrigger
William Godbe [Wed, 17 May 2017 02:14:23 +0000 (19:14 -0700)]
Merge pull request #11671 from dotnet/PerfTrigger

Make Perf Tests by Comment only

7 years agoMake Perf Tests by Comment only
William Godbe [Wed, 17 May 2017 01:49:21 +0000 (18:49 -0700)]
Make Perf Tests by Comment only

7 years agoMerge pull request #11669 from dotnet/FailingTestList
William Godbe [Wed, 17 May 2017 01:36:43 +0000 (18:36 -0700)]
Merge pull request #11669 from dotnet/FailingTestList

Fix Formatting in TestsFailingOutsideOfWindows.txt

7 years agoFix Formatting in TestsFailingOutsideOfWindows.txt
William Godbe [Wed, 17 May 2017 01:36:29 +0000 (18:36 -0700)]
Fix Formatting in TestsFailingOutsideOfWindows.txt

7 years agoMerge pull request #11620 from wtgodbe/BuildToolsUpdate
William Godbe [Wed, 17 May 2017 01:35:31 +0000 (18:35 -0700)]
Merge pull request #11620 from wtgodbe/BuildToolsUpdate

Update Coreclr to 2.0.0 buildtools

7 years agoDisable opt-sensitive tests under tailcall stress and balance pushd. (#11658)
Pat Gavlin [Wed, 17 May 2017 00:28:20 +0000 (17:28 -0700)]
Disable opt-sensitive tests under tailcall stress and balance pushd. (#11658)

Just what it says on the tin.

7 years agoAllow provider deletion to be deferred until after tracing is stopped. (#11651)
Brian Robbins [Wed, 17 May 2017 00:11:47 +0000 (17:11 -0700)]
Allow provider deletion to be deferred until after tracing is stopped. (#11651)

7 years agoUpdate Coreclr to 2.0.0 buildtools
wtgodbe [Tue, 2 May 2017 23:33:41 +0000 (16:33 -0700)]
Update Coreclr to 2.0.0 buildtools

7 years agoLSRA Cleanup
Carol Eidt [Tue, 16 May 2017 22:28:59 +0000 (15:28 -0700)]
LSRA Cleanup

Remove an unused method, and clean up the comments for `checkLastUses`.

7 years agoUpdate CoreClr to preview2-25316-03 (#11650)
dotnet bot [Tue, 16 May 2017 21:53:08 +0000 (14:53 -0700)]
Update CoreClr to preview2-25316-03 (#11650)

7 years agoMerge pull request #9354 from tannergooding/math
Drew Scoggins [Tue, 16 May 2017 20:55:49 +0000 (13:55 -0700)]
Merge pull request #9354 from tannergooding/math

Adding perf tests for the single precision math functions in System.MathF.

7 years agoAdd LinkBench to BenchView
Swaroop Sridhar [Wed, 10 May 2017 09:25:16 +0000 (02:25 -0700)]
Add LinkBench to BenchView

1) Add LinkBench to the xunit-perf benchmark runs, as a scenario test
2) Some improvements to run-xunit-perf to
   - Handle tests that perform size measurement
   - Parametrization of test group
   - Tests running multiple scenarios

CoreFX testing is currently disabled because it fails in the lab
due to a path length limitation.

7 years agoUpdated the JIT/Performance/CodeQuality/Math/Functions single-precision tests to...
Tanner Gooding [Mon, 6 Feb 2017 00:08:20 +0000 (00:08 +0000)]
Updated the JIT/Performance/CodeQuality/Math/Functions single-precision tests to have the correct expected results.

7 years agoJIT/Performance/CodeQuality/Math/Functions tests to use the appropriate precision...
Tanner Gooding [Sun, 5 Feb 2017 23:46:56 +0000 (23:46 +0000)]
JIT/Performance/CodeQuality/Math/Functions tests to use the appropriate precision when printing failure messages.

7 years agoUpdating the JIT/Performance/CodeQuality/Math/Functions tests to target netcoreapp1...
Tanner Gooding [Sun, 5 Feb 2017 23:00:29 +0000 (23:00 +0000)]
Updating the JIT/Performance/CodeQuality/Math/Functions tests to target netcoreapp1.1 instead of netstandard1.4

7 years agoAdding perf tests for the single precision math functions in System.MathF.
Tanner Gooding [Sun, 5 Feb 2017 21:41:37 +0000 (13:41 -0800)]
Adding perf tests for the single precision math functions in System.MathF.

7 years agoDisable tail call stress in GH_10780 if ZapDisable is enabled. (#11649)
Pat Gavlin [Tue, 16 May 2017 18:20:37 +0000 (11:20 -0700)]
Disable tail call stress in GH_10780 if ZapDisable is enabled. (#11649)

* Disable tail call stress in GH_10780 if ZapDisable is enabled.

Tail call stress does not mix well with ZapDisable due to the issues
described in #11408.

Fixes #11648.

* Add a missing semicolon.

7 years agoMerge pull request #11037 from jashook/arm64_test_update
Jarret Shook [Tue, 16 May 2017 16:05:05 +0000 (09:05 -0700)]
Merge pull request #11037 from jashook/arm64_test_update

Turn on tests which are now passing.

7 years agoUpdate Corelib to use SetThreadErrorMode (#11625)
Jeremy Kuhne [Tue, 16 May 2017 15:40:15 +0000 (08:40 -0700)]
Update Corelib to use SetThreadErrorMode (#11625)

See #19738. Note that the enumerable is only used on Unix- but updated
it anyway. Conditioned the set/unset for ! Unix. SetErrorMode in the
PAL is a no-op, want to use the shared interop.

7 years ago[x86/Linux] Remove GetFrameFromRedirectedStubStackFrame stub (#11638)
Jonghyun Park [Tue, 16 May 2017 15:39:40 +0000 (00:39 +0900)]
[x86/Linux] Remove GetFrameFromRedirectedStubStackFrame stub (#11638)

7 years agoMerge pull request #11639 from brianrob/fix_corefx
Stephen Toub [Tue, 16 May 2017 14:35:21 +0000 (10:35 -0400)]
Merge pull request #11639 from brianrob/fix_corefx

Fix EventSource Test Breaks in CoreFX

7 years agoFix EventSource tests.
Brian Robbins [Tue, 16 May 2017 05:23:44 +0000 (22:23 -0700)]
Fix EventSource tests.

7 years agoMove PopSEHRecords into excepx86.cpp (#11626)
Jonghyun Park [Tue, 16 May 2017 05:20:34 +0000 (14:20 +0900)]
Move PopSEHRecords into excepx86.cpp (#11626)

7 years agoMerge pull request dotnet/corert#3622 from dotnet/nmirror
Jan Kotas [Mon, 15 May 2017 23:40:31 +0000 (16:40 -0700)]
Merge pull request dotnet/corert#3622 from dotnet/nmirror

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoUpdate CoreClr, CoreFx to preview2-25316-01, preview2-25316-01, respectively (#11622)
dotnet bot [Tue, 16 May 2017 04:13:10 +0000 (21:13 -0700)]
Update CoreClr, CoreFx to preview2-25316-01, preview2-25316-01, respectively (#11622)

7 years agoRemove an unnecessary binary file
Swaroop Sridhar [Tue, 16 May 2017 02:18:17 +0000 (19:18 -0700)]
Remove an unnecessary binary file

Remove a binary file that was unintentionally checked in.

7 years agoTurn on tests which are now passing.
jashook [Mon, 17 Apr 2017 23:27:37 +0000 (16:27 -0700)]
Turn on tests which are now passing.

This also adds metadata for all tests which are to be excluded
because they do not work with core.

7 years agoUse full move for byte registers stores in jumps. (#11570)
Sergey Andreenko [Mon, 15 May 2017 23:42:18 +0000 (16:42 -0700)]
Use full move for byte registers stores in jumps. (#11570)

* Use the 4-byte move for jump spilling.
The other types of spilling already use the proper move:
1) for lsra spilling it always use 4-byte move because we allocate 4-byte slots;
2) for other types it sets needsByteReg and lsra chooses correct register;

We do not apply the second approach to fixing this issue because jmp doesn't
have real uses, that can keep this requirement on. Also, it creates more strict
restrictions, that we need.

7 years agoWrite EventSource events with metadata to EventPipe (#11577)
Xiangyang (Mark) Guo [Mon, 15 May 2017 20:05:32 +0000 (13:05 -0700)]
Write EventSource events with metadata to EventPipe (#11577)

* Fix EventPipe initialization.

* rebase code with master, add prototype of event source metadata

* fix define event

* add null ptr checking

* move WriteEvent metadata serialization to managed side

* Fix enabled keywords for COMPlus_PerformanceTracing=1.

* put parameter name into metadata, use WriteToBuffer

* Write event metadata to the file.

* allocate buffer in EventPipeEvent ctor

* prevent double free

* refactor code

* AddEvent params reorder

7 years agoFix issue #11574. (#11579)
Pat Gavlin [Mon, 15 May 2017 20:04:30 +0000 (13:04 -0700)]
Fix issue #11574. (#11579)

This bug was yet another case of a transformation being performed during
remorphing that preserved a tree's value number without preserving its
associated semantics. This fix disables the problematic transformations
in morph.

7 years agoUpdate License Info (#11617)
Tarek Mahmoud Sayed [Mon, 15 May 2017 20:00:15 +0000 (13:00 -0700)]
Update License Info (#11617)

7 years agoThrow PNSE in ThreadPoolBoundHandle.BindHandle on Unixes (#11613)
Koundinya Veluri [Mon, 15 May 2017 19:47:36 +0000 (12:47 -0700)]
Throw PNSE in ThreadPoolBoundHandle.BindHandle on Unixes (#11613)

Throw PNSE in ThreadPoolBoundHandle.BindHandle on Unixes

Functional fix for https://github.com/dotnet/corefx/issues/19785

7 years agoUpdate CoreClr, CoreFx to preview2-25315-02, preview2-25315-01, respectively (#11596)
dotnet bot [Mon, 15 May 2017 15:48:36 +0000 (08:48 -0700)]
Update CoreClr, CoreFx to preview2-25315-02, preview2-25315-01, respectively (#11596)

7 years agoRemove unused code from excepx86.cpp (#11602)
Jonghyun Park [Mon, 15 May 2017 15:47:55 +0000 (00:47 +0900)]
Remove unused code from excepx86.cpp (#11602)

7 years agoAllow coniguration of sampling rate. (#11595)
Brian Robbins [Mon, 15 May 2017 15:15:51 +0000 (08:15 -0700)]
Allow coniguration of sampling rate. (#11595)

7 years agoEventPipe: Prepend variable length field sizes (#11600)
Brian Robbins [Mon, 15 May 2017 15:13:42 +0000 (08:13 -0700)]
EventPipe: Prepend variable length field sizes (#11600)

* Write the size in bytes of the stack before the stack contents.

* Specify the size of the metadata payload explicitly in the file.

7 years agoFix minidump hang under shipping lldb 3.9.1 (#11591)
Mike McLaughlin [Mon, 15 May 2017 06:56:22 +0000 (23:56 -0700)]
Fix minidump hang under shipping lldb 3.9.1 (#11591)

Issue: #11590

7 years agoUpdate CoreClr, CoreFx to preview2-25313-04, preview2-25313-02, respectively (#11575)
dotnet bot [Sat, 13 May 2017 21:32:19 +0000 (14:32 -0700)]
Update CoreClr, CoreFx to preview2-25313-04, preview2-25313-02, respectively (#11575)

7 years agoMerge pull request #11593 from brianrob/eventsource_unix
Stephen Toub [Sat, 13 May 2017 21:31:31 +0000 (17:31 -0400)]
Merge pull request #11593 from brianrob/eventsource_unix

Disable ETW calls on UNIX

7 years agoDisable ETW calls on UNIX.
Brian Robbins [Sat, 13 May 2017 18:39:10 +0000 (11:39 -0700)]
Disable ETW calls on UNIX.

7 years agoFix String.IndexOf with empty string input (#11587)
Tarek Mahmoud Sayed [Sat, 13 May 2017 06:35:49 +0000 (23:35 -0700)]
Fix String.IndexOf with empty string input (#11587)

7 years agoEnable Symbolic Rundown for EventPipe (#11582)
Brian Robbins [Sat, 13 May 2017 01:34:16 +0000 (18:34 -0700)]
Enable Symbolic Rundown for EventPipe (#11582)

7 years agoMerge pull request #11584 from dotnet/revert-11500-from-tfs
Brian Sullivan [Fri, 12 May 2017 23:49:45 +0000 (16:49 -0700)]
Merge pull request #11584 from dotnet/revert-11500-from-tfs

Revert "Merge changes from TFS"

7 years agoRevert "Merge changes from TFS"
Jarret Shook [Fri, 12 May 2017 23:47:12 +0000 (16:47 -0700)]
Revert "Merge changes from TFS"

7 years agoPut the serialization marker under its own IFDEF. (#11568)
Brian Robbins [Fri, 12 May 2017 21:42:04 +0000 (14:42 -0700)]
Put the serialization marker under its own IFDEF. (#11568)

7 years agoDon't allow specification of needStack to EventPipeProvider when creating an event...
Brian Robbins [Fri, 12 May 2017 21:14:28 +0000 (14:14 -0700)]
Don't allow specification of needStack to EventPipeProvider when creating an event. (#11571)

7 years agoUpdate CoreClr, CoreFx to preview2-25312-01, preview2-25312-03, respectively (#11544)
dotnet bot [Fri, 12 May 2017 20:23:36 +0000 (13:23 -0700)]
Update CoreClr, CoreFx to preview2-25312-01, preview2-25312-03, respectively (#11544)

7 years agoOnly call EventActivityIdControl ETW function on Windows. (#11549)
Brian Robbins [Fri, 12 May 2017 19:22:06 +0000 (12:22 -0700)]
Only call EventActivityIdControl ETW function on Windows. (#11549)

7 years agoDelete non-shared version and switch over to shared version.
Atsushi Kanamori [Fri, 12 May 2017 15:22:52 +0000 (08:22 -0700)]
Delete non-shared version and switch over to shared version.

7 years agoMerge pull request dotnet/corert#3601 from dotnet/nmirror
Jan Kotas [Fri, 12 May 2017 14:56:00 +0000 (07:56 -0700)]
Merge pull request dotnet/corert#3601 from dotnet/nmirror

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years agoMerge pull request #10972 from hqueue/arm/ryujit/lsra
Carol Eidt [Fri, 12 May 2017 18:04:23 +0000 (11:04 -0700)]
Merge pull request #10972 from hqueue/arm/ryujit/lsra

[Ryujit/ARM32] LSRA support for arm32 floating-point register allocation

7 years agoMerge pull request #11500 from dotnet-bot/from-tfs
Jarret Shook [Fri, 12 May 2017 18:00:57 +0000 (11:00 -0700)]
Merge pull request #11500 from dotnet-bot/from-tfs

Merge changes from TFS

7 years agoEventPipe Circular Buffer Support and Ability to Start/Stop Tracing (#11507)
Brian Robbins [Fri, 12 May 2017 17:51:31 +0000 (10:51 -0700)]
EventPipe Circular Buffer Support and Ability to Start/Stop Tracing (#11507)

7 years agoMerge pull request #11536 from jashook/green_arm64_ci
Jarret Shook [Fri, 12 May 2017 16:40:00 +0000 (09:40 -0700)]
Merge pull request #11536 from jashook/green_arm64_ci

[Arm64] Disable new test regressions

7 years ago[Arm64] Disable new test regressions
jashook [Thu, 11 May 2017 22:54:44 +0000 (15:54 -0700)]
[Arm64] Disable new test regressions

Disable tests based on #11533, #11534.

7 years agoRe-morph lclVar nodes after simplifying (ind (addr (lclVar))). (#11531)
Pat Gavlin [Fri, 12 May 2017 06:02:54 +0000 (23:02 -0700)]
Re-morph lclVar nodes after simplifying (ind (addr (lclVar))). (#11531)

Morph simplifies (ind (addr (lclVar))) if the type of the load matches
the type of the lclVar node. This simplification is not valid, however,
if the lclVar must be normalized upon load: in that case, the lclVar
node must be normalized appropriately as part of the transformation.
This change fixes the simplification to perform this normalization if
necessary by calling `fgMorphLclVar` on the result if the result is a
lclVar node.

Fixes issue #11508.

7 years agoUpdate CoreFx to preview2-25311-04 (#11532)
dotnet bot [Fri, 12 May 2017 03:35:41 +0000 (20:35 -0700)]
Update CoreFx to preview2-25311-04 (#11532)

7 years agoMerge pull request #11528 from sdmaclea/PR-ARM64-Add-ldar-stlr-instrs
Brian Sullivan [Fri, 12 May 2017 02:43:34 +0000 (19:43 -0700)]
Merge pull request #11528 from sdmaclea/PR-ARM64-Add-ldar-stlr-instrs

[Arm64] Add emitter support for ldar/stlr

7 years agoMerge pull request #11468 from sdmaclea/PR-ARM64-3092
Brian Sullivan [Fri, 12 May 2017 02:28:08 +0000 (19:28 -0700)]
Merge pull request #11468 from sdmaclea/PR-ARM64-3092

[Arm64] Use movn in instGen_Set_Reg_To_Imm

7 years agoRemoves unneeded Serializable attributes from enums and delegates. They can be serial...
Morgan Brown [Fri, 12 May 2017 02:24:42 +0000 (19:24 -0700)]
Removes unneeded Serializable attributes from enums and delegates. They can be serialized without attributes and this will remove noise from future serialization changes. (#11535)

7 years ago[RyuJIT/ARM32] Fix GT_NEG decomposition (#11495)
mskvortsov [Fri, 12 May 2017 01:32:11 +0000 (04:32 +0300)]
[RyuJIT/ARM32] Fix GT_NEG decomposition (#11495)

RyuJIT/ARM32: Fix GT_NEG decomposition.

7 years ago[RyuJIT/ARM32] Implement for GT_STORE_OBJ (#10721)
Sujin Kim [Fri, 12 May 2017 01:26:23 +0000 (10:26 +0900)]
[RyuJIT/ARM32] Implement for GT_STORE_OBJ (#10721)

* Implement lowering for GT_STORE_OBJ

In #10657, I commented that the messages for NYI were printed about GT_STORE_OBJ on running the CodeGenBringUpTests.

'Lowering::LowerBlockStore(GenTreeBlk* blkNode)' method implementation is just copied.
but after lowering phase, in code generation, codegenarm.cpp, below would be used.

```cpp
blkNode->gtBlkOpKind = GenTreeBlk::BlkOpKindUnroll;
```
```cpp
blkNode->gtBlkOpKind = GenTreeBlk::BlkOpKindHelper;
```

```cpp
void CodeGen::genCodeForStoreBlk(GenTreeBlk* blkOp)
{
    if (blkOp->gtBlkOpGcUnsafe)
    {
        getEmitter()->emitDisableGC();
    }
    bool isCopyBlk = blkOp->OperIsCopyBlkOp();

    switch (blkOp->gtBlkOpKind)
    {
        case GenTreeBlk::BlkOpKindHelper:
            if (isCopyBlk)
            {
                genCodeForCpBlk(blkOp);
            }
            else
            {
                genCodeForInitBlk(blkOp);
            }
            break;
        case GenTreeBlk::BlkOpKindUnroll:
            if (isCopyBlk)
            {
                genCodeForCpBlkUnroll(blkOp);
            }
            else
            {
                genCodeForInitBlkUnroll(blkOp);
            }
            break;
        default:
            unreached();
    }
    if (blkOp->gtBlkOpGcUnsafe)
    {
        getEmitter()->emitEnableGC();
    }
}
```

'genCodeForCpBlk' and 'genCodeForInitBlk' are implemented in ARM/ARM64 by MEMCPY/MEMSET
but 'genCodeForCpBlkUnroll' and 'genCodeForInitBlkUnroll' are not implemented both ARM and ARM64.

Therefore those need to implement.

* Implement NYI : GT_STORE_OBJ is needed of write barriers implementation

It was copied from ARM64 and removed codes related with gc write barrier which doesn't support on ARM.

* Implement CodeGen::genCodeForCpObj

* Refactor some codes

* Use INS_OPTS_LDST_POST_INC option for post-indexing

When structure is copied, the results of asm codes have been strange.

IN0013: 000048 ldr r3, [r1+4]
IN0014: 00004A str r3, [r0+4]
IN0015: 00004C ldr r3, [r1+4]
IN0016: 00004E str r3, [r0+4]

It needs that the index would increment or the post-indexing.

So I use INS_OPTS_LDST_POST_INC option for post-indexing when the instruction is emitted.

* Fix conflicts

* Fix conflicts and Apply #11219

I want to merge genCodeForCpObj to codegenarmarch.cpp but the function has modified in #11219.

So I decided to keep the code divided now.

In future, If modifying the function on ARM is also needed, it would be able to modify.

* Fix conflicts

* Remove NYI

* Fix genCountBits assertion

7 years agoComment per review
Steve MacLean [Thu, 11 May 2017 23:59:50 +0000 (19:59 -0400)]
Comment per review

7 years agoFix build.
Brian Robbins [Thu, 11 May 2017 01:04:24 +0000 (18:04 -0700)]
Fix build.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
7 years ago[RyuJIT/ARM32] Fix assertion in 'unreached' when using emitIns_R_L (#11486)
Sujin Kim [Thu, 11 May 2017 23:13:33 +0000 (08:13 +0900)]
[RyuJIT/ARM32] Fix assertion in 'unreached' when using emitIns_R_L (#11486)

* [RyuJIT/ARM32] Fix assertion in 'unreached'

Now, All of CodeGenBringUpTests have failed.

message : Assertion failed 'unreached' in 'DomainNeutralILStubClass:IL_STUB_PInvoke(ref)'

I found the problem was caused by #11377 that 'genCodeForTreeNode' merged to codegenarmarch.cpp.

7 years agoLinkBench: Report reduction as a ratio.
Swaroop Sridhar [Thu, 11 May 2017 20:49:17 +0000 (13:49 -0700)]
LinkBench: Report reduction as a ratio.

Report the linker size reduction metric as a ratio
(linked filesize / unlinked filesize) instead of as a percentage.

7 years agoMerge pull request #11423 from jashook/arm64_live_tests
Jarret Shook [Thu, 11 May 2017 22:26:44 +0000 (15:26 -0700)]
Merge pull request #11423 from jashook/arm64_live_tests

Windows Arm64 - Build/Run tests in CI

7 years agoWindows Arm64 - Build/Run tests in CI
jashook [Fri, 5 May 2017 18:10:12 +0000 (11:10 -0700)]
Windows Arm64 - Build/Run tests in CI

Build tests with arm64 runs and upload/run them to the arm64 test
machines.

7 years agoHandle ADC in x86 unwindLazyState (#11527)
Michelle McDaniel [Thu, 11 May 2017 19:28:28 +0000 (12:28 -0700)]
Handle ADC in x86 unwindLazyState (#11527)

When we add PGO instrumentation to coreclr, the instrumentation injects
PUSH, MOV, ADD, ADC, POP into the prolog to mark the function entry. This
causes a crash because we do not currently handle ADC instructions in
unwindLazyState. This change adds support for ADC, which uses the normal
DecodeRM code we already have in place.

7 years agoAdd back private BadImageFormatException constructor called by the VM (#11523)
Jan Kotas [Thu, 11 May 2017 18:45:38 +0000 (11:45 -0700)]
Add back private BadImageFormatException constructor called by the VM (#11523)

Also removed rethrowing of an exception inside AssemblyName.GetAssemblyName that sometimes resulted into two identical exceptions getting nested into each other.

Fixes #11499

7 years agoFix AssemblyName version (#11505)
Sepideh Khoshnood [Thu, 11 May 2017 18:45:06 +0000 (11:45 -0700)]
Fix AssemblyName version (#11505)

* Fix AssemblyName.FullName

* Use canonicalized version instead of Version.ToString

7 years ago[Arm64] Fixup stlr instrs
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Thu, 11 May 2017 18:01:49 +0000 (18:01 +0000)]
[Arm64] Fixup stlr instrs

7 years ago[Arm64] Add emitter support for ldar/stlr
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Wed, 10 May 2017 17:50:25 +0000 (17:50 +0000)]
[Arm64] Add emitter support for ldar/stlr

7 years ago[Arm64] Fix instGen_Set_Reg_To_Imm per review
Steve MacLean, Qualcomm Datacenter Technologies, Inc [Thu, 11 May 2017 15:55:38 +0000 (15:55 +0000)]
[Arm64] Fix instGen_Set_Reg_To_Imm per review

7 years agoMerge pull request #11437 from mjsabby/eventpipetoprofilerapi
Noah Falk [Thu, 11 May 2017 03:29:30 +0000 (20:29 -0700)]
Merge pull request #11437 from mjsabby/eventpipetoprofilerapi

Add dynamic method unload event to Profiler API

7 years agoThis change has the following improvements to LinkBench
Swaroop Sridhar [Wed, 10 May 2017 22:25:53 +0000 (15:25 -0700)]
This change has the following improvements to LinkBench

1. Move the testing to the latest version of ILLink package
   (for all benchmarks except for Roslyn, which is still on netcoreapp1.1)
2. Support for LinkBench to run individual benchmarks in the suite --
   helps local testing.
3. Support for running without clean, cloning, build etc --
   for local runs during continuous development.
4. Support to obtain the correct version(s) of DotNet CLI required to run
   the benchmarks
5. Get-Crossgen.ps1 is required to crossgen MusicStore binaries (before/after linking).
   Since it was recently dropped from JitBench repo, it is added to linkBench as an asset.
6. Add the --perf:runid parameter to generate output file names suitable
   to upload the results to BenchView.

7 years agoRemove eventpipe stuff left from prev commit
Mukul Sabharwal [Thu, 11 May 2017 01:41:13 +0000 (18:41 -0700)]
Remove eventpipe stuff left from prev commit

7 years agoadd prebuilt file
Mukul Sabharwal [Thu, 11 May 2017 01:39:37 +0000 (18:39 -0700)]
add prebuilt file

7 years agoRemove EventPipeProfiler due to time constraints
Mukul Sabharwal [Thu, 11 May 2017 01:37:58 +0000 (18:37 -0700)]
Remove EventPipeProfiler due to time constraints

7 years agoAllow multiple SetData calls on AppDomain (#11496)
Alex Ghiondea [Wed, 10 May 2017 23:45:01 +0000 (16:45 -0700)]
Allow multiple SetData calls on AppDomain (#11496)

* Allow multiple SetData calls on AppDomain
* Remove restriction from GetData and remove now-dead code Locate
* Remove LoaderOptimization check since it is not used on CoreCLR

7 years agoRe-Factor EventSource to Support Writing to EventPipe (#11435)
Brian Robbins [Wed, 10 May 2017 22:11:28 +0000 (15:11 -0700)]
Re-Factor EventSource to Support Writing to EventPipe (#11435)

Re-Factor EventSource to Support Writing to EventPipe.

7 years agoMerge pull request #11478 from sdmaclea/PR-ARM64-9711
Brian Sullivan [Wed, 10 May 2017 20:50:19 +0000 (13:50 -0700)]
Merge pull request #11478 from sdmaclea/PR-ARM64-9711

[Arm64] Support GTF_IND_VOLATILE

7 years agoAdd version.txt to the coreclr transport package (#11497)
Jose Perez Rodriguez [Wed, 10 May 2017 20:23:28 +0000 (13:23 -0700)]
Add version.txt to the coreclr transport package (#11497)

* Add version.txt to the coreclr transport package

* PR Feedback

7 years agoMerge pull request #11448 from DrewScoggins/AddPriority
Drew Scoggins [Wed, 10 May 2017 20:07:12 +0000 (13:07 -0700)]
Merge pull request #11448 from DrewScoggins/AddPriority

Launch perf process with high priority

7 years agoRenable building frankenjit
dotnet-bot [Wed, 10 May 2017 19:43:11 +0000 (12:43 -0700)]
Renable building frankenjit

[tfs-changeset: 1657926]

7 years ago[ARM/Linux] Enable build with FEATURE_DBGIPC=0 (#11254)
Jonghyun Park [Wed, 10 May 2017 19:32:33 +0000 (12:32 -0700)]
[ARM/Linux] Enable build with FEATURE_DBGIPC=0 (#11254)

* [ARM/Linux] Enable build with FEATURE_DBGIPC=0

* Replace HAVE_ALIGNED_MALLOC with SUPPORT_LOCAL_DEBUGGING