Viktor Hofer [Tue, 16 Apr 2019 11:59:00 +0000 (13:59 +0200)]
Update SDK requirement in windows-instructions
Commit migrated from https://github.com/dotnet/corefx/commit/
e2ecd2c33aed216f9a1062044aedf10e25ee8ca4
Viktor Hofer [Tue, 16 Apr 2019 07:19:21 +0000 (09:19 +0200)]
Upgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)
* Upgrade SDK to 3.0
* Remove asp and desktop framework references
* Manual darc update from build '
20190415.1'
* Suppress type overlap with ns2.1
* Make SDK use output of core-setup for both ref and runtime
SDK is ignoring RuntimeFrameworkVersion for ref packs. Set TargetingPackVersion
on KnownFrameworkReference instead.
https://github.com/dotnet/sdk/issues/3129
Commit migrated from https://github.com/dotnet/corefx/commit/
66bcc2d2b1248ed5384393adf5f3a647d18b75f1
Grant [Tue, 16 Apr 2019 01:24:04 +0000 (18:24 -0700)]
Ref Assembly and Units for Span.Trim (dotnet/corefx#35576)
* Units for Trim
* Add ref assembly
* Bug
* Add char units
* Bugs
* CR fixes - 1
* CR fixes - 2
* CR fixes - 3
* CR fixes - 4
* CR fixes - 5
* Revert formatting
* unfo formatting
* Get MemberData working
* Normalize ref
* Manual revert changes
* CR fixes
* Undo code cleanup
* Fixes
* Update ref
* Update ref
* Update ref
* Move memory tests
* Revert StringTests
* Remove redundant unit code
* Add missing refs
* Bug
* dotnet msbuild /t:GenerateReferenceSource
* Revert unintended changes
* POC : Check if fix works
* Fix units
* Revert temp test
* Update ApiCompatBaseline.uapaot.txt
Commit migrated from https://github.com/dotnet/corefx/commit/
2191763a765654710df5317dc65dc7cd935bc8c1
Tomas Weinfurt [Mon, 15 Apr 2019 22:15:32 +0000 (15:15 -0700)]
add test for lower casing header name logic (dotnet/corefx#36708)
* add test for 35164
* update SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2
* fix uwp tests
* change port from 123 to 443
Commit migrated from https://github.com/dotnet/corefx/commit/
4e3b46c22cec88a1f0deaa2f594634e5553412e1
Steve Harter [Mon, 15 Apr 2019 21:44:04 +0000 (14:44 -0700)]
Remove null coalescing assignment operator to avoid build-from-source compile issues (dotnet/corefx#36890)
Commit migrated from https://github.com/dotnet/corefx/commit/
f78e9881bd8ef1def0227569d822693b944378a7
Omair Majid [Mon, 15 Apr 2019 20:55:02 +0000 (16:55 -0400)]
Close the socket if bind() fails (dotnet/corefx#36769)
When using a socket with bind() and bind fails, close the socket to free
up the resources associated with the socket.
Commit migrated from https://github.com/dotnet/corefx/commit/
03ae543d4da4e539b9915a5f38f36a69739fa9d9
Steve Harter [Mon, 15 Apr 2019 17:58:03 +0000 (10:58 -0700)]
Json deserializer collection perf improvements by avoiding boxing (dotnet/corefx#36865)
Commit migrated from https://github.com/dotnet/corefx/commit/
6bfaf4116b5180c857bf6ad531f0655fd57c5eef
Santiago Fernandez Madero [Mon, 15 Apr 2019 17:55:42 +0000 (12:55 -0500)]
Remove myget publish entirely (dotnet/corefx#36886)
Commit migrated from https://github.com/dotnet/corefx/commit/
d601d2e7602c9dbb6ae0d95c450bce2db027f78d
Filip Navara [Mon, 15 Apr 2019 16:46:18 +0000 (18:46 +0200)]
Add guard for runtimes that support large arrays (dotnet/corefx#36883)
Commit migrated from https://github.com/dotnet/corefx/commit/
679dba7531d3be10b387203c9a9f350f39ea3a8a
Santiago Fernandez Madero [Mon, 15 Apr 2019 16:03:58 +0000 (11:03 -0500)]
Restore internal tools using .net core restore (dotnet/corefx#36840)
* Restore internal tools using .net core restore
* Restore internal tools from dnceng-internal
Bump TestILC version
* Manual Darc update from build '
20190414.2'
* Add buildExtraArguments to common
Commit migrated from https://github.com/dotnet/corefx/commit/
10d7d6f812295a572eb148aedb19efd2f96fbe17
Hugh Bellamy [Mon, 15 Apr 2019 14:15:24 +0000 (15:15 +0100)]
Add more number converter tests (dotnet/corefx#36653)
* Add more number converter tests
* Fix if bug in BaseNumberConverter
* Address PR feedback
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
25c10204a69c09afd0701740d1555eba04496c71
dotnet-maestro-bot [Mon, 15 Apr 2019 04:10:26 +0000 (21:10 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27612-00, beta-27612-00, respectively (dotnet/corefx#36867)
Commit migrated from https://github.com/dotnet/corefx/commit/
81e0e2cb79e272e6e270c6562017b64f9c773e99
Tom Deseyn [Mon, 15 Apr 2019 01:48:56 +0000 (03:48 +0200)]
SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling (dotnet/corefx#36721)
* SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling
DangerousGetHandle was used here for performance. SafeHandle marshalling is
faster now, and preferable to avoid using invalid handles.
* Socket.Windows: replace DangerousGetHandle with SafeHandle marshalling for async operations
Commit migrated from https://github.com/dotnet/corefx/commit/
88b6ebe8faaadb027c1378132dc9767c13912159
David Shulman [Mon, 15 Apr 2019 01:34:25 +0000 (18:34 -0700)]
Cleanup SocketOptionNameTest (dotnet/corefx#36864)
One of the oldest issues dotnet/corefx#4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.
At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.
As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.
Closes dotnet/corefx#29929
Closes dotnet/corefx#21327
Closes dotnet/corefx#4887
Commit migrated from https://github.com/dotnet/corefx/commit/
f389a14d375ef90f971bc15095b925f73845a7d3
Tanner Gooding [Mon, 15 Apr 2019 00:46:34 +0000 (17:46 -0700)]
Remove IgnoredTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 types (dotnet/corefx#36866)
Commit migrated from https://github.com/dotnet/corefx/commit/
7336f57f745e7399803902efca8fd085ff6ca326
Ganbarukamo41 [Sun, 14 Apr 2019 23:34:34 +0000 (00:34 +0100)]
Implement IEquatable to Memory and ReadOnlyMemory (dotnet/corefx#36497)
* Implement IEquatable to Memory and ReadOnlyMemory
* Add equality tests using IEquatable of ReadOnlyMemory and Memory
* Fix and add tests for Memory and ReadOnlyMemory
* Fixed where IEquatable interface tests were using object.Equals(object) instead of T.Equals(T)
* Added IEquatable interface tests for Memory of different types (char, string)
* Fix IEquatable tests for Memory and ReadOnlyMemory
* Fix tests that were missed in the previous commit (IEquatable tests calling object.Equals(object))
* Should use ReadOnlyMemory in ReadOnlyMemory tests
* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Remove baselines added to System.Runtime by mistake
* Add baselines to System.Memory
* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Add removed baselines to System.Runtime again
Commit migrated from https://github.com/dotnet/corefx/commit/
68920bb0764fb13257f710f44dd08e85e4a35c7c
Krzysztof Wicher [Sun, 14 Apr 2019 19:31:59 +0000 (12:31 -0700)]
Fix build (dotnet/corefx#36862)
Commit migrated from https://github.com/dotnet/corefx/commit/
822da3133d02da072843ffe7715c6af29d0c4192
Santiago Fernandez Madero [Sun, 14 Apr 2019 17:31:01 +0000 (12:31 -0500)]
Remove myget feeds (dotnet/corefx#36797)
* Remove myget feeds
* Bump compression testdata package version
Commit migrated from https://github.com/dotnet/corefx/commit/
0aa6ccc261165e9e045a6aab6218f3e71f99e0f4
David Shulman [Sun, 14 Apr 2019 03:16:43 +0000 (20:16 -0700)]
Improve HttpClient POST with REDIRECT tests (dotnet/corefx#36848)
This PR is similar to dotnet/corefx#36801 and dotnet/corefx#36828 which improved upload tests stability.
Modify the POST with REDIRECT test to use the VerifyUpload endpoint which avoids
having to echo back the large request body.
Closes dotnet/corefx#36220
Commit migrated from https://github.com/dotnet/corefx/commit/
52d4723aaa8e561a6f36589a6d1e112287c0308b
Steve MacLean [Sun, 14 Apr 2019 01:57:06 +0000 (21:57 -0400)]
Add Assembly.LoadWithPartialName cases (dotnet/corefx#36803)
* Add Assembly.LoadWithPartialName cases
Cover hole reported in dotnet/coreclrdotnet/corefx#19817
* Verify argument parameter name
* Disable new test on .NetFramework
Commit migrated from https://github.com/dotnet/corefx/commit/
5ae3c5655cd84bf3c7f9568477153642fdd7c95e
Steve MacLean [Sun, 14 Apr 2019 01:56:49 +0000 (21:56 -0400)]
Contextual reflection (dotnet/corefx#36845)
* Add ContextualReflection facade
* Update ApiCompatBaseline.uapaot
Commit migrated from https://github.com/dotnet/corefx/commit/
3e2be4796df626d7f4e73c0018992c4f4aa60627
Omair Majid [Mon, 8 Apr 2019 14:40:49 +0000 (10:40 -0400)]
Fix bad null check in pal_dsa.c
The code calls DSA_new() and then, only after assigning the value from
DSA_new to a pointer, tries to check that the pointer was not null.
Assigning to a null pointer leads to undefined behaviour and a compiler
can assume that assignment-to-a-null-pointer wont happen. Subsequently,
the compiler can remove the entire check because the pointer can't be
null.
Fix that by:
1. Moving the check for whether the pointer is null before dereferncing
the pointer.
2. Checking the return value of DSA_new() spearately after it has been
called.
Commit migrated from https://github.com/dotnet/corefx/commit/
e7fd1669eafafd16de85cd90b558d54abb3a3343
Steve Harter [Sat, 13 Apr 2019 22:32:49 +0000 (15:32 -0700)]
JsonSerializerOptions API update and ignore property features (dotnet/corefx#36776)
Commit migrated from https://github.com/dotnet/corefx/commit/
b06250eb9ef50bca50cf7676e87753dbd8b5470a
dotnet-maestro[bot] [Sat, 13 Apr 2019 18:53:57 +0000 (11:53 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36816)
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73
- Also react to changes in the UTF-8 transcoding logic (dotnet/corefx#36712)
Commit migrated from https://github.com/dotnet/corefx/commit/
4c3d4a083488b9f89676926a8b75aa5f7572f67f
Krzysztof Wicher [Sat, 13 Apr 2019 17:46:05 +0000 (10:46 -0700)]
address feedback from 36775 (dotnet/corefx#36839)
Commit migrated from https://github.com/dotnet/corefx/commit/
c3981ca2455f8a6593301bac1adb363d02934954
Hugh Bellamy [Sat, 13 Apr 2019 16:52:14 +0000 (17:52 +0100)]
Fix LsaOpenPolicy interop definition
* Move Lsa handles to Interop code
* Fix implementation of LsaOpenPolicy
* Move LSA_STRING and LSA_UNICODE_STRING to Advapi32
* Consolidate LSA_UNICODE_STRING and UNICODE_STRING
Commit migrated from https://github.com/dotnet/corefx/commit/
f5e2679e76c102aea8218ae290ffb7f4d97e9cc2
Filip Navara [Sat, 13 Apr 2019 16:07:10 +0000 (18:07 +0200)]
Fix encoding of Digest authentication headers (dotnet/corefx#36627)
* Fix encoding of Digest authentication headers for servers that don't understand RFC 5987 encoding
* Quote-prefix special characters when encoding Digest headers
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
cce7870129dcca472f4e6108e21e87bc9573b8d2
Paito Anderson [Sat, 13 Apr 2019 15:28:21 +0000 (11:28 -0400)]
Allow cookies with spaces in the name (dotnet/corefx#36566)
* Allow cookies with spaces in the name
* Apply suggestions from code review
Co-Authored-By: PaitoAnderson <pj.paito@gmail.com>
* Added supporting HttpClient functional cookie test
* Updated UWP cookie class and added additional tests
* Prevent cookies with spaces at the start or end
* Forgot UWP
* Fix could allocate on trim
Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Better cookie space start/end check
Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Bring checks into line
Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Skip test on .net framework
* Skip additional tests on .net framework
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
8a22438a1af870cdd04eaf798b155b8a1ab04cb4
Filip Navara [Sat, 13 Apr 2019 15:19:53 +0000 (17:19 +0200)]
Read system proxy information on macOS (dotnet/corefx#36177)
* Read system proxy information on macOS
* Replace CFRunLoopRemoveSource with CFRunLoopSourceInvalidate to mimic recommended flow from Chromium / WebKit
Commit migrated from https://github.com/dotnet/corefx/commit/
2aa2518a47c541148e2dc3f9d040942e44395acd
Alexander Köplinger [Sat, 13 Apr 2019 04:47:30 +0000 (06:47 +0200)]
Fix TypeInfoTests.GenericParameterConstraints() test (dotnet/corefx#36832)
It was a Theory instead of a Fact and the method parameter wasn't being used.
Commit migrated from https://github.com/dotnet/corefx/commit/
1a83ff9b6d6d3406a6ef800dbe2bc7a74e4d5d3c
Maira Wenzel [Sat, 13 Apr 2019 04:46:42 +0000 (21:46 -0700)]
overwrite -> overwriteFiles (dotnet/corefx#36831)
Commit migrated from https://github.com/dotnet/corefx/commit/
326246059f3e7422e39dd71f2e1541c0288777d0
Charles Stoner [Sat, 13 Apr 2019 04:45:11 +0000 (21:45 -0700)]
Port ErrObject and CreateProjectError (dotnet/corefx#36808)
* Port ErrObject and CreateProjectError
* PR feedback
* Add FilterDefaultMessage test
Commit migrated from https://github.com/dotnet/corefx/commit/
e2ab05d35f00f9cd9a92a94284698cc241f8380d
Layomi Akinrinade [Sat, 13 Apr 2019 01:44:18 +0000 (21:44 -0400)]
Add support for generic interface-based collections in JsonSerializer (dotnet/corefx#36756)
* Add support for generic interface-based collections in JsonSerializer
Specifically, add enumerable converters for:
* IEnumerable<T>
* ICollection<T>
* IList<T>
* IReadOnlyCollection<T>
* IReadOnlyList<T>
This partially addresses https://github.com/dotnet/corefx/issues/36643
* Address review comments
* Add serialization tests for generic interface collection as members of class objects
Commit migrated from https://github.com/dotnet/corefx/commit/
cc01ec9a781c4af5afd495c5b80a1f7d9616bed2
Krzysztof Wicher [Sat, 13 Apr 2019 01:23:31 +0000 (18:23 -0700)]
CipherSuitePolicy implementation (dotnet/corefx#36775)
* CipherSuitePolicy implementation (Linux)
* SSL_CIPHER_find
* do not call TLS1.3 APIs on platforms which don't support it
* Non-TLS1.3 specific tests are skipped when not enough cipher suites is enabled
* clean ups
* attempt to fix OSX
* another attempt to fix OSX
* missing define
* address some feedback, try to fix test failures
* portable build fix
* do not call old set ciphers API when only TLS 1.3 is requested
* apply feedback
* add OSX implementation
* fixes to OSX
* explicit convert
* use explicit SSLCipherSuite instead of uint16_t
* random change to trigger CI
* s/unsafe/fixed
* fixes
* random change to trigger CI
* client ordering does not have to win
* tests: AllowedCipherSuites, new CipherSuitesPolicy(null)
* run AllowedCipherSuites tests only when CSP is supported
* add summary on CipherSuitesPolicy
* address feedback
* move OS specific files to CipherSuitesPolicyPal
* FALLBACK->LIGHTUP and remove local_
* do not call 1.1.1 function on non-portable build when lower openssl version is installed
* get rid of warning that arg is unused
* make CipherSuitesPolicyPal public members internal
Commit migrated from https://github.com/dotnet/corefx/commit/
07f443b6c9f27dd050ffb5eb3afa126a2b1bdddd
Jeremy Barton [Sat, 13 Apr 2019 00:37:52 +0000 (17:37 -0700)]
Add JsonElement.Clone to make a long-term persistable copy
Commit migrated from https://github.com/dotnet/corefx/commit/
cd020c11b563b51f439324bcefc559d1408f4e09
David Shulman [Sat, 13 Apr 2019 00:27:40 +0000 (17:27 -0700)]
Improve WebClient upload tests stability (dotnet/corefx#36828)
This PR is a follow-up to PR dotnet/corefx#36801 which improved HttpClient tests stability.
Some of the WebClient tests were failing with WebExceptions being caused by the
Azure remote endpoint returning 500 status code. Similar to the fixes done to
the HttpClient tests, this PR updates some of the WebClient upload tests to use
the VerifyUpload endpoint which doesn't have to echo back the request body payload.
Some of the WebClient tests upload more complex multi-part formats and can't be
easily changed to use the VerifyUpload endpoint. But those tests aren't using large
data sets so it should be ok.
Closes dotnet/corefx#36226
Commit migrated from https://github.com/dotnet/corefx/commit/
00e9390eb0e9b95a410bd3e91b2c58cf9ec85d95
Anirudh Agnihotry [Fri, 12 Apr 2019 19:07:39 +0000 (12:07 -0700)]
embed generated files into pdbs (dotnet/corefx#36825)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1730e55ba3e1a4d2ae22d052fe17694d2c69379
David Fowler [Fri, 12 Apr 2019 18:55:20 +0000 (11:55 -0700)]
This should fix the flaky test (dotnet/corefx#36826)
- The pool in the test wasn't being used (This was changed in a previous commit)
- Use the DisposeTrackingBufferPool to make sure we allocated the number of segments we expect
Commit migrated from https://github.com/dotnet/corefx/commit/
6eeed98a406adf281649e94546975d52c72465e6
Eric StJohn [Fri, 12 Apr 2019 13:20:07 +0000 (06:20 -0700)]
Update zlib-intel to v1.2.11.1_jtkv6.3 (dotnet/corefx#36795)
* inflate: handle windowBits == 16
* deflate_medium: add dist -1 to hash even for long matches
This fixes an issue where a repeat sequence longer than 258 would be
encoded using longer distance values after the first match.
* deflate_medium: avoid emitting a suboptimal literal in the restart case
When we load new data into the window, we invalidate the next match, in
case the match would improve. In this case, the hash has already been
updated with this data, so when we look for a new match it will point
it back at itself. As a result, a literal is generated even when a
better match is available.
This avoids that by catching this case and ensuring we're looking at the
past.
Commit migrated from https://github.com/dotnet/corefx/commit/
6322a406f88e854c5b827ab838f988f8992048f8
Krzysztof Wicher [Fri, 12 Apr 2019 13:19:51 +0000 (06:19 -0700)]
remove copy of Interop.GetCurrentThreadId.cs (dotnet/corefx#36807)
Commit migrated from https://github.com/dotnet/corefx/commit/
46f57de34bc4df79e50911dce6ec9abb4f35b553
David Fowler [Fri, 12 Apr 2019 11:42:34 +0000 (04:42 -0700)]
Get more information about a flaky test (dotnet/corefx#36810)
Commit migrated from https://github.com/dotnet/corefx/commit/
f843b9ca2ecdc1b3f52d6ab9dfb094689281dee3
Stephen Toub [Fri, 12 Apr 2019 02:11:51 +0000 (22:11 -0400)]
Update Version comparison operator tests (dotnet/corefx#36799)
* Update Version comparison operator tests
Better validate the operators, and update the tests now that the operators won't throw for null.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
599955ac3c2c6625c7baae46be301767b1f074d2
Kevin Jones [Fri, 12 Apr 2019 01:20:23 +0000 (21:20 -0400)]
Remove octet string wrapping from EnvelopedCms
Removes the octet string wrapping from EnvelopedCms encrypt if the content type is id-data.
Commit migrated from https://github.com/dotnet/corefx/commit/
2cd5d08337a7c5fadf90c7d2a571cc18709601d2
David Shulman [Fri, 12 Apr 2019 00:31:25 +0000 (17:31 -0700)]
Improve HttpClient POST tests stability (dotnet/corefx#36801)
Several of the HttpClient POST scenario tests were failing with HTTP status code 500. This was caused
by the Azure remote endpoint generating OutOfMemoryException at times. The tests are sending
large amounts of request body data to the Echo endpoint. That endpoint will respond back with all
the headers and request body data serialized into a JSON payload. The OOM exceptions were
coming from the Newtonsoft JSON serialization code currently used by the server endpoint.
These tests don't really require that the request body data be sent back. The purpose of the tests is
to verify that the request body payload was correctly sent by the client. We already have an endpoint,
VerifyUpload, that can do that without echo'ing back the large request body data.
This PR modifies the tests to use that endpoint. This should mitigate the OOM exceptions
currently being generated in the server-side code. Additional mitigations/fixes will be done later on the server-side code to improve robustness. But fixing the tests to be more streamlined is goodness and will result in these tests being faster and more stable.
Closes dotnet/corefx#36782
Commit migrated from https://github.com/dotnet/corefx/commit/
288ce93787799052705814876d6e5ccb0523797d
Marco Rossignoli [Thu, 11 Apr 2019 20:53:08 +0000 (22:53 +0200)]
Fixes race in NamespaceCache (dotnet/corefx#36699)
* fix race
* address PR feedback
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ce62a086814fdfecea1d6ba6657c3fb88763e1d6
dotnet-maestro[bot] [Thu, 11 Apr 2019 19:37:46 +0000 (12:37 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36788)
* Update dependencies from https://github.com/dotnet/coreclr build
20190410.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27610-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27610-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27610-72
* Regenerating the System.Runtime.Intrinsics ref assembly to pick up the API changes.
* Update Range.GetOffsetAndLength Contract
* Fix return Tuple fields names
* Fix apicompat failure with Range type
Commit migrated from https://github.com/dotnet/corefx/commit/
2cae2dbe1f8b687b15c5e7e3acffb0942524cfe4
Afsaneh Rafighi [Thu, 11 Apr 2019 18:24:31 +0000 (11:24 -0700)]
Merge pull request dotnet/corefx#36735 from Wraith2/sqlfix-envchangepool
SqlClient fix SqlEnvChangePool thread safety bug
Commit migrated from https://github.com/dotnet/corefx/commit/
af562e84b8b5a4a335ceb5006886a6c42c1c023e
Max Kerr [Thu, 11 Apr 2019 18:23:45 +0000 (11:23 -0700)]
HTTP/2 Request Cancellation (dotnet/corefx#35118)
HTTP/2 cancellation support, plus improvements to outgoing write buffering.
Commit migrated from https://github.com/dotnet/corefx/commit/
d6e36e4ecb0d004de54eb7bdf0ed6cdcb042e3c9
Viktor Hofer [Thu, 11 Apr 2019 17:43:27 +0000 (19:43 +0200)]
Remove NETSTandard Test Suite (dotnet/corefx#36784)
Commit migrated from https://github.com/dotnet/corefx/commit/
d26c6cdd6895e8df5ac665ce23f20bbaa42a2a9f
Alexander Köplinger [Thu, 11 Apr 2019 17:07:13 +0000 (19:07 +0200)]
System.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available (dotnet/corefx#36785)
* System.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available
These tests failed on Xamarin.iOS since the linker strips out most Debugger*
attributes in release builds. We can gracefully handle this case and simply
skip the tests instead.
* Use ConditionalFact/Theory
Commit migrated from https://github.com/dotnet/corefx/commit/
7b7345665ec28a85084b3ad2932e03f7641d6151
Eric StJohn [Thu, 11 Apr 2019 15:42:19 +0000 (08:42 -0700)]
Fix -allconfigurations build on linux (dotnet/corefx#36780)
* Fix -allconfigurations build on linux
* Fix whitespace
Commit migrated from https://github.com/dotnet/corefx/commit/
80672656a723818863ae0021370cc4f9ddfbdc73
Michal Strehovský [Thu, 11 Apr 2019 15:42:00 +0000 (17:42 +0200)]
Revert "Run IBCMerge on Linux build (dotnet/corefx#36763)" (dotnet/corefx#36791)
This reverts commit dotnet/corefx@
ef2ee1291ea6140cb462ead8b4cc86a762b58f64.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e843314e1dbd3b3f26abb1f285349be8920cce4
Hugh Bellamy [Thu, 11 Apr 2019 12:46:33 +0000 (13:46 +0100)]
Remove NativeMethods from System.IO.Ports (dotnet/corefx#36740)
* Remove NativeMethods from System.IO.Ports
Commit migrated from https://github.com/dotnet/corefx/commit/
e4dbfa4cbb0ff67efab2bf4214f34125892df986
Michal Strehovský [Thu, 11 Apr 2019 12:08:14 +0000 (14:08 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36763)
* Restores IBC data for both Linux and Windows on all platforms
* Chooses the right IBC data based on the target OS
* When target OS isn't anything specific (like, e.g. System.Linq and other assemblies that are not OS specific), embeds Windows IBC data
Commit migrated from https://github.com/dotnet/corefx/commit/
ef2ee1291ea6140cb462ead8b4cc86a762b58f64
Tom Deseyn [Thu, 11 Apr 2019 09:20:43 +0000 (11:20 +0200)]
SocketAsyncEngine.Unix: use ConcurrentDictionary to get rid of lock for context lookup (dotnet/corefx#36358)
Commit migrated from https://github.com/dotnet/corefx/commit/
1c881ce4e49d723891d10ffabb171dc07b75972e
Levi Broderick [Thu, 11 Apr 2019 07:01:56 +0000 (00:01 -0700)]
Add ref asms and unit tests for string.GetPinnableReference (dotnet/corefx#36777)
Commit migrated from https://github.com/dotnet/corefx/commit/
4672a7b5d28070bd3dc8431887b3474a04249ccf
Alan Parr [Wed, 10 Apr 2019 22:45:45 +0000 (23:45 +0100)]
Removed FEATURE_NOTIFYPROPERTYCHANGED checks (dotnet/corefx#36774)
Commit migrated from https://github.com/dotnet/corefx/commit/
1ae46a2b2a7719e0fd8d30b5df14b7e181d1c963
Levi Broderick [Wed, 10 Apr 2019 19:24:55 +0000 (12:24 -0700)]
Add Win10 19H1 platform detection (dotnet/corefx#36767)
Commit migrated from https://github.com/dotnet/corefx/commit/
dc63fa0a60e68174f423fe5316e323c6635c08fe
Santiago Fernandez Madero [Wed, 10 Apr 2019 18:59:29 +0000 (11:59 -0700)]
Fix outerloop linux build missing container resource (dotnet/corefx#36773)
Commit migrated from https://github.com/dotnet/corefx/commit/
3773daaaba958e65f87e54fc0ec64c4a02282282
Stephen Toub [Wed, 10 Apr 2019 16:51:50 +0000 (12:51 -0400)]
Address PR feedback for nullability docs
Commit migrated from https://github.com/dotnet/corefx/commit/
99943e1060fcb45eae398a04076819e2939716dd
Paul Buonopane [Wed, 10 Apr 2019 14:10:36 +0000 (10:10 -0400)]
Fix docs on System.Text.Json.JsonElement.GetString
Commit migrated from https://github.com/dotnet/corefx/commit/
ffd0ae699611a7b172408ebd96b52f6eec0ebe67
Levi Broderick [Wed, 10 Apr 2019 03:35:03 +0000 (20:35 -0700)]
Condition Utf8String package build on IsPrerelease flag
Commit migrated from https://github.com/dotnet/corefx/commit/
5b6a71f295e5b7dcdff4fae98f1301c6a5772c7d
Santiago Fernandez Madero [Tue, 9 Apr 2019 22:28:07 +0000 (15:28 -0700)]
Fix official builds failing due to LinuxNoTest matrix being empty (dotnet/corefx#36750)
Commit migrated from https://github.com/dotnet/corefx/commit/
401436a3c0cfd48250bbf4d299d593397d49f0a8
Eric St. John [Tue, 9 Apr 2019 19:17:52 +0000 (12:17 -0700)]
Fix build breaks and undo package filtering
Commit migrated from https://github.com/dotnet/corefx/commit/
b67328f7ac17bd842a3f1b67bf969e03837f0c77
wtgodbe [Tue, 9 Apr 2019 18:35:29 +0000 (11:35 -0700)]
Don't build UTF8String.Experimental in release/3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
9fb566123fc1f4d5f662eee44847a2161933de5d
Anirudh Agnihotry [Tue, 9 Apr 2019 21:07:31 +0000 (14:07 -0700)]
Removed netcoreappaot configuration from corefx (dotnet/corefx#36739)
* netcoreappaot-Windows_NT regex removed
* netcoreappaot-WebAssembly;\n regex removed
* netcoreappaot-Windows_NT-Debug;netcoreappaot-Windows_NT-Release;
regex removed
* netcoreappaot; regex removed
* netcoreappaot-Debug;netcoreappaot-Release; removed
* removing rest of occurences of netcoreappaot
* deleteing the netcoreappaot apicompat files
Commit migrated from https://github.com/dotnet/corefx/commit/
e9d1a10ed1d38a8b1ed599b3b5be09b8349f8ea8
Viktor Hofer [Tue, 9 Apr 2019 20:28:10 +0000 (22:28 +0200)]
Copy json dependency to test out dir (dotnet/corefx#36738)
Commit migrated from https://github.com/dotnet/corefx/commit/
5bfb3d6e4e32e1cdb579c96cb1668710697d0383
Wraith2 [Tue, 9 Apr 2019 20:19:29 +0000 (21:19 +0100)]
remove pool
Commit migrated from https://github.com/dotnet/corefx/commit/
538cf16de9aa7155d6b905272648f3d9a3492cb0
Wraith2 [Tue, 9 Apr 2019 19:07:08 +0000 (20:07 +0100)]
spelling feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
f27d235b0bfc08106258c7e3ffff49d3811d2cae
Wraith2 [Tue, 9 Apr 2019 18:29:45 +0000 (19:29 +0100)]
address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
73885393cea96b536564ea39f09a86d6494d83a0
Wraith2 [Tue, 9 Apr 2019 16:49:00 +0000 (17:49 +0100)]
change SqlEnvChangePool to be simpler and safe
Commit migrated from https://github.com/dotnet/corefx/commit/
b9bd3548b69a14c969ecd3604ac71272ca8c4725
Steve Harter [Tue, 9 Apr 2019 16:35:31 +0000 (09:35 -0700)]
Fix deserialize cache test (dotnet/corefx#36646)
Commit migrated from https://github.com/dotnet/corefx/commit/
e3ec42fb156c0354aa4095b125f3f56c27d0ecf7
Santiago Fernandez Madero [Tue, 9 Apr 2019 16:28:47 +0000 (09:28 -0700)]
Add test for string.Concat(object) that ToString returns null (dotnet/corefx#36436)
Commit migrated from https://github.com/dotnet/corefx/commit/
f9c971097b9bea6206cc328188ee1fc3bc984fd1
Hugh Bellamy [Tue, 9 Apr 2019 15:51:19 +0000 (16:51 +0100)]
Add more ArrayConverter tests and cleanup code (dotnet/corefx#36654)
* Add more ArrayConverter tests and cleanup code
* Disable netfx test
Commit migrated from https://github.com/dotnet/corefx/commit/
3f7071d66f563cc2f0d49d4c9be7dd538c0e24ae
Hugh Bellamy [Tue, 9 Apr 2019 15:47:39 +0000 (16:47 +0100)]
Add more misc type converters tests (dotnet/corefx#36655)
* Add more misc type converters tests
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
e65153e07ff478d1e71ed54e6a8b8c6547bb884e
Stephen Toub [Tue, 9 Apr 2019 14:58:04 +0000 (10:58 -0400)]
Add initial nullability annotations guidance (dotnet/corefx#36711)
* Add initial nullability annotations guidance
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
663af00ced6ba81a3a7715e6347270306c1bad52
Jeremy Koritzinsky [Tue, 9 Apr 2019 01:44:23 +0000 (18:44 -0700)]
Change charsets to explicitly unicode in System.Drawing.Common (dotnet/corefx#36718)
* Change charsets to explicitly unicode.
* Remove ActiveIssue.
Commit migrated from https://github.com/dotnet/corefx/commit/
02d4a83f640a802ae34588579ba25e8d77ead8ac
Tanner Gooding [Tue, 9 Apr 2019 00:18:02 +0000 (17:18 -0700)]
Updating all types in System.Numerics.Vectors, minus Vector<T>, to use the readonly members feature. (dotnet/corefx#36702)
Commit migrated from https://github.com/dotnet/corefx/commit/
5023c2420a4145bcb560c4b8c57f4bb60cd6973f
Milosz Kukla [Mon, 8 Apr 2019 23:54:36 +0000 (01:54 +0200)]
Update coding-style.md (dotnet/corefx#36695)
* Update coding-style.md
Removed info about corefx.vssettings since it was removed at https://github.com/dotnet/corefx/pull/35683
* Update coding-style.md
Commit migrated from https://github.com/dotnet/corefx/commit/
7b320a0ad1ea83670f561a6ef9231916465bb4b4
Anirudh Agnihotry [Mon, 8 Apr 2019 23:01:30 +0000 (16:01 -0700)]
Changes required to use newGenfacadeModel (dotnet/corefx#36126)
* making corefx compatible with newGenfacadesTask
correcting the new runtime variable
updating genfacades version to latest
fixes uap build and removes extra seed ype preferences for uapaot
* adding build configuration, comments and updating genfacadwa version
* fixing build for netcoreapaot
* removing netcoreappaot build from all configurations build
Commit migrated from https://github.com/dotnet/corefx/commit/
52206f12e2a34b708f33304d9b076b4958fbaa5e
William Godbe [Mon, 8 Apr 2019 22:40:41 +0000 (15:40 -0700)]
Update APICompat Baselines (dotnet/corefx#36578)
* Update APICompat Baselines
* Fix baslines for UAP/UAPAOT
* Fix baseline for UAPAOT
Commit migrated from https://github.com/dotnet/corefx/commit/
9924aa7f049da3a902be5b70c9935dcc9fad0952
Hugh Bellamy [Mon, 8 Apr 2019 21:43:16 +0000 (22:43 +0100)]
Add more Decimal constructor tests (dotnet/corefx#36668)
Commit migrated from https://github.com/dotnet/corefx/commit/
47d17e30dcbcdec64ec3b00a23145e20afbb048e
Steve MacLean [Mon, 8 Apr 2019 21:13:58 +0000 (17:13 -0400)]
Revert "Disable for coreclrdotnet/corefx#23583" (dotnet/corefx#36564)
Commit migrated from https://github.com/dotnet/corefx/commit/
090f99d94cd1fbcd8c3f9c67deeb53cd99f2d8ba
Tomas Weinfurt [Mon, 8 Apr 2019 20:44:07 +0000 (13:44 -0700)]
add Alpine ARM64 queue (dotnet/corefx#36548)
* try to add Alpine ARM64 queue
* remove extra line
* correct queue names
* update queues
* use open queue for CI
* final cleanup
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
37867bd2a298062b637ad7fcbe9bd19cda15326f
Morgan Brown [Mon, 8 Apr 2019 17:53:37 +0000 (10:53 -0700)]
Implement Serialization Guard - CoreFX portion
Consume Serialization Guard API in BinaryFormatter and Process.
Also includes Serialization Guard's tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
6ca16758a5d454c1f1b04975bf55f259dd71fc49
Stephen Toub [Mon, 8 Apr 2019 16:45:00 +0000 (12:45 -0400)]
Disable System.Drawing test (dotnet/corefx#36700)
Commit migrated from https://github.com/dotnet/corefx/commit/
c653c8966f9264470285bc7d54f7d439bee723c7
Ahson Khan [Mon, 8 Apr 2019 09:55:50 +0000 (02:55 -0700)]
Add support for trailing commas within Utf8JsonReader (dotnet/corefx#36690)
* Add support for trailing commas with single-segment tests.
* Implement single-segment case and update tests.
* Update multi-segment path and add tests.
* Add more tests, add to state, and update rollback logic.
Commit migrated from https://github.com/dotnet/corefx/commit/
87fdc75beacc76e02c8e572ae3b0613b418200eb
Stephen Toub [Mon, 8 Apr 2019 03:19:33 +0000 (23:19 -0400)]
Add test for MemoryStream's buffer after Capacity reset (dotnet/corefx#36580)
Commit migrated from https://github.com/dotnet/corefx/commit/
268812e10fe17e8177dc5ca680128b286207c82f
dotnet-maestro[bot] [Mon, 8 Apr 2019 01:21:44 +0000 (01:21 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36596)
* Update dependencies from https://github.com/dotnet/coreclr build
20190403.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview4-27603-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview4-27603-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27603-72
* Update dependencies from https://github.com/dotnet/coreclr build
20190404.75
- Microsoft.NET.Sdk.IL - 3.0.0-preview4-27604-75
- Microsoft.NETCore.ILAsm - 3.0.0-preview4-27604-75
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27604-75
* Update dependencies from https://github.com/dotnet/coreclr build
20190405.73
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27605-73
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27605-73
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27605-73
* Update dependencies from https://github.com/dotnet/coreclr build
20190406.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27606-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27606-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27606-72
* Fix argument name in Buffer.BlockCopy test
* Update StreamWriters tests for BaseStream dispose change
* Updated tests for new PtrToStringUTF8 behavior
Commit migrated from https://github.com/dotnet/corefx/commit/
1d63519e16fdc298f79c23b0ea7f4e89013024c5
Stephen Toub [Sun, 7 Apr 2019 20:51:29 +0000 (16:51 -0400)]
Plumb CancellationToken through Socket.Receive/SendAsync (dotnet/corefx#36516)
In .NET Core 2.1 we added overloads of Send/ReceiveAsync, and we proactively added CancellationToken arguments to them, but those tokens were only checked at the beginning of the call; if a cancellation request came in after that check, the operation would not be interrupted.
This PR plumbs the token through so that a cancellation request at any point in the operation will cancel that operation. On Windows we register to use CancelIoEx to request cancellation of the specific overlapped operation on the specific socket. On Unix we use the existing cancellation infrastructure already in place to support the existing custom queueing scheme.
Some caveats:
- On Windows, canceling a TCP receive will end up canceling all TCP receives pending on that socket, even when we request cancellation of a specific overlapped operation; this is just how cancellation works at the OS level, and there's little we can do about it. It also shouldn't matter much, as multiple pending receives on the same socket are rare.
- If multiple concurrent receives or multiple concurrent sends are issued on the same socket, only the first will actually be cancelable. This is because this implementation only plumbs the token through the SocketAsyncEventArgs-based code paths, not the APM based code paths, and currently when using the Task-based APIs, we use the SocketAsyncEventArgs under the covers for only one receive and one send at a time; other receives made while that SAEA receive is in progress or other sends made while that SAEA send is in progress will fall back to using the APM code paths. This could be addressed in the future in various ways, including a) just using the SAEA code paths for all operations and deleting the APM fallback, or b) plumbing cancellation through APM as well. However, for now, this approach addresses the primary use case and should be sufficient.
- This only affects code paths to which the CancellationToken passed to Send/ReceiveAsync could reach. If in the future we add additional overloads taking CancellationToken, we will likely need to plumb it to more places.
Commit migrated from https://github.com/dotnet/corefx/commit/
2190a0ffbbc0af808b67e827abdaf01be4271aeb
Erhan Atesoglu [Sun, 7 Apr 2019 20:44:07 +0000 (13:44 -0700)]
Moved Interop Locations For System.IO.Compression.Brotli (dotnet/corefx#36614)
* MovedInteropLocationForBrotli
* Combined Brotli Files
Commit migrated from https://github.com/dotnet/corefx/commit/
e5fddbc1aee5215d988f8044be6d48b273286689
Steve Harter [Sat, 6 Apr 2019 03:56:20 +0000 (20:56 -0700)]
Support json deserialize of 'null' and 'bool' when declared type is typeof(object) (dotnet/corefx#36637)
* Support null and bool values for typeof(object)
* Remove support for bool
Commit migrated from https://github.com/dotnet/corefx/commit/
35249a0072b41a89ce1542deacb2611c2393dec0
Jeremy Barton [Sat, 6 Apr 2019 03:02:12 +0000 (20:02 -0700)]
Add the TPM Object Identifiers to the static table in OidLookup
Experimentation suggests that these values are non-localized in Windows,
and are currently unmapped in OpenSSL; so they are good candidates for
static registration in OidLookup.
The TpmIdentifiers test passed on Windows Server 2012 R2 before the change,
to help prevent typos with registration.
Commit migrated from https://github.com/dotnet/corefx/commit/
2862fae4f7686c0db8cddd26e7da05d0521e2c1d
Foxtrek_64 [Sat, 6 Apr 2019 02:53:21 +0000 (21:53 -0500)]
Label implements IEquatable<Label> (dotnet/corefx#35673)
* Label implements IEquatable<Label>
* Add Unit Tests for IEquatable<Label>
* Actually track LabelEquals.cs this time
* Move Label IEquatable declaration to ILGeneration.netcore
* Merge IEquatable unit tests with existing equality tests
Commit migrated from https://github.com/dotnet/corefx/commit/
b561cd457ccaf4fbf700a561e9581a4214315b81
Santiago Fernandez Madero [Sat, 6 Apr 2019 02:40:22 +0000 (19:40 -0700)]
Remove Microsoft.Windows.Compatibility.Shims package (dotnet/corefx#36644)
* Remove Microsoft.Windows.Compatibility.Shims package
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
f61f49711b441a6650e6989f3c1be551732dd10f
Vladimir Sadov [Sat, 6 Apr 2019 02:39:51 +0000 (19:39 -0700)]
Fix a race condition in a TaskStatusTest (dotnet/corefx#36645)
See:https://github.com/dotnet/coreclr/issues/20706
Commit migrated from https://github.com/dotnet/corefx/commit/
d00fa24e3ee8f55c81589c4ba6841e5baf8cd646
Jeremy Barton [Sat, 6 Apr 2019 02:37:38 +0000 (19:37 -0700)]
Provide a temporary RSA decryption buffer when dest is too small (dotnet/corefx#36601)
* Provide a temporary RSA decryption buffer when dest is too small
* Remove the semi-redundant second span variable
* Add tests to ensure that destination is not tainted when decryption fails
* Make Decrypt_WrongKey_OAEP_SHA256 conditional
Commit migrated from https://github.com/dotnet/corefx/commit/
df5bba114e23afc4a3621917da0a1f810be19e7a
Egor Chesakov [Fri, 5 Apr 2019 22:47:01 +0000 (15:47 -0700)]
Merge pull request dotnet/corefx#36636 from dotnet/MicrosoftPrivateCoreFxNETCoreAppLinuxMuslArm64
Add linux-musl-arm64 RID to Microsoft.Private.CoreFx.NETCoreApp
Commit migrated from https://github.com/dotnet/corefx/commit/
9cc965f2f2da6284b933204810e710cf0e46db10
William Godbe [Fri, 5 Apr 2019 21:41:13 +0000 (14:41 -0700)]
Merge pull request dotnet/corefx#36634 from wtgodbe/Preview5
Update branding to preview5
Commit migrated from https://github.com/dotnet/corefx/commit/
facd959f5c1cead92dba0b1eb2350c430b5b1630
Krzysztof Wicher [Fri, 5 Apr 2019 20:05:34 +0000 (13:05 -0700)]
Negotiated ciphersuite (dotnet/corefx#35029)
* NegotiatedCiphersuite implementation
* fix after merge conflict
* fix netfx
* add more expected Tls 1.0 ciphersuites (rfc5289)
* change TlsCipherSuite API to nullable
* apply self-feedback
* apply feedback
* Revert "change TlsCipherSuite API to nullable"
This reverts commit dotnet/corefx@
c8bffccb5b368239be8529f3789a47f322754907.
* simplification around nullables
* msbuild /t:GenerateReferenceSource instead of copy & paste
* revert badly generated APIs
* fix codegen after moving tt files
* apply feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
f9fbe70f05b6ca89e94dcc91126d5fd4829a100e