Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ia0f2c393b1aa339c1881c084636dbfb91245602d
[version] 2.45
Change-Id: I96f465c583720abbb514635a56adf50988bdac4f
[Filesystem] Fix the position property when writing non-single-byte-signs
[Bug] When FileStream object writes non-single-byte-signs, position members
was not properly updated.
[Verification] TCT filesystem - 100%
Below code:
(function writeKoreanOldAPI(fileName) {
var dirPath = "documents/";
var fullPath = dirPath + fileName;
console.log("fullPath : " + fullPath);
console.log("fileName : " + fileName);
tizen.filesystem.resolve(fullPath, function (fileResult) {
fileResult.openStream("w", function (fileStream) {
fileStream.write("한글 확인 파일입니다\n");
fileStream.write("한글111 확인 파일입니다\n");
fileStream.write("한글22222 확인 파일입니다\n");
fileStream.write("한글 확인 파일입니다\n");
fileStream.write("한글 확인111 파일입니다\n");
fileStream.write("한글 확인22222 파일입니다\n");
fileStream.write("한글 확인 파일입니다\n");
fileStream.write("한글 확인 파일입니다111\n");
fileStream.write("한글 확인 파일입니다22222\n");
fileStream.write("겆\n");
fileStream.write("돐\n");
fileStream.close();
},
function (e) {
console.log("Error " + e.message);
}, "UTF-8");
fileResult.readAsText(
function (str) {
console.log("The file content:\n" + str);
oldAPIResult = str;
},
function (e) {
console.log("Error " + e.message);
},
"UTF-8");
},
function (e) {
console.log("Error:" + e + " Create a file.");
tizen.filesystem.resolve(dirPath, (dir) => { newFile = dir.createFile(fileName); });
writeKoreanOldAPI(fileName);
}, "rw");
})("test")
creates file with size of 302 bytes and content:
한글 확인 파일입니다
한글111 확인 파일입니다
한글22222 확인 파일입니다
한글 확인 파일입니다
한글 확인111 파일입니다
한글 확인22222 파일입니다
한글 확인 파일입니다
한글 확인 파일입니다111
한글 확인 파일입니다22222
겆
돐
Change-Id: I8ff3c158ed2b284e1cdeaa93c339952fef6915b0
Jakub Skowron [Tue, 23 Jan 2018 12:19:10 +0000 (13:19 +0100)]
[Filesystem] Add support for ISO-8859-1
Latin-1 encoding in FileReadString and FileWriteString
Change-Id: I2cd7942481619989891c3019d3f7d4325b962892
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Fri, 2 Oct 2020 10:39:10 +0000 (12:39 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I5424b41f13b345d9ff8b831f99b884f4a541b882
Piotr Kosko [Fri, 2 Oct 2020 10:20:21 +0000 (12:20 +0200)]
[version] 2.45
Change-Id: Ib116dd26b482abb5892e894f280141787f978435
Piotr Kosko [Fri, 2 Oct 2020 10:19:32 +0000 (12:19 +0200)]
[Common] Fixed possible memory leak
[verification] Code compiles without errors
Change-Id: Ib8c7843461a575fd05d3b28e4db1fab35cc08ccb
[version] 2.44
Change-Id: I0caaa6af3791ad65fa165c45dfe37e5e01239b1b
[Humanactivitymonitor] Fixed wrong behaviour of isGestureSupported()
https://code.sec.samsung.net/jira/browse/XWALK-2175
Implementation should not throw NotSupportedError, but return true/false
[Verification] Code compiles without errors.
Change-Id: Ia19893338f9b573a29639b667b3b0b52c6584554
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0abc0ed3a4c04aa1df20e4ef1b804cad4aed2088
[version] 2.43
Change-Id: I1f760b29b975107288cf2b5595f94db168148f4e
Pawel Wasowski [Wed, 5 Feb 2020 13:00:47 +0000 (14:00 +0100)]
[Bluetooth][Pre-6.0] Fix BluetoothLEDevice::getServiceAllUuids()
[Bug] When some remote device advertises non-standard UUID, it was invalidly
translated to 16bit UUID. Which caused "NotFoundError: Service not found" error
in case of reading this service.
Inlcudes:
* fix for BluetoothLEDevice::getServiceAllUuids based on 6.0 implementation
* moving toLowerCase() from messaging to common module (needed for a fix)
[Verification]
Auto TCT 100% pass.
Tested in console:
Precondition:
Remote device need to have a GATT server advertising some non-standard UUID service, e.g.
"
12341234-1234-1234-1234-
123412341234". Below code should work if your remote device "MyDevice"
has proper service with a characteristic.
Last result will be something like "Value read from 1 characteristic -> 116,101,115,116"
var testDeviceName = "MyDevice";
var nonStandardUUID = "
12341234-1234-1234-1234-
123412341234";
var device;
function testBle(name) {
var adapter = tizen.bluetooth.getLEAdapter();
adapter.startScan(function (device_) {
device = device_;
//Item one occurs here:
if (device.name)
console.log("Found: " + JSON.stringify(device))
if (device.name === name) {
console.log("[Found device] address: " + JSON.stringify(device));
adapter.stopScan();
device.connect(function () {
console.log("[Connected]");
uuids = device.getServiceAllUuids();
console.log("all UUIDS\n" + JSON.stringify(uuids))
if (uuids.includes(nonStandardUUID)) {
console.log("Reading: " + nonStandardUUID);
var service = device.getService(nonStandardUUID);
if (service.characteristics.length > 0) {
for (j = 0; j < service.characteristics.length; ++j) {
var characteristic = service.characteristics[j];
characteristic.readValue(function (val) {
console.log("Value read from " + j + " characteristic -> " + val);
});
}
} else {
console.log("no characteristics found for service: " + uuid)
}
} else {
console.error("UUID " + nonStandardUUID + " not found ");
}
}, (e) => console.log(e));
}
}, (e) => console.log(e))
}
testBle(testDeviceName)
Change-Id: I38494b6b5037cf06ee7c4bc32d2f8f5e8e6ce97e
Rafal Walczyna [Tue, 25 Aug 2020 07:29:53 +0000 (09:29 +0200)]
[MediaController] Add locks for variable used in different threads
Handles for client and server can be used in different threads.
It may cause segmentation fault when already freed handle will be used.
Verification: Build successful
Change-Id: Iba90d1a85be51710ccda169389ce393f5ce1d1a3
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 25 Aug 2020 07:29:53 +0000 (09:29 +0200)]
[MediaController] Add locks for variable used in different threads
Handles for client and server can be used in different threads.
It may cause segmentation fault when already freed handle will be used.
Verification: Build successful
Change-Id: Iba90d1a85be51710ccda169389ce393f5ce1d1a3
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Piotr Kosko [Wed, 10 Jun 2020 11:19:07 +0000 (13:19 +0200)]
[Systeminfo] Fixed behaviour of Network property
[Bug] When using device with not supported feature
http://tizen.org/feature/network.telephony
e.g. R800 device, below code returns no error:
tizen.systeminfo.getPropertyValueArray("NETWORK", (s) => {console.log(s)}, (s) => {console.log(s)})
listener for "NETWORK" property is never triggered also:
tizen.systeminfo.addPropertyValueChangeListener("NETWORK", (s) => console.log(s));
[verification]
Systeminfo TCT 100% passrate.
After fix, listener and getter works properly on TW3.
Change-Id: I9f0d533055926d186305fb7c39418de1fed76f5b
Piotr Kosko [Wed, 10 Jun 2020 11:19:07 +0000 (13:19 +0200)]
[Systeminfo] Fixed behaviour of Network property
[Bug] When using device with not supported feature
http://tizen.org/feature/network.telephony
e.g. R800 device, below code returns no error:
tizen.systeminfo.getPropertyValueArray("NETWORK", (s) => {console.log(s)}, (s) => {console.log(s)})
listener for "NETWORK" property is never triggered also:
tizen.systeminfo.addPropertyValueChangeListener("NETWORK", (s) => console.log(s));
[verification]
Systeminfo TCT 100% passrate.
After fix, listener and getter works properly on TW3.
Change-Id: I9f0d533055926d186305fb7c39418de1fed76f5b
Piotr Kosko [Fri, 29 May 2020 09:59:52 +0000 (11:59 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I00cb2f4c2c127315e11546b3d244f25208f921f3
Piotr Kosko [Fri, 29 May 2020 09:11:31 +0000 (11:11 +0200)]
[version] 2.42
Change-Id: I21e64688f0d19c08c7ce6ce28b1c1209c3c3d04d
Michal Michalski [Thu, 28 May 2020 11:47:22 +0000 (13:47 +0200)]
[archive] Fix paths comparator for permissions dictionary.
[Verification] tct-archive-tizen-tests 100% pass rate on TM1 emulator.
Change-Id: I675857a5f1335d8fb28a623ff15edc2d6d1aa8b5
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Thu, 26 Mar 2020 08:32:14 +0000 (09:32 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifbd17f0ca3fcaa5922f6a2194c5f2ffc007ee1c6
Piotr Kosko [Thu, 26 Mar 2020 08:30:38 +0000 (09:30 +0100)]
[version] 2.41
Change-Id: If5ba0f4ac89de2b51259a0a94be4a3a2f156e5a5
Piotr Kosko [Thu, 26 Mar 2020 07:41:59 +0000 (08:41 +0100)]
[Alarm] Fixed Coverity issue and undefined behaviour
[Coverity] 1134493
Change-Id: I3c9aa41a640efc6ca001ea96978374994a88e029
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1bd47bf631acfcd842c26a5076c3538d8cbe8247
[version] 2.40
Change-Id: I06a43e95787fe3e97fc87cbaaee7f2e430b99b97
Pawel Wasowski [Wed, 8 Jan 2020 10:28:08 +0000 (11:28 +0100)]
[Archive] Prevent extracting files with ".." in relative paths
This change mitigates a potential security issue, which could occur if
a zip archive contained files with ".." in their paths.
ArchiveEntry.extract() and Archive.extractAll() will not extract such
files.
Verification: auto tct-tizen-archive-tests pass rate: 100%
Manual tests: attempts to extract files with forbidden
".." results in an UnknownError.
Change-Id: I563744d834d24e896493f55d15e579e714d539f9
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I46b19761d8c18ed668e27a078c7e8094c1dde614
[version] 2.39
Change-Id: I4b83c04cba5ab218c11cefdbffd4e89054f54540
[Messageport] Fixed listener issues
[Bugs]
* There was a problem with missing unregistration of
listeners for local ports, it was added.
* There was invalid calling of listeners (only latest listener was called),
now each registered listener is called properly.
[Verification] Messageport TCT passrate 100%.
Below scenario calls 3 different callbacks:
abc = tizen.messageport.requestLocalMessagePort("abc");
abc.addMessagePortListener((data, name) => {console.log(abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc.addMessagePortListener((data, name) => {console.log("2" + abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc.addMessagePortListener((data, name) => {console.log("3" + abc.messagePortName + " -> \"" + data + "\" : \"" + name + "\"")} );
abc_remote = tizen.messageport.requestRemoteMessagePort(tizen.application.getCurrentApplication().appInfo.id, "abc");
abc_remote.sendMessage([{key: "key1", value: "val1"}]);
Change-Id: If3a4b362de76599904c83737137c0d0cd4d023c7
[version] 2.39
Change-Id: I06df52433c2f8c159d42ae7ad11e10531b13a60d
[Code format] Fixed formatting issues
Change-Id: Ieb6000829e03777e709ecfa9e447185975828866
Piotr Kosko [Mon, 2 Dec 2019 11:21:50 +0000 (11:21 +0000)]
Merge "[ham] Fixed sleep recorder, returned value" into tizen_4.0
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
[ham] Fixed sleep recorder, returned value
[Bug] there was missing conversion from numerical value from database to string value used in Web API
[Verification] TCT passrate 100% on wearable TW3.
Below code works when activity added manually to database.
var data = [];
date = new Date(), startTime = date.getTime(), endTime = date.setDate(date.getDate() + 1),
query = {
startTime: startTime/1000,
endTime: endTime/1000,
interval: 1440
};
tizen.humanactivitymonitor.readRecorderData("SLEEP_MONITOR", query, (s) => console.log(data = s), (s) => console.log(s))
returns one of values of "ASLEEP", "AWAKE", or "UNKNOWN"
Change-Id: I86b6bead534638bafcb5abcb16512bb462c79374
Piotr Kosko [Mon, 2 Dec 2019 07:21:30 +0000 (07:21 +0000)]
Merge "[MediaController] Fix removing invalid listener" into tizen_4.0
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I19c718eb38545fda3bf0b49403e1cbd88960ec4f
[version] 2.38
Change-Id: Id74d1d21292bd36c33771009e5a6fac0bd50537b
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Thu, 21 Nov 2019 10:46:10 +0000 (11:46 +0100)]
[MediaController] Fix removing invalid listener
CommandListener was removed instead of ChangeRequestPlaybackInfoListener.
It was impossible to add ChangeRequestPlaybackInfoListener again.
Verification: tct passrate 100%.
Tested in GoogleChrome console on TM1 and KantM2.
Change-Id: Iff0ea6026581b3649592ee5bde3bfb625ceb35e4
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Icba6eb40bb40a300befb71d01aa07320ea68b069
[version] 2.37
Change-Id: Ib1de6d53a704c6321d70c5202b5a5fcc3b055ead
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I99c57c205dd95970412c98430b9998c773a94917
[version] 2.36
Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56
[Bluetooth] Fixed issues related to BLE
[Bug/Fix]
1. Prevent possible crash in case of invalid data passed from native
2. Prevent type mismatch exception in JS in case of LE devices advertising
serviceData.
[Verification] tct passrate 100%
Checked in chrome console and le device with serviceData.
Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44
[version] 2.35
Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting
Used: ./code_format src/ -c -js
Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Szymon Jastrzebski [Fri, 12 Jan 2018 10:07:53 +0000 (11:07 +0100)]
[Archive] Fix for retrieving virtual roots
Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.
[Verification] TCT Archive passed with 100% p.r.
Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Rafal Walczyna [Tue, 24 Sep 2019 14:23:38 +0000 (16:23 +0200)]
[Filesystem] List of virtual roots for resolve function fixed.
Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.
Verification: TCT - 100 % pass.
Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
Arkadiusz Pietraszek [Fri, 12 Jul 2019 11:47:35 +0000 (13:47 +0200)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0
[Verification] TCT passrate 100%.
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Change-Id: Id004158e62f5d0b6f2c09eeee5cf300d461a9d9f
Arkadiusz Pietraszek [Mon, 8 Jul 2019 08:20:14 +0000 (10:20 +0200)]
[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch
Prietter code formatter treated obiect properties named 'null' and 'undefined' as keywords that should not be in apostrophes and removed those apostrophes.
This change has been reverted and //prettier-ignore tags has been added.
Change-Id: I78d502b9f674397f01c959031ad37fa139dd0b16
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Wed, 3 Jul 2019 09:00:58 +0000 (09:00 +0000)]
Merge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener." into tizen_3.0
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.34
Change-Id: Idd416b0d826a58f7bbc72edb07d4570aa3319212
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.33
Change-Id: I2a04c187950845b460b398c9b16ad963c4c2330f
Arkadiusz Pietraszek [Wed, 3 Apr 2019 11:09:04 +0000 (13:09 +0200)]
[Project] JS code formatting
All project *.js files were formatted with eslint tool, to eliminate CodingRule_Auto negative marks.
Additionally Prettier tool was used for unified line breaking rules.
In few cases, the tool did not break line for very long object definitions e.g.
HumanActivityRecorderPressureData.prototype.constructor = HumanActivityRecorderPressureData;
in such cases, line was broken manually and flag // prettier-ignore was added to ignore next node.
Change-Id: I537435c652abad22364421fc4c5ebddd411defbf
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0d282d007e89b4c761fa74d9b0737ca35c29ec57
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0
Piotr Kosko [Wed, 17 Apr 2019 10:34:30 +0000 (10:34 +0000)]
Merge "[Project][code_formatter] Added u options and changed JS formatting and validating tools" into tizen_3.0
[Project][Codeformat] Added prettier as partial formatter for JS
[Feature] Existing solution check the format using eslint and fix
some issues with predefined rules (which match the requirements
of review.tizen.org CodingRule_Auto bot rules.
However the tool checks the validity, it does not provide auto
formating of too long lines issues.
To ensure such feature, the new tool was introduced and executed before
eslint validation.
Thanks to prettier, the line breaks are unified and handled the same
way in whole project.
Change-Id: I077036521307ef28fda5388ecab01b8d850ad3e3
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8f28e19de69751b7b92328491366aa0b8c7c6847
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
Arkadiusz Pietraszek [Wed, 27 Mar 2019 14:29:37 +0000 (15:29 +0100)]
[Project][code_formatter] Added u options and changed JS formatting and validating tools
Now eslint is used to format js files.
Not all issues can be fixed by eslint, so it prints list of issues for user to fix.
All 'u' options in formatter format appropriate files, that was changed from last commit.
Since files to format are not commited, this script backs up those files.
[Verification] Script executes without errors and proper files are chosen to format. Formated .js files have 4 spaces of indentation.
Change-Id: I10509ce3f639b25cca7e68e95e7c9419d9d82304
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 12:42:20 +0000 (13:42 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201889/
Change-Id: Ic48f0740da9c73ef676d30eedf72226c7f4d5699
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I7bdf58474ccd556f444f93dee7856566a65373b6
[version] 2.31
Change-Id: Ic8c3ade13866c7e55ee660346c3a79103f29d006
[Archive][Exif] Added checking return value of fseek
SVACE issues: 246302, 246317
Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifadc8944744fa1fe4e944670a51c184f1c36c228
[version] 2.30
Change-Id: I701491ee275a9540c9ddb821f420898629a3f5ca
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I3142680c3588c1287d4dc23af6aee9832ebe6cd0
[version] 2.29
Change-Id: I27c09aef9adc3ba125477521e95a85633b0e702d
[Common] Added missing return statement
[Bug] When parsing invalid message, exception is catched, but the control
is not finished. Going to following lines, other exception would be raised.
We need to finish execution for invalid message.
[Verification] Code compiles without errors.
Change-Id: I65784e775b9a765332c4a1f0a19b8184e896872c
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Tue, 23 Oct 2018 05:30:19 +0000 (07:30 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1095cde2fdf145ec952fb0ce220837705982086f
Piotr Kosko [Mon, 22 Oct 2018 12:16:20 +0000 (14:16 +0200)]
[version] 2.28
Change-Id: Icfae075f33085630150a69087c7dc8ccd78c9697
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 12:11:27 +0000 (14:11 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iaff2d9c208f5291dfac1eacb23070b8c4f3f10f2
Piotr Kosko [Tue, 2 Oct 2018 12:08:07 +0000 (14:08 +0200)]
[version] 2.27
Change-Id: I7aa0f9e1384347db1d0b045ef46542fcd5e8c7a2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 11:25:19 +0000 (13:25 +0200)]
[Archive][Exif] Added missing error checking
[Verification] Code compiles without errors.
Change-Id: I588a1d08f4dea4a19038653b2889a1daa5b45673
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 07:20:56 +0000 (09:20 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8dd955cb6c74b1323acfb5c8839733517c70e053
Piotr Kosko [Thu, 20 Sep 2018 07:01:37 +0000 (09:01 +0200)]
[version] 2.26
Change-Id: Ibb8feb4665aee4761dc2592147bdd41743bed13d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 06:40:06 +0000 (08:40 +0200)]
[Bluetooth] Fixing the memory releasing issue
[Verification] Code compiles without errors.
TCT passrate 100%.
Change-Id: I4a7b516635b7d2a3bfc96359fa4d51543b0eb4e0
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Mon, 27 Aug 2018 08:03:57 +0000 (10:03 +0200)]
[Alarm] Fix printing deprecation warnings on TV profile
AlarmAbsolute(date, period) constructor is not marked
as deprecated on TV profile.
[Verification]
Tested in chrome console
Change-Id: I1b3de7ad9d38c4bf4f8e55f8e8309e86b106e2f1
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Piotr Kosko [Thu, 16 Aug 2018 08:43:39 +0000 (10:43 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ic220dd064ebbb7187462bf78fde154cea2a19b66
Piotr Kosko [Thu, 16 Aug 2018 08:42:15 +0000 (10:42 +0200)]
[version] 2.25
Change-Id: If58254886f7fa6188e597e4d20dcb30f0ef60234
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>