mtklein [Mon, 4 Apr 2016 20:48:41 +0000 (13:48 -0700)]
Roll up to use >=4.
https://github.com/mtklein/libpng/commit/
d0513638e7cc7d22b7dace879afea848b342fe33
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854293002
Review URL: https://codereview.chromium.org/
1854293002
borenet [Mon, 4 Apr 2016 19:39:32 +0000 (12:39 -0700)]
Fixes for iOS Swarming bot
BUG=skia:5155
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1855223002
Review URL: https://codereview.chromium.org/
1855223002
halcanary [Mon, 4 Apr 2016 19:14:46 +0000 (12:14 -0700)]
Fix ParseConfigs_OutParam tests
Review URL: https://codereview.chromium.org/
1857923002
mtklein [Mon, 4 Apr 2016 19:08:46 +0000 (12:08 -0700)]
Point libpng at upstream libpng 1.6 + my new perf patch.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852363002
Review URL: https://codereview.chromium.org/
1852363002
robertphillips [Mon, 4 Apr 2016 19:07:47 +0000 (12:07 -0700)]
Switch internal testing ImageFilters over to new onFilterImage interface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854133002
Review URL: https://codereview.chromium.org/
1854133002
ethannicholas [Mon, 4 Apr 2016 18:41:30 +0000 (11:41 -0700)]
Revert of added GrMSAAPathRenderer (patchset #9 id:160001 of https://codereview.chromium.org/
1834133003/ )
Reason for revert:
driver crash on Windows
Original issue's description:
> added GrMSAAPathRenderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
>
> Committed: https://skia.googlesource.com/skia/+/
47a2dc8e229e93e1bcf7405747320920da1ab742
>
> Committed: https://skia.googlesource.com/skia/+/
b0fabd4ed55abcb6f5ed2f331c96c783f42bd37c
TBR=bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1853223003
ethannicholas [Mon, 4 Apr 2016 18:00:00 +0000 (11:00 -0700)]
added GrMSAAPathRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
Committed: https://skia.googlesource.com/skia/+/
47a2dc8e229e93e1bcf7405747320920da1ab742
Review URL: https://codereview.chromium.org/
1834133003
scroggo [Mon, 4 Apr 2016 17:05:23 +0000 (10:05 -0700)]
Add SK_API to SkROBuffer::Iter
Necessary for crrev.com/
1812273003 in Chromium.
Also remove trailing whitespace.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1856033002
Review URL: https://codereview.chromium.org/
1856033002
reed [Mon, 4 Apr 2016 17:02:58 +0000 (10:02 -0700)]
switch maskfilters to sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852113003
Review URL: https://codereview.chromium.org/
1852113003
robertphillips [Mon, 4 Apr 2016 16:18:52 +0000 (09:18 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
Committed: https://skia.googlesource.com/skia/+/
33550dab45516bbcfa5ab908c5857fb382535c44
Review URL: https://codereview.chromium.org/
1851583002
ethannicholas [Mon, 4 Apr 2016 15:27:03 +0000 (08:27 -0700)]
Revert of added GrMSAAPathRenderer (patchset #8 id:140001 of https://codereview.chromium.org/
1834133003/ )
Reason for revert:
nanobench failure
Original issue's description:
> added GrMSAAPathRenderer
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
>
> Committed: https://skia.googlesource.com/skia/+/
47a2dc8e229e93e1bcf7405747320920da1ab742
TBR=bsalomon@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1860563002
robertphillips [Mon, 4 Apr 2016 15:06:17 +0000 (08:06 -0700)]
Revert of Update SkXfermodeImageFilter to sk_sp (patchset #4 id:60001 of https://codereview.chromium.org/
1852123002/ )
Reason for revert:
Chrome-land compilation failure.
Original issue's description:
> Update SkXfermodeImageFilter to sk_sp
>
> TBR=reed@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852123002
>
> Committed: https://skia.googlesource.com/skia/+/
3bc969264d4720d67f0b137552b3777a03b431a8
TBR=fmalita@chromium.org,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1852273002
ethannicholas [Mon, 4 Apr 2016 14:57:39 +0000 (07:57 -0700)]
added GrMSAAPathRenderer
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834133003
Review URL: https://codereview.chromium.org/
1834133003
robertphillips [Mon, 4 Apr 2016 14:13:49 +0000 (07:13 -0700)]
Update SkXfermodeImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852123002
Review URL: https://codereview.chromium.org/
1852123002
halcanary [Mon, 4 Apr 2016 13:12:15 +0000 (06:12 -0700)]
DM/PDF: stop adding unused rasterizer keywords
We can always add it back if we need it in the future.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852713002
Review URL: https://codereview.chromium.org/
1852713002
bsalomon [Mon, 4 Apr 2016 12:56:59 +0000 (05:56 -0700)]
Revert of Rename enums in GrContextFactory to remove "GL" (patchset #4 id:60001 of https://codereview.chromium.org/
1845923004/ )
Reason for revert:
Many GM images unexpectedly changed with this CL.
Original issue's description:
> Rename enums in GrContextFactory to remove "GL"
>
> Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
>
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845923004
>
> Committed: https://skia.googlesource.com/skia/+/
2d9c6f81353597aebf5934547e5cba7a872196fb
TBR=egdaniel@google.com,jvanverth@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/
1856703002
robertphillips [Mon, 4 Apr 2016 12:28:03 +0000 (05:28 -0700)]
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #6 id:100001 of https://codereview.chromium.org/
1851583002/ )
Reason for revert:
changing images on bots
Original issue's description:
> Switch SkDownSampleImageFilter over to new onFilterImage interface
>
> This will slightly change the testimagefilters GM images
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
>
> Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
>
> Committed: https://skia.googlesource.com/skia/+/
33550dab45516bbcfa5ab908c5857fb382535c44
TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1859533002
robertphillips [Mon, 4 Apr 2016 12:05:11 +0000 (05:05 -0700)]
Update internal testing ImageFilters to sk_sp
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854023003
Review URL: https://codereview.chromium.org/
1854023003
robertphillips [Mon, 4 Apr 2016 12:04:45 +0000 (05:04 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
Review URL: https://codereview.chromium.org/
1851583002
robertphillips [Mon, 4 Apr 2016 11:31:25 +0000 (04:31 -0700)]
Update SkBlurImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852743002
Review URL: https://codereview.chromium.org/
1852743002
reed [Sun, 3 Apr 2016 16:11:13 +0000 (09:11 -0700)]
change flattenable factory to return sk_sp
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1855733002
Review URL: https://codereview.chromium.org/
1855733002
update-skps [Sun, 3 Apr 2016 07:59:16 +0000 (00:59 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851323002
Review URL: https://codereview.chromium.org/
1851323002
reed [Sun, 3 Apr 2016 01:40:40 +0000 (18:40 -0700)]
check for bad params sent to discrete patheffect
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853953002
TBR=
Review URL: https://codereview.chromium.org/
1853953002
senorblanco [Fri, 1 Apr 2016 23:41:10 +0000 (16:41 -0700)]
Image filters: optimize crop rect application.
If a filter does not affect transparent black, there's no
reason to allow the crop rect to expand beyond the optimal
size determined by onFilterNodeBounds(). So don't enlarge
the bounds unless the filter affects transparent black.
In order to determine which filters affect transparent
black, I've pulled the inverse of the canComputeFastBounds()
logic into a non-recursive, affectsTransparentBlack()
virtual, and left canComputeFastBounds() as a non-virtual,
recursive function that calls it.
BUG=599933
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848953002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1848953002
bsalomon [Fri, 1 Apr 2016 20:38:04 +0000 (13:38 -0700)]
Rename enums in GrContextFactory to remove "GL"
Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845923004
Review URL: https://codereview.chromium.org/
1845923004
bsalomon [Fri, 1 Apr 2016 18:54:31 +0000 (11:54 -0700)]
Add GrContext::releaseAndAbandonContext()
Like abandonContext() this disconnects the GrContext from the underlying 3D API. However, unlike abandonContext it first frees all allocated GPU resources.
BUG=skia:5142
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852733002
Review URL: https://codereview.chromium.org/
1852733002
halcanary [Fri, 1 Apr 2016 18:51:00 +0000 (11:51 -0700)]
SkPDF: properly dedup bitmaps in shaders
BUG=skia:5161
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848383002
Review URL: https://codereview.chromium.org/
1848383002
halcanary [Fri, 1 Apr 2016 18:43:39 +0000 (11:43 -0700)]
SkPDF: PDFShader does not hold images/bitmaps
motivation: measurable memory savings.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851123002
Review URL: https://codereview.chromium.org/
1851123002
robertphillips [Fri, 1 Apr 2016 17:34:43 +0000 (10:34 -0700)]
Update SkAlphaThresholdFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847053004
Review URL: https://codereview.chromium.org/
1847053004
egdaniel [Fri, 1 Apr 2016 17:10:45 +0000 (10:10 -0700)]
Update vulkan format features in caps.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847963003
Review URL: https://codereview.chromium.org/
1847963003
robertphillips [Fri, 1 Apr 2016 16:28:51 +0000 (09:28 -0700)]
Update SkImageSource to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842243002
Review URL: https://codereview.chromium.org/
1842243002
senorblanco [Fri, 1 Apr 2016 16:24:48 +0000 (09:24 -0700)]
Fix padding bug in SkTileImageFilter.
When padding an image out to tile size, use the filter input, not the
source primitive.
NOTE: this will affect the tileimagefilter GM (new test case & size).
R=robertphillips@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853803003
Review URL: https://codereview.chromium.org/
1853803003
bsalomon [Fri, 1 Apr 2016 16:04:35 +0000 (09:04 -0700)]
Delete duplicate null GL interface implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1846253002
Review URL: https://codereview.chromium.org/
1846253002
egdaniel [Fri, 1 Apr 2016 15:47:35 +0000 (08:47 -0700)]
Initialize variable to appease compiler warning
TBR=bsalomon@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854773002
Review URL: https://codereview.chromium.org/
1854773002
bsalomon [Fri, 1 Apr 2016 15:40:55 +0000 (08:40 -0700)]
Respect build type arg in build_shaderc.py
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1854733004
Review URL: https://codereview.chromium.org/
1854733004
robertphillips [Fri, 1 Apr 2016 15:09:44 +0000 (08:09 -0700)]
Revert of Switch SkDownSampleImageFilter over to new onFilterImage interface (patchset #2 id:20001 of https://codereview.chromium.org/
1851583002/ )
Reason for revert:
Some images are incorrect
Original issue's description:
> Switch SkDownSampleImageFilter over to new onFilterImage interface
>
> This will slightly change the testimagefilters GM images
>
> TBR=reed@google.com
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
>
> Committed: https://skia.googlesource.com/skia/+/
daa9da4937b6dfc9e1047239b4afd41b1c5474d5
TBR=senorblanco@chromium.org,reed@google.com,senorblanco@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1853823002
bsalomon [Fri, 1 Apr 2016 14:42:05 +0000 (07:42 -0700)]
Restore Vulkan setup code accidentally reverted in GrContextFactory.cpp
TBR=egdaniel@google.com,jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1852553004
Review URL: https://codereview.chromium.org/
1852553004
borenet [Fri, 1 Apr 2016 14:18:27 +0000 (07:18 -0700)]
Support for Android Swarming bots
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1819033002
Review URL: https://codereview.chromium.org/
1819033002
robertphillips [Fri, 1 Apr 2016 14:13:42 +0000 (07:13 -0700)]
Switch SkMatrixImageFilter over to new onFilterImage interface
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847953003
Review URL: https://codereview.chromium.org/
1847953003
robertphillips [Fri, 1 Apr 2016 14:13:23 +0000 (07:13 -0700)]
Switch SkDownSampleImageFilter over to new onFilterImage interface
This will slightly change the testimagefilters GM images
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1851583002
Review URL: https://codereview.chromium.org/
1851583002
benjaminwagner [Fri, 1 Apr 2016 13:54:34 +0000 (06:54 -0700)]
Add SK_SUPPORT_LEGACY_IMAGEFILTER_PTR to public.bzl DEFINES to fix build.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1853773002
Review URL: https://codereview.chromium.org/
1853773002
bsalomon [Fri, 1 Apr 2016 13:06:20 +0000 (06:06 -0700)]
Simplify GrDrawBatch uploads and token uage.
GrVertexBatch subclasses no longer need "initDraw".
Simplifies GrTestBatch
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1835283002
Review URL: https://codereview.chromium.org/
1835283002
benjaminwagner [Fri, 1 Apr 2016 12:00:51 +0000 (05:00 -0700)]
In public.bzl, change file locations after https://codereview.chromium.org/
1815823002
Depends on https://codereview.chromium.org/
1847923002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842363002
Review URL: https://codereview.chromium.org/
1842363002
mtklein [Fri, 1 Apr 2016 11:55:51 +0000 (04:55 -0700)]
sk_sp for SkCanvas::drawAnnotation()
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1849703003
Review URL: https://codereview.chromium.org/
1849703003
mtklein [Fri, 1 Apr 2016 11:55:47 +0000 (04:55 -0700)]
fix typo: add missing const
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1848533004
Review URL: https://codereview.chromium.org/
1848533004
bsalomon [Fri, 1 Apr 2016 11:50:45 +0000 (04:50 -0700)]
Add CreatePlatformGLTestContext_none.cpp for Google3 build
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847923002
Review URL: https://codereview.chromium.org/
1847923002
kkinnunen [Fri, 1 Apr 2016 11:50:37 +0000 (04:50 -0700)]
Remove ownership parameter from GrResourceProvider::wrapBackendTextureAsRenderTarget
Remove ownership parameter from
GrResourceProvider::wrapBackendTextureAsRenderTarget.
The function leaks the texture id if kAdopt_LifeCycle is passed.
There is no public API to access the parameter.
BUG=594928
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842313003
Review URL: https://codereview.chromium.org/
1842313003
Brian Salomon [Thu, 31 Mar 2016 18:30:08 +0000 (14:30 -0400)]
Fix compilation of GLTestContext_angle.cpp"
TBR=robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1850783003
BUG=skia:
Review URL: https://codereview.chromium.org/
1850783003 .
bsalomon [Thu, 31 Mar 2016 17:59:06 +0000 (10:59 -0700)]
rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
rename subclasses
Fix up the EGL native GLTestContext
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1849463002
TBR=jvanverth@google.com
Committed: https://skia.googlesource.com/skia/+/
4c7f0a16312c374eba4e8d5d46435ce9eb0b9971
Review URL: https://codereview.chromium.org/
1849463002
halcanary [Thu, 31 Mar 2016 17:35:13 +0000 (10:35 -0700)]
Fiddle: update to new GrGLAssembleInterface API
NOTRY=true
TBR=
Review URL: https://codereview.chromium.org/
1849753003
robertphillips [Thu, 31 Mar 2016 17:27:26 +0000 (10:27 -0700)]
Revert of Add unit repeat tiler (patchset #4 id:60001 of https://codereview.chromium.org/
1837893004/ )
Reason for revert:
ASAN bot failures
Original issue's description:
> Add unit repeat tiler.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1837893004
>
> Committed: https://skia.googlesource.com/skia/+/
865a289bfec169cb19970c734e9aa855c267f060
TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1844713005
bsalomon [Thu, 31 Mar 2016 17:22:40 +0000 (10:22 -0700)]
Revert of rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext (patchset #5 id:80001 of https://codereview.chromium.org/
1849463002/ )
Reason for revert:
breaking bots
Original issue's description:
> rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
>
> rename subclasses
>
> Fix up the EGL native GLTestContext
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1849463002
>
> TBR=jvanverth@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
4c7f0a16312c374eba4e8d5d46435ce9eb0b9971
TBR=jvanverth@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1850543003
bsalomon [Thu, 31 Mar 2016 17:22:20 +0000 (10:22 -0700)]
Expose GrGLAssembleInterface
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842363003
Review URL: https://codereview.chromium.org/
1842363003
bsalomon [Thu, 31 Mar 2016 17:07:23 +0000 (10:07 -0700)]
rename sk_gpu_test::GLContext to sk_gpu_test::GLTestContext
rename subclasses
Fix up the EGL native GLTestContext
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1849463002
TBR=jvanverth@google.com
Review URL: https://codereview.chromium.org/
1849463002
robertphillips [Thu, 31 Mar 2016 16:05:49 +0000 (09:05 -0700)]
Update SkOffsetImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842193002
Review URL: https://codereview.chromium.org/
1842193002
herb [Thu, 31 Mar 2016 15:48:21 +0000 (08:48 -0700)]
Add unit repeat tiler.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1837893004
Review URL: https://codereview.chromium.org/
1837893004
bungeman [Thu, 31 Mar 2016 15:30:38 +0000 (08:30 -0700)]
Add 'P' to SampleApp to cycle through pixel geometries.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834243002
Review URL: https://codereview.chromium.org/
1834243002
msarett [Thu, 31 Mar 2016 15:25:19 +0000 (08:25 -0700)]
Remode dead code from SkReadBuffer
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845283002
Review URL: https://codereview.chromium.org/
1845283002
senorblanco [Thu, 31 Mar 2016 15:24:29 +0000 (08:24 -0700)]
Image filters: fix crop rect application in SkXfermodeImageFilter.
The crop rect was being incorrectly applied in SkXfermodeImageFilter:
the background and foreground bounds were having the crop rect applied
individually to them, and then unioned. The correct approach is to take
the union of their bounds, and apply the crop rect to that. (A similar
bug in SkMergeImageFilter was fixed a while back.)
This is important when applying a compositing mode
which affects pixels outside the foreground bounds
(e.g., SrcIn, SrcOut).
NOTE: this will change the results of the xfermodeimagefilter GM (new
test case).
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842033005
Review URL: https://codereview.chromium.org/
1842033005
kkinnunen [Thu, 31 Mar 2016 15:08:20 +0000 (08:08 -0700)]
Fix Vulkan tests after GrContextFactory move to sk_gpu_test
Fix Vulkan tests after GrContextFactory move to sk_gpu_test
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1844983003
Review URL: https://codereview.chromium.org/
1844983003
halcanary [Thu, 31 Mar 2016 14:33:57 +0000 (07:33 -0700)]
SkPDF: Use Pathops clipping
Turn this on all the time. Remove the SK_PDF_USE_PATHOPS_CLIPPING
define that used to hide this functionality.
All rendering tests are the same or improved by this.
Also, remove non-functional SK_ALLOW_LARGE_PDF_SCALARS.
TBR=reed@google.com
removing dead #defines from SkUserConfig.h
BUG=591805
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845623002
Review URL: https://codereview.chromium.org/
1845623002
halcanary [Thu, 31 Mar 2016 13:59:00 +0000 (06:59 -0700)]
SkPDF: Make magic make sense
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1849453004
Review URL: https://codereview.chromium.org/
1849453004
egdaniel [Thu, 31 Mar 2016 13:16:31 +0000 (06:16 -0700)]
Update shaderc to ToT.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847643002
Review URL: https://codereview.chromium.org/
1847643002
benjaminwagner [Thu, 31 Mar 2016 13:13:22 +0000 (06:13 -0700)]
Make SkRandom::next[US]Fixed1 private; update documentation for SkRandom::nextSScalar1.
SkRandom is unused in Chromium, Android, Mozilla, and Google3.
SkRandom::nextSScalar1 and LCGRandom::nextSScalar1 appear to me by inspection to potentially return -1, so I updated the documentation to match.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1846773002
Review URL: https://codereview.chromium.org/
1846773002
brucedawson [Thu, 31 Mar 2016 12:53:44 +0000 (05:53 -0700)]
Fix C4334 warning about 32-bit shift assigned to 64-bits
VS 2015 has a new or louder warning about 32-bit shifts that are then
assigned to a 64-bit target. This type of code triggers it:
int64_t size = 1 << shift_amount;
Because the '1' being shifted is a 32-bit int the result of the shift
will be a 32-bit result, so assigning it to a 64-bit variable is just
misleading.
In this case the code that triggers it is this:
size_t alloc = 1<<fLgSize++;
The destination is a size_t so the warning only shows up on 64-bit
builds and doesn't indicate a real bug. But, casting the '1' constant
to size_t makes the behavior/intent more obvious and consistent and
allows enabling C4334 in Chromium.
BUG=593448
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1845123002
Review URL: https://codereview.chromium.org/
1845123002
Brian Salomon [Thu, 31 Mar 2016 03:20:09 +0000 (23:20 -0400)]
Make skgputest target depend on gl/glx/glu or egl/gles2 libs on linux
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1846623003
Review URL: https://codereview.chromium.org/
1846623003 .
bsalomon [Thu, 31 Mar 2016 01:56:19 +0000 (18:56 -0700)]
Move SkGLContext and some GrGLInterface implementations to skgputest module
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1815823002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Committed: https://skia.googlesource.com/skia/+/
fe3456cb006110d045b26ff3f8681b893a757b58
Review URL: https://codereview.chromium.org/
1815823002
robertphillips [Wed, 30 Mar 2016 20:34:16 +0000 (13:34 -0700)]
Update SkMergeImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1847583002
Review URL: https://codereview.chromium.org/
1847583002
halcanary [Wed, 30 Mar 2016 19:59:14 +0000 (12:59 -0700)]
SkPDF: SkTypeface::openStream could return nullptr
Speculative fix for hard-to-reproduce bug.
BUG=163892
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842163002
Review URL: https://codereview.chromium.org/
1842163002
robertphillips [Wed, 30 Mar 2016 19:32:58 +0000 (12:32 -0700)]
Update SkComposeImageFilter to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1841233002
Review URL: https://codereview.chromium.org/
1841233002
egdaniel [Wed, 30 Mar 2016 19:06:48 +0000 (12:06 -0700)]
Enable dual source blending for Vulkan
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1837213003
Review URL: https://codereview.chromium.org/
1837213003
msarett [Wed, 30 Mar 2016 19:01:47 +0000 (12:01 -0700)]
Correct png inverse gAMA when parsing color space
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1829433002
Review URL: https://codereview.chromium.org/
1829433002
brianosman [Wed, 30 Mar 2016 18:19:36 +0000 (11:19 -0700)]
Enable gpusrgb config on bots.
Don't run the config if we can't get a context with srgb support.
Includes a unit test for that logic.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1846603002
Review URL: https://codereview.chromium.org/
1846603002
robertphillips [Wed, 30 Mar 2016 16:26:24 +0000 (09:26 -0700)]
Revert of Move SkGLContext and some GrGLInterface implementations to skgputest module (patchset #13 id:240001 of https://codereview.chromium.org/
1815823002/ )
Reason for revert:
red bots
Original issue's description:
> Move SkGLContext and some GrGLInterface implementations to skgputest module
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1815823002
> CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
fe3456cb006110d045b26ff3f8681b893a757b58
TBR=jvanverth@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1845473004
bsalomon [Wed, 30 Mar 2016 15:35:09 +0000 (08:35 -0700)]
Move SkGLContext and some GrGLInterface implementations to skgputest module
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1815823002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1815823002
halcanary [Wed, 30 Mar 2016 15:31:27 +0000 (08:31 -0700)]
DM: allow vias to work with PDF backend
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1837263007
Review URL: https://codereview.chromium.org/
1837263007
djsollen [Wed, 30 Mar 2016 15:28:02 +0000 (08:28 -0700)]
Force include test to run on every compile.
Also fix the tool to stop looking in the src dir for includes.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1839123004
Review URL: https://codereview.chromium.org/
1839123004
robertphillips [Wed, 30 Mar 2016 15:09:56 +0000 (08:09 -0700)]
Update Morphology image filter to store its type
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834953002
Review URL: https://codereview.chromium.org/
1834953002
borenet [Wed, 30 Mar 2016 14:41:32 +0000 (07:41 -0700)]
Fixes for Swarming recipes
BUG=skia:4763
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1827413002
NOTRY=true
Review URL: https://codereview.chromium.org/
1827413002
robertphillips [Wed, 30 Mar 2016 14:32:28 +0000 (07:32 -0700)]
Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842793002
Committed: https://skia.googlesource.com/skia/+/
a33cf07a2273315363c0b6fb5d3ce811742f5a85
Review URL: https://codereview.chromium.org/
1842793002
brianosman [Wed, 30 Mar 2016 13:30:46 +0000 (06:30 -0700)]
Blacklist shapes benchmarks on Mali400 bot.
BUG=skia:4966
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1839193002
Review URL: https://codereview.chromium.org/
1839193002
cdalton [Wed, 30 Mar 2016 03:05:07 +0000 (20:05 -0700)]
Add test configs for nvpr with atlas text
Adds nvpr4 and nvpr16, which use nvpr for paths and atlas for text.
Renames nvprmsaa4 and nvprmsaa16 to nvprdit4, nvprdit16. These use nvpr
for both paths and text.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1834693002
Review URL: https://codereview.chromium.org/
1834693002
djsollen [Wed, 30 Mar 2016 02:07:07 +0000 (19:07 -0700)]
Revert of Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp (patchset #6 id:100001 of https://codereview.chromium.org/
1842793002/ )
Reason for revert:
This CL is causing the autoroll into Chromium & google3 to fail.
Original issue's description:
> Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp
>
> TBR=reed@google.com
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842793002
>
> Committed: https://skia.googlesource.com/skia/+/
a33cf07a2273315363c0b6fb5d3ce811742f5a85
TBR=fmalita@chromium.org,reed@google.com,robertphillips@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1837293003
herb [Tue, 29 Mar 2016 21:48:44 +0000 (14:48 -0700)]
Add repeatSpan and change interface name.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1841793002
Review URL: https://codereview.chromium.org/
1841793002
robertphillips [Tue, 29 Mar 2016 20:54:26 +0000 (13:54 -0700)]
Switch SkLocalMatrixImageFilter and SkPaintImageFilter over to sk_sp
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842793002
Review URL: https://codereview.chromium.org/
1842793002
jcgregorio [Tue, 29 Mar 2016 19:29:19 +0000 (12:29 -0700)]
fiddle: Only output errors to stderr.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1843733002
Review URL: https://codereview.chromium.org/
1843733002
reed [Tue, 29 Mar 2016 18:32:50 +0000 (11:32 -0700)]
switch xfermodes over to sk_sp
waiting on https://codereview.chromium.org/
1835163002/
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1832223002
Review URL: https://codereview.chromium.org/
1832223002
brianosman [Tue, 29 Mar 2016 18:27:20 +0000 (11:27 -0700)]
Dirty mipmaps whenever we upload new contents for a texture.
Found a bug where we rendered with two identically sized textures. On
the first frame, everything worked. On subsequent frames, we would get
the other texture from the cache, causing us to inherit the mips from
the wrong texture.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1836143003
Review URL: https://codereview.chromium.org/
1836143003
halcanary [Tue, 29 Mar 2016 17:10:24 +0000 (10:10 -0700)]
SkPDF: skia_pdf_less_compression - for debugging only
Motivation: as we implement more features in PDF, it would be nice to more easily see what is happening in the output. This change serializes page content as plain text rather than compressed text, but it has to be explicitly enabled with a GYP_DEFINE change:
export GYP_DEFINES='skia_pdf_less_compression=1'
bin/sync-and-gyp
ninja -C out/Debug dm
out/Debug/dm --config pdf --src gm -w /tmp
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1840103002
Review URL: https://codereview.chromium.org/
1840103002
halcanary [Tue, 29 Mar 2016 16:09:29 +0000 (09:09 -0700)]
SkPDF: milestone in metadata, also SkMilestone.h
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1823753002
Review URL: https://codereview.chromium.org/
1823753002
halcanary [Tue, 29 Mar 2016 16:03:52 +0000 (09:03 -0700)]
Style bikeshed - remove extraneous whitespace
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842753002
Review URL: https://codereview.chromium.org/
1842753002
kjlubick [Tue, 29 Mar 2016 12:50:41 +0000 (05:50 -0700)]
Prevent waiting for charge twice
BUG=skia:5111
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1840003002
Review URL: https://codereview.chromium.org/
1840003002
bsalomon [Mon, 28 Mar 2016 22:04:45 +0000 (15:04 -0700)]
Fix GrConvexPolyEffect to deal with line paths.
BUG=skia:4727
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1839743002
Review URL: https://codereview.chromium.org/
1839743002
msarett [Mon, 28 Mar 2016 20:57:10 +0000 (13:57 -0700)]
Delete SkImageDecoder_empty
We no longer need this now that the Chrome build files have been
updated to use SkImageEncoder_none (which is an identical file).
TBR=djsollen@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1832363002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/
1832363002
benjaminwagner [Mon, 28 Mar 2016 20:27:28 +0000 (13:27 -0700)]
Remove GLFW from public.bzl.
Added in https://codereview.chromium.org/
1842463002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1835363002
Review URL: https://codereview.chromium.org/
1835363002
robertphillips [Mon, 28 Mar 2016 20:13:42 +0000 (13:13 -0700)]
Swap SkPictureImageFilter's factories over to smart pointers
A trial balloon before converting the rest
This requires https://codereview.chromium.org/
1836443003/ (add SK_SUPPORT_LEGACY_IMAGEFILTER_PTR flag for future skia CL) to land in Chromium first
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1831323003
Review URL: https://codereview.chromium.org/
1831323003
mtklein [Mon, 28 Mar 2016 19:43:39 +0000 (12:43 -0700)]
We meant these to be YES... sigh.
This will dramatically improve link times with XCode 7.3.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1835303003
Review URL: https://codereview.chromium.org/
1835303003
egdaniel [Mon, 28 Mar 2016 19:39:29 +0000 (12:39 -0700)]
Change VkPipelineStateCahce to use Hash and LRU LList.
This simplifies the caching code and forms the base for a caching template
that will be easier to use for other objects within Vulkan.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1836863002
Review URL: https://codereview.chromium.org/
1836863002
bsalomon [Mon, 28 Mar 2016 19:25:09 +0000 (12:25 -0700)]
Remove the GrGLInterface callback mechanism.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1836013002
Review URL: https://codereview.chromium.org/
1836013002
benjaminwagner [Mon, 28 Mar 2016 19:25:04 +0000 (12:25 -0700)]
Remove advance[XY]Fixed getters.
Reverts https://codereview.chromium.org/
1772863002 after updating Android.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1842453002
Review URL: https://codereview.chromium.org/
1842453002
projects / platform / upstream / libSkiaSharp.git / log