platform/upstream/dotnet/runtime.git
2 years ago[Tizen] Crossgen all dlls in clr test dir
Gleb Balykov [Mon, 13 Dec 2021 09:12:35 +0000 (12:12 +0300)]
[Tizen] Crossgen all dlls in clr test dir

2 years ago[Tizen] Do not pack not needed R2RDump libs on arm/arm64
Gleb Balykov [Mon, 20 Dec 2021 15:47:03 +0000 (18:47 +0300)]
[Tizen] Do not pack not needed R2RDump libs on arm/arm64

2 years ago[Tizen] Add ni.dll.tmp files in order to not interfere with crossgen2
Gleb Balykov [Wed, 15 Dec 2021 11:21:46 +0000 (14:21 +0300)]
[Tizen] Add ni.dll.tmp files in order to not interfere with crossgen2

Consequnce of this is that crossgen2 libs itself can be safely compiled with --inputbubble option

2 years ago[Tizen] Add coreclr crossgen2 skips for TM1/TW3 for armel
Gleb Balykov [Fri, 10 Dec 2021 14:19:42 +0000 (17:19 +0300)]
[Tizen] Add coreclr crossgen2 skips for TM1/TW3 for armel

These are mostly a subset of src/tests/issues.targets with some additional excludes:

- crossgen2 for HugeField1, b71005, b311420 get killed
- BasicTestWithMcj is skipped because it manually invokes crossgen2

2 years ago[Tizen] Add coreclr skips for TM1/TW3 for armel
Gleb Balykov [Fri, 10 Dec 2021 13:36:58 +0000 (16:36 +0300)]
[Tizen] Add coreclr skips for TM1/TW3 for armel

These are mostly a subset of src/tests/issues.targets with some additional excludes:

- readytorun/r2rdump/FrameworkTests/R2RDumpTests/R2RDumpTests is excluded because System.Private.CoreLib.dll is not a r2r image in default mode
- hugeexpr1, releaseondetach, HugeField2, test16 get killed

2 years ago[Tizen] Add method to write coredump of .NET process
Mateusz Moscicki [Mon, 21 Jun 2021 16:12:54 +0000 (18:12 +0200)]
[Tizen] Add method to write coredump of .NET process

This method allows to create minimal coredump (as createdump does) of a
process that is in dumping state after crush.

Original commit:
https://github.sec.samsung.net/dotnet/coreclr/commit/66a3b803910b389de38703ce349695a247146f5b

2 years ago[Tizen] Enable pgo for armel
Gleb Balykov [Thu, 9 Dec 2021 13:56:28 +0000 (16:56 +0300)]
[Tizen] Enable pgo for armel

---------------------------
I. How to get pgo profiles:
---------------------------

1. Rebuild coreclr in instrumentation mode (set pgo_instrument to 1 in coreclr.spec in case of gbs build)

2. Setup device (tw3) correctly, pgo profiling setup should match setup of device for perf measurements:

  a) generate ni.dll using crossgen2 for all dlls from /usr/share/dotnet.tizen/netcoreapp, /usr/share/dotnet.tizen/framework and for all apps:

    for pgo profiles gathered in this commit next crossgen2 options are used: --jitpath /usr/share/dotnet.tizen/netcoreapp/libclrjit.so --targetarch armel -O --compilebubblegenerics --inputbubble

  b) install plugin-prebuilt

3. Run applications using instrumented coreclr in standalone mode:

  For pgo profiles gathered in this commit next apps were used: Alarm, Calculator, XStopWatch.

  To launch apps use app_launcher -e, then terminate app with app_launcher -t.

  Profile data will be stored in /tmp/clrjit-<pid>.profdata and /tmp/coreclr-<pid>.profdata files. It's possible to change filename using LLVM_PROFILE_FILE environment variable (both for clrjit and coreclr).

4. Merge profile data:

  $ llvm-profdata merge -output=/tmp/coreclr.profdata /tmp/coreclr-*.profdata
  $ llvm-profdata merge -output=/tmp/clrjit.profdata /tmp/clrjit-*.profdata

----------------------------
II. How to use pgo profiles:
----------------------------

1. Put profile data in ./pgodata/<arch>/data

  Be sure to verify there are no lines about PGO or LTO in gbs build log! Otherwise pgo profiles are placed incorrectly!

2. Rebuild coreclr with disabled pgo_instrument and enabled pgo_optimized (PGO is disabled by default)

2 years ago[Tizen] Add corerun to coreclr pkg
Woongsuk Cho [Mon, 13 Sep 2021 00:25:28 +0000 (09:25 +0900)]
[Tizen] Add corerun to coreclr pkg

2 years ago[x86/Linux] Fix SIGSEGV on Debugger.Break() during debugging.
Mikhail Kurinnoi [Thu, 23 Sep 2021 14:56:40 +0000 (07:56 -0700)]
[x86/Linux] Fix SIGSEGV on Debugger.Break() during debugging.

SIGSEGV occur in src/vm/i386/cgenx86.cpp `HelperMethodFrame::UpdateRegDisplay()` at line `pRD->pCurrentContext->Eip = pRD->ControlPC = m_MachState.GetRetAddr();`, since `pRD->pCurrentContext` is NULL.
The point of issue - wrong code block compilation in DebuggerWalkStack() in case of Linux x86.

2 years ago#58181 Fix NullReferenceException in crossgen2. (#58183)
Mikhail Filippov [Fri, 10 Sep 2021 16:12:04 +0000 (19:12 +0300)]
#58181 Fix NullReferenceException in crossgen2. (#58183)

* #58181 Fix NullReferenceException in crossgen2.

* Support .exe extension in output filename.

2 years agoUse temporary ni.dll.tmp files with crossgen2 pipeline mode in order to not interfere...
Gleb Balykov [Wed, 1 Sep 2021 22:08:02 +0000 (01:08 +0300)]
Use temporary ni.dll.tmp files with crossgen2 pipeline mode in order to not interfere with crossgen2 itself (#57341)

* Use temporary ni.dll.tmp files with crossgen2 pipeline mode in order to not interfere with crossgen2 itself

* Add check that --single-file-compilation mode of crossgen2 is always used with --out-near-input

2 years agoFix x86 linux tests build and run
Timur Mustafin [Tue, 13 Jul 2021 19:51:59 +0000 (22:51 +0300)]
Fix x86 linux tests build and run

[unix x86] Fix tests build
[unix x86] Add register map for crossgen2
            Fixes readytorun/coreroot_determinism/coreroot_determinism/coreroot_determinism.sh on x86 linux
[unix x86] Fix tail calls tests
[unix x86] Fix unmanaged callconv
[unix x86] Fix passing implicit args via stack
[unix x86] Pop hidden retbuff arg on cdecl callconv
[unix x86] Fix WriteBarrier call

[x86] Add calling convention name print to dump
[x86] Use ebx to pass VASigCookie to GenericPInvokeCalliHelper
            It fixes stack alignment in GenericPInvokeCalliHelper on unix x86

Fix storageType overflow assertion in TinyArray

2 years ago[Tizen] Disable FEATURE_DLG_INVOKE and FEATURE_FAST_CREATE in System.Linq.Expression
Hyungju Lee [Wed, 24 Apr 2019 08:24:15 +0000 (17:24 +0900)]
[Tizen] Disable FEATURE_DLG_INVOKE and FEATURE_FAST_CREATE in System.Linq.Expression

This increases memory consumption

2 years ago[Tizen] Disable staticfilehost for ASan build
Slava Barinov [Mon, 21 Jun 2021 14:21:47 +0000 (17:21 +0300)]
[Tizen] Disable staticfilehost for ASan build

Static binary is not supported by libasansi.so

Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2 years ago[Tizen] Enable ASan annotation of passing to native code buffers
Andrey Kazmin [Wed, 16 Jun 2021 13:49:18 +0000 (16:49 +0300)]
[Tizen] Enable ASan annotation of passing to native code buffers

Turn on ASan inteceptors while marshaling managed buffers to native code.
We could not properly annotate already allocated on heap buffers, so
we have to disable pinning of such objects.
Current patch affects only pinning of native arrays.

Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2 years ago[Tizen] Enable Tizen ASan runtime support
Vyacheslav Cherkashin [Wed, 16 Jun 2021 13:24:30 +0000 (16:24 +0300)]
[Tizen] Enable Tizen ASan runtime support

Enable libasansi.so support (libasan.so with switchable interceptors).

Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2 years ago[Tizen] Implement ASan wrapper for Linux AMD64
Vyacheslav Cherkashin [Wed, 16 Jun 2021 13:21:55 +0000 (16:21 +0300)]
[Tizen] Implement ASan wrapper for Linux AMD64

Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2 years ago[Tizen] Implement ASan wrapper for Linux ARM32
Vyacheslav Cherkashin [Wed, 16 Jun 2021 13:19:36 +0000 (16:19 +0300)]
[Tizen] Implement ASan wrapper for Linux ARM32

This commit implements wrappers that allow interception transitions
from managed to external unmanaged code (CIL -> native) and back
(native -> CIL). This allows enable/disable ASan during transitions.
Due to this, we sanitize only external code, which allows us to
achieve acceptable performance.

Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2 years ago[Tizen] Implement detecting of sanitized libraries
Andrey Drobyshev [Mon, 21 Jun 2021 07:10:17 +0000 (10:10 +0300)]
[Tizen] Implement detecting of sanitized libraries

Parse ".dynamic" section (ELF dynamic array tags) of the module being
added, find ".rel(a).plt" section and search it for presence of
'__asan_init' symbol.

Signed-off-by: Andrey Drobyshev <a.drobyshev@samsung.com>
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2 years ago[Tizen] Add new vconf to set runtime_version
j-h.choi [Tue, 8 Jun 2021 05:14:12 +0000 (14:14 +0900)]
[Tizen] Add new vconf to set runtime_version

2 years ago[Tizen] Use simple name without suffix in MulticoreJit
Gleb Balykov [Mon, 7 Jun 2021 07:52:00 +0000 (10:52 +0300)]
[Tizen] Use simple name without suffix in MulticoreJit

After this change name of resulting profile on disk matches the one passed with COMPlus_MultiCoreJitProfile env variable

2 years ago[Tizen] Reduce arm_phdr_cb call overhead
JUNG DONG-HEON [Thu, 9 Jan 2020 07:38:00 +0000 (16:38 +0900)]
[Tizen] Reduce arm_phdr_cb call overhead

- Too many calls to arm_phdr_cb even though it get the same data.
- It caches an ARM_CB_DATA for libcoreclr.so, then reuse.

2 years ago[Tizen] Disable jithost arena cache
Gleb Balykov [Fri, 2 Aug 2019 14:28:27 +0000 (17:28 +0300)]
[Tizen] Disable jithost arena cache

2 years ago[Tizen] Add coreclr_preload_assembly to CoreCLR host API
Gleb Balykov [Wed, 19 May 2021 17:13:49 +0000 (20:13 +0300)]
[Tizen] Add coreclr_preload_assembly to CoreCLR host API

This API allows to preload ni.dll (both simple and composite)

Restrictions:
- single file bundle can't be preloaded using this API
- images with huge pages (i.e. images with alignment > os page size) can't be preloaded using this API

!This patch should be rebased with caution, see comment for MAPApplyBaseRelocationsPreloadedPEFile!

Co-authored by k.baladurin@samsung.com

----

Simple change to tests coreclr preloading api on corerun (note the extra / for non-SPC dlls, it is needed because TPA list in corerun is created with extra / after dir name, i.e. "/home/z/Dev/runtime2/overlay_x64//System.Runtime.ni.dll" will be in tpa list, and argument of coreclr_preload_assembly must match it exactly). TPA list in dotnet/launcher is created without extra /.

diff --git a/src/coreclr/hosts/corerun/corerun.cpp b/src/coreclr/hosts/corerun/corerun.cpp
index b3f2c867c30..33d446d1a32 100644
--- a/src/coreclr/hosts/corerun/corerun.cpp
+++ b/src/coreclr/hosts/corerun/corerun.cpp
@@ -288,6 +288,17 @@ static int run(const configuration& config)
         return -1;
     }

+    coreclr_preload_assembly_ptr coreclr_preload_assembly_func = nullptr;
+    if (!try_get_export(coreclr_mod, "coreclr_preload_assembly", (void**)&coreclr_preload_assembly_func))
+    {
+        return -1;
+    }
+
+
+    coreclr_preload_assembly_func("/home/z/Dev/runtime2/overlay_x64/System.Private.CoreLib.dll");
+    coreclr_preload_assembly_func("/home/z/Dev/runtime2/overlay_x64//System.Runtime.ni.dll");
+    coreclr_preload_assembly_func("/home/z/Dev/runtime2/overlay_x64//System.IO.ni.dll");
+
     // Construct CoreCLR properties.
     pal::string_utf8_t tpa_list_utf8 = pal::convert_to_utf8(std::move(tpa_list));
     pal::string_utf8_t app_path_utf8 = pal::convert_to_utf8(std::move(app_path));

2 years ago[Tizen] separate PIC and PIE to fix x86_64 build error
Woongsuk Cho [Thu, 9 May 2019 09:02:22 +0000 (18:02 +0900)]
[Tizen] separate PIC and PIE to fix x86_64 build error

2 years ago[Tizen] add pie linker option to createdump
Woongsuk Cho [Thu, 12 Dec 2019 11:41:39 +0000 (20:41 +0900)]
[Tizen] add pie linker option to createdump

2 years ago[Tizen] Add a config knob for importing ibc files
Swift Kim [Thu, 1 Aug 2019 06:10:49 +0000 (15:10 +0900)]
[Tizen] Add a config knob for importing ibc files

2 years ago[Tizen] Workaround Timing Issue
Hyungju Lee [Sun, 19 Apr 2020 22:19:32 +0000 (07:19 +0900)]
[Tizen] Workaround Timing Issue

To avoid an exception thrown on managed build
Context: dotnet/roslyn#37974 and dotnet/roslyn#38420

```
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error MSB3883: Unexpected exception:  [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : System.AggregateException: One or more errors occurred. (Object synchronization method was called from an unsynchronized block of code.) [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : ---> System.ApplicationException: Object synchronization method was called from an unsynchronized block of code. [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : at System.Threading.Mutex.ReleaseMutex() [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : at Microsoft.CodeAnalysis.CommandLine.ServerNamedMutex.Dispose() [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : at Microsoft.CodeAnalysis.CommandLine.BuildServerConnection.RunServerCompilationCore(RequestLanguage language, List`1 arguments, BuildPathsAlt buildPaths, String pipeName, String keepAlive, String libEnvVariable, Nullable`1 timeoutOverride, Func`3 tryCreateServerFunc, CancellationToken cancellationToken) [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : --- End of inner exception stack trace --- [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken) [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : at System.Threading.Tasks.Task.Wait(CancellationToken cancellationToken) [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
[  336s] /home/abuild/rpmbuild/BUILD/corefx-3.1.0/packages/microsoft.net.compilers.toolset/3.3.0-beta2-19367-02/tasks/netcoreapp2.1/Microsoft.CSharp.Core.targets(58,5): error : at Microsoft.CodeAnalysis.BuildTasks.ManagedCompiler.ExecuteTool(String pathToTool, String responseFileCommands, String commandLineCommands) [/home/abuild/rpmbuild/BUILD/corefx-3.1.0/src/System.ComponentModel/src/System.ComponentModel.csproj]
```

2 years ago[Tizen] skip dotnet specific arguments in corerun
Konstantin Baladurin [Fri, 4 Oct 2019 16:45:44 +0000 (19:45 +0300)]
[Tizen] skip dotnet specific arguments in corerun

Now we use corerun to run corefx tests instead of dotnet, because last
one isn't available for Tizen/armel. So we need to skip dotnet specific
arguments, we patch corerun for it because Microsoft.DotNet.RemoteExecutor
tries to execute binary that it gets from /proc/self/maps, so we need a
binary that will behave like dotnet.

2 years ago[Tizen] add access(2) call before dlopening files
Yaroslav Yamshchikov [Thu, 18 Jul 2019 10:14:14 +0000 (13:14 +0300)]
[Tizen] add access(2) call before dlopening files

2 years ago[Tizen] Disable IBC Logger as a default
DongHeon Jung [Thu, 18 Jul 2019 08:28:55 +0000 (17:28 +0900)]
[Tizen] Disable IBC Logger as a default

- Profile information is collected by ibc logger.
  Hower it is not used and saved into profile file.
- The patch disables IBC logger which is enabled by default.
- It disables IBC logger only with ibclogger.h file.
  IBCLOGGER_ENABLED definition is only used in ibclogger files.

2 years ago[Tizen] Update .gitignore
Hyungju Lee [Wed, 13 Mar 2019 00:28:54 +0000 (09:28 +0900)]
[Tizen] Update .gitignore

2 years ago[Tizen] Fix OOPStackUnwinderX86::Unwind crash when Eip is invalid
Igor Kulaychuk [Wed, 25 Apr 2018 18:31:59 +0000 (21:31 +0300)]
[Tizen] Fix OOPStackUnwinderX86::Unwind crash when Eip is invalid

2 years ago[Tizen] Fix EECodeManager::GetAmbientSP on x86/Linux
Igor Kulaychuk [Fri, 20 Apr 2018 20:52:57 +0000 (23:52 +0300)]
[Tizen] Fix EECodeManager::GetAmbientSP on x86/Linux

2 years ago[Tizen] Add -pie to linker option
Hyungju Lee [Mon, 2 Jul 2018 00:28:08 +0000 (09:28 +0900)]
[Tizen] Add -pie to linker option

There have been no -pie linker option.
This patch adds -pie linker option into crossgen(for tizen)

This originates from 0024-Add-pie-to-linker-option.patch

2 years ago[Tizen] Add support for gbs build for i586, x86_64, armv7l, aarch64 (including tests)
Gleb Balykov [Mon, 12 Apr 2021 20:13:24 +0000 (23:13 +0300)]
[Tizen] Add support for gbs build for i586, x86_64, armv7l, aarch64 (including tests)

2 years agoFix linux x86 build error (partial cherry-pick of https://github.com/dotnet/runtime...
Gleb Balykov [Tue, 7 Dec 2021 13:28:24 +0000 (16:28 +0300)]
Fix linux x86 build error (partial cherry-pick of https://github.com/dotnet/runtime/pull/60817)

2 years ago[Tizen] Hardcode LD_GNU for tizen
Gleb Balykov [Tue, 7 Dec 2021 09:12:31 +0000 (12:12 +0300)]
[Tizen] Hardcode LD_GNU for tizen

2 years ago[Tizen] Add coreclr tests build dependencies v6.0.0
Gleb Balykov [Mon, 6 Dec 2021 20:49:45 +0000 (23:49 +0300)]
[Tizen] Add coreclr tests build dependencies v6.0.0

To add these files do next steps:
1. Remove .gitignore
2. Remove all previous build artifacts and non-used files (make output of "git status" clear)
3. export NUGET_PACKAGES=`pwd`/.packages
4. Cross build coreclr tests for armel/arm64/x86 and x64
5. Commit .packages

Notes:
- If some of these nuget packages are not commited or missed for other reasons, gbs build will fail.

2 years ago[Tizen] Add prebuilt libicu-57.1 libraries for x64
Gleb Balykov [Mon, 12 Apr 2021 14:20:02 +0000 (17:20 +0300)]
[Tizen] Add prebuilt libicu-57.1 libraries for x64

These are required for x64 BuildTools in order to run under gbs.

2 years ago[Tizen] Add nuget packages for corefx-managed-ref for clr <= 3.1
Gleb Balykov [Mon, 12 Apr 2021 14:43:01 +0000 (17:43 +0300)]
[Tizen] Add nuget packages for corefx-managed-ref for clr <= 3.1

These are nuget packages, which are used during application build.
To generate these, build TizenFX and put downloaded nuget packages in nuget/ dir.

2 years ago[Tizen] Add x64 BuildTools v6.0.0
Gleb Balykov [Mon, 6 Dec 2021 19:58:08 +0000 (22:58 +0300)]
[Tizen] Add x64 BuildTools v6.0.0

To add these files do next steps:
1. Remove .gitignore
2. Remove all previous build artifacts and non-used files (make output of "git status" clear)
3. export NUGET_PACKAGES=`pwd`/.packages
4. Cross build runtime for required arches (armel, arm64, x86) and build for x64
5. Commit .dotnet, .packages

Notes:
- If some dir names change in future, this will be seen in "git status" after step 4. Add those dirs too.
- If some of these dirs are not commited or missed for other reasons, gbs build will fail.
- These build tools are for x64, thus, gbs build without clang-accel is not supported.

3 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20211022.3 (#60783)
dotnet-maestro[bot] [Fri, 22 Oct 2021 20:27:45 +0000 (13:27 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20211022.3 (#60783)

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21519.3 -> To Version 6.0.0-beta.21522.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years ago[release/6.0] [wasm][debugger] Fix loading a non wasm page and then returning to...
github-actions[bot] [Fri, 22 Oct 2021 20:21:03 +0000 (13:21 -0700)]
[release/6.0] [wasm][debugger] Fix loading a non wasm page and then returning to a wasm page. (#60777)

* Fix loading a non wasm page and then returning to a wasm page.

* Adding non-wasm-page.html

* fixing other method

* addressing @radical comments

* adding last empty line

Co-authored-by: DESKTOP-GEPIA6N\Thays <thaystg@gmail.com>
3 years ago[release/6.0] Create a parent CMake project for building app bundles on CI (#59154)
github-actions[bot] [Thu, 21 Oct 2021 18:43:50 +0000 (14:43 -0400)]
[release/6.0] Create a parent CMake project for building app bundles on CI (#59154)

Backport of #58965 to release/6.0

This allows us to not run the CMake configure step separately for each libraries test suite which speeds up the build.

Helps with #58549

3 years ago[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk (#60684)
dotnet-maestro[bot] [Thu, 21 Oct 2021 15:07:10 +0000 (08:07 -0700)]
[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk (#60684)

* Update dependencies from https://github.com/dotnet/icu build 20211019.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-rtm.21515.1 -> To Version 6.0.0-rtm.21519.1

* Update dependencies from https://github.com/dotnet/emsdk build 20211020.1

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0 -> To Version 6.0.0

* Update dependencies from https://github.com/dotnet/emsdk build 20211020.3

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0 -> To Version 6.0.0

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years ago[release/6.0] Tweak workload build to use _GenerateMsiVersionString target (#60695)
github-actions[bot] [Wed, 20 Oct 2021 22:36:28 +0000 (15:36 -0700)]
[release/6.0] Tweak workload build to use _GenerateMsiVersionString target (#60695)

* Tweak workload build to use _GenerateMsiVersionString target

Replaces GenerateVersions that wasn't quite accurate enough for what we need

* Pulled in arcade target that will be removed at a later date

* More tweaks

* Forget dependsontargets

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
3 years ago[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk dotnet/runtime-assets...
dotnet-maestro[bot] [Wed, 20 Oct 2021 14:00:53 +0000 (07:00 -0700)]
[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk dotnet/runtime-assets dotnet/arcade (#60495)

* Update dependencies from https://github.com/dotnet/runtime-assets build 20211015.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
 From Version 6.0.0-beta.21514.1 -> To Version 6.0.0-beta.21515.1

* Update dependencies from https://github.com/dotnet/arcade build 20211015.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21514.2 -> To Version 6.0.0-beta.21515.3

* Update dependencies from https://github.com/dotnet/icu build 20211015.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-rtm.21513.2 -> To Version 6.0.0-rtm.21515.1

* Update dependencies from https://github.com/dotnet/emsdk build 20211018.1

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0-rtm.21514.1 -> To Version 6.0.0

* Update dependencies from https://github.com/dotnet/emsdk build 20211018.2

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0-rtm.21514.1 -> To Version 6.0.0

* [wasm] Fix workload install for tests, with 6.0.0

Move to using the generated nuget.config, which has the feeds added by
darc. The target is a duplicate from
`src/installer/tests/PrepareTestAssets/PrepareTestAssets.proj`, and
should be moved to a common location in future.

Thanks to @lewing for the suggestion.

* [wasm] Remove unused bits

* Update dependencies from https://github.com/dotnet/runtime-assets build 20211018.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
 From Version 6.0.0-beta.21514.1 -> To Version 6.0.0-beta.21518.1

* Update dependencies from https://github.com/dotnet/arcade build 20211019.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21514.2 -> To Version 6.0.0-beta.21519.3

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
3 years ago[release/6.0] Don't special case "Experimental" projects (#60643)
github-actions[bot] [Tue, 19 Oct 2021 23:27:01 +0000 (16:27 -0700)]
[release/6.0] Don't special case "Experimental" projects (#60643)

* Don't special case "Experimental" projects

We only have one experimental project, System.Runtime.Experimental and
we want it to behave like any other package.

* Make coreclr packages use `IsShipping`

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
3 years ago[release/6.0] Fix stable builds for some transport packages (#60635)
Matt Mitchell [Tue, 19 Oct 2021 23:21:40 +0000 (16:21 -0700)]
[release/6.0] Fix stable builds for some transport packages (#60635)

* Fix stable builds for some transport packages
Some non-shipping transport and sources packages were getting incorrectly getting stable versions. This didn't show up in the servicing excercise, though they probably did the right thing for unrelated reasons.

* Fix transport package version by not using PackageVersion property on workloads-testing.targets

Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
3 years agoUpdate mac installers location string (#60500)
github-actions[bot] [Tue, 19 Oct 2021 17:08:51 +0000 (10:08 -0700)]
Update mac installers location string (#60500)

Co-authored-by: sfoslund <sfoslund@microsoft.com>
3 years ago[release/6.0] Enforce scatter/gather file I/O Windows API requirements et. al. (...
github-actions[bot] [Tue, 19 Oct 2021 17:02:56 +0000 (10:02 -0700)]
[release/6.0] Enforce scatter/gather file I/O Windows API requirements et. al. (#58423)

* Move checking and pinning Windows vectored I/O buffers to a dedicated method.

* Refactor the scatter/gather APIs to use the common checking method.

And use pinned GCHandles and IntPtrs instead of MemoryHandles when passing the segment array to the bottom-most method.

* Shorten the name of the buffer-checking method.

* Directly get the pinned array's address instead of calling GCHandle.AddrOfPinnedObject.

* Refactor the error handling logic in TryPrepareScatterGatherBuffers.

* Allocate the segment array from native memory and at TryPrepareScatterGatherBuffers.

* Cache the page size on a static readonly field and add a couple of TODOs.

* Make the memory handlers readonly structs.

* Add a test.

* Reorder some methods with PR feedback taken into consideration.

* Stop special-casing scatter/gather operations with zero or one buffer.

* Factor the cleaning-up of the segment buffers into a separate method.

* Follow up on Scatter/Gather API changes (#58447)

* Allocate an array of memory handles only if needed.

* Remove an unnecessary variable in the multiple-syscall write gather.

* Actually verify the content read by the read scatter operation.

* Delay allocating native memory.

* Verify that the whole file was read in the scatter/gather test.

* Test the case when the scatter/gather buffers are acceptable by the Windows API.

* Avoid null pointer dereferences when passing an empty segment array.

* Test performing scatter/gather I/O with an empty segment array.

Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Theodore Tsirpanis <teo.tsirpanis.718@gmail.com>
Co-authored-by: Theodore Tsirpanis <12659251+teo-tsirpanis@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
3 years ago[release/6.0] Use custom error message when running out of syncblocks (#60592)
github-actions[bot] [Tue, 19 Oct 2021 17:01:37 +0000 (10:01 -0700)]
[release/6.0] Use custom error message when running out of syncblocks (#60592)

* Use custom error message when running out of syncblocks

Contributes to #49215

* Update src/coreclr/dlls/mscorrc/mscorrc.rc

update message

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
3 years ago[release/6.0] Update IntelliSense package (#60621)
github-actions[bot] [Tue, 19 Oct 2021 17:01:06 +0000 (10:01 -0700)]
[release/6.0] Update IntelliSense package (#60621)

* Update IntelliSense package

* Fixed package version

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
3 years ago[release/6.0] Stabilize for RTM (#60294)
Matt Mitchell [Tue, 19 Oct 2021 01:53:32 +0000 (18:53 -0700)]
[release/6.0] Stabilize for RTM (#60294)

* Stabilize for RTM

* revert xunit version to fix MEDIspecificationTests package

* pass the correct wasm package version and disable the coreclr failing test

* Update wcf and system.data.sqlclient compat pack dependencies

* Update WCF dependencies

Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
3 years ago[release/6.0] Update THIRD-PARTY-NOTICES.TXT (#60092)
Nikola Milosavljevic [Mon, 18 Oct 2021 21:03:44 +0000 (14:03 -0700)]
[release/6.0] Update THIRD-PARTY-NOTICES.TXT (#60092)

* Update THIRD-PARTY-NOTICES.TXT

* Regenerating to incorporate a change in infra

* Fixes for duplicate instance and misplaced header

* Remove duplicate corefx header

3 years agoUpdate NetFramework.ReferenceAssemblies version to 1.0.2 (#60554)
Eric Erhardt [Mon, 18 Oct 2021 18:19:08 +0000 (13:19 -0500)]
Update NetFramework.ReferenceAssemblies version to 1.0.2 (#60554)

3 years agoRevert "Update IntelliSense package (#60488)" (#60567)
Anirudh Agnihotry [Mon, 18 Oct 2021 17:56:01 +0000 (10:56 -0700)]
Revert "Update IntelliSense package (#60488)" (#60567)

This reverts commit f39a90b2778665046d56b5699e89ff7f305bd353.

3 years agoUpdate IntelliSense package (#60488)
github-actions[bot] [Mon, 18 Oct 2021 17:42:22 +0000 (10:42 -0700)]
Update IntelliSense package (#60488)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
3 years ago[release/6.0] Fix Int32 overflow bug in buffering logic (#60460)
github-actions[bot] [Mon, 18 Oct 2021 16:06:27 +0000 (10:06 -0600)]
[release/6.0] Fix Int32 overflow bug in buffering logic (#60460)

* add a failing test

* fix the bug in BufferedFileStreamStrategy

* extend the test and fix it in the BufferedStream as well

* large files are currently not supported on WASM

* Apply suggestions from code review

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
* Exclude test from running in 32 bits

* fix the ConditionalFact attribute usage

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: David Cantu <dacantu@microsoft.com>
3 years ago[wasm] Fix typedef for non-void interp entry callbacks (#59990)
github-actions[bot] [Mon, 18 Oct 2021 05:07:24 +0000 (22:07 -0700)]
[wasm] Fix typedef for non-void interp entry callbacks (#59990)

For UnmanagedCallersOnly methods that return non-void, pass the address of the
return variable to the interp entry method.

Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
3 years ago[reflection] Initialize default ALC gchandle in GetLoadContext (#60399)
github-actions[bot] [Fri, 15 Oct 2021 23:59:37 +0000 (16:59 -0700)]
[reflection] Initialize default ALC gchandle in GetLoadContext (#60399)

If we try to get the ALC of an assembly from the default context before the
managed default ALC object has been created, the native gchandle has a null
target.
Ensure it is not null by explicitly referencing the Default ALC.

Fixes https://github.com/dotnet/runtime/issues/60348

Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
3 years ago[release/6.0] Remove duplicate entries from dotnet --info (#60446)
github-actions[bot] [Fri, 15 Oct 2021 22:09:32 +0000 (15:09 -0700)]
[release/6.0] Remove duplicate entries from dotnet --info (#60446)

* Remove duplicate entries from dotnet --info

* Remove trailing slashes from globally registered locations as well

* PR feedback

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: vitek-karas <vitek.karas@microsoft.com>
3 years ago[release/6.0] Apply custom Message and Url to all [RequiresPreviewFeatures] attribute...
Jeff Handley [Fri, 15 Oct 2021 19:43:21 +0000 (12:43 -0700)]
[release/6.0] Apply custom Message and Url to all [RequiresPreviewFeatures] attributes (#60456)

* Apply custom messages and urls to all generic math [RequiresPreviewFeatures] attributes

* Update AvxVnni message and remove the url

Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
3 years ago[release/6.0] Move 2 Drawing APIs that are not implemented in netfx to netcoreapp3...
Santiago Fernandez Madero [Fri, 15 Oct 2021 16:48:15 +0000 (09:48 -0700)]
[release/6.0] Move 2 Drawing APIs that are not implemented in netfx to netcoreapp3.1 or later (#60371)

3 years ago[release/6.0] Update dependencies from dotnet/emsdk dotnet/runtime-assets dotnet...
dotnet-maestro[bot] [Fri, 15 Oct 2021 14:36:45 +0000 (07:36 -0700)]
[release/6.0] Update dependencies from dotnet/emsdk dotnet/runtime-assets dotnet/arcade (#60398)

* Update dependencies from https://github.com/dotnet/runtime-assets build 20211014.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
 From Version 6.0.0-beta.21511.1 -> To Version 6.0.0-beta.21514.1

* Update dependencies from https://github.com/dotnet/emsdk build 20211014.1

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0-rtm.21512.1 -> To Version 6.0.0-rtm.21514.1

* Update dependencies from https://github.com/dotnet/arcade build 20211014.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21513.3 -> To Version 6.0.0-beta.21514.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years agoFix VS4Mac crash report and core dump generation perf problems (#60319)
Mike McLaughlin [Thu, 14 Oct 2021 19:08:26 +0000 (12:08 -0700)]
Fix VS4Mac crash report and core dump generation perf problems (#60319)

This is a VS4Mac show stopper. The performance (4 min or so) of taking a core dump
when VS4Mac crashes or hangs is unacceptable.

Backport of #60205

Refactor the DAC enumerate memory region phase out of gather crash info

This is so the crash report json is written and available before the core
dump which for VS4Mac currently takes 4 minutes.

Since on both Linux and MacOS all the RW regions have been already added
by createdump itself for heap dumps, then the sometimes slow (4 minutes for
VS4Mac) heap enum memory region is changed to the faster normal one. It adds
necessary DAC globals, etc. without the costly assembly, module, class, type
runtime data structure enumeration.

This fast heap dumps is opt'ed in with COMPlus_DbgEnableFastHeapDumps=1 env var to mitigate the
risk of something missing from these dumps.

Tested creating a crash report/core dump against VS4Mac process. Ran all the SOS tests on MacOS and Linux against this change.

Low since there is an opt-in env var that enables the most risk part.

3 years agoFix CRC32 encoding (#60360)
github-actions[bot] [Thu, 14 Oct 2021 19:07:49 +0000 (12:07 -0700)]
Fix CRC32 encoding (#60360)

On x64, when the crc32 instruction 2nd operand is a memory address
(such as for a static field), and that address is containable
(which normally doesn't happen, because the address will be above
the 4GB lower address space), then the instruction was being
improperly encoded.

Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
3 years ago[release/6.0] Update dependencies from dotnet/arcade dotnet/icu (#60361)
dotnet-maestro[bot] [Thu, 14 Oct 2021 06:34:05 +0000 (23:34 -0700)]
[release/6.0] Update dependencies from dotnet/arcade dotnet/icu (#60361)

* Update dependencies from https://github.com/dotnet/arcade build 20211013.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21512.4 -> To Version 6.0.0-beta.21513.3

* Update dependencies from https://github.com/dotnet/icu build 20211013.2

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-rtm.21507.1 -> To Version 6.0.0-rtm.21513.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years ago[release/6.0] Fix: CTS.TryReset() concurrency issue #60182 (#60323)
github-actions[bot] [Wed, 13 Oct 2021 22:48:14 +0000 (18:48 -0400)]
[release/6.0] Fix: CTS.TryReset() concurrency issue #60182 (#60323)

* Quick fix of #60182

* Fixed reset condition when there is no timer

* Simplify branching

Co-authored-by: sakno <roman.sakno@gmail.com>
3 years agoMerge pull request #60358 from hoyosjs/juhoyosa/merge-rc2-rel
Juan Hoyos [Wed, 13 Oct 2021 22:27:11 +0000 (15:27 -0700)]
Merge pull request #60358 from hoyosjs/juhoyosa/merge-rc2-rel

Merge RC2 tag into release/6.0 branch

3 years agoMerge tag 'v6.0.0-rc.2.21480.5' into juhoyosa/merge-rc2-rel
Juan Sebastian Hoyos Ayala [Wed, 13 Oct 2021 19:01:48 +0000 (12:01 -0700)]
Merge tag 'v6.0.0-rc.2.21480.5' into juhoyosa/merge-rc2-rel

3 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20211012.4 (#60337)
dotnet-maestro[bot] [Wed, 13 Oct 2021 17:33:22 +0000 (10:33 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20211012.4 (#60337)

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21511.3 -> To Version 6.0.0-beta.21512.4

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years agoMake upgrade install new host first, then uninstall old (#60317)
github-actions[bot] [Wed, 13 Oct 2021 13:56:09 +0000 (06:56 -0700)]
Make upgrade install new host first, then uninstall old (#60317)

This should preserve the ordering of PATH, since the old MSI will never
remove its entry.

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
3 years agoFinish59071 update ci argsh for r6.0 (#60100)
Parker Bibus [Wed, 13 Oct 2021 07:14:27 +0000 (02:14 -0500)]
Finish59071 update ci argsh for r6.0 (#60100)

* Updated channel passed to ci_setup in the performance-setup.sh file.

(cherry picked from commit e4416cb4cf6bee2234cf2536bf911045108d42c9)

* Removed spaces from assignments so they are seen as actual variabls, and tested locally.

(cherry picked from commit bf4d5a235d088515157173ddc0fe07a31abe2ad5)

3 years ago[release/6.0] Update dependencies from dotnet/runtime-assets dotnet/arcade dotnet...
dotnet-maestro[bot] [Wed, 13 Oct 2021 05:47:05 +0000 (22:47 -0700)]
[release/6.0] Update dependencies from dotnet/runtime-assets dotnet/arcade dotnet/emsdk (#60217)

* Update dependencies from https://github.com/dotnet/arcade build 20211008.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21507.1 -> To Version 6.0.0-beta.21508.2

* Update dependencies from https://github.com/dotnet/runtime-assets build 20211011.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
 From Version 6.0.0-beta.21504.1 -> To Version 6.0.0-beta.21511.1

* Update dependencies from https://github.com/dotnet/arcade build 20211011.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21507.1 -> To Version 6.0.0-beta.21511.3

* Update dependencies from https://github.com/dotnet/emsdk build 20211012.1

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0-rtm.21505.3 -> To Version 6.0.0-rtm.21512.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years ago[release/6.0] Eliminate pre-built assets during source-build (#60315)
Eric Erhardt [Wed, 13 Oct 2021 05:46:03 +0000 (00:46 -0500)]
[release/6.0] Eliminate pre-built assets during source-build (#60315)

* Remove RefOnly dependency versions

This allows for source-build to replace these versions with source-built versions.

* Eliminate usages of pre-built packages during source-build

* Don't build MSBuild tasks for netfx during source-build
* Don't build Microsoft.Windows.Compatibility during source-build
* Don't build test projects during source-build
* Don't restore Microsoft.DiaSymReader.Native
* Don't build source generators that target older Roslyn versions
* Don't build ILStripTask since it uses a Mono.Cecil "sources" NuGet package that isn't part of source-build

* PR feedback

Fix test build

3 years ago[release/6.0] Add osx-arm64.runtime.native.System.IO.Ports (#60084)
Sean Mollet [Wed, 13 Oct 2021 05:38:10 +0000 (00:38 -0500)]
[release/6.0] Add osx-arm64.runtime.native.System.IO.Ports (#60084)

* Add runtime.osx-arm64.runtime.native.System.IO.Ports proj file for packaging.
Tested on actual osx-arm64 hardware, resulting package works correctly.

* Update src/libraries/System.IO.Ports/pkg/runtime.osx-arm64.runtime.native.System.IO.Ports.proj

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
3 years agoUpdate Package Validation dependency and update Suppression files (#60306)
Jose Perez Rodriguez [Wed, 13 Oct 2021 03:56:10 +0000 (20:56 -0700)]
Update Package Validation dependency and update Suppression files (#60306)

3 years ago[release/6.0] Prevent runtime prop metadata retrieval when [JsonIgnore] is used ...
github-actions[bot] [Tue, 12 Oct 2021 19:00:36 +0000 (12:00 -0700)]
[release/6.0] Prevent runtime prop metadata retrieval when [JsonIgnore] is used (#60299)

* Prevent runtime prop metadata retrieval when [JsonIgnore] is used

* Address feedback

* Re-add ctor param default handling tests

* Remove new concurrent dictionary for generic method holders

Co-authored-by: Layomi Akinrinade <laakinri@microsoft.com>
3 years ago[release/6.0] Fallback to read/write if pread/pwrite fails (#60280)
github-actions[bot] [Tue, 12 Oct 2021 19:00:08 +0000 (12:00 -0700)]
[release/6.0] Fallback to read/write if pread/pwrite fails (#60280)

* Fallback to read/write if pread/pwrite fails

* * Cache whether a handle supports random access * Keep avoiding pread/pwrite for unseekable files * Fallback to read/write only for known error ENXIO

* Test more device paths and add tests for WriteAll*

* Fix CI: skip test when device can't be opened

* * Do not use SkipTestException * Exclude EBADF from assertion

* use NullableBool in _supportsRandomAccess

* Add tests for mkfifo and socketpair

* Rename test file

* Address feedback in src

* Address suggestions

* Address suggestions

* Update src/libraries/System.IO.FileSystem/tests/FileStream/DevicesPipesAndSockets.cs

Use Lazy for thread-safety

Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Use IEnumerable<string> in Lazy and fix usages

Co-authored-by: David Cantu <jozkee@macbook.lan>
Co-authored-by: Jozkee <dacantu@microsoft.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
3 years agoFixed exception type for ConnectionShutdownInitiatedByTransport (#60244)
github-actions[bot] [Tue, 12 Oct 2021 17:35:39 +0000 (11:35 -0600)]
Fixed exception type for ConnectionShutdownInitiatedByTransport (#60244)

Co-authored-by: ManickaP <mapichov@microsoft.com>
3 years agoFix issue in decommit_ephemeral_segment_pages (segment case). (#60170)
github-actions[bot] [Mon, 11 Oct 2021 21:05:08 +0000 (14:05 -0700)]
Fix issue in decommit_ephemeral_segment_pages (segment case). (#60170)

We assume that we can use half the free list space in gen 0 for new allocation. If that is too optimistic, we may allocate into decommitted memory and crash in the allocator. That is because there is a race condition between the allocating thread and the decommitting thread - we decided to avoid that by making sure we would never decommit memory that we may allocate in gen 0.

There are two reasons why assuming we can use half the free list space for new allocations may be too optimistic:
 - if we allocate large objects in gen 0, we may not have free spaces of the necessary size available.
- when background GC goes into background_ephemeral_sweep, it deletes and rebuilds the free list for gen 0. A thread trying to allocate during that time may see a completely empty free list.

Co-authored-by: Peter Sollich <petersol@microsoft.com>
3 years agoFix GetGenerationWithRange when we have a gen 2 object in the ephemeral segment ...
Andrew Au [Mon, 11 Oct 2021 06:53:06 +0000 (23:53 -0700)]
Fix GetGenerationWithRange when we have a gen 2 object in the ephemeral segment (#60189) (#60207)

3 years ago[release/6.0] Regression Fix - Update HostFactoryResolver, set the app name via an...
github-actions[bot] [Sat, 9 Oct 2021 00:20:15 +0000 (17:20 -0700)]
[release/6.0] Regression Fix - Update HostFactoryResolver, set the app name via an argument (#60132)

3 years ago[release/6.0] SafeFileHandle.Unix: don't DeleteOnClose when lock is not successful...
Tom Deseyn [Fri, 8 Oct 2021 22:59:07 +0000 (00:59 +0200)]
[release/6.0] SafeFileHandle.Unix: don't DeleteOnClose when lock is not successful. (#60112)

* SafeFileHandle.Unix: don't DeleteOnClose when lock is not succesful.

In https://github.com/dotnet/runtime/pull/55153 DeleteOnClose handling
moved from FileStream to SafeFileHandle.

This unintentionally caused DeleteOnClose to be applied even when
FileShare locking fails. As on Windows, DeleteOnClose should not take
effect when sharing prevents the file from being opened.

This also swaps the order of unlink and LOCK_UN in Dispose as it was
prior to https://github.com/dotnet/runtime/pull/55153.
Either order should be fine.

* test: add ConditionalFact IsFileLockingEnabled

3 years ago[release/6.0] Produce symbols archives (#59843)
github-actions[bot] [Fri, 8 Oct 2021 19:13:13 +0000 (12:13 -0700)]
[release/6.0] Produce symbols archives (#59843)

* Produce symbols archives.

Contributes to #49026

* Backport official build fix from #60096 to keep this PR from breaking the official build.

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
3 years agoMerge pull request #59810 from dotnet-maestro-bot/merge/release/6.0-rc2-to-release/6.0
Anirudh Agnihotry [Fri, 8 Oct 2021 19:12:51 +0000 (12:12 -0700)]
Merge pull request #59810 from dotnet-maestro-bot/merge/release/6.0-rc2-to-release/6.0

[automated] Merge branch 'release/6.0-rc2' => 'release/6.0'

3 years ago[release/6.0] Update dependencies from dotnet/emsdk dotnet/icu dotnet/runtime-assets...
dotnet-maestro[bot] [Fri, 8 Oct 2021 19:11:55 +0000 (12:11 -0700)]
[release/6.0] Update dependencies from dotnet/emsdk dotnet/icu dotnet/runtime-assets dotnet/arcade (#59895)

* Update dependencies from https://github.com/dotnet/arcade build 20210929.4

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21477.9 -> To Version 6.0.0-beta.21479.4

* Update dependencies from https://github.com/dotnet/runtime-assets build 20211004.1

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
 From Version 6.0.0-beta.21479.2 -> To Version 6.0.0-beta.21504.1

* Update dependencies from https://github.com/dotnet/emsdk build 20211005.2

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0-rc.2.21474.1 -> To Version 6.0.0-rtm.21505.2

* Update dependencies from https://github.com/dotnet/emsdk build 20211005.3

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.0-rc.2.21474.1 -> To Version 6.0.0-rtm.21505.3

* Update dependencies from https://github.com/dotnet/arcade build 20211005.8

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21477.9 -> To Version 6.0.0-beta.21505.8

* Update dependencies from https://github.com/dotnet/arcade build 20211006.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21477.9 -> To Version 6.0.0-beta.21506.2

* Update dependencies from https://github.com/dotnet/arcade build 20211007.1

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21477.9 -> To Version 6.0.0-beta.21507.1

* Update dependencies from https://github.com/dotnet/icu build 20211007.1

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-rtm.21474.1 -> To Version 6.0.0-rtm.21507.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 years ago[release/6.0] Check BackgroundService.ExecuteTask for null (#60177)
github-actions[bot] [Fri, 8 Oct 2021 19:09:07 +0000 (12:09 -0700)]
[release/6.0] Check BackgroundService.ExecuteTask for null (#60177)

* Check BackgroundService.ExecuteTask for null

In some scenarios, derived classes might not have called base.StartAsync, and ExecuteTask will still be null. Ensure we don't fail in those cases.

Fix #60131

* PR feedback

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
3 years ago[release/6.0] Override `corehost_resolve_component_dependencies` and `corehost_set_er...
github-actions[bot] [Fri, 8 Oct 2021 19:08:24 +0000 (12:08 -0700)]
[release/6.0] Override `corehost_resolve_component_dependencies` and `corehost_set_error_writer` PInvokes in singlefile scenario. (#60111)

* Override `corehost_resolve_component_dependencies` and `corehost_set_error_writer` PInvokes in singlefile scenario.

* fix for GCC

* Fixes the test failures when hostpolicy is used at runtime.

Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
Co-authored-by: vitek-karas <vitek.karas@microsoft.com>
3 years agoFix issue with incorrect handling of optimized method layouts - The sort order of...
github-actions[bot] [Fri, 8 Oct 2021 16:52:27 +0000 (09:52 -0700)]
Fix issue with incorrect handling of optimized method layouts - The sort order of the RuntimeFunctions table (among others) was not properly handled when an optimized method layout was applied - While this bug applied to non-composite builds, it was easily reproduced with a composite build - Fix lack of test infrastructure around non-standard method layouts. - Add new random method sorting order - Use new random sorting order in crossgen2 test passes (#60109)

Fixes #59089

Co-authored-by: David Wrighton <davidwr@microsoft.com>
3 years agoChange profilers to use thread local evacuation counters (#59741) (#60116)
David Mason [Fri, 8 Oct 2021 16:52:01 +0000 (09:52 -0700)]
Change profilers to use thread local evacuation counters (#59741) (#60116)

* Change profilers to use thread local evacuation counters

Change to prefix increment

* get rid of lambdas

* Fix jit inlining, fix R2R too

* Remove VolatilePtr<> from helpers

* Get rid of additionalData argument

3 years ago[release/6.0] Fix TimeZones Test failure (#60150)
github-actions[bot] [Fri, 8 Oct 2021 02:48:28 +0000 (19:48 -0700)]
[release/6.0] Fix TimeZones Test failure (#60150)

3 years ago[mono] Fix libcoreclr.so build incompatibilities on Linux (#60077)
github-actions[bot] [Thu, 7 Oct 2021 17:32:19 +0000 (13:32 -0400)]
[mono] Fix libcoreclr.so build incompatibilities on Linux (#60077)

Backport of #59988

* Link with -z relro -z now to enable full RELRO mode
  Fixes https://github.com/dotnet/runtime/issues/59904

* Generate and link in version.c to provide version string
  Fixes https://github.com/dotnet/source-build/issues/2484

Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
3 years agoEnable host.pkg subset in source-build (#60069)
Michael Simons [Thu, 7 Oct 2021 17:17:27 +0000 (12:17 -0500)]
Enable host.pkg subset in source-build (#60069)

3 years ago[release/6.0] Show error dialog in single-file app when runtime is missing (#60045)
Andy Gocke [Thu, 7 Oct 2021 05:33:51 +0000 (22:33 -0700)]
[release/6.0] Show error dialog in single-file app when runtime is missing (#60045)

* Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr (#59929)

Show dialog when running .NET 6 GUI single-file on 5.0 hostfxr

(cherry picked from commit 2f76c088d6ca9d734e9a481aebb5c382085f5ae2)

* Fixes based on feedback for the original #59929 (#59967)

Co-authored-by: Elinor Fung <elfung@microsoft.com>
(cherry picked from commit 3d171f9a6e78770f66cb861de007ec91c407a803)

Co-authored-by: Vitek Karas <vitek.karas@microsoft.com>
3 years ago[release/6.0] Fix incorrect tracking of sign bit in BigInteger (#59951)
github-actions[bot] [Wed, 6 Oct 2021 23:45:07 +0000 (17:45 -0600)]
[release/6.0] Fix incorrect tracking of sign bit in BigInteger (#59951)

* Fix incorrect tracking of sign bit

* Perform the 1 check earlier

* Add comment on checking special pattern

* Simplify fix

* Update the test to target 32 bit right shift as the logic has been restricted to that

* Remove stray newline

Co-authored-by: Wei Zheng <13881045+wzchua@users.noreply.github.com>
3 years agoFix byte array handling in STJ sourcegen (#60004)
github-actions[bot] [Wed, 6 Oct 2021 23:44:21 +0000 (17:44 -0600)]
Fix byte array handling in STJ sourcegen (#60004)

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
3 years ago[release/6.0][wasm] Fix codeql checks (#59839)
Larry Ewing [Wed, 6 Oct 2021 22:29:55 +0000 (17:29 -0500)]
[release/6.0][wasm] Fix codeql checks (#59839)

Fixes #59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.