Saleem Abdulrasool [Sat, 5 Apr 2014 20:51:58 +0000 (20:51 +0000)]
AsmParser: restore LLVM IR compatibility for linker_private{,_weak}
This restores the linker_private and linker_private_weak lexemes to permit
translation of the deprecated lexmes. The behaviour is identical to the bitcode
handling: linker_private and linker_private_weak are handled as if private had
been specified. This enables compatibility with IR generated by LLVM 3.4.
Reported on IRC by ki9a!
llvm-svn: 205675
David Blaikie [Sat, 5 Apr 2014 20:30:31 +0000 (20:30 +0000)]
Fixing typo.
Differential Revision: http://reviews.llvm.org/D3154
llvm-svn: 205674
David Blaikie [Sat, 5 Apr 2014 20:28:13 +0000 (20:28 +0000)]
Fix typo
Differential Revision: http://reviews.llvm.org/D3237
llvm-svn: 205673
David Blaikie [Sat, 5 Apr 2014 20:20:46 +0000 (20:20 +0000)]
Remove unused function
llvm-svn: 205672
David Blaikie [Sat, 5 Apr 2014 07:46:57 +0000 (07:46 +0000)]
Reapply r205655, DebugInfo: Place global constants in their appropriate context.
This was reverted in 205664 and seems to be fixed by 205668... though
that may be more by accident than anything well founded.
llvm-svn: 205669
David Blaikie [Sat, 5 Apr 2014 07:23:17 +0000 (07:23 +0000)]
DebugInfo: Avoid emitting constnants for every use
While the folding set would deduplicate the nodes themselves and LLVM
would handle not emitting the same global twice, it still meant creating
a long/redundant list of global variables.
llvm-svn: 205668
Jordan Rose [Sat, 5 Apr 2014 06:10:28 +0000 (06:10 +0000)]
[analyzer] Add an ErrnoChecker (PR18701) to the Potential Checkers list.
llvm-svn: 205667
Jordan Rose [Sat, 5 Apr 2014 06:10:22 +0000 (06:10 +0000)]
[analyzer] Update Open Projects page with BitwiseConstraintManager.
Also, add the names of people most recently working on particular projects,
and remove "relate bugs and checkers" (thanks, Alex!).
llvm-svn: 205666
Richard Trieu [Sat, 5 Apr 2014 05:17:01 +0000 (05:17 +0000)]
Add a new subgroup to -Wtautological-compare, -Wtautological-overlap-compare,
which warns on compound conditionals that always evaluate to the same value.
For instance, (x > 5 && x < 3) will always be false since no value for x can
satisfy both conditions.
This patch also changes the CFG to use these tautological values for better
branch analysis. The test for -Wunreachable-code shows how this change catches
additional dead code.
Patch by Anders Rönnholm.
llvm-svn: 205665
David Blaikie [Sat, 5 Apr 2014 03:39:29 +0000 (03:39 +0000)]
Revert "DebugInfo: Place global constants in their appropriate context."
This reverts commit r205655.
Breaks the compiler-rt build with an assertion failure in LLVM...
reverting while I investigate.
llvm-svn: 205664
Rui Ueyama [Sat, 5 Apr 2014 02:15:23 +0000 (02:15 +0000)]
[ELF] Add a test for -rpath.
llvm-svn: 205663
Rui Ueyama [Sat, 5 Apr 2014 02:07:04 +0000 (02:07 +0000)]
[ELF] Fix --soname option.
Currently LLD accepts only "-soname <string>", but all the following
options are actually valid.
--soname=foo
--soname foo
-soname=foo
-soname foo
-h foo
This patch fixes that issue.
llvm-svn: 205662
Jordan Rose [Sat, 5 Apr 2014 02:01:41 +0000 (02:01 +0000)]
[analyzer] Look through temporary destructors when finding a region to construct.
Fixes a false positive when temporary destructors are enabled where a temporary
is destroyed after a variable is constructed but before the VarDecl itself is
processed, which occurs when the variable is in the condition of an if or while.
Patch by Alex McCarthy, with an extra test from me.
llvm-svn: 205661
Hal Finkel [Sat, 5 Apr 2014 00:16:28 +0000 (00:16 +0000)]
[PowerPC] Remove unused TM member variable to unbreak build
Fix "error: private field 'TM' is not used [-Werror,-Wunused-private-field]"
llvm-svn: 205660
Fariborz Jahanian [Fri, 4 Apr 2014 23:53:45 +0000 (23:53 +0000)]
Objective-C arc [Sema]. Allow bridge cast of a qualified-id expression
when bridged Objective-C type conforms to the protocols in CF types's
Objective-C class. // rdar://
16393330
llvm-svn: 205659
Hal Finkel [Fri, 4 Apr 2014 23:51:18 +0000 (23:51 +0000)]
[PowerPC] Adjust load/store costs in PPCTTI
This provides more realistic costs for the insert/extractelement instructions
(which are load/store pairs), accounts for the cheap unaligned Altivec load
sequence, and for unaligned VSX load/stores.
Bad news:
MultiSource/Applications/sgefa/sgefa - 35% slowdown (this will require more investigation)
SingleSource/Benchmarks/McGill/queens - 20% slowdown (we no longer vectorize this, but it was a constant store that was scalarized)
MultiSource/Benchmarks/FreeBench/pcompress2/pcompress2 - 2% slowdown
Good news:
SingleSource/Benchmarks/Shootout/ary3 - 54% speedup
SingleSource/Benchmarks/Shootout-C++/ary - 40% speedup
MultiSource/Benchmarks/Ptrdist/ks/ks - 35% speedup
MultiSource/Benchmarks/FreeBench/neural/neural - 30% speedup
MultiSource/Benchmarks/TSVC/Symbolics-flt/Symbolics-flt - 20% speedup
Unfortunately, estimating the costs of the stack-based scalarization sequences
is hard, and adjusting these costs is like a game of whac-a-mole :( I'll
revisit this again after we have better codegen for vector extloads and
truncstores and unaligned load/stores.
llvm-svn: 205658
Hal Finkel [Fri, 4 Apr 2014 23:51:11 +0000 (23:51 +0000)]
[PowerPC] PPCTTI Cleanup
Remove the declaration of an unimplemented function.
llvm-svn: 205657
Andrew Trick [Fri, 4 Apr 2014 23:49:35 +0000 (23:49 +0000)]
Minor change to StackMapLiveness DEBUG output.
llvm-svn: 205656
David Blaikie [Fri, 4 Apr 2014 23:16:44 +0000 (23:16 +0000)]
DebugInfo: Place global constants in their appropriate context.
We also don't need to duplicate the name in the LinkageName field. Just
leave it empty.
llvm-svn: 205655
Rui Ueyama [Fri, 4 Apr 2014 22:36:30 +0000 (22:36 +0000)]
[ELF] Diagnose malformed --dynsym option.
llvm-svn: 205654
Kaelyn Takata [Fri, 4 Apr 2014 22:16:30 +0000 (22:16 +0000)]
Try harder about not suggesting methods as corrections when they
obviously won't work. Specifically, don't suggest methods (static or
not) from unrelated classes when the expression is a method call
through a specific object.
llvm-svn: 205653
Ed Maste [Fri, 4 Apr 2014 21:16:39 +0000 (21:16 +0000)]
Add failure decorators
These tests started failing on FreeBSD after r205497 "Make the fail
messages"
llvm.org/pr19347
llvm-svn: 205652
David Blaikie [Fri, 4 Apr 2014 20:56:17 +0000 (20:56 +0000)]
DebugInfo: PR19298: function local const variables duplicated in the root scope
See the comment for CodeGenFunction::tryEmitAsConstant that describes
how in some contexts (lambdas) we must not emit references to the
variable, but instead use the constant directly - because of this we end
up emitting a constant for the variable, as well as emitting the
variable itself.
Should we just skip putting the variable on the stack at all and omit
the debug info for the constant? It's not clear to me - what if the
address of the local is taken?
llvm-svn: 205651
Saleem Abdulrasool [Fri, 4 Apr 2014 20:31:19 +0000 (20:31 +0000)]
Driver: add target definition for Windows on ARM
This introduces the definitions needed for the Windows on ARM target. Add
target definitions for both the MSVC environment and the MSVC + Itanium C++ ABI
environment. The Visual Studio definitions correspond to the definitions
provided by Visual Studio 2012.
llvm-svn: 205650
Matt Arsenault [Fri, 4 Apr 2014 20:13:13 +0000 (20:13 +0000)]
Add DAG parameter to ComputeNumSignBitsForTargetNode
This way, you can check the number of sign bits in the
operands. The depth parameter it already has is pretty useless
without this.
llvm-svn: 205649
Matt Arsenault [Fri, 4 Apr 2014 20:13:08 +0000 (20:13 +0000)]
Fix tabs
llvm-svn: 205648
Juergen Ributzka [Fri, 4 Apr 2014 19:57:01 +0000 (19:57 +0000)]
Update the test to use FileCheck.
llvm-svn: 205647
Fariborz Jahanian [Fri, 4 Apr 2014 19:33:39 +0000 (19:33 +0000)]
Vector [Sema]. Vector "splats" which are truncated should have a warning
with -Wconversion. // rdar://
16502418
llvm-svn: 205646
Michael J. Spencer [Fri, 4 Apr 2014 19:22:14 +0000 (19:22 +0000)]
[X86-64] Add missing relocation.
llvm-svn: 205645
Rui Ueyama [Fri, 4 Apr 2014 19:17:59 +0000 (19:17 +0000)]
This is yet another case clang-modernize failed to add "override".
llvm-svn: 205644
Rui Ueyama [Fri, 4 Apr 2014 18:34:40 +0000 (18:34 +0000)]
Split a utility function not to use goto statement.
llvm-svn: 205643
Rui Ueyama [Fri, 4 Apr 2014 18:21:53 +0000 (18:21 +0000)]
useNew is set to false in all branches, so set it to false outside the if-else.
llvm-svn: 205642
Rui Ueyama [Fri, 4 Apr 2014 18:21:51 +0000 (18:21 +0000)]
Replace dyn_cast<T>s immediately followed by asserts with cast<T>s.
llvm-svn: 205641
Greg Clayton [Fri, 4 Apr 2014 18:15:18 +0000 (18:15 +0000)]
Xcode 5 crashes if lldb stops at breakpoint if long c++ template lists are present.
This fix reduces the stack size of SymbolFileDWARF::ParseType(). It seems that clang is not very good at sharing locations on the stack with local variables in large functions that have many blocks and each variable gets unique locations. The reduction in size was done by:
1 - removing some large locals that were default constructed by not used
2 - Placing some larger local variables into std::unique_ptr<> to make them on the heap
3 - removing local variables there were large and being populated but not being used
4 - reducing the size of some typedefs to llvm::SmallVector<T, N> so that N wasn’t excessively large
<rdar://problem/
16431645>
llvm-svn: 205640
Rui Ueyama [Fri, 4 Apr 2014 18:12:27 +0000 (18:12 +0000)]
Fix indentation.
llvm-svn: 205639
Greg Clayton [Fri, 4 Apr 2014 18:11:31 +0000 (18:11 +0000)]
Don’t exit the command interpreter if we get interrupted by an EINTR when calling fgets().
llvm-svn: 205638
Rui Ueyama [Fri, 4 Apr 2014 18:06:56 +0000 (18:06 +0000)]
Revert "temporary commit."
This reverts commit r205635 that was submitted by mistake.
llvm-svn: 205637
Jim Ingham [Fri, 4 Apr 2014 18:06:54 +0000 (18:06 +0000)]
Remember to clear the cached data for the OptionValueFileSpec in SetValueFromCString.
<rdar://problem/
16179718> target.expr-prefix contents appear to be cached for an entire session
llvm-svn: 205636
Rui Ueyama [Fri, 4 Apr 2014 18:01:52 +0000 (18:01 +0000)]
temporary commit.
llvm-svn: 205635
Greg Clayton [Fri, 4 Apr 2014 17:53:30 +0000 (17:53 +0000)]
Don’t crash when we get an invalid .debug_aranges set, just ignore it. Also print out warning messages if LLDB_CONFIGURATION_DEBUG is defined.
<rdar://problem/
16516343>
llvm-svn: 205634
Jim Grosbach [Fri, 4 Apr 2014 17:36:55 +0000 (17:36 +0000)]
Tidy up naming.
llvm-svn: 205633
Ben Langmuir [Fri, 4 Apr 2014 16:42:53 +0000 (16:42 +0000)]
Add a test where the module map is overriden in the vfs
Specifically, we pass two -ivfsoverlay yaml files, and the topmost one
remaps the module map file.
llvm-svn: 205632
Kai Nacke [Fri, 4 Apr 2014 16:21:59 +0000 (16:21 +0000)]
[mips] Add Octeon cnMips instructions seqi/snei and v3mulu/vmm0/vmulu.
This patch adds the Octeon cnMips instructions seqi/snei and v3mulu/vmm0/vmulu.
It is only for the assembler. Test case is included.
Reviewed by: Daniel.Sanders@imgtec.com
llvm-svn: 205631
Hal Finkel [Fri, 4 Apr 2014 15:15:57 +0000 (15:15 +0000)]
[PowerPC] Add a full condition code register to make the "cc" clobber work
gcc inline asm supports specifying "cc" as a clobber of all condition
registers. Add just enough modeling of the full register to make this work.
Fixed PR19326.
llvm-svn: 205630
Aaron Ballman [Fri, 4 Apr 2014 15:13:57 +0000 (15:13 +0000)]
In preparation for being able to use simple Boolean logic expressions involving capabilities, the semantics for attributes now looks through the types of the constituent parts of a capability expression instead of at the aggregate expression type.
llvm-svn: 205629
Daniel Sanders [Fri, 4 Apr 2014 14:52:54 +0000 (14:52 +0000)]
[mips] abs.[ds], and neg.[ds] should be allowed regardless of -enable-no-nans-fp-math
Summary:
They behave in accordance with the Has2008 and ABS2008 configuration bits of the
processor which are used to select between the 1985 and 2008 versions of IEEE
754. In 1985 mode, these instructions are arithmetic (i.e. they raise invalid
operation exceptions when given NaN), in 2008 mode they are non-arithmetic
(i.e. they are copies).
nmadd.[ds], and nmsub.[ds] are still subject to -enable-no-nans-fp-math because
the ISA spec does not explicitly state that they obey Has2008 and ABS2008.
Reviewers: matheusalmeida
Reviewed By: matheusalmeida
Differential Revision: http://llvm-reviews.chandlerc.com/D3274
llvm-svn: 205628
Evgeniy Stepanov [Fri, 4 Apr 2014 14:51:23 +0000 (14:51 +0000)]
[sanitizer] Intercept a subset of sunrpc interface (xdr_*).
llvm-svn: 205627
Tim Northover [Fri, 4 Apr 2014 14:49:30 +0000 (14:49 +0000)]
DAGLegalize: add last-ditch type-legalization for VSELECT.
When LLVM sees something like (v1iN (vselect v1i1, v1iN, v1iN)) it can
decide that the result is OK (v1i64 is legal on AArch64, for example)
but it still need scalarising because of that v1i1. There was no code
to do this though.
AArch64 and ARM64 have DAG combines to produce efficient code and
prevent that occuring in *most* such situations, but there are edge
cases that they miss. This adds a legalization to cope with that.
llvm-svn: 205626
Tim Northover [Fri, 4 Apr 2014 14:49:21 +0000 (14:49 +0000)]
ARM64: handle v1i1 types arising from setcc properly.
There were several overlapping problems here, and this solution is
closely inspired by the one adopted in AArch64 in r201381.
Firstly, scalarisation of v1i1 setcc operations simply fails if the
input types are legal. This is fixed in LegalizeVectorTypes.cpp this
time, and allows AArch64 code to be simplified slightly.
Second, vselect with such a setcc feeding into it ends up in
ScalarizeVectorOperand, where it's not handled. I experimented with an
implementation, but found that whatever DAG came out was rather
horrific. I think Hao's DAG combine approach is a good one for
quality, though there are edge cases it won't catch (to be fixed
separately).
Should fix PR19335.
llvm-svn: 205625
Joey Gouly [Fri, 4 Apr 2014 13:43:57 +0000 (13:43 +0000)]
When printing types for the OpenCL kernel metadata, use the PrintingPolicy.
This allows 'half' to be printed as 'half' and not as '__fp16'.
Patch by Fraser Cormack!
llvm-svn: 205624
Alexey Samsonov [Fri, 4 Apr 2014 12:24:46 +0000 (12:24 +0000)]
[ASan] Explicitly specify -ldl/-lpthread in RUN-lines where needed
llvm-svn: 205623
Stepan Dyatkovskiy [Fri, 4 Apr 2014 10:17:56 +0000 (10:17 +0000)]
Fix for PR18921 (LDRD/STRD part)::
Removed "GNU Assembler extension (compatibility)" definitions from ARMInstrInfo.td
Fixed ARMAsmParser::ParseInstruction GNU compatability branch, so it also works for thumb mode from now.
Added new tests.
llvm-svn: 205622
NAKAMURA Takumi [Fri, 4 Apr 2014 10:16:51 +0000 (10:16 +0000)]
Tweak unconditional-branch.ll passing on any hosts, while investigating x86_64-mingw32.
Sorry for the breakage.
For now, it will fail in two ways:
1. To fail for targeting x86_64-mingw32.
<stdin>:131:8: note: possible intended match here
0x30830a0100000002 3 0 1 0 0 is_stmt
2. To fail not to find the target x86.
llc: : error: unable to get target for 'x86_64-unknown-unknown',
see --version and --triple.
llvm-svn: 205621
Alexey Bataev [Fri, 4 Apr 2014 10:02:14 +0000 (10:02 +0000)]
[OPENMP][C++11] Renamed loop vars properly.
llvm-svn: 205620
Dmitry Vyukov [Fri, 4 Apr 2014 09:52:41 +0000 (09:52 +0000)]
tsan: improve error message in test
we've seen a flake on this test
next time it happens we will be able to gather some info
llvm-svn: 205619
Evgeniy Stepanov [Fri, 4 Apr 2014 09:47:41 +0000 (09:47 +0000)]
[msan] Introduce MsanThread. Move thread-local allocator cache out of TLS.
This reduces .tbss from 109K down to almost nothing.
llvm-svn: 205618
Kostya Serebryany [Fri, 4 Apr 2014 09:10:58 +0000 (09:10 +0000)]
[asan] fix a leak in __tls_get_addr handler; introduce a run-time flag to disable this handler completely; remove a workaround for a bug fixed in glibc
llvm-svn: 205617
Tim Northover [Fri, 4 Apr 2014 09:03:09 +0000 (09:03 +0000)]
ARM64: use regalloc-friendly COPY_TO_REGCLASS for bitcasts
The previous patterns directly inserted FMOV or INS instructions into
the DAG for scalar_to_vector & bitconvert patterns. This is horribly
inefficient and can generated lots more GPR <-> FPR register traffic
than necessary.
It's much better to emit instructions the register allocator
understands so it can coalesce the copies when appropriate.
It led to at least one ISelLowering hack to avoid the problems, which
was incorrect for v1i64 (FPR64 has no dsub). It can now be removed
entirely.
This should also fix PR19331.
llvm-svn: 205616
Tim Northover [Fri, 4 Apr 2014 09:03:02 +0000 (09:03 +0000)]
ARM64: add 128-bit MLA operations to the custom selection code.
Without this change, the llvm_unreachable kicked in. The code pattern
being spotted is rather non-canonical for 128-bit MLAs, but it can
happen and there's no point in generating sub-optimal code for it just
because it looks odd.
Should fix PR19332.
llvm-svn: 205615
Evgeniy Stepanov [Fri, 4 Apr 2014 08:58:16 +0000 (08:58 +0000)]
Revert r205613.
llvm-svn: 205614
Evgeniy Stepanov [Fri, 4 Apr 2014 08:39:50 +0000 (08:39 +0000)]
[msan] Fix compilation of a disabled test.
llvm-svn: 205613
Stepan Dyatkovskiy [Fri, 4 Apr 2014 08:14:13 +0000 (08:14 +0000)]
Fixed register class in STRD instruction for Thumb2 mode.
llvm-svn: 205612
Daniel Jasper [Fri, 4 Apr 2014 06:46:23 +0000 (06:46 +0000)]
clang-format: Don't merge simple blocks in case statements.
Before:
switch (a) {
case 1: { return 'a'; }
}
After:
switch (a) {
case 1: {
return 'a';
}
}
llvm-svn: 205611
Craig Topper [Fri, 4 Apr 2014 05:16:06 +0000 (05:16 +0000)]
Make consistent use of MCPhysReg instead of uint16_t throughout the tree.
llvm-svn: 205610
Saleem Abdulrasool [Fri, 4 Apr 2014 05:08:53 +0000 (05:08 +0000)]
Basic: rename VisualStudio to Windows
Visual Studio is the Integrated Development Environment. The toolchain is
generally referred to MSVC. Rename the target information to be more precise as
per the recommendation of Reid Kleckner.
llvm-svn: 205609
Richard Trieu [Fri, 4 Apr 2014 04:13:47 +0000 (04:13 +0000)]
Extend -Wtautological-constant-out-of-range-compare to handle boolean values
better. This warning will now trigger on the following conditionals:
bool b;
int i;
if (b > 1) {} // always false
if (0 <= (i > 5)) {} // always true
if (-1 > b) {} // always false
Patch by Per Viberg.
llvm-svn: 205608
Saleem Abdulrasool [Fri, 4 Apr 2014 04:06:10 +0000 (04:06 +0000)]
sweep up -Wformat warnings from gcc
This is a purely mechanical change explicitly casting any parameters for printf
style conversion. This cleans up the warnings emitted by gcc 4.8 on Linux.
llvm-svn: 205607
Justin Bogner [Fri, 4 Apr 2014 02:48:51 +0000 (02:48 +0000)]
CodeGen: Don't create branch weight metadata from empty profiles
If all of our weights are zero when calculating branch weights, it
means we haven't profiled the code in question. Avoid creating a
metadata node that says all branches are equally likely in this case.
The test also checks constructs that hit the other createBranchWeights
overload. These were already working.
llvm-svn: 205606
Jim Grosbach [Fri, 4 Apr 2014 02:14:38 +0000 (02:14 +0000)]
Fix spelling. Sigh.
llvm-svn: 205605
Jim Grosbach [Fri, 4 Apr 2014 02:11:03 +0000 (02:11 +0000)]
ARM: Range based for-loop over block predecessors.
No functional change.
llvm-svn: 205604
Jim Grosbach [Fri, 4 Apr 2014 02:10:59 +0000 (02:10 +0000)]
Add iterator_ranges for block pred/succ.
llvm-svn: 205603
Jim Grosbach [Fri, 4 Apr 2014 02:10:55 +0000 (02:10 +0000)]
ARM: Use range-based for loops in frame lowering.
No functional change.
llvm-svn: 205602
Quentin Colombet [Fri, 4 Apr 2014 02:05:21 +0000 (02:05 +0000)]
[RegAllocGreedy][Last Chance Recoloring] Emit diagnostics when last chance
recoloring cut-offs are encountered and register allocation failed.
This is related to PR18747
Patch by MAYUR PANDEY <mayur.p@samsung.com>.
llvm-svn: 205601
Quentin Colombet [Fri, 4 Apr 2014 02:02:49 +0000 (02:02 +0000)]
Revert r205599, the commit was not intended to have so many changes
llvm-svn: 205600
Quentin Colombet [Fri, 4 Apr 2014 01:58:57 +0000 (01:58 +0000)]
[RegAllocGreedy][Last Chance Recoloring] Emit diagnostics when last chance
recoloring cut-offs are hit.
This is related to PR18747.
Patch by MAYUR PANDEY <mayur.p@samsung.com>
llvm-svn: 205599
Reid Kleckner [Fri, 4 Apr 2014 01:36:55 +0000 (01:36 +0000)]
Add clang-cl alias to allow users to disable c4005
If we ever want three or more aliases, at that point we should put MSVC
warning ids in DiagnosticGroups.td. We can use that to support #pragma
warning.
llvm-svn: 205598
Rui Ueyama [Fri, 4 Apr 2014 01:22:51 +0000 (01:22 +0000)]
SymbolTable::size() returns an unsigned int.
It's better to use the same type rather than a fixed width integer type
that may be different from the return type.
llvm-svn: 205597
Saleem Abdulrasool [Fri, 4 Apr 2014 01:19:56 +0000 (01:19 +0000)]
ARM: fix test case missed in previous roundup
This should hopefully bring the last MSVC buildbot back to green!
llvm-svn: 205596
Saleem Abdulrasool [Fri, 4 Apr 2014 01:19:54 +0000 (01:19 +0000)]
MIPS: remove vim swap file
llvm-svn: 205595
Rui Ueyama [Fri, 4 Apr 2014 00:59:50 +0000 (00:59 +0000)]
Use range-based for loop. No functionality change.
llvm-svn: 205594
Rui Ueyama [Fri, 4 Apr 2014 00:39:37 +0000 (00:39 +0000)]
Do not use temporary variables to pass them to forEachUndefines.
So that it's obvious that we pass these callbacks only to forEachUndefines.
llvm-svn: 205593
Rafael Espindola [Fri, 4 Apr 2014 00:31:12 +0000 (00:31 +0000)]
Add an assert that this is only used with .o files.
I am not sure how to get a relocation in a .dylib, but this function would
return the wrong value if passed one.
llvm-svn: 205592
Reid Kleckner [Fri, 4 Apr 2014 00:17:16 +0000 (00:17 +0000)]
Put macro redefinition warnings under -Wmacro-redefined
This is consistent with -Wbuiltin-macro-redefined, and puts this common
extension warning under a flag.
Reviewers: rsmith
Differential Revision: http://llvm-reviews.chandlerc.com/D3283
llvm-svn: 205591
Rui Ueyama [Fri, 4 Apr 2014 00:15:52 +0000 (00:15 +0000)]
Return a vector rather than mutating a given one.
This is cleaner and as efficient as before.
Differential Revision: http://llvm-reviews.chandlerc.com/D3284
llvm-svn: 205590
Rui Ueyama [Fri, 4 Apr 2014 00:14:04 +0000 (00:14 +0000)]
Rename getInputGraph() and getNextFile().
Seems getSomething() is more common naming scheme than just a noun
to get something, so renaming these members.
Differential Revision: http://llvm-reviews.chandlerc.com/D3285
llvm-svn: 205589
Rafael Espindola [Thu, 3 Apr 2014 23:54:35 +0000 (23:54 +0000)]
Implement getRelocationAddress for MachO and ET_REL elf files.
With that, fix the symbolizer to work with any ELF file.
llvm-svn: 205588
Rafael Espindola [Thu, 3 Apr 2014 23:51:28 +0000 (23:51 +0000)]
Implement macho relocation iterators with section number + relocation number.
This will make it possible to implement getRelocationAddress.
llvm-svn: 205587
Saleem Abdulrasool [Thu, 3 Apr 2014 23:47:24 +0000 (23:47 +0000)]
ARM: yet another round of ARM test clean ups
llvm-svn: 205586
Jim Grosbach [Thu, 3 Apr 2014 23:43:26 +0000 (23:43 +0000)]
Tidy up. Space before ':' in range-based for loops.
llvm-svn: 205585
Jim Grosbach [Thu, 3 Apr 2014 23:43:22 +0000 (23:43 +0000)]
Tidy up. 80 columns.
llvm-svn: 205584
Jim Grosbach [Thu, 3 Apr 2014 23:43:18 +0000 (23:43 +0000)]
Tidy up. Trailing whitespace.
llvm-svn: 205583
Jim Grosbach [Thu, 3 Apr 2014 23:43:12 +0000 (23:43 +0000)]
Fix typo.
llvm-svn: 205582
Rafael Espindola [Thu, 3 Apr 2014 23:20:02 +0000 (23:20 +0000)]
Fix llvm-objdump crash.
llvm-svn: 205581
Fariborz Jahanian [Thu, 3 Apr 2014 23:06:35 +0000 (23:06 +0000)]
Turn off -Wmissing-noreturn warning for blocks
as there is no way to attach this attribute to the
block literal. // rdar://
16274746
llvm-svn: 205580
Rui Ueyama [Thu, 3 Apr 2014 22:58:41 +0000 (22:58 +0000)]
Update comment.
llvm-svn: 205579
Rui Ueyama [Thu, 3 Apr 2014 22:43:42 +0000 (22:43 +0000)]
Minor cleanups.
llvm-svn: 205578
Rafael Espindola [Thu, 3 Apr 2014 22:42:22 +0000 (22:42 +0000)]
Remove section_rel_empty. Just compare begin() and end() instead.
llvm-svn: 205577
Rui Ueyama [Thu, 3 Apr 2014 22:36:55 +0000 (22:36 +0000)]
Replace a recursion with a loop for speed.
llvm-svn: 205576
Rui Ueyama [Thu, 3 Apr 2014 22:24:40 +0000 (22:24 +0000)]
Do not check deadStripNever twice.
Atoms with deadStripNever attribute has already been added to the
dead strip root set at end of Resolver::doDefinedAtom, so no need
to check it for each atom again.
Differential Revision: http://llvm-reviews.chandlerc.com/D3282
llvm-svn: 205575
Rui Ueyama [Thu, 3 Apr 2014 22:21:59 +0000 (22:21 +0000)]
Move code into a helper function.
Move code that always runs after doUndefinedAtom into doUndefinedAtom
for readability.
llvm-svn: 205574