platform/upstream/dbus.git
17 years agoPatches by Kjartan Maraas <kmaraas at gnome dot org>
John (J5) Palmieri [Mon, 14 Aug 2006 19:11:35 +0000 (19:11 +0000)]
Patches by Kjartan Maraas <kmaraas at gnome dot org>

        * bus/services.c (bus_service_list_queued_owners):
        Add a pointer cast to fix compiler warning

        * dbus/dbus-dataslot.c (_dbus_data_slot_list_get):
        return a NULL instead of FALSE since the return type
        is not expecting a boolean

        * dbus/dbus-marshal-basic.c (_dbus_marshal_test):
        Remove unused variable

        * dbus/dbus-marshal-recursive-util.c (node_new):
        return a NULL instead of FALSE since the return type
        is not expecting a boolean

        * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
        Send a NULL into _dbus_transport_new_for_fd instead of a FALSE
        because we are expecting a pointer not a boolean

        * dbus/dbus-sysdeps-util.c (_dbus_get_tmpdir):
        add void as the parameter so some compilers
        don't complain

        * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket,
          _dbus_transport_new_for_tcp_socket):
        Send a NULL into _dbus_transport_new_for_fd instead of a FALSE
        because we are expecting a pointer not a boolean

        * test/shell-test.c (test_command_line):
        cast the second argument to _dbus_list_append to avoid compiler
        warnings

        * test/test-names.c (main): remove unused variable

        * test/test-service.c (check_hello_from_self_reply):
        Initialize echo_message and echo_reply to NULL

        * test/test-shell-service.c (handle_echo):
        Remove unused variable and cast the third parameter passed to
        dbus_connection_get_object_path_data to avoid compiler warrnings

        * test/name-test/test-names.c (clear_message_queue):
        Remove unused function

        * test/name-test/test-pending-call-dispatch.c:
        Fix format string in printf

17 years ago * dbus/dbus-bus.c:
John (J5) Palmieri [Mon, 14 Aug 2006 18:12:20 +0000 (18:12 +0000)]
    * dbus/dbus-bus.c:
        * test/name-test/test-names.c:
        Remove test method dbus_bus_connection_get_unique_name because
        we already have public method dbus_bus_get_unique_name that
        does the exact same thing

17 years ago* fix typos in Julio's previous patch which cause make check to fail
John (J5) Palmieri [Fri, 11 Aug 2006 22:13:34 +0000 (22:13 +0000)]
* fix typos in Julio's previous patch which cause make check to fail

17 years ago* fix mismatching paren typo
John (J5) Palmieri [Fri, 11 Aug 2006 15:37:11 +0000 (15:37 +0000)]
* fix mismatching paren typo

17 years ago* dbus/dbus-address.c (_dbus_address_test): Revert leaking strcmp.
John (J5) Palmieri [Thu, 10 Aug 2006 23:03:29 +0000 (23:03 +0000)]
* dbus/dbus-address.c (_dbus_address_test): Revert leaking strcmp.
  In any case it was wrong since this is a test checking to see if
  address parsing is correct.  There was no need to get the true
  tmp directory.

17 years ago* dbus/dbus-macros.h: Revert the addition of stddef.h
John (J5) Palmieri [Thu, 10 Aug 2006 22:58:05 +0000 (22:58 +0000)]
* dbus/dbus-macros.h: Revert the addition of stddef.h
  as we should not be adding it to library headers

17 years ago* dbus/dbus-signature.c:
John (J5) Palmieri [Thu, 10 Aug 2006 21:50:23 +0000 (21:50 +0000)]
* dbus/dbus-signature.c:
  Fix the unit tests so that they work if assertions are not enabled.
  (patch from Julio M. Merino Vidal  <jmmv at NetBSD dot org>)

17 years ago* tools/run-with-tmp-session-bus.sh:
John (J5) Palmieri [Thu, 10 Aug 2006 21:44:00 +0000 (21:44 +0000)]
* tools/run-with-tmp-session-bus.sh:
* test/name-test/run-test.sh:
  Remove bashisms (patch from Julio M. Merino Vidal
  <jmmv at NetBSD dot org>)

17 years ago- configure.in doesn't seem to like >= 2.6.0 in a warning message
John (J5) Palmieri [Thu, 10 Aug 2006 21:33:06 +0000 (21:33 +0000)]
- configure.in doesn't seem to like >= 2.6.0 in a warning message

17 years ago* configure.in: add a version (>= 2.6.0) check for libxml2
John (J5) Palmieri [Thu, 10 Aug 2006 21:22:33 +0000 (21:22 +0000)]
* configure.in: add a version (>= 2.6.0) check for libxml2

17 years ago* forgot to save the dbus/dbus-macros.h file for a previous checkin
John (J5) Palmieri [Thu, 10 Aug 2006 21:03:00 +0000 (21:03 +0000)]
* forgot to save the dbus/dbus-macros.h file for a previous checkin

17 years ago* configure.in: make sure the compiler supports -Wfloat-equal
John (J5) Palmieri [Thu, 10 Aug 2006 21:00:30 +0000 (21:00 +0000)]
* configure.in: make sure the compiler supports -Wfloat-equal

* bus/dir-watch-dnotify.c: move functional code after
  variable declerations (C99 fix)  (patches from Jens Granseuer
  <jensgr at gmx dot net>

17 years ago* dbus/dbus-macros.h:
John (J5) Palmieri [Thu, 10 Aug 2006 20:31:20 +0000 (20:31 +0000)]
* dbus/dbus-macros.h:
  add #include <stddef.h> so that Sun compilers don't complain about
  the defining NULL

17 years ago* dbus/dbus-sysdeps.c:
John (J5) Palmieri [Thu, 10 Aug 2006 20:09:43 +0000 (20:09 +0000)]
* dbus/dbus-sysdeps.c:
* dbus/dbus-address.c:
* bus/activation.c:
* test/shell-test.c:
  don't hardcode tmp directory (patch from Dave Meikle
  <dmk at davemeikle dot co dot uk>)

17 years ago* Change an assert to a detailed warning and abort.
John (J5) Palmieri [Wed, 9 Aug 2006 19:45:24 +0000 (19:45 +0000)]
* Change an assert to a detailed warning and abort.
  When allocator->lock != mutex it indicates that the user has failed
  to initalize threads before using the D-Bus library.  This warning
  helps the user identify the issue and fix their app.

17 years ago* missing semicolon
John (J5) Palmieri [Tue, 8 Aug 2006 23:30:39 +0000 (23:30 +0000)]
* missing semicolon

17 years agoThese are all patches from Kjartan Maraas <kmaraas at gnome dot org>
John (J5) Palmieri [Tue, 8 Aug 2006 23:29:03 +0000 (23:29 +0000)]
These are all patches from Kjartan Maraas <kmaraas at gnome dot org>
with cleanups of bugs found from Coverity reports:

* dbus/dbus-sysdeps-util.c (_dbus_write_pid_file):
  close the file on error to avoid a leak

* bus/expirelist.c (bus_expire_list_test):
  Check for NULL on dbus_new0

* bus/activation.c (update_directory):
  remove dead code

* bus/config-parser.c (merge_service_context_hash, start_selinux_child):
  Fix some leaks

* bus/bus.c (process_config_every_time):
  Fixed a leak

* bus/desktop-file.c (parse_key_value):
  Fixed leak

* bus/selinux.c (bus_selinux_id_table_insert):
  Fixed leak

17 years ago* dbus/dbus-object-tree.c (_dbus_object_subtree_new):
John (J5) Palmieri [Tue, 8 Aug 2006 22:43:40 +0000 (22:43 +0000)]
* dbus/dbus-object-tree.c (_dbus_object_subtree_new):
  remove dead code

17 years ago* tools/run-with-tmp-session-bus.sh: use #!/bin/sh instead of
John (J5) Palmieri [Tue, 8 Aug 2006 22:38:32 +0000 (22:38 +0000)]
* tools/run-with-tmp-session-bus.sh: use #!/bin/sh instead of
  #!/bin/bash

17 years ago* Doxyfile.in: fix the INPUT line so we can generate docs
John (J5) Palmieri [Tue, 8 Aug 2006 22:17:18 +0000 (22:17 +0000)]
* Doxyfile.in: fix the INPUT line so we can generate docs
  when sourcedir != builddir (patch from Cygwin Ports maintainer
  <yselkowitz at users dot sourceforge dot net>

17 years ago* dbus/dbus-sysdeps.h:
John (J5) Palmieri [Tue, 8 Aug 2006 22:08:39 +0000 (22:08 +0000)]
* dbus/dbus-sysdeps.h:
* dbus/dbus-sysdeps.c:
* dbus/dbus-string.c:
  s/_dbus_printf_length/_dbus_printf_string_upper_bound to comform with
  GLib's function which does the same thing

* configure.in:
* bus/Makefile.am:
* bus/dir-watch-default.c:
* bus/dir-watch-dnotify.c:
* bus/dir-watch-kqueue.c:
  Add kqueue directory watching for freebsd and split the directory
  watching code into seperate files per method/arch
  (patches from Timothy Redaelli <drizzt at gufi dotorg>)

17 years ago* configure.in:
John (J5) Palmieri [Tue, 8 Aug 2006 21:30:31 +0000 (21:30 +0000)]
* configure.in:
* tools/Makefile.am:
* tools/dbus-launch.c:
* bus/Makefile.am:
  allow --with-dbus-daemondir switch to be used to make the
  daemon install to a seperate bindir like /usr/libexec
  (patch from Brian Cameron <brian dot cameron at sun dot com)

17 years ago* bus/Makefile.am (install-data-hook): removed the slash after
John (J5) Palmieri [Tue, 8 Aug 2006 21:15:56 +0000 (21:15 +0000)]
* bus/Makefile.am (install-data-hook): removed the slash after
  $(DESTDIR) so we don't get the double slash which does not work
  in windows (patch from Andras Porjesz
  <andras dot porjesz at siemens dot com>

17 years ago* dbus/dbus-sysdeps.h:
John (J5) Palmieri [Tue, 8 Aug 2006 20:59:26 +0000 (20:59 +0000)]
* dbus/dbus-sysdeps.h:
* dbus/dbus-sysdeps.c:
  add _dbus_printf_length (patch from Peter Kümmel
  <syntheticpp at gmx dot net>)

17 years ago* dbus/dbus-internals.c: unistd.h is not used
John (J5) Palmieri [Tue, 8 Aug 2006 20:22:14 +0000 (20:22 +0000)]
* dbus/dbus-internals.c: unistd.h is not used
  (_dbus_verbose_real): only enable verbose printing
  if DBUS_VERBOSE environment var is set to '1'
  (patch from Peter Kümmel <syntheticpp at gmx dot net>

17 years ago* confifure.in: add a GCC flag check for -Wdeclaration-after-statement
John (J5) Palmieri [Tue, 8 Aug 2006 15:36:59 +0000 (15:36 +0000)]
* confifure.in: add a GCC flag check for -Wdeclaration-after-statement
  so we still compile on older gcc (patch from Frederic Peters
  <fpeters at 0d dot be>

17 years ago* configure.in: add -Wdeclaration-after-statement
John (J5) Palmieri [Fri, 4 Aug 2006 16:15:16 +0000 (16:15 +0000)]
* configure.in: add -Wdeclaration-after-statement

* dbus/dbus-connection.c: change all the pending call stuff to
  reflect the fact that pending call operations use the connection
  lock

* dbus/dbus-pending-call.c: add locking here

* dbus/dbus-errors.c (struct DBusRealError): don't make the name
  field const consistent with how message field is done

17 years ago* s/D-BUS/D-Bus/g
John (J5) Palmieri [Thu, 3 Aug 2006 20:34:36 +0000 (20:34 +0000)]
* s/D-BUS/D-Bus/g

17 years ago* dbus/dbus-object-tree.c: Patch by Benjamin Otte
John (J5) Palmieri [Thu, 3 Aug 2006 20:02:37 +0000 (20:02 +0000)]
* dbus/dbus-object-tree.c: Patch by Benjamin Otte
  <in7y118 at public.uni-hamburg dot de> - fix invalid
  read/write reported by valgrind

17 years ago- bump release
John (J5) Palmieri [Mon, 24 Jul 2006 17:49:59 +0000 (17:49 +0000)]
- bump release

17 years ago- Released 0.91 dbus-0.91
John (J5) Palmieri [Mon, 24 Jul 2006 17:48:13 +0000 (17:48 +0000)]
- Released 0.91

17 years ago- Correct release location
John (J5) Palmieri [Mon, 24 Jul 2006 17:39:31 +0000 (17:39 +0000)]
- Correct release location

17 years ago* dbus/dbus-connection.c:
John (J5) Palmieri [Sat, 22 Jul 2006 17:06:14 +0000 (17:06 +0000)]
* dbus/dbus-connection.c:
  (_dbus_connection_attach_pending_call_unlocked):
  (connection_timeout_and_complete_all_pending_calls_unlocked):
  Make sure we set timeout_added on pending calls to FALSE when
  we remove the timeout from the connection

17 years agoadd note about fixing locking on pending call
Havoc Pennington [Fri, 21 Jul 2006 23:21:54 +0000 (23:21 +0000)]
add note about fixing locking on pending call

17 years ago* Removed some extra bindings stuff lingering around (thanks timo)
John (J5) Palmieri [Fri, 21 Jul 2006 19:28:56 +0000 (19:28 +0000)]
* Removed some extra bindings stuff lingering around (thanks timo)
* dbus-pendingcall.c (_dbus_pending_call_new):
  s/dbus_connection_ref/_dbus_connection_ref_unlocked fixes assertion
  when we tried to take a lock on an already locked connection

17 years ago- Bump release in CVS
John (J5) Palmieri [Mon, 17 Jul 2006 19:44:21 +0000 (19:44 +0000)]
- Bump release in CVS

17 years ago* Release 0.90 dbus-0.90
John (J5) Palmieri [Mon, 17 Jul 2006 19:42:36 +0000 (19:42 +0000)]
* Release 0.90

17 years ago2006-07-17 Havoc Pennington <hp@redhat.com>
Havoc Pennington [Mon, 17 Jul 2006 18:23:39 +0000 (18:23 +0000)]
2006-07-17  Havoc Pennington  <hp@redhat.com>

        * dbus/dbus-marshal-basic.c (_dbus_type_to_string): support 64-bit
        ints, reported by Owen Taylor

17 years ago* doc/TODO:
John (J5) Palmieri [Mon, 17 Jul 2006 17:44:07 +0000 (17:44 +0000)]
* doc/TODO:
* dbus/dbus-bus.c:
* dbus-errors.c:
* dbus/dbus-marshal-validate.c:
  Removed TODO items which were fixed or are no longer relevent

17 years ago* Remove stray files from the stripped bindings
John (J5) Palmieri [Mon, 17 Jul 2006 17:34:08 +0000 (17:34 +0000)]
* Remove stray files from the stripped bindings

17 years ago2006-07-16 Havoc Pennington <hp@redhat.com>
Havoc Pennington [Sun, 16 Jul 2006 15:35:25 +0000 (15:35 +0000)]
2006-07-16  Havoc Pennington  <hp@redhat.com>

* dbus/dbus-pending-call.c (_dbus_pending_call_set_timeout_error):
Improve the error message on reply timeout

17 years ago* Update ChangeLog for binding removal commit
John (J5) Palmieri [Fri, 14 Jul 2006 16:21:28 +0000 (16:21 +0000)]
* Update ChangeLog for binding removal commit

17 years ago* Remove all bindings
John (J5) Palmieri [Fri, 14 Jul 2006 16:20:12 +0000 (16:20 +0000)]
* Remove all bindings

17 years ago* dbus-connection.c (dbus_connection_send_with_reply): return TRUE
John (J5) Palmieri [Fri, 14 Jul 2006 03:09:22 +0000 (03:09 +0000)]
* dbus-connection.c (dbus_connection_send_with_reply): return TRUE
  and set pending_reply out arg to NULL is connection is disconnected
  (connection_timeout_and_complete_all_pending_calls_unlocked): New
  static method for cleaning up pending calls on disconnect
  (_dbus_connection_get_dispatch_status_unlocked): If we have pending
  calls queued timeouts on disconnect

* dbus/dbus-pending-call.ci (_dbus_pending_call_set_connection):
  Remove

17 years ago* bus/activation.[ch] (bus_activation_list_services): new function to
John (J5) Palmieri [Fri, 14 Jul 2006 01:17:59 +0000 (01:17 +0000)]
* bus/activation.[ch] (bus_activation_list_services): new function to
  get the list of services that can be activated

* bus/dispatch.c: test coverage for the new bus method
  ListActivatableNames

* bus/driver.c: new bus method ListActivatableNames to get the list of
  services that can be activated

* doc/dbus-specification.xml: ListActivatableNames method documentation

17 years ago* dbus/Makefile.am: add dbus-pending-call-internal.h to the list of
John (J5) Palmieri [Wed, 12 Jul 2006 18:05:27 +0000 (18:05 +0000)]
* dbus/Makefile.am: add dbus-pending-call-internal.h to the list of
  source files

17 years ago* dbus/dbus-message-factory.c:
John (J5) Palmieri [Wed, 12 Jul 2006 16:52:44 +0000 (16:52 +0000)]
* dbus/dbus-message-factory.c:
  Fix index into an array (patch by Peter Kümmel <syntheticpp at gmx.net>)

17 years ago- Make DBusPendingCall an opaque type even to D-Bus internals
John (J5) Palmieri [Wed, 12 Jul 2006 15:57:01 +0000 (15:57 +0000)]
- Make DBusPendingCall an opaque type even to D-Bus internals

17 years ago* dbus/dbus-connection.h: remove connection_disconnect and replace with
John (J5) Palmieri [Fri, 7 Jul 2006 21:56:30 +0000 (21:56 +0000)]
* dbus/dbus-connection.h: remove connection_disconnect and replace with
  connection_close

* dbus/dbus-connection.c: include dbus-bus.h
  (_dbus_connection_read_write_dispatch): make static

17 years ago* dbus/dbus-connection.c (dbus_connection_close): removed deprecated
John (J5) Palmieri [Fri, 7 Jul 2006 19:42:56 +0000 (19:42 +0000)]
* dbus/dbus-connection.c (dbus_connection_close): removed deprecated
  function
  (dbus_connection_dispatch): On disconnect unref any shared connections

* dbus/dbus-bus.c (_dbus_bus_check_connection_and_unref): new function
  for cleaning up shared connections on disconnect
  (internal_bus_get): get a hard refrence to shared connections when
  they are created

* doc/TODO: Remove items which are no longer relevent or have been fixed
  Split 1.0 todo items with a 0.90 freeze todo list

17 years ago2006-06-14 Ross Burton <ross@openedhand.com>
Ross Burton [Wed, 14 Jun 2006 16:49:37 +0000 (16:49 +0000)]
2006-06-14  Ross Burton  <ross@openedhand.com>

* glib/dbus-gobject.c:
Free a leaking GArray (surely not!) in dbus_g_method_return.

17 years ago2006-06-14 Ross Burton <ross@openedhand.com>
Ross Burton [Wed, 14 Jun 2006 14:39:51 +0000 (14:39 +0000)]
2006-06-14  Ross Burton  <ross@openedhand.com>

* tools/Makefile.am:
* tools/dbus-monitor.c:
Don't use the GLib bindings in dbus-monitor (patch from Ralf
Habacker).

17 years ago2006-06-14 Ross Burton <ross@openedhand.com>
Ross Burton [Wed, 14 Jun 2006 11:26:41 +0000 (11:26 +0000)]
2006-06-14  Ross Burton  <ross@openedhand.com>

* tools/dbus-print-message.c:
Also print the object path when outputting signals or method calls.

17 years agoadd dbus_bus_get refcount item to TODO
Havoc Pennington [Wed, 14 Jun 2006 04:16:30 +0000 (04:16 +0000)]
add dbus_bus_get refcount item to TODO
link to mail list post about pending call threading problems

17 years ago * qt/src/Makefile.am: install the qdbus.h header.
Thiago Macieira [Tue, 13 Jun 2006 18:21:58 +0000 (18:21 +0000)]
    * qt/src/Makefile.am: install the qdbus.h header.
        This allows people to actually use the installed code.

17 years ago2006-06-12 Ross Burton <ross@openedhand.com>
Ross Burton [Mon, 12 Jun 2006 14:22:48 +0000 (14:22 +0000)]
2006-06-12  Ross Burton  <ross@openedhand.com>

* glib/dbus-gproxy.c:
Don't leak a GArray when firing signals (thank Rob Taylor for review).

17 years ago * Released 0.62 dbus-0.62
Thiago Macieira [Mon, 12 Jun 2006 14:00:47 +0000 (14:00 +0000)]
* Released 0.62
(update ChangeLog and NEWS)

17 years ago * dbus/dbus-arch-deps.h.in: Remove spurious semi-colons that
Thiago Macieira [Mon, 12 Jun 2006 09:20:20 +0000 (09:20 +0000)]
* dbus/dbus-arch-deps.h.in: Remove spurious semi-colons that
        break pedantic builds. Closes bug 6043 (patch approved by
        Havoc back in February).

17 years ago * qt/src/qdbusintegrator.cpp: Fix bug in parsing async methods
Thiago Macieira [Mon, 12 Jun 2006 09:18:45 +0000 (09:18 +0000)]
* qt/src/qdbusintegrator.cpp: Fix bug in parsing async methods
        that took a QDBusMessage parameter.
* qt/src/qdbusbus.h: Add a default flag for RequestName.
* qt/tools/dbus.cpp: Don't use automatic call because we might
        be calling an async method: request a reply.

17 years agoNo changelog: fix distcheck.
Thiago Macieira [Sun, 11 Jun 2006 12:36:01 +0000 (12:36 +0000)]
No changelog: fix distcheck.

17 years ago * test/qt/*: Update the testcases, including testing the new
Thiago Macieira [Sun, 11 Jun 2006 12:18:23 +0000 (12:18 +0000)]
* test/qt/*: Update the testcases, including testing the new
        functionality of sending null QByteArray and QString over the
        bus. Add new headertest test and restore the old
        qdbusxmlparser test.

17 years ago * qt/tools/dbuscpp2xml.cpp: Compile on Windows.
Thiago Macieira [Sun, 11 Jun 2006 12:16:30 +0000 (12:16 +0000)]
* qt/tools/dbuscpp2xml.cpp: Compile on Windows.
* qt/tools/dbusidl2cpp.cpp: Add missing newline.

* qt/examples/Makefile.am:
* qt/examples/chat.h: Use UI-generated files with the ui_*.h
form.

* qt/src/qdbusmarshall.cpp: Allow sending of QString() and
QByteArray() (nulls) over the bus.
* qt/src/qdbusabstractinterface.cpp: Use the correct variable,
the one that has the signature suffix stripped.
* qt/src/qdbusreply.h: Make some methods const.

17 years ago Patch from Timo Hoenig <thoenig@suse.de>.
Thiago Macieira [Fri, 9 Jun 2006 21:43:14 +0000 (21:43 +0000)]
    Patch from Timo Hoenig <thoenig@suse.de>.

        * qt/dbus/Makefile.am: New file.  Fix "make dist", add all
        headers required during build to EXTRA_DIST.
        * qt/src/Makefile.am: Fix "make dist", add 'qdbus.h' to
        EXTRA_DIST.
        * qt/Makefile.am: Fix "make dist", add 'dbus' to DIST_SUBDIRS.
        * configure.in: Fix "make dist", take care that the Makefile
        for qt/dbus is being generated.

17 years ago* bus/bus.c: Fix eavesdropping on method calls
John (J5) Palmieri [Wed, 7 Jun 2006 20:07:34 +0000 (20:07 +0000)]
* bus/bus.c: Fix eavesdropping on method calls

17 years ago* configure.in:
John (J5) Palmieri [Wed, 7 Jun 2006 19:59:11 +0000 (19:59 +0000)]
* configure.in:
* dbus/dbus-userdb-util.c:
Add Solaris console owner patch from Artem Kachitchkine

17 years agoManaged to get the year wrong in April as well as yesterday...
Robert McQueen [Wed, 7 Jun 2006 10:44:23 +0000 (10:44 +0000)]
Managed to get the year wrong in April as well as yesterday...

17 years ago * qt/Makfile.am:
Thiago Macieira [Wed, 7 Jun 2006 10:21:11 +0000 (10:21 +0000)]
* qt/Makfile.am:
* qt/src/Makefile.am: Fix the EXTRA_DIST after the
reorganisation. Thanks to Timo Hoenig for pointing this out.

17 years ago2005-05-06 Robert McQueen <robot101@debian.org>
Robert McQueen [Wed, 7 Jun 2006 00:31:01 +0000 (00:31 +0000)]
2005-05-06  Robert McQueen  <robot101@debian.org>

* glib/dbus-gtype-specialized.c: Fix obvious leak of GArray in every
  call to dbus_g_type_get_struct.

17 years ago2005-05-06 Robert McQueen <robot101@debian.org>
Robert McQueen [Wed, 7 Jun 2006 00:03:57 +0000 (00:03 +0000)]
2005-05-06  Robert McQueen  <robot101@debian.org>

* glib/dbus-gvalue-utils.c: Fix the failing test where static string
  pointers were put into a GPtrArray-based specialised collection, and
  then freed along with the array. GValues which you add into
  collections or maps which have the NOCOPY flag set are assumed to not
  belong to the caller, so rather than the existing pointer-stealing
  semantics, they are copied instead. Given that the main consumers of
  this abstraction are the bindings themselves, I don't think this is
  too bad, but others should watch their choice of take vs set_static.

17 years ago2005-05-06 Robert McQueen <robot101@debian.org>
Robert McQueen [Tue, 6 Jun 2006 23:07:04 +0000 (23:07 +0000)]
2005-05-06  Robert McQueen  <robot101@debian.org>

* glib/dbus-gvalue-utils.c: Spotted a warning about the return value
  of g_slist_prepend not being used. Fixed copying of slist-based
  specialised collections, then wrote a test case and found that it was
  all broken. Went on to fix iterating and appending too. Good thing
  nobody uses this code yet.

17 years agothe recursive locks todo item was a little misleading
Havoc Pennington [Tue, 6 Jun 2006 20:28:57 +0000 (20:28 +0000)]
the recursive locks todo item was a little misleading

17 years ago2005-05-06 Robert McQueen <robot101@debian.org>
Robert McQueen [Tue, 6 Jun 2006 19:45:39 +0000 (19:45 +0000)]
2005-05-06  Robert McQueen  <robot101@debian.org>

* glib/dbus-gvalue-utils.c: Remove duplicated code by having all of
  the iterators use gvalue_take_ptrarray_value (the GValues themselves
  are discarded without unsetting, so it makes no difference whether
  we take or set_static). Remove cases for G_TYPE_POINTER because
  there really is nothing useful we can do with them in our
  specialised types - we *need* boxed copy/free functions at the very
  least.

17 years ago * qt/dbus: Add directory. I had forgotten to add this
Thiago Macieira [Mon, 5 Jun 2006 18:13:07 +0000 (18:13 +0000)]
* qt/dbus: Add directory. I had forgotten to add this
yesterday after the move...

* qt/examples/Makefile.am:
* qt/examples/dbus.cpp: Moved to qt/tools/dbus.cpp.

* qt/tools/Makefile.am:
* qt/tools/dbus.cpp: Moved from qt/examples/dbus.cpp.
Added feature to get and set properties.
Added validation of service, object path and interface names.

* qt/tools/dbusidl2cpp.cpp: Two new features:
1) Allow specifying both the header and the source file names,
by separating them with a colon.
2) Don't write an interface output if the -p switch wasn't
given, but the -a was.

* qt/src/*: Fix usage of Iterators and ConstIterators.
Fix shadowing of variables by other variables (-Wshadow).
Fix keyword-cleanliness in headers.
Fix ASCII-cast (QLatin1String, QLatin1Char).
Fix validation of member names.
Add extra checking of introspection data during XML parsing.
Various bug fixes.

17 years ago * dbus/Makefile.am:
Thiago Macieira [Sun, 4 Jun 2006 16:02:16 +0000 (16:02 +0000)]
* dbus/Makefile.am:
* dbus/qdbus.h: Remove unnecessary file. This is mirrored into
        qt/dbus/qdbus.h now.

17 years ago * configure.in: Make --disable-qt actually do
Thiago Macieira [Sun, 4 Jun 2006 15:53:44 +0000 (15:53 +0000)]
* configure.in: Make --disable-qt actually do
          something. Patch inspired by Zack Rusin.

17 years ago * qt/: Update to Subversion r548032.
Thiago Macieira [Sun, 4 Jun 2006 15:52:05 +0000 (15:52 +0000)]
* qt/: Update to Subversion r548032.
This includes a big reorganisation of the files inside the
subdir.

We really need a version control system that supports moving of
files. I'm not bothering with history anyways anymore, since the
bindings will be moved out to git. The history should be restored from
Subversion when that happens.

18 years ago * dbus/dbus-sysdeps.c: Make tcp socket connection error somewhat more
Sjoerd Simons [Tue, 30 May 2006 15:34:10 +0000 (15:34 +0000)]
  * dbus/dbus-sysdeps.c: Make tcp socket connection error somewhat more
  clear:
  "Failed to connect to socket <host>:<port> <error>" instead of
  "Failed to connect to socket <host>: <error>:<port>"

  * dbus/dbus-transport-unix.c: Fix crash when no host option is given
  for a tcp transport.

18 years ago * qt/*: Update the QtDBus bindings up to revision 546310 in
Thiago Macieira [Mon, 29 May 2006 18:17:09 +0000 (18:17 +0000)]
    * qt/*: Update the QtDBus bindings up to revision 546310 in
        Subversion.
        This adds the dbuscpp2xml tool, that parses a C++ header and
        outputs a D-BUS Introspection XML.

18 years ago2006-05-21 Havoc Pennington <hp@redhat.com>
Havoc Pennington [Sun, 21 May 2006 05:33:52 +0000 (05:33 +0000)]
2006-05-21  Havoc Pennington  <hp@redhat.com>

* glib/dbus-gproxy.c: Put in a pile of assertions that the proxy name
is not NULL when it shouldn't be. Also a couple of possible fixes
for #4637 though I don't understand why the bug happens, to be
honest... also the object constructor has an assert name != NULL
and the name is only currently NULL for peer-to-peer proxies that
I don't think anyone uses? So it should be asserting.
Anyway, for now at least see if we get an earlier assertion failure.

* glib/dbus-gvalue-utils.c: Put in a couple of assertions for
apparently broken code to be sure the tests fail and someone
will fix them...

18 years ago * qt/qdbusmarshall.cpp: Fix a problem of demarshalling lists
Thiago Macieira [Sun, 7 May 2006 09:36:19 +0000 (09:36 +0000)]
    * qt/qdbusmarshall.cpp: Fix a problem of demarshalling lists
        and arrays when they had a single element: has_next returns
        false, even before you read the element. So, instead, check
        the array length.

18 years agoSame changelog as before: fix debug-mode compilation
Thiago Macieira [Sat, 6 May 2006 10:46:38 +0000 (10:46 +0000)]
Same changelog as before: fix debug-mode compilation

18 years ago * qt/qdbusmessage.cpp:
Thiago Macieira [Sat, 6 May 2006 10:37:59 +0000 (10:37 +0000)]
* qt/qdbusmessage.cpp:
* qt/qdbustypehelper_p.h:
* qt/qdbusintegrator.cpp: gcc 3.4 doesn't like Q_FOREACH when
the list is a const-reference

18 years ago* Adding old doc patch that never got applied
John (J5) Palmieri [Wed, 3 May 2006 22:56:35 +0000 (22:56 +0000)]
* Adding old doc patch that never got applied

* dbus/bus.c (dbus_bus_add_match): Add documentation

* doc/dbus-specification.xml: Add documentation for the match rules
  and the AddMatch and RemoveMatch methods

18 years ago * qt/dbusidl2cpp.cpp: There's no callAsync. Use the correct
Thiago Macieira [Tue, 2 May 2006 14:00:27 +0000 (14:00 +0000)]
* qt/dbusidl2cpp.cpp: There's no callAsync. Use the correct
        call (r535506)

* qt/dbusidl2cpp.cpp:
* qt/qdbusabstractadaptor.cpp:
* qt/qdbusabstractadaptor.h: Make QDBusAdaptorConnector be a
        sibling of the QDBusAbstractAdaptor objects instead of the
        parent. (r535848)

* qt/dbusidl2cpp.cpp:
* qt/qdbusabstractinterface.cpp:
* qt/qdbusabstractinterface.h:
* qt/qdbusabstractinterface_p.h:
* qt/qdbusinterface.cpp: Make properties in interfaces
        actually work. The code that was generated would not compile,
        due to moc calls to functions that did not exist. They now
        shall. (r536571)

18 years agoOops, forgot part of the patch. Same ChangeLog entry.
Thiago Macieira [Sun, 30 Apr 2006 11:07:01 +0000 (11:07 +0000)]
Oops, forgot part of the patch. Same ChangeLog entry.

18 years ago * Makefile.am:
Thiago Macieira [Sun, 30 Apr 2006 10:47:47 +0000 (10:47 +0000)]
    * Makefile.am:
        * configure.in:
        * dbus-qt4-1.pc.in: Add a pkg-config file for libdbus-qt4-1.
Thanks to Brad Hards for providing the patch

18 years ago * qt/dbusidl2cpp.cpp: There's no callAsync. Use the correct
Thiago Macieira [Sat, 29 Apr 2006 17:22:47 +0000 (17:22 +0000)]
    * qt/dbusidl2cpp.cpp: There's no callAsync. Use the correct
        call. (r535506)

18 years ago * qt/examples/dbus.cpp: Enhance error messages and use
Thiago Macieira [Sat, 29 Apr 2006 12:49:21 +0000 (12:49 +0000)]
    * qt/examples/dbus.cpp: Enhance error messages and use
        QDBusInterfacePtr.

18 years ago * qt/qdbusinterface.h: Rename QDBusRef to QDBusInterfacePtr
Thiago Macieira [Sat, 29 Apr 2006 12:44:31 +0000 (12:44 +0000)]
    * qt/qdbusinterface.h: Rename QDBusRef to QDBusInterfacePtr
        and disable the copy operators. (r533772, r534746)

        * qt/qdbuserror.h: Remove the automatic cast to
          bool. (r533929)

        * qt/qdbusabstractinterface.cpp:
        * qt/qdbusabstractinterface.h: Change the default call mode to
        not use the event loop. Add convenience call() methods that
        take a CallMode parameter. (r534042)

        * qt/qdbusconnection.h: Change the default call mode to not
        use the event loop. (r534042)

        * qt/qdbusinterface.cpp:
        * qt/qdbusinterface.h: Add a method to tell us if the
        interface is valid (since we don't return a null pointer
        anymore) (r534099)

        * qt/qdbusinterface_p.h: Don't crash if metaObject is 0
        (r534101)

        * qt/qdbusinternalfilters.cpp: Decouple the introspection
        function in two so taht we get the chance to introspect
        without having a QDBusMessage (r534102)

        * qt/qdbusbus.h:
        * qt/qdbusconnection.cpp:
        * qt/qdbusconnection_p.h:
        * qt/qdbusintegrator.cpp: Keep a list of our own names to
        avoid a round-trip to the server when attempting to introspect
        one of our own objects. Also make sure the filter functions
        match the empty interface as well. (r534108)
        Don't keep the connection names. Instead, trust the unique
        connection name (r534111)
        Remove event loop usage (r534112)

18 years ago * qt/qdbusintegrator.cpp: Fix assertion failure spotted by
Thiago Macieira [Sat, 29 Apr 2006 10:07:42 +0000 (10:07 +0000)]
    * qt/qdbusintegrator.cpp: Fix assertion failure spotted by
        Brad Hards.

18 years ago2005-04-28 Robert McQueen <robot101@debian.org>
Robert McQueen [Fri, 28 Apr 2006 21:11:28 +0000 (21:11 +0000)]
2005-04-28  Robert McQueen  <robot101@debian.org>

* glib/dbus-gproxy.c: Fix properties so that they can be given in
any order, making it easier for people who inherit from this
object.

18 years ago2005-04-28 Robert McQueen <robot101@debian.org>
Robert McQueen [Fri, 28 Apr 2006 21:02:16 +0000 (21:02 +0000)]
2005-04-28  Robert McQueen  <robot101@debian.org>

* glib/dbus-gvalue-utils.c: Patch from Jakub Stachowski to fix leaking
of memory from within pointer arrays and lists. Fixes bug #6300.

18 years ago2005-04-28 Robert McQueen <robot101@debian.org>
Robert McQueen [Fri, 28 Apr 2006 20:36:56 +0000 (20:36 +0000)]
2005-04-28  Robert McQueen  <robot101@debian.org>

* glib/dbus-gvalue.c: Patch from Jakub Stachowski to fix a leak in
generating struct signatures. Fixes bug #6083.

18 years ago2005-04-28 Robert McQueen <robot101@debian.org>
Robert McQueen [Fri, 28 Apr 2006 20:09:17 +0000 (20:09 +0000)]
2005-04-28  Robert McQueen  <robot101@debian.org>

* qt/Makefile.am: Tweak CLEANFILES from qdbusconnection.moc
to qdbusconnection_p.moc.

18 years ago2006-04-24 John (J5) Palmieri <johnp@redhat.com>
John (J5) Palmieri [Mon, 24 Apr 2006 15:28:42 +0000 (15:28 +0000)]
2006-04-24 John (J5) Palmieri <johnp@redhat.com>

* README, INSTALL: Doc fixes
Patch from Brad Hards <bradh at frogmouth.net>

18 years ago * qt/examples/dbus.cpp: Use the new merged-interface mode for
Thiago Macieira [Sun, 23 Apr 2006 19:06:55 +0000 (19:06 +0000)]
* qt/examples/dbus.cpp: Use the new merged-interface mode for
the dynamic meta object. No need to guess which interface to
call.

18 years ago * qt/qdbusconnection_p.h:
Thiago Macieira [Sun, 23 Apr 2006 19:04:53 +0000 (19:04 +0000)]
* qt/qdbusconnection_p.h:
* qt/qdbusmetaobject.cpp:
* qt/qdbusmetaobject_p.h:
* qt/qdbusintegrator.cpp: Use the new merged-interface mode
for the dynamic meta object. No need to guess which
interface to call.
* qt/qdbusabstractinterface_p.h:
* qt/qdbusconnection.cpp:
* qt/qdbusintegrator.cpp:
* qt/qdbusinterface.cpp:
* qt/qdbusinterface.h: Make findInterface always return a non-null pointer.
Add a QDBusRef that looks and behaves like DCOPRef.

18 years ago * dbus/dbus-connection.c: Interfaces are optional in method
Thiago Macieira [Sun, 23 Apr 2006 18:54:47 +0000 (18:54 +0000)]
* dbus/dbus-connection.c: Interfaces are optional in method
        calls, so don't give up if the interface parameter is NULL.
Patch reviewed by Havoc Pennington.

18 years ago * qt/qdbusreply.h: Add default constructor and operator=
Thiago Macieira [Sun, 23 Apr 2006 15:17:28 +0000 (15:17 +0000)]
* qt/qdbusreply.h: Add default constructor and operator=
          (r532625)
* qt/qdbustypehelper_p.h: Use a clean namespace: no foreach()
          in public headers (r532952)
* qt/qdbusabstractinterface.cpp:
* qt/qdbusabstractinterface_p.h: Add the AutoDetect mode and
          make it the default (r532951)

18 years ago2006-04-19 John (J5) Palmieri <johnp@redhat.com>
John (J5) Palmieri [Wed, 19 Apr 2006 19:08:23 +0000 (19:08 +0000)]
2006-04-19  John (J5) Palmieri  <johnp@redhat.com>

* dbus/dbus-connection.c: Fix asserts
Patch from Tim Moloney <t.moloney at verizon.net>