Jan Kotas [Tue, 27 Mar 2018 14:06:36 +0000 (07:06 -0700)]
Move String.Comparison.cs to shared CoreLib partition (#17247)
Jan Vorlicek [Tue, 27 Mar 2018 13:27:01 +0000 (15:27 +0200)]
Fix build without libunwind installed (#17221)
* Fix build without libunwind installed
I have removed libunwind dependency in a recent commit, but
it turns out that the build was using incorrect include
paths and it was still depending on the libunwind installation
for the libunwind.h header.
This change fixes it.
* Fix clang warning
The libunwind headers contain two empty structs and clang
issues a warning since the size of such structs is
0 in C and 1 in C++.
This is benign for our purposes, since the affected
structs are not directly used by our code.
dotnet-maestro-bot [Tue, 27 Mar 2018 07:53:56 +0000 (02:53 -0500)]
Update BuildTools, CoreClr, CoreFx to preview3-02627-01, preview3-26327-02, preview3-26327-01, respectively (#17239)
Jan Kotas [Tue, 27 Mar 2018 07:31:55 +0000 (00:31 -0700)]
Delete MemoryExtensions.AsBytes (#17245)
Moved to MemoryMarshal
Jan Kotas [Tue, 27 Mar 2018 07:27:21 +0000 (00:27 -0700)]
Vectorized SequenceCompareTo for Span<char> (#17237)
- This change makes the compare for very short Span strings a bit slower and for longer Span strings many times faster.
- Switch several places where it was a clear benefit to use it.
`String.CompareOrdinal(string,string)` is notable exception that I have left intact for now. It is fine tuned for current string layout, and replacing with a call of vectorized SequenceCompareTo gives mixed results.
Bruce Forstall [Tue, 27 Mar 2018 07:09:33 +0000 (00:09 -0700)]
Merge pull request #17240 from BruceForstall/RemoveTizenPRTrigger
Remove Tizen armel automatic PR triggered jobs
Maryam Ariyan [Tue, 27 Mar 2018 04:56:35 +0000 (21:56 -0700)]
New chunk should be equal/larger than the one it replaces (#17219)
* The new chunk should be equal or larger than the one it is replacing. Fixes #17205
* Adding .exe.stackdump to .gitignore
Jacek Blaszczynski [Thu, 22 Mar 2018 21:17:35 +0000 (22:17 +0100)]
Enable partially implemented Intel HW intrinsics ISAs - CoreCLR part of changes
Wes Haggard [Tue, 27 Mar 2018 00:28:31 +0000 (17:28 -0700)]
Merge pull request #17226 from weshaggard/MergeRestoreTargets
Merge various restore tasks into one Sync target
Bruce Forstall [Tue, 27 Mar 2018 00:27:31 +0000 (17:27 -0700)]
Remove Tizen armel automatic PR triggered jobs
These are failing almost every job with "qeumu: Unsupported
syscall: 389". Issue: https://github.com/dotnet/coreclr/issues/12972.
mikedn [Mon, 26 Mar 2018 23:41:46 +0000 (02:41 +0300)]
Remove a few bogus reinterpret_cast(nullptr_t) (#17229)
reinterpret_cast cannot be used to convert nullptr_t values, so does C++ std says in a note. VC++ ignores this restriction claiming that notes are not normative. Clang enforces the restriction. Oh well...
Carol Eidt [Mon, 26 Mar 2018 23:25:54 +0000 (16:25 -0700)]
Merge pull request #15301 from mikedn/cast-un
Fix inconsistent handling of zero extending casts
Wes Haggard [Mon, 26 Mar 2018 23:13:54 +0000 (16:13 -0700)]
Disable MSBuildEventLogging for optdata alias
We don't need the binclash logger for optdata so disable it
by pass a single space (note empty string means default).
The default value points at net46 which isn't what we want on
linux.
Andy Ayers [Mon, 26 Mar 2018 22:11:39 +0000 (15:11 -0700)]
Use movsdsse2 for HW intrinsic SSE2_ConvertToDouble (#17110)
Instead of movsd, which is for GPRs. Fixes one of the stress failures
seen in #17027.
Bruce Forstall [Mon, 26 Mar 2018 22:05:32 +0000 (15:05 -0700)]
Merge pull request #17018 from dotnet/dev/unix_test_workflow
Enable arm32 Ubuntu testing in CI
Adam Stark [Mon, 26 Mar 2018 20:46:13 +0000 (13:46 -0700)]
Only use FEATURE_PERFTRACING and FEATURE_EVENT_TRACE features when turned on (#17232)
David Mason [Mon, 26 Mar 2018 20:25:32 +0000 (13:25 -0700)]
[local gc] Fix for BitScanForward64, it was ignoring the high byte check (#17142)
dotnet-maestro-bot [Mon, 26 Mar 2018 20:00:05 +0000 (15:00 -0500)]
Update CoreFx to preview3-26326-03 (#17222)
Bruce Forstall [Sun, 25 Mar 2018 21:44:24 +0000 (14:44 -0700)]
Work around Jenkins problem with large env vars
Clear out `ghprbCommentBody` before msbuild is invoked, which can't
deal with large environment variables.
Bruce Forstall [Fri, 2 Mar 2018 19:29:29 +0000 (11:29 -0800)]
Linux arm32 testing
Add support for arm Ubuntu testing on hardware. Most JIT stress jobs are enabled.
GC stress jobs are not enabled currently (they haven't been tried yet).
Most jobs have both PR trigger jobs as well as weekly "cron" jobs.
Job frequency will be adjusted as we gain experience with the load.
Initially, there are no automatically triggered PR jobs, but I plan to add
one or more soon.
Moved existing arm Ubuntu (on emulator) and arm Tizen (on emulator)
to use new "armem" pseudo-architecture.
The arm Ubuntu jobs have the product cross-built on Ubuntu/x64 in Docker,
use tests built in a new Windows_NT x86 BuildOnly (`_bld`) job, and are run
on hardware after copying over all the correct artifacts.
Refactored lots of code related to determining if a particular combination
of os/architecture/configuration/isPR/etc. should create a job.
Refactored test/flow job creation.
runtest.sh now creates three files based on test results that can be fed
back to runtest.sh using the `--playlist` argument: coreclrtests.pass.txt,
coreclrtests.fail.txt, coreclrtests.skip.txt.
New script `runtesttilstable.sh` runs `runtest.sh` in a loop, rerunning failing
tests until no tests fail, or a maximum iteration count is reached (default: 4).
This works around existing issues with flaky test failures on Linux/arm32 hardware.
Some extraneous unused jobs have been removed, such as unused `_bld` jobs
and non-PR triggered `innerloop` jobs.
Victor "Nate" Graf [Mon, 26 Mar 2018 19:10:37 +0000 (12:10 -0700)]
Add /p:UseRazorBuildServer=false to prevent background processes (#17152)
Omair Majid [Mon, 26 Mar 2018 18:18:01 +0000 (14:18 -0400)]
Optionally support using the system-installed libunwind (#17164)
This allows coreclr to link against a system-installed libunwind instead
of using the copy included with the coreclr sources.
The default is still to use the bundled version, except on macOS, where
we always use the system-installed version.
Many Linux distributions prefer to avoid bundled libraries as much as
possible. For their reasons, please see:
- https://fedoraproject.org/wiki/Bundled_Libraries
- https://wiki.debian.org/UpstreamGuide#No_inclusion_of_third_party_code
- https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies
Ahson Khan [Mon, 26 Mar 2018 05:19:11 +0000 (22:19 -0700)]
Update uses of AsBytes to use MemoryMarshal.AsBytes (dotnet/corefx#28460)
* Update uses of AsBytes to use MemoryMarshal.AsBytes
* Cleanup commented out code
* Remove AsBytes from MemoryExtensions Portable
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Wes Haggard [Mon, 26 Mar 2018 18:02:53 +0000 (11:02 -0700)]
Merge various restore tasks into one Sync target
There were various restore targets happening independently
when they should all be combined so the sync step can be
independent from the build step. This change merges them
together under the Sync target.
In particular this moves RestoreOptData and RestoreNETCorePlatforms
to be part of the sync step instead of being individually ran.
Pass BuildType to sync commands so optdata gets restored correctly
Igor Kulaychuk [Mon, 26 Mar 2018 17:58:16 +0000 (20:58 +0300)]
Fix funclet unwinding on x86 Linux (#17144)
Adam Sitnik [Mon, 26 Mar 2018 17:49:43 +0000 (19:49 +0200)]
JitBench scenarios fix (#17154)
* each web app should use a separate directory to avoid conflicts + dead code removal
* update the framework package version to get scenarios benchmarks working
Jarret Shook [Mon, 26 Mar 2018 15:52:11 +0000 (08:52 -0700)]
Merge pull request #17151 from jashook/disable_armlb_windows_jobs
Disable armlb windows jobs
Steve MacLean [Mon, 26 Mar 2018 13:02:19 +0000 (09:02 -0400)]
[Arm64] Remove C++ stubs obscurring assembly versions (#17172)
Koundinya Veluri [Mon, 26 Mar 2018 11:06:55 +0000 (04:06 -0700)]
Don't require all-user permissions on the temp directory for named mutexes on Unix under docker (#17206)
Avoids the need for a workaround for one of the issues seen in https://github.com/dotnet/coreclr/issues/17098
Jacek Blaszczynski [Mon, 26 Mar 2018 08:51:00 +0000 (10:51 +0200)]
build-test.sh: support Clang v4.0 to v6.0, fix always false logic condition preventing tests build (#17025)
dotnet bot [Mon, 26 Mar 2018 07:58:25 +0000 (00:58 -0700)]
Vectorize Span.IndexOf for T = char, similar to T = byte. (#28464) (#17218)
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Phil Garcia [Mon, 26 Mar 2018 06:14:00 +0000 (23:14 -0700)]
Fixed a few typos (#17217)
dotnet-maestro-bot [Mon, 26 Mar 2018 05:20:47 +0000 (00:20 -0500)]
Update CoreFx to preview3-26326-01 (#17216)
Phil Garcia [Mon, 26 Mar 2018 04:18:46 +0000 (21:18 -0700)]
Fixed a few typos (#17215)
* Fixed a few typos
* Fixed a few typos
Ahson Khan [Mon, 26 Mar 2018 00:26:12 +0000 (17:26 -0700)]
Update use of AsBytes in perf tests to use MemoryMarshal.AsBytes. (#17214)
dotnet-maestro-bot [Sun, 25 Mar 2018 22:59:16 +0000 (17:59 -0500)]
Update CoreFx to preview3-26325-01 (#17190)
Ben Adams [Sun, 25 Mar 2018 22:21:16 +0000 (23:21 +0100)]
Dictionary/List code clean up/formatting (C#7) (#17196)
Ahson Khan [Sun, 25 Mar 2018 22:15:00 +0000 (15:15 -0700)]
Fix CompareTo/Equals when dealing with Empty Span or Span wrapping a null string (#17115)
* Fix CompareTo/Equals when dealing with Span wrapping a null string
* Removing unnecessary virtual keyword and address other feedback.
* Remove unnecessary/incorrect Debug.Asserts.
* Remove more unnecessary/incorrect Debug.Asserts.
Bruce Forstall [Sun, 25 Mar 2018 06:07:12 +0000 (23:07 -0700)]
Merge pull request #17201 from BruceForstall/FixDiffable
Fix a case of non-diffable JitDump
Bruce Forstall [Sun, 25 Mar 2018 05:38:58 +0000 (22:38 -0700)]
Fix Unreachable Code warning in desktop build (#17203)
Bruce Forstall [Sun, 25 Mar 2018 02:41:42 +0000 (19:41 -0700)]
Fix a case of non-diffable JitDump
Bruce Forstall [Sun, 25 Mar 2018 01:52:29 +0000 (18:52 -0700)]
Merge pull request #17195 from sdmaclea/PR-Arm64-Assert-on-NYI
[Arm64] Assert on NYI
Steve MacLean [Sat, 24 Mar 2018 22:36:34 +0000 (18:36 -0400)]
[Arm64] Assert on NYI
Anton Lapounov [Sat, 24 Mar 2018 22:48:47 +0000 (15:48 -0700)]
Rename CancellationTokenRegistration.TryDeregister method to Unregister. (#17194)
Reflects CoreRT change https://github.com/dotnet/corert/pull/5612.
mikedn [Sat, 24 Mar 2018 21:21:54 +0000 (23:21 +0200)]
Delete some unused functions (#17193)
Bruce Forstall [Sat, 24 Mar 2018 18:48:38 +0000 (11:48 -0700)]
Merge pull request #17159 from sandreenko/changeTimeOutForAltJitjobs
increase timeout for altjit jobs
Jan Kotas [Sat, 24 Mar 2018 15:30:36 +0000 (08:30 -0700)]
Delete unused files from src/inc (#17186)
Sergey Andreenko [Sat, 24 Mar 2018 08:44:37 +0000 (01:44 -0700)]
[RyuJit/ARM] Fix lsra BuildShiftRotate (#17103)
* add repro
* delete BuildShiftRotate for arm
* fix GT_LSH_HI and GT_RSH_LO
* return the special handling for GT_LSH_HI and GT_RSH_LO
* fix the header
dotnet-maestro-bot [Sat, 24 Mar 2018 05:43:56 +0000 (00:43 -0500)]
Update CoreFx to preview3-26323-09 (#17183)
Egor Chesakov [Sat, 24 Mar 2018 03:17:59 +0000 (20:17 -0700)]
Generate native image for System.Private.CoreLib.dll during Linux/arm build.sh (#17157)
* Add generating native image for System.Private.CoreLib.dll during Linux/arm cross build when __CrossArch/__BuildArch is x86/arm
Carol Eidt [Sat, 24 Mar 2018 01:26:10 +0000 (18:26 -0700)]
Merge pull request #17155 from fiigii/removezero
Remove non-deterministic AVX APIs
Sergey Andreenko [Sat, 24 Mar 2018 00:54:10 +0000 (17:54 -0700)]
[arm32] Disable JIT\jit64\opt\cse\hugeexpr1 stress testing. (#17137)
It fails R2R stress testing, issue 16587
Carol Eidt [Sat, 24 Mar 2018 00:14:46 +0000 (17:14 -0700)]
Merge pull request #17072 from CarolEidt/Fix545505
ARM: call compRsvdRegCheck later
Egor Chesakov [Fri, 23 Mar 2018 19:36:13 +0000 (12:36 -0700)]
Update DockerTag to use the image from dotnet-buildtools-prereqs-docker#38 which enables running x86_arm/crossgen
Bruce Forstall [Fri, 23 Mar 2018 21:57:52 +0000 (14:57 -0700)]
Merge pull request #17133 from sdmaclea/PR-FIX-17095
[Arm64] Fix #17095
Wes Haggard [Fri, 23 Mar 2018 20:28:18 +0000 (13:28 -0700)]
Merge pull request #17136 from weshaggard/OptDataSouceBuildFixes
Fix source-build issues in optdata
Sergey Andreenko [Fri, 23 Mar 2018 19:32:21 +0000 (12:32 -0700)]
increase timeout for altjit jobs
Fei Peng [Fri, 23 Mar 2018 18:21:50 +0000 (11:21 -0700)]
Remove non-deterministic AVX APIs
Bruce Forstall [Fri, 23 Mar 2018 17:47:12 +0000 (10:47 -0700)]
Merge pull request #17083 from BruceForstall/RemoveArmDeadCode
Remove arm32/arm64 dead code
dotnet-maestro-bot [Fri, 23 Mar 2018 17:28:01 +0000 (12:28 -0500)]
Update CoreClr, CoreFx to preview3-26323-05, preview3-26323-06, respectively (#17146)
Stephen Toub [Fri, 23 Mar 2018 16:41:21 +0000 (12:41 -0400)]
Fix Path.GetTempFileName on Windows (#17148)
GetTempFileNameW doesn't return the required length of the buffer; it returns the unique number used in the temporary file name. But the calling code is using that result as a length, resulting in sometimes truncated paths, and sometimes paths that aren't at all related to the original due to state left over in a pooled buffer.
jashook [Fri, 23 Mar 2018 16:33:57 +0000 (09:33 -0700)]
Disable armlb windows jobs
Maryam Ariyan [Fri, 23 Mar 2018 16:29:55 +0000 (09:29 -0700)]
Fixes StringBuilder unbounded size growth in Clear() when we use a mix of Append and Insert (#16926)
* Fixing Clear infinitely growing when we combine usage of Insert and Append. Fixes #27625
* Move debug code to StringBuilder.Debug.cs and Applied code review feedback
* Adding missing debug condition check
* Adding comments and moving Condition on projitems after filename
* Moving the infinite capacity growth fix to Length setter
* Removing originalCapacity and Debug.Assert
* Applying PR feedbacks
* Minor cleanup
* simplifying to single loop
* keeping just one method for ShowChunks function
Carol Eidt [Fri, 23 Mar 2018 16:22:13 +0000 (09:22 -0700)]
Merge pull request #17135 from CarolEidt/DevDiv544985
ARM: correctly unassign constant double
Wes Haggard [Wed, 21 Mar 2018 23:40:34 +0000 (16:40 -0700)]
Fix RestoreSources for optdata packages
Pass unprocessed args to restore optdata step so it
can override the sources when doing restore
Handle prority as an unprocessed arg for the sync alias
Anirudh Agnihotry [Fri, 23 Mar 2018 12:43:47 +0000 (05:43 -0700)]
Rename new Stream.Read/Write{Async} Span/Memory source/Destination arguments to buffer (#17141)
* changed to buffer
* More Common changes
* fixed
* another fix
Igor Kulaychuk [Fri, 23 Mar 2018 11:12:54 +0000 (14:12 +0300)]
Fix Linux/x86 FuncEvalHijack stack alignment (#17143)
dotnet-maestro-bot [Fri, 23 Mar 2018 06:14:05 +0000 (01:14 -0500)]
Update BuildTools, CoreClr, CoreFx to preview3-02622-03, preview3-26322-08, preview3-26323-01, respectively (#17123)
Egor Chesakov [Fri, 23 Mar 2018 03:23:56 +0000 (20:23 -0700)]
Merge pull request #17131 from BredPet/fix_relocation
Fix for #17089
Steve MacLean [Thu, 22 Mar 2018 20:41:33 +0000 (16:41 -0400)]
[Arm64] Fix #17095
Carol Eidt [Thu, 22 Mar 2018 22:05:46 +0000 (15:05 -0700)]
ARM: correctly unassign constant double
When a `RefTypeFixedReg` is encountered for a floating point register, if it is currently holding a double constant, we need to free both halves - but the current register be either half.
Petr Bred [Thu, 22 Mar 2018 19:20:13 +0000 (22:20 +0300)]
Fix bug for #17089
Signed-off-by: Petr Bred <bredpetr@gmail.com>
Brian Sullivan [Thu, 22 Mar 2018 19:51:41 +0000 (12:51 -0700)]
Merge pull request #17132 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Galbraith [Thu, 22 Mar 2018 19:45:52 +0000 (12:45 -0700)]
Merge pull request #16849 from MattGal/use-dotnetcore-build
Move windows agents to DotNetCore-Build
Brian Sullivan [Thu, 22 Mar 2018 19:04:43 +0000 (12:04 -0700)]
Merge pull request #17112 from briansull/rollback-14481
Rollback Stack probing change - PR #14481
David Mason [Thu, 22 Mar 2018 18:44:37 +0000 (11:44 -0700)]
fix order of Serialize for linux build (#17119)
Fix for #17116. The build would work fine for dynamic events on Windows, but on Linux clang always takes the overloads with <Head, Tail...> until there are no arguments, then complains about no overload takes 0 arguments.
Matt Galbraith [Sat, 10 Feb 2018 01:57:35 +0000 (17:57 -0800)]
Move windows agents to DotNetCore-Build to see if we can build in VS2017-only environment
Fei Peng [Wed, 21 Mar 2018 21:51:28 +0000 (14:51 -0700)]
Add emitIns_AR_R_I for vextracti/f128
Fei Peng [Tue, 20 Mar 2018 18:40:39 +0000 (11:40 -0700)]
fix Set tests on 32-bit platforms
Fei Peng [Mon, 19 Mar 2018 22:24:22 +0000 (15:24 -0700)]
Implement SetAllVector256
Fei Peng [Mon, 19 Mar 2018 07:17:31 +0000 (00:17 -0700)]
Implement AVX SetVector256
Fei Peng [Mon, 19 Mar 2018 07:16:34 +0000 (00:16 -0700)]
Optimize AVX Insert/Extract intrinsics
Fei Peng [Mon, 19 Mar 2018 07:15:02 +0000 (00:15 -0700)]
Add more tests for AVX Insert/Extract intrinsics
Konstantin Baladurin [Thu, 22 Mar 2018 14:02:43 +0000 (17:02 +0300)]
[ARM64] Fix UMEntryThunkCode::Poison method (#17122)
Fix hex value of the instruction ldp x16, x0, [x12]
dotnet-maestro-bot [Thu, 22 Mar 2018 05:13:42 +0000 (00:13 -0500)]
Update BuildTools, CoreClr to preview3-02622-01, preview3-26322-01, respectively (#17105)
Brian Robbins [Thu, 22 Mar 2018 04:34:24 +0000 (21:34 -0700)]
Fix incorrect array dereference. (#17113)
Noah Falk [Thu, 22 Mar 2018 02:12:28 +0000 (19:12 -0700)]
Update CODE_OWNERS.TXT (#17114)
Updating owner on the profiler
Ahson Khan [Thu, 22 Mar 2018 01:03:02 +0000 (18:03 -0700)]
Rename {Try}Read/WriteMachineEndian to just {Try}Read/Write (#17106)
Brian Sullivan [Thu, 22 Mar 2018 00:46:10 +0000 (17:46 -0700)]
Rollback Stack probing change - PR #14481
Carol Eidt [Thu, 22 Mar 2018 00:17:44 +0000 (17:17 -0700)]
Fix release build
Jan Vorlicek [Thu, 22 Mar 2018 00:11:59 +0000 (01:11 +0100)]
Remove dependency on libunwind (#17094)
* Add original source of libunwind 1.3-stable
Taken from:
https://github.com/libunwind/libunwind/tree/v1.3-stable
* Enable building of libunwind
This change enables building libunwind and removes
dependency on the libunwind package for all Unixes
except OSX. In OSX the libunwind is part of the OS
and also has support for compact unwind info that
is OSX specific, so we keep using that one.
* Disable warnings in code we don't execute
dotnet-bot [Wed, 21 Mar 2018 22:49:46 +0000 (15:49 -0700)]
Disable legacy_backend jits
[tfs-changeset: 1692827]
Mike McLaughlin [Wed, 21 Mar 2018 22:43:15 +0000 (15:43 -0700)]
Update debugging doc on lldb versions and disabling managed debugging (#17107)
Carol Eidt [Wed, 21 Mar 2018 22:13:17 +0000 (15:13 -0700)]
Remove REG_OPT_RSVD from LSRA's candidate masks if it's reserved.
Stephen Toub [Wed, 21 Mar 2018 21:35:56 +0000 (17:35 -0400)]
Improve DateTime{Offset} "r" and "o" formatting performance (#17092)
Two main changes:
1. Rewrote the formatting to use span, only to then discover that we already had almost exactly the same implementation in Utf8Formatter. As that one had some extra optimizations around JIT behaviors, I ported that over instead.
2. Avoided [ThreadStatic] lookups unless necessary.
ToString/TryFormat for "o"/"O" improve by ~2.5x.
ToString/TryFormat for "r"/"R" improve by ~3x.
Brian Robbins [Wed, 21 Mar 2018 20:31:04 +0000 (13:31 -0700)]
Add More Process Information to EventPipe Traces (#17080)
Frank Gambino [Wed, 21 Mar 2018 20:08:00 +0000 (16:08 -0400)]
Fix strings from being concatenated (#17040)
Jeff Schwartz [Wed, 21 Mar 2018 20:07:00 +0000 (13:07 -0700)]
null terminate the converted LPStr at the right index (#17079)
Mike McLaughlin [Wed, 21 Mar 2018 19:42:49 +0000 (12:42 -0700)]
Add missing license header to test py and cs files (#17102)
Issue #13471
Ahson Khan [Wed, 21 Mar 2018 19:34:48 +0000 (12:34 -0700)]
Moving Span APIs that allow skipping visibility checks to MemoryMarshal (#17087)