Suyeon Hwang [Thu, 15 Apr 2021 07:55:55 +0000 (16:55 +0900)]
Unify error handling function
Because tts_ipc layer is added, error handling code is duplicated.
To remove duplicated code, this patch unifies the functions for handling error from server.
Change-Id: Icc5a43cc8d66a956ef8aa050c01b718454ea8be7
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 17 Nov 2020 08:36:18 +0000 (17:36 +0900)]
Divide __tts_cb_error() into two seperate function
__tts_cb_err() is used for two different purpose, so this function has high complexity.
This patch divides __tts_cb_error() into two functions __handle_service_reset() and
__handle_service_error().
These two function has lower complexity and clear purpose to use.
Thus, it is expected that new developer can easily understand the purpose and behavior of each
function.
Change-Id: I749f292ac3161d1cca33ab8ca6847f8d55f240a3
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 16 Apr 2021 04:32:34 +0000 (13:32 +0900)]
Make validation function for tts_client_s
Using uid is better way to validate tts_client_s.
However, using uid makes unnecessary access for tts_client_s and it makes unsafe pointer access.
This patch makes function for validating tts_client_s using pointer of tts_client_s.
This function is useful when the function does not use uid.
Change-Id: I6f10e64bee6c32c46f78f8124d551d349af5505d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 16 Apr 2021 04:17:48 +0000 (13:17 +0900)]
Remove include statements for unused header
Change-Id: I703f556012ad9c504134758496eb3022ef84e0e0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 26 May 2021 06:02:45 +0000 (15:02 +0900)]
Update version (1.65.4)
Change-Id: I64ae1ce8c2c459d71bd85bc48c874256ee810b08
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 May 2021 07:44:34 +0000 (16:44 +0900)]
Add null check to avoid null reference problem
Change-Id: I717cc485a79eafd97f41f4ca70671dc1a964808f
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 May 2021 06:22:50 +0000 (15:22 +0900)]
Remove access function to avoid toctou problem
Change-Id: I8291353ba9770a470a35cccaddc8a0d6cb8f20ea
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 May 2021 06:15:30 +0000 (15:15 +0900)]
Intialize function pointer to avoid invalid access
Change-Id: I33b539e6735b52bfd42ea7859f1a5c7984150b21
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 May 2021 05:35:48 +0000 (14:35 +0900)]
Swap order of parameter and argument to match proxy and stub
Change-Id: I45e103cd370e38d3bb00d7a7a4534a6bbc160c23
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 21 May 2021 05:15:43 +0000 (14:15 +0900)]
Remove memory leakage on tts_core and tts_engine_parser
Change-Id: I2bdba5074f9ca97af8b40b181fc5653c8e0a7a9f
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 8 Apr 2021 11:53:02 +0000 (20:53 +0900)]
Lock all accessing state code and Use cpp style lock and iteration
Change-Id: I37d67af97884e332ca9392b7d880d91371db5b31
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 8 Apr 2021 07:23:25 +0000 (16:23 +0900)]
Use tts_ipc function as same way regardless of ipc methods.
tts_ipc layer is interface layer.
Thus, developer should not have no interest below the layer.
However, in current code, tts_ipc function is used as different way by the ipc method.
Calling interface as same way is better to read, and if there is difference, the difference should
be covered on implementation layer.
This patch unify the usages of functions in tts_ipc. To unify the usage, this patch also fix the
implementation of each method dbus and tidl.
Change-Id: I557fed82f11cace93f52eb13a9ba37bb9287a38d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 8 Apr 2021 02:52:51 +0000 (11:52 +0900)]
Remove not needed function and reorder the code to log the valid uid
Change-Id: I8e51a8a28c7223fb40cc31feecf02c685fd7f43c
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 7 Apr 2021 12:17:41 +0000 (21:17 +0900)]
Add function on tts_ipc to hide tts_dbus completely
Change-Id: Icee9794fd4b87ab85cc72e4be20acf97689236b6
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 6 Apr 2021 09:36:57 +0000 (18:36 +0900)]
Use tts_ipc_method_e on server side
To match the method handling of client and server, this patch change the code to use
tts_ipc_method_e on server.
Using tts_ipc_method_e, server can be expanded to use other ipc method.
And also, server can clearly know which ipc method is used by client.
Change-Id: I48c98fb567d00fcaff805715bb6c097cc3caddde
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 6 Apr 2021 08:36:45 +0000 (17:36 +0900)]
Join two tidl method, register and request_hello
These two callbacks are called on same and have similar behavior.
So, I combine these two method to simplify the behavior of ttsd_server_initialize().
By this patch, ttsd_server_initialize() has same behavior to use either tidl and dbus method.
Change-Id: I0f5366b8cf1407c7b5943633d19f9b67821d8ddd
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 25 Mar 2021 07:44:11 +0000 (16:44 +0900)]
Create play thread if the app state is still playing
Change-Id: I68a5d0f676cd350063df4aa459bc5a5690b56e47
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 25 Jan 2021 05:18:05 +0000 (14:18 +0900)]
Fix return value of tts_get_max_text_size()
Change-Id: I83c7cfd0c2df8b034bef051ebf2df862a0f20eeb
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 16 Nov 2020 08:58:28 +0000 (17:58 +0900)]
Refactor parameter check
Change-Id: I4612d2f94a0064d153f1af8c7da0e4f18e389df1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 13 Nov 2020 09:47:44 +0000 (18:47 +0900)]
Refactor tts handle check code
To apply unity code to check tts handle, this patch fixes handle check code of each API.
Change-Id: I8168bf04321f81f365a3f38060281b0a922776c9
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 13 Nov 2020 08:03:36 +0000 (17:03 +0900)]
Fix state getter function to return current state directly
This patch fixes getter of current state directyly return the state value to
make clearer and safer checking current state.
Change-Id: Ibd31affec7ab047607aa4469f2247623492bc9d8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 12 Nov 2020 09:11:42 +0000 (18:11 +0900)]
Make functions for set current state into client
Most of funtions in tts.c are directly access tts_client_s to set/get current
state.
This patch provides new functions to access state of client. This function
reduces duplicates code and provides safer access to tts_client_s.
Change-Id: Ia0eac2d4b43adf9badf49ff4b7bc822a19a4c9b5
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 11 Nov 2020 08:23:43 +0000 (17:23 +0900)]
Pass return value of supported_voice_cb to tts_config_mgr_get_voice_list
Change-Id: I746702455b9bd1ba71a52019c6da0437593eca1b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 11 Nov 2020 08:21:30 +0000 (17:21 +0900)]
Make functions to access callbacks and handle of the client
To access safely to member of tts_client_s, this patch define new functions.
Theses functions provides the access of the member of tts_client_s.
And if there is requirement of thread safety, we will easily implement it, only
fixing these functions.
Change-Id: I6190f106ffc334baed4fa0a477fd92f5c204a059
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 11 Nov 2020 05:35:53 +0000 (14:35 +0900)]
Fix tts_client_is_valid() use uid as a parameter
Using the pointer as a parameter may be simple and fast implementation.
However, this program creates a sub thread that the app can not manage and this
sub thread can not know whether the pointer of client is dereferenced.
Thus, using a pointer can occur heap-use-after-free problem in this case.
To remove this kind of issue, this patch changes the parameter from pointer to
integer value uid.
But the code still direct access to pointer
Change-Id: Id657922b0c4c405a525d6cb8ce39516e59a9a744
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 10 Nov 2020 10:59:21 +0000 (19:59 +0900)]
Refactor set/unset client callback logic
To avoid direct access of tts_client_s on tts.c, this patch creates the new function on tts_client.c.
These new functions provides safer access of tts_client_s.
Change-Id: I45d8b5894575951bc2fd34aaf76f8fd9683430f9
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 18 Mar 2021 02:11:49 +0000 (11:11 +0900)]
Fix tts_tidl and tts_dbus use same logic
Change-Id: Ic70c9e0963aee17835beed6826c657c363784ff8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Sungwook Park [Fri, 27 Nov 2020 11:21:12 +0000 (20:21 +0900)]
Support TIDL / dbus IPC
Change-Id: I06a8fcd1d2f51a79e33a4a1d06a66d6f25e27319
Signed-off-by: Sungwook Park <sungwook79.park@samsung.com>
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 8 Mar 2021 01:50:46 +0000 (10:50 +0900)]
Update version (1.65.3)
Change-Id: Id19e2700b76ee225207dcbf0f3adaeef1f27563d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 8 Mar 2021 01:41:02 +0000 (10:41 +0900)]
Add missing mutex unlock before exit the function
Change-Id: I6f6c6f84fc99918f916b387589e5d8e10bcbe83b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 26 Feb 2021 05:04:17 +0000 (14:04 +0900)]
Update version (1.65.2)
Change-Id: Ibeb08f917f10523709decc85624e4b0df185bbf4
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 26 Feb 2021 04:39:33 +0000 (13:39 +0900)]
Fix state check code
Current state check code just checks current state is ready or not.
However, if state is not ready, client is still connected to server,
because playing or processing state also means the connection is still
on.
This patch changes the state check code to exact way.
Change-Id: Idb3be9f1b042c01dbd7c2e5f208866d70d8a25a0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 23 Feb 2021 09:34:29 +0000 (18:34 +0900)]
Update version (1.65.1)
Change-Id: I18e53060c6510df23f0c3cf69bc3a5eb9e6e5497
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 23 Feb 2021 07:59:37 +0000 (16:59 +0900)]
Add mutex to remove race condition among functions of ttsd_player
Change-Id: I34493c7367bda630ae5e0cb78348a3db9caaefb1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
(cherry picked from commit
c6181d507d85f69474837dba5fc8733775f66e18)
Sooyeon Kim [Thu, 18 Feb 2021 10:31:17 +0000 (10:31 +0000)]
Merge "spec: remove unused pkgconfig(libsystemd-daemon) build dependency" into tizen
Suyeon Hwang [Tue, 16 Feb 2021 04:56:54 +0000 (13:56 +0900)]
Remove client data dependency from reprepare thread
Change-Id: I5f65fd56ef3ec89b6f7343b681a0e7dbc08d8150
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
INSUN PYO [Wed, 3 Feb 2021 05:31:42 +0000 (14:31 +0900)]
spec: remove unused pkgconfig(libsystemd-daemon) build dependency
Change-Id: I0e357a90514ac09ee1dfc98a889f8697488249c5
sooyeon.kim [Wed, 16 Dec 2020 09:02:46 +0000 (18:02 +0900)]
Remove unnecessary HTML link for feature
Change-Id: I63ff5ba7ed3e7288ee6cbff8033664f6e46dd1e3
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sungrae jo [Thu, 3 Dec 2020 09:47:24 +0000 (18:47 +0900)]
Fix Native TTS API references
Change-Id: I33ece7bc5d0c31c99f16937bcb721cd0fadebfb1
Signed-off-by: sungrae jo <seongrae.jo@samsung.com>
Suyeon Hwang [Fri, 27 Nov 2020 05:21:03 +0000 (14:21 +0900)]
Version up to 1.65.0
Change-Id: I5ca36efb0d95a600b3f11e0e488b6a4af5d3e0ca
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 27 Nov 2020 05:14:45 +0000 (05:14 +0000)]
Merge changes Ic6ad2c94,I7d0f0397,I5b298cb5,Ib64b8628,I28428a7c into tizen
* changes:
Move service engine status check logic into tts_core
Remove extern definition from tts_dbus
Remove shared variable for callback timer
Refactor prepare/unprepare logic with tts_core
Introduce tts_core.h/c as genral logic layer
Suyeon Hwang [Fri, 20 Nov 2020 07:28:59 +0000 (16:28 +0900)]
Add mutex to wait play thread safely
Change-Id: I4120e70c86042c9fcb87c31c969dba9df6640296
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 4 Nov 2020 06:37:29 +0000 (15:37 +0900)]
Move service engine status check logic into tts_core
tts_core handles all prepare sequence and service engine status is only needed on prepare sequence.
This patch moves all the codes related with service engine status into tts_core.c/h.
Change-Id: Ic6ad2c947b0c6bd40add5842b6c90e0c2577dc56
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon.kim [Mon, 9 Nov 2020 12:20:56 +0000 (21:20 +0900)]
Fix build error in 64bit
Change-Id: I38040f491ddc4cf62e68ffc9e1231b1eb181b310
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
Sungwook Park [Mon, 9 Nov 2020 03:07:20 +0000 (12:07 +0900)]
Remove infinite loop log
Change-Id: I43a0b58706935bccb3eb9c00b258ad384263074d
Signed-off-by: Sungwook Park <sungwook79.park@samsung.com>
sooyeon.kim [Fri, 6 Nov 2020 02:02:00 +0000 (11:02 +0900)]
Return operation failed error when inserting data is failed
Change-Id: Ie8a3d1803bad6978af7b72dfbf9bb1a962c8a68c
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 6 Nov 2020 01:33:08 +0000 (10:33 +0900)]
Fix crash in pringint logs
Change-Id: I6284248b2c32b2edbeb0bb3a607084111cd21e99
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Thu, 5 Nov 2020 09:58:07 +0000 (18:58 +0900)]
Fix build error and Update version (1.60.12)
Change-Id: I632d19dfe19f984cf92c62c4a7a3cc28773866e0
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Thu, 5 Nov 2020 07:49:46 +0000 (16:49 +0900)]
Add logs for checking clients in ttsd_data
Change-Id: Ifbfe0178ffb0b3880b1de9f53f23ea38fa3fe6a2
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
Suyeon Hwang [Mon, 2 Nov 2020 05:20:36 +0000 (14:20 +0900)]
Remove extern definition from tts_dbus
Extern keyword makes easy to use functions in other .c files, but also it makes difficult to trace
call stack and breaks boundary between private and public functions.
This patch removes extern definition from tts_dbus.c and implements these functions on tts_core.
Change-Id: I7d0f039757aedd961f94590489182de688e3d3f2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 30 Oct 2020 07:32:15 +0000 (16:32 +0900)]
Remove shared variable for callback timer
To call client callback asynchronously, current code uses Ecore_timer with shared variable.
But this implementation can cause unexpected problem when multi clients exist.
This patch removes shared Ecore_timer variables and makes Ecore_timer vairable for each clients
on tts_client_s.
Change-Id: I5b298cb55bed27f52e6cab697eca67c6c5441192
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 30 Oct 2020 03:03:17 +0000 (12:03 +0900)]
Refactor prepare/unprepare logic with tts_core
This patch moves core logic of prepare/unprepare into tts_core.c/h.
Change-Id: Ib64b862845aa6fc8b0f6a69847066a1ae7e691e2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 21 Oct 2020 10:53:12 +0000 (19:53 +0900)]
Introduce tts_core.h/c as genral logic layer
tts_core.c/h includes most of general logic to implement TTS FW.
This patch introduces tts_core.c/h as a first step of refactoring client module.
And also, this patch refactors logic to call client callback.
Change-Id: I28428a7c6eca4522c960974f4a0183d327d97f17
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon.kim [Wed, 4 Nov 2020 08:40:26 +0000 (17:40 +0900)]
Add a checker whether pkgmgr_thread is done or not
Change-Id: I78b3c3cbcf6af9b50e2514a1b62837695376bc17
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Mon, 2 Nov 2020 03:18:05 +0000 (12:18 +0900)]
Change not to send dbus message when ttsc is destroyed and Add a checker for validity of ttsd_data_get_pid()
Change-Id: I1360497522e2f2088c5c1357bf14a448d80cd2cc
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
Suyeon Hwang [Fri, 23 Oct 2020 02:14:57 +0000 (11:14 +0900)]
Version up to 1.60.11
Change-Id: Ia49a85a45d0d23b5851d77d95518d203be0ad0b1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 22 Oct 2020 06:31:44 +0000 (15:31 +0900)]
Enhance validation check for current player
Change-Id: Ibc7258394faec26456f639f14a39dd330ca196e6
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 21 Oct 2020 01:28:16 +0000 (10:28 +0900)]
Fix typo (utt_completeted -> utt_completed)
Change-Id: I5f9e3444f40c37aee61aee4e95ec049f361fe61e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon.kim [Fri, 16 Oct 2020 09:14:33 +0000 (18:14 +0900)]
Add a checker of thread cancellation
Change-Id: I27461ca02fdf82b55aa2785b1f32da02e6424621
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Thu, 8 Oct 2020 08:09:02 +0000 (17:09 +0900)]
Update version (1.60.10)
Change-Id: I0807cbdc5f7da7d30784487e39b750fe33501ed8
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
Sooyeon Kim [Thu, 8 Oct 2020 08:03:29 +0000 (08:03 +0000)]
Merge "Fix variable type for credential_needed in ttsd_dbus_server" into tizen
Sooyeon Kim [Thu, 8 Oct 2020 08:02:35 +0000 (08:02 +0000)]
Merge "Revert "Add a checker of screen reader in tts_prepare()"" into tizen
sooyeon.kim [Thu, 8 Oct 2020 07:44:36 +0000 (16:44 +0900)]
Fix variable type for credential_needed in ttsd_dbus_server
Change-Id: Ib1bddef712b54495f6e023cb4417ae4bfae117bc
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
Sooyeon Kim [Thu, 8 Oct 2020 07:17:47 +0000 (07:17 +0000)]
Revert "Add a checker of screen reader in tts_prepare()"
This reverts commit
f99e7d39fd5a4f411af74f2b04a58f1d7635657f.
Change-Id: I67127188dfc8e454b771fada76692cafc46abd64
Sooyeon Kim [Mon, 5 Oct 2020 11:12:39 +0000 (11:12 +0000)]
Merge "Add to call audio_out_unprepare() when g_playing_info is null" into tizen
sooyeon.kim [Mon, 5 Oct 2020 10:21:22 +0000 (19:21 +0900)]
Add to call audio_out_unprepare() when g_playing_info is null
Change-Id: I52cbdc58a89283b6b2c91006df7e9ca0026c1213
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 11 Sep 2020 08:08:31 +0000 (17:08 +0900)]
Add a checker of screen reader in tts_prepare()
Change-Id: I81cec68c66ea2e2daf0b81cce69c583a5d305970
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
(cherry picked from commit
727a0aea05ec1a044278cfcc81aa3aac0f2e1e5d)
biryang1 [Mon, 21 Sep 2020 08:22:57 +0000 (17:22 +0900)]
Remove tts_tag() function
Change-Id: I29d2a373589e5374e1a99b0a79a2755cc5b3b067
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Jihoon Kim [Mon, 27 Jul 2020 01:18:21 +0000 (10:18 +0900)]
Add more unittests
Sep 11 19:49:25 localhost tts-unittests[12848]: [----------] 120 tests from TTSTest (27223 ms total)
Sep 11 19:49:25 localhost tts-unittests[12848]: [----------] Global test environment tear-down
Sep 11 19:49:25 localhost tts-unittests[12848]: [==========] 120 tests from 1 test case ran. (27223 ms total)
Sep 11 19:49:25 localhost tts-unittests[12848]: [ PASSED ] 120 tests.
Change-Id: I5ac5bd4a3da4533a39152128feaaeed5863cf8fe
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
sooyeon.kim [Thu, 10 Sep 2020 06:06:10 +0000 (15:06 +0900)]
Add to avoid a crash in player thread
Change-Id: I8aac7c19383a309e5c85cca501dcc842272c68db
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 4 Sep 2020 10:03:54 +0000 (19:03 +0900)]
Add a timer for prepare once
Change-Id: I747f8e4e14ef5142c71d12242963e9defa29862c
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
(cherry picked from commit
b703adec8bf5e1d104c312eb33d1c07f49f7ed73)
sooyeon.kim [Thu, 20 Aug 2020 07:52:36 +0000 (16:52 +0900)]
Add to set audio handles as NULL
- Fix crash in __pkgmgr_status_cb
- Add a timer handle to notify error
Change-Id: Ie74e81db928273e88d81dd1a901eef6ee1e99852
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:42:39 +0000 (18:42 +0900)]
Add ecore_thread_cancel to avoid crash
Change-Id: I635c27473b4ce8225b9a51f7f2f2fa472497f069
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:37:18 +0000 (18:37 +0900)]
Update version (1.60.9)
Change-Id: I065fae9613ad0b3d4b659fb7d4628f45082eb416
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:33:45 +0000 (18:33 +0900)]
Fix to change background volume when it is changed by tts_setting
Change-Id: If61fd67ad6b8e8cc998682523cc57a4b47e7e5b5
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:30:34 +0000 (18:30 +0900)]
Change a logic to call reprepare
Change-Id: Id2a5adb777953e7965867c76c24be66fa3cd7b1c
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:24:35 +0000 (18:24 +0900)]
Update version (1.60.8)
Change-Id: I68e59f0c05c5e84a43a7697908d510b68f4a0b55
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:20:12 +0000 (18:20 +0900)]
Add INSTALL status into pkgmgr_client_cb
Change-Id: If09373ff73d1e6b6cf17227c6908a1239ebdd27c
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:11:51 +0000 (18:11 +0900)]
Fix an issue not to exit from __play_thread
Change-Id: I710a5be24c48c3518e7a6e7540297439b08d3d07
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 09:02:39 +0000 (18:02 +0900)]
Fix to call __set_policy_for_playing
Change-Id: If8f94c6d58ff8cdb97691d24d738ea889a413248
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 08:57:31 +0000 (17:57 +0900)]
Update version (1.60.7)
Change-Id: I07d4e6cc5f85e5297cb9d0512c9dab24fe39cd9c
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 08:40:49 +0000 (17:40 +0900)]
Remove only proper dbus match
Change-Id: I41bcb8fa422885483b7aec32e31491562d791600
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 08:32:52 +0000 (17:32 +0900)]
Ignore to reprepare when tts engine is already launched
Change-Id: Ib8c2ca008728a5ef27b6031ac7633e21280a451f
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 08:26:24 +0000 (17:26 +0900)]
Change to thread instance of client
Change-Id: I502ce4bd931400694f5afbf20c41b77f8983ac4f
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 08:16:32 +0000 (17:16 +0900)]
Update version (1.60.6)
Change-Id: I72c2025196826a6f009af6f6c14aaa9448d921a8
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 08:14:15 +0000 (17:14 +0900)]
Add a checker whether engine is launched or not
Change-Id: I8d49118dc17c4112cfce15b4a74856922f798669
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 07:48:53 +0000 (16:48 +0900)]
Remove chown setting
Change-Id: I9b8b5ab09b6bbbdd2580ed71bb1fa157e52eb060
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 07:43:44 +0000 (16:43 +0900)]
Update version (1.60.5)
Change-Id: Ie641206b64b66c6bad2e4d02e40a37d6d6454511
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 07:40:49 +0000 (16:40 +0900)]
Add a logic to check activated thread before destroying tts client
Change-Id: I326f171deee0dee502a6ff062fd459d86cde2697
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 07:13:56 +0000 (16:13 +0900)]
Fix to avoid paused_data crash
Change-Id: Ia0db6b669f802ae01adfbe6e4379430ebf985104
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 07:10:04 +0000 (16:10 +0900)]
Change the limit of timeout
Change-Id: I05144fe9aef767dc443c76aff787c86cdc0662db
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
sooyeon.kim [Fri, 24 Jul 2020 07:03:26 +0000 (16:03 +0900)]
Add a logic to check tts engine is installed and launched
Change-Id: Ic7e6adb8e3fc170b793317627d3403fb6a315f47
Signed-off-by: sooyeon.kim <sooyeon.kim@samsung.com>
Suyeon Hwang [Thu, 9 Jul 2020 10:31:07 +0000 (19:31 +0900)]
version up to 1.60.4
Change-Id: Iced20dca6e4c58c3682b44407a76f2c2b2e72217
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 9 Jul 2020 10:22:16 +0000 (19:22 +0900)]
Add null check about client list from tts_client
Change-Id: I6ae21d38aa2f3878e90532ca73e63626ce8bfd67
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 9 Jul 2020 09:24:55 +0000 (18:24 +0900)]
Add mutex lock for global variables in tts_client.c
Global variables, g_client_list and g_allocated_handle, can occur thread safety issue, because
any threads can access these variables.
This patch makes mutex lock for these variables to avoid thread safety issue.
Change-Id: Ie7a2be075ec07d3366b8ee76389a78c91e1a17bb
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 9 Jul 2020 09:19:23 +0000 (09:19 +0000)]
Merge "Revert "Add mutex lock for global variables in tts_client"" into tizen
Suyeon Hwang [Thu, 9 Jul 2020 09:11:55 +0000 (09:11 +0000)]
Revert "Add mutex lock for global variables in tts_client"
This reverts commit
1ec7dcbf00714896f738c92cbf89693a880032cf.
Reason for revert: not intended merge
Change-Id: I6ac66782c09d3797f5f4a00da98f9c5bab8ce7e8
Suyeon Hwang [Thu, 9 Jul 2020 09:11:36 +0000 (09:11 +0000)]
Revert "Return copy of g_client_list"
This reverts commit
b8d4d9fd6809f68d9df8255b47dea97f52fe1f25.
Reason for revert: not intended merge
Change-Id: I56fe5121e5c9590af729386945d74e80657ff315
Suyeon Hwang [Wed, 22 Apr 2020 09:08:40 +0000 (18:08 +0900)]
Return copy of g_client_list
This patch changes the return value of tts_client_get_client_list() to copy of g_client_list.
This change supports safe use of g_client_list and avoids thread safety issues.
Originally, this function returns g_client_list directly.
This kind of access is dangerous, because it allows unmanaged modification of list.
This may occur thread safety issue or dangerous memory access.
However, if function returns copy of g_client_list, g_client_list avoids dangerous access.
And also, callee still accesses all of clients through this copied list.
Change-Id: Ib88ffcf6877130fb92f47cae4167a7340aaa34f6
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 17 Apr 2020 08:23:50 +0000 (17:23 +0900)]
Add mutex lock for global variables in tts_client
Global varaibles, g_client_list and g_allocated_handle, can occur thread safety issue, because
any threads can access these variables.
This patch makes mutex lock for these variables to avoid thread safety issue.
Change-Id: I7ce1adf0c625715b619573d130408f0924da9785
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
projects / platform / core / uifw / tts.git / log