Sebastian Dröge [Tue, 22 Nov 2016 18:01:20 +0000 (20:01 +0200)]
matroska: Add size checks to the parsing of FLAC headers
Matthew Waters [Tue, 22 Nov 2016 12:46:00 +0000 (23:46 +1100)]
flxdec: fix some warnings comparing unsigned < 0
bf43f44fcfada5ec4a3ce60cb374340486fe9fac was comparing an unsigned
expression to be < 0 which was always false.
gstflxdec.c: In function ‘flx_decode_brun’:
gstflxdec.c:322:33: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if ((glong) row - count < 0) {
^
gstflxdec.c:332:33: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if ((glong) row - count < 0) {
^
https://bugzilla.gnome.org/show_bug.cgi?id=774834
Vivia Nikolaidou [Mon, 21 Nov 2016 14:17:31 +0000 (16:17 +0200)]
qtmux: Enable up to 16 unpositioned raw audio channels
https://bugzilla.gnome.org/show_bug.cgi?id=774789
Matthew Waters [Tue, 22 Nov 2016 08:05:00 +0000 (19:05 +1100)]
flxdec: add some write bounds checking
Without checking the bounds of the frame we are writing into, we can
write off the end of the destination buffer.
https://scarybeastsecurity.blogspot.dk/2016/11/0day-exploit-advancing-exploitation.html
https://bugzilla.gnome.org/show_bug.cgi?id=774834
David Evans [Mon, 21 Nov 2016 15:25:23 +0000 (15:25 +0000)]
qtdemux: Be sure not to read off end of FLAC dfLa box
https://bugzilla.gnome.org/show_bug.cgi?id=773712
Nicola Murino [Mon, 21 Nov 2016 10:48:58 +0000 (11:48 +0100)]
matroskademux: add support for skipping invalid data in push mode
https://bugzilla.gnome.org/show_bug.cgi?id=774566
Nicola Murino [Mon, 21 Nov 2016 10:48:29 +0000 (11:48 +0100)]
matroskaparse: add support for skipping invalid data
https://bugzilla.gnome.org/show_bug.cgi?id=774566
Sebastian Dröge [Fri, 18 Nov 2016 15:00:59 +0000 (17:00 +0200)]
rtspsrc: Move to new helper function to parse authentication responses
https://bugzilla.gnome.org/show_bug.cgi?id=774416
christophecvr [Sun, 20 Nov 2016 13:12:16 +0000 (14:12 +0100)]
qtdemux: Fix wrong compiler warning with gcc 6.2
| ../../../git/gst/isomp4/qtdemux.c: In function 'qtdemux_parse_tree':
| ../../../git/gst/isomp4/qtdemux.c:10224:24: error: 'size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
| offset += size;
| ^~
| ../../../git/gst/isomp4/qtdemux.c:10197:25: note: 'size' was declared here
| guint32 size, tag;
| ^~~~
https://bugzilla.gnome.org/show_bug.cgi?id=774747
Tim-Philipp Müller [Sun, 20 Nov 2016 16:15:07 +0000 (16:15 +0000)]
win32: remove copies of generated headers
Sebastian Dröge [Sun, 20 Nov 2016 11:14:08 +0000 (13:14 +0200)]
avidemux: Ensure that raw video have properly aligned buffers
That is, aligned to to 32 bytes for video. Fixes crashes if the raw
buffers are passed to SIMD processing functions.
https://bugzilla.gnome.org/show_bug.cgi?id=774428
Sebastian Dröge [Sun, 20 Nov 2016 11:08:27 +0000 (13:08 +0200)]
qtdemux: Ensure that raw audio and video have properly aligned buffers
That is, aligned to the basic type for audio and to 32 bytes for video.
Fixes crashes if the raw buffers are passed to SIMD processing functions.
https://bugzilla.gnome.org/show_bug.cgi?id=774428
Sebastian Dröge [Mon, 14 Nov 2016 12:44:11 +0000 (14:44 +0200)]
qtmux: Always write edit lists for the tracks to give a more accurate duration
Always write an edit list for the whole track. In general this is not
necessary except for the case of having a gap or DTS adjustment but
it allows to give the whole track's duration in the usually more
accurate media timescale.
https://bugzilla.gnome.org/show_bug.cgi?id=774403
Seungha Yang [Fri, 18 Nov 2016 13:45:45 +0000 (22:45 +0900)]
qtdemux: Remove useless return variable
qtdemux_expose_streams() returns flow error immediately, if there is an error.
So, the variable for the flow return is not needed.
https://bugzilla.gnome.org/show_bug.cgi?id=774674
David Evans [Thu, 17 Nov 2016 13:59:48 +0000 (13:59 +0000)]
qtdemux: Add support for FLAC encapsulated in ISOBMFF
As defined by
https://git.xiph.org/?p=flac.git;a=blob_plain;f=doc/isoflac.txt
https://bugzilla.gnome.org/show_bug.cgi?id=773712
Sebastian Dröge [Thu, 17 Nov 2016 17:59:53 +0000 (19:59 +0200)]
rtpmux: Mark pad as needing reconfiguration again if it failed
And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
https://bugzilla.gnome.org/show_bug.cgi?id=774623
Sebastian Dröge [Thu, 17 Nov 2016 17:59:26 +0000 (19:59 +0200)]
monoscope: Mark pad as needing reconfiguration again if it failed
And return FLUSHING instead of NOT_NEGOTIATED on flushing pads.
https://bugzilla.gnome.org/show_bug.cgi?id=774623
Sebastian Dröge [Thu, 17 Nov 2016 17:58:52 +0000 (19:58 +0200)]
deinterlace: Mark pad as needing reconfiguration again if reconfiguration failed
And consider negotiation failures on flushing pads as FLUSHING, not as
NOT_NEGOTIATED.
https://bugzilla.gnome.org/show_bug.cgi?id=774623
Sebastian Dröge [Thu, 17 Nov 2016 17:56:23 +0000 (19:56 +0200)]
dvdec: Fix handling of negotiation failures
Return NOT_NEGOTIATED if sending the caps event fails, or FLUSHING if
the pad was flushing at that point.
https://bugzilla.gnome.org/show_bug.cgi?id=774623
Scott D Phillips [Fri, 18 Nov 2016 01:16:26 +0000 (17:16 -0800)]
meson: add_global_arguments -> add_project_arguments
https://bugzilla.gnome.org/show_bug.cgi?id=774656
Vinod Kesti [Wed, 16 Nov 2016 05:23:51 +0000 (10:53 +0530)]
splitmuxsink: pad request fails for flvmux
splitmuxsink requests pad from element using pad template like "video_%u", "audio_%u" and "sink_%d". This is true for most of the muxers.
But splitmuxsink not able to request pad to flvmux as flvmux has "audio" and "video" as pad templates.
fix: splitmuxsink should fallback to "audio" and "video" when template not found.
https://bugzilla.gnome.org/show_bug.cgi?id=774507
Sebastian Dröge [Thu, 17 Nov 2016 08:24:28 +0000 (10:24 +0200)]
matroskaparse: Add remaining relevant parts from
a3a55305 to the parser
https://bugzilla.gnome.org/show_bug.cgi?id=774566
Nicola Murino [Wed, 16 Nov 2016 21:39:01 +0000 (22:39 +0100)]
matroskaparse: ignore parsing errors at the end of the file
This is the same change as
a3a55305 for the parser.
https://bugzilla.gnome.org/show_bug.cgi?id=774566
Philippe Normand [Wed, 16 Nov 2016 07:56:34 +0000 (08:56 +0100)]
rtpbin: receive bundle support
A new signal named on-bundled-ssrc is provided and can be
used by the application to redirect a stream to a different
GstRtpSession or to keep the RTX stream grouped within the
GstRtpSession of the same media type.
https://bugzilla.gnome.org/show_bug.cgi?id=772740
Vinod Kesti [Tue, 15 Nov 2016 11:22:39 +0000 (16:52 +0530)]
aacparse: assertion while converting ADTS stream to RAW
aacparse resizes input buffer while converting ADTS stream to RAW,
During buffer resize buffer write permission is not checked.
This throws gst_buffer_is_writable assertion and leads to AV sync issue some times.
It is corrected by making buffer writeable using gst_buffer_make_writable
https://bugzilla.gnome.org/show_bug.cgi?id=774129
Seungha Yang [Tue, 15 Nov 2016 12:17:51 +0000 (21:17 +0900)]
qtdemux: Don't modify upstream TIME segment
TIME segment implies that stream/running time is being handled by upstream.
So, we shouldn't override it without any clue.
This patch is for fixing seek in DASH streaming.
https://bugzilla.gnome.org/show_bug.cgi?id=774196
Arun Raghavan [Mon, 14 Nov 2016 17:03:27 +0000 (22:33 +0530)]
meson: Add define for v4l2-probe config option
Sebastian Dröge [Mon, 14 Nov 2016 15:37:51 +0000 (17:37 +0200)]
deinterleave: Reset caps accumulator to ANY when resyncing the adapter, not EMPTY
The accumulator is filled by intersecting with all the pad caps, as such
it must be initialized with ANY (like it is before the iteration is
started) and not to EMPTY.
Fixes the CAPS query always returning EMPTY caps when resyncing happened
during the query, e.g. because pads were added/removed.
Petr Kulhavy [Mon, 14 Nov 2016 11:13:14 +0000 (12:13 +0100)]
udpsrc: remove redundant saddr unref
The g_object_unref (saddr) before receiving message seems to be redundant as it
is done just before jumping to retry
Though not directly related, part of
https://bugzilla.gnome.org/show_bug.cgi?id=772841
Petr Kulhavy [Sat, 12 Nov 2016 22:34:23 +0000 (23:34 +0100)]
udpsrc: receive control messages only in multicast
Control messages are used only in multicast mode - to detect if the destination
address is not ours and possibly drop the packet. However in non-multicast
modes the messages are still allocated and freed even if not used. Therefore
request control messages from g_socket_receive_message() only in multicast
mode.
https://bugzilla.gnome.org/show_bug.cgi?id=772841
Scott D Phillips [Fri, 11 Nov 2016 18:45:01 +0000 (10:45 -0800)]
Use intermediate guint when handling GstVideoMultiviewFlags
The underlying integer type of the enum GstVideoMultiviewFlags is
implementation defined and may not have the same size as guint.
https://bugzilla.gnome.org/show_bug.cgi?id=774293
Scott D Phillips [Fri, 11 Nov 2016 18:44:18 +0000 (10:44 -0800)]
splitfilesrc: update uri_get_type to match the prototype in GstURIHandlerInterface
https://bugzilla.gnome.org/show_bug.cgi?id=774293
Scott D Phillips [Thu, 27 Oct 2016 05:37:34 +0000 (22:37 -0700)]
meson: don't add_global_arguments when being built as a subproject
https://bugzilla.gnome.org/show_bug.cgi?id=773568
Vincent Penquerc'h [Fri, 21 Oct 2016 14:49:36 +0000 (15:49 +0100)]
flacparse: fix header rewriting being ignored
https://bugzilla.gnome.org/show_bug.cgi?id=727802
Sean DuBois [Wed, 9 Nov 2016 06:25:27 +0000 (06:25 +0000)]
flvmux: Add metadatacreator property
Allow users to set metadatacreator value in the meta packet
https://bugzilla.gnome.org/show_bug.cgi?id=774131
Vivia Nikolaidou [Tue, 1 Nov 2016 17:56:36 +0000 (19:56 +0200)]
splitmuxsink: Use first buffer TS as mux start time
Do not use last buffer TS + buffer duration because buffer duration
might be inaccurate, especially for frame rates like 30fps where a
rounding error is observed.
https://bugzilla.gnome.org/show_bug.cgi?id=773785
Havard Graff [Thu, 3 Nov 2016 14:03:59 +0000 (15:03 +0100)]
rtpjitterbuffer: fix timer-reuse bug
When doing rtx, the jitterbuffer will always add an rtx-timer for the next
sequence number.
In the case of the packet corresponding to that sequence number arriving,
that same timer will be reused, and simply moved on to wait for the
following sequence number etc.
Once an rtx-timer expires (after all retries), it will be rescheduled as
a lost-timer instead for the same sequence number.
Now, if this particular sequence-number now arrives (after the timer has
become a lost-timer), the reuse mechanism *should* now set a new
rtx-timer for the next sequence number, but the bug is that it does
not change the timer-type, and hence schedules a lost-timer for that
following sequence number, with the result that you will have a very
early lost-event for a packet that might still arrive, and you will
never be able to send any rtx for this packet.
Found by Erlend Graff - erlend@pexip.com
https://bugzilla.gnome.org/show_bug.cgi?id=773891
Havard Graff [Sun, 9 Oct 2016 13:59:05 +0000 (15:59 +0200)]
rtpjitterbuffer: fix lost-event using dts instead of pts
The lost-event was using a different time-domain (dts) than the outgoing
buffers (pts). Given certain network-conditions these two would become
sufficiently different and the lost-event contained timestamp/duration
that was really wrong. As an example GstAudioDecoder could produce
a stream that jumps back and forth in time after receiving a lost-event.
The previous behavior calculated the pts (based on the rtptime) inside the
rtp_jitter_buffer_insert function, but now this functionality has been
refactored into a new function rtp_jitter_buffer_calculate_pts that is
called much earlier in the _chain function to make pts available to
various calculations that wrongly used dts previously
(like the lost-event).
There are however two calculations where using dts is the right thing to
do: calculating the receive-jitter and the rtx-round-trip-time, where the
arrival time of the buffer from the network is the right metric
(and is what dts in fact is today).
The patch also adds two tests regarding B-frames or the
“rtptime-going-backwards”-scenario, as there were some concerns that this
patch might break this behavior (which the tests shows it does not).
Havard Graff [Thu, 3 Nov 2016 15:33:53 +0000 (16:33 +0100)]
rtpjitterbuffer: fix bug in reschedule_timer
The new timeout is always going to be (timeout + delay), however, the
old behavior compared the current timeout to just (timeout), basically
being (delay) off.
This would happen if rtx-delay == rtx-retry-timeout, with the result that
a second rtx attempt for any buffers would be scheduled immediately instead
of after rtx-delay ms.
Simply calculate (new_timeout = timeout + delay) and then use that instead.
https://bugzilla.gnome.org/show_bug.cgi?id=773905
Tim-Philipp Müller [Thu, 3 Nov 2016 13:27:51 +0000 (13:27 +0000)]
tests: wavparse: add test for processing an actual .wav file
https://bugzilla.gnome.org/show_bug.cgi?id=773861
Sebastian Dröge [Thu, 3 Nov 2016 10:34:51 +0000 (12:34 +0200)]
wavparse: Don't set caps to NULL after setting them on the srcpad
We would like to check later on EOS if we found a known stream type or
not, to possibly post an error message.
https://bugzilla.gnome.org/show_bug.cgi?id=773861
Sebastian Dröge [Wed, 2 Nov 2016 12:33:28 +0000 (14:33 +0200)]
qtmux: Don't deref NULL pads in debug output
That tends to crash.
Jan Schmidt [Wed, 2 Nov 2016 00:46:07 +0000 (11:46 +1100)]
isomp4: Don't use gst_video_colorimetry_to_string_full()
The API was reverted. Just use the plain
gst_video_colorimetry_to_string() function.
Jan Schmidt [Wed, 2 Nov 2016 00:00:13 +0000 (11:00 +1100)]
splitmuxsink: Fix GObject warnings on shutdown.
Commit 83e718 added a pad template to splitmux request
pads, which means that GstElement now releases the pads on
dispose, but after having removed all elements in the bin
and unlinked them. Make sure we can handle cleanup in that case
without throwing assertions.
https://bugzilla.gnome.org/show_bug.cgi?id=773784
Jan Schmidt [Tue, 1 Nov 2016 15:25:51 +0000 (02:25 +1100)]
splitmuxsrc: Store seek seqnum and send it on EOS / segment events.
GES relies on the EOS event having the seqnum of the seek that
caused it.
Jan Schmidt [Tue, 1 Nov 2016 15:25:00 +0000 (02:25 +1100)]
splitmuxsrc: Forward a not-linked error on the bus
Handle not-linked as for other fatal errors and post it
onto the bus so the app knows
Sebastian Dröge [Tue, 1 Nov 2016 19:00:15 +0000 (21:00 +0200)]
qtdemux: Fix compiler warning
qtdemux.c: In function ‘qtdemux_parse_tree’:
qtdemux.c:10139:16: error: ‘color_table_id’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (color_table_id != 0) {
^
qtdemux.c:10121:19: note: ‘color_table_id’ was declared here
guint16 color_table_id;
^~~~~~~~~~~~~~
Sebastian Dröge [Thu, 20 Oct 2016 14:40:59 +0000 (17:40 +0300)]
qtmux: Use a default interleave of 250ms for all codecs
https://bugzilla.gnome.org/show_bug.cgi?id=773217
Sebastian Dröge [Wed, 19 Oct 2016 11:33:33 +0000 (14:33 +0300)]
qtmux: Use a default interleave when ProRes is used
The ProRes guidelines suggest an interleave of 0.5s is common, but
specifies that for ProRes at most 2MB (for SD) and 4MB (for HD) should
be used per chunk.
It might also make sense to use similar numbers in general.
https://bugzilla.gnome.org/show_bug.cgi?id=773217
Sebastian Dröge [Wed, 19 Oct 2016 11:25:28 +0000 (14:25 +0300)]
qtmux: Allow configuring the interleave size in bytes/time
Previously we were switching from one chunk to another on every single
buffer. This wastes some space in the headers and, depending on the
software, might depend in more reads (e.g. if the software is reading
multiple samples in one go if they're in the same chunk).
The ProRes guidelines suggest an interleave of 0.5s is common, but
specifies that for ProRes at most 2MB (for SD) and 4MB (for HD) should
be used per chunk. This will be handled in a follow-up commit.
https://bugzilla.gnome.org/show_bug.cgi?id=773217
Sebastian Dröge [Fri, 30 Sep 2016 15:22:27 +0000 (18:22 +0300)]
qtmux: Set compressor name, horizontal/vertical resolution and depth for ProRes
This is also required by some software to handle ProRes files.
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Sebastian Dröge [Fri, 30 Sep 2016 15:05:38 +0000 (18:05 +0300)]
qt: Add support for ProRes 4444 XQ
And also 4444 in the muxer.
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Sebastian Dröge [Fri, 30 Sep 2016 14:58:37 +0000 (17:58 +0300)]
qtmux: Write 'clap' atom for ProRes
It's required for ProRes to work with other software.
It is also in the MP4 standard, but inventing values here seems a bit
tricky for the general case and it does not really give any extra
information.
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Sebastian Dröge [Fri, 30 Sep 2016 06:55:58 +0000 (09:55 +0300)]
qtdemux: Read colorimetry information from colr atom if available
https://bugzilla.gnome.org/show_bug.cgi?id=772181
Sebastian Dröge [Thu, 29 Sep 2016 18:56:18 +0000 (21:56 +0300)]
qtmux: Always write colr atom with the colorimetry information
https://bugzilla.gnome.org/show_bug.cgi?id=772181
Sebastian Dröge [Thu, 29 Sep 2016 15:16:18 +0000 (18:16 +0300)]
qtmux: Fix writing of the 'fiel' extension atom
This was also wrong for JPEG2000. Also write it for all MOV files and
JPEG2000, not only for ProRes.
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Sebastian Dröge [Thu, 29 Sep 2016 14:40:23 +0000 (17:40 +0300)]
qtmux: Write 4 bytes of zeroes at the end of the sample description extensions
This is working around some broken software.
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Sebastian Dröge [Wed, 28 Sep 2016 17:55:24 +0000 (20:55 +0300)]
atoms: 'pasp' atom is also part of MP4, write it always
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Vivia Nikolaidou [Mon, 11 Jul 2016 16:30:12 +0000 (19:30 +0300)]
qtmux: Write additional atoms for prores video
These required atoms are: colorimetry, field information, spatial/temporal
quality, and vendor.
https://bugzilla.gnome.org/show_bug.cgi?id=769048
Stian Selnes [Mon, 16 Jun 2014 15:20:32 +0000 (17:20 +0200)]
rtph263depay: Don't drop mode b packets with picture start code
Some buggy payloaders, e.g. rtph263pay, may use mode B for packets
that starts with a picture (or GOB) start code although it's not
allowed. Let's be nice and not drop these packets/frames.
https://bugzilla.gnome.org/show_bug.cgi?id=773516
Havard Graff [Wed, 22 Jun 2016 11:59:35 +0000 (13:59 +0200)]
rtph263ppay: Fix caps leak
Fix leaking caps when downstream has not-fixed caps.
https://bugzilla.gnome.org/show_bug.cgi?id=773515
Stian Selnes [Wed, 26 Oct 2016 14:42:19 +0000 (16:42 +0200)]
rtph263pay: Fix indentation
https://bugzilla.gnome.org/show_bug.cgi?id=773514
Stian Selnes [Tue, 18 Oct 2016 09:35:58 +0000 (11:35 +0200)]
rtph263pay: Use GST_TRACE_OBJECT for logging bitstream parsing
Bump the bitstream parsing to TRACE log level so it doesn't flood the
output when trying to read the more useful DEBUG and LOG messages.
Also use GST_DEBUG_OBJECT instead of GST_DEBUG in various places
https://bugzilla.gnome.org/show_bug.cgi?id=773514
Stian Selnes [Tue, 18 Oct 2016 09:09:10 +0000 (11:09 +0200)]
rtph263pay: Fix leak for B-fragments
Altough commits 6a16be7, 64f9d08 and 0c7e3a8 fixed some issues they
introduced others. This patch fixes the leak of one macroblock for every
B fragment.
Macroblock structures must not be freed immediately after finding the
boundaries as they are stored and used later. However the inital dummy
structure (used for finding the first boundary) must be freed.
CID #1212156
https://bugzilla.gnome.org/show_bug.cgi?id=773512
Alejandro G. Castro [Thu, 20 Oct 2016 11:14:13 +0000 (13:14 +0200)]
rtpbin: avoid generating errors when rtcp messages are empty and check the queue is not empty
Add a check to verify all the output buffers were empty for the
session in a timout and log an error.
https://bugzilla.gnome.org/show_bug.cgi?id=773269
Alejandro G. Castro [Wed, 26 Oct 2016 11:21:29 +0000 (13:21 +0200)]
rtpbin: pipeline gets an EOS when any rtpsources byes
Instead of sending EOS when a source byes we have to wait for
all the sources to be gone, which means they already sent BYE and
were removed from the session. We now handle the EOS in the rtcp
loop checking the amount of sources in the session.
https://bugzilla.gnome.org/show_bug.cgi?id=773218
Matt Staples [Fri, 21 Oct 2016 17:31:00 +0000 (17:31 +0000)]
rtspsrc: Also handle redirect on PLAY
https://bugzilla.gnome.org/show_bug.cgi?id=772610
Petr Kulhavy [Tue, 30 Aug 2016 08:24:43 +0000 (10:24 +0200)]
rtspsrc: allow missing control attribute in case of a single stream
Improve RFC2326 - chapter C.3 compatibility:
In case just a single stream is specified in SDP and the control attribute
is missing do not drop the stream but rather assume "a=control:*"
https://bugzilla.gnome.org/show_bug.cgi?id=770568
William Manley [Sat, 8 Oct 2016 16:11:17 +0000 (18:11 +0200)]
v4l2: Warn, don't assert if v4l gives us a buffer with a too large size
I've seen problems where the `bytesused` field of `v4l2_buffer` would be
a silly number causing the later call to:
gst_memory_resize (group->mem[i], 0, group->planes[i].bytesused);
to result in this error to be printed:
(pulsevideo:11): GStreamer-CRITICAL **: gst_memory_resize: assertion 'size + mem->offset + offset <= mem->maxsize' failed
besides causing who-knows what other problems.
We make the assumption that this buffer has still been dequeued correctly
so just clamp to a valid size so downstream elements won't end up in
undefined behaviour.
The invalid `v4l2_buffer` I saw from my capture device was:
buffer = {
index = 0,
type = 1,
bytesused =
534748928, // <- Invalid
flags = 8260, // V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC | V4L2_BUF_FLAG_ERROR | V4L2_BUF_FLAG_DONE
field = 01330, // <- Invalid
timestamp = {
tv_sec = 0,
tv_usec = 0
},
timecode = {
type = 0,
flags = 0,
frames = 0 '\000',
seconds = 0 '\000',
minutes = 0 '\000',
hours = 0 '\000',
userbits = "\000\000\000"
},
sequence = 0,
memory = 2,
m = {
offset =
3537219584,
userptr =
140706665836544, // Could be nonsense, not sure
planes = 0x7ff8d2d5b000,
fd = -
757747712
},
length = 2764800,
reserved2 = 0,
reserved = 0
}
This is from gdb with my own annotations added.
This was with gst-plugins-good 1.8.1, a Magewell XI100DUSB-HDMI video
capture device and kernel 3.13 using a dodgy HDMI cable which is great at
breaking HDMI capture devices. I'm using io-mode=userptr and have built
gst-plugins-good without libv4l.
https://bugzilla.gnome.org/show_bug.cgi?id=769765
Sebastian Dröge [Thu, 20 Oct 2016 17:41:07 +0000 (20:41 +0300)]
qtmux: Use a better default value for the movie header timescale
Take the maximum video timescale, or if no video track is present the
previous value of 1800.
https://bugzilla.gnome.org/show_bug.cgi?id=769041
Sebastian Dröge [Thu, 20 Oct 2016 17:07:19 +0000 (20:07 +0300)]
qtmux: Be more clever with the default video track timescale
Use the number of milliframes per second for integral and drop-frame
framerates, as suggested by the QT file format specification and other
places. We already did that for integral framerates before, but not for
drop-frame framerates. This now keeps precision better.
For all other framerates, check if it's close to a well-known framerate
and use that instead.
https://bugzilla.gnome.org/show_bug.cgi?id=769041
Vincent Penquerc'h [Mon, 10 Oct 2016 12:00:01 +0000 (13:00 +0100)]
qtdemux: extract interlaced information from jpeg video
This information is hidden in a small chunk of data.
Format found at https://developer.apple.com/standards/qtff-2001.pdf,
page 92, "Video Sample Description", under table 3.1.
https://bugzilla.gnome.org/show_bug.cgi?id=767771
Jagadish [Wed, 26 Oct 2016 07:16:28 +0000 (12:46 +0530)]
gdkpixbufoverlay: Fixing x and y offset computation
While computing the x and y offsets, it's the video resolution and
resized overlay resolution to be used instead of actual overlay image
resoltuion. Due to this, the overlay image used to get wrongly overlayed
in undesired location
https://bugzilla.gnome.org/show_bug.cgi?id=757292
Tim-Philipp Müller [Tue, 1 Nov 2016 18:09:00 +0000 (18:09 +0000)]
meson: update version
Enrique Ocaña González [Mon, 24 Oct 2016 16:56:31 +0000 (16:56 +0000)]
qtdemux: Use the tfdt decode time on byte streams when it's significantly different than the time in the last sample
We consider there's a sifnificant difference when it's larger than on second
or than half the duration of the last processed fragment in case the latter is
larger.
https://bugzilla.gnome.org/show_bug.cgi?id=754230
Sebastian Dröge [Tue, 1 Nov 2016 16:53:15 +0000 (18:53 +0200)]
Back to development
Sebastian Dröge [Tue, 1 Nov 2016 15:57:44 +0000 (17:57 +0200)]
Release 1.10.0
Sebastian Dröge [Tue, 1 Nov 2016 15:47:31 +0000 (17:47 +0200)]
Update .po files
Sebastian Dröge [Tue, 1 Nov 2016 15:41:51 +0000 (17:41 +0200)]
po: Update translations
Tobias Schneider [Thu, 27 Oct 2016 10:01:55 +0000 (12:01 +0200)]
v4l2object: fix extra-controls leak
Gst struct v4l2object->extra_controls is created if user sets appropriate
option but it is not freed on destruction of v4l2object.
https://bugzilla.gnome.org/show_bug.cgi?id=773580
Sebastian Dröge [Mon, 31 Oct 2016 16:00:07 +0000 (18:00 +0200)]
Revert "souphttpsrc: reduce reading latency by using non-blocking read"
This reverts commit
8816764112408766889c8b680a3af51115df4bf5.
It causes issues with the timeouts, and causes connections to be closed
without actual reason. Needs further investigation.
https://bugzilla.gnome.org/show_bug.cgi?id=773509
Sebastian Dröge [Mon, 31 Oct 2016 07:00:49 +0000 (09:00 +0200)]
wavparse: Don't try to add srcpad if we don't know valid caps yet
Otherwise we'll run into an assertion on specially crafted files.
https://bugzilla.gnome.org/show_bug.cgi?id=773643
Nirbheek Chauhan [Thu, 27 Oct 2016 05:53:51 +0000 (11:23 +0530)]
meson: Remove uselessly duplicated dep checks
These checks are done inside the meson.build files for each plugin.
Nirbheek Chauhan [Thu, 27 Oct 2016 05:52:59 +0000 (11:22 +0530)]
meson: dv plugin now works on MSVC
Needs a Meson patch to filter out the useless -lpthread
https://github.com/mesonbuild/meson/pull/962
Branko Subasic [Thu, 27 Oct 2016 12:03:48 +0000 (14:03 +0200)]
matroskamux: allow resolutions above 4096
Modify the caps string to allow width and height greater than 4096.
There is no need to restrict it since the matroska format allows the
width and height values to be up to eight bytes long.
https://bugzilla.gnome.org/show_bug.cgi?id=773582
Scott D Phillips [Mon, 24 Oct 2016 00:23:10 +0000 (17:23 -0700)]
udpsrc: Check for G_PLATFORM_WIN32 for presence of ipi_spec_dest
G_OS_WIN32 is only set when not building with cygwin, but
ipi_spec_dest is missing both with and without cygwin.
https://bugzilla.gnome.org/show_bug.cgi?id=773114
Michael Olbrich [Wed, 26 Oct 2016 06:51:40 +0000 (08:51 +0200)]
souphttpsrc: reset read_position when reading fails
souphttpsrc maintains two variables for the position:
* 'request_position' is where we want to be
* 'read_position' is where we are
During Normal operations both are updated in sync when data arrives. A seek
changes 'request_position' but not 'read_position'.
When the two positions get out of sync, then a new request is send and the
'Range' header is adjusted to the current 'request_position'.
Without this patch, if reading fails, then the source is destroyed. This
triggers a new request, but the range remains unchanged. As a result, the
old range is used and old data will be read.
Changing the 'read_position' to -1 makes it explicitly different from
'request_position' and as a result the 'Range' header is updated correctly.
https://bugzilla.gnome.org/show_bug.cgi?id=773509
Scott D Phillips [Tue, 25 Oct 2016 15:54:34 +0000 (08:54 -0700)]
meson: Don't depend on gstreamer-check-1.0 on windows
https://bugzilla.gnome.org/show_bug.cgi?id=773114
Mark Nauwelaerts [Tue, 25 Oct 2016 13:24:20 +0000 (15:24 +0200)]
rtspsrc: reset connection info to non-flushing when closing
This solves a hanging mainloop in following scenario:
* connect to source
* network/server drops
* pipeline set to NULL (and connection to flushing as part)
* pipeline set to PAUSED/PLAYING (connection to non-flushing, but not recorded)
* [connecting still not possible]
* pipeline set to NULL => mainloop hangs (since no actual flushing is done)
Jan Schmidt [Wed, 26 Oct 2016 03:32:48 +0000 (14:32 +1100)]
splitmuxsink: Only allow one video request pad
The pacing of the overall muxing is controlled
by the video GOPs arriving, so we can only handle
1 video stream, and the request pad is named accordingly.
Ignore a request for a 2nd video pad if there's already
an active one.
Jan Schmidt [Wed, 26 Oct 2016 00:59:32 +0000 (11:59 +1100)]
splitmuxsink: Take ownership of floating refs
sink the floating ref when handed a muxer or sink to use so
we clearly take ownership.
Jan Schmidt [Tue, 25 Oct 2016 03:51:52 +0000 (14:51 +1100)]
splitmuxsink: Set child elements to NULL when removing.
Make sure that elements are in the NULL state when removing.
Fixes critical warnings when errors occur early on in starting up.
Jan Schmidt [Tue, 25 Oct 2016 03:50:53 +0000 (14:50 +1100)]
splitmuxsink: Set pad template on request sink pads
Ensure that the ghost pad returned as a request pad
has the template that was requested
Nirbheek Chauhan [Tue, 25 Oct 2016 05:20:47 +0000 (10:50 +0530)]
Revert "meson: move gstreamer-check-1.0 dependency to tests/check"
This reverts commit
46632694662b96fddb848a1f2091a215b28a2d35.
Does not actually work. See:
https://bugzilla.gnome.org/show_bug.cgi?id=773114#c31
Nicolas Dufresne [Wed, 8 Jun 2016 15:24:37 +0000 (11:24 -0400)]
flvmux: Assume PTS is DTS when PTS is missing
This fixes issue for encoders that only sets the DTS. We assume that
there was no re-ordering when that happens.
https://bugzilla.gnome.org/show_bug.cgi?id=762207
Tim-Philipp Müller [Sun, 23 Oct 2016 23:34:15 +0000 (00:34 +0100)]
meson: fix build outside of gst-all
Scott D Phillips [Fri, 21 Oct 2016 07:42:54 +0000 (00:42 -0700)]
meson: directsound: Add ole32 library dependency
https://bugzilla.gnome.org/show_bug.cgi?id=773114
Scott D Phillips [Fri, 21 Oct 2016 07:42:18 +0000 (00:42 -0700)]
meson: move gstreamer-check-1.0 dependency to tests/check
https://bugzilla.gnome.org/show_bug.cgi?id=773114
Tim-Philipp Müller [Thu, 20 Oct 2016 21:08:14 +0000 (22:08 +0100)]
tests: videomixer: disable racy flush_start_flush_stop test
It's been broken for years, and it's unlikely it will ever
be fixed for collectpads/videomixer now that there's compositor
which works fine. So let's disable it, since all it does
is that it creates noise that distracts from other failures.
Also see the corresponding adder bug as it failed in the same way:
https://bugzilla.gnome.org/show_bug.cgi?id=708891
Jan Alexander Steffens (heftig) [Sun, 9 Oct 2016 14:56:10 +0000 (16:56 +0200)]
tests: Fix souphttpsrc tests without CK_FORK=no
It seems that the forked processes all attempt to handle the listening
socket from the server, and only one has to shutdown the socket to break
the server completely.
Create a new server inside each test to avoid this.
https://bugzilla.gnome.org/show_bug.cgi?id=772656