bsalomon [Tue, 9 Dec 2014 18:04:14 +0000 (10:04 -0800)]
Move shader precision out of GrShaderVar
Review URL: https://codereview.chromium.org/
777443003
bsalomon [Tue, 9 Dec 2014 17:00:49 +0000 (09:00 -0800)]
Use texture size to determine precision of texture coord varyings.
Review URL: https://codereview.chromium.org/
778783002
scroggo [Tue, 9 Dec 2014 16:27:37 +0000 (08:27 -0800)]
Revert of Replace EncodeBitmap with an interface. (patchset #12 id:210001 of https://codereview.chromium.org/
784643002/)
Reason for revert:
Failing serialization tasks in DM:
http://build.chromium.org/p/client.skia/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/352/steps/dm/logs/stdio
Original issue's description:
> Replace EncodeBitmap with an interface.
>
> Gives more flexibility to the caller to decide whether to use the
> encoded data returned by refEncodedData().
>
> Provides an implementation that supports the old version of
> SkPicture::serialize().
>
> TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
>
> BUG=skia:3190
>
> Committed: https://skia.googlesource.com/skia/+/
0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1
>
> Committed: https://skia.googlesource.com/skia/+/
02b217f80b01a7dda8493422e5257c36a9ce8464
TBR=reed@google.com,rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:3190
Review URL: https://codereview.chromium.org/
783393004
scroggo [Tue, 9 Dec 2014 15:44:36 +0000 (07:44 -0800)]
Replace EncodeBitmap with an interface.
Gives more flexibility to the caller to decide whether to use the
encoded data returned by refEncodedData().
Provides an implementation that supports the old version of
SkPicture::serialize().
TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
BUG=skia:3190
Committed: https://skia.googlesource.com/skia/+/
0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1
Review URL: https://codereview.chromium.org/
784643002
robertphillips [Tue, 9 Dec 2014 15:15:20 +0000 (07:15 -0800)]
Rebaselines for https://codereview.chromium.org/
785893004/ (Fix MatrixImageFilter computeFastBounds)
The msaa4 image diffs aren't actually due to the named CL
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
787093002
tomhudson [Tue, 9 Dec 2014 15:09:08 +0000 (07:09 -0800)]
Avoid crash on some 64b ARM NEON platforms.
The compiler may choose to use x30 for a local loop counter;
ensure it's saved. Patch from kevin.petit@arm.com,
verified by benm@google.com.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
786273003
scroggo [Tue, 9 Dec 2014 13:49:50 +0000 (05:49 -0800)]
Rebaseline GalaxyS4 and Nexus10.
TBR=bsalomon
Review URL: https://codereview.chromium.org/
757413003
robertphillips [Tue, 9 Dec 2014 13:35:07 +0000 (05:35 -0800)]
Revert of Replace EncodeBitmap with an interface. (patchset #11 id:190001 of https://codereview.chromium.org/
784643002/)
Reason for revert:
Compilation is failing on some bots
Original issue's description:
> Replace EncodeBitmap with an interface.
>
> Gives more flexibility to the caller to decide whether to use the
> encoded data returned by refEncodedData().
>
> Provides an implementation that supports the old version of
> SkPicture::serialize().
>
> TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
>
> BUG=skia:3190
>
> Committed: https://skia.googlesource.com/skia/+/
0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1
TBR=reed@google.com,scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:3190
Review URL: https://codereview.chromium.org/
787833002
robertphillips [Tue, 9 Dec 2014 13:28:24 +0000 (05:28 -0800)]
Fix MatrixImageFilter computeFastBounds
This CL makes the bounding box returned from SkMatrixImageFilter::computeFastBounds actually contain the final result pixels. This, in turn, fixes the first two rows of the filterfastbounds GM and the SVG web page cited in the bug.
BUG=418417
Review URL: https://codereview.chromium.org/
785893004
fmalita [Tue, 9 Dec 2014 13:28:20 +0000 (05:28 -0800)]
Display text blob bounds in the debugger.
Also fix YPOS.
R=robertphillips@google.com,jbroman@chromium.org
Review URL: https://codereview.chromium.org/
786083002
fmalita [Tue, 9 Dec 2014 13:23:20 +0000 (05:23 -0800)]
Cleanup GM:pictureshadertile
Post review cleanup for https://codereview.chromium.org/
733203005/
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
784053002
scroggo [Tue, 9 Dec 2014 13:23:12 +0000 (05:23 -0800)]
Replace EncodeBitmap with an interface.
Gives more flexibility to the caller to decide whether to use the
encoded data returned by refEncodedData().
Provides an implementation that supports the old version of
SkPicture::serialize().
TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely
BUG=skia:3190
Review URL: https://codereview.chromium.org/
784643002
egdaniel [Mon, 8 Dec 2014 21:26:43 +0000 (13:26 -0800)]
Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory. (patchset #7 id:140001 of https://codereview.chromium.org/
759713002/)
Reason for revert:
break many gm's
Original issue's description:
> Make all blending up to GrOptDrawState be handled by the xp/xp factory.
>
> In this cl the blending information is extracted for the xp and stored in the ODS
> which is then used as it currently is. In the follow up cl, an XP backend will be added
> and at that point all blending work will take place inside XP's.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
7c66342a399b529634bed0fabfaa562db2c0dbd4
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
766653008
egdaniel [Mon, 8 Dec 2014 20:35:16 +0000 (12:35 -0800)]
Fix GrUnPreMulColor.
Current version incorrectly unpacked the resulting sk unpremulled color into rgba.
BUG=skia:3208
Review URL: https://codereview.chromium.org/
787713002
robertphillips [Mon, 8 Dec 2014 19:37:35 +0000 (11:37 -0800)]
Remove virtual clear in PdfViewer's SkNulCanvas
Causing compilation complaints on Windows
Review URL: https://codereview.chromium.org/
783683004
egdaniel [Mon, 8 Dec 2014 19:20:39 +0000 (11:20 -0800)]
Make all blending up to GrOptDrawState be handled by the xp/xp factory.
In this cl the blending information is extracted for the xp and stored in the ODS
which is then used as it currently is. In the follow up cl, an XP backend will be added
and at that point all blending work will take place inside XP's.
BUG=skia:
Review URL: https://codereview.chromium.org/
759713002
fmalita [Mon, 8 Dec 2014 19:13:27 +0000 (11:13 -0800)]
Tweak SkPictureShader's tile semantics.
Currently, the tile offset is added when drawing the picture. This might
have made a tiny bit of sense when the picture was always positioned at
origin, but with a picture cull rect offset things looks really strange.
For example, to specify a tile == the picture cull rect we have to pass
in [-cullrect.x, -cullrect.y, cullrect.width, cullrect.height]. Yikes.
(there's also a bug when not passing a tile, as we use a default tile
== cullrect but don't compensate for the above oddity)
This changes the semantics of the tile offset: it is now subtracted when
drawing the picture tile. As a consequence, one can pass in a tile equal
to the cull rect and get the expected behavior (same when not passing
a tile).
This will require a minor Blink change with the roll, as one client
works around the current behavior:
https://codereview.chromium.org/
789503003
R=reed@google.com,robertphillips@google.com
BUG=440046
Review URL: https://codereview.chromium.org/
733203005
Brian Salomon [Mon, 8 Dec 2014 18:57:30 +0000 (13:57 -0500)]
Massive N10 Rebaseline Part 2
BUG=skia:3205
Review URL: https://codereview.chromium.org/
790533002
robertphillips [Mon, 8 Dec 2014 17:18:58 +0000 (09:18 -0800)]
Add new GM (filterfastbounds)
This new GM visualizes the fast bounds computed by various image-filter-based SkPaints. This is lead up to fixing some issues in fast bound computation.
BUG=418417
Review URL: https://codereview.chromium.org/
788613003
fmalita [Mon, 8 Dec 2014 17:04:05 +0000 (09:04 -0800)]
Constify CreatePictureShader's picture arg.
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
768113004
jvanverth [Mon, 8 Dec 2014 16:10:31 +0000 (08:10 -0800)]
Update dftext expectations after https://codereview.chromium.org/
772633003/.
BUG=skia:3195, skia:3188
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
778043003
reed [Mon, 8 Dec 2014 16:00:29 +0000 (08:00 -0800)]
remove device::clear -- no longer called
BUG=skia:
Review URL: https://codereview.chromium.org/
778373003
Brian Salomon [Mon, 8 Dec 2014 15:50:04 +0000 (10:50 -0500)]
Massive N10 Rebaseline
BUG=skia:3193
Review URL: https://codereview.chromium.org/
783173002
reed [Mon, 8 Dec 2014 14:06:36 +0000 (06:06 -0800)]
make SkColorShader private, use public factory
BUG=skia:
Need https://codereview.chromium.org/
785823002/ to land first
Review URL: https://codereview.chromium.org/
788533002
caryclark [Mon, 8 Dec 2014 12:57:38 +0000 (04:57 -0800)]
add convexity logic and tests for scalar max, Inf, and NaN
PathOps relies on isConvex() only returning true for trivially
convex paths. The old logic also returns true if the paths that
contain NaNs and Infinities. Return kUnknown_Convexity instead
in those cases and in cases where the convexity logic computes
intermediaries that overflow.
Review URL: https://codereview.chromium.org/
784593002
reed [Sat, 6 Dec 2014 04:49:03 +0000 (20:49 -0800)]
clear() is now an alias for drawPaint, so remove its virtual
Needs these to land first:
https://codereview.chromium.org/
733343005
https://codereview.chromium.org/
777413004
BUG=skia:
Review URL: https://codereview.chromium.org/
780393002
jvanverth [Fri, 5 Dec 2014 21:06:35 +0000 (13:06 -0800)]
Add support for half float alpha textures.
This allows us to create distance field textures with better precision,
which may help text quality.
BUG=skia:3103
Review URL: https://codereview.chromium.org/
762923003
egdaniel [Fri, 5 Dec 2014 20:58:28 +0000 (12:58 -0800)]
Check XpFactory equality in DrawState
BUG=skia:
Review URL: https://codereview.chromium.org/
767873006
reed [Fri, 5 Dec 2014 20:46:22 +0000 (12:46 -0800)]
rebaseline after GM change
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
784603002
egdaniel [Fri, 5 Dec 2014 20:40:52 +0000 (12:40 -0800)]
Fix include for GrPortderDuffXferProcessor.cpp
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
771353005
bungeman [Fri, 5 Dec 2014 20:26:44 +0000 (12:26 -0800)]
Factor text size device mapping in SkScalerContext.
All of our font back-ends use the text size in some way other than
simple concatentation with the current matrix. The code here finds
the full device matrix and then decomposes it to extract the text
size.
FreeType, GDI, and DirectWrite use the text size as the pre-hint scale.
CoreText will not scale color emoji above the requested text size,
and certain features like 'trak' are performed on the text size.
Review URL: https://codereview.chromium.org/
748883005
joshualitt [Fri, 5 Dec 2014 20:14:43 +0000 (12:14 -0800)]
get rid of static gps
This may cause a perf regression
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
749413003
egdaniel [Fri, 5 Dec 2014 20:14:26 +0000 (12:14 -0800)]
Move GrPorterDuffXferProcessor to include/gpu/effects.
BUG=skia:
Review URL: https://codereview.chromium.org/
780263003
qiankun.miao [Fri, 5 Dec 2014 19:16:25 +0000 (11:16 -0800)]
Use size of SkRect as the key for blur mask cache
BUG=429409
Review URL: https://codereview.chromium.org/
708073002
reed [Fri, 5 Dec 2014 17:18:27 +0000 (09:18 -0800)]
rebaseline after change to imagefilterscropped gm change
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
779313002
jvanverth [Fri, 5 Dec 2014 15:56:53 +0000 (07:56 -0800)]
Fix overoptimization in distance field code on N7 and N10.
BUG=skia:3188
Review URL: https://codereview.chromium.org/
772633003
reed [Fri, 5 Dec 2014 15:33:00 +0000 (07:33 -0800)]
remove unnecessary save/clip/restore
BUG=skia:
Review URL: https://codereview.chromium.org/
785493003
mtklein [Fri, 5 Dec 2014 15:25:16 +0000 (07:25 -0800)]
Don't upload metrics we don't want to track.
BUG=skia:
Review URL: https://codereview.chromium.org/
758853004
bungeman [Fri, 5 Dec 2014 15:14:53 +0000 (07:14 -0800)]
Tolerate unstarted builds in rebaseline server.
Currently server.py --rietveld-issue will crash if there are any
unstarted trybots on the latest patch. Instead of crashing, warn
that the bot hasn't started yet.
Review URL: https://codereview.chromium.org/
758793003
skia.buildbots [Fri, 5 Dec 2014 07:03:33 +0000 (23:03 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
781043002
jvanverth [Fri, 5 Dec 2014 00:01:53 +0000 (16:01 -0800)]
Ignore failures for n7 and n10 dftext GM.
BUG=skia:3188
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
785433002
bsalomon [Thu, 4 Dec 2014 21:02:47 +0000 (13:02 -0800)]
clean up default precision handling
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
766753006
joshualitt [Thu, 4 Dec 2014 19:35:33 +0000 (11:35 -0800)]
Remove backend factories
BUG=skia:
Review URL: https://codereview.chromium.org/
778453002
mtklein [Thu, 4 Dec 2014 18:47:02 +0000 (10:47 -0800)]
nanobench: upload peak memory usage as its own trace.
We'll end up with a result like this:
"memory_usage" : {
"meta" : {
"max_rss_mb" : 57
}
}
BUG=skia:
Review URL: https://codereview.chromium.org/
780013002
jvanverth [Thu, 4 Dec 2014 18:46:50 +0000 (10:46 -0800)]
Ganesh text rendering cleanup.
Rename GrTextStrike.{cpp.h} to GrFontCache.{cpp,h}
Move contents of GrTextStrike_impl.h to GrFontCache.h
Move glyph uploading to a separate function and remove harmful gotos
Add assert on glyph upload failure (shouldn't happen)
Review URL: https://codereview.chromium.org/
780923002
halcanary [Thu, 4 Dec 2014 18:41:45 +0000 (10:41 -0800)]
rebaseline pdf-native
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/
779073002
joshualitt [Thu, 4 Dec 2014 18:41:40 +0000 (10:41 -0800)]
create and thread batch tracker object
I remove the factory on the next CL
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
c3a6eb23483e5d28073b509a5f637f41660de294
Review URL: https://codereview.chromium.org/
772513002
halcanary [Thu, 4 Dec 2014 18:21:04 +0000 (10:21 -0800)]
pdf-mac clear to black rebaseline
NOTRY=true
TBR=
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
783543002
joshualitt [Thu, 4 Dec 2014 16:59:10 +0000 (08:59 -0800)]
move program descriptor generation to flush
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
829e1b80b1020b17f2078020c990e079b70c077c
Review URL: https://codereview.chromium.org/
777673003
mtklein [Thu, 4 Dec 2014 16:46:51 +0000 (08:46 -0800)]
Upload picture byte size and op count metrics for SKP recording.
Look okay?
{
"results" : {
"desk_amazon.skp_1264_3999" : {
"nonrendering" : {
"bytes" : 75656,
"max_ms" : 1.150187,
"mean_ms" : 1.150187,
"median_ms" : 1.150187,
"min_ms" : 1.150187,
"ops" : 659,
"options" : {
"bench_type" : "recording",
"clip" : "0 0 1000 1000",
"name" : "desk_amazon.skp",
"scale" : "1",
"source_type" : "skp"
}
}
},
...
BUG=skia:
Review URL: https://codereview.chromium.org/
773323002
robertphillips [Thu, 4 Dec 2014 16:43:53 +0000 (08:43 -0800)]
Rebaseline multipicturedraw GMs
This is clean up after https://codereview.chromium.org/
753253002/ (Use variable length key (rather than accumulated matrix) as save layer hoisting key)
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
783523002
reed [Thu, 4 Dec 2014 16:39:09 +0000 (08:39 -0800)]
quick fix to land clear() change
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
774863003
robertphillips [Thu, 4 Dec 2014 16:31:02 +0000 (08:31 -0800)]
Fix SKPBench tiling so MPD and non-MPD match
Two issues with the SKPBench tile computation were causing the MPD path to do more work:
The clip from the parent canvas wasn't being used to trim content off the edges of the MPD tiles
The non-MPD path was not taking the scale into account in its tile placement (resulting in it having fewer, larger active tiles when scaling).
Review URL: https://codereview.chromium.org/
776273002
reed [Thu, 4 Dec 2014 16:06:17 +0000 (08:06 -0800)]
check (thread-tricky) colortable after we've copied the bitmap into a per-thread context
BUG=skia:
Review URL: https://codereview.chromium.org/
766283004
mtklein [Thu, 4 Dec 2014 15:53:21 +0000 (07:53 -0800)]
Fix up RecordReplaceDrawTest memory leak.
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/151/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/
779973002
reed [Thu, 4 Dec 2014 15:50:14 +0000 (07:50 -0800)]
Change clear() to respect the clip
This reverts commit
af641a1c10f176cb9617026d3cc93c117a85d13d.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
783493002
qiankun.miao [Thu, 4 Dec 2014 14:27:03 +0000 (06:27 -0800)]
Add SSSE3 acceleration for S32_D16_filter_DXDY
With this CL, related nanobench can be improved for 565 config.
bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
45a05780867a06b9f8a8d5240cf6c5d5a2c15a35
Review URL: https://codereview.chromium.org/
773753002
joshualitt [Thu, 4 Dec 2014 14:01:45 +0000 (06:01 -0800)]
Revert of move program descriptor generation to flush (patchset #7 id:120001 of https://codereview.chromium.org/
777673003/)
Reason for revert:
breaking linux build
Original issue's description:
> move program descriptor generation to flush
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
829e1b80b1020b17f2078020c990e079b70c077c
TBR=egdaniel@google.com,bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
776243005
joshualitt [Thu, 4 Dec 2014 14:00:41 +0000 (06:00 -0800)]
Revert of create and thread batch tracker object (patchset #9 id:160001 of https://codereview.chromium.org/
772513002/)
Reason for revert:
Breaking linux layout test
Original issue's description:
> create and thread batch tracker object
>
> I remove the factory on the next CL
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
c3a6eb23483e5d28073b509a5f637f41660de294
TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
774133003
reed [Thu, 4 Dec 2014 11:48:34 +0000 (03:48 -0800)]
make clear private (before we delete it)
BUG=skia:
Review URL: https://codereview.chromium.org/
781593002
skia.buildbots [Thu, 4 Dec 2014 07:04:09 +0000 (23:04 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
776873006
jam [Wed, 3 Dec 2014 23:56:36 +0000 (15:56 -0800)]
Revert of Add SSSE3 acceleration for S32_D16_filter_DXDY (patchset #3 id:40001 of https://codereview.chromium.org/
773753002/)
Reason for revert:
breaks build when not using SSE3, since the two method definitions differ in parameter types (typo)
Original issue's description:
> Add SSSE3 acceleration for S32_D16_filter_DXDY
>
> With this CL, related nanobench can be improved for 565 config.
> bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
> bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
> bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
45a05780867a06b9f8a8d5240cf6c5d5a2c15a35
TBR=mtklein@google.com,qkmiao@gmail.com,qiankun.miao@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
761103003
joshualitt [Wed, 3 Dec 2014 23:34:20 +0000 (15:34 -0800)]
create and thread batch tracker object
I remove the factory on the next CL
BUG=skia:
Review URL: https://codereview.chromium.org/
772513002
joshualitt [Wed, 3 Dec 2014 21:57:36 +0000 (13:57 -0800)]
move program descriptor generation to flush
BUG=skia:
Review URL: https://codereview.chromium.org/
777673003
reed [Wed, 3 Dec 2014 21:17:29 +0000 (13:17 -0800)]
Revert of Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/
777003002/)
Reason for revert:
fix landed in chrome to allow this (I hope)
Original issue's description:
> Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/
765643004/)
>
> Reason for revert:
> ../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named 'eraseColor' in 'skia::BitmapPlatformDevice'
>
>
> Original issue's description:
> > remove unused device::eraseColor
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/
b1ab276c3719d6690e58f347c25126d2b8929c5d
>
> TBR=reed@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
8b0197ef2e32be9d62e79d58f8b50811975c79c6
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
779543004
tfarina [Wed, 3 Dec 2014 21:13:02 +0000 (13:13 -0800)]
Add SK_SUPPORT_LEGACY_PORTER_DUFF macro.
This trick will be used to remove deprecated SkPorterDuff API. But first
we need to add it so Android can be updated later.
BUG=skia:3178
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
758133004
mtklein [Wed, 3 Dec 2014 21:07:39 +0000 (13:07 -0800)]
Turn on MPD threading in nanobench.
Seems okay after this small patch to skip lockPixels() / unlockPixels().
BUG=skia:3149
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot
Review URL: https://codereview.chromium.org/
773203003
egdaniel [Wed, 3 Dec 2014 20:22:51 +0000 (12:22 -0800)]
Remove guard on and enable vertexAttrib function pts on GrGLInterface.
BUG=skia:
Review URL: https://codereview.chromium.org/
774303003
egdaniel [Wed, 3 Dec 2014 19:41:54 +0000 (11:41 -0800)]
Use static XPF for porter duff xp factories.
BUG=skia:
Review URL: https://codereview.chromium.org/
776843004
mtklein [Wed, 3 Dec 2014 19:08:47 +0000 (11:08 -0800)]
Copy src in SkDrawLooper::computeFastBounds().
We do alias src and dst when building the BBH. This meant we calculated
the wrong bounds in LayoutTests/ietestcenter/css3/text/textshadow-010.htm.
Not sure how best to test this inside Skia. It may become moot after I
work through the API changes we were talking about today, but if not I'll
make sure it's tested somehow before I'm done with SkDrawLoopers.
BUG=skia:3186
Review URL: https://codereview.chromium.org/
760023004
halcanary [Wed, 3 Dec 2014 19:03:52 +0000 (11:03 -0800)]
Fix PdfViewer BGR byte order
BUG=skia:3184
Review URL: https://codereview.chromium.org/
775763003
bsalomon [Wed, 3 Dec 2014 18:46:08 +0000 (10:46 -0800)]
Add glGetShaderPrecisionFormat
Review URL: https://codereview.chromium.org/
778703003
halcanary [Wed, 3 Dec 2014 18:41:11 +0000 (10:41 -0800)]
Revert of remove unused device::eraseColor (patchset #1 id:1 of https://codereview.chromium.org/
765643004/)
Reason for revert:
../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named 'eraseColor' in 'skia::BitmapPlatformDevice'
Original issue's description:
> remove unused device::eraseColor
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
b1ab276c3719d6690e58f347c25126d2b8929c5d
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
777003002
egdaniel [Wed, 3 Dec 2014 18:40:13 +0000 (10:40 -0800)]
Add XferProcessor factory in GrPaint and GrDrawState.
In this CL the XP should have zero effect on the actual rendering pipeline.
BUG=skia:
Review URL: https://codereview.chromium.org/
751283002
Brian Salomon [Wed, 3 Dec 2014 18:36:10 +0000 (13:36 -0500)]
rebaseline images
TBR=
Review URL: https://codereview.chromium.org/
776983003
jvanverth [Wed, 3 Dec 2014 18:35:37 +0000 (10:35 -0800)]
Update color emoji GMs after https://codereview.chromium.org/
759613005/.
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
775163002
reed [Wed, 3 Dec 2014 17:47:48 +0000 (09:47 -0800)]
remove unused device::eraseColor
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
765643004
joshualitt [Wed, 3 Dec 2014 17:29:52 +0000 (09:29 -0800)]
bug fix for cubic low precision
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
776953002
halcanary [Wed, 3 Dec 2014 16:59:48 +0000 (08:59 -0800)]
update tileimagefilter gm expectations
TBR=reed@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
777683002
mtklein [Wed, 3 Dec 2014 16:48:57 +0000 (08:48 -0800)]
Decompose a weird assert.
I got my hands on a list of new warnings coming out of MSVC when run with /analyze.
I scanned over them and didn't see any bugs, but I did notice this is just a weird
way to write this expression. (MSVC /analyze was wary of '=' in a boolean expression.)
BUG=skia:
Review URL: https://codereview.chromium.org/
776033002
Mike Klein [Wed, 3 Dec 2014 16:32:37 +0000 (11:32 -0500)]
Rebaseline verylargebitmap
BUG=skia:
Review URL: https://codereview.chromium.org/
778693002
mtklein [Wed, 3 Dec 2014 16:18:46 +0000 (08:18 -0800)]
Remove unused constants.
BUG=skia:
Review URL: https://codereview.chromium.org/
773193004
halcanary [Wed, 3 Dec 2014 16:17:57 +0000 (08:17 -0800)]
(re)baseline several of my gms
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/
780593002
robertphillips [Wed, 3 Dec 2014 15:33:57 +0000 (07:33 -0800)]
Fuse GrReplacements and GrLayerCache
The conversion step from GrCachedLayer to ReplacementInfo isn't necessary.
Review URL: https://codereview.chromium.org/
769533004
joshualitt [Wed, 3 Dec 2014 14:24:10 +0000 (06:24 -0800)]
First step to moving vertex attributes to the geometryProcessor
BUG=skia:
Review URL: https://codereview.chromium.org/
761563002
kkinnunen [Wed, 3 Dec 2014 14:18:12 +0000 (06:18 -0800)]
Make debugger not fail with webpages_playback script and multiple skp files
The debugger accepts either a single skp or a directory as a parameter.
The webpages_playback script used to pass multiple files using a '*'
glob.
Review URL: https://codereview.chromium.org/
775073002
kkinnunen [Wed, 3 Dec 2014 13:51:24 +0000 (05:51 -0800)]
Update webpages_playback documentation
Update the documentation on how to run webpages_playback. It was out of
date.
Review URL: https://codereview.chromium.org/
778633002
kkinnunen [Wed, 3 Dec 2014 12:38:46 +0000 (04:38 -0800)]
Remove Google Storage scheme prefix correctly from gs base name in webpages_playback
In python, str.lstrip([chars]) means "lstrip any of the chars from str",
not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia".
Replace with custom function stripping the prefix from lstrip()ed gs
base name.
Review URL: https://codereview.chromium.org/
780493002
kkinnunen [Wed, 3 Dec 2014 12:22:06 +0000 (04:22 -0800)]
Make render_pdfs not crash webpages_playback script
The render_pdfs nowadays seems to input the skps from
the dir passed as '-r' parameter.
The app will not output anything, but it will not crash the
webpages_playback script either. Affects only runs that have
--skia_tools=<dir> argument.
Review URL: https://codereview.chromium.org/
776873004
skia.buildbots [Wed, 3 Dec 2014 07:05:53 +0000 (23:05 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
773113004
reed [Wed, 3 Dec 2014 04:04:40 +0000 (20:04 -0800)]
Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE (patchset #1 id:1 of https://codereview.chromium.org/
759303004/)
Reason for revert:
reverted clear() change
Original issue's description:
> rebaseline after clear change -- pdf was not treating clear as SRC_MODE
>
> BUG=skia:
> NOTRY=True
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
2fb352abebc342a322d4a66c054bbff8bd565767
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
774073002
reed [Wed, 3 Dec 2014 03:40:18 +0000 (19:40 -0800)]
Revert "Change clear() to respect the clip"
This reverts commit
3729469d6a12266037b697c2192768545e097ab0.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
778563002
reed [Wed, 3 Dec 2014 03:11:30 +0000 (19:11 -0800)]
Revert of implement device::clear until we can remove callers in chrome skia/ext (patchset #1 id:1 of https://codereview.chromium.org/
773903002/)
Reason for revert:
failing win unittests
Original issue's description:
> implement device::clear until we can remove callers in chrome skia/ext
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
252fccfb546efe83fb1d2c7a0b3c18a96ff46ea4
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
774063002
qiankun.miao [Wed, 3 Dec 2014 02:26:09 +0000 (18:26 -0800)]
Add SSSE3 acceleration for S32_D16_filter_DXDY
With this CL, related nanobench can be improved for 565 config.
bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x
bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x
BUG=skia:
Review URL: https://codereview.chromium.org/
773753002
abarth [Tue, 2 Dec 2014 23:47:33 +0000 (15:47 -0800)]
Add matrix operations to C canvas API
R=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
769123002
halcanary [Tue, 2 Dec 2014 22:01:46 +0000 (14:01 -0800)]
work in progress
Review URL: https://codereview.chromium.org/
769423002
derekf [Tue, 2 Dec 2014 21:51:29 +0000 (13:51 -0800)]
check matrix does not have rotation or perspective transformation
When checking whether we need apply AA to a rect for non-msaa target,
simply checking that the mapped rect is integer is not enough.
We need to check whether the transformation matrix has transformations
other than simple translation.
Original-Author: Henry Song <henrysong@samsung.com>
Review URL: https://codereview.chromium.org/
772953002
mtklein [Tue, 2 Dec 2014 21:17:05 +0000 (13:17 -0800)]
Flail a little against LLVM crash.
Cannot reproduce this in my local Chromium checkout (using their Clang, just like the bots).
BUG=skia:
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
764433003
reed [Tue, 2 Dec 2014 20:53:04 +0000 (12:53 -0800)]
implement device::clear until we can remove callers in chrome skia/ext
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
773903002
halcanary [Tue, 2 Dec 2014 20:31:26 +0000 (12:31 -0800)]
baseline colorwheelnative
TBR=scroggo@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
777443002