review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 20:51:13 +0000 (20:51 +0000)]

Revert of Remove setLocalMatrix calls from picture shader GM. (https://codereview.chromium.org/260863007/)

Reason for revert:
changed GM unexpectedly. will sort out and try again

Original issue's description:
> Remove setLocalMatrix calls from picture shader GM.
>
> This makes all --skr tests pass for me. Enabling it by default in DM.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14549

R=reed@google.com, fmalita@google.com, mtklein@chromium.org
TBR=fmalita@google.com, mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/265013003

git-svn-id: http://skia.googlecode.com/svn/trunk@14550 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 20:30:11 +0000 (20:30 +0000)]

Remove setLocalMatrix calls from picture shader GM.

This makes all --skr tests pass for me. Enabling it by default in DM.

BUG=skia:2378
R=reed@google.com, mtklein@google.com, fmalita@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/260863007

git-svn-id: http://skia.googlecode.com/svn/trunk@14549 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 20:28:56 +0000 (20:28 +0000)]

Choose memset procs once.

TSAN shows us racing on the function pointers.  Might as well fix it.

WARNING: ThreadSanitizer: data race (pid=19995)
  Read of size 8 at 0x7f703affb048 by thread T12 (mutexes: write M2957):
    #0 SkBitmap::internalErase(SkIRect const&, unsigned int, unsigned int, unsigned int, unsigned int) const /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkBitmap.cpp:886 (tests+0x0000003511ca)
    #1 SkBitmap::eraseARGB(unsigned int, unsigned int, unsigned int, unsigned int) const /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkBitmap.cpp:919 (tests+0x0000003534bf)
    #2 (anonymous namespace)::DecodingImageGenerator::getPixels(SkImageInfo const&, void*, unsigned long) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/images/SkDecodingImageGenerator.cpp:195 (tests+0x00000051bee1)
    #3 SkDiscardablePixelRef::onNewLockPixels(SkPixelRef::LockRec*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/lazy/SkDiscardablePixelRef.cpp:63 (tests+0x00000039ad9c)
    #4 SkPixelRef::lockPixels(SkPixelRef::LockRec*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkPixelRef.cpp:179 (tests+0x0000003fec23)
    #5 SkBitmap::lockPixels() const /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkBitmap.cpp:414 (tests+0x00000034e41e)
    #6 SkAutoLockPixels /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/include/core/SkBitmap.h:819 (tests+0x0000002752f3)
    #7 ImageDecoderOptions(skiatest::Reporter*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/tests/ImageDecodingTest.cpp:565 (tests+0x000000275d03)
    #8 skiatest::Test::run() /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/tests/Test.cpp:107 (tests+0x0000002263e7)
    #9 SkTestRunnable::run() /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/tests/skia_test.cpp:108 (tests+0x0000001d8607)
    #10 SkThreadPoolPrivate::ThreadLocal<void>::run(SkTRunnable<void>*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/include/utils/SkThreadPool.h:108 (tests+0x0000001d817e)
    #11 thread_start(void*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/utils/SkThreadUtils_pthread.cpp:66 (tests+0x000000604347)

  Previous write of size 8 at 0x7f703affb048 by thread T26:
    [failed to restore the stack]

BUG=skia:1792
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/250503003

git-svn-id: http://skia.googlecode.com/svn/trunk@14548 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 20:27:50 +0000 (20:27 +0000)]

Add literal picture recording mode, triggered by a compile time switch.

This is helpful to record SKPs from Chrome as a fair bootstrapping source for
SkRecord. Without this sort of switch, a good bit of SkPicture's cleverness is
baked into the SKP, and thus SkRecord looks unfairly good.

Tested by defining SK_RECORD_LITERAL_PICTURES and running dm --match
~optimizations. By design that GM will never pass in literal mode.

BUG=skia:2378
R=robertphillips@google.com, reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/246393008

git-svn-id: http://skia.googlecode.com/svn/trunk@14547 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 20:26:01 +0000 (20:26 +0000)]

mark flaky GM tests as ignore-failure
followup to https://codereview.chromium.org/265043002 ('commit GM actuals as expectations for all tests, marking them as unreviewed')

BUG=skia:2332
NOTREECHECKS=True
NOTRY=True
R=djsollen@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/269763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14546 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 20:14:59 +0000 (20:14 +0000)]

guard against self-assignment

BUG=skia:
R=mtklein@google.com, bungeman@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/264793014

git-svn-id: http://skia.googlecode.com/svn/trunk@14545 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 19:59:59 +0000 (19:59 +0000)]

Don't run GPU configs in bench_pictures on RHB

BUG=skia:2518
R=epoger@google.com, djsollen@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/262803012

git-svn-id: http://skia.googlecode.com/svn/trunk@14544 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 2 May 2014 19:13:11 +0000 (19:13 +0000)]

Fix for SkMatrixConvolutionImageFilter with large borders.

Intersect the requested processing rect with the destination
bounds.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/267863004

git-svn-id: http://skia.googlecode.com/svn/trunk@14543 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 18:00:58 +0000 (18:00 +0000)]

re-enable simpleblurroundrect gm now that all the rebaselines have landed

BUG=skia:
R=djsollen@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/268763004

git-svn-id: http://skia.googlecode.com/svn/trunk@14542 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 2 May 2014 17:44:34 +0000 (17:44 +0000)]

Revert of Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. (https://codereview.chromium.org/243413002/)

Reason for revert:
This is firing an assert on many of the Android debug bots

Original issue's description:
> Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.
>
> BUG=skia:2402
>
> Committed: http://code.google.com/p/skia/source/detail?r=14533

git-svn-id: http://skia.googlecode.com/svn/trunk@14541 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 2 May 2014 17:41:33 +0000 (17:41 +0000)]

Remove extra includes from android sample app

R=borenet@google.com

Review URL: https://codereview.chromium.org/264773012

git-svn-id: http://skia.googlecode.com/svn/trunk@14540 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 17:37:05 +0000 (17:37 +0000)]

Revert of Fix iOS build. (https://codereview.chromium.org/269663008/)

Reason for revert:
Reverting as this is a follow on to https://codereview.chromium.org/243413002/ which is breaking android debug bots

Original issue's description:
> Fix iOS build.
>
> Committed: https://code.google.com/p/skia/source/detail?r=14537

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/261983002

git-svn-id: http://skia.googlecode.com/svn/trunk@14539 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 16:48:30 +0000 (16:48 +0000)]

remove self-tests for no-longer-supported rebaseline.py
see https://codereview.chromium.org/262703003 ('mark rebaseline.py as deprecated')

NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/265073002

git-svn-id: http://skia.googlecode.com/svn/trunk@14538 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 2 May 2014 16:15:41 +0000 (16:15 +0000)]

Fix iOS build.

Review URL: https://codereview.chromium.org/269663008

git-svn-id: http://skia.googlecode.com/svn/trunk@14537 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 2 May 2014 15:59:13 +0000 (15:59 +0000)]

adjust win7 perf ranges to reduce flakiness

Review URL: https://codereview.chromium.org/267903002

git-svn-id: http://skia.googlecode.com/svn/trunk@14536 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 2 May 2014 15:54:00 +0000 (15:54 +0000)]

adjust android perf ranges to reduce flakiness.

Review URL: https://codereview.chromium.org/264793012

git-svn-id: http://skia.googlecode.com/svn/trunk@14535 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Fri, 2 May 2014 15:38:39 +0000 (15:38 +0000)]

Lower range for bench expectation for the following faster tests.

desk_yahoosports.skp_simple_viewport_1000x1000_scalar_1.100000

Review URL: https://codereview.chromium.org/261813004

git-svn-id: http://skia.googlecode.com/svn/trunk@14534 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 15:08:18 +0000 (15:08 +0000)]

Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.

BUG=skia:2402
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/243413002

git-svn-id: http://skia.googlecode.com/svn/trunk@14533 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 14:57:25 +0000 (14:57 +0000)]

commit GM actuals as expectations for all tests, marking them as unreviewed

BUG=skia:1578
NOTREECHECKS=True
NOTRY=True
R=reed@google.com
TBR=reed

Author: epoger@google.com

Review URL: https://codereview.chromium.org/265043002

git-svn-id: http://skia.googlecode.com/svn/trunk@14532 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 2 May 2014 14:43:12 +0000 (14:43 +0000)]

Fix type in DM/mesa

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/269723004

git-svn-id: http://skia.googlecode.com/svn/trunk@14531 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 14:34:18 +0000 (14:34 +0000)]

mark rebaseline.py as deprecated

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=senorblanco@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/262703003

git-svn-id: http://skia.googlecode.com/svn/trunk@14530 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 14:22:38 +0000 (14:22 +0000)]

Mark drawbitmaprect's large bitmaps as immutable.

This reduces the peak memory usage of out/Debug/dm --skr --match drawbitmaprect from ~1.6G to ~200M.

I'm not sure how the numbers got so huge to begin with from a 2K x 2K 8888 bitmap (16MB).

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/265813007

git-svn-id: http://skia.googlecode.com/svn/trunk@14529 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 2 May 2014 14:12:54 +0000 (14:12 +0000)]

Add initial baselines for discard GM

Review URL: https://codereview.chromium.org/267763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14528 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 14:13:08 +0000 (14:13 +0000)]

Add Doxygen link to titlebar.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/268773002

git-svn-id: http://skia.googlecode.com/svn/trunk@14527 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 12:56:43 +0000 (12:56 +0000)]

Need checkerboard on history images too.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/267723010

git-svn-id: http://skia.googlecode.com/svn/trunk@14526 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 2 May 2014 12:39:41 +0000 (12:39 +0000)]

Add flag for SkGpuSurface creation to enable distance fields.

BUG=skia:2173
R=bsalomon@google.com, reed@google.com, bungeman@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/261783004

git-svn-id: http://skia.googlecode.com/svn/trunk@14525 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 2 May 2014 03:03:47 +0000 (03:03 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14524 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 1 May 2014 22:37:56 +0000 (22:37 +0000)]

Rebaselines for r14518 (Add support for kEmbeddedBitmapText_Flag to DirectWrite.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14523 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 21:23:19 +0000 (21:23 +0000)]

Fix image decode thrashing when drawing a very large source image to a GPU canvas

R=bsalomon@google.com

Author: junov@chromium.org

Review URL: https://codereview.chromium.org/265763005

git-svn-id: http://skia.googlecode.com/svn/trunk@14522 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 21:06:39 +0000 (21:06 +0000)]

DM: Apply initial transform in --skr mode.

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/263853005

git-svn-id: http://skia.googlecode.com/svn/trunk@14521 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 21:03:53 +0000 (21:03 +0000)]

Remove dead code.

No files reference this file.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/255243002

git-svn-id: http://skia.googlecode.com/svn/trunk@14520 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 20:52:12 +0000 (20:52 +0000)]

Add checkerboard under the image.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/263853004

git-svn-id: http://skia.googlecode.com/svn/trunk@14519 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 1 May 2014 20:39:14 +0000 (20:39 +0000)]

Add support for kEmbeddedBitmapText_Flag to DirectWrite.

R=reed@google.com

Review URL: https://codereview.chromium.org/263503004

git-svn-id: http://skia.googlecode.com/svn/trunk@14518 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 20:20:50 +0000 (20:20 +0000)]

Revert of Roll ANGLE. (https://codereview.chromium.org/237173002/)

Reason for revert:
breaking the buildbots (see http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Release-ANGLE/builds/3198).

NOTRY=true

Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
>
> Committed: http://code.google.com/p/skia/source/detail?r=14509

R=bsalomon@chromium.org, bsalomon@google.com, geofflang@chromium.org, djsollen@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/264733006

git-svn-id: http://skia.googlecode.com/svn/trunk@14517 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 20:17:18 +0000 (20:17 +0000)]

Fix history on workspaces, where you couldn't click on old tries.

Also allow editing the first and last line because you might need
to do that to fix "old" tries that are already stored in the database.
By "old" I mean yesterday.

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/264833004

git-svn-id: http://skia.googlecode.com/svn/trunk@14516 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 20:10:03 +0000 (20:10 +0000)]

Run Squid as a reverse caching proxy on port 80 and proxy the requests
to the server running on port 8000.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/261023002

git-svn-id: http://skia.googlecode.com/svn/trunk@14515 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:31:31 +0000 (19:31 +0000)]

create struct to hold all the params passed around for shader::context

BUG=skia:
R=scroggo@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/264843006

git-svn-id: http://skia.googlecode.com/svn/trunk@14514 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:30:35 +0000 (19:30 +0000)]

Add more detailed logging when things go wrong in android_run_skia

R=borenet@google.com, halcanary@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/263733006

git-svn-id: http://skia.googlecode.com/svn/trunk@14513 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:29:53 +0000 (19:29 +0000)]

tweaks to tab CSS for rebaseline server page; moar pretty

BUG=skia:
R=epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/264853004

git-svn-id: http://skia.googlecode.com/svn/trunk@14512 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:29:46 +0000 (19:29 +0000)]

gyp rules for ubsan

BUG=skia:2481
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/258393004

git-svn-id: http://skia.googlecode.com/svn/trunk@14511 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:22:41 +0000 (19:22 +0000)]

rebaseline simpleblurroundrect

BUG=skia:
TBR=epoger

Author: humper@google.com

Review URL: https://codereview.chromium.org/269573007

git-svn-id: http://skia.googlecode.com/svn/trunk@14510 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:22:22 +0000 (19:22 +0000)]

Roll ANGLE.

BUG=skia:2272

Committed: http://code.google.com/p/skia/source/detail?r=14243

R=bsalomon@chromium.org, bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/237173002

git-svn-id: http://skia.googlecode.com/svn/trunk@14509 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:21:41 +0000 (19:21 +0000)]

Remove SkDEBUGFAILs that are problematic for Chromium

BUG=368107
R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/268683003

git-svn-id: http://skia.googlecode.com/svn/trunk@14508 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 19:21:33 +0000 (19:21 +0000)]

Move to a theme that more closely matches what was there before.

Also, since it's a variation of "default" we can drop a whole file.

BUG=skia:
R=mtklein@google.com, fmalita@chromium.org

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/265703005

git-svn-id: http://skia.googlecode.com/svn/trunk@14507 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 17:41:32 +0000 (17:41 +0000)]

DM: Push GPU-parent child tasks to the front of the queue.

Like yesterday's change to run CPU-parent child tasks serially in thread, this
reduces peak memory usage by improving the temporaly locality of the bitmaps we
create.

E.g. Let's say we start with tasks A B C and D
    Queue: [ A B C D ]
Running A creates A' and A", which depend on a bitmap created by A.
    Queue: [ B C D A' A" * ]
That bitmap now needs sit around in RAM while B C and D run pointlessly and can
only be destroyed at *.  If instead we do this and push dependent child tasks
to the front of the queue, the queue and bitmap lifetime looks like this:
    Queue: [ A' A" * B C D ]

This is much, much worse in practice because the queue is often several thousand
tasks long.  100s of megs of bitmaps can pile up for 10s of seconds pointlessly.

To make this work we add addNext() to SkThreadPool and its cousin DMTaskRunner.
I also took the opportunity to swap head and tail in the threadpool
implementation so it matches the comments and intuition better: we always pop
the head, add() puts it at the tail, addNext() at the head.

Before
  Debug:   49s, 1403352k peak
  Release: 16s, 2064008k peak

After
  Debug:   49s, 1234788k peak
  Release: 15s, 1903424k peak

BUG=skia:2478
R=bsalomon@google.com, borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/263803003

git-svn-id: http://skia.googlecode.com/svn/trunk@14506 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 16:30:30 +0000 (16:30 +0000)]

Whitespace change to test the Skia CQ

(SkipBuildbotRuns)

BUG=skia:
R=fmalita@chromium.org

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/269543006

git-svn-id: http://skia.googlecode.com/svn/trunk@14505 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 1 May 2014 15:56:52 +0000 (15:56 +0000)]

remove code behind SK_SUPPORT_LEGACY_PROCXFERMODE

BUG=skia:
R=scroggo@google.com

Review URL: https://codereview.chromium.org/264923004

git-svn-id: http://skia.googlecode.com/svn/trunk@14504 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 15:34:28 +0000 (15:34 +0000)]

Improve Android gdbserver and gdb_ex scripts
- Don't complain if $GDB_TMP_DIR already exists
- Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file.

NOTRY=true
R=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/266453006

git-svn-id: http://skia.googlecode.com/svn/trunk@14503 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 15:30:52 +0000 (15:30 +0000)]

reduce total number of segments in giant-dash

still exercises large coordinates, but won't kill our memory usage on 32bit bots

NOTRY=True
R=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/262733007

git-svn-id: http://skia.googlecode.com/svn/trunk@14502 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 15:24:55 +0000 (15:24 +0000)]

expose ConvertRadiusToSigma to aid clients in the API transition to sigma

NOTRY=True
R=robertphillips@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/264923002

git-svn-id: http://skia.googlecode.com/svn/trunk@14501 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 15:18:06 +0000 (15:18 +0000)]

Revert of re-enable simpleblurroundrect gm (https://codereview.chromium.org/263823002/)

Reason for revert:
broken rebaseline.

Original issue's description:
> re-enable simpleblurroundrect gm
>
> BUG=skia:
> TBR=caryclark
>
> Committed: http://code.google.com/p/skia/source/detail?r=14498

R=caryclark@google.com
TBR=caryclark@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: humper@google.com

Review URL: https://codereview.chromium.org/265863002

git-svn-id: http://skia.googlecode.com/svn/trunk@14500 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Thu, 1 May 2014 15:14:56 +0000 (15:14 +0000)]

Use CodeMirror for WebTry snippets.

CodeMirror (http://codemirror.net) is a rich code editor. This CL
adds the needed library and wires it with some minimal features, to
update the editor appearance to something like this:
http://codemirror.net/demo/theme.html?ambiance

We can later add Skia-customized features (custom keyword highlighting,
code completion, etc.).

(only tested locally)

R=jcgregorio@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/261693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14499 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 14:38:45 +0000 (14:38 +0000)]

re-enable simpleblurroundrect gm

BUG=skia:
R=caryclark@google.com
TBR=caryclark

Author: humper@google.com

Review URL: https://codereview.chromium.org/263823002

git-svn-id: http://skia.googlecode.com/svn/trunk@14498 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 1 May 2014 14:03:41 +0000 (14:03 +0000)]

Add a fix for a spurious assert in SkMatrixConvolutionImageFilter.

When matrix convolution processes border pixels with zero width, it
asserts in getAddr32() with an invalid x coordinate. The assert is
harmless, since the returned pointer is never accessed (the next line
is a loop from left to right, which does nothing, since left == right).
However, the fix is simple: early out on an empty rect before entering
the outer loop.

R=sugoi@chromium.org

Review URL: https://codereview.chromium.org/265693005

git-svn-id: http://skia.googlecode.com/svn/trunk@14497 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Thu, 1 May 2014 13:32:21 +0000 (13:32 +0000)]

Add fmalita@chromium.org to CQ_COMMITTERS.

R=rmistry@google.com, reed@google.com

Review URL: https://codereview.chromium.org/267693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14496 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 12:56:19 +0000 (12:56 +0000)]

Support unknown Android target devices via environment variables.

This is useful for working with prototypes and uncommon devices.

NOTRY=true
R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/263673004

git-svn-id: http://skia.googlecode.com/svn/trunk@14495 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 12:54:25 +0000 (12:54 +0000)]

Display the color at a point.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/261533006

git-svn-id: http://skia.googlecode.com/svn/trunk@14494 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 1 May 2014 12:32:39 +0000 (12:32 +0000)]

Rename expectations for Valgrind bot: ATI5770->GTX550Ti

This will likely cause GM failures, since the GPU has changed.

BUG=skia:2506
R=caryclark@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/265773004

git-svn-id: http://skia.googlecode.com/svn/trunk@14493 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 1 May 2014 03:04:54 +0000 (03:04 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14492 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 23:29:02 +0000 (23:29 +0000)]

add default impl for context methods on shader

These are reasonable return values, since both of these methods can return a known value (0)
which means that no context can be created. This also makes it easier for chrome's subclasses
which already do not want to create a context, but having them actually overridden makes
changing the virtual signatures much harder.

BUG=skia:
R=scroggo@google.com, dominikg@google.com, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/262703002

git-svn-id: http://skia.googlecode.com/svn/trunk@14491 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 30 Apr 2014 21:46:38 +0000 (21:46 +0000)]

Rebaseline tileimagefilter on IntelRhb post-r14432.

TBR=caryclark@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/267573004

git-svn-id: http://skia.googlecode.com/svn/trunk@14490 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 21:34:14 +0000 (21:34 +0000)]

remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/267573003

git-svn-id: http://skia.googlecode.com/svn/trunk@14489 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 21:32:37 +0000 (21:32 +0000)]

rebaseline_server: ignore builders we don't have any expectations for

(SkipBuildbotRuns)
BUG=skia:2486
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/269543002

git-svn-id: http://skia.googlecode.com/svn/trunk@14488 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 21:10:13 +0000 (21:10 +0000)]

one valgrind.supp to rule them all.

R=mtklein@google.com, robertphillips@google.com, borenet@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/268473004

git-svn-id: http://skia.googlecode.com/svn/trunk@14487 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 20:47:30 +0000 (20:47 +0000)]

DM: run child tasks that are already on the CPU threadpool serially

These tasks tend to do similar things with similar sized bitmaps, so running
them serially means we tend to hold 2x bitmaps at a time (golden and
comparison) instead of (1+k)x bitmaps (golden and k concurrent comparisons).

We still migrate GPU task's children over to the main CPU thread pool,
because they'll run faster there and free up capacity on the GPU thread.

Before
  Debug: 54s, 2.9G peak
  Release: 13s, 2.4G peak

After
  Debug: 48s, 1.5G peak
  Release: 15s, 2.0G peak

BUG=skia:2478
R=borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/261593008

git-svn-id: http://skia.googlecode.com/svn/trunk@14486 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 20:47:22 +0000 (20:47 +0000)]

try /LARGEADDRESSAWARE to give Windows 32-bit builds access to more RAM.

BUG=skia:2478
R=borenet@google.com, robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/258403006

git-svn-id: http://skia.googlecode.com/svn/trunk@14485 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 19:55:51 +0000 (19:55 +0000)]

make gitignore happy with symlinks

See https://codereview.chromium.org/139473002 for similar CL.

R=djsollen@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/267543002

git-svn-id: http://skia.googlecode.com/svn/trunk@14484 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 19:38:51 +0000 (19:38 +0000)]

Set ulimits for the compile stage.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/265453010

git-svn-id: http://skia.googlecode.com/svn/trunk@14483 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 19:20:42 +0000 (19:20 +0000)]

Add Valgrind suppressions for nvidia driver.

Did we recently switch the machine Valgrind runs on from an ati card to
an nvidia one?

BUG=skia:
R=bsalomon@google.com, borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/266473010

git-svn-id: http://skia.googlecode.com/svn/trunk@14482 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 18:24:16 +0000 (18:24 +0000)]

Rename SK_DEBUGBREAK to SK_ALWAYSBREAK

Committed: http://code.google.com/p/skia/source/detail?r=14473

R=caryclark@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/263553012

git-svn-id: http://skia.googlecode.com/svn/trunk@14481 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:54:00 +0000 (16:54 +0000)]

Fix bug with starting at the home page.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/260773002

git-svn-id: http://skia.googlecode.com/svn/trunk@14480 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:51:51 +0000 (16:51 +0000)]

Avoid undefined behavior and enable asserts in ClampTest.

The old code here wasn't being careful to avoid int32_t overflow in slow_check. Fix that.

R_ASSERT hasn't been doing anything for a while. As a result, there are a couple bugs in SkClampRange, marked as such and commented out. The asserts also weren't quite passing, so I fixed them up (allowing 0xFFFF to be considered either as part of the ramp or part of V1.)

BUG=skia:2481
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/260523004

git-svn-id: http://skia.googlecode.com/svn/trunk@14479 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:49:34 +0000 (16:49 +0000)]

Turn off warnings as errors, also allow c++11 extensions.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/262603005

git-svn-id: http://skia.googlecode.com/svn/trunk@14478 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:34:43 +0000 (16:34 +0000)]

remove inverse_paths from ignored tests

new expectations have been checked in

https://codereview.chromium.org/264653003

R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/265453009

git-svn-id: http://skia.googlecode.com/svn/trunk@14477 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:27:21 +0000 (16:27 +0000)]

Revert of Rename SK_DEBUGBREAK to SK_ALWAYSBREAK (https://codereview.chromium.org/263553012/)

Reason for revert:
Broke windows bot

Original issue's description:
> Rename SK_DEBUGBREAK to SK_ALWAYSBREAK
>
> Committed: http://code.google.com/p/skia/source/detail?r=14473

R=caryclark@google.com, reed@google.com
TBR=caryclark@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/260763003

git-svn-id: http://skia.googlecode.com/svn/trunk@14476 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:15:49 +0000 (16:15 +0000)]

unsuppress inverse_paths gm images

R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/264653003

git-svn-id: http://skia.googlecode.com/svn/trunk@14475 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:14:10 +0000 (16:14 +0000)]

Set TCP keepalive for MySQL connections.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/268473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14474 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 16:14:04 +0000 (16:14 +0000)]

Rename SK_DEBUGBREAK to SK_ALWAYSBREAK

R=caryclark@google.com, reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/263553012

git-svn-id: http://skia.googlecode.com/svn/trunk@14473 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 30 Apr 2014 16:11:50 +0000 (16:11 +0000)]

Update the list of bots in rebaseline.py.

This script was not updated for the new Ubuntu bots. Also, it was
attempting to rebaseline some bots for which we don't keep results
(NVPR, ASAN).

R=borenet@google.com, borenet

Review URL: https://codereview.chromium.org/267483002

git-svn-id: http://skia.googlecode.com/svn/trunk@14472 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 15:55:14 +0000 (15:55 +0000)]

Eliminate SkPicture-related flags Chromium no longer requires

This was originally reverted in r14349 (Restore SkPicture-related guard flags for Chrome - https://codereview.chromium.org/255543004/) due to Android WebView compile failures. These failures should be fixed in Chromium r267210 (Fixing Chromium Android build's reliance on old SkPicture recording API - https://codereview.chromium.org/251843005/)

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/254333003

git-svn-id: http://skia.googlecode.com/svn/trunk@14471 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 15:54:29 +0000 (15:54 +0000)]

Use SkDebugf to print when GrContext can't be created for a config.

Also, don't label it an "Error". New output matches that of GM.

BUG=skia:2494
R=caryclark@google.com, bensong@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/264563008

git-svn-id: http://skia.googlecode.com/svn/trunk@14470 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 15:29:53 +0000 (15:29 +0000)]

refresh expectations for android intel conical gradients

TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/260513005

git-svn-id: http://skia.googlecode.com/svn/trunk@14469 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 15:22:47 +0000 (15:22 +0000)]

un-ignore image-surface GM results

NOTRY=True
TBR=reed@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/264623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14468 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 30 Apr 2014 15:18:53 +0000 (15:18 +0000)]

New Ubuntu baselines for tileimagefilter GM post-r14432.

TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/254323003

git-svn-id: http://skia.googlecode.com/svn/trunk@14467 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 15:17:01 +0000 (15:17 +0000)]

rebaseline but with known incorrectness

BUG=skia:2497
NOTRY=True
TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/266473006

git-svn-id: http://skia.googlecode.com/svn/trunk@14466 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 14:59:38 +0000 (14:59 +0000)]

rebaseline GM changes to image-surface

NOTRY=True
TBR=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/254283003

git-svn-id: http://skia.googlecode.com/svn/trunk@14465 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 14:58:46 +0000 (14:58 +0000)]

Cleanup of SSE optimization files.

General cleanup of optimization files for x86/SSEx.
Renamed the opts_check_SSE2.cpp file to _x86, since it's not specific
to SSE2. Commented out the ColorRect32 optimization, since it's
disabled anyway, to make it more visible.
Also fixed a lot of indentation, inclusion guards, spelling,
copyright headers, braces, whitespace, and sorting of includes.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/264603002

git-svn-id: http://skia.googlecode.com/svn/trunk@14464 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 14:56:29 +0000 (14:56 +0000)]

DM: when 32-bit, disable pathops internal threading by default

Before this change, when limited to 4G, pathops threaded tests were the weak
link RAM-consumption-wise (in thread-local font caches) up until about 12
cores, where other problems begin to pile up too.

Tested by running:
ulimit -Sv 4194304
out/Debug/dm --threads N [--pathOpsSingleThread]

After this, we're _probably_ good to go on 32-bit machines with 8 cores.

BUG=skia:2478
R=borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/265593003

git-svn-id: http://skia.googlecode.com/svn/trunk@14463 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 30 Apr 2014 14:35:57 +0000 (14:35 +0000)]

New baselines for tileimagefilter GM after r14432.

TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/260753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14462 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 14:33:04 +0000 (14:33 +0000)]

remove rebaselined tests from ignore file

this removes the lines corresponding to this rebaseline CL

Change committed as 14447

https://codereview.chromium.org/263473002/

R=reed@android.com
TBR=reed
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/262583005

git-svn-id: http://skia.googlecode.com/svn/trunk@14461 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 14:17:00 +0000 (14:17 +0000)]

Convert GrCrash->SkFAIL GrDebugCrash->SkDEBUGFAIL

R=robertphillips@google.com, reed@google.com, mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/257393004

git-svn-id: http://skia.googlecode.com/svn/trunk@14460 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Wed, 30 Apr 2014 14:11:29 +0000 (14:11 +0000)]

Rebaselines post-r14433.

Update testimagefilters GM on SGX540 GPU and matrixconvolution GM on
Win7 (perspective).

TBR=caryclark@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/261533004

git-svn-id: http://skia.googlecode.com/svn/trunk@14459 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 13:37:48 +0000 (13:37 +0000)]

fix cubic/line intersection; add skp tests

BUG=skia:2488
TBR=reed

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/252243003

git-svn-id: http://skia.googlecode.com/svn/trunk@14458 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 13:20:45 +0000 (13:20 +0000)]

Turn on quilt mode in DM.
  - Rename TileGrid -> Quilt to avoid the name overload.
  - Tag all failing GMs with kSkipTiled_Flag.

You may be wondering, do any GMs pass?  Yes, some do!  And that trends towards all of them as we increase --quiltTile.

Two GMs only fail in --quilt mode in 565.  Otherwise all GMs which fail are skipped, and those which don't fail aren't. (The 8888 variants of those two GMs are skipped even though they pass.)

BUG=skia:2477
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/256373002

git-svn-id: http://skia.googlecode.com/svn/trunk@14457 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 13:19:28 +0000 (13:19 +0000)]

Remove the unused SkCachePreload_arm

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/263553008

git-svn-id: http://skia.googlecode.com/svn/trunk@14456 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 13:18:12 +0000 (13:18 +0000)]

Backfill unit tests for SkRecord

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/251133008

git-svn-id: http://skia.googlecode.com/svn/trunk@14455 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 12:56:40 +0000 (12:56 +0000)]

bench rebase after eeaeafe
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/260713003

git-svn-id: http://skia.googlecode.com/svn/trunk@14454 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 30 Apr 2014 03:05:25 +0000 (03:05 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14453 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 01:26:04 +0000 (01:26 +0000)]

Fail to create GrContext when we get a NULL for a GL/GLSL version string

BUG=368107
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/254083002

git-svn-id: http://skia.googlecode.com/svn/trunk@14452 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 30 Apr 2014 00:46:29 +0000 (00:46 +0000)]

Increase picture bench inner loop iteration to 10 for testing number stableness.

BUG=skia:2473
NOTRY=true
R=caryclark@google.com
TBR=caryclark@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/254093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14451 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;