profile/ivi/webkit-efl.git
13 years agoAdd logic to collect dirty objects as roots
oliver@apple.com [Thu, 29 Sep 2011 22:52:45 +0000 (22:52 +0000)]
Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100

Reviewed by Geoff Garen.

This gives us the ability to walk all the MarkedBlocks in an
AllocationSpace and collect the dirty objects, and then use
them as GC roots.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* heap/AllocationSpace.cpp:
   Tidy up the write barrier logic a bit
(JSC::MarkedBlock::gatherDirtyObjects):
(JSC::TakeIfDirty::returnValue):
(JSC::TakeIfDirty::TakeIfDirty):
(JSC::TakeIfDirty::operator()):
(JSC::AllocationSpace::gatherDirtyObjects):
* heap/AllocationSpace.h:
* heap/CardSet.h:
(JSC::::isCardMarked):
(JSC::::clearCard):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC::Heap::writeBarrier):
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
* heap/SlotVisitor.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
   Tidy the write barrier a bit

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to make this tool work on Windows.
abarth@webkit.org [Thu, 29 Sep 2011 22:25:48 +0000 (22:25 +0000)]
Attempt to make this tool work on Windows.

* Scripts/run-api-tests:
(buildTestTool):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEnable LCD text in Skia on Mac
caryclark@google.com [Thu, 29 Sep 2011 22:21:00 +0000 (22:21 +0000)]
Enable LCD text in Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=68734

Reviewed by Stephen White.

No new tests. Existing layout tests are generated
with LCD text disabled for pixel comparisons.

Duplicate the logic in FontMac.mm to pass settings
for antialiasing and smoothing. Also disable smoothing
for DumpRenderTree.

* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Implement flick gesture in Chromium Gesture Recognizer
commit-queue@webkit.org [Thu, 29 Sep 2011 22:16:56 +0000 (22:16 +0000)]
 Implement flick gesture in Chromium Gesture Recognizer
 https://bugs.webkit.org/show_bug.cgi?id=67930

 Reviewed by Dimitri Glazkov.

 Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp

 * platform/chromium/GestureRecognizerChromium.cpp:
 (WebCore::GestureRecognizerChromium::isOverMinFlickSpeed):
 (WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
 (WebCore::GestureRecognizerChromium::updateValues):
 (WebCore::GestureRecognizerChromium::scrollEnd):
 * platform/chromium/GestureRecognizerChromium.h:

Patch by Varun Jain <varunjain@google.com> on 2011-09-29

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium] canvas.toDataURL("image/jpeg"): use libjpeg-turbo data swizzle
noel.gordon@gmail.com [Thu, 29 Sep 2011 22:14:42 +0000 (22:14 +0000)]
[chromium] canvas.toDataURL("image/jpeg"): use libjpeg-turbo data swizzle
https://bugs.webkit.org/show_bug.cgi?id=67402

Reviewed by Kenneth Russell.

libjpeg-turbo can read directly from the input data for the premultiplied BRGX
(SkBitmap) encoding case.

No change in behavior, covered by existing canvas 2d/3d tests
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::encodePixels): If JCS_EXTENSIONS is defined (libjpeg-turbo), swizzle
the input BRGX pixels directly within libjpeg-turbo.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed windows build fix.
barraclough@apple.com [Thu, 29 Sep 2011 22:13:37 +0000 (22:13 +0000)]
Unreviewed windows build fix.

* assembler/MacroAssemblerCodeRef.h:
* dfg/DFGOperations.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[EFL] API to get plain text of the frame
commit-queue@webkit.org [Thu, 29 Sep 2011 22:02:37 +0000 (22:02 +0000)]
[EFL] API to get plain text of the frame
https://bugs.webkit.org/show_bug.cgi?id=67114

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-29
Reviewed by Ryosuke Niwa.

Add a function to return a frame's contents converted to plain text,
as already exposed by other ports and needed by DRT when dumping a
frame's contents.

* ewk/ewk_frame.cpp:
(ewk_frame_plain_text_get):
* ewk/ewk_frame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThis test can also time out.
abarth@webkit.org [Thu, 29 Sep 2011 21:58:53 +0000 (21:58 +0000)]
This test can also time out.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Try to fix the minial build
vestbo@webkit.org [Thu, 29 Sep 2011 21:29:11 +0000 (21:29 +0000)]
[Qt] Try to fix the minial build

* QtTestBrowser/launcherwindow.cpp:
* QtTestBrowser/webpage.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDelete bogus expectation.
abarth@webkit.org [Thu, 29 Sep 2011 21:15:56 +0000 (21:15 +0000)]
Delete bogus expectation.

* platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAttempt to update these image results again.
abarth@webkit.org [Thu, 29 Sep 2011 21:12:10 +0000 (21:12 +0000)]
Attempt to update these image results again.

* platform/chromium-cg-mac-leopard/http/tests/misc: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt:
* platform/chromium-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixenate the build.
abarth@webkit.org [Thu, 29 Sep 2011 21:07:11 +0000 (21:07 +0000)]
Fixenate the build.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMark test as expected to fail.
abarth@webkit.org [Thu, 29 Sep 2011 20:51:19 +0000 (20:51 +0000)]
Mark test as expected to fail.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt][WK2] Skip all failing tests (10605!) after refactored Qt5.
ossy@webkit.org [Thu, 29 Sep 2011 20:50:20 +0000 (20:50 +0000)]
[Qt][WK2] Skip all failing tests (10605!) after refactored Qt5.

Rubber-stamped by Tor Arne Vestbø.

* platform/qt-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoStructure transitions involving many (> 64) properties sometimes cause structure...
fpizlo@apple.com [Thu, 29 Sep 2011 20:45:52 +0000 (20:45 +0000)]
Structure transitions involving many (> 64) properties sometimes cause structure corruption
https://bugs.webkit.org/show_bug.cgi?id=69102

Reviewed by Darin Adler.

Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
don't lead to the dictionary kind being forgotten.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelection...
rniwa@webkit.org [Thu, 29 Sep 2011 20:31:41 +0000 (20:31 +0000)]
Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=69023

Reviewed by Enrica Casucci.

Converted to removeUnrenderedTextNodesAtEnds to use InsertedNodes instead of m_firstNodeInserted
and m_lastLeafInserted. Extracted the logic to update nodes as InsertedNodes::willRemoveNode
(old one was renamed to InsertedNodes::willRemoveNodePreservingChildren).

Also extracted shouldPerformSmartReplace and addSpacesForSmartReplace out of doApply,
and rewrote the logic to obtain endNode and startNode using startOfInsertedContent and
endOfInsertedContent instead of m_firstNodeInserted and m_lastLeafInserted.

Finally, replaced the nullity checks of m_firstNodeInserted and m_lastLeafInserted in
completeHTMLReplacement by nullity checks of start and end positions.

* dom/Node.cpp:
(WebCore::Node::traversePreviousSibling): Added.
* dom/Node.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren): Renamed from
willRemoveNode.
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode): Extracted from
removeUnrenderedTextNodesAtEnds.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Takes firstNodeInserted instead of directly
accessing m_firstNodeInserted.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
* editing/ReplaceSelectionCommand.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoShrink HTMLAnchorElement on 32-bit.
commit-queue@webkit.org [Thu, 29 Sep 2011 20:30:17 +0000 (20:30 +0000)]
Shrink HTMLAnchorElement on 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69094

Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.

* html/HTMLAnchorElement.h: Pack members into a bitfield.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/10191243> Glyph variants (line final swashes) appear where they shoul...
mitz@apple.com [Thu, 29 Sep 2011 20:21:02 +0000 (20:21 +0000)]
<rdar://problem/10191243> Glyph variants (line final swashes) appear where they should not

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/text/line-initial-and-final-swashes.html

Hoefler Text Italic enables line-initial and -final swashes by default, so disable them. This
change targets only this known-bad font rather than all fonts, because at least one font (Khmer MN)
incorrectly claims to have the line-initial feature enabled, but disabling it actually does
something different and bad (breaking some combining marks).

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::createFeatureSettingDictionary): Added this helper function.
(WebCore::cascadeToLastResortFontDescriptor): Deployed WTF_ARRAY_LENGTH().
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor): Added. Returns a font descriptor
that, in addition to having a cascade list consisting of the last resort font, also has feature
settings to disable line-initial and line-final swashes.
(WebCore::FontPlatformData::ctFont): For Hoefler Text Italic, use cascadeToLastResortAndDisableSwashesFontDescriptor().

LayoutTests:

* fast/text/line-initial-and-final-swashes.html: Added.
* platform/mac/fast/text/line-initial-and-final-swashes-expected.png: Added.
* platform/mac/fast/text/line-initial-and-final-swashes-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed: resetting baseline for code generator bindings
mhahnenberg@apple.com [Thu, 29 Sep 2011 20:14:44 +0000 (20:14 +0000)]
Unreviewed: resetting baseline for code generator bindings

Unreviewed build fix

No new tests.

* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[V8, chromium] More logging to determine cause of a null
japhet@chromium.org [Thu, 29 Sep 2011 19:46:01 +0000 (19:46 +0000)]
[V8, chromium] More logging to determine cause of a null
v8::Context in V8DOMWindowShell::namedItemAdded().

https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agohttps://bugs.webkit.org/show_bug.cgi?id=69040
ap@apple.com [Thu, 29 Sep 2011 19:40:34 +0000 (19:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69040
ScrollbarThemeComposite requires a ScrollView to draw scroll corner

Reviewed by Simon Fraser.

No new tests. This will be needed later.

* platform/ScrollbarThemeComposite.cpp:
(WebCore::pageForScrollView):
(WebCore::ScrollbarThemeComposite::paintScrollCorner):
Use pageForScrollView() function which already existed in this file, used in another similar
location.

* platform/chromium/FramelessScrollView.cpp:
* platform/chromium/FramelessScrollView.h:
* platform/gtk/ScrollbarThemeGtk.cpp:
* platform/gtk/ScrollbarThemeGtk.h:
* platform/wx/ScrollbarThemeWx.cpp:
* platform/wx/ScrollbarThemeWx.h:
All these overrides are no longer needed, ScrollbarThemeComposite will do the right thing.

* platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
Removed a special case for updatingControlTints phase. The same case is present in cross-platform
code now, and Qt doesn't have any custom subclasses of ScrollableArea or ScrollView to need
special handling.
This was added in r37377 without a bug or much ChangeLog explanation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
barraclough@apple.com [Thu, 29 Sep 2011 19:37:53 +0000 (19:37 +0000)]
DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux

* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDe-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual...
mhahnenberg@apple.com [Thu, 29 Sep 2011 19:37:09 +0000 (19:37 +0000)]
De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=68839

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed the remaining visitChildrenVirtual methods.  This patch completes the process of
de-virtualizing visitChildren.

* API/JSCallbackObject.h:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/Executable.cpp:
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
* runtime/GetterSetter.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
* runtime/JSPropertyNameIterator.cpp:
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSValue.h:
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/Structure.cpp:
* runtime/Structure.h:
* runtime/StructureChain.cpp:
* runtime/StructureChain.h:

Inlined the method table access and call to the visitChildren function (the only call sites
to visitChildren are here).
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):

Changed the field name for the visitChildren function pointer to visitChildren (from
visitChildrenFunctionPtr) to make call sites less verbose.
* runtime/ClassInfo.h:

Discovered JSBoundFunction doesn't have its own ClassInfo (it used JSFunction's ClassInfo) but
overrides visitChildren, so it needs to have its own ClassInfo.
* runtime/JSBoundFunction.cpp:
* runtime/JSBoundFunction.h:

Had to move className up to make sure that the virtual destructor in JSObject wasn't
the first non-inline virtual method in JSObject (as per the comment in the file).
Also moved JSCell::visitChildrenVirtual into JSObject.h in order for it be inline-able
to mitigate the cost of an extra method call.

Also added a convenience accessor function methodTable() to JSCell to return the MethodTable to make
call sites more concise.  Implementation is inline in JSObject.h.
* runtime/JSObject.h:
(JSC::JSCell::methodTable):
* runtime/JSCell.h:

Added an out of line virtual destructor to JSWrapperObject and ScopeChainNode to
appease the vtable gods.  It refused to compile if there were no virtual methods in
both of these classes due to the presence of a weak vtable pointer.
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::~JSWrapperObject):
* runtime/JSWrapperObject.h:
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::~ScopeChainNode):
* runtime/ScopeChain.h:

Source/JavaScriptGlue:

Removed the remaining visitChildrenVirtual methods.  This patch completes the process of
de-virtualizing visitChildren.

* UserObjectImp.cpp:
* UserObjectImp.h:

Source/WebCore:

No new tests.

Removed the remaining visitChildrenVirtual methods.  This patch completes the process of
de-virtualizing visitChildren.

* WebCore.exp.in:
* bindings/js/JSAttrCustom.cpp:
* bindings/js/JSAudioContextCustom.cpp:
* bindings/js/JSCSSRuleCustom.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCanvasRenderingContextCustom.cpp:
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::~JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::finishCreation):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
* bindings/js/JSMessageChannelCustom.cpp:
* bindings/js/JSMessagePortCustom.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/JSNodeFilterCustom.cpp:
* bindings/js/JSNodeIteratorCustom.cpp:
* bindings/js/JSSVGElementInstanceCustom.cpp:
* bindings/js/JSSharedWorkerCustom.cpp:
* bindings/js/JSStyleSheetCustom.cpp:
* bindings/js/JSTreeWalkerCustom.cpp:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
* bindings/js/JSWorkerContextCustom.cpp:
* bindings/js/JSXMLHttpRequestCustom.cpp:
* bindings/js/JSXPathResultCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
vestbo@webkit.org [Thu, 29 Sep 2011 19:31:59 +0000 (19:31 +0000)]
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi

QWidget and friends now live in the QtWidgets library. We update
includes in implementation files and private headers to us the
non-module-prefixed path, and leave the lookup for the include
path. For public headers we have to ifdef the includes as the
user might now have the modules we need in his QT config.

Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
have to update our code and use windowHandle() for setting the
parent relationships.

https://bugs.webkit.org/show_bug.cgi?id=68687

Reviewed by Andreas Kling.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
commit-queue@webkit.org [Thu, 29 Sep 2011 19:07:41 +0000 (19:07 +0000)]
Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69075

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed, rolling out r96340.
abarth@webkit.org [Thu, 29 Sep 2011 19:03:40 +0000 (19:03 +0000)]
Unreviewed, rolling out r96340.
http://trac.webkit.org/changeset/96340
https://bugs.webkit.org/show_bug.cgi?id=69098

Caused 10 tests to crash in Debug (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-29

Source/WebCore:

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/AccessibilityRenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):

LayoutTests:

* platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
* platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoShrink FontFallbackList.
commit-queue@webkit.org [Thu, 29 Sep 2011 18:04:21 +0000 (18:04 +0000)]
Shrink FontFallbackList.
https://bugs.webkit.org/show_bug.cgi?id=69093

Patch by Andreas Kling <kling@webkit.org> on 2011-09-29
Reviewed by Antti Koivisto.

Reduce the size of FontFallbackList by one CPU word, decreasing memory
consumption by 300 kB (on 64-bit) when loading the full HTML5 spec.

* platform/graphics/FontCache.h:
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::generation):

    Store the FontCache generation as an ushort rather than uint.

* platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
* platform/graphics/FontFallbackList.h:

    Pack enum and bool members in a bitfield.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWe should ignore the return value of GetRealNamedProperty
abarth@webkit.org [Thu, 29 Sep 2011 17:50:47 +0000 (17:50 +0000)]
We should ignore the return value of GetRealNamedProperty
https://bugs.webkit.org/show_bug.cgi?id=68840

Reviewed by Nate Chapin.

Source/WebCore:

Instead of skipping the lookup process by using the result of real
named property, we should just indiciate that it wasn't handled by the
interceptor.

Test: http/tests/security/window-named-valueOf.html

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):

LayoutTests:

* http/tests/security/window-named-valueOf-expected.txt: Added.
* http/tests/security/window-named-valueOf.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoARIA live regions don't trigger notifications for elements that aren't in the AX...
cfleizach@apple.com [Thu, 29 Sep 2011 17:46:14 +0000 (17:46 +0000)]
ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289

Source/WebCore:

If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned
that it's generally not safe to create objects.

Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-liveregion-without-element-access.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/AccessibilityRenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):

LayoutTests:

Reviewed by Darin Adler.

* platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
* platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Dragging a selection does not produce a drag image
commit-queue@webkit.org [Thu, 29 Sep 2011 17:35:41 +0000 (17:35 +0000)]
[GTK] Dragging a selection does not produce a drag image
https://bugs.webkit.org/show_bug.cgi?id=69064

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-09-29
Reviewed by Andreas Kling.

Moved Chromium's generic implementation of Frame::nodeImage and
Frame::dragImageForSeletion to Frame.cpp and simply excluded via
#ifdefs platforms that do not have their own implementation. Removed
all empty implementations of these functions and Qt's which was
functionally identical.

No new tests. Drag-and-drop drag image functionality changes
are incredibly difficult to test in a non-manual way.

* CMakeListsEfl.txt: Delist FrameEfl.cpp.
* GNUmakefile.list.am: Delist FrameGtk.cpp.
* WebCore.gypi: Delist removed Frame*.cpp.
* WebCore.pro: Delist FrameQt.cpp.
* page/Frame.cpp: Moved FrameChromium implementation here.
(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* page/chromium/FrameChromium.cpp: Removed.
* page/efl/FrameEfl.cpp: Removed.
* page/gtk/FrameGtk.cpp: Removed.
* page/qt/FrameQt.cpp: Removed.
* page/wx/FrameWx.cpp: Removed.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::createDragImage): Call nodeImage to get
the drag image for a node.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[chromium skia] PNGImageEncoder: hoist constants out of the encoding loop
noel.gordon@gmail.com [Thu, 29 Sep 2011 17:16:35 +0000 (17:16 +0000)]
[chromium skia] PNGImageEncoder: hoist constants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=68988

Reviewed by Kenneth Russell.

No new tests.  Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.png.*.html
fast/canvas/toDataURL-alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

* platform/image-encoders/skia/PNGImageEncoder.cpp:
(WebCore::encodePixels):  Move constant out of the encoding loop.
(WebCore::PNGImageEncoder::encode):  Consistency & style: call encodePixels()
just like we do in the JPEG encoder.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd unit test for CCLayerSorter
commit-queue@webkit.org [Thu, 29 Sep 2011 17:05:41 +0000 (17:05 +0000)]
Add unit test for CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=68622

Source/WebCore:

Minor refactoring for testability:
- Made pointInTriangle public.
- Added LayerShape to decouple LayerIntersector and GraphNode.
- Added a public wrapper function for LayerIntersector.

Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::pointInTriangle):
(WebCore::CCLayerSorter::calculateZDiff):
(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
(WebCore::CCLayerSorter::LayerIntersector::go):
(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):
* platform/graphics/chromium/cc/CCLayerSorter.h:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):

Source/WebKit/chromium:

Patch by Iain Merrick <husky@google.com> on 2011-09-29
Reviewed by James Robinson.

* WebKit.gypi:
* tests/CCLayerSorterTest.cpp: Added.
(WebCore::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRebaseline for r95870
commit-queue@webkit.org [Thu, 29 Sep 2011 17:04:20 +0000 (17:04 +0000)]
Rebaseline for r95870
https://bugs.webkit.org/show_bug.cgi?id=69090

Patch by David Reveman <reveman@chromium.org> on 2011-09-29
Reviewed by James Robinson.

* platform/chromium-gpu-cg-mac/compositing/flat-with-transformed-child-expected.png: Removed.
* platform/chromium-gpu-cg-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png: Removed.
* platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
* platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Removed.
* platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Removed.
* platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.png: Added.
* platform/chromium-gpu-win/platform/chromium/compositing/3d-corners-expected.txt: Added.
* platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Removed.
* platform/chromium-gpu/compositing/flat-with-transformed-child-expected.png: Added.
* platform/chromium-gpu/platform/chromium/compositing/3d-corners-expected.png: Added.
* platform/chromium-gpu/platform/chromium/compositing/backface-visibility-transformed-expected.png: Renamed from LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png.
* platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
* platform/chromium-gpu/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayout test demonstrating IDBCursor inconsistency bug.
dgrogan@chromium.org [Thu, 29 Sep 2011 16:42:48 +0000 (16:42 +0000)]
Layout test demonstrating IDBCursor inconsistency bug.
https://bugs.webkit.org/show_bug.cgi?id=69012

Reviewed by Nate Chapin.

* storage/indexeddb/cursor-inconsistency-expected.txt: Added.
* storage/indexeddb/cursor-inconsistency.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoInitial implementation of WebInspector for WebKit2 GTK port.
commit-queue@webkit.org [Thu, 29 Sep 2011 16:32:49 +0000 (16:32 +0000)]
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-29
Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowConstructed): Set the developer extra flags to true to enable inspect element.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGeneralize expected result to all of MAC.
abarth@webkit.org [Thu, 29 Sep 2011 16:25:46 +0000 (16:25 +0000)]
Generalize expected result to all of MAC.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThis test can also time out.
abarth@webkit.org [Thu, 29 Sep 2011 16:24:05 +0000 (16:24 +0000)]
This test can also time out.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate expected results on Leopard. As far as I can tell, these are
abarth@webkit.org [Thu, 29 Sep 2011 16:20:12 +0000 (16:20 +0000)]
Update expected results on Leopard.  As far as I can tell, these are
progressions.

* platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd some expected failures on Leopard.
abarth@webkit.org [Thu, 29 Sep 2011 16:09:23 +0000 (16:09 +0000)]
Add some expected failures on Leopard.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnbreak the "update expectatations" button by using the existing
abarth@webkit.org [Thu, 29 Sep 2011 15:46:55 +0000 (15:46 +0000)]
Unbreak the "update expectatations" button by using the existing
machinery to create the failureInfo objects.

Unbreak the "close" button on the progress dialog by using |this|
instead of the old name of the object.

Teach the controllers unit test not to talk to the actual network.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate baselines. (Font rendering.)
abarth@webkit.org [Thu, 29 Sep 2011 15:34:40 +0000 (15:34 +0000)]
Update baselines.  (Font rendering.)

* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Added.
* platform/chromium-mac/http/tests/misc/acid3-expected.png: Added.
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate baselines.
abarth@webkit.org [Thu, 29 Sep 2011 15:32:02 +0000 (15:32 +0000)]
Update baselines.

* platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.
* platform/chromium-cg-mac/svg/text/selection-background-color-expected.png: Added.
* platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Added.
* platform/chromium-mac-leopard/svg/text: Added.
* platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Added.
* platform/gtk/svg/text/selection-background-color-expected.txt: Removed.
* platform/mac/svg/text/selection-background-color-expected.txt: Removed.
* svg/text/selection-background-color-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: UI performance test for network panel is incorrect. The time is includ...
loislo@chromium.org [Thu, 29 Sep 2011 14:30:38 +0000 (14:30 +0000)]
Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.
https://bugs.webkit.org/show_bug.cgi?id=69087

The fix has the changes for the test and minor perf framework improvements.

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._defaultRefreshDelay.500._scheduleRefresh):

LayoutTests:

* inspector/performance/resources/network-append-30-requests.html:
* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Bump version to 1.7.0
sergio@webkit.org [Thu, 29 Sep 2011 13:59:23 +0000 (13:59 +0000)]
[GTK] Bump version to 1.7.0
https://bugs.webkit.org/show_bug.cgi?id=69082

Reviewed by Martin Robinson.

Apart from bumping the library version to 1.7.0 this patch also
sets the libtool version to the same one we have for the stable
branch.

* configure.ac:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Force single header include in WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 29 Sep 2011 13:53:53 +0000 (13:53 +0000)]
[GTK] Force single header include in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69084

Reviewed by Martin Robinson.

Only <webkit2/webkit2.h> will be allowed for API users.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitError.h:
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/WebKitWebLoaderClient.h:
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/API/gtk/webkit2.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: Make search-in-resource test simpler.
vsevik@chromium.org [Thu, 29 Sep 2011 12:59:17 +0000 (12:59 +0000)]
Web Inspector: Make search-in-resource test simpler.
https://bugs.webkit.org/show_bug.cgi?id=69025

Source/WebCore:

Changed search-in-resource test.
Removed error parameter from content provider's searchInContent callback.

Reviewed by Pavel Feldman.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector/search/search-in-resource-expected.txt:
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-resources.html:
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoIndexedDB: Use LevelDB also for in-memory databases
hans@chromium.org [Thu, 29 Sep 2011 12:29:13 +0000 (12:29 +0000)]
IndexedDB: Use LevelDB also for in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=68903

Reviewed by Steve Block.

Source/WebCore:

Add LevelDBDatabase::openInMemory() which uses leveldb::NewMemEnv()
to create in-memory LevelDB databases.

Use this in IDBLeveLDBBackingStore::open() when the caller passes in
an empty file path.
This happens in Chromium's incognito mode, and when running layout
tests.

Fix IDBSQLiteBackingStore::backingStoreExists() so it doesn't create
files when passed in an empty file path, but uses the in-memory mode
instead.

Existing layout tests will all be run in-memory.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::~LevelDBDatabase):
(WebCore::openDB):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):
* platform/leveldb/LevelDBDatabase.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::backingStoreExists):

Source/WebKit/chromium:

Don't fall back to SQLite or use a temporary dir for in-memory
databases (Incognito and layout tests); LevelDB supports in-memory
databases now.

* public/WebIDBFactory.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

Tools:

Remove the temporary dir that was necessary before LevelDB supported
in-memory databases.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: speed-up Network panel. Change _staleResources type from array to...
loislo@chromium.org [Thu, 29 Sep 2011 11:59:27 +0000 (11:59 +0000)]
Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
https://bugs.webkit.org/show_bug.cgi?id=69081

There is a test with 30 requests.
For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.

Reviewed by Pavel Feldman.

Test: inspector/performance/resources/network-append-30-requests.html

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype._refreshResource):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: make inspector protocol validation a part of the build process.
pfeldman@chromium.org [Thu, 29 Sep 2011 11:49:53 +0000 (11:49 +0000)]
Web Inspector: make inspector protocol validation a part of the build process.
https://bugs.webkit.org/show_bug.cgi?id=68999

Since we'd like to commit to inspector protocol backwards compatibility, violating it
should be a build failure.

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/Inspector.draft-01.json:
* inspector/Inspector.json:
* inspector/generate-inspector-idl:
* inspector/generate-protocol-externs:
* inspector/validate-protocol-compatibility:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: Scripts panel without folders causes errors when creating content...
pfeldman@chromium.org [Thu, 29 Sep 2011 11:39:11 +0000 (11:39 +0000)]
Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

LayoutTests:

* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
* platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
* platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-09-28 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 29 Sep 2011 11:06:15 +0000 (11:06 +0000)]
2011-09-28  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: network log view refresh optimizations
        https://bugs.webkit.org/show_bug.cgi?id=69010

        Reviewed by Pavel Feldman.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkLogView.prototype.refresh):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Explicitly call destructors for objects initialized with placement new syntax
carlosgc@webkit.org [Thu, 29 Sep 2011 11:00:04 +0000 (11:00 +0000)]
[GTK] Explicitly call destructors for objects initialized with placement new syntax
https://bugs.webkit.org/show_bug.cgi?id=69079

Reviewed by Xan Lopez.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests: media/video-does-not-loop.html failing on Snow Leopard
commit-queue@webkit.org [Thu, 29 Sep 2011 10:33:03 +0000 (10:33 +0000)]
LayoutTests: media/video-does-not-loop.html failing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=69067

Patch by Arun Patole <bmf834@motorola.com> on 2011-09-29
Reviewed by Philippe Normand.

Update expected test result for video-does-not-loop.html
as the 'pause' event should be fired at the end of playback.

* media/video-does-not-loop-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] some Layout Tests in editing/ is failing
hamaji@chromium.org [Thu, 29 Sep 2011 10:30:20 +0000 (10:30 +0000)]
[Chromium] some Layout Tests in editing/ is failing
https://bugs.webkit.org/show_bug.cgi?id=69078

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-javascript-doc...
hamaji@chromium.org [Thu, 29 Sep 2011 10:07:33 +0000 (10:07 +0000)]
[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-javascript-doc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69077

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWeb Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProvi...
podivilov@chromium.org [Thu, 29 Sep 2011 08:44:57 +0000 (08:44 +0000)]
Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.
https://bugs.webkit.org/show_bug.cgi?id=69068

Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js.
(WebInspector.RawSourceCode): Moved from SourceFile.js.
(WebInspector.UILocation): Moved from SourceFile.js.
* inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Layout Test svg/filters/animate-fill.svg is failing
hamaji@chromium.org [Thu, 29 Sep 2011 08:36:04 +0000 (08:36 +0000)]
[Chromium] Layout Test svg/filters/animate-fill.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=69070

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GStreamer] 2 flaky media tests
philn@webkit.org [Thu, 29 Sep 2011 08:07:19 +0000 (08:07 +0000)]
[GStreamer] 2 flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=67407

Reviewed by Martin Robinson.

Workaround for GStreamer bug#639941. In GStreamer
0.10.35 basesink reports wrong duration in case of EOS and
negative playback rate. This workaround fixes two media tests,
media/video-timeupdate-reverse-play.html and
media/video-reverse-play-duration.html.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GStreamer] fullscreen video pause/play fails
philn@webkit.org [Thu, 29 Sep 2011 08:03:31 +0000 (08:03 +0000)]
[GStreamer] fullscreen video pause/play fails
https://bugs.webkit.org/show_bug.cgi?id=66936

Reviewed by Martin Robinson.

Don't use the identity element to avoid painting of the in-window
video. Instead simply make the sink aware of the fullscreen state
and ignore buffers if fullscreen and autovideosink are
active. Also fixed two deadlocks happening when a paused pipeline
is switched to fullscreen and when fullscreen is disabled for a
paused pipeline.

* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/GStreamerGWorld.h:
(WebCore::GStreamerGWorld::isFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_render):
(webkit_video_sink_new):
* platform/graphics/gstreamer/VideoSinkGStreamer.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded...
commit-queue@webkit.org [Thu, 29 Sep 2011 07:52:49 +0000 (07:52 +0000)]
JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Gavin Barraclough.

size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.

* dfg/DFGNode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHopefully the last Chromium test expectation update for r96294.
rniwa@webkit.org [Thu, 29 Sep 2011 07:33:46 +0000 (07:33 +0000)]
Hopefully the last Chromium test expectation update for r96294.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoREGRESSION(87010): elements in ECMA-cloud neither filled nor blurred
timothy_horton@apple.com [Thu, 29 Sep 2011 07:23:08 +0000 (07:23 +0000)]
REGRESSION(87010): elements in ECMA-cloud neither filled nor blurred
https://bugs.webkit.org/show_bug.cgi?id=68679
<rdar://problem/10204649>

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Strip prefixes from SVG attributes before testing if they're supported.
Namespaced attributes will be matched using their namespace instead of
the (user-choosable) prefix.

Test: svg/custom/xlink-custom-namespace.svg

* svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::isSupportedAttribute):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::isSupportedAttribute):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isSupportedAttribute):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
* svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
* svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::isSupportedAttribute):
* svg/SVGElement.h:
(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
* svg/SVGExternalResourcesRequired.h:
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::isSupportedAttribute):
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
* svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
* svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::isSupportedAttribute):
* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
* svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
* svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::isSupportedAttribute):
* svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::isSupportedAttribute):
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::isSupportedAttribute):
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::isSupportedAttribute):
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::isSupportedAttribute):
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
* svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::isSupportedAttribute):
* svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::isSupportedAttribute):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::isSupportedAttribute):
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::isSupportedAttribute):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::isSupportedAttribute):
* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::isSupportedAttribute):
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::isSupportedAttribute):
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::isSupportedAttribute):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::isSupportedAttribute):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isSupportedAttribute):
* svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::isSupportedAttribute):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::isSupportedAttribute):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isSupportedAttribute):
* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::isSupportedAttribute):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::isSupportedAttribute):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isSupportedAttribute):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::isSupportedAttribute):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::isSupportedAttribute):
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::isSupportedAttribute):
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::addSupportedAttributes):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::isSupportedAttribute):

LayoutTests:

Add a test ensuring that using xlink:href with a different prefix (i.e. xl:href)
works correctly.

* svg/custom/xlink-custom-namespace-expected.png: Added.
* svg/custom/xlink-custom-namespace-expected.txt: Added.
* svg/custom/xlink-custom-namespace.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDFG checkArgumentTypes fails to check boolean predictions
fpizlo@apple.com [Thu, 29 Sep 2011 07:12:10 +0000 (07:12 +0000)]
DFG checkArgumentTypes fails to check boolean predictions
https://bugs.webkit.org/show_bug.cgi?id=69059

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

LayoutTests:

* fast/js/boolean-argument-prediction-expected.txt: Added.
* fast/js/boolean-argument-prediction.html: Added.
* fast/js/script-tests/boolean-argument-prediction.js: Added.
(predictBooleanArgument):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium test_expectations update for isindex-with-no-form.html
hamaji@chromium.org [Thu, 29 Sep 2011 06:32:20 +0000 (06:32 +0000)]
Chromium test_expectations update for isindex-with-no-form.html

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
hamaji@chromium.org [Thu, 29 Sep 2011 06:27:59 +0000 (06:27 +0000)]
[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062

Chromium test_expectations update

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium rebaseline after r96294.
rniwa@webkit.org [Thu, 29 Sep 2011 06:24:19 +0000 (06:24 +0000)]
Chromium rebaseline after r96294.

* platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoYet another Chromium linux rebaseline after r96257.
rniwa@webkit.org [Thu, 29 Sep 2011 06:11:04 +0000 (06:11 +0000)]
Yet another Chromium linux rebaseline after r96257.

* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
haraken@chromium.org [Thu, 29 Sep 2011 06:07:17 +0000 (06:07 +0000)]
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
https://bugs.webkit.org/show_bug.cgi?id=68984

Reviewed by Darin Adler.

Just a follow-up fix for the bug 68345. For performance,
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&".

Tests: fast/events/constructors/pop-state-event-constructor.html
       fast/events/fire-popstate-event.html

* dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::initPopStateEvent):
* dom/PopStateEvent.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Unreviewed gardening after r96257.
ossy@webkit.org [Thu, 29 Sep 2011 06:03:12 +0000 (06:03 +0000)]
[Qt] Unreviewed gardening after r96257.

* platform/qt-4.8/editing/inserting/4278698-expected.png:
* platform/qt-4.8/editing/inserting/4278698-expected.txt:
* platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png:
* platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt:
* platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png:
* platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
mrobinson@webkit.org [Thu, 29 Sep 2011 06:02:57 +0000 (06:02 +0000)]
[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=66890

Source/WebCore:

Added a GtkDragAndDropHelper class to hold all the logic that is common
between WebKit1 and WebKit2. This will allow greater code sharing between
the two ports.

Reviewed by Philippe Normand.

No new tests. This patch should not change behavior.

* GNUmakefile.list.am: Added the GtkDragAndDropHelper to the sources list.
* platform/gtk/GtkDragAndDropHelper.cpp: Added.
* platform/gtk/GtkDragAndDropHelper.h: Added.

Source/WebKit/gtk:

Use the new GtkWidgetDragAndDropGlue class to hold the logic that will be
common between WebKit1 and WebKit2. Modify WebKitWebView to use this class.

Reviewed by Philippe Normand.

* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag): Inform the drag-and-drop glue about the drag.
* webkit/webkitwebview.cpp: Use GtkWidgetDragAndDropGlue wherever this class was
maintaining drag-and-drop state itself.
* webkit/webkitwebviewprivate.h: Swap out the drag-and-drop state for an instance
of the glue class.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate Chromium test expectation and also add back the expected result erroneously...
rniwa@webkit.org [Thu, 29 Sep 2011 06:01:34 +0000 (06:01 +0000)]
Update Chromium test expectation and also add back the expected result erroneously removed in r96284.

* platform/chromium/test_expectations.txt:
* platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
* platform/mac/editing/pasteboard/paste-text-006-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium rebaselines for r96257 part 2.
rniwa@webkit.org [Thu, 29 Sep 2011 05:43:21 +0000 (05:43 +0000)]
Chromium rebaselines for r96257 part 2.

* editing/deleting/delete-line-011-expected.txt: Added.
* editing/deleting/delete-tab-001-expected.txt: Added.
* editing/deleting/delete-tab-002-expected.txt: Added.
* editing/deleting/delete-tab-003-expected.txt: Added.
* editing/deleting/delete-tab-004-expected.txt: Added.
* editing/deleting/smart-delete-002-expected.txt: Added.
* editing/inserting/insert-text-with-newlines-expected.txt: Added.
* editing/style/smoosh-styles-003-expected.txt: Added.
* editing/style/style-3681552-fix-001-expected.txt: Added.
* editing/style/style-boundary-002-expected.txt: Added.
* editing/style/style-boundary-003-expected.txt: Added.
* editing/style/typing-style-001-expected.txt: Added.
* editing/style/typing-style-002-expected.txt: Added.
* platform/chromium-cg-mac-leopard/editing/pasteboard/paste-xml-expected.txt: Added.
* platform/chromium-cg-mac/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-linux-x86/editing: Added.
* platform/chromium-linux-x86/editing/pasteboard: Added.
* platform/chromium-linux-x86/editing/pasteboard/paste-xml-expected.txt: Added.
* platform/chromium-linux-x86/editing/style: Added.
* platform/chromium-linux-x86/editing/style/style-3681552-fix-002-expected.txt: Added.
* platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
* platform/chromium-linux/editing/pasteboard/paste-xml-expected.txt: Added.
* platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
* platform/chromium-linux/editing/style/style-3681552-fix-002-expected.txt: Added.
* platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-win-vista/editing/deleting: Removed.
* platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Removed.
* platform/chromium-win-vista/editing/execCommand: Removed.
* platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Removed.
* platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Removed.
* platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Removed.
* platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Removed.
* platform/chromium-win-vista/editing/inserting: Removed.
* platform/chromium-win-vista/editing/inserting/4278698-expected.png: Removed.
* platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Removed.
* platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Added.
* platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Removed.
* platform/chromium-win-vista/editing/selection: Removed.
* platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Removed.
* platform/chromium-win-vista/editing/style: Added.
* platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Added.
* platform/chromium-win-vista/editing/undo: Removed.
* platform/chromium-win-vista/editing/undo/4063751-expected.png: Removed.
* platform/chromium-win-vista/editing/unsupported-content: Removed.
* platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Removed.
* platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Removed.
* platform/chromium-win-xp/editing/pasteboard: Added.
* platform/chromium-win-xp/editing/pasteboard/paste-xml-expected.txt: Added.
* platform/chromium-win-xp/editing/style: Added.
* platform/chromium-win-xp/editing/style/style-3681552-fix-002-expected.txt: Added.
* platform/chromium-win-xp/fast/events: Removed.
* platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Added.
* platform/chromium-win/editing/deleting/delete-line-011-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
* platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
* platform/chromium-win/editing/pasteboard/drag-drop-modifies-page-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/chromium-win/editing/spelling/spelling-expected.txt:
* platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
* platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
* platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
* platform/chromium-win/editing/style/style-boundary-002-expected.txt:
* platform/chromium-win/editing/style/style-boundary-003-expected.txt:
* platform/chromium-win/editing/style/style-boundary-005-expected.txt:
* platform/chromium-win/editing/style/typing-style-001-expected.txt:
* platform/chromium-win/editing/style/typing-style-002-expected.txt:
* platform/chromium-win/fast/events/updateLayoutForHitTest-expected.png:
* platform/chromium-win/fast/events/updateLayoutForHitTest-expected.txt:
* platform/gtk/editing/deleting/delete-line-011-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-tab-001-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-tab-002-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-tab-003-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-tab-004-expected.txt: Removed.
* platform/gtk/editing/deleting/smart-delete-002-expected.txt: Removed.
* platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
* platform/gtk/editing/style/smoosh-styles-003-expected.txt: Removed.
* platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Removed.
* platform/gtk/editing/style/style-boundary-002-expected.txt: Removed.
* platform/gtk/editing/style/style-boundary-003-expected.txt: Removed.
* platform/gtk/editing/style/typing-style-001-expected.txt: Removed.
* platform/gtk/editing/style/typing-style-002-expected.txt: Removed.
* platform/gtk/fast/repaint/selection-clear-expected.txt: Removed.
* platform/mac/editing/deleting/delete-line-011-expected.txt: Removed.
* platform/mac/editing/deleting/delete-tab-001-expected.txt: Removed.
* platform/mac/editing/deleting/delete-tab-002-expected.txt: Removed.
* platform/mac/editing/deleting/delete-tab-003-expected.txt: Removed.
* platform/mac/editing/deleting/delete-tab-004-expected.txt: Removed.
* platform/mac/editing/deleting/smart-delete-002-expected.txt: Removed.
* platform/mac/editing/inserting/insert-text-with-newlines-expected.txt: Removed.
* platform/mac/editing/style/smoosh-styles-003-expected.txt: Removed.
* platform/mac/editing/style/style-3681552-fix-001-expected.txt: Removed.
* platform/mac/editing/style/style-boundary-002-expected.txt: Removed.
* platform/mac/editing/style/style-boundary-003-expected.txt: Removed.
* platform/mac/editing/style/typing-style-001-expected.txt: Removed.
* platform/mac/editing/style/typing-style-002-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove some of Chromium test expectations temporarily added for r96257.
rniwa@webkit.org [Thu, 29 Sep 2011 04:55:10 +0000 (04:55 +0000)]
Remove some of Chromium test expectations temporarily added for r96257.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago.: Fix the WebKit2 WebGL build.
mrobinson@webkit.org [Thu, 29 Sep 2011 04:48:58 +0000 (04:48 +0000)]
.: Fix the WebKit2 WebGL build.

* configure.ac: Add -ldl to the OPENGL_LIBS.

Source/WebKit2: Fix the WebGL build on WebKit2 GTK+.

* GNUmakefile.am: Add OPENGL_LIBS to WebKit2 targets.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/10196497> first-letter after list marker not updated correctly
mitz@apple.com [Thu, 29 Sep 2011 04:12:42 +0000 (04:12 +0000)]
<rdar://problem/10196497> first-letter after list marker not updated correctly

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/dynamic/first-letter-after-list-marker.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter): Improved the logic for continuing past list markers
when trying to locate a first letter to update.

LayoutTests:

* fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* fast/dynamic/first-letter-after-list-marker-expected.txt: Added.
* fast/dynamic/first-letter-after-list-marker.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix pt 2 for r96286.
barraclough@apple.com [Thu, 29 Sep 2011 04:00:01 +0000 (04:00 +0000)]
Build fix pt 2 for r96286.

* assembler/MacroAssemblerCodeRef.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a test for accesskey in regard to iframes.
hayato@chromium.org [Thu, 29 Sep 2011 03:57:39 +0000 (03:57 +0000)]
Add a test for accesskey in regard to iframes.
https://bugs.webkit.org/show_bug.cgi?id=67642

Reviewed by Hajime Morita.

To catch any improvement of accesskey behavior in regard to
iframes, it'd be nice to add a test to verify the current behavior.

* fast/dom/access-key-iframe-expected.txt: Added.
* fast/dom/access-key-iframe.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
commit-queue@webkit.org [Thu, 29 Sep 2011 02:52:11 +0000 (02:52 +0000)]
[EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.
https://bugs.webkit.org/show_bug.cgi?id=68594

As the 1st assignment of local variable bx in _ewk_tiled_backing_store_zoom_set_internal
isn't effective at all, this patch just removes it.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-09-28
Reviewed by Ryosuke Niwa.

* ewk/ewk_tiled_backing_store.c:
(_ewk_tiled_backing_store_zoom_set_internal):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoREGRESSION(r93858): Can't type anything into input elements when maxlength is greater...
tkent@chromium.org [Thu, 29 Sep 2011 02:49:45 +0000 (02:49 +0000)]
REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 2^31
https://bugs.webkit.org/show_bug.cgi?id=68981

Reviewed by Darin Adler.

Source/WebCore:

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLInteger):
Check the failure of charactersToIntStrict().
(WebCore::parseHTMLNonNegativeInteger):
Check the failure of charactersToUIntStrict().

LayoutTests:

* fast/forms/input-text-paste-maxlength-expected.txt:
* fast/forms/input-text-paste-maxlength.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRun TestWebKitAPI on Chromium buildbots
commit-queue@webkit.org [Thu, 29 Sep 2011 02:37:33 +0000 (02:37 +0000)]
Run TestWebKitAPI on Chromium buildbots
https://bugs.webkit.org/show_bug.cgi?id=68678

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-28
Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix attempt for r96286.
rniwa@webkit.org [Thu, 29 Sep 2011 02:32:53 +0000 (02:32 +0000)]
Build fix attempt for r96286.

* assembler/MacroAssemblerCodeRef.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[EFL] Bump minimum requirement for eina.
ryuan.choi@samsung.com [Thu, 29 Sep 2011 02:27:29 +0000 (02:27 +0000)]
[EFL] Bump minimum requirement for eina.
https://bugs.webkit.org/show_bug.cgi?id=68994

Reviewed by Ryosuke Niwa.

* Source/cmake/FindEFL.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDFG JIT Operations on 32_64 should use stdcall calling convention.
barraclough@apple.com [Thu, 29 Sep 2011 01:36:00 +0000 (01:36 +0000)]
DFG JIT Operations on 32_64 should use stdcall calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69046

Reviewed by Sam Weinig.

All calls out are expecting stdcall conventions, but the default on OS X are cdecl.
Leave D_DFGOperation_DD calls as the one exception, since we want to be able to link
directly to std library functions like fmod - leave these calls obeying the default
platform calling convention.

* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
    - Add implicit constructors for std calls.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
    - Make this work non-Mac platforms.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
* dfg/DFGOperations.h:
    - Mark all operations as stdcalls.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOne last GTK rebaseline for r96257.
rniwa@webkit.org [Thu, 29 Sep 2011 01:34:02 +0000 (01:34 +0000)]
One last GTK rebaseline for r96257.

* platform/gtk/editing/inserting/insert-at-end-02-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium rebaseline for r96257 part 2.
rniwa@webkit.org [Thu, 29 Sep 2011 01:31:58 +0000 (01:31 +0000)]
Chromium rebaseline for r96257 part 2.

* platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png:
* platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/undo: Added.
* platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/unsupported-content: Added.
* platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png: Added.
* platform/chromium-cg-mac/editing/deleting/table-cells-expected.png:
* platform/chromium-cg-mac/editing/execCommand/create-list-with-hr-expected.png: Added.
* platform/chromium-cg-mac/editing/execCommand/find-after-replace-expected.png: Added.
* platform/chromium-cg-mac/editing/execCommand/paste-1-expected.png: Added.
* platform/chromium-cg-mac/editing/execCommand/paste-2-expected.png: Added.
* platform/chromium-cg-mac/editing/inserting/4278698-expected.png: Added.
* platform/chromium-cg-mac/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
* platform/chromium-cg-mac/editing/pasteboard/3976872-expected.png: Added.
* platform/chromium-cg-mac/editing/pasteboard/4076267-2-expected.png: Added.
* platform/chromium-cg-mac/editing/pasteboard/4076267-3-expected.png: Added.
* platform/chromium-cg-mac/editing/pasteboard/4076267-expected.png: Added.
* platform/chromium-cg-mac/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
* platform/chromium-cg-mac/editing/selection/select-all-iframe-expected.png: Added.
* platform/chromium-cg-mac/editing/undo: Added.
* platform/chromium-cg-mac/editing/undo/4063751-expected.png: Added.
* platform/chromium-cg-mac/editing/unsupported-content: Added.
* platform/chromium-cg-mac/editing/unsupported-content/table-type-after-expected.png: Added.
* platform/chromium-cg-mac/editing/unsupported-content/table-type-before-expected.png: Added.
* platform/chromium-linux/editing/deleting/table-cells-expected.png:
* platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-linux/editing/execCommand/paste-1-expected.png:
* platform/chromium-linux/editing/execCommand/paste-2-expected.png:
* platform/chromium-linux/editing/inserting/4278698-expected.png:
* platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-linux/editing/pasteboard/3976872-expected.png:
* platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-linux/editing/pasteboard/4076267-expected.png:
* platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
* platform/chromium-linux/editing/undo/4063751-expected.png:
* platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-mac/editing/deleting/table-cells-expected.png:
* platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-mac/editing/execCommand/paste-1-expected.png:
* platform/chromium-mac/editing/execCommand/paste-2-expected.png:
* platform/chromium-mac/editing/inserting/4278698-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-mac/editing/pasteboard/3976872-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png:
* platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
* platform/chromium-mac/editing/undo/4063751-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-win-vista/editing: Added.
* platform/chromium-win-vista/editing/deleting: Added.
* platform/chromium-win-vista/editing/deleting/table-cells-expected.png: Added.
* platform/chromium-win-vista/editing/execCommand: Added.
* platform/chromium-win-vista/editing/execCommand/create-list-with-hr-expected.png: Added.
* platform/chromium-win-vista/editing/execCommand/find-after-replace-expected.png: Added.
* platform/chromium-win-vista/editing/execCommand/paste-1-expected.png: Added.
* platform/chromium-win-vista/editing/execCommand/paste-2-expected.png: Added.
* platform/chromium-win-vista/editing/inserting: Added.
* platform/chromium-win-vista/editing/inserting/4278698-expected.png: Added.
* platform/chromium-win-vista/editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
* platform/chromium-win-vista/editing/pasteboard: Added.
* platform/chromium-win-vista/editing/pasteboard/3976872-expected.png: Added.
* platform/chromium-win-vista/editing/pasteboard/4076267-2-expected.png: Added.
* platform/chromium-win-vista/editing/pasteboard/4076267-3-expected.png: Added.
* platform/chromium-win-vista/editing/pasteboard/4076267-expected.png: Added.
* platform/chromium-win-vista/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
* platform/chromium-win-vista/editing/selection: Added.
* platform/chromium-win-vista/editing/selection/select-all-iframe-expected.png: Added.
* platform/chromium-win-vista/editing/undo: Added.
* platform/chromium-win-vista/editing/undo/4063751-expected.png: Added.
* platform/chromium-win-vista/editing/unsupported-content: Added.
* platform/chromium-win-vista/editing/unsupported-content/table-type-after-expected.png: Added.
* platform/chromium-win-vista/editing/unsupported-content/table-type-before-expected.png: Added.
* platform/chromium-win/editing/deleting/table-cells-expected.png:
* platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-win/editing/execCommand/paste-1-expected.png:
* platform/chromium-win/editing/execCommand/paste-2-expected.png:
* platform/chromium-win/editing/inserting/4278698-expected.png:
* platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-win/editing/pasteboard/3976872-expected.png:
* platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-win/editing/pasteboard/4076267-expected.png:
* platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
* platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-win/editing/selection/select-all-iframe-expected.png:
* platform/chromium-win/editing/undo/4063751-expected.png:
* platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
* platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove unused createRootLayerPainter from CCLayerTreeHostClient
commit-queue@webkit.org [Thu, 29 Sep 2011 01:28:54 +0000 (01:28 +0000)]
Remove unused createRootLayerPainter from CCLayerTreeHostClient
https://bugs.webkit.org/show_bug.cgi?id=69042

Patch by Antoine Labour <piman@chromium.org> on 2011-09-28
Reviewed by James Robinson.

No new test needed: no semantic change.

* platform/graphics/chromium/cc/CCLayerTreeHost.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogarden-o-matic results should anticipate 0 unexpected failures.
dglazkov@chromium.org [Thu, 29 Sep 2011 01:03:30 +0000 (01:03 +0000)]
garden-o-matic results should anticipate 0 unexpected failures.
https://bugs.webkit.org/show_bug.cgi?id=69036

Also fixes controllers: UnexpectedFailures test.

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOnly resolve direction aware properties when properties are direction aware.
macpherson@chromium.org [Thu, 29 Sep 2011 01:01:13 +0000 (01:01 +0000)]
Only resolve direction aware properties when properties are direction aware.
https://bugs.webkit.org/show_bug.cgi?id=68968

Reviewed by Eric Seidel.

No new tests / no functionality changed.

Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDFG JIT falls back on numerical comparisons when it does not
fpizlo@apple.com [Thu, 29 Sep 2011 00:47:07 +0000 (00:47 +0000)]
DFG JIT falls back on numerical comparisons when it does not
recognize a prediction
https://bugs.webkit.org/show_bug.cgi?id=68977

Reviewed by Geoffrey Garen.

This fixes both the way comparison implementations are selected. It
also fixes a bug where comparisons other than equality (like < or >)
on objects are compiled as if the comparison was equality.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
joepeck@webkit.org [Thu, 29 Sep 2011 00:45:26 +0000 (00:45 +0000)]
ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=69037

Reviewed by Alexey Proskuryakov.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::runOpenPanel):
If no delegate is implemented, dismiss the listener
with a cancel. It expects some action.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofast/dom/scroll-element-to-rect.html fails on WK1 Mac port
simon.fraser@apple.com [Thu, 29 Sep 2011 00:45:20 +0000 (00:45 +0000)]
fast/dom/scroll-element-to-rect.html fails on WK1 Mac port
https://bugs.webkit.org/show_bug.cgi?id=68815

Source/WebCore:

Reviewed by Dan Bernstein.

FrameView::scrollElementToRect() was incorrectly using Element::boundsInWindowSpace(),
which is window-relative (not web view-relative), and has flipped coordinates
in WebKit1.

Change to use Node::getRect() which is what the author intended.

* dom/Element.h:
* page/FrameView.cpp:
(WebCore::FrameView::scrollElementToRect):

LayoutTests:

Reviewed by Dan Bernstein.

Fix these tests to not throw errors when window.internals is not available.

* fast/dom/scroll-element-to-rect-centered.html:
* fast/dom/scroll-element-to-rect.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoQt rebsaeline after r96257. It seems like the difference is coming from the font...
rniwa@webkit.org [Thu, 29 Sep 2011 00:32:26 +0000 (00:32 +0000)]
Qt rebsaeline after r96257. It seems like the difference is coming from the font used in select element.

* platform/qt/editing/pasteboard/select-element-1-expected.txt: Copied from
LayoutTests/editing/pasteboard/select-element-1-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDon't clamp cubic-bezier timing functions between 0 and 1
commit-queue@webkit.org [Thu, 29 Sep 2011 00:29:11 +0000 (00:29 +0000)]
Don't clamp cubic-bezier timing functions between 0 and 1
https://bugs.webkit.org/show_bug.cgi?id=45761

Source/WebCore:

Remove the limitation of clamping the cubic-bezier timing function
values between 0 and 1, following the specification change made on
April 5 of this year.

Patch by Peter Beverloo <peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.

Tests: transitions/cubic-bezier-overflow-color.html
       transitions/cubic-bezier-overflow-length.html
       transitions/cubic-bezier-overflow-shadow.html
       transitions/cubic-bezier-overflow-svg-length.html
       transitions/cubic-bezier-overflow-transform.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):

LayoutTests:

Test overflow behavior of colors, lengths, svg lengths,
shadows and transforms (through rotations). Update the
timing function test to check for now valid values.

Patch by Peter Beverloo <peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.

* fast/css/transition-timing-function-expected.txt:
* fast/css/transition-timing-function.html:
* transitions/cubic-bezier-overflow-color-expected.txt: Added.
* transitions/cubic-bezier-overflow-color.html: Added.
* transitions/cubic-bezier-overflow-length-expected.txt: Added.
* transitions/cubic-bezier-overflow-length.html: Added.
* transitions/cubic-bezier-overflow-shadow-expected.txt: Added.
* transitions/cubic-bezier-overflow-shadow.html: Added.
* transitions/cubic-bezier-overflow-svg-length-expected.txt: Added.
* transitions/cubic-bezier-overflow-svg-length.html: Added.
* transitions/cubic-bezier-overflow-transform-expected.txt: Added.
* transitions/cubic-bezier-overflow-transform.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMore GTK rebaselines after r96257.
rniwa@webkit.org [Thu, 29 Sep 2011 00:24:07 +0000 (00:24 +0000)]
More GTK rebaselines after r96257.

* platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/gtk/editing/deleting/delete-line-005-expected.txt:
* platform/gtk/editing/deleting/merge-endOfParagraph-expected.txt:
* platform/gtk/editing/deleting/regional-indicators-expected.txt:
* platform/gtk/editing/deleting/table-cells-expected.txt:
* platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
* platform/gtk/editing/pasteboard/paste-match-style-002-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-005-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove Chromium failing expectations for tests that now pass.
mihaip@chromium.org [Thu, 29 Sep 2011 00:21:30 +0000 (00:21 +0000)]
Remove Chromium failing expectations for tests that now pass.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChromium rebaseline for r96257 part 1.
rniwa@webkit.org [Thu, 29 Sep 2011 00:20:47 +0000 (00:20 +0000)]
Chromium rebaseline for r96257 part 1.

* platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-008-expected.png: Removed.
* platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
* platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
* platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
* platform/chromium-linux/editing/deleting/table-cells-expected.png:
* platform/chromium-linux/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-linux/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-linux/editing/execCommand/paste-1-expected.png:
* platform/chromium-linux/editing/execCommand/paste-2-expected.png:
* platform/chromium-linux/editing/inserting/4278698-expected.png:
* platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-linux/editing/pasteboard/3976872-expected.png:
* platform/chromium-linux/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-linux/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-linux/editing/pasteboard/4076267-expected.png:
* platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-linux/editing/selection/node-removal-1-expected.png:
* platform/chromium-linux/editing/selection/select-all-iframe-expected.png:
* platform/chromium-linux/editing/undo/4063751-expected.png:
* platform/chromium-linux/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-linux/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-mac/editing/deleting/table-cells-expected.png:
* platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-mac/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-mac/editing/execCommand/paste-1-expected.png:
* platform/chromium-mac/editing/execCommand/paste-2-expected.png:
* platform/chromium-mac/editing/inserting/4278698-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-mac/editing/pasteboard/3976872-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-expected.png:
* platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-mac/editing/selection/node-removal-1-expected.png:
* platform/chromium-mac/editing/selection/select-all-iframe-expected.png:
* platform/chromium-mac/editing/undo/4063751-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-win-xp/editing/pasteboard: Removed.
* platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3775172-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3857753-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3865854-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3928305-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt:
* platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Added.
* platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-contents-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-contents-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-contents-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-018-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-021-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-022-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-023-expected.txt:
* platform/chromium-win/editing/deleting/delete-block-merge-contents-024-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-008-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-first-list-item-expected.txt:
* platform/chromium-win/editing/deleting/delete-image-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-image-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-image-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-image-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-003-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-005-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-006-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-007-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-008-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-009-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-010-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-012-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-013-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-014-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-015-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-016-expected.txt:
* platform/chromium-win/editing/deleting/delete-line-017-expected.txt:
* platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-listitem-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
* platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
* platform/chromium-win/editing/deleting/forward-delete-expected.txt:
* platform/chromium-win/editing/deleting/list-item-1-expected.txt:
* platform/chromium-win/editing/deleting/merge-different-styles-expected.txt:
* platform/chromium-win/editing/deleting/merge-endOfParagraph-expected.txt:
* platform/chromium-win/editing/deleting/merge-no-br-expected.txt:
* platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
* platform/chromium-win/editing/deleting/pruning-after-merge-2-expected.txt:
* platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
* platform/chromium-win/editing/deleting/table-cells-expected.png:
* platform/chromium-win/editing/deleting/table-cells-expected.txt:
* platform/chromium-win/editing/execCommand/4641880-1-expected.txt:
* platform/chromium-win/editing/execCommand/4641880-2-expected.txt:
* platform/chromium-win/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-win/editing/execCommand/create-list-with-hr-expected.txt:
* platform/chromium-win/editing/execCommand/find-after-replace-expected.png:
* platform/chromium-win/editing/execCommand/find-after-replace-expected.txt:
* platform/chromium-win/editing/execCommand/format-block-with-trailing-br-expected.txt:
* platform/chromium-win/editing/execCommand/indent-list-item-expected.txt:
* platform/chromium-win/editing/execCommand/indent-selection-expected.txt:
* platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.txt:
* platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
* platform/chromium-win/editing/execCommand/nsresponder-indent-expected.txt:
* platform/chromium-win/editing/execCommand/nsresponder-outdent-expected.txt:
* platform/chromium-win/editing/execCommand/paste-1-expected.png:
* platform/chromium-win/editing/execCommand/paste-1-expected.txt:
* platform/chromium-win/editing/execCommand/paste-2-expected.png:
* platform/chromium-win/editing/execCommand/paste-2-expected.txt:
* platform/chromium-win/editing/execCommand/remove-list-from-range-selection-expected.txt:
* platform/chromium-win/editing/execCommand/remove-list-item-1-expected.txt:
* platform/chromium-win/editing/inserting/4278698-expected.png:
* platform/chromium-win/editing/inserting/4278698-expected.txt:
* platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
* platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
* platform/chromium-win/editing/inserting/insert-3775316-fix-expected.txt:
* platform/chromium-win/editing/inserting/insert-3851164-fix-expected.txt:
* platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
* platform/chromium-win/editing/inserting/insert-at-end-01-expected.txt:
* platform/chromium-win/editing/inserting/insert-at-end-02-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-001-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-005-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
* platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-001-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-002-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-005-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-007-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-009-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-010-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-020-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-023-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-025-expected.txt:
* platform/chromium-win/editing/inserting/insert-div-026-expected.txt:
* platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
* platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
* platform/chromium-win/editing/inserting/multiple-lines-selected-expected.txt:
* platform/chromium-win/editing/inserting/paragraph-separator-03-expected.txt:
* platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.txt:
* platform/chromium-win/editing/inserting/redo-expected.txt:
* platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.txt:
* platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.txt:
* platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.txt:
* platform/chromium-win/editing/inserting/typing-001-expected.txt:
* platform/chromium-win/editing/inserting/typing-002-expected.txt:
* platform/chromium-win/editing/inserting/typing-003-expected.txt:
* platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
* platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
* platform/chromium-win/editing/pasteboard/3976872-expected.png:
* platform/chromium-win/editing/pasteboard/3976872-expected.txt:
* platform/chromium-win/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
* platform/chromium-win/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
* platform/chromium-win/editing/pasteboard/4076267-expected.png:
* platform/chromium-win/editing/pasteboard/4076267-expected.txt:
* platform/chromium-win/editing/pasteboard/8145-3-expected.txt:
* platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
* platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
* platform/chromium-win/editing/pasteboard/displaced-generic-placeholder-expected.txt:
* platform/chromium-win/editing/pasteboard/displaced-placeholder-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-after-delete-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
* platform/chromium-win/editing/pasteboard/merge-end-borders-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-match-style-002-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-004-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-008-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
* platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.txt:
* platform/chromium-win/editing/selection/move-between-blocks-no-001-expected.txt:
* platform/chromium-win/editing/selection/node-removal-1-expected.png:
* platform/chromium-win/editing/selection/node-removal-1-expected.txt:
* platform/chromium-win/editing/selection/node-removal-2-expected.txt:
* platform/chromium-win/editing/selection/replace-selection-1-expected.txt:
* platform/chromium-win/editing/selection/select-all-iframe-expected.png:
* platform/chromium-win/editing/selection/select-all-iframe-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-001-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-002-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-003-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-004-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-007-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-009-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-010-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-011-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-012-expected.txt:
* platform/chromium-win/editing/style/create-block-for-style-013-expected.txt:
* platform/chromium-win/editing/style/designmode-expected.txt:
* platform/chromium-win/editing/style/relative-font-size-change-001-expected.txt:
* platform/chromium-win/editing/style/relative-font-size-change-002-expected.txt:
* platform/chromium-win/editing/style/smoosh-styles-001-expected.txt:
* platform/chromium-win/editing/style/smoosh-styles-003-expected.png:
* platform/chromium-win/editing/style/smoosh-styles-003-expected.txt:
* platform/chromium-win/editing/style/style-3998892-fix-expected.txt:
* platform/chromium-win/editing/style/style-boundary-001-expected.txt:
* platform/chromium-win/editing/style/style-boundary-004-expected.txt:
* platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
* platform/chromium-win/editing/undo/4063751-expected.png:
* platform/chromium-win/editing/undo/4063751-expected.txt:
* platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
* platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
* platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
* platform/chromium-win/editing/undo/undo-delete-expected.txt:
* platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
* platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
* platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
* platform/chromium-win/editing/unsupported-content/list-delete-001-expected.txt:
* platform/chromium-win/editing/unsupported-content/list-delete-003-expected.txt:
* platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
* platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-delete-001-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-delete-002-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-delete-003-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
* platform/chromium-win/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:
* platform/chromium-win/fast/dynamic/move-node-with-selection-expected.txt:
* platform/chromium-win/svg/custom/use-clipped-hit-expected.txt:
* platform/gtk/editing/deleting/delete-br-010-expected.txt: Removed.
* platform/gtk/editing/inserting/insert-div-010-expected.txt: Removed.
* platform/mac/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt: Removed.
* platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoModify new-run-webkit-tests to return the percentage difference in image diffs where...
dpranke@chromium.org [Thu, 29 Sep 2011 00:09:39 +0000 (00:09 +0000)]
Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.

https://bugs.webkit.org/show_bug.cgi?id=67253

Reviewed by Eric Seidel.

Tools:

Nearly all of the work in this was done by Simon Fraser; I'm
just repackaging it and cleaning it up a bit. This change
modifies port.diff_image() to return a tuple of (pass/fail,
%age), adds the value to the FailureImageHashMismatch, and
writes the value into the full_results.json files to be
displayed in the results page.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/models/test_failures.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

LayoutTests:

* fast/harness/resources/results-test.js:
(mockExpectation):
(runDefaultSingleRowTest):
():
* fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWinCairo build fix.
bfulgham@webkit.org [Thu, 29 Sep 2011 00:09:02 +0000 (00:09 +0000)]
WinCairo build fix.

* WebProcess/WebPage/WebFrame.h: Add include of <wtc/RetainPtr.h>

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDelayNode must set the context on delayTime AudioParam to support automation
crogers@google.com [Thu, 29 Sep 2011 00:06:06 +0000 (00:06 +0000)]
DelayNode must set the context on delayTime AudioParam to support automation
https://bugs.webkit.org/show_bug.cgi?id=68828

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/delaynode-scheduling.html

* webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):

LayoutTests:

* webaudio/delaynode-scheduling-expected.txt: Added.
* webaudio/delaynode-scheduling.html: Added.
* webaudio/delaynode.html:
* webaudio/resources/delay-testing.js: Added.
(createToneBuffer):
(checkDelayedResult.return.var):
(checkDelayedResult):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMore Mac rebaselines for r96257.
rniwa@webkit.org [Thu, 29 Sep 2011 00:02:29 +0000 (00:02 +0000)]
More Mac rebaselines for r96257.

* platform/mac/editing/execCommand/insertHorizontalRule-expected.png:
* platform/mac/editing/selection/node-removal-1-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96269 268f45cc-cd09-0410-ab3c-d52691b4dbfc