platform/upstream/nodejs.git
11 years agovm: add support for timeout argument
Andrew Paprocki [Mon, 8 Oct 2012 19:24:08 +0000 (21:24 +0200)]
vm: add support for timeout argument

Add a watchdog class which executes a timer in a separate event loop in
a separate thread that will terminate v8 execution if it expires.

Add timeout argument to functions in vm module which use the watchdog
if a non-zero timeout is specified.

11 years agotools: fix test.py after v8 upgrade
Ben Noordhuis [Mon, 29 Apr 2013 21:08:02 +0000 (23:08 +0200)]
tools: fix test.py after v8 upgrade

test.py imports deps/v8/tools/utils.py but that file is gone after the
upgrade to 3.18.4 in commit 2f75785. Resurrect the file in tools/

11 years agov8: reapply floating patches
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches

11 years agodeps: upgrade v8 to 3.18.4
Ben Noordhuis [Mon, 29 Apr 2013 20:35:21 +0000 (22:35 +0200)]
deps: upgrade v8 to 3.18.4

11 years agodebugger: fix bug in breakpoint regex escaping
Miroslav Bajtoš [Mon, 29 Apr 2013 12:09:26 +0000 (14:09 +0200)]
debugger: fix bug in breakpoint regex escaping

Fix a bug in setBreakpoint() where not all regex characters are escaped
when constructing scriptRegEx for V8.

11 years agoRevert "deps: downgrade openssl to v1.0.0f"
Ben Noordhuis [Mon, 29 Apr 2013 12:15:07 +0000 (14:15 +0200)]
Revert "deps: downgrade openssl to v1.0.0f"

This commit undoes the downgrade from OpenSSL v1.0.1e to v1.0.0f,
effectively upgrading OpenSSL to v1.0.1e again. The reason for the
downgrade was to work around compatibility issues with certain TLS
servers in the stable branch. See the commit log of 4fdb8ac and the
linked issue for details. We're going to revisit that in the master
branch.

This reverts commit 4fdb8acdaef4c3cb1d855e992ada0e63fee520a6.

11 years agohttp: forward-port missing bits from 01e2920
Ben Noordhuis [Mon, 29 Apr 2013 12:12:24 +0000 (14:12 +0200)]
http: forward-port missing bits from 01e2920

Forward-port the comments from commit 01e2920 (v0.10) to the master
branch. Everything else from that patch already exists in master.

It didn't merge cleanly because lib/http.js has been split up in
several files.

11 years agoMerge remote-tracking branch 'origin/v0.10'
Ben Noordhuis [Mon, 29 Apr 2013 12:08:51 +0000 (14:08 +0200)]
Merge remote-tracking branch 'origin/v0.10'

Conflicts:
AUTHORS
ChangeLog
deps/uv/ChangeLog
deps/uv/src/version.c
lib/http.js
src/node_crypto.cc
src/node_os.cc
src/node_version.h
test/simple/helper-debugger-repl.js

11 years agodeps: downgrade openssl to v1.0.0f
Ben Noordhuis [Fri, 26 Apr 2013 12:49:54 +0000 (14:49 +0200)]
deps: downgrade openssl to v1.0.0f

Several people have reported issues with IIS and Resin servers (or maybe
SSL terminators sitting in front of those servers) that are fixed by
downgrading OpenSSL. The AESNI performance improvements were nice but
stability is more important. Downgrade OpenSSL from 1.0.1e to 1.0.0f.

Fixes #5360 (and others).

11 years agodoc: cluster: s/server.destroy/server.close/
Ben Noordhuis [Mon, 29 Apr 2013 10:06:30 +0000 (12:06 +0200)]
doc: cluster: s/server.destroy/server.close/

Fixes #5379.

11 years agodoc: Deprecate require.extensions
isaacs [Mon, 29 Apr 2013 05:10:24 +0000 (22:10 -0700)]
doc: Deprecate require.extensions

11 years agodoc: stream writev cleanups
isaacs [Sun, 28 Apr 2013 06:41:16 +0000 (23:41 -0700)]
doc: stream writev cleanups

11 years agobenchmark: add chunked-encoding benchmark
Fedor Indutny [Mon, 8 Apr 2013 22:04:38 +0000 (02:04 +0400)]
benchmark: add chunked-encoding benchmark

11 years agotest: fix timing sensitive tests
Fedor Indutny [Mon, 8 Apr 2013 12:40:31 +0000 (16:40 +0400)]
test: fix timing sensitive tests

11 years agohttp: write buffers when chunked to embrace writev
Fedor Indutny [Mon, 8 Apr 2013 12:40:21 +0000 (16:40 +0400)]
http: write buffers when chunked to embrace writev

11 years agonet: implement ._writev for .cork/uncork() support
Fedor Indutny [Tue, 9 Apr 2013 08:56:56 +0000 (12:56 +0400)]
net: implement ._writev for .cork/uncork() support

Add Writev method to StreamWrap class for writing mixed array of strings
and buffers. Expose this method for TCP class.

11 years agostreams: introduce .cork/.uncork/._writev
Fedor Indutny [Sun, 14 Apr 2013 12:15:15 +0000 (08:15 -0400)]
streams: introduce .cork/.uncork/._writev

11 years agodebugger: breakpoints in scripts not loaded yet
Miroslav Bajtoš [Fri, 26 Apr 2013 06:05:33 +0000 (08:05 +0200)]
debugger: breakpoints in scripts not loaded yet

When developer calls setBreakpoint with an unknown script name,
we convert the script name into regular expression matching all
paths ending with given name (name can be a relative path too).

To create such breakpoint in V8, we use type `scriptRegEx`
instead of `scriptId` for `setbreakpoint` request.

To restore such breakpoint, we save the original script name
send by the user. We use this original name to set (restore)
breakpoint in the new child process.

11 years agodebugger: `restart` with custom debug port
Miroslav Bajtoš [Fri, 26 Apr 2013 19:07:56 +0000 (21:07 +0200)]
debugger: `restart` with custom debug port

Fixed a bug in debugger repl where `restart` command did not work
when a custom debug port was specified via command-line option
--port={number}.

File test/simple/helper-debugger-repl.js was extracted
from test/simple/test-debugger-repl.js

11 years agodebugger: print port number when connecting to debuggee
Miroslav Bajtoš [Fri, 26 Apr 2013 19:09:08 +0000 (21:09 +0200)]
debugger: print port number when connecting to debuggee

To improve troubleshooting of debugger problems in the future,
the debugger repl now prints the port it is connecting to.

11 years agodebugger: `restart` with custom debug port
Miroslav Bajtoš [Fri, 26 Apr 2013 19:07:56 +0000 (21:07 +0200)]
debugger: `restart` with custom debug port

Fixed a bug in debugger repl where `restart` command did not work
when a custom debug port was specified via command-line option
--port={number}.

File test/simple/helper-debugger-repl.js was extracted
from test/simple/test-debugger-repl.js

11 years agotest: cluster: unhide child errors in bind-twice
Ben Noordhuis [Thu, 25 Apr 2013 20:01:24 +0000 (22:01 +0200)]
test: cluster: unhide child errors in bind-twice

Errors in leaf child processes weren't picked up by the test runner
because they didn't get bubbled up to the main process. Don't forcibly
kill the child processes; tell them to quit gracefully, then inspect
their exit codes.

11 years agotest: cluster: rename bind-twice-v2 to bind-twice
Ben Noordhuis [Thu, 25 Apr 2013 20:02:42 +0000 (22:02 +0200)]
test: cluster: rename bind-twice-v2 to bind-twice

11 years agotest: cluster: remove bind-twice-v1 test
Ben Noordhuis [Thu, 25 Apr 2013 20:00:06 +0000 (22:00 +0200)]
test: cluster: remove bind-twice-v1 test

It tests the same thing as bind-twice-v2, only not as in-depth.

11 years agobuild: Makefile should respect configure --prefix
Timothy J Fontaine [Wed, 24 Apr 2013 17:15:36 +0000 (10:15 -0700)]
build: Makefile should respect configure --prefix

Fixes a regression that got introduced in commit ddf4d1a.

11 years agoChangeLog: Merge in v0.8
isaacs [Tue, 23 Apr 2013 21:43:46 +0000 (14:43 -0700)]
ChangeLog: Merge in v0.8

Close #5355

11 years agoblog: Post for v0.10.5
isaacs [Tue, 23 Apr 2013 21:08:01 +0000 (14:08 -0700)]
blog: Post for v0.10.5

11 years agoNow working on 0.10.6
isaacs [Tue, 23 Apr 2013 21:07:23 +0000 (14:07 -0700)]
Now working on 0.10.6

11 years agoMerge branch 'v0.10.5-release' into v0.10
isaacs [Tue, 23 Apr 2013 21:07:09 +0000 (14:07 -0700)]
Merge branch 'v0.10.5-release' into v0.10

11 years agoinstall: Support $(PREFIX) install target directory prefix
Olof Johansson [Tue, 23 Apr 2013 18:17:09 +0000 (20:17 +0200)]
install: Support $(PREFIX) install target directory prefix

This change introduces support for the common PREFIX variable in the
Makefile and install.py, instead of having /usr/local hardcoded. This
makes it much easier to install node to custom locations e.g. in a
user's home directory.

The PREFIX variable defaults to /usr/local.

11 years ago2013.04.23, Version 0.10.5 (Stable) v0.10.5
isaacs [Tue, 23 Apr 2013 01:00:41 +0000 (18:00 -0700)]
2013.04.23, Version 0.10.5 (Stable)

* uv: Upgrade to 0.10.5 (isaacs)

* build: added support for Visual Studio 2012 (Miroslav Bajtoš)

* http: Don't try to destroy nonexistent sockets (isaacs)

* crypto: LazyTransform on properties, not methods (isaacs)

* assert: put info in err.message, not err.name (Ryan Doenges)

* dgram: fix no address bind() (Ben Noordhuis)

* handle_wrap: fix NULL pointer dereference (Ben Noordhuis)

* os: fix unlikely buffer overflow in os.type() (Ben Noordhuis)

* stream: Fix unshift() race conditions (isaacs)

11 years agobuild: added support for Visual Studio 2012
Miroslav Bajtoš [Tue, 23 Apr 2013 07:38:17 +0000 (09:38 +0200)]
build: added support for Visual Studio 2012

11 years agouv: Upgrade to 0.10.5
isaacs [Tue, 23 Apr 2013 00:39:05 +0000 (17:39 -0700)]
uv: Upgrade to 0.10.5

11 years agoos: Fix uname() error handling on sunos
isaacs [Mon, 22 Apr 2013 17:18:46 +0000 (10:18 -0700)]
os: Fix uname() error handling on sunos

The uname function can return any non-negative int to indicate success.

Strange, but that's how it is documented.  This also fixes a similar
buffer overflow in the even more unlikely event that info.release is
> 255 characters, similar to how 78c5de5 did for info.sysname.

11 years agohttp: Don't try to destroy nonexistent sockets
isaacs [Mon, 22 Apr 2013 15:52:42 +0000 (08:52 -0700)]
http: Don't try to destroy nonexistent sockets

Fixes #3740

In the case of pipelined requests, you can have a situation where
the socket gets destroyed via one req/res object, but then trying
to destroy *another* req/res on the same socket will cause it to
call undefined.destroy(), since it was already removed from that
message.

Add a guard to OutgoingMessage.destroy and IncomingMessage.destroy
to prevent this error.

11 years agohttp: Don't try to destroy nonexistent sockets
isaacs [Mon, 22 Apr 2013 15:52:42 +0000 (08:52 -0700)]
http: Don't try to destroy nonexistent sockets

Fixes #3740

In the case of pipelined requests, you can have a situation where
the socket gets destroyed via one req/res object, but then trying
to destroy *another* req/res on the same socket will cause it to
call undefined.destroy(), since it was already removed from that
message.

Add a guard to OutgoingMessage.destroy and IncomingMessage.destroy
to prevent this error.

11 years agotest: fix dgram-bind-default-address on osx
isaacs [Fri, 19 Apr 2013 15:32:24 +0000 (08:32 -0700)]
test: fix dgram-bind-default-address on osx

Allow the IPv4-mapped-as-IPv6 style address.

11 years agocrypto: LazyTransform on properties, not methods
isaacs [Mon, 8 Apr 2013 15:43:20 +0000 (08:43 -0700)]
crypto: LazyTransform on properties, not methods

It needs to apply the Transform class when the _readableState,
_writableState, or _transformState properties are accessed,
otherwise things like setEncoding and on('data') don't work
properly.

Also, the methods wrappers are no longer needed, since they're only
problematic because they access the undefined properties.

11 years agosrc: fix potential memory leak on early return
mscdex [Sun, 21 Apr 2013 03:21:13 +0000 (23:21 -0400)]
src: fix potential memory leak on early return

11 years agosrc: don't initialize variable before assignment
mscdex [Sun, 21 Apr 2013 03:21:05 +0000 (23:21 -0400)]
src: don't initialize variable before assignment

11 years agocluster: clean up lib/cluster.js
Ben Noordhuis [Mon, 15 Apr 2013 12:17:17 +0000 (14:17 +0200)]
cluster: clean up lib/cluster.js

Clean up and DRY the cluster source code. Fix a few bugs while we're
here:

* Short-lived handles in long-lived worker processes were never
  reclaimed, resulting in resource leaks.

* Handles in the master process are now closed when the last worker
  that holds a reference to them quits. Previously, they were only
  closed at cluster shutdown.

* The cluster object no longer exposes functions/properties that are
  only valid in the 'other' process, e.g. cluster.fork() is no longer
  exported in worker processes.

So much goodness and still manages to reduce the line count from 590
to 320.

11 years agolint
isaacs [Fri, 19 Apr 2013 23:25:11 +0000 (16:25 -0700)]
lint

11 years agoevents: add EventEmitter.defaultMaxListeners
Ben Noordhuis [Fri, 4 May 2012 15:45:27 +0000 (17:45 +0200)]
events: add EventEmitter.defaultMaxListeners

Class property that controls the maximum number of listeners for all
instances of EventEmitter.

Fixes #3014.

Conflicts:
lib/events.js

11 years agov8: reapply floating patches
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches

11 years agoV8: Upgrade to 3.18.1
isaacs [Fri, 19 Apr 2013 17:50:44 +0000 (10:50 -0700)]
V8: Upgrade to 3.18.1

11 years agopath: add path.isAbsolute(path)
Ryan Doenges [Sun, 14 Apr 2013 19:44:40 +0000 (12:44 -0700)]
path: add path.isAbsolute(path)

An absolute path will always open the same location regardless of your
current working directory. For posix, this just means path.charAt(0) ===
'/', but on Windows it's a little more complicated.

Fixes joyent/node#5299.

11 years agoblog: v0.11.1 does not work on windows x64
isaacs [Fri, 19 Apr 2013 16:21:29 +0000 (09:21 -0700)]
blog: v0.11.1 does not work on windows x64

11 years agoNow working on 0.11.2
isaacs [Fri, 19 Apr 2013 16:14:44 +0000 (09:14 -0700)]
Now working on 0.11.2

11 years agoMerge branch 'v0.11.1-release'
isaacs [Fri, 19 Apr 2013 16:14:24 +0000 (09:14 -0700)]
Merge branch 'v0.11.1-release'

11 years agoblog: Post about 0.11.1
isaacs [Fri, 19 Apr 2013 16:12:34 +0000 (09:12 -0700)]
blog: Post about 0.11.1

11 years agoblog: Post about 0.10.4
isaacs [Fri, 19 Apr 2013 16:12:22 +0000 (09:12 -0700)]
blog: Post about 0.10.4

11 years ago2013.04.19, Version 0.11.1 (Unstable) v0.11.1
isaacs [Fri, 19 Apr 2013 14:39:44 +0000 (07:39 -0700)]
2013.04.19, Version 0.11.1 (Unstable)

* V8: upgrade to 3.18.0

* uv: Upgrade to v0.11.1

* http: split into multiple separate modules (Timothy J Fontaine)

* http: escape unsafe characters in request path (Ben Noordhuis)

* url: Escape all unwise characters (isaacs)

* build: depend on v8 postmortem-metadata if enabled (Paddy Byers)

* etw: update prototypes to match dtrace provider (Timothy J Fontaine)

* buffer: change output of Buffer.prototype.toJSON() (David Braun)

* dtrace: actually use the _handle.fd value (Timothy J Fontaine)

* dtrace: pass more arguments to probes (Dave Pacheco)

* build: allow building with dtrace on osx (Dave Pacheco)

* zlib: allow passing options to convenience methods (Kyle Robinson Young)

11 years agotest: fix dgram-bind-default-address on osx
isaacs [Fri, 19 Apr 2013 15:32:24 +0000 (08:32 -0700)]
test: fix dgram-bind-default-address on osx

Allow the IPv4-mapped-as-IPv6 style address.

11 years agosrc: replace Holder() with This()
Trevor Norris [Thu, 18 Apr 2013 23:52:07 +0000 (16:52 -0700)]
src: replace Holder() with This()

Switch to always use args.This() to retrieve object instance.

11 years agobuild: fix arm build after v8 upgrade
Ben Noordhuis [Fri, 19 Apr 2013 12:54:21 +0000 (14:54 +0200)]
build: fix arm build after v8 upgrade

V8 was upgraded to 3.18 in commit 9f68226. The knobs that control the
ARM build have changed in a number of ways. This commit patches the
configure script to reflect that. Should fix the Raspberry Pi build.

Fixes #5329.

11 years agodoc: document value of `this` inside listeners
Sean Silva [Thu, 18 Apr 2013 22:34:12 +0000 (18:34 -0400)]
doc: document value of `this` inside listeners

Fixes #5326.

11 years agoMerge remote-tracking branch 'ry/v0.10'
isaacs [Thu, 18 Apr 2013 23:21:24 +0000 (16:21 -0700)]
Merge remote-tracking branch 'ry/v0.10'

11 years agoassert: put info in err.message, not err.name
Ryan Doenges [Sun, 14 Apr 2013 01:48:00 +0000 (18:48 -0700)]
assert: put info in err.message, not err.name

4716dc6 made assert.equal() and related functions work better by
generating a better toString() from the expected, actual, and operator
values passed to fail(). Unfortunately, this was accomplished by putting
the generated message into the error's `name` property. When you passed
in a custom error message, the error would put the custom error into
`name` *and* `message`, resulting in helpful string representations like
"AssertionError: Oh no: Oh no".

This commit resolves that issue by storing the generated message in the
`message` property while leaving the error's name alone and adding
a regression test so that this doesn't pop back up later.

Closes #5292.

11 years agowebsite: add link to nightlies on download page
Ben Noordhuis [Thu, 18 Apr 2013 20:06:03 +0000 (22:06 +0200)]
website: add link to nightlies on download page

11 years agoMerge remote-tracking branch 'origin/v0.10'
Ben Noordhuis [Thu, 18 Apr 2013 10:14:30 +0000 (12:14 +0200)]
Merge remote-tracking branch 'origin/v0.10'

Conflicts:
src/node_os.cc

11 years agocrypto: fix return Local Handle w/o scope.Close()
Trevor Norris [Wed, 17 Apr 2013 18:45:13 +0000 (11:45 -0700)]
crypto: fix return Local Handle w/o scope.Close()

A new String was being created and returned, but was not sent through
the scope.Close(), which caused it to be cleaned up before being
returned.

11 years agobuild: libv8_base.a is now libv8_base.<arch>.a
Timothy J Fontaine [Wed, 17 Apr 2013 22:37:22 +0000 (15:37 -0700)]
build: libv8_base.a is now libv8_base.<arch>.a

This fixes generating the v8 contstants for dtrace on smartos

11 years agodgram: fix no address bind()
Ben Noordhuis [Wed, 17 Apr 2013 22:44:53 +0000 (00:44 +0200)]
dgram: fix no address bind()

I broke dgram.Socket#bind(port, cb) almost a year ago in 332fea5a but
it wasn't until today that someone complained and none of the tests
caught it because they all either specify the address or omit the
callback.

Anyway, now it works again and does what you expect: it binds the
socket to the "any" address ("0.0.0.0" for IPv4 and "::" for IPv6.)

11 years agotest: make stdout-close-unref work in test runner
Ben Noordhuis [Wed, 17 Apr 2013 21:59:49 +0000 (23:59 +0200)]
test: make stdout-close-unref work in test runner

process.stdout isn't fully initialized yet by the time the test starts
when invoked with `python tools/test.py`. Use process.stdin instead and
force initialization with process.stdin.resume().

11 years agobuffer: upgrade to new V8 profiler API
Ben Noordhuis [Wed, 17 Apr 2013 14:59:19 +0000 (16:59 +0200)]
buffer: upgrade to new V8 profiler API

11 years agov8: reapply floating patches
Ben Noordhuis [Mon, 8 Apr 2013 18:34:11 +0000 (20:34 +0200)]
v8: reapply floating patches

11 years agodeps: upgrade v8 to 3.18.0
Ben Noordhuis [Wed, 17 Apr 2013 14:10:37 +0000 (16:10 +0200)]
deps: upgrade v8 to 3.18.0

11 years agohttp: split Client into _http_client.js
Timothy J Fontaine [Thu, 11 Apr 2013 23:11:12 +0000 (16:11 -0700)]
http: split Client into _http_client.js

11 years agohttp: move Server and ServerResponse out
Timothy J Fontaine [Thu, 11 Apr 2013 23:00:19 +0000 (16:00 -0700)]
http: move Server and ServerResponse out

11 years agohttp: move OutgoingMessage into it's own file
Timothy J Fontaine [Thu, 11 Apr 2013 22:37:14 +0000 (15:37 -0700)]
http: move OutgoingMessage into it's own file

11 years agohttp: move parsers into _http_common.js
Timothy J Fontaine [Thu, 11 Apr 2013 22:15:41 +0000 (15:15 -0700)]
http: move parsers into _http_common.js

11 years agohttp: move IncomingMessage into its own file
Timothy J Fontaine [Thu, 11 Apr 2013 22:00:45 +0000 (15:00 -0700)]
http: move IncomingMessage into its own file

11 years agohttp: split Agent into its own file
Timothy J Fontaine [Thu, 11 Apr 2013 21:47:15 +0000 (14:47 -0700)]
http: split Agent into its own file

11 years agodocs: update path.join() example for v0.10
Kelly Gerber [Tue, 9 Apr 2013 20:36:34 +0000 (13:36 -0700)]
docs: update path.join() example for v0.10

The current example shows the behavior of v0.8. In v0.10 arguments
to path.join() must be strings; otherwise, an exception is thrown.

11 years agodoc: note a gotcha with http.Server sockets
Ryan Graham [Tue, 16 Apr 2013 20:52:52 +0000 (13:52 -0700)]
doc: note a gotcha with http.Server sockets

11 years agohandle_wrap: fix NULL pointer dereference
Ben Noordhuis [Tue, 16 Apr 2013 20:59:35 +0000 (22:59 +0200)]
handle_wrap: fix NULL pointer dereference

Fix a NULL pointer dereference in src/handle_wrap.cc which is really a
use-after-close bug.

The test checks that unref() after close() works on process.stdout but
this bug affects everything that derives from HandleWrap. I discovered
it because child processes would sometimes quit for no reason (that is,
no reason until I turned on core dumps.)

11 years agotest: preserve process.env after test-init exec
Stanislav Ochotnicky [Tue, 16 Apr 2013 07:51:56 +0000 (09:51 +0200)]
test: preserve process.env after test-init exec

When LD_LIBRARY_PATH is overriden for custom builds we need to preserve
it for child processes. To be sure we preserve whole environment of
parent process and just add TEST_INIT variable to it.

11 years agotest: preserve process.env in forked child_process
Stanislav Ochotnicky [Wed, 10 Apr 2013 13:38:02 +0000 (15:38 +0200)]
test: preserve process.env in forked child_process

When LD_LIBRARY_PATH is overriden for custom builds we need to preserve
it for forked process. There are possibly other environment variables
that could cause test failures so we preserve whole environment of
parent process.

11 years agoos: unbreak windows build
Ben Noordhuis [Mon, 15 Apr 2013 20:36:49 +0000 (22:36 +0200)]
os: unbreak windows build

Windows doesn't have MAXHOSTNAMELEN. Introduced in afbadde.

11 years agoos: handle 256 character hostnames
Ben Noordhuis [Mon, 15 Apr 2013 19:05:20 +0000 (21:05 +0200)]
os: handle 256 character hostnames

Fix a (rather academic) buffer overflow. MAXHOSTNAMELEN is 256 on most
platforms, which means the buffer wasn't big enough to hold the
trailing nul byte on a system with a maximum length hostname.

11 years agoos: fix unlikely buffer overflow in os.type()
Ben Noordhuis [Mon, 15 Apr 2013 18:51:28 +0000 (20:51 +0200)]
os: fix unlikely buffer overflow in os.type()

* Fix a buffer overflow that happens iff strlen(info.sysname) > 255.
* Check the return value of uname().

11 years agotest: add extra checks
Ben Noordhuis [Fri, 12 Apr 2013 14:16:18 +0000 (16:16 +0200)]
test: add extra checks

11 years agohttp: escape unsafe characters in request path
Ben Noordhuis [Fri, 12 Apr 2013 13:54:31 +0000 (15:54 +0200)]
http: escape unsafe characters in request path

Make http.request() and friends escape unsafe characters in the request
path. That is, a request for '/foo bar' is now escaped as '/foo%20bar'.

Before this commit, the path was used as-is in the request status line,
creating an invalid HTTP request ("GET /foo bar HTTP/1.1").

Fixes #4381.

11 years agourl: ~ is not actually an unwise char
isaacs [Fri, 12 Apr 2013 23:27:42 +0000 (16:27 -0700)]
url: ~ is not actually an unwise char

11 years agourl: Escape all unwise characters
isaacs [Fri, 12 Apr 2013 18:39:28 +0000 (11:39 -0700)]
url: Escape all unwise characters

This makes node's http URL handling logic identical to Chrome's

Re #5284

11 years agouv: Upgrade to v0.11.1
Fedor Indutny [Fri, 12 Apr 2013 15:43:05 +0000 (11:43 -0400)]
uv: Upgrade to v0.11.1

11 years agoMerge branch 'v0.10'
Fedor Indutny [Fri, 12 Apr 2013 15:30:11 +0000 (11:30 -0400)]
Merge branch 'v0.10'

Conflicts:
ChangeLog
deps/uv/src/version.c
src/node.h
src/node_crypto.cc
src/node_crypto_bio.cc
src/node_crypto_bio.h
src/node_object_wrap.h
src/node_version.h

11 years agobuild: Typo in tools/msvs/msi/product.wxs
isaacs [Fri, 12 Apr 2013 03:40:05 +0000 (20:40 -0700)]
build: Typo in tools/msvs/msi/product.wxs

11 years agostream: Fix unshift() race conditions
isaacs [Thu, 11 Apr 2013 22:01:26 +0000 (15:01 -0700)]
stream: Fix unshift() race conditions

Fix #5272

The consumption of a readable stream is a dance with 3 partners.

1. The specific stream Author (A)
2. The Stream Base class (B), and
3. The Consumer of the stream (C)

When B calls the _read() method that A implements, it sets a 'reading'
flag, so that parallel calls to _read() can be avoided.  When A calls
stream.push(), B knows that it's safe to start calling _read() again.

If the consumer C is some kind of parser that wants in some cases to
pass the source stream off to some other party, but not before "putting
back" some bit of previously consumed data (as in the case of Node's
websocket http upgrade implementation).  So, stream.unshift() will
generally *never* be called by A, but *only* called by C.

Prior to this patch, stream.unshift() *also* unset the state.reading
flag, meaning that C could indicate the end of a read, and B would
dutifully fire off another _read() call to A.  This is inappropriate.
In the case of fs streams, and other variably-laggy streams that don't
tolerate overlapped _read() calls, this causes big problems.

Also, calling stream.shift() after the 'end' event did not raise any
kind of error, but would cause very strange behavior indeed.  Calling it
after the EOF chunk was seen, but before the 'end' event was fired would
also cause weird behavior, and could lead to data being lost, since it
would not emit another 'readable' event.

This change makes it so that:

1. stream.unshift() does *not* set state.reading = false
2. stream.unshift() is allowed up until the 'end' event.
3. unshifting onto a EOF-encountered and zero-length (but not yet
end-emitted) stream will defer the 'end' event until the new data is
consumed.
4. pushing onto a EOF-encountered stream is now an error.

So, if you read(), you have that single tick to safely unshift() data
back into the stream, even if the null chunk was pushed, and the length
was 0.

11 years agoNow working on v0.10.5
isaacs [Thu, 11 Apr 2013 18:07:08 +0000 (11:07 -0700)]
Now working on v0.10.5

11 years agoMerge branch 'v0.10.4-release' into v0.10
isaacs [Thu, 11 Apr 2013 18:06:37 +0000 (11:06 -0700)]
Merge branch 'v0.10.4-release' into v0.10

11 years agolint
isaacs [Thu, 11 Apr 2013 18:06:07 +0000 (11:06 -0700)]
lint

11 years agoblog: Fix title for v0.8.23 release
isaacs [Thu, 11 Apr 2013 18:05:53 +0000 (11:05 -0700)]
blog: Fix title for v0.8.23 release

11 years ago2013.04.11, Version 0.10.4 (Stable) v0.10.4
isaacs [Thu, 11 Apr 2013 16:39:16 +0000 (09:39 -0700)]
2013.04.11, Version 0.10.4 (Stable)

* uv: Upgrade to 0.10.4

* npm: Upgrade to 1.2.18

* v8: Avoid excessive memory growth in JSON.parse (Fedor Indutny)

* child_process, cluster: fix O(n*m) scan of cmd string (Ben Noordhuis)

* net: fix socket.bytesWritten Buffers support (Fedor Indutny)

* buffer: fix offset checks (Łukasz Walukiewicz)

* stream: call write cb before finish event (isaacs)

* http: Support write(data, 'hex') (isaacs)

* crypto: dh secret should be left-padded (Fedor Indutny)

* process: expose NODE_MODULE_VERSION in process.versions (Rod Vagg)

* crypto: fix constructor call in crypto streams (Andreas Madsen)

* net: account for encoding in .byteLength (Fedor Indutny)

* net: fix buffer iteration in bytesWritten (Fedor Indutny)

* crypto: zero is not an error if writing 0 bytes (Fedor Indutny)

* tls: Re-enable check of CN-ID in cert verification (Tobias Müllerleile)

11 years agonpm: Upgrade to 1.2.18
isaacs [Thu, 11 Apr 2013 16:16:47 +0000 (09:16 -0700)]
npm: Upgrade to 1.2.18

11 years agouv: Upgrade to v0.10.4
isaacs [Thu, 11 Apr 2013 16:07:22 +0000 (09:07 -0700)]
uv: Upgrade to v0.10.4

11 years agochild_process: fix O(n*m) scan of cmd string
Ben Noordhuis [Thu, 11 Apr 2013 11:50:45 +0000 (13:50 +0200)]
child_process: fix O(n*m) scan of cmd string

Don't scan the whole string for a "NODE_" substring, just check that
the string starts with the expected prefix.

This is a reprise of dbbfbe7 but this time for the child_process
module.

11 years agocluster: fix O(n*m) scan of cmd string
Ben Noordhuis [Thu, 11 Apr 2013 11:18:02 +0000 (13:18 +0200)]
cluster: fix O(n*m) scan of cmd string

Don't scan the whole string for a "NODE_CLUSTER_" substring, just check
that the string starts with the expected prefix. The linear scan was
causing a noticeable (but unsurprising) slowdown on messages with a
large .cmd string property.

11 years agosrc: get rid of compiler warning
Trevor Norris [Tue, 9 Apr 2013 23:17:34 +0000 (16:17 -0700)]
src: get rid of compiler warning

Removed the following compiler warning from clang:

warning: adding 'int' to a string does not append to the string
[-Wstring-plus-int]

11 years agoreq_wrap: only grab domain object if in use
Trevor Norris [Tue, 9 Apr 2013 22:31:22 +0000 (15:31 -0700)]
req_wrap: only grab domain object if in use