dglazkov@chromium.org [Tue, 3 Apr 2012 23:04:21 +0000 (23:04 +0000)]
Unreviewed, rolling out r113087.
http://trac.webkit.org/changeset/113087
https://bugs.webkit.org/show_bug.cgi?id=83068
Breaks Windows builds in other unpredictable ways.
* WebKit.gyp: Removed the hack.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Tue, 3 Apr 2012 23:04:11 +0000 (23:04 +0000)]
Add a Media watchlist.
https://bugs.webkit.org/show_bug.cgi?id=83071
Reviewed by David Levin.
* Scripts/webkitpy/common/config/watchlist:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 3 Apr 2012 22:58:47 +0000 (22:58 +0000)]
Fix large leak in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=83084
Reviewed by Beth Dakin.
Fix a leak of the bimap backing store created when doing pixel and
ref tests. This leak was causing serious thrash on the test bots.
We don't need to allocate memory for CGBitmapContextCreate(); if we
pass NULL, it will allocate and manage its own backing store.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 22:54:07 +0000 (22:54 +0000)]
[Qt][WK2] Remove #if !USE(TILED_BACKING_STORE) from WebFrameLoaderClient::transitionToCommittedForNewPage()
https://bugs.webkit.org/show_bug.cgi?id=83070
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Andreas Kling.
It is preventing m_frameHasCustomRepresentation to be set properly and not in sync with
WebFrameLoaderClient::transitionToCommittedFromCachedFrame()
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 3 Apr 2012 22:51:44 +0000 (22:51 +0000)]
Crash in SelectorChecker::checkOneSelector.
https://bugs.webkit.org/show_bug.cgi?id=83040
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/css-set-selector-text-crash.html
Removing the early bail when we detect that our selector text
hasn't changed, and we don't notify the styleSelectorChanged.
In fact, when we adopt the new selector list, the old one will
get destroyed and the styleSelectorChanged call needs to be made.
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
LayoutTests:
* fast/css/css-set-selector-text-crash-expected.txt: Added.
* fast/css/css-set-selector-text-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 3 Apr 2012 22:39:13 +0000 (22:39 +0000)]
presentationAttributeCacheMaximumSize is set too low
https://bugs.webkit.org/show_bug.cgi?id=82816
Reviewed by Antti Koivisto.
Performance change, no side effects anticipated.
Prior to r106740, the presentation attribute style cache used to grow unbounded. As part of r110316,
a different version of the cache was introduced with a maximum size of 128. This size gave a 75% hit rate.
However this is bad as the previous cache had a 85% hit rate** and each miss propagate down to the matched
properties cache as we use pointer comparisons.
This change bumps the size to 4096. This size was chosen to bring us back to the previous hit rate while
being a power of 2 (it is the HashMap maximum size). The steep increase is due to the combinational compexity
of the new cache model: we need to match all our attributes' name, value and tag name to get a hit vs
one attribute name, value and a category in the previous cache. To avoid blowing up the memory, we introduced
a timer to clear the cache if the hit rate is too low.
The measured hit rate is actually better now - in the 90% range on most page cyclers. This ups the matched
properties hit rate by 1 percent point on presentation attributes.
** This is not a true apple-to-apple comparison as the cache model was changed.
* dom/StyledElement.cpp:
(PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::didHitPresentationAttributeCache):
(WebCore::PresentationAttributeCacheCleaner::cleanCache):
(WebCore):
(WebCore::presentationAttributeCacheCleaner):
(WebCore::StyledElement::updateAttributeStyle):
Added the logic to clean the presentation attribute cache if we drop below 100 hits per minutes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Apr 2012 22:34:03 +0000 (22:34 +0000)]
Implement new flex property and deprecate flex function
https://bugs.webkit.org/show_bug.cgi?id=82128
Reviewed by Ojan Vafai.
Source/WebCore:
No new tests. Tests were updated to use the new syntax and they should
all pass.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredFlexLengthForChild): Grab the
preferred size and if it's auto, fall back to width or height.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Use the value from the flex property.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
* rendering/RenderFlexibleBox.h:
LayoutTests:
Update tests to use the -webkit-flex: propery instead of the function.
In most cases this was just a simple find & replace, but in a few cases
we had to clear the flex value.
* css3/flexbox/auto-height-dynamic.html:
* css3/flexbox/child-overflow.html:
* css3/flexbox/columns-auto-size.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/flex-algorithm-min-max.html:
* css3/flexbox/flex-algorithm-with-margins.html:
* css3/flexbox/flex-algorithm.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-max.html:
* css3/flexbox/flex-align-percent-height.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/flex-flow-border.html:
* css3/flexbox/flex-flow-margins-auto-size-expected.txt: This test had expected failures that needed to be updated.
* css3/flexbox/flex-flow-margins-auto-size.html:
* css3/flexbox/flex-flow-margins.html:
* css3/flexbox/flex-flow-overflow.html:
* css3/flexbox/flex-flow-padding.html:
* css3/flexbox/flex-flow.html:
* css3/flexbox/flex-no-flex.html:
* css3/flexbox/flex-order.html:
* css3/flexbox/flex-pack.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-line-pack-horizontal-column.html:
* css3/flexbox/multiline-reverse-wrap-baseline.html:
* css3/flexbox/multiline-reverse-wrap-overflow.html:
* css3/flexbox/multiline.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/position-absolute-child.html:
* css3/flexbox/repaint-rtl-column.html:
* css3/flexbox/repaint.html:
* css3/flexbox/writing-modes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 3 Apr 2012 22:26:21 +0000 (22:26 +0000)]
Search result page scrolls up before the correct page opens from google search
https://bugs.webkit.org/show_bug.cgi?id=81280
<rdar://problem/
10973263>
Reviewed by Sam Weinig.
Make the requested scroll position part of the ScrollingTreeState so any changes being made
are in sync with other important changes such as the scroll layer or contents size.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
Use coordinatesScrollingForFrameView instead of checking if the frame is the main frame.
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
Call ScrollingTreeState::setRequestedScrollPosition.
(WebCore::ScrollingCoordinator::setScrollLayer):
Reset the requested scroll position.
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setRequestedScrollPosition):
Keep track of the scroll position.
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Update the scroll position if it's changed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Tue, 3 Apr 2012 22:02:58 +0000 (22:02 +0000)]
[chromium] Switch touchpad fling curve physics to absolute (not scaled) curve.
https://bugs.webkit.org/show_bug.cgi?id=83061
Reviewed by James Robinson.
Source/WebCore:
Revised existing unit tests.
Use an absolute curve for touchpad fling. Here we identify the location on the curve corresponding
to the initial fling velocity, and "jump in" at that point. Avoids issues around time/magnitude
scaling present in previous implementation, and gives better feel to fling animation.
* platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore):
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):
(WebCore::TouchpadFlingPlatformGestureCurve::apply):
* platform/TouchpadFlingPlatformGestureCurve.h:
(TouchpadFlingPlatformGestureCurve):
Source/WebKit/chromium:
* tests/PlatformGestureCurveTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 22:01:05 +0000 (22:01 +0000)]
Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
* BuildSlaveSupport/built-product-archive:
(unzipArchive):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Tue, 3 Apr 2012 21:52:11 +0000 (21:52 +0000)]
http/tests/media/video-cancel-load.html is flaky on linux
https://bugs.webkit.org/show_bug.cgi?id=82508
Unreviewed, removing no-longer-needed expectation.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 3 Apr 2012 21:48:37 +0000 (21:48 +0000)]
Implement WebGLShaderPrecisionFormat
https://bugs.webkit.org/show_bug.cgi?id=75925
Reviewed by Kenneth Russell.
Source/Platform:
* chromium/public/WebGraphicsContext3D.h: Add getShaderPrecisionFormat().
(WebGraphicsContext3D):
Source/WebCore:
Test: fast/canvas/webgl/shader-precision-format.html
* CMakeLists.txt: Add new source files webglshaderprecisionformat.h/idl
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* html/canvas/WebGLRenderingContext.cpp: Add getShaderPrecisionFormat.
(WebCore):
(WebCore::WebGLRenderingContext::getShaderPrecisionFormat):
* html/canvas/WebGLRenderingContext.h: Ditto.
(WebCore):
(WebGLRenderingContext):
* html/canvas/WebGLRenderingContext.idl: Ditto.
* html/canvas/WebGLShaderPrecisionFormat.h: Added.
(WebCore):
(WebGLShaderPrecisionFormat):
(WebCore::WebGLShaderPrecisionFormat::create):
(WebCore::WebGLShaderPrecisionFormat::rangeMin):
(WebCore::WebGLShaderPrecisionFormat::rangeMax):
(WebCore::WebGLShaderPrecisionFormat::precision):
(WebCore::WebGLShaderPrecisionFormat::WebGLShaderPrecisionFormat):
* html/canvas/WebGLShaderPrecisionFormat.idl: Added.
* page/DOMWindow.idl: Expose new type WebGLShaderPrecisionFormat for instanceof.
* platform/graphics/GraphicsContext3D.h: Add getShaderPrecisionFormat().
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):
* platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.
(WebCore::GraphicsContext3D::getShaderPrecisionFormat):
(WebCore):
Source/WebKit/chromium:
* src/GraphicsContext3DChromium.cpp: Add getShaderPrecisionFormat().
(WebCore):
* src/GraphicsContext3DPrivate.h: Ditto.
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h: Ditto.
(FakeWebGraphicsContext3D):
LayoutTests:
* fast/canvas/webgl/instanceof-test-expected.txt: Add new WebGLShaderPrecisionFormat failure.
* fast/canvas/webgl/instanceof-test.html:
* fast/canvas/webgl/shader-precision-format-expected.txt: Added.
* fast/canvas/webgl/shader-precision-format.html: Added.
* fast/dom/Window/script-tests/window-property-descriptors.js: Add new type WebGLShaderPrecisionFormat.
* fast/dom/Window/window-properties.html: Ditto.
* fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
(constructorNamesForWindow):
* fast/dom/script-tests/prototype-inheritance.js: Ditto.
* fast/js/script-tests/global-constructors.js: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 21:35:08 +0000 (21:35 +0000)]
Source/WebCore: Frame flattening: Do not restart layout from parent frame, when the parent is clean.
https://bugs.webkit.org/show_bug.cgi?id=81114
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.
When frame flattening is on, child frames try to mark the ancestors dirty
to be able to restart layout from the main frame. Child frames mark the
anchestors in FrameView::scheduleRelayout(). Marking fails when scheduling is disabled,
for example when the iframe's <head> has blocking resource and the <body> has not
been injected into the document.
When marking ancestor fails, child frame layout needs to continue normally.
It is expected to have layouts, when scheduling is enabled.
Test: http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):
(WebCore):
(WebCore::FrameView::doLayoutWithFrameFlattening):
* page/FrameView.h:
(FrameView):
LayoutTests: Add test case for 3 level nested iframes with frame flattening on.
https://bugs.webkit.org/show_bug.cgi?id=81114
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-03
Reviewed by Antti Koivisto.
* http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource-expected.txt: Added.
* http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html: Added.
* http/tests/misc/resources/3rd-level-iframe-with-blocking-resource.php: Added.
* http/tests/misc/resources/nested-iframe-loading-another-iframe.html: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 3 Apr 2012 21:30:27 +0000 (21:30 +0000)]
Avoid virtual method calls in the GraphicsLayer destructor
https://bugs.webkit.org/show_bug.cgi?id=83067
Reviewed by James Robinson.
Code cleanup to avoid calling virtual methods in the GraphicsLayer
destructor. Factor teardown code into a willBeDestroyed() method
that is called from the most dervied class. willBeDestroyed()
calls have to be chained. Fix the various ports' GraphicsLayer
implementations.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore):
(WebCore::GraphicsLayer::willBeDestroyed):
* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::~GraphicsLayerBlackBerry):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::willBeDestroyed):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore):
(WebCore::GraphicsLayerCA::willBeDestroyed):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
(WebCore):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
* platform/graphics/efl/GraphicsLayerEfl.cpp:
(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQt::~GraphicsLayerQt):
(WebCore):
(WebCore::GraphicsLayerQt::willBeDestroyed):
* platform/graphics/qt/GraphicsLayerQt.h:
(GraphicsLayerQt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 21:29:16 +0000 (21:29 +0000)]
[skia] Switch to Skia's implementation of the feMorphology filter.
https://bugs.webkit.org/show_bug.cgi?id=82085
Unreviewed Chromium expectations rebaseline.
Patch by Florin Malita <fmalita@google.com> on 2012-04-03
* platform/chromium-linux/svg/filters/filterRes-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/filterRes-expected.png: Removed.
* platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
* platform/chromium-win/svg/filters/filterRes-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Tue, 3 Apr 2012 21:21:46 +0000 (21:21 +0000)]
Having a drop handler prevents navigation on drop even if event is not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172
Reviewed by Ryosuke Niwa.
Source/WebCore:
Only early return if the drop handler prevents the default action.
http://trac.webkit.org/changeset/105396 introduced this issue when fixing some other aspects
of DnD handling.
Test: fast/events/drop-handler-should-not-stop-navigate.html
* page/DragController.cpp:
(WebCore::DragController::performDrag):
(WebCore::DragController::concludeEditDrag): Remove the assert. By definition, we want to
allow default actions to run now if they weren't explicitly canceled.
LayoutTests:
* fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
* fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
* fast/events/drop-handler-should-not-stop-navigate.html: Added.
* http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler
to prevent bubbled events from causing navigation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 3 Apr 2012 21:17:59 +0000 (21:17 +0000)]
disable incremental linking for debug of webkit
https://bugs.webkit.org/show_bug.cgi?id=83068
Reviewed by Adam Barth.
Now that we need to export symbols from webkit.dll that are
defined in webcore_platform, we have to enable ULDI in order for
incremental linking to work (which is used in debug mode).
* WebKit.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Tue, 3 Apr 2012 20:59:10 +0000 (20:59 +0000)]
[v8] Fix memory leak in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=83057
Reviewed by Ojan Vafai.
Source/WebCore:
This also brings the V8 and JSC implementation closer. The timing when we first lookup
the form element is now same in JSC and V8 (but different from Mozilla).
This also clears the strings once the code has been parsed and the function created.
Tests: fast/dom/inline-event-attributes-moved.html
fast/dom/inline-event-attributes-release.html
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8LazyEventListener.h:
(WebCore::V8LazyEventListener::create):
(V8LazyEventListener):
LayoutTests:
* fast/dom/inline-event-attributes-moved-expected.txt: Added.
* fast/dom/inline-event-attributes-moved.html: Added.
* fast/dom/inline-event-attributes-release-expected.txt: Added.
* fast/dom/inline-event-attributes-release.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 20:56:17 +0000 (20:56 +0000)]
More rebaselines after WK79568
https://bugs.webkit.org/show_bug.cgi?id=79568
Unreviewed test expectations update.
Patch by Philip Rogers <pdr@google.com> on 2012-04-03
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
* platform/chromium-linux/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
* platform/chromium-mac-leopard/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
* platform/chromium-win-vista/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
* platform/chromium-win/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 3 Apr 2012 20:53:41 +0000 (20:53 +0000)]
Give more human friendly error message when builders fail to load or have stale data.
https://bugs.webkit.org/show_bug.cgi?id=83058
Reviewed by Eric Seidel.
* TestResultServer/static-dashboards/dashboard_base.js:
(addError):
(addBuilderLoadErrors):
(handleLocationChange):
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Tue, 3 Apr 2012 20:50:45 +0000 (20:50 +0000)]
Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734
Unreviewed test expectation updates
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 3 Apr 2012 20:40:36 +0000 (20:40 +0000)]
Frequent crashes in JSC::parse in a worker thread when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=82660
Reviewed by Geoffrey Garen.
Source/WebCore:
Initialize m_script to empty string. Therefore if there isn't any script payload,
the worker thread will see an empty string, not a null string.
Re-enabling fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html tests as part of this patch.
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):
LayoutTests:
Re-enable fast/workers/empty-worker-nocrash.html and
fast/workers/shared-worker-constructor.html with corresponding fix.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 20:36:32 +0000 (20:36 +0000)]
[chromium] Enable sparkline FPS counter in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82959
Patch by James Robinson <jamesr@chromium.org> on 2012-04-03
Reviewed by Adrienne Walker.
This enables rendering the FPS counter sparkline when in threaded compositing mode. We don't currently have a
way to draw text from the thread (since we can't interact with WebCore::Font objects from a non-main thread),
but having a sparkline is still useful for judging framerate stability.
There are no tests for the HUD since it's a developer-facing feature and not user-facing.
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(CCHeadsUpDisplay):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 20:32:40 +0000 (20:32 +0000)]
Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
* BuildSlaveSupport/built-product-archive:
(extractBuiltProduct):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Tue, 3 Apr 2012 20:16:05 +0000 (20:16 +0000)]
[chromium] Fix incorrect comment in CCDamageTrackerTest
https://bugs.webkit.org/show_bug.cgi?id=82118
Reviewed by Adrienne Walker.
* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 20:15:00 +0000 (20:15 +0000)]
Yet another build fix after r113067. Don't trigger Chromium testers right away
since they're now triggered by builders.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 3 Apr 2012 20:14:18 +0000 (20:14 +0000)]
CSS 2.1 failure: at-import-009.htm fails
https://bugs.webkit.org/show_bug.cgi?id=82921
Source/WebCore:
Reviewed by Antti Koivisto.
This fixes at-import-009.htm only, the other tests already passed.
Tests: css2.1/
20110323/at-import-001.htm
css2.1/
20110323/at-import-002.htm
css2.1/
20110323/at-import-003.htm
css2.1/
20110323/at-import-004.htm
css2.1/
20110323/at-import-005.htm
css2.1/
20110323/at-import-006.htm
css2.1/
20110323/at-import-007.htm
css2.1/
20110323/at-import-009.htm
css2.1/
20110323/at-import-010.htm
css2.1/
20110323/at-import-011.htm
* css/CSSGrammar.y: ignore empty '@media;' and '@charset;' declarations
LayoutTests:
Add the at-import-* tests from the CSS 2.1 suite. Skip at-import-008.htm
as it relies on a print media type to work.
Reviewed by Antti Koivisto.
* css2.1/
20110323/at-import-001-expected.html: Added.
* css2.1/
20110323/at-import-001.htm: Added.
* css2.1/
20110323/at-import-002-expected.html: Added.
* css2.1/
20110323/at-import-002.htm: Added.
* css2.1/
20110323/at-import-003-expected.html: Added.
* css2.1/
20110323/at-import-003.htm: Added.
* css2.1/
20110323/at-import-004-expected.html: Added.
* css2.1/
20110323/at-import-004.htm: Added.
* css2.1/
20110323/at-import-005-expected.html: Added.
* css2.1/
20110323/at-import-005.htm: Added.
* css2.1/
20110323/at-import-006-expected.html: Added.
* css2.1/
20110323/at-import-006.htm: Added.
* css2.1/
20110323/at-import-007-expected.html: Added.
* css2.1/
20110323/at-import-007.htm: Added.
* css2.1/
20110323/at-import-009-expected.html: Added.
* css2.1/
20110323/at-import-009.htm: Added.
* css2.1/
20110323/at-import-010-expected.html: Added.
* css2.1/
20110323/at-import-010.htm: Added.
* css2.1/
20110323/at-import-011-expected.html: Added.
* css2.1/
20110323/at-import-011.htm: Added.
* css2.1/
20110323/support/at-import-001.css: Added.
* css2.1/
20110323/support/at-import-002.css: Added.
* css2.1/
20110323/support/at-import-004.css: Added.
* css2.1/
20110323/support/at-import-005.css: Added.
* css2.1/
20110323/support/at-import-006.css: Added.
* css2.1/
20110323/support/at-import-007.css: Added.
* css2.1/
20110323/support/import-green.css: Added.
* css2.1/
20110323/support/import-red.css: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 20:05:06 +0000 (20:05 +0000)]
Another build fix after r113067 for Mac port.
It turned out that archiving the entire build directory doesn't work.
* BuildSlaveSupport/built-product-archive:
(createZipManually):
(createZip):
(archiveBuiltProduct):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 20:02:29 +0000 (20:02 +0000)]
[BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
https://bugs.webkit.org/show_bug.cgi?id=82643
Source/WebKit/blackberry:
Enhance BlackBerry::WebKit::WebPage::findNextString()
This patch adds support for toggling case sensitivity,
search wrapping, and whether or not to highlight all matches
in addition to the next found match.
I refactored and renamed the new setActiveMatchAndMarker() method
to move the active match from one range to another. This was
required because in the case of a non wrapped search we do not
want to adjust the m_activeMatch if another match is not found.
Internal Review by Andy Chen.
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::findNextString):
* Api/WebPage.h:
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
* WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):
Tools:
Update LayoutTestController to accomodate the new find API.
It now provides caseSensitive functionality to DRT.
Internal Review by Andy Chen.
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::findString):
LayoutTests:
Update findString-markers to also test caseSensitive.
All findString tests used to be case insensitive before.
Internal Review by Andy Chen.
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-03
Reviewed by Rob Buis.
* platform/blackberry/editing/text-iterator/findString-markers-expected.txt:
* platform/blackberry/editing/text-iterator/findString-markers.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 19:31:38 +0000 (19:31 +0000)]
Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
because download-built-product creates the build directory as needed.
This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestFactory.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 19:26:56 +0000 (19:26 +0000)]
Build fix after r113067. Don't delete the build directory.
* BuildSlaveSupport/built-product-archive:
(extractBuiltProduct):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Tue, 3 Apr 2012 19:24:31 +0000 (19:24 +0000)]
[chromium] remove dead function declarations in RenderSurfacechromium
https://bugs.webkit.org/show_bug.cgi?id=82086
Reviewed by James Robinson.
No tests needed, no change in behavior.
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 3 Apr 2012 19:21:09 +0000 (19:21 +0000)]
Update fast/regions expectations to match what's happening on
the chromium bots.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 3 Apr 2012 19:08:48 +0000 (19:08 +0000)]
Load all builder lists from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=82998
Reviewed by Adam Barth.
Also, remove an unnecessary list of test types. Now we don't hard-code
builder names anywhere and we only have a single hard-coded list of
test types.
* TestResultServer/static-dashboards/builders.js:
(BuilderMaster.prototype.logPath):
(BuilderMaster.prototype.builderJsonPath):
(requestBuilderList.xhr.onload):
(requestBuilderList.xhr.onerror):
(isChromiumDepsFyiGpuTestRunner):
(isChromiumTipOfTreeGpuTestRunner):
(isChromiumDepsGTestRunner):
(isChromiumDepsCrosGTestRunner):
(isChromiumTipOfTreeGTestRunner):
(onBuilderListLoad):
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(parseCrossDashboardParameters):
(currentBuilderGroupCategory):
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testHtmlForTestsWithExpectationsButNoFailures):
(testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
(testGenerateChromiumDepsGTestBuildersFromBuilderList):
(testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
(testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
* TestResultServer/static-dashboards/timeline_explorer.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 18:58:21 +0000 (18:58 +0000)]
Chromium testers should extract builds instead of building on their own
https://bugs.webkit.org/show_bug.cgi?id=82996
Reviewed by Tony Chang.
Make Chromium builders triggger Chromium testers and make testers download and extract builds
from the buildbot master instead of building binaries on their own.
Add download-built-product to wrap curl used in the download-built-product step since Windows
does not provide "curl" natively.
* BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(DownloadBuiltProduct): Call download-built-product instead of curl.
* BuildSlaveSupport/built-product-archive:
(createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
(archiveBuiltProduct): Zip the configuration build directory on Mac port.
(unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
(extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
* BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 3 Apr 2012 18:54:54 +0000 (18:54 +0000)]
[GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
https://bugs.webkit.org/show_bug.cgi?id=82473
Reviewed by Philippe Normand.
Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
was ever run.
* gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 3 Apr 2012 18:26:34 +0000 (18:26 +0000)]
Another attempt to fix the Windows build. This uses WebSecurityOrigin
has a value type but doesn't include the header.
* public/WebUserMediaRequest.h:
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 3 Apr 2012 18:09:13 +0000 (18:09 +0000)]
Attempt to fix the Windows component build by including these headers
rather than forward declaring these objects.
* chromium/public/WebMediaStreamSourcesRequest.h:
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 3 Apr 2012 17:57:06 +0000 (17:57 +0000)]
Not reviewed. Follow up to inspector's r113032: change provisional method signature a bit.
* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::save):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpu@apple.com [Tue, 3 Apr 2012 17:42:45 +0000 (17:42 +0000)]
Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=82946
Reviewed by Enrica Casucci.
On OS X, we draw similar underline on dictated text that has alternative text. We rename
this function, so that we can reuse it for dictation underline.
No new tests, since there's no change of functionality.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
* rendering/InlineTextBox.cpp:
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Tue, 3 Apr 2012 17:39:13 +0000 (17:39 +0000)]
Layout Test media/video-src-source.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82227
De-race the test by registering the listener before the event can fire.
Reviewed by Eric Carlson.
* media/video-src-source.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Tue, 3 Apr 2012 17:34:05 +0000 (17:34 +0000)]
[Chromium] media/video-delay-load-event.html is flaky on all platforms
https://bugs.webkit.org/show_bug.cgi?id=64003
Explicitly request a .load() on the <video> element before expecting changes to its <source>
to be reflected, per the note in section 4.8.8 of the spec saying:
Dynamically modifying a source element [...] when the element is already
inserted [...] will have no effect. To change what is playing [...] call
the load() method on the media element [...]
Reviewed by Eric Carlson.
* media/video-delay-load-event.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 3 Apr 2012 17:33:50 +0000 (17:33 +0000)]
ESC key in full screen does not result in webkitFullScreenChange event.
https://bugs.webkit.org/show_bug.cgi?id=82755
<rdar://problem/
11093513>
Reviewed by Eric Carlson.
Source/WebCore:
* WebCore.exp.in: Export the WebCore::Document::webkitCancelFullScreen() symbol.
Source/WebKit/mac:
Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
out correctly.
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController cancelOperation:]):
(-[WebFullScreenController requestExitFullScreen]):
Source/WebKit2:
Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
out correctly.
Because the WebProcess may be stalled or hung, add a watchdog timer which will force an exit of full
screen if the WebProcess does not respond in a timely manner (defaults to 1s).
Add a new method, requestExitFullScreen, which calls through to the WebProcess and Document:
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):
* UIProcess/WebFullScreenManagerProxy.h:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::requestExitFullScreen):
* WebProcess/FullScreen/WebFullScreenManager.h:
* WebProcess/FullScreen/WebFullScreenManager.messages.in:
Request that the document exits full screen when the ESC key is pressed:
* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController cancelOperation:]):
(-[WKFullScreenWindowController exitFullScreen]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 3 Apr 2012 17:31:59 +0000 (17:31 +0000)]
Unreviewed, skip 2 flaky crash inspector tests on GTK.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Tue, 3 Apr 2012 17:21:24 +0000 (17:21 +0000)]
Expectations update after 82734
https://bugs.webkit.org/show_bug.cgi?id=82734
Unreviewed expectations update.
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 17:14:36 +0000 (17:14 +0000)]
[EFL] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=82050
Source/WebKit/efl:
Add a setting setInteractiveFormValidationEnabled to EFL's
DumpRenderTreeSupport.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Enable interactive form validation and unskip tests from the
skip list.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
LayoutTests:
Unskip interactive form validation tests.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-03
Reviewed by Antonio Gomes.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 3 Apr 2012 16:52:28 +0000 (16:52 +0000)]
REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue
https://bugs.webkit.org/show_bug.cgi?id=83000
Reviewed by Andreas Kling.
Source/WebCore:
Fixed the crash by exiting early in StylePropertySet::borderSpacingValue when
the vertical value is set.
Test: fast/css/border-spacing-without-vertical-value.html
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::borderSpacingValue):
LayoutTests:
Add a regression for obtaining the value of border-spacing without specifying
-webkit-horizontal-vertical.
* fast/css/border-spacing-without-vertical-value-expected.txt: Added.
* fast/css/border-spacing-without-vertical-value.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 16:49:09 +0000 (16:49 +0000)]
[Chromium] Add click count and modifiers to the factory method of mouse event.
https://bugs.webkit.org/show_bug.cgi?id=82502
Modify WebInputEventFactory::mouseEvent() to take click count
and modifiers from input parameters. Sample use cases of these
are double click, triple click, Ctrl+click, etc.
Patch by Bolin Hsu <bhsu@google.com> on 2012-04-03
Reviewed by Eric Seidel.
* public/android/WebInputEventFactory.h:
* src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::mouseEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 3 Apr 2012 16:41:05 +0000 (16:41 +0000)]
LayoutTests/.gitattributes cleanup
https://bugs.webkit.org/show_bug.cgi?id=82975
Reviewed by Hajime Morita.
* .gitattributes: Set svn:mime-type for .gif files and remove files
that no longer exist.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 3 Apr 2012 16:23:49 +0000 (16:23 +0000)]
Unreviewed ASSERT fix on Chromium bots (in debug).
It appears that http://trac.webkit.org/changeset/113031 caused ASSERT in CSSParser::parseFillProperty.
I added the ASSERT to fix the compilation about values not handled in the switch. I supposed the callers
were only property ids handled in the switch case. It wasn't the case, so I'm restoring the old behavior
while keeping the code to compile (it still need a deeper investigation but let fix the bots quickly).
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 3 Apr 2012 16:00:48 +0000 (16:00 +0000)]
Unreviewed, another test-webkitpy fix-up after r113037.
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
crash dump depending on current environment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Tue, 3 Apr 2012 15:55:10 +0000 (15:55 +0000)]
Expectations update after 65072
https://bugs.webkit.org/show_bug.cgi?id=65072
Unreviewed Chromium expectations update.
* platform/chromium-linux/svg/text/ems-display-none-expected.png: Added.
* platform/chromium-linux/svg/text/exs-display-none-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/ems-display-none-expected.txt: Added.
* platform/chromium-mac/svg/text/ems-display-none-expected.png: Added.
* platform/chromium-mac/svg/text/exs-display-none-expected.png: Added.
* platform/chromium-win/svg/text/ems-display-none-expected.png: Added.
* platform/chromium-win/svg/text/ems-display-none-expected.txt: Added.
* platform/chromium-win/svg/text/exs-display-none-expected.png: Added.
* platform/chromium-win/svg/text/exs-display-none-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 3 Apr 2012 15:46:20 +0000 (15:46 +0000)]
[Part 3] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83032
Reviewed by Kentaro Hara.
CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.
No new tests : There should be no behavior change in this patch.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore::cssPropertyInfo):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::counterToCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive):
Remove the parameter's name from the h file as it doesn't follow the style and also because the
name was simply wrong we don't expect a propId here but an indentifier. Make it clear in the
cpp file too.
* css/CSSParser.h:
(CSSParser):
* page/animation/AnimationBase.cpp:
(WebCore::addPropertyWrapper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 3 Apr 2012 15:45:02 +0000 (15:45 +0000)]
[Qt][WK2] ASSERT(!(outputBytes.size() % sizeof(UChar))) in PluginProcessProxyQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=83034
Reviewed by Zoltan Herczeg.
Don't allow the plugin to pollute the standard output.
Reinvent StdOutDevNullRedirector which was removed in
r112889 for this purpose.
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::NetscapePluginModule::scanPlugin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 3 Apr 2012 15:37:16 +0000 (15:37 +0000)]
Unreviewed, test-webkitpy build fix after r113037.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_crash_log):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 3 Apr 2012 15:33:43 +0000 (15:33 +0000)]
Web Inspector: remove unused references to TimelineCalculator
https://bugs.webkit.org/show_bug.cgi?id=83025
Reviewed by Yury Semikhatsky.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._showPopover):
(WebInspector.TimelineRecordListRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Tue, 3 Apr 2012 15:33:27 +0000 (15:33 +0000)]
Integrate IETC CSS : borders and backgrounds tests
https://bugs.webkit.org/show_bug.cgi?id=82734
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-03
Reviewed by Adam Barth.
Adding 57 pixel tests for IETC backgrounds and borders. Modified chromium
tests expectations, will pull the MISSING FAIL lines when we get good
expected results from the bots. Also renaming 'ahem.ttf' to 'Ahem.ttf' to deal with
case-insensitive filesystem issue.
* ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-color-border-box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-size-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_color_padding_box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_position_three_four_values.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-clip-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-style-005.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-001.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-002.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-003.htm: Added.
* ietestcenter/css3/bordersbackgrounds/box-shadow-004.htm: Added.
* ietestcenter/css3/bordersbackgrounds/color-behind-images.htm: Added.
* ietestcenter/css3/bordersbackgrounds/none-as-image-layer.htm: Added.
* ietestcenter/css3/bordersbackgrounds/order-of-images.htm: Added.
* ietestcenter/css3/support/Ahem.ttf: Renamed from LayoutTests/ietestcenter/css3/support/ahem.ttf.
* ietestcenter/css3/support/orange_color.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 3 Apr 2012 15:23:06 +0000 (15:23 +0000)]
[GTK] crash log reports support
https://bugs.webkit.org/show_bug.cgi?id=81659
Reviewed by Martin Robinson.
Removed the daemontools crashmon/xvfb scripts and implemented the crash
log reporting in the NRWT Gtk port. To get proper crash logs one
needs to set the core pattern like this:
echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
environment variable.
* BuildSlaveSupport/gtk/README:
* BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
* BuildSlaveSupport/gtk/crashmon/log/run: Removed.
* BuildSlaveSupport/gtk/crashmon/run: Removed.
* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
* BuildSlaveSupport/gtk/xvfb/log/run: Removed.
* BuildSlaveSupport/gtk/xvfb/run: Removed.
* Scripts/new-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver.stop):
(GtkPort.show_results_html_file):
(GtkPort):
(GtkPort._get_gdb_output):
(GtkPort._get_crash_log):
(GtkPort._get_crash_log.match_filename):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest):
(test_show_results_html_file):
(assertLinesEqual):
(_mock_gdb_output):
(test_get_crash_log):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Tue, 3 Apr 2012 15:22:02 +0000 (15:22 +0000)]
More unreviewed mac rebaselines
https://bugs.webkit.org/show_bug.cgi?id=79568
Unreviewed test expectations update.
Patch by Philip Rogers <pdr@google.com> on 2012-04-03
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/text/text-text-05-t-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 3 Apr 2012 15:16:14 +0000 (15:16 +0000)]
[GTK] svg/zoom/page/zoom-svg-through-object-with-auto-size.html is flaky on 32-bits Release
https://bugs.webkit.org/show_bug.cgi?id=68523
Unreviewed, unskip tests passing locally, they aren't flaky
anymore, from the test runs I performed locally.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 15:03:29 +0000 (15:03 +0000)]
Call incrementStatsCounter directly
https://bugs.webkit.org/show_bug.cgi?id=83023
Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-04-03
Reviewed by Kentaro Hara.
Source/WebCore:
* bindings/v8/V8Proxy.h:
* platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
* src/PlatformSupport.cpp:
(WebCore):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::WebFrameImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 14:48:33 +0000 (14:48 +0000)]
[chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying
https://bugs.webkit.org/show_bug.cgi?id=83013
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-03
Reviewed by Stephen White.
Source/WebCore:
We need to flush the GPU command queue after copying the canvas back
buffer into the front buffer. Otherwise the copy might be delayed to a
point where new contents have already been drawn into the back buffer,
leading to flickering.
Added test to Canvas2DLayerChromiumTest.
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
Source/WebKit/chromium:
* tests/Canvas2DLayerChromiumTest.cpp: Make sure context is flushed after copying.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 3 Apr 2012 14:29:32 +0000 (14:29 +0000)]
Web Inspector: [chromium] add provisional save method into the frontend client.
https://bugs.webkit.org/show_bug.cgi?id=83022
Reviewed by Yury Semikhatsky.
* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::save):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 3 Apr 2012 14:18:19 +0000 (14:18 +0000)]
[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=82977
Reviewed by Andreas Kling.
Source/WebCore:
CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. Almost everything has been changed with the exception of the Animation related
classes which can be done in a following patch.
No new tests : There should be no behavior change in this patch.
* WebCore.exp.in:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::cssText):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::logUnimplementedPropertyID):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
(WebCore::CSSComputedStyleDeclaration::item):
* css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::isColorPropertyID):
(WebCore::parseColorValue):
(WebCore::isSimpleLengthPropertyID):
(WebCore::parseSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSize):
(WebCore::CSSParser::parseQuotes):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseClipShape):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):
* css/CSSParser.h:
(CSSParser):
(WebCore::ShorthandScope::ShorthandScope):
* css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
(CSSProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyCSSValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
* css/StylePropertySet.h:
(StylePropertySet):
* css/StylePropertyShorthand.cpp:
(WebCore::shorthandForProperty):
* css/StylePropertyShorthand.h:
(WebCore):
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::addPropertyToAttributeStyle):
* editing/EditingStyle.cpp:
(HTMLElementEquivalent):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::setProperty):
* editing/EditingStyle.h:
(WebCore::EditingStyle::create):
(EditingStyle):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::selectionHasStyle):
* editing/Editor.h:
(Editor):
* editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeToggleStyle):
(WebCore::executeApplyParagraphStyle):
(WebCore::stateStyle):
* editing/markup.cpp:
(WebCore):
(WebCore::propertyMissingOrEqualToNone):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):
* html/HTMLElement.h:
(HTMLElement):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):
* svg/SVGFontFaceElement.cpp:
(WebCore::cssPropertyIdForSVGAttributeName):
(WebCore::SVGFontFaceElement::parseAttribute):
* svg/SVGStyledElement.cpp:
(WebCore::mapAttributeToCSSProperty):
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::SVGStyledElement::collectStyleForAttribute):
(WebCore::SVGStyledElement::svgAttributeChanged):
(WebCore::SVGStyledElement::getPresentationAttribute):
* svg/SVGStyledElement.h:
(WebCore):
(SVGStyledElement):
Source/WebKit/qt:
Update the code to use CSSPropertyID rather than an integer.
* Api/qwebelement.cpp:
(QWebElement::setStyleProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 3 Apr 2012 13:55:52 +0000 (13:55 +0000)]
Revert RenderTheme paint and layout functions to ints
https://bugs.webkit.org/show_bug.cgi?id=82196
Reviewed by Julien Chaffraix.
When dealing with object that are rendered outside of WebCore, we do all necessary pixel snapping
before passing coordinates to the external code. RenderTheme encompasses a set of objects whose
rendering is influenced by the platform. This change reverts the interface between this platform
code and WebCore to be integers.
Some platforms, such as Mac, use sub-pixel units for layout and rendering, but it's still not
desirable to pass sub-pixel values to these API's, because ultimately we'll render these objects
at whole-pixel values to avoid anti-aliasing.
Marking touched overridden virtual functions as OVERRIDE. There are many more to update.
No new tests. No change in behavior.
* platform/graphics/FractionalLayoutRect.h:
(WebCore::FractionalLayoutRect::pixelSnappedLocation): Convenience function.
(WebCore::FractionalLayoutRect::pixelSnappedSize): Ditto.
(FractionalLayoutRect):
* platform/graphics/IntRect.h:
(WebCore::IntRect::pixelSnappedLocation): Temporary mirrors to the functions of the same name on
FractionalLayoutRect.
(WebCore::IntRect::pixelSnappedSize): Ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Adding a local pixel snapped paint rect to avoid
repeated pixel snapping.
* rendering/RenderBox.h:
(WebCore::RenderBox::absoluteContentBox): Reverting to integers since this represents on-screen
coordinates
(WebCore::RenderBox::pixelSnappedSize): Convenience method.
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): This static function is only called
from RenderTheme platform code. Changing it to operate on pixel snapped values since we don't want
to pipe LayoutUnits through that code.
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::computeLogicalWidth): Changing to feed pixel snapped values into the platform
code to properly determine the resulting meter size.
(WebCore::RenderMeter::computeLogicalHeight): Ditto.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::meterSizeForBounds):
* rendering/RenderTheme.h:
(RenderTheme):
(WebCore::RenderTheme::paintCapsLockIndicator):
* rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::convertToPaintingRect):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
* rendering/RenderThemeChromiumSkia.h:
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton):
* rendering/RenderThemeWin.h:
(RenderThemeWin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 13:39:59 +0000 (13:39 +0000)]
chromium: fast/dom/error-to-string-stack-overflow.html is failing after v8 roll to 3.10.0.2
https://bugs.webkit.org/show_bug.cgi?id=82993
Adjust test expectation to include the line number of the exception.
Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-04-03
Reviewed by Kentaro Hara.
* platform/chromium-linux/fast/dom/error-to-string-stack-overflow-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:24:56 +0000 (13:24 +0000)]
Enable and connect the WebInspectorServer with WebKit2 pages.
https://bugs.webkit.org/show_bug.cgi?id=73094
Reviewed by Simon Hausmann.
Source/WebKit2:
Pages are registered/unregistered as they are created/destroyed, if they have
developer extras enabled. The server is run on the UI process and communicates
with the web process through IPC for each message between the inspector
controller and the remote frontend.
Includes the server spawning logic for the Qt port, the server is
started through an environment variable specifying the interface and
port to bind the server to, by default on 127.0.0.1.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit):
(WebKit::WebInspectorProxy::enableRemoteInspection):
(WebKit::WebInspectorProxy::remoteFrontendConnected):
(WebKit::WebInspectorProxy::remoteFrontendDisconnected):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::sendMessageToRemoteFrontend):
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
* UIProcess/WebInspectorProxy.messages.in:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::preferencesDidChange):
* UIProcess/qt/QtWebContext.cpp:
(WebKit::initInspectorServer):
(WebKit):
(WebKit::globalInitialization):
(WebKit::QtWebContext::create):
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::sendMessageToFrontend):
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::WebInspector):
(WebKit):
(WebKit::WebInspector::sendMessageToRemoteFrontend):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):
* WebProcess/WebPage/WebInspector.h:
(WebInspector):
(WebKit::WebInspector::hasRemoteFrontendConnected):
* WebProcess/WebPage/WebInspector.messages.in:
Tools:
Enable developer extras on pages in MiniBrowser for Qt.
* MiniBrowser/qt/qml/BrowserWindow.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:24:32 +0000 (13:24 +0000)]
WebInspectorServer for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=73855
Reviewed by Simon Hausmann.
The server uses WebSocket for communication with the remote client and
normal HTTP requests are handled to optionally send the frontend on the
wire. Those decision are handled per platform and Qt currently maps:
- "/" to a static listing page.
- "/pagelist.json" to the page list for the listing page or tools.
- anything else, for example "/inspector.js" to the file with the
same name in the dynamic libraries built resources.
Invalid files should return a 404.
* Target.pri:
* UIProcess/InspectorServer/WebInspectorServer.cpp: Added.
(WebKit):
(WebKit::pageIdFromRequestPath):
(WebKit::WebInspectorServer::server):
(WebKit::WebInspectorServer::WebInspectorServer):
(WebKit::WebInspectorServer::~WebInspectorServer):
(WebKit::WebInspectorServer::registerPage):
(WebKit::WebInspectorServer::unregisterPage):
(WebKit::WebInspectorServer::sendMessageOverConnection):
(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebInspectorServer::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebInspectorServer::didEstablishWebSocketConnection):
(WebKit::WebInspectorServer::didReceiveWebSocketMessage):
(WebKit::WebInspectorServer::didCloseWebSocketConnection):
(WebKit::WebInspectorServer::closeConnection):
* UIProcess/InspectorServer/WebInspectorServer.h: Added.
(WebKit):
(WebInspectorServer):
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Added.
(WebKit):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):
* WebKit2.qrc: Added.
* qt/Resources/inspectorPageIndex.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:24:11 +0000 (13:24 +0000)]
Add a Generic WebSocket Server.
https://bugs.webkit.org/show_bug.cgi?id=73093
Reviewed by Simon Hausmann.
Source/WebCore:
Allow SocketStreamHandle for the Qt port to take an existing QTcpSocket in its constructor.
* platform/network/qt/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
(SocketStreamHandle):
* platform/network/qt/SocketStreamHandlePrivate.h:
(SocketStreamHandlePrivate):
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore):
(WebCore::SocketStreamHandlePrivate::initConnections):
(WebCore::SocketStreamHandlePrivate::close):
(WebCore::SocketStreamHandle::SocketStreamHandle):
Source/WebKit2:
The Inspector Server will be a WebSocket Server that also responds to
non-WebSocket-Upgrade HTTP Requests. This is a generic WebSocket server
that passes on what it doesn't know on to its client for extended
functionality. This code is wrapped in a new ENABLE(INSPECTOR_SERVER) flag.
There are no tests yet for a built-in WebSocket server.
This will be covered by API level tests in a later patch.
* Target.pri:
WebSocketServer is a simple server. Calling listen, or close,
multiple times is safe. Subclassing is expected.
* UIProcess/InspectorServer/WebSocketServer.cpp: Added.
(WebKit):
(WebKit::WebSocketServer::WebSocketServer):
(WebKit::WebSocketServer::~WebSocketServer):
(WebKit::WebSocketServer::listen):
(WebKit::WebSocketServer::close):
(WebKit::WebSocketServer::didAcceptConnection):
(WebKit::WebSocketServer::didCloseWebSocketServerConnection):
* UIProcess/InspectorServer/WebSocketServer.h: Added.
(WebKit):
(WebCore):
(WebSocketServer):
* UIProcess/InspectorServer/WebSocketServerClient.h: Added.
(WebCore):
(WebKit):
(WebSocketServerClient):
(WebKit::WebSocketServerClient::~WebSocketServerClient):
(WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebSocketServerClient::didEstablishWebSocketConnection):
(WebKit::WebSocketServerClient::didReceiveWebSocketMessage):
(WebKit::WebSocketServerClient::didCloseWebSocketConnection):
Each WebSocketConnection:
- Passes unknown HTTP Requests to the server's client.
- Handles WebSocket Upgrade Requests.
- First ask the client if it is okay.
- Later notify the client about a success.
- Once upgraded the connection parses and passes WebSocket
frames to the client.
* UIProcess/InspectorServer/WebSocketServerConnection.cpp: Added.
(WebKit):
(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::~WebSocketServerConnection):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::shutdownAfterSendOrNow): meant to shutdown after an HTTP response. Ensure all platforms work as expected.
(WebKit::WebSocketServerConnection::sendWebSocketMessage): send a text message (WebSocket message) over the connection.
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData): send raw data (HTTP message) over the connection.
(WebKit::WebSocketServerConnection::didCloseSocketStream): handle socket closing scenarios.
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData): parse the incoming data in HTTP / WebSocket modes.
(WebKit::WebSocketServerConnection::didFailSocketStream): log errors.
(WebKit::WebSocketServerConnection::readHTTPMessage): when starting, a web socket connection reads an HTTP message.
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):
(WebKit::WebSocketServerConnection::readWebSocketFrames): parse our buffer for as many frames as possible.
(WebKit::WebSocketServerConnection::readWebSocketFrame): parse an individual frame.
* UIProcess/InspectorServer/WebSocketServerConnection.h: Added.
(WebCore):
(WebKit):
(WebSocketServerConnection):
(WebKit::WebSocketServerConnection::identifier):
(WebKit::WebSocketServerConnection::setIdentifier):
Qt specific implementation.
* UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Added.
(WebKit):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):
(WebKit::QtTcpServerHandler::QtTcpServerHandler):
(WebKit::QtTcpServerHandler::handleNewConnection):
(WebKit::QtTcpServerHandler::listen):
(WebKit::QtTcpServerHandler::close):
* UIProcess/InspectorServer/qt/WebSocketServerQt.h: Added.
(WebKit):
(QtTcpServerHandler):
* WebKit2.pri:
* config.h: Add ENABLE(INSPECTOR_SERVER) for WebKit2.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:23:46 +0000 (13:23 +0000)]
Expose reusable WebSocket code for WebSocketServer.
https://bugs.webkit.org/show_bug.cgi?id=73852
Reviewed by Kent Tamura.
Keep the majority the web socket handshake HTTP request and response logic
inside WebSocketHandshake and expose it through WebSocketFrame to make it
available for the web socket server implementation.
This also re-add the masking code that was removed in r111829 since it is
needed for the server implementation.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/websockets/WebSocketChannel.cpp:
(WebCore):
(WebCore::WebSocketChannel::processFrame): now using WebSocketChannel::parseFrame. Extracted the !frame.masked check.
(WebCore::WebSocketChannel::sendFrame):
* Modules/websockets/WebSocketChannel.h:
(WebSocketChannel):
* Modules/websockets/WebSocketFrame.cpp: Added.
(WebCore):
(WebCore::WebSocketFrame::needsExtendedLengthField):
(WebCore::WebSocketFrame::parseFrame): moved from WebSocketChannel::parseFrame.
(WebCore::appendMaskedFramePayload):
(WebCore::WebSocketFrame::makeFrameData): moved from makeFrameData in WebSocketChannel.cpp.
(WebCore::WebSocketFrame::WebSocketFrame): moved from the header.
* Modules/websockets/WebSocketFrame.h:
(WebSocketFrame):
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept): expose this object-static function.
* Modules/websockets/WebSocketHandshake.h:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:23:23 +0000 (13:23 +0000)]
Add Generic HTTP Request Class. Generalized HTTP Parsing.
https://bugs.webkit.org/show_bug.cgi?id=73092
Reviewed by Simon Hausmann.
A WebSocket server will need to read HTTP Requests before upgrading
to WebSocket framing. This patch creates a cross-platform HTTPRequest
class. Since some of this was already done in WebSocket code:
- the header parsing code was extracted and put into HTTPParsers.cpp
- WebSocketHandshakeRequest subclasses HTTPRequest
- WebSocket code was refactored for these changes
Refactoring is covered by existing http/tests/websocket tests.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpenSocketStream):
Extract the HTTP Header parsing out of WebSocketHandshake and
put it into HTTP Parsers. Now make use of the generic parsing.
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore):
(WebCore::trimInputSample):
(WebCore::WebSocketHandshake::clientHandshakeRequest): switch to RefCounted HandshakeRequest.
(WebCore::WebSocketHandshake::readStatusLine):
(WebCore::WebSocketHandshake::readHTTPHeaders): use generic HTTPParsers parsing.
* Modules/websockets/WebSocketHandshake.h: switch to RefCounted HandshakeRequest.
WebSocketHandshakeRequest is a specialization of an HTTPRequest.
Much of its original code was abstracted into HTTPRequest, and
this is now a subclass with WebSocket key information.
* Modules/websockets/WebSocketHandshakeRequest.cpp:
(WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): initialize now calls super.
* Modules/websockets/WebSocketHandshakeRequest.h:
(WebCore::WebSocketHandshakeRequest::create): switch to being ref counted like HTTPRequest.
(WebSocketHandshakeRequest):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add generic HTTP Request parsing functions to HTTPParsers.cpp.
Use out parameters to get values after parsing.
* platform/network/HTTPParsers.cpp:
(WebCore):
(WebCore::trimInputSample): taken from WebSocket parsing.
(WebCore::parseHTTPRequestLine): new code, parse a request line.
(WebCore::parseHTTPHeaders): taken from previous WebSocket parsing. Algorithm unchanged.
(WebCore::parseHTTPRequestBody): new code, just copy the date into the provided buffer.
* platform/network/HTTPParsers.h:
(WebCore):
This adds a general HTTPRequest class. Accessors for the
request method, url, httpVersion, headers, and data. You can
create an HTTPRequest using the constructor, or parse one
from a data buffer, such as one read from a socket.
* platform/network/HTTPRequest.cpp: Added.
(WebCore):
(WebCore::HTTPRequest::parseHTTPRequestFromBuffer): create an HTTPRequest by parsing data in a buffer.
(WebCore::HTTPRequest::parseRequestLine): helper to initialize members while parsing.
(WebCore::HTTPRequest::parseHeaders): helper to initialize members while parsing.
(WebCore::HTTPRequest::parseRequestBody): helper to initialize members while parsing.
(WebCore::HTTPRequest::HTTPRequest):
(WebCore::HTTPRequest::~HTTPRequest):
* platform/network/HTTPRequest.h: Added.
(WebCore):
(HTTPRequest):
(WebCore::HTTPRequest::create): create an empty request, or specify details.
(WebCore::HTTPRequest::requestMethod):
(WebCore::HTTPRequest::setRequestMethod):
(WebCore::HTTPRequest::url):
(WebCore::HTTPRequest::setURL):
(WebCore::HTTPRequest::body):
(WebCore::HTTPRequest::headerFields):
(WebCore::HTTPRequest::addHeaderField):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:22:57 +0000 (13:22 +0000)]
[Qt] Add a missing inspector front-end image to resources.
Reviewed by Simon Hausmann.
* inspector/front-end/WebKit.qrc:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Tue, 3 Apr 2012 13:22:41 +0000 (13:22 +0000)]
[Qt] Add developerExtrasEnabled to QWebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=83018
Reviewed by Kenneth Rohde Christiansen.
This is required to allow inspecting pages.
* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::developerExtrasEnabled):
(QWebPreferences::setDeveloperExtrasEnabled):
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/API/qt/qwebpreferences_p_p.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 3 Apr 2012 13:13:14 +0000 (13:13 +0000)]
[Qt][WK2] All plugin tests are failing on buildbot
https://bugs.webkit.org/show_bug.cgi?id=83024
Unreviewed gardening. Skip plugin tests until fix.
* platform/qt-5.0-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 13:06:54 +0000 (13:06 +0000)]
Gtk fails media/video-source-error.html (due to trailing whitespace?)
https://bugs.webkit.org/show_bug.cgi?id=30198
Patch by Simon Pena <spena@igalia.com> on 2012-04-03
Reviewed by Philippe Normand.
Unskip offending test, since it is now passing without errors.
* platform/gtk/Skipped: Unskip media/video-source-error.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:59:35 +0000 (12:59 +0000)]
Soup HTTP backend does not send Content-Length in certain cases
https://bugs.webkit.org/show_bug.cgi?id=82036
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-03
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Telling soup explicitly when to send content-length header
in POST & PUT cases in order to align with e.g. Chromium and FF.
No new tests, already covered by *methods*.html in
http/tests/xmlhttprequest/.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::startHTTPRequest): Special handling for POST & PUT.
LayoutTests:
Rebaselining and unskipping relevant tests for EFL.
Rebaselining POST and PUT cases for GTK.
* platform/efl/Skipped:
* platform/efl/http/tests/xmlhttprequest/methods-async-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt.
* platform/efl/http/tests/xmlhttprequest/methods-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/methods-expected.txt.
* platform/efl/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt.
* platform/efl/http/tests/xmlhttprequest/workers/methods-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt.
* platform/efl/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt.
* platform/efl/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Copied from LayoutTests/platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt.
* platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/methods-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:
* platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:56:49 +0000 (12:56 +0000)]
[EFL] LayoutTestController needs implementation of setDefersLoading
https://bugs.webkit.org/show_bug.cgi?id=82890
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-03
Reviewed by Philippe Normand.
Source/WebKit/efl:
Implement setDefersLoading() in EFL's LayoutTestController so that the
corresponding test case can be removed from the skip list.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setDefersLoading):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Implement setDefersLoading() in EFL's LayoutTestController so that the
corresponding test case can be removed from the skip list.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDefersLoading):
LayoutTests:
Unskip loader/navigation-while-deferring-loads test in EFL now that
its LayoutTestController implements setDefersLoading().
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 3 Apr 2012 12:16:45 +0000 (12:16 +0000)]
[Chromium] Unreviewed, suppress compositing/reflections/nested-reflection-transformed2.html on Win Debug.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:11:05 +0000 (12:11 +0000)]
Simplify CSSStyleSelector constructor through the use of a helper function
https://bugs.webkit.org/show_bug.cgi?id=82940
Reviewed by Andreas Kling.
No behavior change, thus no tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:11:04 +0000 (12:11 +0000)]
[EFL] LayoutTestController needs implementation of goBack
https://bugs.webkit.org/show_bug.cgi?id=81914
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-03
Reviewed by Philippe Normand.
Tools:
Implement goBack() in EFL's LayoutTestController by calling
ewk_frame_back().
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::goBack):
LayoutTests:
Unskip loader/navigation-while-deferring-loads test in EFL now that
its LayoutTestController supports goBack().
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 3 Apr 2012 12:08:14 +0000 (12:08 +0000)]
[Qt][WK2] Failing http/tests/plugins tests after reenabled plugins
https://bugs.webkit.org/show_bug.cgi?id=82895
Reviewed by Csaba Osztrogonác.
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 3 Apr 2012 12:07:53 +0000 (12:07 +0000)]
Web Inspector: Database::Database::id field in the protocol should have type integer not string
https://bugs.webkit.org/show_bug.cgi?id=83003
Reviewed by Pavel Feldman.
Changed DOM storage and database identifier type from int to String. This
is aligned with other domains and gives us more flexibility.
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::databaseId):
(WebCore::JSInjectedScriptHost::storageId):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::databaseIdImpl):
(WebCore::InjectedScriptHost::storageIdImpl):
* inspector/InjectedScriptHost.h:
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/Inspector.json:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
* inspector/InspectorDOMStorageAgent.h:
(InspectorDOMStorageAgent):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::bind):
* inspector/InspectorDOMStorageResource.h:
(WebCore::InspectorDOMStorageResource::id):
(InspectorDOMStorageResource):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::databaseForId):
* inspector/InspectorDatabaseAgent.h:
(InspectorDatabaseAgent):
* inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
(WebCore::InspectorDatabaseResource::bind):
* inspector/InspectorDatabaseResource.h:
(WebCore::InspectorDatabaseResource::id):
(InspectorDatabaseResource):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:06:20 +0000 (12:06 +0000)]
[Qt] Tap highlight attempted hidden several times
https://bugs.webkit.org/show_bug.cgi?id=82903
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-03
Reviewed by Kenneth Rohde Christiansen.
Do not reset GestureRecognizer if already reset, and do not
disable tap-highlight on touch-end if already reset.
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::reset):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:05:49 +0000 (12:05 +0000)]
[EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=82589
Source/WebKit/efl:
Add missing implementation for pageSizeAndMarginsInPixels to EFL's
DumpRenderTreeSupport.
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-03
Reviewed by Philippe Normand.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
in order to unskip printing/page-format-data.html
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-04-03
Reviewed by Philippe Normand.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::pageSizeAndMarginsInPixels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 12:01:11 +0000 (12:01 +0000)]
[Qt] Tap highlight still showing when tap gesture has timed out
https://bugs.webkit.org/show_bug.cgi?id=82902
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-03
Reviewed by Kenneth Rohde Christiansen.
Disable highlight of potential tap, when tap-and-hold state
replaces potential tap state.
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 3 Apr 2012 11:26:50 +0000 (11:26 +0000)]
2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>
Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459
Rubber-stamped by Zoltan Herczeg.
Make highestEnumValue() return an unsigned to avoid casting in SVGAnimatedEnumerationPropertyTearOff.
Fixes the last chromium build failure on the debug carnary bots.
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEMorphologyElement.h:
* svg/SVGFETurbulenceElement.h:
* svg/SVGGradientElement.h:
* svg/SVGMarkerElement.h:
* svg/SVGTextContentElement.h:
* svg/SVGTextPathElement.h:
* svg/SVGUnitTypes.h:
* svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 3 Apr 2012 10:36:01 +0000 (10:36 +0000)]
Animate animatedPoints instead of points for SVGPoly*Elements
https://bugs.webkit.org/show_bug.cgi?id=82844
Reviewed by Dirk Schulze.
Source/WebCore:
When the points attribute of a SVGPoly*Element is animated, we should animate
the 'animatedPoints' SVG DOM property, not the 'points' property, which corresponds
to the "baseVal". Fix that, now only the 'd' attribute for SVGPathElement is incorrect,
everything else is moved to the new animVal concept!
* svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPointListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPointListAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPointListAnimator::animValWillChange):
(WebCore::SVGAnimatedPointListAnimator::animValDidChange):
* svg/SVGAnimatedPointList.h:
(SVGAnimatedPointListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
(WebCore::SVGPolyElement::points):
(WebCore::SVGPolyElement::animatedPoints):
LayoutTests:
Update SVGPointList animation tests, verifying that animatedPoints is animated, and not points.
* svg/animations/script-tests/svgpointlist-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgpointlist-animation-2.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svgpointlist-animation-1-expected.txt:
* svg/animations/svgpointlist-animation-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 3 Apr 2012 10:27:09 +0000 (10:27 +0000)]
[GTK] media/video-volume.html fails on 32-bits debug
https://bugs.webkit.org/show_bug.cgi?id=50389
Unreviewed, unskip the test, it's passing locally. We'll keep an
eye on the bots.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 3 Apr 2012 10:26:34 +0000 (10:26 +0000)]
2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Next chromium build fix, this time for real :-)
* svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal): Cast highestEnumValue to unsigned.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 3 Apr 2012 10:19:50 +0000 (10:19 +0000)]
2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to fix chromium build.
* svg/properties/SVGAnimatedEnumerationPropertyTearOff.h: Unsigned is always >= 0 - only check if its 0 here.
(WebCore::SVGAnimatedEnumerationPropertyTearOff::setBaseVal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 3 Apr 2012 09:57:19 +0000 (09:57 +0000)]
Unreviewed, rolling out r112954 and r112969.
http://trac.webkit.org/changeset/112954
http://trac.webkit.org/changeset/112969
https://bugs.webkit.org/show_bug.cgi?id=79172
Hits "ASSERTION FAILED: !m_isHandlingDrag" in DnD-related
tests on Debug bots
Source/WebCore:
* page/DragController.cpp:
(WebCore::DragController::performDrag):
LayoutTests:
* fast/events/drag-dataTransferItemList.html:
* fast/events/drop-handler-should-not-stop-navigate-expected.txt: Removed.
* fast/events/drop-handler-should-not-stop-navigate.html: Removed.
* http/tests/security/clipboard/clipboard-file-access.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 3 Apr 2012 09:39:17 +0000 (09:39 +0000)]
2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>
Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459
Reviewed by Dirk Schulze.
Add new tests for all SVGAnimatedEnumeration in the SVG DOM to proof they animate and update animVal correctly.
* platform/gtk/Skipped: Unskip svgenum tests.
* svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Added.
* svg/animations/animate-marker-orient-from-angle-to-angle.html: Added.
* svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Added.
* svg/animations/animate-marker-orient-from-angle-to-auto.html: Added.
* svg/animations/animate-marker-orient-to-angle-expected.txt: Added.
* svg/animations/animate-marker-orient-to-angle.html: Added.
* svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/animate-marker-orient-to-angle.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgenum-animation-1.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-10.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-11.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svgenum-animation-12.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgenum-animation-13.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/svgenum-animation-2.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/script-tests/svgenum-animation-3.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-4.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(sample6):
(executeTest):
* svg/animations/script-tests/svgenum-animation-5.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-6.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(executeTest):
* svg/animations/script-tests/svgenum-animation-7.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/script-tests/svgenum-animation-8.js: Added.
(sample1):
(sample2):
(sample3):
(sample4):
(sample5):
(executeTest):
* svg/animations/script-tests/svgenum-animation-9.js: Added.
(sample1):
(sample2):
(executeTest):
* svg/animations/svgangle-animation-deg-to-grad-expected.txt:
* svg/animations/svgangle-animation-deg-to-rad-expected.txt:
* svg/animations/svgangle-animation-grad-to-deg-expected.txt:
* svg/animations/svgangle-animation-grad-to-rad-expected.txt:
* svg/animations/svgangle-animation-rad-to-deg-expected.txt:
* svg/animations/svgangle-animation-rad-to-grad-expected.txt:
* svg/animations/svgenum-animation-1-expected.txt: Added.
* svg/animations/svgenum-animation-1.html: Added.
* svg/animations/svgenum-animation-10-expected.txt: Added.
* svg/animations/svgenum-animation-10.html: Added.
* svg/animations/svgenum-animation-11-expected.txt: Added.
* svg/animations/svgenum-animation-11.html: Added.
* svg/animations/svgenum-animation-12-expected.txt: Added.
* svg/animations/svgenum-animation-12.html: Added.
* svg/animations/svgenum-animation-13-expected.txt: Added.
* svg/animations/svgenum-animation-13.html: Added.
* svg/animations/svgenum-animation-2-expected.txt: Added.
* svg/animations/svgenum-animation-2.html: Added.
* svg/animations/svgenum-animation-3-expected.txt: Added.
* svg/animations/svgenum-animation-3.html: Added.
* svg/animations/svgenum-animation-4-expected.txt: Added.
* svg/animations/svgenum-animation-4.html: Added.
* svg/animations/svgenum-animation-5-expected.txt: Added.
* svg/animations/svgenum-animation-5.html: Added.
* svg/animations/svgenum-animation-6-expected.txt: Added.
* svg/animations/svgenum-animation-6.html: Added.
* svg/animations/svgenum-animation-7-expected.txt: Added.
* svg/animations/svgenum-animation-7.html: Added.
* svg/animations/svgenum-animation-8-expected.txt: Added.
* svg/animations/svgenum-animation-8.html: Added.
* svg/animations/svgenum-animation-9-expected.txt: Added.
* svg/animations/svgenum-animation-9.html: Added.
2012-04-03 Nikolas Zimmermann <nzimmermann@rim.com>
Enable animVal support for SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=82459
Reviewed by Dirk Schulze.
Enable animVal support for the last missing SVG DOM primitive: SVGAnimatedEnumeration.
It's a bit more involved than the others as we have to differentiate between the various
enumerations to use the correct SVGPropertyTraits<MyEnum>::fromString() code-path.
One SVGAnimatedEnumeration property in the SVG DOM is special: SVGAnimatedEnumeration orientType
from SVGMarkerElement. SVGMarkerElement exposes both the orientType and SVGAnimatedAngle orientAngle
SVG DOM properties and both get mapped to the same SVGNames::orientAttr ("orient" XML attribute).
That means that any animation of the orientAttr has to update both orientType & orientAngle.
This is a not a new requirement, we already support attributes like 'stdDeviation' from
SVGFEGaussianBlurElement, which get mapped to multiple SVG DOM objects: SVGAnimatedInteger stdDeviationX/Y.
The difference is that <integer-optional-integer> or <number-optional-number> animations use the
same type in the pair<xxx, xxx> (eg. both int, or both float). The 'orient' attribute needs to be
mapped to pair<xxx, yyy> types. Generalize the templates in SVGAnimatedTypeAnimator to support that.
Example:
<marker id="someMarkerElement" orient="45deg"/>
<animate fill="remove" begin="1s" dur="2s" from="90deg" to="auto" attributeName="orient" xlink:href="#someMarkerElement"/>
at 0s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.animVal.value = 45
someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45
at 1s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.animVal.value = 90
someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45
at 2s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO
someMarkerElement.orientAngle.animVal.value = 0
someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45
> 3s: someMarkerElement.orientType.animVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.animVal.value = 45
someMarkerElement.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE
someMarkerElement.orientAngle.baseVal.value = 45
We need to map the 'orient' attribute to a pair<SVGAngle, unsigned short> type, in order
to track both orientAngle & orientType at the same type. Fortunately SVGAnimatedAngle
is only used in the SVG DOM for SVGMarkerElements orientAngle property. We can directly
switch SVGAnimatedAngleAnimator to the new pair<SVGAngle, unsigned short> type instead
of having to introduce a special SVGAnimatedAngleAndEnumerationAnimator.
Added tests for all SVGAnimatedEnumeration properties in the SVG DOM, including an extensive set of tests
for the synchronization of the orientType / orientAngle properties, when they get animated.
Tests: svg/animations/animate-marker-orient-from-angle-to-angle.html
svg/animations/animate-marker-orient-from-angle-to-auto.html
svg/animations/animate-marker-orient-to-angle.html
svg/animations/svgenum-animation-1.html
svg/animations/svgenum-animation-10.html
svg/animations/svgenum-animation-11.html
svg/animations/svgenum-animation-12.html
svg/animations/svgenum-animation-13.html
svg/animations/svgenum-animation-2.html
svg/animations/svgenum-animation-3.html
svg/animations/svgenum-animation-4.html
svg/animations/svgenum-animation-5.html
svg/animations/svgenum-animation-6.html
svg/animations/svgenum-animation-7.html
svg/animations/svgenum-animation-8.html
svg/animations/svgenum-animation-9.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedAngle.h:
(WebCore):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedEnumeration.cpp: Added.
(WebCore):
(WebCore::enumerationValueForTargetAttribute):
(WebCore::SVGAnimatedEnumerationAnimator::SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::constructFromString):
(WebCore::SVGAnimatedEnumerationAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedEnumerationAnimator::animValWillChange):
(WebCore::SVGAnimatedEnumerationAnimator::animValDidChange):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedEnumerationAnimator::calculateAnimatedValue):
(WebCore::SVGAnimatedEnumerationAnimator::calculateDistance):
* svg/SVGAnimatedEnumeration.h:
(SVGAnimatedEnumerationAnimator):
(WebCore::SVGAnimatedEnumerationAnimator::~SVGAnimatedEnumerationAnimator):
(WebCore):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngleAndEnumeration):
(WebCore::SVGAnimatedType::createEnumeration):
(WebCore):
(WebCore::SVGAnimatedType::angleAndEnumeration):
(WebCore::SVGAnimatedType::enumeration):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGAnimatedType.h:
(SVGAnimatedType):
* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForTypes):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::executeAction):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGMarkerElement.cpp:
(WebCore):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(SVGAnimatedListPropertyTearOff):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(SVGAnimatedPropertyTearOff):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(SVGAnimatedStaticPropertyTearOff):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 09:24:39 +0000 (09:24 +0000)]
Unreviewed, rolling out r112987 and r112993.
http://trac.webkit.org/changeset/112987
http://trac.webkit.org/changeset/112993
https://bugs.webkit.org/show_bug.cgi?id=83010
hits ASSERTs in Debug builds (Requested by philn-tp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-03
Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::initSecurityContext):
* dom/Document.h:
(Document):
* html/HTMLAttributeNames.in:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::location):
* html/HTMLIFrameElement.idl:
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::defaultForInitial):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::outgoingReferrer):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/FrameLoader.h:
(FrameLoader):
LayoutTests:
* fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again-expected.txt: Removed.
* fast/frames/srcdoc/reloading-a-srcdoc-document-loads-it-again.html: Removed.
* fast/frames/srcdoc/setting-src-does-nothing-expected.txt: Removed.
* fast/frames/srcdoc/setting-src-does-nothing.html: Removed.
* fast/frames/srcdoc/setting-srcdoc-reloads-document-expected.txt: Removed.
* fast/frames/srcdoc/setting-srcdoc-reloads-document.html: Removed.
* fast/frames/srcdoc/srcdoc-beats-src-dom-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-beats-src-dom.html: Removed.
* fast/frames/srcdoc/srcdoc-beats-src-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-beats-src.html: Removed.
* fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode.html: Removed.
* fast/frames/srcdoc/srcdoc-can-navigate-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-can-navigate.html: Removed.
* fast/frames/srcdoc/srcdoc-defaults-to-standards-mode-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-defaults-to-standards-mode.html: Removed.
* fast/frames/srcdoc/srcdoc-loads-content-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-loads-content.html: Removed.
* fast/frames/srcdoc/srcdoc-urls-expected.txt: Removed.
* fast/frames/srcdoc/srcdoc-urls.html: Removed.
* http/tests/security/srcdoc-can-access-parent-expected.txt: Removed.
* http/tests/security/srcdoc-can-access-parent.html: Removed.
* http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Removed.
* http/tests/security/srcdoc-in-sandbox-cannot-access-parent.html: Removed.
* http/tests/security/srcdoc-inherits-referrer-expected.txt: Removed.
* http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt: Removed.
* http/tests/security/srcdoc-inherits-referrer-for-forms.html: Removed.
* http/tests/security/srcdoc-inherits-referrer.html: Removed.
* platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 3 Apr 2012 09:20:50 +0000 (09:20 +0000)]
[GTK] DRT missing didRunInsecureContent notification
https://bugs.webkit.org/show_bug.cgi?id=59367
Patch by Simon Pena <spena@igalia.com> on 2012-04-03
Reviewed by Philippe Normand.
Source/WebKit/gtk:
Add a new signal "insecure-content-run" to the WebFrame to notify
when insecure HTTP content (such as CSS, an iframe or a script) is
run from a secure HTTPS WebFrame. Implement didRunInsecureContent
in gtk's FrameLoaderClient by means of emitting that signal.
* WebCoreSupport/FrameLoaderClientGtk.cpp: Implement
didRunInsecureContent by emitting WebFrame's
"insecure-content-run" signal
(WebKit::FrameLoaderClient::didRunInsecureContent):
* webkit/webkitwebframe.cpp: Add "insecure-content-run" signal
(webkit_web_frame_class_init):
Tools:
Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
the main WebFrame or any other WebFrame created later. Added
"didRunInsecureContent" notification in the callback in order to
get the LayoutTests passing.
* DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
to WebFrame's "insecure-content-run" signal and add
didRunInsecureContent notification in the callback to get the
LayoutTests passing.
(didRunInsecureContent):
(createWebView):
LayoutTests:
Unskip tests as new API is added to detect when a secure HTTPS page
loads content (such as CSS, images, iframes or a script) from
a non-secure HTTP origin.
* platform/gtk/Skipped: Unskip insecure-css-in-main-frame,
insecure-css-in-iframe, insecure-image-in-main-frame,
insecure-script-in-iframe, insecure-plugin-in-iframe,
redirect-http-to-https-script-in-iframe and
redirect-https-to-http-script-in-iframe since they pass after the
new API has been added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Tue, 3 Apr 2012 09:16:13 +0000 (09:16 +0000)]
[Qt] Unreviewed gardening after r112954.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-03
* platform/qt/Skipped: Skip fast/events/drop-handler-should-not-stop-navigate.html because of missing drag and drop support.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Tue, 3 Apr 2012 09:08:01 +0000 (09:08 +0000)]
Fallback fonts should be used while a web font is being loaded
https://bugs.webkit.org/show_bug.cgi?id=76684
Reviewed by Ojan Vafai.
Add the test which should have been submitted with r112489.
* http/tests/webfont/fallback-font-while-loading-expected.txt: Added.
* http/tests/webfont/fallback-font-while-loading.html: Added.
* http/tests/webfont/slow-ahem-loading.cgi: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 3 Apr 2012 08:53:49 +0000 (08:53 +0000)]
Unreviewed, disable inspector/styles/override-screen-size.html on platforms other than Chromium.
Related bug: https://bugs.webkit.org/show_bug.cgi?id=82886
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bbudge@chromium.org [Tue, 3 Apr 2012 08:45:26 +0000 (08:45 +0000)]
REGRESSION (r112217): H&R Block tax site won't load
https://bugs.webkit.org/show_bug.cgi?id=82964
Source/WebCore:
Modifies the redirect checking code to first check if the security origin can
request the redirect URL before invoking the CORS check.
Reviewed by Adam Barth.
http/tests/xmlhttprequest/access-control-and-redirects-async.html
* loader/DocumentThreadableLoader.cpp:
* loader/DocumentThreadableLoader.h:
LayoutTests:
Add a test case for a same origin request with a custom header that receives a
same origin redirect, and therefore should pass the redirect check.
Reviewed by Adam Barth.
* http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
* http/tests/xmlhttprequest/access-control-and-redirects-async.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Tue, 3 Apr 2012 08:36:12 +0000 (08:36 +0000)]
Unreviewed, rolling out r112994.
http://trac.webkit.org/changeset/112994
https://bugs.webkit.org/show_bug.cgi?id=83008
This patch has to wait until v8 roll. (Requested by loislo on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-03
* bindings/js/ScriptHeapSnapshot.h:
* bindings/v8/ScriptHeapSnapshot.cpp:
(WebCore):
* bindings/v8/ScriptHeapSnapshot.h:
(WebCore):
(ScriptHeapSnapshot):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged.firstSnapshotLoaded):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged.secondSnapshotLoaded):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.get maxNodeId):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.get maxNodeId):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@FreeBSD.org [Tue, 3 Apr 2012 08:32:34 +0000 (08:32 +0000)]
rebaseline-server: Make it possible to not launch a browser with the server.
https://bugs.webkit.org/show_bug.cgi?id=82999
Reviewed by Adam Barth.
Add the `--no-show-results' option, which lets one decide not to
launch a web browser when running the rebaseline server. This is
especially useful if the default browser is not the wanted one, or
if the rebaseline server page is already open.
* Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.__init__):
(AbstractLocalServerCommand.execute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
projects / profile / ivi / webkit-efl.git / log