Deng Zhengrong [Sat, 28 Jul 2012 22:45:44 +0000 (06:45 +0800)]
tests: modify sig2str-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 22:26:06 +0000 (06:26 +0800)]
tests: modify sigbus-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 22:12:53 +0000 (06:12 +0800)]
tests: modify interpol-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 21:59:46 +0000 (05:59 +0800)]
tests: modify smoother-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 17:21:25 +0000 (01:21 +0800)]
tests: modify sync-playback to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 17:17:27 +0000 (01:17 +0800)]
tests: modify extended-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 16:59:42 +0000 (00:59 +0800)]
tests: modify hook-list-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 16:24:33 +0000 (00:24 +0800)]
tests: modify memblockq-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 14:56:43 +0000 (22:56 +0800)]
tests: modify proplist-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 14:51:04 +0000 (22:51 +0800)]
tests: modify memblock-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 14:21:56 +0000 (22:21 +0800)]
tests: modify connect-stress to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 13:53:58 +0000 (21:53 +0800)]
tests: modify queue-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 13:34:58 +0000 (21:34 +0800)]
tests: modify cpulimit-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 13:25:58 +0000 (21:25 +0800)]
tests: modify channelmap-tets to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 13:22:05 +0000 (21:22 +0800)]
tests: modify asyncq-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 13:16:31 +0000 (21:16 +0800)]
tests: modify asyncmsgq-test to new 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 13:08:49 +0000 (21:08 +0800)]
tests: modify alsa-time-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 10:07:28 +0000 (18:07 +0800)]
tests: modify thread-mainloop-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 10:01:41 +0000 (18:01 +0800)]
tests: modify thread-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 09:45:50 +0000 (17:45 +0800)]
tests: modify get-binary-name-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 09:25:16 +0000 (17:25 +0800)]
tests: modify format-test to use 'check' framework
Deng Zhengrong [Sat, 28 Jul 2012 09:21:22 +0000 (17:21 +0800)]
tests: modify usergroup-test to use 'check' test framework
Deng Zhengrong [Sat, 28 Jul 2012 09:13:10 +0000 (17:13 +0800)]
tests: modify volume_test to use new 'check' framework
Tanu Kaskinen [Sun, 19 Aug 2012 11:49:27 +0000 (14:49 +0300)]
Add comments referring to bug #53709.
David Henningsson [Wed, 8 Aug 2012 14:01:38 +0000 (16:01 +0200)]
resampler: Fix volume on downmix to mono
Patch credit: kwanghui
When downmixing to mono, we should average the signal instead of
summing it to avoid clipping.
BugLink: http://pulseaudio.org/ticket/934
BugLink: https://bugs.launchpad.net/bugs/416190
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Tanu Kaskinen [Mon, 6 Aug 2012 12:07:57 +0000 (15:07 +0300)]
build-sys: Link utf8-test to libpulsecommon.
Fixes this:
/usr/bin/ld: utf8_test-utf8-test.o: undefined reference to symbol 'pa_log_set_level'
/usr/bin/ld: note: 'pa_log_set_level' is defined in DSO /home/takaskin/dev/pulseaudio/src/.libs/libpulsecommon-2.98.so so try adding it to the linker command line
/home/takaskin/dev/pulseaudio/src/.libs/libpulsecommon-2.98.so: could not read symbols: Invalid operation
Sjoerd Simons [Fri, 20 Jul 2012 19:18:26 +0000 (19:18 +0000)]
build-sys: webrtc-utils needs to be installed before module-echo-cancel
Like other plugin helper libraries these need to be installed
before the plugins that use them..
Deng Zhengrong [Mon, 23 Jul 2012 05:12:46 +0000 (13:12 +0800)]
tests: enable to test standalone pulseaudio daemon
With this fix, `check-daemon` doesn't need a system-wide running pulseaudio
anymore.
The method to use is to invoke `make check-daemon` under `src/` and it just
works! :)
Deng Zhengrong [Fri, 20 Jul 2012 06:32:35 +0000 (14:32 +0800)]
build: add a target to ease the creation of coverage files
Arun Raghavan [Tue, 24 Jul 2012 09:16:34 +0000 (14:46 +0530)]
tests: Make cpu-test less verbose
Arun Raghavan [Tue, 24 Jul 2012 09:07:54 +0000 (14:37 +0530)]
tests: Factor out Orc test code into cpu-test
Reorganises all the svolume core test code in cpu-test since it's the
same across MMX/SSE/etc.
Deng Zhengrong [Tue, 17 Jul 2012 06:45:55 +0000 (14:45 +0800)]
tests: modify strlist-test to use new 'check' framework
Deng Zhengrong [Tue, 17 Jul 2012 06:45:54 +0000 (14:45 +0800)]
tests: modify utf8-test to use new 'check' test framework
Deng Zhengrong [Tue, 17 Jul 2012 06:45:53 +0000 (14:45 +0800)]
tests: modify mainloop-test to use new 'check' framework
Deng Zhengrong [Tue, 17 Jul 2012 06:45:52 +0000 (14:45 +0800)]
tests: add cpu test
It tests only x86 architecture right now.
Deng Zhengrong [Tue, 17 Jul 2012 06:45:51 +0000 (14:45 +0800)]
tests: modify mix-test to use new 'check' test framework
Deng Zhengrong [Tue, 17 Jul 2012 06:45:50 +0000 (14:45 +0800)]
build-sys: add `check` test framework
Peter Meerwald [Tue, 24 Jul 2012 08:16:56 +0000 (10:16 +0200)]
modules: Add null/dummy echo canceller
I find a dummy/passthrough implementation useful for AEC debugging
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Mikel Astiz [Thu, 26 Jul 2012 10:36:33 +0000 (12:36 +0200)]
bluetooth: Remove minor unnecessary check
The return value of dbus_message_iter_next() doesn't need to be checked
since the while condition will be false anyway (arg type will be
DBUS_TYPE_INVALID).
Mikel Astiz [Thu, 26 Jul 2012 10:36:32 +0000 (12:36 +0200)]
bluetooth: Replace deprecated ListDevices()
The method ListDevices() in org.bluez.Adapter was deprecated in BlueZ
4.61, and is going to be removed in future releases. Instead, a property
was introduced for this purpose in BlueZ 4.7.
Mikel Astiz [Thu, 26 Jul 2012 10:36:31 +0000 (12:36 +0200)]
bluetooth: Replace deprecated ListAdapters()
The method ListAdapters() in org.bluez.Manager was deprecated in BlueZ
4.61, and is going to be removed in future releases. Instead, a property
was introduced for this purpose in BlueZ 4.22.
Mikel Astiz [Fri, 27 Jul 2012 14:41:22 +0000 (16:41 +0200)]
bluetooth: Avoid duplicating profile argument twice
The module module-bluetooth-device should never be given parameter
'profile' twice, even if both HFGW and A2DP are playing. This patch
proposed to consider HFGW first.
Mikel Astiz [Fri, 27 Jul 2012 14:41:21 +0000 (16:41 +0200)]
bluetooth: Consider different input and output MTU
Previous implementation assumes these values are equal, but this doesn't
necessarily have to be so.
Mikel Astiz [Fri, 27 Jul 2012 14:41:20 +0000 (16:41 +0200)]
bluetooth: Minor style fixes
Fix some minor style fixes to be consistent with the project coding
style.
Mikel Astiz [Fri, 6 Jul 2012 09:19:53 +0000 (11:19 +0200)]
bluetooth: Remove library for IPC to BlueZ
This library is not used anymore after the definitive transition to
Media API.
Mikel Astiz [Wed, 25 Jul 2012 14:29:52 +0000 (16:29 +0200)]
bluetooth: Refactor property parsing code
Use a separate method to perform the common checks when a property needs
to be parsed.
Mikel Astiz [Fri, 6 Jul 2012 09:19:52 +0000 (11:19 +0200)]
bluetooth: Don't use the old socket IPC mechanism with BlueZ
This simplifies the code a lot, in favour of the D-Bus Media interface
in BlueZ. The old socket-based IPC mechanism has been deprecated and is
about to be removed soon.
Arun Raghavan [Thu, 19 Jul 2012 11:25:03 +0000 (16:55 +0530)]
build: Fix distcheck failure on libwebrtc-util
Without -avoid-version, libtool creates a libwebrtc-util.so.0 and
libwebrtc-util.so.0.0.0 which are not cleaned up by make uninstall,
which in turn causes make distcheck to fail.
Arun Raghavan [Thu, 19 Jul 2012 11:10:49 +0000 (16:40 +0530)]
i18n: module-coreaudio-device now has some translatable strings
Feng Wei [Tue, 17 Jul 2012 10:17:21 +0000 (18:17 +0800)]
alsa: Catch role matched streams to enable/disable modifier
In UCM basic functions, we only assign intended roles from modifier
to sink/source, but we don't have a chance to set the ucm modifiers.
Here we amend the functions so that when roled stream starts or
stops, we have the following results:
1. stream will be routed to sink/source specified in modifier by
module-intended-roles
2. After that, modifier will be enabled or disabled.
3. when multiple streams with matched roles of modifier start, only
the first one will enable the modifier, and when they end, the
last one will disable the modifier.
Signed-off-by: Feng Wei <wei.feng@freescale.com>
Signed-off-by: Arun Raghavan <arun.raghavan@collabora.co.uk>
Arun Raghavan [Tue, 17 Jul 2012 07:38:20 +0000 (13:08 +0530)]
build: Avoid libstdc++ dep for module-echo-cancel if possible
This moves out the webrtc bits into a small helper library to shield the
rest of module-echo-cancel from being linked with a C++ linker. This is
required because automake will _always_ link module-echo-cancel in C++
mode if any of its deps (even conditional ones) are in C++.
Jan Alexander Steffens (heftig) [Tue, 17 Jul 2012 13:44:37 +0000 (15:44 +0200)]
alsa-mixer: Actually install analog-input-headphone-mic.conf
Without this file, pulseaudio aborts with:
E: [pulseaudio] alsa-mixer.c: Assertion 'eb = p2->elements' failed at
modules/alsa/alsa-mixer.c:3179, function path_set_condense(). Aborting.
Arun Raghavan [Tue, 17 Jul 2012 07:35:28 +0000 (13:05 +0530)]
echo-cancel: Print what AEC engine is being used
Useful for debugging
Arun Raghavan [Tue, 17 Jul 2012 06:27:35 +0000 (11:57 +0530)]
i18n: Remove module-hal-detect reference in POTFILES
Peter Meerwald [Mon, 9 Jul 2012 16:01:32 +0000 (18:01 +0200)]
core: Set volumes const in pa_do_volume_func_t
volumes do not change, the samples get scaled
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Deng Zhengrong [Tue, 10 Jul 2012 00:32:54 +0000 (08:32 +0800)]
core: add more verbose error info
I'm debugging an issue, and find that it's more useful for users to know which
directory hasn't been created instead of just knowing error code.
Deng Zhengrong [Wed, 11 Jul 2012 14:29:45 +0000 (22:29 +0800)]
man: document option `set-log-target`
Deng Zhengrong [Wed, 11 Jul 2012 14:42:04 +0000 (22:42 +0800)]
bluetooth: add a parenthesis around pa_streq()
I know that pa_streq() is defined with an extra parenthesis, but everytime I
look at it, it makes me nervous. :D
So it's better to add the parenthesis here.
Peter Meerwald [Fri, 13 Jul 2012 07:32:04 +0000 (09:32 +0200)]
build: Fix static linking
fixes bug #52038:
gcc -static x.c `PKG_CONFIG_PATH=/usr/local/lib/pkgconfig pkg-config --static
--libs libpulse-simple`
/usr/bin/ld: error: cannot find -lpulsecommon-2.98
pulse/simple.c:373: error: undefined reference to 'pa_log_level_meta'
pulse/simple.c:374: error: undefined reference to 'pa_log_level_meta'
Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
Frédéric Dalleau [Fri, 13 Jul 2012 15:38:23 +0000 (17:38 +0200)]
pacmd: Display inputs and outputs PASSTHROUGH flag
Arun Raghavan [Mon, 16 Jul 2012 10:12:53 +0000 (15:42 +0530)]
alsa: Add separate sinks/sources for UCM modifiers if needed
Modifiers may have their own PlaybackPCM/CapturePCM and for these, we
create separate sinks/sources. These are marked with the
device.intended_roles property to let role-based routing take care if
streams are tagged appropriately.
Arun Raghavan [Tue, 3 Jul 2012 06:20:29 +0000 (11:50 +0530)]
alsa: Add a proplist to mappings
The proplist isn't used by the conventional alsa-mixer code path, but
can be used by UCM to transfer properties from UCM data to the
sinks/sources corresponding to a mapping. These properties could be used
later in policy, etc.
The specific use for which I'm writing this now is for UCM modifiers
that have their own PlaybackPCM/CapturePCM field. These will be
translated to a separate sink/source corresponding to the modifier by
adding an additional mapping per sink/source. These mappings' proplist
will be populated with the name of the modifier and corresponding
"device.intended_role" property. The latter will be used in the usual
routing-by-role way, and the former will be used during sink/source
activation and deactivation to know what UCM modifier is to be enabled
or disabled.
Arun Raghavan [Mon, 16 Jul 2012 10:20:10 +0000 (15:50 +0530)]
alsa: Allow channel count probe on open by mapping
This allows opening a PCM given a mapping to work even if we don't have
a channel count for the device up-front.
Feng Wei [Thu, 5 Jul 2012 05:03:45 +0000 (13:03 +0800)]
alsa: Add UCM jack detection
Jack in UCM is decided by UCM device name, although in fact
not all UCM devices have "jacks". Because port is also mapped
to UCM device, we can always find target port when some jack
event happens.
Signed-off-by: Feng Wei <wei.feng@freescale.com>
Feng Wei [Thu, 5 Jul 2012 04:53:21 +0000 (12:53 +0800)]
alsa: Integrate UCM basic functions
UCM basic functions will provide another way to handle the alsa mixer
and controls. That means alsa card module will make use of alsa ucm
configurations provided by various audio systems instead of mixer and
paths configurations provided by PA. PA profiles come from UCM verb, PA
sinks/sources and ports come from UCM devices.
In case the proper UCM configurations are found, ucm branches are
activated, or we will still fall through to the original way.
Signed-off-by: Feng Wei <wei.feng@freescale.com>
David Henningsson [Thu, 28 Jun 2012 14:03:17 +0000 (16:03 +0200)]
alsa-mixer: Add "Headphone Mic" support for 3-pin ASUS netbooks
Some ASUS netbooks, such as the 1015 CX, have only one 3.5 mm jack,
but it can be used either as a headphone or as a mic (but not both
simultaneously).
This patch adds support for the "Headphone Mic" path that is used
on these devices, so that we can use the jack as an external mic, and
doing so without muting the speaker.
BugLink: https://bugs.launchpad.net/bugs/1018262
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Sjors Gielen [Sun, 8 Jul 2012 21:24:18 +0000 (23:24 +0200)]
osx: Add a single "On" profile to coreaudio devices. Fixes crash on OS X.
Since commit
12af302a last month, cards always have at least one
profile, so there is also always an active_profile (this makes the code
more simple). However, module-coreaudio-device did not create a profile
yet, causing a crash of PulseAudio when used on OS X. This patch fixes
this crash, by adding a single "On" profile. I've also added a TODO for
adding an "Off" profile which removes all sinks and sources -- I can
work on resolving this TODO later on.
Jarkko Nikula [Thu, 22 Mar 2012 09:29:12 +0000 (11:29 +0200)]
alsa: Merge pa_alsa_setting_select with pa_alsa_path_select
As these functions are called together and are related, we might merge
them and call setting_select from pa_alsa_path_select by passing
optional pa_alsa_setting argument.
Make also the setting_select static as it is not called outside of
alsa-mixer.c after this change.
[Additional note from Tanu Kaskinen: this change improves the
mute-during-activation feature, because now the mixer changes related
to selecting the setting happen while the hw is muted.]
Jarkko Nikula [Thu, 22 Mar 2012 09:29:11 +0000 (11:29 +0200)]
alsa: move pa_alsa_setting_select close to pa_alsa_path_select
Move pa_alsa_setting_select call just after the pa_alsa_path_select in
[sink | source]_set_port_cb functions as there is no dependency to volume
calculations that are done between these two calls. Idea here is to make
possible to merge these two functions since they are called together from
other places too.
Tanu Kaskinen [Thu, 22 Mar 2012 09:29:10 +0000 (11:29 +0200)]
alsa-mixer: Implement a new path option: "mute-during-activation".
Peter Meerwald [Wed, 22 Feb 2012 12:07:17 +0000 (13:07 +0100)]
memblock: Fix typos.
Tanu Kaskinen [Sat, 30 Jun 2012 10:00:25 +0000 (13:00 +0300)]
card-restore: Handle reading NULL profile name from the database.
It's assumed in a couple of places that entry_read()
initializes entry->profile to a non-NULL string. This patch
makes those assumptions hold.
Tested-by: Mikel Astiz <mikel.astiz.oss@gmail.com>
poljar (Damir Jelić) [Wed, 27 Jun 2012 20:55:35 +0000 (22:55 +0200)]
card-restore: Add the ability to save and restore the latency offset.
module-card-restore now saves the latency offsets.
This change includes a entry version bump.
The entry now consists of a port count and a port name and offset for
every port that belongs to the relevant card.
Frédéric Dalleau [Wed, 4 Jul 2012 14:48:27 +0000 (16:48 +0200)]
bluetooth: module-bluetooth-policy initial commit
This is a basic module for enabling loopback as soon as a new bluetooth A2DP
source is created. The module is given a source and a media role using command
line. This allows module-intended-roles or module-device-manager to choose a
target sink for the stream.
Frédéric Dalleau [Wed, 20 Jun 2012 15:33:35 +0000 (17:33 +0200)]
loopback: Enable routing on loopback streams
At module-loopback load, if no sink is given, the default sink is used. If the
stream has a media.role property, the property cannot be used because a the
source or sink is forced to default. Both module-intended-roles and
module-device-manager are affected. The same apply to sources.
With this patch, if sink or source is missing, routing modules can be used.
Arun Raghavan [Tue, 3 Jul 2012 12:41:54 +0000 (18:11 +0530)]
role-cork: Fix another minor leak
Credit to David for finding this one.
Arun Raghavan [Tue, 3 Jul 2012 12:34:48 +0000 (18:04 +0530)]
Revert "Revert "role-cork: Fix a minor leak""
This reverts commit
a2c4bf22e0813d529f153c01d7421345a792f3bc.
As Tanu points out, I'm stupid. The pa_xstrdup(n) was unnecessary
because pa_split() allocates a new string for us.
Arun Raghavan [Tue, 3 Jul 2012 12:22:36 +0000 (17:52 +0530)]
role-cork: Fix incorrect check at deinitialisation time
Arun Raghavan [Tue, 3 Jul 2012 12:30:36 +0000 (18:00 +0530)]
Revert "role-cork: Fix a minor leak"
This reverts commit
51c8d5a477d36f0646243a092994036b3781e9c1.
As David points out, this was incorrect.
David Henningsson [Tue, 3 Jul 2012 08:31:30 +0000 (10:31 +0200)]
alsa-mixer: Add "Front Headphone Jack" (fixup)
I forgot half of the front headphone patch, i e, to hide the
speaker output when the front headphone is connected. Thanks to
Shih-Yuan Lee for noticing.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Arun Raghavan [Tue, 3 Jul 2012 03:19:26 +0000 (08:49 +0530)]
core-util: Fix permissions handling while creating directories
This makes updating of permissions on existing directories optional with
pa_make_secure_dir() and pa_make_secure_parent_dir(). This makes sure
that the recursive directory creation doesn't end up modifying existing
directories, and also fixes a problem where creating an auth cookie
(specifically ~/.esd_auth) would end up modifying permissions on ~.
Thanks to Frédéric Danis for reporting this.
Deng Zhengrong [Thu, 28 Jun 2012 07:27:57 +0000 (15:27 +0800)]
add a new log target that enables to create new log file if it exists
David Henningsson [Mon, 2 Jul 2012 10:17:30 +0000 (12:17 +0200)]
alsa-mixer: Document "state.plugged" and "state.unplugged"
Put explanation of state.plugged and state.unplugged in
analog-output.conf.common.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Mon, 2 Jul 2012 10:09:06 +0000 (12:09 +0200)]
alsa-mixer: Add "Front Headphone" jack
Many desktops have headphone on the front and line outs on the back.
Sometimes this means that the headphone is labelled "Front Headphone Jack",
but the volume controls are only "Headphone Playback Volume", i e,
without the "Front" prefix.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Thu, 28 Jun 2012 13:40:17 +0000 (15:40 +0200)]
alsa-mixer: Always turn "Inverted Internal Mic" off
Some devices have inverted right channel, so when you add left and right,
the result is silence, or very faint sound. In recent kernels (3.5,
perhaps also 3.4) these are starting to be marked with a special
"Inverted Internal Mic" capture switch.
While we might want to add some reverse summing mechanism in the
future, for now, we just turn the thing off to avoid the problem of
recording silence.
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Thu, 28 Jun 2012 13:35:38 +0000 (15:35 +0200)]
alsa-mixer: Add Phantom Jack support
For kernel 3.6, "phantom jack" kctls have been added. They serve as
a marker that a particular port exist. They were made so we can detect
that there actually are speakers and internal mic on a laptop, even if
there are no other indications (volume controls etc).
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
David Henningsson [Thu, 3 May 2012 13:39:18 +0000 (15:39 +0200)]
alsa-mixer: Add special profiles for some laptops missing speaker and/or internal mic
Several laptops have speaker ports, and/or internal mic ports, but we have
no way of detecting that. So we make the port(s) always show up for these
devices.
BugLink: https://bugs.launchpad.net/bugs/946232
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
poljar (Damir Jelić) [Thu, 28 Jun 2012 13:02:27 +0000 (15:02 +0200)]
man: Add latency offset documentation to the cli syntax.
The new latency offset command is now documented in the
pulse-cli-syntax man page.
poljar (Damir Jelic) [Thu, 28 Jun 2012 13:00:46 +0000 (15:00 +0200)]
pactl: Add set-latency-offset command.
This introduces a new command to allow setting the latency offset.
Also the card list command now shows the latency offset on the ports.
poljar (Damir Jelic) [Thu, 28 Jun 2012 13:00:45 +0000 (15:00 +0200)]
introspect: Add functions to handle the latency offset.
This includes updating the native protocol and the client API.
A new command was added to allow setting the latency offset.
Also the card list command now shows the latency offset if there
are ports available.
Update protocol to 27.
Paul Menzel [Sat, 19 May 2012 08:03:01 +0000 (10:03 +0200)]
Fix spelling of separated: s, sepera, separa, g
The used command for fixing the script is the following.
$ git grep sepera | cut --delimiter=: --fields=1 | xargs sed -i s,sepera,separa,g
This patch is motivated by a patch in Debian from Martin-Éric Racine [1].
[1] http://anonscm.debian.org/gitweb/?p=pkg-pulseaudio/pulseaudio.git;a=commitdiff;h=
70e7261a615141908c0cf366fd49e0fc0f550fbf
poljar (Damir Jelić) [Thu, 28 Jun 2012 11:17:21 +0000 (13:17 +0200)]
device-port: Send a subscription event when the offset changes.
When the offset changes a subscription event should be sent to the
relevant card.
poljar (Damir Jelić) [Fri, 29 Jun 2012 21:19:52 +0000 (23:19 +0200)]
conf-parser: Initialize the state to zero immediately.
Set the state variable immediately to zero so if we fail to open the
configuration file we don't check an uninitialized pointer and free an
nonexistent proplist.
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:12 +0000 (21:49 +0300)]
Assume that the ports hashmap of cards is always non-NULL.
The hashmap is created in pa_card_new_data_init().
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:11 +0000 (21:49 +0300)]
Assume that the profiles hashmap of ports is always non-NULL.
It's a valid assumption nowadays, because the hashmap is
created in pa_device_port_new().
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:10 +0000 (21:49 +0300)]
card: Ensure that there's always at least one profile.
In practice there is always at least one profile, and I
don't think there will ever be cards without profiles.
Therefore, I added assertions to pa_card_new() stating that
the card new data must always contain at least one profile.
Now a lot of code can be simplified, because it's guaranteed
that the profiles hashmap and the active_profile field are
always non-NULL.
Tanu Kaskinen [Fri, 8 Jun 2012 18:49:09 +0000 (21:49 +0300)]
sink, source: Always create a hashmap for ports.
Having the hashmap sometimes NULL requires a lot of checking
here and there, so ensuring that the hashmap is always
non-NULL simplifies the code.
Tanu Kaskinen [Fri, 8 Jun 2012 16:36:45 +0000 (19:36 +0300)]
card: Don't crash if someone gives NULL name to pa_card_set_profile().
In my opinion, pa_card_set_profile() should assert that name
is not NULL, and it would be the job of the client interface
to filter out NULLs from the client input, but this is done
this way also when setting sink and source ports, so for
consistency I'll do this this way for now.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:30 +0000 (14:48 +0300)]
pactl: Print card port properties with the "list" command.
Tanu Kaskinen [Fri, 13 Apr 2012 11:48:29 +0000 (14:48 +0300)]
native: Send the actual port proplists with card info.