kling@webkit.org [Sat, 31 Dec 2011 23:36:08 +0000 (23:36 +0000)]
KeyframeAnimation: Use hash lookups to determine if property is animated.
<http://webkit.org/b/75407>
Reviewed by Anders Carlsson.
Clean out an old FIXME about using hash lookups instead of iterating over
the properties.
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::affectsProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Dec 2011 20:58:39 +0000 (20:58 +0000)]
Source/WebCore: WebCore change for <rdar://problem/
10463059> Cannot print USPS shipping labels
http://webkit.org/b/72801
Reviewed by Anders Carlsson and Alexey Proskuryakov.
* WebCore.exp.in: Exported Chrome::print().
Source/WebKit2: <rdar://problem/
10463059> Cannot print USPS shipping labels
http://webkit.org/b/72801
Reviewed by Anders Carlsson and Alexey Proskuryakov.
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(appendValuesInPDFNameSubtreeToVector): Copied from WebKit/mac/WebView/WebPDFDocumentExtras.mm.
(getAllValuesInPDFNameTree): Ditto.
(getAllScriptsInPDFDocument): Copied allScriptsInPDFDocument() from WebPDFDocumentExtras.mm
and changed it to append to a Vector<RetainPtr<CFStringRef> >.
(WebKit::BuiltInPDFView::create): Changed to take a WebFrame* rather than a Page*.
(WebKit::BuiltInPDFView::BuiltInPDFView): Ditto. Updated initializer accordingly.
(WebKit::BuiltInPDFView::pdfDocumentDidLoad): Copied and adapted code from
-[WebPDFRepresentation finishedLoadingWithDataSource:] to run scripts from the PDF with a
Doc object as the this object.
(WebKit::BuiltInPDFView::initialize): Adapted for the change from having a Page* to having
a WebFrame*.
(WebKit::BuiltInPDFView::destroy): Ditto.
(WebKit::BuiltInPDFView::isActive): Ditto.
(WebKit::jsPDFDocInitialize): Added. Refs the BuiltInPDFView which is the private object for
this Doc.
(WebKit::jsPDFDocFinalize): Added. Derefs the BuiltInPDFView for this Doc.
(WebKit::BuiltInPDFView::jsPDFDocPrint): Added. Calls WebCore::Chrome::print().
(WebKit::BuiltInPDFView::makeJSPDFDoc): Copied from WebKit/mac/WebView/WebJSPDFDoc.mm and
modified to use this BuiltInPDFView as the private object of the Doc being made.
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
(WebKit::BuiltInPDFView::disconnectFromPage): Adapted for the change from having a Page* to
having a WebFrame*.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin): Pass the WebFrame to WebPage::createPlugin().
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Added a WebFrame* parameter, which is used when creating
a BuiltInPDFView.
* WebProcess/WebPage/WebPage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Dec 2011 20:44:44 +0000 (20:44 +0000)]
<rdar://problem/8553040> REGRESSION (WebKit2): Safari status text doesn't change when you change the modifier keys without moving the mouse
https://bugs.webkit.org/show_bug.cgi?id=75404
Reviewed by Jon Honeycutt.
* UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]): Remove the flags changed event monitor.
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]): Added. Similarly to
-[WebHTMLView _postFlagsChangedEvent:], creates a mouse moved event and passes it to
-mouseMoved:.
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Create a local event monitor for flags
changed events.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 31 Dec 2011 20:29:46 +0000 (20:29 +0000)]
Source/WebCore: WebCore changes for <rdar://problem/8750356> REGRESSION (WebKit2): Printing a subframe containing a PDF prints the on-screen view instead of the entire PDF document
<http://webkit.org/b/75232>
Reviewed by Alexey Proskuryakov.
* WebCore.exp.in: Exported PluginDocument::pluginWidget().
* WebCore.xcodeproj/project.pbxproj: Promoted PluginDocument.h to private.
* html/PluginDocument.h: Fixed a typo in a comment.
Source/WebKit2: <rdar://problem/8750356> REGRESSION (WebKit2): Printing a subframe containing a PDF prints the on-screen view instead of the entire PDF document
<http://webkit.org/b/75232>
Reviewed by Alexey Proskuryakov.
* UIProcess/API/C/WKPage.cpp:
(WKPageDrawPagesToPDF): Added WKPrintInfo parameter, which is passed through as a PrintInfo
to the WebPageProxy.
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Changed to pass the PrintInfo
down to WebPageProxy::drawPagesToPDF.
(-[WKPrintingView _drawPreview:]): Changed to pass the PrintInfo down to
WebPageProxy::drawRectToPDF.
* UIProcess/API/mac/WKView.mm:
(-[WKView canChangeFrameLayout:]): Changed to use WebFrameProxy::isDisplayingPDFDocument, which
works for subframes as well.
(-[WKView printOperationWithPrintInfo:forFrame:]): Added a FIXME.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isDisplayingPDFDocument): Added.
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::drawRectToPDF): Added a PrintInfo parameter, which is passed through to
the Web process.
(WebKit::WebPageProxy::drawPagesToPDF): Ditto.
* UIProcess/WebPageProxy.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Added an override of pdfDocumentForPrinting() which returns the PDFDocument.
* WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::pdfDocumentForPrinting): Added. This base class implementation returns 0.
* WebProcess/Plugins/PluginView.h:
(WebKit::PluginView::pdfDocumentForPrinting): Added. Calls through to the Plugin.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::pdfDocumentForPrintingFrame): Added this helper function. If the frame is displaying
a plug-in document, allows the plug-in to provide a PDF document for printing.
(WebKit::WebPage::beginPrinting): Added an early return if the frame provides a PDF document
for printing.
(WebKit::WebPage::computePagesForPrinting): If the frame provides a PDF document for printing,
create for each page in the PDF document a page rect with the size available for printing.
(WebKit::drawPDFPage): Added this helper function, which draws a page from the PDF document
into one of the aforementioned page rects. It rotates the PDF page 90 degrees if necessary to
better match the aspect ratio of the paper, then it centers it on the paper. This matches the
behavior of a PDFView when printed with default settings.
(WebKit::WebPage::drawRectToPDF): If the frame provides a PDF document for printing, draw the
PDF pages falling within the requested rect.
(WebKit::WebPage::drawPagesToPDF): If the frame provides a PDF document for printing, draw
the requested pages.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Added a PrintInfo parameter to DrawRectToPDF and
DrawPagesToPDF.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 31 Dec 2011 06:02:49 +0000 (06:02 +0000)]
Allow disabling accelerated compositing in WebMediaPlayerClient (so audio-only <video> isn't accelerated).
https://bugs.webkit.org/show_bug.cgi?id=75261
Patch by Ami Fischman <fischman@chromium.org> on 2011-12-30
Reviewed by Darin Fisher.
* public/WebMediaPlayerClient.h:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
* src/WebMediaPlayerClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 31 Dec 2011 02:56:55 +0000 (02:56 +0000)]
Cache and reuse the HTMLTableElement.rows collection.
<http://webkit.org/b/75398>
Reviewed by Anders Carlsson.
Source/WebCore:
Let HTMLTableElement::rows() cache the returned collection and tie it to the
lifetime of the form.
Test: fast/dom/table-rows-collection-idempotence.html
fast/dom/gc-9.html
* html/HTMLTableElement.h:
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
Cache the HTMLTableRowsCollection returned by rows() on the HTMLTableElement.
Remove the per-table CollectionCache and let the collection manage that.
* html/HTMLTableRowsCollection.h:
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::create):
Tell the base class constructor to not retain the back-pointer to the table.
LayoutTests:
- Update gc-9.html to document the new lifetime characteristics of HTMLTableElement.rows.
- Add a test to verify that HTMLTableElement.rows returns the same object when called repeatedly.
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/table-rows-collection-idempotence-expected.txt: Added.
* fast/dom/table-rows-collection-idempotence.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 31 Dec 2011 02:43:33 +0000 (02:43 +0000)]
Cache and reuse the HTMLSelectElement.options collection.
<http://webkit.org/b/75399>
Reviewed by Anders Carlsson.
Source/WebCore:
Let HTMLSelectElement::options() cache the returned collection and tie it to the
lifetime of the form. This shrinks HTMLSelectElement by sizeof(CollectionCache)
minus one pointer.
Test: fast/dom/select-options-collection-idempotence.html
fast/gc-9.html
* html/HTMLSelectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::options):
Cache the HTMLOptionsCollection returned by options() on the HTMLSelectElement.
Remove the per-select CollectionCache and let the collection manage that.
* html/HTMLOptionsCollection.h:
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::create):
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
Tell the base class constructor to not retain the back-pointer to the element.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setRecalcListItems):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::invalidateCache):
Added so HTMLSelectElement can invalidate the collection without triggering
unnecessary instantiation of a CollectionCache.
LayoutTests:
- Update gc-9.html to document the new lifetime characteristics of HTMLSelectElement.options.
- Add a test to verify that HTMLSelectElement.options returns the same object when called repeatedly.
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/select-options-collection-idempotence-expected.txt: Added.
* fast/dom/select-options-collection-idempotence.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Sat, 31 Dec 2011 01:10:47 +0000 (01:10 +0000)]
Enable the [Supplemental] IDL on CMake
https://bugs.webkit.org/show_bug.cgi?id=75345
Reviewed by Daniel Bates.
This patch enables the [Supplemental] IDL on CMake by changing the build
flow of CMake as follows.
- Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
- New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,
including all attributes in the IDL files that are implementing $idl;
}
Tests: Confirm that build succeeds.
http/tests/websocket/tests/*
* CMakeLists.txt:
* UseJSC.cmake: Modified to reflect the new build flow as described above.
* UseV8.cmake: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sat, 31 Dec 2011 00:20:00 +0000 (00:20 +0000)]
[Qt] fast/css/absolute-inline-alignment.html fails
https://bugs.webkit.org/show_bug.cgi?id=75400
Unreviewed, skipping 2 new tests on Qt after r103851.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 30 Dec 2011 21:27:14 +0000 (21:27 +0000)]
[chromium] media/track/track-cue-rendering.html fails
https://bugs.webkit.org/show_bug.cgi?id=75098
Reviewed by Dan Bernstein.
* media/media-controls.js:
(textTrackDisplayElement): Don't assume there is only one shadow DOM element used to
display captions.
* media/track/track-cue-nothing-to-render-expected.txt: Updated.
* media/track/track-cue-nothing-to-render.html: Fix the test so it checks the track
container and cue text pseudo element properties separately.
* media/track/track-cue-rendering-expected.txt: Updated for textTrackDisplayElement change.
* media/track/track-cue-rendering.html: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Fri, 30 Dec 2011 20:58:29 +0000 (20:58 +0000)]
REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
https://bugs.webkit.org/show_bug.cgi?id=74723
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/css/absolute-inline-alignment-2.html
fast/css/absolute-inline-alignment.html
Inline positioned elements in the leading spaces of an inline run need to align to
adjacent text, so add them to the run as they're encountered.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineInfo::LineInfo): Keep a count of positioned objects encountered when
skipping leading whitespace.
(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::RenderBlock::constructLine): Leading positioned objects should not be considered
when deciding the number of runs in a line. Otherwise they would contribute towards line
height themselves and prevent a free-standing BR following the positioned object from providing a full
20px of height.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Since a run containing line-breaks will enter
skipLeadingWhitespace for each new line we reset the count every time so that the count of positioned
objects we encounter only affects the line they appear on. This case is covered by
fast/inline/styledEmptyInlinesWithBRs.html
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Add a run for each inline positioned object
encountered in leading white space. Keep a count of them so that they can be excluded from
the total number of runs in constructLine.
LayoutTests:
* fast/css/absolute-inline-alignment-2-expected.html: Added.
* fast/css/absolute-inline-alignment-2.html: Added.
* fast/css/absolute-inline-alignment-expected.html: Added.
* fast/css/absolute-inline-alignment.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Dec 2011 20:53:28 +0000 (20:53 +0000)]
media/video-scales-in-media-document.html is Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=75079
Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2011-12-30
Reviewed by Eric Carlson.
* platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
* platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Dec 2011 20:40:08 +0000 (20:40 +0000)]
Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=75376
Patch by Raymond Liu <raymond.liu@intel.com> on 2011-12-30
Reviewed by Adam Barth.
No new tests required.
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* html/canvas/CanvasRenderingContext2D.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 30 Dec 2011 20:15:16 +0000 (20:15 +0000)]
Cache and reuse the HTMLFormElement.elements collection.
<http://webkit.org/b/75375>
Reviewed by Anders Carlsson.
Source/WebCore:
Let HTMLFormElement::elements() cache the returned collection and tie it to the
lifetime of the form. This reduces memory consumption by ~70 kB (on 64-bit) when
viewing your average popular post on reddit.com.
Test: fast/dom/form-elements-collection-idempotence.html
fast/dom/gc-9.html
* html/HTMLFormElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
Cache the HTMLFormCollection returned by elements() on the HTMLFormElement.
Remove the per-form CollectionCache and let the collection manage that.
* html/HTMLCollection.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
Have the HTMLCollection constructor take a bool argument that decides whether
we retain the base node pointer or not. This mechanism is a temporary measure
until all collection types are owned by their respective base nodes.
* html/HTMLFormCollection.h:
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::create):
Tell the base class constructor to not retain the back-pointer to the form.
LayoutTests:
- Update gc-9.html to document the new lifetime characteristics of HTMLFormElement.elements.
- Add a test to verify that HTMLFormElement.elements returns the same object when called repeatedly.
* fast/dom/form-elements-collection-idempotence-expected.txt: Added.
* fast/dom/form-elements-collection-idempotence.html: Added.
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 30 Dec 2011 19:08:03 +0000 (19:08 +0000)]
Add a ParamStorageTraits specialization for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=75392
Reviewed by Daniel Bates.
* wtf/Functional.h:
Add a partial specialization of ParamStorageTraits for RetainPtr<T>.
* wtf/RetainPtr.h:
Bring in the retainPtr function template from WTF.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 30 Dec 2011 19:07:56 +0000 (19:07 +0000)]
Unreviewed buildfix after r103841.
* inspector/InspectorMemoryAgent.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 30 Dec 2011 18:35:53 +0000 (18:35 +0000)]
CSSStyleDeclaration: Only allow setting parent rule at construction.
<http://webkit.org/b/75391>
Reviewed by Dan Bernstein.
A CSSStyleDeclaration should only ever belong to one CSSRule. Enforce this
at compile-time by replacing setParentRule(CSSRule*) with clearParentRule().
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::~CSSFontFaceRule):
* css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::clearParentRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::~CSSStyleRule):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Fri, 30 Dec 2011 17:32:12 +0000 (17:32 +0000)]
WebKitCSSKeyframeRule.style.parentRule should point to the keyframe rule.
<http://webkit.org/b/75336>
Reviewed by Antti Koivisto.
Source/WebCore:
Let CSS animation keyframe rules .style.parentRule point back to the keyframe
board, rather than the keyframes rule containing it.
Test: fast/css/css-keyframe-style-parentRule.html
* css/CSSParser.cpp:
(WebCore::CSSParser::createKeyframeRule):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::setDeclaration):
Set the CSSMutableStyleDeclaration's parent rule when creating it instead
of in WebKitCSSKeyframeRule::setDeclaration(). Add assertion to make sure
it's only called with declarations already parented to the keyframe rule.
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::append):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
Stop reparenting keyframe rules' style declarations to the keyframes rule.
LayoutTests:
* fast/css/css-keyframe-style-parentRule-expected.txt: Added.
* fast/css/css-keyframe-style-parentRule.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 30 Dec 2011 17:01:20 +0000 (17:01 +0000)]
EnvironmentUtilities::stripValuesEndingWithString fails when the variable ends with the search value
https://bugs.webkit.org/show_bug.cgi?id=75389
Reviewed by Anders Carlsson.
* Platform/unix/EnvironmentUtilities.cpp:
(WebKit::EnvironmentUtilities::stripValuesEndingWithString): Fixed an off-by-1 error when
examining the character after the match.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Dec 2011 13:11:36 +0000 (13:11 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-30
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 30 Dec 2011 10:30:58 +0000 (10:30 +0000)]
Web Inspector: use typed front-end API in the memory agent
https://bugs.webkit.org/show_bug.cgi?id=75382
Memory agent now uses generate C++ API for communicating to the front-end.
Reviewed by Pavel Feldman.
* inspector/InspectorMemoryAgent.cpp:
(WebCore::DOMTreeStatistics::CounterVisitor::CounterVisitor):
(WebCore::DOMTreeStatistics::CounterVisitor::counters):
(WebCore::DOMTreeStatistics::CounterVisitor::visitNode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Fri, 30 Dec 2011 10:29:05 +0000 (10:29 +0000)]
[Chromium] Unreviewed test expectations change for nested-reflection tests.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 30 Dec 2011 10:17:20 +0000 (10:17 +0000)]
Web Inspector: migrate from "attached" to "compact" styles.
https://bugs.webkit.org/show_bug.cgi?id=75381
Source/WebCore:
When front-end is docked to right, it should look like "detached", but is still "attached".
Use "compact" mode instead of "attached" mode in the styles to mitigate it.
Reviewed by Yury Semikhatsky.
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.updateSearchLabel):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype.set compact):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):
* inspector/front-end/helpScreen.css:
(body.compact .help-window-outer):
(body.compact .help-window-main):
(body.compact .help-window-caption):
(body.compact .help-close-button):
(body.compact .help-content):
* inspector/front-end/inspector.css:
(body.compact #toolbar):
(body.compact.port-qt #toolbar):
(body.compact.inactive #toolbar):
(body.compact #search-toolbar-label):
(body.compact #toolbar-dropdown-arrow):
(body.compact #search):
(body.compact.port-qt .toolbar-item.close-left, body.compact.port-qt .toolbar-item.close-right):
(body.compact #main):
* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector.get isCompactMode):
(WebInspector.get _setCompactMode):
(WebInspector._installDockToRight.listener.get if):
(WebInspector._installDockToRight.listener):
* inspector/front-end/inspectorCommon.css:
(body.dock-to-right):
(body.dock-to-right.inactive):
Source/WebKit/chromium:
Reviewed by Yury Semikhatsky.
When front-end is docked to right, it should look like "detached", but is still "attached".
Use "compact" mode instead of "attached" mode in the styles to mitigate it.
* src/js/devTools.css:
(body.compact #toolbar):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Dec 2011 09:20:18 +0000 (09:20 +0000)]
Unreviewed, rolling out r103794.
http://trac.webkit.org/changeset/103794
https://bugs.webkit.org/show_bug.cgi?id=75379
the ASSERT is triggered by several tests (Requested by
jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-30
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::recalcSections):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
* rendering/RenderTable.h:
(WebCore::RenderTable::header):
(WebCore::RenderTable::footer):
(WebCore::RenderTable::firstBody):
(WebCore::RenderTable::hasSections):
(WebCore::RenderTable::topSection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Fri, 30 Dec 2011 08:43:46 +0000 (08:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75373
[Chromium] Remove WebWorkerClient.h
After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed.
Reviewed by Adam Barth.
* WebKit.gyp:
* public/WebFrameClient.h:
* public/WebWorkerClient.h: Removed.
* src/WebSharedWorkerImpl.h:
* src/WebWorkerBase.cpp:
* src/WebWorkerClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Dec 2011 06:24:22 +0000 (06:24 +0000)]
Unreviewed, rolling out r103831.
http://trac.webkit.org/changeset/103831
https://bugs.webkit.org/show_bug.cgi?id=75377
broke chromium build (Requested by dslomov_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-29
* WebKit.gyp:
* public/WebFrameClient.h:
* public/WebWorkerClient.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.
* src/WebSharedWorkerImpl.h:
* src/WebWorkerBase.cpp:
* src/WebWorkerClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 30 Dec 2011 06:01:06 +0000 (06:01 +0000)]
Web Inspector: enable dock-to-right view (still need embedders to support it).
https://bugs.webkit.org/show_bug.cgi?id=75360
Patch by Pavel Feldman <pfeldman@google.com> on 2011-12-29
Reviewed by Yury Semikhatsky.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/inspector.js:
(WebInspector.set attached):
(WebInspector._renderAsAttached.get return):
(WebInspector._renderAsAttached):
(WebInspector._installDockToRight.updateToolbar):
Source/WebKit/chromium:
* src/js/DevTools.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 30 Dec 2011 04:59:05 +0000 (04:59 +0000)]
debug-safari --no-saved-state fails to start the debugger
https://bugs.webkit.org/show_bug.cgi?id=75374
Reviewed by Sam Weinig.
* Scripts/webkitdirs.pm:
(execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
the executable being debugged.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 30 Dec 2011 04:50:17 +0000 (04:50 +0000)]
It should be easier to iterate a Vector backwards
https://bugs.webkit.org/show_bug.cgi?id=75359
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
Adds Vector::rbegin(), Vector::rend(), and Vector::reversed(),
a new proxy driven way to access a vector backwards. One can use
reversed() in a range-based for loop like so:
for (auto val: myVector.reversed())
doSomething(val)
* wtf/Vector.h:
(WTF::Vector::~Vector):
Fix style.
(WTF::Vector::rbegin):
(WTF::Vector::rend):
Added using standard adaptor std::reverse_iterator.
(WTF::Vector::reversed):
(WTF::Vector::VectorReverseProxy::begin):
(WTF::Vector::VectorReverseProxy::end):
Add proxy similar to one used in HashMap for keys() and values()
which allows access to a Vector backwards for use in range-based
for loops.
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/TestWebKitAPI.gypi:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Add new Vector test.
* TestWebKitAPI/Tests/Vector.cpp: Added.
(TestWebKitAPI::TEST):
Test Vector iterators, reverse_iterators and new reversed proxy.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 30 Dec 2011 02:28:44 +0000 (02:28 +0000)]
Use IDL overloads in AudioContext.idl for createBuffer
https://bugs.webkit.org/show_bug.cgi?id=75293
Patch by Raymond Liu <raymond.liu@intel.com> on 2011-12-29
Reviewed by Adam Barth.
No new tests required.
* bindings/js/JSAudioContextCustom.cpp:
* bindings/v8/custom/V8AudioContextCustom.cpp:
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createBuffer):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Fri, 30 Dec 2011 02:13:12 +0000 (02:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75373
[Chromium] Remove WebWorkerClient.h
After coordinated patch in chromium, WebWorkerClient alias for WebSharedWorkerClient is no longer needed.
Reviewed by Adam Barth.
* WebKit.gyp:
* public/WebFrameClient.h:
* public/WebWorkerClient.h: Removed.
* src/WebSharedWorkerImpl.h:
* src/WebWorkerBase.cpp:
* src/WebWorkerClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 29 Dec 2011 23:49:52 +0000 (23:49 +0000)]
[chromium] Unreviewed, add a bug number to a failing test.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Thu, 29 Dec 2011 23:40:07 +0000 (23:40 +0000)]
Unreviewed chromium expectation changes to skip array-splice.html.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 29 Dec 2011 23:30:17 +0000 (23:30 +0000)]
HTMLDivElement: Remove unnecessary variable in parseMappedAttribute().
<http://webkit.org/b/75363>
Reviewed by Daniel Bates.
* html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::parseMappedAttribute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 29 Dec 2011 23:27:28 +0000 (23:27 +0000)]
HTMLParagraphElement: Remove unnecessary variable in parseMappedAttribute().
<http://webkit.org/b/75362>
Reviewed by Daniel Bates.
* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::parseMappedAttribute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 29 Dec 2011 23:25:18 +0000 (23:25 +0000)]
Use HashMap<OwnPtr> for Document's named item collection caches.
<http://webkit.org/b/75335>
Reviewed by Daniel Bates.
* dom/Document.cpp:
(WebCore::Document::~Document):
Remove now-unneeded deleteAllValues() loop.
(WebCore::Document::nameCollectionInfo):
Use add() instead of find()/add() to avoid one extra hash lookup.
* dom/Document.h:
Switch the value type of m_nameCollectionInfo to use OwnPtr.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 29 Dec 2011 22:49:02 +0000 (22:49 +0000)]
mfenced skips the first separator if the separators attribute contains multiple separators
https://bugs.webkit.org/show_bug.cgi?id=57697
Patch by David Barton <dbarton@mathscribe.com> on 2011-12-29
Reviewed by Dan Bernstein.
Source/WebCore:
Added 2 test cases.
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::addChild):
- Thanks to Xun Sun <xun.sun@intel.com> for the off-by-one error fix.
LayoutTests:
* mathml/presentation/fenced-mi.xhtml:
- Added 2 test cases.
* platform/mac/mathml/presentation/fenced-mi-expected.png:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 29 Dec 2011 22:40:55 +0000 (22:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75140
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Start cleaning up JSArray construction. JSArray has a set of create methods,
one of which (currently) takes a 'creation mode' enum parameter. Based on that
parameter, the constructor does one of two completely different things. If the
parameter is 'CreateInitialized' it creates an array, setting the length, but
does not eagerly allocate a storage vector of the specified length. A small
(BASE_VECTOR_LEN sized) initial vector will be allocated, and cleared, property
access to the vector will read the hole value (return undefined). The alternate
usage of this method ('CreateCompact') does something very different. It tries
to create an array of the requested length, and also allocates a storage vector
large enough to hold all properties. It does not clear the storage vector,
leaving the memory uninitialized and requiring the user to call a method
'uncheckedSetIndex' to initialize values in the vector.
This patch factors out these two behaviours, moving the 'CreateCompact' mode
into its own method, 'tryCreateUninitialized' (matching the naming for this
functionality in the string classes). 'tryCreateUninitialized' may return 0 if
memory allocation fails during construction of the object. The construction
pattern changes such that values added during initialization will be marked if
a GC is triggered during array allocation. 'CreateInitialized' no longer need
be passed to create a normal, fully constructed array with a length, and this
method is merged with the version of 'create' that does not take an initial
length (length parameter defaults to 0).
* JavaScriptCore.exp:
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- removed 'CreateInitialized' argument
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
- changed to call 'tryCreateUninitialized'
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
- changed to call 'tryCreateUninitialized'
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
- initialize m_storage to null; if construction fails, make destruction safe
(JSC::JSArray::finishCreation):
- merge versions of this method, takes an initialLength parameter defaulting to zero
(JSC::JSArray::tryFinishCreationUninitialized):
- version of 'finishCreation' that tries to eagerly allocate storage; may fail & return 0
(JSC::JSArray::~JSArray):
- check for null m_storage, in case array construction failed.
(JSC::JSArray::increaseVectorPrefixLength):
* runtime/JSArray.h:
(JSC::JSArray::create):
- merge versions of this method, takes an initialLength parameter defaulting to zero
(JSC::JSArray::tryCreateUninitialized):
- version of 'create' that tries to eagerly allocate storage; may fail & return 0
(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):
- used in conjunction with 'tryCreateUninitialized' to initialize the array
* runtime/JSGlobalObject.h:
(JSC::constructEmptyArray):
- removed 'CreateInitialized' argument
* runtime/RegExpConstructor.cpp:
(JSC::RegExpMatchesArray::finishCreation):
- removed 'CreateInitialized' argument
LayoutTests:
Added test case.
* fast/js/script-tests/array-splice.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 29 Dec 2011 22:29:28 +0000 (22:29 +0000)]
[chromium] Unreviewed, unskip http/tests/plugins/geturlnotify-from-npp-destroystream.html
since it passes on my Mac Chromium build. Move plugins/inner-html-display-none-expected.txt
from chromium-win to chromium-- it's a V8 specific result.
* platform/chromium/plugins/inner-html-display-none-expected.txt: Renamed from LayoutTests/platform/chromium-win/plugins/inner-html-display-none-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 29 Dec 2011 22:18:39 +0000 (22:18 +0000)]
Unreviewed, rolling out r103808.
http://trac.webkit.org/changeset/103808
https://bugs.webkit.org/show_bug.cgi?id=75370
Tests failed on Chrome Canary bots. (Requested by atwilson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-29
* media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/platform/chromium/media/video-scales-in-media-document-expected.txt.
* media/video-scales-in-media-document.html: Renamed from LayoutTests/platform/chromium/media/video-scales-in-media-document.html.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 29 Dec 2011 22:02:00 +0000 (22:02 +0000)]
[chromium] Unreviewed, rebaseline new flexbox repaint tests on chromium mac
and remove http/tests/plugins/geturlnotify-from-npp-destroystream.html
from test_expectations.txt since it's passing on Win/Linux.
* platform/chromium-cg-mac-leopard/css3/flexbox/repaint-expected.png: Added.
* platform/chromium-cg-mac-leopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
* platform/chromium-mac-leopard/css3/flexbox/repaint-expected.png: Added.
* platform/chromium-mac-leopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/flexbox/repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/flexbox/repaint-rtl-column-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 29 Dec 2011 21:45:57 +0000 (21:45 +0000)]
[chromium] Unreviewed, add a png baseline for
mouse-click-plugin-clears-selection on chromium-win and re-add 2 flaky svg tests.
* platform/chromium-cg-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
* platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
* platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
* platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png: Renamed from LayoutTests/platform/chromium-win-vista/plugins/mouse-click-plugin-clears-selection-expected.png.
* platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.txt.
* platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/plugins/mouse-click-plugin-clears-selection-expected.png.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 29 Dec 2011 21:27:11 +0000 (21:27 +0000)]
Add a retainPtr function template
https://bugs.webkit.org/show_bug.cgi?id=75365
Reviewed by Dan Bernstein.
This makes it easier to make a RetainPtr using template argument deduction, which
is useful when passing RetainPtr objects as function arguments.
* wtf/RetainPtr.h:
(WTF::retainPtr):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 29 Dec 2011 20:34:37 +0000 (20:34 +0000)]
Enable the [Supplemental] IDL on Qt.
https://bugs.webkit.org/show_bug.cgi?id=75274
Reviewed by Andreas Kling.
http://trac.webkit.org/changeset/103783 broke the Qt SL bot.
This patch fixes the problem by using 'tr' rather than 'sed' which
seems to be more consistent between Mac and Linux.
* DerivedSources.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 29 Dec 2011 20:18:22 +0000 (20:18 +0000)]
animation-drt-api-multiple-keyframes.html cannot possibly fail
https://bugs.webkit.org/show_bug.cgi?id=73112
Reviewed by Simon Fraser.
Output a FAIL message when we fail to pause the animation. This matches the
failure mode before <https://trac.webkit.org/changeset/84873> (bug #59389).
Additionally, fixes an issue where we paused at a time after cessation of the
animation following <https://trac.webkit.org/changeset/84873>. Instead, we
should pause at a time before cessation of the animation.
* animations/animation-drt-api-multiple-keyframes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 29 Dec 2011 19:08:38 +0000 (19:08 +0000)]
Web Inspector: Scripts navigator should support incremental search by typing.
https://bugs.webkit.org/show_bug.cgi?id=75349
Reviewed by Pavel Feldman.
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.show):
(WebInspector.ScriptsNavigator.prototype._reset):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
* inspector/front-end/inspector.css:
(.outline-disclosure ol.search-match-not-found li.selected .selection):
(.outline-disclosure ol.search-match-found li.selected):
(.outline-disclosure ol.search-match-found li.selected *):
(.outline-disclosure ol.search-match-found li.parent.selected::before):
(.outline-disclosure ol.search-match-found li.parent.expanded.selected::before):
* inspector/front-end/scriptsPanel.css:
(#scripts-navigator-tree-search-box):
(#scripts-navigator-tree-search-box.visible):
(#scripts-navigator-tree-search-box > input):
(.scripts.panel .navigator .search-match-found li.selected .selection):
(.scripts.panel .navigator .search-match-not-found li.selected .selection):
(.scripts.panel .navigator .searching li.selected .selection):
* inspector/front-end/treeoutline.js:
(TreeOutline):
(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._startSearch.focusSearchInput):
(TreeOutline.prototype._startSearch):
(TreeOutline.prototype._searchTextChanged):
(TreeOutline.prototype._showSearchMatchElement):
(TreeOutline.prototype._searchInputKeyDown):
(TreeOutline.prototype._nextSearchMatch):
(TreeOutline.prototype._previousSearchMatch):
(TreeOutline.prototype._searchInputBlur):
(TreeOutline.prototype._searchFinished):
(TreeOutline.prototype.stopSearch):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Thu, 29 Dec 2011 18:56:44 +0000 (18:56 +0000)]
Web Inspector: Scripts navigator should trim long file names and show full url in tooltip.
https://bugs.webkit.org/show_bug.cgi?id=75343
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/debugger/ui-source-code-display-name.html
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
(WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._appendSourceFrameTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab.get if):
(WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab):
(WebInspector.TabbedEditorContainer.prototype.get replaceSourceFrames):
(WebInspector.TabbedEditorContainer.prototype.reset):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.changeTabTooltip):
(WebInspector.TabbedPaneTab):
(WebInspector.TabbedPaneTab.prototype.get tooltip):
(WebInspector.TabbedPaneTab.prototype.set tooltip):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._parseURL):
* inspector/front-end/utilities.js:
():
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/ui-source-code-display-name-expected.txt: Added.
* inspector/debugger/ui-source-code-display-name.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 29 Dec 2011 18:52:25 +0000 (18:52 +0000)]
getComputedStyle for margin is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75358
Reviewed by Andreas Kling.
Source/WebCore:
Implement getComputedStyle for margin.
Test: fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to cover that we return correct values.
* fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 29 Dec 2011 18:44:45 +0000 (18:44 +0000)]
Use HashMap<OwnPtr> in RenderSVGResourcePattern
https://bugs.webkit.org/show_bug.cgi?id=75361
Reviewed by Andreas Kling.
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::removeAllClientsFromCache):
(WebCore::RenderSVGResourcePattern::removeClientFromCache):
(WebCore::RenderSVGResourcePattern::applyResource): use HashMap::add() to avoid
looking up the hash twice.
* rendering/svg/RenderSVGResourcePattern.h: rename m_pattern to m_patternMap to
improve readability a little bit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 29 Dec 2011 18:36:52 +0000 (18:36 +0000)]
getComputedStyle for padding is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75352
Reviewed by Andreas Kling.
Source/WebCore:
Implement getComputedStyle for padding shorthand property.
Test: fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to cover that we return correct values.
* fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 29 Dec 2011 18:21:17 +0000 (18:21 +0000)]
[GTK] media/video-scales-in-media-document.html fails
https://bugs.webkit.org/show_bug.cgi?id=75079
Moves the test into platform/chromium/media and removes the Skipped
entry for gtk.
Patch by Dale Curtis <dalecurtis@chromium.org> on 2011-12-29
Reviewed by Eric Carlson.
* platform/chromium/media/video-scales-in-media-document-expected.txt: Renamed from LayoutTests/media/video-scales-in-media-document-expected.txt.
* platform/chromium/media/video-scales-in-media-document.html: Renamed from LayoutTests/media/video-scales-in-media-document.html.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 29 Dec 2011 17:52:48 +0000 (17:52 +0000)]
Use HashMap<OwnPtr> in OriginAccessMap
https://bugs.webkit.org/show_bug.cgi?id=75327
Reviewed by Andreas Kling.
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 29 Dec 2011 17:22:51 +0000 (17:22 +0000)]
[Qt] Remove unused m_signalListeners from WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=75354
Reviewed by Andreas Kling.
This is unused since r76507.
* Platform/WorkQueue.h:
* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::platformInvalidate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 29 Dec 2011 17:12:45 +0000 (17:12 +0000)]
Web Inspector: support sourceMappingURL magic comment.
https://bugs.webkit.org/show_bug.cgi?id=75356
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::findSourceMapURL):
* inspector/ContentSearchUtils.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug.html:
* http/tests/inspector/resources/compiled.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 29 Dec 2011 17:08:05 +0000 (17:08 +0000)]
Web Inspector: Suggest pop-over doesn't hide on tab switch
https://bugs.webkit.org/show_bug.cgi?id=73611
Reviewed by Pavel Feldman.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.willHide):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.acceptSuggestion):
(WebInspector.TextPrompt.prototype.hideSuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 29 Dec 2011 17:02:43 +0000 (17:02 +0000)]
Web Inspector: Implement CSS selector profiler
https://bugs.webkit.org/show_bug.cgi?id=74004
Reviewed by Pavel Feldman.
Source/WebCore:
This implementation of CSS selector profiler measures the total time required to match a certain selector
against DOM nodes and apply the style declaration properties to the particular element,
as well as the number of selector matches (i.e. the number of nodes that matched the selector.)
The results are approximate due to internal matching algorithm optimizations (shared styles et al.)
Multiple selectors with the same selectorText are coalesced into a single record.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/CSSSelectorProfileView.js: Added.
(WebInspector.CSSSelectorDataGridNode):
(WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.get statusBarItems):
(WebInspector.CSSSelectorProfileView.prototype.get profile):
(WebInspector.CSSSelectorProfileView.prototype.set profile):
(WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):
(WebInspector.CSSSelectorProfileView.prototype.refreshShowAsPercents):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.get selectorComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.timeComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile.matchesComparator):
(WebInspector.CSSSelectorProfileView.prototype._sortProfile):
(WebInspector.CSSSelectorProfileType):
(WebInspector.CSSSelectorProfileType.prototype.get buttonTooltip):
(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype.get treeItemTitle):
(WebInspector.CSSSelectorProfileType.prototype.get description):
(WebInspector.CSSSelectorProfileType.prototype.reset):
(WebInspector.CSSSelectorProfileType.prototype.isRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.setRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CSSSelectorProfileType.prototype.createView):
* inspector/front-end/DetailedHeapshotView.js:
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.reset):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/profilesPanel.css:
LayoutTests:
* inspector/profiler/detailed-heapshots-test.js:
(initialize_DetailedHeapshotTest):
* inspector/profiler/profiler-test.js:
(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 29 Dec 2011 16:39:08 +0000 (16:39 +0000)]
[GTK] Context menu is hidden right after showing it when first menu item is not disabled
https://bugs.webkit.org/show_bug.cgi?id=75357
Reviewed by Martin Robinson.
The problem is that we are passing GDK_CURRENT_TIME (which is 0)
to gtk_popup_menu, because the events are async and
gtk_get_current_event is NULL when calling gtk_menu_popup. GtkMenu
has a timeout to decide whether the press-release was fast enough
and ignore the button release event in that case. That way, a
normal right click shows the menu while a long press hides the
menu when the button is released. So, we need to know the real time
when the right button was pressed and pass it to gtk_popup_menu.
* UIProcess/WebPageProxy.h: Make
currentlyProcessedMouseDownEvent() public.
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::showContextMenu): Use
WebPageProxy::currentlyProcessedMouseDownEvent() to get the
current mouse event and pass its button number and time to
gtk_popup_menu.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 29 Dec 2011 16:33:38 +0000 (16:33 +0000)]
[GTK] Fix several conding style issues in WebKit2 GTK+ code
https://bugs.webkit.org/show_bug.cgi?id=75339
Reviewed by Martin Robinson.
In addition to the WebKit coding style, code in UIProcess/API/gtk
should follow style and conventions described here
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
* UIProcess/API/gtk/WebKitSettings.cpp: Remove trailing whitespaces.
(webkit_settings_class_init): Remove trailing whitespaces, fix
indentation issues in API doc comments, add missing trailing to
some properties.
(webkit_settings_set_enable_fullscreen): Move the code after
get_enable_fullscreen() for consistency.
* UIProcess/API/gtk/WebKitSettings.h: Remove trailing
whitespaces. Fix * placement and line up parameters.
* UIProcess/API/gtk/WebKitWebView.cpp: Remove several empty lines.
(webkit_web_view_class_init): Mark property nicks and blurbs for translation.
(webkitWebViewSetTitle): Remove trailing whitespaces.
* UIProcess/API/gtk/WebKitWebView.h: Line up parameters.
* UIProcess/API/gtk/WebKitWebViewBase.cpp: Use the angle-bracket
form for including file from WebCore and wtf. Use GRefPtr for
GtkIMContext and bool instead of gboolean. Use the placement new
syntax for private struct instead of new/delete.
(webkitWebViewBaseRealize):
(webkitWebViewBaseFinalize):
(webkit_web_view_base_init):
(webkitWebViewBaseFocusInEvent):
(webkitWebViewBaseFocusOutEvent):
(webkitWebViewBaseKeyPressEvent): Remove trailing whitespaces.
(webkitWebViewBaseKeyReleaseEvent):
(webkit_web_view_base_class_init):
(webkitWebViewBaseGetIMContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 29 Dec 2011 15:08:57 +0000 (15:08 +0000)]
Unreviewed, rolling out r103798.
http://trac.webkit.org/changeset/103798
https://bugs.webkit.org/show_bug.cgi?id=75353
some small scrollbar differences are making the tests fail on
several platforms (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-29
Source/WebCore:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
LayoutTests:
* fast/layers/scroll-with-transform-composited-layer-expected.html: Removed.
* fast/layers/scroll-with-transform-composited-layer.html: Removed.
* fast/layers/scroll-with-transform-layer-expected.html: Removed.
* fast/layers/scroll-with-transform-layer.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 29 Dec 2011 14:58:11 +0000 (14:58 +0000)]
Web Inspector: Focus of the DOM tree is not restored when switching to the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=75351
Reviewed by Yury Semikhatsky.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.wasShown):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 29 Dec 2011 14:06:18 +0000 (14:06 +0000)]
REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=67100
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/layers/scroll-with-transform-composited-layer-expected.html
fast/layers/scroll-with-transform-composited-layer.html
fast/layers/scroll-with-transform-layer-expected.html
fast/layers/scroll-with-transform-layer.html
The regression came from a previous optimization that was wrongly kept after r93614.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Remove the early return for transformed layer. This change worked as we used
to call updateLayerPositions from scrollTo which would call updateLayerPosition on
all our descendants. After r93614, this is no longer the case and we explicitely need
to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.
LayoutTests:
Added 2 ref tests for scrolling inside a transformed layers (either composited
or not).
* fast/layers/scroll-with-transform-composited-layer-expected.html: Added.
* fast/layers/scroll-with-transform-composited-layer.html: Added.
* fast/layers/scroll-with-transform-layer-expected.html: Added.
* fast/layers/scroll-with-transform-layer.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 29 Dec 2011 13:28:52 +0000 (13:28 +0000)]
Web Inspector: Tree views can be collapsed/hidden using the keyboard arrows
https://bugs.webkit.org/show_bug.cgi?id=46272
Reviewed by Yury Semikhatsky.
WebInspector.SidebarSectionTreeElement which is not selectable has also been made non-collapsible
and expanded by default.
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._registerProfileType):
* inspector/front-end/SidebarTreeElement.js:
(WebInspector.SidebarSectionTreeElement):
(WebInspector.SidebarSectionTreeElement.prototype.selectable.false.collapse):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 29 Dec 2011 13:10:48 +0000 (13:10 +0000)]
Web Inspector: [chromium] pass dock to side request to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=75344
Reviewed by Yury Semikhatsky.
Source/WebCore:
I'd like to enable dock-to-right for the front-end window. This is a background work
to pass control flow from the front-end to the front-end host.
* inspector/InspectorFrontendClient.h:
* inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::requestSetDockSide):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
Source/WebKit/chromium:
* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::requestSetDockSide):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::requestSetDockSide):
* src/InspectorFrontendClientImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 29 Dec 2011 12:16:05 +0000 (12:16 +0000)]
Web Inspector: add "enable source maps" checkbox setting.
https://bugs.webkit.org/show_bug.cgi?id=75311
Reviewed by Pavel Feldman.
Source/WebCore:
When "enable source maps" is on, all auto detected source maps are silently applied.
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
* inspector/front-end/inspector.js:
(WebInspector._toolbarItemClicked):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug-expected.txt:
* http/tests/inspector/compiler-source-mapping-debug.html:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 29 Dec 2011 11:21:20 +0000 (11:21 +0000)]
Tighten our checks for needsSectionRecalc in RenderTable
https://bugs.webkit.org/show_bug.cgi?id=73972
Reviewed by Adam Barth.
Refactoring covered under the new tests.
Now most of the functions use the header, first body and footer's
getters that checks if we need a section recalculation. The only
exceptions are addChild and recalcSections as they can be called
with the bit set.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
Updated the previous functions to use the sections' getters.
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::recalcSections):
Update the previous functions after the 2 renames
(see below).
* rendering/RenderTable.h:
(WebCore::RenderTable::header):
(WebCore::RenderTable::footer):
(WebCore::RenderTable::firstBody):
Added some ASSERT here. Also renamed m_head to m_header
and m_foot to m_footer to match the getter and to avoid
unneeded abbreviation.
(WebCore::RenderTable::hasSections):
(WebCore::RenderTable::topSection):
Updated the previous functions to use the section getters.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 29 Dec 2011 10:50:30 +0000 (10:50 +0000)]
Use HashMap<OwnPtr> for UserScriptMap and UserStyleSheetMap
https://bugs.webkit.org/show_bug.cgi?id=75323
Reviewed by Darin Adler.
* dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld): fix a small mistake in
previous code. Now the entry for world is removed (and deleted) only if its
stylesheet vector is empty.
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):
* page/UserScriptTypes.h:
* page/UserStyleSheetTypes.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuqiang.xian@intel.com [Thu, 29 Dec 2011 04:33:20 +0000 (04:33 +0000)]
spill unboxed values in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=75291
Reviewed by Filip Pizlo.
Currently all the values are spilled as boxed in DFG 32_64, which is
not necessary and introduces additional stores/loads. Instead we
can spill them as unboxed if feasible. It can be applied to the
Integers, Cells and Booleans in DFG 32_64. Doubles are left as is
because they don't need to be boxed at all. The modifications to the
spill/fill and the OSR exit are required, as well as a bug fix to the
"isUnknownJS" logic.
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::displacedInRegisterFile):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dump):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::isUnknownJS):
(JSC::DFG::GenerationInfo::spill):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::isKnownNotBoolean):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::silentFillGPR):
(JSC::DFG::SpeculativeJIT::spill):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 29 Dec 2011 03:56:25 +0000 (03:56 +0000)]
Reduce memory used by NamedNodeMap.
<http://webkit.org/b/75333>
Reviewed by Sam Weinig.
Give NamedNodeMap's attribute vector an inline capacity of 4. The vast majority
of elements have <= 4 attributes, and if they don't have any we normally don't
allocate an attribute map at all.
This reduces memory consumption by 1.2MB (on 64-bit) when loading the full HTML5
spec at <http://whatwg.org/c>.
* dom/NamedNodeMap.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 29 Dec 2011 03:54:44 +0000 (03:54 +0000)]
Reduce memory used by SpaceSplitString.
<http://webkit.org/b/75315>
Reviewed by Sam Weinig.
Split the string upon creation instead of waiting until it's accessed.
This allows us to get rid of all data members except the substring vector.
Since we're storing AtomicStrings, this is way more memory-efficient than
the previous implementation in the majority of cases.
Also reduced the inline capcity of the vector to 2 (from 8), after testing
showed this to cover 90% of the cases on the Alexa top sites.
All in all this reduces memory consumption by 1.1MB (on 64-bit) when
loading the full HTML5 spec at <http://whatwg.org/c>. On that same page,
less than 2ms is spent (on my MBP) splitting the ~20000 strings.
* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::createVector):
(WebCore::SpaceSplitStringData::containsAll):
(WebCore::SpaceSplitStringData::remove):
* dom/SpaceSplitString.h:
(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitStringData::contains):
(WebCore::SpaceSplitStringData::size):
(WebCore::SpaceSplitStringData::operator[]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Thu, 29 Dec 2011 02:03:47 +0000 (02:03 +0000)]
Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:
- WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
- NewWebCommonWorkerClient renamed to WebCommonWorkerClient
- WebWorkerBase merged into WebSharedWorkerImpl
- NewWebWorkerBase renamed into WebWorkerBase
WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.
Reviewed by David Levin.
* WebKit.gyp:
* public/WebCommonWorkerClient.h:
* public/WebSharedWorker.h:
* public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):
* public/WebWorkerClient.h:
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.cpp:
(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):
* src/WebWorkerBase.cpp:
(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
* src/WebWorkerBase.h:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::commonClient):
* src/WebWorkerImpl.cpp: Removed.
* src/WebWorkerImpl.h: Removed.
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:
Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:
- WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
- NewWebCommonWorkerClient renamed to WebCommonWorkerClient
- WebWorkerBase merged into WebSharedWorkerImpl
- NewWebWorkerBase renamed into WebWorkerBase
Reviewed by David Levin.
* DumpRenderTree/chromium/TestWebWorker.h:
(TestWebWorker::createWorker):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createWorker):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 29 Dec 2011 01:25:47 +0000 (01:25 +0000)]
[GTK] Fix compilation issue when selecting opengl for Accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=75309
Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-12-28
Reviewed by Martin Robinson.
.:
Replace WTF_USE_TEXTURE_MAPPER_OPENGL to WTF_USE_TEXTURE_MAPPER_GL
* GNUmakefile.am:
Source/WebCore:
Add TextureMapperGL and TextureMapperGLCairo files.
They define new classes required to implement TextureMapperGL for GTK port.
No new tests required.
* GNUmakefile.list.am:
* platform/graphics/cairo/TextureMapperGLCairo.cpp: Added.
(WebCore::BGRA32PremultimpliedBufferCairo::BGRA32PremultimpliedBufferCairo):
(WebCore::BGRA32PremultimpliedBufferCairo::~BGRA32PremultimpliedBufferCairo):
(WebCore::BGRA32PremultimpliedBufferCairo::beginPaint):
(WebCore::BGRA32PremultimpliedBufferCairo::data):
(WebCore::BGRA32PremultimpliedBufferCairo::endPaint):
(WebCore::uidForImage):
(WebCore::BGRA32PremultimpliedBuffer::create):
* platform/graphics/cairo/TextureMapperGLCairo.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 29 Dec 2011 01:14:01 +0000 (01:14 +0000)]
Unreviewed, rolling out r103785.
http://trac.webkit.org/changeset/103785
https://bugs.webkit.org/show_bug.cgi?id=75332
Broke builders; looks like clobbering didnt help (Requested by
dslomov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28
Source/WebKit/chromium:
* WebKit.gyp:
* public/WebCommonWorkerClient.h:
(WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebCommonWorkerClient::allowFileSystem):
(WebKit::WebCommonWorkerClient::openFileSystem):
(WebKit::WebCommonWorkerClient::dispatchDevToolsMessage):
(WebKit::WebCommonWorkerClient::saveDevToolsAgentState):
(WebKit::WebCommonWorkerClient::~WebCommonWorkerClient):
* public/WebFrameClient.h:
(WebKit::WebFrameClient::createWorker):
* public/WebSharedWorker.h:
* public/WebSharedWorkerClient.h: Removed.
* public/WebWorkerClient.h:
(WebKit::WebWorkerClient::~WebWorkerClient):
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorker::create):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::newCommonClient):
* src/WebWorkerBase.cpp:
(WebKit::initializeWebKitStaticValues):
(WebKit::WebWorkerBase::WebWorkerBase):
(WebKit::WebWorkerBase::~WebWorkerBase):
(WebKit::WebWorkerBase::stopWorkerThread):
(WebKit::WebWorkerBase::initializeLoader):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
(WebKit::WebWorkerBase::invokeTaskMethod):
(WebKit::WebWorkerBase::didCreateDataSource):
(WebKit::WebWorkerBase::createApplicationCacheHost):
(WebKit::WebWorkerBase::postMessageToWorkerObject):
(WebKit::WebWorkerBase::postMessageTask):
(WebKit::WebWorkerBase::postExceptionToWorkerObject):
(WebKit::WebWorkerBase::postExceptionTask):
(WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
(WebKit::WebWorkerBase::postConsoleMessageTask):
(WebKit::WebWorkerBase::postMessageToPageInspector):
(WebKit::WebWorkerBase::postMessageToPageInspectorTask):
(WebKit::WebWorkerBase::updateInspectorStateCookie):
(WebKit::WebWorkerBase::updateInspectorStateCookieTask):
(WebKit::WebWorkerBase::confirmMessageFromWorkerObject):
(WebKit::WebWorkerBase::confirmMessageTask):
(WebKit::WebWorkerBase::reportPendingActivity):
(WebKit::WebWorkerBase::reportPendingActivityTask):
(WebKit::WebWorkerBase::workerContextClosed):
(WebKit::WebWorkerBase::workerContextClosedTask):
(WebKit::WebWorkerBase::workerContextDestroyed):
(WebKit::WebWorkerBase::workerContextDestroyedTask):
(WebKit::WebWorkerBase::postTaskToLoader):
(WebKit::WebWorkerBase::postTaskForModeToWorkerContext):
* src/WebWorkerBase.h:
(WebKit::WebWorkerBase::view):
(WebKit::WebWorkerBase::setWorkerThread):
(WebKit::WebWorkerBase::workerThread):
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::newCommonClient):
* src/WebWorkerImpl.cpp: Added.
(WebKit::WebWorker::create):
(WebKit::WebWorkerImpl::WebWorkerImpl):
(WebKit::WebWorkerImpl::~WebWorkerImpl):
(WebKit::WebWorkerImpl::newCommonClient):
(WebKit::WebWorkerImpl::commonClient):
(WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::terminateWorkerContext):
(WebKit::WebWorkerImpl::postMessageToWorkerContext):
(WebKit::WebWorkerImpl::workerObjectDestroyed):
(WebKit::WebWorkerImpl::clientDestroyed):
* src/WebWorkerImpl.h: Copied from Source/WebKit/chromium/src/WebWorkerBase.cpp.
(WebKit::WebWorkerImpl::client):
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:
Tools:
* DumpRenderTree/chromium/TestWebWorker.h:
(TestWebWorker::createWorker):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createWorker):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 29 Dec 2011 00:09:25 +0000 (00:09 +0000)]
Add an implicit block conversion operator to WTF::Function
https://bugs.webkit.org/show_bug.cgi?id=75325
Reviewed by Dan Bernstein.
* wtf/Compiler.h:
Add a define for COMPILER_SUPPORTS(BLOCKS). It's only defined for clang, since the gcc blocks implementation
is buggy, especially when it comes to C++.
* wtf/Functional.h:
Add a block conversion operator that creates and returns an autoreleased block that will call the function when executed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Thu, 29 Dec 2011 00:00:58 +0000 (00:00 +0000)]
Source/WebKit/chromium: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:
- WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
- NewWebCommonWorkerClient renamed to WebCommonWorkerClient
- WebWorkerBase merged into WebSharedWorkerImpl
- NewWebWorkerBase renamed into WebWorkerBase
WebWorkerClient.h has a "#define WebWorkerClient WebSharedWorkerClient" to keep chromium building.
Will be removed after coordinated patch in chromium.
Reviewed by David Levin.
* WebKit.gyp:
* public/WebCommonWorkerClient.h:
* public/WebSharedWorker.h:
* public/WebSharedWorkerClient.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerClient::allowFileSystem):
(WebKit::WebSharedWorkerClient::openFileSystem):
(WebKit::WebSharedWorkerClient::dispatchDevToolsMessage):
(WebKit::WebSharedWorkerClient::saveDevToolsAgentState):
(WebKit::WebSharedWorkerClient::~WebSharedWorkerClient):
* public/WebWorkerClient.h:
* src/DatabaseObserver.cpp:
(WebKit::AllowDatabaseMainThreadBridge::create):
(WebKit::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
(WebKit::AllowDatabaseMainThreadBridge::allowDatabaseTask):
(WebKit::allowDatabaseForWorker):
(WebCore::DatabaseObserver::canEstablishDatabase):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker):
* src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
* src/WebSharedWorkerImpl.cpp:
(WebKit::initializeWebKitStaticValues):
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::~WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::stopWorkerThread):
(WebKit::WebSharedWorkerImpl::initializeLoader):
(WebKit::WebSharedWorkerImpl::didCreateDataSource):
(WebKit::WebSharedWorkerImpl::createApplicationCacheHost):
(WebKit::WebSharedWorkerImpl::postMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postMessageTask):
(WebKit::WebSharedWorkerImpl::postExceptionToWorkerObject):
(WebKit::WebSharedWorkerImpl::postExceptionTask):
(WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
(WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspector):
(WebKit::WebSharedWorkerImpl::postMessageToPageInspectorTask):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookie):
(WebKit::WebSharedWorkerImpl::updateInspectorStateCookieTask):
(WebKit::WebSharedWorkerImpl::confirmMessageFromWorkerObject):
(WebKit::WebSharedWorkerImpl::confirmMessageTask):
(WebKit::WebSharedWorkerImpl::reportPendingActivity):
(WebKit::WebSharedWorkerImpl::reportPendingActivityTask):
(WebKit::WebSharedWorkerImpl::workerContextClosed):
(WebKit::WebSharedWorkerImpl::workerContextClosedTask):
(WebKit::WebSharedWorkerImpl::workerContextDestroyed):
(WebKit::WebSharedWorkerImpl::workerContextDestroyedTask):
(WebKit::WebSharedWorkerImpl::postTaskToLoader):
(WebKit::WebSharedWorkerImpl::postTaskForModeToWorkerContext):
(WebKit::WebSharedWorker::create):
* src/WebSharedWorkerImpl.h:
(WebKit::WebSharedWorkerImpl::view):
(WebKit::WebSharedWorkerImpl::commonClient):
(WebKit::WebSharedWorkerImpl::client):
(WebKit::WebSharedWorkerImpl::setWorkerThread):
(WebKit::WebSharedWorkerImpl::workerThread):
* src/WebWorkerBase.cpp:
(WebKit::invokeTaskMethod):
(WebKit::WebWorkerBase::dispatchTaskToMainThread):
* src/WebWorkerBase.h:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerClientImpl.h:
(WebKit::WebWorkerClientImpl::commonClient):
* src/WebWorkerImpl.cpp: Removed.
* src/WebWorkerImpl.h: Removed.
* src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
* src/WorkerFileSystemCallbacksBridge.h:
Tools: [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
https://bugs.webkit.org/show_bug.cgi?id=66509
Just renames, merges and removal of dead code. Here are the list of renames:
- WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
- NewWebCommonWorkerClient renamed to WebCommonWorkerClient
- WebWorkerBase merged into WebSharedWorkerImpl
- NewWebWorkerBase renamed into WebWorkerBase
Reviewed by David Levin.
* DumpRenderTree/chromium/TestWebWorker.h:
(TestWebWorker::createWorker):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createWorker):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Dec 2011 23:42:40 +0000 (23:42 +0000)]
Unreviewed, rolling out r103782.
http://trac.webkit.org/changeset/103782
https://bugs.webkit.org/show_bug.cgi?id=75328
broke origin-whitelisting-removal.html (Requested by kling on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 28 Dec 2011 23:30:48 +0000 (23:30 +0000)]
Enable the [Supplemental] IDL on Qt
https://bugs.webkit.org/show_bug.cgi?id=75274
Reviewed by Adam Barth.
This patch enables the [Supplemental] IDL on Qt by changing the build
flow of Qt as follows.
- Previous build flow:
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;
}
- New build flow (See the discussions in bug 72138 for more details):
resolve-supplemental.pl depends on all IDL files;
resolve-supplemental.pl reads all IDL files;
resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
resolve-supplemental.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {
generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,
including all attributes in the IDL files that are implementing $idl;
}
Tests: Confirm that build succeeds.
http/tests/websocket/tests/*
* DerivedSources.pri: Described the above build flow.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Wed, 28 Dec 2011 22:43:44 +0000 (22:43 +0000)]
Use HashMap<OwnPtr> in OriginAccessMap
https://bugs.webkit.org/show_bug.cgi?id=75327
Reviewed by Andreas Kling.
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
(WebCore::SecurityPolicy::resetOriginAccessWhitelists):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Wed, 28 Dec 2011 22:08:14 +0000 (22:08 +0000)]
Use HashMap<OwnPtr> for ProgressTracker's items
https://bugs.webkit.org/show_bug.cgi?id=75326
Reviewed by Andreas Kling.
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::~ProgressTracker): although is empty, the destructor was
kept so in the header file we can forward declare ProgressItem and use in an OwnPtr.
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress): removed a useless assignment to item
member just before it is deleted.
* loader/ProgressTracker.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 28 Dec 2011 21:26:35 +0000 (21:26 +0000)]
getComputedStyle for border-color is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75324
Reviewed by Andreas Kling.
Source/WebCore:
Implement getComputedStyle for border-color.
Test: fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to cover that we return correct values.
* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 28 Dec 2011 21:12:23 +0000 (21:12 +0000)]
Use OwnPtr to handle lifetime and deletion of FontFace objects
https://bugs.webkit.org/show_bug.cgi?id=75221
Reviewed by Daniel Bates.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Use add instead of get/set to read and
then later fill a cache. Use new version of registerCustomFont that takes PassOwnPtr.
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData): Ditto.
* dom/Document.cpp:
(WebCore::Document::registerCustomFont): Take a PassOwnPtr instead of raw pointer.
* dom/Document.h: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 28 Dec 2011 21:10:50 +0000 (21:10 +0000)]
"Fake" insertion mode in HTMLTreeBuilder doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=75322
Reviewed by Darin Adler.
This machinery isn't needed anymore now that we're using the new
foreign content hotness.
* html/parser/HTMLTreeBuilder.cpp:
* html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::setInsertionMode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Wed, 28 Dec 2011 21:04:08 +0000 (21:04 +0000)]
[Qt] fails fast/inline/nested-text-descendants.html
https://bugs.webkit.org/show_bug.cgi?id=75321
Unreviewed, skip reference test fast/inline/nested-text-descendants.html
on Qt for now. It is the only platform that fails it.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 28 Dec 2011 20:36:46 +0000 (20:36 +0000)]
<math><option><option></html><option></option> used to crash the parser
https://bugs.webkit.org/show_bug.cgi?id=75317
Reviewed by Eric Seidel.
Add a test so that this case continues to not crash.
* fast/parser/math-options-crash-expected.txt: Added.
* fast/parser/math-options-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 28 Dec 2011 20:18:03 +0000 (20:18 +0000)]
getComputedStyle for border-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75312
Reviewed by Andreas Kling.
Source/WebCore:
Implement getComputedStyle for border-style.
Test: fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to cover that we return correct values.
* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 28 Dec 2011 20:13:44 +0000 (20:13 +0000)]
getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74743
Reviewed by Tony Chang.
Source/WebCore:
Implement getComputedStyle for border-top, border-bottom, border-right, border-left.
Test: fast/css/getComputedStyle/getComputedStyle-border-shorthand.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
* css/CSSComputedStyleDeclaration.h:
LayoutTests:
Add test to cover that we return correct values.
* fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-shorthand.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 28 Dec 2011 19:47:45 +0000 (19:47 +0000)]
Entering "make" in Source builds only JavaScriptGlue and ANGLE
https://bugs.webkit.org/show_bug.cgi?id=75318
Reviewed by Anders Carlsson.
* Makefile: Changed to make Source and Tools.
* Source/Makefile: Changed to make all projects in Source.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Wed, 28 Dec 2011 19:18:05 +0000 (19:18 +0000)]
Inline flow not learning height of all text descendants
https://bugs.webkit.org/show_bug.cgi?id=75305
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/inline/nested-text-descendants-expected.html
fast/inline/nested-text-descendants.html
The root inline box would only learn it had text descendants if its first grandchild
was text. It wasn't informed of subsequent text grandchildren so could not factor them
into its calculation of the line height.
To fix this, propagate the existence of a text descendant to the root inline box
by walking up through the text child's ancestors.
* rendering/InlineFlowBox.cpp:
(WebCore::setHasTextDescendantsOnAncestors):
(WebCore::InlineFlowBox::addToLine):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::setHasTextDescendants):
LayoutTests:
* fast/inline/nested-text-descendants-expected.html: Added.
* fast/inline/nested-text-descendants.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 28 Dec 2011 19:16:31 +0000 (19:16 +0000)]
Add a new WTF::bind overload that takes 6 parameters
https://bugs.webkit.org/show_bug.cgi?id=75287
Reviewed by Sam Weinig.
* wtf/Functional.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 28 Dec 2011 18:21:04 +0000 (18:21 +0000)]
Unreviewed, rolling out r103620.
http://trac.webkit.org/changeset/103620
https://bugs.webkit.org/show_bug.cgi?id=75316
Causes many crashes (Requested by abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28
Source/WebCore:
* loader/FrameLoaderClient.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessageTimerFired):
Source/WebKit/chromium:
* public/WebDOMMessageEvent.h:
* public/WebFrameClient.h:
* src/FrameLoaderClientImpl.cpp:
* src/FrameLoaderClientImpl.h:
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
LayoutTests:
* platform/chromium/fast/events/intercept-postmessage-expected.txt: Removed.
* platform/chromium/fast/events/intercept-postmessage.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 28 Dec 2011 18:08:37 +0000 (18:08 +0000)]
[V8][Chromium] 'randomString' in document.body.style always returns true
https://bugs.webkit.org/show_bug.cgi?id=75313
Reviewed by Adam Barth.
Source/WebCore:
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
LayoutTests:
* fast/css/style-enumerate-properties-expected.txt:
* fast/css/style-enumerate-properties.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 28 Dec 2011 16:06:48 +0000 (16:06 +0000)]
Web Inspector: Add domain.png to WebCore.gypi / WebKit.qrc.
https://bugs.webkit.org/show_bug.cgi?id=75310
Reviewed by Pavel Feldman.
* WebCore.gypi:
* inspector/front-end/WebKit.qrc:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 28 Dec 2011 16:02:35 +0000 (16:02 +0000)]
Web Inspector: ExperimentsSettings causes warning on chromium when reading localizedStrings.
https://bugs.webkit.org/show_bug.cgi?id=75299
Reviewed by Pavel Feldman.
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createExperimentCheckbox):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 28 Dec 2011 15:59:15 +0000 (15:59 +0000)]
Web Inspector: Scripts panel: add debug sidebar resizer to TabbedEditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=75300
Reviewed by Pavel Feldman.
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/scriptsPanel.css:
(#scripts-debug-sidebar-resizer-widget):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 28 Dec 2011 15:25:05 +0000 (15:25 +0000)]
Web Inspector: Introduce a Profiler launcher view similar to that in the Audits panel
https://bugs.webkit.org/show_bug.cgi?id=75228
Reviewed by Pavel Feldman.
Source/WebCore:
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotProfileType):
(WebInspector.DetailedHeapshotProfileType.prototype.get treeItemTitle):
(WebInspector.DetailedHeapshotProfileType.prototype.get description):
* inspector/front-end/ProfileLauncherView.js: Added.
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.setUpEventListeners):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.ProfileLauncherView.prototype._profileTypeChanged):
(WebInspector.ProfileLauncherView.prototype._onProfileStarted):
(WebInspector.ProfileLauncherView.prototype._onProfileFinished):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.get treeItemTitle):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._showLauncherView):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._updateInterface):
(WebInspector.ProfileTypeTreeElement):
(WebInspector.ProfileTypeTreeElement.prototype.collapse):
(WebInspector.ProfilesSidebarTreeElement):
(WebInspector.ProfilesSidebarTreeElement.prototype.onattach):
(WebInspector.ProfilesSidebarTreeElement.prototype.onselect):
(WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):
(WebInspector.ProfilesSidebarTreeElement.prototype.refresh):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/WelcomeView.js: Removed.
* inspector/front-end/auditsPanel.css:
(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.panel-enabler-view.audit-launcher-view label):
(.panel-enabler-view.audit-launcher-view label.disabled):
* inspector/front-end/inspector.html:
* inspector/front-end/panelEnablerView.css:
(.panel-enabler-view img):
(.panel-enabler-view .flexible-space):
(.panel-enabler-view button:not(.status-bar-item)):
(body.inactive .panel-enabler-view button, .panel-enabler-view button:disabled):
(.panel-enabler-view input[type="radio"]):
(.panel-enabler-view input[type="radio"]:active:not(:disabled)):
(.panel-enabler-view input[type="radio"]:checked):
(.panel-enabler-view input[type="radio"]:checked:active):
* inspector/front-end/profilesPanel.css:
(.profile-launcher-view-tree-item > .icon):
(.profile-launcher-view-content):
(.profile-launcher-view-content h1):
(.panel-enabler-view.profile-launcher-view form):
(.panel-enabler-view.profile-launcher-view label):
(.profile-launcher-view-content p):
(.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):
(.profile-launcher-view-content button.running:not(.status-bar-item)):
(body.inactive .profile-launcher-view-content button.running:not(.status-bar-item)):
LayoutTests:
* inspector/profiler/profiler-test.js:
(initialize_ProfilerTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 28 Dec 2011 13:41:15 +0000 (13:41 +0000)]
Unreviewed, rolling out r103763.
http://trac.webkit.org/changeset/103763
https://bugs.webkit.org/show_bug.cgi?id=75307
"Compilation fails on Snow Leopard" (Requested by yurys on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-28
* inspector/CodeGeneratorInspector.py:
(Helper):
(create_ad_hoc_type_declaration.Helper):
(CodeGenerator.generate_type_builder):
(get_in_c_type_text):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Wed, 28 Dec 2011 13:29:33 +0000 (13:29 +0000)]
Web Inspector: CodeGeneratorInspector.py: generate enum types.
https://bugs.webkit.org/show_bug.cgi?id=74954
Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-12-28
Reviewed by Yury Semikhatsky.
Internal map of string contants is created. C enums are created for
each JSON enum.
* inspector/CodeGeneratorInspector.py:
(EnumConstants.add_constant):
(EnumConstants):
(EnumConstants.get_enum_constant_code):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
(get_in_c_type_text):
(get_setter_value_expression_pattern):
(PlainObjectBinding.get_in_c_type_text):
(PlainObjectBinding.get_setter_value_expression_pattern):
(RawTypesBinding.get_in_c_type_text):
(RawTypesBinding.get_setter_value_expression_pattern):
(get_annotated_type_text):
(MethodGenerateModes.get_modes):
(MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
(MethodGenerateModes.StrictParameterMode):
(MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
(MethodGenerateModes.RawParameterMode.get_c_param_type_text):
(MethodGenerateModes.RawParameterMode):
(MethodGenerateModes.RawParameterMode.get_setter_value_expression):
(MethodGenerateModes.CombinedMode.get_c_param_type_text):
(MethodGenerateModes):
(MethodGenerateModes.CombinedMode):
(MethodGenerateModes.CombinedMode.get_setter_value_expression):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 28 Dec 2011 12:58:43 +0000 (12:58 +0000)]
IndexedDB: IDBKeyRange constructor should throw when lower > upper
https://bugs.webkit.org/show_bug.cgi?id=74705
Reviewed by Tony Chang.
Source/WebCore:
Make IDBKeyRange throw an exception when lower > upper,
or lower == upper and one or both of the bounds is open.
Tested in storage/indexeddb/keyrange.html.
* storage/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::bound):
LayoutTests:
Update tests to check that the IDBKeyRange constructor throws when
trying to specify illegal key ranges, and update tests that were
doing that.
* storage/indexeddb/index-cursor-expected.txt:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/keyrange.html:
* storage/indexeddb/objectstore-cursor-expected.txt:
* storage/indexeddb/objectstore-cursor.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 28 Dec 2011 12:28:04 +0000 (12:28 +0000)]
Web Inspector: [protocol] empty enum constant should be replaced with identifier
https://bugs.webkit.org/show_bug.cgi?id=75273
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForRule):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.get isRegular):
LayoutTests:
* inspector/styles/get-set-stylesheet-text-expected.txt:
* inspector/styles/styles-new-API-expected.txt:
* inspector/styles/styles-source-offsets.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Wed, 28 Dec 2011 12:04:28 +0000 (12:04 +0000)]
[Qt][WK2] Crash in ~WebGraphicsLayer when running fast/multicol/pagination-* tests
https://bugs.webkit.org/show_bug.cgi?id=75000
Reviewed by Noam Rosenthal.
Don't adopt a tile client that belongs to a parent layer.
This is unnecessary and also unsafe because we can live
through that client.
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 28 Dec 2011 09:31:41 +0000 (09:31 +0000)]
Web Inspector: complete annotating SDK component.
https://bugs.webkit.org/show_bug.cgi?id=75259
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
(WebInspector.NetworkDispatcher.prototype._isNull):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
* inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
(WebInspector.ResourceTreeFrame.prototype.get name):
* inspector/front-end/TabbedEditorContainer.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@103759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc