Sven van Haastregt [Wed, 21 Oct 2020 10:46:55 +0000 (11:46 +0100)]
[TargetLowering] Check boolean content when folding bit compare
Updates an optimization that relies on boolean contents being either 0
or 1 to properly check for this before triggering.
The following:
(X & 8) != 0 --> (X & 8) >> 3
Produces unexpected results when a boolean 'true' value is represented
by negative one.
Patch by Erik Hogeman.
Differential Revision: https://reviews.llvm.org/D89390
Sven van Haastregt [Wed, 21 Oct 2020 09:02:50 +0000 (10:02 +0100)]
[TargetLowering] Add test for bit comparison fold
This adds a test covering an issue in bit comparison folding. The
issue will be addressed in the subsequent commit.
Patch by Erik Hogeman.
Differential Revision: https://reviews.llvm.org/D89390
Sebastian Neubauer [Tue, 20 Oct 2020 16:23:24 +0000 (18:23 +0200)]
[AMDGPU] Fix off by one in assert
D89217 did not subtract one when accessing SubRegFromChannelTable in one
place.
Differential Revision: https://reviews.llvm.org/D89804
John Brawn [Wed, 21 Oct 2020 10:18:04 +0000 (11:18 +0100)]
[Driver] Incorporate -mfloat-abi in the computed triple on ARM
LLVM assumes that when it creates a call to a C library function it
can use the C calling convention. On ARM the effective calling
convention is determined from the target triple, however using
-mfloat-abi=hard on ARM means that calls to (and definitions of) C
library functions use the arm_aapcs_vfpcc calling convention which can
result in a mismatch.
Fix this by incorporating -mfloat-abi into the target triple, similar
to how -mbig-endian and -march/-mcpu are. This only works for EABI
targets and not Android or iOS, but there the float abi is fixed so
instead give an error.
Fixes PR45524
Differential Revision: https://reviews.llvm.org/D89573
Adam Balogh [Thu, 15 Oct 2020 13:07:48 +0000 (15:07 +0200)]
[ADT] Fix for ImmutableMapRef
The `Root` member of `ImmutableMapRef` was changed recently from a plain
pointer to `IntrusiveRefCntPtr`. However, the `Profile` member function
was not adjusted. This results in comilation error whenever the
`Profile` method is used on an `ImmutableMapRef`. This patch fixes this
issue and also adds unit tests for `ImmutableMapRef`.
Differential Revision: https://reviews.llvm.org/D89486
Sjoerd Meijer [Wed, 21 Oct 2020 09:53:28 +0000 (10:53 +0100)]
[InstructionSimplify] And precommit more tests for D89317. NFC.
Alex Zinenko [Fri, 16 Oct 2020 09:40:34 +0000 (11:40 +0200)]
[mlir] ODS: support TableGen dag objects to specify OpBuilder parameters
Historically, custom builder specification in OpBuilder has been accepting the
formal parameter list for the builder method as a raw string containing C++.
While this worked well to connect the signature and the body, this became
problematic when ODS needs to manipulate the parameter list, e.g. to inject
OpBuilder or to trim default values when generating the definition. This has
also become inconsistent with other method declarations, in particular in
interface definitions.
Introduce the possibility to define OpBuilder formal parameters using a
TableGen dag similarly to other methods. Additionally, introduce a mechanism to
declare parameters with default values using an additional class. This
mechanism can be reused in other methods. The string-based builder signature
declaration is deprecated and will be removed after a transition period.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D89470
Florian Hahn [Wed, 21 Oct 2020 09:21:50 +0000 (10:21 +0100)]
[Passes] Move ADCE before DSE & LICM.
The adjustment seems to have very little impact on optimizations.
The only binary change with -O3 MultiSource/SPEC2000/SPEC2006 on X86 is
in consumer-typeset and the size there actually decreases by -0.1%, with
not significant changes in the stats.
On its own, it is mildly positive in terms of compile-time, most likely
due to LICM & DSE having to process slightly less instructions. It
should also be unlikely that DSE/LICM make much new code dead.
http://llvm-compile-time-tracker.com/compare.php?from=
df63eedef64d715ce1f31843f7de9c11fe1e597f&to=
e3bdfcf94a9eeae6e006d010464f0c1b3550577d&stat=instructions
With DSE & MemorySSA, it gives some nice compile-time improvements, due
to the fact that DSE can re-use the PDT from ADCE, if it does not make
any changes:
http://llvm-compile-time-tracker.com/compare.php?from=
15fdd6cd7c24c745df1bb419e72ff66fd138aa7e&to=
481f494515fc89cb7caea8d862e40f2c910dc994&stat=instructions
Reviewed By: xbolva00
Differential Revision: https://reviews.llvm.org/D87322
Sjoerd Meijer [Wed, 21 Oct 2020 09:02:04 +0000 (10:02 +0100)]
[InstructionSimplify] Precommit more tests for D89317. NFC.
Jay Foad [Wed, 21 Oct 2020 08:17:28 +0000 (09:17 +0100)]
[AMDGPU][TableGen] Make more use of !ne !not !and !or. NFC.
Jonas Paulsson [Wed, 14 Oct 2020 06:48:29 +0000 (08:48 +0200)]
Reapply "[clang] Improve handling of physical registers in inline
assembly operands."
Earlyclobbers are now excepted from this change (original commit: c78da03).
Review: Ulrich Weigand, Nick Desaulniers
Differential Revision: https://reviews.llvm.org/D87279
Luís Marques [Wed, 21 Oct 2020 08:47:25 +0000 (09:47 +0100)]
[compiler-rt][builtins][RISCV] Always include __mul[sd]i3 builtin definitions
The RISC-V implementations of the `__mulsi3`, `__muldi3` builtins were
conditionally compiling the actual function definitions depending on whether
the M extension was present or not. This caused Compiler-RT testing failures
for RISC-V targets with the M extension, as when these sources were included
the `librt_has_mul*i3` features were still being defined. These `librt_has_*`
definitions are used to conditionally run the respective tests. Since the
actual functions were not being compiled-in, the generic test for `__muldi3`
would fail. This patch makes these implementations follow the normal
Compiler-RT convention of always including the definition, and conditionally
running the respective tests by using the lit conditional
`REQUIRES: librt_has_*`.
Since the `mulsi3_test.c` wasn't actually RISC-V-specific, this patch also
moves it out of the `riscv` directory. It now only depends on
`librt_has_mulsi3` to run.
Differential Revision: https://reviews.llvm.org/D86457
Vitaly Buka [Wed, 21 Oct 2020 08:33:21 +0000 (01:33 -0700)]
[NFC][LSAN] Use InitializeCommonFlags in LSAN
Wang, Pengfei [Wed, 21 Oct 2020 07:57:43 +0000 (15:57 +0800)]
[X86] Add clang release notes for HRESET and minor change for llvm release notes. (NFC)
Alex Zinenko [Tue, 20 Oct 2020 09:22:29 +0000 (11:22 +0200)]
[mlir] Fix copy-pasted docstrings in Python bindings
Docstrings for `__str__` method in many classes was recycling the constant
string defined for `Type`, without being types themselves. Use proper
docstrings instead. Since they are succint, use string literals instead of
top-level constants to avoid further mistakes.
Differential Revision: https://reviews.llvm.org/D89780
Alex Zinenko [Tue, 20 Oct 2020 09:22:02 +0000 (11:22 +0200)]
[mlir] Use the correct base class for Attributes in Python bindings
The pybind class typedef for concrete attribute classes was erroneously
deriving all of them from PyAttribute instead of the provided base class. This
has not been triggering any error because only one level of the hierarchy is
currently exposed.
Differential Revision: https://reviews.llvm.org/D89779
Alex Zinenko [Tue, 20 Oct 2020 09:21:05 +0000 (11:21 +0200)]
[mlir] Expose Value hierarchy to Python bindings
Values are ubiquitous in the IR, in particular block argument and operation
results are Values. Define Python classes for BlockArgument, OpResult and their
common ancestor Value. Define pseudo-container classes for lists of block
arguments and operation results, and use these containers to access the
corresponding values in blocks and operations.
Differential Revision: https://reviews.llvm.org/D89778
Craig Topper [Wed, 21 Oct 2020 07:42:39 +0000 (00:42 -0700)]
[X86] Remove period from end of error message in assembler
Addresses post-commit feedback from D89837.
David Sherwood [Wed, 30 Sep 2020 12:36:59 +0000 (13:36 +0100)]
[SVE][CodeGen] Replace use of TypeSize comparison operator in CreateStackTemporary
We were previously relying upon the TypeSize comparison operators to
obtain the maximum size of two types, however use of such operators is
being deprecated in favour of making the caller aware that it could
be dealing with scalable vector types. I have changed the code to assert
that the two types have the same scalable property and thus we can
simply take the maximum of the known minimum sizes instead.
Differential Revision: https://reviews.llvm.org/D88563
David Sherwood [Fri, 9 Oct 2020 13:29:15 +0000 (14:29 +0100)]
[SVE] Remove reliance on TypeSize comparison operators in unit tests
The EXPECT_XY comparison functions all rely upon using the existing
TypeSize comparison operators, which we are deprecating in favour
of isKnownXY. I've changed all such cases to compare either the known
minimum size or the fixed size.
Differential Revision: https://reviews.llvm.org/D89531
Martin Storsjö [Fri, 16 Oct 2020 09:49:01 +0000 (12:49 +0300)]
[libcxx] [test] Split the file_time_type synopsis test
Split the resolution check to a separate test, which is marked as
unsupported on windows.
On windows (both with MS STL and libstdc++), the file time has
100 ns resolution; the standard doesn't mandate a specific resolution.
Differential Revision: https://reviews.llvm.org/D89535
Martin Storsjö [Wed, 21 Oct 2020 06:33:51 +0000 (09:33 +0300)]
Revert "[InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3)) uniform vector support"
Also revert "[InstCombine] foldOrOfICmps - use m_Specific instead of
explicit comparisons. NFCI." to make the primarily intended revert
work.
This reverts commits
ce13549761b6a22263e051dda09ef5122435008b and
e372a5f86f6488bb0c2593a665d51fdd3a97c6e4.
This commit caused failed asserts e.g. like this:
$ cat repro.cpp
bool a(char b) {
return b >= '0' && b <= '9' || (b | 32) >= 'a' && (b | 32) <= 'z';
$ clang++ -target x86_64-linux-gnu -c -O2 repro.cpp
clang++: ../include/llvm/ADT/APInt.h:1151: bool llvm::APInt::operator==(const
llvm::APInt&) const: Assertion `BitWidth == RHS.BitWidth && "Comparison
requires equal bit widths"' failed.
Esme-Yi [Wed, 21 Oct 2020 06:38:22 +0000 (06:38 +0000)]
[NFC][PowerPC]Add tests for folding RLWINM before and after RA.
Max Kazantsev [Wed, 21 Oct 2020 06:03:46 +0000 (13:03 +0700)]
Revert "[SCEV] Prove implications of different type via truncation"
This reverts commit
80852a4f2fb154c6094bb9d9e3457757d5a60ad1.
Test is now broken because underlying required patch was also reverted SUDDENLY.
Max Kazantsev [Wed, 21 Oct 2020 05:42:40 +0000 (12:42 +0700)]
[SCEV] Prove implications of different type via truncation
When we need to prove implication of expressions of different type width,
the default strategy is to widen everything to wider type and prove in this
type. This does not interact well with AddRecs with negative steps and
unsigned predicates: such AddRec will likely not have a `nuw` flag, and its
`zext` to wider type will not be an AddRec. In contraty, `trunc` of an AddRec
in some cases can easily be proved to be an `AddRec` too.
This patch introduces an alternative way to handling implications of different
type widths. If we can prove that wider type values actually fit in the narrow type,
we truncate them and prove the implication in narrow type.
Differential Revision: https://reviews.llvm.org/D89548
Reviewed By: fhahn
Craig Topper [Wed, 21 Oct 2020 03:59:27 +0000 (20:59 -0700)]
[X86] Error on using h-registers with REX prefix in the assembler instead of leaving it to a fatal error in the encoder.
Using a fatal error is bad for user experience.
Reviewed By: pengfei
Differential Revision: https://reviews.llvm.org/D89837
Fangrui Song [Wed, 21 Oct 2020 04:03:58 +0000 (21:03 -0700)]
Revert D89381 "[SCEV] Recommit "Use nw flag and symbolic iteration count to sharpen ranges of AddRecs", attempt 2"
This reverts commit
a10a64e7e334dc878d281aba9a46f751fe606567.
It broke polly/test/ScopInfo/NonAffine/non-affine-loop-condition-dependent-access_3.ll
The difference suggests that this may be a serious issue.
Mircea Trofin [Tue, 20 Oct 2020 19:09:38 +0000 (12:09 -0700)]
[NFC][MC] Use [MC]Register in MachineVerifier
Differential Revision: https://reviews.llvm.org/D89815
Geoffrey Martin-Noble [Wed, 21 Oct 2020 02:35:17 +0000 (19:35 -0700)]
Remove unnecessary header include which violates layering
This was introduced in https://reviews.llvm.org/D89774, but I don't
think it should be necessary.
Reviewed By: TaWeiTu, aeubanks
Differential Revision: https://reviews.llvm.org/D89843
Carl Ritson [Wed, 21 Oct 2020 02:38:21 +0000 (11:38 +0900)]
[AMDGPU][NFC] Fix missing size in comment
Fangrui Song [Wed, 21 Oct 2020 01:34:31 +0000 (18:34 -0700)]
[Polly] Delete unused lambda capture after
7175cffb2133048018df74c1b49d1d4962ea18f2
TaWeiTu [Wed, 21 Oct 2020 01:34:15 +0000 (09:34 +0800)]
Revert "This is a test commit"
This reverts commit
cbe0ee1a94d11bd32019920c8f55ebd58054542a.
TaWeiTu [Wed, 21 Oct 2020 01:33:36 +0000 (09:33 +0800)]
This is a test commit
Fangrui Song [Wed, 21 Oct 2020 01:31:21 +0000 (18:31 -0700)]
[test] Fix -fbasic-block-sections= test on Windows after D89500
Cyndy Ishida [Wed, 21 Oct 2020 00:50:29 +0000 (17:50 -0700)]
[llvm] Fix ODRViolations for VersionTuple YAML specializations NFC
It appears for Swift there was confusing errors when trying to parse APINotes, when libAPINotes and libInterfaceStub are linked, they both export symbol
`__ZN4llvm4yaml7yamlizeINS_12VersionTupleEEENSt3__19enable_ifIXsr16has_ScalarTraitsIT_EE5valueEvE4typeERNS0_2IOERS5_bRNS0_12EmptyContextE`, and discovered
same symbol defined within llvm-ifs.
This consolidates the boilerplate into YAMLTraits and defers the specific validation in reading the whole input.
fixes: rdar://problem/
70450563
Reviewed By: phosek, dblaikie
Differential Revision: https://reviews.llvm.org/D89764
Duncan P. N. Exon Smith [Mon, 19 Oct 2020 19:28:38 +0000 (15:28 -0400)]
SourceManager: Simplify early returns in ContentCache::getBufferOrNone, NFC
As suggested in the review for https://reviews.llvm.org/D89430, simplify
the logic for marking the buffer as invalid in the early return paths.
Differential Revision: https://reviews.llvm.org/D89722
Jonas Devlieghere [Wed, 21 Oct 2020 01:15:45 +0000 (18:15 -0700)]
[lldb] Don't strip LLDB.framework on install
The framework build will run dsymutil after LLDB.framework is installed.
Peter Steinfeld [Tue, 20 Oct 2020 22:05:35 +0000 (15:05 -0700)]
[flang] Fix call to CHECK() on erroneous subroutine declaration
When processing declarations in resolve-names.cpp, we were returning a
symbol that had SubprogramName details to PushSubprogramScope(), which
expects a symbol with Subprogram details.
I adjusted the code and added a test.
Differential Revision: https://reviews.llvm.org/D89829
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 22:57:04 +0000 (18:57 -0400)]
ContentCache: Simplify by always owning the MemoryBuffer
This changes `ContentCache::Buffer` to use
`std::unique_ptr<MemoryBuffer>` instead of the `PointerIntPair`. It
drops the (mostly unused) `DoNotFree` bit, instead creating a (new)
non-owning `MemoryBuffer` instance when passed a `MemoryBufferRef`.
Differential Revision: https://reviews.llvm.org/D67030
Hubert Tong [Wed, 21 Oct 2020 00:50:38 +0000 (20:50 -0400)]
NFC: Fix -Wsign-compare warnings on 32-bit builds
Comparing 32-bit `ptrdiff_t` against 32-bit `unsigned` results in
`-Wsign-compare` warnings for both GCC and Clang.
The warning for the cases in question appear to identify an issue
where the `ptrdiff_t` value would be mutated via conversion to an
unsigned type.
The warning is resolved by using the usual arithmetic conversions to
safely preserve the value of the `unsigned` operand while trying to
convert to a signed type. Host platforms where `unsigned` has the same
width as `unsigned long long` will need to make a different change, but
using an explicit cast has disadvantages that can be avoided for now.
Reviewed By: dantrushin
Differential Revision: https://reviews.llvm.org/D89612
Richard Smith [Wed, 21 Oct 2020 00:35:15 +0000 (17:35 -0700)]
Don't instantiate lambda closure types in default member initializers
when instantiating the enclosing class.
We'll build new lambda closure types if and when we instantiate the
default member initializer, and instantiating the closure type by itself
can go wrong in cases where we fully-instantiate nested classes (in
explicit instantiations of the enclosing class and when the enclosing
class is a local class) -- we will instantiate the 'operator()' as a
regular function rather than as a lambda call operator, so it doesn't
get to use its captures, has the wrong 'this' type, etc.
Austin Kerbow [Mon, 19 Oct 2020 23:54:24 +0000 (16:54 -0700)]
[AMDGPU] Avoid inserting noops during scheduling
Passes that are run after the post-RA scheduler may insert instructions like
waitcnt which eliminate the need for certain noops. After this patch the
scheduler is still aware of possible latency from hazards but noops will
not be inserted until the dedicated hazard recognizer pass is run.
Depends on D89753.
Reviewed By: foad
Differential Revision: https://reviews.llvm.org/D89754
Austin Kerbow [Mon, 19 Oct 2020 21:38:02 +0000 (14:38 -0700)]
[HazardRec] Allow inserting multiple wait-states simultaneously
If a target can encode multiple wait-states into a noop allow emitting such
instructions directly.
Reviewed By: rampitec, dmgreen
Differential Revision: https://reviews.llvm.org/D89753
Richard Smith [Fri, 16 Oct 2020 00:50:48 +0000 (17:50 -0700)]
Don't permit array bound constant folding in OpenCL.
Permitting non-standards-driven "do the best you can" constant-folding
of array bounds is permitted solely as a GNU compatibility feature. We
should not be doing it in any language mode that is attempting to be
conforming.
From https://reviews.llvm.org/D20090 it appears the intent here was to
permit `__constant int` globals to be used in array bounds, but the
change in that patch only added half of the functionality necessary to
support that in the constant evaluator. This patch adds the other half
of the functionality and turns off constant folding for array bounds in
OpenCL.
I couldn't find any spec justification for accepting the kinds of cases
that D20090 accepts, so a reference to where in the OpenCL specification
this is permitted would be useful.
Note that this change also affects the code generation in one test:
because after 'const int n = 0' we now treat 'n' as a constant
expression with value 0, it's now a null pointer, so '(local int *)n'
forms a null pointer rather than a zero pointer.
Reviewed By: Anastasia
Differential Revision: https://reviews.llvm.org/D89520
Sriraman Tallam [Tue, 20 Oct 2020 23:39:44 +0000 (16:39 -0700)]
Improve file doesnt exist error with -fbasic-block-sections=
With -fbasicblock-sections=, let the front-end handle the case where the file
doesnt exist. The driver only checks if the option syntax is right.
Differential Revision: https://reviews.llvm.org/D89500
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 21:54:44 +0000 (17:54 -0400)]
clang/Basic: ContentCache::InvalidFlag => ContentCache::IsBufferInvalid, NFC
Move a flag out of the `MemoryBuffer*` to unblock changing it to a
`unique_ptr`. There are plenty of bits available in the bitfield below.
Differential Revision: https://reviews.llvm.org/D89431
Michael Kruse [Fri, 16 Oct 2020 17:37:34 +0000 (12:37 -0500)]
[Polly] Reuse multiple uses in operand tree.
Recursively traversing the operand tree leads to an exponential blowup
if instructions are used multiple times due to every path leading to an
additional copy of the instructions after forwarding. This problem was
marked as a TODO in the code and was reported as a bug in llvm.org/PR47340.
Fix by caching already visited instructions and returning the cached
version when already visited. Instead of calling forwardTree() twice,
return a ForwardingAction structure that contains a lambda which will
carry-out the forwarding when requested. The lambdas are executed in
reverse-postorder to mimic the previous recursive calls unless there
is a reuse.
Fixes llvm.org/PR47340
Kostya Kortchinsky [Tue, 20 Oct 2020 18:15:52 +0000 (11:15 -0700)]
[GWP-ASan] Rework utilities (NFC)
Few changes wrt utilities:
- split `Check` into a platform agnostic condition test and a platform
specific termination, for which we introduce the function `die`.
- add a platform agnostic `utilities.cpp` that gets the allocation
alignment functions original in the platform specific file, as they
are reusable by all platforms.
Differential Revision: https://reviews.llvm.org/D89811
Tony [Fri, 16 Oct 2020 07:09:38 +0000 (07:09 +0000)]
[AMDGPU] Optimize waitcnt insertion for flat memory operations
Change waitcnt insertion to check the memory operand tokens to see if
flat memory operations access VMEM in the same way it does to check if
accessing LDS. This avoids adding waitcnt for counters for address
spaces that are not accessed.
In addition, only generate the pessimistic waitcnt 0 if a flat memory
operation appears to access both VMEM and LDS.
This benefits flat memory operations that explicitly specify the
address space as GLOBAL or LOCAL.
Differential Revision: https://reviews.llvm.org/D89618
Craig Topper [Tue, 20 Oct 2020 21:31:47 +0000 (14:31 -0700)]
[X86] Move 'int $3' -> 'int3' handling in the assembler to processInstruction.
Instead of handling before parsing, just fix it after parsing.
Craig Topper [Tue, 20 Oct 2020 21:17:07 +0000 (14:17 -0700)]
[X86] Move 's{hr,ar,hl} , <op>' to 'shift <op>' optimization in the assembler into processInstruction.
Instead of detecting the mnemonic and hacking the operands before
parsing. Just fix it up after parsing.
Louis Dionne [Mon, 19 Oct 2020 20:51:33 +0000 (16:51 -0400)]
[libc++] Get rid of <sstream> in the valarray tests
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 22:17:01 +0000 (18:17 -0400)]
clang/Basic: Remove SourceManager::getBufferPointer, NFC
Inline `Source::getBufferPointer` into its only remaining caller,
`getBufferOrNone`. No functionality change.
Differential Revision: https://reviews.llvm.org/D89430
Kazu Hirata [Tue, 20 Oct 2020 22:01:39 +0000 (15:01 -0700)]
[AsmWriter] Construct SlotTracker with the function
This patch teaches BasicBlock::print to construct an instance of
SlotTracker with the containing function.
Without this patch, we dump:
*** IR Dump After LoopInstSimplifyPass ***
; Preheader:
br label %1
; Loop:
<badref>: ; preds = %1, %0
br label %1
Note "<badref>" above. This happens because BasicBlock::print calls:
SlotTracker SlotTable(this->getModule());
Note that this constructor does not add the contents of functions to
the slot table. That is, basic blocks are left unnumbered.
This patch fixes the problem by switching to:
SlotTracker SlotTable(this->getParent());
which does add the contents of the Module and the function,
this->getParent(), to the slot table.
Differential Revision: https://reviews.llvm.org/D89567
Federico Lebrón [Tue, 20 Oct 2020 21:37:38 +0000 (14:37 -0700)]
Fix pretty printing of linalg GenericOps when there are no inputs.
Differential Revision: https://reviews.llvm.org/D89825
Christopher Tetreault [Tue, 20 Oct 2020 18:32:28 +0000 (11:32 -0700)]
Get the address space within getVectorPtrTy
getVectorPtrTy is private to VectorBlockGenerator, and all uses query
the address space from the passed-in pointer prior to calling it.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D89745
David Goldman [Fri, 16 Oct 2020 18:14:37 +0000 (14:14 -0400)]
[clangd][ObjC] Support nullability annotations
Nullability annotations are implmented using attributes; previusly
clangd would skip over AttributedTypeLoc since their location
points to the attribute instead of the modified type.
Also add some test cases for this.
Differential Revision: https://reviews.llvm.org/D89579
Vitaly Buka [Tue, 20 Oct 2020 21:16:27 +0000 (14:16 -0700)]
[LSAN][NFC] Reformat test
Evgenii Stepanov [Mon, 19 Oct 2020 23:38:03 +0000 (16:38 -0700)]
[hwasan] Increase max allocation size to 1Tb.
2Gb is unreasonably low on devices with 12Gb RAM and more.
Differential Revision: https://reviews.llvm.org/D89750
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 22:06:29 +0000 (18:06 -0400)]
clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC
Replace `SourceManager::getMemoryBufferForFile`, which returned a
dereferenceable `MemoryBuffer*` and had a `bool*Invalid` out parameter,
with `getMemoryBufferForFileOrNone` (returning
`Optional<MemoryBufferRef>`) and `getMemoryBufferForFileOrFake`
(returning `MemoryBufferRef`).
Differential Revision: https://reviews.llvm.org/D89429
Louis Dionne [Tue, 20 Oct 2020 20:47:47 +0000 (16:47 -0400)]
[libc++] Remove uses of verbose_assert.h in Filesystem tests
For a modest loss of debugability in the tests, this allows more tests
to run on platforms that do not have support for <iostream>.
Jonas Devlieghere [Tue, 20 Oct 2020 20:46:34 +0000 (13:46 -0700)]
[Apple-stage2] Install FileCheck and yaml2obj in the toolchain
rdar://
70274446
Differential revision: https://reviews.llvm.org/D89763
Peter Collingbourne [Tue, 20 Oct 2020 05:18:18 +0000 (22:18 -0700)]
Driver: Add integer sanitizers to trapping group automatically.
In D86000 we added a new sanitizer to the integer group
without adding it to the trapping group. This broke usage of
-fsanitize=integer -fsanitize-trap=integer or -fsanitize=integer
-fsanitize-minimal-runtime.
I think we can reasonably expect any new integer sanitizers to be
compatible with trapping and the minimal runtime, so add them to the
trapping group automatically.
Also add a test to ensure that any future additions of sanitizers
to the integer group will most likely result in test failures which
would lead to updates to the minimal runtime if necessary. For this
particular sanitizer no updates are required because it uses the
existing shift_out_of_bounds callback function.
Differential Revision: https://reviews.llvm.org/D89766
Paul C. Anagnostopoulos [Mon, 19 Oct 2020 14:52:15 +0000 (10:52 -0400)]
[AMDGPU] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans
Differential Revision: https://reviews.llvm.org/D89796
Louis Dionne [Tue, 20 Oct 2020 19:52:57 +0000 (15:52 -0400)]
[libc++] Make it easier to add new restrictions for feature-test macro tests
Louis Dionne [Thu, 15 Oct 2020 21:54:15 +0000 (17:54 -0400)]
[libc++] Decouple debug mode tests from iostreams
Shimin Cui [Tue, 20 Oct 2020 19:41:49 +0000 (12:41 -0700)]
[ConstantFold] Fold the comparison of bitcasted global values
This is to simplify icmp instructions in the form like:
%cmp = icmp eq i32 (i8*, i8*)* bitcast (i32 (i32**, i32**)* @f32 to i32
%(i8*, i8*)), bitcast (i32 (i64**, i64**) @f64 to i32 (i8*, i8*)*)
Here @f32 and @f64 are two functions.
Differential Revision: https://reviews.llvm.org/D87850
Jonas Devlieghere [Tue, 20 Oct 2020 18:42:09 +0000 (11:42 -0700)]
[lldb] Add a page to the docs with (external) links on how to use LLDB
In a discussion with Jim last week we came to the realization that often
we get asked about things that might not be documented on the website,
but that have been pretty well explained elsewhere. In those situations
it's often easier to quickly answer the question than searching for that
presentation you gave 3 years ago if you remember at all.
This often results in us having to answer the same questions over and
over again. We could add the questions and their answer to the website,
but that means we (1) have to duplicate the work and (2) now have to
maintain it.
A more efficient solution is to add a page with external resources with
the caveat that they might be outdated. That's exactly the purpose of
this patch.
I've added a few links that came to mind, but I don't want to be the
arbiter of what should and should not be included. I'd hope that over
time the community can crowd-source the best resources.
Differential revision: https://reviews.llvm.org/D89215
Mircea Trofin [Mon, 19 Oct 2020 18:10:47 +0000 (11:10 -0700)]
[NFC][Regalloc] Type 2 statics in terms of Register
Using Register instead of unsigned.
Also added isStack to mirror the other members, and eventually remove
the static testers.
Differential Revision: https://reviews.llvm.org/D89718
David Stenberg [Tue, 20 Oct 2020 17:30:39 +0000 (19:30 +0200)]
Handle value uses wrapped in metadata for the use-list order
When generating the use-list order, also consider value uses that are
operands which are wrapped in metadata; e.g. llvm.dbg.value operands.
This fixes PR36778. The test case is based on the reproducer from that
report.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D53758
LLVM GN Syncbot [Tue, 20 Oct 2020 17:56:26 +0000 (17:56 +0000)]
[gn build] Port
848a68a032d
Nicolai Hähnle [Tue, 20 Oct 2020 17:51:44 +0000 (19:51 +0200)]
DomTree: Extract (mostly) read-only logic into type-erased base classes
Avoid having to instantiate and compile a subset of the dominator tree logic
separately for each node type. More importantly, this allows generic
algorithms to be built on top of dominator trees without writing them as
templates -- such algorithms can now use opaque CfgBlockRef and
CfgInterface instead.
A type-erased implementation of dominator trees could be written in
terms of CfgInterface as well, but doing so would change the current
trade-off: it would slightly reduce code size at the cost of a slight
runtime overhead.
This patch does not change the trade-off, as it only does type-erasure
where basic blocks can be treated in a fully opaque way, i.e. it only
moves methods that don't require iteration over CFG successors and
predecessors.
v5:
- rename generic_{begin,end,children} back without the generic_ prefix
and refer explictly to base class methods in NewGVN, which wants to
mutate the order of dominator tree node children directly
v6:
- style change: iDom -> idom; it's arguable whether this is really
invalid, since it is actually standard camelCase, but clang-tidy
complains about it so... *shrug*
- rename {to,from}Generic -> {wrap,unwrap}Ref
Change-Id: Ib860dc04cf8bb093d8ed00be7def40d662213672
Differential Revision: https://reviews.llvm.org/D83089
Duncan P. N. Exon Smith [Tue, 20 Oct 2020 17:50:52 +0000 (13:50 -0400)]
lldb: Migrate to MemoryBufferRef for createFileID (after
51d1d585e5838ea0f02f1271f7543c4e43639969)
I missed these two lldb users before deleting the `UnownedTag` API for
`createFileID` in
51d1d585e5838ea0f02f1271f7543c4e43639969. This should
fix the build.
Ta-Wei Tu [Tue, 20 Oct 2020 17:41:38 +0000 (10:41 -0700)]
[NPM] port -unify-loop-exits to NPM
Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D89774
vnalamot [Tue, 20 Oct 2020 16:31:09 +0000 (22:01 +0530)]
[AMDGPU] Remove getAllVGPR32() which cannot handle Accum VGPRs properly
Remove getAllVGPR32() interface and update the SGPR spill code to use
a proper method to get the relevant VGPR registers list.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D89806
Duncan P. N. Exon Smith [Thu, 15 Oct 2020 14:36:00 +0000 (10:36 -0400)]
FileManager: Test FileManager::getFileRef
Add a test demonstrating `getFileRef`'s behaviour, which isn't obvious
from code inspection when it's handling a redirected file.
Differential Revision: https://reviews.llvm.org/D89469
Duncan P. N. Exon Smith [Wed, 14 Oct 2020 21:17:34 +0000 (17:17 -0400)]
clang/Frontend: Use MemoryBufferRef in FrontendInputFile (and remove SourceManager::getBuffer)
In order to drop the final callers to `SourceManager::getBuffer`, change
`FrontendInputFile` to use `Optional<MemoryBufferRef>`. Also updated
the "unowned" version of `SourceManager::createFileID` to take a
`MemoryBufferRef` (it now calls `MemoryBuffer::getMemBuffer`, which
creates a `MemoryBuffer` that does not own the buffer data).
Differential Revision: https://reviews.llvm.org/D89427
Ta-Wei Tu [Tue, 20 Oct 2020 17:32:28 +0000 (10:32 -0700)]
[NPM] Port -mergereturn to NPM
Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D89781
Martin Liska [Fri, 16 Oct 2020 13:08:52 +0000 (15:08 +0200)]
ASAN: Support detect_invalid_pointer_pairs=1 with detect_stack_use_after_return=1
Do not crash when AsanThread::GetStackVariableShadowStart does not find
a variable for a pointer on a shadow stack.
Differential Revision: https://reviews.llvm.org/D89552
Lei Zhang [Tue, 20 Oct 2020 17:04:02 +0000 (13:04 -0400)]
Wrap CfgTraitsFor in namespace llvm to please GCC 5
Jianzhou Zhao [Sun, 18 Oct 2020 04:39:31 +0000 (04:39 +0000)]
Set Huge Page mode on shadow regions based on no_huge_pages_for_shadow
It turned out that at dynamic shared library mode, the memory access
pattern can increase memory footprint significantly on OS when transparent
hugepages (THP) are enabled. This could cause >70x memory overhead than
running a static linked binary. For example, a static binary with RSS
overhead 300M can use > 23G RSS if it is built dynamically.
/proc/../smaps shows in 6204552 kB RSS 6141952 kB relates to
AnonHugePages.
Also such a high RSS happens in some rate: around 25% runs may use > 23G RSS, the
rest uses in between 6-23G. I guess this may relate to how user memory
is allocated and distributted across huge pages.
THP is a trade-off between time and space. We have a flag
no_huge_pages_for_shadow for sanitizer. It is true by default but DFSan
did not follow this. Depending on if a target is built statically or
dynamically, maybe Clang can set no_huge_pages_for_shadow accordingly
after this change. But it still seems fine to follow the default setting of
no_huge_pages_for_shadow. If time is an issue, and users are fine with
high RSS, this flag can be set to false selectively.
Martin Storsjö [Thu, 15 Oct 2020 10:41:50 +0000 (13:41 +0300)]
[libcxx] [test] Fix path.modifiers/make_preferred for windows
Use p.string() instead of p.native() for comparing with the expected
value.
Explicitly list the expected values for both posix and windos, even if
the operation is an identity operation on posix.
Differential Revision: https://reviews.llvm.org/D89532
Martin Storsjö [Tue, 4 Feb 2020 20:51:06 +0000 (22:51 +0200)]
[libcxx] [test] Avoid conflicting definitions of _CRT_SECURE_NO_WARNINGS
This is defined both by libcxx/utils/libcxx/test/config.py (for
any windows target) and msvc_stdlib_force_include.h (when testing
specifically the MSVC C++ library).
The command line define (-D_CRT_SECURE_NO_WARNINGS) defines it to the
value 1; change the header define to match that.
Keeping both instances, to keep the fix for cases when not building
in cases that don't use config.py.
Also remove a comment about whether this can be removed; it can't at
least be removed altogether - doing that breaks a number of tests that
otherwise succeed.
Differential Revision: https://reviews.llvm.org/D89588
Fangrui Song [Mon, 19 Oct 2020 23:45:56 +0000 (16:45 -0700)]
[ELF] --gdb-index: support --icf={safe,all}
The combination has not been tested before. In the case of ICF,
`e.section->getVA(0)` equals the start address of the output section.
This can cause incorrect overlapping with the actual function at the
start of the output section and potentially trigger a GDB internal error
in `dw2_find_pc_sect_compunit_symtab` (presumably because:
if a short address range incorrectly starts at the start address of the
output section, GDB may pick it instead of the correct longer address
range. When mapping an address within the long address range but
out of the scope of the short address range, the routine may find
nothing - while the code asserts that it can find something).
Note that in the case of ICF there may be duplicate address range entries,
but GDB appears to be fine with them.
Reviewed By: grimar
Differential Revision: https://reviews.llvm.org/D89751
Jianzhou Zhao [Sun, 11 Oct 2020 01:26:47 +0000 (01:26 +0000)]
Release pages to OS when setting 0 label
This is a follow up patch of https://reviews.llvm.org/D88755.
When set 0 label for an address range, we can release pages within the
corresponding shadow address range to OS, and set only addresses outside
the pages to be 0.
Reviewed-by: morehouse, eugenis
Differential Revision: https://reviews.llvm.org/D89199
Florian Hahn [Tue, 20 Oct 2020 15:41:56 +0000 (16:41 +0100)]
[DSE] Do not scan users of memory terminators for further reads.
isMemTerminator checks if the current def is a memory terminator that
terminates the memory pointed to by DefLoc. We do not have to add any of
their users to the worklist, because the follow-on users cannot read the
memory in question.
This leads to more stores eliminated in the presence of lifetime calls.
Previously we added the users of those intrinsics to the worklist,
limiting elimination.
In terms of removed stores, this gives a nice boost on some benchmarks
(MultiSource/SPEC2000/SPEC2006 on X86 with -flto -O3):
Same hash: 205 (filtered out)
Remaining: 32
Metric: dse.NumFastStores
Program base patch diff
test-suite...000/197.parser/197.parser.test 4.00 8.00 100.0%
test-suite...rolangs-C++/family/family.test 4.00 7.00 75.0%
test-suite...marks/7zip/7zip-benchmark.test 1722.00 2189.00 27.1%
test-suite...CFP2000/177.mesa/177.mesa.test 30.00 38.00 26.7%
test-suite :: External/Nurbs/nurbs.test 44.00 49.00 11.4%
test-suite...lications/sqlite3/sqlite3.test 115.00 128.00 11.3%
test-suite...006/447.dealII/447.dealII.test 2715.00 3013.00 11.0%
test-suite...ProxyApps-C++/CLAMR/CLAMR.test 237.00 261.00 10.1%
test-suite...tions/lambda-0.1.3/lambda.test 40.00 44.00 10.0%
test-suite...3.xalancbmk/483.xalancbmk.test 1366.00 1475.00 8.0%
test-suite...abench/jpeg/jpeg-6a/cjpeg.test 13.00 14.00 7.7%
test-suite...oxyApps-C++/miniFE/miniFE.test 43.00 46.00 7.0%
test-suite...lications/ClamAV/clamscan.test 230.00 246.00 7.0%
test-suite...006/450.soplex/450.soplex.test 284.00 299.00 5.3%
test-suite...nsumer-jpeg/consumer-jpeg.test 21.00 22.00 4.8%
Simon Pilgrim [Tue, 20 Oct 2020 15:44:59 +0000 (16:44 +0100)]
[InstCombine] SimplifyDemandedUseBits - replace dyn_cast<ConstantInt> with m_ConstantInt. NFCI.
Jay Foad [Tue, 20 Oct 2020 15:30:39 +0000 (16:30 +0100)]
[AMDGPU] Remove unused declaration. NFC.
The implementation of this method was removed in D89706.
Simon Pilgrim [Tue, 20 Oct 2020 14:45:54 +0000 (15:45 +0100)]
[InstCombine] foldOrOfICmps - use m_Specific instead of explicit comparisons. NFCI.
Mikhail Maltsev [Tue, 20 Oct 2020 15:21:38 +0000 (16:21 +0100)]
[clang] Use SourceLocation as key in hash maps, NFCI
The patch adjusts the existing `llvm::DenseMap<unsigned, T>` and
`llvm::DenseSet<unsigned>` objects that store source locations, so
that they use `SourceLocation` directly instead of `unsigned`.
This patch relies on the `DenseMapInfo` trait added in D89719.
It also replaces the construction of `SourceLocation` objects from
the constants -1 and -2 with calls to the trait's methods `getEmptyKey`
and `getTombstoneKey` where appropriate.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D69840
Hans Wennborg [Tue, 20 Oct 2020 15:12:07 +0000 (17:12 +0200)]
Explicitly initialize StreamingDiagnostic in derived class copy ctors
To pacify a GCC warning:
[1/1] Building CXX object tools/clang/lib/Analysis/CMakeFiles/obj.clangAnalysis.dir/Dominators.cpp.o
In file included from /work/llvm.monorepo/clang/include/clang/AST/NestedNameSpecifier.h:18:0,
from /work/llvm.monorepo/clang/include/clang/AST/Type.h:21,
from /work/llvm.monorepo/clang/include/clang/AST/DeclarationName.h:16,
from /work/llvm.monorepo/clang/include/clang/AST/DeclBase.h:18,
from /work/llvm.monorepo/clang/include/clang/Analysis/AnalysisDeclContext.h:20,
from /work/llvm.monorepo/clang/include/clang/Analysis/Analyses/Dominators.h:16,
from /work/llvm.monorepo/clang/lib/Analysis/Dominators.cpp:9:
/work/llvm.monorepo/clang/include/clang/Basic/Diagnostic.h:
In copy constructor ‘clang::DiagnosticBuilder::DiagnosticBuilder(const clang::DiagnosticBuilder&)’:
/work/llvm.monorepo/clang/include/clang/Basic/Diagnostic.h:1287:3:
warning: base class ‘class clang::StreamingDiagnostic’ should be explicitly initialized in the copy constructor [-Wextra]
DiagnosticBuilder(const DiagnosticBuilder &D) {
^
In file included from /work/llvm.monorepo/clang/include/clang/AST/Type.h:29:0,
from /work/llvm.monorepo/clang/include/clang/AST/DeclarationName.h:16,
from /work/llvm.monorepo/clang/include/clang/AST/DeclBase.h:18,
from /work/llvm.monorepo/clang/include/clang/Analysis/AnalysisDeclContext.h:20,
from /work/llvm.monorepo/clang/include/clang/Analysis/Analyses/Dominators.h:16,
from /work/llvm.monorepo/clang/lib/Analysis/Dominators.cpp:9:
/work/llvm.monorepo/clang/include/clang/Basic/PartialDiagnostic.h:
In copy constructor ‘clang::PartialDiagnostic::PartialDiagnostic(const clang::PartialDiagnostic&)’:
/work/llvm.monorepo/clang/include/clang/Basic/PartialDiagnostic.h:52:3:
warning: base class ‘class clang::StreamingDiagnostic’ should be explicitly initialized in the copy constructor [-Wextra]
PartialDiagnostic(const PartialDiagnostic &Other) : DiagID(Other.DiagID) {
^
Hans Wennborg [Tue, 20 Oct 2020 15:06:35 +0000 (17:06 +0200)]
Try to make GCC5 happy about the CfgTraits thing
It was failing with:
In file included from /work/llvm.monorepo/clang/lib/Analysis/Dominators.cpp:9:0:
/work/llvm.monorepo/clang/include/clang/Analysis/Analyses/Dominators.h: At global scope:
/work/llvm.monorepo/clang/include/clang/Analysis/Analyses/Dominators.h:111:26:
error: specialization of ‘template<class CfgRelatedTypeT> struct llvm::CfgTraitsFor’ in different namespace [-fpermissive]
template <> struct llvm::CfgTraitsFor<clang::CFGBlock> {
^
In file included from /work/llvm.monorepo/clang/include/clang/Analysis/Analyses/Dominators.h:21:0,
from /work/llvm.monorepo/clang/lib/Analysis/Dominators.cpp:9:
/work/llvm.monorepo/llvm/include/llvm/Support/CfgTraits.h:294:44:
error: from definition of ‘template<class CfgRelatedTypeT> struct llvm::CfgTraitsFor’ [-fpermissive]
template <typename CfgRelatedTypeT> struct CfgTraitsFor;
^
Mikhail Maltsev [Tue, 20 Oct 2020 14:52:59 +0000 (15:52 +0100)]
[clang][Basic] Make SourceLocation usable as key in hash maps, NFCI
This change creates a `DenseMapInfo` trait specialization for the
SourceLocation class. The empty key, the tombstone key, and the hash
function are identical to `DenseMapInfo<unsigned>`, because we already
have hash maps that use raw the representation of `SourceLocation` as
a key.
The update of existing `DenseMap`s containing raw representation of
`SourceLocation`s will be done in a follow-up patch. As an example
the patch makes use of the new trait in one instance:
clang-tidy/google/UpgradeGoogletestCaseCheck.{h,cpp}
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D89719
Louis Dionne [Tue, 20 Oct 2020 14:42:11 +0000 (10:42 -0400)]
[libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds
Since
9b40ee8eb0c1, new/delete must be requested explicitly during the
CMake configuration if one wants these definitions to appear in libc++.
Differential Revision: https://reviews.llvm.org/D89793
Akira Hatanaka [Tue, 20 Oct 2020 14:34:38 +0000 (07:34 -0700)]
Add a C++ test case for https://reviews.llvm.org/D86854
The test case was part of https://reviews.llvm.org/D82999, which was
abandoned after https://reviews.llvm.org/D86854 fixed the bug.
Michael Liao [Tue, 20 Oct 2020 14:19:44 +0000 (10:19 -0400)]
Revert "[clang] Fix warnings on the missing of explicitly copy constructor on the base class. NFC."
This reverts commit
1ed506deaddb41870d22f5b48d52ba710e8d6c00.
Nico Weber [Tue, 20 Oct 2020 14:23:40 +0000 (10:23 -0400)]
[gn build] assert clang-format does not depend on AST, Frontend, Sema at gn time
To catch things like https://reviews.llvm.org/D69854 and
https://reviews.llvm.org/D89708 earlier next time they happen.
Nico Weber [Tue, 20 Oct 2020 14:17:20 +0000 (10:17 -0400)]
[gn build] belatedly port
3ddac7e56363
Nico Weber [Tue, 20 Oct 2020 14:16:06 +0000 (10:16 -0400)]
[gn build] port
a2214757e2ca more
Simon Pilgrim [Tue, 20 Oct 2020 14:03:08 +0000 (15:03 +0100)]
[InstCombine] Add (icmp ult (X + CA), C1) | (icmp eq X, C2) -> (icmp ule (X + CA), C1) test coverage
Add both commuted variants and vector uniform/nonuniform examples