Kazu Hirata [Sun, 16 Apr 2023 20:03:02 +0000 (13:03 -0700)]
[AMDGPU] Modernize Status and BlockData (NFC)
Identified with modernize-use-default-member-init.
Kazu Hirata [Sun, 16 Apr 2023 19:48:14 +0000 (12:48 -0700)]
[IPO] Modernize OpenMPOptPass and OpenMPOptCGSCCPass (NFC)
Identified with readability-redundant-member-init.
Kazu Hirata [Sun, 16 Apr 2023 19:43:02 +0000 (12:43 -0700)]
[InstCombine] Modernize InstCombineOptions (NFC)
Identified with modernize-use-default-member-init.
Lang Hames [Sun, 16 Apr 2023 19:14:15 +0000 (12:14 -0700)]
[ORC][LLJIT] Add LLJITBuilder convenience function to enable debugger support.
Clients can now call LLJITBuilder::setEnableDebuggerSupport to enable
registration of debug info via the GDB-JIT registration protocol for JIT'd
code.
Calling LLJITBuilder::setEnableDebuggerSupport(true) will cause LLJITBuilder to
add either a DebugObjectManagerPlugin (if the object format on the triple is
ELF), or a GDBJITDebugInfoRegistrationPlugin (if the object format on the
triple is MachO). At present there is no support for debugging when using COFF.
This debugger registration support will only work when JITLink is used as the
underlying JIT linker.
This patch only addresses registration of JIT'd code by the JIT. To debug JIT'd
code you may also need to enable JIT'd code debugging in your debugger. E.g.
when debugging MachO JIT'd code under LLDB you will currently need to run
(lldb) set set plugin.jit-loader.gdb.enable on
to tell LLDB to listen for JIT'd code registration.
Kazu Hirata [Sun, 16 Apr 2023 19:12:07 +0000 (12:12 -0700)]
[Analysis] Modernize CallStackTrie (NFC)
Identified with modernize-use-default-member-init.
Jay Foad [Wed, 12 Apr 2023 17:33:01 +0000 (18:33 +0100)]
[AMDGPU] Don't assert that image intrinsics are supported
Unsupported intrinsics should give a regular "cannot select" error.
Differential Revision: https://reviews.llvm.org/D148147
Kazu Hirata [Sun, 16 Apr 2023 18:40:32 +0000 (11:40 -0700)]
[Support] Modernize TimeRecord (NFC)
Identified with modernize-use-default-member-init.
Lang Hames [Sun, 16 Apr 2023 18:10:09 +0000 (11:10 -0700)]
[TargetParser] Expose Triple::getObjectFormatTypeName.
This is useful for printing the object format of a triple in debug logs.
Ezike Ebuka [Sun, 16 Apr 2023 14:19:46 +0000 (14:19 +0000)]
[flang] Refine how Clang dependencies are expressed #58663
Fixes #58663
Reviewed By: awarzynski
Differential Revision: https://reviews.llvm.org/D140998
Kazu Hirata [Sun, 16 Apr 2023 17:18:57 +0000 (10:18 -0700)]
[MCParser] Modernize IntelExpr (NFC)
Identified with readability-redundant-member-init.
Kazu Hirata [Sun, 16 Apr 2023 16:42:34 +0000 (09:42 -0700)]
[llvm] Remove redundant string initialization (NFC)
Identified with readability-redundant-string-init.
NAKAMURA Takumi [Sun, 16 Apr 2023 16:12:40 +0000 (01:12 +0900)]
llvm/module.modulemap: Exclude `CodeGenPassBuilder.h` out of `LLVM_Backend`
NAKAMURA Takumi [Sun, 16 Apr 2023 16:12:40 +0000 (01:12 +0900)]
llvm/module.modulemap: Add `Demangle` in `LLVM_Utils`
NAKAMURA Takumi [Sun, 16 Apr 2023 16:12:40 +0000 (01:12 +0900)]
llvm/module.modulemap: Exclude `Support/Host.h`
It is declared as `deprecated`.
Peter Rong [Sun, 16 Apr 2023 16:07:19 +0000 (09:07 -0700)]
Revert "[FuzzMutate] RandomIRBuilder has more source and sink type now."
This reverts commit
e0117a3efacf9620408393f162a7795b5e0965d2.
Kazu Hirata [Sun, 16 Apr 2023 16:05:20 +0000 (09:05 -0700)]
[Scalar] Use range-based for loops (NFC)
Joseph Huber [Mon, 17 Apr 2023 20:08:59 +0000 (15:08 -0500)]
[clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas
The `llvmlibc-inline-function-decl` check is intended to be used to
allow declarations in the `libc` project's header to be changed per-TU.
However, it is impossible to place this macro in front of a lambda so
this is not helpful. Additionally, lambdas are always going to have
internal linkage so they will not differ accross TUs.
Fixes https://github.com/llvm/llvm-project/issues/62147
Reviewed By: lntue, PiotrZSL
Differential Revision: https://reviews.llvm.org/D148444
NAKAMURA Takumi [Sun, 16 Apr 2023 15:38:49 +0000 (00:38 +0900)]
[CMake] Cleanup deps
NAKAMURA Takumi [Sun, 16 Apr 2023 15:17:45 +0000 (00:17 +0900)]
[CMake] Reorder and reformat deps
Kazu Hirata [Sun, 16 Apr 2023 15:31:23 +0000 (08:31 -0700)]
[flang] Apply fixes from readability-string-compare (NFC)
Kazu Hirata [Sun, 16 Apr 2023 15:25:28 +0000 (08:25 -0700)]
[Transforms] Apply fixes from performance-for-range-copy (NFC)
Florian Hahn [Sun, 16 Apr 2023 14:38:31 +0000 (15:38 +0100)]
[VPlan] Unify Value2VPValue and VPExternalDefs maps (NFCI).
Before this patch, a VPlan contained 2 mappings for Values -> VPValue:
1) Value2VPValue and 2) VPExternalDefs.
This duplication is unnecessary and there are already cases where
external defs are added to Value2VPValue. This patch replaces all uses
of VPExternalDefs with Value2VPValue.
It clarifies the naming of getOrAddVPValue (to getOrAddExternalVPValue)
and addVPValue (to addExternalVPValue).
At the moment, this is NFC, but will enable additional simplifications
in D147783.
Depends on D147891.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D147892
DianQK [Sun, 16 Apr 2023 14:35:27 +0000 (22:35 +0800)]
[SROA] Remove UB-implying metadata when promoting speculative instruction.
After D138238 introduced the then/else blocks, we should remove UB-implying metadata for the promoted speculative instruction.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D148456
Florian Hahn [Sun, 16 Apr 2023 13:48:02 +0000 (14:48 +0100)]
[VPlan] Check VPValue step in isCanonical (NFCI).
Update the isCanonical() implementations to check the VPValue step
operand instead of the step in the induction descriptor.
At the moment this is NFC, but it enables further optimizations if the
step is replaced by a constant in D147783.
Reviewed By: Ayal
Differential Revision: https://reviews.llvm.org/D147891
Nikolas Klauser [Mon, 23 Jan 2023 09:27:14 +0000 (10:27 +0100)]
[libc++] Add hide_from_abi check for classes
We already have a clang-tidy check for making sure that `_LIBCPP_HIDE_FROM_ABI` is on free functions. This patch extends this to class members. The places where we don't check for `_LIBCPP_HIDE_FROM_ABI` are classes for which we have an instantiation in the library.
Reviewed By: ldionne, Mordante, #libc
Spies: jplehr, mikhail.ramalho, sstefan1, libcxx-commits, krytarowski, miyuki, smeenai
Differential Revision: https://reviews.llvm.org/D142332
Piotr Zegar [Sun, 16 Apr 2023 10:16:29 +0000 (10:16 +0000)]
[clang-tidy] Fix handling of UseAssignment option in cppcoreguidelines-prefer-member-initializer
From now on check will use value from cppcoreguidelines-prefer-member-initializer
and fallback to modernize-use-default-member-init.UseAssignment if not specified.
Fixes: #55616.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D147929
Jorge Pinto Sousa [Sun, 16 Apr 2023 10:17:40 +0000 (03:17 -0700)]
[clang-format] Dont interpret variable named interface as keyword for C++
Fixes #53173.
Differential Revision: https://reviews.llvm.org/D148437
LLVM GN Syncbot [Sun, 16 Apr 2023 08:51:39 +0000 (08:51 +0000)]
[gn build] Port
3bf322e69d5c
Piotr Zegar [Sun, 16 Apr 2023 05:58:34 +0000 (05:58 +0000)]
[clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check
Detect implicit and explicit conversions of enum to bool,
when enum doesn't have a enumerator with value equal to 0.
In theory such conversion should always return TRUE.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D144036
Kazu Hirata [Sun, 16 Apr 2023 07:51:27 +0000 (00:51 -0700)]
Apply fixes from performance-faster-string-find (NFC)
Kazu Hirata [Sun, 16 Apr 2023 07:40:05 +0000 (00:40 -0700)]
Remove redundant initialization of std::optional (NFC)
Kazu Hirata [Sun, 16 Apr 2023 07:29:51 +0000 (00:29 -0700)]
[IR] Drop unnecessary const from a return type (NFC)
Identified with readability-const-return-type.
Kazu Hirata [Sun, 16 Apr 2023 07:13:46 +0000 (00:13 -0700)]
[llvm] Apply fixes from readability-redundant-control-flow (NFC)
Kazu Hirata [Sun, 16 Apr 2023 05:39:17 +0000 (22:39 -0700)]
[clang-tools-extra] Use llvm::is_contained (NFC)
Philip Reames [Sun, 16 Apr 2023 04:26:07 +0000 (21:26 -0700)]
[RISCV] Fix a crash in RISCVGatherScatterLowering
We were assuming that the constant must always be fixed length when this is not required. Such code is unlikely after optimization, which is why we didn't see this previously.
Lang Hames [Sun, 16 Apr 2023 03:13:38 +0000 (03:13 +0000)]
[JITLink][ELF][x86-64] Implement ELF::R_X86_64_NONE.
R_X86_64_NONE is a no-op, so we just need to return from addSingleRelocation
early.
Ben Shi [Sat, 15 Apr 2023 04:44:30 +0000 (12:44 +0800)]
[LoongArch] Use empty debug location for register spill/reload
Spill/reload instructions are automatically generated by the
compiler and have no relation to the original source code. So it
would be better to not attach any debug location to them.
The X86/AArch64/ARM/Thumb backends all follow this way.
Reviewed By: xen0n
Differential Revision: https://reviews.llvm.org/D148304
Lang Hames [Sun, 16 Apr 2023 02:35:36 +0000 (02:35 +0000)]
[JITLink][x86-64] Add x86_64::Pointer8 edge kind, ELF::R_X86_64_8 reloc support.
This commit adds an x86-64 Pointer8 edge kind (8-bit pointer), and uses it to
implement support for the ELF::R_X86_64_8 relocation kind.
Lang Hames [Sun, 16 Apr 2023 02:07:31 +0000 (02:07 +0000)]
[JITLink][ELF][x86-64] Replace R_X86_64_32 yaml testcase with asm version.
The assembly version of this testcase is shorter and easier to read.
Lang Hames [Sun, 16 Apr 2023 01:59:00 +0000 (01:59 +0000)]
[JITLink][x86-64] Implement ELF::R_X86_64_16.
We already had an x86_64::Pointer16 edge kind courtesy of Sunho's COFF/x86-64
work, it just needed to be wired up.
Lang Hames [Sat, 15 Apr 2023 20:13:21 +0000 (20:13 +0000)]
[JITLink][aarch64] Update aarch64 test names
Tests in test/ExecutionEngine/JITLink/AArch64 are for aarch64 only, so we don't
need to repeat 'aarch64' / 'arm64' in the individual test names.
Commit
8ad75c10372 made a similar change for the x86-64 tests.
Jun Zhang [Sat, 15 Apr 2023 16:38:38 +0000 (00:38 +0800)]
[clang-repl] JITTargetAddress --> ExecutorAddr, NFC
Most of Orc and JITLink are movinng away from JITTargetAddress and
use ExecutorAddr instead.
Signed-off-by: Jun Zhang <jun@junz.org>
Differential Revision: https://reviews.llvm.org/D148434
Matthias Springer [Sat, 15 Apr 2023 03:18:56 +0000 (12:18 +0900)]
[mlir][tensor][bufferize] Fix dealloc placement in scf.forall op
The terminator of this op is special: it does not just yield a value,
but bufferizes to a memcpy. This requires special treatment to make sure
that deallocs are placed after the memcpy. (By default, deallocs are
placed right before the terminator.)
Differential Revision: https://reviews.llvm.org/D148408
Aart Bik [Sat, 15 Apr 2023 01:30:29 +0000 (18:30 -0700)]
[mlir][sparse][gpu] generate single module, unique kernel names
This fixes a TODO in the first version.
Reviewed By: Peiming
Differential Revision: https://reviews.llvm.org/D148406
Peter Rong [Sat, 15 Apr 2023 23:39:01 +0000 (16:39 -0700)]
[FuzzMutate] Update unit testing
There are some typos in the previous patch
e0117a3efacf that woulc break unit test and CI.
These typos are fixed now.
Signed-off-by: Peter Rong <PeterRong96@gmail.com>
Peter Rong [Tue, 13 Dec 2022 03:04:41 +0000 (19:04 -0800)]
[FuzzMutate] RandomIRBuilder has more source and sink type now.
Source and Sink are required when generating a new instruction.
(Term defined by previous author, in LLVM terms it's probably Use and User.)
Previously, only instructions in the same block is considered when taking source and sink.
In this patch, more source and sink types are considered.
For source, we have SrcFromInstInCurBlock, FunctionArgument, InstInDominator, SrcFromGlobalVariable, and NewConstOrStack.
For sink, we have SinkToInstInCurBlock, PointersInDominator, InstInDominatee, NewStore, and SinkToGlobalVariable.
A unit test to make sure source always dominates an instruction, and the instruction always dominates the sink is included.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D139907
Nathan James [Sat, 15 Apr 2023 21:58:15 +0000 (22:58 +0100)]
[clang-tidy] Fix crash in --dump-config
Fixes a crash in dump-config when checks emit warnings trying to read the config
Fixes https://github.com/llvm/llvm-project/issues/50876
Co-authored-by: Piotr Zegar <me@piotrzegar.pl>
Reviewed By: PiotrZSL
Differential Revision: https://reviews.llvm.org/D148436
Kazu Hirata [Sat, 15 Apr 2023 21:34:40 +0000 (14:34 -0700)]
[InstCombine] Precommit a test
This patch precommits a test for:
https://github.com/llvm/llvm-project/issues/61650
Kazu Hirata [Sat, 15 Apr 2023 21:26:24 +0000 (14:26 -0700)]
Use isNegative (NFC)
Kazu Hirata [Sat, 15 Apr 2023 21:22:13 +0000 (14:22 -0700)]
[lldb] Use StringMap::contains (NFC)
Kazu Hirata [Sat, 15 Apr 2023 21:14:56 +0000 (14:14 -0700)]
[Target] Use range-based for loops (NFC)
Lang Hames [Sat, 15 Apr 2023 18:35:11 +0000 (18:35 +0000)]
[JITLink][X86] Rename X86 test directory to x86-64, update test names.
Tests in test/ExecutionEngine/JITLink/X86 were for x86-64 only (never i386) so
it makes sense to name the test directory x86-64, and drop x86-64 from the
individual test names.
Kazu Hirata [Sat, 15 Apr 2023 18:32:33 +0000 (11:32 -0700)]
[InstCombine] Generate better code for std::bit_floor from libstdc++
Without this patch, std::bit_floor<uint32_t> in libstdc++ is compiled
as:
%eq0 = icmp eq i32 %x, 0
%lshr = lshr i32 %x, 1
%ctlz = tail call i32 @llvm.ctlz.i32(i32 %lshr, i1 false)
%sub = sub i32 32, %ctlz
%shl = shl i32 1, %sub
%sel = select i1 %eq0, i32 0, i32 %shl
With this patch:
%eq0 = icmp eq i32 %x, 0
%ctlz = call i32 @llvm.ctlz.i32(i32 %x, i1 false)
%lshr = lshr i32 -
2147483648, %1
%sel = select i1 %eq0, i32 0, i32 %lshr
This patch recognizes the specific pattern emitted for std::bit_floor
in libstdc++.
https://alive2.llvm.org/ce/z/piMdFX
This patch fixes:
https://github.com/llvm/llvm-project/issues/61183
Differential Revision: https://reviews.llvm.org/D145890
Mark de Wever [Sat, 15 Apr 2023 18:12:24 +0000 (20:12 +0200)]
Revert "Revert "Revert "[CMake] Bumps minimum version to 3.20.0."""
This reverts commit
1ef4c3c859728008cf707cad8d67f45ae5070ae1.
Two buildbots still haven't been updated.
Lang Hames [Sat, 15 Apr 2023 04:50:49 +0000 (04:50 +0000)]
[JITLink][ELF][x86-64] Don't use intermediate edge-kinds in ELF/x86-64 backend.
The mapping from ELF relocation types to JITLink x86-64 edge kinds is 1-1, so
we don't need the intermediate step.
Vlad Serebrennikov [Sat, 15 Apr 2023 15:24:35 +0000 (18:24 +0300)]
[clang][NFC] Fix DR test ordering
Some C++ DR tests are disrupting the usual ascending order, introducing confusion, and making people put new tests in the wrong place (myself included). This change affects 15 tests out of roughly 700.
Nathan James [Sat, 15 Apr 2023 14:51:26 +0000 (14:51 +0000)]
[clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive
Fix https://llvm.org/PR49498.
The check notices 2 sides of a conditional operator have types with a different constness and so tries to examine the implicit cast.
As one side is infinity, the float narrowing detection sees when its casted to a double(which it already was) it thinks the result is out of range.
I've fixed this by just disregarding expressions where the builtin type(without quals) match as no conversion would take place.
However this has opened a can of worms. Currenty `float a = std::numeric_limits<double>::infinity();` is marked as narrowing.
Whats more suspicious is `double a = std::numeric_limits<float>::infinity();` is also marked as narrowing.
It could be argued `double inf -> float inf` is narrowing, but `float inf -> double inf` definitely isnt.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D98416
Mark de Wever [Sat, 15 Apr 2023 15:01:38 +0000 (17:01 +0200)]
[NFC][libc++] Removes incorrect sliceExpr friend.
There is no type named sliceExpr, so it's likely a misspelling of
either slice_array or __slice_expr. Neither of which appear to
need the friend declaration.
This may indicate a unimplemented bit of `<valarray`, but ¯\_(ツ)_/¯
Nobody uses it anyway.
(Commit message provided by @EricWF.)
This reverts commit
e13c43b229527234ec99f7f03aff3e1560c259c8.
Mark de Wever [Sat, 15 Apr 2023 14:56:50 +0000 (16:56 +0200)]
Revert "[NFC][libc++] Removes sliceExpr friend."
This reverts commit
d5193e34b81fb3e9c27aea541516112d8a5f708d.
Reverted at @EricWF's request so it can be relanded with a better commit
message.
Carlos Galvez [Sat, 15 Apr 2023 14:49:01 +0000 (14:49 +0000)]
[clang-tidy][NFC] Fix format of header file comment in MisleadingCaptureDefaultByValueCheck.h
Piotr Zegar [Sat, 15 Apr 2023 13:16:35 +0000 (13:16 +0000)]
Revert "[clang-tidy] Add misc-header-include-cycle check"
This reverts commit
9ece8753d5e6f49c31c2d988ef69225c036b25e0.
Florian Hahn [Sat, 15 Apr 2023 13:06:46 +0000 (14:06 +0100)]
[Matrix] Split off transpose + dot product tests.
Piotr Zegar [Sat, 15 Apr 2023 12:39:25 +0000 (12:39 +0000)]
[clang-tidy] Add misc-header-include-cycle check
Check detects cyclic #include dependencies between user-defined headers.
Reviewed By: njames93
Differential Revision: https://reviews.llvm.org/D144828
Joseph Huber [Tue, 11 Apr 2023 20:08:59 +0000 (15:08 -0500)]
[libc] Add `fetch_or` to the atomic interface
Summary:
This patch adds `fetch_or`. It is mainly useful for querying and set a
bit's status without using the more expensive `exchange` functions.
Carlos Galvez [Sat, 15 Apr 2023 10:16:49 +0000 (10:16 +0000)]
[clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value
Also fix ordering in Release Notes.
Differential Revision: https://reviews.llvm.org/D148424
Mark de Wever [Fri, 14 Apr 2023 18:00:51 +0000 (20:00 +0200)]
[NFC][libc++] Removes sliceExpr friend.
The class is never defined. This was discovered while validating modules
in libc++.
Reviewed By: #libc, philnik
Differential Revision: https://reviews.llvm.org/D148357
Mark de Wever [Sat, 15 Apr 2023 11:12:04 +0000 (13:12 +0200)]
Revert "Revert "[CMake] Bumps minimum version to 3.20.0.""
This reverts commit
92523a35a827539db8557bbc3ecab7f9ea3f6ade.
Reland to see whether CIs are updated.
Mark de Wever [Fri, 14 Apr 2023 18:12:27 +0000 (20:12 +0200)]
[libc++] Removes Clang 14 support.
Per our policy we only support the last two releases.
Reviewed By: #libc, EricWF, philnik
Differential Revision: https://reviews.llvm.org/D148359
Piotr Zegar [Sat, 15 Apr 2023 10:29:38 +0000 (10:29 +0000)]
[clang-tidy] Fix typedefs handling in bugprone-dangling-handle
Using 'hasUnqualifiedDesugaredType' to skip all type aliases when
checking for handle.
Fixes #38779
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D148418
LLVM GN Syncbot [Sat, 15 Apr 2023 10:21:07 +0000 (10:21 +0000)]
[gn build] Port
eedbe81b1c6d
Piotr Zegar [Sat, 15 Apr 2023 10:07:45 +0000 (10:07 +0000)]
[clang-tidy] Exclude template instantiations in modernize-use-override
Added IgnoreTemplateInstantiations option to modernize-use-override
check. Allows to ignore virtual function overrides that are part of
template instantiations. This can be useful in cases where the use
of the "override" keyword is not appropriate or causes issues with
template specialization.
Fixes #38276.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D147924
Vlad Serebrennikov [Sat, 15 Apr 2023 10:15:05 +0000 (13:15 +0300)]
[clang] Mark CWG2331 as N/A
[[https://wg21.link/p1787 | P1787]]: CWG2331 is resolved by defining lookup from complete-class contexts and out-of-line member definitions.
Wording: The declaration set is the result of a single search in the scope of C for N from immediately after the class-specifier of C if P is in a complete-class context of C or from P otherwise. ([class.member.lookup]/4)
Reviewed By: #clang-language-wg, shafik
Differential Revision: https://reviews.llvm.org/D148260
Carlos Galvez [Fri, 14 Apr 2023 06:39:12 +0000 (06:39 +0000)]
[clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default
Since Cpp Core Guidelines have accepted the change in the rules:
https://github.com/isocpp/CppCoreGuidelines/commit/
3c90d590e138c3a1e4eb59234e410e00545326de
Also rename the check accordingly.
Differential Revision: https://reviews.llvm.org/D148340
Louis Dionne [Fri, 14 Apr 2023 16:49:03 +0000 (17:49 +0100)]
[libunwind] Sync Unwind_AppleExtras.cpp with downstream version
Both had diverged in a few ways, so this brings them both back in sync.
Differential Revision: https://reviews.llvm.org/D148351
Ben Shi [Sat, 15 Apr 2023 09:10:06 +0000 (17:10 +0800)]
[RISCV] Optimize multiplication with immediates
The optimization of (mul x, c) to (ADD (SLLI x, i0), (SLLI x, i1))
is only enabled for i32 multiplication on rv64, because of
the regression in i64 multiplication on rv32.
However we can change the condition to that the immediate 'c'
should only be used once, then the above regression can also be
avoided, and ohter chances of optimization can be enabled.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D147410
Piotr Zegar [Sat, 15 Apr 2023 08:34:41 +0000 (08:34 +0000)]
[clang-tidy] Add support for long double in bugprone-incorrect-roundings
Support all floating point representations for an 0.5 floating const.
Added missing tests.
Depend on D147906.
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D147908
Piotr Zegar [Sat, 15 Apr 2023 08:34:04 +0000 (08:34 +0000)]
[clang-tidy] Avoid float compare in bugprone-incorrect-roundings
Using APFloat to compare floating numbers instead of float/double.
Fixes: #46424
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D147906
Akshay Khadse [Sat, 15 Apr 2023 06:00:45 +0000 (14:00 +0800)]
Fix uninitialized pointer members in Target/X86
Reviewed By: LuoYuanke
Differential Revision: https://reviews.llvm.org/D148312
chenglin.bi [Sat, 15 Apr 2023 08:12:31 +0000 (16:12 +0800)]
[InstSimplify] Precommit tests for dominate conditions are not single predecessor; NFC
Vitaly Buka [Fri, 14 Apr 2023 23:22:54 +0000 (16:22 -0700)]
[NFC][lsan] Add GetCurrentThreadId wrapper for GetCurrentThread
I am going to change return type of GetCurrentThreadId() in the next
patch.
Differential Revision: https://reviews.llvm.org/D148394
Vitaly Buka [Sat, 15 Apr 2023 05:38:58 +0000 (22:38 -0700)]
[test][sanitizer] Add another stress test for pthread_create
Vitaly Buka [Sat, 15 Apr 2023 00:18:04 +0000 (17:18 -0700)]
[NFC][sanitizer] Return nullptr instead of 0
Sergei Barannikov [Thu, 13 Apr 2023 01:42:07 +0000 (04:42 +0300)]
[GISel] Legalize G_FSUB to G_FADD + G_FNEG even if G_FNEG is illegal
`G_FNEG` used to be legalized to `G_FSUB -0, x` causing infinite loop.
This is no longer the case after D84287.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D148187
Akshay Khadse [Sat, 15 Apr 2023 03:28:50 +0000 (11:28 +0800)]
Guard against dereferencing a nullptr
In `lib/CodeGen/PrologEpilogInserter.cpp` file, `RS` is assigned via `RS = TRI->requiresRegisterScavenging(MF) ? new RegScavenger() : nullptr;`. This means that `RS` can be `nullptr`. While executing the `TFI->processFunctionBeforeFrameFinalized(MF, RS);`, the `RS` can be dereferenced in the call `RS->enterBasicBlock(MBB);` in file `lib/Target/AMDGPU/SIFrameLowering.cpp`
Reviewed By: skan, arsenm
Differential Revision: https://reviews.llvm.org/D146791
Craig Topper [Sat, 15 Apr 2023 02:40:56 +0000 (19:40 -0700)]
[TableGen] Make InlinePatternFragments a member of TreePatternNode again. NFC
Now that we use IntrusiveRefCntPtr instead of std::shared_ptr
we don't need to pass a TreePatternNodePtr to this method.
Craig Topper [Sat, 15 Apr 2023 02:30:45 +0000 (19:30 -0700)]
[RISCV] Move RISCVInstrInfoZihintntl.td include out of the vendor extension section. NFC
Florian Mayer [Sat, 15 Apr 2023 01:50:22 +0000 (18:50 -0700)]
[hwasan] [test] fix test broken by argument promotion pass
Fangrui Song [Sat, 15 Apr 2023 01:42:11 +0000 (18:42 -0700)]
Revert D148384 "[Demangle] replace use of llvm::StringView w/ std::string_view"
This reverts commit
3e559509b426b6aae735a7f57dbdaed1041d2622 and
e0c4ffa796b553fa78c638a9584c05ac21fe07d5.
This still breaks Windows builds.
In addition, `#include <llvm/ADT/StringViewExtras.h>` in
llvm/include/llvm/Demangle/ItaniumDemangle.h is a library layering violation
(LLVMDemangle is the lowest LLVM library and cannot depend on LLVMSupport).
Prem Chintalapudi [Sat, 15 Apr 2023 00:35:07 +0000 (17:35 -0700)]
[NewPM] Use PassID instead of pass name
PrintIRInstrumentation::shouldPrintAfterPass accepts a pass ID instead of a pass name
Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D147394
Arthur Eubanks [Fri, 14 Apr 2023 18:06:17 +0000 (11:06 -0700)]
[MC] Add section flag 'l' for SHF_X86_64_LARGE
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D148358
Paul Kirth [Fri, 14 Apr 2023 23:51:34 +0000 (23:51 +0000)]
[asan][test] Fix use-after-scope-capture test after D148269
After enabling ArgPromotion at lower opt levels, the body of this test
was optimized away, and the CHECK lines no longer functioned.
Setting -O0 is a hammer, but gets the test passing again, until code owners
can find a better solution.
Reviewed By: fmayer
Differential Revision: https://reviews.llvm.org/D148396
Vitaly Buka [Fri, 14 Apr 2023 22:43:56 +0000 (15:43 -0700)]
[NFC][lsan] Move SetCurrentThread call
Future patch will set the current context as well.
Existing callsite requires additional lock to find context.
Differential Revision: https://reviews.llvm.org/D148390
Nick Desaulniers [Fri, 14 Apr 2023 23:25:11 +0000 (16:25 -0700)]
[Demangle] fix windows build
Fixes diagnostics reported against
https://reviews.llvm.org/D148384
https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D148392
Noah Goldstein [Fri, 14 Apr 2023 19:34:23 +0000 (14:34 -0500)]
[ValueTracking] Add `shl nsw %val, %cnt != 0` if `%val != 0`.
Link: https://alive2.llvm.org/ce/z/mxZLJn
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D147898
Noah Goldstein [Sun, 9 Apr 2023 21:27:57 +0000 (16:27 -0500)]
[ValueTracking] Use maximum shift count in `shl` when determining if `shl` can be zero.
Previously only return `shl` non-zero if the shift value was `1`. We
can expand this if we have some bounds on the shift count.
For example:
```
%cnt = and %c, 16 ; Max cnt == 16
%val = or %v, 4 ; val[2] is known one
%shl = shl %val, %cnt ; (val.known.one << cnt.maxval) != 0
```
Differential Revision: https://reviews.llvm.org/D147897
Noah Goldstein [Sun, 9 Apr 2023 22:11:27 +0000 (17:11 -0500)]
[ValueTracking] Add more tests for `shl` isKnownNonZero; NFC
Differential Revision: https://reviews.llvm.org/D147896
Daniel Hoekwater [Tue, 11 Apr 2023 00:09:59 +0000 (17:09 -0700)]
Account for PATCHABLE instrs in Branch Relaxation
PATCHABLE_* instructions expand to up to 36-byte
sleds. Updating the size of PATCHABLE instructions
causes them to be outlined, so we need to add a
check to prevent the outliner from considering
basic blocks that contain PATCHABLE instructions.
Differential Revision: https://reviews.llvm.org/D147982
V Donaldson [Wed, 12 Apr 2023 22:37:19 +0000 (15:37 -0700)]
[flang] Remove `ignoring all compiler directives` warning
The explicit `ignoring all compiler directives` reminder warning is no
longer accurate. Any similar, more accurate message is best generated
by the front end (change pending).
Fangrui Song [Fri, 14 Apr 2023 23:06:12 +0000 (16:06 -0700)]
[MCParser] Reject processor-specific section flags not known by the current target
Catch accidentally used flags and match MCSectionELF.cpp
`MCSectionELF::printSwitchToSection`.
Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D148386
Nick Desaulniers [Fri, 14 Apr 2023 22:43:03 +0000 (15:43 -0700)]
[Demangle] replace use of llvm::StringView w/ std::string_view
This refactoring was waiting on converting LLVM to C++17.
Leave StringView.h and cleanup around for subsequent cleanup.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D148384