borenet@google.com [Thu, 27 Jun 2013 11:53:37 +0000 (11:53 +0000)]
Whitespace change to trigger rebuilds after master restart.
Unreviewed.
Review URL: https://codereview.chromium.org/
18058002
git-svn-id: http://skia.googlecode.com/svn/trunk@9787
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 27 Jun 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9786
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 26 Jun 2013 22:57:29 +0000 (22:57 +0000)]
Fix for crbug/253460 (generatePath crashing on Windows).
Sometimes GetGlyphOutlineW returns a number larger than BUFFERSIZE
even if BUFFERSIZE > 0. It was previously expected that GetGlyphOutlineW
would always return GDI_ERROR in this case.
git-svn-id: http://skia.googlecode.com/svn/trunk@9785
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Jun 2013 22:20:22 +0000 (22:20 +0000)]
Alias deref -> unref. This allows Skia objects to be held by WTF::RefPtr
smart pointers without need for another smart pointer type.
Note that the semantics of SkRefCnt match those WTF expects. In
particular, newly created objects have refcount 1 and objects are
deallocated at refcount 0.
This seems like a better fit than the AddRef/Release alises which exist
for scoped_ptr (but seem unused).
BUG=254509
R=reed@google.com
Author: jbroman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
17880003
git-svn-id: http://skia.googlecode.com/svn/trunk@9784
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 26 Jun 2013 21:28:10 +0000 (21:28 +0000)]
struct != class, even in a friend forward declare
git-svn-id: http://skia.googlecode.com/svn/trunk@9783
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 26 Jun 2013 21:09:37 +0000 (21:09 +0000)]
move legacy mipmap apis to private, save one that is currently called by chrome. It will go soon...
git-svn-id: http://skia.googlecode.com/svn/trunk@9782
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Jun 2013 21:08:11 +0000 (21:08 +0000)]
Remove SK_IGNORE_MAC_TEXT_BOUNDS_FIX workaround.
Now that SK_IGNORE_MAC_TEXT_BOUNDS_FIX is no longer used in Chromium, we can remove the code.
R=bungeman@gmail.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
17886002
git-svn-id: http://skia.googlecode.com/svn/trunk@9781
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 26 Jun 2013 20:38:39 +0000 (20:38 +0000)]
ignore pyc files.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
17845007
git-svn-id: http://skia.googlecode.com/svn/trunk@9778
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Jun 2013 19:18:23 +0000 (19:18 +0000)]
Change undefined SkGpuRenderTarget and SkGpuTexture forward declares to GrRenderTarget and GrTexture.
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://chromiumcodereview.appspot.com/
17269003
git-svn-id: http://skia.googlecode.com/svn/trunk@9775
2bbb7eff-a529-9590-31e7-
b0007b416f81
zachr@google.com [Wed, 26 Jun 2013 18:55:36 +0000 (18:55 +0000)]
add globbing util function
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
17881002
git-svn-id: http://skia.googlecode.com/svn/trunk@9774
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 26 Jun 2013 17:48:12 +0000 (17:48 +0000)]
refactoring for pdf viewer lib
Review URL: https://codereview.chromium.org/
17856004
git-svn-id: http://skia.googlecode.com/svn/trunk@9773
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 26 Jun 2013 17:06:45 +0000 (17:06 +0000)]
Add a new GM for very thin stroke widths
git-svn-id: http://skia.googlecode.com/svn/trunk@9770
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 26 Jun 2013 15:53:29 +0000 (15:53 +0000)]
Fix PathRefDebugRef (SK_DEBUG_PATH_REF) case for SkPath copy constructor.
Review URL: https://codereview.chromium.org/
17902003
git-svn-id: http://skia.googlecode.com/svn/trunk@9768
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 26 Jun 2013 15:28:42 +0000 (15:28 +0000)]
remove RLE config from debugger too
Review URL: https://codereview.chromium.org/
17857003
git-svn-id: http://skia.googlecode.com/svn/trunk@9766
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 26 Jun 2013 14:52:34 +0000 (14:52 +0000)]
fix build break, remove "RLE" from gConfigNames too
Review URL: https://codereview.chromium.org/
17893004
git-svn-id: http://skia.googlecode.com/svn/trunk@9765
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 26 Jun 2013 14:35:02 +0000 (14:35 +0000)]
remove kRLE_Index8_Config from SkBitmap
BUG=
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
17740003
git-svn-id: http://skia.googlecode.com/svn/trunk@9764
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 26 Jun 2013 07:00:59 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9763
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 26 Jun 2013 00:17:41 +0000 (00:17 +0000)]
Revert "avoid AntiFrameRect when strokeSize is too small. Workaround for skbug/1368"
This reverts commit
b70c77bb33495b5956550b39d479cf9b911d6114.
git-svn-id: http://skia.googlecode.com/svn/trunk@9762
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Jun 2013 23:55:23 +0000 (23:55 +0000)]
avoid AntiFrameRect when strokeSize is too small. Workaround for skbug/1368
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
17739003
git-svn-id: http://skia.googlecode.com/svn/trunk@9761
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 25 Jun 2013 23:21:28 +0000 (23:21 +0000)]
add removed file by mistake
Review URL: https://codereview.chromium.org/
17739006
git-svn-id: http://skia.googlecode.com/svn/trunk@9760
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Jun 2013 21:23:54 +0000 (21:23 +0000)]
move kConfigCount out of Config enum, so we don't pullute type-checking
git-svn-id: http://skia.googlecode.com/svn/trunk@9759
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 25 Jun 2013 21:04:02 +0000 (21:04 +0000)]
Add folders for skimage expectations, plus one set
Expectations json files will be stored here for running skimage.
Once we move to git, this directory will be at a higher level, but
keeping here for now for simplicity.
(SkipBuildbotRuns)
BUG=https://code.google.com/p/skia/issues/detail?id=1241
R=borenet@google.com
Review URL: https://codereview.chromium.org/
17737002
git-svn-id: http://skia.googlecode.com/svn/trunk@9758
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 25 Jun 2013 20:45:40 +0000 (20:45 +0000)]
Basic support for Type3 Fonts in Pdf + various refactorings
Review URL: https://codereview.chromium.org/
17748002
git-svn-id: http://skia.googlecode.com/svn/trunk@9757
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Jun 2013 20:42:37 +0000 (20:42 +0000)]
dump strokeWidth in SkDumpCanvas
git-svn-id: http://skia.googlecode.com/svn/trunk@9756
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 25 Jun 2013 19:26:11 +0000 (19:26 +0000)]
Disable Goma for ChromeOS build
Doesn't work on VMs.
(RunBuilders:Build-Ubuntu12-GCC-x86-Debug-Alex,Build-Ubuntu12-GCC-x86-Release-Alex)
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
17688005
git-svn-id: http://skia.googlecode.com/svn/trunk@9754
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Jun 2013 18:18:07 +0000 (18:18 +0000)]
Remove no longer needed stuff from chromeos build script, always run gyp
(RunBuilders:Test-ChromeOS-Alex-GMA3150-x86-Debug,Test-ChromeOS-Alex-GMA3150-x86-Release,Perf-ChromeOS-Alex-GMA3150-x86-Release)
R=djsollen@google.com
Author: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
17684002
git-svn-id: http://skia.googlecode.com/svn/trunk@9752
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 25 Jun 2013 18:07:45 +0000 (18:07 +0000)]
Ensure we use the current locale when looking up fallback fonts per character
http://crbug.com/183830
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
17691002
git-svn-id: http://skia.googlecode.com/svn/trunk@9751
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 25 Jun 2013 15:39:58 +0000 (15:39 +0000)]
Revert r9724 (add rect-output parameter to isRect) to allow the DEPS roll
git-svn-id: http://skia.googlecode.com/svn/trunk@9750
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 25 Jun 2013 13:14:38 +0000 (13:14 +0000)]
Temporarily disable gpu on chromeos
Unreviewed.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
17611013
git-svn-id: http://skia.googlecode.com/svn/trunk@9747
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 24 Jun 2013 19:31:58 +0000 (19:31 +0000)]
Use a single cros_toolchain tarball for ChromeOS build
It's stored in our GS bucket, so we won't need two sets of credentials.
(SkipBuildbotRuns) since this isn't in use.
Review URL: https://codereview.chromium.org/
17608003
git-svn-id: http://skia.googlecode.com/svn/trunk@9743
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 24 Jun 2013 11:03:18 +0000 (11:03 +0000)]
Fix Performance trigger baselines
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9739
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 22 Jun 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9738
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Jun 2013 21:45:20 +0000 (21:45 +0000)]
Add modulo flag to lua_pictures.
The intended use is spawning processes to save time.
R=caryclark@google.com, reed@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/
16950025
git-svn-id: http://skia.googlecode.com/svn/trunk@9736
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 21 Jun 2013 21:43:09 +0000 (21:43 +0000)]
add missing font.* files, map podofo to SkPdfObject for SkPdfArray::operator[]
Review URL: https://codereview.chromium.org/
17063014
git-svn-id: http://skia.googlecode.com/svn/trunk@9735
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Fri, 21 Jun 2013 21:03:15 +0000 (21:03 +0000)]
load font manually, for now Type0
Review URL: https://codereview.chromium.org/
17294008
git-svn-id: http://skia.googlecode.com/svn/trunk@9734
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Jun 2013 19:51:31 +0000 (19:51 +0000)]
restore bitmap.erase() support for 4444 : trivial, and BitmapCopyTest relied on it
git-svn-id: http://skia.googlecode.com/svn/trunk@9731
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 21 Jun 2013 19:12:47 +0000 (19:12 +0000)]
Treat empty directory properly in skimage.
Instead of treating an empty directory as a file that failed to
decode, treat it as an empty directory.
Add self tests to check for this.
Builds upon from https://codereview.chromium.org/
16866010,
which was reverted.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
17101029
git-svn-id: http://skia.googlecode.com/svn/trunk@9730
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Jun 2013 19:05:57 +0000 (19:05 +0000)]
remove dead AutoValidator
git-svn-id: http://skia.googlecode.com/svn/trunk@9729
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Jun 2013 18:40:09 +0000 (18:40 +0000)]
remove dead references to PlatformProcs4444
git-svn-id: http://skia.googlecode.com/svn/trunk@9728
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Jun 2013 18:30:53 +0000 (18:30 +0000)]
remove dst/rendertarget support for kARGB_4444_Config
BUG=
Review URL: https://codereview.chromium.org/
17335008
git-svn-id: http://skia.googlecode.com/svn/trunk@9727
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 21 Jun 2013 18:16:47 +0000 (18:16 +0000)]
GM: add --missingExpectationsPath option, similar to --mismatchPath
This will allow us to make the buildbots record all images EXCEPT those which
match expectations to Google Storage.
R=borenet@google.com
Review URL: https://codereview.chromium.org/
17552012
git-svn-id: http://skia.googlecode.com/svn/trunk@9725
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Jun 2013 17:32:32 +0000 (17:32 +0000)]
add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo
https://code.google.com/p/chromium/issues/detail?id=247770
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
16950021
git-svn-id: http://skia.googlecode.com/svn/trunk@9724
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Jun 2013 17:14:48 +0000 (17:14 +0000)]
SkDebugCanvas: remove unused <iostream> include.
No only this is unused, but it's pulling in a static initializer (which makes SkDebugCanvas unusable in Chromium).
BUG=
R=robertphillips@google.com, bungeman@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
17553006
git-svn-id: http://skia.googlecode.com/svn/trunk@9723
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Jun 2013 15:28:54 +0000 (15:28 +0000)]
Fix macro for r9718.
git-svn-id: http://skia.googlecode.com/svn/trunk@9720
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Jun 2013 15:13:34 +0000 (15:13 +0000)]
SkPath::rewind needs to have same reset as SkPath::reset.
R=caryclark@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
17432003
git-svn-id: http://skia.googlecode.com/svn/trunk@9718
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Jun 2013 15:11:40 +0000 (15:11 +0000)]
add (disabled) wrapper for javascript canvas
git-svn-id: http://skia.googlecode.com/svn/trunk@9717
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 21 Jun 2013 07:00:53 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9713
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Jun 2013 05:31:38 +0000 (05:31 +0000)]
Add maxCharWidth and a compile flag to use old metrics (needed by Blink).
Review URL: https://codereview.chromium.org/
17502006
git-svn-id: http://skia.googlecode.com/svn/trunk@9712
2bbb7eff-a529-9590-31e7-
b0007b416f81
egdaniel@google.com [Thu, 20 Jun 2013 21:18:05 +0000 (21:18 +0000)]
Change window size on GM to fit objects properly
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
17419010
git-svn-id: http://skia.googlecode.com/svn/trunk@9711
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Jun 2013 20:28:54 +0000 (20:28 +0000)]
Add gyp define for optimization level
R=tomhudson@google.com, djsollen@google.com, epoger@google.com, bungeman@google.com
Author: borenet@google.com
Review URL: https://chromiumcodereview.appspot.com/
17370005
git-svn-id: http://skia.googlecode.com/svn/trunk@9710
2bbb7eff-a529-9590-31e7-
b0007b416f81
egdaniel@google.com [Thu, 20 Jun 2013 18:05:31 +0000 (18:05 +0000)]
Turn off conic GM for now
BUG=
Review URL: https://codereview.chromium.org/
17500004
git-svn-id: http://skia.googlecode.com/svn/trunk@9707
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 20 Jun 2013 17:54:26 +0000 (17:54 +0000)]
Fixed invalid cast on mingw.
Fixes GCC error:
SkThread_win.cpp:39:61: error: invalid static_cast from type ‘int32_t {aka int}’ to type ‘const volatile LONG& {aka const volatile long int&}’
Review URL: https://codereview.chromium.org/
17047004
git-svn-id: http://skia.googlecode.com/svn/trunk@9706
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Jun 2013 17:40:21 +0000 (17:40 +0000)]
formally declare luaskia extern guy, and then define it
BUG=
Review URL: https://codereview.chromium.org/
17503003
git-svn-id: http://skia.googlecode.com/svn/trunk@9705
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Jun 2013 17:37:24 +0000 (17:37 +0000)]
disable PDF for now, until it knows about conics
git-svn-id: http://skia.googlecode.com/svn/trunk@9704
2bbb7eff-a529-9590-31e7-
b0007b416f81
zachr@google.com [Thu, 20 Jun 2013 17:15:05 +0000 (17:15 +0000)]
enable shared lib support in linux for lua
R=bungeman@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
16099014
git-svn-id: http://skia.googlecode.com/svn/trunk@9703
2bbb7eff-a529-9590-31e7-
b0007b416f81
egdaniel@google.com [Thu, 20 Jun 2013 16:54:31 +0000 (16:54 +0000)]
Add GM to test conic path rendering
R=reed@google.com
Review URL: https://codereview.chromium.org/
17365006
git-svn-id: http://skia.googlecode.com/svn/trunk@9702
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 20 Jun 2013 15:29:16 +0000 (15:29 +0000)]
Fix limit on size of glyph paths.
Some web fonts have been observed to contain glyphs which require a buffer
greater than 20KB. In these rare cases we should allocate space on the heap.
Most glyphs require less than 8KB, and Windows has a 1MB stack, so in the
common case just use the stack.
This change also removes the gFTMutex which was both poorly named and used.
The constructor does not appear to have any need for it, and with this change
the path generation code does not need it. The mask generating code does need
memory barriers for correctness, but these bariers are no-ops on x86. We will
need another change to clean up this sort of static initialization code.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
17435003
git-svn-id: http://skia.googlecode.com/svn/trunk@9700
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 20 Jun 2013 07:06:44 +0000 (07:06 +0000)]
Rebaselining some performance trigger flakes
git-svn-id: http://skia.googlecode.com/svn/trunk@9696
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 20 Jun 2013 07:00:59 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9695
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 19 Jun 2013 23:06:00 +0000 (23:06 +0000)]
Fix shift detection in views on X.
On X, the meta keys are encoded in xkey.state, not xkey.keycode.
This fixes 'h' and 's' not working in SampleApp.
git-svn-id: http://skia.googlecode.com/svn/trunk@9694
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 19 Jun 2013 20:56:45 +0000 (20:56 +0000)]
post Expose event when we see an inval
git-svn-id: http://skia.googlecode.com/svn/trunk@9693
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 19 Jun 2013 19:44:18 +0000 (19:44 +0000)]
Allow specification of a non-default boto file in chromeos_make
This is needed because our GS bucket needs a different auth key from the
ChromeOS bucket.
(SkipBuildbotRuns)
R=epoger@google.com
Review URL: https://codereview.chromium.org/
16975017
git-svn-id: http://skia.googlecode.com/svn/trunk@9692
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 19 Jun 2013 19:25:36 +0000 (19:25 +0000)]
combine glyph and image bulk alloc, and adjust initial alloc size, to reduce total waste from 50% to 30%
add diagnostics to measure cache efficiency
BUG=
Review URL: https://codereview.chromium.org/
17449012
git-svn-id: http://skia.googlecode.com/svn/trunk@9691
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 19 Jun 2013 19:12:53 +0000 (19:12 +0000)]
Allow skimage expectations file to not exist.
If the file is not there, assume that all images are mismatches.
This allows running the test before the initial rebaseline.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
17448011
git-svn-id: http://skia.googlecode.com/svn/trunk@9690
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 19 Jun 2013 18:56:59 +0000 (18:56 +0000)]
rebaseline.py: split image-based rebaselining, which will go away soon, into its own script
(part of step 3 in https://goto.google.com/ChecksumTransitionDetail )
also adds new --expectations-root option
R=scroggo@google.com, senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
17379004
git-svn-id: http://skia.googlecode.com/svn/trunk@9689
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 19 Jun 2013 18:52:42 +0000 (18:52 +0000)]
fix https://code.google.com/p/skia/issues/detail?id=1356
('32-bit Mac compiler doesn't like https://code.google.com/p/skia/source/detail?r=9686')
git-svn-id: http://skia.googlecode.com/svn/trunk@9688
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 19 Jun 2013 18:28:31 +0000 (18:28 +0000)]
Reland r9682, using new SkString::appendU64()
Review URL: https://codereview.chromium.org/
17157005
git-svn-id: http://skia.googlecode.com/svn/trunk@9687
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 19 Jun 2013 18:27:20 +0000 (18:27 +0000)]
Add SkString::appendU32() and SkString::appendU64()
as needed to re-land r9682
R=reed@google.com
Review URL: https://codereview.chromium.org/
17448012
git-svn-id: http://skia.googlecode.com/svn/trunk@9686
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 19 Jun 2013 17:42:17 +0000 (17:42 +0000)]
Deal with ca and CA transparency operators in pdf. add comments to generated classes.
Review URL: https://codereview.chromium.org/
16975013
git-svn-id: http://skia.googlecode.com/svn/trunk@9685
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 19 Jun 2013 15:58:00 +0000 (15:58 +0000)]
Reverting r9682, which broke on some compilers
git-svn-id: http://skia.googlecode.com/svn/trunk@9684
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 19 Jun 2013 15:50:09 +0000 (15:50 +0000)]
GM: add --writeChecksumBasedFilenames option
as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail :
make GenerateGMs upload actual images to Google Storage instead of skia-autogen
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
17365002
git-svn-id: http://skia.googlecode.com/svn/trunk@9682
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 19 Jun 2013 15:13:32 +0000 (15:13 +0000)]
Use "Simple Chrome for Chrome OS Workflow" to build Skia for ChromeOS
(SkipBuildbotRuns) since this isn't used yet.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
17412007
git-svn-id: http://skia.googlecode.com/svn/trunk@9681
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Jun 2013 13:28:44 +0000 (13:28 +0000)]
Remove unused NormalizeBench::fUsePortable field.
To address build warnings:
../bench/MathBench.cpp:442:10: error: private field 'fUsePortable' is not used
[-Werror,-Wunused-private-field]
bool fUsePortable;
^
R=reed@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
17463002
git-svn-id: http://skia.googlecode.com/svn/trunk@9677
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 19 Jun 2013 11:50:18 +0000 (11:50 +0000)]
Performance trigger rebaselines
git-svn-id: http://skia.googlecode.com/svn/trunk@9673
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 19 Jun 2013 11:41:02 +0000 (11:41 +0000)]
Make GrGLConfigConversionEffect work on Intel GPUs
BUG=247664
R=noel@chromium.org, bsalomon@chromium.org, reed@google.com, tomhudson@chromium.org, bsalomon@google.com
Author: jun.a.jiang@intel.com
Review URL: https://chromiumcodereview.appspot.com/
15719007
git-svn-id: http://skia.googlecode.com/svn/trunk@9672
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 19 Jun 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9671
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 18 Jun 2013 22:00:40 +0000 (22:00 +0000)]
Continue to contain podofo, shorter enums
Review URL: https://codereview.chromium.org/
17395005
git-svn-id: http://skia.googlecode.com/svn/trunk@9670
2bbb7eff-a529-9590-31e7-
b0007b416f81
zachr@google.com [Tue, 18 Jun 2013 21:23:31 +0000 (21:23 +0000)]
force linking inside of skdiff
Review URL: https://codereview.chromium.org/
16879012
git-svn-id: http://skia.googlecode.com/svn/trunk@9669
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Jun 2013 20:50:34 +0000 (20:50 +0000)]
Refactor: clean up some unused or mostly-unused API I saw here.
BUG=
R=bungeman@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
17414003
git-svn-id: http://skia.googlecode.com/svn/trunk@9668
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Jun 2013 20:20:55 +0000 (20:20 +0000)]
Rename SkDrawCommand subclasses
SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:
../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {
This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".
R=robertphillips@google.com, bungeman@google.com, djsollen@google.com
Author: fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
17101005
git-svn-id: http://skia.googlecode.com/svn/trunk@9667
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Jun 2013 20:06:36 +0000 (20:06 +0000)]
remove double including of libpng decoder
R=bungeman@google.com
Author: zachr@google.com
Review URL: https://chromiumcodereview.appspot.com/
17408002
git-svn-id: http://skia.googlecode.com/svn/trunk@9666
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Jun 2013 18:35:58 +0000 (18:35 +0000)]
Allow files, making ".skp files or directories are required." less of a lie.
BUG=
R=reed@google.com
Author: mtklein@google.com
Review URL: https://chromiumcodereview.appspot.com/
17151008
git-svn-id: http://skia.googlecode.com/svn/trunk@9665
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 18 Jun 2013 16:28:29 +0000 (16:28 +0000)]
put each generated pdf api class in a file (step 1, add new files)
Review URL: https://codereview.chromium.org/
17395005
git-svn-id: http://skia.googlecode.com/svn/trunk@9661
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 18 Jun 2013 15:37:27 +0000 (15:37 +0000)]
Smallest possible desktop application that uses Skia to render stuff.
Small Hello World smaple. Subclasses SkOSWindow.
R=caryclark@google.com
Author: sglez@google.com
Review URL: https://chromiumcodereview.appspot.com/
16337012
git-svn-id: http://skia.googlecode.com/svn/trunk@9657
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Tue, 18 Jun 2013 14:51:21 +0000 (14:51 +0000)]
add value() functions to podofo wrapers to isolate the client from knowing it is using podofo internally
Review URL: https://codereview.chromium.org/
17101011
git-svn-id: http://skia.googlecode.com/svn/trunk@9654
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Jun 2013 14:43:53 +0000 (14:43 +0000)]
Fuse skgr & gr targets in gyp files
https://codereview.chromium.org/
17101010/
git-svn-id: http://skia.googlecode.com/svn/trunk@9653
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Jun 2013 13:29:32 +0000 (13:29 +0000)]
Performance trigger rebaselines after hard reboot
(SkipBuildbotRuns)
git-svn-id: http://skia.googlecode.com/svn/trunk@9651
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 18 Jun 2013 07:00:52 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9648
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Tue, 18 Jun 2013 02:53:16 +0000 (02:53 +0000)]
skimage: revert r9642
git-svn-id: http://skia.googlecode.com/svn/trunk@9647
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 17 Jun 2013 23:36:45 +0000 (23:36 +0000)]
Pdfviewer: generate isAFoo() and getAsFoo() api for fields that can have multiple types.
Review URL: https://codereview.chromium.org/
16968007
git-svn-id: http://skia.googlecode.com/svn/trunk@9646
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 17 Jun 2013 21:06:22 +0000 (21:06 +0000)]
fix typo in spec
Review URL: https://codereview.chromium.org/
17124003
git-svn-id: http://skia.googlecode.com/svn/trunk@9644
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Mon, 17 Jun 2013 20:46:27 +0000 (20:46 +0000)]
few steps in the direction of to encapsulating podofo, so the client is not aware podofo is used.
Review URL: https://codereview.chromium.org/
17286007
git-svn-id: http://skia.googlecode.com/svn/trunk@9643
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 17 Jun 2013 19:34:58 +0000 (19:34 +0000)]
skimage: if --readPath points at an empty dir, create an empty expectations file
TBR=scroggo
Review URL: https://codereview.chromium.org/
17294006
git-svn-id: http://skia.googlecode.com/svn/trunk@9642
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 17 Jun 2013 15:39:43 +0000 (15:39 +0000)]
SkHello for NaCl
Not ready to submit.
R=reed@google.com
Review URL: https://codereview.chromium.org/
16904003
git-svn-id: http://skia.googlecode.com/svn/trunk@9639
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 17 Jun 2013 14:19:01 +0000 (14:19 +0000)]
*** Perlin noise GM needs to be rebaselined ***
Enabling Perlin Noise on Android
I enabled the Perlin Noise shader on Android after doing some minor modifications to the shader, specifically for Android (and #ifdefed for Android, to make sure none of this affects other platforms).
For Tegra devices (Nexus 7, Xoom), a precision issue related to the color values read from textures caused the noise to read the wrong indices and produce bad noise. I fixed this by adding a founding of the values read by simply doing the equivalent of "colorValue = floor(colorValue * 255.0) / 255.0" to make sure we retrieve the colors that were written in the texture originally.
For non-Tegra devices (Nexus 10), dealing with values in the order of 4096.0 was problematic without using the "highp" precision setting. To solve this, a few variables were given the high precision setting.
Since both fixes don't seem to do considerable harm to the platforms that are not being targetted, I left both fixes on all android devices for now.
I also reduced the Perlin noise gm so that it takes less time to test it on the Xoom (Original time was about 20 seconds, this shold take less than 10, hopefully)
BUG=
R=senorblanco@google.com, bsalomon@google.com, sugoi@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
16818013
git-svn-id: http://skia.googlecode.com/svn/trunk@9637
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 17 Jun 2013 14:10:36 +0000 (14:10 +0000)]
convert pathops to use SkSTArray where possible.
Replace SkTDArray with SkTArray and use SkSTArray when
the probable array size is known.
In a couple of places (spans, chases) the arrays are
constructed using insert() so SkTArrays can't be used for
now.
Also, add an optimization to cubic subdivide if either end
is zero or one.
BUG=
Review URL: https://codereview.chromium.org/
16951017
git-svn-id: http://skia.googlecode.com/svn/trunk@9635
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 17 Jun 2013 13:42:43 +0000 (13:42 +0000)]
use select() so we can wait for XEvents or our timer
poll for xevents using XPending
BUG=
Review URL: https://codereview.chromium.org/
17275003
git-svn-id: http://skia.googlecode.com/svn/trunk@9633
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 17 Jun 2013 04:43:05 +0000 (04:43 +0000)]
whitespace change to trigger buildbots after master restart
git-svn-id: http://skia.googlecode.com/svn/trunk@9632
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 15 Jun 2013 07:00:53 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@9631
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 14 Jun 2013 23:56:20 +0000 (23:56 +0000)]
whitespace change to trigger buildbots after skia-autogen reset
git-svn-id: http://skia.googlecode.com/svn/trunk@9630
2bbb7eff-a529-9590-31e7-
b0007b416f81