Enable additional build warnings on Unix (dotnet/core-setup#6071)

* Enable -Wall, -Wextra, -Weverything and -Werror on Unix

This enables *all* native code warnings on gcc/clang.

To avoid breaking the build, this commit also explicitly disables all
warnings that currently cause the build to fail.

* Remove -Wno-zero-as-null-pointer-constant

Fix all the code that was causing the warnings.

* Fix newline-eof warnings

* Fix 'deprecated' warnings

Use `noexcept` instead of `throw()`.

Use explicit copy-constructors where the compiler complains.

* Fix non-virtual-destructor warnings

Add a virtual destructor

* Fix extra-semi warnings

* Fix some sign-compare warnings

But leave sign-compare warnings disabled: some shared API essentially
forces some code do this comparison.

* Fix ignored-qualifiers warnings

It doesn't matter when functions that return value types use const or
not: value types are returned by copying and the caller can't mutate the
the version that the callee had. So remove those const flags.

* Fix undef warnings

Use defined() for preprocessor flags that can be undefined.

* Fix range-loop-analysis warnings

* Enable shorten-64-to-32 warnings

Previous commits have fixed all code that produced this warning.

* Fix used-but-marked-unused warnings

* Fix missing-braces warnings

* Disable vla-extension warnings

* Fix missing-variable-declarations warnings

Fix the warnings by explicitly declaring the global variables that are
only meant to be used locally in the file as static.

* Enable sign-conversion warnings

The code seems to have been fixed by previous commits.

* Fix old-style-cast warnings

* Fix unused-variable warnings

* Fix sign-compare warnings

* Fix documentation-unknown-command warnings

Clang thinks these comment blocks enclosed by /** and **/ are
doxygen-style comments. And doxygen doesn't know of a \Program tag. Use
\\ to "escape" a single slash and make doxygen/clang happy.

* Disable -Weverything

And remove various -Wno- flags that are not required anymore.

* Update global locations that comments refer to

The original locations are basically wrong.

* Fix bad cast in mockcoreclr.cpp

We should set the left hand value (a host_handle_t) to a right hand
value of the same type (a host_handle_t). Casting `0xdeadbeef` to a
host_handle_t* - only to assign it to a host_handle_t - does't make too
much sense.

Commit migrated from https://github.com/dotnet/core-setup/commit/0dd08fe1414c690d3243739f3be4cd35f84f7dde

Check for previously loaded hostfxr before loading in component hosts (dotnet/core-setup#6107)

Commit migrated from https://github.com/dotnet/core-setup/commit/a5b7fbb36794f6b778e66282a60a67f84711d701

Increase GUI test timeout and add more diagnostics. (dotnet/core-setup#6168)

* Increase GUI test timeout and add more diagnostics.

* Implement two timeout approach to detect hangs.

As suggested by @danmosemsft the waiting now succeeds if the window is detected in the specified timeout. If it is detected but it took longer than that (up to 3 * timeout), the test fails but notes that it did get the window. If it takes longer than 3 * timeout, the test just fails.

Commit migrated from https://github.com/dotnet/core-setup/commit/8cdebdfda7c8d22b5460fd2b9d7e30e372093d81

Generalize dotnet-runtime-deps Deb/RPM package dependencies (dotnet/core-setup#6070)

* Expand runtime-deps package applicability

On RPM package distros, depend on the libicu capability that a libicu## package provides.

On Debian package distros, use "or" dependencies that list all known versions of libicu and libssl.

This removes the need for some distro-specific packages.

* Collapse identical Deb packages into one

Commit migrated from https://github.com/dotnet/core-setup/commit/c98ab5cca3f5a7721581de057ba87cde3f30f69d

Fix build warnings in the coreclr mock. (dotnet/core-setup#6092)

Commit migrated from https://github.com/dotnet/core-setup/commit/34e7c67ad78ef5780d3e8c78757743f0181dfbc0

Remove ".Internal" from runtime packages (dotnet/core-setup#6096)

Commit migrated from https://github.com/dotnet/core-setup/commit/6a78e0fd349ef19a5a31380c37b39e62ad68fefa

Add trace flush to error writer propagation (dotnet/core-setup#6053)

* Add trace flush to error writer propagation

Removes small amount of code duplication. Makes sure that the behavior is consistent across all cross-module calls.

* Apply suggestions from code review

Co-Authored-By: vitek-karas <vitek.karas@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/948e3be562e8e964c0c1898b86d82cc2c901789f

Remove the --roll-forward-on-no-candidate-fx from command line help (dotnet/core-setup#6025)

* Remove the --roll-forward-on-no-candidate-fx from command line help. The setting is now deprecated so we don't want to show it in the command line help (it still works though).

* Rename a parameter to make it clearer what it's used for

Commit migrated from https://github.com/dotnet/core-setup/commit/04abec82b4cc52f6aec749acff25550c7ae76c83

 Produce mostly empty Microsoft.NETCore.App (dotnet/core-setup#5893)

* Produce mostly empty Microsoft.NETCore.App

Package is now empty with a platforms package dependency. Create Microsoft.NETCore.App.Insertion transport package for compatibility workarounds.

This commit also moves netcoreapp sfx generation to the new infrastructure to more easily handle the migration away from Microsoft.NETCore.App.

* Test workarounds for Msft.NETCore.App.Insertion

If tests use MNA, use MNAI.

* M.NETCore.App.Insertion => M.NETCore.App.Internal

It isn't just for insertion into core-sdk, we use it in core-setup too for now.

* Update dir.props: quote '/' and '\' in comment

Co-Authored-By: dagood <dagood@users.noreply.github.com>
* Comment on explicit .lib exclusion

Commit migrated from https://github.com/dotnet/core-setup/commit/0752a1798f8a089aa78796068a43b52ee1564aa5

Native hosting proposal (dotnet/core-setup#5336)

Design describing current level of support for hosting managed code from native applications and proposal for improvements in this area.

Commit migrated from https://github.com/dotnet/core-setup/commit/1a68a6c1b0b70bb5d0b06d7878ae728c1e3800d1

Fix FixLayoutPermissions ordering for AppHost +x (dotnet/core-setup#6003)

Make sure it runs for macOS installers, and run it before copying to the secondary layout for Deb/RPM.

Commit migrated from https://github.com/dotnet/core-setup/commit/ca333bca8f505b8d6e201017dc140866b121c5d8

Fix _jitPackageDir ref to include cross build jit (dotnet/core-setup#5987)

Commit migrated from https://github.com/dotnet/core-setup/commit/2db2f6b5fa34d517ccc3cbfda4c75abb814a2ca0

Merge pull request dotnet/core-setup#5983 from wtgodbe/p6

Update branding in master to preview6

Commit migrated from https://github.com/dotnet/core-setup/commit/ccc1bf52bb80869f7e84320f080de801d8d6a08f

Update branding in master to preview6

Commit migrated from https://github.com/dotnet/core-setup/commit/d7ca8cfc7c0eef2188e5a313501416e196f40711

Crossgen the WindowsDesktop shared framework using standardized crossgen infra (dotnet/core-setup#5942)

* Move crossgen to shared tooling, no changes

* Standardize crossgen, use on WindowsDesktop sfx

* Clarify System.Runtime.WindowsRuntime exclusion

Commit migrated from https://github.com/dotnet/core-setup/commit/f78b553ee37fbe18d4d3ba5972b74cfcc560d1aa

Apphost: Handle long paths while reading bundles (dotnet/core-setup#5948)

Handle path-lengths larger than 127 bytes in:
- Bundle ID (also a component of the extraction path)
- relative-path (path of a file within the bundle)

The above strings are encoded as length prefixed strings by System.IO.BinaryWriter.Write()
The length itself is encoded as a series of bytes where
  - 7-bits contain length bits
  - 8th bit indicates whether there are more bytes to follow.

For a path, there can be a maximum of two bytes (max 4096)
This commit handles the case where a path length is long enough to be need two bytes.

Also added a test case.

Fixes dotnet/core-setup#5932

Commit migrated from https://github.com/dotnet/core-setup/commit/9889b387cff5086f09ef174c5e73c278d3dba208

Roll forward (dotnet/core-setup#5691)

This is the new implementation of the framework resolution with the new roll forward setting.
The spec for this is [framework version resolution](https://github.com/dotnet/core-setup/blob/master/Documentation/design-docs/framework-version-resolution.md).

Major parts:
- introduce `rollForward` setting (CLI, env, config)
- convert the existing `rollForwardOnNoCandidateFx` to the new `rollForward` internally
- change framework reference compatibility algorithm to use the new `rollFoward` settings.
- basically rewrite the framework resolution algorithm with the new settings and fix an existing bug with incorrect retry logic
- add test infra for the new setting
- add tests for the new setting

Commit migrated from https://github.com/dotnet/core-setup/commit/ef496a091be8d8b43ab8c4ed3622ca89bce251cb

Create dotnet-runtime-deps for Ubuntu 19.04 (dotnet/core-setup#5897)

Commit migrated from https://github.com/dotnet/core-setup/commit/03e6fda1ab2ddb7317f735bc68cdd739f0865d9a

Update BuildTools to preview4-03917-01 (dotnet/core-setup#5895)

Commit migrated from https://github.com/dotnet/core-setup/commit/fa8587318445a7bc1dab753159c5d1c594afa5e9

Add AddMicrosoftNETCoreAppFrameworkMockCoreclr (dotnet/core-setup#5907)

* Add AddMicrosoftNETCoreAppFrameworkMockCoreclr

* Add MockCoreClrSanity test

* Add mockcoreclr.def

Commit migrated from https://github.com/dotnet/core-setup/commit/cedac19e41340258c97eccac7c3336110a73884c

Add mockcoreclr.def

Commit migrated from https://github.com/dotnet/core-setup/commit/df54a7e811c9c9faf6a03e3294f2114c89ba2c3c

Add MockCoreClrSanity test

Commit migrated from https://github.com/dotnet/core-setup/commit/1d3f5515e8ba9321ca091f25f442efd1897cb3e4

Add AddMicrosoftNETCoreAppFrameworkMockCoreclr

Commit migrated from https://github.com/dotnet/core-setup/commit/cd5d0985a659cfb86a239b49578450fc8adb15e6

Update hosting components with new hosts and new scenarios (dotnet/core-setup#5889)

* Update hosting components with new hosts and new scenarios

* Apply suggestions from code review

Co-Authored-By: vitek-karas <vitek.karas@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/17737d8b507401b28afef4b576e801f31b76a7e3

Fail early on duplicate runtime properties (dotnet/core-setup#5898)

Commit migrated from https://github.com/dotnet/core-setup/commit/859ee7d256a043b0a9bfe3e9cc6c8483eb23efd5

Add documentation for existing hostfxr functions (dotnet/core-setup#5904)

Commit migrated from https://github.com/dotnet/core-setup/commit/46210e5c170a5c4fd2aca61d5590c765955bdd03

Update readme: Ubuntu 19.04 and Linux musl arm64 (dotnet/core-setup#5899)

* Add Ubuntu 19.04 links

* Add Linux musl arm64 links

* Regenerate table

Commit migrated from https://github.com/dotnet/core-setup/commit/0270cfbcb197a5feb99078b99f34fa61c8951efb

Merge pull request dotnet/core-setup#5849 from dotnet/leecow-patch

Add execute perms to dotnet-wrapper for SDK Snap

Commit migrated from https://github.com/dotnet/core-setup/commit/ae2f9703a398e3dea1b9ea33910d39b64e9ec185

Add links to nethost zip/tar.gz to readme (dotnet/core-setup#5860)

Commit migrated from https://github.com/dotnet/core-setup/commit/810adb35cf1478f68c6a885adaef45925f012f45

Create AppHost pack nupkg and installers (dotnet/core-setup#5818)

* Create AppHost pack nupkg and installers

* Publish rid-specific AppHost packs

Commit migrated from https://github.com/dotnet/core-setup/commit/29db80e003d7160f20bd2b036ba16721c3ee66bc

Merge pull request dotnet/core-setup#5827 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools to preview4-03913-01 (master)

Commit migrated from https://github.com/dotnet/core-setup/commit/75239a14e63313457be9c723c99a0a67c6645e3b

Fix reorder warnings (dotnet/core-setup#5821)

Add compiler flags to fail any builds that produce that warning.

The member initialization list is always evaluated in the order the
members are delcared in the class, not the order in which they are
listed in the member initialization list. So modify the member
initialization lists to match the order in which they will be evaluated.

Commit migrated from https://github.com/dotnet/core-setup/commit/dcbb048073e3745df48e52d0619648f7aae8fa3d

Add basic native hosting test using comhost (dotnet/core-setup#5833)

* Test loads comhost and calls DllGetClassObject to activate
* Specify calling convention for COM activation delegate

Commit migrated from https://github.com/dotnet/core-setup/commit/48437b978361b7af9b37cdbecc290d4e058ee3fd

Add execute perms to dotnet-wrapper. Resolves https://github.com/dotnet/core-setup/issues/5790

Commit migrated from https://github.com/dotnet/core-setup/commit/875a48cef8683292f19a1b93916bd50345b9593c

AppHost: Support bundles (stage 1) (dotnet/core-setup#5742)

* AppHost: Support bundles (stage 1)

This changes implements the [app-host support](https://github.com/dotnet/designs/blob/master/accepted/single-file/design.md#the-host )
for executing .net core apps published as a single file.

This change implements [stage 1](https://github.com/dotnet/designs/blob/master/accepted/single-file/staging.mddotnet/core-setup#1-self-extractor),
which [extracts out](https://github.com/dotnet/designs/blob/master/accepted/single-file/extract.md ) the embedded files to disk.

On startup, the AppHost detects whether it's own binary is a .net core bundle.
If so, on the first run, the host extracts embedded files to:
  * if `DOTNET_BUNDLE_EXTRACT_BASE_DIR` is set, to `$DOTNET_BUNDLE_EXTRACT_BASE_DIR/.net/<app>/<id>/...` . Otherwise,
  * On Windows, to `%TEMP%/.net/<app>/<id>/...`
  * On Unix systems, if `$TMPDIR` is set, to `$TMPDIR/.net/<app>/<id>/...` . Otherwise to `/var/tmp` or `/tmp` if those paths are available and accessible.

On subsequent runs, the files extracted above are reused.

AppHost (X64) size increase:
Windows 5KB
Linux 11KB
Mac 6KB

Testing:
Tested the single-file extraction locally with several kinds of dotnet apps
(wpf, winforms, web, mvc, console, etc.)
Added a test case that runs a bundled apps with sub directories
Also fixed a bug in the Microsoft.NET.HostModel.extractor wrt processing bundled files in chunks.

Commit migrated from https://github.com/dotnet/core-setup/commit/4a01e55806b0849a08b820518e8cdcbeaaf07476

Move creating hostpolicy context and coreclr out of run functions (dotnet/core-setup#5775)

Commit migrated from https://github.com/dotnet/core-setup/commit/8e0590b0f1320ea455d125c2d75dc230109d8e43

Add Mock CoreCLR (dotnet/core-setup#5823)

* Add Mock CoreCLR

* Add MockLog* macros

* Use SHARED_API

Commit migrated from https://github.com/dotnet/core-setup/commit/6e994af6195ac90c9050a54c317a6623a729962e

Fix algorithm description with the order problem solution (dotnet/core-setup#5744)

Describe the ordering problem and how it is fixed in the new version.

Commit migrated from https://github.com/dotnet/core-setup/commit/09ee70255ebbce00bae4e4ff188241b42d001d89

Remove unused is_executable function in pal.unix.cpp (dotnet/core-setup#5814)

The function is declared as static. The only other function that called
it was removed in commit ad495acf.

Commit migrated from https://github.com/dotnet/core-setup/commit/cdcc62925ec47a2affb0249c6c6b8c14e3070430

Remove redundant std::move() (dotnet/core-setup#5824)

This is essentially a port of:
https://github.com/Microsoft/cpprestsdk/commit/dotnet/core-setup@f0637654fc0e6752d60f483138cbc8aef4ff0b75#diff-8e55486b33944293c131ee21fe87ff37

clang (and gcc, but I didn't test that) complains about std::move being
redundant because the compiler can already infer it.

Commit migrated from https://github.com/dotnet/core-setup/commit/ded9cda79f8c48f60c56596f8badd99feffd98a3

Update BuildTools to preview4-03913-01

Commit migrated from https://github.com/dotnet/core-setup/commit/5dbaf7f72c6eac5bd8c33d4562a91dc59abafef4

Create zip file for WindowsDesktop sfx (dotnet/core-setup#5816)

Commit migrated from https://github.com/dotnet/core-setup/commit/c80a9630e016c3517fe6dce784f7f344b744ba1b

Create WindowsDesktop shared framework nupkgs and MSIs (dotnet/core-setup#5741)

* Move packaging-tools out: unwanted dir.props

Move packaging-tools from src/pkg/projects/ to src/pkg/ so the shared framework project isn't interfered with by src/pkg/projects/dir.props. Changing the dir.props would be wasted effort because packaging-tools will have to move to become shared tooling in the future.

* WindowsDesktop shared framework, nupkg + msi

Commit migrated from https://github.com/dotnet/core-setup/commit/e1f47891f3fc715cbf73b599a5466ef8fce105ea

Build the Bundler as a library (dotnet/core-setup#5798)

* Build the Bundler as a library

Currently, the single-file bundler is
* Built as an app instead of a library
* Invoked from the SDK out-of-proc in order to enforce strict API boundaries

However, since the SDK implementation progressed, we've had to revisit the above decisions.

First, the bundler currently is implemented to take a folder vs a list of files to bundle.
* This causes unnecessary extra copies to the publish directory.
    * The files to be bundled need not be first copied to the publish directory.
    * Instead they can be written directly to the bundle.
* Stale items remaining in the publish directory may be written into the bundle unnecessarily.

Therefore, we decided that the bundler should take tuples of (source file-path, relative-path within bundle) instead of the publish folder as input.
* While it is possible to provide this input on the command-line/response file, it is convenient and more efficient to do it in-proc.
* Further, the SDK team agrees that the bundler is simple enough to run in-proc with the build system.

Therefore, the changes proposed are:
* Bundler will be built into a library Microsoft.NET.HostModel in core-setup repo (similar to DependencyModel)
    * It is not a task directly because we don't have to worry about multi-targeting
    * Other apphost related services like stamping the app.dll name into the apphost will be moded into this library
* A task in the SDK repo will consume this library through package reference (from myget)
    * (WIP) SDK changes: https://github.com/dotnet/sdk/compare/master...swaroop-sridhar:bundle-lib?expand=1

Commit migrated from https://github.com/dotnet/core-setup/commit/345061995531c6f8de00189842a27298d5d1a9b1

Update COM-activation.md (dotnet/core-setup#5805)

Update support matrix

Commit migrated from https://github.com/dotnet/core-setup/commit/727ed5ae59845fbca7d538ead2cecd0a82d8b2f5

Split getting init info for app/lib into separate helper function from executing runtime (dotnet/core-setup#5758)

* Split processing config for app/lib into separate function from
loading/executing runtime
* Pull hostpolicy resolving/loading out of fx_muxer.cpp

Commit migrated from https://github.com/dotnet/core-setup/commit/d221fe769b321d2f8d689fb0fd97243c5f77b7b0

Remove test duplicates (dotnet/core-setup#5729)

Adde some test variants to better covered what the removed tests covered.

Commit migrated from https://github.com/dotnet/core-setup/commit/fa51624c4e17fb9f46686c9c599cdedb3dbd1779

Tests for startup hook using simple name only (dotnet/core-setup#5597)

Also includes:
Update dependencies from https://github.com/dotnet/coreclr build 20190410.72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27610-72

Commit migrated from https://github.com/dotnet/core-setup/commit/0cc40ba37ae41be6f66128278df898c4f6ea0a85

Add missing closedir() in readdir() (dotnet/core-setup#5761)

The readdir function calls opendir() but never closedir(), leaking the
DIR resource.

Commit migrated from https://github.com/dotnet/core-setup/commit/ad2e0c415a04e47be4343cc1e956166bfd244632

Simplify nethost API for getting hostfxr path (dotnet/core-setup#5734)

- Remove nethost_ prefix on exported function
- Collapse buffer size / required size into one inout parameter

Commit migrated from https://github.com/dotnet/core-setup/commit/cb2db83f1ad2a4c8ca48a930c77656f29fca9a52

Fix copy/paste error (dotnet/core-setup#5756)

Commit migrated from https://github.com/dotnet/core-setup/commit/5d22ea8ecfdc05a35d621122d86e21bea1857177

Merge pull request dotnet/core-setup#5749 from jcagme/feedTaskUpgrade

Feed task upgrade

Commit migrated from https://github.com/dotnet/core-setup/commit/eb6224b99fb8c902882d64c37329a6dd3737a72f

Merge pull request dotnet/core-setup#5714 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools to preview4-03906-01 (master)

Commit migrated from https://github.com/dotnet/core-setup/commit/81d69a8ee3f6052e210de1428ed4d629cf318778

Upgrading feed taks version

Commit migrated from https://github.com/dotnet/core-setup/commit/bdf999f1e1e379ca8d1d2b3d33336b34228c0a71

Upgrading feed taks version

Commit migrated from https://github.com/dotnet/core-setup/commit/75aeeb3d91d77d5e66193f0bb4445785d24de0ab

Add hostpolicy_context which holds information to load/execute the runtime (dotnet/core-setup#5683)

Commit migrated from https://github.com/dotnet/core-setup/commit/59c193bd93deafba5926cb827872b80338aca7c0

Improve multi framework resolution tests (dotnet/core-setup#5690)

Roll forward tests with multiple frameworks
Fix a pre-release comparison in soft-roll-forward

Commit migrated from https://github.com/dotnet/core-setup/commit/8371c289a2adcfc3a3fd1c8784e02bb197a94011

Update BuildTools to preview4-03906-01

Commit migrated from https://github.com/dotnet/core-setup/commit/24633ddc9023b866d0671dba55d2f98b6e71de3c

Roll forward for pre release edge cases (dotnet/core-setup#5635)

* Describe proposed behavioral changes for pre-release roll forward
* More tests to validate existing pre-release behavior

Commit migrated from https://github.com/dotnet/core-setup/commit/e33913f3bb45def8f588dc586178e9f09cc49cc6

Merge pull request dotnet/core-setup#5705 from JohnTortugo/SetupBatchBuild

Setup batch build

Commit migrated from https://github.com/dotnet/core-setup/commit/4e9a9f2118182df123f5ffa874f41462e1dad0b7

Fix syntax

Commit migrated from https://github.com/dotnet/core-setup/commit/0d63f0bfa51854ba64869499b8b54256861eb635

Batch core-setup builds

Commit migrated from https://github.com/dotnet/core-setup/commit/8058bab5f1e71877944ab6ec4e049e99057eec9f

.NET Core WinRT Host (dotnet/core-setup#5527)

Implement a WinRT host for .NET Core so users can write WinRT WinMDs that target and build on .NET Core.

We can't accurately test this E2E in CI until we have a test machine running a version of Windows with the Reg-Free WinRT support (requires at least Windows 10 19H1 Build 18309).

Runtime side of the host work is in dotnet/coreclrdotnet/core-setup#23402

Commit migrated from https://github.com/dotnet/core-setup/commit/4ed031a6a01352696bd7fdd58bddc365d34e91bf

Add doc with hostpolicy APIs (dotnet/core-setup#5659)

* Add doc listing existing hostpolicy APIs
* Add proposed new hostpolicy exports

Commit migrated from https://github.com/dotnet/core-setup/commit/4be876975d0e475ee78a2105f458b54952154df7

Merge pull request dotnet/core-setup#5697 from wtgodbe/preview5

Update branding to preview5

Commit migrated from https://github.com/dotnet/core-setup/commit/1043445a8182f725ba60e0745d0b534f8b800564

Update branding to preview5

Commit migrated from https://github.com/dotnet/core-setup/commit/f3836495eeb3a6a9d8ac64eb736979c1adbc4668

Enforce that DLL/EXEs in platform manifest have a FileVersion (dotnet/core-setup#5682)

* Enforce DLL/EXEs in platform manifest have version

* Allow zero/missing versions on non-Windows

Commit migrated from https://github.com/dotnet/core-setup/commit/851859e9e07eda7adb2dcf129b0d6fb3cab411e3

Merge pull request dotnet/core-setup#5521 from dotnet/leecow-patch

Refresh snap definitions

Commit migrated from https://github.com/dotnet/core-setup/commit/7c5ad7177d42e70641677bd039f5d4e889832e0b

Merge branch 'leecow-patch' of https://github.com/dotnet/core-setup into leecow-patch

Commit migrated from https://github.com/dotnet/core-setup/commit/cb3880facef1da9a651a946e4208443d994b9fcf

formatting fix

Commit migrated from https://github.com/dotnet/core-setup/commit/092c10eef41e463f12c15f08d48ffa40f9b4e72a

Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/5de68d7b75d9d31560fc605c6f1e44be8dd293b9

Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/58952bae556822efccef5d3e39611065b8b71f1b

Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/007b7f86ad2ee473ac69a61d561f3ca7e765f149

Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/8388f46ddc2eff94b17139a18adbe9585453803c

Add ijwhost.lib to host package. (dotnet/core-setup#5650)

I forgot to include the `ijwhost.lib` exports lib in the Microsoft.NETCore.DotNetAppHost package. C++/CLI will need this in the package for aquisition via NuGet.

Commit migrated from https://github.com/dotnet/core-setup/commit/482c74beffd6206694004fbd539ecede6dcab4b1

Add <functional> include to coreclr.h (dotnet/core-setup#5664)

Commit migrated from https://github.com/dotnet/core-setup/commit/80622592a4e993200cb5b495b802abc1ee2fe96d

Bundler: Add test case for handling relative-path input (dotnet/core-setup#5653)

Run the bundle-extract test where inputs are specified as:
 - Absolute paths
 - Relative paths terminated by directory separator
 - Relative paths not terminated by directory separator

Commit migrated from https://github.com/dotnet/core-setup/commit/d29ad01cb118f0750a517360757755b8be1d4097

Bundler: Fix path handling

This commit has two changes:
* Allow relative paths to be used for source directory. (dotnet/core-setup#5594)
* Fix a typo.

Commit migrated from https://github.com/dotnet/core-setup/commit/3f3c14ebcb95b5f83cdf8afd9d5083a6e7dbdb2c

Make coreclr_property_bag_t handle lifetime of property strings (dotnet/core-setup#5638)

* Make coreclr_property_bag_t handle lifetime of property strings
* Basic test for runtime config properties

Commit migrated from https://github.com/dotnet/core-setup/commit/ba5b51b74e7b4a39551f4f47eaa2b0a9bc0b439a

Rename nethost zip/tar.gz to be consistent with runtime compressed files (dotnet/core-setup#5639)

Commit migrated from https://github.com/dotnet/core-setup/commit/158cab126cb58c21bcee8385b2c6e46c3e3501ff

Move files only used for hostpolicy under hostpolicy subdirectory (dotnet/core-setup#5629)

Commit migrated from https://github.com/dotnet/core-setup/commit/4ea0233e38681384ee91d7a72c011db9c02e35ff

Update BuildTools to preview4-03828-01 (dotnet/core-setup#5584)

Commit migrated from https://github.com/dotnet/core-setup/commit/8db9f804ff77ff866ff203cff6ea0791e895045e

Disable multi-level lookup for the test solution (dotnet/core-setup#5598)

Commit migrated from https://github.com/dotnet/core-setup/commit/b699f32549d72d41d950841a07a1d76c8d508429

Refactor FX resolution into its own class (dotnet/core-setup#5582)

fx_muxer is a collection of muxer functionality, framework resolution and command line parsing.
This change moves the framework resolution out into its own fx_resolver.

In the fx_resolver, made some of the methods "this" methods so that they don't have to pass the framework maps in arguments.

No functional changes, just moving code around.

Commit migrated from https://github.com/dotnet/core-setup/commit/20f2752ccd2fdbb285a77d66306e5ad2cdb81f07

Remove coreclr shutdown from coreclr_t destructor. (dotnet/core-setup#5612)

Commit migrated from https://github.com/dotnet/core-setup/commit/d18247239a28e4ec353f92bedf2dde153a8068ea

Add zip/tar.gz for nethost (dotnet/core-setup#5603)

Commit migrated from https://github.com/dotnet/core-setup/commit/6d0c29c1870efd6a041f9d599723f462c0d74b0e

Use BYOC pools: '*-temp' pools being deleted (dotnet/core-setup#5591)

Add chown workaround for a new way that 'root' file ownership can break the build in the new pools.

Commit migrated from https://github.com/dotnet/core-setup/commit/8f45c48aca40aaa007288faf495ee425397e401c

Rename Microsoft.Dotnet.Build.Bundle to Microsoft.NET.Build.Bundle (dotnet/core-setup#5581)

Rename the Bundler package to match other tools in the toolset repository.

Commit migrated from https://github.com/dotnet/core-setup/commit/3460b19cf6ade03882e7b168a3295f959074d7c6

Omit trailing path separator in TPA (dotnet/core-setup#5575)

In 2.* the trailing separator was removed by the runtime. After refactorings in the runtime it's no longer the case. This is technically a breaking change since in 2.* the `AppDomain.GetData("TRUSTED_PLATFORM_ASSEMBLIES")` returns string which doesn't have trailing path separator. In 3.0 it has.

It's cleaner to fix this in `hostpolicy` because there's no reason for runtime to "tweak" runtime property values before they are reported via `GetData`. TPA is not special in any way either. The trailing path separator serves no purpose anyway, so it's perfectly fine to remove it. And there's no reason to keep the change from 2.* in the codebase.

Commit migrated from https://github.com/dotnet/core-setup/commit/eb3f9526c14fab300247c9caaf1506141d89ec64

Test on Windows x86 (dotnet/core-setup#5583)

Commit migrated from https://github.com/dotnet/core-setup/commit/a000c54cc800b326bd45fb54b7caeb91a7ca59c6

Fix GetHostFxrPath_DotNetRootEnvironment test failure on x86 (dotnet/core-setup#5571)

Commit migrated from https://github.com/dotnet/core-setup/commit/0b6c947fcd15ab7105a4eef0f50f7dff280c557a

Bundler Test: Run using AppHost (dotnet/core-setup#5574)

The bundler test runs a self-contained-published test app twice:
once before and once after bundling.

The initial run (to sanity check the project) was done using
the dotnet host obtained from the SDK. However, the SDK dotnet seems
to be a X64 binary, which failed to run the test-app published for x86.
https://dev.azure.com/dnceng/public/_build/results?buildId=134281&view=logs

This change fixes the problem by invoking both runs using the published AppHost.

Commit migrated from https://github.com/dotnet/core-setup/commit/e9bd1539c2fb2d0d5c1aff2ea05d6f095ad5e913

FX resolution small cleanup (dotnet/core-setup#5544)

* Renames and add comments to roll-forward functions
* Refactor to remove code duplication

Commit migrated from https://github.com/dotnet/core-setup/commit/06c7660c571cc02a1f276c7b992ff225e4ec5903

Rename test only env variables (dotnet/core-setup#5548)

The globally registered location applies to everything, not just SDK, so remove the SDK from the env variable names. Also rename to better match product intent.

Modify tests to use constatns for the test only env variables.
Add couple tests to framework resolution around multiple hive resolution.

Commit migrated from https://github.com/dotnet/core-setup/commit/f35738641da91c46be5a50b8d9da0718228cb212

Add framework resolution tests for --fx-version (dotnet/core-setup#5545)

Commit migrated from https://github.com/dotnet/core-setup/commit/fef74d39b1bb08aefd0930f6c7866ddb3150d75b

Switch SDKLookup tests to use mock hostpolicy (dotnet/core-setup#5563)

These are just testing discovery of the SDK locations, and do not need
an actual app or the SDK to run.

Commit migrated from https://github.com/dotnet/core-setup/commit/adb65e24465fa2d37f4c062f9598e082c8df6f39

Run tests on Windows jobs using '-test' alias (dotnet/core-setup#5570)

Commit migrated from https://github.com/dotnet/core-setup/commit/e030161415a0ca857a2b5cb7fffeade0ebb26a70

Add alias for build option to just build/run tests (dotnet/core-setup#5564)

Commit migrated from https://github.com/dotnet/core-setup/commit/feb4180dcc6a5c9dc3ca5810e02c15a377277db8

Expose function for locating hostfxr (dotnet/core-setup#5522)

* Add nethost library and implement nethost_get_hostfxr_path
* Add basic tests for nethost_get_hostfxr_path

Commit migrated from https://github.com/dotnet/core-setup/commit/6001915623d99527f5af3252b9d19694935ae4a8

Package Microsoft.DotNet.Build.Bundle as a tool (dotnet/core-setup#5555)

Package Microsoft.DotNet.Build.Bundle as a tool similar to ILLink.Tasks
so that it can be consumed by the ToolSet repo.
(https://github.com/dotnet/toolset/pull/541)

Packaging the bundler as a lib causes version compatibility check failures.

Commit migrated from https://github.com/dotnet/core-setup/commit/142a83f6580b3e409e7a2de4ff7a3b27807474bd