platform/upstream/libSkiaSharp.git
11 years agoRefactor SkImageFilter into its own .cpp file.
senorblanco@chromium.org [Mon, 20 Aug 2012 15:43:14 +0000 (15:43 +0000)]
Refactor SkImageFilter into its own .cpp file.

Review URL:  https://codereview.appspot.com/6465073/

git-svn-id: http://skia.googlecode.com/svn/trunk@5188 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoflush() and glFinish() are now in the timed area of rendering.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:15 +0000 (15:04 +0000)]
flush() and glFinish() are now in the timed area of rendering.

git-svn-id: http://skia.googlecode.com/svn/trunk@5187 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed up SK_SUPPORT_GPU flags.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:12 +0000 (15:04 +0000)]
Fixed up SK_SUPPORT_GPU flags.

git-svn-id: http://skia.googlecode.com/svn/trunk@5186 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDeleted timer for record and unflatten benchmarks.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:09 +0000 (15:04 +0000)]
Deleted timer for record and unflatten benchmarks.

git-svn-id: http://skia.googlecode.com/svn/trunk@5185 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded some assertions.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:07 +0000 (15:04 +0000)]
Added some assertions.

git-svn-id: http://skia.googlecode.com/svn/trunk@5184 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded the option to enable GPU rendering on render_ and bench_pictures.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:04 +0000 (15:04 +0000)]
Added the option to enable GPU rendering on render_ and bench_pictures.

git-svn-id: http://skia.googlecode.com/svn/trunk@5183 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove fBitmap delete. Tile bitmaps are no longer kept around.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:02 +0000 (15:04 +0000)]
Remove fBitmap delete. Tile bitmaps are no longer kept around.

git-svn-id: http://skia.googlecode.com/svn/trunk@5182 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe tiles are properly reset.
keyar@chromium.org [Mon, 20 Aug 2012 15:04:00 +0000 (15:04 +0000)]
The tiles are properly reset.

git-svn-id: http://skia.googlecode.com/svn/trunk@5181 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTiledPictureRenderer now has tiles accelerated when appropiate.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:57 +0000 (15:03 +0000)]
TiledPictureRenderer now has tiles accelerated when appropiate.

git-svn-id: http://skia.googlecode.com/svn/trunk@5180 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanged new and delete to SkNEW* and SkDELETE as appropriate.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:54 +0000 (15:03 +0000)]
Changed new and delete to SkNEW* and SkDELETE as appropriate.

git-svn-id: http://skia.googlecode.com/svn/trunk@5179 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoresetState is called between every benchmark run.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:52 +0000 (15:03 +0000)]
resetState is called between every benchmark run.

git-svn-id: http://skia.googlecode.com/svn/trunk@5178 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoState reset and gpu timers added.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:47 +0000 (15:03 +0000)]
State reset and gpu timers added.

git-svn-id: http://skia.googlecode.com/svn/trunk@5177 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanged to Yoda style comparisons where appropriate.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:44 +0000 (15:03 +0000)]
Changed to Yoda style comparisons where appropriate.

git-svn-id: http://skia.googlecode.com/svn/trunk@5176 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHave GPU based approach workingish.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:41 +0000 (15:03 +0000)]
Have GPU based approach workingish.

Benchmarks do not work and it is always on.

git-svn-id: http://skia.googlecode.com/svn/trunk@5175 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanged the gyp file to handle dpendencies via exports.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:38 +0000 (15:03 +0000)]
Changed the gyp file to handle dpendencies via exports.

git-svn-id: http://skia.googlecode.com/svn/trunk@5174 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor whitespace change.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:36 +0000 (15:03 +0000)]
Minor whitespace change.

git-svn-id: http://skia.googlecode.com/svn/trunk@5173 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe GrContext and the GrFactoryContext are now kept around.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:33 +0000 (15:03 +0000)]
The GrContext and the GrFactoryContext are now kept around.

git-svn-id: http://skia.googlecode.com/svn/trunk@5172 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDirty commit so Brian can see changes.
keyar@chromium.org [Mon, 20 Aug 2012 15:03:29 +0000 (15:03 +0000)]
Dirty commit so Brian can see changes.

git-svn-id: http://skia.googlecode.com/svn/trunk@5171 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplements a new class, SkSingleInputImageFilter, to handle DAG connectivity
senorblanco@chromium.org [Mon, 20 Aug 2012 14:53:21 +0000 (14:53 +0000)]
Implements a new class, SkSingleInputImageFilter, to handle DAG connectivity
for filters with a single image input.  This provides functionality to store,
flatten and unflatten a single SkImageFilter input, as well as to recursively
evaluate it on the CPU or GPU.  The following classes were re-parented to
implement DAG connectivity:  SkBlurImageFilter, SkDilateImageFilter,
SkErodeImageFilter, SkColorFilterImageFilter.  The constructors for each
have been appended with a new parameter, representing the input filter
(default NULL).

This change also implements an arbitrary SkBitmap input source for filtering,
SkBitmapSource.

NOTE:  This CL will require gyp file changes when rolling past this revision.

Review URL:  https://codereview.appspot.com/6462071/

git-svn-id: http://skia.googlecode.com/svn/trunk@5170 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoStop refcounting SkDeferredCanvas::NotificationClient
junov@chromium.org [Mon, 20 Aug 2012 14:25:04 +0000 (14:25 +0000)]
Stop refcounting SkDeferredCanvas::NotificationClient

User code (i.e. WebKit) is now responsible for the lifetime scope of the notification client.
With http://trac.webkit.org/changeset/125804 skia-side ref counting has become unnecessary and undesirable.
Review URL: https://codereview.appspot.com/6443146

git-svn-id: http://skia.googlecode.com/svn/trunk@5169 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet LF property on a bunch of files.
bsalomon@google.com [Mon, 20 Aug 2012 13:55:09 +0000 (13:55 +0000)]
Set LF property on a bunch of files.

Review URL: http://codereview.appspot.com/6461094/

git-svn-id: http://skia.googlecode.com/svn/trunk@5168 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline images from r5136 and Ubuntu driver change.
bsalomon@google.com [Mon, 20 Aug 2012 13:31:47 +0000 (13:31 +0000)]
Rebaseline images from r5136 and Ubuntu driver change.
The following images were deleted:
base-macmini/imagefiltersbase_msaa16.png (garbage, issue 791)
base-macmini-lion-float/imagefiltersbase_msaa16.png (garbage, issue 791)
base-shuttle_ubuntu12_ati5770/imagefiltersbase_gpu.png (hairlines became thick, due to driver change, isseu 795 filed)

git-svn-id: http://skia.googlecode.com/svn/trunk@5167 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 20 Aug 2012 12:43:57 +0000 (12:43 +0000)]
shape ops work in progress
major milestone: 35.8M tests pass
(all rect/triangle/quadralateral)

git-svn-id: http://skia.googlecode.com/svn/trunk@5166 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadds -i flag to ignore a timer for bench plots.
bensong@google.com [Fri, 17 Aug 2012 21:42:14 +0000 (21:42 +0000)]
adds -i flag to ignore a timer for bench plots.

git-svn-id: http://skia.googlecode.com/svn/trunk@5163 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 5156
reed@google.com [Fri, 17 Aug 2012 21:13:17 +0000 (21:13 +0000)]
revert 5156

git-svn-id: http://skia.googlecode.com/svn/trunk@5160 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 5157
reed@google.com [Fri, 17 Aug 2012 21:10:44 +0000 (21:10 +0000)]
revert 5157

git-svn-id: http://skia.googlecode.com/svn/trunk@5159 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd long/unsigned-long variations to the debug SkIntToScalar, as the mac compiler
reed@google.com [Fri, 17 Aug 2012 20:53:48 +0000 (20:53 +0000)]
add long/unsigned-long variations to the debug SkIntToScalar, as the mac compiler
makes a distinction between int and long (it appears)

git-svn-id: http://skia.googlecode.com/svn/trunk@5157 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix SkIntToScalar signature for 64-bit build
borenet@google.com [Fri, 17 Aug 2012 20:32:29 +0000 (20:32 +0000)]
Fix SkIntToScalar signature for 64-bit build
Review URL: https://codereview.appspot.com/6443147

git-svn-id: http://skia.googlecode.com/svn/trunk@5156 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDeleted 3 flaky GM baselines
robertphillips@google.com [Fri, 17 Aug 2012 18:37:22 +0000 (18:37 +0000)]
Deleted 3 flaky GM baselines

gm/base-android-nexus-s/giantbitmap_mirror_bilerp_rotate_gpu.png
gm/base-android-nexus-s/giantbitmap_repeat_bilerp_rotate_gpu.png
gm/base-macmini-lion-float/drawbitmaprect_msaa16.png

git-svn-id: http://skia.googlecode.com/svn/trunk@5154 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleaning up deprecated API in SkDeferredCanvas
junov@chromium.org [Fri, 17 Aug 2012 14:50:16 +0000 (14:50 +0000)]
Cleaning up deprecated API in SkDeferredCanvas
Review URL: https://codereview.appspot.com/6461077

git-svn-id: http://skia.googlecode.com/svn/trunk@5152 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDecrease SkClipStack memory allocations & deallocations
robertphillips@google.com [Fri, 17 Aug 2012 14:25:43 +0000 (14:25 +0000)]
Decrease SkClipStack memory allocations & deallocations

http://codereview.appspot.com/6443138

git-svn-id: http://skia.googlecode.com/svn/trunk@5151 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unnecessary GrContext flushes
bsalomon@google.com [Fri, 17 Aug 2012 14:06:49 +0000 (14:06 +0000)]
Remove unnecessary GrContext flushes

Review URL: http://codereview.appspot.com/6446150/

git-svn-id: http://skia.googlecode.com/svn/trunk@5150 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkDeque::back faster & inline
robertphillips@google.com [Fri, 17 Aug 2012 13:53:05 +0000 (13:53 +0000)]
Make SkDeque::back faster & inline

http://codereview.appspot.com/6462073/

git-svn-id: http://skia.googlecode.com/svn/trunk@5149 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix clear records in IODB
bsalomon@google.com [Fri, 17 Aug 2012 13:43:08 +0000 (13:43 +0000)]
Fix clear records in IODB

Review URL: http://codereview.appspot.com/6465061/

git-svn-id: http://skia.googlecode.com/svn/trunk@5148 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModify Read/WritePixelTests to print one pixel failure for each test case rather...
bsalomon@google.com [Fri, 17 Aug 2012 13:32:06 +0000 (13:32 +0000)]
Modify Read/WritePixelTests to print one pixel failure for each test case rather than every pixel

Review URL: http://codereview.appspot.com/6450154/

git-svn-id: http://skia.googlecode.com/svn/trunk@5147 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove tiling up into SampleWindow.
scroggo@google.com [Fri, 17 Aug 2012 13:29:50 +0000 (13:29 +0000)]
Move tiling up into SampleWindow.

Now the tiles do not move with the view, and tiling persists when changing slides.

Review URL: https://codereview.appspot.com/6450143

git-svn-id: http://skia.googlecode.com/svn/trunk@5146 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger linux bot with proprietary ATI driver newly installed.
bsalomon@google.com [Fri, 17 Aug 2012 13:17:40 +0000 (13:17 +0000)]
Whitespace change to trigger linux bot with proprietary ATI driver newly installed.

git-svn-id: http://skia.googlecode.com/svn/trunk@5144 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded Serialization of SkPath's bound
robertphillips@google.com [Fri, 17 Aug 2012 10:58:49 +0000 (10:58 +0000)]
Added Serialization of SkPath's bound

http://codereview.appspot.com/6458143/

git-svn-id: http://skia.googlecode.com/svn/trunk@5143 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore rebaselines from r5136
bsalomon@google.com [Thu, 16 Aug 2012 21:56:48 +0000 (21:56 +0000)]
More rebaselines from r5136

git-svn-id: http://skia.googlecode.com/svn/trunk@5142 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove EdgeType enum. Unimportant distinction, and removing speeds up quickReject
reed@google.com [Thu, 16 Aug 2012 20:53:31 +0000 (20:53 +0000)]
remove EdgeType enum. Unimportant distinction, and removing speeds up quickReject
Review URL: https://codereview.appspot.com/6448161

git-svn-id: http://skia.googlecode.com/svn/trunk@5140 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocleaned up algorithm codes and added 25th percentile for representation.
bensong@google.com [Thu, 16 Aug 2012 20:49:28 +0000 (20:49 +0000)]
cleaned up algorithm codes and added 25th percentile for representation.

git-svn-id: http://skia.googlecode.com/svn/trunk@5139 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline gm due to r5136
bsalomon@google.com [Thu, 16 Aug 2012 20:42:40 +0000 (20:42 +0000)]
Rebaseline gm due to r5136

git-svn-id: http://skia.googlecode.com/svn/trunk@5138 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a memory leak in SkBitmapHeap.
scroggo [Thu, 16 Aug 2012 20:30:18 +0000 (20:30 +0000)]
Fix a memory leak in SkBitmapHeap.

When I switched fLookupTable to be an array of pointers, I did not
delete those pointers when I was done with them. Do it now.

Also modify SkTDArray::deleteAll to call SkDELETE instead of delete.

Review URL: https://codereview.appspot.com/6453129

git-svn-id: http://skia.googlecode.com/svn/trunk@5137 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake all GrContext draws go through the draw buffer.
bsalomon@google.com [Thu, 16 Aug 2012 18:36:06 +0000 (18:36 +0000)]
Make all GrContext draws go through the draw buffer.

Review URL: http://codereview.appspot.com/6462069/

git-svn-id: http://skia.googlecode.com/svn/trunk@5136 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SK_ENABLE_CLIP_QUICKREJECT option (currently disabled)
reed@google.com [Thu, 16 Aug 2012 18:27:05 +0000 (18:27 +0000)]
add SK_ENABLE_CLIP_QUICKREJECT option (currently disabled)

git-svn-id: http://skia.googlecode.com/svn/trunk@5135 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a parenthesis bug.
scroggo@google.com [Thu, 16 Aug 2012 17:56:49 +0000 (17:56 +0000)]
Fix a parenthesis bug.

SkGPipeCanvas::needOpBytes was being called with the wrong value due to a misplaced
parens in clipRect and clipPath. This can cause a crash if clip is called at just
the right (wrong) time. Instead of writing a boolean to the stream, I have added a
flag, which helps to avoid the parens problem.

Also renamed some flags from _DrawOpsFlag to _DrawOpFlag for consistency.

Lastly, added an assert that the size provided by the SkGPipeController is a multiple
of four.

Review URL: https://codereview.appspot.com/6453126

git-svn-id: http://skia.googlecode.com/svn/trunk@5134 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SK_FONTHOST_WIN_DW define.
bungeman@google.com [Thu, 16 Aug 2012 17:35:58 +0000 (17:35 +0000)]
Remove SK_FONTHOST_WIN_DW define.

git-svn-id: http://skia.googlecode.com/svn/trunk@5132 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agowe have no subclasses, so change protected to private.
reed@google.com [Thu, 16 Aug 2012 16:46:27 +0000 (16:46 +0000)]
we have no subclasses, so change protected to private.

git-svn-id: http://skia.googlecode.com/svn/trunk@5131 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix assertion in in order draw buffer
bsalomon@google.com [Thu, 16 Aug 2012 16:26:33 +0000 (16:26 +0000)]
Fix assertion in in order draw buffer

Review URL: http://codereview.appspot.com/6460095/

git-svn-id: http://skia.googlecode.com/svn/trunk@5130 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't try to build SkFontHost_win_dw.cpp on non-Windows platforms.
bungeman@google.com [Thu, 16 Aug 2012 16:23:09 +0000 (16:23 +0000)]
Don't try to build SkFontHost_win_dw.cpp on non-Windows platforms.

git-svn-id: http://skia.googlecode.com/svn/trunk@5129 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDirectWrite font host for skia.
bungeman@google.com [Thu, 16 Aug 2012 16:13:40 +0000 (16:13 +0000)]
DirectWrite font host for skia.
https://codereview.appspot.com/5417063/

git-svn-id: http://skia.googlecode.com/svn/trunk@5128 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkClipStack::clipEmpty() as an optimized way to say clipDevRect(empty, intersect)
reed@google.com [Thu, 16 Aug 2012 15:59:59 +0000 (15:59 +0000)]
add SkClipStack::clipEmpty() as an optimized way to say clipDevRect(empty, intersect)
if the caller knows up-front that it wants the clipstact to become empty.
Review URL: https://codereview.appspot.com/6443132

git-svn-id: http://skia.googlecode.com/svn/trunk@5127 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix overrun in aa rect renderer
bsalomon@google.com [Thu, 16 Aug 2012 15:28:54 +0000 (15:28 +0000)]
Fix overrun in aa rect renderer

Review URL: http://codereview.appspot.com/6446146/

git-svn-id: http://skia.googlecode.com/svn/trunk@5126 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix uninitialized color filter data on GrPaint
bsalomon@google.com [Thu, 16 Aug 2012 15:06:57 +0000 (15:06 +0000)]
Fix uninitialized color filter data on GrPaint

Review URL: http://codereview.appspot.com/6443135/

git-svn-id: http://skia.googlecode.com/svn/trunk@5125 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCompilation fix for r5123 (disabling template inst count tracking)
robertphillips@google.com [Thu, 16 Aug 2012 15:04:34 +0000 (15:04 +0000)]
Compilation fix for r5123 (disabling template inst count tracking)

git-svn-id: http://skia.googlecode.com/svn/trunk@5124 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExtended Inst counting to find "unknown" leaked object (SkTMaskGamma)
robertphillips@google.com [Thu, 16 Aug 2012 14:58:06 +0000 (14:58 +0000)]
Extended Inst counting to find "unknown" leaked object (SkTMaskGamma)

http://codereview.appspot.com/6453127/

git-svn-id: http://skia.googlecode.com/svn/trunk@5123 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplaced TextureCacheEntry with GrTexture* and a back pointer to GrResourceEntry...
robertphillips@google.com [Thu, 16 Aug 2012 14:49:16 +0000 (14:49 +0000)]
Replaced TextureCacheEntry with GrTexture* and a back pointer to GrResourceEntry (in GrTexture)

http://codereview.appspot.com/6460089/

git-svn-id: http://skia.googlecode.com/svn/trunk@5122 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoskdiff: recurse over subdirectories, unless --norecurse option is given
epoger@google.com [Thu, 16 Aug 2012 13:42:13 +0000 (13:42 +0000)]
skdiff: recurse over subdirectories, unless --norecurse option is given
in anticipation of https://code.google.com/p/skia/issues/detail?id=743 ('move gm baselines outside of trunk, and modify naming convention')
Review URL: https://codereview.appspot.com/6465053

git-svn-id: http://skia.googlecode.com/svn/trunk@5121 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange tiling to 16 tiles instead of 4
reed@google.com [Wed, 15 Aug 2012 20:44:36 +0000 (20:44 +0000)]
change tiling to 16 tiles instead of 4

git-svn-id: http://skia.googlecode.com/svn/trunk@5120 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoProvide a key to go to the previous slide in SampleApp.
scroggo@google.com [Wed, 15 Aug 2012 20:03:06 +0000 (20:03 +0000)]
Provide a key to go to the previous slide in SampleApp.

The left key now mirrors the right key, and goes to the previous slide.
It used to change the device type, which can still be done by pressing
'd' or using the menu.

Review URL: https://codereview.appspot.com/6443133

git-svn-id: http://skia.googlecode.com/svn/trunk@5119 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing a deferred canvas optimization that purges pending draws when the canvas is...
junov@chromium.org [Wed, 15 Aug 2012 19:49:22 +0000 (19:49 +0000)]
Fixing a deferred canvas optimization that purges pending draws when the canvas is cleared

It appears that the recording canvas returns a save count of 1 when the save stack is empty.
In order to pass Canvas unit tests when a clear occurs, changes to SkGPipe were necessary
to allow SkDeferredCanvas to set the device bounds on the SkGPipeCanvas.  A positive
side effect of this change is that graphics primitives that fall outside of the device
bounds will now always be culled at the recording stage (as opposed playback).

BUG=http://code.google.com/p/skia/issues/detail?id=782
TEST=deferred_canvas_record bench test
Review URL: https://codereview.appspot.com/6454157

git-svn-id: http://skia.googlecode.com/svn/trunk@5117 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkCanvas::concat instead of SkCanvas::setMatrix so this GM can be tiled.
scroggo@google.com [Wed, 15 Aug 2012 18:42:45 +0000 (18:42 +0000)]
Use SkCanvas::concat instead of SkCanvas::setMatrix so this GM can be tiled.

Review URL: https://codereview.appspot.com/6460091

git-svn-id: http://skia.googlecode.com/svn/trunk@5116 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadded representation to xhtml title.
bensong@google.com [Wed, 15 Aug 2012 18:27:38 +0000 (18:27 +0000)]
added representation to xhtml title.

git-svn-id: http://skia.googlecode.com/svn/trunk@5115 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofixes elif bug.
bensong@google.com [Wed, 15 Aug 2012 17:55:42 +0000 (17:55 +0000)]
fixes elif bug.

git-svn-id: http://skia.googlecode.com/svn/trunk@5114 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadds flag for choosing bench representative algorithm.
bensong@google.com [Wed, 15 Aug 2012 17:31:46 +0000 (17:31 +0000)]
adds flag for choosing bench representative algorithm.

git-svn-id: http://skia.googlecode.com/svn/trunk@5113 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkip tiled drawing in GM for magnifier image filter.
scroggo@google.com [Wed, 15 Aug 2012 16:32:19 +0000 (16:32 +0000)]
Skip tiled drawing in GM for magnifier image filter.

Merely skips the test until we get a real fix for the problem.

BUG=https://code.google.com/p/skia/issues/detail?id=781

Review URL: https://codereview.appspot.com/6459094

git-svn-id: http://skia.googlecode.com/svn/trunk@5111 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded virtual destructor to SkColorSpaceLuminance
robertphillips@google.com [Wed, 15 Aug 2012 14:52:58 +0000 (14:52 +0000)]
Added virtual destructor to SkColorSpaceLuminance

http://codereview.appspot.com/6459092/

git-svn-id: http://skia.googlecode.com/svn/trunk@5110 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd 't' to toggle tiling modes
reed@google.com [Wed, 15 Aug 2012 14:41:58 +0000 (14:41 +0000)]
add 't' to toggle tiling modes
Review URL: https://codereview.appspot.com/6446138

git-svn-id: http://skia.googlecode.com/svn/trunk@5109 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAddressed Windows compiler complaints
robertphillips@google.com [Wed, 15 Aug 2012 14:36:41 +0000 (14:36 +0000)]
Addressed Windows compiler complaints

http://codereview.appspot.com/6462062/

This CL will require re-baselining of the imagemagnifier GM

git-svn-id: http://skia.googlecode.com/svn/trunk@5108 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGrContextFactory can now expose the GLContext it is using.
keyar@chromium.org [Tue, 14 Aug 2012 22:02:48 +0000 (22:02 +0000)]
GrContextFactory can now expose the GLContext it is using.

Review URL: https://codereview.appspot.com/6461081

git-svn-id: http://skia.googlecode.com/svn/trunk@5105 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert r5100 experiment
bsalomon@google.com [Tue, 14 Aug 2012 21:53:53 +0000 (21:53 +0000)]
revert r5100 experiment

git-svn-id: http://skia.googlecode.com/svn/trunk@5104 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert GrTextureStripAtlas change due to performance concerns.
rileya@google.com [Tue, 14 Aug 2012 21:33:15 +0000 (21:33 +0000)]
Revert GrTextureStripAtlas change due to performance concerns.

git-svn-id: http://skia.googlecode.com/svn/trunk@5103 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for GPU-less Linux build: move #include GrTextureStripAtlas into SK_SUPPORT_GPU...
rileya@google.com [Tue, 14 Aug 2012 21:14:08 +0000 (21:14 +0000)]
Fix for GPU-less Linux build: move #include GrTextureStripAtlas into SK_SUPPORT_GPU ifdefs. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@5102 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMade gradient effects use GrTextureStripAtlas.
rileya@google.com [Tue, 14 Aug 2012 21:06:15 +0000 (21:06 +0000)]
Made gradient effects use GrTextureStripAtlas.
Review URL: https://codereview.appspot.com/6450131

git-svn-id: http://skia.googlecode.com/svn/trunk@5101 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporary change to bench on android to run limited set of test in order to see wheth...
bsalomon@google.com [Tue, 14 Aug 2012 20:44:17 +0000 (20:44 +0000)]
Temporary change to bench on android to run limited set of test in order to see whether it allows bench to complete.

Review URL: http://codereview.appspot.com/6459087

git-svn-id: http://skia.googlecode.com/svn/trunk@5100 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnsure that Pipe does not crash when attempting to draw after endRecording.
scroggo@google.com [Tue, 14 Aug 2012 20:38:28 +0000 (20:38 +0000)]
Ensure that Pipe does not crash when attempting to draw after endRecording.

Add a test for drawing a bitmap and a bitmapshader after endRecording.

BUG=https://code.google.com/p/skia/issues/detail?id=774&can=3
Test=PipeTest

Review URL: https://codereview.appspot.com/6459088

git-svn-id: http://skia.googlecode.com/svn/trunk@5099 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing source files that do not have newlines at the end.
rmistry@google.com [Tue, 14 Aug 2012 20:27:54 +0000 (20:27 +0000)]
Fixing source files that do not have newlines at the end.

Found using the new unsubmitted newline_checker slave script:
piraeus.cnc.corp.google.com:10125/builders/Skia_House_Keeping/builds/5/steps/shell_1/logs/stdio
Review URL: https://codereview.appspot.com/6443124

git-svn-id: http://skia.googlecode.com/svn/trunk@5097 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoprivatize SkScalerContext.h
reed@google.com [Tue, 14 Aug 2012 19:45:58 +0000 (19:45 +0000)]
privatize SkScalerContext.h

git-svn-id: http://skia.googlecode.com/svn/trunk@5096 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBug Fix: Fixes transformation bug where debugger locked up during incremental draw...
chudy@google.com [Tue, 14 Aug 2012 19:38:31 +0000 (19:38 +0000)]
Bug Fix: Fixes transformation bug where debugger locked up during incremental draw due to nested clips not being cleared.

Review URL: https://codereview.appspot.com/6462060

git-svn-id: http://skia.googlecode.com/svn/trunk@5095 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBug Fix: Fixes incremental drawing in conjunction with the highlighting filter for...
chudy@google.com [Tue, 14 Aug 2012 19:36:09 +0000 (19:36 +0000)]
Bug Fix: Fixes incremental drawing in conjunction with the highlighting filter for the OpenGL widget.

Review URL: https://codereview.appspot.com/6441141

git-svn-id: http://skia.googlecode.com/svn/trunk@5094 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefactored inspector widget such that creating custom tabs for information is straigh...
chudy@google.com [Tue, 14 Aug 2012 19:34:13 +0000 (19:34 +0000)]
Refactored inspector widget such that creating custom tabs for information is straightforward for future developers.

Review URL: https://codereview.appspot.com/6463046

git-svn-id: http://skia.googlecode.com/svn/trunk@5093 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix broken test.
scroggo@google.com [Tue, 14 Aug 2012 19:30:20 +0000 (19:30 +0000)]
Fix broken test.

Review URL: https://codereview.appspot.com/6450133

git-svn-id: http://skia.googlecode.com/svn/trunk@5092 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove write buffer flags used by SkFlataData::Create into SkFlatController.
scroggo@google.com [Tue, 14 Aug 2012 19:22:05 +0000 (19:22 +0000)]
Move write buffer flags used by SkFlataData::Create into SkFlatController.

Review URL: https://codereview.appspot.com/6446135

git-svn-id: http://skia.googlecode.com/svn/trunk@5091 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTo allow forward declarations, move SkScalerContext::Rec to SkScalerContextRec
reed@google.com [Tue, 14 Aug 2012 19:13:55 +0000 (19:13 +0000)]
To allow forward declarations, move SkScalerContext::Rec to SkScalerContextRec
Review URL: https://codereview.appspot.com/6462059

git-svn-id: http://skia.googlecode.com/svn/trunk@5090 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReduce number of paths created by benchs
bsalomon@google.com [Tue, 14 Aug 2012 17:49:46 +0000 (17:49 +0000)]
Reduce number of paths created by benchs

Review URL:http://codereview.appspot.com/6454151/

git-svn-id: http://skia.googlecode.com/svn/trunk@5088 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove baseline for flaky test.
scroggo@google.com [Tue, 14 Aug 2012 17:47:43 +0000 (17:47 +0000)]
Remove baseline for flaky test.

This test goes back and forth, slightly changing the location of a
rectangle, only on this bot. Remove the baseline so we no longer
see the noise.

Review URL: https://codereview.appspot.com/6460088

git-svn-id: http://skia.googlecode.com/svn/trunk@5087 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoprivatize SkDescriptor.h
reed@google.com [Tue, 14 Aug 2012 17:41:34 +0000 (17:41 +0000)]
privatize SkDescriptor.h

git-svn-id: http://skia.googlecode.com/svn/trunk@5086 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn SkGPipeCanvas, rename fSharedHeap to fBitmapHeap
scroggo@google.com [Tue, 14 Aug 2012 17:21:34 +0000 (17:21 +0000)]
In SkGPipeCanvas, rename fSharedHeap to fBitmapHeap

to reflect the fact that it is only used for storing bitmaps.

Review URL: https://codereview.appspot.com/6446134

git-svn-id: http://skia.googlecode.com/svn/trunk@5085 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkTArray consider only the new count and reserve when determining how much to...
bsalomon@google.com [Tue, 14 Aug 2012 17:19:08 +0000 (17:19 +0000)]
Make SkTArray consider only the new count and reserve when determining how much to alloc
Review URL: http://codereview.appspot.com/6459084

git-svn-id: http://skia.googlecode.com/svn/trunk@5084 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBug Fix: Resets the users zoom and translation every picture load. Was acting inconsi...
chudy@google.com [Tue, 14 Aug 2012 16:00:32 +0000 (16:00 +0000)]
Bug Fix: Resets the users zoom and translation every picture load. Was acting inconsistently between different viewing widgets, now forces a redraw every new picture.

Review URL: https://codereview.appspot.com/6450130

git-svn-id: http://skia.googlecode.com/svn/trunk@5083 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkBitmapHeap for shaders in SkGPipe.
scroggo@google.com [Tue, 14 Aug 2012 15:48:43 +0000 (15:48 +0000)]
Use SkBitmapHeap for shaders in SkGPipe.

Required adding a new feature to SkBitmapHeap, allowing it to defer
adding owners, since sometimes we flatten a shader, but then do not
unflatten it, since we already had a copy in the heap, so the owners
never get removed.

Reviewed at https://codereview.appspot.com/6464053/

Review URL: https://codereview.appspot.com/6465047

git-svn-id: http://skia.googlecode.com/svn/trunk@5082 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCheck in r5063 again, along with fix for tests.
scroggo@google.com [Tue, 14 Aug 2012 15:20:01 +0000 (15:20 +0000)]
Check in r5063 again, along with fix for tests.

Thank you to Android build, for catching the problem, which would
show up elsewhere. Now we access entry->fStorageSlot before
deleting entry.

(Original message:)
Use the SkBitmapHeap to handle SkBitmaps in SkGPipe cross process.

Required moving the LRU handles from SkBitmapHeapEntry to LookupEntry.

Allows simplification of drawBitmap* calls in SkGPipeCanvas.

Review URL: https://codereview.appspot.com/6453113

git-svn-id: http://skia.googlecode.com/svn/trunk@5081 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReduce allocations in RandomPathBench
bsalomon@google.com [Tue, 14 Aug 2012 15:10:09 +0000 (15:10 +0000)]
Reduce allocations in RandomPathBench

Review URL: http://codereview.appspot.com/6453116

git-svn-id: http://skia.googlecode.com/svn/trunk@5080 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClean up most clang warnings outside animator/
tomhudson@google.com [Tue, 14 Aug 2012 15:03:35 +0000 (15:03 +0000)]
Clean up most clang warnings outside animator/

http://codereview.appspot.com/6464058/

git-svn-id: http://skia.googlecode.com/svn/trunk@5079 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAugmenting SkDeferredCanvas notification interface to signal flushes and memory alloc...
junov@chromium.org [Tue, 14 Aug 2012 13:36:26 +0000 (13:36 +0000)]
Augmenting SkDeferredCanvas notification interface to signal flushes and memory allocations
Renamed SkDeferredCanvas::DeviceContext to SkDeferredCanvas::NotificationClient

BUG=http://code.google.com/p/chromium/issues/detail?id=136828
TEST=Added coverage for new API to DeferredCanvas unit test. Added DeferredCanvas bench test to track deferred canvas overhead cost.
Review URL: https://codereview.appspot.com/6442108

git-svn-id: http://skia.googlecode.com/svn/trunk@5078 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd LF at the end, for clanginess
reed@google.com [Tue, 14 Aug 2012 13:22:16 +0000 (13:22 +0000)]
add LF at the end, for clanginess

git-svn-id: http://skia.googlecode.com/svn/trunk@5077 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd inst counting to bench and count SkPaths
bsalomon@google.com [Tue, 14 Aug 2012 13:15:44 +0000 (13:15 +0000)]
Add inst counting to bench and count SkPaths

Review URL: http://codereview.appspot.com/6450129/

git-svn-id: http://skia.googlecode.com/svn/trunk@5076 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodelete empty file
mike@reedtribe.org [Tue, 14 Aug 2012 01:30:34 +0000 (01:30 +0000)]
delete empty file

git-svn-id: http://skia.googlecode.com/svn/trunk@5075 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooops, revert the flake on the win shuttle
mike@reedtribe.org [Tue, 14 Aug 2012 01:25:42 +0000 (01:25 +0000)]
oops, revert the flake on the win shuttle

git-svn-id: http://skia.googlecode.com/svn/trunk@5074 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove as flake?
mike@reedtribe.org [Tue, 14 Aug 2012 01:12:43 +0000 (01:12 +0000)]
remove as flake?

git-svn-id: http://skia.googlecode.com/svn/trunk@5073 2bbb7eff-a529-9590-31e7-b0007b416f81