Edward Hervey [Wed, 16 Apr 2014 13:17:03 +0000 (15:17 +0200)]
dvbsrc: Don't try to access NULL string
And refactor the pid setting code to be in its own function for clarity
CID #206374
Stefan Ringel [Thu, 10 Apr 2014 14:04:21 +0000 (16:04 +0200)]
mpegts: add dvb ca identifier descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727560
Stefan Ringel [Thu, 10 Apr 2014 14:03:07 +0000 (16:03 +0200)]
mpegts: add scrambling descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727560
Stefan Ringel [Thu, 10 Apr 2014 14:02:09 +0000 (16:02 +0200)]
mpegts: add frequency list descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727560
Stefan Ringel [Thu, 10 Apr 2014 14:00:50 +0000 (16:00 +0200)]
mpegts: add data broadcast id descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727403
Stefan Ringel [Thu, 10 Apr 2014 13:59:50 +0000 (15:59 +0200)]
mpegts: add private data specifier descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727403
Sebastian Dröge [Wed, 16 Apr 2014 07:20:37 +0000 (09:20 +0200)]
dvb: Minor code style fix
Stefan Ringel [Thu, 10 Apr 2014 13:58:55 +0000 (15:58 +0200)]
mpegts: add parential rating descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727403
Stefan Ringel [Thu, 10 Apr 2014 13:58:04 +0000 (15:58 +0200)]
mpegts: add linkage descriptor
https://bugzilla.gnome.org/show_bug.cgi?id=727403
Tim-Philipp Müller [Tue, 15 Apr 2014 23:25:51 +0000 (00:25 +0100)]
mpegts: for loop initial declarations are only allowed in C99 mode
Fixes compiler warnings.
Sebastian Dröge [Tue, 15 Apr 2014 18:47:55 +0000 (20:47 +0200)]
egl: Add libgstegl and eglgles plugin to the CRUFT directories
Julien Isorce [Tue, 15 Apr 2014 16:58:34 +0000 (17:58 +0100)]
egl/eglglessink: remove since EGLImage and iOS support have been added in glimagesink
https://bugzilla.gnome.org/show_bug.cgi?id=703343
Julien Isorce [Mon, 24 Mar 2014 12:08:43 +0000 (12:08 +0000)]
gl: allow to include GLES/gl.h
https://bugzilla.gnome.org/show_bug.cgi?id=703343
Edward Hervey [Mon, 14 Apr 2014 05:56:16 +0000 (07:56 +0200)]
wayland: Remove dead assignment
We set it just after variable declaration
CID #1197709
Sebastian Dröge [Sun, 13 Apr 2014 17:20:32 +0000 (19:20 +0200)]
gl/eagl: Fix compilation
Sebastian Dröge [Sun, 13 Apr 2014 14:53:58 +0000 (16:53 +0200)]
gl/eagl: Notify the window's resize callback about surface dimension changes
https://bugzilla.gnome.org/show_bug.cgi?id=728107
Sebastian Dröge [Sun, 13 Apr 2014 14:46:11 +0000 (16:46 +0200)]
gl/eagl: Remove spurious private struct pointer
Sebastian Dröge [Sun, 13 Apr 2014 14:40:58 +0000 (16:40 +0200)]
gl/android: Notify the window's resize callback about surface dimension changes
https://bugzilla.gnome.org/show_bug.cgi?id=728107
Matthew Waters [Sun, 13 Apr 2014 12:16:45 +0000 (22:16 +1000)]
glimagesink: remove unused texture
Matthew Waters [Sun, 13 Apr 2014 12:14:52 +0000 (22:14 +1000)]
glimagesink: move upload into _prepare()
Matthew Waters [Sun, 13 Apr 2014 03:49:22 +0000 (13:49 +1000)]
gl/context: output available extensions
Matthew Waters [Sun, 13 Apr 2014 03:39:14 +0000 (13:39 +1000)]
gl/context: provide get_gl_version
Julien Isorce [Sat, 12 Apr 2014 23:21:00 +0000 (00:21 +0100)]
gl/color: restore viewport dimensions when fbo done
Regression introduced by
95abfda1399bcddbee345d4542e857d743965477.
It caused to display the wrong frame size when resizing the window.
Sebastian Dröge [Sat, 12 Apr 2014 20:45:30 +0000 (22:45 +0200)]
gl: Import QuartzCore/QuartzCore.h for CAEAGLLayer on older iOS versions
Sebastian Dröge [Sat, 12 Apr 2014 20:15:35 +0000 (22:15 +0200)]
gl: Set glimagesink rank to SECONDARY
This is a full-featured video sink now and especially should be
used instead of osxvideosink on OSX if available.
Sebastian Dröge [Sat, 12 Apr 2014 19:43:50 +0000 (21:43 +0200)]
gl: Add support for iOS EAGL platform
https://bugzilla.gnome.org/show_bug.cgi?id=703341
Julien Isorce [Sat, 12 Apr 2014 16:33:44 +0000 (17:33 +0100)]
gl/cocoa: make gst_gl_window_cocoa_send_message_async re-entrant
Backends that use g_main_context_invoke are re-entrant.
Il allows to call two nested gst_gl_context_thread_add.
ex: init_upload / init_colorconvert
Sebastian Dröge [Sat, 12 Apr 2014 15:01:09 +0000 (17:01 +0200)]
glimagesink: First handle GL window setup, then create the context and its thread
Julien Isorce [Sat, 12 Apr 2014 14:51:47 +0000 (15:51 +0100)]
gl/cocoa: fix NSAutoreleasePool initialization
Julien Isorce [Sat, 12 Apr 2014 11:42:40 +0000 (12:42 +0100)]
gl/cocoa: ensure to call NSApplication:sharedApplication in the main thread
"(NSApplication *)sharedApplication This method also makes a connection
to the window server and completes other initialization"
The implicit thing which is not mentioned is that it required
to be called in the main thread.
Fix a regression introduces by
82b7c915bb02a9790d256d599452e5a54afda633
When using with gst-launch, it was not possible to click on the close
cross of the window anymore which is a bit anoying and also because
it's was possible before.
Prior to this commit the GstGLContextCocoaClass was initialized
in the main thread because gst_gl_context_new was called in the
state change function from going from ready to paused.
From this commit this call is done from the streaming thread.
So that the call to [NSApplication sharedApplication];
was not done in the main thread anymore.
We now ensure that by assuming there is a GMainLoop running.
It's for debugging purpose so that's ok to do that. Also
note we already do this assumtion to run app itereations.
The regression had no consequence on the cocoa/videooverlay example
(that should be moved from gst-plugins-gl to -bad) because the
application is responsible for that necessary call.
Julien Isorce [Sat, 12 Apr 2014 13:40:40 +0000 (14:40 +0100)]
gl/color: fix warning type qualifiers ignored
i686-apple-darwin11-llvm-gcc-4.2
"warning: type qualifiers ignored on function return type"
Matthew Waters [Sat, 12 Apr 2014 08:24:43 +0000 (18:24 +1000)]
gl/color: remove if statement with no effect
Coverity 1199698
Matthew Waters [Sat, 12 Apr 2014 08:16:29 +0000 (18:16 +1000)]
gl/color: pass large value by reference
Coverity 1199700
Aleix Conchillo Flaqué [Wed, 2 Apr 2014 19:59:58 +0000 (12:59 -0700)]
srtpdec: fix assertion checking ssrc from rtcp packets
rtcp_buffer_get_ssrc is called even with RTP buffers. this means we
might end up with an exception and not find any valid RTCP packet type
and thus hit GST_RTCP_TYPE_INVALID. we now take care of this.
https://bugzilla.gnome.org/show_bug.cgi?id=727512
Andoni Morales Alastruey [Fri, 11 Apr 2014 10:29:17 +0000 (12:29 +0200)]
jp2kdecimator: fix maybe-uninitialized compiler error
Edward Hervey [Fri, 11 Apr 2014 09:34:26 +0000 (11:34 +0200)]
mpegtsmux: Remove unneeded unref
packet_buffer has already been cleared in all code paths leading
to this point.
CID #1199696
Edward Hervey [Fri, 11 Apr 2014 06:39:29 +0000 (08:39 +0200)]
dvbsrc: Handle symbols added in minor version 7 and 8
Some symbols were re-defined in minor v8 (GO TEAM BACKWARDS COMPATIBLE!)
Some symbols were added in minor v7
https://bugzilla.gnome.org/show_bug.cgi?id=727977
Matthew Waters [Fri, 11 Apr 2014 07:24:39 +0000 (17:24 +1000)]
gl/mem: cache the stride/unpack length for upload
Matthew Waters [Fri, 11 Apr 2014 07:23:32 +0000 (17:23 +1000)]
gl/color: explicitly map the buffers we are copying into
Otherwise it may not be downloaded at all.
Edward Hervey [Fri, 11 Apr 2014 06:16:01 +0000 (08:16 +0200)]
dvbsrc: Add comment with all DVB API v5 minor changes
There wasn't a definite list anyway, so I just dove in the kernel
and extract all that information.
Matthew Waters [Fri, 11 Apr 2014 06:09:09 +0000 (16:09 +1000)]
gl/color: cache the temporary textures
Matthew Waters [Fri, 11 Apr 2014 01:04:43 +0000 (11:04 +1000)]
gl/mem: provide defines for tokens not defined in GLES2/ancient platforms
Matthew Waters [Fri, 11 Apr 2014 01:03:19 +0000 (11:03 +1000)]
gl: fixup incorrect number of arguments
Matthew Waters [Fri, 11 Apr 2014 00:55:21 +0000 (10:55 +1000)]
gl: fix incorrect usage of g_return_if_fail
Matthew Waters [Wed, 2 Apr 2014 06:43:52 +0000 (17:43 +1100)]
gl/mem: allocate the memory per plane
This patch provides the basic infrastructure required for this.
Upload and Download has been ported to this.
Has the nice effect of allowing GstGLMemory to be our
refcounted texture object for any texture type (not just RGBA).
Should not lose any features/video formats.
Matthew Waters [Tue, 1 Apr 2014 04:10:05 +0000 (15:10 +1100)]
gl/eglimage: #if 0 unused code
Matthew Waters [Tue, 1 Apr 2014 02:30:51 +0000 (13:30 +1100)]
gl: add colorconvert object that converts between color spaces/formats
Currently used by both upload and download objects separately.
Vincent Penquerc'h [Thu, 10 Apr 2014 16:55:21 +0000 (17:55 +0100)]
faac: fix faac API error checking
Coverity 1139790
Vincent Penquerc'h [Thu, 10 Apr 2014 16:52:02 +0000 (17:52 +0100)]
dashdemux: do not ignore failure to register typefinder
Coverity 1139629
Vincent Penquerc'h [Thu, 10 Apr 2014 16:48:03 +0000 (17:48 +0100)]
dashdemux: fix time leak
Coverity 1147016
Vincent Penquerc'h [Thu, 10 Apr 2014 16:44:14 +0000 (17:44 +0100)]
dashdemux: remove dead code and variable
A recent commit made stream not able to be NULL, ending up with
a flag being always set to FALSE when it matters.
Coverity 1146968, 1147012
Vincent Penquerc'h [Thu, 10 Apr 2014 16:37:22 +0000 (17:37 +0100)]
curl: remove unneeded NULL check
We just checked for NULL and allocated if it was. And glib aborts
if it can't allocate, I'm told.
Coverity 1139841
Vincent Penquerc'h [Thu, 10 Apr 2014 16:33:55 +0000 (17:33 +0100)]
curl: remove duplicate assignment
Coverity 1197708
Sebastian Dröge [Thu, 10 Apr 2014 14:53:42 +0000 (16:53 +0200)]
hlsdemux: Also update the sequence position when updating non-live playlists
Sebastian Dröge [Thu, 10 Apr 2014 12:59:57 +0000 (14:59 +0200)]
hlsdemux: Try reloading the playlist first if downloading a fragment fails
But only add this for non-live playlists. For live playlists we already
have another thread that is periodically updating playlists.
Reason for this is that sometimes downloading a fragment can fail because
the URIs have changed or expired since last time.
Sebastian Dröge [Thu, 10 Apr 2014 12:46:01 +0000 (14:46 +0200)]
hlsdemux: When updating a non-live playlist make sure to find the current sequence by time
Sequence numbers in different playlists are not guaranteed to be the same for the
same position, e.g. fragments could have different durations in different playlists.
In theory we should do exactly the same for live playlists, but unfortunately we can't
because doing this kind of seeking requires the complete playlist since we started
playback. For live playlists the server is however dropping fragments in the beginning
over time and we have no absolute time references.
Vincent Penquerc'h [Wed, 9 Apr 2014 16:28:49 +0000 (17:28 +0100)]
smoothstreaming: avoid using an uninitialized manifest
If we did not set the manifest yet, early out in the seeking query.
Coverity 1139737
Thibault Saunier [Mon, 17 Mar 2014 15:39:42 +0000 (16:39 +0100)]
h264parse: Set framerate even for interlaced videos
Co-Authored by: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
https://bugzilla.gnome.org/show_bug.cgi?id=726752
Stefan Ringel [Wed, 9 Apr 2014 08:04:46 +0000 (10:04 +0200)]
mpegts: add atsc terrestrial virtual channel table
https://bugzilla.gnome.org/show_bug.cgi?id=727460
Santiago Carot-Nemesio [Wed, 9 Apr 2014 13:07:19 +0000 (15:07 +0200)]
liveadder: fix memory leak querying sink caps
https://bugzilla.gnome.org/show_bug.cgi?id=727894
Vincent Penquerc'h [Wed, 9 Apr 2014 17:44:38 +0000 (18:44 +0100)]
hlssink: catch failure to write playlist file
Coverity 1139613
Vincent Penquerc'h [Wed, 9 Apr 2014 17:31:31 +0000 (18:31 +0100)]
kate: fix implicit promotion to signed int breaking on largeish inputs
Coverity 1139858, 1139857
Vincent Penquerc'h [Wed, 9 Apr 2014 17:16:52 +0000 (18:16 +0100)]
ladspa: remove duplicate assignment
Coverity 1139706
Vincent Penquerc'h [Wed, 9 Apr 2014 17:12:58 +0000 (18:12 +0100)]
mimdec: fix open error checking
Coverity 206364
Vincent Penquerc'h [Wed, 9 Apr 2014 16:37:41 +0000 (17:37 +0100)]
schrodec: remove unnecessary check
The tag was dereferenced earier. From the libschroedinger code,
it's not obvious to see whether tag and frame would be NULL at
the same time. I think is likely that both will be non NULL
here, but that's not certain. Additional tests may be needed
to avoid dereferencing tag and/or frame, but what to do if
only one is NULL isn't obvious, as the _get_tag function does
transfer ownership so isn't undoable.
Coverity 1139850
Vincent Penquerc'h [Wed, 9 Apr 2014 16:10:06 +0000 (17:10 +0100)]
smoothstreaming: remove unnecessary check
The function is static, the only call site passes a non NULL
pointer, and the pointer is dereferenced before anyway.
Coverity 1139839
Vincent Penquerc'h [Wed, 9 Apr 2014 15:55:30 +0000 (16:55 +0100)]
srtp: remove dead assignment
Coverity 1197707
Vincent Penquerc'h [Wed, 9 Apr 2014 14:54:18 +0000 (15:54 +0100)]
mpegts: fix sdt length check
It was originally test for 9 bytes (as the comment says) and was
rewritten buggily. So rewrite it a third way, which is now
hopefully consistent with the original and the comment, while
being more sense-making to humans.
Coverity 1139654
Vincent Penquerc'h [Wed, 9 Apr 2014 15:00:24 +0000 (16:00 +0100)]
Revert "tsmux: catch alloc failure"
Turns out glib aborts on allocation failure, so this is pointless.
We'll just ignore Coverity warnings on such constructs.
This reverts commit
d347809a82e24057302f948269392e76aaacea10.
Vincent Penquerc'h [Wed, 9 Apr 2014 14:58:37 +0000 (15:58 +0100)]
mpegts: turns out glib aborts on allocation failure
So this is actually pointless. We'll just have to ignore
Coverity moaning on those.
Revert "mpegts: test for allocation failure"
This reverts commit
224cb81b8fcbf03df5e07f045ecb9ecf64189400.
Vincent Penquerc'h [Wed, 9 Apr 2014 14:44:10 +0000 (15:44 +0100)]
mpegts: test for allocation failure
While it's unlikely to get there, it silences the coverity warning
on the error code path that we test for NULL before freeing, when
all branches there are from locations where pmt cannot be NULL,
and removing the NULL check makes the code more vulnerable to a
hypothetical future branch from somewhere where it can be.
Coverity 1139852
Vincent Penquerc'h [Wed, 9 Apr 2014 14:41:11 +0000 (15:41 +0100)]
asfmux: remove unnecessary test
We've been dereferencing that object like there's no tomorrow
in the code just before that.
Coverity 206369
Vincent Penquerc'h [Wed, 9 Apr 2014 14:37:55 +0000 (15:37 +0100)]
asfmux: remove stray gst_buffer_unmap on error path
A previous commit removed the map, and the unmap on the main
code path, but not the one on the error path.
Coverity 1139930
Vincent Penquerc'h [Wed, 9 Apr 2014 14:28:05 +0000 (15:28 +0100)]
autoconvert: remove dead code
Those events were previously taken from a cached events list,
which was removed during the port to 0.11, but this bit stayed.
Coverity 1139684
Vincent Penquerc'h [Wed, 9 Apr 2014 14:24:13 +0000 (15:24 +0100)]
camerabin2: remove unneeded check
A message may not be NULL in the message handling function
(and nothing there sets it to NULL).
Coverity 1139848
Vincent Penquerc'h [Wed, 9 Apr 2014 14:18:22 +0000 (15:18 +0100)]
compare: special case empty regions with 1 SSIM to avoid dividing by 0
Coverity 1139689, 1139688
Vincent Penquerc'h [Wed, 9 Apr 2014 14:09:25 +0000 (15:09 +0100)]
inter: remove dead code
Coverity 1139666
Vincent Penquerc'h [Wed, 9 Apr 2014 14:03:45 +0000 (15:03 +0100)]
liveadder: remove dead code
From the 0.11 port
Coverity 1139676
Vincent Penquerc'h [Wed, 9 Apr 2014 13:37:48 +0000 (14:37 +0100)]
resindvd: avoid crashing in pathological case
When we'd see an unknown stream type, then a SDDS stream.
Then we'd get to the end of the switch with a NULL temp stream
pointer, and dereference it.
Coverity 1139708
Vincent Penquerc'h [Wed, 9 Apr 2014 13:13:46 +0000 (14:13 +0100)]
mpegtsdemux: catch prev-not-found when inserting in the group list
While this probably should never happen if callers are well behaved,
this avoids a crash if it does. With a warning about it. Unsure if
it'd be better to not add at all, but it should not happen...
Coverity 1139713
Vincent Penquerc'h [Wed, 9 Apr 2014 12:51:41 +0000 (13:51 +0100)]
mpegtsmux: guard against _dispose being called mutiple times
_dispose calls _reset, so we need to make sure _reset handles
already NULLed fields.
Coverity 1139843
Vincent Penquerc'h [Wed, 9 Apr 2014 12:43:10 +0000 (13:43 +0100)]
tsmux: prevent possible double free on error path
Spotted while looking at a Coverity issue in the area.
Vincent Penquerc'h [Wed, 9 Apr 2014 12:41:35 +0000 (13:41 +0100)]
tsmux: catch alloc failure
While it will probably not trigger, it should silence a Coverity
warning about the fail code path testing for NULLness before
freeing, where the buffer was already dereferenced. It seems
safest to keep that test, in case future goto fail statements
happen to have a NULL buffer there.
Coverity 1139851
Vincent Penquerc'h [Wed, 9 Apr 2014 10:43:23 +0000 (11:43 +0100)]
decklink: initialize priv to NULL
While the code that creates the object sets priv to some existing
pointer after new, this ensures any future new not doing this will
hit the various priv!=NULL asserts in the code.
Coverity 1139935
Vincent Penquerc'h [Wed, 9 Apr 2014 10:15:10 +0000 (11:15 +0100)]
speed: make duration query able to convert bytes to time
It was only querying in time, but then trying to use dead bytes
to time conversion code.
Coverity 1139677
Vincent Penquerc'h [Wed, 9 Apr 2014 10:04:32 +0000 (11:04 +0100)]
mfc: fix left crop change test
It was testing a noop
Coverity 1139643
Vincent Penquerc'h [Wed, 9 Apr 2014 10:02:00 +0000 (11:02 +0100)]
opus: add missing va_end in variadic function
Coverity 1139944
Vincent Penquerc'h [Wed, 9 Apr 2014 10:00:22 +0000 (11:00 +0100)]
shm: remove dead code
Coverity 1139683
Vincent Penquerc'h [Wed, 9 Apr 2014 09:56:16 +0000 (10:56 +0100)]
mfc: reset "in use" flag on failure to initialize
Vincent Penquerc'h [Wed, 9 Apr 2014 09:55:46 +0000 (10:55 +0100)]
mfc: test for allocation failure before dereferencing
Coverity 1139849
Vincent Penquerc'h [Wed, 9 Apr 2014 09:33:10 +0000 (10:33 +0100)]
mpeg2enc: remove dead assignment
Coverity 1139829
Vincent Penquerc'h [Wed, 9 Apr 2014 09:28:46 +0000 (10:28 +0100)]
gl: pass large structure by const pointer, not value
Avoids large pointless memcpy.
Coverity 206236, 206237
Mohammed Sameer [Tue, 8 Apr 2014 18:39:20 +0000 (21:39 +0300)]
camerabin: add any feature to viewfinderbin static pad template
https://bugzilla.gnome.org/show_bug.cgi?id=727857
Mohammed Sameer [Tue, 8 Apr 2014 17:54:26 +0000 (20:54 +0300)]
camerabin: report an error if we fail to link vfsrc and viewfinder queue
https://bugzilla.gnome.org/show_bug.cgi?id=727855
Tim-Philipp Müller [Tue, 8 Apr 2014 16:45:46 +0000 (17:45 +0100)]
d3dvideosink: post proper error message when window disappears
Vincent Penquerc'h [Tue, 8 Apr 2014 16:34:13 +0000 (17:34 +0100)]
flite: fix off by one in channel mask building
The first loop would shift 1 by 64, which is either undefined
or implementation defined, instead of clearing the top bit.
Coverity 1197691
Vincent Penquerc'h [Tue, 8 Apr 2014 16:10:27 +0000 (17:10 +0100)]
hls: restore NULL test mistakenly removed
Thanks to tpm for point out I'm an idiot.
Vincent Penquerc'h [Tue, 8 Apr 2014 15:53:54 +0000 (16:53 +0100)]
hls: only set DISCONT flag on a valid buffer
Recent refactoring causes this code to be called with either a NULL
fragment, or a non NULL fragment. In the former case, we don't have
a buffer. In the latter case, the original code dealing with DISCONT
assumed the buffer was valid. Testing for a NULL buffer here thus
does not seem to change the intent, and fixes:
Coverity 1195147
Tim-Philipp Müller [Tue, 8 Apr 2014 15:53:41 +0000 (16:53 +0100)]
mxfdemux: guard against NULL material track
Just to be on the safe side.
Vincent Penquerc'h [Tue, 8 Apr 2014 15:46:56 +0000 (16:46 +0100)]
hls: bring NULL test before dereference
Coverity 1195168