Behdad Esfahbod [Wed, 7 Nov 2018 14:53:02 +0000 (09:53 -0500)]
[kern] Remove Override business
Not used in any fonts. Not well-specified when mixing kerning with
Cross-Stream positioning.
Behdad Esfahbod [Wed, 7 Nov 2018 05:25:48 +0000 (00:25 -0500)]
[kern/kerx] Fix cursive joining
Tested with Waseem TTC:
$ hb-shape Waseem.ttc جحخج
[F1Jeem_R2=3@0,180+479|M1Khah_L2_R2=2@0,682+403|M1Hah_L2_R2=1@0,1184+403|I1Jeem_L2=0@0,1184+744]
Behdad Esfahbod [Wed, 7 Nov 2018 05:04:40 +0000 (00:04 -0500)]
[kern/kerx] Fix "reset" magic value
Behdad Esfahbod [Wed, 7 Nov 2018 02:45:40 +0000 (21:45 -0500)]
[kerx] Adjust CrossStream kern to match 'kern' table
Behdad Esfahbod [Wed, 7 Nov 2018 02:41:28 +0000 (21:41 -0500)]
[kern] More tweaks
Solves a mystery or two. I'm fairly confident this is what CoreText does now.
Behdad Esfahbod [Wed, 7 Nov 2018 02:04:40 +0000 (21:04 -0500)]
[kern] Adjust some more
Getting closer. So many open questions still...
Behdad Esfahbod [Wed, 7 Nov 2018 02:04:02 +0000 (21:04 -0500)]
[kern] Add TODO
Behdad Esfahbod [Wed, 7 Nov 2018 00:24:04 +0000 (19:24 -0500)]
[kern] Minor
Behdad Esfahbod [Tue, 6 Nov 2018 23:35:58 +0000 (18:35 -0500)]
[kern] In Format1, adjust how kerning is done
In a series of kerns in one action, kern all but last glyph forward,
and the last one backward. Seems to better match what CoreText is doing.
Test cases, with GeezaPro Arabic:
$ ./hb-shape GeezaPro_10_10.ttc -u U+0631,U+0628
[u0628.beh=1+1415|u0631.reh=0@-202,0+700]
$ ./hb-shape GeezaPro_10_10.ttc -u U+0628,U+064F
[u064f.damma=0@0,-250+-250|u0628.beh=0@250,0+1665]
In a later change, I'll make kern machine avoid producing negative kerns.
Behdad Esfahbod [Tue, 6 Nov 2018 22:16:04 +0000 (17:16 -0500)]
[kern] XXX Negate CrossKerning sign
Not sure why, but seems to better match GeezaPro Arabic w CoreText.
Quite possibly I'm doing something very wrong...
Behdad Esfahbod [Tue, 6 Nov 2018 19:48:42 +0000 (14:48 -0500)]
[kern] Implement CrossStream kerning
Behdad Esfahbod [Tue, 6 Nov 2018 20:23:18 +0000 (15:23 -0500)]
[kern] Improve Format 2
Still disabled.
Behdad Esfahbod [Tue, 6 Nov 2018 20:07:19 +0000 (15:07 -0500)]
Minor
Behdad Esfahbod [Tue, 6 Nov 2018 18:32:13 +0000 (13:32 -0500)]
[kern] Minor
Behdad Esfahbod [Tue, 6 Nov 2018 18:18:27 +0000 (13:18 -0500)]
[kern] Minor
Behdad Esfahbod [Tue, 6 Nov 2018 18:51:39 +0000 (13:51 -0500)]
[kern/kerx] Fix trace numbering
Behdad Esfahbod [Tue, 6 Nov 2018 17:11:45 +0000 (12:11 -0500)]
[kern] Switch to dispatch
Behdad Esfahbod [Tue, 6 Nov 2018 17:07:15 +0000 (12:07 -0500)]
[kern] Refactor to include header in each subtable type
Behdad Esfahbod [Tue, 6 Nov 2018 16:16:45 +0000 (11:16 -0500)]
[kern] Some more
Behdad Esfahbod [Tue, 6 Nov 2018 16:13:40 +0000 (11:13 -0500)]
[kern] Renames
Khaled Hosny [Tue, 6 Nov 2018 16:10:56 +0000 (18:10 +0200)]
Another missing backlash
Did this ever work?
Khaled Hosny [Tue, 6 Nov 2018 16:07:47 +0000 (18:07 +0200)]
Add missing backslash
Behdad Esfahbod [Tue, 6 Nov 2018 16:03:34 +0000 (11:03 -0500)]
[util] Fix up previous commit
Behdad Esfahbod [Tue, 6 Nov 2018 15:49:19 +0000 (10:49 -0500)]
[util] Don't terminate string after a a 0 in -u
Fixes https://github.com/harfbuzz/harfbuzz/issues/1361
Behdad Esfahbod [Tue, 6 Nov 2018 15:24:54 +0000 (10:24 -0500)]
[fuzzing] Fix test
Behdad Esfahbod [Tue, 6 Nov 2018 15:20:57 +0000 (10:20 -0500)]
[fuzzing] Add make check-valgrind
Behdad Esfahbod [Tue, 6 Nov 2018 15:20:36 +0000 (10:20 -0500)]
[test] Minor
Behdad Esfahbod [Tue, 6 Nov 2018 15:03:38 +0000 (10:03 -0500)]
Minor
Ebrahim Byagowi [Tue, 6 Nov 2018 08:12:47 +0000 (11:42 +0330)]
[test] Fix -Weverything bot complain
Ebrahim Byagowi [Tue, 6 Nov 2018 07:56:30 +0000 (11:26 +0330)]
[test] Test hb_ot_name_{list_names,get_utf8} on test-ot-name
Ebrahim Byagowi [Tue, 6 Nov 2018 07:47:14 +0000 (11:17 +0330)]
Fix link issue of some of the bots
e.g. https://circleci.com/gh/harfbuzz/harfbuzz/52410
Ebrahim Byagowi [Tue, 6 Nov 2018 05:46:28 +0000 (09:16 +0330)]
[mort] Fix table detection logic
mort really needs some initial tests at least.
Behdad Esfahbod [Tue, 6 Nov 2018 04:34:07 +0000 (23:34 -0500)]
Simplify some more
Behdad Esfahbod [Tue, 6 Nov 2018 04:28:52 +0000 (23:28 -0500)]
[math] Shorten names a bit
Behdad Esfahbod [Tue, 6 Nov 2018 04:26:29 +0000 (23:26 -0500)]
[ot-layout] Simplify GSUB/GPOS access
This concludes simplifying table access to face->table.XXXX.
Behdad Esfahbod [Tue, 6 Nov 2018 04:23:57 +0000 (23:23 -0500)]
[ot-layout] Simplify GDEF access
Behdad Esfahbod [Tue, 6 Nov 2018 04:19:04 +0000 (23:19 -0500)]
[ot-layout] Simplify some access
Behdad Esfahbod [Tue, 6 Nov 2018 04:11:46 +0000 (23:11 -0500)]
[ot-layout] Remove ensures
Behdad Esfahbod [Tue, 6 Nov 2018 04:10:37 +0000 (23:10 -0500)]
[ot-font] Remove ensure
Behdad Esfahbod [Tue, 6 Nov 2018 04:09:29 +0000 (23:09 -0500)]
[ot-face] Remove a few ensures
Behdad Esfahbod [Tue, 6 Nov 2018 04:08:33 +0000 (23:08 -0500)]
[ot-face] Simplify more table access
Behdad Esfahbod [Tue, 6 Nov 2018 03:58:43 +0000 (22:58 -0500)]
[ot-face] Simplify table access
Yoohoo!
Behdad Esfahbod [Tue, 6 Nov 2018 03:39:50 +0000 (22:39 -0500)]
[ot-face] Include hb-ot-face directly in hb_face_t
Simplifying access coming next.
Behdad Esfahbod [Tue, 6 Nov 2018 00:49:54 +0000 (19:49 -0500)]
[cmap] Push get_nominal_glyphs down into cmap accelerator
Behdad Esfahbod [Tue, 6 Nov 2018 00:46:29 +0000 (19:46 -0500)]
[cmap] Use hb_nonnullptr_t
Behdad Esfahbod [Mon, 5 Nov 2018 23:47:22 +0000 (18:47 -0500)]
2.1.1
Behdad Esfahbod [Mon, 5 Nov 2018 20:03:18 +0000 (15:03 -0500)]
[fuzzing] Fuzz glyph-id etc in test-ot-face
Behdad Esfahbod [Mon, 5 Nov 2018 19:33:41 +0000 (14:33 -0500)]
[uniscribe] Fix use of deprecated API
Behdad Esfahbod [Mon, 5 Nov 2018 18:45:12 +0000 (13:45 -0500)]
[cmap] Make null accelerator safe
Fixes https://github.com/harfbuzz/harfbuzz/issues/1146
Behdad Esfahbod [Mon, 5 Nov 2018 18:23:54 +0000 (13:23 -0500)]
Add pointer magic operators to hb_atomic_ptr_t
Behdad Esfahbod [Mon, 5 Nov 2018 18:23:07 +0000 (13:23 -0500)]
Fix const-confusion in hb_array_t as well
Behdad Esfahbod [Mon, 5 Nov 2018 18:13:39 +0000 (13:13 -0500)]
[null] Tweak hb_nonnull_ptr_t some more
Behdad Esfahbod [Mon, 5 Nov 2018 17:59:32 +0000 (12:59 -0500)]
Minor
Behdad Esfahbod [Sun, 4 Nov 2018 17:58:02 +0000 (12:58 -0500)]
[aat] Clean up ankr table include mess
Behdad Esfahbod [Sun, 4 Nov 2018 07:47:34 +0000 (02:47 -0500)]
[test] Call test-ot-face.c test from hb-shape-fuzzer
Should increase coverage...
Behdad Esfahbod [Sun, 4 Nov 2018 07:40:20 +0000 (02:40 -0500)]
[test] More funcs in test-ot-face
Behdad Esfahbod [Sun, 4 Nov 2018 07:25:07 +0000 (02:25 -0500)]
Clean up buffer->swap_buffers() calls
That function checks for buffer->successful already. No need
to check at call site.
Behdad Esfahbod [Sun, 4 Nov 2018 01:45:39 +0000 (21:45 -0400)]
Fix >>
Behdad Esfahbod [Sun, 4 Nov 2018 01:41:50 +0000 (21:41 -0400)]
Fix "Warning: extra ";" ignored."
Behdad Esfahbod [Sun, 4 Nov 2018 01:38:24 +0000 (21:38 -0400)]
Revert "Add operator char * to the naked array types as well"
This reverts commit
db889c182ee5f54127285bfaab5bc94dafe46bda.
Was resulting in ambigious overloads...
Behdad Esfahbod [Sun, 4 Nov 2018 01:07:39 +0000 (21:07 -0400)]
Minor
Behdad Esfahbod [Sun, 4 Nov 2018 00:50:56 +0000 (20:50 -0400)]
[test] Add test for empty face
Behdad Esfahbod [Sat, 3 Nov 2018 20:15:30 +0000 (16:15 -0400)]
Fix null accelerator's
Fixes all except for cmap. To be done separately.
Part of https://github.com/harfbuzz/harfbuzz/issues/1146
Behdad Esfahbod [Sat, 3 Nov 2018 20:04:19 +0000 (16:04 -0400)]
Add operator char * to the naked array types as well
Behdad Esfahbod [Sat, 3 Nov 2018 20:02:03 +0000 (16:02 -0400)]
Add operator char * to hb_nonnull_ptr_t
Behdad Esfahbod [Sat, 3 Nov 2018 19:59:13 +0000 (15:59 -0400)]
Template casts in hb_nonnull_ptr_t
Behdad Esfahbod [Sat, 3 Nov 2018 19:49:37 +0000 (15:49 -0400)]
[blob] Allow null parent in create_sub_blob()
Like font and unicode.
Behdad Esfahbod [Sat, 3 Nov 2018 19:24:14 +0000 (15:24 -0400)]
Add hb_nonnull_ptr_t
Towards fixing https://github.com/harfbuzz/harfbuzz/issues/1146
Behdad Esfahbod [Sat, 3 Nov 2018 19:14:57 +0000 (15:14 -0400)]
[kern] Third try fix access violation in Format3
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
Behdad Esfahbod [Sat, 3 Nov 2018 19:06:45 +0000 (15:06 -0400)]
[kern] Really fix access violation in Format3
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
Behdad Esfahbod [Sat, 3 Nov 2018 19:03:06 +0000 (15:03 -0400)]
Replace most uses of is_inert with is_immutable
Behdad Esfahbod [Sat, 3 Nov 2018 18:58:54 +0000 (14:58 -0400)]
[kern] Fix access violation in Format3
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
Behdad Esfahbod [Sat, 3 Nov 2018 18:51:38 +0000 (14:51 -0400)]
Port objects to use header.writable instead of immutable
Saves 4 or 8 bytes per object on 64bit archs.
Behdad Esfahbod [Sat, 3 Nov 2018 18:28:55 +0000 (14:28 -0400)]
[object] Add "writable"
Ebrahim Byagowi [Sat, 3 Nov 2018 18:58:30 +0000 (22:28 +0330)]
[BASE] Improvements (#1347)
Ebrahim Byagowi [Sat, 3 Nov 2018 09:33:36 +0000 (13:03 +0330)]
[fuzz] A new testcase
Khaled Hosny [Fri, 2 Nov 2018 21:06:00 +0000 (23:06 +0200)]
[os2] Capitalize table tag and struct
Other tables follow the case of the OT tag, except this one.
Behdad Esfahbod [Fri, 2 Nov 2018 18:47:42 +0000 (14:47 -0400)]
[kern] Implement Format1
Also, implement backwards kerning for Format1 in kern and kerx.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1350
Behdad Esfahbod [Fri, 2 Nov 2018 18:43:38 +0000 (14:43 -0400)]
[kern] Set subtable on sanitizer
Behdad Esfahbod [Fri, 2 Nov 2018 18:26:04 +0000 (14:26 -0400)]
[kern] Respect more flags
Behdad Esfahbod [Fri, 2 Nov 2018 17:57:41 +0000 (13:57 -0400)]
[kern] Minor
We like check_struct() more.
Behdad Esfahbod [Fri, 2 Nov 2018 17:47:33 +0000 (13:47 -0400)]
Remove pointer cast operators from ArrayOf<>
ArrayOf<>, unlike UnsizedArrayOf<>, has data before the array.
This was confusing. Remove.
Behdad Esfahbod [Fri, 2 Nov 2018 17:26:15 +0000 (13:26 -0400)]
[kern] Comment
Behdad Esfahbod [Fri, 2 Nov 2018 17:23:54 +0000 (13:23 -0400)]
[kern] Push apply loop to each subtable
Behdad Esfahbod [Fri, 2 Nov 2018 16:47:55 +0000 (12:47 -0400)]
[kern] Remove accelerator
It wasn't doing anything.
Behdad Esfahbod [Fri, 2 Nov 2018 16:23:26 +0000 (12:23 -0400)]
Use as_array in more places
Behdad Esfahbod [Fri, 2 Nov 2018 16:14:21 +0000 (12:14 -0400)]
Fix &array_of<>
Behdad Esfahbod [Fri, 2 Nov 2018 16:00:55 +0000 (12:00 -0400)]
Fixup
Behdad Esfahbod [Fri, 2 Nov 2018 15:56:55 +0000 (11:56 -0400)]
[kern] Implement Format3
Untested.
Behdad Esfahbod [Fri, 2 Nov 2018 15:51:21 +0000 (11:51 -0400)]
Add cast operators to hb_array_t
Behdad Esfahbod [Fri, 2 Nov 2018 15:46:24 +0000 (11:46 -0400)]
Add UnsizedArrayOf::as_array() instead of hb_array() template
Behdad Esfahbod [Fri, 2 Nov 2018 15:38:00 +0000 (11:38 -0400)]
Add get_size to UnsizedArrayOf
Behdad Esfahbod [Fri, 2 Nov 2018 15:16:43 +0000 (11:16 -0400)]
[kern] Add buffer message
Behdad Esfahbod [Thu, 1 Nov 2018 22:13:58 +0000 (18:13 -0400)]
[Crap] Avoid operator=
Behdad Esfahbod [Thu, 1 Nov 2018 22:05:22 +0000 (18:05 -0400)]
[aat] Rely on vector auto initialization
Behdad Esfahbod [Thu, 1 Nov 2018 22:01:26 +0000 (18:01 -0400)]
[aat] Remove unused forward declaration
Behdad Esfahbod [Thu, 1 Nov 2018 14:31:12 +0000 (10:31 -0400)]
Warning fix
Ebrahim Byagowi [Thu, 1 Nov 2018 12:01:14 +0000 (15:31 +0330)]
[ot-layout] minor
Ebrahim Byagowi [Thu, 1 Nov 2018 10:09:06 +0000 (13:39 +0330)]
[test] minor
Behdad Esfahbod [Thu, 1 Nov 2018 02:05:53 +0000 (19:05 -0700)]
[aat] Implement 'aalt' mapping
Fixes https://github.com/harfbuzz/harfbuzz/issues/1160