Ben Greear [Tue, 24 Aug 2010 16:30:26 +0000 (18:30 +0200)]
multi: Fix compile warning on 64-bit systems
Dan Fandrich [Mon, 23 Aug 2010 22:07:14 +0000 (15:07 -0700)]
Mention PolarSSL in tutorial & add some URLs to INSTALL
Daniel Stenberg [Sun, 22 Aug 2010 22:36:11 +0000 (00:36 +0200)]
RESUME_FROM: clarify what ftp uploads do
The numerical value passed to CURLOPT_RESUME_FROM for FTP uploads is
interpreted and used as position where to resume the _reading_ of the
local file and it will "blindly" append that data on the remote
file. This was certainly not clear in the docs previously.
Reported by: catalin
Bug: http://curl.haxx.se/bug/view.cgi?id=3048174
Dirk Manske [Fri, 20 Aug 2010 22:29:35 +0000 (00:29 +0200)]
Curl_is_connected: use correct errno
The correctly extracted errno contents were mistakenly overwritten by a newer
value that wasn't the correct error value.
Bug: http://curl.haxx.se/mail/lib-2010-08/0242.html
Daniel Stenberg [Fri, 20 Aug 2010 22:21:24 +0000 (00:21 +0200)]
cmdline: make -F type= accept ;charset=
The -F option allows some custom parameters within the given string, and
those strings are separated with semicolons. You can for example specify
"name=daniel;type=text/plain" to set content-type for the
field. However, the use of semicolons like that made it not work fine if
you specified one within the content-type, like for:
"name=daniel;type=text/plain;charset=UTF-8"
... as the second one would be seen as a separator and "charset" is no
parameter curl knows anything about so it was just silently discarded.
The new logic now checks if the semicolon and following keyword looks
like a parameter it knows about and if it isn't it is assumed to be
meant to be used within the content-type string itself.
I modified test case 186 to verify that this works as intended.
Reported by: Larry Stone
Bug: http://curl.haxx.se/bug/view.cgi?id=3048988
Guenter Knauf [Fri, 20 Aug 2010 01:02:49 +0000 (03:02 +0200)]
Added mk-ca-bundle.vbs script.
The script works exactly same as the Perl one except for one thing:
when the text descriptions generated with openssl are included then
the md5 fingerprints are missing; seems openssl has either a bug or
a feature which prints the md5 fingerprint output to stdout instead
of writing them to specified file; this script could here do the same
as what the Perl scripr does (redirect stdout into file) but this
makes the script take up double the time because it needs to launch
cmd.exe 140 times (fo each openssl call). So I think for now we just
ommit the md5 fingerprints, and see if openssl will be fixed.
Guenter Knauf [Fri, 20 Aug 2010 00:33:29 +0000 (02:33 +0200)]
Trial to fix win32 autobuilds.
It seems that its time to look at some better ideas for the win32
non-configure builds; probably a prebuild target which copies
config-win32.h to curl_config.h and appends also then feature
defines like USE_ARES.
Dan Fandrich [Thu, 19 Aug 2010 18:45:54 +0000 (11:45 -0700)]
Use the S_ISREG macro to determine what is a regular file
Kamil Dudka [Thu, 19 Aug 2010 14:38:22 +0000 (16:38 +0200)]
AC_INIT: avoid a warning with autoconf 2.66
It was complaining about the '=>' operator, introduced in e3fc0d5.
Dan Fandrich [Thu, 19 Aug 2010 06:08:18 +0000 (23:08 -0700)]
Fixed a memory leak during OOM in the multi timeout code
Dan Fandrich [Thu, 19 Aug 2010 05:16:46 +0000 (22:16 -0700)]
Removed a C99ism & made an array const
Julien Chaffraix [Wed, 18 Aug 2010 22:27:04 +0000 (00:27 +0200)]
test: added test 579 to verify progress callback for chunked post
The 66 bytes checked are those 38 bytes with the chunked encoding
headers added: 8+8+10+35+5 = 66
The three-letter words become 8 bytes on the wire because they are sent
like: "3\r\none\r\n"
... and there's the trailing 5 bytes write after the four lines since
the final chunk is sent (which is "0\r\n\r\n").
Daniel Stenberg [Wed, 18 Aug 2010 17:59:46 +0000 (19:59 +0200)]
multi: avoid sending multiple complete messages
I fell over this bug report that mentioned that libcurl could wrongly
send more than one complete messages at the end of a transfer. Reading
the code confirmed this, so I've added a new multi state to make it not
happen. The mentioned bug report was made by Brad Jorsch but is (oddly
enough) filed in Debian's bug tracker for the "wmweather+" tool.
Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593390
Daniel Stenberg [Wed, 18 Aug 2010 17:43:06 +0000 (19:43 +0200)]
FAQ: update the list of supported protocols
Daniel Stenberg [Wed, 18 Aug 2010 14:54:11 +0000 (16:54 +0200)]
FAQ: added blurb about ECCN
"1.13 curl's ECCN number" is a new section mostly made up from
Alessandro Vesely's very informative ML post on the subject:
http://curl.haxx.se/mail/lib-2008-03/0251.html
Guenter Knauf [Wed, 18 Aug 2010 14:08:20 +0000 (16:08 +0200)]
It is sufficient to pipe stderr to NUL to get rid of the nasty messages.
Guenter Knauf [Wed, 18 Aug 2010 13:16:10 +0000 (15:16 +0200)]
Added SSPI build to Watcom makefile.
Julien Chaffraix [Mon, 16 Aug 2010 20:54:19 +0000 (22:54 +0200)]
progress: callback for POSTs less than MAX_INITIAL_POST_SIZE
Add a call to Curl_pgrsSetUploadSize in this case valided by a test
case.
Reported by: Никита Дорохин.
Bug: http://curl.haxx.se/mail/lib-2010-04/0173.html
Dan Fandrich [Mon, 16 Aug 2010 20:36:04 +0000 (13:36 -0700)]
Make the LD_PRELOAD path absolute in the tests that use it
In some situations, libtool will change directories and perform
a link step before executing the libtest test app. Since
LD_PRELOAD is in effect for this entire process, the path to the
binary must be absolute so it will be valid no matter in which
directory the app is running.
Daniel Stenberg [Mon, 16 Aug 2010 20:19:38 +0000 (22:19 +0200)]
negotiation: Wrong proxy authorization
There's an error in http_negotiation.c where a mistake is using only
userpwd even for proxy requests. Ludek provided a patch, but I decided
to write the fix slightly different using his patch as inspiration.
Reported by: Ludek Finstrle
Bug: http://curl.haxx.se/bug/view.cgi?id=3046066
Dan Fandrich [Mon, 16 Aug 2010 19:09:18 +0000 (12:09 -0700)]
Clear stdout and stderr files on each test run
This allows a test to be run several times in the same test
session even when the -k option is given.
Guenter Knauf [Sun, 15 Aug 2010 14:55:02 +0000 (16:55 +0200)]
Syncroniszed vclean target; fixed some comments.
Daniel Stenberg [Sun, 15 Aug 2010 11:59:44 +0000 (13:59 +0200)]
THANKS: added contributors from 7.21.1
Daniel Stenberg [Sun, 15 Aug 2010 11:55:22 +0000 (13:55 +0200)]
multi: two fixes done
Daniel Stenberg [Tue, 10 Aug 2010 12:12:05 +0000 (14:12 +0200)]
multi: use timeouts properly for MAX_RECV/SEND_SPEED
When detecting that the send or recv speed, the multi interface changes
state to TOOFAST and previously there was no timeout set that would
force a recheck but it would rely on the application to somehow call
libcurl anyway. This now sets a timeout for a suitable future time to
check again if the average transfer speed is then below the threshold
again.
Daniel Stenberg [Tue, 10 Aug 2010 09:02:07 +0000 (11:02 +0200)]
multi: support timeouts
Curl_expire() is now expanded to hold a list of timeouts for each easy
handle. Only the closest in time will be the one used as the primary
timeout for the handle and will be used for the splay tree (which sorts
and lists all handles within the multi handle).
When the main timeout has triggered/expired, the next timeout in time
that is kept in the list will be moved to the main timeout position and
used as the key to splay with. This way, all timeouts that are set with
Curl_expire() internally will end up as a proper timeout. Previously any
Curl_expire() that set a _later_ timeout than what was already set was
just silently ignored and thus missed.
Setting Curl_expire() with timeout 0 (zero) will cancel all previously
added timeouts.
Corrects known bug #62.
Daniel Stenberg [Tue, 10 Aug 2010 08:52:26 +0000 (10:52 +0200)]
Curl_llist_insert_next: allow insertion first in the list
When we specify the "insert after" entry as NULL, this function now
inserts the new entry first in the list.
Daniel Stenberg [Sun, 8 Aug 2010 22:01:36 +0000 (00:01 +0200)]
multi: make curl_multi_info_read perform O(1)
Instead of looping over all attached easy handles, this now keeps a list
of messages in the multi handle. It allows curl_multi_info_read() to
perform O(1) no matter how many easy handles that are handled. This is
of importance since this function may be polled very frequently by apps
using the multi interface.
Kamil Dudka [Thu, 12 Aug 2010 19:45:31 +0000 (21:45 +0200)]
curl -T: ignore file size of special files
original bug report at https://bugzilla.redhat.com/622520
Dan Fandrich [Sat, 14 Aug 2010 05:14:26 +0000 (22:14 -0700)]
Reset environment variables before starting servers
Otherwise, variables from tests could affect the servers
themselves.
Kamil Dudka [Thu, 12 Aug 2010 18:45:52 +0000 (20:45 +0200)]
typecheck-gcc: work around gcc upstream bug #32061
original bug report at https://bugzilla.redhat.com/617757
Daniel Stenberg [Wed, 11 Aug 2010 21:57:44 +0000 (23:57 +0200)]
release cycle loop: start over toward 7.21.2
Daniel Stenberg [Wed, 11 Aug 2010 21:35:02 +0000 (23:35 +0200)]
RELEASE-NOTES: mention the runtests fix as well
Daniel Stenberg [Wed, 11 Aug 2010 21:12:39 +0000 (23:12 +0200)]
runtests: clear old setenv remainders before test
Due to the layout of the singletest function there are situations where
it returns before it clears the environment variables that were
especially set for the single specific test case. That could lead to
subsequent tests getting executed with environment variables sticking
around from a previous test which could lead to badness.
This change makes sure to clear all custom variables that may be laying
around from a previous round, before running a test case.
Reported by: Kamil Dudka
Bug: http://curl.haxx.se/mail/lib-2010-08/0141.html
Guenter Knauf [Wed, 11 Aug 2010 16:08:39 +0000 (18:08 +0200)]
Added OpenSSL builds to Watcom makefiles.
Yang Tse [Wed, 11 Aug 2010 12:08:05 +0000 (14:08 +0200)]
configure: werror related adjustments
Daniel Stenberg [Wed, 11 Aug 2010 07:15:43 +0000 (09:15 +0200)]
FAQ: s/libcurl.so.3/libcurl.so.X
Dan Fandrich [Wed, 11 Aug 2010 04:47:10 +0000 (21:47 -0700)]
KNOWN_BUG #59 is fixed. Clarify support of IPv6 zone IDs.
Dan Fandrich [Wed, 11 Aug 2010 04:36:27 +0000 (21:36 -0700)]
Fixed typo in Android configure command
Daniel Stenberg [Tue, 10 Aug 2010 22:50:56 +0000 (00:50 +0200)]
HISTORY: added stuff from recent years
Daniel Stenberg [Tue, 10 Aug 2010 22:06:20 +0000 (00:06 +0200)]
warning: silence the compiler
warning: conversion to 'long int' from 'time_t' may alter its value
... on win64 when time_t is 64bit and long is 32bit.
Daniel Stenberg [Tue, 10 Aug 2010 21:34:03 +0000 (23:34 +0200)]
RELEASE-NOTES: synced, 3 additional bugfixes
Daniel Stenberg [Tue, 10 Aug 2010 21:18:16 +0000 (23:18 +0200)]
multi_socket_action: clarify how to kickstart it
The callbacks are called when curl_multi_socket_action() is called, not
when handles are added. This is now mentioned in the "TYPICAL USAGE"
section.
Daniel Stenberg [Tue, 10 Aug 2010 13:28:46 +0000 (15:28 +0200)]
callbacks: acknowledge progress callback error returns
When the progress callback is called during the TCP connection, an error
return would accidentally not abort the operation as intended but would
instead be counted as a failure to connect to that particular IP and
libcurl would just continue to try the next. I made singleipconnect()
and trynextip() return CURLcode properly.
Added bonus: it corrected the error code for bad --interface usages,
like tested in test 1084 and test 1085.
Reported by: Adam Light
Bug: http://curl.haxx.se/mail/lib-2010-08/0105.html
Guenter Knauf [Tue, 10 Aug 2010 19:27:01 +0000 (21:27 +0200)]
More Watcom makefile fixes ...
Final fix (hopefully!) for dll wlink loader;
prefer faster internal rm if available.
Guenter Knauf [Tue, 10 Aug 2010 15:41:48 +0000 (17:41 +0200)]
Fixed my wrong edit.
Guenter Knauf [Tue, 10 Aug 2010 15:29:06 +0000 (17:29 +0200)]
More Watcom makefile fixes.
Added the -br switch to dynamic builds which fixes the issue I saw
with curl's --version output. Added debug info and symfile for debug
builds to linker opts. Added DLL loader for wlink back, but this time
dependend on wlink version.
Patch posted to the list by malak.jiri AT gmail.com.
Guenter Knauf [Tue, 10 Aug 2010 13:25:48 +0000 (15:25 +0200)]
Changed test for -u switch in order to enable other wmake switches.
The var %MAKEFLAGS is only set in 3 cases: if set as environment
var or as macro definition from commandline, and either with the
-u or -ms switch. Since all these cases are unlikely for the average
user it should be safe to only test if %MAKEFLAGS is defined; this
has the benefit that now all other switches can be used again in
addition to the -u which was formerly not possible.
Daniel Stenberg [Sun, 8 Aug 2010 21:49:49 +0000 (23:49 +0200)]
llist: hide Curl_llist_init
Curl_llist_init is never used outside of llist.c and thus it should be
static. I also removed the protos for Curl_llist_insert_prev and
Curl_llist_remove_next which are functions we removed from llist.c ages
ago.
Guenter Knauf [Tue, 10 Aug 2010 05:10:57 +0000 (07:10 +0200)]
Added msys Perl since git for Win32 comes with own Perl which identifies as msys.
Guenter Knauf [Tue, 10 Aug 2010 03:51:38 +0000 (05:51 +0200)]
Updated lib dependency versions.
Guenter Knauf [Tue, 10 Aug 2010 02:09:35 +0000 (04:09 +0200)]
Make testcurl.pl Watcom-aware.
Daniel Stenberg [Mon, 9 Aug 2010 22:56:45 +0000 (00:56 +0200)]
parse_remote_port: fix ;type= URL suffix over HTTP proxy
Test 563 is enabled now and verifies that the combo FTP type=A URL,
CURLOPT_PORT set and proxy work fine. As a bonus I managed to remove the
somewhat odd FTP check in parse_remote_port() and instead converted it
to a better and more generic 'slash_removed' struct field. Checking the
->protocol field isn't right since when an FTP:// URL is sent over a
HTTP proxy, the protocol is HTTP but the URL was handled by the FTP code
and thus slash_removed is set TRUE for this case.
Daniel Stenberg [Mon, 9 Aug 2010 22:07:06 +0000 (00:07 +0200)]
indent: white space fixes only
Yang Tse [Mon, 9 Aug 2010 11:06:27 +0000 (13:06 +0200)]
build: fix previous push
Yang Tse [Mon, 9 Aug 2010 07:33:53 +0000 (09:33 +0200)]
build: don't build libhostname unless shared libcurl is built
Yang Tse [Mon, 9 Aug 2010 03:45:11 +0000 (05:45 +0200)]
build: libhostname and chkhostname linkage adjustments followup
Daniel Stenberg [Sun, 8 Aug 2010 20:51:37 +0000 (22:51 +0200)]
typo: remove duplicate semicolon
Daniel Stenberg [Sat, 7 Aug 2010 23:06:29 +0000 (01:06 +0200)]
multi: avoid a malloc() when a transfer is complete
The struct used for storing the message for a completed transfer is now
no longer allocated separatly but is kept within the main struct kept
for each easy handle so that we avoid one malloc (and the subsequent
free).
Yang Tse [Sun, 8 Aug 2010 00:58:19 +0000 (02:58 +0200)]
build: libhostname linkage adjustments followup
Guenter Knauf [Sat, 7 Aug 2010 16:32:39 +0000 (18:32 +0200)]
Fix to overwrite libcurl name.
Yang Tse [Sat, 7 Aug 2010 15:39:36 +0000 (17:39 +0200)]
build: chkhostname build adjustments followup
U-D5B1PQ1J\Administrador [Sat, 7 Aug 2010 12:33:14 +0000 (14:33 +0200)]
build: allow NTLM tests to run on more build configurations
Daniel Stenberg [Sat, 7 Aug 2010 12:06:28 +0000 (14:06 +0200)]
curl_easy_setopt.3: rename stream to userdata
In some places where the name 'stream' has been used for naming a
function argument that is in fact settable with a setopt() option we now
call that argument 'userdata' to make it more obvious that it is in fact
possible to set by the application.
Suggested by: Jeff Pohlmeyer
Guenter Knauf [Fri, 6 Aug 2010 23:29:04 +0000 (01:29 +0200)]
Block created curlbuild.h for NetWare to avoid usage from other platforms.
Daniel Stenberg [Fri, 6 Aug 2010 22:24:04 +0000 (00:24 +0200)]
RELEASE-NOTES: synced with recent changes
Yang Tse [Fri, 6 Aug 2010 16:40:13 +0000 (18:40 +0200)]
build: ensure that libhostname doesn't get installed
Daniel Stenberg [Fri, 6 Aug 2010 08:57:44 +0000 (10:57 +0200)]
multi_socket: set timeout for 100-continue
When libcurl internally decided to wait for a 100-continue header, there
was no call to the timeout function so there was no timeout callback
called when the multi_socket API was used and thus applications became
either completely wrong or at least ineffecient depending on how they
handled the situation. We now set a timeout to get triggered.
Reported by: Ben Darnell
Bug: http://curl.haxx.se/bug/view.cgi?id=3039744
Guenter Knauf [Fri, 6 Aug 2010 01:42:18 +0000 (03:42 +0200)]
Some more Watcom makefile massage ...
For now removed the .autodepend directive until I've figured out
which of my changes broke it again.
Yang Tse [Thu, 5 Aug 2010 14:27:39 +0000 (16:27 +0200)]
build: fix libssh2_scp_send64() availability
Yang Tse [Wed, 4 Aug 2010 17:05:09 +0000 (19:05 +0200)]
build: remove unneeded cast to (void *)
Yang Tse [Wed, 4 Aug 2010 16:54:45 +0000 (18:54 +0200)]
build: remove unused file
Daniel Stenberg [Wed, 4 Aug 2010 15:23:38 +0000 (17:23 +0200)]
SCP: send large files properly with new enough libssh2
libssh2 1.2.6 and later handle >32bit file sizes properly even on 32bit
architectures and we make sure to use that ability.
Reported by: Mikael Johansson
Bug: http://curl.haxx.se/mail/lib-2010-08/0052.html
Yang Tse [Tue, 3 Aug 2010 11:09:39 +0000 (13:09 +0200)]
build: add missing new files to non-configure target build files
Yang Tse [Tue, 3 Aug 2010 10:00:32 +0000 (12:00 +0200)]
md4: replace bcopy usage with memcpy
Daniel Stenberg [Mon, 2 Aug 2010 22:00:01 +0000 (00:00 +0200)]
RELEASE-NOTES: synced with recent changes
Daniel Stenberg [Mon, 2 Aug 2010 21:51:56 +0000 (23:51 +0200)]
TODO-RELEASE: clear, file not really used ATM
Daniel Stenberg [Mon, 2 Aug 2010 21:48:21 +0000 (23:48 +0200)]
typecheck-gcc: add checks for recently added options
I added all OBJECTPOINT curl_easy_setopt() options from 178 to 202. Left
to add: the five FUNCTIONPOINT (callbacks) options added since:
SSH_KEYFUNCTION
INTERLEAVEFUNCTION
CHUNK_BGN_FUNCTION
CHUNK_END_FUNCTION
FNMATCH_FUNCTION
Daniel Stenberg [Mon, 2 Aug 2010 21:47:44 +0000 (23:47 +0200)]
.gitignore: ignore all built examples
Daniel Stenberg [Mon, 2 Aug 2010 21:46:24 +0000 (23:46 +0200)]
example: fix code to build warning-free
Daniel Stenberg [Mon, 2 Aug 2010 21:17:30 +0000 (23:17 +0200)]
Curl_connected_proxy: skip the bits.tcpconnect check
Simply because the TCP might be connected already we cannot skip the
proxy connect procedure. We need to be careful to not overload more
meaning to the bits.tcpconnect field like this.
With this fix, SOCKS proxies work again when the multi interface is
used. I believe this regression was added with commit
4b351d018e,
released as 7.20.1.
Left todo: add a test case that verifies this functionality that
prevents us from breaking it again in the future!
Reported by: Robin Cornelius
Bug: http://curl.haxx.se/bug/view.cgi?id=3033966
Daniel Stenberg [Mon, 2 Aug 2010 20:51:24 +0000 (22:51 +0200)]
sethostname: provide local prototype for gethostname
This is only to avoid warnings on some systems.
Daniel Stenberg [Mon, 2 Aug 2010 16:53:03 +0000 (18:53 +0200)]
build: add typecast to avoid warning
There is an implicit conversion from "unsigned long" to "long";
rounding, sign extension, or loss of accuracy may result.
Guenter Knauf [Mon, 2 Aug 2010 10:24:54 +0000 (12:24 +0200)]
Rename CURL_SOURCES macro; revert previous rename of curl_SOURCES macro.
Guenter Knauf [Mon, 2 Aug 2010 03:51:17 +0000 (05:51 +0200)]
Removed ugly dependency lists since wmake knows the .autodepend directive.
Guenter Knauf [Mon, 2 Aug 2010 02:53:17 +0000 (04:53 +0200)]
Use suffix search path for sources in lib folder.
Guenter Knauf [Mon, 2 Aug 2010 00:01:56 +0000 (02:01 +0200)]
Changed src/Makefile.Watcom to use CURL_SOURCES from src/Makefile.inc.
Guenter Knauf [Sun, 1 Aug 2010 23:50:53 +0000 (01:50 +0200)]
Renamed curl_SOURCES to CURL_ALLFILES to overcome wmake's case-insensitivity.
Guenter Knauf [Sun, 1 Aug 2010 23:30:37 +0000 (01:30 +0200)]
Removed wlink from DLL loader list because it doesnt work with Watcom < 1.8.
Guenter Knauf [Sun, 1 Aug 2010 23:24:04 +0000 (01:24 +0200)]
Moved the LDAP API defines from Makefile.Watcom to config-win32.h.
These defines are only needed for older Watcom versions (< 1280).
Daniel Stenberg [Sun, 1 Aug 2010 22:10:18 +0000 (00:10 +0200)]
retry: consider retrying even if -f is used
The --retry logic does retry HTTP when some specific response codes are
returned, but because the -f option sets the CURLOPT_FAILONERROR to
libcurl, the return codes are different for such situations and then the
curl tool failed to consider it for retrying.
Reported by: Mike Power
Bug: http://curl.haxx.se/bug/view.cgi?id=3037362
Daniel Stenberg [Sun, 1 Aug 2010 21:50:46 +0000 (23:50 +0200)]
multi: fix FTPS connecting the data connection with OpenSSL
Commit
496002ea1cd76af7f (released in 7.20.1) broke FTPS when using the
multi interface and OpenSSL was used. The condition for the non-blocking
connect was incorrect.
Reported by: Georg Lippitsch
Bug: http://curl.haxx.se/mail/lib-2010-07/0270.html
Guenter Knauf [Sun, 1 Aug 2010 02:48:29 +0000 (04:48 +0200)]
Fixed curlbuild.h rule.
Guenter Knauf [Sun, 1 Aug 2010 00:39:03 +0000 (02:39 +0200)]
Added rule to create curlbuild.h if not present (for builds from git).
Guenter Knauf [Sat, 31 Jul 2010 22:54:40 +0000 (00:54 +0200)]
Added dependend libs for curl static linking.
Guenter Knauf [Sat, 31 Jul 2010 09:52:05 +0000 (11:52 +0200)]
Fixed curl.exe static linking.
Daniel Stenberg [Fri, 30 Jul 2010 21:19:08 +0000 (23:19 +0200)]
warning: silence a win64 compiler warning
conversion from 'size_t' to 'curl_socklen_t', possible loss of data
Reported by: Adam Light
Daniel Stenberg [Fri, 30 Jul 2010 21:08:17 +0000 (23:08 +0200)]
KNOWN_BUG: The SOCKET type in Win64 is 64 bits
The SOCKET type in Win64 is 64 bits large (and thus so is curl_socket_t
on that platform), and long is only 32 bits. It makes it impossible for
curl_easy_getinfo() to return a socket properly with the
CURLINFO_LASTSOCKET option as for all other operating systems.
Daniel Stenberg [Fri, 30 Jul 2010 20:36:31 +0000 (22:36 +0200)]
smtp_connect: always provide host name buffer
Previously the host name buffer was only used if gethostname() exists,
but since we converted that into a curl private function that function
always exists and will be used so the buffer needs to exist for all
cases/systems.
Daniel Stenberg [Fri, 30 Jul 2010 20:32:57 +0000 (22:32 +0200)]
sethostname: avoid including unistd.h to duck for warnings