Stephen Toub [Fri, 2 Feb 2018 01:15:16 +0000 (20:15 -0500)]
Move ManagedHandler version/chunking validation earlier (dotnet/corefx#26766)
Move it to ManagedHandler.SendAsync rather than HttpConnection.SendAsync so that it happens before we even try to get a connection. A minor benefit of the change as well is that isHttp10 is no longer lifted to the state machine.
Commit migrated from https://github.com/dotnet/corefx/commit/
bb738a07720a8c0888a088f2adb737d2cbe09ca2
Stephen Toub [Fri, 2 Feb 2018 01:07:57 +0000 (20:07 -0500)]
Use TryFormat with spans in a few more places in ManagedHandler (dotnet/corefx#26755)
Commit migrated from https://github.com/dotnet/corefx/commit/
2b4664a53d8a5729343f056ffa82ff5cb4d32d40
Stephen Toub [Fri, 2 Feb 2018 01:07:44 +0000 (20:07 -0500)]
Remove Supports* properties from ManagedHandler (dotnet/corefx#26764)
Commit migrated from https://github.com/dotnet/corefx/commit/
c18664d0d55dad41d00193ac182e292c0c6cd458
Matt Galbraith [Fri, 2 Feb 2018 01:01:24 +0000 (17:01 -0800)]
Merge pull request dotnet/corefx#26723 from MattGal/Update-From-EOL-Linux
Update Linux Versions for test execution
Commit migrated from https://github.com/dotnet/corefx/commit/
cfca3aac61689191888a6d074caca6dad3a95d6c
Pent Ploompuu [Thu, 1 Feb 2018 22:57:03 +0000 (00:57 +0200)]
BigInteger based random testing of Decimal (part 2) (dotnet/corefx#26338)
Commit migrated from https://github.com/dotnet/corefx/commit/
64634c7c7f260a1025d61c7b0523fc522523932c
Matt Galbraith [Wed, 31 Jan 2018 23:26:41 +0000 (15:26 -0800)]
Some cleanups for test execution, in preparation of removing support for running on EOL Linux OSes.
Removals:
Fedora 25 - EOL 12/20/17
OpenSUSE 42.2 - EOL 01/26/18
RedHat 7.2 - EOL 11/30/17
Additions:
OpenSUSE 42.3
Fedora 27
Commit migrated from https://github.com/dotnet/corefx/commit/
3de89a70a1ac81d420543604cf1956818abbe7e8
Stephen Toub [Thu, 1 Feb 2018 22:22:53 +0000 (17:22 -0500)]
Disable Test_Write_Metric_EventListener test (dotnet/corefx#26761)
Commit migrated from https://github.com/dotnet/corefx/commit/
b60c5db080b2fe4c1457cce3acd2647f8ebc4e99
Stephen Toub [Thu, 1 Feb 2018 22:22:00 +0000 (17:22 -0500)]
Use ValueTask shared from corelib (dotnet/corefx#26636)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b6abc253912de3caeddfcb06aa3f619255351f7
Jon Hanna [Thu, 1 Feb 2018 20:23:58 +0000 (20:23 +0000)]
Only search for member types in Microsoft.CSharp member lookup. (dotnet/corefx#26633)
As opposed to nested classes, or type parameters.
Fixes dotnet/corefx#26632
Commit migrated from https://github.com/dotnet/corefx/commit/
9bf574ec5edeb682f46e9635447fe3dc84fc4efa
Stephen Toub [Thu, 1 Feb 2018 18:52:25 +0000 (13:52 -0500)]
Disable Brotli perf tests (dotnet/corefx#26746)
Commit migrated from https://github.com/dotnet/corefx/commit/
033851fe7d545d6e48fe492fe110e5b72c8d2668
Stephen Toub [Thu, 1 Feb 2018 18:52:11 +0000 (13:52 -0500)]
Disable failing NameResolutionPalTests (dotnet/corefx#26747)
Commit migrated from https://github.com/dotnet/corefx/commit/
0bc7246a14c0dea01926ba371009a3a14c557c0b
Lakshmi Priya Sekar [Thu, 1 Feb 2018 18:43:27 +0000 (10:43 -0800)]
Make SslStreamInternal to free resources with SslStream dispose. (dotnet/corefx#26666)
* Make SslStreamInternal to free resources with SslStream dispose.
* Fix framework test.
* Respond to PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
04f0b1eeb4c634b1f41f396244892571e94b5b16
John Doe [Thu, 1 Feb 2018 17:46:48 +0000 (09:46 -0800)]
intecept -> intercept (dotnet/corefx#26742)
* typo
* typo
* Typo
* Typo
* Fix a typo
Commit migrated from https://github.com/dotnet/corefx/commit/
7c4d35b12e16beaf8a10c9d9b304c6b92defcb61
Ben Adams [Thu, 1 Feb 2018 17:40:08 +0000 (17:40 +0000)]
NetworkChange should capture AsyncLocals (but not to Timer) (dotnet/corefx#26073)
* NetworkChange shouldn't capture AsyncLocals into its Timer
* Capture EC on Linux
* Capture EC on OSX
* Feedback/dedupe platforms
* Better null checking
Commit migrated from https://github.com/dotnet/corefx/commit/
60003797de586098f83eea0719d31787b9c2e141
Caesar Chen [Thu, 1 Feb 2018 17:13:32 +0000 (09:13 -0800)]
Update HttpStatusCode enum (dotnet/corefx#26727)
* Update HttpStatusCode enum
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
504781cbfb166c71204b9077c0528623c85cf68c
Tanner Gooding [Tue, 30 Jan 2018 02:24:00 +0000 (18:24 -0800)]
Updating the x86 HWIntrinsic ref assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
90027686dc6ee078ae190bfa471962efeab7a123
dotnet-maestro-bot [Thu, 1 Feb 2018 04:16:04 +0000 (20:16 -0800)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02431-05, preview2-26201-01, preview2-26201-01, preview2-26131-06, beta-26201-00, beta-26201-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
c2c94e2c89c04392fba55e76f97311c3d1a8bf15
Stephen Toub [Thu, 1 Feb 2018 15:42:50 +0000 (10:42 -0500)]
Fix spacing in WebClient tests .csproj
Commit migrated from https://github.com/dotnet/corefx/commit/
c1f7bb9cb3f5490e1477bc13078f074da78c7959
Douglas-Cleghorn [Thu, 1 Feb 2018 15:41:48 +0000 (08:41 -0700)]
WebClient progress monitoring uses ContentLength header (dotnet/corefx#26462)
* WebClient progress monitoring uses ContentLength header
* Added test for download progress
* Fixed build issue
* Set contentLength to zero if the header is zero
* Fixing WebClient async tests
Commit migrated from https://github.com/dotnet/corefx/commit/
3c4115d601335a61d9d170a71bdfb71eb2177beb
Geoff Kizer [Thu, 1 Feb 2018 14:21:36 +0000 (06:21 -0800)]
fix dribble tests when client disconnects on bad request (dotnet/corefx#26730)
Fixes dotnet/corefx#26729
Commit migrated from https://github.com/dotnet/corefx/commit/
6f5d255a76a192906f692fd3d2b9104ab6aeb2f2
Geoff Kizer [Thu, 1 Feb 2018 04:24:58 +0000 (20:24 -0800)]
Merge pull request dotnet/corefx#26708 from geoffkizer/httpretry
ManagedHandler: implement connection retry logic
Commit migrated from https://github.com/dotnet/corefx/commit/
95bfb895707d5756d4b9693286672780f0a6ba02
dotnet-maestro-bot [Thu, 1 Feb 2018 03:03:40 +0000 (21:03 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02430-04, preview2-26130-05, preview2-26130-01, preview2-26129-06, beta-26130-01, beta-26130-01, respectively (master) (dotnet/corefx#26631)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02430-04, preview2-26130-05, preview2-26130-01, preview2-26129-06, beta-26130-01, beta-26130-01, respectively
* Undoing BuildTools update
* Skipping test causing UAP test run to crash for Process
Commit migrated from https://github.com/dotnet/corefx/commit/
39742d3f1eac73898ad1b153141419e1f6e866d0
Tomas Weinfurt [Wed, 31 Jan 2018 23:46:27 +0000 (15:46 -0800)]
add proxy configuration based on environment variables on Unix (dotnet/corefx#26341)
* initial attempt
* remove extra debug message and cleanup.
* take feedabck from reviews
* adress comments from review and add unit tests
* add missing variables to cleanup function
* fix more style and review comments
* updates suggested by geoff
* few more places s/Credientials/Credentials/
* refactor credentials handling
* more fixes to address review feedback
* include HttpProxyConnectionHandler.*.cs only for netcoreapp
Commit migrated from https://github.com/dotnet/corefx/commit/
454220d87dc118a6cb039ef5bd68707de20b79a5
Paulo Janotti [Wed, 31 Jan 2018 23:37:08 +0000 (15:37 -0800)]
Separate basic auth test cases for HttpClientHandler (dotnet/corefx#26713)
Separating the test cases between compliant and non-compliant names. Related to dotnet/corefx#23135
Commit migrated from https://github.com/dotnet/corefx/commit/
62a3d898ceb94227b2b03462b5b09f0a7cd4e3a8
Geoff Kizer [Wed, 31 Jan 2018 23:04:18 +0000 (15:04 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
87ff7479b35c3df7b1a5381447d89c42e2463bc7
Atsushi Kanamori [Wed, 31 Jan 2018 21:49:03 +0000 (13:49 -0800)]
Utf8Parsing - the remaining 'N' format overloads (dotnet/corefx#26683)
* Utf8Parsing - the remaining 'N' format overloads
Fixes https://github.com/dotnet/corefx/issues/24986
This is a piece of the Utf8Parser that was punted for time
last year.
There are 8 overloads for each of the 8 integer types.
Int32 was done in a previous PR - this completes the set.
The "N" format prints out integers like this:
`"N2" => 12,345.00`
This parser mimics the behavior of
`int.TryParse(v, NumberStyles.Integer | AllowThousands | AllowDecimalPoint)`
The thing that may look strange is that the parser
allows commas anywhere, not just on the 10^3 digits.
This mimics the desktop api behavior. Comma placement is
culture-dependent and this is an api that is culture-agnostic.
The test data was confirmed on a control implementation
that calls the classic int.TryParse().
* Added comment
* Fix comment typo
Commit migrated from https://github.com/dotnet/corefx/commit/
efdbbe6ba587a9efb1389f6d090b564f441c7b86
Stephen Toub [Wed, 31 Jan 2018 19:34:24 +0000 (14:34 -0500)]
Fix BoundedChannel.DequeueItemAndPostProcess to respect _doneWriting (dotnet/corefx#26707)
It shouldn't attempt to interact with _blockedWriters/_waitingWriters if _doneWriting has been set.
Commit migrated from https://github.com/dotnet/corefx/commit/
8ae3df0dddc4608b7c03cfcae26a42d4f3deebc8
Stephen Toub [Wed, 31 Jan 2018 19:04:08 +0000 (14:04 -0500)]
Add ValueTask perf tests (dotnet/corefx#26706)
Basic perf tests for ValueTasks.
Commit migrated from https://github.com/dotnet/corefx/commit/
623af48d03bffb857616be5cc9c46a0f19c18cc6
Geoff Kizer [Wed, 31 Jan 2018 18:19:41 +0000 (10:19 -0800)]
Merge pull request dotnet/corefx#26585 from geoffkizer/httpversionhandling
clean up request and response version handling in managed handler
Commit migrated from https://github.com/dotnet/corefx/commit/
2e10ed5418bac7b6b47a407b7efb28ccfcbc9f21
Geoff Kizer [Tue, 30 Jan 2018 06:28:33 +0000 (22:28 -0800)]
implement connection retry logic and related changes
Commit migrated from https://github.com/dotnet/corefx/commit/
64976bf062b6cbc55a3e708dbf7116188d075ff1
Jose Perez Rodriguez [Wed, 31 Jan 2018 17:09:37 +0000 (09:09 -0800)]
Building non-Windows builds using the CLI's MSBuild (dotnet/corefx#26686)
Commit migrated from https://github.com/dotnet/corefx/commit/
363599c0e29a5843031f5360d1b114a5ac088805
Jan Kotas [Wed, 31 Jan 2018 16:57:17 +0000 (08:57 -0800)]
Replace JitIntrinsicAttribute with IntrinsicAttribute (dotnet/corefx#26700)
* Replace JitIntrinsicAttribute with IntrinsicAttribute
* Use s_ prefix for statics
Commit migrated from https://github.com/dotnet/corefx/commit/
9885497081a1bc58d2645d99aa4ed8b3bd303ee7
Ben Adams [Wed, 31 Jan 2018 16:04:48 +0000 (16:04 +0000)]
Activity shouldn't capture AsyncLocals into its Timer (dotnet/corefx#26071)
* Activity shouldn't capture AsyncLocals into its Timer
* SecuritySafeCritical
* feddback
Commit migrated from https://github.com/dotnet/corefx/commit/
54d3e65708a9c20d11c6d6164f63a249ebca5aa5
Stephen Toub [Wed, 31 Jan 2018 14:04:36 +0000 (09:04 -0500)]
Remove ValueTask<T>.CreateAsyncMethodBuilder from ref (dotnet/corefx#26703)
Commit migrated from https://github.com/dotnet/corefx/commit/
9ba6220b3d8846d7c5bb1a28b9c3fb10270a98a3
Marco Rossignoli [Wed, 31 Jan 2018 13:51:42 +0000 (14:51 +0100)]
Add new MediaTypeNames (dotnet/corefx#26701)
* add new types
* fix MembersMustExist
Commit migrated from https://github.com/dotnet/corefx/commit/
9e1b3345b8414ab17366bdf2d48369d796daf394
Anirudh Agnihotry [Wed, 31 Jan 2018 06:54:03 +0000 (22:54 -0800)]
Follow up changes For serviceBase (dotnet/corefx#26695)
Commit migrated from https://github.com/dotnet/corefx/commit/
530fb9e84dd9e24b085dc63ceb0810cf719e6c8f
Michal Strehovský [Wed, 31 Jan 2018 06:50:22 +0000 (07:50 +0100)]
Add test coverage for Type.GetInterfaceMap (dotnet/corefx#26679)
Commit migrated from https://github.com/dotnet/corefx/commit/
6cd7e55e1a3fc7b2890023483e319f39bfb34c35
Jeremy Barton [Wed, 31 Jan 2018 06:30:13 +0000 (22:30 -0800)]
Make AsnSerializer resiliant to ILC reflection rules
AsnSerializer had two different paths which checked for ordered fields, one
which used the MetadataToken and one which didn't. The MetadataToken
method is more reliable, but is not available on ILC.
With this change
* MetadataToken is used when available, and we hope for the best otherwise.
* The two paths now use the same resolution, so future algorithms apply evenly
* The results are cached, so we only sort once per type
Commit migrated from https://github.com/dotnet/corefx/commit/
035305b0b4cc598f0acfe435f93d523bddd523c1
Gene Lee [Wed, 31 Jan 2018 04:26:44 +0000 (20:26 -0800)]
Fixed ReadAsync blocking issue (dotnet/corefx#26595)
Commit migrated from https://github.com/dotnet/corefx/commit/
da8a105c39ce4b10406c2da5dfce19269293942b
Ben Adams [Wed, 31 Jan 2018 01:22:22 +0000 (01:22 +0000)]
Don't capture AsyncLocals into ODBC Global Timers (dotnet/corefx#26066)
Commit migrated from https://github.com/dotnet/corefx/commit/
48525389b9e8957b3bb527edd6b7f149c4af6c11
Dan Moseley [Wed, 31 Jan 2018 01:12:29 +0000 (01:12 +0000)]
Missing guid from two interop types (dotnet/corefx#26688)
* Add missing Guids to two interfaces
* Curly
Commit migrated from https://github.com/dotnet/corefx/commit/
ec353e2e18007f36a5a192bf08f97e9826509a8c
Josh Free [Tue, 30 Jan 2018 23:12:53 +0000 (15:12 -0800)]
Add System.IO.Pipelines
Add new section for System.IO.Pipelines
Commit migrated from https://github.com/dotnet/corefx/commit/
21486567a754e580dc1c058b97ac42b875f3d80e
Tarek Mahmoud Sayed [Tue, 30 Jan 2018 23:09:58 +0000 (15:09 -0800)]
Remove Unbuffer Channel (dotnet/corefx#26689)
Commit migrated from https://github.com/dotnet/corefx/commit/
1f8e408e7f2b0681056d1cac55b3ccc5586e8995
Josh Free [Tue, 30 Jan 2018 22:58:18 +0000 (14:58 -0800)]
Add System.Threading.Channels
Add new section for System.Threading.Channels
Commit migrated from https://github.com/dotnet/corefx/commit/
873d4ee2d5dcb173f5fb592edbc9f1c9a0eebe1a
Santiago Fernandez Madero [Tue, 30 Jan 2018 22:27:57 +0000 (14:27 -0800)]
Update servicemodel dependencies to latest stable version (dotnet/corefx#26281)
Commit migrated from https://github.com/dotnet/corefx/commit/
5494ff2ea60503fe739443c3c8d52df6eebe2bf5
Eric Erhardt [Tue, 30 Jan 2018 21:44:49 +0000 (15:44 -0600)]
Move Vector<T> to the shared CoreLib partition. (dotnet/corefx#26656)
* Move Vector<T> to the shared CoreLib partition.
This is in support of eventually compiling it into System.Private.CoreLib. That way we can use it in other corelib algorithms.
* Update Test project to link to new CoreLib file path
Commit migrated from https://github.com/dotnet/corefx/commit/
6aa7ebdcb444c05449c9e14c66eb38f13826bfc7
Paulo Janotti [Tue, 30 Jan 2018 21:26:09 +0000 (13:26 -0800)]
Make redirect test case really 'redirect' (dotnet/corefx#26674)
The test case was redirecting to the same URL this was bringing instability with the handlers (more with the managed). This change should make the test more reliable, as such moving it to inner loop.
Fixes dotnet/corefx#23769
Since no action is planned for dotnet/corefx#26434 this also closes dotnet/corefx#26434
Commit migrated from https://github.com/dotnet/corefx/commit/
3b69635f25636377841ded02de254eacec6e3728
Paulo Janotti [Tue, 30 Jan 2018 21:06:51 +0000 (13:06 -0800)]
Http protocol dribble tests taking two long (dotnet/corefx#26680)
The time of inner loop is dominated by the http protocol dribble tests.
Returning the Task.Delay to Task.Yield reduces it from ~19 seconds to less than a second on a Windows 10 RS3 box.
Commit migrated from https://github.com/dotnet/corefx/commit/
179cf080901f8f7f4e5499b80ad393b7370eef40
Lakshmi Priya Sekar [Tue, 30 Jan 2018 18:35:11 +0000 (10:35 -0800)]
Merge pull request dotnet/corefx#26625 from wfurt/fix_26599
make opaque parameter optional for digest auth
Commit migrated from https://github.com/dotnet/corefx/commit/
dee052ff7c5b49af357678f40afe97e4f2bd0940
Santiago Fernandez Madero [Tue, 30 Jan 2018 18:10:58 +0000 (10:10 -0800)]
Add netfx placeholder configuration to System.Data.DataSetExtensions (dotnet/corefx#26576)
* Add netfx placeholder configuration to System.Data.DataSetExtensions
* Update System.Data.DataSetExtensions key to match Desktop public key
Commit migrated from https://github.com/dotnet/corefx/commit/
451824f7d2c0679888b2d4acd541795de9f8a7f7
Anirudh Agnihotry [Tue, 30 Jan 2018 17:38:16 +0000 (09:38 -0800)]
ServiceBase And ServiceController Tests using NamedPipes (dotnet/corefx#26524)
ServiceBase And ServiceController tests using NamedPipes
Commit migrated from https://github.com/dotnet/corefx/commit/
c78d3d4f1879e5b0bf3c58edf5baefdc9cdb4e1c
Ben Adams [Tue, 30 Jan 2018 15:15:54 +0000 (15:15 +0000)]
Don't capture AsyncLocals into EventCounter timer (dotnet/corefx#26075)
* Don't capture AsyncLocals into EventCounter timer
* Harden Flow suppression
* Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
bcc2940faeb58cc92a66c61ca404bed54a3a3bb3
Ian Hays [Tue, 30 Jan 2018 13:36:57 +0000 (05:36 -0800)]
Use ToArray based debuggerview for portable span (dotnet/corefx#26661)
* Use ToArray based debuggerview for portable span
* Fix Ordering for System.Memory csproj include
Commit migrated from https://github.com/dotnet/corefx/commit/
4a57e8045ff5f9eff5f7b17778785f7790589bec
Jeremy Barton [Tue, 30 Jan 2018 13:30:28 +0000 (05:30 -0800)]
Make Linux and macOS throw the same exception on unknown hash algorithms (dotnet/corefx#26648)
Currently Linux throws CryptographicException with a default message, and
macOS throws a PNSE with a message.
This normalizes them to throw CryptographicException with a message.
Windows NetFX throws CryptographicException(NTE_BAD_ALGID), and CoreFx
behaves similarly.
Commit migrated from https://github.com/dotnet/corefx/commit/
34709c597cb88ff7ff7f270a7a020d681b2deb61
Ben Adams [Tue, 30 Jan 2018 13:28:12 +0000 (13:28 +0000)]
Don't capture AsyncLocals into SQL global timers (dotnet/corefx#26065)
* Don't capture AsyncLocals into SQL global timers
* Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
093126c7219819f1acd500331a733d1bba4ce17f
Günther Foidl [Tue, 30 Jan 2018 12:44:52 +0000 (13:44 +0100)]
Stack<T> optimization of (Try)Peek, (Try)Pop and Push (dotnet/corefx#26086)
* Stack.Pop RCE
With value types the effect is not so big, because there is still one (manual) check for bounds.
For reference types one bounds-check can be saved, so there is a win.
* Applied same optimizations as for Pop on Peek, TryPeek, TryPop, Push
* Revert change for Push
I can't see a real win, sometimes it's faster and sometimes slower. On Linux the tendency is to be slower.
Therefore the state as is will be remained.
* Stack.Push with hot-/cold-path (PushWithResize)
* Addressed PR feedback
Cf. https://github.com/dotnet/corefx/pull/26086#discussion_r158987900
* Array-copy in Peek is not necessary, JIT can do the same
As of PR-feedback https://github.com/dotnet/corefx/pull/26086#discussion_r159071441
* Reverted b0bfd83
Cf. https://github.com/dotnet/corefx/pull/26086#issuecomment-
357314683
* Addressed PR feedback
Cf. https://github.com/dotnet/corefx/pull/26086#discussion_r164453817
Commit migrated from https://github.com/dotnet/corefx/commit/
36ae61031f94c7d92ce8750c088bfa640b5ccb1e
Günther Foidl [Tue, 30 Jan 2018 09:55:08 +0000 (10:55 +0100)]
Queue<T> optimization of (Try)Dequeue (dotnet/corefx#26087)
* Queue RCE
With value types the effect is not so big, because there is still one (manual) check for bounds.
For reference types one bounds-check can be saved, so there is a win.
In MoveNext the conditional is with if, so the JIT can produce better code.
* MoveNext uses temp-Variable for register access instead of memory access
* Addressed PR feedback
* https://github.com/dotnet/corefx/pull/26087#pullrequestreview-
92229686
* https://github.com/dotnet/corefx/pull/26087#pullrequestreview-
92229910
Commit migrated from https://github.com/dotnet/corefx/commit/
fc7cd1bf8eb8406b84cc995cfe225fa41f46d0ee
Tomas Weinfurt [Tue, 30 Jan 2018 01:14:05 +0000 (17:14 -0800)]
merge positive and negative test to one. add more test cases
Commit migrated from https://github.com/dotnet/corefx/commit/
6457d8102bc6527b8a5277c7cc4838a497cf2e48
Tomas Weinfurt [Tue, 30 Jan 2018 00:26:52 +0000 (16:26 -0800)]
update from reviews. refactor opaque handling, make realm mandatory and add negative test case.
Commit migrated from https://github.com/dotnet/corefx/commit/
dd1d93fc8a25343ab15360e368a0c7d900355c34
Cory Rivera [Mon, 29 Jan 2018 23:18:10 +0000 (15:18 -0800)]
Add try-finally statements around AbortTransaction calls in SqlBulkCopy, so that parser locks always get released. (dotnet/corefx#26649)
Commit migrated from https://github.com/dotnet/corefx/commit/
5b5eacfce3a62712ceb67dfb51128221b0fce137
Ian Hays [Mon, 29 Jan 2018 23:01:25 +0000 (15:01 -0800)]
Consume Span moves (dotnet/corefx#26467)
Consume Span moves
- [Move Span.DangerousCreate to MemoryMarshal.CreateSpan](dotnet/corefx#26139)
- [Move ReadOnlySpan.DangerousCreate to MemoryMarshal.CreateReadOnlySpan](dotnet/corefx#26139)
- [Move Span.NonPortableCast to MemoryMarshal.Cast](dotnet/corefx#26368)
- [Move ReadOnlySpan.NonPortableCast to MemoryMarshal.Cast](dotnet/corefx#26368)
- [Add ToString override to Span and ReadOnlySpan](dotnet/corefx#26295)
- [Add ToEnumerable function to MemoryMarshal that takes a Memory](dotnet/corefx#24854)
Commit migrated from https://github.com/dotnet/corefx/commit/
540a99ce273265ba62a25b48c696d2d506c88ab4
Jeremy Barton [Mon, 29 Jan 2018 19:00:59 +0000 (11:00 -0800)]
Make ProtectedData function on empty input
In .NET Framework the implementation used GCHandle.Alloc, which does not
normalize an empty array to null. In .NET Core the implementation uses fixed,
which does normalize empty to null. Since the Win32 API rejects null inputs,
map empty to some other array for the duration of the call.
Commit migrated from https://github.com/dotnet/corefx/commit/
7590642a7a40594136f0f91555704781c49587da
Jon Hanna [Mon, 29 Jan 2018 21:50:48 +0000 (21:50 +0000)]
Fix regression in Microsoft.CSharp on accessing accessors or operators (dotnet/corefx#26620)
Correct incorrectly inverted if test so accessor methods are allowed
iff they are on parametrised properties.
Fixes dotnet/corefx#26619
Commit migrated from https://github.com/dotnet/corefx/commit/
4f8c637f0f7f0a4b313e2b0bc4101bd30d669704
Geoff Kizer [Mon, 29 Jan 2018 21:31:18 +0000 (13:31 -0800)]
fix CurlHandler test for 2.0 response
Commit migrated from https://github.com/dotnet/corefx/commit/
b91b6c63aa3678ba707a9900b64eea9f8e0a6d00
Stephen Toub [Mon, 29 Jan 2018 20:36:45 +0000 (15:36 -0500)]
Replace TryCopyTo with CopyTo (dotnet/corefx#26641)
While doing various Span-related work involving copying, in a few places I previously used a pattern of calling TryCopyTo and then asserting its result, in places where I knew the destination was long enough. This was because CopyTo was implemented as a wrapper around TryCopyTo and thus involved an extra unnecessary branch. Now that that's no longer the case, I'm simplifying the call sites.
cc: @GrabYourPitchforks
Commit migrated from https://github.com/dotnet/corefx/commit/
b3ad6ab802bc7fd050b2bfb2381ff525ac370594
Saurabh Singh [Mon, 29 Jan 2018 20:33:27 +0000 (12:33 -0800)]
Disable the DiagnosticTest on Framework (dotnet/corefx#26645)
* Disable the DiagnosticTest on Framework because the feature is not available
* Fixing comments
Commit migrated from https://github.com/dotnet/corefx/commit/
dfd9d7649c7c5c79e9af54bb5e854a2b2e60f345
Stephen Toub [Mon, 29 Jan 2018 19:17:31 +0000 (14:17 -0500)]
Remove several faulty System.Drawing.Common printer default tests (dotnet/corefx#26639)
Several printer-related tests in System.Drawing.Common are validating defaults that are actually based on system settings that are influenced by if and what printer(s) you have. On my machine, where I have a printer attached, this causes a handful of tests to fail. Since the tests assume defaults only in the context of no printer attached, the tests are invalid and I'm removing them. There are likely to be other tests as well that should be removed for a similar reason, but I've only removed enough so that the suite passes on my machine.
Commit migrated from https://github.com/dotnet/corefx/commit/
450cad853b7c555286cec23564b47ec6853338f3
Levi Broderick [Mon, 29 Jan 2018 18:55:48 +0000 (10:55 -0800)]
Add more tests for Span.CopyTo (dotnet/corefx#26609)
Add extra tests for Span.CopyTo
Commit migrated from https://github.com/dotnet/corefx/commit/
949129f1a94c2d1290aeded32742a9a41193dac7
Stephen Toub [Mon, 29 Jan 2018 17:01:12 +0000 (12:01 -0500)]
Use corelib-shared ValueStringBuilder
Use the shared version, delete the copy.
Commit migrated from https://github.com/dotnet/corefx/commit/
3d1ebc18c356b03039d24c29939dae374c64b4a5
Thiez [Mon, 29 Jan 2018 18:40:24 +0000 (19:40 +0100)]
Fix various issues with System.Json.JsonValue.Save (dotnet/corefx#26502)
* Fix various issues with System.Json.JsonValue.Save
The `JsonObject` class overrides `JsonValue.Save(Stream)`, but was
implemented incorrectly: it would produce output resembling
`{"key1","value1""key2","value2"}`, instead of the more reasonable
`{"key1": "value1", "key2": "value2"}`. Because `JsonValue` already
contains code that can properly serialize a `JsonObject`, the override
now simply calls the base method.
In addition, it turns out that the `JsonValue.Save(Stream)` method was
also implemented incorrectly. This method would invoke
`JsonValue.Save(TetxtWriter)`, but the `StreamWriter` it created was never
flushed or disposed, so output could go missing. In addition, it would
encode json as utf-8, but would include a BOM, while none of the methods
that override `JsonValue.Save(Stream)` would write a BOM. Both these
issues have been resolved.
The tests have also been modified to test for the new and correct
behavior.
* PR fixes
* Add reference to System.Text.Encoding.Extensions
Commit migrated from https://github.com/dotnet/corefx/commit/
97af4b48b310252622b62b02124aef4fd8796983
Atsushi Kanamori [Mon, 29 Jan 2018 18:09:37 +0000 (10:09 -0800)]
Utf8Parsing for Int32 'N' format (dotnet/corefx#26635)
https://github.com/dotnet/corefx/issues/24986
This is a piece of the Utf8Parser that was punted for time
last year.
There are 8 overloads for each of the 8 integer types.
This PR only covers Int32. I'm putting this through
by itself for this PR so I don't have to apply every PR
feedback in octuplicate.
The "N" format prints out integers like this:
`"N2" => 12,345.00`
This parser mimics the behavior of
`int.TryParse(v, NumberStyles.Integer | AllowThousands | AllowDecimalPoint)`
The thing that may look strange is that the parser
allows commas anywhere, not just on the 10^3 digits.
This mimics the desktop api behavior. Comma placement is
culture-dependent and this is an api that is culture-agnostic.
The test data was confirmed on a control implementation
that calls the classic int.TryParse().
Commit migrated from https://github.com/dotnet/corefx/commit/
3f3e8ec9a8de7a53a4a2306024bed1039cb8ae1f
Eric Erhardt [Mon, 29 Jan 2018 16:41:27 +0000 (10:41 -0600)]
Support Process.Start as a different user on Unix. (dotnet/corefx#26431)
* Support Process.Start as a different user on Unix.
The most common use case is to de-escalate privileges from a privileged process to a normal process.
Part of dotnet/corefx#26268
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
4464cceace7615502a1003bc7488f206a47c82ee
Jeremy Barton [Mon, 29 Jan 2018 16:01:55 +0000 (08:01 -0800)]
Fix IO error handling for adding certs to X509Store on Linux
If a directory was readonly then UnauthorizedAccessException was being thrown
and not handled by opportunistic caching, so caching now won't fail on that
exception.
Other tests being run after
mv ~/.dotnet{,-sav}
chmod u-w ~
showed that the exception model wasn't very tight, so now all rogue
exceptions from X509Store.Add will be wrapped in CryptographicException.
This better matches Windows and macOS where a CryptographicException
is raised to interpret a failed NTSTATUS/HRESULT/OSStatus.
Commit migrated from https://github.com/dotnet/corefx/commit/
36664b188d15e3cf517bd390c212fc14ff03a74d
dotnet-maestro-bot [Mon, 29 Jan 2018 13:31:19 +0000 (07:31 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02427-01, preview2-26129-01, preview2-26127-04, preview2-26128-03, beta-26129-00, beta-26129-00, respectively (dotnet/corefx#26605)
Commit migrated from https://github.com/dotnet/corefx/commit/
209559e78f720c855a87e02ec876a6e0c8519c3e
Tomas Weinfurt [Mon, 29 Jan 2018 06:43:47 +0000 (22:43 -0800)]
make opaque parameter optional
Commit migrated from https://github.com/dotnet/corefx/commit/
a623ebc34fd63d85b65af7ed91a967d37cf1d906
Jon Hanna [Mon, 29 Jan 2018 04:41:48 +0000 (04:41 +0000)]
Remove skeletal caching from ExprVisitorBase (dotnet/corefx#26534)
Methods exist to build caching layer out of, but without actually
implementing it. Any such cache would almost never have a cache hit, so
remove it.
Commit migrated from https://github.com/dotnet/corefx/commit/
f8c403f7b05daf4b7f07d4b45ac7ee7f2372abfb
Jon Hanna [Mon, 29 Jan 2018 03:55:30 +0000 (03:55 +0000)]
Remove orphaned methods from Microsoft.CSharp (dotnet/corefx#26491)
* Switch on MethodSymbol.MethKind instead of repeated tests.
And make it a property.
* Make isConversionOperator an assertion and remove isExplicit
isExplicit is only used to assert the symbol is a conversion, so make
the method itself an assertion property.
* Use binary MethWithType ctor
Rather than the nullary, only to set properties.
* Make UdConvInfo a readonly struct
* Remove orphaned methods.
Commit migrated from https://github.com/dotnet/corefx/commit/
dd36a83508c2c7a11261a531fb9dfe348cace4eb
Jon Hanna [Mon, 29 Jan 2018 03:45:05 +0000 (03:45 +0000)]
Refactor Microsoft.CSharp's SubstContext (dotnet/corefx#26489)
* Remove SubstTypeFlags.NoRefOutDifference
Looked for, but never set.
* Remove SubstTypeFlags.DenormClass
Looked for, but never set.
* Remove SubstTypeFlags.Norm*
Looked for, but never set.
* Remove _stvcClass
No longer used.
* Move init into ctor and make fields readonly
* Remove unused ctors
* Remove counts from SubsContext
Just get them from the arrays.
* FNop() method to IsNop property
* Rename context's arrays
Non-Hungarian based.
* Remove SubstTypeFlags
Only two values in use, so use boolean.
* Remove denormMeth argument to SubstEqualTypeArrays
Always true
* Remove most uses of context in ErrAppendType
Instead of setting to null, just use null.
* Remove paths in SubstType for null typeSrc
Never happens. (And if it did, it would safely have the same result).
Commit migrated from https://github.com/dotnet/corefx/commit/
275b172426b42c152ee359601197aeb64f3e8b28
Caesar Chen [Sat, 27 Jan 2018 23:11:55 +0000 (15:11 -0800)]
Make sure HttpListenerContext will not deallocate twice (dotnet/corefx#26596)
* avoid double free
* protect httpContext with Interlocked
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ab0e5a0a81f6fa221d5cc12ef019f3175e9707bb
Gene Lee [Sat, 27 Jan 2018 00:45:34 +0000 (00:45 +0000)]
removed active issue tag on unit tests (dotnet/corefx#26409)
Commit migrated from https://github.com/dotnet/corefx/commit/
07774350dff82d5acc3342e50b84908ad4d68ff2
Jon Hanna [Fri, 26 Jan 2018 23:12:32 +0000 (23:12 +0000)]
Avoid cast of Microsoft.CSharp's binder types. (dotnet/corefx#26565)
Bind casts from DynamicMetaObjectBinder (base of all the C# binders) to
ICSharpBinder (implemented by all C# binders), but adding ReturnType to
ICSharpBinder allows that type to be used throughout.
Since ReturnType is virtual anyway there's no extra cost on the call,
and the type safety can now be statically confirmed rather than just
asserted.
Commit migrated from https://github.com/dotnet/corefx/commit/
3b2666a7aed005c98fcb4f8ca5245c9459be311f
Maryam Ariyan [Fri, 26 Jan 2018 22:44:08 +0000 (17:44 -0500)]
Adding EnsureCapacity API to Dictionary and Adding Tests (dotnet/corefx#26158)
Commit migrated from https://github.com/dotnet/corefx/commit/
7decb192287cf6fbfd9701c8a28d722c6c5f3680
Jon Hanna [Fri, 26 Jan 2018 22:31:53 +0000 (22:31 +0000)]
Refactor MS.CSharp's CType (dotnet/corefx#26414)
* Remove name from CType.
Only used in TypeParameterType, and there can be done by delegating to
symbol.
* Make CType.Get/SetTypeKind init-only property.
* Have singleton CTypes control their own singleton instances.
* Initial AggregateType state as init-only properties
* TypeParameterType state to init-only property.
All other getter methods to properties.
* ArrayType state as auto-properties.
Other getter method as property.
* PointerType state to init-only auto-properties.
* ParameterModifierType state to init-only auto properties
* NullableType state to init-only auto properties.
* Remove TypeFactory
No state or returning of derived types to benefit from factory pattern.
* Don't use names in TypeTable lookups.
The names are created to reflect properties of the type, but just use
the values of those properties directly.
* Don't branch on result of TryGet within TypeTable
In case of failure out parameter is guaranteed to be null, so no need
to branch just to return null.
* Replace getAggregate() calls with OwningAggregate where feasible.
Avoid cast, or move cast closer to where it is deemed safe. Greater
type-safety.
* CType IsRefType() to virtual property.
* IsNonNubValType() and IsValType() to virtual properties
* IsStaticClass() to virtual member.
Note that while in source code an array, parameter modifier or pointer
can be of a static type due to an error in the source, these types can
never be static in dynamic code.
* Remove arguments to CheckForStaticClass that are always the same.
* isPredefined and getPredefType to virtual properties.
* isPredefType() to virtual instead of type-testing.
* isUnsafe to virtual instead of type-testing.
* Several Aggregate-only methods to virtual properties.
* Move IsCollectionType to only derived type that uses it.
Optimise to skip tests it can't pass.
* Make AssociatedSystemType virtual instead of testing types.
Only memoise in AggregateType as it's not as expensive elsewhere.
* Make GetBaseOrParameterOrElementType virtual property.
* IsWindowsRuntimeType to property.
* Remove underlyingType()
All uses can be safely replaced with UnderlyingEnumType and name
clashes with UnderlyingType property elsewhere.
* Remove more uses of getAggregate()
One is within a branch for a test that is only true for AggregateTypes.
Another goes from an enum to the underlying before using
Type.GetTypeCode() on the system type, but Type.GetTypeCode() will
behave the same on the enum type anyway.
* IsUnsigned to virtual property.
* fundType() to virtual property
* constValKind to virtual property.
* AggregateType.GetIfacesAll to property.
* AggregateType.GetBaseClass to property
* Remove CheckConstraintsFlags.NoDupErrors
Checked for, but never set.
* Merge AggregateType.fConstraintsChecked and fConstraintError into bool?
* Don't recheck constraints if exception not necessary.
Akin to the removed NoDupErrors but where that prevented repeated
messages in a static compilation, with dynamic code we can depend on
the cached value from previous operations.
* Change field names to not use Hungarian notation.
* Short-circuit on constraints checking.
The non–short-circuiting behaviour is a legacy of the times the static
compiler would want to emit multiple error messages. The dynamic
compiler will already short-circuit for error-emitting cases as the
exception will cut the operation short, but it should also short-
circuit for non–error-emitting cases too.
* Pick nit.
Commit migrated from https://github.com/dotnet/corefx/commit/
16b3b70e2eee62e9121b0466103dd97f5aa00f7a
dotnet-maestro-bot [Fri, 26 Jan 2018 19:20:33 +0000 (13:20 -0600)]
Update CoreClr, ProjectNTfs, ProjectNTfsTestILC to preview2-26126-07, beta-26126-00, beta-26126-00, respectively (dotnet/corefx#26597)
Commit migrated from https://github.com/dotnet/corefx/commit/
4a7ed53ccb31de796b6dbe579326994f8fa74120
Geoff Kizer [Thu, 25 Jan 2018 20:23:55 +0000 (12:23 -0800)]
update tests to correctly test existing behaviors of different handlers
Commit migrated from https://github.com/dotnet/corefx/commit/
380f45c16b952d5064002de0d8e936a38a49d276
dotnet-maestro-bot [Fri, 26 Jan 2018 04:03:56 +0000 (22:03 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02425-02, preview2-26125-07, preview2-26126-03, preview2-26125-06, beta-26125-01, beta-26125-01, respectively (dotnet/corefx#26551)
Commit migrated from https://github.com/dotnet/corefx/commit/
847e5204861639ca321adfa243896062ebb037c7
Tanner Gooding [Thu, 18 Jan 2018 23:58:40 +0000 (15:58 -0800)]
Adding the `Vector64<T>` type to the S.R.Intrinsics assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
2cdb8eb02ed7f8de8a6c7336763e727d287c1599
Caesar Chen [Thu, 25 Jan 2018 23:57:38 +0000 (15:57 -0800)]
Enable some HttpProtocolTests test cases and skip them on .NET Core Windows run (dotnet/corefx#26573)
* split test cases
* disable against CurlHandler as well
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
e274885db32ec40b327ed4dcb3439aca41d29844
Atsushi Kanamori [Thu, 25 Jan 2018 23:53:08 +0000 (15:53 -0800)]
PR feedback (dotnet/corefx#26563)
Commit migrated from https://github.com/dotnet/corefx/commit/
a3986843153e27e92c89907f58046bb37da0f9eb
Ahson Khan [Thu, 25 Jan 2018 21:28:17 +0000 (13:28 -0800)]
String-like Span extension methods - Trim / IsWhiteSpace (dotnet/corefx#26560)
* String-like Span extension methods - Trim / IsWhiteSpace
* Vectroized implementation and add tests
* Test clean up and improve code coverage
* Optimize Trim() and move helpers to SpanHelpers.char.cs
* Addressing PR feedback
* Revert back to the naiive impl for IsWhiteSpace and Trim
* Remove length == 0 checks and vector code from IsWhiteSpace/Trim(char)
* Fix test nits
* Revert back to old impl of Trim(ReadOnySpan<char> trimChars)
* Replace break with goto
* Fix goto bug - use while loop
* Fix nit in for loop
* Change back to using for loop
Commit migrated from https://github.com/dotnet/corefx/commit/
92df6949f01350fce829fc4cc64797c47cc596a9
Tarek Mahmoud Sayed [Thu, 25 Jan 2018 21:22:42 +0000 (13:22 -0800)]
Fix some Channel issues (dotnet/corefx#26570)
* Fix some Channel issues
These issues caught during the code review of the Channel code.
* Fix reader waiter waking inside the lock
* Addressing the feedback
* tag the problematic line of code with the tracking issue
* revert BoundedChannel changes
* remove empty lines
Commit migrated from https://github.com/dotnet/corefx/commit/
b8a15a768b8255096fc87dd9cb9f33cdb4a25208
Geoff Kizer [Thu, 25 Jan 2018 20:22:33 +0000 (12:22 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
7ec77a68174759e3d04b242e2c82cdb30055c9c3
Geoff Kizer [Thu, 25 Jan 2018 07:17:21 +0000 (23:17 -0800)]
clean up request and response version handling in managed handler, and add tests
Commit migrated from https://github.com/dotnet/corefx/commit/
a1bf78551ff6de29ea02837a21620000886b2828
Geoff Kizer [Thu, 25 Jan 2018 05:47:48 +0000 (21:47 -0800)]
Merge pull request dotnet/corefx#26511 from geoffkizer/mischttp1
Several small ManagedHandler fixes
Commit migrated from https://github.com/dotnet/corefx/commit/
25c4a916bf1f35be1d009b679b19f7ebea535647
Krzysztof Wicher [Thu, 25 Jan 2018 00:46:14 +0000 (16:46 -0800)]
Regression test for AM/PMDesignator handling (dotnet/corefx#26436)
* Regression test for AM/PMDesignator handling
* skip on netfx (needs port)
Commit migrated from https://github.com/dotnet/corefx/commit/
d22340ec3d1ad5854eb694e3f04729a9ec496721
Santiago Fernandez Madero [Wed, 24 Jan 2018 22:48:37 +0000 (14:48 -0800)]
Add netfx placeholder configurations for inbox projects and enable netfx tests (dotnet/corefx#26559)
Commit migrated from https://github.com/dotnet/corefx/commit/
b7435702fe02e542f9dc35cccc7a795eef100bb2
Joel Braun [Wed, 24 Jan 2018 20:27:41 +0000 (12:27 -0800)]
Add SqlCommand Begin and EndExecuteXmlReader functions (dotnet/corefx#26252)
* Add SqlCommand Begin and EndExecuteXmlReader functions
* Updated tests to remove try/catch and use Assert.Throws
Commit migrated from https://github.com/dotnet/corefx/commit/
767696781f2a1803c5bb003a27bd0bc885817f6f
artkpv [Wed, 24 Jan 2018 17:41:51 +0000 (20:41 +0300)]
Command line tokenization reconciling (dotnet/corefx#25857)
* Command line tokenization reconciling
Using PasteArguments from Environment to avoid code duplication while
getting command line.
Issue dotnet/corefx#21267. Command Line tokenization is done all over the place and inconsistently.
* Fixing no-op bug. Clean up (style)
* Paste arguments cross platform fix: avoiding arg[0] check on Unix. refs dotnet/corefx#25857
* Fixing code style. Adding unit tests. Refs dotnet/corefx#25857
* (UWP CoreCLR x64 build fix)
Commit migrated from https://github.com/dotnet/corefx/commit/
956aefebe8ad325a7d4357480bfa327c91d8eb8c
Matt Galbraith [Wed, 24 Jan 2018 17:26:41 +0000 (09:26 -0800)]
Remove EOL Ubuntu 17.04 from test execution
Commit migrated from https://github.com/dotnet/corefx/commit/
b93ec32bbd636dc4950dc0b32a4b8f61f7422de0
Levi Broderick [Tue, 23 Jan 2018 22:19:25 +0000 (14:19 -0800)]
Add Unsafe.IsAddressGreaterThan and IsAddressLessThan
Commit migrated from https://github.com/dotnet/corefx/commit/
83f35ef9a79b5cd1412aeaad8d2cb84e1bfe73c4