Stephen Toub [Wed, 18 Mar 2020 20:49:18 +0000 (16:49 -0400)]
Annotate System.Runtime.WindowsRuntime.UI.Xaml for nullable reference types (#33725)
Andy Ayers [Wed, 18 Mar 2020 20:32:07 +0000 (13:32 -0700)]
JIT: propagate block flags during guarded devirt transform (#33724)
This transform duplicates code that might contain constructs we track via
block flags, so update the block flags.
Fadi Hanna [Wed, 18 Mar 2020 18:03:46 +0000 (11:03 -0700)]
Fix for issue 32731 (#33534)
* Couple of crossgen2 fixes:
1) Fix an issue hitting an assert in the TypeSystem's virtual function resolution
2) Port some inlining rules from crossgen1 - One of them fixes an issue where we would incorrectly inline a virtual method that has a MethodImpl associated with it (test = self_override5)
3) Remove an assert from R2RDump related to the composite work (assert needs to be after loading _readyToRunHeaderRVA, and is actually already at the right place a few lines below)
Johan Lorensson [Wed, 18 Mar 2020 17:34:43 +0000 (18:34 +0100)]
Change Mono runtime to use static linked c-runtime in debug builds. (#33715)
Tomáš Rylek [Wed, 18 Mar 2020 17:13:21 +0000 (18:13 +0100)]
One more fix for running / debugging Crossgen2 under dogfooding VS (#33698)
Juan Hoyos [Wed, 18 Mar 2020 16:08:20 +0000 (09:08 -0700)]
Only add the llvm elf headers on Windows for dbgutil (#33706)
Krzysztof Wicher [Wed, 18 Mar 2020 15:19:25 +0000 (08:19 -0700)]
Support Rfc3279 signature format for DSA and EcDSA (#1612)
This change adds overloads for SignData and SignHash/ComputeSignature on the DSA and ECDsa classes to make it easier for callers that need to use RFC3279's signature format to work with the classes in .NET.
It also moves more temporary work from temporary buffers to stackallocs.
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Johan Lorensson [Wed, 18 Mar 2020 13:35:08 +0000 (14:35 +0100)]
Correct subsetCategory parameter passed to build.cmd on Windows. (#33713)
monojenkins [Wed, 18 Mar 2020 12:50:46 +0000 (08:50 -0400)]
Fix additional constants embedded in instruction stream on AMD64. (#33682)
A couple of more op codes embedded constant values in instruction stream. When using MONO_ARCH_CODE_EXEC_ONLY these needs to be moved into GOT slots.
Thanks @buggeststar for bring the issues to our attention.
Co-authored-by: lateralusX <lateralusX@users.noreply.github.com>
monojenkins [Wed, 18 Mar 2020 09:20:07 +0000 (05:20 -0400)]
Remove useless ip += from MINT_JMP, it is assigned later. (#33548)
Co-authored-by: jaykrell <jaykrell@users.noreply.github.com>
Vladimir Sadov [Wed, 18 Mar 2020 05:00:41 +0000 (22:00 -0700)]
Adding public API for Pinned Object Heap allocations (#33526)
* Adding API for POH allocations and propagating flags all the way to Alloc.
* make `AllocateUninitializedArray` and `AllocateArray` public
* Added NYI implementations to Mono
* moved tests to libraries
* Actually use POH and more tests.
* Disable tests for the new API on mono
* mop up remaining TODOs
* Fix build breaking whitespace.
* Mono tabs and mark heavier tests as [Outerloop]
* Mono space before openning parens and braces
* Refactored AllocateArray
* PR feedback
* XML Doc comments
Jan Kotas [Wed, 18 Mar 2020 03:22:39 +0000 (20:22 -0700)]
Avoid unnecessary use of Linq (#33700)
Aaron Robinson [Wed, 18 Mar 2020 01:48:32 +0000 (18:48 -0700)]
Reverse P/Invoke methods do not support tailcalls. (#33677)
* Disable tailcalls in all scenarios involving a Reverse P/Invoke
dotnet-maestro[bot] [Wed, 18 Mar 2020 01:30:43 +0000 (18:30 -0700)]
[master] Update dependencies from mono/linker dotnet/arcade (#33646)
* Update dependencies from https://github.com/dotnet/arcade build
20200316.1
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20166.1
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20166.1
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20166.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20166.1
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20166.1
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20166.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20166.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20166.1
* Update dependencies from https://github.com/dotnet/arcade build
20200316.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20166.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20166.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20166.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20166.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20166.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20166.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20166.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20166.3
* Fix nullability warnings due to new compiler
* Update dependencies from https://github.com/mono/linker build
20200316.4
- ILLink.Tasks - 0.1.6-prerelease.20166.4
* PR Feedback
* Update dependencies from https://github.com/dotnet/arcade build
20200317.1
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20167.1
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20167.1
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20167.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20167.1
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20167.1
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20167.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20167.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20167.1
* Fix nullability warnings in System.Net.Http
* Use ! instead of pragma warning where we can and fix warning in tests build
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
Jan Kotas [Wed, 18 Mar 2020 00:16:59 +0000 (17:16 -0700)]
Disable warnings-as-errors for release branches (#33664)
Fixes #33627
Matt Galbraith [Tue, 17 Mar 2020 23:48:41 +0000 (16:48 -0700)]
Try UsePythonVersion to work around py2 removal (#33695)
* Try UsePythonVersion to work around py2 removal; Additionally, use hosted pools for windows to deal with lack of python on path
* PR feedback (typos)
Stephen Toub [Tue, 17 Mar 2020 23:37:48 +0000 (19:37 -0400)]
Annotate System.Threading.Tasks.Dataflow for nullable reference types (#33644)
Jo Shields [Tue, 17 Mar 2020 23:19:56 +0000 (19:19 -0400)]
Add AzDO builds for iOS (#33424)
This is based on #33292
Adeel Mujahid [Tue, 17 Mar 2020 23:03:37 +0000 (01:03 +0200)]
Fix native components build for Android (#32800)
* Fix native components build for Android
* Add cmake introspection for pthread_setcancelstate
* Address CR feedback
* Use calculated eth speed for Android
* Use #ifdef FEATURE_EVENT_TRACE
Stephen Toub [Tue, 17 Mar 2020 22:54:08 +0000 (18:54 -0400)]
Address follow-up feedback on System.Net.Requests annotations (#33691)
Maryam Ariyan [Tue, 17 Mar 2020 21:29:26 +0000 (14:29 -0700)]
Extensions: Incremental additions (#33563)
ref/src/pkg (have no test projects)
Microsoft.Extensions.Caching.Abstractions
Microsoft.Extensions.Configuration.Abstractions
Microsoft.Extensions.DependencyInjection.Abstractions
Microsoft.Extensions.Hosting.Abstractions
Microsoft.Extensions.Logging.Abstractions
ref/src/test/pkg
Microsoft.Extensions.Configuration
Microsoft.Extensions.Configuration.Binder
Microsoft.Extensions.Configuration.CommandLine
Microsoft.Extensions.Configuration.EnvironmentVariables
Microsoft.Extensions.Options.ConfigurationExtensions
Microsoft.Extensions.Options.DataAnnotations
Anirudh Agnihotry [Tue, 17 Mar 2020 19:48:23 +0000 (12:48 -0700)]
Adding missing test project config to .sln file (#33679)
Stephen Toub [Tue, 17 Mar 2020 19:47:58 +0000 (15:47 -0400)]
Annotate System.Net.WebClient for nullable reference types (#33670)
Stephen Toub [Tue, 17 Mar 2020 19:45:17 +0000 (15:45 -0400)]
Annotate System.Net.Requests for nullable reference types (#33630)
Tarek Mahmoud Sayed [Tue, 17 Mar 2020 16:18:35 +0000 (09:18 -0700)]
Fix Reading the Currency Formats (#33599)
* Fix Reading the Currency Formats
* Fix the managed format arrays
* Support formats missing #'s
Vitek Karas [Tue, 17 Mar 2020 12:41:55 +0000 (05:41 -0700)]
Merge pull request #33602 from vitek-karas/AppHostVersionAlways
Include apphost_version parameter in download URLs for both GUI and CLI apps
Stephen Toub [Tue, 17 Mar 2020 10:33:10 +0000 (06:33 -0400)]
Annotate System.Net.WebSockets.Client for nullable reference types (#33625)
Alexis Christoforides [Tue, 17 Mar 2020 10:26:52 +0000 (06:26 -0400)]
Revert "Disable System.Reflection.Emit.Tests in mono (#32201)" (#33641)
This reverts commit
11dcd00c1a77c8da0fe06404609a9c4af9e5da4f.
Anton Lapounov [Tue, 17 Mar 2020 09:28:24 +0000 (02:28 -0700)]
Enable crossgen2smoke test for ARM64 (#33530)
* Enable crossgen2smoke test for ARM64.
* Re-enable NullableWithExplicitLayoutTest sub-test.
* Restore setting the image base removed by #31663.
Aaron Robinson [Tue, 17 Mar 2020 05:35:14 +0000 (22:35 -0700)]
GC coverage can now occur in scenarios where a thread doesn't exist. (#33615)
* GC coverage can now occur in scenarios where a thread doesn't exist.
Properly handle this case and assert some invariant.
* Update gccover.cpp
Misspelled function referenced in comment.
* Remove MethodDesc from GC coverage.
* Code review and fix some asserts when running the Debug version of tests.
* Limit JIT flag manipulation to FEATURE_TIERED_COMPILATION
Santiago Fernandez Madero [Tue, 17 Mar 2020 05:34:50 +0000 (22:34 -0700)]
Use compilerName and compilerArg in pipeline configs (#33605)
Jan Vorlicek [Tue, 17 Mar 2020 05:34:35 +0000 (06:34 +0100)]
Fix Win64 exception propagation in NativeCallable methods (#33653)
A recent change has removed the UMThunkStub usage for native callable
methods. That has broken handling of exceptions propagated from the
managed native callable method into the native caller in case there were
explicit frames below the native frame, like during the GC stress 3.
This change fixes it by unwinding the explicit frames upto the native
frame during the 2nd pass of exception handling when exception unwinding
passes through the frame of a native callable method and isn't handled
there.
Pent Ploompuu [Tue, 17 Mar 2020 05:13:07 +0000 (07:13 +0200)]
Simplify Convert (#33659)
* Simplify Convert
* Optimize Number.UInt32ToDecStr
monojenkins [Tue, 17 Mar 2020 04:51:25 +0000 (00:51 -0400)]
Fix usage of JIT_FLAG_CODE_EXEC_ONLY flag. (#33623)
#19219 didn't convert the JIT flags into options on cfg meaning that code currently checked JIT_FLAG_CODE_EXEC_ONLY never executed. Fix handles the new JIT flag in same way as other JIT flags, converted into bit field on cfg.
With this fix, the following C# method:
```
static double Test()
{
return 1.0f;
}
```
will now generate the following assembly on amd64, when using MONO_ARCH_CODE_EXEC_ONLY:
```
sub rsp,8
mov r11,qword ptr [180003318h]
movsd xmm0,mmword ptr [r11]
add rsp,8
ret
```
Co-authored-by: lateralusX <lateralusX@users.noreply.github.com>
Jan Kotas [Tue, 17 Mar 2020 04:30:03 +0000 (21:30 -0700)]
Delete IExecutionEngine (#33640)
* Delete IExecutionEngine
* Delete InitUtilcode
* Delete cvtres invocation
* Delete cached m_pClrDebugState and fix contract violations
Jan Kotas [Tue, 17 Mar 2020 04:01:45 +0000 (21:01 -0700)]
Delete unused and redundant msbuild properties in coreclr build (#33645)
Aaron Robinson [Tue, 17 Mar 2020 03:22:17 +0000 (20:22 -0700)]
Limit JIT flag manipulation to FEATURE_TIERED_COMPILATION
monojenkins [Tue, 17 Mar 2020 02:23:38 +0000 (22:23 -0400)]
[merp] Add breadcrumb for StackHash (#33635)
Contributes to https://github.com/mono/mono/issues/18715
<!--
Thank you for your Pull Request!
If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.
Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
Co-authored-by: alexischr <alexischr@users.noreply.github.com>
buyaa-n [Tue, 17 Mar 2020 01:06:01 +0000 (18:06 -0700)]
Annotate System.Net.Http for nullable (#33268)
* Annotate System.Net.Http for nullable
monojenkins [Tue, 17 Mar 2020 01:02:22 +0000 (21:02 -0400)]
[jit] Transition the SIMD code to use the MONO_CPU_... set of flags instead of the SIMD_VERSION_... flags. (#33267)
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Davis Goodin [Tue, 17 Mar 2020 00:33:31 +0000 (18:33 -0600)]
Update area owners: Setup, Infra-installer (#33650)
Andy Ayers [Tue, 17 Mar 2020 00:29:55 +0000 (17:29 -0700)]
Implement simple version of On Stack Replacement (OSR) (#32969)
Add support to runtime and jit to allow switching from unoptimized to
optimized code for a method while the method has active stack frames.
Details in the included document.
Elinor Fung [Tue, 17 Mar 2020 00:02:38 +0000 (17:02 -0700)]
Fix COM + dynamic tests (#33642)
David Mason [Tue, 17 Mar 2020 00:01:08 +0000 (17:01 -0700)]
Revert "Add example profiler that does stack sampling with ICorProfilerInfo10::SuspendRuntime (#32988)" (#33656)
This reverts commit
7a362a03f6e829828b5276ab2bf3f1d3073cc166.
Aaron Robinson [Mon, 16 Mar 2020 23:34:28 +0000 (16:34 -0700)]
Code review and fix some asserts when running the Debug version of tests.
Thomas Gassmann [Mon, 16 Mar 2020 22:18:55 +0000 (23:18 +0100)]
Fix timespan wrap-around when multiplying back by inverse scale
When creating a `TimeSpan` by either dividing, multiplying or using one of
the `From...` methods, the ticks are multiplied by an inverse scale.
When converting the double-precision value back to a long, this
currently causes incorrect values.
This change makes MaxValue work and to allow it to roundtrip.
Ganbarukamo41 [Mon, 16 Mar 2020 22:10:27 +0000 (07:10 +0900)]
Implement Vector.Ceiling / Vector.Floor (#31993)
* Add Ceil/Floor to S.P.CoreLib and expose publicly
* Make Ceil/Floor JIT intrinsic
* Add missing identifier for closing endif
* Add JIT test for Ceil/Floor
* Add test for Ceil/Floor in S.Numerics.Vectors
* Also fix the old path for the new structure
* Apply jit-format
* Do not attempt to treat Ceil/Floor if SSE4.1 isn't available
* Mark Vector<T>.Ceiling/Floor as Intrinsic
* Add missing underscore
* Revert "Add missing idenfitier for closing endif"
* Oops
* Add missing breaks
* Oops, again
* Simplify switch case
* Per review suggestion
Co-Authored-By: Egor Chesakov <egor.chesakov@microsoft.com>
Co-authored-by: Egor Chesakov <egor.chesakov@microsoft.com>
Eirik Tsarpalis [Mon, 16 Mar 2020 22:00:12 +0000 (22:00 +0000)]
[CBOR] Implement Map support for CborReader and CborWriter (#33500)
* Implement map support for CborReader and CborWriter
* fix test naming
* move helper functions to nested type
* check for arithmetic overflow in CborReader.ReadStartMap
* throw FormatExceptions on data items whose definite length exceeds remaining buffer size
Nathan Ricci [Mon, 16 Mar 2020 21:07:31 +0000 (17:07 -0400)]
Changed RuntimeName to the existing RuntimeFlavor property. (#33559)
Change RuntimeName to the exiting RuntimeFlavor property.
Jan Kotas [Mon, 16 Mar 2020 20:13:09 +0000 (13:13 -0700)]
Delete redundant LangVersion properties (#33637)
vitek-karas [Mon, 16 Mar 2020 19:44:45 +0000 (12:44 -0700)]
Update the docs with the change
Jan Kotas [Mon, 16 Mar 2020 18:36:36 +0000 (11:36 -0700)]
Delete unnecessary ReferenceSystemPrivateCoreLib from CoreCLR tests (#33629)
Jan Kotas [Mon, 16 Mar 2020 17:54:49 +0000 (10:54 -0700)]
Replace manually managed TLS slots with regular thread_local statics (#33597)
* Delete TlsIdx_XXX
* Delete EnableTerminationOnHeapCorruption
* Delete redundant cant stop tracking
* Workaround compiler bug
monojenkins [Mon, 16 Mar 2020 15:51:56 +0000 (11:51 -0400)]
[Loader] Change mono_trace level from info to debug (#33104)
Fixes mono/mono#18795
**Testing:**
Created HelloWorld script
Set environment variable `export MONO_LOG_LEVEL=info`
Compiled and executed script before and after these changes were applied
```
mdhwang:~/Desktop$ ls -al csc_*txt mono_*txt
-rw-r--r--@ 1 mdhwang staff 4270 Mar 3 10:12 csc_after.txt
-rw-r--r--@ 1 mdhwang staff 56698 Mar 3 10:14 csc_before.txt
-rw-r--r--@ 1 mdhwang staff 176 Mar 3 10:12 mono_after.txt
-rw-r--r--@ 1 mdhwang staff 3617 Mar 3 10:14 mono_before.txt
```
There is a noticeable difference in log output sizes, and the logs created after the changes were applied mainly contain `Loading reference 0 of _ asmctx _` as desired in the issue.
Co-authored-by: mdh1418 <mdh1418@users.noreply.github.com>
dotnet-maestro[bot] [Mon, 16 Mar 2020 15:37:59 +0000 (16:37 +0100)]
[master] Update dependencies from 3 repositories (#33588)
* Update dependencies from https://github.com/mono/linker build
20200313.2
- ILLink.Tasks - 0.1.6-prerelease.20163.2
* Update dependencies from https://github.com/microsoft/vstest build
20200313-06
- Microsoft.NET.Test.Sdk - 16.6.0-preview-
20200313-06
* Update dependencies from https://github.com/mono/linker build
20200316.1
- ILLink.Tasks - 0.1.6-prerelease.20166.1
* Update dependencies from https://github.com/microsoft/vstest build
20200316-01
- Microsoft.NET.Test.Sdk - 16.6.0-preview-
20200316-01
* Update dependencies from https://github.com/dotnet/llvm-project build
20200316.1
- runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools - 6.0.1-alpha.1.20166.1
- runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk - 6.0.1-alpha.1.20166.1
- runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools - 6.0.1-alpha.1.20166.1
- runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk - 6.0.1-alpha.1.20166.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Roman Marusyk [Mon, 16 Mar 2020 14:39:37 +0000 (16:39 +0200)]
Remove calls to empty RuntimeHelpers.PrepareConstrainedRegions() (#33191)
Fixes #33179
handlespeed [Mon, 16 Mar 2020 11:27:25 +0000 (19:27 +0800)]
Remove unused variable for System.Net.Requests, as part of #30457 (#33619)
src/libraries/System.Net.Requests/src/System/Net/FtpControlStream.cs, remove unused variable 'request' in L414.
Partially Fix #30457
David Mason [Mon, 16 Mar 2020 08:17:58 +0000 (01:17 -0700)]
Add example profiler that does stack sampling with ICorProfilerInfo10::SuspendRuntime (#32988)
Aaron Robinson [Mon, 16 Mar 2020 04:57:16 +0000 (21:57 -0700)]
Remove MethodDesc from GC coverage.
Jeremy Barton [Mon, 16 Mar 2020 04:52:33 +0000 (21:52 -0700)]
Don't delete private keys detected from SerializedCert imports
Aaron Robinson [Mon, 16 Mar 2020 04:23:49 +0000 (21:23 -0700)]
Update gccover.cpp
Misspelled function referenced in comment.
Aaron Robinson [Mon, 16 Mar 2020 03:46:49 +0000 (20:46 -0700)]
GC coverage can now occur in scenarios where a thread doesn't exist.
Properly handle this case and assert some invariant.
Alan Isaac [Mon, 16 Mar 2020 03:02:23 +0000 (23:02 -0400)]
Additional code coverage in System.Text.Json - no public constructors (#33137)
* added tests for concurrent collection private constructors
* added tests for non generic collection private constructors
* added tests for generic collection private constructors
* added additional test for read only dictionary private constructor
* fixed location of compile directive
* added assertion for exception messages
* added additional assertions for exception messages
* using [Theory] tests to reduce LoC
* using [Theory] for additional tests
* reordered files in test project
* added internal ctor tests
Anirudh Agnihotry [Sun, 15 Mar 2020 20:19:09 +0000 (13:19 -0700)]
Fixing the sourcelink failure for embeded files (#33521)
* fixing sourcelink
* enable sourcelink on official build
* addressing feedback
* removing extra space
* reverting eng common change
* adding comment
* moving comment to correct place
* not embedding files for test assemblies
David Wrighton [Sun, 15 Mar 2020 20:02:00 +0000 (13:02 -0700)]
Print Ibc messages only when --verbose is specified (#33595)
Jan Kotas [Sun, 15 Mar 2020 15:55:32 +0000 (08:55 -0700)]
Update links to the design repo (#33606)
Adeel [Sun, 15 Mar 2020 09:44:51 +0000 (11:44 +0200)]
Use compilerName and compilerArg in pipeline configs
Levi Broderick [Sun, 15 Mar 2020 06:53:43 +0000 (23:53 -0700)]
Update .NET 5 Unicode data to version 13.0.0 (#33538)
Egor Bogatov [Sun, 15 Mar 2020 03:20:36 +0000 (06:20 +0300)]
[mono] Implement all Ssse3 and Sse42 intrinsics (#33591)
* implement Ssse3
* Implement Sse42
* remove unrelated change
* Fix C compilation error
Levi Broderick [Sun, 15 Mar 2020 01:22:22 +0000 (18:22 -0700)]
Add missing early-exit for LastIndexOfOrdinal (#33601)
vitek-karas [Sun, 15 Mar 2020 00:01:19 +0000 (17:01 -0700)]
Include apphost_version parameter in download URLs for both GUI and CLI apps
So far the code only included the `&apphost_version=<version>` URL parameter in the URL used by the error dialog in GUI apps. The error written to stderr/trace would not have that parameter in its URL.
This change include this parameter in all cases. This also means that comhost/ijwhost and so on will also include the `apphost_version` parameter in their error codes and it will be the version of the comhost/ijwhost and so on. This is not 100% correct, but for the purposed of the website this should be enough (for now we don't see a reason to differentiate between the various hosting scenarios).
Adds a new test to cover this case.
monojenkins [Sat, 14 Mar 2020 22:23:10 +0000 (18:23 -0400)]
[wasm] Add a sample for collecting coverage data. (#33584)
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Vitek Karas [Sat, 14 Mar 2020 21:55:53 +0000 (14:55 -0700)]
Merge pull request #33578 from vitek-karas/HostDownloadUrls
Add a document describing usage of URLs in the hosting layer
Vitek Karas [Sat, 14 Mar 2020 21:55:29 +0000 (14:55 -0700)]
Apply suggestions from code review
Co-Authored-By: Elinor Fung <47805090+elinor-fung@users.noreply.github.com>
Eric Erhardt [Sat, 14 Mar 2020 15:43:44 +0000 (10:43 -0500)]
Allow Utf8String package to work on netstandard 2.0 (#33357)
* Update ref assembly for building netstandard2.0.
Includes System.Text.Rune for netstandard2.0, since that is currently only netcoreapp3.0.
* Get Rune working on netstandard2.0
* Get Utf8Span compiling on netstandard2.0.
* Get Utf8String building on netstandard2.0
* Compile Utf8String/Span.Conversion.cs for netstandard.
* Build Utf8String Comparison and Enumeration for netstandard.
* Enable Index and Range on netstandard2.0
* Moving code around so it lines up with the ref assemblies.
Getting the full build working again.
* Build for netcoreapp3.0.
Get the package building.
* Get tests building on netfx
* Get Utf8String constructors working on netstandard.
* Get all tests running on netfx.
* Fix build for netcoreapp3.0, which doesn't have SerializeToStreamAsync with cancellation.
* Add netstandard2.1 support to Utf8String.Experimental.
* Make Intrinsics IsSupported be const fields.
* Address PR feedback
* Ensure nint and nuint are set correctly when building Utf8String outside of CoreLib.
* Fix bug in construction from long UTF16 string.
Next Turn [Sat, 14 Mar 2020 11:34:34 +0000 (19:34 +0800)]
Fix indentations of nameof (#33586)
Adeel Mujahid [Sat, 14 Mar 2020 03:49:11 +0000 (05:49 +0200)]
Update artifactName prefix for GCC publish log task (#33573)
dotnet-maestro[bot] [Sat, 14 Mar 2020 03:46:19 +0000 (20:46 -0700)]
[master] Update dependencies from dotnet/arcade dotnet/runtime-assets (#33562)
* Update dependencies from https://github.com/dotnet/arcade build
20200312.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20162.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20162.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20162.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20162.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20162.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20162.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20162.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20162.3
* Update dependencies from https://github.com/dotnet/runtime-assets build
20200312.1
- System.Windows.Extensions.TestData - 5.0.0-beta.20162.1
- System.Security.Cryptography.X509Certificates.TestData - 5.0.0-beta.20162.1
- System.Private.Runtime.UnicodeData - 5.0.0-beta.20162.1
- System.Net.TestData - 5.0.0-beta.20162.1
- System.IO.Packaging.TestData - 5.0.0-beta.20162.1
- System.IO.Compression.TestData - 5.0.0-beta.20162.1
- System.Drawing.Common.TestData - 5.0.0-beta.20162.1
- System.ComponentModel.TypeConverter.TestData - 5.0.0-beta.20162.1
* Remove APICompat downgrade
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
Egor Bogatov [Sat, 14 Mar 2020 03:35:53 +0000 (06:35 +0300)]
[mono] Implement missing SSE2 intrinsics (#33574)
* Implement missing SSE2 intrinsics
* remove SN_ConvertScalarToVector128Single case
* Remove unrelated change
* Shuffle < Sqrt (binary search)
Andrew Au [Sat, 14 Mar 2020 03:23:53 +0000 (20:23 -0700)]
Read the image earlier (#33576)
Santiago Fernandez Madero [Sat, 14 Mar 2020 02:45:40 +0000 (19:45 -0700)]
Disable publishing CoreCLR product binaries on GCC leg (#33580)
Levi Broderick [Sat, 14 Mar 2020 02:43:13 +0000 (19:43 -0700)]
Prep CompareInfo for spanification (#32385)
Jan Vorlicek [Sat, 14 Mar 2020 02:22:09 +0000 (03:22 +0100)]
Fix dump of common methods diff (#33570)
The DiffMethodsForModule was accidentally trying to get leftSection from
the right dumper.
Egor Chesakov [Sat, 14 Mar 2020 00:11:30 +0000 (17:11 -0700)]
[Arm64] Vector Load/Store structure instructions (#33461)
This adds support in the JIT emitter for Vector Load/Store structure instructions (C3.2.10 - Arm
Architecture Reference Manual):
- LD1 (1-4 registers)
- LD2
- LD3
- LD4
- LD1R
- LD2R
- LD3R
- LD4R
- ST1 (1-4 registers)
- ST2
- ST3
- ST4
in the following addressing modes:
- Base register only
- Post-indexed by a 64-bit register
- Post-indexed by an immediate, equal to the number of bytes transferred
Also adds support in JitDump for printing of
* A SIMD vector register list.
For example, ld1 {v5.16b, v6.16b, v7.16b, v8.16b}, [x9]
* A SIMD vector element list.
For example, st1 {v0.b}[3], [x1],#1
Aaron Robinson [Fri, 13 Mar 2020 23:50:58 +0000 (16:50 -0700)]
Make NativeCallableAttribute public. (#33005)
* Avoid creating a COM Delegate when calling NativeCallableAttribute.
* Create reverse P/Invoke frame.
Create Preempt and Coop PreStubWorker().
* Limit the exclusion for NativeCallableAttribute to Win-x86.
* Add Reverse P/Invoke JIT helpers to CrossGen2.
* Add test for generic class with NativeCallableAttribute method.
* Implement Unix EH change for NativeCallableAttribute method.
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Erhan Atesoglu [Fri, 13 Mar 2020 22:56:27 +0000 (15:56 -0700)]
Remove TS_UserSuspendPending enum (#33539)
This PR removes the unused TS_UserSuspendPending enum as well as flag usage.
vitek-karas [Fri, 13 Mar 2020 22:28:57 +0000 (15:28 -0700)]
Add a document describing usage of URLs in the hosting layer
monojenkins [Fri, 13 Mar 2020 22:26:44 +0000 (18:26 -0400)]
[jit] Add support for emitting r4/r8 constants outside of the text segment. (#33552)
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Swaroop Sridhar [Fri, 13 Mar 2020 22:23:30 +0000 (15:23 -0700)]
HostModel: Remove depricated API (#33545)
Some depricated APIs were maintained in #33413 so that SDK build is green.
Now that the SDK is updated https://github.com/dotnet/sdk/pull/10849, remove the unused APIs.
Also move out a test-only methods from the product to the test helpers.
Jan Jahoda [Fri, 13 Mar 2020 22:17:30 +0000 (22:17 +0000)]
Disable not working test containing RemoteExecutor (#33560)
Steve Harter [Fri, 13 Mar 2020 22:12:09 +0000 (17:12 -0500)]
Add polymorphic tests for all root APIs (#33391)
monojenkins [Fri, 13 Mar 2020 22:01:14 +0000 (18:01 -0400)]
[runtime] Coverage profiler improvements. (#33540)
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Koundinya Veluri [Fri, 13 Mar 2020 20:14:02 +0000 (16:14 -0400)]
Merge pull request #33512 from kouvel/NoQuickJitFix
When QuickJit is disabled, fix assertion failures regarding R2R code
Steve Harter [Fri, 13 Mar 2020 19:38:46 +0000 (14:38 -0500)]
Rename "PolicyProperty" to "PropertyInfoForClassInfo" and update nullability (#33432)
Steve Harter [Fri, 13 Mar 2020 18:57:43 +0000 (13:57 -0500)]
Update doc for exceptions thrown during serialization (#33400)
Gustavo Varo [Fri, 13 Mar 2020 16:36:03 +0000 (12:36 -0400)]
Fix content of baseline files (#33514)
Egor Bogatov [Fri, 13 Mar 2020 16:18:10 +0000 (19:18 +0300)]
[mono] Track .dotnet runtime version (#33180)
* Track .dotnet runtime version correctly
* Use BundledNETCoreAppPackageVersion
* Rollback to an error
* Update src/mono/mono.proj
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Miha Zupan [Fri, 13 Mar 2020 15:30:00 +0000 (16:30 +0100)]
Replace ushort usage with int (#32694)
* Replace pointless ushort usage with int
* Revert extracting name[i] to a local
* Use int instead of byte in IPv4 ParseCanonical
Next Turn [Fri, 13 Mar 2020 14:49:09 +0000 (22:49 +0800)]
Clean up unused locals in System.Drawing.Common (#32212)
* Clean up unused locals in System.Drawing.Common
* Remove BufferedStream, use MemoryStream.ToArray()
Aleksey Kliger (λgeek) [Fri, 13 Mar 2020 14:45:03 +0000 (10:45 -0400)]
[threads] If shutting_down, don't create new thread, kill current thread (#32968)
If the runtime is shutting down, instead of creating a new thread, or throwing
an exception on the current thread, just shut down the current thread.
This takes advantage of `mono_threads_set_shutting_down`'s behavior that if you
call it after shutdown is already started, it will suspend, detach and exit
from the current thread.
Fixes https://github.com/dotnet/runtime/issues/31842