Jorge González [Sat, 29 May 2010 10:06:16 +0000 (12:06 +0200)]
Updated Spanish translation
Jorge González [Fri, 28 May 2010 18:21:02 +0000 (20:21 +0200)]
Updated Spanish translation
Jorge González [Fri, 28 May 2010 17:45:51 +0000 (19:45 +0200)]
Updated Spanish translation
Yaron Shahrabani [Fri, 28 May 2010 13:57:56 +0000 (16:57 +0300)]
Updated Hebrew translation.
Yaron Shahrabani [Fri, 28 May 2010 13:54:58 +0000 (16:54 +0300)]
Updated Hebrew translation.
Lin Ma [Fri, 28 May 2010 08:57:10 +0000 (16:57 +0800)]
After talk with FEN dev, we dicide simply disable monitor function if
the current filesystem doesn't suport FEN.
Alexander Larsson [Fri, 1 Jan 2010 20:39:52 +0000 (21:39 +0100)]
Add dtrace and systemtap support for gobject
This adds static markers and systemtap tapsets for:
* type creation
* object lifetimes (creation, ref, unref, dispose, finalize)
* signal creation and emission
Signal emissions and finalization marker have a corresponding
*_end (or *-end in dtrace) version that is when the corresponding
operation is finished.
https://bugzilla.gnome.org/show_bug.cgi?id=606044
Alexander Larsson [Fri, 18 Dec 2009 20:25:47 +0000 (21:25 +0100)]
Initial support for dtrace and systemtap
This adds static markers for dtrace, which are also usable
by systemtap. Additionally it adds a tapset for systemtap
that makes it easier to use the static markers.
These are enabled by default.
This initial set of probes is rather limited:
* allocation and free using g_malloc & co
* allocation and free using g_slice
* gquark name tracking (useful for converting quarks to strings in probes)
Notes on naming:
Its traditional with dtrace to use probe names with dashes as
delimiter (slice-alloc). Since dashes are not usable in identifiers
the C code uses double underscores (slice__alloc) which is converted
to dashes in the UI. We follow this for the shared lowlevel probe
names.
Additionally dtrace supports putting a "provider" part in the probe
names which is essentially a namespacing thing. On systemtap this
field is currently ignored (but may be implemented in the future), but
this is not really a problem since in systemtap the probes are
specified by combining the solib file and the marker name, so there
can't really be name conflicts.
For the systemtap tapset highlevel probes we instead use names that
are systemtapish with single dashes as separators.
https://bugzilla.gnome.org/show_bug.cgi?id=606044
Mikhail Zabaluev [Thu, 27 May 2010 18:00:12 +0000 (14:00 -0400)]
Optimized the overlong sequence check in g_utf8_get_char_extended()
Rather make it branch to get the due sequence length for the resulting
character code, we can as well get the minimum code value in the initial
branching.
Ryan Lortie [Thu, 27 May 2010 17:11:49 +0000 (13:11 -0400)]
GSettings schema docs: mention need for EXTRA_DIST
Mention that you will need to use EXTRA_DIST for your schema file if it
is distributed with your project.
Ryan Lortie [Thu, 27 May 2010 17:07:54 +0000 (13:07 -0400)]
Remove duplicate copies of migration docs
Fixup for commit
133f66538dbf266be3c99b34f1eeee0a5e6068ac which
duplicated the contents of most of the migration documentation by
splitting it out into separate files but keeping the original file
intact (with a rename).
This removes the duplicated content from the renamed file.
Ryan Lortie [Thu, 27 May 2010 15:58:54 +0000 (11:58 -0400)]
gsettings m4: check for .xml in src/builddir
This checks for the .gschema.xml file in the srcdir and builddir and
runs the schema validation on which one it finds. This handles
non-srcdir builds in both cases: .gschema.xml is in the tarball and
.gschema.xml is generated.
Ryan Lortie [Thu, 27 May 2010 15:32:34 +0000 (11:32 -0400)]
GVariant: One more FreeBSD fix
FreeBSD's malloc() sometimes returns unaligned memory if you are
requesting small sizes. This can get GVariant into trouble. For
example, consider the type "mmi" containing the value "just nothing".
According to the type signature, the memory containing this should be
aligned to a boundary of 4 since it might contain an int. The
serialised size of this value is 1 byte, however, and when you ask
FreeBSD to allocate memory of that size, it knows you can't put an int
into it so it doesn't bother aligning it.
This patch modifies the GVariant serialiser to not assert the alignment
constraint in the case that the size of the serialised data is smaller
than its own alignment requirement.
Ryan Lortie [Thu, 27 May 2010 03:34:31 +0000 (23:34 -0400)]
More alignment-related fixes.
Partial-backout
8a21d8d23317ecebe46007f1fd5f7459bf182415. The
assertions should have remained relaxed since these functions are used
with non-posix_memalign()ed data.
Lin Ma [Thu, 27 May 2010 02:24:58 +0000 (10:24 +0800)]
Remove unused code.
Ryan Lortie [Wed, 26 May 2010 21:35:18 +0000 (17:35 -0400)]
include "config.h" for HAVE_POSIX_MEMALIGN
Ryan Lortie [Wed, 26 May 2010 21:31:52 +0000 (17:31 -0400)]
Use aligned memory in GVariant test cases.
The GVariant serialiser works well with non-8-aligned memory, but the
comparison serialiser in the test case depends on memory being
8-aligned. Use posix_memalign() to get the memory used by this
serialiser.
Colin Walters [Wed, 26 May 2010 20:21:15 +0000 (16:21 -0400)]
[mainloop-test] Fix compilation errors
Colin Walters [Wed, 26 May 2010 19:59:36 +0000 (15:59 -0400)]
[tests/gvariant] Handle flavored_free(NULL), since flavored_malloc can return NULL
Jorge González [Wed, 26 May 2010 16:12:22 +0000 (18:12 +0200)]
Updated Spanish translation
Jorge González [Wed, 26 May 2010 16:09:46 +0000 (18:09 +0200)]
Updated Spanish translation
Lin Ma [Wed, 26 May 2010 06:32:37 +0000 (14:32 +0800)]
bugster#6955199, on hsfs portfs will fail, and FEN backend will fail
to run lstat and port_associate on root node.
Havoc Pennington [Tue, 20 Apr 2010 21:47:44 +0000 (17:47 -0400)]
GSource: add g_source_set_name, g_source_get_name, g_source_set_name_by_id
These allow applications to give meaningful names to their sources.
Source names can then be used for debugging and profiling, for
example with systemtap or gdb.
https://bugzilla.gnome.org/show_bug.cgi?id=606044
Havoc Pennington [Tue, 20 Apr 2010 21:47:44 +0000 (17:47 -0400)]
GSource: add g_source_set_name, g_source_get_name, g_source_set_name_by_id
These allow applications to give meaningful names to their sources.
Source names can then be used for debugging and profiling, for
example with systemtap or gdb.
https://bugzilla.gnome.org/show_bug.cgi?id=606044
David Zeuthen [Tue, 25 May 2010 15:59:57 +0000 (11:59 -0400)]
GDBus: Big-endian fixes
Tested this on my Powerbook G4 12", 867MHz PowerPC G4 running Fedora
11ish.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Ryan Lortie [Tue, 25 May 2010 15:25:34 +0000 (11:25 -0400)]
GVariant: deal with non-8-aligned malloc()
Closes bug #619585.
Matthias Clasen [Tue, 25 May 2010 14:43:29 +0000 (10:43 -0400)]
Document that vtable is not copied
Fran Diéguez [Tue, 25 May 2010 07:56:33 +0000 (09:56 +0200)]
Updated Galician translations
Ryan Lortie [Tue, 25 May 2010 03:21:01 +0000 (23:21 -0400)]
.gitignore manpages (*.1)
Ryan Lortie [Tue, 25 May 2010 03:03:36 +0000 (23:03 -0400)]
post-release version bump.
Ryan Lortie [Tue, 25 May 2010 03:02:18 +0000 (23:02 -0400)]
Release 2.25.7.
Ryan Lortie [Tue, 25 May 2010 02:37:43 +0000 (22:37 -0400)]
another occurrence of the last fix (@XSLTPROC@)
Ryan Lortie [Tue, 25 May 2010 02:35:33 +0000 (22:35 -0400)]
man pages: fix broken @XSLTPROC@ substitution
Ryan Lortie [Tue, 25 May 2010 02:20:47 +0000 (22:20 -0400)]
change GSettingsBackend.list() API
Matthias Clasen [Tue, 25 May 2010 01:09:55 +0000 (21:09 -0400)]
Improve the g_file_make_symbolic_link docs
Following a proposal by Neil Williams in bug 619527.
Ryan Lortie [Mon, 24 May 2010 21:03:26 +0000 (17:03 -0400)]
GIO: Add g_d{,c}gettext to PLT check exceptions
Ryan Lortie [Mon, 24 May 2010 20:46:24 +0000 (16:46 -0400)]
GDBusConnection.call(): add 'reply_type' argument
This allows the caller to specify the reply type that they are expecting
for this call. If the reply comes back with the wrong type, GDBus will
generate an appropriate error internally.
- add a GVariantType * argument to g_dbus_connection_call() and
_call_sync().
- move the internal API for computing message types from introspection
data to be based on GVariantType instead of strings. Update users
of this code.
- have GDBusProxy pass this calculated GVariantType into
g_dbus_connection_call(). Remove the checks done in GDBusProxy.
- Update other users of the code (test cases, gdbus-tool, GSettings
tool, etc). In some cases, remove redundant checks; in some other
cases, we are fixing bugs because no checking was done where it
should have been.
Closes bug #619391.
Richard Hughes [Mon, 24 May 2010 16:22:38 +0000 (17:22 +0100)]
Fix up a typo in the g_variant_builder_add() docs
Tor Lillqvist [Mon, 24 May 2010 08:22:41 +0000 (11:22 +0300)]
Most of the gdbus test programs build only on Unix
Kjartan Maraas [Sun, 23 May 2010 14:27:17 +0000 (16:27 +0200)]
Updated Norwegian bokmål translation
Kjartan Maraas [Sun, 23 May 2010 14:27:08 +0000 (16:27 +0200)]
Add two missing files
Fran Diéguez [Sat, 22 May 2010 22:22:48 +0000 (00:22 +0200)]
Updated Galician translations
Fran Diéguez [Sat, 22 May 2010 22:20:26 +0000 (00:20 +0200)]
Updated Galician translations
Fran Diéguez [Thu, 20 May 2010 19:52:11 +0000 (21:52 +0200)]
Updated Galician translations
Matthias Clasen [Sat, 22 May 2010 02:28:42 +0000 (22:28 -0400)]
Clean up man page handling
Remove all formatted man pages from git, and use the same
Makefile fragment in all doc dirs.
Ryan Lortie [Sat, 22 May 2010 00:08:49 +0000 (20:08 -0400)]
add .SECONDARY: rule to preserve generated schemas
If the .gschema.xml file was generated as the result of an implicit make
rule then make would 'rm' it after creating the validity stamp. This
would cause 'make install' to fail.
David Zeuthen [Fri, 21 May 2010 16:09:27 +0000 (12:09 -0400)]
Return an error for calls into unknown interfaces or unknown objects
Ryan pointed out on IRC that we didn't do anything here. Looking at
the code, it's painfully obvious that we should be returning an error
here since a comment already says that we've exhausted all possible
options.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Christian Persch [Fri, 14 May 2010 12:00:24 +0000 (14:00 +0200)]
Use stack-allocated GVariantBuilders
This saves a few allocations.
Also simplify the code a bit in gdbusconnection.
Bug #618616.
Christian Persch [Wed, 19 May 2010 22:54:51 +0000 (00:54 +0200)]
Add g_dc[p]gettext, and use it in gsettings
Avoid using LC_MESSAGES, and just call g_d[c]gettext directly.
Bug #617004.
Fran Diéguez [Thu, 20 May 2010 17:30:39 +0000 (19:30 +0200)]
Updated Galician translations
David Zeuthen [Thu, 20 May 2010 14:51:00 +0000 (10:51 -0400)]
Bug 619142 – Build fixes
- Fix various #include issues
- Change #error to #warning for the EXTERNAL authentication mechanism.
It is not clear if this should work on Win32 at all.
- Call close() before unlink() for the SHA1 keyring
- Change #error to #warning so we don't forget to do
permission checking of the .dbus-keyrings directory
- Use Win32 SID for the SHA1 auth mech
- Apparently we can't use word 'interface' as an identifier
- Implement a _g_dbus_win32_get_user_sid() function. For now it's
private. Don't know if it should be public somewhere. Maybe in
a future GCredentials support for Win32? I don't know.
- GFileDescriptorBased is not available on Win32. So avoid using
it in GLocalFile stuff. Now, Win32 still uses GLocalFile + friends
(which works with file descriptors) so expose a private function
to get the fd for an OutputStream so things still work.
- Fixup gio.symbols
- Fixup tests/gdbus-peer.c so it builds
With this, at least things compile and the gdbus-peer.exe test case
passes. Which is a great start. I've tested this by cross-compiling on
a x86_64 Fedora 13 host using mingw32 and running the code on a 32-bit
Windows 7 box.
https://bugzilla.gnome.org/show_bug.cgi?id=619142
Signed-off-by: David Zeuthen <davidz@redhat.com>
Ivar Smolin [Thu, 20 May 2010 11:56:46 +0000 (14:56 +0300)]
Estonian translation updated
Javier Jardón [Wed, 19 May 2010 23:55:58 +0000 (01:55 +0200)]
Add G_TYPE_CLASS_GET_PRIVATE macro to docs
Ryan Lortie [Wed, 19 May 2010 21:38:17 +0000 (17:38 -0400)]
Version bump.
Ryan Lortie [Wed, 19 May 2010 21:32:42 +0000 (17:32 -0400)]
Release 2.25.6
Ryan Lortie [Wed, 19 May 2010 20:02:05 +0000 (16:02 -0400)]
Add --uninstall option to glib-compile-schemas
If --uninstall is given then don't give an error if the schema directory
is empty. Instead, erase the gschemas.compiled file, if it exists.
This is the right thing to do in the 'make uninstall' rule, where the
schema directory could very well be left empty as a result.
Modify gsettings.m4 to use this option.
Ryan Lortie [Tue, 18 May 2010 22:28:39 +0000 (18:28 -0400)]
Bug 619038 - increase gsettings.m4 power
handle schema checking, installation, uninstallation, cleaning
Tor Lillqvist [Wed, 19 May 2010 07:47:02 +0000 (10:47 +0300)]
Make config.h.win32.in match what configure produces
No semantic changes.
Ryan Lortie [Tue, 18 May 2010 22:24:04 +0000 (18:24 -0400)]
glib-compile-schemas rename missed in docs
change a mention of gschema_compile in the docs
Javier Jardón [Tue, 18 May 2010 21:45:54 +0000 (23:45 +0200)]
Fix trivial typo in GCredentials code
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=618839
Ryan Lortie [Tue, 18 May 2010 21:25:43 +0000 (17:25 -0400)]
Bug 619031 - method-calls-in-thread test failing
The test was assuming that g_timeout_add() waited for at least the amount of
time given to it before running the function. This is not the case -- the
function can be run as much as 1ms early. Make the lower time bound asserted
in the test more permissive to account for this.
Ryan Lortie [Tue, 18 May 2010 20:43:36 +0000 (16:43 -0400)]
Bug 618839 - Typo at translation message
Fix trivial typo in GCredentials code
Ryan Lortie [Tue, 18 May 2010 20:13:58 +0000 (16:13 -0400)]
Add sync method to GSettingsBackend, and pad
Ryan Lortie [Tue, 18 May 2010 17:43:42 +0000 (13:43 -0400)]
whitespace fix
Robert Ancell [Tue, 18 May 2010 02:01:25 +0000 (12:01 +1000)]
Add missing gunixfdlist.h include in gdbus-example-server.c
David Zeuthen [Mon, 17 May 2010 23:51:49 +0000 (19:51 -0400)]
GDBus: Fix obvious crasher when looking up annotations
Signed-off-by: David Zeuthen <davidz@redhat.com>
Fran Diéguez [Mon, 17 May 2010 21:59:42 +0000 (23:59 +0200)]
Updated Galician translations
David Zeuthen [Mon, 17 May 2010 15:08:53 +0000 (11:08 -0400)]
gdbus(1): Don't fetch props if introspection data indicates none are available
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 17 May 2010 15:07:53 +0000 (11:07 -0400)]
GDBus: Fix introspection of objects registered at /
Signed-off-by: David Zeuthen <davidz@redhat.com>
Ryan Lortie [Sun, 16 May 2010 20:56:36 +0000 (16:56 -0400)]
improve thread safety in GDelayedSettingsBackend
- hold a lock while accessing the tree of delayed values
- use weak reference counts with the owner object to avoid doing
g_object_notify on a dead object
- dispatch the "has-unapplied" notify to the proper main context
Ryan Lortie [Sun, 16 May 2010 18:17:34 +0000 (14:17 -0400)]
GSettingsBackend: make signal dispatch threadsafe
This commit fixes up a few race conditions in the GSettingsBackend, mostly with
respect to change notifications occuring at the same time as the last reference
count on a GSettings is dropped. With GDBus feeding us our incoming signals in
a separate thread, this is something that could easily happen.
Ryan Lortie [Sun, 16 May 2010 16:14:46 +0000 (18:14 +0200)]
gitignore additions for gdbus, new test cases
Ryan Lortie [Sun, 16 May 2010 11:02:23 +0000 (13:02 +0200)]
GSettings: support emitting signals in threads
The thread-default context that was in effect at the time that the
GSettings was created will be used for emitting signals on that
GSettings.
Ryan Lortie [Sun, 16 May 2010 11:03:34 +0000 (13:03 +0200)]
GSettings tool: work-around GDBus issue
There is currently no way (near as I can tell) to ensure that a message
has been sent when using GDBus. If we exit() before we are sure, then
it is very possible that the message isn't sent at all. This behaviour
was observed when using the GSettings commandline tool with dconf.
A quick and dirty workaround for now.
Ryan Lortie [Sun, 16 May 2010 08:19:46 +0000 (10:19 +0200)]
intern a key name instead of using strdup()
Lin Ma [Mon, 17 May 2010 06:42:52 +0000 (14:42 +0800)]
Reworked Solaris file event notification for GIO. See
https://defect.opensolaris.org/bz/show_bug.cgi?id=10194
Updated copyright.
Jorge González [Mon, 17 May 2010 05:41:48 +0000 (07:41 +0200)]
Updated Spanish translation
Matthias Clasen [Sun, 16 May 2010 17:07:25 +0000 (13:07 -0400)]
Add GDBus files to POTFILES.in
Fran Diéguez [Sun, 16 May 2010 14:31:25 +0000 (16:31 +0200)]
Updated Galician translations
Andika Triwidada [Sun, 16 May 2010 09:30:38 +0000 (16:30 +0700)]
Updated Indonesian translation
Sebastian Dröge [Sat, 15 May 2010 08:17:35 +0000 (10:17 +0200)]
Fix gio tests linking with binutils gold linker
Sebastian Dröge [Sat, 15 May 2010 08:13:28 +0000 (10:13 +0200)]
Fix build of gdbus tool with binutils gold linker
Matthias Clasen [Sat, 15 May 2010 22:23:23 +0000 (18:23 -0400)]
Expand information about schema translation
I have added some hints on how to use intltool for translation
of summary and description elements, taken from comments in bug #618523.
Matthias Clasen [Sat, 15 May 2010 22:15:30 +0000 (18:15 -0400)]
Fix build on !linux
Don't define __USE_GNU, thats a glibc-internal macro, and
don't use SOL_SOCKET when not including sys/socket.h.
Maybe this file should be called glinuxcredentialsmessage.c...
Bug #618730
Christian Persch [Sat, 15 May 2010 09:56:21 +0000 (11:56 +0200)]
Use the new option name
It's --schema-file now, not --schema-files.
Bug #616864.
Matthias Clasen [Sat, 15 May 2010 02:30:19 +0000 (22:30 -0400)]
Bump version
Matthias Clasen [Sat, 15 May 2010 02:28:46 +0000 (22:28 -0400)]
2.25.5
Matthias Clasen [Sat, 15 May 2010 02:03:03 +0000 (22:03 -0400)]
Updates
Matthias Clasen [Sat, 15 May 2010 01:58:08 +0000 (21:58 -0400)]
Fix issues with GSETTINGS_CHECK_RULE
Rename the --schema-files option to --schema-file, since it only
accepts one file at a time. Change the GSETTINGS_CHECK_RULE to
use it that way, too. And also make it work better with !srcdir
builds.
Bugs #616731 and #616864
David Zeuthen [Sat, 15 May 2010 01:08:01 +0000 (21:08 -0400)]
GDBus: Use specific variant type in GetAll()
Without this fix, we segfault if the exported object returned an error
on all get_property() calls (in reality, this never happens).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 15 May 2010 00:52:15 +0000 (20:52 -0400)]
GDBus: Fix a double free
Fix an unintentional double free introduced in commit
4ad4c306c3b80620185cf975b402e17a6174aea9.
This bug manifested itself when trying to complete this
$ gdbus introspect --system --dest <tab>
Christian Persch [Fri, 14 May 2010 18:07:15 +0000 (20:07 +0200)]
Plug mem leaks in gdbus tests & examples
Use "&s" instead of "s", and free the variant iters after use.
Bug #618663.
Christian Persch [Fri, 14 May 2010 16:21:01 +0000 (18:21 +0200)]
Plug a mem leak in gdbusauth
From valgrind running gdbus-peer test:
==20513== 32 bytes in 1 blocks are definitely lost in loss record 1 of 15
==20513== at 0x4024E4C: realloc (vg_replace_malloc.c:429)
==20513== by 0x4079BB1: g_realloc (gmem.c:174)
==20513== by 0x4099472: g_string_maybe_expand (gstring.c:396)
==20513== by 0x409A42A: g_string_insert_c (gstring.c:1050)
==20513== by 0x42169AC: g_string_append_c_inline (gstring.h:153)
==20513== by 0x421682C: _my_g_input_stream_read_line_safe (gdbusauth.c:336)
==20513== by 0x421843E: _g_dbus_auth_run_server (gdbusauth.c:1265)
==20513== by 0x4222B94: initable_init (gdbusconnection.c:1783)
==20513== by 0x41CF8D5: g_initable_init (ginitable.c:106)
==20513== by 0x41CFA8D: g_initable_new_valist (ginitable.c:219)
==20513== by 0x41CF920: g_initable_new (ginitable.c:139)
==20513== by 0x4223479: g_dbus_connection_new_sync (gdbusconnection.c:2046)
Bug #618650.
Christian Persch [Fri, 14 May 2010 12:27:08 +0000 (14:27 +0200)]
Plug mem leak in g_dbus_address_get_stream_sync
==6279== 21,615 (4,708 direct, 16,907 indirect) bytes in 169 blocks are
definitely lost in loss record 12 of 13
==6279== at 0x4024D2E: malloc (vg_replace_malloc.c:207)
==6279== by 0x4079A90: g_malloc (gmem.c:135)
==6279== by 0x4079DC8: g_malloc_n (gmem.c:252)
==6279== by 0x4097E66: g_strsplit (gstrfuncs.c:2434)
==6279== by 0x42169A2: g_dbus_address_get_stream_sync
(gdbusaddress.c:875)
Bug #618622.
Christian Persch [Fri, 14 May 2010 12:22:45 +0000 (14:22 +0200)]
Plug a mem leak in get_uninitialized_connection
Free the bus address after creating the singleton.
==26308== 39,736 (10,517 direct, 29,219 indirect) bytes in 388 blocks
are definitely lost in loss record 14 of 15
==26308== at 0x4024D2E: malloc (vg_replace_malloc.c:207)
==26308== by 0x4079A90: g_malloc (gmem.c:135)
==26308== by 0x4079DC8: g_malloc_n (gmem.c:252)
==26308== by 0x4095607: g_strdup (gstrfuncs.c:102)
==26308== by 0x4216B9A: g_dbus_address_get_for_bus_sync
(gdbusaddress.c:961)
==26308== by 0x422A7AE: get_uninitialized_connection
(gdbusconnection.c:5241)
Bug #618622.
Christian Persch [Fri, 14 May 2010 12:15:42 +0000 (14:15 +0200)]
Plug mem leaks in parse_value_from_blob
The result of read_string() was leaked.
Bug #618615.
Christian Persch [Fri, 14 May 2010 22:08:29 +0000 (18:08 -0400)]
Plug a mem leak
This code leaked the return value of g_variant_get_child_value();
use g_variant_get() instead and free the iter when done.
David Zeuthen [Fri, 14 May 2010 16:55:25 +0000 (12:55 -0400)]
GDBus: Remove cached value if a property is invalidated
Also add a test case to catch this.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 14 May 2010 16:49:51 +0000 (12:49 -0400)]
GDBus: Fix serialization of empty arrays
It turns out that we didn't observe padding (neither when reading nor
writing) for empty arrays which (apparently) is needed according to
the D-Bus spec and reference implementation. A simple test case to
provoke this behavior is as follows (notice the lack of 4 bytes worth
of padding at position 0x0064):
Error calling dbus_message_demarshal() on this blob: org.freedesktop.DBus.Error.InvalidArgs: Message is corrupted (Alignment padding not null)
0000: 6c 01 00 01 2e 00 00 00 41 00 00 00 37 00 00 00 l.......A...7...
0010: 08 01 67 00 08 73 61 7b 73 76 7d 61 73 00 00 00 ..g..sa{sv}as...
0020: 01 01 6f 00 08 00 00 00 2f 66 6f 6f 2f 62 61 72 ..o...../foo/bar
0030: 00 00 00 00 00 00 00 00 03 01 73 00 06 00 00 00 ..........s.....
0040: 4d 65 6d 62 65 72 00 00 11 00 00 00 30 31 32 33 Member......0123
0050: 34 35 36 37 38 39 30 31 32 33 34 35 36 00 00 00
4567890123456...
0060: 00 00 00 00 0e 00 00 00 09 00 00 00 53 6f 6d 65 ............Some
0070: 74 68 69 6e 67 00 thing.
The blob was generated from the following GVariant value:
('
01234567890123456', @a{sv} {}, ['Something'])
If the blob was encoded using DBusMessageIter, the payload would have been:
0000: 6c 01 00 01 32 00 00 00 41 00 00 00 36 00 00 00 l...2...A...6...
0010: 01 01 6f 00 08 00 00 00 2f 66 6f 6f 2f 62 61 72 ..o...../foo/bar
0020: 00 00 00 00 00 00 00 00 03 01 73 00 06 00 00 00 ..........s.....
0030: 4d 65 6d 62 65 72 00 00 08 01 67 00 08 73 61 7b Member....g..sa{
0040: 73 76 7d 61 73 00 00 00 11 00 00 00 30 31 32 33 sv}as.......0123
0050: 34 35 36 37 38 39 30 31 32 33 34 35 36 00 00 00
4567890123456...
0060: 00 00 00 00 00 00 00 00 0e 00 00 00 09 00 00 00 ................
0070: 53 6f 6d 65 74 68 69 6e 67 00 Something.
** ERROR:gdbus-serialization.c:547:check_serialization: code should not be reached
Aborted
and this is now in the libdbus-1-using serialization test case.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Jorge González [Fri, 14 May 2010 15:55:37 +0000 (17:55 +0200)]
Updated Spanish translation