isl_pw_*_union_add: don't subtract non-overlapping cells

There is no point in subtracting a cell from another if their intersection
is empty.  It can only lead to a further subdivision of the other cell.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: skip constraints implied by div expression

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_is_div_constraint

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

Conflicts:
isl_output.c

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: fix printing in C format

In 3280c05 (make isl_pw_* object live in a map space,
Tue Aug 30 16:47:59 2011 +0200), the space in which objects live was
changed from that of its domain to that of a map, but
isl_printer_print_pw_aff was not changed accordingly.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_pw_aff: call isl_pw_aff_union_add instead of isl_pw_aff_add

We missed this in 7a86dd8 (rename isl_pw_aff_add to isl_pw_aff_union_add,
Thu Oct 13 12:16:45 2011 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_vertices.c: compute_chambers: avoid access to freed data structure

The problem was introduced in 328c78f (isl_tab_from_basic_map: preserve all
constraints in input when tracking, Mon Jan 16 16:55:44 2012 +0100).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_pw_multi_aff_coalesce

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_pw_multi_aff_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_normalize: remove unused divs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_multi_aff_from_map: add a special case where result can be read off

If all output dimensions are uniquely defined in terms of the parameters
and input dimensions, we can directly read off the desired isl_pw_multi_aff.
This usually results in much simpler expressions.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_basic_map_plain_is_single_valued

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_pw_aff: simplify domain expression in C format

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_morph.c: fix typo in comment

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_basic_set_full_compression: detect equalities in input first

Without this explicit detection of equalities, some equalities
may be discovered in the middle of the computation, possibly
leading to the introduction of existentially quantified variables,
while callers of isl_basic_set_full_compression typically do not
want such variables.

Since the detection of equalities can in some cases be fairly expensive,
we may have to find a better way of dealing with this problem at some point.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_pw_qpolynomial: accept products of integer divisions

Before, we called accept_affine to parse an integer division that appears
inside a function, but accept_affine also parses a subsequent '*' and
then expects this '*' to be followed by a constant.
Call accept_div directly intead.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_union_set_product: call isl_set_product on entries

Before, we would simply delegate control to isl_union_map_product,
which calls isl_map_product on the entries.  This doesn't work
on isl_sets because they only have a "range" and no "domain".

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_pip.c: sol_add: skip empty contexts

If the context becomes non-empty inside find_solutions, we stop
looking for solutions since a89841a (isl_tab_pip.c: find_solutions: break
when context becomes empty, Sun Jan 31 18:29:12 2010 +0100), but
we still call sol_add.  We need to return from sol_add early in
such cases because there is nothing to do and, more importantly,
when a basic set is marked empty, its existentials are removed,
resulting in a mismatch in the number of dimensions.  In particular,
the basic set returned by sol_domain may not satisfy all assumptions
made by the remainder of sol_add.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_space_set_dim_id: also set id of parameter in nested spaces

A nested space is supposed to have the same parameters as
the nesting space, so if the id of a parameter in the nesting
space space changes, it has to be changed in the nested spaces too.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_space_set_dim_id: rename "dim" variable to "space"

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: replace split_parallel by split_scaled option

The split_parallel option was ill-conceived.
The condition split_parallel looked for was too specific
and the implementation was wrong.  Part of this has been fixed
in 1b2fdb6 (schedule.c: split_parallel: avoid invalid memory accesses,
Mon Jan 30 15:23:18 2012 +0100), but the code could in principle
still produce an incorrect schedule because it didn't check the sizes
of the constant terms.

The new option essentially applies strip-mining and should therefore
be safe.  In particular, it is applied when the linear parts of the
schedules have a non-trivial common divisor.  The strip-mining is
then performed with respect to this common divisor.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_mat_scale_down_row

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Add isl_union_map_gist_range

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

scheduler: add an option to configure the level of fusing

We currently only support maximal (the old behavior) and minimal fusion.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

schedule.c: split_parallel: avoid invalid memory accesses

The original code incorrectly assumed that the schedules for
all statements have the same number of columns, i.e., that the
dimensions of the iteration domains of all statements are the same.

We fix this up by simply bailing out if we find this assumption not to hold.
We will improve the applicability of the transformation performed by
split_parallel in a subsequent patch.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

update for change in clang's HandleTopLevelDecl return type

In recent versions of clang, HandleTopLevelDecl should return a boolean
indicating whether parsing should continue.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

configure.ac: only link against libraries from LLVM analysis component

Before, we would link against all LLVM components, which would make
us depend on google-test.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

put annotations after "struct"

Recent versions of clang require the annotations to be placed after "struct".

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_pw_aff_non_zero_set: don't assume isl_pw_aff is total

Before, we would return the domain where the function is not zero
or undefined, whereas we should only return the domain where the function
is not zero.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_nonneg_basic_set and isl_aff_zero_basic_set: simplify result

The constructed constraint may be a tautology in which case it needs
to be simplified away, especially if it is an equality.

We probably want to perform this simplification in
isl_basic_set_from_constraint instead, but CLooG currently depends
on the resulting basic set not being simplified.
We would have to fix CLooG first before we can change this behavior.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_from_basic_map: preserve all constraints in input when tracking

If the user wants to keep track of a basic map representation of the tableau,
then we need to make sure that the initial tableau corresponds exactly to
the input.  In particular, we need to make sure that no (redundant) constraints
are removed.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_track_bmap: drop sanity checks in case of empty tab

If tab is empty, then we may not have added all constraints of "bmap"
and so the number of constraints in tab and bmap may be different.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_track_bmap: make sure we have a unique copy of the basic map

The basic map will be modified in place by isl_tab_add_ineq.
Some callers were passing a unique copy to isl_tab_track_bmap
already, but some others apparently were not.
It's safer to just let isl_tab_track_bmap take care of this.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_tab_track_bmap: fix memory leak on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_remove_unknown_divs: restart whenever div has been removed

The call to isl_basic_map_remove_dims may end up calling
isl_basic_map_simplify, which may in turn remove additional divs
if they no longer occur in any constraint.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_simple_hull: improve error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_multi_aff_drop_dims

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_aff_drop_dims: handle removal of output dimensions

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_aff_set_aff: improve error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_aff_set_tuple_id

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_aff_on_shared_domain: perform gist on results wrt shared domains

The shared domain may have extra constraints compared to the original
domains, which may help to simplify some of the integer divisions involved.
As a side effect, the gist operation may also simplify integer divisions
that could have been simplified even on a universe domain.
We should probably handle such cases much earlier during the construction
of isl_affs.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_aff_project_domain_on_params

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_aff_align_params

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_printer_print_aff: only print () when needed in C format

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_gist: normalize result

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_schedule.c: mark row constructed by compute_split_schedule as non-zero

compute_split_schedule is only called when no zero-distance schedule row
could be found on the entire graph.
We missed this part in ee1ca56 (isl_schedule.c: keep track of parallel loops,
Sun May 29 19:41:55 2011 +0200).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_project_out: properly handle named or nested spaces

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_arg_parse: reset all flags with same option name whenever a flag is set

Otherwise, there is no way to turn off a flag that is set by default.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_ctx_peek_options: special case isl_options_args

The isl_options_args options are always available, even
when they do not appear in ctx->user_opt.
Just return them instead of looking through ctx->user_opt.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_compute_vertices: set activity domain on single vertex

isl_basic_set_compute_vertices always sets the activity domains of
the vertices, except when there is only a single vertex.
Chnage vertices_0D to also set the activity domain in this case.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_morph_{dom,ran}_params: add missing isl_morph_cow

Usually, isl_morph_remove_{dom,ran}_dims will call isl_morph_cow for us,
but not when n == 0.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info: allow user interaction to restrict potential sources

In particular, the user can register a callback that will be called
any time right before the last potential source is computed.
This should be useful for fuzzy array dataflow analysis.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info_compute_flow: store sink domain map in isl_access_info

We will be able to reuse this map in the next commit.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info_alloc: use isl_calloc to allocate structure

This makes it easier to add new (zero-by-default) fields.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_access_info_compute_flow: don't pass ownership of "acc" down

This slightly simplifies the error handling.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl 0.09

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

avoid "errno" argument name

On mingw, errno is defined as (*_errno()) in stdlib.h

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_morph_dump

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

rename isl_morph_dump to isl_morph_print_internal

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_compute_vertices: fix handling of lower-dimensional input

Support was broken by 9043b59 (explicitly differentiate between spaces
of maps, sets and parameter sets, Thu Aug 25 19:21:05 2011 +0200).
This fix should have gone in before that commit.

Reported-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: improve consistency in list of schedule options

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add Feautrier's scheduling algorithm

Offer Feautrier's algorithm as an alternative to isl's default scheduling
algorithm.  The schedule is extended to a full-dimensional schedule.
To select the scheduling algorithm to use, we introduce isl option
schedule-algorithm.

Signed-off-by: Sven van Haastregt <svhaastr@liacs.nl>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add option to bound the constant scheduling coefficients

If larger coefficients appear as part of the input dependences, the
schedule calculation can take a very long time. We observed that the
main overhead in this calculation is due to optimizing the constant
coefficients. They are misused to increase locality by merging several
unrelated dimensions into a single dimension. This unwanted optimization
increases the complexity of the code and slows down the generated code.

We introduce a new option that bounds the values in the constant
dimension by a user defined value. If the right value is choosen,
costly overoptimization can be prevented.

This solution works, but requires the user to specify the value by
which the constants are bound. For the moment, this is our best
solution, but we hope to to find a more generic one later on.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Introduce new ISL_CTX_(GET|SET)_INT_DEF macro

This macro uses the same implementation as the corresponding
BOOL and CHOICE macros. Hence, we simplify BOOL and CHOICE by
forwarding to the new INT macro.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Fix typo in documentation

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Add interface to set schedule_maximize_band_depth

Previously, schedule_maximize_band_depth could only be set with the
corresponding command line option. This patch adds two functions
to change this option when using isl as a library.

int isl_options_set_schedule_maximize_band_depth(
isl_ctx *ctx, int val);
int isl_options_get_schedule_maximize_band_depth(
isl_ctx *ctx);

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc/SubmittingPatches: fix typo in email address

Signed-off-by: Sven van Haastregt <svhaastr@liacs.nl>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export schedule_split_parallel option

Signed-off-by: Sven van Haastregt <svhaastr@liacs.nl>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_multi_aff_get_pw_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_map_from_pw_aff: handle NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_space_map_from_domain_and_range

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Introduce option 'on_error'

The option on_error defines the behaviour of isl in case of an error.
By default, the option is set to 'warn'. This is the current behaviour
and means isl prints a warning and continues the execution of the
program. We also introduce two new modes: 'continue' and 'abort'.
'continue' does not print any warning, but continues execution and 'abort'
abort the program from within isl.  'abort' is useful for debuggers as
they automatically break at the place of the error condition.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_map_eliminate

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Improve message when ctx is freed, but still referenced

Instead of a cryptic 'Assertion "ctx->ref == 0" failed' we report
'isl_ctx freed, but some objects still reference it'.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_local_space_range

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_pw_aff_scale: don't special case multiplication with zero

isl_pw_*_scale returns an empty result if a multiplication with zero
is being performed.  We do this because zero is the default value
for polynomials.  Affine expressions, by contrast, have no default value
and so we should not return an empty result in this case.

Reported-by: Tomofumi Yuki <tomofumi.yuki@gmail.com>
Tested-by: Tomofumi Yuki <tomofumi.yuki@gmail.com>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_find_dim_by_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_involves_dims: double-check divs

In principle, the extra test is not needed at this moment, but
this may change in future.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_schedule.c: fix typo in comment

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

configure.ac: only create interface/Makefile if user has clang

This allows users without clang to perform a "make dist".

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_has_dim_id

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add missing namespace qualification on llvm::ArrayRef

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

Merge branch 'maint'

isl_union_pw_*_{intersect_domain,gist}: update to change of isl_pw_* space

In 3280c05 (make isl_pw_* object live in a map space,
Tue Aug 30 16:47:59 2011 +0200), the space in which objects live was
changed from that of its domain to that of a map, but
isl_union_pw_*_{intersect_domain,gist} were not changed accordingly.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_insert_dims: handle NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_set_from_pw_aff: handle NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

document isl_basic_map_set_tuple_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

.gitignore: add isl_config.h.in~

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_arg_parse: support string list arguments

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

hide isl_options structure

We also add some getters and setters for options that are known to
be used from outside of isl.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

introduce isl_args structure that constains isl_arg list and size of options

Before, the size of the options structure of a submodule was stored
inside the corresponding child option of the parent.
This however, requires that the options structure of the submodule
is visible to the parent so that it can compute the size of this structure.
Moreover, if the size of this structure changes, then the code
containing the child option, which may reside in a different module,
would have to be recompiled.

Now, we store the size of the options structure together with the list
of option descriptions.  In particular, it is stored in the same module
as the options structure itself, so that this structure no longer needs
to be exposed.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_ctx_parse_options

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_arg_parse: print current option values as defaults

In the --help output, we used to print the default values stored
in the isl_arg objects as the defaults for options.
It is however sometimes convenient to change some of the options
to values different from their true defaults before allowing
the user to override these options.  It then makes more sense
to print the current values of the options as defaults, rather
than the defaults that were used during the construction of
options object.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>