Cijo Thomas [Sun, 3 May 2020 10:33:59 +0000 (03:33 -0700)]
Fix minor typo in comment. (#35768)
Tomáš Rylek [Sun, 3 May 2020 07:59:27 +0000 (09:59 +0200)]
Baseline SimpleSIMDProgram failing with CG2; fix typo in build-test.cmd (#35757)
Jan Kotas [Sun, 3 May 2020 05:50:41 +0000 (22:50 -0700)]
Revert "Add Reverse Diagnostics Server (#33307)" (#35767)
This reverts commit
629dba55058b58a126d08fc37db30b0cfa844dde.
Aaron Robinson [Sun, 3 May 2020 00:39:18 +0000 (17:39 -0700)]
Ensure the function pointer being returned is from an active method. (#35750)
Bruce Forstall [Sat, 2 May 2020 22:58:51 +0000 (15:58 -0700)]
Enable src/JIT/Methodical/explicit/coverage tests on non-Windows (#34250)
Eirik Tsarpalis [Sat, 2 May 2020 21:34:00 +0000 (22:34 +0100)]
[CBOR] Implement Conformance Levels (#35246)
* implement writing sorted keys in maps
* rename NoConformance to NonStrict
* add tests for strict mode map writes
* extract common conformance level logic to helper class
* implement reader map conformance levels
* add missing struct labels
* NonStrict -> Lax
* implement CborWriter indefinite length conformance levels
* implement CborWriter tag conformance levels
* remove preserve float representation check
* implement CborReader integer encoding conformance
* implement CborReader indefinte-length conformance
* implement CborReader tag conformance level validation
* factor frame struct out of checkpoint struct
* use HashSet for reader key uniqueness
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Integer.cs
Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* address tuple label naming consistency
* address PR feedback
* address tuple label style
* implement appropriate rollback semantics for key conformance validation
* rename CborWriter.ToArray() => CborWriter.GetEncoding(); add a span encoding method
* implement patching for indefinite-length items
* minor CborReader string refactoring
* add support for indefinite byte string literals in reader helpers
* Implement CborReader.SkipToParent();
* add a validateConformance parameter to Skip* methods
* implement CborWriter encodeIndefiniteLengths parameter
* make ReadStartMap() and ReadStartArray() return int
* strip IndefiniteLength suffix from write methods
* replace SortedList use with HashSet
* pool key encoding range HashSets
* implement writing and reading multiple root-level values
* I am disappoint
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborConformanceLevel.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Array.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Map.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* address PR feedback
* clean up code and add comments; remove unneeded synchronization
* rework CborWriter map sorting implementation
* store current major type in a field
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Stephen Toub [Sat, 2 May 2020 20:42:39 +0000 (16:42 -0400)]
Improve ContinueWith perf with NotOn* options (#35575)
* Delete dead code from Task.InternalCancel
The bCancelNonExecutingOnly argument was always false.
* Rename StandardTaskContinuation to ContinueWithTaskContinuation
* Remove unused return value from InternalCancel
* Combine two overloads
There's no point in these being separate, with one being small and only and always called from the other.
* Streamline ContinueWith completions for NotOn*
We can avoid unnecessarily instantiating the contingent properties bag, as well as a few interlocked operations.
Santiago Fernandez Madero [Sat, 2 May 2020 19:58:22 +0000 (12:58 -0700)]
Use GDI+1.1 API set in Windows 8 and later (#35169)
* Use GDI+1.1 API set in Windows 8 and later
* PR Feedback, add meaningful test
* Update System.Drawing test package from runtime-assets
* PR Feedback and skip test on full framework
Aaron Robinson [Sat, 2 May 2020 19:40:49 +0000 (12:40 -0700)]
Fix spurious error message in libnethost.lib scenarios (#35739)
1) Empty paths don't exist, so no attribute will be found.
2) Remove string copy.
Stephen Toub [Sat, 2 May 2020 19:24:59 +0000 (15:24 -0400)]
Remove FromAsync usage from System.Net.NetworkInformation (#35710)
Eirik Tsarpalis [Sat, 2 May 2020 18:59:41 +0000 (19:59 +0100)]
store current major type in a field
Eirik Tsarpalis [Sat, 2 May 2020 18:10:47 +0000 (19:10 +0100)]
rework CborWriter map sorting implementation
Tomas Weinfurt [Sat, 2 May 2020 16:09:57 +0000 (09:09 -0700)]
build HTTP on FreeBSD once again (#35742)
Stephen Toub [Sat, 2 May 2020 16:02:25 +0000 (12:02 -0400)]
Remove FromAsync usage from SendPacketsAsync on Unix (#35513)
This call is in the Unix implementation, and the Unix implementation of DisconnectAsync just calls the synchronous Disconnect... so we can just call it directly and skip all the unnecessary layering.
Carol Eidt [Sat, 2 May 2020 15:58:57 +0000 (08:58 -0700)]
Fix ZeroInit of finally vars (#35723)
Finally vars need zero-init'ing if we are enregistering them, but they will not necessarily be live-in to the first block, so we have to take care not to zero-init its last associated register in that case.
Tomas Weinfurt [Sat, 2 May 2020 09:11:44 +0000 (02:11 -0700)]
fix handling of COMPlus_ZapDisable (#35741)
Jan Kotas [Sat, 2 May 2020 07:52:34 +0000 (00:52 -0700)]
Fix CoreCLR incremental builds (#35732)
Layomi Akinrinade [Sat, 2 May 2020 06:18:53 +0000 (02:18 -0400)]
Merge pull request #35700 from layomia/clean_up
Clean up misc areas in JsonSerializer
Anton Lapounov [Sat, 2 May 2020 02:55:58 +0000 (19:55 -0700)]
Support ARM64 HVAs in Crossgen2 (#35576)
• Change FieldLayoutAlgorithm.ComputeValueTypeShapeCharacteristics method to compute the homogeneous aggregate element type and cache it in the existing field. That allows to remove all ComputeHomogeneousFloatAggregateElementType methods.
• Change MetadataFieldLayoutAlgorithm.ComputeHomogeneousAggregateCharacteristic to compute HVAs in addition to HFAs.
• Change CorInfoImpl.getHFAType JIT callback to handle HVAs. Note that returning ELEMENT_TYPE_VALUETYPE indicates the TYP_SIMD16 type (see Compiler::GetHfaType).
• Change TypeFixupSignature.EncodeTypeLayout to handle HVAs.
• Support HVAs in the ArgIterator class.
• Fix TransitionBlock.OffsetFromGCRefMapPos for ARM64. R2RDump used to dump incorrect offsets.
• Use TransitionBlock.OffsetFromGCRefMapPos in GCRefMapBuilder.GetCallRefMap to simplify logic.
• Remove ARM64 .NET Native-specific code from TransitionBlock.cs and ArgIterator.cs files.
Minor:
• Remove a redundant GetVectorSize check in MethodTable::GetHFAType.
• Improve an assertion in Compiler::raUpdateRegStateForArg.
• Fix comments in JIT code.
Layomi Akinrinade [Fri, 1 May 2020 17:21:21 +0000 (10:21 -0700)]
Move collection tests to dedicated class + more clean up
Stephen Toub [Sat, 2 May 2020 00:27:00 +0000 (20:27 -0400)]
Fix test after TcpClient change (#35721)
My change to TcpClient.ConnectAsync resulted in a sporadic test failure. ConnectAsync had been implemented in terms of Begin/EndConnect. It would call BeginConnect, and then the callback invoked when the asynchronous operation completed would call EndConnect. The very first thing EndConnect would do is check whether the TcpClient was disposed, and throw an ObjectDisposedException if it is, ignoring the actual result or failure in the callback. By changing the ConnectAsync implementation to bypass Begin/EndConnect, it's also skipping that check, and so if you dispose of the TcpClient while the operation is in flight, you'll end up with a SocketError.OperationAborted SocketException (exactly what you get from Socket) rather than an ObjectDisposedException.
Since SocketException was already possible from TcpClient.ConnectAsync (and is documented as such), since we want an actual error to propagate rather than hiding it with a different one, since this is about behavior after dispose, and since this is effectively an implementation detail that was leaking out, I've opted to fix the test rather than change the implementation.
Egor Chesakov [Fri, 1 May 2020 23:30:22 +0000 (16:30 -0700)]
[Arm64] Fix JIT/HardwareIntrinsics/Arm/AdvSimd tests (#35726)
* Set LargestVectorSize to 16 where it must be in GenerateTests.csx
* Update AdvSimd/
Eugene Rozenfeld [Fri, 1 May 2020 19:50:55 +0000 (12:50 -0700)]
Remove an unnecessary check from fgMakeOutgoingStructArgCopy. (#35701)
The old-style helper tail calls required the jit to copy implicit by-ref
args. After #341 we are using old-style helper tail calls only for x86,
which doesn't have implicit by-ref parameters. So the check is no longer
necessary.
This is a no-diffs cleanup change.
Stephen Toub [Fri, 1 May 2020 18:56:52 +0000 (14:56 -0400)]
Fix comment on CancellationTokenRegistration.Token (#35708)
dotnet-maestro[bot] [Fri, 1 May 2020 18:39:24 +0000 (18:39 +0000)]
[master] Update dependencies from mono/linker dotnet/xharness (#35703)
* Update dependencies from https://github.com/dotnet/xharness build
20200430.6
- Microsoft.DotNet.XHarness.Tests.Runners: 1.0.0-prerelease.20230.2 -> 1.0.0-prerelease.20230.6
* Update dependencies from https://github.com/mono/linker build
20200430.3
- Microsoft.NET.ILLink.Tasks: 5.0.0-preview.3.20229.1 -> 5.0.0-preview.3.20230.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
David Wrighton [Fri, 1 May 2020 17:41:15 +0000 (10:41 -0700)]
Pointer types are decomposable by the JIT (#35673)
- Fix getChildType, and getArgType
- getArgType fix involves updating asCorInfoType to match native behavior
Fixes #34734
Layomi Akinrinade [Wed, 29 Apr 2020 17:38:47 +0000 (10:38 -0700)]
Clean up misc areas in JsonSerializer
Tamar Christina [Fri, 1 May 2020 17:14:32 +0000 (18:14 +0100)]
Add TBL and TBX emitter tests and make displayer always emit 16B. (#35707)
Eirik Tsarpalis [Fri, 1 May 2020 16:41:03 +0000 (17:41 +0100)]
clean up code and add comments; remove unneeded synchronization
Stephen Toub [Fri, 1 May 2020 15:56:39 +0000 (11:56 -0400)]
Update nullability.md with note about Try methods and [NotNullWhen(true)] (#35711)
Stephen Toub [Fri, 1 May 2020 15:50:02 +0000 (11:50 -0400)]
Change ManagedWebSocket to send pong frame for keep-alive (#35644)
Mitchell Hwang [Fri, 1 May 2020 15:27:50 +0000 (11:27 -0400)]
[eng] Fix condition on RunTestsCommand property (#35709)
Co-authored-by: Mitchell Hwang <mihw@microsoft.com>
Stephen Toub [Fri, 1 May 2020 15:07:43 +0000 (11:07 -0400)]
Remove FromAsync usage from TcpClient (#35512)
Eirik Tsarpalis [Fri, 1 May 2020 14:40:26 +0000 (15:40 +0100)]
address PR feedback
Eirik Tsarpalis [Fri, 1 May 2020 14:36:40 +0000 (15:36 +0100)]
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.Map.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Eirik Tsarpalis [Fri, 1 May 2020 14:24:51 +0000 (15:24 +0100)]
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Eirik Tsarpalis [Fri, 1 May 2020 14:24:08 +0000 (15:24 +0100)]
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Tag.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Egor Bogatov [Fri, 1 May 2020 14:09:36 +0000 (17:09 +0300)]
[mono] Pass category=failing and category=outerloop to Android and iOS (#35665)
Eirik Tsarpalis [Fri, 1 May 2020 14:06:11 +0000 (15:06 +0100)]
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Array.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Eirik Tsarpalis [Fri, 1 May 2020 14:05:58 +0000 (15:05 +0100)]
Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborConformanceLevel.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
nietras [Fri, 1 May 2020 13:30:46 +0000 (15:30 +0200)]
IntroSort minor cleanup, remove unnecessary 'hi' (#35663)
* IntroSort minor cleanup, remove unnecessary 'hi'
* Apply suggestions from code review
Co-authored-by: nietras <nietras@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Mitchell Hwang [Fri, 1 May 2020 11:58:29 +0000 (07:58 -0400)]
[libraries] Build lib-runtime-packs for all of mono, not just mobile (#35295)
* [libraries] Build lib-runtime-packs for all of mono, not just mobile
* [libraries] Build lib-runtime-packs for all of mono, not just mobile
* [libraries] Remove dotnet and unnecessary files from lib-runtime-packs
* [libraries] Reinclude dotnet and other files into test host
* [libraries] Alternative to excluding dotnet and other files from lib-runtime-packs
* Undo alternative changes for exclude dotnet and other files from lib-runtime-packs
This reverts commit
8cecd66db2024b4dd859212399fb69725c29fdf2.
* BinPlace native libs + runtime into testhost for desktop mono
* Removed comment
* [libraries] Remove redundant condition from ItemGroup in SetupRuntimePackNative
Co-authored-by: Mitchell Hwang <mihw@microsoft.com>
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
monojenkins [Fri, 1 May 2020 08:21:12 +0000 (04:21 -0400)]
[wasm] Integrate the m2n-gen.cs tool into mcs/tools/wasm-tuner. (#35660)
It should be ran as:
mono wasm-tuner.exe --gen-interp-to-native <output file name> <extra assemblies>.
The <extra assemblies> will be searched for pinvoke methods, and their signatures
will be added to the set of supported signatures.
<!--
Thank you for your Pull Request!
If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.
Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Egor Chesakov [Fri, 1 May 2020 02:47:01 +0000 (19:47 -0700)]
[Arm64] Implement ASIMD widening, narrowing, saturating intrinsics (#35612)
* AbsoluteDifferenceWideningLower and AbsoluteDifferenceWideningUpper
* AbsoluteDifferenceWideningLowerAndAdd and AbsoluteDifferenceWideningUpperAndAdd
* AddPairwiseWidening{Scalar}
* AddPairwiseWideningAndAdd{Scalar}
* AddSaturate{Scalar}
* AddWideningLower and AddWideningUpper
* FusedAddHalving
* FusedAddRoundedHalving
* FusedSubtractHalving
* MultiplyWideningLower and MultiplyWideningUpper
* MultiplyWideningLowerAndAdd and MultiplyWideningUpperAndAdd
* MultiplyWideningLowerAndSubtract and MultiplyWideningUpperAndSubtract
* SubtractSaturate{Scalar}
* SubtractWideningLower and SubtractWideningUpper
* AddReturningHighNarrowLower and AddReturningHighNarrowUpper
* AddReturningRoundedHighNarrowLower and AddReturningRoundedHighNarrowUpper
* SubtractReturningHighNarrowLower and SubtractReturningHighNarrowUpper
* SubtractReturningRoundedHighNarrowLower and SubtractReturningRoundedHighNarrowUpper
Eric Erhardt [Fri, 1 May 2020 01:25:41 +0000 (20:25 -0500)]
Strip the ILLinkTrim.xml file from System.Private.Xml (#35547)
* Strip the ILLinkTrim.xml file from System.Private.Xml
The two methods being preserved in System.Private.Xml (CreateSqlReader and GenerateSerializer) are large, and are not necessary when linking a mobile app. These methods only need to be preserved when linking the shared framework. When a normal app is linked, the linker is able to figure out if the two methods are necessary.
Contributes to #35199
Fix #30912
* Respond to PR feedback
- Add PreserveDependencyAttribute to SqlXml to be explicit.
- Rename ILLinkTrim.xml to ILLinkTrim_LibraryBuild.xml when it shouldn't be embedded in the resulting assembly.
Steve MacLean [Fri, 1 May 2020 00:18:34 +0000 (20:18 -0400)]
Cleanup src/coreclr/src/inc/src/metadata.h (#35621)
* Cleanup src/coreclr/src/inc/src/metadata.h
Remove #include of private implementation headers
Fix build breaks
* Remove stray #undef __unaligned
Egor Chesakov [Thu, 30 Apr 2020 23:35:36 +0000 (16:35 -0700)]
[Arm64] Implement Vector64/128.CreateScalar() using AdvSimd.Insert (#35300)
dotnet-maestro[bot] [Thu, 30 Apr 2020 21:20:03 +0000 (17:20 -0400)]
[master] Update dependencies from dotnet/arcade Microsoft/vstest dotnet/xharness (#35662)
* Update dependencies from https://github.com/dotnet/arcade build
20200428.4
- Microsoft.DotNet.XUnitExtensions: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.VersionTools.Tasks: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.ApiCompat: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.Arcade.Sdk: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.Build.Tasks.Feed: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.Build.Tasks.Packaging: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.CodeAnalysis: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.XUnitConsoleRunner: 2.5.1-beta.20224.11 -> 2.5.1-beta.20228.4
- Microsoft.DotNet.GenAPI: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.Helix.Sdk: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.RemoteExecutor: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
- Microsoft.DotNet.GenFacades: 5.0.0-beta.20224.11 -> 5.0.0-beta.20228.4
* Update dependencies from https://github.com/microsoft/vstest build
20200429-01
- Microsoft.NET.Test.Sdk: 16.7.0-preview-
20200428-01 -> 16.7.0-preview-
20200429-01
* Update dependencies from https://github.com/dotnet/xharness build
20200430.1
- Microsoft.DotNet.XHarness.Tests.Runners: 1.0.0-prerelease.20229.6 -> 1.0.0-prerelease.20230.1
* Update dependencies from https://github.com/dotnet/xharness build
20200430.2
- Microsoft.DotNet.XHarness.Tests.Runners: 1.0.0-prerelease.20229.6 -> 1.0.0-prerelease.20230.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Levi Broderick [Thu, 30 Apr 2020 20:50:48 +0000 (13:50 -0700)]
Implement TranscodingStream (#35145)
This is a streaming analog to the one-shot Encoding.Convert method.
Steve MacLean [Thu, 30 Apr 2020 20:35:49 +0000 (16:35 -0400)]
Feedback from 3.1 amd64InstrDecode review (#35670)
* Feedback from 3.1 amd64InstrDecode review
* More feedback and cleanup
* One more
Steve MacLean [Thu, 30 Apr 2020 20:09:21 +0000 (16:09 -0400)]
Remove unused library definition (#35668)
Tomas Weinfurt [Thu, 30 Apr 2020 19:16:33 +0000 (12:16 -0700)]
improve resiliency of process tests (#35584)
* impove resiliency of process tests
* feedback from review
* dispose process
Co-authored-by: Tomas Weinfurt <furt@Shining.local>
Eirik Tsarpalis [Thu, 30 Apr 2020 18:44:29 +0000 (19:44 +0100)]
I am disappoint
Eirik Tsarpalis [Thu, 30 Apr 2020 18:32:22 +0000 (19:32 +0100)]
implement writing and reading multiple root-level values
Clinton Ingram [Thu, 30 Apr 2020 17:24:54 +0000 (10:24 -0700)]
disable LZCNT in crossgen (#35598)
Now that BitOperations.TrailingZeroCount has a fallback to BSR, the cost of querying Lzcnt.IsSupported before using LZCNT is higher than simply using the fallback. This is a situation very specific to LZCNT because it's most often a one-and-done instruction and the fallback is only very marginally slower.
Note that this change applies only to crossgen, as the hardware intrinsic model differs for crossgen2 and it was decided that this change isn't appropriate for that different model.
David Wrighton [Thu, 30 Apr 2020 17:17:12 +0000 (10:17 -0700)]
Don't notify crossgen2 about Vector<T> size when not needed (#34614)
- Stop notifying about usage status of AVX2 when using isSubRegisterSIMDType
- This allows use of the Vector2/3/4 simd types in crossgen'd code without fixing whether or not Avx2 is required
Tamar Christina [Thu, 30 Apr 2020 17:02:03 +0000 (18:02 +0100)]
Add VectorTableList and TableVectorExtension intrinsics (#35600)
Eric Erhardt [Thu, 30 Apr 2020 14:54:26 +0000 (09:54 -0500)]
Set charset in editorconfig for .csproj (#35634)
* Add editorconfig charset for csproj files.
This stops VS from inserting a BOM in these files.
* Removing BOM from .csproj files.
Nathan Ricci [Thu, 30 Apr 2020 14:50:58 +0000 (10:50 -0400)]
Run runtime tests with mono on test change. (#35604)
Adding tests or modifyig build-test.sh will run runtime tests on mono (in addition to coreclr).
dotnet-maestro[bot] [Thu, 30 Apr 2020 12:22:02 +0000 (14:22 +0200)]
Update dependencies from https://github.com/dotnet/xharness build
20200429.6 (#35659)
monojenkins [Thu, 30 Apr 2020 12:19:27 +0000 (08:19 -0400)]
Disable a few executables if DISABLE_EXECUTABLES is defined. (#35653)
Tomáš Rylek [Thu, 30 Apr 2020 10:53:30 +0000 (12:53 +0200)]
Add new unit test demonstrating a JIT crash in Crossgen2 build mode (#35623)
Egor Bogatov [Thu, 30 Apr 2020 09:44:50 +0000 (12:44 +0300)]
Integrate Android into /t:Test (#35640)
Integrate Android into the "Test" workflow, e.g.:
```
./build.sh -os Android -arch arm64 -subset Mono+Libs
cd src/libraries/System.Buffers/tests
dotnet build /p:TargetOS=Android /p:TargetArchitecture=arm64 /t:Test
```
^ should run tests for any test suite on an active device or emulator.
dotnet-maestro[bot] [Thu, 30 Apr 2020 08:40:47 +0000 (10:40 +0200)]
[master] Update dependencies from 5 repositories (#35567)
Sergey Andreenko [Thu, 30 Apr 2020 07:37:26 +0000 (00:37 -0700)]
Disable two failing tests. (#35652)
Eugene Rozenfeld [Thu, 30 Apr 2020 07:22:19 +0000 (00:22 -0700)]
Fix compFastTailCalls check. (#35596)
compFastTailCalls is true if COMPlus_FastTailCalls is not 0.
It was introduced in #341 to help with testing:
setting COMPlus_FastTailCalls to 0 forces all tail-prefixed
calls to be dispatched via helpers.
This fixes a subtle bug with checking compFastTailCalls:
it needs to be checked after `fgInitargInfo` has been called in
`fgCanFastTailCall`. `fgInitArgInfo` adds the stub address for VSD calls
and `fgMorphTailCallViaHelpers` then removes it.
This change also factors out the logic for checking whether the call
has byref parameters that must be copied by the caller.
Simon Nattress [Thu, 30 Apr 2020 06:53:34 +0000 (23:53 -0700)]
Baseline profiler/rejit/rejit/rejit.cmd (#35641)
Related issue: https://github.com/dotnet/runtime/issues/35639
Steve MacLean [Thu, 30 Apr 2020 03:20:37 +0000 (23:20 -0400)]
Remove problematic #undef _ASSERTE (#35630)
Egor Chesakov [Thu, 30 Apr 2020 02:40:29 +0000 (19:40 -0700)]
Remove HW_Flag_UnfixedSIMDSize (#35594)
* Remove HW_Flag_UnfixedSIMDSize usages in hwintrinsiclistarm64.h
* Remove HW_Flag_UnfixedSIMDSize usages in hwintrinsiclistxarch.h
* Remove HW_Flag_UnfixedSIMDSize and HWIntrinsicInfo::HasFixedSimdSize() in hwintrinsic.cpp hwintrinsic.h
* Change HWIntrinsicInfo::simdSize type to int and remove all the casts in hwintrinsic.cpp hwintrinsic.h
Steve MacLean [Thu, 30 Apr 2020 02:28:17 +0000 (22:28 -0400)]
Revert "Remove obsolete managedOsxBuild et. al (#35356)" (#35647)
This reverts commit
5b9fe8f29f0429ad410eaeefdffed59509d83176.
Steve MacLean [Thu, 30 Apr 2020 01:43:36 +0000 (21:43 -0400)]
Remove obsolete managedOsxBuild et. al (#35356)
* Remove obsolete managedOsxBuild et. al
Remove managedOsxBuild
Remove managedTestBuildOsGroup
Remove managedTestBuildOsSubgroup
Stephen Toub [Thu, 30 Apr 2020 01:25:08 +0000 (21:25 -0400)]
Delete DataContractSerializer's ILLinkTrim.xml file (#35520)
The whole assembly isn't being trimmed:
```
<!-- Too much private reflection. Do not bother with trimming -->
<ILLinkTrimAssembly>false</ILLinkTrimAssembly>
```
(On top of that, the set_Option that's being kept here is only set via reflection by test code that's not actually built today; it's guarded behind a compilation constant that's not set.)
Jeremy Barton [Thu, 30 Apr 2020 01:23:33 +0000 (18:23 -0700)]
Update link from corefx to runtime (#35633)
Tomas Weinfurt [Thu, 30 Apr 2020 01:23:19 +0000 (18:23 -0700)]
handle UnauthorizedAccessException from mmap on OSX (#35619)
* handle UnauthorizedAccessException on OSX
* update SkipTestException text
* add comments
Co-authored-by: Tomas Weinfurt <furt@Shining.local>
mrj001 [Wed, 29 Apr 2020 23:13:46 +0000 (17:13 -0600)]
Invalid derivation of fixed fractionDigits (#34973)
* Added code to throw XmlSchemaException if the derived type attempts to alter the fixed value of fractionDigits from the base type.
Tomáš Rylek [Wed, 29 Apr 2020 21:18:28 +0000 (23:18 +0200)]
Add OS loader relocation type statistics to Crossgen2 map file (#35587)
David Wrighton [Wed, 29 Apr 2020 20:13:47 +0000 (13:13 -0700)]
Fix NeedsAlignedBaseOffset for composite R2R (#35231)
- Syncronize and correct NeedsAlignedBaseOffset
- Crossgen2 and the runtime had different models for when the base type size needed to be aligned up
- This caused issues for composite crossgen2 builds as the logic was heavily module focussed
- Also, the IsInSameVersionBubble logic was non-functional for composite build
The new algorithm is similar to the old normal R2R rule, with the extension that alignment isn't required in the case of a type which has layout dependent on multiple modules if all of the modules involved are part of the same compilation. (Thus composite compilation is slightly more optimized).
The other rule which must be enforced to allow for inputbubble compilation is that all assemblies depended on by an input bubble compilation must be R2R compiled.
- Add testing for many different variations of compiling the tests with
crossgen, crossgen2, and crossgen2 with input bubble enabled/disable and various composite compilation arrangements.
- Fix R2RDump for composite images
- Fix R2RDump for various fixup types
Eirik Tsarpalis [Wed, 29 Apr 2020 20:05:23 +0000 (21:05 +0100)]
pool key encoding range HashSets
Ganbarukamo41 [Wed, 29 Apr 2020 19:32:49 +0000 (04:32 +0900)]
Implement Vector{Size}<T>.AllBitsSet (#33924)
Miha Zupan [Wed, 29 Apr 2020 19:19:30 +0000 (21:19 +0200)]
Simple formatting cleanup over Uri (#31874)
* Simple formatting cleanup over Uri
* More Uri test cleanup
* Address pr feedback
Eirik Tsarpalis [Wed, 29 Apr 2020 19:12:01 +0000 (20:12 +0100)]
replace SortedList use with HashSet
Jan Kotas [Wed, 29 Apr 2020 18:48:38 +0000 (11:48 -0700)]
Check if PortableThreadPoolEventSource is enabled before logging (#8117) (#35608)
Co-authored-by: Ben Adams <thundercat@illyriad.co.uk>
Miha Zupan [Wed, 29 Apr 2020 17:50:15 +0000 (19:50 +0200)]
Optimize Uri.GetHashCode (#32713)
* Optimize Uri.GetHashCode
* Don't use case-insensitive string hashing when not necessary
* Don't expect Uri.GetHashCode to always be case-insensitive in tests
* Correct Uri.Equals test
Hash codes being equal doesn't mean that the values are equal
* Do not cache Uri GetHashCode
* Simplify Uri.Equals test
Egor Bogatov [Wed, 29 Apr 2020 16:34:29 +0000 (19:34 +0300)]
[mono] Add Android sample and AndroidAppBuilder task (#35483)
Jose Perez Rodriguez [Wed, 29 Apr 2020 16:26:56 +0000 (09:26 -0700)]
Fixing break on OOB System.IO.Ports package where native dependency was no longer produced (#35591)
Carol Eidt [Wed, 29 Apr 2020 16:17:57 +0000 (09:17 -0700)]
Don't create duplicate ZeroInits (#35585)
Tomáš Rylek [Wed, 29 Apr 2020 15:04:03 +0000 (17:04 +0200)]
Further tuning of the CORE_ROOT folder content (#35546)
Based on Sergey's feedback I'm putting back the alternate JITs
(linuxonjit, protononjit) as they are actively used by the JIT team
in specialized scenarios. I have also pruned the PDB subfolder -
after extensive discussions I tried to be conservative in removing
only those PDB's we believe we don't need in Helix.
Thanks
Tomas
Layomi Akinrinade [Wed, 29 Apr 2020 14:46:47 +0000 (10:46 -0400)]
Improve code coverage on collections with stream-based flows (#35046)
* Improve code coverage on collections with stream-based flows
* Address feedback & fortify tests
Eirik Tsarpalis [Tue, 28 Apr 2020 21:26:39 +0000 (22:26 +0100)]
strip IndefiniteLength suffix from write methods
Eirik Tsarpalis [Tue, 28 Apr 2020 21:22:14 +0000 (22:22 +0100)]
make ReadStartMap() and ReadStartArray() return int
Eirik Tsarpalis [Tue, 28 Apr 2020 21:14:19 +0000 (22:14 +0100)]
implement CborWriter encodeIndefiniteLengths parameter
Eirik Tsarpalis [Tue, 28 Apr 2020 20:31:43 +0000 (21:31 +0100)]
add a validateConformance parameter to Skip* methods
Eirik Tsarpalis [Tue, 28 Apr 2020 17:54:56 +0000 (18:54 +0100)]
Implement CborReader.SkipToParent();
Eirik Tsarpalis [Tue, 28 Apr 2020 15:31:26 +0000 (16:31 +0100)]
add support for indefinite byte string literals in reader helpers
Eirik Tsarpalis [Tue, 28 Apr 2020 15:30:58 +0000 (16:30 +0100)]
minor CborReader string refactoring
Eirik Tsarpalis [Tue, 28 Apr 2020 15:18:51 +0000 (16:18 +0100)]
implement patching for indefinite-length items
Eirik Tsarpalis [Mon, 27 Apr 2020 22:53:04 +0000 (23:53 +0100)]
rename CborWriter.ToArray() => CborWriter.GetEncoding(); add a span encoding method
Eirik Tsarpalis [Mon, 27 Apr 2020 21:52:06 +0000 (22:52 +0100)]
implement appropriate rollback semantics for key conformance validation
Eirik Tsarpalis [Mon, 27 Apr 2020 14:27:28 +0000 (15:27 +0100)]
address tuple label style
Eirik Tsarpalis [Fri, 24 Apr 2020 23:29:33 +0000 (00:29 +0100)]
address PR feedback