Bruce Forstall [Wed, 26 Jun 2019 16:49:21 +0000 (09:49 -0700)]
Merge pull request #25326 from BruceForstall/CrossPlatTestHost
Expand corefx testing in coreclr repo
Currently, corefx testing is done on Windows/x64.
Expand testing to include:
1. Linux/x64, Linux/arm, Linux/arm64, Windows/x86 platforms.
Windows/arm should be added after corefx official builds
publish tests and test manifest. Windows/arm64 should be
added after corefx tests are published, and we have
sufficient hardware.
2. All JIT stress modes that are used in normal coreclr testing.
Testing is split into 4 Azure DevOps Pipelines: coreclr-corefx,
coreclr-corefx-jitstress, coreclr-corefx-jitstressregs, and
coreclr-corefx-jitstress2-jitstressregs.
In addition, we now use the corefx meta-package Microsoft.Private.CoreFx.OOB
instead of a list of individual assemblies when constructing
the testhost.
José Rivero [Wed, 26 Jun 2019 16:45:47 +0000 (09:45 -0700)]
Fix disabling wrong session on EventPipe::Shutdown (#25409)
- It's safe to call EventPipe::Disable during shutdown (eventpipe being disabled)
Rafael Lillo [Wed, 26 Jun 2019 15:31:16 +0000 (16:31 +0100)]
Fixes link to install SOS on linux (#25420)
Ben Adams [Wed, 26 Jun 2019 12:55:14 +0000 (14:55 +0200)]
Don't show AggressiveInlining items in exception stacks (#25408)
Tanner Gooding [Wed, 26 Jun 2019 05:36:36 +0000 (22:36 -0700)]
Reverting the ShouldRoundUp logic to not change for custom numeric format strings. (#25400)
Mukul Sabharwal [Wed, 26 Jun 2019 05:00:28 +0000 (22:00 -0700)]
Fix incorrect signature of QCall (#25419)
Sung Yoon Whang [Wed, 26 Jun 2019 04:03:04 +0000 (21:03 -0700)]
Fix LTTng filtering for runtime providers (#25374)
* LTTng filtering
* Fix Windows build, make IsInitialized check faster
* Cleanup/change default to no keywords/level set
* Keep the default to be the current policy - enable everything
* more cleanup
* No need to check for initialization
* Fix Windows build
Santiago Fernandez Madero [Wed, 26 Jun 2019 03:19:28 +0000 (20:19 -0700)]
Tell the compiler to emit nullable attributes for public API only (#25398)
David Mason [Wed, 26 Jun 2019 03:15:02 +0000 (20:15 -0700)]
Fix ReJIT failures (#25377)
David Mason [Wed, 26 Jun 2019 03:13:31 +0000 (20:13 -0700)]
emit rundown event for generic methods in R2R images (#25371)
* emit rundown event for generic methods in R2R images
* fix mac build
* Code Review Feedback
Bruce Forstall [Thu, 20 Jun 2019 20:05:53 +0000 (13:05 -0700)]
Expand corefx testing in coreclr repo
Currently, corefx testing is done on Windows/x64.
Expand testing to include:
1. Linux/x64, Linux/arm, Linux/arm64, Windows/x86 platforms.
Windows/arm should be added after corefx official builds
publish tests and test manifest. Windows/arm64 should be
added after corefx tests are published, and we have
sufficient hardware.
2. All JIT stress modes that are used in normal coreclr testing.
Testing is split into 4 Azure DevOps Pipelines: coreclr-corefx,
coreclr-corefx-jitstress, coreclr-corefx-jitstressregs, and
coreclr-corefx-jitstress2-jitstressregs.
In addition, we now use the corefx meta-package Microsoft.Private.CoreFx.OOB
instead of a list of individual assemblies when constructing
the testhost.
Tomáš Rylek [Wed, 26 Jun 2019 00:27:50 +0000 (17:27 -0700)]
Remove the Crossgen-specific VSD flag from R2RDump (#25391)
Based on JanK's advice I have removed the VSD flag from R2RDump.
The flag should get never observed by the dump tool as it's just
an intermediate contract internal to the Crossgen ZAP logic.
Thanks
Tomas
Jan Kotas [Wed, 26 Jun 2019 00:24:40 +0000 (17:24 -0700)]
Delete DeserializationBlockedException (#25393)
Contributes to dotnet/corefx#36723
Noah Falk [Tue, 25 Jun 2019 23:33:08 +0000 (16:33 -0700)]
Policheck comment adjustment
dotnet-maestro[bot] [Tue, 25 Jun 2019 23:04:19 +0000 (16:04 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190624.8 (#25379)
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19324.8
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19324.8
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19324.8
Stephen Toub [Tue, 25 Jun 2019 19:12:08 +0000 (15:12 -0400)]
React to compiler respecting nullable attributes on properties
dotnet-maestro [Tue, 25 Jun 2019 12:20:07 +0000 (12:20 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190624.24
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19324.24
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19324.24
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19324.24
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19324.24
Andrew Au [Tue, 25 Jun 2019 20:36:18 +0000 (13:36 -0700)]
Make sure EventPipeProvider::m_keywords is accurate after EventPipeConfiguration::Disable (#25358)
Michal Strehovský [Tue, 25 Jun 2019 20:25:02 +0000 (22:25 +0200)]
JitBench: Run PowerShell with an execution policy (#25259)
PowerShell is useless without this argument in default Windows configurations.
Tarek Mahmoud Sayed [Tue, 25 Jun 2019 20:23:56 +0000 (13:23 -0700)]
Map C Locale to Invariant (#25373)
ICU map the C locale to en-US_POSIX which has a non desired collation behavior as it doesn't support case insensitive comparison.
This change is to force mapping C locale to Invariant instead.
Tanner Gooding [Tue, 25 Jun 2019 20:23:33 +0000 (13:23 -0700)]
Updating the zapper to filter out some named intrinsics which are dependent on the ISAs supported by the target CPU. (#25365)
Jan Kotas [Tue, 25 Jun 2019 20:22:23 +0000 (13:22 -0700)]
Fix StackChange value for OpCodes.Stelem (#25382)
Fixes dotnet/corefx#37955
dotnet-maestro[bot] [Tue, 25 Jun 2019 20:18:59 +0000 (13:18 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190624.03 (#25380)
- Microsoft.NETCore.App - 3.0.0-preview7-27824-03
Egor Chesakov [Tue, 25 Jun 2019 19:59:49 +0000 (12:59 -0700)]
Add pr.yml ci.yml internal.yml pipelines to /eng/pipelines (#25385)
John Salem [Tue, 25 Jun 2019 19:39:16 +0000 (12:39 -0700)]
Remove outputPath parameter for EventPipe IPC protocol (#25363)
Jan Vorlicek [Tue, 25 Jun 2019 19:32:47 +0000 (21:32 +0200)]
Fix StackFrameIterator::IsValid check race (#25359)
* Fix StackFrameIterator::IsValid check race
During GC stress >= 4, there could be a race when we would compute
bRedirectedPinvoke as false, but before the condition of the following
_ASSERTE is evaluated, the thread that is being walked pushes a
ResumableFrame to the explicit frames stack of that thread in the GC
marker handler.
The fix to prevent this race is to evaluate all the conditions that
formed the bRedirectedPinvoke after the conditions in the _ASSERTE.
Omair Majid [Tue, 25 Jun 2019 00:41:13 +0000 (20:41 -0400)]
Add a note about ReadyToRun to ManagedNativeHeader
dotnet-maestro[bot] [Tue, 25 Jun 2019 17:27:17 +0000 (10:27 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190624.3 (#25381)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190624.3
- optimization.PGO.CoreCLR - 99.99.99-master-
20190624.3
José Rivero [Tue, 25 Jun 2019 14:24:43 +0000 (07:24 -0700)]
Stop deallocating provider/events on shutdown (#25369)
Peter Sollich [Tue, 25 Jun 2019 13:55:05 +0000 (15:55 +0200)]
Brick table (#25349)
Fix brick table logic to fix perf issue in several ASP.NET tests, remove #ifdef FFIND_OBJECT.
What I observed was that some GCs spent a lot of time in find_first_object called from find_object, which is called during stack scanning to find the containing object for interior pointers. A substantial fraction of generation 0 was being scanned, indicating that the brick table logic didn't work properly in these cases.
The root cause was the fact that the brick table entries were not being set in adjust_limit_clr if the allocation was satisfied from the free list in gen0 instead of newly allocated space. This is the case if there are pinned objects in gen0 as well.
The main fix is in adjust_limit_clr - if the allocation is satisfied from the freelist, seg is nullptr, the change is to set the bricks in this case as well if we are allocating in gen0 and the allocated piece is above a reasonable size threshold.
The bricks are not set always set during allocation - instead, when we detect an interior pointer during GC, we make the allocator set the bricks during the next GC cycles by setting gen0_must_clear_bricks. I changed the way this is handled for server GC (multiple heaps). We used to multiply the decay time by the number of heaps (gc_heap::n_heaps), but only applied it to the single heap where an interior pointer was found. Instead, I think it's better to instead set gen0_must_clear_bricks for all heaps, but leave the decay time unchanged compared to workstation GC.
Maoni suggested to remove the #ifdef FFIND_OBJECT - interior pointers are not going away, so the #ifdefs are unnecessary clutter.
Addressed code review feedback:
- add parentheses as per GC coding conventions
- use max instead of if-statement
- merge body of for-loop over all into existing for-loop
Sung Yoon Whang [Tue, 25 Jun 2019 09:47:48 +0000 (02:47 -0700)]
Fix broken ETW events (#25364)
José Rivero [Tue, 25 Jun 2019 03:31:14 +0000 (20:31 -0700)]
Make s_numberOfSessions Volatile as advertisement to other devs that the data is being used across multiple threads and a portion of that usage is lock-free (#25366)
Sung Yoon Whang [Tue, 25 Jun 2019 00:36:54 +0000 (17:36 -0700)]
Events with keyword 0 needs to be fired (#25361)
Santiago Fernandez Madero [Tue, 25 Jun 2019 00:11:32 +0000 (19:11 -0500)]
Address last round of nullable feedback - S.Resources.ResourceManager, System.Reflection.Emit and ILGeneration (#25318)
* Address nullable feedback for System.Resources.ResourceManager
* Address nullable feedback for System.Reflection.Emit.ILGeneration
* Address nullable feedback for System.Reflection.Emit
* PR Feedback and clean-up redundant casts
Egor Chesakov [Tue, 25 Jun 2019 00:09:14 +0000 (17:09 -0700)]
Add /eng/pipelines/*.yml (#25325)
Jarret Shook [Mon, 24 Jun 2019 23:18:14 +0000 (16:18 -0700)]
Throw platform unsupported error for windows arm32 varargs (#25320)
* Throw unsupported platform for native vcarargs on Arm32 Windows
* Re-enable baseservices vararg test
Tanner Gooding [Mon, 24 Jun 2019 22:39:50 +0000 (15:39 -0700)]
Updating Dragon4 to ensure the number buffer always provides a significant digit if one exists. (#25096)
* Updating Dragon4 to ensure the number buffer always provides a significant digit if one exists.
* Changing System.Number.RoundNumber to not round up floating-point numbers.
* Re-enabling the RealFormatterTestsBase CoreFX tests
* Updating Number.RoundNumber to take a isCorrectlyRounded parameter and to use IEEE compliant rounding for floating-point numbers.
* Change SinglePrecisionCustomFormat to 7, ensuring it matches the value used in netcoreapp2.1
Andrii Siriak [Fri, 21 Jun 2019 22:25:09 +0000 (01:25 +0300)]
Switch from IndexOf(string) to Contains(string) for better readability and performance (#38757)
* Fix performance IndexOf(string) -> Contains(string)
* Make comparison ordinal
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Ganbarukamo41 [Mon, 24 Jun 2019 19:44:50 +0000 (04:44 +0900)]
Make Vector*.ToString() Culture invariant (#25343)
* Remove IFormattable
* Hardcode characters
* Add tests
José Rivero [Mon, 24 Jun 2019 19:18:54 +0000 (12:18 -0700)]
Multiple bug fixes (#25308)
- Fixes EventPipe does not properly dispose of itself on an active session error #25228
- On EventPipeSession::ThreadProc, if an error occurs on the IPC streaming, then EventPipe::Disable will be invoked.
- Fixes Prevent EventPipe Sessions IDs from being reused on disconnect #25229
Michal Strehovský [Mon, 24 Jun 2019 19:17:01 +0000 (21:17 +0200)]
Remove AggressiveOptimization flag from System.Text (#25356)
Based on conversation with Levi, I don't think this flag is needed.
The flag currently controls two things:
* Disqualifies the method from precompilation
* Disables Tier-0 JIT for the method
Removing the attribute allows us to precompile some of the methods (not all, because of `Vector<T>`). It measurably helps improve startup time because many of the attributed methods are complex and take a while to compile.
Once tier-1 JIT kicks in, the generated code should be identical to what we were getting before.
Andy Ayers [Mon, 24 Jun 2019 18:19:58 +0000 (11:19 -0700)]
JIT: see if jmp offset will fit in 32 bit displacement (#25348)
On x86 we can always reach any IAT_PVALUE entry via a 32 bit indirect
jump, and proper handling of jmp epilogs depends on this. So check if the
target address is reachable in 32 bits, and if so, use the jmp [addr] form
on x86, and the jmp [rip + disp] form for x64.
Fixes #25345
Fixes #25346
Undoes the assertion change from #25302
Fixes #25286
Tomáš Rylek [Mon, 24 Jun 2019 18:06:42 +0000 (11:06 -0700)]
Update R2R format doc to 3.0 (#25297)
I have updated the various enumerations and tables. I didn't try
to go overboard w.r.t. understanding tables I'm not yet familiar
with, most notably the diagnostic, inlining and profiling tables.
dotnet-maestro[bot] [Mon, 24 Jun 2019 14:49:06 +0000 (07:49 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190624.1 (#25354)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190624.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190624.1
dotnet-maestro[bot] [Mon, 24 Jun 2019 14:48:42 +0000 (07:48 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190623.4 (#25351)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19323.4
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19323.4
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19323.4
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19323.4
dotnet-maestro[bot] [Mon, 24 Jun 2019 14:45:06 +0000 (07:45 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190623.05 (#25353)
- Microsoft.NETCore.App - 3.0.0-preview7-27823-05
dotnet-maestro[bot] [Mon, 24 Jun 2019 14:38:15 +0000 (07:38 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190623.4 (#25352)
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19323.4
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19323.4
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19323.4
Michal Strehovský [Mon, 24 Jun 2019 14:00:29 +0000 (16:00 +0200)]
Extend the assert for zero-offset fields (#25341)
CoreRT has an [actual field](https://github.com/dotnet/corert/blob/
ba3ba929c88bd80ec5d4dd9cf6917471ad8fa180/src/System.Private.CoreLib/src/System/Object.CoreRT.cs#L30) for the method table table pointer in `System.Object`. CoreCLR does shenanigans when laying out `System.Object` to leave a pointer-sized hole instead.
I think the zero-offset field is triggering these asserts.
Stephen Toub [Mon, 24 Jun 2019 13:27:47 +0000 (09:27 -0400)]
Force secondary await continuations to run asynchronously (#25280)
* Force secondary await continuations to run asynchronously
For performance reasons, await continuations have been invoked synchronously, meaning they're invoked as part of the antecedent task's completion (as long as that task allows it, as long as there's sufficient stack space, etc.) This generally works out well in the case where there's a single await continuation, which is far and away the common case. However, it can cause problems in situations where there are multiple await continuations, as those continuations will end up being serialized, which can lead to slowdowns and deadlocks in niche situations. To address that, this commit backs off a bit. The first await continuation is still invoked synchronously, but subsequent await continuations are invoked asynchronously, such that they are not blocked by a previously registered await continuation.
* Fix nits
dotnet-maestro[bot] [Sun, 23 Jun 2019 16:05:06 +0000 (09:05 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190622.05 (#25338)
- Microsoft.NETCore.App - 3.0.0-preview7-27822-05
Marco Rossignoli [Sun, 23 Jun 2019 15:30:58 +0000 (17:30 +0200)]
MemoryExtensions ToUpper / ToLower throws for overlapping buffer (#25327)
dotnet-maestro[bot] [Sun, 23 Jun 2019 15:30:10 +0000 (08:30 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190623.1 (#25339)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190623.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190623.1
dotnet-maestro[bot] [Sun, 23 Jun 2019 15:29:57 +0000 (08:29 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190622.2 (#25336)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19322.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19322.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19322.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19322.2
dotnet-maestro[bot] [Sun, 23 Jun 2019 15:27:00 +0000 (08:27 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190622.7 (#25337)
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19322.7
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19322.7
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19322.7
Roman Marusyk [Sun, 23 Jun 2019 02:55:17 +0000 (05:55 +0300)]
Change exception throwing in Path.GetRelativePath (#25047)
* Fix Path.GetRelativePath throws ArgumentNullException when relativeTo is empty string
* Fix ArgumentException for relativeTo
Herman Eldering [Sun, 23 Jun 2019 02:52:42 +0000 (04:52 +0200)]
ArgumentException: use system-supplied message if message is null (#25115)
Enable using a system-supplied message while also providing an argument/parameter name by passing in a null message. Made to match the behavior of FileNotFoundException.
Andy Ayers [Sun, 23 Jun 2019 02:06:27 +0000 (19:06 -0700)]
Fix ReturnKind classification for byref like types returned in registers (#25333)
These types contain byrefs, and so when returned in registers we may need
to avoid GC stress at the return site.
Addresses part of #24263.
dotnet-maestro[bot] [Sat, 22 Jun 2019 16:43:47 +0000 (09:43 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190621.75 (#25328)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19321.75
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19321.75
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19321.75
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19321.75
dotnet-maestro[bot] [Sat, 22 Jun 2019 16:43:36 +0000 (09:43 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190621.8 (#25329)
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19321.8
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19321.8
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19321.8
dotnet-maestro[bot] [Sat, 22 Jun 2019 16:43:24 +0000 (09:43 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190621.07 (#25330)
- Microsoft.NETCore.App - 3.0.0-preview7-27821-07
dotnet-maestro[bot] [Sat, 22 Jun 2019 16:07:02 +0000 (16:07 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190622.1 (#25331)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190622.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190622.1
Leandro A. F. Pereira [Sat, 22 Jun 2019 08:52:48 +0000 (01:52 -0700)]
Fix generation of RID on distros that do not set VERSION_ID (#25034)
Rolling-release distros do not set this variable, leading to invalid
RIDs such as "gentoo.-x64", which causes build failures.
Omit VERSION_ID (and the period preceding it) when unset, so it's
consistent with host and PlatformAbstractions.
Fixes #19769.
dotnet-maestro[bot] [Sat, 22 Jun 2019 08:33:30 +0000 (01:33 -0700)]
[master] Update dependencies from dotnet/corefx (#25120)
* Update dependencies from https://github.com/dotnet/corefx build
20190621.1
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19321.1
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19321.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19321.1
* Disable failing tests
Tamar Christina [Sat, 22 Jun 2019 07:47:20 +0000 (08:47 +0100)]
Arm64: Correct encoding of fabd (#25150)
Maoni Stephens [Sat, 22 Jun 2019 01:06:39 +0000 (18:06 -0700)]
don't require seg size to be power of 2 for large pages (#25216)
large pages will have segments aligned to 16mb (the default min seg size for hardlimit)
dotnet-maestro[bot] [Sat, 22 Jun 2019 00:19:33 +0000 (17:19 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190620.1 (#25311)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19320.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19320.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19320.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19320.1
dotnet-maestro[bot] [Sat, 22 Jun 2019 00:19:00 +0000 (17:19 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190621.1 (#25314)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190621.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190621.1
dotnet-maestro[bot] [Sat, 22 Jun 2019 00:18:41 +0000 (17:18 -0700)]
[master] Update dependencies from dotnet/core-setup (#25254)
* Update dependencies from https://github.com/dotnet/core-setup build
20190620.07
- Microsoft.NETCore.App - 3.0.0-preview7-27820-07
Brian Sullivan [Fri, 21 Jun 2019 22:56:36 +0000 (15:56 -0700)]
Merge pull request #25260 from briansull/GitHub_25134
Fix Issue #25134 - AssertionProp incorrectly removes cast from uint
Noah Falk [Fri, 21 Jun 2019 22:27:21 +0000 (15:27 -0700)]
Add EventPipe Processor Number support and make NetTrace the default … (#25276)
* Add EventPipe Processor Number support and make NetTrace the default format
The EventPipe header now has a Processor Number field. On windows we query the correct value, on other OSes we currently have a -1 placeholder, but the field is written to the format regardless.
NetTrace is now the default format when using the environment variable, and the format must be explicitly configured when using the IPC channel or managed API. A parallel change in the diagnostics repo is changing dotnet-trace and dotnet-counter to specify nettrace format which means .NET devs should see nettrace almost exclusively from now on. If for whatever reason it is needed, NetPerf remains available if a scenario explicitly requests to use it.
* PR feedback + attempting to fix broken tests
Sergey Andreenko [Fri, 21 Jun 2019 21:49:57 +0000 (14:49 -0700)]
WorkAround for #25050. (#25316)
* WorkAround for #25050.
A temporary workaround to push the milestone for this issue to 3.next.
* Response review.
Carol Eidt [Fri, 21 Jun 2019 21:26:11 +0000 (14:26 -0700)]
Fix test to use mutual waits (#25317)
Fix #25245
Santiago Fernandez Madero [Fri, 21 Jun 2019 17:54:36 +0000 (10:54 -0700)]
Address nullable feedback for System.Diagnostics.Tracing and StackTrace (#25303)
* Address nullable feedback for System.Diagnostics.Tracing and StackTrace
* Disable corefx tests that need to be updated
Carol Eidt [Fri, 21 Jun 2019 17:40:03 +0000 (10:40 -0700)]
Update instructions to build individual tests
cc @jashook and @sandreenko
Mike McLaughlin [Fri, 21 Jun 2019 16:40:16 +0000 (09:40 -0700)]
ifdef Linux specific readvirtual code (#25299)
Stephen Toub [Fri, 21 Jun 2019 15:56:13 +0000 (11:56 -0400)]
Remove several unnecessary string allocations (#25305)
Andy Ayers [Fri, 21 Jun 2019 15:32:37 +0000 (08:32 -0700)]
JIT: update epilog exit size assert for x86 (#25302)
With the advent of #25251 we can now see the epilog exit sequence on x86 vary
by as much as 6 bytes. Update the assert accordingly.
Fixes #25301.
Ao Qi [Fri, 21 Jun 2019 12:29:01 +0000 (20:29 +0800)]
Fixed mis-matching arguments in src/CMakeLists.txt (#25307)
Jan Vorlicek [Fri, 21 Jun 2019 12:21:34 +0000 (14:21 +0200)]
Disable unloading incompatible test for runincontext (#25126)
* Disable unloading incompatible test for runincontext
These tests do various things that make them incompatible with running
in an unloadable assembly load context using the runincontext tool.
I've attached comments to the UnloadabilityIncompatible element
describing the specific problems of each test.
I've also found a problem in the parameter passing in the
runincontext.sh where it was always passing 7 parameters to each test
and tests that were checking the number of parameters were failing due
to that. This change fixes it by passing just the parameters that were
passed to the runincontext.sh.
* Added printing unhandled exception details if it happened in the test
* Added 10ms wait to the GC collection loop to also give time to async
stuff to completely exit threadpool threads
David Mason [Fri, 21 Jun 2019 09:20:57 +0000 (02:20 -0700)]
Mark the profiler attach thread during attach
Jan Vorlicek [Fri, 21 Jun 2019 08:48:08 +0000 (10:48 +0200)]
Fix OSX floating point state extraction (#25295)
There was a bug reported on a very recent Mac with Intel i9 processor. A
crash in the RtlRestoreContext was happening at the fxrstor instruction
due to the fact that the floating point state data were garbage.
The investigation has shown that sometimes, the x86_FLOAT_STATE64
cannot be obtained using the thread_get_state API. And it was also found
that at the same time, the x86_AVX_STATE64 can be obtained. The state
extracted by the AVX variant contains all the registers that the FLOAT
variant would extract.
However, in some cases, even the x86_AVX_STATE64 cannot be obtained and
there is a third flavor that we can get - x86_AVX512_STATE64.
Unfortunately, there are cases where none of those can be obtained.
It is not clear what causes these cases, it seems only kernel debugging
can give us an answer to that.
This change modifies the way we extract the floating point state. We
first try to get the AVX state, if we fail, we try the AVX512 and
finally we fall back to the FLOAT state. If we fail to get the floating
point state with any of these, we return context without the floating
point state flag set. Also, if only getting the FLOAT state succeeds,
we return context without the XSTATE flag set.
Stephen Toub [Fri, 21 Jun 2019 04:36:42 +0000 (00:36 -0400)]
Reduce string allocation in DiagnosticCounter.GetMetadataString (#25219)
When the _metadata dictionary contains a single key/value pair, the method ends up allocating an unnecessary StringBuilder, char[] beneath it, and input string.
When the _metadata dictionary contains more key/value pairs, the method ends up allocating an unnecessary string per key/value pair.
Vladimir Sadov [Fri, 21 Jun 2019 02:54:34 +0000 (19:54 -0700)]
ensure process-wide fence when updating GC write barrier on ARM64 (#25130)
* ensure process-wide fences when updating GC write barrier on ARM64
dotnet-maestro[bot] [Fri, 21 Jun 2019 01:47:15 +0000 (18:47 -0700)]
[master] Update dependencies from dotnet/arcade (#25253)
* Update dependencies from https://github.com/dotnet/arcade build
20190619.25
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19319.25
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19319.25
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19319.25
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19319.25
dotnet-maestro[bot] [Fri, 21 Jun 2019 01:44:26 +0000 (18:44 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#25255)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190620.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190620.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190620.1
Brian Sullivan [Fri, 21 Jun 2019 01:43:32 +0000 (18:43 -0700)]
Added the complementary test cases of going from a negative int to an unsigned.
Jeremy Koritzinsky [Fri, 21 Jun 2019 00:57:58 +0000 (17:57 -0700)]
Revert "ILMarshaler Refactor (#21227)" (#25292)
This reverts commit
70febbad4bbe23326c26480b2848cdfe9fc8450c.
Gleb Balykov [Fri, 21 Jun 2019 00:55:10 +0000 (03:55 +0300)]
Add custom default base address option to crossgen (#25227)
* Add crossgen option to setup default base address for native image
This is enabled only with -DFEATURE_ENABLE_NO_ADDRESS_SPACE_RANDOMIZATION.
* Mmap native images at default base address if env variable COMPlus_UseDefaultBaseAddr=0x1 is setup.
This is enabled only with -DFEATURE_ENABLE_NO_ADDRESS_SPACE_RANDOMIZATION.
Sung Yoon Whang [Thu, 20 Jun 2019 23:33:51 +0000 (16:33 -0700)]
Fix eventpipe filtering (#25221)
* Add DOTNET_TRACE_CONTEXT and change macros to use DOTNET_TRACE_CONTEXT instead of MCGEN_TRACE_CONTEXT
* Fixing macro definitions
* eventing codegen scripts now generates EventPipe trace contexts
* Fix macros to use the EVENTPIPE_TRACE_Context
* Fix linux build
* Fix windows build
* Update Eventpipe provider context at EtwCallbackComon
* break in switch
* Update rundown provider context manually
* PR feedback
* Eventpipe->EventPipe
* cleanup in codegen script
Sung Yoon Whang [Thu, 20 Jun 2019 23:32:20 +0000 (16:32 -0700)]
Update linux-performace-tracing doc to add eventpipe/dotnet-trace (#25212)
* Update linux-performace-tracing doc to add eventpipe/dotnet-trace
* typo
* Add more detailed doc instead of just a link :)
* remove redundant part
* Update based on noah's feedback
Jeremy Koritzinsky [Thu, 20 Jun 2019 23:12:02 +0000 (16:12 -0700)]
Remove dead code related to copy-constructors and intercept stubs (#25264)
* Remove dead code related to copy-constructors and intercept stubs
* PR Feedback.
Jeremy Koritzinsky [Thu, 20 Jun 2019 23:11:17 +0000 (16:11 -0700)]
Disable NativeVarargsTest on Windows Nano Server. (#25284)
Egor Chesakov [Thu, 20 Jun 2019 22:36:25 +0000 (15:36 -0700)]
Move resources/containers out of azure-pipelines.yml to platform-matrix.yml (#25155)
Tomáš Rylek [Thu, 20 Jun 2019 21:49:27 +0000 (14:49 -0700)]
Initial check-in of R2R format documentation (#25267)
In this initial check-in I have converted Jan Kotas' R2R format doc
from an internal Word document to the md format and I removed some
references to other internal docs. I plan to follow up by updating
the description to the current format version (e.g. apparently the
description doesn't yet include the instance entrypoint table) and
by adding specific extensions for the composite R2R format.
Thanks
Tomas
Matt Galbraith [Thu, 20 Jun 2019 21:44:45 +0000 (14:44 -0700)]
Merge pull request #25285 from MattGal/update-arm32-dockerimages
Update ARM32 Helix Images to include Python 3
Mike McLaughlin [Thu, 20 Jun 2019 21:08:55 +0000 (14:08 -0700)]
Remove SOS and lldb plugin (#25220)
* Remove SOS and lldb plugin
Issue: https://github.com/dotnet/coreclr/issues/24092
Egor Chesakov [Thu, 20 Jun 2019 20:00:53 +0000 (13:00 -0700)]
Triage issues in #25098 (#25240)
Andy Ayers [Thu, 20 Jun 2019 19:04:54 +0000 (12:04 -0700)]
JIT: use register indirect for indirect jumps (#25251)
If we are jumping to another method via an indirection cell, the cell address
may be too far from the jump to address via a RIP-relative indirection. So
instead, load the target address into RAX and jump register indirect.
Fixes #22342.
Matt Galbraith [Thu, 20 Jun 2019 19:00:16 +0000 (12:00 -0700)]
missed a spot
Matt Galbraith [Thu, 20 Jun 2019 18:57:09 +0000 (11:57 -0700)]
Update ARM32 Helix Images to include Python 3