platform/upstream/dotnet/runtime.git
5 years agoMerge pull request dotnet/core-setup#5749 from jcagme/feedTaskUpgrade
JC Aguilera [Tue, 9 Apr 2019 16:52:45 +0000 (09:52 -0700)]
Merge pull request dotnet/core-setup#5749 from jcagme/feedTaskUpgrade

Feed task upgrade

Commit migrated from https://github.com/dotnet/core-setup/commit/eb6224b99fb8c902882d64c37329a6dd3737a72f

5 years agoMerge pull request dotnet/core-setup#5714 from dotnet-maestro-bot/master-UpdateDepend...
William Godbe [Tue, 9 Apr 2019 16:50:00 +0000 (09:50 -0700)]
Merge pull request dotnet/core-setup#5714 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools to preview4-03906-01 (master)

Commit migrated from https://github.com/dotnet/core-setup/commit/81d69a8ee3f6052e210de1428ed4d629cf318778

5 years agoUpgrading feed taks version
juanam [Tue, 9 Apr 2019 16:02:23 +0000 (09:02 -0700)]
Upgrading feed taks version

Commit migrated from https://github.com/dotnet/core-setup/commit/bdf999f1e1e379ca8d1d2b3d33336b34228c0a71

5 years agoUpgrading feed taks version
juanam [Tue, 9 Apr 2019 16:01:59 +0000 (09:01 -0700)]
Upgrading feed taks version

Commit migrated from https://github.com/dotnet/core-setup/commit/75aeeb3d91d77d5e66193f0bb4445785d24de0ab

5 years agoAdd hostpolicy_context which holds information to load/execute the runtime (dotnet...
Elinor Fung [Tue, 9 Apr 2019 03:40:27 +0000 (20:40 -0700)]
Add hostpolicy_context which holds information to load/execute the runtime (dotnet/core-setup#5683)

Commit migrated from https://github.com/dotnet/core-setup/commit/59c193bd93deafba5926cb827872b80338aca7c0

5 years agoImprove multi framework resolution tests (dotnet/core-setup#5690)
Vitek Karas [Mon, 8 Apr 2019 21:20:58 +0000 (14:20 -0700)]
Improve multi framework resolution tests (dotnet/core-setup#5690)

Roll forward tests with multiple frameworks
Fix a pre-release comparison in soft-roll-forward

Commit migrated from https://github.com/dotnet/core-setup/commit/8371c289a2adcfc3a3fd1c8784e02bb197a94011

5 years agoUpdate BuildTools to preview4-03906-01
dotnet-maestro-bot [Mon, 8 Apr 2019 13:42:16 +0000 (06:42 -0700)]
Update BuildTools to preview4-03906-01

Commit migrated from https://github.com/dotnet/core-setup/commit/24633ddc9023b866d0671dba55d2f98b6e71de3c

5 years agoRoll forward for pre release edge cases (dotnet/core-setup#5635)
Vitek Karas [Mon, 8 Apr 2019 13:33:46 +0000 (06:33 -0700)]
Roll forward for pre release edge cases (dotnet/core-setup#5635)

* Describe proposed behavioral changes for pre-release roll forward
* More tests to validate existing pre-release behavior

Commit migrated from https://github.com/dotnet/core-setup/commit/e33913f3bb45def8f588dc586178e9f09cc49cc6

5 years agoMerge pull request dotnet/core-setup#5705 from JohnTortugo/SetupBatchBuild
Matt Mitchell [Fri, 5 Apr 2019 23:18:08 +0000 (16:18 -0700)]
Merge pull request dotnet/core-setup#5705 from JohnTortugo/SetupBatchBuild

Setup batch build

Commit migrated from https://github.com/dotnet/core-setup/commit/4e9a9f2118182df123f5ffa874f41462e1dad0b7

5 years agoFix syntax
Cesar Soares Lucas [Fri, 5 Apr 2019 22:55:01 +0000 (15:55 -0700)]
Fix syntax

Commit migrated from https://github.com/dotnet/core-setup/commit/0d63f0bfa51854ba64869499b8b54256861eb635

5 years agoBatch core-setup builds
Cesar Soares Lucas [Fri, 5 Apr 2019 22:52:12 +0000 (15:52 -0700)]
Batch core-setup builds

Commit migrated from https://github.com/dotnet/core-setup/commit/8058bab5f1e71877944ab6ec4e049e99057eec9f

5 years ago.NET Core WinRT Host (dotnet/core-setup#5527)
Jeremy Koritzinsky [Fri, 5 Apr 2019 22:38:12 +0000 (15:38 -0700)]
.NET Core WinRT Host (dotnet/core-setup#5527)

Implement a WinRT host for .NET Core so users can write WinRT WinMDs that target and build on .NET Core.

We can't accurately test this E2E in CI until we have a test machine running a version of Windows with the Reg-Free WinRT support (requires at least Windows 10 19H1 Build 18309).

Runtime side of the host work is in dotnet/coreclrdotnet/core-setup#23402

Commit migrated from https://github.com/dotnet/core-setup/commit/4ed031a6a01352696bd7fdd58bddc365d34e91bf

5 years agoAdd doc with hostpolicy APIs (dotnet/core-setup#5659)
Elinor Fung [Fri, 5 Apr 2019 22:03:40 +0000 (15:03 -0700)]
Add doc with hostpolicy APIs (dotnet/core-setup#5659)

* Add doc listing existing hostpolicy APIs
* Add proposed new hostpolicy exports

Commit migrated from https://github.com/dotnet/core-setup/commit/4be876975d0e475ee78a2105f458b54952154df7

5 years agoMerge pull request dotnet/core-setup#5697 from wtgodbe/preview5
William Godbe [Fri, 5 Apr 2019 21:33:43 +0000 (14:33 -0700)]
Merge pull request dotnet/core-setup#5697 from wtgodbe/preview5

Update branding to preview5

Commit migrated from https://github.com/dotnet/core-setup/commit/1043445a8182f725ba60e0745d0b534f8b800564

5 years agoUpdate branding to preview5
wtgodbe [Fri, 5 Apr 2019 19:49:56 +0000 (12:49 -0700)]
Update branding to preview5

Commit migrated from https://github.com/dotnet/core-setup/commit/f3836495eeb3a6a9d8ac64eb736979c1adbc4668

5 years agoEnforce that DLL/EXEs in platform manifest have a FileVersion (dotnet/core-setup...
Davis Goodin [Fri, 5 Apr 2019 17:06:18 +0000 (12:06 -0500)]
Enforce that DLL/EXEs in platform manifest have a FileVersion (dotnet/core-setup#5682)

* Enforce DLL/EXEs in platform manifest have version

* Allow zero/missing versions on non-Windows

Commit migrated from https://github.com/dotnet/core-setup/commit/851859e9e07eda7adb2dcf129b0d6fb3cab411e3

5 years agoMerge pull request dotnet/core-setup#5521 from dotnet/leecow-patch
Lee Coward [Thu, 4 Apr 2019 21:03:36 +0000 (14:03 -0700)]
Merge pull request dotnet/core-setup#5521 from dotnet/leecow-patch

Refresh snap definitions

Commit migrated from https://github.com/dotnet/core-setup/commit/7c5ad7177d42e70641677bd039f5d4e889832e0b

5 years agoMerge branch 'leecow-patch' of https://github.com/dotnet/core-setup into leecow-patch
Lee Coward [Thu, 4 Apr 2019 21:02:11 +0000 (14:02 -0700)]
Merge branch 'leecow-patch' of https://github.com/dotnet/core-setup into leecow-patch

Commit migrated from https://github.com/dotnet/core-setup/commit/cb3880facef1da9a651a946e4208443d994b9fcf

5 years agoformatting fix
Lee Coward [Thu, 4 Apr 2019 21:01:58 +0000 (14:01 -0700)]
formatting fix

Commit migrated from https://github.com/dotnet/core-setup/commit/092c10eef41e463f12c15f08d48ffa40f9b4e72a

5 years agoUpdate src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime
Davis Goodin [Thu, 4 Apr 2019 20:59:12 +0000 (13:59 -0700)]
Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/5de68d7b75d9d31560fc605c6f1e44be8dd293b9

5 years agoUpdate src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime
Davis Goodin [Thu, 4 Apr 2019 20:58:00 +0000 (13:58 -0700)]
Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/58952bae556822efccef5d3e39611065b8b71f1b

5 years agoUpdate src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime
Davis Goodin [Thu, 4 Apr 2019 20:57:44 +0000 (13:57 -0700)]
Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/007b7f86ad2ee473ac69a61d561f3ca7e765f149

5 years agoUpdate src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime
Davis Goodin [Thu, 4 Apr 2019 20:57:34 +0000 (13:57 -0700)]
Update src/pkg/packaging/snaps/dotnet-sdk-3/dotnet-runtime

Co-Authored-By: leecow <leecow@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/8388f46ddc2eff94b17139a18adbe9585453803c

5 years agoAdd ijwhost.lib to host package. (dotnet/core-setup#5650)
Jeremy Koritzinsky [Thu, 4 Apr 2019 17:30:40 +0000 (10:30 -0700)]
Add ijwhost.lib to host package. (dotnet/core-setup#5650)

I forgot to include the `ijwhost.lib` exports lib in the Microsoft.NETCore.DotNetAppHost package. C++/CLI will need this in the package for aquisition via NuGet.

Commit migrated from https://github.com/dotnet/core-setup/commit/482c74beffd6206694004fbd539ecede6dcab4b1

5 years agoAdd <functional> include to coreclr.h (dotnet/core-setup#5664)
Jeremy Koritzinsky [Thu, 4 Apr 2019 06:00:58 +0000 (23:00 -0700)]
Add <functional> include to coreclr.h (dotnet/core-setup#5664)

Commit migrated from https://github.com/dotnet/core-setup/commit/80622592a4e993200cb5b495b802abc1ee2fe96d

5 years agoBundler: Add test case for handling relative-path input (dotnet/core-setup#5653)
Swaroop Sridhar [Wed, 3 Apr 2019 20:11:30 +0000 (13:11 -0700)]
Bundler: Add test case for handling relative-path input (dotnet/core-setup#5653)

Run the bundle-extract test where inputs are specified as:
 - Absolute paths
 - Relative paths terminated by directory separator
 - Relative paths not terminated by directory separator

Commit migrated from https://github.com/dotnet/core-setup/commit/d29ad01cb118f0750a517360757755b8be1d4097

5 years agoBundler: Fix path handling
Austin Wise [Tue, 2 Apr 2019 22:03:26 +0000 (15:03 -0700)]
Bundler: Fix path handling

This commit has two changes:
* Allow relative paths to be used for source directory. (dotnet/core-setup#5594)
* Fix a typo.

Commit migrated from https://github.com/dotnet/core-setup/commit/3f3c14ebcb95b5f83cdf8afd9d5083a6e7dbdb2c

5 years agoMake coreclr_property_bag_t handle lifetime of property strings (dotnet/core-setup...
Elinor Fung [Tue, 2 Apr 2019 21:11:27 +0000 (14:11 -0700)]
Make coreclr_property_bag_t handle lifetime of property strings (dotnet/core-setup#5638)

* Make coreclr_property_bag_t handle lifetime of property strings
* Basic test for runtime config properties

Commit migrated from https://github.com/dotnet/core-setup/commit/ba5b51b74e7b4a39551f4f47eaa2b0a9bc0b439a

5 years agoRename nethost zip/tar.gz to be consistent with runtime compressed files (dotnet...
Elinor Fung [Tue, 2 Apr 2019 17:21:33 +0000 (10:21 -0700)]
Rename nethost zip/tar.gz to be consistent with runtime compressed files (dotnet/core-setup#5639)

Commit migrated from https://github.com/dotnet/core-setup/commit/158cab126cb58c21bcee8385b2c6e46c3e3501ff

5 years agoMove files only used for hostpolicy under hostpolicy subdirectory (dotnet/core-setup...
Elinor Fung [Mon, 1 Apr 2019 19:18:30 +0000 (12:18 -0700)]
Move files only used for hostpolicy under hostpolicy subdirectory (dotnet/core-setup#5629)

Commit migrated from https://github.com/dotnet/core-setup/commit/4ea0233e38681384ee91d7a72c011db9c02e35ff

5 years agoUpdate BuildTools to preview4-03828-01 (dotnet/core-setup#5584)
dotnet-maestro-bot [Sat, 30 Mar 2019 04:30:13 +0000 (21:30 -0700)]
Update BuildTools to preview4-03828-01 (dotnet/core-setup#5584)

Commit migrated from https://github.com/dotnet/core-setup/commit/8db9f804ff77ff866ff203cff6ea0791e895045e

5 years agoDisable multi-level lookup for the test solution (dotnet/core-setup#5598)
Vitek Karas [Sat, 30 Mar 2019 02:20:16 +0000 (19:20 -0700)]
Disable multi-level lookup for the test solution (dotnet/core-setup#5598)

Commit migrated from https://github.com/dotnet/core-setup/commit/b699f32549d72d41d950841a07a1d76c8d508429

5 years agoRefactor FX resolution into its own class (dotnet/core-setup#5582)
Vitek Karas [Fri, 29 Mar 2019 20:44:16 +0000 (13:44 -0700)]
Refactor FX resolution into its own class (dotnet/core-setup#5582)

fx_muxer is a collection of muxer functionality, framework resolution and command line parsing.
This change moves the framework resolution out into its own fx_resolver.

In the fx_resolver, made some of the methods "this" methods so that they don't have to pass the framework maps in arguments.

No functional changes, just moving code around.

Commit migrated from https://github.com/dotnet/core-setup/commit/20f2752ccd2fdbb285a77d66306e5ad2cdb81f07

5 years agoRemove coreclr shutdown from coreclr_t destructor. (dotnet/core-setup#5612)
Aaron Robinson [Fri, 29 Mar 2019 18:44:41 +0000 (11:44 -0700)]
Remove coreclr shutdown from coreclr_t destructor. (dotnet/core-setup#5612)

Commit migrated from https://github.com/dotnet/core-setup/commit/d18247239a28e4ec353f92bedf2dde153a8068ea

5 years agoAdd zip/tar.gz for nethost (dotnet/core-setup#5603)
Elinor Fung [Fri, 29 Mar 2019 18:13:38 +0000 (11:13 -0700)]
Add zip/tar.gz for nethost (dotnet/core-setup#5603)

Commit migrated from https://github.com/dotnet/core-setup/commit/6d0c29c1870efd6a041f9d599723f462c0d74b0e

5 years agoUse BYOC pools: '*-temp' pools being deleted (dotnet/core-setup#5591)
Davis Goodin [Wed, 27 Mar 2019 21:36:35 +0000 (16:36 -0500)]
Use BYOC pools: '*-temp' pools being deleted (dotnet/core-setup#5591)

Add chown workaround for a new way that 'root' file ownership can break the build in the new pools.

Commit migrated from https://github.com/dotnet/core-setup/commit/8f45c48aca40aaa007288faf495ee425397e401c

5 years agoRename Microsoft.Dotnet.Build.Bundle to Microsoft.NET.Build.Bundle (dotnet/core-setup...
Swaroop Sridhar [Wed, 27 Mar 2019 19:49:35 +0000 (12:49 -0700)]
Rename Microsoft.Dotnet.Build.Bundle to Microsoft.NET.Build.Bundle (dotnet/core-setup#5581)

Rename the Bundler package to match other tools in the toolset repository.

Commit migrated from https://github.com/dotnet/core-setup/commit/3460b19cf6ade03882e7b168a3295f959074d7c6

5 years agoOmit trailing path separator in TPA (dotnet/core-setup#5575)
Vitek Karas [Wed, 27 Mar 2019 18:33:57 +0000 (11:33 -0700)]
Omit trailing path separator in TPA (dotnet/core-setup#5575)

In 2.* the trailing separator was removed by the runtime. After refactorings in the runtime it's no longer the case. This is technically a breaking change since in 2.* the `AppDomain.GetData("TRUSTED_PLATFORM_ASSEMBLIES")` returns string which doesn't have trailing path separator. In 3.0 it has.

It's cleaner to fix this in `hostpolicy` because there's no reason for runtime to "tweak" runtime property values before they are reported via `GetData`. TPA is not special in any way either. The trailing path separator serves no purpose anyway, so it's perfectly fine to remove it. And there's no reason to keep the change from 2.* in the codebase.

Commit migrated from https://github.com/dotnet/core-setup/commit/eb3f9526c14fab300247c9caaf1506141d89ec64

5 years agoTest on Windows x86 (dotnet/core-setup#5583)
Davis Goodin [Wed, 27 Mar 2019 18:04:07 +0000 (13:04 -0500)]
Test on Windows x86 (dotnet/core-setup#5583)

Commit migrated from https://github.com/dotnet/core-setup/commit/a000c54cc800b326bd45fb54b7caeb91a7ca59c6

5 years agoFix GetHostFxrPath_DotNetRootEnvironment test failure on x86 (dotnet/core-setup#5571)
Elinor Fung [Wed, 27 Mar 2019 17:05:53 +0000 (10:05 -0700)]
Fix GetHostFxrPath_DotNetRootEnvironment test failure on x86 (dotnet/core-setup#5571)

Commit migrated from https://github.com/dotnet/core-setup/commit/0b6c947fcd15ab7105a4eef0f50f7dff280c557a

5 years agoBundler Test: Run using AppHost (dotnet/core-setup#5574)
Swaroop Sridhar [Wed, 27 Mar 2019 14:47:15 +0000 (07:47 -0700)]
Bundler Test: Run using AppHost (dotnet/core-setup#5574)

The bundler test runs a self-contained-published test app twice:
once before and once after bundling.

The initial run (to sanity check the project) was done using
the dotnet host obtained from the SDK. However, the SDK dotnet seems
to be a X64 binary, which failed to run the test-app published for x86.
https://dev.azure.com/dnceng/public/_build/results?buildId=134281&view=logs

This change fixes the problem by invoking both runs using the published AppHost.

Commit migrated from https://github.com/dotnet/core-setup/commit/e9bd1539c2fb2d0d5c1aff2ea05d6f095ad5e913

5 years agoFX resolution small cleanup (dotnet/core-setup#5544)
Vitek Karas [Wed, 27 Mar 2019 12:05:30 +0000 (05:05 -0700)]
FX resolution small cleanup (dotnet/core-setup#5544)

* Renames and add comments to roll-forward functions
* Refactor to remove code duplication

Commit migrated from https://github.com/dotnet/core-setup/commit/06c7660c571cc02a1f276c7b992ff225e4ec5903

5 years agoRename test only env variables (dotnet/core-setup#5548)
Vitek Karas [Wed, 27 Mar 2019 12:04:25 +0000 (05:04 -0700)]
Rename test only env variables (dotnet/core-setup#5548)

The globally registered location applies to everything, not just SDK, so remove the SDK from the env variable names. Also rename to better match product intent.

Modify tests to use constatns for the test only env variables.
Add couple tests to framework resolution around multiple hive resolution.

Commit migrated from https://github.com/dotnet/core-setup/commit/f35738641da91c46be5a50b8d9da0718228cb212

5 years agoAdd framework resolution tests for --fx-version (dotnet/core-setup#5545)
Vitek Karas [Wed, 27 Mar 2019 10:13:40 +0000 (03:13 -0700)]
Add framework resolution tests for --fx-version (dotnet/core-setup#5545)

Commit migrated from https://github.com/dotnet/core-setup/commit/fef74d39b1bb08aefd0930f6c7866ddb3150d75b

5 years agoSwitch SDKLookup tests to use mock hostpolicy (dotnet/core-setup#5563)
Elinor Fung [Wed, 27 Mar 2019 00:00:49 +0000 (17:00 -0700)]
Switch SDKLookup tests to use mock hostpolicy (dotnet/core-setup#5563)

These are just testing discovery of the SDK locations, and do not need
an actual app or the SDK to run.

Commit migrated from https://github.com/dotnet/core-setup/commit/adb65e24465fa2d37f4c062f9598e082c8df6f39

5 years agoRun tests on Windows jobs using '-test' alias (dotnet/core-setup#5570)
Davis Goodin [Tue, 26 Mar 2019 23:02:38 +0000 (18:02 -0500)]
Run tests on Windows jobs using '-test' alias (dotnet/core-setup#5570)

Commit migrated from https://github.com/dotnet/core-setup/commit/e030161415a0ca857a2b5cb7fffeade0ebb26a70

5 years agoAdd alias for build option to just build/run tests (dotnet/core-setup#5564)
Elinor Fung [Tue, 26 Mar 2019 21:49:44 +0000 (14:49 -0700)]
Add alias for build option to just build/run tests (dotnet/core-setup#5564)

Commit migrated from https://github.com/dotnet/core-setup/commit/feb4180dcc6a5c9dc3ca5810e02c15a377277db8

5 years agoExpose function for locating hostfxr (dotnet/core-setup#5522)
Elinor Fung [Mon, 25 Mar 2019 23:57:29 +0000 (16:57 -0700)]
Expose function for locating hostfxr (dotnet/core-setup#5522)

* Add nethost library and implement nethost_get_hostfxr_path
* Add basic tests for nethost_get_hostfxr_path

Commit migrated from https://github.com/dotnet/core-setup/commit/6001915623d99527f5af3252b9d19694935ae4a8

5 years agoPackage Microsoft.DotNet.Build.Bundle as a tool (dotnet/core-setup#5555)
Swaroop Sridhar [Mon, 25 Mar 2019 21:46:01 +0000 (14:46 -0700)]
Package Microsoft.DotNet.Build.Bundle as a tool (dotnet/core-setup#5555)

Package Microsoft.DotNet.Build.Bundle as a tool similar to ILLink.Tasks
so that it can be consumed by the ToolSet repo.
(https://github.com/dotnet/toolset/pull/541)

Packaging the bundler as a lib causes version compatibility check failures.

Commit migrated from https://github.com/dotnet/core-setup/commit/142a83f6580b3e409e7a2de4ff7a3b27807474bd

5 years agoImprove .NET Shared Framework bundle installer accessibility (dotnet/core-setup#5549)
Davis Goodin [Mon, 25 Mar 2019 18:03:54 +0000 (13:03 -0500)]
Improve .NET Shared Framework bundle installer accessibility (dotnet/core-setup#5549)

* Add missing 'Name' attributes to bundle installer

'Image' and 'Text' tags were missing 'Name' attributes.

* Shrink text bounds to fit inside parent

Fixes "An element's BoundingRectangle must be contained within its parent element."

* Fix tab stops: add links, remove text

Some links couldn't be navigated to, and some non-interactive text on the welcome screen could be focused.

Commit migrated from https://github.com/dotnet/core-setup/commit/28fb2967251f3d63cb8a9c82529f671836941bdd

5 years agoFix framework ordering if graphs (dotnet/core-setup#5542)
Vitek Karas [Mon, 25 Mar 2019 17:36:54 +0000 (10:36 -0700)]
Fix framework ordering if graphs (dotnet/core-setup#5542)

If both the app and framework (for example ASP.NET) have dependency on the root Microsoft.NETCore.App and these references are for different versions the product may not find `hostpolicy`.

The problem happens if the framework (ASP.NET for example) has a reference to lower (but still compatible) version to what the app has. In such case the app will resolve the framework and put it into the list. Then we process ASP.NET framework which gets added to the end of that list as well. And then we process references for ASP.NET, we find that the reference to NETCore.App is compatible with the one we already have (soft-roll-forward). In this case the NETCore.App should be moved to the end of the list (the list is ordered such that the root framework should be last), but the code used to only do that if the versions were an exact match.

The fix is to always move the dependent framework to the last position.

Tests we already added as part of the framework resolution test improvement, but commented out as they were failing. Just uncommenting the tests.

Commit migrated from https://github.com/dotnet/core-setup/commit/b29f3d524a111a2b1c77a4c1362761d2988c6532

5 years agoAdd .NET Standard 2.1 Targeting Pack (dotnet/core-setup#5535)
Davis Goodin [Mon, 25 Mar 2019 15:23:03 +0000 (10:23 -0500)]
Add .NET Standard 2.1 Targeting Pack (dotnet/core-setup#5535)

* Add .NET Standard 2.1 Targeting Pack

* has no platforms => has no shared framework

* 2.1.0-* netstandard version

* Fix rpm/deb version: use ProductBandVersion

Commit migrated from https://github.com/dotnet/core-setup/commit/6a73779c901b957a8107aefbd3f48542b60c538a

5 years agoAdd internal notice to targeting pack nupkg desc (dotnet/core-setup#5536)
Davis Goodin [Mon, 25 Mar 2019 14:47:45 +0000 (09:47 -0500)]
Add internal notice to targeting pack nupkg desc (dotnet/core-setup#5536)

Commit migrated from https://github.com/dotnet/core-setup/commit/167dbc84e5c98ff196e936345d6c274ce6b0860c

5 years agoGeneralize test settings for framework resolution tests (dotnet/core-setup#5524)
Vitek Karas [Sat, 23 Mar 2019 11:41:45 +0000 (04:41 -0700)]
Generalize test settings for framework resolution tests (dotnet/core-setup#5524)

Add ability to easily apply settings (roll forward and so on) in a dynamic way (picking location via variable).
This simplifies testing of settings combinations.

Commit migrated from https://github.com/dotnet/core-setup/commit/7d83e1fa27bb2ef3e3623f37370023446a3d3dbe

5 years agoPublish Microsoft.Dotnet.Build.Bundle package (dotnet/core-setup#5537)
Swaroop Sridhar [Sat, 23 Mar 2019 00:42:24 +0000 (17:42 -0700)]
Publish Microsoft.Dotnet.Build.Bundle package (dotnet/core-setup#5537)

This change publishes the Bundle tool as a package for consumption in the toolset/sdk repos.

The changes are:

Enable package publishing for the Bundler
Add a property in sdk.props so help find the tool easily from the MSBuild tooling
(similar to https://github.com/mono/linker/pull/487/files)

Commit migrated from https://github.com/dotnet/core-setup/commit/dfe2a49a40ebde28481454573f4d8a8c460a0b6b

5 years agoAdd a README file for the bundler (dotnet/core-setup#5526)
Swaroop Sridhar [Fri, 22 Mar 2019 21:43:20 +0000 (14:43 -0700)]
Add a README file for the bundler (dotnet/core-setup#5526)

Add a README file for the bundler

Add a readme file that explains why the Bundler is in the core-setup repo,
and why it is built as a command line tool.

Commit migrated from https://github.com/dotnet/core-setup/commit/8a6ed3585d14e939d36fecf2b94547e1425e8a2b

5 years agoFix WindowsDesktop file list root attributes (dotnet/core-setup#5533)
Davis Goodin [Fri, 22 Mar 2019 18:54:03 +0000 (13:54 -0500)]
Fix WindowsDesktop file list root attributes (dotnet/core-setup#5533)

Stop automatically inheriting the .NET Core targeting pack's values.

Commit migrated from https://github.com/dotnet/core-setup/commit/42bdab6aa6ebfb40e9cb99de2542b6fb326bf44f

5 years agoImprove roll forward spec and tests (dotnet/core-setup#5516)
Vitek Karas [Fri, 22 Mar 2019 09:08:13 +0000 (02:08 -0700)]
Improve roll forward spec and tests (dotnet/core-setup#5516)

Commit migrated from https://github.com/dotnet/core-setup/commit/b58bfb6da1e5d538f8f2e8a80184943378a5dd9f

5 years agoFix daily build symbol publish (dotnet/core-setup#5525)
Davis Goodin [Fri, 22 Mar 2019 02:27:56 +0000 (21:27 -0500)]
Fix daily build symbol publish (dotnet/core-setup#5525)

Commit migrated from https://github.com/dotnet/core-setup/commit/c3f419792ab78a235acb622bb42070eb2d8ce069

5 years agoImplement SemVer 2.0.0 (dotnet/core-setup#4953)
Steve MacLean [Thu, 21 Mar 2019 20:38:56 +0000 (16:38 -0400)]
Implement SemVer 2.0.0 (dotnet/core-setup#4953)

Implement SemVer 2.0.0 https://semver.org/spec/v2.0.0.html
Add unit test code.
Add end to end SemVer 2.0.0 tests
Respond to comments
Optimize char set check

Commit migrated from https://github.com/dotnet/core-setup/commit/8ee7c85052193cbf064b7da16c34a8f50d94695a

5 years agoUpdate licence info (dotnet/core-setup#5258)
Nikita Potapenko [Thu, 21 Mar 2019 08:46:28 +0000 (10:46 +0200)]
Update licence info (dotnet/core-setup#5258)

Commit migrated from https://github.com/dotnet/core-setup/commit/18780678da576d8c629066f50af30159a8859b2f

5 years agoInclude header files in projects (dotnet/core-setup#5514)
Vitek Karas [Wed, 20 Mar 2019 21:09:16 +0000 (14:09 -0700)]
Include header files in projects (dotnet/core-setup#5514)

Currently the project files generated by CMake which can be opened in VS don't contain any header files. For the most part intellisense works, but simple Find In Files mostly doesn't and some other navigation in VS is a bit flaky.

This change adds the header files to the projects.

This is Windows only as CMake doesn't generate any project files on Linux/macOS.

Adds header files to the SOURCES list on windows only.

Commit migrated from https://github.com/dotnet/core-setup/commit/e2ead1e8128bfc31af2b86688f86b014ecde1a75

5 years agoIJW Host (dotnet/core-setup#5185)
Jeremy Koritzinsky [Wed, 20 Mar 2019 20:34:18 +0000 (13:34 -0700)]
IJW Host (dotnet/core-setup#5185)

* First pass porting mscoree/mscoreei's IJW hosting hooks into a new .NET Core host. Functions that use runtime data structures are stubbed out.

* Use Windows heap functions for allocating executable memory.

* Add IJW activation design document.

* Add talking point about loading dependencies from *.deps.json* files and what work needs to be done for those.

* Clean up design doc.

* Update design doc.

* Feedback.

* Clean up the PEDecoder since we don't need to port over all of the validation, just enough to ensure that the assembly is a .NET assembly.

* The OS will verify that the IJW image and the IJW host are the same architecture, so we don't need to branch on architecture.

* Clean up ijwhost and PEDecoder code based on review feedback.

* Refactor corehost.cpp and add implementations of functions to fetch IJW delegates from hostfxr.

* Move hostfxr resolution into separate file and make corehost only relevant for the exe hosts.

* Make get_latest_fxr local to fxr_resolver.cpp

* Implement fxr wire-up for ijwhost.

* Rvas are already mapped for loaded images.

* Don't use stubs if being loaded into currently running runtime.

* Update IJW activation doc based on updated info about callbacks.

* Implement token resolution from thunks. Fix calling a users native entry-point from _CorDllMain.

* Correctly resolve side-by-side hostfxr from ijwhost and comhost. Correctly handle an empty TPA when appending S.P.CL. Pass app-path to delegate.

* Update design doc.

* Remove unneeded validation.

* Fix assembler selection for ARM/ARM64.

* Fix indentation.

* Remove dead code in PEDecoder.

* Fix missing CommandLineToArgvW symbol in arm/arm64 builds.

* Fix ARM/ARM64 build by bringing over custom arm assembler supporting cmake from coreclr.

* Remove IJWBootstrapThunk opaque class. Rename all non-exported apis to match the snake_case convention in this repo.

* Remove exports.cpp files per pr feedback.

* Use an enum to specify which delegate to load from the runtime in the hostfxr<->hostpolicy API.

* Fix x86 build

* Make x86 implementation of get_thunk_from_cookie clearer.

* Symbol export changes needed for x86 as found by testing.

* Remove ijw-exe-specific path.

* clean up ijwhost.cpp since we only have one entrypoint into hostfxr from ijwhost now.

* Use enum for delegate getter in hostfxr-exposed api as well.

* PR Feedback.

* Add ijwhost to Microsoft.NetCore.DotNetAppHost package.

* Setup tracing on comhost and ijwhost entry points.

* PR Feedback.

* Remove IsILOnly checks.

* Clean up design doc.

* More cleanup on IJW activation design doc

* swallow tracing on IJW. Remove as much of corhdr.h as possible.

* Fix bad copy-paste in the install command in ijwhost cmake script.

* Fix cmake

* Add error message to trace for failure to find the "corehost_get_coreclr_delegate" entrypoint.

* Sign ijwhost. Fixes dotnet/core-setup#5485.

Commit migrated from https://github.com/dotnet/core-setup/commit/bc7bcc646567a261c0ae113d5fe43f17469af4ae

5 years agoupdate dependencies and add 3.0 preview
Lee Coward [Wed, 20 Mar 2019 18:30:40 +0000 (11:30 -0700)]
update dependencies and add 3.0 preview

Commit migrated from https://github.com/dotnet/core-setup/commit/bb28f0b7bdb2c47190a78178d330e33736c3f416

5 years agosnap yaml updates to enable build on 18.04
Lee Coward [Wed, 20 Mar 2019 17:49:03 +0000 (10:49 -0700)]
snap yaml updates to enable build on 18.04

Commit migrated from https://github.com/dotnet/core-setup/commit/8e8df8c0eec8ba4d67dcce9c9dc5d3501895cd5f

5 years agoUpdate Snap definitions with latest
Lee Coward [Wed, 20 Mar 2019 17:16:27 +0000 (10:16 -0700)]
Update Snap definitions with latest

Commit migrated from https://github.com/dotnet/core-setup/commit/57478cb0932c48d66916edaa060f73791f190006

5 years agoDisable using clang 3.9 for linux ARM cross build (dotnet/core-setup#5515)
Jan Vorlicek [Wed, 20 Mar 2019 14:56:53 +0000 (15:56 +0100)]
Disable using clang 3.9 for linux ARM cross build (dotnet/core-setup#5515)

* Disable using clang 3.9 for linux ARM cross build

The clang 3.9 was found to be generating broken code when cross
building for arm/armel long time ago for coreclr repo builds.
It was generating e.g. incorrect code for interlocked operations.
Now with a recent change in core-setup (adding linking of libatomic.a),
it started to generate broken code in core-setup too (leading to
SIGILL in libhostpolicy.so).
This change disables usage of clang 3.9 for ARM cross building, like
we do in the coreclr repo.

* Update docker image used to build for linux arm

The updated image contains clang 5.0

Commit migrated from https://github.com/dotnet/core-setup/commit/9ae2a9af66c0c44e7078b3dcc37fc66a350a3cb1

5 years agoExact spec of framework version resolution (dotnet/core-setup#5202)
Vitek Karas [Wed, 20 Mar 2019 10:46:00 +0000 (03:46 -0700)]
Exact spec of framework version resolution (dotnet/core-setup#5202)

Commit migrated from https://github.com/dotnet/core-setup/commit/ff91750c447ebdfa762683197a72b92f66464f1f

5 years agoCreate targeting pack macOS pkg installer (dotnet/core-setup#5504)
Davis Goodin [Tue, 19 Mar 2019 21:55:28 +0000 (16:55 -0500)]
Create targeting pack macOS pkg installer (dotnet/core-setup#5504)

Commit migrated from https://github.com/dotnet/core-setup/commit/41ebaaa81cfd9810920388933de07ded53128bcc

5 years agoEnable upgrade-in-place Shared Framework bundle installer (dotnet/core-setup#5509)
John Beisner [Tue, 19 Mar 2019 21:17:14 +0000 (14:17 -0700)]
Enable upgrade-in-place Shared Framework bundle installer (dotnet/core-setup#5509)

*'upgrade-in-place' Shared Framework bundle installer.

Commit migrated from https://github.com/dotnet/core-setup/commit/1c42c6215b8183cb55b85ee046a9a3521fc76d64

5 years agoMove pkg tools import for runtime.json override (dotnet/core-setup#5512)
Davis Goodin [Tue, 19 Mar 2019 21:06:51 +0000 (16:06 -0500)]
Move pkg tools import for runtime.json override (dotnet/core-setup#5512)

IncludeRuntimeJson was being overridden by dir.props, but the value in dir.props should have been overridden.

Commit migrated from https://github.com/dotnet/core-setup/commit/b0cfc6e820a94a1251e4fbb8cc2411ca351e3209

5 years agoDon't save CI packages as artifacts (dotnet/core-setup#5508)
Davis Goodin [Tue, 19 Mar 2019 17:30:36 +0000 (12:30 -0500)]
Don't save CI packages as artifacts (dotnet/core-setup#5508)

Publishing to a build artifact can take long enough to time out the build, and isn't useful very often.

Commit migrated from https://github.com/dotnet/core-setup/commit/4d6b497d03a1758b9beed08a0b3fa258bc78160d

5 years agoFramework resolution tests (dotnet/core-setup#5502)
Vitek Karas [Tue, 19 Mar 2019 15:14:46 +0000 (08:14 -0700)]
Framework resolution tests (dotnet/core-setup#5502)

* Framework resolution tests

Backfill detailed tests for framework resolution behavior, specifically
around roll-forward.

Introduces some new test helpers
* hostpolicy mock, to avoid actually loading and running coreclr just to
validate selected frameworks
* Builder-like API for `.runtimeconfig.js`
* Builder-like API for shared frameworks
* Some helper classes to limit file copy while keeping the tests fully
isolated

Commit migrated from https://github.com/dotnet/core-setup/commit/e42109d82608c0c0a6123f9b70c21ab632b08d07

5 years agoCreate WindowsDesktop targeting pack MSIs, fix registry entry ref counting (dotnet...
Davis Goodin [Mon, 18 Mar 2019 22:55:20 +0000 (17:55 -0500)]
Create WindowsDesktop targeting pack MSIs, fix registry entry ref counting (dotnet/core-setup#5491)

* Create targeting pack MSIs through pkgproj

* Use generated GUIDs for MSI Provider components

Fixes ref-counting for registry keys. Registry entries could be left behind on uninstall because the static GUID with a changing registry key path broke ref counting.

* Fix GetUpgradeCode comment

Commit migrated from https://github.com/dotnet/core-setup/commit/165bba0c0e5b74cb545649c626f27c404dce2b55

5 years agoUpdate the roll forward doc to document no inheritance (dotnet/core-setup#5497)
Vitek Karas [Mon, 18 Mar 2019 20:39:51 +0000 (13:39 -0700)]
Update the roll forward doc to document no inheritance (dotnet/core-setup#5497)

The original version of the doc defined that chained framework references would inherit effective roll forward settings (with possible overrides).

But the code never implemented the behavior. The behavior in code is such that each `.runtimeconfig.json` is processed in isolation.

Changing the document to match the code.

Commit migrated from https://github.com/dotnet/core-setup/commit/c638300eb750c6e731495a756a8e35e11e7bd844

5 years agoCOMHost logging and registration bugs (dotnet/core-setup#5496)
Aaron Robinson [Sat, 16 Mar 2019 22:41:24 +0000 (15:41 -0700)]
COMHost logging and registration bugs (dotnet/core-setup#5496)

Initialize logging during registration
Set default name for COM server entry
Handle cases where GUIDs supplied in .clsidmap are not in full GUID format

Commit migrated from https://github.com/dotnet/core-setup/commit/606cf1f607d23f0ae5557c580e55f4f99d6d4ece

5 years agoOnly run long path test if machine-wide setting is enabled (dotnet/core-setup#5492)
Elinor Fung [Sat, 16 Mar 2019 18:08:26 +0000 (11:08 -0700)]
Only run long path test if machine-wide setting is enabled (dotnet/core-setup#5492)

Commit migrated from https://github.com/dotnet/core-setup/commit/60d8fb31b7e96b1682d1a4efba713aee91413c1b

5 years agoRevert "Remove MyGet feed restore sources (dotnet/core-setup#5484)" (dotnet/core...
Davis Goodin [Fri, 15 Mar 2019 17:34:22 +0000 (12:34 -0500)]
Revert "Remove MyGet feed restore sources (dotnet/core-setup#5484)" (dotnet/core-setup#5488)

This reverts commit dotnet/core-setup@a155796b825e025d29dba469cad7686e23aa40b3.

Commit migrated from https://github.com/dotnet/core-setup/commit/1d00c6fcd8679b1e7930636ca2194d7c9151d84a

5 years agoRestore support for UTF-8 BOM/Preamble on loading JSON.
Jeremy Barton [Fri, 15 Mar 2019 16:28:18 +0000 (09:28 -0700)]
Restore support for UTF-8 BOM/Preamble on loading JSON.

Commit migrated from https://github.com/dotnet/core-setup/commit/65af8133a3a6ceb3abe7baa39f4898e55b86ce01

5 years agoImplement Single-file Bundler (dotnet/core-setup#5286)
Swaroop Sridhar [Fri, 15 Mar 2019 03:10:53 +0000 (20:10 -0700)]
Implement Single-file Bundler (dotnet/core-setup#5286)

* Implement Single-file Bundler

This change implements the single-file bundler, according to this
[design document](https://github.com/dotnet/designs/blob/master/accepted/single-file/design.md)

The change also adds a test-case that:
* Bundles the contents of a self-contained console app publish directory along with all sub-directories
* Extracts the contents to a new location
* Runs the extracted app to verify successful execution

TBD:
* Add more tests tests once the host-changes to process the bundle are implemented.
* Localization of output strings.

Issue: https://github.com/dotnet/coreclr/issues/20287

Commit migrated from https://github.com/dotnet/core-setup/commit/1bcd5d5ec790b9d6ade0ff8619bd0acfe6e50269

5 years agoRemove MyGet feed restore sources (dotnet/core-setup#5484)
Davis Goodin [Thu, 14 Mar 2019 21:34:15 +0000 (16:34 -0500)]
Remove MyGet feed restore sources (dotnet/core-setup#5484)

Commit migrated from https://github.com/dotnet/core-setup/commit/a155796b825e025d29dba469cad7686e23aa40b3

5 years agoUse tests folder for test artifacts (dotnet/core-setup#5478)
Vitek Karas [Thu, 14 Mar 2019 17:29:32 +0000 (10:29 -0700)]
Use tests folder for test artifacts (dotnet/core-setup#5478)

Commit migrated from https://github.com/dotnet/core-setup/commit/aa0913a7b96bc77935f48d85efe2f67434945c84

5 years agoMaintain readme table: add 3.0 + 2.2 columns, remove 2.0 column, add table tooling...
Davis Goodin [Thu, 14 Mar 2019 15:44:33 +0000 (10:44 -0500)]
Maintain readme table: add 3.0 + 2.2 columns, remove 2.0 column, add table tooling (dotnet/core-setup#5468)

* Normalize table to reduce diff

* Create task to regen table based on existing links

This commit includes a table regeneration run to see that nothing was lost.

* Add 2.2 + 3.0, remove 2.0

* Clarify table regen task and target

* Fix Ubuntu 14.04 3.0 links

Commit migrated from https://github.com/dotnet/core-setup/commit/b0f767dd8b7af4ff62d9a704aeea18f0aaf75719

5 years agoClarify why renaming dotnet.exe is blocked. (dotnet/core-setup#5476)
Vitek Karas [Thu, 14 Mar 2019 14:30:16 +0000 (07:30 -0700)]
Clarify why renaming dotnet.exe is blocked. (dotnet/core-setup#5476)

Commit migrated from https://github.com/dotnet/core-setup/commit/f8edc0e02e4389efe98a9ba762d72228eb8c345e

5 years agoBackfill license headers (dotnet/core-setup#5469)
Vitek Karas [Wed, 13 Mar 2019 23:37:29 +0000 (16:37 -0700)]
Backfill license headers (dotnet/core-setup#5469)

Commit migrated from https://github.com/dotnet/core-setup/commit/b944f5ba22e7b4733e6437cb57d65e425cedac3d

5 years agoUpdate dotnet.exe win32 manifest to support long paths (dotnet/core-setup#5335)
Elinor Fung [Wed, 13 Mar 2019 17:08:17 +0000 (10:08 -0700)]
Update dotnet.exe win32 manifest to support long paths (dotnet/core-setup#5335)

* Update dotnet.exe win32 manifest to support long paths
* Add test using a Win32 API with long paths

Fixes dotnet/core-setup#5262

Commit migrated from https://github.com/dotnet/core-setup/commit/a76107370efa277c49c44298ffded862e2999d57

5 years agoUse the CMake install target to place binaries instead of MSBuild post-processing...
Jeremy Koritzinsky [Tue, 12 Mar 2019 22:29:30 +0000 (15:29 -0700)]
Use the CMake install target to place binaries instead of MSBuild post-processing (dotnet/core-setup#5397)

We generate an install target to place our binaries and symbols in the right location via CMake, but we never use it. Additionally, we effectively replicate that functionality in `core-host/build.proj`.

This PR switches the native build to place the native output via the CMake install target and removes the MSBuild scripting that was duplicating it.

Also fixes a few build bugs in our RID construction in `src/corehost/build.sh` with cross-compilation.

Commit migrated from https://github.com/dotnet/core-setup/commit/76887daf5a142dcae756882ff1849f620dfe1aa4

5 years agoAdd pkgproj-based DEB/RPM build for targeting packs (dotnet/core-setup#5369)
Davis Goodin [Tue, 12 Mar 2019 21:24:49 +0000 (16:24 -0500)]
Add pkgproj-based DEB/RPM build for targeting packs (dotnet/core-setup#5369)

* Pkgproj-based DEB/RPM build for targeting packs

* Code review fixes

Make clean displayName clearer.

Add '-a' to 'docker system prune'.

Fix comments for fpm and debuild tool checks.

* Fix bad indent

Commit migrated from https://github.com/dotnet/core-setup/commit/f6441d4af6030bd40eb0440038bbe4d522d266cf

5 years agoThe AppHost and the global registry key (dotnet/core-setup#5455)
John Beisner [Tue, 12 Mar 2019 21:07:28 +0000 (14:07 -0700)]
The AppHost and the global registry key (dotnet/core-setup#5455)

* The AppHost needs to consider the self-registered dotnet installation location when searching for the HostFXR.

Commit migrated from https://github.com/dotnet/core-setup/commit/ede9e16b4b2396475bdc38700ed6205b3df4c0bf

5 years agoClean up RPM dotnet symlink to fix build failure (dotnet/core-setup#5451)
Davis Goodin [Tue, 12 Mar 2019 20:45:54 +0000 (15:45 -0500)]
Clean up RPM dotnet symlink to fix build failure (dotnet/core-setup#5451)

Commit migrated from https://github.com/dotnet/core-setup/commit/43f5f662f30718de0ea2bda2f8abd759a6ad9863

5 years agoTest rename (dotnet/core-setup#5440)
Elinor Fung [Tue, 12 Mar 2019 18:39:58 +0000 (11:39 -0700)]
Test rename (dotnet/core-setup#5440)

* Test rename

- Remove 'GivenThatICareAbout' prefix from file and class names
- Remove unnecessary public sets
- Rename/shorten test project fixture variable names
- Consistent formatting of assertions for Pass/Fail and HaveStdOut/Err

Commit migrated from https://github.com/dotnet/core-setup/commit/1956cfc197079daf1facaaf1dba2e24dad383bdb

5 years agoTest cleanup (dotnet/core-setup#5410)
Vitek Karas [Mon, 11 Mar 2019 20:16:28 +0000 (13:16 -0700)]
Test cleanup (dotnet/core-setup#5410)

* Test cleanup

* PR Feedback

Commit migrated from https://github.com/dotnet/core-setup/commit/c285e76a5b768dcb4434f0349e5fcc78bf9c9e29

5 years agoFix comhost to actually have exports (dotnet/core-setup#5431)
Vitek Karas [Mon, 11 Mar 2019 16:07:21 +0000 (09:07 -0700)]
Fix comhost to actually have exports (dotnet/core-setup#5431)

This regression was introduced in dotnet/core-setup#5228

Commit migrated from https://github.com/dotnet/core-setup/commit/e9cb90761197c4fce33c24f17af77d42e488605d

5 years agoMove method bodies out of header files (dotnet/core-setup#5406)
Vitek Karas [Sun, 10 Mar 2019 06:59:21 +0000 (22:59 -0800)]
Move method bodies out of header files (dotnet/core-setup#5406)

Commit migrated from https://github.com/dotnet/core-setup/commit/e2a3635ab218108042058465ac03de4c4fe1fca6

5 years agoRemove small amount of code duplication in cmake files. (dotnet/core-setup#5409)
Vitek Karas [Sat, 9 Mar 2019 20:47:02 +0000 (12:47 -0800)]
Remove small amount of code duplication in cmake files. (dotnet/core-setup#5409)

Commit migrated from https://github.com/dotnet/core-setup/commit/f7fde3da40fd616e65cbb85e8d45621de061f05a

5 years agoSplit libhost.h into multiple headers and cleanup (dotnet/core-setup#5391)
Vitek Karas [Fri, 8 Mar 2019 21:49:23 +0000 (13:49 -0800)]
Split libhost.h into multiple headers and cleanup (dotnet/core-setup#5391)

Commit migrated from https://github.com/dotnet/core-setup/commit/3586f526ae50b9c1f7e31019a317a7358f1f2170

5 years agoRemove host RPM postinstall, install the symlink (dotnet/core-setup#5380)
Davis Goodin [Fri, 8 Mar 2019 21:22:29 +0000 (15:22 -0600)]
Remove host RPM postinstall, install the symlink (dotnet/core-setup#5380)

Rather than using postinstall and postuninstall scripts to maintain a /usr/bin/dotnet symlink, have the RPM package install the symlink file itself. This reduces the complexity of the host package.

Commit migrated from https://github.com/dotnet/core-setup/commit/76f2f1e43f8951d7ef4a3f059be4a9ae9c849f7a

5 years agoRegistry component mistakenly reinstated; see: (dotnet/core-setup#5393)
John Beisner [Fri, 8 Mar 2019 19:50:02 +0000 (11:50 -0800)]
Registry component mistakenly reinstated; see: (dotnet/core-setup#5393)

Registry component mistakenly reinstated

Commit migrated from https://github.com/dotnet/core-setup/commit/007088847d7e6fe1943bdb6f93ca24eb7a94cf9a

5 years agoFix native build warnings (dotnet/core-setup#5389)
Vitek Karas [Fri, 8 Mar 2019 17:41:00 +0000 (09:41 -0800)]
Fix native build warnings (dotnet/core-setup#5389)

Commit migrated from https://github.com/dotnet/core-setup/commit/54afeff31b17226d98b9a25c7c6d9abd6b4d35fc

5 years agoHost testing proposal (dotnet/core-setup#5153)
Vitek Karas [Fri, 8 Mar 2019 10:39:07 +0000 (02:39 -0800)]
Host testing proposal (dotnet/core-setup#5153)

Commit migrated from https://github.com/dotnet/core-setup/commit/df98d5ca0ac0d3c9db6af6c0cfc3586bf656f9b5