Raphael Isemann [Tue, 6 Apr 2021 12:30:27 +0000 (14:30 +0200)]
[lldb][NFC] Fix misleading indentation in Cocoa.cpp
Jay Foad [Tue, 6 Apr 2021 12:17:29 +0000 (13:17 +0100)]
[AMDGPU] Fix dubious regexes with unescaped brackets. NFC.
Simon Pilgrim [Tue, 6 Apr 2021 11:35:55 +0000 (12:35 +0100)]
[InstCombine] Add PR45984 test case
Fold (a ^ b) | ~(a | b) --> ~(a & b)
Alex Zinenko [Tue, 6 Apr 2021 10:53:04 +0000 (12:53 +0200)]
[mlir] Fix support for lowering non-32-bit affine reductions.
The existing implementation was always creating 32-bit constants for
floating-point and integer reductions regardless of the actual type, which
resulted in invalid IR being generated for any types other than f32 and i32
when lowering affine.parallel to SCF. Use the actual type instead.
Reviewed By: chelini
Differential Revision: https://reviews.llvm.org/D99942
Jay Foad [Tue, 6 Apr 2021 11:29:48 +0000 (12:29 +0100)]
[AMDGPU] Fix typo in regular expression checks. NFC.
Simon Pilgrim [Tue, 6 Apr 2021 11:24:04 +0000 (12:24 +0100)]
LoopFlatten - CanWidenIV - Fix uninitialized variable warnings and use for-range loop. NFCI.
Fix static analysis uninitialized variable warnings, and use for-range loop iteration across WideIVs array.
Simon Pilgrim [Tue, 6 Apr 2021 11:04:01 +0000 (12:04 +0100)]
Don't directly dereference getAs<> casts to avoid potential null dereferences. NFCI.
Replace with castAs<> which asserts the cast is valid.
Fixes a number of static analyzer warnings.
Abhina Sreeskantharajan [Tue, 6 Apr 2021 11:22:41 +0000 (07:22 -0400)]
[SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text
Problem:
On SystemZ we need to open text files in text mode. On Windows, files opened in text mode adds a CRLF '\r\n' which may not be desirable.
Solution:
This patch adds two new flags
- OF_CRLF which indicates that CRLF translation is used.
- OF_TextWithCRLF = OF_Text | OF_CRLF indicates that the file is text and uses CRLF translation.
Developers should now use either the OF_Text or OF_TextWithCRLF for text files and OF_None for binary files. If the developer doesn't want carriage returns on Windows, they should use OF_Text, if they do want carriage returns on Windows, they should use OF_TextWithCRLF.
So this is the behaviour per platform with my patch:
z/OS:
OF_None: open in binary mode
OF_Text : open in text mode
OF_TextWithCRLF: open in text mode
Windows:
OF_None: open file with no carriage return
OF_Text: open file with no carriage return
OF_TextWithCRLF: open file with carriage return
The Major change is in llvm/lib/Support/Windows/Path.inc to only set text mode if the OF_CRLF is set.
```
if (Flags & OF_CRLF)
CrtOpenFlags |= _O_TEXT;
```
These following files are the ones that still use OF_Text which I left unchanged. I modified all these except raw_ostream.cpp in recent patches so I know these were previously in Binary mode on Windows.
./llvm/lib/Support/raw_ostream.cpp
./llvm/lib/TableGen/Main.cpp
./llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
./llvm/unittests/Support/Path.cpp
./clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
./clang/lib/Frontend/CompilerInstance.cpp
./clang/lib/Driver/Driver.cpp
./clang/lib/Driver/ToolChains/Clang.cpp
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D99426
Aaron Ballman [Tue, 6 Apr 2021 11:18:24 +0000 (07:18 -0400)]
Silence -Woverloaded-virtual warnings from generated code; NFC
Kerry McLaughlin [Tue, 6 Apr 2021 09:51:08 +0000 (10:51 +0100)]
[LoopVectorize] Change the identity element for FAdd
Changes getRecurrenceIdentity to always return a neutral value of -0.0 for FAdd.
Reviewed By: dmgreen, spatel
Differential Revision: https://reviews.llvm.org/D98963
Florian Hahn [Tue, 6 Apr 2021 10:54:23 +0000 (11:54 +0100)]
[VPlan] Print VPValue operands for VPWidenPHI if possible.
For VPWidenPHIRecipes that model all incoming values as VPValue
operands, print those operands instead of printing the original PHI.
D99294 updates recipes of reduction PHIs to use the VPValue for the
incoming value from the loop backedge, making use of this new printing.
Dmitry Preobrazhensky [Tue, 6 Apr 2021 11:07:45 +0000 (14:07 +0300)]
[AMDGPU][MC][GFX9] Corrected SMEM decoding
Corrected SMEM decoding when IMM=0 and OFFSET>127
Fixed bug 49819 (https://bugs.llvm.org/show_bug.cgi?id=49819)
Differential Revision: https://reviews.llvm.org/D99804
Dominik Montada [Thu, 1 Apr 2021 10:28:39 +0000 (12:28 +0200)]
[CMake] Fix Python 3 lookup when building LLVM with tests
Remove the find_package(Python3 ...) call from Tooling/CMakeLists.txt as
it would override the python 3 version determined in llvm/CMakeLists.txt.
This call did not respect the LLVM_MINIMUM_PYTHON_VERSION.
This fixes the check-all target when building LLVM on a system where the
default python version is not the minimum required version for running tests.
Reviewed By: serge-sans-paille
Differential Revision: https://reviews.llvm.org/D99715
Martin Storsjö [Sat, 3 Apr 2021 21:15:48 +0000 (00:15 +0300)]
[LLDB] Fix building for aarch64 windows after
d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99
Differential Revision: https://reviews.llvm.org/D99847
Simon Pilgrim [Tue, 6 Apr 2021 10:40:37 +0000 (11:40 +0100)]
[CostModel][X86] Improve accuracy of vXi8 multiply reduction costs
After rG47321c311bdbe0145b9bf45d822185c37b19fa50 we promote vXi8 reductions to vXi16 to create a much faster PMULLW mul reduction, followed by a (free) truncation. This avoids the high cost of repeated vXi8 multiplications (which extend+multiply+truncate to/from vXi16 types....).
Fixes the missing vXi8 mul reduction vectorization in PR42674 (Comment #20) 'mul16' test case.
Jay Foad [Tue, 6 Apr 2021 10:41:56 +0000 (11:41 +0100)]
[AMDGPU] Regenerate checks to fix prefixes broken in D96340. NFC.
Alexander Belyaev [Tue, 6 Apr 2021 10:27:44 +0000 (12:27 +0200)]
[rt] Update DIPrinter usage in 'sanitizer_symbolize.cpp`.
These changes were required after
https://github.com/llvm/llvm-project/commit/
5f57793c4fe47aa3486a755768b43189351cbd15
Differential Revision: https://reviews.llvm.org/D99937
David Spickett [Tue, 6 Apr 2021 10:25:52 +0000 (11:25 +0100)]
[lsan][test] Disable many_tls_keys_pthread.cpp on AArch64
Partially reverts
04dbb63400c5fa2f263d7473272509be572a367a.
This test requires
9be8f8b34d9b150cd1811e3556fe9d0cd735ae29
which is/has been reverted a few times but this test was
left enabled.
Currently that change is reverted and this test is failing:
http://lab.llvm.org:8011/#/builders/7/builds/2327
Zakk Chen [Tue, 30 Mar 2021 17:12:07 +0000 (10:12 -0700)]
[RISCV][Clang] Add all RVV Fixed-Point Arithmetic intrinsic functions.
Reviewed By: HsiangKai
Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Zakk Chen <zakk.chen@sifive.com>
Differential Revision: https://reviews.llvm.org/D99610
Zakk Chen [Tue, 30 Mar 2021 15:59:07 +0000 (08:59 -0700)]
[RISCV][Clang] Add more RVV Integer intrinsic functions.
Support below instructions.
1. Vector Integer Add-with-Carry / Subtract-with-Borrow Instructions
2. Vector Integer Comparison Instructions
3. Vector Widening Integer Multiply-Add Instructions
Reviewed By: HsiangKai
Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Zakk Chen <zakk.chen@sifive.com>
Differential Revision: https://reviews.llvm.org/D99528
Zakk Chen [Tue, 30 Mar 2021 15:55:46 +0000 (08:55 -0700)]
[RISCV][Clang] Add RVV Widening Integer Extension intrinsic functions.
Reviewed By: HsiangKai
Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Zakk Chen <zakk.chen@sifive.com>
Differential Revision: https://reviews.llvm.org/D99527
Zakk Chen [Mon, 29 Mar 2021 16:38:55 +0000 (09:38 -0700)]
[RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions.
Reviewed By: craig.topper
Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Zakk Chen <zakk.chen@sifive.com>
Differential Revision: https://reviews.llvm.org/D99525
Zakk Chen [Mon, 29 Mar 2021 14:37:29 +0000 (07:37 -0700)]
[RISCV][Clang] Add some RVV Integer intrinsic functions.
1. Rename RVVBinBuiltin to RVVOutputOp1Builtin because it is not related
to the number of operand.
2. Add RVV Integer instuctions which use RVVOutputOp1Builtin.
Reviewed By: craig.topper
Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Zakk Chen <zakk.chen@sifive.com>
Differential Revision: https://reviews.llvm.org/D99524
David Spickett [Thu, 1 Apr 2021 14:30:16 +0000 (15:30 +0100)]
[lldb] Improve CPUInfo test predicate
Use a with block for reading the cpuinfo file.
When loading the file fails (or we're not on Linux)
return an empty string. Since all the callers are
going to do "x in self.getCPUInfo()".
Reviewed By: omjavaid
Differential Revision: https://reviews.llvm.org/D99729
Thomas Preud'homme [Sun, 28 Mar 2021 00:03:37 +0000 (00:03 +0000)]
[test, AArch64] Fix use of var defined in CHECK-NOT
LLVM test CodeGen/AArch64/aarch64-tbz.ll tries to check for the absence
of a sequence of instructions with several CHECK-NOT with one of those
directives using a variable defined in another. However CHECK-NOT are
checked independently so that is using a variable defined in a pattern
that should not occur in the input.
This commit removes the definition and uses of variable to check each
line independently, making the check stronger than the current one. It
also removes unnecessary regex match for labels.
Reviewed By: dmgreen
Differential Revision: https://reviews.llvm.org/D99602
Simon Pilgrim [Tue, 6 Apr 2021 09:31:27 +0000 (10:31 +0100)]
[PhaseOrdering] Add PR45687 test coverage
This is a mixture of instcombine/simplfycfg/instcombine to recognise and then remove the abs pattern
madhur13490 [Thu, 18 Mar 2021 18:15:51 +0000 (18:15 +0000)]
[IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction
This patch enhances hasAddressTaken() to ignore bitcasts as a
callee in callbase instruction. Such bitcast usage doesn't really take
the address in a useful meaningful way.
Reviewed By: rampitec
Differential Revision: https://reviews.llvm.org/D98884
Simon Pilgrim [Thu, 25 Mar 2021 17:04:47 +0000 (17:04 +0000)]
[KnownBits] Rename KnownBits::computeForMul to KnownBits::mul. NFCI.
As promised in D98866
Balázs Kéri [Tue, 6 Apr 2021 08:26:52 +0000 (10:26 +0200)]
[clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.
It is possible that an entry in 'DestroyRetVal' lives longer
than an entry in 'LockMap' if not removed at checkDeadSymbols.
The added test case demonstrates this.
Reviewed By: NoQ
Differential Revision: https://reviews.llvm.org/D98504
Sjoerd Meijer [Tue, 6 Apr 2021 07:53:42 +0000 (08:53 +0100)]
[AArch64] Default to zero-cycle-zeroing FP registers
It is generally beneficial to prefer "movi d0, #0" over "fmov s0, wzr" as this
is most efficient across all cores; it is recognised as a zeroing idiom. For
newer cores, fmov instructions can also be eliminated early and there is no
difference with movi, but some implementations lack this so is not true for
other/older cores. Thus this standardises on using movi as this should always
gives the same or better performance than the fmov with wzr.
Differential Revision: https://reviews.llvm.org/D99586
Jan Svoboda [Tue, 6 Apr 2021 08:38:19 +0000 (10:38 +0200)]
[clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing
In D84673, we started using `DiagnosticsEngine` during command-line parsing in more contexts.
When using `ToolInvocation`, a custom `DiagnosticsConsumer` can be specified and it might expect `SourceManager` to be present on the emitted diagnostics.
This patch ensures the `SourceManager` is set up in such scenarios.
Test authored by Jordan Rupprecht.
Reviewed By: rupprecht
Differential Revision: https://reviews.llvm.org/D99414
Kiran Chandramohan [Tue, 6 Apr 2021 07:39:19 +0000 (08:39 +0100)]
Revert "[flang] Improve constant folding for type parameter inquiries"
This reverts commit
8c7bf2f93da9b64b07509f67552d592a86260ff5.
Sam Parker [Tue, 6 Apr 2021 07:55:27 +0000 (08:55 +0100)]
[NFC][WebAssembly] Removed mangled name from test.
Sjoerd Meijer [Thu, 1 Apr 2021 08:47:35 +0000 (09:47 +0100)]
[AArch64] Use 64-bit movi for zeroing halfs/floats
This was using the .2d variant which zeros 128 bits, but using the .2s variant
that zeros 64 bits is faster on some cores.
This is a prep step for D99586 to always using movi for zeroing floats.
Differential Revision: https://reviews.llvm.org/D99710
Jay Foad [Wed, 31 Mar 2021 10:39:25 +0000 (11:39 +0100)]
[AMDGPU] Add some missing testing for new subtargets gfx90a and gfx90c
Differential Revision: https://reviews.llvm.org/D99647
Jan Svoboda [Mon, 5 Apr 2021 10:15:50 +0000 (12:15 +0200)]
[clang][cli] Ensure plugin args are generated in deterministic order
The '-plugin-arg' command-line arguments are not being generated in deterministic order.
This patch changes the storage from `std::unordered_map` to `std::map` to enforce ordering.
Reviewed By: dexonsmith
Differential Revision: https://reviews.llvm.org/D99879
Yevgeny Rouban [Tue, 6 Apr 2021 06:14:16 +0000 (13:14 +0700)]
[NewPM] Fix unused lambda capture build error
Fixes commit
39e3e3aa51d: Redesign of PreserveCFG Checker
Yevgeny Rouban [Tue, 6 Apr 2021 04:55:18 +0000 (11:55 +0700)]
[NewPM] Redesign of PreserveCFG Checker
The reason for the NewPM redesign is described in the commit
cba3e783389a: [NewPM] Disable PreservedCFGChecker ...
The checker introduces an internal custom CFG analysis that tracks
current up-to date CFG snapshot. The analysis is invalidated along
any other CFG related analysis (the key is CFGAnalyses). If the CFG
analysis is not invalidated at a functional pass exit then the checker
asserts that the CFG snapshot taken from this analysis is equals to
a snapshot of the current CFG.
Along the way:
- the function CFG::printDiff() is simplified by removing function
name calculation. The name is printed by the caller;
- fixed CFG invalidated condition (see CFG::invalidate());
- StandardInstrumentations::registerCallbacks() gets additional
optional parameter of type FunctionAnalysisManager*, which is
needed by the checker to get the custom CFG analysis;
- several PM related tests updated to explicitly set
-verify-cfg-preserved=1 as they need.
This patch is safe to land as the CFGChecker is left switched off
(the options -verify-cfg-preserved is false by default). It will be
switched on by a separate patch to minimize possible reverts.
Reviewed By: skatkov, kuhar
Differential Revision: https://reviews.llvm.org/D91327
Geoffrey Martin-Noble [Tue, 6 Apr 2021 04:32:23 +0000 (21:32 -0700)]
[MLIR][docs] Fixes to operation syntax in Lang Ref
Reviewed By: rriddle
Differential Revision: https://reviews.llvm.org/D99922
Serguei Katkov [Mon, 5 Apr 2021 03:21:46 +0000 (10:21 +0700)]
[Statepoint] Factor-out utility function to get non-foldable area of STATEPOINT like instructions. NFC
Reviewers: reames, dantrushin
Reviewed By: reames
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D99875
Yevgeny Rouban [Tue, 6 Apr 2021 04:31:07 +0000 (11:31 +0700)]
[NewPM] Change tests to run them without PreserveCFGChecker. NFC
Change several pass sequence sensitive tests to be indifferent
to the PreserveCFGChecker by explicitly settting the option
-verify-cfg-preserved=0. It is a preparation step that allows
a redesign of PreserveCFGChecker.
Reviewed By: skatkov
Differential Revision: https://reviews.llvm.org/D99878
Craig Topper [Tue, 6 Apr 2021 04:25:52 +0000 (21:25 -0700)]
[RISCV] When custom iseling masked stores, copy the mask into V0 instead of virtual register.
I missed a few intrinsics in
3dd4aa7d09599507d1f801ffe4bec4c9eebbb8da
when I did this for masked loads and masked segment loads/stores.
Found while trying to share more code between these custom isel
functions.
Philip Reames [Tue, 6 Apr 2021 04:05:40 +0000 (21:05 -0700)]
Comment adjustments for a rename
Arthur Eubanks [Tue, 30 Mar 2021 00:02:41 +0000 (17:02 -0700)]
[SROA] Allow SROA on pointers with invariant group intrinsic uses
When we are able to SROA an alloca, we know all uses of it, meaning we
don't have to preserve the invariant group intrinsics and metadata.
It's possible that we could lose information regarding redundant
loads/stores, but that's unlikely to have any real impact since right
now the only user is Clang and vtables.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D99760
Philip Reames [Tue, 6 Apr 2021 02:21:38 +0000 (19:21 -0700)]
Exact ashr/lshr don't loose any set bits and are thus trivially invertible
Use that fact to improve isKnownNonEqual.
patacca [Sat, 3 Apr 2021 22:04:52 +0000 (17:04 -0500)]
[Polly] Refactoring isInnermost() from isl to use the C++ wrapper
Polly use algorithms from the Integer Set Library (isl), which is a library written in C and which is incompatible with the rest of the LLVM as it is written in C++.
Changes made:
- Refactoring isInnermost() to take C++ bindings instead of the plain isl C api.
- Addition of manage_copy() when needed to get the reference for the isl_ast_node object
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D99841
Christopher Di Bella [Sun, 21 Mar 2021 18:48:24 +0000 (18:48 +0000)]
[libcxx] moves `std::invoke` into `__functional_base`
Including `<concepts>` in other standard library headers (such as
`<iterator>`) creates circular dependencies due to `<functional>`.
Since `<concepts>` only needs `std::invoke` from `<functional>`, the
easiest, fastest, and cleanest way to eliminate the circular dep is to
move `std::invoke` into `__functional_base`.
This has the added advantage of `<concepts>` not transitively importing
`<functional>`.
Differential Revision: https://reviews.llvm.org/D99041
Philip Reames [Tue, 6 Apr 2021 01:22:01 +0000 (18:22 -0700)]
Address minor post commit feedback on 0e59dd
Jim Ingham [Mon, 5 Apr 2021 17:29:21 +0000 (10:29 -0700)]
Revert "Revert "Add support for fetching signed values from tagged pointers.""
This reverts commit
602ab188a7e18b97d9af95e17271e8fbee129081.
The patch replicated an lldbassert for a certain type of NSNumber for tagged
pointers. This really shouldn't be an assert since we don't do anything wrong
with these numbers, we just don't print a summary. So this patch changed the
lldbassert to a log message in reverting the revert.
Stanislav Mekhanoshin [Mon, 5 Apr 2021 21:45:33 +0000 (14:45 -0700)]
Copy syncscope when expanding atomicrmw into cmpxchg loop
Fixes: SWDEV-280070
Differential Revision: https://reviews.llvm.org/D99902
Craig Topper [Tue, 6 Apr 2021 00:02:27 +0000 (17:02 -0700)]
[RISCV] Add more RV32 vslide1up intrinsic test cases. NFC
For some reason we only had 1 test case. This synchronizes the
test with vslide1down so we have the same number of tests for both.
MaheshRavishankar [Mon, 5 Apr 2021 22:44:07 +0000 (15:44 -0700)]
[mlir][Linalg] Add callbacks to fusion of elementwise operations to control fusion.
Right now Elementwise operations fusion in Linalg fuses everything it
can. This can run up against resource limits of the target hardware
without some checks. This patch adds a callback function that clients
can use to implement a cost function. When two elementwise operations
are deemed structurally fusable, the callback can be used to control
if the fusion applies.
Differential Revision: https://reviews.llvm.org/D99820
Peter Steinfeld [Mon, 5 Apr 2021 18:12:13 +0000 (11:12 -0700)]
[flang] Improve constant folding for type parameter inquiries
We were not folding type parameter inquiries for the form 'var%typeParam'
where 'typeParam' was a KIND or LEN type parameter of a derived type and 'var'
was a designator of the derived type. I fixed this by adding code to the
function 'FoldOperation()' for 'TypeParamInquiry's to handle this case. I also
cleaned up the code for the case where there is no designator.
In order to make the error messages correctly refer to both the points of
declaration and instantiation, I needed to add an argument to the function
'InstantiateIntrinsicType()' for the location of the instantiation.
I also changed the formatting of 'TypeParamInquiry' to correctly format this
case. I also added tests for both KIND and LEN type parameter inquiries in
resolve104.f90.
Making these changes revealed an error in resolve89.f90 and caused one of the
error messages in assign04.f90 to be different.
Differential Revision: https://reviews.llvm.org/D99892
Nico Weber [Mon, 5 Apr 2021 23:00:18 +0000 (19:00 -0400)]
Revert "[sanitizer] Simplify GetTls with dl_iterate_phdr on Linux"
This reverts commit
ec575e3b0a462ff7a3d23d0f39a22147606050de.
Still doesn't work, see https://crbug.com/1196037
Aaron Ballman [Mon, 5 Apr 2021 21:51:05 +0000 (17:51 -0400)]
Rework the way statement attributes are processed; NFC
This changes our approach to processing statement attributes to be more
similar to how we process declaration attributes. Namely,
ActOnAttributedStmt() now calls ProcessStmtAttributes() instead of
vice-versa, and there is now an interface split between building an
attributed statement where you already have a list of semantic
attributes and building an attributed statement with attributes from
the parser.
This should make it easier to support statement attributes that are
dependent on a template. In that case, you would add a
TransformFooAttr() function in TreeTransform.h to perform the semantic
checking (morally similar to how Sema::InstantiateAttrs() already works
for declaration attributes) when transforming the semantic attribute at
instantiation time.
Aart Bik [Mon, 5 Apr 2021 20:43:22 +0000 (13:43 -0700)]
[mlir][sparse] move new test to right directory structure
Differential Revision: https://reviews.llvm.org/D99899
Martin Storsjö [Wed, 17 Mar 2021 10:10:42 +0000 (12:10 +0200)]
[libcxx] [ci] Add a Windows CI buildkite configuration
Differential Revision: https://reviews.llvm.org/D99093
Sanjay Patel [Mon, 5 Apr 2021 20:47:29 +0000 (16:47 -0400)]
[InstSimplify] fix potential miscompile in select value equivalence
This is the sibling fix to
c590a9880d7a -
as there, we can't subsitute a vector value the equality
compare replacement that we are trying requires that the
comparison is true for the entire value. Vector select
can be partly true/false.
Sanjay Patel [Mon, 5 Apr 2021 20:11:39 +0000 (16:11 -0400)]
[InstSimplify] add test for vector select with operand replacement; NFC
We need a sibling fix to
c590a9880d7a
( https://llvm.org/PR49832 ) to avoid miscompiling.
Thomas Preud'homme [Sun, 4 Apr 2021 07:31:41 +0000 (08:31 +0100)]
[OpenCL, test] Fix use of undef FileCheck var
Clang test CodeGenOpenCL/fpmath.cl uses a variable defined in an earlier
CHECK-NOT directive. However, by definition the pattern in that
directive is not supposed to occur so no variable will be defined. This
commit solves the issue by using a regex match with the same regex as in
the definition. It also changes the definition into a regex match since
no variable is going to be defined.
Reviewed By: yaxunl
Differential Revision: https://reviews.llvm.org/D99857
Craig Topper [Mon, 5 Apr 2021 20:03:36 +0000 (13:03 -0700)]
[RISCV] Add SDTCisInt to the SDTRVVSlide1 since it is only used for vslide1up.vx/vslide1down.vx.
The scalar type is already marked as XLenVT. The floating point
version would need a different rule.
Craig Topper [Mon, 5 Apr 2021 19:54:49 +0000 (12:54 -0700)]
[RISCV] Split RISCVISD::VMV_S_XF_VL into separate integer and FP.
It's a bit silly, but it allows us to write stricter type
constraints for isel. There's still some extra type checks in
the generated table due to some type interference limitations
around HWMode.
Philip Reames [Mon, 5 Apr 2021 19:38:36 +0000 (12:38 -0700)]
Fix copy paste errors in tests from
be11bd1e
Several of these weren't testing what was intented.
Philip Reames [Mon, 5 Apr 2021 19:12:16 +0000 (12:12 -0700)]
Extract a helper for figuring out if an operator is invertible [nfc]
For use in an uncoming patch. Left out the phi case (which could otherwise fit in this framework) as it would cause infinite recursion in said patch. We can probably also leverage this in instcombine to ensure we keep the two sets of related analysis and transforms in sync.
Philip Reames [Mon, 5 Apr 2021 17:24:35 +0000 (10:24 -0700)]
[tests] Precommmit tests for reasoning about equality of recurrences
Craig Topper [Mon, 5 Apr 2021 18:52:41 +0000 (11:52 -0700)]
[RISCV] Move VSLIDE1UP_VX pattern out of a loop that includes FP types.
FP would need VFSLIDE1UP_VF which uses an FP register.
Ricky Taylor [Tue, 26 Jan 2021 14:51:50 +0000 (14:51 +0000)]
[M68k] Add support for Motorola literal syntax to AsmParser
These look like $00A0cf for hex and %
001010101 for binary. They are used in Motorola assembly syntax.
Differential Revision: https://reviews.llvm.org/D98519
Jennifer Yu [Sat, 3 Apr 2021 18:09:25 +0000 (11:09 -0700)]
[OPENMP51]Initial support for nocontext clause.
Added basic parsing/sema/serialization support for the 'nocontext' clause.
Differential Revision: https://reviews.llvm.org/D99848
MaheshRavishankar [Mon, 5 Apr 2021 17:54:59 +0000 (10:54 -0700)]
[mlir][Linalg] NFC: Move populatePatterns* method into linalg namespace.
The moved `populate` methods are only relevant to Linalg
operations. So they are better of in `linalg` namespace. Also rename
`populateLinalgTensorOpsFusionPatterns` to
`populateElementwiseOpsFusionPatterns`. This makes the scope of these
patterns explicit and disambiguates it with fusion on tensors using
tile + fuse.
Differential Revision: https://reviews.llvm.org/D99819
Sam Clegg [Mon, 5 Apr 2021 15:11:37 +0000 (08:11 -0700)]
[lld][WebAssembly] Rewrite exports test in assembly. NFC
Differential Revision: https://reviews.llvm.org/D99885
Nico Weber [Mon, 5 Apr 2021 18:12:58 +0000 (14:12 -0400)]
[gn build] (manually) port
0116d04d04f2
Tom Stellard [Mon, 5 Apr 2021 15:31:09 +0000 (08:31 -0700)]
Revert "llvm-shlib: Create object libraries for each component and link against them"
This reverts commit
43ceb74eb1a5801662419fb66a6bf0d5414f1ec5.
This caused some build failures: https://bugs.llvm.org/show_bug.cgi?id=49818
Tom Stellard [Mon, 5 Apr 2021 15:30:37 +0000 (08:30 -0700)]
Revert "Fix build rules for LLVM_WITH_Z3 after D95727"
This reverts commit
d66f9c4f1e83e69abf75f97cb5f8fd1dc9422357.
This was a follow up fix for
43ceb74eb1a5801662419fb66a6bf0d5414f1ec5, which
will be reverted.
Cyndy Ishida [Mon, 5 Apr 2021 16:59:50 +0000 (09:59 -0700)]
[TextAPI] move source code files out of subdirectory, NFC
TextAPI/ELF has moved out into InterfaceStubs, so theres no longer a
need to seperate out TextAPI between formats.
Reviewed By: ributzka, int3, #lld-macho
Differential Revision: https://reviews.llvm.org/D99811
LLVM GN Syncbot [Mon, 5 Apr 2021 17:21:14 +0000 (17:21 +0000)]
[gn build] Port
9b3df78b4c2a
Charusso [Mon, 5 Apr 2021 17:20:43 +0000 (19:20 +0200)]
[analyzer] DynamicSize: Rename 'size' to 'extent'
Charusso [Mon, 5 Apr 2021 17:17:48 +0000 (19:17 +0200)]
[analyzer] DynamicSize: Debug facility
This patch adds two debug functions to ExprInspectionChecker to dump out
the dynamic extent and element count of symbolic values:
dumpExtent(), dumpElementCount().
Arnamoy Bhattacharyya [Mon, 5 Apr 2021 16:58:00 +0000 (12:58 -0400)]
[flang][driver] Modify the existing test cases that use -Mstandard in f18, to use -pedantic and %flang_fc1 to share with the new driver
Reviewed By: awarzynski
Differential Revision: https://reviews.llvm.org/D99518
Ta-Wei Tu [Mon, 5 Apr 2021 17:08:35 +0000 (01:08 +0800)]
[LoopFusion] Bails out if only the second candidate is guarded (PR48060)
If only the second candidate loop is guarded while the first one is not, fusioning
two loops might not be valid but this check is currently missing.
Fixes https://bugs.llvm.org/show_bug.cgi?id=48060
Reviewed By: sidbav
Differential Revision: https://reviews.llvm.org/D99716
Charusso [Mon, 5 Apr 2021 17:04:30 +0000 (19:04 +0200)]
[analyzer] DynamicSize: Store the dynamic size
This patch introduces a way to store the size.
Reviewed By: NoQ
Differential Revision: https://reviews.llvm.org/D69726
Arnamoy Bhattacharyya [Mon, 5 Apr 2021 16:41:46 +0000 (12:41 -0400)]
[flang][driver] Add options for -Werror
With the option given, warnings are treated as error.
Reviewed By: awarzynski
Differential Revision: https://reviews.llvm.org/D98657
Fraser Cormack [Wed, 31 Mar 2021 16:01:16 +0000 (17:01 +0100)]
[RISCV] Add support for bitcasts between scalars and fixed-length vectors
This patch supports bitcasts from scalar types to fixed-length vectors
and vice versa. It custom-lowers and custom-legalizes them to
EXTRACT_VECTOR_ELT/INSERT_VECTOR_ELT operations, using a single-element
vectors to hold the scalar where appropriate.
Previously, some of these would fail to select, others would be expanded
through stack loads and stores. Effort was made to ensure the codegen
avoids the stack for both legal and illegal scalar types.
Some of the codegen could be improved, but on first glance it looks like
a general optimization of EXTRACT_VECTOR_ELT when extracting an i64
element on RV32.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D99667
Sanjay Patel [Mon, 5 Apr 2021 16:14:49 +0000 (12:14 -0400)]
[InstCombine] fix potential miscompile in select value equivalence
As shown in the example based on:
https://llvm.org/PR49832
...and the existing test, we can't substitute
a vector value because the equality compare
replacement that we are attempting requires
that the comparison is true for the entire
value. Vector select can be partly true/false.
Sanjay Patel [Mon, 5 Apr 2021 16:03:50 +0000 (12:03 -0400)]
[InstCombine] add test for miscompile from select value equivalence; NFC
The new test is reduced from:
https://llvm.org/PR49832
...but we already show a potential miscompile in the existing test too.
John Paul Adrian Glaubitz [Mon, 5 Apr 2021 16:22:59 +0000 (09:22 -0700)]
[M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro
In
0dbcb3639451, most most target symbols were made hidden by default
with the public ones marked with LLVM_EXTERNAL_VISIBILITY. When the
M68k target was added, this particular change was forgotten so that
external tools cannot make use of the public M68k target functions
in libLLVM.so. Thus, add the missing LLVM_EXTERNAL_VISIBILITY macro
to all public target functions in the M68k backend.
Differential Revision: https://reviews.llvm.org/D99869
Fraser Cormack [Wed, 31 Mar 2021 11:51:03 +0000 (12:51 +0100)]
[RISCV] Expand scalable-vector truncstores and extloads
Caught in internal testing, these operations are assumed legal by
default, even for scalable vector types. Expand them back into separate
truncations and stores, or loads and extensions.
Also add explicit fixed-length vector tests for these operations, even
though they should have been correct already.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D99654
Erik Pilkington [Mon, 5 Apr 2021 13:05:56 +0000 (09:05 -0400)]
[SemaObjC] Fix a -Wbridge-cast false-positive
Clang used to emit a bad -Wbridge-cast diagnostic on the cast in the attached
test. This was because, after
09abecef7, struct __CFString was not added to
lookup, so the objc_bridge attribute wasn't getting duplicated onto the most
recent declaration, causing us to fail to find it in getObjCBridgeAttr. This
patch fixes this by instead walking through the redeclarations to find an
appropriate bridge attribute. rdar://
72823399
Differential revision: https://reviews.llvm.org/D99661
Stefan Pintilie [Mon, 5 Apr 2021 13:07:16 +0000 (08:07 -0500)]
[PowerPC] Fix issue where binary uses a .got but is missing a .TOC.
From the PowerPC ELFv2 ABI section 4.2.3. Global Offset Table.
```
The GOT consists of an 8-byte header that contains the TOC base (the first TOC
base when multiple TOCs are present), followed by an array of 8-byte addresses.
```
Due to the introduction of PC Relative code it is now possible to require a GOT
without having a .TOC. symbol in the object that is being linked. Since LLD uses
the .TOC. symbol to determine whether or not a GOT is required the GOT header is
not setup correctly and the 8-byte header is missing.
This patch allows the Power PC GOT setup to happen when an element is added to
the GOT instead of at the very begining. When this header is added a .TOC.
symbol is also added.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D91426
Peyton, Jonathan L [Thu, 25 Feb 2021 18:49:12 +0000 (12:49 -0600)]
[OpenMP] Fix incorrect KMP_STRLEN() macro
The second argument to the strnlen_s(str, size) function should be
sizeof(str) when str is a true array of characters with known size
(instead of just a char*). Use type traits to determine if first
parameter is a character array and use the correct size based on that
trait.
Differential Revision: https://reviews.llvm.org/D98209
Alexey Bataev [Thu, 1 Apr 2021 16:16:31 +0000 (09:16 -0700)]
[SLP]Improve vectorization of the CmpInst instructions.
During vectorization better to postpone the vectorization of the CmpInst
instructions till the end of the basic block. Otherwise we may vectorize
it too early and may miss some vectorization patterns, like reductions.
Reworked part of D57059
Differential Revision: https://reviews.llvm.org/D99796
Paul C. Anagnostopoulos [Fri, 2 Apr 2021 16:35:24 +0000 (12:35 -0400)]
[TableGen] [docs] Correct a couple of mistakes; use 'true' and 'false' in examples
Differential Revision: https://reviews.llvm.org/D99800
Alex Orlov [Mon, 5 Apr 2021 11:40:41 +0000 (15:40 +0400)]
* NFC. Refactored DIPrinter for better support of new print styles.
This patch introduces a DIPrinter interface to implement by different output style printer implementations. DIPrinterGNU and DIPrinterLLVM implement the GNU and LLVM output style printing respectively. No functional changes.
This refactoring clarifies and simplifies the code, and makes a new output style addition easier.
Reviewed By: jhenderson, dblaikie
Differential Revision: https://reviews.llvm.org/D98994
Fraser Cormack [Wed, 20 Jan 2021 07:49:53 +0000 (07:49 +0000)]
[RISCV] Add a test showing incorrect codegen
This patch adds a test which shows how the compiler incorrectly sets the
size and alignment of a stack object used to indirectly pass vector
types to functions.
In the particular example, the test passes a <4 x i8> vector type to a
function and creates a stack object of size and alignment equal to 4
bytes. However, the code generated to set up that parameter has been
scalarized and stores each element as individual XLEN-sized values. Thus
on RV32 this stores 16 bytes and on RV64 32 bytes, both of which clobber
the stack. Similarly, the alignment is set up as the alignment
of the vector type, which is not necessarily the natural alignment of XLEN.
Reviewed By: luismarques
Differential Revision: https://reviews.llvm.org/D95025
Simon Pilgrim [Mon, 5 Apr 2021 10:40:29 +0000 (11:40 +0100)]
[X86] Fold xor(zext(xor(x,c1)),c2) -> xor(zext(x),xor(zext(c1),c2))
Fixes PR47603 (second case) by extending rG89afec348dbd3e5078f176e978971ee2d3b5dec8
Simon Pilgrim [Mon, 5 Apr 2021 10:16:03 +0000 (11:16 +0100)]
[X86] Add second PR47603 test case
We had coverage for the xor(trunc(xor(x,31)),31) case but not xor(zext(xor(x,31)),31)
Thomas Preud'homme [Sat, 3 Apr 2021 07:52:39 +0000 (08:52 +0100)]
[DebugInfo, CallSites, test] Fix use of undef FileCheck var
Clang test CodeGen/debug-info-extern-call.c tries to check for the
absence of a sequence of instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.
This commit removes the CHECK-NOT for the retained line attribute
definition since the CHECK-NOT on the compile unit will already check
that there is no retained lines.
Reviewed By: djtodoro
Differential Revision: https://reviews.llvm.org/D99830
Josh Berdine [Sun, 28 Mar 2021 22:18:01 +0000 (23:18 +0100)]
[NFC][OCaml] Reformat to clean up following CAMLprim removal
The removal of CAMLprim left the code in need of an application of
clang-format. There are various other changes made by clang-format
which it seems ought to be rolled together into this diff.
Differential Revision: https://reviews.llvm.org/D99477
Josh Berdine [Sun, 28 Mar 2021 21:52:55 +0000 (22:52 +0100)]
[NFC][OCaml] Remove vestigial CAMLprim declarations
The CAMLprim macro has not been needed since OCaml 3.11, and is
defined to the empty string. This diff removes all instances of it.
Differential Revision: https://reviews.llvm.org/D99476
Josh Berdine [Sun, 28 Mar 2021 20:54:25 +0000 (21:54 +0100)]
[OCaml] Omit unnecessary GC root registrations
The current code does not follow the simple interface to the OCaml GC,
where GC roots are registered conservatively, only initializing
allocations are performed, etc. This is intentional, as stated in the
opening file comments. On the other hand, the current code does
register GC roots in many situations where it is not strictly
necessary. This diff omits many of them.
Differential Revision: https://reviews.llvm.org/D99475
Josh Berdine [Sat, 27 Mar 2021 23:00:47 +0000 (23:00 +0000)]
[OCaml] Code simplification using string allocation functions
Using the `cstr_to_string` function that allocates and initializes an
OCaml `string` value enables simplifications in several cases. This
change also has the effect of avoiding calling `memcpy` on NULL
pointers even if only 0 bytes are to be copied.
Differential Revision: https://reviews.llvm.org/D99474