Wei Yi Tee [Mon, 27 Jun 2022 09:18:01 +0000 (11:18 +0200)]
[clang][dataflow] Implement functionality for flow condition variable substitution.
This patch introduces `buildAndSubstituteFlowCondition` - given a flow condition token, this function returns the expression of constraints defining the flow condition, with values substituted where specified.
As an example:
Say we have tokens `FC1`, `FC2`, `FC3`:
```
FlowConditionConstraints: {
FC1: C1,
FC2: C2,
FC3: (FC1 v FC2) ^ C3,
}
```
`buildAndSubstituteFlowCondition(FC3, /*Substitutions:*/{{C1 -> C1'}})`
returns a value corresponding to `(C1' v C2) ^ C3`.
Note:
This function returns the flow condition expressed directly as its constraints, which differs to how we currently represent the flow condition as a token bound to a set of constraints and dependencies. Making the representation consistent may be an option to consider in the future.
Depends On D128357
Reviewed By: gribozavr2, xazax.hun
Differential Revision: https://reviews.llvm.org/D128363
Andrzej Warzynski [Thu, 23 Jun 2022 09:29:12 +0000 (09:29 +0000)]
[flang] Update the release notes
Document changes introduced in https://reviews.llvm.org/D126164.
Differential Revision: https://reviews.llvm.org/D128413
Wei Yi Tee [Mon, 27 Jun 2022 09:12:37 +0000 (11:12 +0200)]
[clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`.
`createStorageLocation` in `DataflowEnvironment` is now a trivial wrapper around the logic in `DataflowAnalysisContext`.
Additionally, `getObjectFields` and `getFieldsFromClassHierarchy` (required for the implementation of `createStorageLocation`) are also moved to `DataflowAnalysisContext`.
Reviewed By: gribozavr2, sgatev
Differential Revision: https://reviews.llvm.org/D128359
Siva Chandra Reddy [Fri, 24 Jun 2022 17:45:02 +0000 (17:45 +0000)]
[libc] Add a simple arm32 config.
This will be expanded in future as more functions are brought up on arm32.
Sven van Haastregt [Mon, 27 Jun 2022 08:55:44 +0000 (09:55 +0100)]
[OpenCL] Reduce emitting candidate notes for builtins
When overload resolution fails, clang emits a note diagnostic for each
candidate. For OpenCL builtins this often leads to many repeated note
diagnostics with no new information. Stop emitting such notes.
Update a test that was relying on counting those notes to check how
many builtins are available for certain extension configurations.
Differential Revision: https://reviews.llvm.org/D127961
Nikita Popov [Mon, 27 Jun 2022 08:50:33 +0000 (10:50 +0200)]
[SCEV] Assert that GEP source element type is sized (NFC)
This is checked by the IR verifier, so replace the condition with
an assert.
Jay Foad [Thu, 23 Jun 2022 12:35:02 +0000 (13:35 +0100)]
[AMDGPU] Fix assertion failure on mad with negative immediate addend
Without this, the new test case would fail with:
AMDGPUInstPrinter.cpp:545: void llvm::AMDGPUInstPrinter::printImmediate64(uint64_t, const llvm::MCSubtargetInfo &, llvm::raw_ostream &): Assertion `isUInt<32>(Imm) || Imm == 0x3fc45f306dc9c882' failed.
Differential Revision: https://reviews.llvm.org/D128435
Siva Chandra Reddy [Sat, 25 Jun 2022 08:28:57 +0000 (08:28 +0000)]
[libc][NFC] Make the support thread library an object library.
It was previously a header library. Making it an object library will
allow us to declare thread local variables which can used to setup a
thread's self object.
Matthias Springer [Mon, 27 Jun 2022 08:01:58 +0000 (10:01 +0200)]
[mlir][bufferization][NFC] Change signature of getMemRefType
These functions now accep unsigned attributes for address spaces instead of Attributes.
Differential Revision: https://reviews.llvm.org/D128275
Simon Tatham [Mon, 27 Jun 2022 08:36:20 +0000 (09:36 +0100)]
[libunwind,EHABI,ARM] Fix get/set of RA_AUTH_CODE.
According to EHABI32 §8.5.2, the PAC for the return address of a
function described in an exception table is supposed to be addressed
in the _Unwind_VRS_{Get,Set} API by setting regclass=_UVRSC_PSEUDO and
regno=0. (The space of 'regno' values is independent for each
regclass, and for _UVRSC_PSEUDO, there is only one valid regno so far.)
That is indeed what libunwind's _Unwind_VRS_{Get,Set} functions expect
to receive. But at two call sites, the wrong values are passed in:
regno is being set to UNW_ARM_RA_AUTH_CODE (0x8F) instead of 0, and in
one case, regclass is _UVRSC_CORE instead of _UVRSC_PSEUDO.
As a result, those calls to _Unwind_VRS_{Get,Set} return
_UVRSR_FAILED, which their callers ignore. So if you compile in the
AUTG instruction that actually validates the PAC, it will try to
validate what's effectively an uninitialised register as an
authentication code, and trigger a CPU fault even on correct exception
unwinding.
Reviewed By: danielkiss
Differential Revision: https://reviews.llvm.org/D128522
Florian Hahn [Mon, 27 Jun 2022 08:33:04 +0000 (09:33 +0100)]
[SCEV] Use SCEVUnknown(poison) instead of SCEVUnknown(undef).
Use poison instead of undef for SCEVUnkown of unreachable values.
This should be in line with the movement to replace undef with poison
when possible.
Suggested in D114650.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D128586
Mikhail Goncharov [Mon, 27 Jun 2022 08:18:39 +0000 (10:18 +0200)]
Revert "[lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers"
This reverts commit
a57b62deef37c7f2ec31bca3bf9173a6206bfb9b.
lldb-aarch64-ubuntu buildbot test fails since https://lab.llvm.org/buildbot/#/builders/96/builds/25128
Nikita Popov [Mon, 27 Jun 2022 08:15:06 +0000 (10:15 +0200)]
[FunctionAttrs] Add missing pass dependency
This pass depends on AAResults. This fixes the ocaml IPO binding
tests.
Nikita Popov [Fri, 24 Jun 2022 15:06:07 +0000 (17:06 +0200)]
[ArgPromotion] Remove legacy PM support
Support for the legacy pass manager in ArgPromotion causes
complications in D125485. As the legacy pass manager for middle-end
optimizations is unsupported, drop ArgPromotion from the legacy
pipeline, rather than introducing additional complexity to deal
with it.
Differential Revision: https://reviews.llvm.org/D128536
Adrian Kuegel [Mon, 27 Jun 2022 07:15:39 +0000 (09:15 +0200)]
[mlir] Fix ClangTidyPerformance finding (NFC)
Chuanqi Xu [Mon, 27 Jun 2022 06:44:10 +0000 (14:44 +0800)]
[NFC] Add parentheses around && within || to avoid warning
Jacques Pienaar [Mon, 27 Jun 2022 03:45:25 +0000 (20:45 -0700)]
[mlir] Flip MemRef dialect to _Both (NFC)
Chuanqi Xu [Mon, 27 Jun 2022 02:38:29 +0000 (10:38 +0800)]
Revert "[Coroutines] Only do symmetric transfer if optimization is on"
This reverts commit
7782e080e80a90f7bb32049beb3787e2118c2251. According
to the discussion of WG21, symmetric transfer is a desired feature.
Kazu Hirata [Mon, 27 Jun 2022 02:54:41 +0000 (19:54 -0700)]
Don't use Optional::hasValue (NFC)
This patch replaces x.hasValue() with x where x is contextually
convertible to bool.
Kazu Hirata [Mon, 27 Jun 2022 02:37:14 +0000 (19:37 -0700)]
[lld] Don't use Optional::hasValue (NFC)
This patch replaces x.hasValue() with x where x is contextually
convertible to bool.
Kazu Hirata [Mon, 27 Jun 2022 02:29:40 +0000 (19:29 -0700)]
[lld] Don't use Optional::hasValue (NFC)
This patch replaces x.hasValue() with x where x is contextually
convertible to bool.
Jacques Pienaar [Mon, 27 Jun 2022 02:12:38 +0000 (19:12 -0700)]
[mlir] Flip more uses to prefixed accessor form (NFC).
Try to keep the final flip small. Need to flip MemRef as there are many
templated cases with it and Tensor.
Kazu Hirata [Mon, 27 Jun 2022 01:51:54 +0000 (18:51 -0700)]
[clang] Don't use Optional::hasValue (NFC)
This patch replaces x.hasValue() with x where x is contextually
convertible to bool.
Kazu Hirata [Mon, 27 Jun 2022 01:31:51 +0000 (18:31 -0700)]
[llvm] Don't use Optional::hasValue (NFC)
This patch replaces Optional::hasValue with the implicit cast to bool
in conditionals only.
Craig Topper [Mon, 27 Jun 2022 01:19:16 +0000 (18:19 -0700)]
[RISCV] Remove extra semicolon. NFC
Fangrui Song [Mon, 27 Jun 2022 00:26:44 +0000 (17:26 -0700)]
[ELF] Remove deprecated -dc
-dc is deprecated in release/14.x. Remove it for 15.0.
The only usage I know was FreeBSD crungen which was removed by https://reviews.freebsd.org/D34215
glibc just dropped -Wl,-d today. Keep -d for now.
Kazu Hirata [Sun, 26 Jun 2022 23:10:42 +0000 (16:10 -0700)]
[llvm] Use Optional::has_value instead of Optional::hasValue (NFC)
This patch replaces x.hasValue() with x.has_value() where x is not
contextually convertible to bool.
Paul Walker [Sat, 25 Jun 2022 18:04:49 +0000 (19:04 +0100)]
[NFC][SVE] Auto-generate CHECK lines for intrinsic codegen tests.
Uday Bondhugula [Sun, 26 Jun 2022 02:23:31 +0000 (07:53 +0530)]
[MLIR] NFC. Fix doc comment for AliasResult::isNo
Fix doc comment for AliasResult::isNo. NFC.
Differential Revision: https://reviews.llvm.org/D128594
sstwcw [Sun, 26 Jun 2022 22:22:27 +0000 (22:22 +0000)]
[clang-format] Fix uninitialized memory problem
The setLength function checks for the token kind which could be
uninitialized in the previous version.
The problem was introduced in
2e32ff106e.
Reviewed By: MyDeveloperDay, owenpan
Differential Revision: https://reviews.llvm.org/D128607
Craig Topper [Sun, 26 Jun 2022 20:28:57 +0000 (13:28 -0700)]
[RISCV] Evaluate ICE operands to builtins using getIntegerConstantExpr.
Some RISC-V builtins requires ICE operands. We should call
getIntegerConstantExpr instead of EmitScalarExpr to match other
targets.
This was made a little trickier by the vector intrinsics not having
a valid type string, but there are two that have ICE operands so
I specified them manually.
Frederic Cambus [Fri, 24 Jun 2022 08:47:30 +0000 (10:47 +0200)]
[Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD
This was requested in D109244.
Differential Revision: https://reviews.llvm.org/D128512
owenca [Sat, 25 Jun 2022 05:09:57 +0000 (22:09 -0700)]
[clang-format] Quit analyzing solution space for large state count
Fixes #56043.
Differential Revision: https://reviews.llvm.org/D128574
Greg Steuck [Sun, 26 Jun 2022 19:04:43 +0000 (21:04 +0200)]
[Driver] Use Component in OpenBSD::getCompilerRT to find libraries
Clang uses runtime libraries for some advanced features like
sanitizers. Different systems have different preferences about file
placement. OpenBSD with this change will use this name for ASan:
/usr/lib/clang/15.0.0/lib/libclang_rt.asan.a
Already committed to OpenBSD repository then amended to cover the
case of development tree.
Differential Revision: https://reviews.llvm.org/D109051
Craig Topper [Sun, 26 Jun 2022 18:08:44 +0000 (11:08 -0700)]
[RISCV] Refactor SelectAddrRegImm to not depend on SelectBaseAddr.
SelectBaseAddr was a minor convenience to use since it already'
existed for vector load/store. D128187 is going to remove the other
uses of SelectBaseAddr so it has less reason to exist.
This patch removes the dependency on SelectBaseAddr and adds a new
SelectAddrFrameIndex to share some code with SelectFrameAddrRegImm.
Stella Laurenzo [Sun, 26 Jun 2022 17:39:20 +0000 (10:39 -0700)]
[mlir] Generalize SCF passes to not have to run on FuncOp.
Seems to have been an accident of history and none of these had any reason to be restricted to FuncOp.
Differential Revision: https://reviews.llvm.org/D128614
Nuno Lopes [Sun, 26 Jun 2022 17:50:47 +0000 (18:50 +0100)]
PHINode::removeIncomingValue: use poison as a placeholder instead of undef when the PHI is dead [NFC]
Craig Topper [Sun, 26 Jun 2022 17:45:48 +0000 (10:45 -0700)]
[CodeGenPrepare] Avoid double map lookup. NFCI
Nuno Lopes [Sun, 26 Jun 2022 13:56:35 +0000 (14:56 +0100)]
[LICM] Use poison to replace unreachable values instead of undef [NFC]
Shivam [Sun, 26 Jun 2022 13:52:52 +0000 (19:22 +0530)]
Update LibASTImporter.rst
As my last commit changed the name of ImportError to ASTImportError , this section also needs to be updated so changed it.
Vassil Vassilev [Sun, 26 Jun 2022 13:47:50 +0000 (13:47 +0000)]
[clang] Add missing Interpreter -> ClangDriverOptions dependency
Without this, it is possible that Interpreter.cpp is being built before
clang/Driver/Options.inc is generated.
Observed only infrequently, serial builds and ext4 manifest the problem
much more often than parallel builds and btrfs.
https://reviews.llvm.org/rG06487b010d48c36c7714ee083ed38dff65711812
is a very similar case.
Patch by t184256!
Differential revision: https://reviews.llvm.org/D115827
Tapasweni Pathak [Sun, 26 Jun 2022 09:40:43 +0000 (09:40 +0000)]
Allow interfaces to operate on in-memory buffers with no source location info.
This patch is a part of the upstreaming efforts. Cling has the ability to spawn
child interpreters (mainly for auto completions). The child interpreter import
Decls using the ASTImporter which casuses the assertion here
https://github.com/llvm/llvm-project/blob/
65eb74e94b414fcde6bfa810d1c30c7fcb136b77/clang/include/clang/Basic/SourceLocation.h#L322
The patch is co-developed with V. Vassilev.
Differential revision: https://reviews.llvm.org/D88780
Nuno Lopes [Sun, 26 Jun 2022 13:15:40 +0000 (14:15 +0100)]
[LoopSimplifyCFG] use poison when replacing dead instructions instead of undef [NFC]
Sunho Kim [Sun, 26 Jun 2022 12:57:05 +0000 (21:57 +0900)]
Revert "[clang-repl] Support destructors of global objects."
This reverts commit
9de8b05bfe0de2915d2443d06159396c5f9d389f.
Nikolas Klauser [Sun, 26 Jun 2022 12:55:19 +0000 (14:55 +0200)]
[libc++] Simplify type_traits and use more builtins
Reviewed By: ldionne, #libc
Spies: manojgupta, cjdb, ayzhao, alanphipps, libcxx-commits
Differential Revision: https://reviews.llvm.org/D127226
Stuff
Nuno Lopes [Sun, 26 Jun 2022 12:44:05 +0000 (13:44 +0100)]
[ArgumentPromotion] use poison when replacing dead instructions instead of undef [NFC]
Benjamin Kramer [Sun, 26 Jun 2022 10:54:32 +0000 (12:54 +0200)]
[Support] Work around an issue when building with old versions of libstdc++
llvm/lib/Support/UnicodeNameToCodepoint.cpp:189:12: error: chosen constructor is explicit in copy-initialization
return {N, false, 0};
^~~~~~~~~~~~~
/usr/include/c++/5.4.0/tuple:479:19: note: explicit constructor declared here
constexpr tuple(_UElements&&... __elements)
^
Jun Zhang [Sun, 19 Jun 2022 02:39:03 +0000 (10:39 +0800)]
[clang-repl] Implement code undo.
In interactive C++ it is convenient to roll back to a previous state of the
compiler. For example:
clang-repl> int x = 42;
clang-repl> %undo
clang-repl> float x = 24 // not an error
To support this, the patch extends the functionality used to recover from
errors and adds functionality to recover the low-level execution infrastructure.
The current implementation is based on watermarks. It exploits the fact that
at each incremental input the underlying compiler infrastructure is in a valid
state. We can only go N incremental inputs back to a previous valid state. We do
not need and do not do any further dependency tracking.
This patch was co-developed with V. Vassilev, relies on the past work of Purva
Chaudhari in clang-repl and is inspired by the past work on the same feature
in the Cling interpreter.
Co-authored-by: Purva-Chaudhari <purva.chaudhari02@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Signed-off-by: Jun Zhang <jun@junz.org>
Sunho Kim [Sun, 26 Jun 2022 10:02:19 +0000 (19:02 +0900)]
[clang-repl] Support destructors of global objects.
Supports destructors of global objects by properly calling jitdylib deinitialize which calls the global dtors of ir modules.
This supersedes https://reviews.llvm.org/D127945. There was an issue when calling deinitialize on windows but it got fixed by https://reviews.llvm.org/D128037.
Reviewed By: v.g.vassilev
Differential Revision: https://reviews.llvm.org/D128589
Nikita Popov [Sun, 26 Jun 2022 09:37:15 +0000 (11:37 +0200)]
Revert "[LiveInterval] Simplify. NFC"
This reverts commit
e733b80f3cba26bf2df9bd691120f37fc1af21ce.
This caused a major compile-time regression:
https://llvm-compile-time-tracker.com/compare.php?from=
3b7c3a654c9175f41ac871a937cbcae73dfb3c5d&to=
e733b80f3cba26bf2df9bd691120f37fc1af21ce&stat=instructions
About 1% on average, 10% on individual files.
Patryk Wychowaniec [Sun, 26 Jun 2022 09:20:04 +0000 (17:20 +0800)]
[AVR] Fix expanding MOVW for overlapping registers
When expanding a MOVW (16-bit copy) to two MOVs (8-bit copy), the
lower byte always comes first. This is incorrect for corner cases like
'$r24r23 -> $r25r24', in which the higher byte copy should come first.
Current patch fixes that bug as recorded at
https://github.com/rust-lang/rust/issues/98167
Reviewed By: benshi001
Differential Revision: https://reviews.llvm.org/D128588
Fangrui Song [Sun, 26 Jun 2022 05:30:52 +0000 (22:30 -0700)]
[ELF] Improve compound assignment tests
Also use strchr instead of is_contained.
Kazu Hirata [Sun, 26 Jun 2022 05:26:24 +0000 (22:26 -0700)]
[clang] Don't use Optional::hasValue (NFC)
This patch replaces Optional::hasValue with the implicit cast to bool
in conditionals only.
Fangrui Song [Sun, 26 Jun 2022 05:22:59 +0000 (22:22 -0700)]
[ELF] Support -= *= /= <<= >>= &= |= in symbol assignments
Kazu Hirata [Sun, 26 Jun 2022 04:42:52 +0000 (21:42 -0700)]
[llvm] Don't use Optional::hasValue (NFC)
This patch replaces Optional::hasValue with the implicit cast to bool
in conditionals only.
Fangrui Song [Sun, 26 Jun 2022 04:16:59 +0000 (21:16 -0700)]
[ELF] Allow ? without adjacent space
GNU ld allows 1 ? 2?3:4 : 5?6 :7
Fangrui Song [Sun, 26 Jun 2022 04:11:32 +0000 (21:11 -0700)]
[ELF][test] Improve expression test
Fangrui Song [Sun, 26 Jun 2022 03:26:47 +0000 (20:26 -0700)]
[ELF] Fix assertion failure when PROVIDE/HIDDEN/PROVIDE_HIDDEN does not have =
Fangrui Song [Sun, 26 Jun 2022 03:25:34 +0000 (20:25 -0700)]
[ELF] Allow an expression to follow = in a symbol assignment
GNU ld doesn't require whitespace before =. Match it.
LLVM GN Syncbot [Sun, 26 Jun 2022 02:21:47 +0000 (02:21 +0000)]
[gn build] Port
9ed2e68c9ae5
sstwcw [Sun, 26 Jun 2022 01:54:02 +0000 (01:54 +0000)]
[clang-format] Handle Verilog preprocessor directives
Verilog uses the backtick instead of the hash. In this revision
backticks are lexed manually and then get labeled as hashes so the logic
for handling C preprocessor stuff don't have to change. Hashes get
labeled as identifiers for Verilog-specific stuff like delays.
Reviewed By: HazardyKnusperkeks
Differential Revision: https://reviews.llvm.org/D124749
sstwcw [Sun, 26 Jun 2022 01:51:40 +0000 (01:51 +0000)]
[clang-format] Parse Verilog if statements
This patch mainly handles treating `begin` as block openers.
While and for statements will be handled in another patch.
Reviewed By: HazardyKnusperkeks
Differential Revision: https://reviews.llvm.org/D123450
sstwcw [Sun, 26 Jun 2022 01:25:39 +0000 (01:25 +0000)]
[clang-format] Fix whitespace counting stuff
The current way of counting whitespace would count backticks as
whitespace. For Verilog stuff we need backticks to be handled
correctly. For JavaScript the current way is to compare the entire
token text to see if it's a backtick. However, when the backtick is the
first token following an escaped newline, the escaped newline will be
part of the tok::unknown token. Verilog has macros and escaped newlines
unlike JavaScript. So we can't regard an entire tok::unknown token as
whitespace. Previously, the start of every token would be matched for
newlines. Now, it is all whitespace instead of just newlines.
The column counting problem has already been fixed for JavaScript in
e71b4cbdd140f059667f84464bd0ac0ebc348387 by counting columns elsewhere.
Reviewed By: HazardyKnusperkeks
Differential Revision: https://reviews.llvm.org/D124748
Joachim Priesner [Fri, 24 Jun 2022 17:01:35 +0000 (11:01 -0600)]
[clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro
Check llvm::Optional before dereferencing it.
Compute VirtualEndLoc differently to avoid an assertion failure
in clang::SourceManager::getFileIDLoaded:
Assertion `0 && "Invalid SLocOffset or bad function choice"' failed
Fangrui Song [Sat, 25 Jun 2022 20:48:52 +0000 (13:48 -0700)]
[ELF] Fix precedence of ? when there are 2 or more operators on the left hand side
For 1 != 1 <= 1 ? 1 : 2, the current code incorrectly considers that ?
has a higher precedence than != (minPrec).
Also, add a test for right associativity.
Fangrui Song [Sat, 25 Jun 2022 20:47:32 +0000 (13:47 -0700)]
[ELF] Fix precedence of == and != in expressions
In GNU ld, the == and != operators have lower precedence than < > <= >=.
This behavior matches C.
Craig Topper [Sat, 25 Jun 2022 19:19:40 +0000 (12:19 -0700)]
[RISCV] Merge more rv32/rv64 vector intrinsic tests that contain the same content.
Kazu Hirata [Sat, 25 Jun 2022 20:21:34 +0000 (13:21 -0700)]
[flang] Restore Optional::value() (NFC)
This patch restores several calls to Optional::value() in preference
to Optional::operator*.
The Flang C++ Style Guide tells us to use x.value() where no presence
test is obviously protecting a *x reference to the contents.
Differential Revision: https://reviews.llvm.org/D128590
Brad Smith [Sat, 25 Jun 2022 20:16:38 +0000 (16:16 -0400)]
[Driver][Minix] -r: imply -nostdlib like GCC
Similar to D116843 for Gnu.cpp
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D128554
Manoj Gupta [Sat, 25 Jun 2022 16:51:00 +0000 (09:51 -0700)]
Revert "[libc++] Simplify type_traits and use more builtins"
This reverts commit
42f8f557989741434d7b7b4439b3eef3e68b2ab5.
Breaks float128 usage, test case provided in D127226.
Differential Revision: https://reviews.llvm.org/D128587
Fangrui Song [Sat, 25 Jun 2022 19:31:20 +0000 (12:31 -0700)]
[ELF] Support quoted name in the TARGET command
Fangrui Song [Sat, 25 Jun 2022 19:19:45 +0000 (12:19 -0700)]
[ELF] Support quoted symbol in the ENTRY command
This matches GNU ld and matches other places we unquote the symbol name.
Fixes #56208
Fangrui Song [Sat, 25 Jun 2022 19:14:47 +0000 (12:14 -0700)]
[ELF][test] Improve linkerscript/entry.s
Philip Reames [Sat, 25 Jun 2022 19:09:25 +0000 (12:09 -0700)]
Fix build after
ab736a27
This class is templatized by the concrete subclass - not all subclasses have a data layout field called DL.
Fangrui Song [Sat, 25 Jun 2022 18:59:33 +0000 (11:59 -0700)]
[LiveInterval] Simplify. NFC
Kazu Hirata [Sat, 25 Jun 2022 18:56:50 +0000 (11:56 -0700)]
Revert "Don't use Optional::hasValue (NFC)"
This reverts commit
aa8feeefd3ac6c78ee8f67bf033976fc7d68bc6d.
Kazu Hirata [Sat, 25 Jun 2022 18:55:57 +0000 (11:55 -0700)]
Don't use Optional::hasValue (NFC)
Kazu Hirata [Sat, 25 Jun 2022 18:55:33 +0000 (11:55 -0700)]
[clang, clang-tools-extra] Don't use Optional::{hasValue,getValue} (NFC)
Sunho Kim [Sat, 25 Jun 2022 18:49:05 +0000 (03:49 +0900)]
[ORC][LLJIT] Define atexit symbol in GenericLLVMIRPlatformSupport.
Define atexit symbol in GenericLLVMIRPlatformSupport so that it doesn't need to be defined by user.
On windows, llvm codegen emits atexit runtime calls to support global deinitializers as there is no lower function like cxa_atexit as in Itanium C++ ABI. ORC JIT user had to define custom atexit symbol manually. This was a hassle as it has to deal with dso_handle and cxa_atexit internals of LLJIT. If client didn't provide atexit definition, the default behaviour is just linking with host atexit function which is destined to fail as it calls dtors when the host program exits. This is after jit instances and buffers are freed, so users would see weird access violation exception from the uknown location. (in console application, the debugger thinks exception happened in scrt_common_main_seh)
This is a hack that has some caveats. (e.g. memory address is not identical) But, it's better than the situation described in the above. Ultimately, we will move on to ORC runtime that is able to solve the memory address issue properly.
Reviewed By: sgraenitz
Differential Revision: https://reviews.llvm.org/D128037
Philip Reames [Sat, 25 Jun 2022 18:18:40 +0000 (11:18 -0700)]
[RISCV] Implement getVScaleForTuning and thus prefer scalable vectorization when enabled
LoopVectorizer uses getVScaleForTuning for deciding how to discount the cost of a potential vector factor by the amount of work performed. Without the callback implemented, the vectorizer was defaulting to an estimated vscale of 1. This results in fixed vectorization looking falsely profitable (since it used the command line VLEN).
The test change is pretty limited since a) we don't have much coverage of the vectorizer with scalable vectors at all, and b) what little coverage we have mostly uses i64 element types. There's a separate issue with <vscale x 1 x i64> which prevents us from getting to this stage of costing, and thus only the one test explicitly written to avoid that is visible in the diff. However, this is actually a very wide impact change as it changes the practical vectorization result when both fixed and scalable is enabled to scalable.
As an aside, I think the vectorizer is at little too strongly biased towards scalable when both are legal, but we can explore that separately. For now, let's just get the cost model working the way it was intended.
Differential Revision: https://reviews.llvm.org/D128547
Kazu Hirata [Sat, 25 Jun 2022 18:24:23 +0000 (11:24 -0700)]
[llvm] Don't use Optional::{hasValue,getValue} (NFC)
Philip Reames [Sat, 25 Jun 2022 18:11:58 +0000 (11:11 -0700)]
[BasicTTI] Account for vector of pointers in getMemoryOpCost
By using getPrimitiveSizeInBits, we were getting 0 for every pointer type. This code is trying to account for the cost of truncating a store or extending a load to convert from the source vector element type to the legal vector element type.
I'd originally seen this as a crash when trying to scalarize a <vscale x 1 x ptr> type coming from the vectorizer. Here's a minimum reproducer to exercise the code in question.
void e(int *argv[], int *p) {
for (int i = 0; i < 1024; i++)
argv[i] = p;
}
This was checked in as the splat_ptr test in 2cf320d. After bbf3fd, this no longer crashes since we correctly return invalid if the extending load/truncating store isn't legal.
Differential Revision: https://reviews.llvm.org/D128228
Philip Reames [Fri, 24 Jun 2022 23:59:46 +0000 (16:59 -0700)]
[RISCV] Make getMinRVVVectorSizeInBits and getMaxRVVVectorSizeInBits protected [nfc]
These are now only used in the implementation of getRealMinVLen and getRealMaxVLEn, and useRVVForFixedLengthVectors; make them protected to discourage new users.
Casey Carter [Fri, 7 Jan 2022 02:45:28 +0000 (18:45 -0800)]
[libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements
Implement `rebind`, the rebinding constructor, and rebind-compatible comparison operators.
Differential Revision: https://reviews.llvm.org/D118279
Guillaume Chatelet [Sat, 25 Jun 2022 17:18:29 +0000 (17:18 +0000)]
[NFC] Remove dead code
LLVM GN Syncbot [Sat, 25 Jun 2022 17:03:46 +0000 (17:03 +0000)]
[gn build] Port
c92056d03881
Corentin Jabot [Mon, 4 Apr 2022 10:41:12 +0000 (12:41 +0200)]
[Clang][C++23] P2071 Named universal character escapes
Implements [[ https://wg21.link/p2071r1 | P2071 Named Universal Character Escapes ]] - as an extension in all language mode, the patch not warn in c++23 mode will be done later once this paper is plenary approved (in July).
We add
* A code generator that transforms `UnicodeData.txt` and `NameAliases.txt` to a space efficient data structure that can be queried in `O(NameLength)`
* A set of functions in `Unicode.h` to query that data, including
* A function to find an exact match of a given Unicode character name
* A function to perform a loose (ignoring case, space, underscore, medial hyphen) matching
* A function returning the best matching codepoint for a given string per edit distance
* Support of `\N{}` escape sequences in String and character Literals, with loose and typos diagnostics/fixits
* Support of `\N{}` as UCN with loose matching diagnostics/fixits.
Loose matching is considered an error to match closely the semantics of P2071.
The generated data contributes to 280kB of data to the binaries.
`UnicodeData.txt` and `NameAliases.txt` are not committed to the repository in this patch, and regenerating the data is a manual process.
Reviewed By: tahonermann
Differential Revision: https://reviews.llvm.org/D123064
Kazu Hirata [Sat, 25 Jun 2022 16:18:04 +0000 (09:18 -0700)]
[mlir] Fix a warning
This patch fixes:
llvm-project/mlir/lib/Dialect/Linalg/Transforms/SplitReduction.cpp:300:26:
error: comparison of integers of different signs: 'int64_t' (aka
'long') and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
Jacques Pienaar [Sat, 25 Jun 2022 16:06:52 +0000 (09:06 -0700)]
[mlir][shape] Switch types to ODS generated (NFC)
These were already pretty simple, so just switching to generated.
Matt Arsenault [Fri, 24 Jun 2022 23:03:57 +0000 (19:03 -0400)]
GlobalISel: Make LoadStoreOpt preserve all
Avoids dropping CSE info analysis
Matt Arsenault [Fri, 24 Jun 2022 15:57:04 +0000 (11:57 -0400)]
X86: Regenerate test checks
Matt Arsenault [Fri, 24 Jun 2022 01:55:42 +0000 (21:55 -0400)]
CodeGen: Use else if between Value and PseudoSourceValue cases
These are mutually exclusive.
Arjun P [Tue, 21 Jun 2022 04:30:11 +0000 (06:30 +0200)]
[MLIR][Presburger] Support computing a representation of a set that only has locals that are divs
This paves the way for integer-exact projection, and for supporting
non-division locals in subtraction, complement, and equality checks.
Reviewed By: Groverkss
Differential Revision: https://reviews.llvm.org/D127463
Michał Górny [Sat, 25 Jun 2022 13:04:26 +0000 (15:04 +0200)]
Reland "[lldb] [llgs] Support multiprocess in qfThreadInfo"
Now preserving the non-standard behavior of returning "OK" response
when there is no debugged process.
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.llvm.org/D128152
sstwcw [Sat, 25 Jun 2022 08:35:51 +0000 (08:35 +0000)]
[clang-format] NFC Sort names of format token types
Suggested by HazardyKnusperkeks in D126845.
Reviewed By: HazardyKnusperkeks, owenpan
Differential Revision: https://reviews.llvm.org/D126934
Rainer Orth [Sat, 25 Jun 2022 08:40:11 +0000 (10:40 +0200)]
[asan][test] XFAIL global-location-nodebug.cpp on Solaris
A new test `FAIL`s on Solaris:
FAIL: AddressSanitizer-i386-sunos ::
TestCases/global-location-nodebug.cpp (465 of 64279)
FAIL: AddressSanitizer-i386-sunos-dynamic ::
TestCases/global-location-nodebug.cpp (961 of 64279)
The problem is the unconditional use of `-Wl,-S`:
ld: fatal: dlopen() of support library (-lstdc++) failed with error:
ld.so.1: ld: -lstdc++: open failed: No such file or directory
`ld -S` has a completely different semantics compared to GNU `ld
-S`/`--strip-debug`: specify a link-edit support library. To avoid this,
I've chosen to `XFAIL` the test.
Tested on `amd64-pc-solaris2.11`.
Differential Revision: https://reviews.llvm.org/D128516
Michał Górny [Sat, 25 Jun 2022 07:39:25 +0000 (09:39 +0200)]
Revert "[lldb] [llgs] Support multiprocess in qfThreadInfo"
This reverts part of commit
75757c86c695a6b4695458343637b3c4fe86def6.
It broke the following test:
commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
I need more time to figure it out, so I'm reverting the code changes
and marking the tests depending on them xfail.
Pavel Samolysov [Sat, 25 Jun 2022 07:31:27 +0000 (10:31 +0300)]
[DeadArgElim] Replace insert with emplace (NFC)
Valentin Clement [Sat, 25 Jun 2022 07:18:59 +0000 (09:18 +0200)]
[flang] Use descriptors for real/complex input other than kinds 4 and 8
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: PeteSteinfeld, vdonaldson
Differential Revision: https://reviews.llvm.org/D128502
Co-authored-by: V Donaldson <vdonaldson@nvidia.com>
Siva Chandra Reddy [Sat, 25 Jun 2022 06:38:03 +0000 (06:38 +0000)]
[libc] Add compound assignment and pre-increment operators to UInt.