platform/upstream/ofono.git
14 years agoremove unneeded debug statement
Kristen Carlson Accardi [Thu, 25 Mar 2010 04:41:52 +0000 (21:41 -0700)]
remove unneeded debug statement

cleanup old debug print statement

14 years agouse separate timers for PPP config and terminate
Kristen Carlson Accardi [Thu, 25 Mar 2010 03:26:28 +0000 (20:26 -0700)]
use separate timers for PPP config and terminate

Prevent conflicts between config timer information and terminate timer
information by providing a new data structure which keeps timer information
for config and terminate requests separate.

14 years agoswitch to g_timeout_add_seconds()
Kristen Carlson Accardi [Thu, 25 Mar 2010 03:26:27 +0000 (20:26 -0700)]
switch to g_timeout_add_seconds()

we don't care that much about the exactness of our timer, so use
the more power efficient call.

14 years agoFix: Make CONNECT <baud> responses work
Denis Kenzior [Thu, 25 Mar 2010 00:42:16 +0000 (19:42 -0500)]
Fix: Make CONNECT <baud> responses work

14 years agoRefactor: Simplify parsing logic
Denis Kenzior [Thu, 25 Mar 2010 00:40:59 +0000 (19:40 -0500)]
Refactor: Simplify parsing logic

It isn't actually necessary to check the basic command prefixes, if the
extended prefix doesn't match we try to parse it like a basic command.
That one does the same exact check anyway.  If that fails, then this is
not a recognized command line anyway.

14 years agoRefactor basic command parsing
Denis Kenzior [Thu, 25 Mar 2010 00:37:18 +0000 (19:37 -0500)]
Refactor basic command parsing

Make more bullet proof and efficient

14 years agoFix: Use SO_REUSEADDR in test_server
Denis Kenzior [Thu, 25 Mar 2010 00:34:33 +0000 (19:34 -0500)]
Fix: Use SO_REUSEADDR in test_server

14 years agoStyle: foo[0] is preferable to *foo
Denis Kenzior [Wed, 24 Mar 2010 21:28:42 +0000 (16:28 -0500)]
Style: foo[0] is preferable to *foo

14 years agoFix: Be more paranoid in basic command parsing
Denis Kenzior [Wed, 24 Mar 2010 21:28:19 +0000 (16:28 -0500)]
Fix: Be more paranoid in basic command parsing

14 years agoAdd basic command parsing
Zhenhua Zhang [Wed, 24 Mar 2010 01:47:30 +0000 (09:47 +0800)]
Add basic command parsing

14 years agoStyle: No point to write a function to wrap g_free
Denis Kenzior [Wed, 24 Mar 2010 20:17:57 +0000 (15:17 -0500)]
Style: No point to write a function to wrap g_free

Using casting magic works well enough, and more consistent with the rest
of the library.

14 years agoAdd enum for cdma sms tpdu data objects
Yang Gu [Wed, 24 Mar 2010 09:35:45 +0000 (17:35 +0800)]
Add enum for cdma sms tpdu data objects

14 years agoFix enum for more time proactive command
Yang Gu [Wed, 24 Mar 2010 09:35:43 +0000 (17:35 +0800)]
Fix enum for more time proactive command

14 years agofix memory leak in ppp_auth
Kristen Carlson Accardi [Wed, 24 Mar 2010 17:13:25 +0000 (10:13 -0700)]
fix memory leak in ppp_auth

Free packet after calling ppp_transmit()

14 years agofix memory leaks after ppp_transmit
Kristen Carlson Accardi [Wed, 24 Mar 2010 17:13:24 +0000 (10:13 -0700)]
fix memory leaks after ppp_transmit

Free packets in ppp_cp after calling ppp_transmit()

14 years agofix memory leaks in option handling
Kristen Carlson Accardi [Wed, 24 Mar 2010 17:13:23 +0000 (10:13 -0700)]
fix memory leaks in option handling

free the data as well as the link when deleting options lists.

14 years agoRelease 0.20 0.20
Marcel Holtmann [Wed, 24 Mar 2010 08:26:21 +0000 (01:26 -0700)]
Release 0.20

14 years agoFix: Handle broken modems that returns empty COPS
Denis Kenzior [Tue, 23 Mar 2010 18:43:55 +0000 (13:43 -0500)]
Fix: Handle broken modems that returns empty COPS

14 years agoMove netreg interface definitions to dbus.h
Denis Kenzior [Tue, 23 Mar 2010 18:35:58 +0000 (13:35 -0500)]
Move netreg interface definitions to dbus.h

14 years agoStyle: Fixup some style issues
Denis Kenzior [Tue, 23 Mar 2010 17:31:00 +0000 (12:31 -0500)]
Style: Fixup some style issues

- Large if statements should be handled as switchcase
- Avoid initialization of variables, even if code needs to be rearranged

14 years agoAdd parser for file list objects
Yang Gu [Tue, 23 Mar 2010 04:33:49 +0000 (12:33 +0800)]
Add parser for file list objects

14 years agoFix: trivial formatting fix in call settings api
Denis Kenzior [Tue, 23 Mar 2010 04:16:06 +0000 (23:16 -0500)]
Fix: trivial formatting fix in call settings api

14 years agoRemove pointless optimization attempt with g_list_length()
Marcel Holtmann [Tue, 23 Mar 2010 04:43:46 +0000 (21:43 -0700)]
Remove pointless optimization attempt with g_list_length()

14 years agoUse password instead of passwd as variable name
Marcel Holtmann [Tue, 23 Mar 2010 03:13:55 +0000 (20:13 -0700)]
Use password instead of passwd as variable name

14 years agoThe g_free() function checks for NULL pointers
Marcel Holtmann [Tue, 23 Mar 2010 03:10:17 +0000 (20:10 -0700)]
The g_free() function checks for NULL pointers

And so does even the free() function from glibc ;)

14 years agoUnnest some more functions in PPP CP implementation
Marcel Holtmann [Tue, 23 Mar 2010 03:07:13 +0000 (20:07 -0700)]
Unnest some more functions in PPP CP implementation

14 years agoSome additional whitespace cleanup for PPP code
Marcel Holtmann [Tue, 23 Mar 2010 03:01:28 +0000 (20:01 -0700)]
Some additional whitespace cleanup for PPP code

14 years agoFix the broken PPP CP debug trace function
Marcel Holtmann [Tue, 23 Mar 2010 02:56:53 +0000 (19:56 -0700)]
Fix the broken PPP CP debug trace function

14 years agoRemove some heavy nesting that is not needed at all
Marcel Holtmann [Tue, 23 Mar 2010 02:32:47 +0000 (19:32 -0700)]
Remove some heavy nesting that is not needed at all

14 years agoFix another pointer casting issue on 32-bit systems
Marcel Holtmann [Tue, 23 Mar 2010 02:29:34 +0000 (19:29 -0700)]
Fix another pointer casting issue on 32-bit systems

14 years agoFix pointer casting with uint16 protocol variable
Marcel Holtmann [Tue, 23 Mar 2010 02:13:22 +0000 (19:13 -0700)]
Fix pointer casting with uint16 protocol variable

14 years agoMention Kristen's contributions
Marcel Holtmann [Tue, 23 Mar 2010 00:29:12 +0000 (17:29 -0700)]
Mention Kristen's contributions

14 years agoAdd PPP option to gsmdial
Kristen Carlson Accardi [Tue, 23 Mar 2010 00:06:01 +0000 (17:06 -0700)]
Add PPP option to gsmdial

Implement new options for gsmdial to use PPP and set the user name and
password for authentication if needed.

14 years agoIP support for PPP
Kristen Carlson Accardi [Tue, 23 Mar 2010 00:06:00 +0000 (17:06 -0700)]
IP support for PPP

Adds IPCP support, and creates a TUN interface for sending/receiving IP
packets.

14 years agoCHAP with MD5 authentication support
Kristen Carlson Accardi [Tue, 23 Mar 2010 00:05:59 +0000 (17:05 -0700)]
CHAP with MD5 authentication support

Authentication support with CHAP and MD5

14 years agoPPP LCP support
Kristen Carlson Accardi [Tue, 23 Mar 2010 00:05:58 +0000 (17:05 -0700)]
PPP LCP support

Implement LCP support for the PPP protocol.

14 years agoGeneric PPP control protocol support
Kristen Carlson Accardi [Tue, 23 Mar 2010 00:05:57 +0000 (17:05 -0700)]
Generic PPP control protocol support

Implement a generic protocol that can be shared by both the LCP and the
NCP implementation.

14 years agoBasic PPP protocol support
Kristen Carlson Accardi [Tue, 23 Mar 2010 00:05:56 +0000 (17:05 -0700)]
Basic PPP protocol support

This patch implements the basic PPP protocol.  LCP, NCP etc. are handled in
a different patch.

14 years agoMove sim manager interface definition to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:39:13 +0000 (15:39 -0500)]
Move sim manager interface definition to dbus.h

14 years agoMove cbs interface definition to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:36:04 +0000 (15:36 -0500)]
Move cbs interface definition to dbus.h

14 years agoMove call volume interface definition to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:33:56 +0000 (15:33 -0500)]
Move call volume interface definition to dbus.h

14 years agoMove mwi interface definition to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:31:03 +0000 (15:31 -0500)]
Move mwi interface definition to dbus.h

14 years agoMove radio settings interface definition to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:29:03 +0000 (15:29 -0500)]
Move radio settings interface definition to dbus.h

14 years agoMove sms interface definition to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:28:08 +0000 (15:28 -0500)]
Move sms interface definition to dbus.h

14 years agoMove voicecall interface definitions to dbus.h
Denis Kenzior [Mon, 22 Mar 2010 20:27:08 +0000 (15:27 -0500)]
Move voicecall interface definitions to dbus.h

14 years agoAdd message-waiting api
Denis Kenzior [Mon, 22 Mar 2010 20:16:43 +0000 (15:16 -0500)]
Add message-waiting api

14 years agoAdd call-volume api
Denis Kenzior [Mon, 22 Mar 2010 20:07:53 +0000 (15:07 -0500)]
Add call-volume api

14 years agoAdd cell broadcast API
Denis Kenzior [Mon, 22 Mar 2010 20:04:55 +0000 (15:04 -0500)]
Add cell broadcast API

14 years agoAdd phonebook-api document
Denis Kenzior [Mon, 22 Mar 2010 19:52:05 +0000 (14:52 -0500)]
Add phonebook-api document

14 years agoFix: extract line should use S3, not hardcode CR
Denis Kenzior [Mon, 22 Mar 2010 17:58:04 +0000 (12:58 -0500)]
Fix: extract line should use S3, not hardcode CR

14 years agoRefactor: Command line extraction
Denis Kenzior [Mon, 22 Mar 2010 17:57:40 +0000 (12:57 -0500)]
Refactor: Command line extraction

14 years agoRefactor: Extended command parsing
Denis Kenzior [Mon, 22 Mar 2010 17:56:57 +0000 (12:56 -0500)]
Refactor: Extended command parsing

Make the code more bullet proof and easier to follow

14 years agoAdd G_AT_SERVER_RESULT_EXT_ERROR
Zhenhua Zhang [Fri, 19 Mar 2010 09:44:45 +0000 (17:44 +0800)]
Add G_AT_SERVER_RESULT_EXT_ERROR

14 years agoAdd g_at_server_register and unregister callback
Zhenhua Zhang [Fri, 19 Mar 2010 09:44:44 +0000 (17:44 +0800)]
Add g_at_server_register and unregister callback

14 years agoAdd notify at command callback
Zhenhua Zhang [Fri, 19 Mar 2010 09:44:43 +0000 (17:44 +0800)]
Add notify at command callback

14 years agoAdd server at command data structure
Zhenhua Zhang [Fri, 19 Mar 2010 09:44:42 +0000 (17:44 +0800)]
Add server at command data structure

14 years agoAdd extended command parsing
Zhenhua Zhang [Fri, 19 Mar 2010 09:44:41 +0000 (17:44 +0800)]
Add extended command parsing

14 years agoAdd framework of server parser
Zhenhua Zhang [Fri, 19 Mar 2010 09:44:39 +0000 (17:44 +0800)]
Add framework of server parser

a. The parser fetch and parse one command per loop. The prefix is
the command prefix without parameter. For example, the prefix of
"AT+CLIP=1" is "+CLIP".

b. Search registered notification node in command_list. Invoke the
callback if found.

c. Termiate the execution if the result is an error. Otherwise,
parse next command.

14 years agoRevert the default statement for PIN type checking
Marcel Holtmann [Sat, 20 Mar 2010 01:26:57 +0000 (02:26 +0100)]
Revert the default statement for PIN type checking

Also fix the coding style for the switch statement and remove the
number assignment for an internal enum.

14 years agoTrivial: Add break statement
Denis Kenzior [Fri, 19 Mar 2010 18:51:31 +0000 (13:51 -0500)]
Trivial: Add break statement

In case we ever extend the enum/switch and unwittingly introduce a bug.

14 years agoFix: Check password length based on its type
Pekka Pessi [Fri, 19 Mar 2010 17:49:54 +0000 (19:49 +0200)]
Fix: Check password length based on its type

The different password types have different length requirements, so
update is_valid_pin to validate according to the password type being
validated (PIN / PUK / NET)

14 years agohuawei: use GSM permissive parser instead of V1.
João Paulo Rechi Vita [Thu, 18 Mar 2010 20:45:31 +0000 (17:45 -0300)]
huawei: use GSM permissive parser instead of V1.

With V1 parser the driver fails to detect when a SMS is successfully
sent and keeps re-trying until Max retries.

14 years agoAdd support for IP based connections to gsmdial
Denis Kenzior [Thu, 18 Mar 2010 21:05:01 +0000 (16:05 -0500)]
Add support for IP based connections to gsmdial

14 years agoFix: Echo everything as soon as received
Denis Kenzior [Thu, 18 Mar 2010 19:41:21 +0000 (14:41 -0500)]
Fix: Echo everything as soon as received

14 years agoUpdate sim-api.txt
Denis Kenzior [Thu, 18 Mar 2010 19:47:12 +0000 (14:47 -0500)]
Update sim-api.txt

14 years agoRefactor add is_basic_command_prefix function
Zhenhua Zhang [Thu, 18 Mar 2010 15:14:28 +0000 (23:14 +0800)]
Refactor add is_basic_command_prefix function

14 years agoRename parse_v250_settings
Zhenhua Zhang [Thu, 18 Mar 2010 15:14:27 +0000 (23:14 +0800)]
Rename parse_v250_settings

To parse_basic_command

14 years agoRename parse_at_command
Zhenhua Zhang [Thu, 18 Mar 2010 15:14:26 +0000 (23:14 +0800)]
Rename parse_at_command

To parse_extended_command

14 years agoRename is_at_command_prefix
Zhenhua Zhang [Thu, 18 Mar 2010 15:14:25 +0000 (23:14 +0800)]
Rename is_at_command_prefix

To is_extended_command_prefix

14 years agoRename g_at_server_send_result
Zhenhua Zhang [Thu, 18 Mar 2010 15:14:24 +0000 (23:14 +0800)]
Rename g_at_server_send_result

To g_at_server_send_final

14 years agoDoc: Fixup style issues
Denis Kenzior [Thu, 18 Mar 2010 16:35:06 +0000 (11:35 -0500)]
Doc: Fixup style issues

14 years agoAdded call-barring-api.txt.
Pekka Pessi [Thu, 18 Mar 2010 14:44:30 +0000 (16:44 +0200)]
Added call-barring-api.txt.

14 years agoFix: Interrogation of barring does not need pin
Pekka Pessi [Thu, 18 Mar 2010 14:44:27 +0000 (16:44 +0200)]
Fix: Interrogation of barring does not need pin

14 years agoFix: Number of barring services is constant
Pekka Pessi [Thu, 18 Mar 2010 14:44:27 +0000 (16:44 +0200)]
Fix: Number of barring services is constant

14 years agoStyle: Remove the now unnecessary braces
Denis Kenzior [Thu, 18 Mar 2010 16:27:06 +0000 (11:27 -0500)]
Style: Remove the now unnecessary braces

14 years agoFix: Return newly-queried barring status
Pekka Pessi [Thu, 18 Mar 2010 14:44:26 +0000 (16:44 +0200)]
Fix: Return newly-queried barring status

We were returning the contents of the old locks

14 years agoFix: call barring can only be (de)activated
Pekka Pessi [Thu, 18 Mar 2010 14:44:25 +0000 (16:44 +0200)]
Fix: call barring can only be (de)activated

14 years agoFix: Use g_try_malloc when parsing stk result
Denis Kenzior [Tue, 16 Mar 2010 22:41:26 +0000 (17:41 -0500)]
Fix: Use g_try_malloc when parsing stk result

14 years agoFix: Use g_try_malloc when parsing stk address
Denis Kenzior [Tue, 16 Mar 2010 22:40:44 +0000 (17:40 -0500)]
Fix: Use g_try_malloc when parsing stk address

14 years agoFix: Use g_try_malloc in gisi/pipe.c
Denis Kenzior [Tue, 16 Mar 2010 22:37:44 +0000 (17:37 -0500)]
Fix: Use g_try_malloc in gisi/pipe.c

14 years agoFix: Use g_try_malloc not g_malloc in isi/pep.c
Denis Kenzior [Tue, 16 Mar 2010 22:34:49 +0000 (17:34 -0500)]
Fix: Use g_try_malloc not g_malloc in isi/pep.c

14 years agoStyle: Use newlines to make the code more readable
Denis Kenzior [Tue, 16 Mar 2010 22:34:18 +0000 (17:34 -0500)]
Style: Use newlines to make the code more readable

14 years agoStyle: Always use tab for indentation
Denis Kenzior [Tue, 16 Mar 2010 22:33:50 +0000 (17:33 -0500)]
Style: Always use tab for indentation

14 years agoFix: Use g_try_malloc in gatutil
Denis Kenzior [Tue, 16 Mar 2010 22:22:56 +0000 (17:22 -0500)]
Fix: Use g_try_malloc in gatutil

14 years agoFix: Use g_try_malloc instead of g_malloc in util
Denis Kenzior [Tue, 16 Mar 2010 22:21:06 +0000 (17:21 -0500)]
Fix: Use g_try_malloc instead of g_malloc in util

In these cases we were checking for NULL return, but the function used
should have been g_try_malloc instead.

14 years agoRefactor: create_dirs logic
Denis Kenzior [Tue, 16 Mar 2010 22:19:01 +0000 (17:19 -0500)]
Refactor: create_dirs logic

- Remove reference to g_malloc and replace with g_try_malloc
- Be extra pedantic on the inputs
- Refactor the logic to make it slightly easier to follow

14 years agoFix: Fixup error paths in sim_op_check_cached
Denis Kenzior [Tue, 16 Mar 2010 20:44:29 +0000 (15:44 -0500)]
Fix: Fixup error paths in sim_op_check_cached

14 years agoFix: avoid assigning to return structure on error
Denis Kenzior [Tue, 16 Mar 2010 20:26:53 +0000 (15:26 -0500)]
Fix: avoid assigning to return structure on error

14 years agoStyle: Spaces before / after arithmetic operations
Denis Kenzior [Tue, 16 Mar 2010 20:16:59 +0000 (15:16 -0500)]
Style: Spaces before / after arithmetic operations

14 years agoStyle: Align the enum values to be easier to read
Denis Kenzior [Tue, 16 Mar 2010 20:14:17 +0000 (15:14 -0500)]
Style: Align the enum values to be easier to read

14 years agoHandle the conversion failure when parsing item
Yang Gu [Tue, 16 Mar 2010 10:01:38 +0000 (18:01 +0800)]
Handle the conversion failure when parsing item

14 years agoFix the structure of stk_subaddress
Yang Gu [Tue, 16 Mar 2010 10:01:37 +0000 (18:01 +0800)]
Fix the structure of stk_subaddress

14 years agoAdd support of Huawei EM770 modem
Yang Gu [Tue, 16 Mar 2010 07:42:29 +0000 (15:42 +0800)]
Add support of Huawei EM770 modem

Comparing with general Huawei modem, EM770 is a full feature modem that
supports voicecall, phonebook, call forwarding, call barring, etc.

14 years agoDoc: Add small clarification to SMS docs
Denis Kenzior [Tue, 16 Mar 2010 02:20:51 +0000 (21:20 -0500)]
Doc: Add small clarification to SMS docs

14 years agodoc: Add SmsManager API documentation.
João Paulo Rechi Vita [Mon, 15 Mar 2010 20:17:45 +0000 (17:17 -0300)]
doc: Add SmsManager API documentation.

14 years agoAdd stk tone type enum
Denis Kenzior [Tue, 16 Mar 2010 02:11:11 +0000 (21:11 -0500)]
Add stk tone type enum

14 years agoAdd basic unit test for send sms parser
Denis Kenzior [Tue, 16 Mar 2010 02:01:33 +0000 (21:01 -0500)]
Add basic unit test for send sms parser

14 years agoAdd parser for STK send sms proactive commands
Denis Kenzior [Tue, 16 Mar 2010 02:01:04 +0000 (21:01 -0500)]
Add parser for STK send sms proactive commands

14 years agoRefactor: stk send_sms datastructure
Denis Kenzior [Tue, 16 Mar 2010 01:59:02 +0000 (20:59 -0500)]
Refactor: stk send_sms datastructure

14 years agoRefactor: stk result dataobject
Denis Kenzior [Fri, 12 Mar 2010 14:19:25 +0000 (08:19 -0600)]
Refactor: stk result dataobject