caryclark [Wed, 20 Aug 2014 15:11:24 +0000 (08:11 -0700)]
copy points in array that may stretch
Description:
Potential SkOpSegment::addT() use-after-free
The 'pt' arg can be a reference to a point stored in the local fTs
TDArray => appending may cause a realloc and leave the reference
pointing to deallocated mem.
Copy the points from the stretchy array before adding them.
R=fmalita@google.com, fmalita@chromium.org, fmalita
BUG=405417
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
489853002
mtklein [Wed, 20 Aug 2014 15:09:46 +0000 (08:09 -0700)]
Implement SkPicture::hasText() for SkRecord backend.
Plus, some small tweaks to the existing code surrounding it. Just proposals,
will undo whatever you don't like.
BUG=skia:
R=mtklein@google.com, tomhudson@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
494683003
bungeman [Wed, 20 Aug 2014 15:01:35 +0000 (08:01 -0700)]
Remove SK_FONT_HOST_DOES_NOT_USE_FONTMGR and guarded code.
This define is no longer needed or set, so remove it from the code.
R=tomhudson@google.com, djsollen@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
488083004
epoger [Wed, 20 Aug 2014 15:00:28 +0000 (08:00 -0700)]
rebaseline_server: allow users to generate SKP diff patches on a shared instance
This will allow developers to maintain SKP baselines without ever running their
own rebaseline_server instance!
For now, the developer must manually apply the resulting patchset to his local
Skia checkout to actually modify expectations; in the near future, we hope to
make the UI upload the patchset to Rietveld on the user's behalf.
BUG=skia:1918
NOTRY=true
R=stephana@google.com, rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
487853004
epoger [Wed, 20 Aug 2014 14:52:28 +0000 (07:52 -0700)]
start maintaining some experimental SKP expectations
BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
491003002
mtklein [Wed, 20 Aug 2014 14:38:46 +0000 (07:38 -0700)]
Define NDEBUG instead of SK_DEBUG/SK_RELEASE.
This makes our builds more like Chrome's, and will make our builds fail
if we accidentally use if SK_DEBUG instead of ifdef SK_DEBUG.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
481513004
reed [Wed, 20 Aug 2014 14:24:01 +0000 (07:24 -0700)]
fix Image::isOpaque test to not leak
BUG=skia:
R=halcanary@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
495523002
djsollen [Wed, 20 Aug 2014 14:03:23 +0000 (07:03 -0700)]
Revert to old autohinting behavior on Android.
This CL reverts to the NO_AUTOHINT behavior when autohinting is not
explicitly requested. This should be removed when Skia supports a
better API for selecting the correct variation.
This CL has landed in the Android repo and is being upstreamed to
avoid fragmenting the codebase.
R=bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
490913003
caryclark [Wed, 20 Aug 2014 13:34:15 +0000 (06:34 -0700)]
ignore release as well
This GM is flaky as Brian expected on both Release and Debug,
so suppress the Release expectation as well.
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
TBR=bsalomon
BUG=skia:2826
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
489083002
borenet [Wed, 20 Aug 2014 13:31:12 +0000 (06:31 -0700)]
Rename Recipes bot expectations
Accidentally used the wrong name :-/
R=epoger@google.com, rmistry@google.com
TBR=epoger, rmistry
BUG=skia:761
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
495493002
tomhudson [Wed, 20 Aug 2014 12:29:41 +0000 (05:29 -0700)]
Move the code over using the same template type approach previously used for willPlayBackBitmaps in skbug.com/2702.
Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test.
BUG=skia:2700
R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com
Committed: https://skia.googlesource.com/skia/+/
60c2a79cfa8ceebcbafc243407564dc71f5e3b4f
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
364823009
borenet [Wed, 20 Aug 2014 12:25:31 +0000 (05:25 -0700)]
Copy skimage expectations for Recipes bots
BUG=skia:761
NOTRY=true
R=epoger@google.com, rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
480333003
caryclark [Wed, 20 Aug 2014 12:24:29 +0000 (05:24 -0700)]
fix #if to #ifdef for SK_DEBUG
fix the chrome build
R=mtklein@google.com
TBR=mtklein
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
495453003
kkinnunen [Wed, 20 Aug 2014 11:13:27 +0000 (04:13 -0700)]
Simplify GrGLPathRendering interface
Simplify GrGLPathRendering interface by removing polymorphism and functions that
simply wrap GL functions unnecessarily.
Replace the polymorphism by if -condition.
Call the unconditional GL functions directly. GrGLPath, GrGLPathRange and
GrGLPathRendering are part of the same logical subsystem. This means that the
subsystem implementation details are taken into account within these
classes. Example: if support for using conics would be added, the feature flag
would go to GrGLPathRendering::Caps, the emulation would go to GrGLPath instead of
GrGLPathRendering::pathCommands. Wrapping glPathCommandsNV is not useful.
Try to expose the interface fully in same logical level; rename fragment input
function to reflect this.
R=bsalomon@google.com, cdalton@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
450283002
kkinnunen [Wed, 20 Aug 2014 08:36:23 +0000 (01:36 -0700)]
Separate GL path rendering state from GrGpuGL to GrGLPathRendering
Separate GL path rendering state from GrGpuGL to GrGLPathRendering. This
makes GrGpuGL code simpler.
The intention is that while GrGpuGL represents the global environment for GL,
the GrGLPathRendering represents the global environment for path rendering
extension.
Add GrPathRendering, a base class for path rendering, and inherit
GrGLPathRendering from that. Move the path rendering virtual functions from
GrGpu to GrPathRendering.
R=bsalomon@google.com, cdalton@nvidia.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
452823002
changjun.yang [Wed, 20 Aug 2014 01:24:30 +0000 (18:24 -0700)]
Make GrGLConfigConversionEffect work for Imagination and some other GPUs.
BUG=372341
Committed: https://skia.googlesource.com/skia/+/
93cf46f7d687128d2ad05762bd65fea6c4539553
R=bsalomon@google.com, tomhudson@chromium.org
Author: changjun.yang@intel.com
Review URL: https://codereview.chromium.org/
277323002
mtklein [Wed, 20 Aug 2014 00:47:14 +0000 (17:47 -0700)]
Cheat to go fast, but be careful in debug mode.
Turns out recording actual text metrics is currently really slow.
If we want to compete with the (cheating) status quo, gotta cheat too.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
494483002
mtklein [Tue, 19 Aug 2014 22:55:55 +0000 (15:55 -0700)]
Print max RSS in GM and nanobench too.
Everyone used MB, so update the API to just return that.
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
483323002
piotaixr [Tue, 19 Aug 2014 21:29:02 +0000 (14:29 -0700)]
Add the method isOpaque() to SkImage
BUG=skia:2766
R=junov@chromium.org, halcanary@google.com, scroggo@google.com, reed@google.com, bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
406673003
bsalomon [Tue, 19 Aug 2014 21:20:58 +0000 (14:20 -0700)]
Revert of Add GrResourceCache2. (patchset #4 of https://codereview.chromium.org/
481443002/)
Reason for revert:
Likely caused a leak detected in Chromium after last Skia roll.
Original issue's description:
> Add GrResourceCache2.
>
> Currently it just replaces GrGpu as the owner of the linked list of resources.
>
> Committed: https://skia.googlesource.com/skia/+/
94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f
R=mtklein@google.com, robertphillips@google.com
TBR=mtklein@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
477323006
mtklein [Tue, 19 Aug 2014 20:32:59 +0000 (13:32 -0700)]
Trim down OSX GYP rules. Same effect, shorter.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
486233003
bungeman [Tue, 19 Aug 2014 20:18:58 +0000 (13:18 -0700)]
Treat embedded bitmaps as a hinting method.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
483313002
mtklein [Tue, 19 Aug 2014 19:41:53 +0000 (12:41 -0700)]
Add --options to nanobench, similar to --key but for non-identifying options.
Friends with https://codereview.chromium.org/
487233003/
Example of out/Release/nanobench --options build_number 12374 --match patch_grid_texs_small
{
"gitHash":"unknown-revision",
"options":{
"build_number":"12374",
"system":"UNIX"
},
"results":{
"patch_grid_texs_small_640_480":{
"565":{
"max_ms":0.268116,
"mean_ms":0.2318529,
"median_ms":0.235337,
"min_ms":0.219158,
"options":{
"source_type":"bench"
},
"stddev_ms":0.
01491263917658814
},
"8888":{
"max_ms":0.231881,
"mean_ms":0.2214668,
"median_ms":0.219356,
"min_ms":0.218887,
"options":{
"source_type":"bench"
},
"stddev_ms":0.
004595541070791701
},
"gpu":{
"max_ms":0.
1398304782608696,
"mean_ms":0.
128833402173913,
"median_ms":0.
1316798695652174,
"min_ms":0.
1111915434782609,
"options":{
"GL_RENDERER":"Quadro 600/PCIe/SSE2",
"GL_SHADING_LANGUAGE_VERSION":"4.40 NVIDIA via Cg compiler",
"GL_VENDOR":"NVIDIA Corporation",
"GL_VERSION":"4.4.0 NVIDIA 331.79",
"source_type":"bench"
},
"stddev_ms":0.
008923738937837156
}
}
}
}
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
490683002
epoger [Tue, 19 Aug 2014 19:17:06 +0000 (12:17 -0700)]
rebaseline_server: in Pending Approval tab, change expected/actual labels to old/new
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
484763004
bsalomon [Tue, 19 Aug 2014 15:21:25 +0000 (08:21 -0700)]
Add GrResourceCache2.
Currently it just replaces GrGpu as the owner of the linked list of resources.
R=robertphillips@google.com, mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
481443002
caryclark [Tue, 19 Aug 2014 14:39:40 +0000 (07:39 -0700)]
remove unused SkIntToFloatCast_NoOverflowCheck
R=reed@google.com, reed
BUG=skia:2849
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
483273003
mtklein [Tue, 19 Aug 2014 14:21:00 +0000 (07:21 -0700)]
Roll jsoncpp, drop dependency on Chromium overrides.
This rolls jsoncpp to head, crucially past "Added missing includes for
std::istream." which has given us some grief in the past. And it's required to
build jsoncpp against libc++.
Vanilla jsoncpp works just fine for us, so no need for Chromium's overrides.
Like all DEPS, only tools depend on jsoncpp.
BUG=skia:
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
481823003
mtklein [Tue, 19 Aug 2014 14:09:40 +0000 (07:09 -0700)]
Record concat as setMatrix.
Mainly this cuts out a type to have to think about in SkRecord world.
It also means all the CTMs are recorded directly in the SkRecord, so
we can track the current CTM by pointer rather than by copying.
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
484673003
fmalita [Tue, 19 Aug 2014 13:50:35 +0000 (06:50 -0700)]
Quickfix for incorrect PICTURE_MATRIX_PAINT & PATCH optimization.
DRAW_PICTURE_MATRIX_PAINT & DRAW_PATCH are drawing ops.
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
480463004
halcanary [Tue, 19 Aug 2014 13:27:53 +0000 (06:27 -0700)]
Move SkReadBuffer.h and SkReader32.h out of include.
Committed: https://skia.googlesource.com/skia/+/
2a51d7c74cec217195f861677de8998b382b39e4
R=mtklein@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
481053002
caryclark [Tue, 19 Aug 2014 12:28:23 +0000 (05:28 -0700)]
add patch grid update for 64 bit arm
TBR=
NOTREECHECKS=true
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
463353003
borenet [Tue, 19 Aug 2014 04:22:20 +0000 (21:22 -0700)]
Update SKP version to 78
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
487073003
Mike Klein [Mon, 18 Aug 2014 22:35:16 +0000 (18:35 -0400)]
Revert "Move the code over using the same template type approach previously used for willPlayBackBitmaps in skbug.com/2702."
This reverts commit
60c2a79cfa8ceebcbafc243407564dc71f5e3b4f.
BUG=skia:
Review URL: https://codereview.chromium.org/
481173003
epoger [Mon, 18 Aug 2014 22:14:46 +0000 (15:14 -0700)]
rebaseline_server: constrain setADir/setBDir to consistently refer to single directories, not lists
Before this CL, we supported multiple setADirs/setBDirs for some operations but
not others... now we consistently support a single pair of directories.
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
480293002
tomhudson [Mon, 18 Aug 2014 22:07:13 +0000 (15:07 -0700)]
Move the code over using the same template type approach previously used for willPlayBackBitmaps in skbug.com/2702.
Also unifies that flag and this one into a struct so they and others can be computed together. The struct is stored const to enforce lifetime expectations. Adds a few new cases to the unit test.
BUG=skia:2700
R=mtklein@google.com, reed@google.com, robertphillips@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
364823009
halcanary [Mon, 18 Aug 2014 20:48:13 +0000 (13:48 -0700)]
Revert "Move SkReadBuffer.h and SkReader32.h out of include."
This reverts commit
2a51d7c74cec217195f861677de8998b382b39e4.
Breaking Blink
NOTRY=true
R=bungeman@google.com
TBR=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
472303006
mtklein [Mon, 18 Aug 2014 20:39:11 +0000 (13:39 -0700)]
Counterproposal for skirting the BBH when the query fully contains the picture.
BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
485703002
stephana [Mon, 18 Aug 2014 20:37:59 +0000 (13:37 -0700)]
This adds renderMode and builder as columns to the front end when looking at SKPs.
BUG=skia:2833
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/
480153002
halcanary [Mon, 18 Aug 2014 20:04:59 +0000 (13:04 -0700)]
Move SkReadBuffer.h and SkReader32.h out of include.
R=mtklein@google.com, reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
481053002
ajuma [Mon, 18 Aug 2014 19:59:55 +0000 (12:59 -0700)]
Expose API for whether an SkPicture contains text
BUG=chromium:399728
R=reed@google.com, nduca@chromium.org
Author: ajuma@chromium.org
Review URL: https://codereview.chromium.org/
478673002
bsalomon [Mon, 18 Aug 2014 18:49:37 +0000 (11:49 -0700)]
Fix srcAlpaWillBeOne() for coverage drawing
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
480113002
mtklein [Mon, 18 Aug 2014 18:10:37 +0000 (11:10 -0700)]
Start actually bounding some draw ops.
This covers most of the common draws.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
469213007
bungeman [Mon, 18 Aug 2014 17:29:57 +0000 (10:29 -0700)]
Fix copyright on SkTLS.h.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
481783002
robertphillips [Mon, 18 Aug 2014 16:39:34 +0000 (09:39 -0700)]
Rename GPUAccelData to GrAccelData
This is calved off of (Add new API to allow layer hoisting/atlasing across picture piles
- https://codereview.chromium.org/
474623002/)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
482773002
borenet [Mon, 18 Aug 2014 15:50:42 +0000 (08:50 -0700)]
Copy N10 GM expectations for recipe bot
BUG=skia:761
R=epoger@google.com, rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
481963002
robertphillips [Mon, 18 Aug 2014 15:50:03 +0000 (08:50 -0700)]
Refactor GrLayerCache for new API
The only substantive change in this CL is skipping atlasing
for any layers that are involved in nesting. Prior versions
have allowed nesting layers to be atlased.
--------------------------------------------------------
All times are on Windows with a repeat count of 200.
Format is: <time in ms> (<# of glBindframebuffer calls>)
How to interpret this:
For the boogie page:
both columns should be the same (since boogie has no
nested layers)
without the new API the tiled case doesn't show any real
benefit from hoisting
For the carsvg page:
The nesting change does increase the number of FBO
switches but doesn't kill performance
Because of the location & size of the layers the
tile case does show some improvement (even
without the new API)
boogie
-------
w/o nested change w/ nested change
simple 5.62 (811) N/A
tiled 7.72 (811) N/A
simple w/ hoisting 5.23 (409) 5.77 (409)
(but no caching)
tiled w/ hoisting 7.57 (809) 7.49 (809)
(but no caching)
carsvg
------
w/o nested change w/ nested change
simple 60.37 (141990) N/A
tiled 115.13 (256929) N/A
simple w/ hoisting 41.57 (64570) 42.82 (72279)
(but no caching)
tiled w/ hoisting 84.24 (154352) 84.71 (165630)
(but no caching)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
476833004
mtklein [Mon, 18 Aug 2014 15:45:33 +0000 (08:45 -0700)]
Small tweaks and a bug fix.
Bug fixed: I was calling paint->canComputeFastBounds() where I should have been calling fSaveStack[i].paint->canComputeFastBounds().
This suggested I factor out the paint adjusting code, now called AdjustForPaint(). This removes the getImageFilter() check for SaveLayers, which seems like an optimization we can add back later if it proves important.
We're going to want to intersect the bounds with the current clip bounds eventually, so might as well land that here too.
Plus, more const.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
481543002
mtklein [Mon, 18 Aug 2014 15:44:54 +0000 (08:44 -0700)]
Android.mk: bench_pictures -> nanobench
We're only keeping bench_pictures around for the bots now. For human-initiated work, nanobench is the way to go.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
484663002
halcanary [Mon, 18 Aug 2014 15:27:09 +0000 (08:27 -0700)]
SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
R=reed@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
465823003
mtklein [Mon, 18 Aug 2014 15:23:18 +0000 (08:23 -0700)]
Stop sorting the results of SkBBH::search().
We only seem to need to sort with SkQuadTree, which is not actively used by
client code. So it's really just wasted work. SkQuadTree is interesting, but
I'd rather disable it than slow down the production code path.
BUG=skia:2834
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
471063004
borenet [Mon, 18 Aug 2014 15:13:12 +0000 (08:13 -0700)]
Fix Android platform self-tests
Remove things related to no-longer-existing unittests, run makefile_writer_tests --rebaseline
BUG=skia:2843
R=djsollen@google.com, scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
481943002
reed [Mon, 18 Aug 2014 15:13:02 +0000 (08:13 -0700)]
eliminate code related to SkBitmap::Config
BUG=skia:
R=reed@google.com, mike@reedtribe.org
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
483593002
jshin [Mon, 18 Aug 2014 15:07:51 +0000 (08:07 -0700)]
Add alias mapping for Noto Sans CJK for ja/hans
Chrome/Chromium OS are getting a brand new CJK fonts (Noto Sans CJK).
We want them to be used in place of common Japanese and Simplified
Chinese sans-serif fonts.
BUG=chromium:399080
TEST=With CrOS CL
(https://chromium-review.googlesource.com/#/c/212624/), web pages
using 'Simhei' and 'MSP Gothic' are rendered with Noto Sans CJK.
R=reed@chromium.org, bungeman@google.com
Author: jshin@chromium.org
Review URL: https://codereview.chromium.org/
476203003
bungeman [Mon, 18 Aug 2014 15:07:44 +0000 (08:07 -0700)]
Correct order for alignment in name iterator record.
We must be quite careful about the order of fields in a 'pragma pack(1)'.
On Android the order 'uint16_t, void*' will misalign the pointer,
potentially leading to a crash.
In the future we should move anything which is not strictly part of the
table definition outside of the packed region.
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
474313002
reed [Mon, 18 Aug 2014 15:02:43 +0000 (08:02 -0700)]
simplify SkCanvas::init()
BUG=skia:
R=robertphillips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
472123002
krajcevski [Mon, 18 Aug 2014 15:02:33 +0000 (08:02 -0700)]
Fix typo
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
478533002
bungeman [Mon, 18 Aug 2014 14:57:35 +0000 (07:57 -0700)]
Remove fOrigFontID from SkScalerContextRec.
With the recent Android changes and removal of chaining, this is no longer used.
R=djsollen@google.com, reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
476713003
bungeman [Mon, 18 Aug 2014 14:57:26 +0000 (07:57 -0700)]
Remove unused SkGlyphCache::VisitAllCaches.
R=reed@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
472153002
krajcevski [Mon, 18 Aug 2014 14:52:25 +0000 (07:52 -0700)]
Add scraper to find paths that fallback to software
R=robertphillips@google.com, krajcevski@gmail.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
475433004
krajcevski [Mon, 18 Aug 2014 14:52:17 +0000 (07:52 -0700)]
Add flag to bench/render pictures
R=robertphillips@google.com, bsalomon@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
464423003
borenet [Mon, 18 Aug 2014 13:50:32 +0000 (06:50 -0700)]
Rebaseline astcbitmap and etc1bitmap on Recipes bot
BUG=skia:761
NOTREECHECKS=true
R=robertphillips@google.com, bsalomon@google.com, krajcevski@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
481883003
dandov [Fri, 15 Aug 2014 20:30:47 +0000 (13:30 -0700)]
Added bench for grid of patches.
It is on top of my previous cl to fix the mem leaks of the regular patch bench.
NOTREECHECKS=true
BUG=skia:
R=egdaniel@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
470543004
mtklein [Fri, 15 Aug 2014 18:49:49 +0000 (11:49 -0700)]
SkRecordDraw: incorporate clip into BBH
NOTREECHECKS=true
BUG=skia:
R=robertphillips@google.com, senorblanco@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
474983002
senorblanco [Fri, 15 Aug 2014 17:48:43 +0000 (10:48 -0700)]
Check all scratch texture allocations for image filters.
BUG=403677
R=bsalomon@google.com
NOTREECHECKS=true
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
473283002
reed [Fri, 15 Aug 2014 17:13:35 +0000 (10:13 -0700)]
remove SkBitmap::Config support from android
NOTREECHECKS=True
NOTRY=True
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
470933003
stephana [Fri, 15 Aug 2014 13:53:23 +0000 (06:53 -0700)]
This passes the URL of the diff image to the front-end, thus removing the need to keep frontend code for URL generation in sync with the backend.
BUG=skia:
NOTREECHECKS=true
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/
471033003
dandov [Fri, 15 Aug 2014 13:06:47 +0000 (06:06 -0700)]
Fixed memory leak for nanobench and crashing in SampleApp
NOTREECHECKS=True
BUG=skia:2830
R=mtklein@google.com, egdaniel@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
469333002
mtklein [Fri, 15 Aug 2014 02:17:18 +0000 (19:17 -0700)]
int SkPicture::approximateOpCount()
NOTREECHECKS=true
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
470333002
halcanary [Thu, 14 Aug 2014 20:08:45 +0000 (13:08 -0700)]
valgrind suppression for zlib Flate Test
NOTREECHECKS=true
NOTRY=true
R=bsalomon@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
477733002
bsalomon [Thu, 14 Aug 2014 20:03:58 +0000 (13:03 -0700)]
Remove aarects benchmark. Redundant with rotated_rects* bench and *much* slower.
NOTREECHECKS=true
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
469373003
bsalomon [Thu, 14 Aug 2014 19:24:46 +0000 (12:24 -0700)]
remove internal repeat count from gradient benches
NOTREECHECKS=true
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
476923002
Brian Salomon [Thu, 14 Aug 2014 17:51:16 +0000 (13:51 -0400)]
Rebaseline and remove tests from ignored-tests.txt
BUG=skia:
Review URL: https://codereview.chromium.org/
475013002
mtklein [Thu, 14 Aug 2014 17:36:55 +0000 (10:36 -0700)]
Guard ANGLE and MESA instead of defining them as native when unsupported.
Since we've added "angle" to the default list of configs we've been running
kNative_GLContextType tests twice in DM, once for the real native, once for
angle. This pointlessly doubles the GPU critical path in DM. Whoops.
NOTREECHECKS=true
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
471063002
epoger [Thu, 14 Aug 2014 16:55:36 +0000 (09:55 -0700)]
rebaseline_server: show Pending Approval tab if viewing SKP expectations vs actuals
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
473973002
bsalomon [Thu, 14 Aug 2014 15:13:27 +0000 (08:13 -0700)]
Make null gpu context threadsafe(r) and make sure buffer objects are destroyed.
NOTREECHECKS=true
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
470993002
epoger [Thu, 14 Aug 2014 14:32:49 +0000 (07:32 -0700)]
add --descriptions flag to render_pictures tool
Needed because right now, when you look at the full set of SKP results in
rebaseline_server, you can't tell which renderMode (or builder) generated each
one.
BUG=skia:2833
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
466153006
krajcevski [Thu, 14 Aug 2014 14:24:52 +0000 (07:24 -0700)]
Rebaseline R11 and ASTC bitmap GMs
TBR=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
471723002
epoger [Thu, 14 Aug 2014 14:12:46 +0000 (07:12 -0700)]
rebaseline_server: include setA/setB descriptions in output JSON
This is needed for rebaselining using the shared rebaseline_server instance:
by telling the client which git revision was used to fetch expectations, we
allow the client to pass that back along with new baselines (so the server
knows which revision to patch).
This is also handy in that it allows the server to tell the client more about the
different result sets (which files they were generated from).
BUG=skia:1918
NOTRY=true
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
474813002
djsollen [Thu, 14 Aug 2014 13:29:02 +0000 (06:29 -0700)]
Remove SkPaintOptionsAndroid
Committed: https://skia.googlesource.com/skia/+/
f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b
R=reed@google.com, mtklein@google.com, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
447873003
epoger [Thu, 14 Aug 2014 02:29:49 +0000 (19:29 -0700)]
rebaseline_server UI: add link to raw JSON
patchset 3 from https://codereview.chromium.org/
467843002
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
475623002
epoger [Thu, 14 Aug 2014 02:23:33 +0000 (19:23 -0700)]
rebaseline_server: move more code into common path for GET_live_results and GET_prefetch_results
patchset 1 from issue
467843002
BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
465143004
stephana [Thu, 14 Aug 2014 02:12:57 +0000 (19:12 -0700)]
This is a bit of a hack, but will work. I have a cleaner fix ready (but still need to fix some broken tests).
BUG=skia:
NOTRY=true
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/
472703002
Brian Salomon [Wed, 13 Aug 2014 22:31:03 +0000 (18:31 -0400)]
Fix typo in ignored-tests.txt
BUG=skia:
Review URL: https://codereview.chromium.org/
475583002
bsalomon [Wed, 13 Aug 2014 22:18:46 +0000 (15:18 -0700)]
Revert of Remove SkPaintOptionsAndroid (patchset #5 of https://codereview.chromium.org/
447873003/)
Reason for revert:
Breaks the Chromium build: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2469/steps/BuildContentShell_1/logs/stdio
Original issue's description:
> Remove SkPaintOptionsAndroid
>
> Committed: https://skia.googlesource.com/skia/+/
f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
473543004
mtklein [Wed, 13 Aug 2014 20:33:49 +0000 (13:33 -0700)]
Start tracking the CTM while filling the BBH in SkRecordDraw.
Depends on https://codereview.chromium.org/
475473002/
BUG=skia:
R=robertphillips@google.com, reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
468193003
djsollen [Wed, 13 Aug 2014 20:09:49 +0000 (13:09 -0700)]
Remove SkPaintOptionsAndroid
R=reed@google.com, mtklein@google.com, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
447873003
mtklein [Wed, 13 Aug 2014 19:58:45 +0000 (12:58 -0700)]
Start filling BBH in SkRecordDraw.
This starts with a skeleton of how to calculate bounds for ops which don't have
their own bounds. For any given Save/Restore block, we'll find the union of the
bounds of all the draws inside it (including other Save/Restore blocks), then say
those are the bounds of all non-draws in the block, including the Save and Restore.
To implement this, we keep a stack of active Save blocks. Any time we hit a
non-drawing op ("control"), we'll add it to that Save block (implemented with a
separate stack of indices and a count of control ops in the entry on the Save
stack). Save and SaveLayer push onto the stack, and Restore pops the stack, at
which point we can fill in the bounds for all the control ops in the block.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
475473002
epoger [Wed, 13 Aug 2014 19:51:57 +0000 (12:51 -0700)]
roll common deps
NOTRY=true
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
469043003
krajcevski [Wed, 13 Aug 2014 19:06:26 +0000 (12:06 -0700)]
Add runtime flag to turn compressed alpha masks on
R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
468293002
mtklein [Wed, 13 Aug 2014 18:59:53 +0000 (11:59 -0700)]
Baseline Android-Reference-Unknown-Arm64
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
474563002
tomhudson [Wed, 13 Aug 2014 18:06:43 +0000 (11:06 -0700)]
Update path to Android font config file
In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/
446473003/). This patch tries
the new path before falling back to the old path.
The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/
462073002/ or the equivalent has turned on the
new SkFontManager.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com
Committed: https://skia.googlesource.com/skia/+/
94fa4b99e2a53e997a90c7808cc5263f1bf40c9f
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
458543002
krajcevski [Wed, 13 Aug 2014 17:46:31 +0000 (10:46 -0700)]
Add entry point for passing options to the GrContextFactory
R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
465073002
robertphillips [Wed, 13 Aug 2014 17:46:23 +0000 (10:46 -0700)]
Add support for new drawPicture entry point to debugger
R=fmalita@google.com, fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
464063003
tomhudson [Wed, 13 Aug 2014 17:41:25 +0000 (10:41 -0700)]
Delete the old font management implementation based on SkFontConfigInterface, now that SkFontMgr_Android is live.
BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/
445143002
mtklein [Wed, 13 Aug 2014 17:41:16 +0000 (10:41 -0700)]
Don't leak the shader in PatchBench.
BUG=skia:
R=dandov@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
465083003
Brian Salomon [Wed, 13 Aug 2014 17:37:45 +0000 (13:37 -0400)]
git cl land# Enter a description of the change.
Even more tests to ignored-tests for gpu rect changes
BUG=skia:
Review URL: https://codereview.chromium.org/
468223003
krajcevski [Wed, 13 Aug 2014 17:36:18 +0000 (10:36 -0700)]
Add override to force bitmap rendering
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
462203002
stephana [Wed, 13 Aug 2014 17:36:06 +0000 (10:36 -0700)]
This eliminates the need to copy the generated images from a temporary directory to the directory that is served by the rebaseline_server.
BUG=skia:2815, skia:2818
R=epoger@google.com
Author: stephana@google.com
Review URL: https://codereview.chromium.org/
457203003
joshualitt [Wed, 13 Aug 2014 17:31:04 +0000 (10:31 -0700)]
Updating expectations for matrix convolution
R=bsalomon@chromium.org
BUG=skia:
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
464913003
halcanary [Wed, 13 Aug 2014 17:30:57 +0000 (10:30 -0700)]
DM: Replace --pathOpsVerbose with --veryVerbose
R=caryclark@google.com, mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
468963002