platform/upstream/libSkiaSharp.git
10 years agobench rebase test 1f75ab9
commit-bot@chromium.org [Fri, 11 Apr 2014 19:07:40 +0000 (19:07 +0000)]
bench rebase test 1f75ab9
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235483004

git-svn-id: http://skia.googlecode.com/svn/trunk@14164 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse the correct rowBytes so Debug build doesn't assert
commit-bot@chromium.org [Fri, 11 Apr 2014 19:06:46 +0000 (19:06 +0000)]
use the correct rowBytes so Debug build doesn't assert

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/235453002

git-svn-id: http://skia.googlecode.com/svn/trunk@14163 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove dead code from SkPicturePlayback
commit-bot@chromium.org [Fri, 11 Apr 2014 19:05:22 +0000 (19:05 +0000)]
remove dead code from SkPicturePlayback

This is from an earlier iteration of the pull-forward task before we switched to doing the majority of the work in SkGpuDevice.

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/235473002

git-svn-id: http://skia.googlecode.com/svn/trunk@14162 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoR=robertphillips@google.com
commit-bot@chromium.org [Fri, 11 Apr 2014 19:00:28 +0000 (19:00 +0000)]
R=robertphillips@google.com
TBR=robertphillips@google.com
BUG=skia:

Author: bensong@google.com

Review URL: https://codereview.chromium.org/235603002

git-svn-id: http://skia.googlecode.com/svn/trunk@14161 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement intra-frame cacheing in image filters.
commit-bot@chromium.org [Fri, 11 Apr 2014 18:57:00 +0000 (18:57 +0000)]
Implement intra-frame cacheing in image filters.

When image filters are processed within Skia, they simply do
a blind recursion. This has the side-effect of turning the
DAG into a tree. I.e., nodes visited more than once during
the traversal will be processed more than once.

This change implements a very simple cacheing scheme: a
cache is created before traversing the DAG, and handed
into the processing traversal. Before recursing into a child
in SkImageFilter::filterImage(), the cache is checked for a
hit, and early-out is performed. Otherwise, the node is
processed, and its result bitmap and location (offset) are
cached, but only if it contains two or more children and
thus will be visited again during the traversal.

Currently, the child count is approximated with the
refcount. This is good enough in most cases (and exactly
correct for the Chrome use case). We could add an exact
child count to the image filter, but this will require
violating the immutability of image filters slightly in
order to bump the child count as nodes are connected. I
leave it up to the reviewer to decide which is better.

R=reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/230653005

git-svn-id: http://skia.googlecode.com/svn/trunk@14160 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove picture-backed surfaces
commit-bot@chromium.org [Fri, 11 Apr 2014 18:34:35 +0000 (18:34 +0000)]
remove picture-backed surfaces

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/233943002

git-svn-id: http://skia.googlecode.com/svn/trunk@14159 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark our territory with (C).
commit-bot@chromium.org [Fri, 11 Apr 2014 18:33:31 +0000 (18:33 +0000)]
Mark our territory with (C).

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/235253002

git-svn-id: http://skia.googlecode.com/svn/trunk@14158 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate Android expectations to reflect the new default gamma for fonts.
djsollen@google.com [Fri, 11 Apr 2014 18:22:44 +0000 (18:22 +0000)]
Update Android expectations to reflect the new default gamma for fonts.

see https://code.google.com/p/skia/source/detail?r=14148 for the responsible CL.

R=epoger@google.com

Review URL: https://codereview.chromium.org/228323006

git-svn-id: http://skia.googlecode.com/svn/trunk@14157 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://coderev...
commit-bot@chromium.org [Fri, 11 Apr 2014 17:15:40 +0000 (17:15 +0000)]
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/)

Reason for revert:
Want to reland the original CL.

Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144

R=reed@google.com, bensong@google.com
TBR=bensong@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/235523003

git-svn-id: http://skia.googlecode.com/svn/trunk@14156 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse SkIntToScalar, fix windows build
commit-bot@chromium.org [Fri, 11 Apr 2014 16:13:54 +0000 (16:13 +0000)]
use SkIntToScalar, fix windows build

NOTRY=true
NOTREECHECKS=true
BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/234913004

git-svn-id: http://skia.googlecode.com/svn/trunk@14155 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate bench to be able to preprocess skps
commit-bot@chromium.org [Fri, 11 Apr 2014 15:54:14 +0000 (15:54 +0000)]
Update bench to be able to preprocess skps

This allows benchmarking of optimization improvements and plumbs in the purging API. The purging is necessary so we don't magically get faster because the saveLayers are always pre-generated.

R=jvanverth@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/233663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14154 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove guard for getTotalClip
commit-bot@chromium.org [Fri, 11 Apr 2014 15:54:06 +0000 (15:54 +0000)]
remove guard for getTotalClip

TBR=robertphilips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/235093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14153 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased)
commit-bot@chromium.org [Fri, 11 Apr 2014 15:53:47 +0000 (15:53 +0000)]
Rename GrAtlasedLayer to GrCachedLayer (since not all cached layers are atlased)

This is mainly a renaming CL but it does add a ref-counted ptr  to the backing GrTexture for non-atlased layers (the only kind working right now)

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/233703003

git-svn-id: http://skia.googlecode.com/svn/trunk@14152 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd bench_playback, for quick profiling of SKR playback.
commit-bot@chromium.org [Fri, 11 Apr 2014 15:53:39 +0000 (15:53 +0000)]
Add bench_playback, for quick profiling of SKR playback.

It is not completely fair to compare --skr and --noskr numbers.  SKR looks
unfairly good because some optimizations are baked into our SKPs at record
time.  But, at least, by using a kWriteOnly_Mode SkRecorder, we prevent
SkPicturePlayback from compounding that unfairness.  SkRecordDraw must handle
its own playback-time optimizations (quickrejects) on its own.

This code should look suspiciously similar to bench_record.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/233833002

git-svn-id: http://skia.googlecode.com/svn/trunk@14151 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd some .gitignores related to gm and tools
commit-bot@chromium.org [Fri, 11 Apr 2014 14:49:50 +0000 (14:49 +0000)]
add some .gitignores related to gm and tools

NOTREECHECKS=True
NOTRY=True
R=scroggo@google.com
TBR=scroggo

Author: epoger@google.com

Review URL: https://codereview.chromium.org/234603004

git-svn-id: http://skia.googlecode.com/svn/trunk@14150 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromi...
commit-bot@chromium.org [Fri, 11 Apr 2014 13:47:30 +0000 (13:47 +0000)]
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)

Reason for revert:
Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now.

Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/234833003

git-svn-id: http://skia.googlecode.com/svn/trunk@14149 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDisable SK_GAMMA_SRGB on android builds.
djsollen@google.com [Fri, 11 Apr 2014 13:09:21 +0000 (13:09 +0000)]
Disable SK_GAMMA_SRGB on android builds.

R=bungeman@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/229133003

git-svn-id: http://skia.googlecode.com/svn/trunk@14148 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSo apparently Chrome has an x86 iOS build...
commit-bot@chromium.org [Fri, 11 Apr 2014 12:52:44 +0000 (12:52 +0000)]
So apparently Chrome has an x86 iOS build...

and for some reason we don't bother to build or link our SSE2 opts
there.  So don't go looking for them when SK_BUILD_FOR_IOS is set.

BUG=skia:
NOTREECHECKS=true
NOTRY=true
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/225033003

git-svn-id: http://skia.googlecode.com/svn/trunk@14147 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a focused public API for src/record.
commit-bot@chromium.org [Thu, 10 Apr 2014 23:30:59 +0000 (23:30 +0000)]
Add a focused public API for src/record.

BUG=skia:2378
R=reed@google.com, robertphillips@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/233053005

git-svn-id: http://skia.googlecode.com/svn/trunk@14146 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://coderev...
commit-bot@chromium.org [Thu, 10 Apr 2014 22:49:20 +0000 (22:49 +0000)]
Revert of Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/234243002/)

Reason for revert:
fixes on the chrome side are landing (brettw), keep fingers crossed.

Original issue's description:
> Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)
>
> Reason for revert:
> breaking the Chrome deps roll.
> http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio
>
> Original issue's description:
> > Rename kPMColor_SkColorType to kN32_SkColorType.
> >
> > The new name better represents what this flag means.
> >
> > BUG=skia:2384
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14117
>
> TBR=reed@google.com,scroggo@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14144

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/233813004

git-svn-id: http://skia.googlecode.com/svn/trunk@14145 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromi...
commit-bot@chromium.org [Thu, 10 Apr 2014 22:36:34 +0000 (22:36 +0000)]
Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/)

Reason for revert:
breaking the Chrome deps roll.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/839/steps/compile/logs/stdio

Original issue's description:
> Rename kPMColor_SkColorType to kN32_SkColorType.
>
> The new name better represents what this flag means.
>
> BUG=skia:2384
>
> Committed: http://code.google.com/p/skia/source/detail?r=14117

R=reed@google.com, scroggo@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2384

Author: bensong@google.com

Review URL: https://codereview.chromium.org/234243002

git-svn-id: http://skia.googlecode.com/svn/trunk@14144 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoClean up the default gamma settings.
bungeman@google.com [Thu, 10 Apr 2014 22:26:29 +0000 (22:26 +0000)]
Clean up the default gamma settings.

This makes it a compile error to specify both SK_GAMMA_EXPONENT
and SK_GAMMA_SRGB. It also ensures that SK_GAMMA_EXPONENT will
be set consistently.

R=djsollen@google.com, reed@google.com

Review URL: https://codereview.chromium.org/233003003

git-svn-id: http://skia.googlecode.com/svn/trunk@14143 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove two more effects that are now immutable
commit-bot@chromium.org [Thu, 10 Apr 2014 21:57:32 +0000 (21:57 +0000)]
remove two more effects that are now immutable

BUG=skia:
R=scroggo@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/233753002

git-svn-id: http://skia.googlecode.com/svn/trunk@14142 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agowhen getClipBounds returns false, the out-param is uninitialized
reed@google.com [Thu, 10 Apr 2014 21:15:30 +0000 (21:15 +0000)]
when getClipBounds returns false, the out-param is uninitialized

BUG=skia:

Review URL: https://codereview.chromium.org/233933002

git-svn-id: http://skia.googlecode.com/svn/trunk@14141 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCast int to float.
commit-bot@chromium.org [Thu, 10 Apr 2014 21:09:33 +0000 (21:09 +0000)]
Cast int to float.

Get rid of warning->error.

TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/233883002

git-svn-id: http://skia.googlecode.com/svn/trunk@14140 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCreate SkLayerRasterizer w/o destroying Builder.
commit-bot@chromium.org [Thu, 10 Apr 2014 20:42:53 +0000 (20:42 +0000)]
Create SkLayerRasterizer w/o destroying Builder.

Add a new method to SkLayerRasterizer::Builder that creates a new
SkLayerRasterizer without destroying the Builder. Necessary to
continue to support Android's API.

Also fix a bug where creating a Builder and never calling
detachRasterizer results in not calling the destructor for any SkPaints
in the Builder.

Add tests.

BUG=b/13729784
R=reed@google.com, dominikg@chromium.org

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/233673002

git-svn-id: http://skia.googlecode.com/svn/trunk@14139 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: eliminate meaningless 404 errors while waiting for content to...
commit-bot@chromium.org [Thu, 10 Apr 2014 20:41:13 +0000 (20:41 +0000)]
rebaseline_server: eliminate meaningless 404 errors while waiting for content to load

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/231513004

git-svn-id: http://skia.googlecode.com/svn/trunk@14138 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFlesh out the list of includes, also fix up README markdown
commit-bot@chromium.org [Thu, 10 Apr 2014 20:24:14 +0000 (20:24 +0000)]
Flesh out the list of includes, also fix up README markdown

Currently only pulls in 'core' and 'effects'. Will add in gpu once we add an option to render via Mesa.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/232883004

git-svn-id: http://skia.googlecode.com/svn/trunk@14137 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd MakeEmpty to GrIRect16
commit-bot@chromium.org [Thu, 10 Apr 2014 18:36:19 +0000 (18:36 +0000)]
Add MakeEmpty to GrIRect16

The GrLayerCache will use this capability.

R=jvanverth@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/232563007

git-svn-id: http://skia.googlecode.com/svn/trunk@14136 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a new bench that tests a simple image filter DAG.
senorblanco@chromium.org [Thu, 10 Apr 2014 16:16:13 +0000 (16:16 +0000)]
Add a new bench that tests a simple image filter DAG.

This bench exercises a blur filter connected to 5 inputs of the same
merge filter.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/233383002

git-svn-id: http://skia.googlecode.com/svn/trunk@14135 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix GPU-less build.
commit-bot@chromium.org [Thu, 10 Apr 2014 16:03:06 +0000 (16:03 +0000)]
Fix GPU-less build.

Do not include GrTBackendEffectFactory.h if SK_SUPPORT_GPU is
undefined.

R=egdaniel@google.com
TBR=egdaniel@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/233093003

git-svn-id: http://skia.googlecode.com/svn/trunk@14134 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd explicit filepaths to render_pictures JSON summary
commit-bot@chromium.org [Thu, 10 Apr 2014 15:39:02 +0000 (15:39 +0000)]
add explicit filepaths to render_pictures JSON summary

BUG=skia:2230,skia:1942
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/226293002

git-svn-id: http://skia.googlecode.com/svn/trunk@14133 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove build guard to fix Android framework compile.
commit-bot@chromium.org [Thu, 10 Apr 2014 15:37:52 +0000 (15:37 +0000)]
Move build guard to fix Android framework compile.

After merging into the Android tree, this file was not compiling.
It turns out that it was because SK_SUPPORT_GPU was not defined. When
built by GYP, SK_SUPPORT_GPU is defined by GYP. When built by the
Android framework, we depend on SkUserConfig.h, which is included by
other files, to set SK_SUPPORT_GPU. Moving the includes outside of
#if SK_SUPPORT_GPU ensures that the dependency chain defining
SK_SUPPORT_GPU is included, so this code gets compiled as expected.

R=egdaniel@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/228893003

git-svn-id: http://skia.googlecode.com/svn/trunk@14132 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: allow user to specify which builders to process
commit-bot@chromium.org [Thu, 10 Apr 2014 15:05:24 +0000 (15:05 +0000)]
rebaseline_server: allow user to specify which builders to process

BUG=skia:1543,skia:1915
NOTRY=True
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/232103002

git-svn-id: http://skia.googlecode.com/svn/trunk@14131 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename README and DESIGN so their markdown gets picked up my GitHub.
commit-bot@chromium.org [Thu, 10 Apr 2014 14:13:23 +0000 (14:13 +0000)]
Rename README and DESIGN so their markdown gets picked up my GitHub.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231883008

git-svn-id: http://skia.googlecode.com/svn/trunk@14130 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd the chromium ninja builder to the list of trybots for a DEPS roll.
commit-bot@chromium.org [Thu, 10 Apr 2014 14:10:08 +0000 (14:10 +0000)]
Add the chromium ninja builder to the list of trybots for a DEPS roll.

R=robertphillips@google.com, borenet@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/227913005

git-svn-id: http://skia.googlecode.com/svn/trunk@14129 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorevert of 14111 to fix build
bensong@google.com [Thu, 10 Apr 2014 12:46:36 +0000 (12:46 +0000)]
revert of 14111 to fix build

git-svn-id: http://skia.googlecode.com/svn/trunk@14128 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 10 Apr 2014 03:05:44 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14127 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecordDraw: don't bother clipping an empty clip down further
commit-bot@chromium.org [Thu, 10 Apr 2014 02:26:33 +0000 (02:26 +0000)]
SkRecordDraw: don't bother clipping an empty clip down further

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, fmalita@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231933003

git-svn-id: http://skia.googlecode.com/svn/trunk@14126 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of remove sprintf (https://codereview.chromium.org/230413005/)
commit-bot@chromium.org [Wed, 9 Apr 2014 23:38:57 +0000 (23:38 +0000)]
Revert of remove sprintf (https://codereview.chromium.org/230413005/)

Reason for revert:
Boo, hiss, SK_ARRAY_COUNT not defined in skia_launcher.cpp!

Original issue's description:
> remove sprintf
>
> Committed: http://code.google.com/p/skia/source/detail?r=14123

R=halcanary@google.com
TBR=halcanary@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/232323002

git-svn-id: http://skia.googlecode.com/svn/trunk@14125 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecordDraw: skip draw ops when the clip is empty
commit-bot@chromium.org [Wed, 9 Apr 2014 23:30:28 +0000 (23:30 +0000)]
SkRecordDraw: skip draw ops when the clip is empty

   - Adds tests for SkRecordDraw's two main features: cull- and clip- based skipping.
   - Adds full SkCanvas semantic mode to SkRecorder, so it can be used as a target for SkRecordDraw.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231653002

git-svn-id: http://skia.googlecode.com/svn/trunk@14124 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove sprintf
commit-bot@chromium.org [Wed, 9 Apr 2014 23:22:44 +0000 (23:22 +0000)]
remove sprintf

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/230413005

git-svn-id: http://skia.googlecode.com/svn/trunk@14123 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReal fix for SK_API / Windows shared lib problems.
mtklein@google.com [Wed, 9 Apr 2014 22:54:57 +0000 (22:54 +0000)]
Real fix for SK_API / Windows shared lib problems.

Ben reviewed this over my shoulder, and we tested on his machine.

git-svn-id: http://skia.googlecode.com/svn/trunk@14122 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCleaned up the start page, added wait cursor, disabled Run button while waiting for...
commit-bot@chromium.org [Wed, 9 Apr 2014 22:54:02 +0000 (22:54 +0000)]
Cleaned up the start page, added wait cursor, disabled Run button while waiting for results.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14121 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSK_API for SkXfermode_opts_SSE2 so Chrome can initialize flattenables.
commit-bot@chromium.org [Wed, 9 Apr 2014 21:43:27 +0000 (21:43 +0000)]
SK_API for SkXfermode_opts_SSE2 so Chrome can initialize flattenables.

BUG=skia:2401
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231423003

git-svn-id: http://skia.googlecode.com/svn/trunk@14120 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoI got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have...
commit-bot@chromium.org [Wed, 9 Apr 2014 21:35:18 +0000 (21:35 +0000)]
I got too aggressive on the seccomp cleanup, turns out backports-debian doesn't have the linux/seccomp.h header.

Also forgot one last place that referenced syscall_reporter.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/231663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14119 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImplement drawDRRect for GPU
commit-bot@chromium.org [Wed, 9 Apr 2014 21:26:11 +0000 (21:26 +0000)]
Implement drawDRRect for GPU

BUG=skia:2259
R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/220233011

git-svn-id: http://skia.googlecode.com/svn/trunk@14118 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename kPMColor_SkColorType to kN32_SkColorType.
commit-bot@chromium.org [Wed, 9 Apr 2014 20:45:29 +0000 (20:45 +0000)]
Rename kPMColor_SkColorType to kN32_SkColorType.

The new name better represents what this flag means.

BUG=skia:2384
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/227433009

git-svn-id: http://skia.googlecode.com/svn/trunk@14117 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore SkPictureShader baselines.
fmalita@google.com [Wed, 9 Apr 2014 19:31:48 +0000 (19:31 +0000)]
More SkPictureShader baselines.

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/231563002

git-svn-id: http://skia.googlecode.com/svn/trunk@14116 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBaselines for the SkPictureShader GM.
fmalita@google.com [Wed, 9 Apr 2014 19:14:23 +0000 (19:14 +0000)]
Baselines for the SkPictureShader GM.

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/230443007

git-svn-id: http://skia.googlecode.com/svn/trunk@14115 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoInitial code for webtry, a web application for allowing users to try out Skia.
commit-bot@chromium.org [Wed, 9 Apr 2014 18:59:44 +0000 (18:59 +0000)]
Initial code for webtry, a web application for allowing users to try out Skia.

Currently running at http://108.170.220.126:8000/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/228693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14114 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoenable developers to provide their own android toolchain
commit-bot@chromium.org [Wed, 9 Apr 2014 18:57:42 +0000 (18:57 +0000)]
enable developers to provide their own android toolchain

R=halcanary@google.com, scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/227673003

git-svn-id: http://skia.googlecode.com/svn/trunk@14113 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdjusts the bench expectations calculation to consider average value.
commit-bot@chromium.org [Wed, 9 Apr 2014 18:57:02 +0000 (18:57 +0000)]
Adjusts the bench expectations calculation to consider average value.

BUG=skia:2225
NOTRY=true
R=borenet@google.com
TBR=borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/231513002

git-svn-id: http://skia.googlecode.com/svn/trunk@14112 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agono more callers of getTotalClip -- except in android
reed@google.com [Wed, 9 Apr 2014 18:47:28 +0000 (18:47 +0000)]
no more callers of getTotalClip -- except in android

git-svn-id: http://skia.googlecode.com/svn/trunk@14111 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDo div-by-zero check for all gpus in ellipse/rr effects.
commit-bot@chromium.org [Wed, 9 Apr 2014 17:11:09 +0000 (17:11 +0000)]
Do div-by-zero check for all gpus in ellipse/rr effects.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/231093002

git-svn-id: http://skia.googlecode.com/svn/trunk@14110 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14106.
bungeman@google.com [Wed, 9 Apr 2014 17:09:36 +0000 (17:09 +0000)]
Rebaselines for r14106.

git-svn-id: http://skia.googlecode.com/svn/trunk@14109 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDefine SK_CPU_X86 on x86 machines.
commit-bot@chromium.org [Wed, 9 Apr 2014 16:50:55 +0000 (16:50 +0000)]
Define SK_CPU_X86 on x86 machines.

Use this to only register flattening for SkSSE2ProcCoeffXfermode::CreateProc when it's linked.

BUG=skia:

R=reed@google.com, mtklein@google.com, bsalomon@google.com
TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/231223002

git-svn-id: http://skia.googlecode.com/svn/trunk@14108 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoXfermode: SSE2 implementation of multiply_modeproc
commit-bot@chromium.org [Wed, 9 Apr 2014 15:43:46 +0000 (15:43 +0000)]
Xfermode: SSE2 implementation of multiply_modeproc

This patch implements basics for Xfermode SSE optimization. Based on
these basics, SSE2 implementation of multiply_modeproc is provided. SSE2
implementation for other modes will come in future. With this patch
performance of Xfermode_Multiply will improve about 45%. Here are the
data on desktop i7-3770.
before:
Xfermode_Multiply   8888:  cmsecs =     33.30   565:  cmsecs =     45.65
after:
Xfermode_Multiply   8888:  cmsecs =     17.18   565:  cmsecs =     24.87

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=14006

Committed: http://code.google.com/p/skia/source/detail?r=14050

R=mtklein@google.com, robertphillips@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/202903004

git-svn-id: http://skia.googlecode.com/svn/trunk@14107 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMeasure DirectWrite BW consistently with rendering.
bungeman@google.com [Wed, 9 Apr 2014 15:35:03 +0000 (15:35 +0000)]
Measure DirectWrite BW consistently with rendering.

Also move DirectWrite glyph drawing into the scaler context, as this
reduces duplication.

R=reed@google.com

Review URL: https://codereview.chromium.org/225283021

git-svn-id: http://skia.googlecode.com/svn/trunk@14106 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for https://codereview.chromium.org/181523002/
commit-bot@chromium.org [Wed, 9 Apr 2014 14:34:24 +0000 (14:34 +0000)]
Rebaselines for https://codereview.chromium.org/181523002/

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/230733004

git-svn-id: http://skia.googlecode.com/svn/trunk@14105 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixes to Android.mk generation for arm64.
commit-bot@chromium.org [Wed, 9 Apr 2014 13:34:26 +0000 (13:34 +0000)]
Fixes to Android.mk generation for arm64.

Remove warning about no optimizations for arm64 and rebaseline the
associated test.

Exclude _opts_none.cpps when building arm64, to avoid double definitions.

BUG=skia:1975
R=halcanary@google.com, djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/229393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14104 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoARM Skia NEON patches - 22 - S32_D565_Blend
commit-bot@chromium.org [Wed, 9 Apr 2014 09:46:31 +0000 (09:46 +0000)]
ARM Skia NEON patches - 22 - S32_D565_Blend

BlitRow565: new NEON version of S32_D565_Blend

This new implementation brings a good speedup in most cases and
gives exact results (removes one mismatch in gm).

Here are the benchmark results (speedup vs. existing S32A_D565_Blend):

+-------+-----------+------------+
| count | Cortex-A9 | Cortex-A15 |
+-------+-----------+------------+
| 1     | -26,7%    | -27,5%     |
+-------+-----------+------------+
| 2     | 0%        | +53%       |
+-------+-----------+------------+
| 4     | +38,3%    | +26,5%     |
+-------+-----------+------------+
| 8     | +10,9%    |  -4,5%     |
+-------+-----------+------------+
| 16    | +18,2%    | +1,6%      |
+-------+-----------+------------+
| 64    | +22,3%    | +8,75%     |
+-------+-----------+------------+
| 256   | +12,3%    | +11,2%     |
+-------+-----------+------------+
| 1024  | +79,2%    | +10,9%     |
+-------+-----------+------------+

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/181523002

git-svn-id: http://skia.googlecode.com/svn/trunk@14103 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 9 Apr 2014 03:04:11 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14102 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkRecord: make culling work if SkRecordAnnotateCullingPairs is called.
commit-bot@chromium.org [Tue, 8 Apr 2014 23:31:35 +0000 (23:31 +0000)]
SkRecord: make culling work if SkRecordAnnotateCullingPairs is called.

  - Allow stateful functors; allow visit()/mutate() at a given index; add count().
  - Annotate cull push/pop pairs on the PushCull records.  (tested)
  - Use those annotations to skip ahead in SkRecordDraw.   (not yet tested beyond dm --skr)
  - Make SkRecordDraw a function, move its implementation to a .cpp.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/229523002

git-svn-id: http://skia.googlecode.com/svn/trunk@14101 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore SkRecord TODOs:
commit-bot@chromium.org [Tue, 8 Apr 2014 21:01:17 +0000 (21:01 +0000)]
More SkRecord TODOs:

  - add basic test for SkRecorder
  - rejigger GYPs so that the include dir comes along with the dependency

BUG=skia:2378

Committed: http://code.google.com/p/skia/source/detail?r=14099

NOTRY=true
NOTREECHECKS=true
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/227673011

git-svn-id: http://skia.googlecode.com/svn/trunk@14100 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore SkRecord TODOs:
commit-bot@chromium.org [Tue, 8 Apr 2014 20:17:26 +0000 (20:17 +0000)]
More SkRecord TODOs:

  - add basic test for SkRecorder
  - rejigger GYPs so that the include dir comes along with the dependency

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/227673011

git-svn-id: http://skia.googlecode.com/svn/trunk@14099 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't try to render color fonts using distance fields.
commit-bot@chromium.org [Tue, 8 Apr 2014 20:14:32 +0000 (20:14 +0000)]
Don't try to render color fonts using distance fields.

Adds detection of ARGB mask format, which is only used for color fonts.

BUG=skia:2173
R=bungeman@google.com, reed@google.com, bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/224903012

git-svn-id: http://skia.googlecode.com/svn/trunk@14098 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStart on some unwritten SkRecord TODOs:
commit-bot@chromium.org [Tue, 8 Apr 2014 17:31:08 +0000 (17:31 +0000)]
Start on some unwritten SkRecord TODOs:

  - add SK_OVERRIDE for SkCanvas methods in SkRecorder
  - start on unit tests, here just for SkRecord itself

BUG=skia:2378
R=fmalita@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/228723003

git-svn-id: http://skia.googlecode.com/svn/trunk@14097 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agouse default to fix warning (or I will shoot myself)
reed@google.com [Tue, 8 Apr 2014 16:57:05 +0000 (16:57 +0000)]
use default to fix warning (or I will shoot myself)

git-svn-id: http://skia.googlecode.com/svn/trunk@14096 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix warning for uninitialized count
reed@google.com [Tue, 8 Apr 2014 16:02:45 +0000 (16:02 +0000)]
fix warning for uninitialized count

git-svn-id: http://skia.googlecode.com/svn/trunk@14095 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix warning about uninitialized typeface_encoding by folding glyph case into switch
reed@google.com [Tue, 8 Apr 2014 15:48:26 +0000 (15:48 +0000)]
fix warning about uninitialized typeface_encoding by folding glyph case into switch

git-svn-id: http://skia.googlecode.com/svn/trunk@14094 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix warning by removing padding field
reed@google.com [Tue, 8 Apr 2014 15:29:10 +0000 (15:29 +0000)]
fix warning by removing padding field

git-svn-id: http://skia.googlecode.com/svn/trunk@14093 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoInitial picture shader implementation
commit-bot@chromium.org [Tue, 8 Apr 2014 15:19:34 +0000 (15:19 +0000)]
Initial picture shader implementation

This CL adds an SkPictureShader class to support SkPicture-based
patterns.

The implementation renders the picture into an SkBitmap tile and then
delegates to SkBitmapProcShader for the actual operation.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com

Committed: http://code.google.com/p/skia/source/detail?r=14085

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/221923007

git-svn-id: http://skia.googlecode.com/svn/trunk@14092 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd push/pop cull to SkRecord.
commit-bot@chromium.org [Tue, 8 Apr 2014 15:17:17 +0000 (15:17 +0000)]
Add push/pop cull to SkRecord.

BUG=skia:2378
R=fmalita@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/224723026

git-svn-id: http://skia.googlecode.com/svn/trunk@14091 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWIP -- SkFont
reed@google.com [Tue, 8 Apr 2014 15:04:29 +0000 (15:04 +0000)]
WIP -- SkFont

BUG=skia:
R=bungeman@google.com, fmalita@chromium.org

Review URL: https://codereview.chromium.org/185293018

git-svn-id: http://skia.googlecode.com/svn/trunk@14090 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRelax the assert in SkReadBuffer::setPictureVersion().
fmalita@google.com [Tue, 8 Apr 2014 14:11:26 +0000 (14:11 +0000)]
Relax the assert in SkReadBuffer::setPictureVersion().

I'm hitting this with SkPictureShader serialization because there can be
multiple pictures deserialized from the same buffer.

I think we can relax the assert to allow setting the same version
multiple times.

(Alternatively, we could guard all the callers - but since setting the
same version is a no-op, that seems overkill)

R=mtklein@google.com, reed@google.com

Review URL: https://codereview.chromium.org/226743004

git-svn-id: http://skia.googlecode.com/svn/trunk@14089 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemoves deleted files SkBitmapShader* from gyp/core.gypi.
commit-bot@chromium.org [Tue, 8 Apr 2014 12:24:01 +0000 (12:24 +0000)]
Removes deleted files SkBitmapShader* from gyp/core.gypi.

BUG=skia:
NOTRY=true
R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/228513003

git-svn-id: http://skia.googlecode.com/svn/trunk@14088 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Initial picture shader implementation (https://codereview.chromium.org...
commit-bot@chromium.org [Mon, 7 Apr 2014 23:45:31 +0000 (23:45 +0000)]
Revert of Initial picture shader implementation (https://codereview.chromium.org/221923007/)

Reason for revert:
breaking the buildbots. Subsequent CL only addressed CompareGMs but GenerateGMs are also failing.

Original issue's description:
> Initial picture shader implementation
>
> This CL adds an SkPictureShader class to support SkPicture-based
> patterns.
>
> The implementation renders the picture into an SkBitmap tile and then
> delegates to SkBitmapProcShader for the actual operation.
>
> R=reed@google.com,robertphillips@google.com,bsalomon@google.com
>
> Committed: http://code.google.com/p/skia/source/detail?r=14085

R=bsalomon@google.com, reed@google.com, robertphillips@google.com, fmalita@chromium.org
TBR=bsalomon@google.com, fmalita@chromium.org, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/227553010

git-svn-id: http://skia.googlecode.com/svn/trunk@14087 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSuppress pictureshader GM failures.
fmalita@google.com [Mon, 7 Apr 2014 23:30:37 +0000 (23:30 +0000)]
Suppress pictureshader GM failures.

Pending baselines.

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/225413018

git-svn-id: http://skia.googlecode.com/svn/trunk@14086 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoInitial picture shader implementation
commit-bot@chromium.org [Mon, 7 Apr 2014 23:11:45 +0000 (23:11 +0000)]
Initial picture shader implementation

This CL adds an SkPictureShader class to support SkPicture-based
patterns.

The implementation renders the picture into an SkBitmap tile and then
delegates to SkBitmapProcShader for the actual operation.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/221923007

git-svn-id: http://skia.googlecode.com/svn/trunk@14085 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd option to SkDecodingImageGenerator to require unpremul.
commit-bot@chromium.org [Mon, 7 Apr 2014 21:37:36 +0000 (21:37 +0000)]
Add option to SkDecodingImageGenerator to require unpremul.

Android needs to be able to set unpremul for purgeable
pixelRefs.

Once Android switches to the new interface, we can delete SkImageRef.

Bug=skia:2389

R=reed@google.com, halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/223903007

git-svn-id: http://skia.googlecode.com/svn/trunk@14084 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG
commit-bot@chromium.org [Mon, 7 Apr 2014 21:33:06 +0000 (21:33 +0000)]
remove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG
remove SK_SUPPORT_LEGACY_GETDEVICECAPABILITIES

BUG=skia:
R=robertphillips@google.com, bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/227643005

git-svn-id: http://skia.googlecode.com/svn/trunk@14083 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoclear bitmap in texture domain gm
commit-bot@chromium.org [Mon, 7 Apr 2014 21:18:46 +0000 (21:18 +0000)]
clear bitmap in texture domain gm

R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/227563007

git-svn-id: http://skia.googlecode.com/svn/trunk@14082 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkNonCopyable should be used with private inheritance.
commit-bot@chromium.org [Mon, 7 Apr 2014 19:34:38 +0000 (19:34 +0000)]
SkNonCopyable should be used with private inheritance.

This is mostly s/public SkNoncopyable/SkNoncopyable/g.

Two classes (SkDrawLooper::Context and SkPicture::OperationList) don't actually work with SkNoncopyable because they introduce a virtual destructor.  I added SkNoncopyableVirtual to make them work as intended.  Sort of questionable whether they really need to be noncopyable in the first place, but I guess it doesn't hurt to keep the behavior the same.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/226183018

git-svn-id: http://skia.googlecode.com/svn/trunk@14081 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFactory methods for heap-allocated SkTypeface objects.
commit-bot@chromium.org [Mon, 7 Apr 2014 19:34:16 +0000 (19:34 +0000)]
Factory methods for heap-allocated SkTypeface objects.

This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.

This patch makes the constructors of SkTypeface and its subclasses non-public
and instead provides factory methods for creating these objects on the heap.

BUG=skia:2187
R=scroggo@google.com, bungeman@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/227693003

git-svn-id: http://skia.googlecode.com/svn/trunk@14080 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoConvert SkPicture's generation ID to a unique ID
commit-bot@chromium.org [Mon, 7 Apr 2014 18:26:22 +0000 (18:26 +0000)]
Convert SkPicture's generation ID to a unique ID

This CL addresses linger code review comments on r14037 (Add generation ID to SkPicture https://codereview.chromium.org/222683002/)

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/225283014

git-svn-id: http://skia.googlecode.com/svn/trunk@14079 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SkBitmapShaderTemplate.
commit-bot@chromium.org [Mon, 7 Apr 2014 18:01:09 +0000 (18:01 +0000)]
Remove SkBitmapShaderTemplate.

Remove files that are no longer needed:
src/core/SkBitmapShaderTemplate.h
src/core/SkBitmapShader16BilerpTemplate.h

BUG=skia:1976
R=scroggo@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/225023028

git-svn-id: http://skia.googlecode.com/svn/trunk@14078 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Discard scratch render targets before reusing them. (https://codereview...
commit-bot@chromium.org [Mon, 7 Apr 2014 17:43:01 +0000 (17:43 +0000)]
Revert of Discard scratch render targets before reusing them. (https://codereview.chromium.org/225183012/)

Reason for revert:
Asserts in debug.

Original issue's description:
> Discard scratch render targets before reusing them.
>
> R=robertphillips@google.com
>
> Committed: http://code.google.com/p/skia/source/detail?r=14075

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/224963014

git-svn-id: http://skia.googlecode.com/svn/trunk@14077 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix EffectKey for XferEffect
commit-bot@chromium.org [Mon, 7 Apr 2014 17:13:10 +0000 (17:13 +0000)]
Fix EffectKey for XferEffect

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/227233007

git-svn-id: http://skia.googlecode.com/svn/trunk@14076 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDiscard scratch render targets before reusing them.
commit-bot@chromium.org [Mon, 7 Apr 2014 17:03:00 +0000 (17:03 +0000)]
Discard scratch render targets before reusing them.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/225183012

git-svn-id: http://skia.googlecode.com/svn/trunk@14075 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_GETCLIPTYPE
commit-bot@chromium.org [Mon, 7 Apr 2014 15:17:37 +0000 (15:17 +0000)]
remove SK_SUPPORT_LEGACY_GETCLIPTYPE

after this lands and sticks, we can remove the assocated code from skia

BUG=skia:
R=robertphillips@google.com, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/216703004

git-svn-id: http://skia.googlecode.com/svn/trunk@14074 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SkResizeImageFilter.
commit-bot@chromium.org [Mon, 7 Apr 2014 15:11:08 +0000 (15:11 +0000)]
Remove SkResizeImageFilter.

Its functionality has been subsumed by SkMatrixImageFilter, and it's no longer
used in Blink.

BUG=skia:
R=bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/222923005

git-svn-id: http://skia.googlecode.com/svn/trunk@14073 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove deprecated function.
commit-bot@chromium.org [Mon, 7 Apr 2014 14:00:31 +0000 (14:00 +0000)]
Remove deprecated function.

We have switched Android to call decodeSubset, so this function
is no longer necessary.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/225413013

git-svn-id: http://skia.googlecode.com/svn/trunk@14072 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixed Skia compilation error with strict clang.
commit-bot@chromium.org [Mon, 7 Apr 2014 13:12:47 +0000 (13:12 +0000)]
Fixed Skia compilation error with strict clang.

BUG=skia:
R=reed@google.com, sergeyberezin@chromium.org, hcm@google.com

Author: kolczyk@opera.com

Review URL: https://codereview.chromium.org/227043006

git-svn-id: http://skia.googlecode.com/svn/trunk@14071 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 5 Apr 2014 03:05:27 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14070 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoget iOS building again
commit-bot@chromium.org [Sat, 5 Apr 2014 01:13:43 +0000 (01:13 +0000)]
get iOS building again

1) Disable SampleApp.  Seems like it's totally horked?  SkOSFile_iOS.mm is missing about half the functions needed, and SkOSFile_stdio.cpp is double-providing the others.

2) Drop armv6.

3) Switch from putting headers in sources to putting the corresponding directories in includes.

4)  Force cast the type of glShaderSource.  Something to do with GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE?

After all this,
    env CC=clang CXX=clang++ GYP_DEFINES=skia_os=ios make
builds for me.
BUG=skia:2363
R=bsalomon@google.com, epoger@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/226413005

git-svn-id: http://skia.googlecode.com/svn/trunk@14069 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselining resizeimagefilter
commit-bot@chromium.org [Fri, 4 Apr 2014 21:23:30 +0000 (21:23 +0000)]
Rebaselining resizeimagefilter

BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/226413002

git-svn-id: http://skia.googlecode.com/svn/trunk@14068 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdates to Android.mk generation.
commit-bot@chromium.org [Fri, 4 Apr 2014 21:19:53 +0000 (21:19 +0000)]
Updates to Android.mk generation.

These defines were manually added to the last merge.

BUG=skia:1975
R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/226663002

git-svn-id: http://skia.googlecode.com/svn/trunk@14067 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange SkDecodingImageGenerator to hide implementation details.
commit-bot@chromium.org [Fri, 4 Apr 2014 20:13:05 +0000 (20:13 +0000)]
Change SkDecodingImageGenerator to hide implementation details.

Motivation: A later CL will move SkDecodingImageGenerator into
include/ for Android to use.

R=scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/226253003

git-svn-id: http://skia.googlecode.com/svn/trunk@14066 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix nacl build using ninja
commit-bot@chromium.org [Fri, 4 Apr 2014 18:16:04 +0000 (18:16 +0000)]
fix nacl build using ninja

BUG=skia:2366
NOTREECHECKS=True
NOTRY=True
R=robertphillips@google.com
TBR=robertphillips

Author: epoger@google.com

Review URL: https://codereview.chromium.org/225683005

git-svn-id: http://skia.googlecode.com/svn/trunk@14065 2bbb7eff-a529-9590-31e7-b0007b416f81