Jaeun Choi [Thu, 10 Apr 2014 10:29:37 +0000 (19:29 +0900)]
removed unnecessary field in key binding
Summary: No need to check ev->string if use ev->key instead of ev->keyname.
Test Plan: None
Reviewers: raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D714
Carsten Haitzler (Rasterman) [Thu, 10 Apr 2014 09:18:21 +0000 (18:18 +0900)]
FIX TOMS BREAKING OF ELEMENTARY!
Tom Hacohen [Thu, 10 Apr 2014 08:49:22 +0000 (09:49 +0100)]
Adjust code to use the slightly different Eo2 API.
With Eo2 you can return values directly without the need to use a pointer
(use the C return).
For example:
eo_do(obj, elm_object_text_get(&text));
becomes:
eo_do(obj, text = elm_object_text_get());
@feature
Tom Hacohen [Thu, 3 Apr 2014 14:21:28 +0000 (15:21 +0100)]
atspi: Made some protected functions protected.
They should be protected and they break compilation if they are not. I'm
pretty sure much more functions should be protected, but this one
definitely.
Tom Hacohen [Thu, 3 Apr 2014 16:30:04 +0000 (17:30 +0100)]
test task switcher: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:26:23 +0000 (17:26 +0100)]
test systray: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:25:38 +0000 (17:25 +0100)]
test application server: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:23:03 +0000 (17:23 +0100)]
win: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:21:05 +0000 (17:21 +0100)]
widget: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:13:49 +0000 (17:13 +0100)]
web: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:13:10 +0000 (17:13 +0100)]
video: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:12:41 +0000 (17:12 +0100)]
toolbar: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 16:00:37 +0000 (17:00 +0100)]
thumb: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:56:23 +0000 (16:56 +0100)]
table: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:55:07 +0000 (16:55 +0100)]
spinner: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:53:52 +0000 (16:53 +0100)]
slideshow: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:53:19 +0000 (16:53 +0100)]
slider: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:51:55 +0000 (16:51 +0100)]
separator: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:51:11 +0000 (16:51 +0100)]
segment control: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:50:15 +0000 (16:50 +0100)]
scroller: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:46:01 +0000 (16:46 +0100)]
route: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:45:35 +0000 (16:45 +0100)]
radio: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:44:14 +0000 (16:44 +0100)]
progressbar: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:42:49 +0000 (16:42 +0100)]
prefs: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:41:59 +0000 (16:41 +0100)]
plug: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:41:05 +0000 (16:41 +0100)]
photocam: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:39:38 +0000 (16:39 +0100)]
photo: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:38:49 +0000 (16:38 +0100)]
panes: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:36:36 +0000 (16:36 +0100)]
notify: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:35:37 +0000 (16:35 +0100)]
menu: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:34:29 +0000 (16:34 +0100)]
mapbuf: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:33:52 +0000 (16:33 +0100)]
map: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:32:21 +0000 (16:32 +0100)]
list: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:30:35 +0000 (16:30 +0100)]
layout: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:27:05 +0000 (16:27 +0100)]
label: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:25:28 +0000 (16:25 +0100)]
inwin: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:23:51 +0000 (16:23 +0100)]
interface scrollable: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:20:32 +0000 (16:20 +0100)]
interface atspi component: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:18:15 +0000 (16:18 +0100)]
index: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:17:22 +0000 (16:17 +0100)]
image: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:15:48 +0000 (16:15 +0100)]
icon: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:13:46 +0000 (16:13 +0100)]
hover: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:10:56 +0000 (16:10 +0100)]
grid: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:10:15 +0000 (16:10 +0100)]
glview: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:09:35 +0000 (16:09 +0100)]
genlist: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:07:36 +0000 (16:07 +0100)]
gengrid: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:06:01 +0000 (16:06 +0100)]
frame: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:05:07 +0000 (16:05 +0100)]
flipselector: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:04:11 +0000 (16:04 +0100)]
flip: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 15:02:32 +0000 (16:02 +0100)]
entry: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 14:10:04 +0000 (15:10 +0100)]
diskselector: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 14:05:31 +0000 (15:05 +0100)]
dbus menu: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 14:03:20 +0000 (15:03 +0100)]
dayselector: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:57:11 +0000 (14:57 +0100)]
datetime: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:55:57 +0000 (14:55 +0100)]
conformant: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:55:07 +0000 (14:55 +0100)]
colorselector: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:54:14 +0000 (14:54 +0100)]
cnp: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:51:21 +0000 (14:51 +0100)]
clock: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:50:21 +0000 (14:50 +0100)]
check: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:49:09 +0000 (14:49 +0100)]
calendar: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:48:15 +0000 (14:48 +0100)]
button: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:47:03 +0000 (14:47 +0100)]
bubble: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:46:22 +0000 (14:46 +0100)]
box: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:45:21 +0000 (14:45 +0100)]
atspi bridge: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:35:15 +0000 (14:35 +0100)]
atspi object: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:28:24 +0000 (14:28 +0100)]
app client view: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:26:23 +0000 (14:26 +0100)]
app client: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:24:13 +0000 (14:24 +0100)]
app server view: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:21:40 +0000 (14:21 +0100)]
app server: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:09:52 +0000 (14:09 +0100)]
actionslider: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:08:39 +0000 (14:08 +0100)]
popup: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:05:41 +0000 (14:05 +0100)]
player: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:04:32 +0000 (14:04 +0100)]
naviframe: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:02:23 +0000 (14:02 +0100)]
multibuttonentry: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 13:00:20 +0000 (14:00 +0100)]
hoversel: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 12:58:26 +0000 (13:58 +0100)]
fileselector entry: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 12:55:13 +0000 (13:55 +0100)]
fileselector button: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 12:53:04 +0000 (13:53 +0100)]
fileselector: Adjusted to Eo2.
Tom Hacohen [Thu, 3 Apr 2014 12:46:17 +0000 (13:46 +0100)]
Ctxpopup: Adjusted to Eo2.
Jaeun Choi [Thu, 10 Apr 2014 08:10:00 +0000 (17:10 +0900)]
scroller: apply key binding
Summary: This patch applies key binding to elm_scroller.
Test Plan: elementary_test > Scroller > check key events
Reviewers: Hermet, raster
Differential Revision: https://phab.enlightenment.org/D711
Carsten Haitzler (Rasterman) [Thu, 10 Apr 2014 08:02:52 +0000 (17:02 +0900)]
fix new access of uninitted memory isue on eo move
Jean-Philippe Andre [Thu, 10 Apr 2014 07:07:05 +0000 (16:07 +0900)]
Makefile: Add @EVIL_LIBS@ for access_output
Thanks Adrien for the report and fix.
Carsten Haitzler (Rasterman) [Thu, 10 Apr 2014 06:06:35 +0000 (15:06 +0900)]
elm cnip - fix new cnp problem where invalid mem ref done
Tom Hacohen [Thu, 3 Apr 2014 14:43:26 +0000 (15:43 +0100)]
layout: expose a typedef that needs to be public (Content_Alias).
This typedef is used in publicly exposed APIs.
Thiep Ha [Thu, 10 Apr 2014 02:20:50 +0000 (11:20 +0900)]
dnd: Skip drag window when drag starts
Summary:
Currently, when drag starts, drag window is not skipped. It makes ecore_x cannot find dropable window in some cases.
Issue: Dropable window is not found if we drop inside the initialized area of drag window.
(Example: in Dnd Types of elementary test, try to start dragging at right edge of left label and drop to left edge of right label. The drop is failed).
Reason: Ecore_x considers drag window when it tries to find dropable window at specific position. Therefore, it cannot find dropable window.
Resolve: Skip drag window.
@fix
Reviewers: raster, JackDanielZ, seoz
CC: woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D710
Jaeun Choi [Thu, 10 Apr 2014 02:14:59 +0000 (11:14 +0900)]
naviframe: apply key binding
Summary: This patch applies key binding to elc_naviframe.
Test Plan: elementary_test > Naviframe > check key events
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D709
Ryuan Choi [Wed, 9 Apr 2014 15:49:10 +0000 (00:49 +0900)]
fleselector_button: Implement some missing interfaces of Elm_Interface_Fileselector
Implemented below.
- Elm_Interface_Fileselector::selected_paths::get;
- Elm_Interface_Fileselector::thumbnail_size;
- Elm_Interface_Fileselector::selected;
- Elm_Interface_Fileselector::hidden_visible;
- Elm_Interface_Fileselector::sort_method;
- Elm_Interface_Fileselector::multi_select;
- Elm_Interface_Fileselector::mode;
Bogdan Devichev [Wed, 9 Apr 2014 10:04:55 +0000 (19:04 +0900)]
elementary: when modal win appears another wins are blocked
Summary:
In win.edc add blocker for its content and programs for it. Add
Eina_Bool blocked and was_enabled to _Elm_Menu_Item for correctly blocking
and unblocking of main_menu. They used for saving state which was before modal
win was apeared. Add callbacks and private functions in menu.c for blocking and
unblocking menu. Add integer modal_count to Elm_Win_Smart_Data for creating
enum of modal wins. Add changes in win.c for blocking content, in_focus callback
and menu while modal win is exist.
Reviewers: cedric, seoz, raster
Reviewed By: raster
CC: reutskiy.v.v, raster
Differential Revision: https://phab.enlightenment.org/D607
Mike Blumenkrantz [Tue, 8 Apr 2014 20:23:07 +0000 (16:23 -0400)]
genlist event_block_rect needs a smart parent to reduce BITCH
Daniel Juyung Seo [Sun, 6 Apr 2014 19:13:01 +0000 (04:13 +0900)]
list: Fixed _elm_list_item_content_focus_set in case the first content
is focused.
The function should return true when the first content of an item is
focused.
@fix
Daniel Juyung Seo [Sun, 6 Apr 2014 19:01:32 +0000 (04:01 +0900)]
list: Refactor direction key event handling routine in list.
- Added internal function _elm_list_elm_widget_event_direction.
- Simplified cascaded if statements.
- Note: focus_on_selection feature is still broken.
Daniel Juyung Seo [Sun, 6 Apr 2014 18:08:20 +0000 (03:08 +0900)]
list: Fixed _elm_list_item_content_focus_set misbehavior.
- Moved a check for direction at the start of the function based on the
horizontal mode configuration.
- Removed unnecessary focus set to edje object. In this case, that item
will get the focus automatically by elm widget item focus
infrastructure.
But this focus_on_selection feature is still broken. I need to fix them
more.
Daniel Juyung Seo [Sun, 6 Apr 2014 15:58:22 +0000 (00:58 +0900)]
test_list: Removed wrong box packing from list focus example.
Amitesh Singh [Sat, 5 Apr 2014 15:10:55 +0000 (00:10 +0900)]
focus: Renamed the config APIs _item_focus_on_selection_get/set to _item_select_on_focus_disabled_set/get()
Summary: - List: On Enter/Space/KP_Enter key press, focused item gets selected.
Test Plan: elementary_test->List Focus
Reviewers: seoz, raster
Reviewed By: seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D704
Daniel Juyung Seo [Fri, 4 Apr 2014 16:18:26 +0000 (01:18 +0900)]
gengrid: Fixed wrong formatting.
wonguk.jeong [Fri, 4 Apr 2014 03:18:48 +0000 (12:18 +0900)]
plug: fix SEGV of elementary_test during reconnecting
Summary:
problem:
1. open window socket
2. open window plug
3. close window socket
4. open window socket
5. SEGV
there was invalid timer deletion due to dangling pointer.
@fix
Test Plan: elementary_test -> open window socket -> open window plug -> close window socket -> open window socket ->SEGV
Reviewers: raster, seoz
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D699
Amitesh Singh [Fri, 4 Apr 2014 03:04:04 +0000 (12:04 +0900)]
list/genlist/gengrid/toolbar: Fix - _nearest_visible_item_get() should always return an item.
Test Plan:
Bug:
- elementary_test->genlist/list/toolbar/gengrid Focus
- Resize the window to a state when no item is fully visible. only partially visible.
- Move Focus from outer widgets (Up/Down/Left/right buttons) to list/genlist/gengrid/toolbar.
- Focus goes away (size - 0). Reason: _nearest_visible_item_get returns NULL.
@fix
Reviewers: seoz, raster, woohyun
Reviewed By: raster
CC: seoz, nirajkr, anand.km
Differential Revision: https://phab.enlightenment.org/D696
wonguk.jeong [Fri, 4 Apr 2014 02:47:39 +0000 (11:47 +0900)]
map: remove memory leak
Summary:
1. Name of sources from external module was not free'd. (there was type mismatch between external module and internal impl.)
2. after eina_module_list_free(), eina_array_free() was not invoked.
3. alloc'd but not free'd
@fix
Test Plan: valgrind
Reviewers: raster, cedric, seoz, bluezery, woohyun
CC: seoz
Differential Revision: https://phab.enlightenment.org/D661
Tom Hacohen [Thu, 3 Apr 2014 16:58:59 +0000 (17:58 +0100)]
Interface scrollable: Added missing dep.
Tom Hacohen [Thu, 3 Apr 2014 14:53:58 +0000 (15:53 +0100)]
Elm interface scrollable: Put .eo.h include after needed deps.