jihwan.seo [Fri, 10 Jul 2015 05:25:03 +0000 (14:25 +0900)]
remove unnecessary codes in android BLE
there are many unnecessary wait/mutex/flag.
it will bring slow performance.
Change-Id: I8cb9c4c93d522c5c32669aab569da1a6ff22511a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1617
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
sonu1.yadav [Tue, 14 Jul 2015 09:09:57 +0000 (14:39 +0530)]
Fix IOT-605: fridgeclient executable's abnormal termination
Change-Id: Idcfcd4296d76742859e10b44f36f3ca56ce76ca0
Signed-off-by: sonu1.yadav <sonu1.yadav@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1644
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Mon, 13 Jul 2015 02:15:37 +0000 (19:15 -0700)]
Fixed broken observation cancellation.
Observe Cancel was broken because the uri from the client callback was
not copied into the request object. This caused connectivity to eat the
request witout sending it out.
Change-Id: Ib0ab815647897f2815fdffc3011e9977a003ac5f
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1637
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 10 Jul 2015 23:34:32 +0000 (16:34 -0700)]
Fixed Fridge sample with constructResourceObject
The constructResourceObject takes a host string, which isn't compatible
with the current OCDevAddr address. This patch parses said string, and
converts it properly to an OCDevAddr.
Change-Id: Id86f3832e596aa8869794a1d33915e158fe85008
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1624
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Erich Keane [Sat, 11 Jul 2015 05:37:41 +0000 (22:37 -0700)]
Fixed broken presence after IPv6 plumbing merge to
Presence wasn't working for multiple reasons. oc/presence was not moved
to oic/ad, probably lost in the merge to master.
resourceUri in CA data structures was moved form the endpoint to the
CAInfo struct. But wasn't included in a clone operation which resulted
in a race condition when the memory was free'd in the main thread before
being accessed by the thread in CA.
Other adapter/flag issues.
Unicast presence failed to work because host() from OCResource only
returned the IP without the port.
Change-Id: If2e46f4677ebe369cbaee9609de38c369bf4c524
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Signed-off-by: Erich Keane <erich.keane@verizon.net>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1424
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Omkar Hegde [Fri, 10 Jul 2015 23:21:17 +0000 (16:21 -0700)]
Changed C Samples to use correct adapter type
The C Samples were broken as a result of changing
the samples for IPv6. Also, removed port 6298 from
unicast discovery query and replaced some printf()
with OC_LOG(). Removed Differentiation between
IPv4 and IPv6 in the samples.
Change-Id: I83859aaf468c991ca5406014359476d0f43d5745
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 10 Jul 2015 22:42:07 +0000 (15:42 -0700)]
Fixed an invalid read/write caused by deleted temporary
The copy used a std::copy mechanism on optionData, which
resulted in the temporary being deleted before the function
returned. This creates a variable to hold the temporary so that
the string won't be deleted before use.
Change-Id: I5da2601b730e27d42e244b52ba6cdd69a0e28fb4
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1622
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Sachin Agrawal [Fri, 10 Jul 2015 00:27:59 +0000 (17:27 -0700)]
Updated Secure Sample for new resource discovery response
Resource Discovery response was udpated to be compliance with
OIC Specification. This change is to correctly parse the
discovery response.
Change-Id: I3c16f0ed827f5f993def01e7741c592b1ad1926b
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1614
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Jamal Haidar [Sat, 4 Jul 2015 11:59:23 +0000 (17:29 +0530)]
Add Destructor to free new allocated resource in Ctor.
~Middle() and ~RestInput() destrcutors added which deletes allocated
memory in Ctors.
Change-Id: I29823cde6c7b28325fde9b40f088f83994ebc6a5
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1522
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Wed, 1 Jul 2015 13:41:29 +0000 (19:11 +0530)]
csdk: Fixes cppcheck issue in security dir.
This patch fixes the the below issue reported by cppcheck tool in security dir:
"(error) Possible null pointer dereference: jsonObj - otherwise it is
redundant to check if jsonObj is null at line 259
(error) Possible null pointer dereference: jsonStr1 - otherwise it is
redundant to check if jsonStr1 is null at line 132"
Null value check of jsonObj and jsonStr1 are removed as it in unnecessary here.
Change-Id: I6c0676a58780afea3026c3e1332c8ecac7c0dd1e
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1508
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
koushik.girijala [Fri, 3 Jul 2015 07:18:02 +0000 (12:48 +0530)]
[CA] RI sample occlient fix for not able to send get unicast data
fixed OCconectivity type and port number adding to uri
Change-Id: Ie99e66dd6c7840008d9f0cfc41089d183907c585
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1503
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Mon, 6 Jul 2015 08:48:28 +0000 (17:48 +0900)]
Updated android BLE code
I have replaced previous property and permission code
with Property_Notify which mentioned OIC ble spec.
(https://workspace.openinterconnect.org/
apps/org/workgroup/oswg/download.php/1568/
OIC_BLE_Transport_Profile.pdf)
Change-Id: I7002ba70c9f0d267ef9f695c0cb3ee3688dd9a77
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1532
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
sanilgupta [Wed, 1 Jul 2015 06:41:05 +0000 (12:11 +0530)]
Updated the comments as per Jira IOT-573
Please update
Change-Id: Idd318b1f6d2359deb1653b323d35159ffb9fbd8f
Signed-off-by: sanilgupta <sanil.g@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1473
Reviewed-by: Ravi Nanjundappa <nravi.n@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Thu, 9 Jul 2015 11:54:41 +0000 (17:24 +0530)]
Replaced printf with Serial.println() in arduino CASample
Change-Id: I8ab085b2ca330789255d8397d42cf483a9d97187
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1600
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Fri, 10 Jul 2015 08:10:18 +0000 (17:10 +0900)]
Fix Android TinyDtls build issue in Debug mode
For Android build currently debug.c is not included.
In this case NDEBUG flag must be defined.
Provided a correct fix
Change-Id: Icaa4364a3e87bc33e9e7165977838ba1ea328506
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1618
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Thu, 9 Jul 2015 08:39:46 +0000 (14:09 +0530)]
Resolved compilation issues of BLE adapter in Tizen and Arduino
Change-Id: If9c4d1ade926733a3959808e9b3cfc6880e91cb3
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1594
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Fri, 10 Jul 2015 00:39:06 +0000 (17:39 -0700)]
Updated gitignore to ignore dependencies folder
Ignore 'dep' folder created in iotivity tree when
android build is invoked.
Change-Id: Ibd9630a9d4327c44518d632fb8f39ffd3509b9f3
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1615
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Mandeep Shetty [Thu, 9 Jul 2015 17:15:11 +0000 (10:15 -0700)]
Fix failure to respond when SRM says Access Denied.
The enum types for forbidden request and unauthorized request in
CAResponseResult_t added as part of security where misisng in a sanity
check switch case. This caused the forbidden and unauthorized response
codes to be classified as invalid.
Change-Id: Idc53a50422e3d5e43a847395a2389da351ea6baf
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1610
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>
Rahul Rahul [Thu, 2 Jul 2015 19:23:14 +0000 (12:23 -0700)]
Updated android code based on OcConnectivityType changes due to IPv6 support
Change-Id: Ic3c332dc72c5ab87f971b346eae0cb5456ac58a7
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1495
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Bernie Keany <bernie.keany@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Rahul Rahul [Mon, 6 Jul 2015 22:59:04 +0000 (15:59 -0700)]
Adding GuiClient example for android
Change-Id: I4c0930032ccfc7814965f152846d16561bd3ed76
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Thu, 9 Jul 2015 10:37:22 +0000 (16:07 +0530)]
Fixed Tizen CASample to select proper Transport type.
Change-Id: I74c8cc3a768501c8620b9f558a1e15da04d79e08
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1596
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Thu, 9 Jul 2015 11:05:26 +0000 (16:35 +0530)]
[Tizen][DTLS] Fix for broken DTLS build in Tizen
Fixed broken DTLS build in Tizen
Change-Id: If281be0640fd11a830655102bc9cd091a82a0df8
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1599
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Thu, 9 Jul 2015 05:19:58 +0000 (14:19 +0900)]
modify the preprocessor to stop the thread in ipadapter
In case I use a ndk-build for android sample build,
the MULTI_THREAD is not defined.
because preprocessor was defined within Sconscript.
so I modified the code to stop the send thread.
Change-Id: I732fad2120fe243b6b976230aa395fdbb385dda1
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1588
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Thu, 9 Jul 2015 12:09:08 +0000 (17:39 +0530)]
[Tizen][BLE] Fix for broken BLE build
Fixed broken BLE build for Tizen
Change-Id: I508404f97ef5ef19f1b9820519e44c1d911158da
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1601
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jamal Haidar [Thu, 9 Jul 2015 07:56:49 +0000 (13:26 +0530)]
Fix memory leak in policyengine
Temp allocated memory in policyengine is unsed and not freed before
exit.
Change-Id: I1a1f3587c521b83ba764248f00547a2e8997c865
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1592
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>
Hauke Mehrtens [Mon, 29 Jun 2015 21:07:39 +0000 (23:07 +0200)]
things-manager: sampleapp: fix name of musicplayer
The musicplayer should be named MusicplayerApp as it is referenced
under that name some lines below.
Change-Id: I351ee4316bbb19a67a0afc16882cb2192a2ff07f
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1445
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Mandeep Shetty [Tue, 7 Jul 2015 22:35:12 +0000 (15:35 -0700)]
Changed discovery JSON for spec compliance to contain device ID.
New json schema does not have properties field for resources.
Everything is now a property.
Device ID as string UUID is included in discovery responses once per
response as opposed to being a part of every resource earlier.
Device Ids as part of every resource rep is also accepted and will be
used in resource construction if present.
Refactored filtering and encoding for resource into separate functions.
Removed unnecessary repeated strcmp() to figure out type of virtual
uri.
Change-Id: Ib995e819c8ab63aae6abff956941698d6919f9c4
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/934
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ankur Bansal [Tue, 7 Jul 2015 07:26:56 +0000 (12:56 +0530)]
Fix string copy issue in Credential resource unit test.
Update getCredList to correctly pass length of destination buffer while
using OICStrcpy.
Change-Id: I4763d295fc1da92831956bf9ed4a34e90718c7f3
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1553
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
jw1103.kim [Mon, 20 Apr 2015 12:17:44 +0000 (21:17 +0900)]
Integrated single/multi thread for interface controller and connectivity manager.
Merged serperated files by using #SINGLE_THREAD and #MULTI_THREAD flags.
Signed-off-by: jw1103.kim <jw1103.kim@samsung.com>
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Change-Id: I2d7b38d86226bdfc03c7a7b12626c2c4459ad305
Signed-off-by: jw1103.kim <jw1103.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/783
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Fri, 3 Jul 2015 11:11:27 +0000 (16:41 +0530)]
things-manager: Fix cppcheck issues in TMSampleApp for tizen
This patch fixes the below issues
reported by cppcheck tool in TMSampleApp dir for tizen.
"(error) Possible null pointer dereference: popup_fields ...."
It is invliad to set the member of popup_field to NULL if
popup_field itself is NULL.
Removed such statements from the code.
Change-Id: Ie1457662cb2727e5bab5e21886db6bece2f356a7
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1511
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ravi Nanjundappa [Fri, 3 Jul 2015 11:06:22 +0000 (16:36 +0530)]
soft-sensor-manager: Fixes cppcheck issue for arduino SampleApp
This patch fixes the the below issue reported by cppcheck tool
in stack dir: "(error) Possible null pointer dereference:
entityHandlerRequest - otherwise it is redundant to check if
entityHandlerRequest is null at line 114"
Dereferencing of entityHandlerRequest->resJSONPayload is done if
flag includes OC_REQUEST_FLAG.
The patch also includes removal of some unnecessary blank lines
Change-Id: I8d9d7c40df5602b9d55de8d948871a2c485798a2
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1510
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
hyuna0213.jo [Mon, 11 May 2015 04:50:55 +0000 (13:50 +0900)]
integrated caretransmission single/multi thread
Merged serperated files by using #SINGLE_THREAD flags
Change-Id: I8c0162b6220a221146ffa1428f25612aa0cfc0c4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/950
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Tue, 7 Jul 2015 12:16:05 +0000 (21:16 +0900)]
fixed Android Sample App build issue
to import Log was missed
so it was not built
Change-Id: I702b220bddd9ba0243a47eeca718326eb17fa9f6
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1561
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jihun Ha [Tue, 7 Jul 2015 00:40:56 +0000 (09:40 +0900)]
Fix defects of IOT-534 in Things Manager
Exception handling logic is added in group application.
startPresence for enabling presence check is added in speaker and musicplayer apps.
Change-Id: I12f6589154e27d288417d3fdd6413b867499a2bf
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ankur Bansal [Sat, 4 Jul 2015 13:08:08 +0000 (18:38 +0530)]
Add handling for error case in GroupManager::getActionSetfromString.
Delete action in case something went wrong during parsing.
Change-Id: I0e72db223ef21d0e89351d238532e168b2ca1177
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1523
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ankur Bansal [Mon, 6 Jul 2015 12:07:32 +0000 (17:37 +0530)]
Fix a potential crash in PPM, in case of incomlete xml.
Handle the case when pluginInfo tag is missing in the Configuration
file.
Change-Id: I0bc8e14a875a71bd2254d5ef917b3dc7652339f8
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1538
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jamal Haidar [Fri, 26 Jun 2015 13:14:23 +0000 (18:44 +0530)]
Fix delete array memory issue
Memory assigned with new array is deleted with non-array delete
Change-Id: I7e3411104d805bab66a863fb2814e93def897def
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1429
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jihun Ha [Mon, 6 Jul 2015 05:10:38 +0000 (14:10 +0900)]
Fix some string used for group management feature
1. Instead of "oc", "oic" is used for decoding a JSON request in group management.
2. There are a difference of group interface string in octypes.h and ocapi.h.
"oic.mi.def" will be used in the both.
Change-Id: I79763315926dc6e6bba3444db5ed94a68db65eb2
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Junghyun Oh <junghyun.oh@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
vimala.v [Mon, 6 Jul 2015 11:21:16 +0000 (16:51 +0530)]
Resolved Tizen build issue
Change-Id: I8271eaf5f6a80b9efff5a1030ee94d91ab4569b4
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1533
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jamal Haidar [Sat, 4 Jul 2015 08:35:08 +0000 (14:05 +0530)]
Fix memory leak in IP Monitor for tizen.
In CAWIFIConnectionStateChangedCb, netInfo pointer not freed.
Change-Id: I186ffd6ddc43a1fff717a06a6d8f445ba8165691
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1518
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Wed, 1 Jul 2015 09:02:58 +0000 (14:32 +0530)]
things-manager: Fix cppcheck errors
This patch fixes the errors reported by cppcheck tool for '(error) Mismatching
allocation and deallocation: newActionSet'.
Replaced free() calls with delete wherever the memory is allocated using new().
Change-Id: Icc22a8c7658c29afb8ed60b5cd9926e69ce3e6fb
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1506
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jamal Haidar [Sat, 4 Jul 2015 09:47:12 +0000 (15:17 +0530)]
Fix memory leak in oicgroup file of cstack.
ClientRequestInfo *info memory leaked in case of SendAction() method
failure called in DoAction().
Change-Id: I81de9f0765cd9fdd3387ff98f6975df146dbbc2a
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1521
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ankur Bansal [Sat, 4 Jul 2015 09:16:35 +0000 (14:46 +0530)]
Fix memory leak in SSM processQueryResult.
Update logic in CQueryEngine::processQueryResult to free
pDataReader in case of error.
Change-Id: I14cb27cd5c56731632fc6288cec555807f96ba97
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1520
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ankur Bansal [Sat, 4 Jul 2015 07:48:46 +0000 (13:18 +0530)]
Fix memory leak in SSM executeContextQuery.
Update logic in CQueryEngine::executeContextQuery to free
clsContextQuery in case of error.
Change-Id: Ife66485b61a5f64ff5f190787482cdf6737850dd
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ankur Bansal [Thu, 2 Jul 2015 13:09:17 +0000 (18:39 +0530)]
Fix memory leak in SSM Sensor Processor
Fix memory leak in CResourceFinder::onExecute. Delete resource handler
in case of Error.
Change-Id: I3d2363ed0b2585ffcbc403417fd73f60e89f1a88
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1490
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Mon, 29 Jun 2015 21:29:47 +0000 (23:29 +0200)]
protocol-plugin: sample-app: add missing lib to mqttclient
The mqttclient file does not link successfully on OpenWrt with boost
1.58.0. Without this patch I am getting this error message:
out/linux/arm/release/service/protocol-plugin/sample-app/linux/mqtt/mqttclient.o: In function `_GLOBAL__sub_I_mqttclient.cpp':
mqttclient.cpp:(.text.startup+0x7a0): undefined reference to `boost::system::generic_category()'
mqttclient.cpp:(.text.startup+0x7a8): undefined reference to `boost::system::generic_category()'
mqttclient.cpp:(.text.startup+0x7b0): undefined reference to `boost::system::system_category()'
out/linux/arm/release/libppm.a(PluginManager.o): In function `_GLOBAL__sub_I_PluginManager.cpp':
PluginManager.cpp:(.text.startup+0x8): undefined reference to `boost::system::generic_category()'
PluginManager.cpp:(.text.startup+0x1c): undefined reference to `boost::system::generic_category()'
PluginManager.cpp:(.text.startup+0x28): undefined reference to `boost::system::system_category()'
Change-Id: Ib5728b37609de6b9b426888c77eb3522eb5e0b7d
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1446
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ravi Nanjundappa [Wed, 1 Jul 2015 13:44:42 +0000 (19:14 +0530)]
stack: Fixes cppcheck issue in ocserverrequest
This patch fixes the the below issue reported by
cppcheck tool in stack dir:
"(error) Possible null pointer dereference:
ehResponse - otherwise it is redundant to check if
ehResponse is null at line 445
"
Dereferencing of ehResponse is done after NULL check.
Change-Id: I9cc20ce2386b5bdb08c4d9f9dbd2d143040f9a0f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1509
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Wed, 1 Jul 2015 13:36:20 +0000 (19:06 +0530)]
csdk: Fixes issue reported by cppcheck tool
This patch fixes the the below issue reported by cppcheck tool:
"(error) Possible null pointer dereference: ReqInfo - otherwise it is
redundant to check if ReqInfo is null at line 234".
Null value check of ReqInfo is removed as it in unnecessary here, as this check is
already done and OIC_LOG_BUFFER is just printing the content of ReqInfo->info.token.
Change-Id: I8c15d8b582135c445fe89350dc67812e531c52d3
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Fri, 3 Jul 2015 05:22:36 +0000 (10:52 +0530)]
Integrated singlethread and multithread files of BLE adapter.
Removed all "_singlethread" files related to BLE adapter.
Change-Id: Idad8e8a488d7b2d742f7082116f9bd4895175d8f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1035
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
doil.kwon [Thu, 2 Jul 2015 09:05:26 +0000 (18:05 +0900)]
Distributed Resource Hosting Sample App and ResourceHosting for JAVA API folder.
- Added new folder in NotificationManager folder
- "/NotificationManger/android/resource_hosting"
Modified notification-manager's Sconscript
- ~_JNI.cpp file is not included in Sconscript.
Changed folder name : ResourceHostingSampleApp->SampleResourceHosting
Deleted files : resourceCoordinator_JNI.cpp and resourceCoordinator_JNI.h in Notification/src folder.
Modified about ResourceHosing_JNI.h path is relative path to absolute path in ResourceHosing_JNI.cpp
Added "OCProcessFunc"'s return value : none -> return;
Change-Id: I2c44c31f1399ca9722c4f2281ec2b8af1646ed21
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
vimala.v [Wed, 1 Jul 2015 05:28:31 +0000 (10:58 +0530)]
Integrated IP adapter Singlethread and Multithread files
Removed all "_singlethread" files related to IP adapter.
Change-Id: I8a096ca6b28f74afaa8d122bf416cb4b0733f185
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1010
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Juliet Cai [Thu, 2 Jul 2015 17:31:35 +0000 (10:31 -0700)]
Update to OICSensorboard example
Change OC_ALL to CT_DEFAULT in client.cpp to compile with the latest API
Change-Id: I4654afefc72f9a95a41a23e36ed4f3172afe414d
Signed-off-by: Juliet Cai <juliet.z.cai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1493
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Thu, 2 Jul 2015 09:56:36 +0000 (18:56 +0900)]
fixed memory leak in CA
As the uri is moved from Endpoint to CAInfo structure currently.
but 'free()' was not updated at that time.
so 'free()' is also need in here and there.
Change-Id: I1b3429c29c769c5920dd427688e97b517dd94f66
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1488
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Tue, 30 Jun 2015 13:42:43 +0000 (22:42 +0900)]
Fix send LE adapter sendRequestToAll
Change-Id: I5892851829b56e4a52d5b66d1711554b4b7c4530
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1458
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Tue, 30 Jun 2015 04:52:23 +0000 (10:22 +0530)]
Added camutex no operation file.
This change will be used for singlethread and multithread integration
to avoid the usage of #ifdef around camutex api's.
Change-Id: Ie483c16cd0ac1d194a77fd94a8b9dd459e75509a
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1455
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Wed, 1 Jul 2015 12:19:20 +0000 (17:49 +0530)]
Changed BLE UUID defined in Tizen according to OIC Spec
Change-Id: I92dd97c6176484c621f37d6d946aee683c3da35d
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Rahul Rahul [Mon, 29 Jun 2015 20:27:18 +0000 (13:27 -0700)]
Added platform information to the android code, as per the spec compliance changes
Change-Id: I78fba71991d8e9da92f706f26166be86a6704c7c
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Wed, 1 Jul 2015 20:44:41 +0000 (13:44 -0700)]
[CA] Fix for DTLS secure unicast port.
Not to set "reuse_address" option when secure unicast port is requested.
Change-Id: Ieffa4fda038946a02c500aa43a85041a2a3b77b3
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1440
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Moumita Ray [Tue, 23 Jun 2015 16:57:29 +0000 (09:57 -0700)]
Adding IPv6 changes in Sample Apps.
This change is part of Multiadaptor/IPv6. Sample Apps needs to be updated to allow available
and currently suppoted connectivity types.
Change-Id: I701027d599e53183673abe2afd7b0f1a5fade885
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1406
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
John Light [Sat, 20 Jun 2015 22:28:04 +0000 (15:28 -0700)]
Restore host string behavior lost in IPv6 plumbing patch
Change-Id: Ia7120dd3d361e717f2a04782c3b59bdb841bc8bc
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1430
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 1 Jul 2015 07:42:54 +0000 (16:42 +0900)]
replaced uuids in Android BLE
I have replaced current uuids in android BLE
with new uuids which mentioned in OIC spec.
(https://workspace.openinterconnect.org/
apps/org/workgroup/oswg/download.php/1568/
OIC_BLE_Transport_Profile.pdf)
Change-Id: I409174458c0abc2c669f252e4e3ac44e9a040743
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ankur Bansal [Thu, 25 Jun 2015 05:18:36 +0000 (10:48 +0530)]
Fix memory leak in SSM QueryEngine
Fix memory leak in processQueryResult. Allocate pModelData only when
previous operations were successful.
Change-Id: I4829c729d10233ee263c75af533c22782a4659ee
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1428
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Tue, 30 Jun 2015 17:37:31 +0000 (10:37 -0700)]
Changed OCRandom.h's define name to remove lead underscore
The lead underscore is reserved for standard library authors. In
this case, including OCRandom.h from C++ conflicted with the C++
random.h file!
Change-Id: Iff8d06ab7e0838fe8cf9d8af7e67a1fae00c2e4b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1459
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Tue, 23 Jun 2015 13:14:45 +0000 (22:14 +0900)]
clean up endpoint methods.
- There are not flexible things in CA codes which
related to handling Endpoint.
: all endpoint objects will be managed by remotehandler.c
: all clone methods related to Endpoint will be managed
by remotehandler.c (not AdapterUtil)
- fixed previous Transport type in some endpoint method
since previous Type was still used in there (CA_LE / CA_EDR)
so i replaced it with
CA_ADAPTER_GATT_BTLE / CA_ADAPTER_RFCOMM_BTEDR
(already done by https://gerrit.iotivity.org/gerrit/#/c/1401/)
Change-Id: Ib8400bbea0c3b4c005b8bec68ded2ed66c337c7b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1404
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Wed, 3 Jun 2015 09:30:40 +0000 (18:30 +0900)]
IP adapter error handling
Ad dependencies got messed up, earlier patch set failed
Adding a fresh patch with right dependencies
Change-Id: Id55430b0d8ce502978e11e5102972fcb901e4472
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1181
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Tue, 30 Jun 2015 04:13:32 +0000 (09:43 +0530)]
Fix compile warnings in SimpleClientServer for Linux
SimpleClientServer application for Linux was trying to check the address of array
'clientResponse->rcvdVendorSpecificHeaderOptions' which will always evaluate to 'true'.
Corrected by removing such checks in the code.
Change-Id: Id7306af0792646887740ab3c7952d5fffe8c760b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1454
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Juliet Cai [Mon, 8 Jun 2015 20:50:47 +0000 (13:50 -0700)]
Updates to OICSensorboard example
* Updated OICSensorBoard client to work with the latest API
* Modified the server code for temperature conversion to reflect a minor circuit change
* Deleted OICSensorBoardREADME.pdf
* Added README and point to wiki page
Change-Id: Iab74e08f934e2a2c7c50c015b43e8fde8651bc85
Signed-off-by: Juliet Cai <juliet.z.cai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1221
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Charlie Lenahan [Fri, 12 Jun 2015 00:13:36 +0000 (20:13 -0400)]
Fix issue the previous CreateResourceWithHost change
resolve issue registerResource mangles the name properly
Change-Id: I1926a03aef98c79ca00e2605730e856ab1a07915
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Hauke Mehrtens [Mon, 29 Jun 2015 21:06:44 +0000 (23:06 +0200)]
things-manager: sampleapp: fix typo in ConClientApp
This should be ConClientApp and not ConClientApp
Change-Id: Ib39ad167674e31e8a1088f4f23e62d213fa4948b
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1444
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Satya Prakash Gupta [Thu, 18 Jun 2015 12:22:24 +0000 (17:52 +0530)]
Fix NULL pointer deferencing in SimpleClientServer
Update PrintReceivedMsgInfo to print UNKNOWN when ehRequest is NULL.
Change-Id: Iaed6e2287efbcca2e41cc497545f21dcc6dc618a
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1356
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 26 Jun 2015 04:35:43 +0000 (13:35 +0900)]
CA linux/android sample modification for the secure message
In spite of selecting a secure, CA sample send the normal message.
I modified the CA sample to send secure message
Change-Id: I7725a0033b91dbc5159f9f27ee8147f4a3bfb174
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1425
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Mon, 29 Jun 2015 05:38:27 +0000 (11:08 +0530)]
Added one more unit test for OCCreateResource
* Unit test to exercise code path to check OCCreateResource() when the
resource policy is non-discoverable & non-observable.
Change-Id: Ifd95cd6f48a498fbc81c5c62fd7c8df91855f40b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1438
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Thu, 21 May 2015 12:22:54 +0000 (21:22 +0900)]
CA Error handling for LE adapter
This adds error handling from LE adapter to the interface controller
Interface controller to RI Error Handling was submitted in
https://gerrit.iotivity.org/gerrit/#/c/1046/
Change-Id: If7cceb4db3a0c47c1fee6cd6814fd1257fc856e8
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1069
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Wed, 1 Apr 2015 20:20:35 +0000 (13:20 -0700)]
Minimized hardcoding of CA transport adapter source file lists.
For each of the CA transport adapters, the single SConscript file that
handled construction of the source file list relied heavily and
needlessly on explicit target OS checks. Minimize such logic by
delegating construction of such lists to newly created target
OS-specific SConscript files. Each of those SConscript files will also
handle OS-specific CA transport adapter build configuration.
Change-Id: Iae493631491f6ce98521e36f1e4e790cee4d8186
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/820
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
koushik.girijala [Tue, 23 Jun 2015 10:35:49 +0000 (16:05 +0530)]
[CA] Fixed sample app code for Tizen and Arduino
Fixed build errors and run time errors w.r.to IPv6 and endpoint api changes
Change-Id: Ia2fc13cf2b0e60ee06e451725b1b283db99daa14
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 26 Jun 2015 06:14:46 +0000 (15:14 +0900)]
remove unnecessary code in caipserver
- remove unnecessary error check logic
- add the global variable initialization to fix the build warning
Change-Id: I1e02103b024a4b2a61d71f6e8403117069fe4b32
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1426
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
arafat.hsn [Wed, 24 Jun 2015 10:07:12 +0000 (16:07 +0600)]
[IOT-555]Add event logs to CA sample app
Fix spacing related issue and other missing Log added.
Change-Id: I07ccb79c38073c04bda5055fc07440445b8c124a
Signed-off-by: arafat.hsn <arafat.hsn@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1277
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Fri, 22 May 2015 07:22:14 +0000 (16:22 +0900)]
CA Error handling for BT(EDR) Adapter
This adds error handling from BT adapter to the interface controller
Interface controller to RI Error Handling was submitted in
https://gerrit.iotivity.org/gerrit/#/c/1046/
Change-Id: I6ad67d5a4da4b65bba82c45bddbee3178fb06ef3
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1087
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Thu, 25 Jun 2015 05:13:26 +0000 (14:13 +0900)]
[IOT-583] fixed Option Parameter is not support
HeaderOption in RequestInfo and responseInfo parameter
was not supporting since there are no logic related to it
after IPv6 merged.
trus. i'll be support through SendRequest and SendResponse
Change-Id: Ic200ebe29e130baac95991570183beb8f9fb7148
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1422
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 24 Jun 2015 11:51:29 +0000 (20:51 +0900)]
[IOT-580] fixed RESET is not working
RESET on CoAP spec is not working in EDR
because OICStrcpyPartial(..) is supported only string format.
it have to be copied bytes to buffer
(https://gerrit.iotivity.org/gerrit/#/c/1208/8/
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrserver.c)
Change-Id: I01f4cabccdada80cccdc7efe6fb55fe203a09c99
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1416
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Wed, 24 Jun 2015 18:12:03 +0000 (11:12 -0700)]
Corrected error return value when parsing fragmentation header.
CAParseHeader() on error returned CA_STATUS_INVALID_PARAM, a
CAResult_t value, instead of a value that matches uint32_t return
type. Return zero on error instead.
Updated documentation accordingly.
Change-Id: I3dee0e2b562a272c5d41963e0049618d7bacd69e
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1419
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 23 Jun 2015 17:02:27 +0000 (13:02 -0400)]
Removed memory leaks in CA Unit Tests.
These memory leaks are reported by Valgrind on the build server. With
these removed, the threshold value for memory leaks can be lowered and
further commits will be more resilient.
Change-Id: I606ec487c0a4f0207b85556ed0c48b4f34873907
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1407
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Patrick C Lankswert [Wed, 24 Jun 2015 17:37:19 +0000 (13:37 -0400)]
Added documentation build script for Doxygen and JavaDoc
This change set adds a script (./build_docs.sh) to generate
the documenation for iotivity which is placed into the ./docs
directory. Currently, the script builds java and C/C++ API
documentation and includes checks for warnings and errors.
When all of the existing warnings and errors are addressed,
this should be added to the build script to fail validation
if/when a contributor breaks the API documentation.
Please consider cherry-picking to the 0.9.1 release branch.
Change-Id: I490fbfc83cf61c76c7f59ba2c00404a073b039e7
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1418
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Rahul Rahul [Wed, 24 Jun 2015 20:47:21 +0000 (13:47 -0700)]
Updated android ResourceProperty to follow the same order as specified in octypes.h.
This fixes IOT-579.
Made a small correction in android build instructions
Change-Id: I5b2df5986ac8d0a75d9a987d8667f942a24ec2cf
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1420
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Sachin Agrawal [Wed, 24 Jun 2015 15:49:33 +0000 (08:49 -0700)]
Fixed unicast failure bug due to faulty strcpy
Recent modifications in ParseRequestUri introduced a bug where
IP address was not copied properly in OCDevAddr data structure.
Change-Id: I40a322530a11ab3cdae89d015cd774f507ccfdab
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1408
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Ravi Nanjundappa [Wed, 24 Jun 2015 11:07:34 +0000 (16:37 +0530)]
Fix compile warnings in connectivity unittests
Unit test was emitting a warning due to unused variables in x86 Linux.
Corrected it by removing all unused varaibles.
Change-Id: I7f29487414e894149a8acc0620be4b7643f0f531
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1415
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Wed, 24 Jun 2015 08:35:51 +0000 (17:35 +0900)]
Remove unnecessary code in Android CA Sample
As some CA API(FindResource/AdvertiseResource) had removed
by IPv6 change.
the code in Android Sample related to the API is removed
in this patch
Change-Id: I9a69620656c62aef5a89117cb562a441d08a349a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1413
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Ravi Nanjundappa [Tue, 23 Jun 2015 04:52:05 +0000 (10:22 +0530)]
Added unit tests for StackResource
Unit test exercise code paths to check OCCreateResource() for
OC_LIENT mode and also to check if resource type name is invalid
i.e., null terminated or not.
This also includes the bug fix related to checking if resource type
name is invalid i.e., null terminated or not.
Change-Id: I7f8767a4e8b9586de9cb0926dd8a4afcd03b792c
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1391
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Mon, 22 Jun 2015 23:38:58 +0000 (16:38 -0700)]
Added missing DTLS #ifdef guard.
One of the functions only used for DTLS was missing #ifdef guards
resulting in compile warnings.
Change-Id: Ieb0082e1dba2547e8d73d0526cf0aab3bf3af589
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1333
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jihwan.seo [Tue, 23 Jun 2015 08:06:24 +0000 (17:06 +0900)]
removed duplicated code in Sample app
- Target Platform : Android, Linux
Change-Id: I7035a138cb9b83a6e653c213aaa4fc349b57545d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1395
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Tue, 23 Jun 2015 09:02:49 +0000 (14:32 +0530)]
Remove unused scons file in examples/OICMiddle/ for x86 linux build
Actual file used is examples/OICMiddle/SConscript, So removed the unused
scons file examples/OICMiddle/SConstruct from git.
Change-Id: I9c0d3c37d0f228ed3125763f05efa7b447e4e41b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1399
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Tue, 23 Jun 2015 10:55:55 +0000 (19:55 +0900)]
remove unnecessary code in messagehandler
- remove the duplicated log message for the debugging
- add the null check logic for token
Change-Id: Icfd74fcc350b6e1c9038acdac290cfcaf9d344e7
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1402
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Tue, 23 Jun 2015 11:15:03 +0000 (16:45 +0530)]
Remove unused make file in resource/csdk/connectivity/ for x86 linux build
Now scons are used in place of makefiles. So need to remove this left out
common.mk file from git.
Change-Id: Ice0abdc0a02ff78a9fddb0e407613d242acdffbe
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1403
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 23 Jun 2015 00:05:12 +0000 (20:05 -0400)]
Realigned usage of IP Adapter modules' APIs on Arduino.
This fixes an issue where an Arduino using an Ethernet shield did not
respond to incoming requests nor notified the application of incoming
requests.
Change-Id: I035120e7bbe4a5950d2ed36a357f06c85c1ef8db
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1388
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
koushik.girijala [Thu, 18 Jun 2015 08:22:37 +0000 (13:52 +0530)]
[CA] Assigned unicast port number 0 instead of fixed number
Fix for jira issue IOT 379
Change-Id: Iaefe63189473fb106c5a43eb8648fc903ed3954e
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1338
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Satya Prakash Gupta [Thu, 18 Jun 2015 06:15:07 +0000 (11:45 +0530)]
Fix memory leak in Notification Manager
Fix memory leak in requestIsAlive when resource is not found.
Change-Id: Ia54883ac2d4f207402c4ac99a0e5304e96a39257
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1354
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ravi Nanjundappa [Wed, 17 Jun 2015 05:38:26 +0000 (11:08 +0530)]
Fix compile warnings in resource src
This patch fixes compiler warnings related to implicit declaration
of function 'strncasecmp' in resource security module
Change-Id: I4a785dde406fcaffe1acbb2b4f2c76524143c2d0
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1291
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Jiwon Kim [Fri, 22 May 2015 11:16:48 +0000 (20:16 +0900)]
Fix install external libraries comment on openssl in 'Readme.scons.txt'
file
Add comment libssl-dev
Change-Id: I160837cf3316eaecf6e872337ec4bc79a82ac9b8
Signed-off-by: Jiwon Kim <kjo6152@naver.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1095
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sanjeev BA [Thu, 11 Jun 2015 06:16:48 +0000 (15:16 +0900)]
Remove unused includes.
Change-Id: Ifb5ec2dbe549d03add076d8a10844b3409484534
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1238
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Satya Prakash Gupta [Thu, 18 Jun 2015 08:48:40 +0000 (14:18 +0530)]
Close fd after use in RestInput
A socket descriptor being created in loop and not closed after use.
Change-Id: Iadf195c4bb4591bcfd124e89a08964660bc64103
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1339
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
projects / contrib / iotivity.git / log